{"$schema":"https://json.schemastore.org/sarif-2.1.0.json","version":"2.1.0","runs":[{"tool":{"driver":{"name":"codehealth","informationUri":"https://codehealth.canine.dev","rules":[{"id":"D1","name":"Cyclomatic Complexity","shortDescription":{"text":"Cyclomatic Complexity"},"helpUri":"https://codehealth.canine.dev/dimensions/D1"},{"id":"D2","name":"Cognitive Complexity","shortDescription":{"text":"Cognitive Complexity"},"helpUri":"https://codehealth.canine.dev/dimensions/D2"},{"id":"D3","name":"God Classes","shortDescription":{"text":"God Classes"},"helpUri":"https://codehealth.canine.dev/dimensions/D3"},{"id":"D4","name":"Code Duplication","shortDescription":{"text":"Code Duplication"},"helpUri":"https://codehealth.canine.dev/dimensions/D4"},{"id":"D6","name":"Cohesion (LCOM4)","shortDescription":{"text":"Cohesion (LCOM4)"},"helpUri":"https://codehealth.canine.dev/dimensions/D6"},{"id":"D8","name":"Code Coverage","shortDescription":{"text":"Code Coverage"},"helpUri":"https://codehealth.canine.dev/dimensions/D8"},{"id":"D12","name":"Dependency Hygiene","shortDescription":{"text":"Dependency Hygiene"},"helpUri":"https://codehealth.canine.dev/dimensions/D12"},{"id":"D13","name":"Secret Scanning","shortDescription":{"text":"Secret Scanning"},"helpUri":"https://codehealth.canine.dev/dimensions/D13","relationships":[{"target":{"id":"CWE-798","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-798","CWE-259"],"owasp":"A07:2025"}},{"id":"D15","name":"Churn \u00D7 Complexity Hotspots","shortDescription":{"text":"Churn \u00D7 Complexity Hotspots"},"helpUri":"https://codehealth.canine.dev/dimensions/D15"},{"id":"D17","name":"Explicit Debt","shortDescription":{"text":"Explicit Debt"},"helpUri":"https://codehealth.canine.dev/dimensions/D17"},{"id":"D20","name":"ADR Quality","shortDescription":{"text":"ADR Quality"},"helpUri":"https://codehealth.canine.dev/dimensions/D20"},{"id":"D27","name":"Navigability","shortDescription":{"text":"Navigability"},"helpUri":"https://codehealth.canine.dev/dimensions/D27"},{"id":"D28","name":"Secrets (history)","shortDescription":{"text":"Secrets (history)"},"helpUri":"https://codehealth.canine.dev/dimensions/D28","relationships":[{"target":{"id":"CWE-798","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-798","CWE-259"],"owasp":"A07:2025"}},{"id":"D29","name":"Static Analysis (SAST)","shortDescription":{"text":"Static Analysis (SAST)"},"helpUri":"https://codehealth.canine.dev/dimensions/D29","relationships":[{"target":{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-89","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-78","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-94","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-77","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-79","CWE-89","CWE-78","CWE-94","CWE-77"],"owasp":"A05:2025"}},{"id":"D34","name":"Knowledge Freshness","shortDescription":{"text":"Knowledge Freshness"},"helpUri":"https://codehealth.canine.dev/dimensions/D34"},{"id":"D35","name":"Change Coupling","shortDescription":{"text":"Change Coupling"},"helpUri":"https://codehealth.canine.dev/dimensions/D35"},{"id":"AX10","name":"Code composition","shortDescription":{"text":"Code composition"},"helpUri":"https://codehealth.canine.dev/dimensions/AX10"},{"id":"AX3","name":"Project dependency cycles","shortDescription":{"text":"Project dependency cycles"},"helpUri":"https://codehealth.canine.dev/dimensions/AX3"},{"id":"AX4","name":"Dependency direction","shortDescription":{"text":"Dependency direction"},"helpUri":"https://codehealth.canine.dev/dimensions/AX4"},{"id":"AXB1","name":"Runtime evidence locked \u2014 no reproducible boot","shortDescription":{"text":"Runtime evidence locked \u2014 no reproducible boot"},"helpUri":"https://codehealth.canine.dev/dimensions/AXB1"},{"id":"ED4","name":"Outbox / dual-write","shortDescription":{"text":"Outbox / dual-write"},"helpUri":"https://codehealth.canine.dev/dimensions/ED4"},{"id":"ED5","name":"Idempotency","shortDescription":{"text":"Idempotency"},"helpUri":"https://codehealth.canine.dev/dimensions/ED5"},{"id":"M1","name":"Documentation (README)","shortDescription":{"text":"Documentation (README)"},"helpUri":"https://codehealth.canine.dev/dimensions/M1"},{"id":"M2","name":"Architecture documentation","shortDescription":{"text":"Architecture documentation"},"helpUri":"https://codehealth.canine.dev/dimensions/M2"},{"id":"M3","name":"Folder \u0026 project structure","shortDescription":{"text":"Folder \u0026 project structure"},"helpUri":"https://codehealth.canine.dev/dimensions/M3"},{"id":"P1","name":"CI/CD gates","shortDescription":{"text":"CI/CD gates"},"helpUri":"https://codehealth.canine.dev/dimensions/P1"},{"id":"P3","name":"Security \u0026 performance tooling","shortDescription":{"text":"Security \u0026 performance tooling"},"helpUri":"https://codehealth.canine.dev/dimensions/P3"},{"id":"X10","name":"Duplicated predicate","shortDescription":{"text":"Duplicated predicate"},"helpUri":"https://codehealth.canine.dev/dimensions/X10"},{"id":"X20","name":"Mistyped argument guard","shortDescription":{"text":"Mistyped argument guard"},"helpUri":"https://codehealth.canine.dev/dimensions/X20"},{"id":"X21","name":"Side-effecting pattern guard","shortDescription":{"text":"Side-effecting pattern guard"},"helpUri":"https://codehealth.canine.dev/dimensions/X21"},{"id":"X22","name":"Contradicted release guard","shortDescription":{"text":"Contradicted release guard"},"helpUri":"https://codehealth.canine.dev/dimensions/X22"},{"id":"X25","name":"Inert configuration knob","shortDescription":{"text":"Inert configuration knob"},"helpUri":"https://codehealth.canine.dev/dimensions/X25"},{"id":"X26","name":"Unsynchronised callback handoff","shortDescription":{"text":"Unsynchronised callback handoff"},"helpUri":"https://codehealth.canine.dev/dimensions/X26"},{"id":"X27","name":"Collection changed while being enumerated","shortDescription":{"text":"Collection changed while being enumerated"},"helpUri":"https://codehealth.canine.dev/dimensions/X27"},{"id":"X28","name":"Index access outside its own emptiness guard","shortDescription":{"text":"Index access outside its own emptiness guard"},"helpUri":"https://codehealth.canine.dev/dimensions/X28"},{"id":"X3","name":"Exception handling","shortDescription":{"text":"Exception handling"},"helpUri":"https://codehealth.canine.dev/dimensions/X3"},{"id":"X31","name":"Test-only surface in a production module","shortDescription":{"text":"Test-only surface in a production module"},"helpUri":"https://codehealth.canine.dev/dimensions/X31"},{"id":"X32","name":"Type resolved by simple name across every loaded assembly","shortDescription":{"text":"Type resolved by simple name across every loaded assembly"},"helpUri":"https://codehealth.canine.dev/dimensions/X32"},{"id":"X5","name":"Nullable reference types","shortDescription":{"text":"Nullable reference types"},"helpUri":"https://codehealth.canine.dev/dimensions/X5"},{"id":"X6","name":"Hand-rolled structured-format parsing","shortDescription":{"text":"Hand-rolled structured-format parsing"},"helpUri":"https://codehealth.canine.dev/dimensions/X6"},{"id":"X9","name":"Subsumed condition operand","shortDescription":{"text":"Subsumed condition operand"},"helpUri":"https://codehealth.canine.dev/dimensions/X9"}]}},"results":[{"ruleId":"D1","level":"warning","message":{"text":"path_find.compute_fun (cyclomatic 23): path_find.compute_fun has cyclomatic complexity 23 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform \u2014 the same kind of value, with no behaviour of its own \u2014 a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/path_find.erl"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"b8e95bb852396137b26f13caa9a7776d016718cd10f0d44a61fbd0455822c70e"}},{"ruleId":"D2","level":"warning","message":{"text":"path_find.compute_fun (cognitive 46): path_find.compute_fun has cognitive complexity 46 (threshold 15). Drivers by points: match/switch 23 (33 pts), loops 3 (7 pts), boolean chains 6 (nesting depth added 14). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/path_find.erl"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"64d2715fcc2b7595233d307bfc92f754afa5d796de4ed2bc37db3058af2df7a1"}},{"ruleId":"D2","level":"warning","message":{"text":"algos.shortest_path (cognitive 21): algos.shortest_path has cognitive complexity 21 (threshold 15). Drivers by points: match/switch 11 (16 pts), loops 2 (5 pts) (nesting depth added 8). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/algos.erl"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"1458551601c6d8379f8f7ad71ea63ca2629c447ef92d222e30b932649eca3e43"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: src/phoebus_worker.erl: FileTooLong \u2014 521 significant lines (blank, comment-only and punctuation-only lines excluded), declaring 33 functions. The bar is 500 significant lines; this is 21 over it, 1.04\u00D7 the bar. In this language a module is exactly one source file, so its length cannot be moved into sibling files of the same module. To reduce it, extract each cohesive family of functions into a new module of its own and have this one delegate to it, so no one module has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/phoebus_worker.erl"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"8825c91bfb2f76826cb23009f1115f52f2dda598a50f715a5a4b432e9fec7c19"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (25 corresponding lines): src/algos.erl:80-104 | src/path_find.erl:18-44 \u2014 These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/algos.erl"},"region":{"startLine":80}}}],"partialFingerprints":{"codehealthFindingId/v1":"1f2982f3167fac7a2cb098fb4978a70823f556cb79a0f1990810189a18824e9e"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (8 corresponding lines): src/phoebus_worker.erl:206-214 | src/phoebus_worker.erl:222-229 \u2014 These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/phoebus_worker.erl"},"region":{"startLine":206}}}],"partialFingerprints":{"codehealthFindingId/v1":"8a089da4575fbef55a054295f9f81c62fd8f2596c851f523fde84c2354b568d0"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (10 corresponding lines): src/phoebus_master.erl:212-221 | src/phoebus_master.erl:244-253 \u2014 These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/phoebus_master.erl"},"region":{"startLine":212}}}],"partialFingerprints":{"codehealthFindingId/v1":"935bb348136cf5bcfddcb5fe8bc468861d82e28cf25a64ce03214c50ff213775"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (5 corresponding lines): src/msg_buffer.erl:363-367 | src/phoebus_worker.erl:798-802 \u2014 These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/msg_buffer.erl"},"region":{"startLine":363}}}],"partialFingerprints":{"codehealthFindingId/v1":"f24b4c0d3f9c7f9d68cb230ad2fbc271566ac414e0a53ad83c2cf16ae51b7e62"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (4 corresponding lines): src/external_store_file.erl:111-114 | src/external_store_hdfs.erl:158-161 \u2014 These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/external_store_file.erl"},"region":{"startLine":111}}}],"partialFingerprints":{"codehealthFindingId/v1":"8bf888b8ec9b4d3b5a3443d6d5756f83a16008367fca5218504a86d7685d923a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16\u201317 lines \u00D7 2): src/algos.erl:81-97 | src/path_find.erl:19-34 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/algos.erl:81\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/path_find.erl:34\u0060 calls \u0060fun\u0060, \u0060integer_to_list\u0060, \u0060uniform\u0060 and \u0060src/algos.erl:97\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/algos.erl"},"region":{"startLine":81}}}],"partialFingerprints":{"codehealthFindingId/v1":"c0e01bfcf2296768db1cee6f9621b68554d850935387041a0bf1516fafe64255"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16\u201317 lines \u00D7 2): src/phoebus_worker.erl:632-648 | src/phoebus_worker.erl:651-666 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/phoebus_worker.erl:632\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/phoebus_worker.erl"},"region":{"startLine":632}}}],"partialFingerprints":{"codehealthFindingId/v1":"8ee9fe2700c392c97b0d716b0a4cb027dda9c95c74654d3f8ea4e6443ff11578"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): src/external_store_file.erl:56-65 | src/external_store_hdfs.erl:83-92 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/external_store_file.erl"},"region":{"startLine":56}}}],"partialFingerprints":{"codehealthFindingId/v1":"814a24d0974915442514b99b91949290b5c4c963377b0b1d720038bf33be30b4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8\u20139 lines \u00D7 2): src/phoebus_worker.erl:159-166 | src/phoebus_worker.erl:179-187 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/phoebus_worker.erl:159\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/phoebus_worker.erl"},"region":{"startLine":159}}}],"partialFingerprints":{"codehealthFindingId/v1":"21481d500b6ddbbb989b822bc452433469806326d65ff3a8d3ce7136759adf55"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/msg_buffer.erl:291-297 | src/msg_buffer.erl:299-305 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/msg_buffer.erl:291\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/msg_buffer.erl"},"region":{"startLine":291}}}],"partialFingerprints":{"codehealthFindingId/v1":"2733bc2fca0d8c8e833072229eae8ea829f3a397f3fd62c7c1514817381ff1fb"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6\u20137 lines \u00D7 2): src/table_manager.erl:123-129 | src/table_manager.erl:149-154 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/table_manager.erl"},"region":{"startLine":123}}}],"partialFingerprints":{"codehealthFindingId/v1":"385ba427a1a3b3515ebd93e93f8eb1a5f4ae8487cf02334f65c0a21c6571ee01"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5\u20136 lines \u00D7 2): src/phoebus_worker.erl:687-691 | src/phoebus_worker.erl:697-702 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/phoebus_worker.erl"},"region":{"startLine":687}}}],"partialFingerprints":{"codehealthFindingId/v1":"5e96cce12b58febd7cc41e52439a0f1331abbc6e698f1845b6554cc018a465fd"}},{"ruleId":"D8","level":"error","message":{"text":"No automated tests: No automated tests \u2014 no test code was found in this repository. Untested code is the largest single risk to changing it safely. Start with the code you change most often: add a suite in a framework a runner can collect (EUnit or Common Test), and run it in CI so the gap cannot reopen."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"3132564c6310e5d01a231f252a02d5d2f5a542c0a8fa29a14c89693f1e3df871"}},{"ruleId":"D12","level":"warning","message":{"text":"No dependency lockfile committed (rebar.config): rebar.config declares 2 dependencies but no lockfile (rebar.lock or mix.lock) is committed beside it, so \u0060rebar3 compile\u0060 resolves versions afresh on every machine and every CI run \u2014 two builds of this commit are not guaranteed to be the same build. Run \u0060rebar3 compile\u0060 and commit the resulting \u0060rebar.lock\u0060."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"8167d684e70969326978dc347dd61843dfe24c2c826307dbb1edecc8ff726c1c"}},{"ruleId":"D12","level":"warning","message":{"text":"Floating source dependency: thrift_erl: Runtime dependency \u0060thrift_erl\u0060 is fetched from source in rebar.config and names no revision at all, so it tracks the default branch \u2014 the declaration pins no immutable revision, so \u0060rebar3 upgrade\u0060 moves this dependency to code nobody reviewed. Pin it with \u0060{tag, \u0022v1.2.3\u0022}\u0060 or \u0060{ref, \u0022\u003Cfull commit SHA\u003E\u0022}\u0060."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"187b34609cb9cad653db5534b16d41f5d2acc12c758b46f70d20dbafa739540d"}},{"ruleId":"D12","level":"warning","message":{"text":"Floating source dependency: eleveldb: Runtime dependency \u0060eleveldb\u0060 is fetched from source in rebar.config and names no revision at all, so it tracks the default branch \u2014 the declaration pins no immutable revision, so \u0060rebar3 upgrade\u0060 moves this dependency to code nobody reviewed. Pin it with \u0060{tag, \u0022v1.2.3\u0022}\u0060 or \u0060{ref, \u0022\u003Cfull commit SHA\u003E\u0022}\u0060."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"bc24ed5ea94199f6000d3285b47de86500597bc96492a7853001fa6849de51d8"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: %% TODO : check if there is a registered thrift server for this NN \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060% REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/external_store_hdfs.erl"},"region":{"startLine":51}}}],"partialFingerprints":{"codehealthFindingId/v1":"9660c9eface14c373c40b45da707baba3dab13367b660726817a670e755ce955"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: %% TODO : Compute Incremental Aggregate.. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060% REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/phoebus_master.erl"},"region":{"startLine":199}}}],"partialFingerprints":{"codehealthFindingId/v1":"a063ac96f3c693a297d66b3eb3052da8b4aff35b1fd3b53d4f18b476fbb5162b"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: %% TODO : Make Async \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060% REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/phoebus_master.erl"},"region":{"startLine":435}}}],"partialFingerprints":{"codehealthFindingId/v1":"aad9c4305c65e645210d4f87e4547719204a4b4c7598fb260cc92e14e9f97780"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: %% TODO : This has to be configurable... \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060% REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/phoebus_utils.erl"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"2bf081c0a6e1ba264c62f9176be8fd933bea9162457a13cd0cfcbd2afeae0be3"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: %% TODO : implement \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060% REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/phoebus_utils.erl"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"79540f688152aeb076962cc37f2773603f7719b21d550e856825f7b44ceede1b"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: %% TODO : might be a better idea for the master to do this.. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060% REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/phoebus_worker.erl"},"region":{"startLine":512}}}],"partialFingerprints":{"codehealthFindingId/v1":"b10a0cce7dabedfa26a913f697be52c4f9fee16afc120dec71fcc04af530b8a2"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: %% TODO : have to implemnt.. using a table manager.. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060% REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/phoebus_worker.erl"},"region":{"startLine":584}}}],"partialFingerprints":{"codehealthFindingId/v1":"599be5d4772b77ba2bf6465bfbe7db061c633487b387d989cf39ed59e2120e8f"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: %% TODO : Handle this... \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060% REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/worker_store.erl"},"region":{"startLine":266}}}],"partialFingerprints":{"codehealthFindingId/v1":"475e4fea5cf71070736d19bba26dde5d2268b95dd6d5a7ed0b603cde40fb0b6c"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: %% TODO : have to think of something... \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060% REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/worker_store.erl"},"region":{"startLine":325}}}],"partialFingerprints":{"codehealthFindingId/v1":"31da59a6cdc163a058e828c153cc9b0248832cdfb840974a4a22c3bc768c4079"}},{"ruleId":"D20","level":"note","message":{"text":"No ADRs found: No ADRs found. No recognised ADR directory (\u0060docs/adr/\u0060, \u0060docs/decisions/\u0060, \u0060adr/\u0060, \u0060docs/rfcs/\u0060, an \u0060ADR0001/\u0060 folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (\u0060docs/adr/use-postgres.md\u0060, \u0060docs/adr/2024/0001-x.md\u0060); or a file anywhere whose name is ADR-shaped (\u00600001-use-postgres.md\u0060, \u0060adr-012-caching.md\u0060); or, when neither turned anything up, a document carrying the decision-record signature (an \u0022Architecture Decision Record\u0022 heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these \u2014 unnumbered files outside any recognised directory, without those headings \u2014 is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in \u0060docs/adr/\u0060. ADRs are expected here because \u0060rel/reltool.config\u0060 makes this repository a deployable product (line 1)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"rel/reltool.config"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"bebf51852dd5ae08e30f7d703f06b45f1f3967781afdbd710d3b5e03461342b9"}},{"ruleId":"D34","level":"error","message":{"text":"Orphaned knowledge: No living knowledge remains for this large file \u2014 its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/phoebus_worker.erl"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"dd8bacfa9d01df6df4ce2ad928462610080365f06f2bc5b702d17c7a2d04f761"}},{"ruleId":"D34","level":"note","message":{"text":"Further orphaned files (smaller): 14 smaller file(s) also have no living knowledge \u2014 folded into the freshness score and metrics rather than raised one row each \u2014 most significant first: src/phoebus_master.erl, src/worker_store.erl, src/msg_buffer.erl, src/external_store_hdfs.erl, src/table_manager.erl, src/path_find.erl, src/external_store_file.erl, src/serde.erl (and 6 more) (15 orphaned of 15 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated, example/demo and scaffolding-template trees and test files identified by path convention, largest first; 15 of the 17 production source files in this repository met that bar). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"ce861fd78f6935114d3a342cb90ad25870f984e1042954fcbbe27c0e23be3658"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/phoebus_master.erl"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"bfbd5ca2922ff847ee8312f399012a8eb8ca9243b4b686eac4ddbd8e55bdd4b6"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/worker_store.erl"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"29679fccb41472331b3e5ac8f6c5077f98593e5050066c78580dceb6dce78bb9"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/msg_buffer.erl"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"1e5727d5ca14d179e5e669df42532457a473fe738b90a77d98d50331431a0450"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/external_store_hdfs.erl"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"afa0998ae076f26ee0ee8ab9f592f60e8e08add6810a01a2c161b7ae61dc66c3"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/table_manager.erl"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"52998b3eefbec74d8bc4cb7113cdb46ea8040f62350e27e7c882134242094da2"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/path_find.erl"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"9e4546354fd4e92d91389456246c2f707092e5f13e04718ac4e493f4a2b0a33a"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/external_store_file.erl"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"bb10a5150d2b820a849efdf69d6203483bfa43e50eb02c51b16c6644375247db"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/serde.erl"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"0c7ee55149b75739809e192d3b1e009c1ae8dd3d4aecba1db03ff8057797bc1d"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/algos.erl"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"20b9cb850c104a6d5eae5cf9728a008ebc06ea65e4de52c1fe2b3feafc644f57"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"include/phoebus.hrl"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"c5276731c315113f43142202dc7a035cfee64589e7c9ac6ad5ccb1867ec13b1a"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/phoebus_app.erl"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"d69162b43851bcf0d5f3bf85e2cd243418de1f5ae5bb47a4ee1660f9f194bdb8"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/external_store.erl"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"dd199e64391b16e5e9b9b66be17c14867045917f137eef72da16c0754907464d"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/phoebus_sup.erl"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"85600c6467415d43da9b422ebf30f6c035c58ed5cc4f0efedf17a49c2fc93f9e"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/phoebus_utils.erl"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"f8cda48b281a5e23459ea053db9b8af732d524fbddf0f419b4b14c0d8f22b6a1"}},{"ruleId":"D35","level":"warning","message":{"text":"Change coupling: phoebus_master.erl \u2194 worker_store.erl: \u0060src/phoebus_master.erl\u0060 and \u0060src/worker_store.erl\u0060 change together 58% of the time (7 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well \u2014 a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency between them. They sit in the same directory, but in this ecosystem each file is its own module \u2014 a sibling reference still needs an import \u2014 so the missing import edge is real: the coupling runs through shared behaviour, not a declared dependency. If they duplicate structure, extract the common part into one unit; otherwise the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are \u0060d866ed34\u0060 Handled some dets \u0022premature_eof\u0022 issues..; \u0060093bfd3a\u0060 Fixed bug in deserializer; \u00603a1a0463\u0060 Msg transfer is GO.. \u2014 run \u0060git show\u0060 on any of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/phoebus_master.erl"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"c1c83cf90c3a5cab545631f5faee341a524a9019777f610952e386fb08175c90"}},{"ruleId":"ED4","level":"error","message":{"text":"Dual write (no outbox): phoebus_worker.vsplit_phase1/2#158: \u0060phoebus_worker\u0060 clause \u0060vsplit_phase1/2#158\u0060 PERSISTS state AND BROADCASTS a domain event as two independent side effects in the same clause, with no shared transaction or outbox. A crash between the two \u2014 or a redelivered message \u2014 diverges the store from what subscribers saw (state committed, broadcast lost) or emits a phantom event (broadcast sent, state rolled back). Record the event alongside the state in the SAME write and dispatch it from there afterwards (a transactional outbox); where the store is mnesia, wrapping both in one \u0060mnesia:transaction\u0060 achieves the same atomicity directly. Divergence blast-radius: MEDIUM."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/phoebus_worker.erl"},"region":{"startLine":170}}}],"partialFingerprints":{"codehealthFindingId/v1":"47ee7618d8bd4d8dd7c40dfa5b3338ac442c70dbd5313153f887b9e7e9ca43a4"}},{"ruleId":"ED4","level":"error","message":{"text":"Dual write (no outbox): phoebus_worker.vsplit_phase1/2#178: \u0060phoebus_worker\u0060 clause \u0060vsplit_phase1/2#178\u0060 PERSISTS state AND BROADCASTS a domain event as two independent side effects in the same clause, with no shared transaction or outbox. A crash between the two \u2014 or a redelivered message \u2014 diverges the store from what subscribers saw (state committed, broadcast lost) or emits a phantom event (broadcast sent, state rolled back). Record the event alongside the state in the SAME write and dispatch it from there afterwards (a transactional outbox); where the store is mnesia, wrapping both in one \u0060mnesia:transaction\u0060 achieves the same atomicity directly. Divergence blast-radius: MEDIUM."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/phoebus_worker.erl"},"region":{"startLine":191}}}],"partialFingerprints":{"codehealthFindingId/v1":"859188b38ebe7e8fa92bd44fe61f374060f6e7f2d1b3c033a4232929226406fc"}},{"ruleId":"ED4","level":"error","message":{"text":"Dual write (no outbox): phoebus_worker.store_result/2#360: \u0060phoebus_worker\u0060 clause \u0060store_result/2#360\u0060 PERSISTS state AND BROADCASTS a domain event as two independent side effects in the same clause, with no shared transaction or outbox. A crash between the two \u2014 or a redelivered message \u2014 diverges the store from what subscribers saw (state committed, broadcast lost) or emits a phantom event (broadcast sent, state rolled back). Record the event alongside the state in the SAME write and dispatch it from there afterwards (a transactional outbox); where the store is mnesia, wrapping both in one \u0060mnesia:transaction\u0060 achieves the same atomicity directly. Divergence blast-radius: MEDIUM."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/phoebus_worker.erl"},"region":{"startLine":370}}}],"partialFingerprints":{"codehealthFindingId/v1":"132439fab3ca328090cc671f01815bc8bfc6fda83ef485dfa0e0a3456c4e3b75"}},{"ruleId":"M2","level":"note","message":{"text":"No ADRs: No Architecture Decision Records found \u2014 no conventional ADR directory, no numbered \u0060NNNN-title\u0060 documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"670b3d6e36a756d63097d0dfbf90afd5fc761308800b9354894a07c3f4e4aa14"}},{"ruleId":"M2","level":"note","message":{"text":"No architecture diagram/doc: No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named \u0060architecture\u0060 or \u0060design\u0060 in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape \u2014 no \u0060## Architecture\u0060 heading, no \u0022architecture overview\u0022/\u0022high-level design\u0022 phrasing, no \u0022the architecture is \u2026\u0022 introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document \u2014 not evidence that nobody wrote the shape down."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"0c190e7c159d1850ee706c3ac4486e151e8a4fe169de4bf61436b9f399654f06"}},{"ruleId":"P1","level":"warning","message":{"text":"No CI pipeline: No CI workflow found (.github/workflows, azure-pipelines.yml, .gitlab-ci.yml, \u2026) \u2014 changes aren\u0027t gated by an automated build/test."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"44f01af96e50474fba2df84d95ddf4f7e1d34c29c307830b9efc9057daa6b670"}},{"ruleId":"P3","level":"note","message":{"text":"No SAST: No static application security testing detected. For this repository\u0027s stack, add dialyzer or elvis \u2014 this repository has no CI pipeline yet, so run it locally to clear the existing findings, then make it a step of the first workflow you add so a regression fails the build. What was searched, so you can tell an absence from a miss: the 0 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge\u0027s web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen \u2014 if that is your case the row is wrong, and saying so is more useful than adding a second scanner."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"6e54424179c892f03ef2fd003130ac4bd43f39bbf3b1ca0a0143e25acb80ec87"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch _:_\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/msg_buffer.erl"},"region":{"startLine":360}}}],"partialFingerprints":{"codehealthFindingId/v1":"54e21cb6a3c4bc58c52c80a2b9e13f4abd744ff7a30d230d021277211f0cfe4b"}}],"taxonomies":[{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d","organization":"MITRE","informationUri":"https://cwe.mitre.org/","isComprehensive":false,"shortDescription":{"text":"The MITRE Common Weakness Enumeration (CWE)."},"taxa":[{"id":"CWE-259","guid":"ae9ad959-fbb6-9d5e-892d-3dca66da0b69","name":"Use of Hard-coded Password","shortDescription":{"text":"Use of Hard-coded Password"},"helpUri":"https://cwe.mitre.org/data/definitions/259.html"},{"id":"CWE-77","guid":"332c8ade-6612-9f56-a06b-d8d90b1a8750","name":"Improper Neutralization of Special Elements used in a Command (\u0027Command Injection\u0027)","shortDescription":{"text":"Improper Neutralization of Special Elements used in a Command (\u0027Command Injection\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/77.html"},{"id":"CWE-78","guid":"2e31ceaf-c7ae-2e5e-9661-cfb1362789cf","name":"Improper Neutralization of Special Elements used in an OS Command (\u0027OS Command Injection\u0027)","shortDescription":{"text":"Improper Neutralization of Special Elements used in an OS Command (\u0027OS Command Injection\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/78.html"},{"id":"CWE-79","guid":"fd45580b-e8c4-fc5e-8c2f-aa8fab0b4dbf","name":"Improper Neutralization of Input During Web Page Generation (\u0027Cross-site Scripting\u0027)","shortDescription":{"text":"Improper Neutralization of Input During Web Page Generation (\u0027Cross-site Scripting\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/79.html"},{"id":"CWE-798","guid":"5e8f057d-fee3-995a-a0cb-9fc5b0d174d1","name":"Use of Hard-coded Credentials","shortDescription":{"text":"Use of Hard-coded Credentials"},"helpUri":"https://cwe.mitre.org/data/definitions/798.html"},{"id":"CWE-89","guid":"6d08fdad-37eb-c150-bbf0-d7d946863407","name":"Improper Neutralization of Special Elements used in an SQL Command (\u0027SQL Injection\u0027)","shortDescription":{"text":"Improper Neutralization of Special Elements used in an SQL Command (\u0027SQL Injection\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/89.html"},{"id":"CWE-94","guid":"75e7f50c-6c2f-dd52-bf40-bf6c52b861fd","name":"Improper Control of Generation of Code (\u0027Code Injection\u0027)","shortDescription":{"text":"Improper Control of Generation of Code (\u0027Code Injection\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/94.html"}]},{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61","version":"2025","organization":"OWASP Foundation","informationUri":"https://top10.owasp.org/2025/","isComprehensive":false,"shortDescription":{"text":"The OWASP Top 10:2025 web application security risks."},"taxa":[{"id":"A05:2025","guid":"87e86033-3231-8458-8e4a-5cb82743553a","name":"Injection","shortDescription":{"text":"Injection"},"helpUri":"https://top10.owasp.org/2025/A05_2025-Injection/"},{"id":"A07:2025","guid":"334ddd78-539d-d35c-83dd-253647eb7eaf","name":"Authentication Failures","shortDescription":{"text":"Authentication Failures"},"helpUri":"https://top10.owasp.org/2025/A07_2025-Authentication_Failures/"}]}],"properties":{"codehealthPublication":{"public":true,"notice":"This is the PUBLIC form of this artifact. Findings are listed in full, but the details of SECURITY findings \u2014 which rule fired, in which file, on which line, and how to fix it \u2014 are deliberately withheld, and any secret-scanner results are excluded entirely. Where detail is absent here it was REMOVED FOR PUBLICATION; it is not missing from the analysis. The complete artifact is available from the repository owner.","securityFindingsRedacted":0,"secretScannerRunsExcluded":0}}}]}