Public report of solidusio/solidus, published 14 November 2026. It has the same score, grades and number of
findings as the full report. The details of security findings (where they are in the code, which known
vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive reportMeasured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.11.4). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey →
Signed and filed in the standard's public register, 14 November 2026, 14:26 UTC · Survey ID cd_86a90b3a38a0433dabcb16c41aec70dc
solidusio/solidus
Measured 14 November 2026, 14:24 UTC, at code version a532c63
CAI scoreWeak
CriticalWeakAdequateStrongExemplary
No change since the last survey
The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.
A medium codebase: 49,449 lines of product code in 9 projects, tests not counted · Estimated rebuild effort: about 0.7 person-years · Weakest lens: Accessibility, 32
Findings by how serious they are
176 critical306 serious84 minor
8 dimensions are left out of the score. For each one, we either couldn't measure it in this code, or found no evidence of the safeguard we look for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.
This survey was produced by
Canine Code Analyzer
Producer
Canine Development
Analyzer
Canine Code Analyzer engine 1.0.0
Measured
14 November 2026, 14:24 UTC
A measurement, not a certificate. The Code Assurance Index records a number
together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee
the code. The standard was written by Canine Development, which also builds the Canine Code Analyzer. It is open to any tool that
implements it, and today the Canine Code Analyzer is the only one that does.
The score is deterministic, which means the same code always gets the same score. We work it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸
74of 74 dimensions measured by tools.
547of 566 findings point to an exact file and line, so you can open each one in the code. The other 19 concern the repository as a whole, such as missing documentation.
74dimensions across 8 lenses, read from 49,449 lines of product code in 9 projects.
solidusio/solidus falls short of our standard for production, in part because it has images with no text description. It scores 39 out of 100 and is rated Weak, and 140 of its 176 critical findings are security problems.
Accessibility, at 32, is the weakest lens and counts most in the score. The best first step for the work it takes is fixing the password or key in the code, worth about 2 points. Making the controls keyboard-usable would lift Accessibility itself, worth about 4 points. Raising Accessibility to 70 would lift the score to about 45.
Sixty-nine weaknesses in the code could be used by an attacker. Thirty-three pipeline tools are referenced by a changeable name, so the build pipeline can be tampered with, and eleven secrets can leak from the build pipeline. Fixing the weaknesses the scanner points to, pinning each tool to an exact version and limiting each secret to its own step would close these risks. Passing outside input through environment variables would fix the nine pipeline steps that put outside input straight into a shell command, and the five unsafe settings in infrastructure or container files need changing to safe values. The 20 labels or groups of fields with no name need connecting to their fields or naming.
The product code is 49,449 lines, about €110,000 to rebuild.
A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.
How the score is built: what each lens counts forThe lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
If Accessibility rose from 32 to 70, the lowest score rated Strong, the score would rise from 39 to about 45.
Code composition: what the lines of code are
Product code 40%Tests 60%
New since the last survey: 78 findings
These 78 critical or serious findings weren't in the previous survey, on 26 October 2026.
Code Duplication · Edited copy of a member (41 corresponding lines) legacy_promotions/lib/components/admin/solidus_admin/promotions/index/component.rb
Code Duplication · Edited copy of a member (54 corresponding lines) core/db/migrate/20250605105424_add_shipping_category_foreign_keys.rb
Code Duplication · Edited copies of one member (3 members, 34+ corresponding lines) core/db/migrate/20250604072555_add_fk_to_product_properties.rb
Code Duplication · Edited copy of a member (8 corresponding lines) admin/app/components/solidus_admin/ui/forms/address/fieldsets/contact/component.rb
Code Duplication · Edited copy of a member (22 corresponding lines) legacy_promotions/app/models/spree/promotion/rules/product.rb
Code Duplication · Edited copy of a member (18 corresponding lines) promotions/app/models/solidus_promotions/benefit.rb
Code Duplication · Edited copy of a member (18 corresponding lines) legacy_promotions/lib/solidus_legacy_promotions/testing_support/factories/order_factory.rb
Code Duplication · Edited copy of a member (20 corresponding lines) promotions/lib/solidus_promotions/migrate_adjustments.rb
Code Duplication · Edited copies of one member (4 members, 10+ corresponding lines) core/app/models/spree/in_memory_order_updater.rb
Code Duplication · Edited copy of a member (21 corresponding lines) legacy_promotions/app/models/spree/promotion_code/batch_builder.rb
Code Duplication · Edited copy of a member (9 corresponding lines) core/db/migrate/20250129061658_add_metadata_to_spree_resources.rb
Code Duplication · Edited copy of a member (15 corresponding lines) legacy_promotions/lib/controllers/backend/spree/admin/promotions_controller.rb
Code Duplication · Edited copy of a member (12 corresponding lines) REDACTED
Code Duplication · Edited copy of a member (12 corresponding lines) legacy_promotions/lib/controllers/backend/spree/admin/promotions_controller.rb
Code Duplication · Edited copy of a member (4 corresponding lines) REDACTED
Code Duplication · Edited copies of one member (4 members, 7+ corresponding lines) REDACTED
Code Duplication · Edited copies of one member (3 members, 12+ corresponding lines) core/db/migrate/20250708120317_add_adjustment_reason_foreign_keys.rb
Code Duplication · Edited copies of one member (3 members, 12+ corresponding lines) core/db/migrate/20250530102541_add_addressbook_foreign_key.rb
Code Duplication · Edited copies of one member (3 members, 14+ corresponding lines) admin/app/components/solidus_admin/products/index/component.rb
Code Duplication · Edited copy of a member (16 corresponding lines) admin/app/components/solidus_admin/return_reasons/index/component.rb
Code Duplication · Edited copy of a member (6 corresponding lines) legacy_promotions/app/models/spree/calculator/tiered_percent.rb
Code Duplication · Edited copies of one member (3 members, 13+ corresponding lines) promotions/app/models/concerns/solidus_promotions/conditions/line_item_level_condition.rb
Code Duplication · Edited copy of a member (16 corresponding lines) admin/app/components/solidus_admin/ui/forms/field/component.rb
Code Duplication · Edited copy of a member (6 corresponding lines) REDACTED
Code Duplication · Edited copies of one member (3 members, 12+ corresponding lines) REDACTED
Code Duplication · Edited copy of a member (11 corresponding lines) REDACTED
Code Duplication · Edited copy of a member (14 corresponding lines) admin/app/components/solidus_admin/orders/show/component.rb
Code Duplication · Edited copy of a member (19 corresponding lines) api/app/controllers/spree/api/checkouts_controller.rb
Code Duplication · Edited copy of a member (10 corresponding lines) promotions/app/models/solidus_promotions/calculators/tiered_percent.rb
Code Duplication · Edited copy of a member (12 corresponding lines) REDACTED
Code Duplication · Edited copies of one member (3 members, 12+ corresponding lines) admin/app/components/solidus_admin/orders/index/component.rb
Code Duplication · Edited copy of a member (9 corresponding lines) REDACTED
Code Duplication · Edited copy of a member (3 corresponding lines) REDACTED
Code Duplication · Edited copies of one member (4 members, 8+ corresponding lines) REDACTED
Code Duplication · Edited copy of a member (4 corresponding lines) admin/app/components/concerns/solidus_admin/products/form_options.rb
Code Duplication · Edited copy of a member (10 corresponding lines) core/app/models/spree/tax_calculator/default.rb
Code Duplication · Edited copy of a member (8 corresponding lines) legacy_promotions/app/models/spree/promotion_code.rb
Code Duplication · Edited copy of a member (7 corresponding lines) backend/app/controllers/spree/admin/return_authorizations_controller.rb
Code Duplication · Edited copies of one member (7 members, 8+ corresponding lines) admin/app/components/solidus_admin/adjustment_reasons/index/component.rb
Code Duplication · Edited copy of a member (13 corresponding lines) promotions/app/models/solidus_promotions/conditions/line_item_product.rb
Code Duplication · Edited copies of one member (3 members, 10+ corresponding lines) admin/app/controllers/solidus_admin/reimbursement_types_controller.rb
Code Duplication · Edited copy of a member (6 corresponding lines) admin/app/components/solidus_admin/orders/index/component.rb
Code Duplication · Edited copy of a member (6 corresponding lines) admin/app/components/solidus_admin/orders/index/component.rb
Code Duplication · Edited copy of a member (10 corresponding lines) core/app/models/spree/simple_order_contents.rb
Code Duplication · Edited copy of a member (6 corresponding lines) legacy_promotions/app/models/spree/promotion.rb
Code Duplication · Edited copy of a member (9 corresponding lines) legacy_promotions/lib/components/admin/solidus_legacy_promotions/orders/index/component.rb
Code Duplication · Edited copy of a member (6 corresponding lines) REDACTED
Code Duplication · Edited copy of a member (4 corresponding lines) backend/app/controllers/spree/admin/cancellations_controller.rb
Code Duplication · Edited copy of a member (9 corresponding lines) REDACTED
Code Duplication · Edited copy of a member (3 corresponding lines) backend/app/controllers/spree/admin/shipping_methods_controller.rb
Code Duplication · Edited copy of a member (1 corresponding lines) core/app/models/spree/in_memory_order_updater.rb
Code Duplication · Edited copies of one member (3 members, 6+ corresponding lines) REDACTED
Code Duplication · Edited copy of a member (8 corresponding lines) legacy_promotions/app/models/spree/promotion.rb
Code Duplication · Edited copies of one member (3 members, 4+ corresponding lines) promotions/app/models/solidus_promotions/benefits/adjust_line_item.rb
Code Duplication · Edited copies of one member (3 members, 9+ corresponding lines) api/app/controllers/spree/api/customer_returns_controller.rb
Code Duplication · Edited copy of a member (3 corresponding lines) REDACTED
Code Duplication · Edited copy of a member (4 corresponding lines) promotions/app/models/solidus_promotions/conditions/line_item_option_value.rb
Cohesion (LCOM4) · Low cohesion: Order (LCOM4 30) core/app/models/spree/order.rb
Dead Code · Dead file (~68 LoC) admin/app/javascript/solidus_admin/tom-select/plugins/stash_on_search.js
Dead Code · Dead file (~67 LoC) admin/app/javascript/solidus_admin/tom-select/plugins/remote_with_pagination.js
Dead Code · Dead file (~63 LoC) admin/app/components/solidus_admin/ui/forms/address/fields/country_and_state/component.js
Dead Code · Dead file (~28 LoC) admin/app/components/solidus_admin/payment_methods/form/deployment/component.js
Dead Code · Dead file (~19 LoC) admin/app/javascript/solidus_admin/tom-select/plugins/patch_scroll.js
Page structure · Data table has no header cells core/app/views/spree/carton_mailer/shipped_email.html.erb
Page structure · Data table has no header cells core/app/views/spree/carton_mailer/shipped_email.html.erb
Page structure · Data table has no header cells core/app/views/spree/order_mailer/cancel_email.html.erb
Page structure · Data table has no header cells core/app/views/spree/order_mailer/cancel_email.html.erb
Page structure · Data table has no header cells core/app/views/spree/order_mailer/confirm_email.html.erb
Page structure · Data table has no header cells core/app/views/spree/order_mailer/confirm_email.html.erb
Page structure · Data table has no header cells core/app/views/spree/order_mailer/inventory_cancellation_email.html.erb
Page structure · Data table has no header cells core/app/views/spree/order_mailer/inventory_cancellation_email.html.erb
Page structure · Data table has no header cells core/app/views/spree/reimbursement_mailer/reimbursement_email.html.erb
Page structure · Data table has no header cells core/app/views/spree/reimbursement_mailer/reimbursement_email.html.erb
Page structure · Data table has no header cells legacy_promotions/app/views/spree/order_mailer/cancel_email.html.erb
Page structure · Data table has no header cells legacy_promotions/app/views/spree/order_mailer/cancel_email.html.erb
Page structure · Data table has no header cells legacy_promotions/app/views/spree/order_mailer/confirm_email.html.erb
Page structure · Data table has no header cells legacy_promotions/app/views/spree/order_mailer/confirm_email.html.erb
We compare every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.
Fixed since the last survey: 140 findings
These 140 critical or serious findings were in the previous survey, on 26 October 2026, and are gone from this one. The first 100 are listed here.
Dead Code · Dead file (~60 LoC) admin/app/components/solidus_admin/ui/forms/address/fields/country_and_state/component.js
Dead Code · Dead file (~7 LoC) promotions/app/javascript/backend/solidus_promotions/web_components/user_picker.js
Dead Code · Dead file (~7 LoC) promotions/app/javascript/backend/solidus_promotions/web_components/variant_picker.js
Forms & labels · <fieldset> without a <legend> backend/app/views/spree/admin/product_properties/index.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/product_properties/index.html.erb
Forms & labels · <fieldset> without a <legend> backend/app/views/spree/admin/product_properties/index.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/products/_form.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/products/_form.html.erb
Forms & labels · <fieldset> without a <legend> backend/app/views/spree/admin/products/edit.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/products/index.html.erb
Forms & labels · <fieldset> without a <legend> backend/app/views/spree/admin/properties/edit.html.erb
Forms & labels · <fieldset> without a <legend> backend/app/views/spree/admin/refund_reasons/edit.html.erb
Forms & labels · <fieldset> without a <legend> backend/app/views/spree/admin/refund_reasons/new.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/refund_reasons/shared/_form.html.erb
Forms & labels · <fieldset> without a <legend> backend/app/views/spree/admin/refunds/edit.html.erb
Forms & labels · <fieldset> without a <legend> backend/app/views/spree/admin/refunds/new.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/refunds/new.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/refunds/new.html.erb
Forms & labels · <fieldset> without a <legend> backend/app/views/spree/admin/return_authorizations/edit.html.erb
Forms & labels · <fieldset> without a <legend> backend/app/views/spree/admin/return_authorizations/new.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/shared/_rebuild_vat_prices_checkbox.html.erb
Forms & labels · <fieldset> without a <legend> backend/app/views/spree/admin/shared/named_types/_edit.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/shared/named_types/_form.html.erb
Forms & labels · <fieldset> without a <legend> backend/app/views/spree/admin/shared/named_types/_new.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/shared/preference_fields/_boolean.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/shared/search_fields/_checkbox.html.erb
Forms & labels · <fieldset> without a <legend> backend/app/views/spree/admin/shipping_categories/edit.html.erb
Forms & labels · <fieldset> without a <legend> backend/app/views/spree/admin/shipping_categories/new.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/shipping_methods/_form.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/shipping_methods/_form.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/shipping_methods/_form.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/shipping_methods/_form.html.erb
Forms & labels · <fieldset> without a <legend> backend/app/views/spree/admin/shipping_methods/edit.html.erb
Forms & labels · <fieldset> without a <legend> backend/app/views/spree/admin/shipping_methods/new.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/stock_locations/_form.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/stock_locations/_form.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/stock_locations/_form.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/stock_locations/_form.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/stock_locations/_form.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/stock_locations/_form.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/stock_locations/_form.html.erb
Forms & labels · <fieldset> without a <legend> backend/app/views/spree/admin/stock_locations/edit.html.erb
Forms & labels · <fieldset> without a <legend> backend/app/views/spree/admin/store_credit_reasons/edit.html.erb
Forms & labels · <fieldset> without a <legend> backend/app/views/spree/admin/store_credit_reasons/new.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/store_credit_reasons/shared/_form.html.erb
Forms & labels · <fieldset> without a <legend> backend/app/views/spree/admin/stores/edit.html.erb
Forms & labels · <input> without a programmatic label backend/app/views/spree/admin/style_guide/topics/forms/_building_forms.html.erb
Forms & labels · <input> without a programmatic label backend/app/views/spree/admin/style_guide/topics/forms/_building_forms.html.erb
Forms & labels · <input> without a programmatic label backend/app/views/spree/admin/style_guide/topics/forms/_building_forms.html.erb
Forms & labels · <select> without a programmatic label backend/app/views/spree/admin/style_guide/topics/forms/_building_forms.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/tax_categories/_form.html.erb
Forms & labels · <fieldset> without a <legend> backend/app/views/spree/admin/tax_categories/edit.html.erb
Forms & labels · <fieldset> without a <legend> backend/app/views/spree/admin/tax_categories/new.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/tax_rates/_form.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/tax_rates/_form.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/tax_rates/_form.html.erb
Forms & labels · <fieldset> without a <legend> backend/app/views/spree/admin/tax_rates/edit.html.erb
Forms & labels · <fieldset> without a <legend> backend/app/views/spree/admin/tax_rates/new.html.erb
Forms & labels · <fieldset> without a <legend> backend/app/views/spree/admin/taxonomies/edit.html.erb
Forms & labels · <fieldset> without a <legend> backend/app/views/spree/admin/taxonomies/new.html.erb
Forms & labels · <input> without a programmatic label backend/app/views/spree/admin/taxons/index.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/users/_form.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/users/_form.html.erb
Forms & labels · <fieldset> without a <legend> backend/app/views/spree/admin/users/_sidebar.html.erb
Forms & labels · <fieldset> without a <legend> backend/app/views/spree/admin/variants/_form.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/variants/_form.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/variants/_table_filter.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/zones/_form.html.erb
Forms & labels · <label> that labels no control backend/app/views/spree/admin/zones/_form.html.erb
Forms & labels · <input> without a programmatic label REDACTED
Forms & labels · <input> without a programmatic label REDACTED
Rebuild cost: about €110,000 · Estimate
Cost to rebuild
€35,000 to €180,000, for 589 to 1,867 hours of work, about 0.7 person-years for 1 to 2 engineers
Difficulty of the problem
Standard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor
×0.7 at a score of 39. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
Size
Medium: 49,449 lines of product code
What it is not
Not a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.
How the estimate is made: We price the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.
Top priorities
The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.
1
Resolve the 1 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED.
Add a text alternative — alt on images (alt="" for purely decorative ones), a title or aria-label on meaningful svg, an aria-label or inner fallback content on canvas, and a captions <track> on video.
Raises the score by about 3 points · Medium effort · Text alternatives
Diagnosis: what the measurements show together
Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.
Where the investment is most exposed · Value at risk
This code would cost about €110,000 to build again, about 0.7 person-years of work. Its weakest lens is Accessibility, at 32 (Weak). Accessibility is about whether the interface is built so that everyone can use it, including people who can't see the screen or can't use a mouse. Because the weakest lens counts most in the score, work on Accessibility also moves the score most.
Based on: the rebuild estimate · the Accessibility grade · how much each lens counts
What to do: Start with the Accessibility actions in Top priorities.
If you do one thing first · First action
Resolve the 1 Leaked secret finding(s) in REDACTED Scanning. Of all the actions in this report, it raises the score most for the work it takes: about 2 points for low effort, because it clears the 1 REDACTED Scanning findings. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
Architecture — module dependency graph
Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways, which only happens where the projects form a dependency cycle. A graph without cycles has none.
Architecture: which parts of the code depend on which
The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.
348 modules, with 269 dependencies between them. 2 loops run through 6 of the modules, marked above the diagonal.
The table shows the 40 modules with the most connections; 308 more are left out to keep it readable.
Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
Spree.Core uses Spree.Preferences, so a change to Spree.Preferences can break Spree.Core, while a change to Spree.Core can't break Spree.Preferences.
Position
Below the diagonal: Spree.Core uses a module listed above it, which is the healthy direction.
5→6 Spree.Core.ControllerHelpers uses Spreepart of a loop✕
Connections
1 pair of types, where a type in Spree.Core.ControllerHelpers uses a type in Spree.
The types involved
Spree.Core.ControllerHelpers.Order → Spree.Order
Direction
Spree.Core.ControllerHelpers uses Spree, so a change to Spree can break Spree.Core.ControllerHelpers, while a change to Spree.Core.ControllerHelpers can't break Spree.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
Spree uses Spree.Core.ControllerHelpers, so a change to Spree.Core.ControllerHelpers can break Spree, while a change to Spree can't break Spree.Core.ControllerHelpers.
Position
Below the diagonal: Spree uses a module listed above it, which is the healthy direction.
(global) uses Spree.Core.ControllerHelpers, so a change to Spree.Core.ControllerHelpers can break (global), while a change to (global) can't break Spree.Core.ControllerHelpers.
Position
Below the diagonal: (global) uses a module listed above it, which is the healthy direction.
Spree.Admin uses Spree.Core.ControllerHelpers, so a change to Spree.Core.ControllerHelpers can break Spree.Admin, while a change to Spree.Admin can't break Spree.Core.ControllerHelpers.
Position
Below the diagonal: Spree.Admin uses a module listed above it, which is the healthy direction.
Spree.Api uses Spree.Core.ControllerHelpers, so a change to Spree.Core.ControllerHelpers can break Spree.Api, while a change to Spree.Api can't break Spree.Core.ControllerHelpers.
Position
Below the diagonal: Spree.Api uses a module listed above it, which is the healthy direction.
SolidusAdmin.ControllerHelpers uses Spree.Admin, so a change to Spree.Admin can break SolidusAdmin.ControllerHelpers, while a change to SolidusAdmin.ControllerHelpers can't break Spree.Admin.
Position
Below the diagonal: SolidusAdmin.ControllerHelpers uses a module listed above it, which is the healthy direction.
SolidusPaypalCommercePlatform uses Spree.Core.ControllerHelpers, so a change to Spree.Core.ControllerHelpers can break SolidusPaypalCommercePlatform, while a change to SolidusPaypalCommercePlatform can't break Spree.Core.ControllerHelpers.
Position
Below the diagonal: SolidusPaypalCommercePlatform uses a module listed above it, which is the healthy direction.
SolidusPaypalCommercePlatform uses Spree, so a change to Spree can break SolidusPaypalCommercePlatform, while a change to SolidusPaypalCommercePlatform can't break Spree.
Position
Below the diagonal: SolidusPaypalCommercePlatform uses a module listed above it, which is the healthy direction.
SolidusPaypalCommercePlatform uses Spree.Api, so a change to Spree.Api can break SolidusPaypalCommercePlatform, while a change to SolidusPaypalCommercePlatform can't break Spree.Api.
Position
Below the diagonal: SolidusPaypalCommercePlatform uses a module listed above it, which is the healthy direction.
SolidusAdmin uses Spree.Preferences, so a change to Spree.Preferences can break SolidusAdmin, while a change to SolidusAdmin can't break Spree.Preferences.
Position
Below the diagonal: SolidusAdmin uses a module listed above it, which is the healthy direction.
SolidusAdmin uses Spree.Core.ControllerHelpers, so a change to Spree.Core.ControllerHelpers can break SolidusAdmin, while a change to SolidusAdmin can't break Spree.Core.ControllerHelpers.
Position
Below the diagonal: SolidusAdmin uses a module listed above it, which is the healthy direction.
SolidusAdmin uses SolidusAdmin.ControllerHelpers, so a change to SolidusAdmin.ControllerHelpers can break SolidusAdmin, while a change to SolidusAdmin can't break SolidusAdmin.ControllerHelpers.
Position
Below the diagonal: SolidusAdmin uses a module listed above it, which is the healthy direction.
SolidusAdmin.Orders.Show uses SolidusAdmin.Layout, so a change to SolidusAdmin.Layout can break SolidusAdmin.Orders.Show, while a change to SolidusAdmin.Orders.Show can't break SolidusAdmin.Layout.
Position
Below the diagonal: SolidusAdmin.Orders.Show uses a module listed above it, which is the healthy direction.
SolidusAdmin.Orders.Show uses SolidusAdmin, so a change to SolidusAdmin can break SolidusAdmin.Orders.Show, while a change to SolidusAdmin.Orders.Show can't break SolidusAdmin.
Position
Below the diagonal: SolidusAdmin.Orders.Show uses a module listed above it, which is the healthy direction.
SolidusAdmin.Orders.Show.Address uses SolidusAdmin.Layout, so a change to SolidusAdmin.Layout can break SolidusAdmin.Orders.Show.Address, while a change to SolidusAdmin.Orders.Show.Address can't break SolidusAdmin.Layout.
Position
Below the diagonal: SolidusAdmin.Orders.Show.Address uses a module listed above it, which is the healthy direction.
SolidusAdmin.Orders.Show.Address uses SolidusAdmin, so a change to SolidusAdmin can break SolidusAdmin.Orders.Show.Address, while a change to SolidusAdmin.Orders.Show.Address can't break SolidusAdmin.
Position
Below the diagonal: SolidusAdmin.Orders.Show.Address uses a module listed above it, which is the healthy direction.
SolidusAdmin.Orders.Show.Adjustments.Index.Adjustable uses SolidusAdmin, so a change to SolidusAdmin can break SolidusAdmin.Orders.Show.Adjustments.Index.Adjustable, while a change to SolidusAdmin.Orders.Show.Adjustments.Index.Adjustable can't break SolidusAdmin.
Position
Below the diagonal: SolidusAdmin.Orders.Show.Adjustments.Index.Adjustable uses a module listed above it, which is the healthy direction.
SolidusAdmin.Orders.Show.Adjustments.Index.Source uses SolidusAdmin, so a change to SolidusAdmin can break SolidusAdmin.Orders.Show.Adjustments.Index.Source, while a change to SolidusAdmin.Orders.Show.Adjustments.Index.Source can't break SolidusAdmin.
Position
Below the diagonal: SolidusAdmin.Orders.Show.Adjustments.Index.Source uses a module listed above it, which is the healthy direction.
SolidusAdmin.PaymentMethods.Form uses SolidusAdmin.Layout, so a change to SolidusAdmin.Layout can break SolidusAdmin.PaymentMethods.Form, while a change to SolidusAdmin.PaymentMethods.Form can't break SolidusAdmin.Layout.
Position
Below the diagonal: SolidusAdmin.PaymentMethods.Form uses a module listed above it, which is the healthy direction.
SolidusAdmin.PaymentMethods.Form uses SolidusAdmin, so a change to SolidusAdmin can break SolidusAdmin.PaymentMethods.Form, while a change to SolidusAdmin.PaymentMethods.Form can't break SolidusAdmin.
Position
Below the diagonal: SolidusAdmin.PaymentMethods.Form uses a module listed above it, which is the healthy direction.
SolidusAdmin.PaymentMethods.Form.Deployment uses SolidusAdmin.Layout, so a change to SolidusAdmin.Layout can break SolidusAdmin.PaymentMethods.Form.Deployment, while a change to SolidusAdmin.PaymentMethods.Form.Deployment can't break SolidusAdmin.Layout.
Position
Below the diagonal: SolidusAdmin.PaymentMethods.Form.Deployment uses a module listed above it, which is the healthy direction.
SolidusAdmin.PaymentMethods.Form.Deployment uses SolidusAdmin, so a change to SolidusAdmin can break SolidusAdmin.PaymentMethods.Form.Deployment, while a change to SolidusAdmin.PaymentMethods.Form.Deployment can't break SolidusAdmin.
Position
Below the diagonal: SolidusAdmin.PaymentMethods.Form.Deployment uses a module listed above it, which is the healthy direction.
SolidusAdmin.Products.New uses SolidusAdmin.Layout, so a change to SolidusAdmin.Layout can break SolidusAdmin.Products.New, while a change to SolidusAdmin.Products.New can't break SolidusAdmin.Layout.
Position
Below the diagonal: SolidusAdmin.Products.New uses a module listed above it, which is the healthy direction.
SolidusAdmin.Products.New uses SolidusAdmin.Products, so a change to SolidusAdmin.Products can break SolidusAdmin.Products.New, while a change to SolidusAdmin.Products.New can't break SolidusAdmin.Products.
Position
Below the diagonal: SolidusAdmin.Products.New uses a module listed above it, which is the healthy direction.
SolidusAdmin.Products.New uses SolidusAdmin, so a change to SolidusAdmin can break SolidusAdmin.Products.New, while a change to SolidusAdmin.Products.New can't break SolidusAdmin.
Position
Below the diagonal: SolidusAdmin.Products.New uses a module listed above it, which is the healthy direction.
SolidusAdmin.Products.Show uses SolidusAdmin.Layout, so a change to SolidusAdmin.Layout can break SolidusAdmin.Products.Show, while a change to SolidusAdmin.Products.Show can't break SolidusAdmin.Layout.
Position
Below the diagonal: SolidusAdmin.Products.Show uses a module listed above it, which is the healthy direction.
SolidusAdmin.Products.Show uses SolidusAdmin.Products, so a change to SolidusAdmin.Products can break SolidusAdmin.Products.Show, while a change to SolidusAdmin.Products.Show can't break SolidusAdmin.Products.
Position
Below the diagonal: SolidusAdmin.Products.Show uses a module listed above it, which is the healthy direction.
SolidusAdmin.Products.Show uses SolidusAdmin, so a change to SolidusAdmin can break SolidusAdmin.Products.Show, while a change to SolidusAdmin.Products.Show can't break SolidusAdmin.
Position
Below the diagonal: SolidusAdmin.Products.Show uses a module listed above it, which is the healthy direction.
SolidusAdmin.Resources uses SolidusAdmin, so a change to SolidusAdmin can break SolidusAdmin.Resources, while a change to SolidusAdmin.Resources can't break SolidusAdmin.
Position
Below the diagonal: SolidusAdmin.Resources uses a module listed above it, which is the healthy direction.
SolidusAdmin.StockLocations.Form uses SolidusAdmin.Layout, so a change to SolidusAdmin.Layout can break SolidusAdmin.StockLocations.Form, while a change to SolidusAdmin.StockLocations.Form can't break SolidusAdmin.Layout.
Position
Below the diagonal: SolidusAdmin.StockLocations.Form uses a module listed above it, which is the healthy direction.
SolidusAdmin.StockLocations.Form uses SolidusAdmin, so a change to SolidusAdmin can break SolidusAdmin.StockLocations.Form, while a change to SolidusAdmin.StockLocations.Form can't break SolidusAdmin.
Position
Below the diagonal: SolidusAdmin.StockLocations.Form uses a module listed above it, which is the healthy direction.
SolidusAdmin.UI.Forms.Address.Fieldsets uses SolidusAdmin, so a change to SolidusAdmin can break SolidusAdmin.UI.Forms.Address.Fieldsets, while a change to SolidusAdmin.UI.Forms.Address.Fieldsets can't break SolidusAdmin.
Position
Below the diagonal: SolidusAdmin.UI.Forms.Address.Fieldsets uses a module listed above it, which is the healthy direction.
SolidusAdmin.UI.Pages.Index uses SolidusAdmin.Layout, so a change to SolidusAdmin.Layout can break SolidusAdmin.UI.Pages.Index, while a change to SolidusAdmin.UI.Pages.Index can't break SolidusAdmin.Layout.
Position
Below the diagonal: SolidusAdmin.UI.Pages.Index uses a module listed above it, which is the healthy direction.
SolidusAdmin.UI.Pages.Index uses SolidusAdmin, so a change to SolidusAdmin can break SolidusAdmin.UI.Pages.Index, while a change to SolidusAdmin.UI.Pages.Index can't break SolidusAdmin.
Position
Below the diagonal: SolidusAdmin.UI.Pages.Index uses a module listed above it, which is the healthy direction.
SolidusAdmin.UI.PreferenceFields.Base uses SolidusAdmin, so a change to SolidusAdmin can break SolidusAdmin.UI.PreferenceFields.Base, while a change to SolidusAdmin.UI.PreferenceFields.Base can't break SolidusAdmin.
Position
Below the diagonal: SolidusAdmin.UI.PreferenceFields.Base uses a module listed above it, which is the healthy direction.
SolidusAdmin.Users.StoreCredits.Show uses SolidusAdmin.Layout, so a change to SolidusAdmin.Layout can break SolidusAdmin.Users.StoreCredits.Show, while a change to SolidusAdmin.Users.StoreCredits.Show can't break SolidusAdmin.Layout.
Position
Below the diagonal: SolidusAdmin.Users.StoreCredits.Show uses a module listed above it, which is the healthy direction.
SolidusAdmin.Users.StoreCredits.Show uses Spree.Admin, so a change to Spree.Admin can break SolidusAdmin.Users.StoreCredits.Show, while a change to SolidusAdmin.Users.StoreCredits.Show can't break Spree.Admin.
Position
Below the diagonal: SolidusAdmin.Users.StoreCredits.Show uses a module listed above it, which is the healthy direction.
SolidusAdmin.Users.StoreCredits.Show uses SolidusAdmin, so a change to SolidusAdmin can break SolidusAdmin.Users.StoreCredits.Show, while a change to SolidusAdmin.Users.StoreCredits.Show can't break SolidusAdmin.
Position
Below the diagonal: SolidusAdmin.Users.StoreCredits.Show uses a module listed above it, which is the healthy direction.
SolidusPromotions uses Spree.Preferences, so a change to Spree.Preferences can break SolidusPromotions, while a change to SolidusPromotions can't break Spree.Preferences.
Position
Below the diagonal: SolidusPromotions uses a module listed above it, which is the healthy direction.
SolidusPromotions uses SolidusAdmin.ControllerHelpers, so a change to SolidusAdmin.ControllerHelpers can break SolidusPromotions, while a change to SolidusPromotions can't break SolidusAdmin.ControllerHelpers.
Position
Below the diagonal: SolidusPromotions uses a module listed above it, which is the healthy direction.
SolidusPromotions uses SolidusAdmin, so a change to SolidusAdmin can break SolidusPromotions, while a change to SolidusPromotions can't break SolidusAdmin.
Position
Below the diagonal: SolidusPromotions uses a module listed above it, which is the healthy direction.
SolidusAdmin.Orders.Index uses SolidusAdmin.UI.Pages.Index, so a change to SolidusAdmin.UI.Pages.Index can break SolidusAdmin.Orders.Index, while a change to SolidusAdmin.Orders.Index can't break SolidusAdmin.UI.Pages.Index.
Position
Below the diagonal: SolidusAdmin.Orders.Index uses a module listed above it, which is the healthy direction.
SolidusAdmin.RefundsAndReturns uses SolidusAdmin.UI.Pages.Index, so a change to SolidusAdmin.UI.Pages.Index can break SolidusAdmin.RefundsAndReturns, while a change to SolidusAdmin.RefundsAndReturns can't break SolidusAdmin.UI.Pages.Index.
Position
Below the diagonal: SolidusAdmin.RefundsAndReturns uses a module listed above it, which is the healthy direction.
SolidusAdmin.Resources.Edit uses SolidusAdmin.Resources, so a change to SolidusAdmin.Resources can break SolidusAdmin.Resources.Edit, while a change to SolidusAdmin.Resources.Edit can't break SolidusAdmin.Resources.
Position
Below the diagonal: SolidusAdmin.Resources.Edit uses a module listed above it, which is the healthy direction.
SolidusAdmin.Resources.New uses SolidusAdmin.Resources, so a change to SolidusAdmin.Resources can break SolidusAdmin.Resources.New, while a change to SolidusAdmin.Resources.New can't break SolidusAdmin.Resources.
Position
Below the diagonal: SolidusAdmin.Resources.New uses a module listed above it, which is the healthy direction.
SolidusAdmin.Shipping uses SolidusAdmin.UI.Pages.Index, so a change to SolidusAdmin.UI.Pages.Index can break SolidusAdmin.Shipping, while a change to SolidusAdmin.Shipping can't break SolidusAdmin.UI.Pages.Index.
Position
Below the diagonal: SolidusAdmin.Shipping uses a module listed above it, which is the healthy direction.
SolidusAdmin.Taxes uses SolidusAdmin.UI.Pages.Index, so a change to SolidusAdmin.UI.Pages.Index can break SolidusAdmin.Taxes, while a change to SolidusAdmin.Taxes can't break SolidusAdmin.UI.Pages.Index.
Position
Below the diagonal: SolidusAdmin.Taxes uses a module listed above it, which is the healthy direction.
SolidusAdmin.UsersAndRoles uses SolidusAdmin.UI.Pages.Index, so a change to SolidusAdmin.UI.Pages.Index can break SolidusAdmin.UsersAndRoles, while a change to SolidusAdmin.UsersAndRoles can't break SolidusAdmin.UI.Pages.Index.
Position
Below the diagonal: SolidusAdmin.UsersAndRoles uses a module listed above it, which is the healthy direction.
SolidusAdmin.OptionTypes.Edit uses SolidusAdmin.Layout, so a change to SolidusAdmin.Layout can break SolidusAdmin.OptionTypes.Edit, while a change to SolidusAdmin.OptionTypes.Edit can't break SolidusAdmin.Layout.
Position
Below the diagonal: SolidusAdmin.OptionTypes.Edit uses a module listed above it, which is the healthy direction.
SolidusAdmin.OptionTypes.Edit uses SolidusAdmin.Resources.Edit, so a change to SolidusAdmin.Resources.Edit can break SolidusAdmin.OptionTypes.Edit, while a change to SolidusAdmin.OptionTypes.Edit can't break SolidusAdmin.Resources.Edit.
Position
Below the diagonal: SolidusAdmin.OptionTypes.Edit uses a module listed above it, which is the healthy direction.
SolidusAdmin.PaymentMethods.Edit uses SolidusAdmin.Layout, so a change to SolidusAdmin.Layout can break SolidusAdmin.PaymentMethods.Edit, while a change to SolidusAdmin.PaymentMethods.Edit can't break SolidusAdmin.Layout.
Position
Below the diagonal: SolidusAdmin.PaymentMethods.Edit uses a module listed above it, which is the healthy direction.
SolidusAdmin.PaymentMethods.Edit uses SolidusAdmin.Resources.Edit, so a change to SolidusAdmin.Resources.Edit can break SolidusAdmin.PaymentMethods.Edit, while a change to SolidusAdmin.PaymentMethods.Edit can't break SolidusAdmin.Resources.Edit.
Position
Below the diagonal: SolidusAdmin.PaymentMethods.Edit uses a module listed above it, which is the healthy direction.
SolidusAdmin.PaymentMethods.New uses SolidusAdmin.Layout, so a change to SolidusAdmin.Layout can break SolidusAdmin.PaymentMethods.New, while a change to SolidusAdmin.PaymentMethods.New can't break SolidusAdmin.Layout.
Position
Below the diagonal: SolidusAdmin.PaymentMethods.New uses a module listed above it, which is the healthy direction.
SolidusAdmin.PaymentMethods.New uses SolidusAdmin.Resources.New, so a change to SolidusAdmin.Resources.New can break SolidusAdmin.PaymentMethods.New, while a change to SolidusAdmin.PaymentMethods.New can't break SolidusAdmin.Resources.New.
Position
Below the diagonal: SolidusAdmin.PaymentMethods.New uses a module listed above it, which is the healthy direction.
SolidusAdmin.Roles.Edit uses SolidusAdmin, so a change to SolidusAdmin can break SolidusAdmin.Roles.Edit, while a change to SolidusAdmin.Roles.Edit can't break SolidusAdmin.
Position
Below the diagonal: SolidusAdmin.Roles.Edit uses a module listed above it, which is the healthy direction.
SolidusAdmin.Roles.Edit uses SolidusAdmin.Resources.Edit, so a change to SolidusAdmin.Resources.Edit can break SolidusAdmin.Roles.Edit, while a change to SolidusAdmin.Roles.Edit can't break SolidusAdmin.Resources.Edit.
Position
Below the diagonal: SolidusAdmin.Roles.Edit uses a module listed above it, which is the healthy direction.
SolidusAdmin.Roles.New uses SolidusAdmin, so a change to SolidusAdmin can break SolidusAdmin.Roles.New, while a change to SolidusAdmin.Roles.New can't break SolidusAdmin.
Position
Below the diagonal: SolidusAdmin.Roles.New uses a module listed above it, which is the healthy direction.
SolidusAdmin.Roles.New uses SolidusAdmin.Resources.New, so a change to SolidusAdmin.Resources.New can break SolidusAdmin.Roles.New, while a change to SolidusAdmin.Roles.New can't break SolidusAdmin.Resources.New.
Position
Below the diagonal: SolidusAdmin.Roles.New uses a module listed above it, which is the healthy direction.
SolidusAdmin.StockLocations.Edit uses SolidusAdmin.Layout, so a change to SolidusAdmin.Layout can break SolidusAdmin.StockLocations.Edit, while a change to SolidusAdmin.StockLocations.Edit can't break SolidusAdmin.Layout.
Position
Below the diagonal: SolidusAdmin.StockLocations.Edit uses a module listed above it, which is the healthy direction.
SolidusAdmin.StockLocations.Edit uses SolidusAdmin.Resources.Edit, so a change to SolidusAdmin.Resources.Edit can break SolidusAdmin.StockLocations.Edit, while a change to SolidusAdmin.StockLocations.Edit can't break SolidusAdmin.Resources.Edit.
Position
Below the diagonal: SolidusAdmin.StockLocations.Edit uses a module listed above it, which is the healthy direction.
At a glance — Code Health · 35% · Weak · gated by R1, R7, X5 ·
Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).
OWASP category
Findings
Severity
A05:2025 — Injection
145
High / Critical
A03:2025 — Software Supply Chain Failures
16
High / Critical
A02:2025 — Security Misconfiguration
13
High / Critical
A07:2025 — Authentication Failures
10
High / Critical
Roadmap
Top priorities: Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href; Add a text alternative — alt on images (alt="" for purely decorative ones), a title or aria-label on meaningful svg, an aria-label or inner fallback content on canvas, and a captions <track> on video; Resolve the 1 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED.
Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.
Do this
Helps
Effort
Dimension
Resolve the 1 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED.
Add a text alternative — alt on images (alt="" for purely decorative ones), a title or aria-label on meaningful svg, an aria-label or inner fallback content on canvas, and a captions <track> on video.
Adopt TypeScript for the frontend: add a typecheck step to the build, then either type-check the existing JavaScript in place (`checkJs`/JSDoc types) or convert the highest-traffic modules first — no file is typed today, so this is an adoption, not a clean-up.
Add a SAST step to CI running what this repository's stack ships: brakeman for Rails apps, otherwise `semgrep --config=auto` or CodeQL's ruby pack — so a security regression fails the build instead of landing.
Per-file score 0–10 — a quality signature. Of 174 files carrying findings, judged against the Production bar: 8% slop · 56% mixed · 36% near-clean.
File
Score
Band
Worst signal
REDACTED
2.3
Slop
IaC & Container Security: High IaC: REDACTED
REDACTED
2.3
Slop
Static Analysis (SAST): High: REDACTED
REDACTED
2.4
Slop
Static Analysis (SAST): High: REDACTED
REDACTED
2.5
Slop
Static Analysis (SAST): High: REDACTED
REDACTED
2.9
Slop
Static Analysis (SAST): High: REDACTED
REDACTED
2.9
Slop
Static Analysis (SAST): High: REDACTED
REDACTED
3.0
Slop
Static Analysis (SAST): High: REDACTED
REDACTED
3.0
Slop
Static Analysis (SAST): High: REDACTED
REDACTED
3.0
Slop
IaC & Container Security: High IaC: REDACTED
REDACTED
3.3
Slop
Static Analysis (SAST): High: REDACTED
REDACTED
3.5
Slop
Static Analysis (SAST): High: REDACTED
REDACTED
3.7
Slop
Static Analysis (SAST): High: REDACTED
REDACTED
3.7
Slop
Static Analysis (SAST): High: REDACTED
REDACTED
3.7
Slop
Static Analysis (SAST): High: REDACTED
REDACTED
4.3
Mixed
Static Analysis (SAST): High: REDACTED
REDACTED
4.3
Mixed
Static Analysis (SAST): High: REDACTED
REDACTED
4.3
Mixed
Static Analysis (SAST): High: REDACTED
REDACTED
4.4
Mixed
REDACTED Scanning: Leaked secret: REDACTED
REDACTED
4.4
Mixed
Static Analysis (SAST): High: REDACTED
REDACTED
4.6
Mixed
Static Analysis (SAST): High: REDACTED
How the grades work
Every finding carries one of four grades. Three say how serious it is. The fourth says this
survey could not settle it — and it is a grade, not a gap.
Critical — 176
A definite problem that already costs you something and drags the score down: a
missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here
tends to cause failures elsewhere.
Serious — 306
Likely wrong, but not failing yet. It degrades
the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to
carry for two years either.
Minor — 84
Recorded, with no effect on how the codebase functions.
Present so the survey is complete, not because it needs doing.
Could not be resolved — 8
Something this survey could not settle
from the outside, and which could be critical or serious. Either a control was required and no
positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves
nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean
result. These are excluded from the score rather than awarded a pass, so the number on the cover neither
rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each
one is named under Limitations.
Methodology & how to trust this report
This survey is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. All 74 evaluated dimensions are computed by tools and static analysis; no language model sets or judges any of them. Overall confidence is 0.9, the weighted average across measured dimensions.
Every figure here is one of two kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10.
What we checked — 74 dimensions across the health lenses
Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.
How to trust any code-health report — three questions
Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 547 of 566 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it: Roslyn, git or a scanner, not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.
This report answers yes to all three. That's the bar to hold any assessment to.
Tools & methods
The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.
Method
Backs
Version
Evaluator
Roslyn static analysis
Complexity, cohesion, coupling, dead code, API surface, layering
What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.
D8 Code Coverage — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT READ here — but this repository measures it: a Codecov configuration (codecov.yml) and a coverage step in CI (`codecov/codecov-action`) shows that coverage is collected and tracked in your own CI. The built-in collector has no runner for this ecosystem (.rb), so the analyzer could not read the number — a gap in the analyzer's language coverage, not an unmeasured repo. Not scored.
D11 Test Reliability — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test reliability not included — the Ruby suite (RSpec: 10 bundle roots) did not finish re-running within its budget: the Ruby suite did not finish re-running within its tier budget.
D19 Documentation Quality — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This kind did not reach the 95 % precision gate in three adjudicated runs (docs/plans/deterministic-engine/adjudication/D19-sample3-v3.md), so by the pre-registered fallback it publishes no row until a re-measurement shows it does. The candidates are counted here, not reported as findings, and the score does not include them.
D22 Internal API Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D22's deterministic call-shape rules are gated on C# first (docs/plans/deterministic-engine.md, P5): each other language is switched on only after its own concept suite and A/B gate pass. This says nothing about whether that surface is consistent.
D24 Comment Value — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Each source language's comment syntax, and the code a comment annotates in it, needs its own proof before D24 judges it. Until then those comments are left unread, not counted as clean.
D32 Data Compliance (PII/GDPR) — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `storefront/template.rb` produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
AC2 Forms & labels — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 107 further occurrence(s) are not listed individually; the score already reflects all 147.
AXR1 Runtime accessibility — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Render strategy: boot via DockerCompose (REDACTED). compose up failed (exit 17 — an image could not be built) — failed to solve: process "/bin/sh -c curl -sSL https://www.postgresql.org/media/keys/ACCC4CF8.asc | apt-key add - && echo 'deb http://apt.postgresql.org/pub/repos/apt/ bookworm-pgdg main' $PG_VERSION > /etc/apt/sources.list.d/pgdg.list" did not complete successfully: exit code: 2; runtime evidence skipped.
M4 Documentation accuracy — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. M4 checks only the claim kinds adjudicated at or above 95 % precision: links and versions (PREREGISTRATION version 9), and artefact counts an order of magnitude off. Paths, command arguments, installs, environment variables, settings, projects, packages, routes, cd targets, infrastructure products and removed modules are read but not checked, and none of them is reported or counted.
R7 Dead Code — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 2 further occurrence(s) are not listed individually; the score already reflects all 42.
S1 Web-Security Posture — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. 1095 Ruby file(s) were read for weak hashes and ciphers, key material fixed in the source, disabled certificate validation and obsolete TLS versions, and none was found. The server controls this dimension also scores were not assessed, so no score is given.
Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.
Limitations & what we did not check
We assess the repository exactly as committed, and only the repository. By design we do not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.
Per-dimension blind spots
For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.
D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
D12 Dependency Hygiene: Dependency health reads manifests and lockfiles — a vulnerability in a vendored/copied dependency, or risk from how a dependency is actually used, is outside this view.
D13 REDACTED Scanning: REDACTED detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
D20 ADR Quality: ADR quality checks the structure of the decision records present: it cannot know about decisions made and never recorded, and it does not judge how well a record argues its case. Records in a language the section lexicon does not cover are not evaluated.
D23 Boundary Type-Coupling: Boundary leakage is detected from type references across detected contexts — leaks that flow through primitives, serialization or shared infrastructure may not surface as a typed reference.
D24 Comment Value: Comment value is measured as redundancy only: a comment that repeats its code's words is found, but a paraphrase in other words, a vague comment, or one the code contradicts is not, and whether a comment is valuable is not claimed. Comments in other scripts or languages, and outside C#, are not judged.
D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
D31 IaC & Container Security: IaC scanning checks Dockerfiles/Terraform/Kubernetes against best-practice rules — it cannot see the live cloud account, runtime configuration, or drift between the committed config and what is actually deployed.
D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a REDACTED (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a REDACTED ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
AC1 Text alternatives: Alt-text is detected structurally — the scan sees that an alternative EXISTS, not whether it meaningfully describes the image, and decorative-vs-missing is judged by attribute shape; runtime-injected images and a non-role=img decorative svg are out of scope. This is accessibility readiness, never a WCAG conformance claim.
AC2 Forms & labels: Label association is read from static markup — a label wired up at runtime (JS-set aria-labelledby, framework-injected ids) reads as missing, a present label says nothing about whether its text is correct. A known UI-library field component (e.g. a JSX <TextField>) is now checked conservatively — flagged only when it carries NO label/aria-label/aria-labelledby/id/name — but wrapper/context-labelled libraries (Chakra/Radix FormControl+FormLabel) aren't statically visible (possible false positive) and non-JSX lowercased components are still skipped. A click handler on a plain element is now asked for a name too (it is a control the author declared), but the subtree test that answers it is deliberately generous: any DYNAMIC text expression in the subtree counts as a name, so an icon chosen by a ternary ({cond ? <IconA/> : <IconB/>}) reads as named, and a glyph component from a library the icon-import list does not know still names its parent. A clean result is "no unlabelled control found", not a labelling proof.
AC3 Page structure: Page structure is read from the static markup tree — landmarks, headings and lang injected at runtime aren't seen, heading ORDER is checked structurally (not against the rendered visual hierarchy), and lang/title/main fire only on full documents, never partials, and the data-table check sees header-cell presence (a <th> exists), not whether each header correctly associates with its cells. Static readiness, not conformance.
AC4 Keyboard semantics: Keyboard semantics are inferred from markup attributes — interactivity wired purely in script, focus managed at runtime, and component-level handlers are invisible. A clean result means "no static keyboard-trap shape", not a keyboard-operability proof.
AC5 ARIA correctness: ARIA correctness is checked against the static role/attribute shape — roles/attributes set dynamically aren't seen, a valid role says nothing about whether it matches the element's real behaviour, and required-state checks are suppressed when a JSX spread could supply them. The two-branch toggle check (a control whose state is conveyed only by which of two mutually exclusive branches renders) reads CONDITIONALS THAT ARE ATTRIBUTES — Vue v-if/v-else/v-show and Alpine x-if/x-show — so the same toggle written as a Svelte {#if} block or a JSX ternary is control flow the markup model never projects as a branch and is not seen at all.
AC6 Visual & motion safety: Contrast and motion safety are PARTIAL by construction — literal colours (hex/rgb/hsl/named) in inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS top-level declarations are read (same-rule/same-element colour+background pairs only); computed/runtime/theme colour, external-CDN stylesheets, CSS-in-JS dynamic (${…}) and nested-selector colours, cross-element pairs and image contrast stay out of reach, so a clean result is bounded by what the static CSS itself shows.
AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
DM6 Domain ↔ infrastructure boundary: Infrastructure reached through a hand-rolled wrapper, a domain-named facade, reflection, or a string-keyed service locator resolves to a non-infra type and isn't seen; the body scan is symbol resolution over syntax, not full dataflow. A clean result means "no resolved infra reference in a domain body", not a proof of purity.
M4 Documentation accuracy: Documentation accuracy checks links, versions and artefact counts against the tree: other claims (paths, commands, settings, routes) are read but not checked, and it cannot run the onboarding or measure how long a real new joiner takes.
P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
P5 DR & Backup: Backup/restore and disaster-recovery readiness is judged from in-repo evidence — a config that exists is not a tested restore, so the absence of positive evidence is reported as "not evidenced", never scored as present.
P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.
What it measures: How tangled the control flow is — methods with many branches are hard to test and change.
Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.
Bring the 2 bodies over 15 down to 15 or less in Cyclomatic Complexity — start with InstallGenerator.prepare_options (cyclomatic 17), Preferable.convert_preference_value (cyclomatic 16). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 2 together lifts Cyclomatic Complexity from 9.7 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.
Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How hard the code is for a person to follow, beyond raw branching.
Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.
Bring the 4 bodies over 15 down to 15 or less in Cognitive Complexity — start with (anonymous) (cognitive 31), address.window.addEventListener("DOMContentLoaded") (cognitive 28), component.render (cognitive 17). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 4 together lifts Cognitive Complexity from 8.8 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.
Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D3 · God Classes9.5 / 10Stronggated by 6 serious findings✓ Tool-verified
What it measures: Over-large classes that try to do too much ("god classes").
Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.
Resolve the 4 TooManyMethods finding(s) in God Classes — start with REDACTED, shipment.rb, variant.rb. — One of this dimension's main actionable groups (4 warning-level).
Resolve the 2 FileTooLong finding(s) in God Classes — start with 20160101010000_solidus_one_four.rb, REDACTED. — One of this dimension's main actionable groups (2 warning-level).
Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How much of the production code is copy-pasted: the share of production lines inside a reported copy (every copy of a duplicated block or of an edited member, each line once), 10 at none and 0 at a quarter of the lines.
Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), scored on the share of production lines inside a reported copy (each line once; 10 at none, 0 at a quarter). Deterministic.
31 duplicated block group(s) detected. 3.8 % of the production lines (1,901 of 49,449) are in a reported copy. A further 57 rows report members as variants of one another; the share counts each copied line once, however many rows cite it. 1 of the 88 are in trees this repository does not ship — vendored, example/demo, project-template, fixture and benchmark code — and are ranked below the shipped groups rather than excluded from them: the duplication there is real and is still counted in this dimension's score. The dimensions that publish a production-file census leave those trees out of theirs, so this count is deliberately drawn over the wider population.
Edited copy of a member (6 corresponding lines) · ×6legacy_promotions/app/models/spree/calculator/tiered_percent.rb:46
Edited copy of a member (9 corresponding lines) · ×4core/db/migrate/20250129061658_add_metadata_to_spree_resources.rb:6
Edited copy of a member (4 corresponding lines) · ×4REDACTED:119
+ 42 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 6 Edited copy of a member (6 corresponding lines) finding(s) in Code Duplication — start with component.rb (2), tiered_percent.rb, REDACTED. — One of this dimension's main actionable groups (6 warning-level).
Resolve the 6 Duplicated block (8 lines × 2) finding(s) in Code Duplication — start with component.rb (2), 20250129061658_add_metadata_to_spree_resources.rb, stores.rb. — One of this dimension's main actionable groups (6 warning-level).
Resolve the 5 Duplicated block (12 lines × 2) finding(s) in Code Duplication — start with in_memory_order_updater.rb (2), install_tailwindcss.rb, 20160101010000_solidus_one_four.rb. — One of this dimension's main actionable groups (5 warning-level).
Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D5 · Coupling10.0 / 10Exemplary✓ Tool-verified
What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.
Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.
Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.
8 production modules (RubyGems), 0 dependency cycle(s), 0 unstable depended-on module(s). Read from the build's own module declarations, and main-sequence distance (abstractness) is not computed for these modules yet.
What it measures: Whether a class's methods are focused on a single responsibility.
Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.
Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.
Low cohesion: Order (LCOM4 30) · ×11core/app/models/spree/order.rb:21
What to do
Resolve the 11 Low cohesion finding(s) in Cohesion (LCOM4) — start with REDACTED (2), REDACTED, shipment.rb. — One of this dimension's main actionable groups (11 warning-level).
Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether dependencies are current, not deprecated, and not bloated. Known vulnerabilities are D30's.
Method: Manifest scan via dotnet list package across all projects; worst-signal-per-package deduction (capped-linear for deprecation, prerelease and outdated) per KLoC. Known-vulnerable packages are D30's and are not charged here (rubric-2026.11.2). Exhaustive.
0 outdated direct gem(s), 1 pinning defect(s). 104 declaration(s) graded against rubygems.org, none of them against a committed REDACTED.lock — this repository commits none, which a published gem correctly does not, so currency is read off the declared requirements: a declaration that does not cap below the current release resolves to it on `bundle install`. 14 declaration(s) carry a requirement that EXCLUDES the current release; that is a deliberate constraint (a supported-version ceiling or a held-back CI pin) and is counted, not charged. Whether any of these gems is DEPRECATED or YANKED is not graded — rubygems.org publishes no deprecation marker, and a yank removes a version rather than flagging it. Whether any is UNMAINTAINED is not graded either: no registry publishes a maintenance status, and release age does not stand in for one. Whether any is UNUSED is a source question, not a registry one. Known CVEs in this dependency graph are D30's question, read from the manifest there.
Floating git dependency: rails
What to do
Resolve the 1 Floating git dependency finding(s) in Dependency Hygiene. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d12_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.
Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.
What it measures: Whether the licenses of third-party packages are compatible with your policy.
Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.
0 of 77 shipped gem(s) use a banned license. Licences were resolved from rubygems.org over the 77 runtime gem(s) this repository declares. It commits no REDACTED.lock to close that set over, so the verdict covers the declarations rather than the whole resolved graph. Development-group and `add_development_dependency` gems are excluded: they are not distributed with this repository. 4 of them publish no licence on rubygems.org; that is missing data, not a violation, and none of them is charged. This repository publishes itself under BSD-3-Clause, which is its own choice and is not judged here.
What it measures: Files that change often and are also complex — the riskiest hotspots.
Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.
What it measures: Whether knowledge is concentrated in too few people (the "bus factor").
Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.
31 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is promotions/app/models/solidus_promotions/benefit.rb. Counted over 195 of the 1216 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
Off-boarding risk: anonymized user #1 · ×3
Further sole-owners (lower concentration)
What to do
Resolve the 3 Off-boarding risk finding(s) in Bus Factor. — One of this dimension's main actionable groups (3 recommendation-level).
Resolve the 1 Further sole-owners (lower concentration) finding(s) in Bus Factor. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.
Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.
30 deducted task-comment markers across 49449 LoC (0.1/KLoC) → score 9.9. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.
TodoComment repeated across 12 filespromotions/app/models/solidus_promotions/conditions/first_order.rb:6
What to do
Resolve the 13 TodoComment finding(s) in Explicit Debt — start with routes.rb (2), ability_spec.rb, order_shipping_spec.rb. — One of this dimension's main actionable groups (13 warning-level).
Resolve the 4 FixmeComment finding(s) in Explicit Debt — start with scopes_spec.rb, payment_create.rb, scopes.rb. — One of this dimension's main actionable groups (4 warning-level).
Resolve the 1 HackComment finding(s) in Explicit Debt — start with checkouts_controller.rb. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D20 · ADR Quality0.0 / 10Critical✓ Tool-verified
What it measures: Whether architecture decisions are recorded well (context, decision, consequences).
Method: Every ADR read by its section structure: nine located rules (a missing Decision, Context or Consequences section, a stale status, two records deciding the same question, a dangling supersede link, a number-only title, a single option, no named cost, no status where the log uses one, no enforcement field where the log adopted one), each a fixed deduction from 10; the score is the mean over evaluated records. Deterministic, no model. Advisory.
What it measures: Whether domain types (IDs, enums, value objects) leak across bounded-context boundaries.
Method: Cross-context domain-type leakage via Roslyn structural classification (strongly-typed IDs / value objects) over every public surface. Exhaustive, deterministic, type-level aggregate-boundary check.
Coverage: Bounded contexts derived from NAMESPACE prefix (or graph-inferred where available); cross-boundary domain-type leakage then checked exhaustively over every public member of every type.
What it measures: Whether comments are worth it — explaining WHY (valuable) rather than WHAT (redundant).
Method: Every inline C# comment compared word by word with the identifiers, literals and constructs of the code it annotates (taken from the syntax); a comment whose words that code already contains is redundant, as are closing-brace labels and generator template text. Comments giving a reason or a reference are kept; other scripts and languages are not judged. Deterministic, exhaustive, advisory.
4 of 9 build units (Bundler, RubyGems) flagged as possibly oversized/incoherent.
Projects may be oversized for their cohesion
What to do
Resolve the 1 Projects may be oversized for their cohesion finding(s) in Project Cohesion. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.
Method: REDACTED scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.
8 finding(s): 0 critical, 8 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.
REDACTED
REDACTED
REDACTED
What to do
Resolve the 6 REDACTED finding(s) in Secrets (history) — start with REDACTED (4), REDACTED, REDACTED. — One of this dimension's main actionable groups (6 issue-level).
Resolve the 2 High secret finding(s) in Secrets (history) — start with REDACTED (2). — One of this dimension's main actionable groups (2 issue-level).
Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.
Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.
Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).
145 finding(s): 0 critical, 123 high, 22 medium, 0 low. 31 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. semgrep hit a parse error in 24 file(s) — `core/config/locales/en.yml`, `core/lib/generators/spree/dummy/templates/rails/database.yml`, `core/lib/spree/testing_support/dummy_app/database.yml`, `i18n/config/locales/bg.yml`, `i18n/config/locales/cs.yml`, … (+19 more) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. Separately, one or more rules could not re-parse an embedded snippet in 7 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
+ 14 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 65 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (8), REDACTED (6), REDACTED (5). — One of this dimension's main actionable groups (65 issue-level).
Resolve the 2 REDACTED finding(s) charged to Static Analysis (SAST) — the other 31 are reported here at file:line but scored by D36 (supply-chain provenance), which charges them once. — One of this dimension's main actionable groups (33 issue-level, 2 of them charged here).
Resolve the 9 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (6), REDACTED, REDACTED. — One of this dimension's main actionable groups (9 issue-level).
Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.
Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no REDACTED.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05. Advisory since rubric-2026.11.2 (CAI decision 0006): every row is a match against a vulnerability database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.
2 finding(s): 0 critical, 1 high, 1 medium, 0 low. 4 known-vulnerable gem advisory(ies) across 80 declared gem(s). This repository commits no REDACTED.lock — which a published gem correctly does not — so osv-scanner had no resolved graph to read, and the question was put to osv.dev instead over the releases `bundle install` resolves this repository's 104 declared requirement(s) to. The verdict therefore covers the DIRECT declarations at their resolved releases, not the transitive graph a lock would close over.
REDACTED
REDACTED
What to do
Resolve the 1 High CVE finding(s) in Dependency Vulnerabilities — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 1 Medium CVE finding(s) in Dependency Vulnerabilities — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d30_recommendation.md · top locations in Appendix A, every location in findings.md.
Resolve the 5 High IaC finding(s) in IaC & Container Security — start with REDACTED (5). — One of this dimension's main actionable groups (5 issue-level).
Resolve the 6 Medium IaC finding(s) in IaC & Container Security — start with REDACTED (4), REDACTED (2). — One of this dimension's main actionable groups (6 warning-level).
Resolve the 2 Low IaC finding(s) in IaC & Container Security — start with REDACTED (2). — One of this dimension's main actionable groups (2 recommendation-level).
Detailed fixes: d31_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.
Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.
43 of 195 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is core/db/migrate/20160101010000_solidus_one_four.rb. Counted over 195 of the 1216 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
Resolve the 1 Orphaned knowledge finding(s) in Knowledge Freshness — start with 20160101010000_solidus_one_four.rb. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 42 Orphaned file finding(s) in Knowledge Freshness — start with REDACTED (2), routes.rb (2), REDACTED (2). — One of this dimension's main actionable groups (42 recommendation-level).
Resolve the 1 Further orphaned files (smaller) finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.
Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.
Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.
Resolve the 4 Change coupling finding(s) in Change Coupling — start with adjust_line_item.rb, component.rb, REDACTED. — One of this dimension's main actionable groups (4 warning-level).
Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.
Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.
+ 4 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 4 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (4 warning-level).
Resolve the 2 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED, REDACTED. — One of this dimension's main actionable groups (2 issue-level).
Resolve the 2 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED, REDACTED. — One of this dimension's main actionable groups (2 warning-level).
Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Reported apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.
Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. Advisory since rubric-2026.11.2 (CAI decision 0006): the malicious-package feed is a database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.
No dependency in any ecosystem this repository declares is published as malicious. 4 known-vulnerable gem advisory(ies) across 80 declared gem(s). This repository commits no REDACTED.lock — which a published gem correctly does not — so osv-scanner had no resolved graph to read, and the question was put to osv.dev instead over the releases `bundle install` resolves this repository's 104 declared requirement(s) to. The verdict therefore covers the DIRECT declarations at their resolved releases, not the transitive graph a lock would close over.
What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.
Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.
0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 0 platform declaration(s) and 104 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.
✓ On the Gold path — maintain.
Detailed fixes: d44_recommendation.md.
Do you agree with this assessment?
Frontend & cross-cutting dimensions
R = React/JS · M = Maturity · P = Readiness.
AC1 · Text alternatives2.2 / 10Critical✓ Tool-verified
Other · Accessibility — Whether non-text content carries a text alternative — img/area/input[type=image] have alt, a meaningful svg has a title or aria-label, video has a captions track, and object/embed/canvas have a name or fallback content. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: every img/area/input[type=image] checked for alt, svg[role=img] for a title/aria-label, video for a captions <track>. Components skipped, spreads suppressed. Deterministic, hard fact per element.
Coverage: Population: image/media elements — img, area, input[type=image], svg, video, object, embed, canvas — across the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and dynamic-attribute elements are skipped. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is NOT read by any producer, so it contributes no element to this population; where such a frontend is present the card discloses it as an analyzer gap rather than scoring around it.
An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative. (×3) — backend/app/assets/javascripts/spree/backend/templates/products/upload_progress.hbs:2, backend/app/views/spree/admin/style_guide/topics/tables/_building_tables.html.erb:18, backend/app/views/spree/admin/style_guide/topics/tables/_building_tables.html.erb:40
What to do
Add a text alternative — alt on images (alt="" for purely decorative ones), a title or aria-label on meaningful svg, an aria-label or inner fallback content on canvas, and a captions <track> on video.
Do you agree with this assessment?
AC2 · Forms & labels3.7 / 10Weak✓ Tool-verified
Other · Accessibility — Whether form controls have a programmatic label (an associated label, aria-label or aria-labelledby), buttons have text, links have an accessible name, a click handler on a plain element names the control it declares, fieldsets have a non-empty legend, known UI-library field components carry a label prop, and a placeholder isn't used as the only label. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: inputs/selects/textareas checked for an associated label[for]/wrapping label/aria-label/aria-labelledby (per document), buttons for accessible text, fieldsets for a legend; placeholder-only labelling flagged. Deterministic, hard fact per control.
Coverage: Population: form controls, buttons, links, fieldsets and known UI-library field components in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and spread/dynamic-attribute elements are skipped, so a control whose label arrives through a spread or a runtime expression is deliberately not judged. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id. (×20) — admin/app/components/solidus_admin/layout/navigation/component.html.erb:25, admin/app/components/solidus_admin/ui/checkbox_row/component.html.erb:6, admin/app/components/solidus_admin/ui/checkbox_row/component.html.erb:21, …
A fieldset groups related controls but has no <legend> to name the group. Add a <legend> as its first child — or, if the group already has a visible caption beside it (or the fieldset is there only to disable its subtree and carries no group box), point aria-labelledby at that caption's id instead, which names the group without rendering a second one. (×14) — admin/app/components/solidus_admin/ui/table/ransack_filter/component.html.erb:1, backend/app/assets/javascripts/spree/backend/templates/variants/line_items_autocomplete_stock.hbs:1, backend/app/views/spree/admin/adjustment_reasons/edit.html.erb:11, …
This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label. — admin/app/components/solidus_admin/ui/table/ransack_filter/component.html.erb:32
This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it. (×5) — backend/app/assets/javascripts/spree/backend/templates/orders/line_item.hbs:23, backend/app/assets/javascripts/spree/backend/templates/orders/shipment_tracking.hbs:7, backend/app/assets/javascripts/spree/backend/templates/orders/shipping_method.hbs:8, …
What to do
Give every control a programmatic label (a <label for> / wrapping <label> / aria-label) and every button text — a placeholder is not a label.
Other · Accessibility — Whether pages declare a language (well-formed BCP-47) and a non-empty title, expose exactly one main landmark and a sane heading order with non-empty headings, keep zoom enabled, title their iframes, give data tables header cells, and avoid meta-refresh. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: html lang, document <title>, a main landmark and heading order on full documents only, plus zoom-disabling viewports, untitled iframes and meta-refresh anywhere. Deterministic, per structural checkpoint.
Coverage: Population: the PARSED MARKUP documents (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx). The page-level checks — lang, title, single main landmark — fire ONCE PER FULL DOCUMENT (an <html> root) and never on a partial or component fragment, so a repo of fragments is assessed only on the per-element checks (heading order, table headers, iframe titles, meta-refresh, zoom). Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en"). (×2) — admin/app/views/layouts/solidus_admin/preview.html.erb:2, core/app/views/layouts/spree/base_mailer.html.erb:2
A page with no <title> gives no name in the tab, history or screen-reader page list. Add a descriptive <title> in <head>. (×2) — admin/app/views/layouts/solidus_admin/preview.html.erb:2, core/app/views/layouts/spree/base_mailer.html.erb:2
No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>. (×4) — admin/app/views/layouts/solidus_admin/preview.html.erb:2, backend/app/views/spree/layouts/admin.html.erb:2, backend/app/views/spree/layouts/admin_style_guide.html.erb:2, …
A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope). (×23) — backend/app/views/spree/admin/stock_items/_stock_management.html.erb:37, backend/app/views/spree/admin/stock_items/_stock_management.html.erb:53, backend/app/views/spree/admin/stock_items/_stock_management.html.erb:65, …
What to do
Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh.
Other · Accessibility — Whether interactive behaviour is keyboard-reachable — no click handler on a non-interactive element lacking a role, tabindex and key handler, no element the repo's own CSS styles `cursor: pointer` without giving it any of the three, no unfocusable element whose only binding is a mouse enter/leave pair or a double-click, no positive tabindex, no href-less anchor, no placeholder-href (#/javascript) link acting as a button. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: click handlers on non-interactive elements lacking role+tabindex+key handler, positive tabindex values, and href-less anchors. Components skipped, spreads suppressed. Deterministic, hard fact per element.
Coverage: Population: elements that pose a keyboard-semantics question, in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx) — a non-natively-interactive element carrying a click handler, a double-click or hover enter/leave binding, a pointer-only gesture on a tabindex="0" element, or `cursor: pointer` from the repo's own CSS; an href-less or placeholder-href (#, javascript:) anchor; and any element with a positive tabindex. Natively interactive elements used correctly (<button>, <a href>, form controls) are NOT in the population — there is nothing to judge — so a page of nothing but correct controls gives AC4 nothing to measure. Keyboard reachability is judged from the markup, never from a rendered page. ★ An interactive element declared in a tagged-template (html`…`) or hyperscript frontend is NOT in this population — no producer reads either — so an empty population is reported as an analyzer gap, never as "this repository has no interactive elements".
This <div role="dialog"> is a modal dialog, but nothing moves focus into it when it opens and nothing keeps focus inside it while it is open, so a keyboard or screen-reader user keeps acting on the content behind it (WCAG 2.4.3). Use a native <dialog> opened with showModal(), a dialog component that traps focus, or move focus to the dialog on open, trap Tab inside it (or make the page behind inert) and return focus to the control that opened it on close. (×3) — admin/app/components/solidus_admin/ui/alert/component.html.erb:1, admin/app/components/solidus_admin/ui/toast/component.html.erb:1, backend/app/views/spree/admin/shared/_modal.html.erb:1
An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action. (×10) — backend/app/views/spree/admin/shared/_navigation_footer_fallback.html.erb:15, REDACTED:2, REDACTED:2, …
What to do
Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href.
Other · Accessibility — Whether ARIA is used correctly — valid non-abstract roles, the ARIA state a role requires, valid (non-misspelled) aria-* attribute names, in-enum values for token-typed aria-* attributes, and no aria-hidden on (or wrapping) a focusable element. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: role values checked against the WAI-ARIA role set (abstract/invalid flagged), required ARIA state for a role, and aria-hidden on a focusable element. Deterministic, role/attribute level.
Coverage: Population: elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx) that carry a role or an aria-* attribute; roles and token values are checked against the ARIA enums exhaustively within that set. An expression-valued (dynamic) role or aria-* value is skipped rather than guessed, and markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
aria-hidden="true" hides the element from assistive tech but leaves it keyboard-focusable — a confusing dead stop. Remove aria-hidden or make the element non-focusable. — admin/app/components/solidus_admin/ui/modal/component.html.erb:9
aria-hidden="true" here hides the subtree from assistive tech, but a focusable descendant stays in the tab order — a keyboard user can land on a control screen readers can't see. Add inert, take the descendants out of the tab order (tabindex="-1"), or drop aria-hidden. — backend/app/views/spree/admin/shared/_modal.html.erb:1
What to do
Use valid, non-abstract roles, supply the ARIA state each role requires, and never put aria-hidden on a focusable element.
Other · Accessibility — Whether focus outlines aren't removed without a replacement, motion respects prefers-reduced-motion, and literal CSS colour pairs meet contrast — PARTIAL: inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS literals are read (hex/rgb/hsl/named), never computed/runtime/external-CDN colour. Static markup readiness, not a WCAG conformance claim.
Method: Static markup/CSS scan: inline outline:none/0, literal inline colour/background contrast against the 4.5:1 AA floor, and <style>-block animation without a prefers-reduced-motion guard. Deterministic but PARTIAL — only inline styles and in-repo CSS literals are visible.
Coverage: Population: styled elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx), plus in-repo <style> blocks, in-repo .css files and CSS-in-JS literals. Colour contrast is computed from LITERAL colour pairs only (hex/rgb/hsl/named, including var() tokens and Tailwind neutral utilities) — computed, runtime-themed and external-CDN colour is never resolved, so this is a partial read of contrast by construction. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
`hr` sets color: #d9d9d9 on background-color: #d9d9d9 — 1.0:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — core/app/views/layouts/spree/base_mailer.html.erb:90
`table.button td, table.tiny-button td, table.small-button td, table.medium-button td, table.large-button td` sets color: #ffffff on background-color: #2ba6cb — 2.8:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — core/app/views/layouts/spree/base_mailer.html.erb:436
`.text-input input` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — storefront/templates/app/assets/stylesheets/application.tailwind.css:44
`.select-input select` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — storefront/templates/app/assets/stylesheets/application.tailwind.css:58
`.theme-switcher` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — storefront/templates/app/assets/stylesheets/application.tailwind.css:89
`#admin-nav-toggle.fa:focus` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — backend/app/assets/stylesheets/spree/backend/components/_navigation.scss:45
`.solidus-admin--nav--footer summary` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — backend/app/assets/stylesheets/spree/backend/components/_navigation_solidus_admin.scss:204
`.solidus-admin--nav--switch:focus` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — backend/app/assets/stylesheets/spree/backend/components/_switch_solidus_admin.scss:14
`#admin-nav-toggle.fa:before` moves (`transition: transform .5s ease-in-out`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — backend/app/assets/stylesheets/spree/backend/components/_navigation.scss:41
`.spinner` moves (`animation: spinner 1s infinite linear`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — backend/app/assets/stylesheets/spree/backend/components/_progress.scss:47
What to do
Keep a visible focus style (don't remove the outline without a replacement), guard animation with prefers-reduced-motion, and raise low-contrast colour pairs to at least 4.5:1.
Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.
Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.
Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.
Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.
Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.
Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).
Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.
Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.
Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.
Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').
Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.
Do you agree with this assessment?
C1 · Data Protection3.5 / 10Weak✓ Tool-verified
Other · Security — Whether sensitive data is encrypted at rest and in transit and keys are vaulted.
Method: Roslyn plus filesystem scan: encryption presence (EF ColumnEncryption, key-vault references, HTTPS enforcement) and key-derivation KDF detection. Deterministic.
What to do
Strengthen data-at-rest protection: vault your keys (AWS KMS / Secrets Manager, GCP KMS / REDACTED Manager, HashiCorp Vault — kms_encrypted or vault-rails, not only the master key beside credentials.yml.enc) and encrypt the most sensitive columns (encrypts, lockbox) — partial coverage still leaves gaps.
Enforce HTTPS (config.force_ssl = true in config/environments/production.rb, or Rack::SSL in a Rack application) so data in transit is always encrypted.
Other · Security — Whether access is authorized by default — a framework authorization attribute/decorator or policy, or imperative guard methods (throw-on-violation) called from handlers.
Method: Roslyn scan: [Authorize] usage and authorization policies, plus imperative throw-on-violation guard methods detected via syntax. Deterministic.
Other · Domain Modelling — Whether the domain layer stays free of infrastructure dependencies — a domain aggregate fused to a persistence ORM (ActiveRecord/Sequel/ROM) on its own declaration (active-record) couples the domain to infrastructure. The clean-architecture dependency rule.
Method: Roslyn (DDD-gated): domain-layer types scanned for infrastructure usage in member SIGNATURES and inside method/accessor BODIES — resolved calls and object-creations into EF/Marten/HTTP/Mongo/Redis/message-bus types (not just a namespace allowlist). Deterministic, symbol-resolved, exhaustive over domain-layer bodies, DDD-native.
Coverage: Domain layer identified by NAMESPACE heuristic; infrastructure then resolved by symbol in member SIGNATURES and method/accessor BODIES — rename the layer and the check evaporates.
Other · Code Health — Unreviewed-generation residue in this repository's Ruby: methods whose whole body still raises NotImplementedError where nothing overrides them, or a "not implemented" error, and placeholder text (lorem ipsum, changeme/replace_me…) left in strings of non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.
Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.
A placeholder string ("Lorem ipsum dolor sit amet") is still in shipped code — typical of generated boilerplate that was never filled in. — REDACTED:26
What to do
Finish or delete the methods that still raise NotImplementedError where nothing overrides them, and replace placeholder text before shipping.
Other · Code Health — Unfinished work detected by code SHAPE, not keywords, in this repository's Ruby: methods that only raise NotImplementedError or a "not implemented" error where nothing overrides them, methods that take inputs and return a constant or do nothing, dead `if false` branches, and skeleton classes most of whose methods are holes.
Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.
A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something. — backend/spec/features/admin/products/edit/taxons_spec.rb:48
`to_key` has an empty body — confirm it's an intentional no-op and not an unfinished method. — core/app/models/spree/exchange.rb:40
What to do
Clear the softer debt: re-enable or delete `xit`/`skip`ped tests, decide whether each empty method or NotImplementedError refusal is deliberate (and say so in a comment), and replace `# rubocop:disable all` with targeted, justified disables.
Maturity · Maturity — Whether the repository and its projects have a README, and whether it is substantive.
Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.
Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.
Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.
No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
What to do
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Maturity · Maturity — Whether the repository is organised deliberately: production code and tests are set apart in a way its ecosystem or the repository itself declares.
Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.
Maturity · Maturity — Whether the project's current-state documentation describes the code that exists.
Method: Every current-state document's checkable claims looked up in the tree (links, versions, and artefact counts an order of magnitude off), plus two README checks: an advertised infrastructure product with no footprint, and a module the CHANGELOG records as removed. Deterministic, no model. Advisory.
i18n/README.md links to `CONTRIBUTING.md`, but `i18n/CONTRIBUTING.md` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — i18n/README.md:105
What to do
Reconcile the README with reality: i18n/README.md links to `CONTRIBUTING.md`, but `i18n/CONTRIBUTING.md` does not exist.
Readiness · Readiness — Whether an automated pipeline builds and tests every change.
Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.
Do you agree with this assessment?
P10 · Library API & versioning10.0 / 10Exemplary○ Nothing flagged
Readiness · Readiness — For a library: a deliberate (small) public API surface and explicit semantic versioning so consumers can depend on it safely.
Method: Roslyn scan: public API surface area and semantic-versioning markers (SemVer attributes, changelog entries) for libraries; off .NET, a library is the ecosystem's publication act (an npm package that is not private and names an entry point, a PyPI distribution with a build system, a Rust library crate, a Maven/Gradle module that publishes, a Go module with no package main, a gemspec, a Composer library, a SwiftPM library product, a pub.dev or Hex package), its surface is the share of types the language's code model records as public (Rust, Swift, Java, Kotlin, Go, Dart; not measured where the model records no type visibility or, as in TypeScript, only module-level export), and its version is read from the manifest, a semver CHANGELOG, release tooling or semver git tags. Exhaustive, deterministic.
Do you agree with this assessment?
P2 · Observability7.0 / 10Strong✓ Tool-verified
Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.
Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).
Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.
No static application security testing detected. For this repository's stack, add brakeman for Rails apps, otherwise `semgrep --config=auto` or CodeQL's ruby pack as a CI step. What was searched, so you can tell an absence from a miss: the 13 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner. — REDACTED:3
What to do
Add a SAST step to CI running what this repository's stack ships: brakeman for Rails apps, otherwise `semgrep --config=auto` or CodeQL's ruby pack — so a security regression fails the build instead of landing.
Enable Dependabot/Renovate or a dependency-review gate.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.
Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.
Deployment automation exists but no readiness/liveness probes, rolling-update strategy, lifecycle hooks or migration job were evidenced — a bad release is harder to detect and reverse.
What to do
Add readiness/liveness probes and a rolling-update (or blue/green) strategy so a bad release is caught and rolled back automatically.
Add an approval/environment gate (required reviewers / protection rules) before production promotion.
Do you agree with this assessment?
P5 · DR & Backup0.0 / 10Critical✓ Tool-verified
Readiness · Readiness — Whether disaster recovery is planned and codified — backups, geo-recovery, RTO/RPO, persistence guarantees — from IaC + container manifests + docs, never the live cloud.
Method: Filesystem scan: disaster recovery, backup, geo-recovery, RTO/RPO, persistence guarantees from IaC, manifests, and docs. Exhaustive, deterministic, never a live environment.
A persistence guard (data volume / purge-protection) was found, but no backup, geo-recovery or RTO/RPO controls were evidenced — a volume that survives a container recreate is not a tested restore from catastrophic loss.
Readiness · Readiness — Whether database schema changes go through versioned migrations rather than being auto-created from the model at startup.
Method: Roslyn scan: EF Core DbContext for a versioned migrations directory versus bare EnsureCreated usage; off .NET, a file scan of dependency manifests, migration histories (Flyway, Liquibase, Alembic, Django, Rails, Prisma, TypeORM, Knex/Sequelize, golang-migrate, goose, Laravel, Doctrine, Diesel/sqlx) and schema auto-create in production source or config. Exhaustive, deterministic.
Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.
Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from each language's code model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.
Do you agree with this assessment?
R1 · Type Safety0.0 / 10Critical✓ Tool-verified
React / JS · Code Health — How much of the frontend is typed TypeScript vs untyped JavaScript.
Method: Frontend file inventory: the share of typed TypeScript vs untyped JavaScript across the source tree. Deterministic, exhaustive over frontend files.
0 typed · 177 plain JS — the untyped files are admin/app/assets/config/solidus_admin_manifest.js, admin/app/components/solidus_admin/layout/confirm/component.js, admin/app/components/solidus_admin/layout/navigation/account/component.js, admin/app/components/solidus_admin/layout/navigation/component.js, admin/app/components/solidus_admin/orders/cart/component.js, admin/app/components/solidus_admin/orders/show/address/component.js (+171 more).
What to do
Adopt TypeScript for the frontend: add a typecheck step to the build, then either type-check the existing JavaScript in place (`checkJs`/JSDoc types) or convert the highest-traffic modules first — no file is typed today, so this is an adoption, not a clean-up.
React / JS · Code Health — The share of the scored frontend lines inside a near-exact copy-pasted block of substantial extent (the D4 clone algorithm over JS/TS tokens, D-386; each line once, 10 at none and 0 at a quarter of the lines, as D4): a block is reported only where its copies still agree on most of their own identifiers and literals, or were renamed as they were pasted but kept most of their constants, and where the copies carry enough code to stand on their own or the copied extent reaches 30 lines — so a re-implementation sharing neither names nor values, and a small pasted declaration, are both found and deliberately not reported, and a clean R10 is not a claim that nothing was copied.
Method: Near-exact copy-pasted blocks of substantial extent across the frontend (the D4 clone algorithm run over JS/TS tokens). Masking finds the candidates; a block is reported when its copies still agree on most of their own identifiers and literals, or when a renamed copy still agrees on most of its constants, AND the copies carry enough code to stand on their own — or when the copied extent reaches 30 lines. So a re-implementation sharing neither names nor values, and a small pasted declaration, are deliberately not counted. Scored on the share of the scored frontend lines inside a reported copy, on the same curve as D4. Deterministic.
7 duplicated blocks under the repository root have copies in at least two of the sibling directories admin, backend, legacy_promotions, promotions, storefront — 6 of them are reported below, and 1 is counted here but not reported individually: those copies match on shape but no longer clear R10's bar for an individually reported row — either they kept neither their own names nor their values, or what was copied is too small to stand on its own (it reports near-exact duplication only, and only of substantial extent). What this row states is the concentration, which the detector measured over all 7 and which does not depend on how exactly each block's copies still match. That concentration is one structural fact, not 7 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 7 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on. — backend/app/assets/javascripts/spree/backend/views/order/details_adjustments.js:1
backend/app/assets/javascripts/spree/backend/views/order/details_adjustments.js:1 · legacy_promotions/app/assets/javascripts/spree/backend/views/order/details_adjustments.js:1 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — backend/app/assets/javascripts/spree/backend/views/order/details_adjustments.js:1
promotions/app/javascript/backend/solidus_promotions/controllers/calculator_tiers_controller.js:3 · promotions/app/javascript/backend/solidus_promotions/controllers/product_option_values_controller.js:3 — the 2 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it. — promotions/app/javascript/backend/solidus_promotions/controllers/calculator_tiers_controller.js:3
backend/app/assets/javascripts/spree/backend/views/stock/add_stock_item.js:50 · backend/app/assets/javascripts/spree/backend/views/stock/edit_stock_item_row.js:86 — the two spans are one implementation copied and then locally edited — 71 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — backend/app/assets/javascripts/spree/backend/views/stock/add_stock_item.js:50
promotions/eslint.config.mjs:8 · storefront/eslint.config.mjs:8 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — promotions/eslint.config.mjs:8
admin/eslint.config.mjs:8 · promotions/eslint.config.mjs:8 · storefront/eslint.config.mjs:8 — the 3 copies are spread across 3 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. There is one copy in each of 3 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape — one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values — and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete. — admin/eslint.config.mjs:8
backend/app/assets/javascripts/spree/backend/option_value_picker.js:7 · promotions/app/javascript/backend/solidus_promotions/web_components/option_value_picker.js:6 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — backend/app/assets/javascripts/spree/backend/option_value_picker.js:7
admin/eslint.config.mjs:6 · eslint.config.mjs:6 · promotions/eslint.config.mjs:6 · storefront/eslint.config.mjs:6 — the 4 copies are spread across 4 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. There is one copy in each of 4 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape — one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values — and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete. — admin/eslint.config.mjs:6
backend/app/assets/javascripts/spree/backend/views/cart/add_line_item_button.js:1 · backend/app/assets/javascripts/spree/backend/views/cart/empty_cart_button.js:1 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — backend/app/assets/javascripts/spree/backend/views/cart/add_line_item_button.js:1
legacy_promotions/app/assets/javascripts/spree/backend/promotions.js:4 · legacy_promotions/app/assets/javascripts/spree/backend/promotions.js:13 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — legacy_promotions/app/assets/javascripts/spree/backend/promotions.js:4
storefront/templates/app/assets/javascripts/checkout/address.js:54 · storefront/templates/app/assets/javascripts/checkout/address.js:66 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. — storefront/templates/app/assets/javascripts/checkout/address.js:54
backend/app/assets/javascripts/spree/backend/views/order/details_adjustments.js:1 · backend/app/assets/javascripts/spree/backend/views/order/details_total.js:1 · legacy_promotions/app/assets/javascripts/spree/backend/views/order/details_adjustments.js:1 — the 3 copies are spread across 3 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — backend/app/assets/javascripts/spree/backend/views/order/details_adjustments.js:1
What to do
Act on each finding's own remediation rather than one rule: the move depends on what recurs. Where the copies are executable blocks, give the shared part one home and call it from each site; where they are declarations, a listing, a specialisation already delegating to its base, or one shape repeated per entity, there is no call site and the move is a shared type, a generated set or a factory — sometimes there is nothing to extract.
React / JS · Code Health — Per-function cyclomatic/cognitive complexity from the token-level function scanner (D-386) — real branching, not a regex heuristic.
Method: Per-function cyclomatic/cognitive complexity from a token-level function scanner (real branching, not a regex heuristic), computed over every frontend function. Deterministic.
Do you agree with this assessment?
R3 · Large Files10.0 / 10Exemplary✓ Tool-verified
React / JS · Code Health — How many source files exceed the large-file threshold.
Method: Components/modules exceeding the large-file threshold, counted exhaustively across the frontend source tree. Deterministic.
Do you agree with this assessment?
R7 · Dead Code1.7 / 10Critical✓ Tool-verified
React / JS · Code Health — Files unreachable from every application/tooling/test entry point, and exports nothing imports (module-graph reachability, D-386).
Method: Dead code: files unreachable from every application/tooling/test entry point plus exports nothing imports, via module-graph reachability. Deterministic, exhaustive over the import graph.
Unreachable from the 130 application, 6 tooling and 6 test entry point(s) detected in this repo. This repository declares no build, type-check or test script, so nothing here would fail on a wrong deletion — confirm by hand that nothing loads each file (including by a path built at runtime) before removing it. An undetected custom entry would make these reachable.
no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make (×39) — REDACTED, admin/app/components/solidus_admin/ui/forms/search/component.js, admin/app/components/solidus_admin/ui/table/ransack_filter/component.js, …
What to do
Delete the dead files and unused exports — every line is maintenance cost and rebuild-estimate inflation with zero runtime value.
React / JS · Architecture — Import cycles in the module graph (D-386) — files that can only be understood and changed together.
Method: Import cycles in the module graph, detected exhaustively over JS/TS imports (the same cycle detection as the .NET coupling dimension). Deterministic.
Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.
Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.
Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.
Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.
Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.
Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether async functions that make a cancellable request accept or pass on an AbortSignal (adoption curve).
Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.
Only 0/4 async functions that make a cancellable request (fetch, axios, ky, ofetch, got, undici, node:http) accept an AbortSignal or pass one on, so a request keeps running after whatever wanted it has given up — a page navigated away from, an unmounted component, a timed-out job. Take a `signal` (or an options object that carries one) and hand it to the request; where nothing could ever cancel the call, omitting it is a deliberate choice — judge against how the function is used.
`updateCartLink` awaits `fetch(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `fetch(url, { signal })`. — storefront/templates/app/javascript/controllers/top_bar_controller.js:9
`fetchOptions` awaits `fetch(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `fetch(url, { signal })`. — admin/app/javascript/solidus_admin/tom-select/plugins/remote_with_pagination.js:20
`search` awaits `fetch(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `fetch(url, { signal })`. (×2) — admin/app/components/solidus_admin/orders/show/customer_search/component.js:6, admin/app/components/solidus_admin/orders/cart/component.js:13
What to do
Thread an AbortSignal through async functions that make requests, so the work stops when its caller gives up.
Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.
Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.
Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.
`debug` at line 116 is called with an argument built by `full_messages.join` (line 116), whose cost grows with the collection it walks. Ruby evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because debug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: no `debug?` test, no debug flag, no block the logger calls only when the level is on. — REDACTED:116
`debug` at line 24 is called with an argument built by `keys.join(".")` (line 24), whose cost grows with the collection it walks. Ruby evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because debug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: no `debug?` test, no debug flag, no block the logger calls only when the level is on. — admin/app/components/solidus_admin/base_component.rb:24
What to do
In Ruby, hand the logger a block it calls only when the level is on (`logger.debug { "args: #{args.join(' ')}" }` — Logger, ActiveSupport, SemanticLogger and console all take one), or put the line behind `if logger.debug?`. Interpolating the value into the message is not the fix: Ruby builds the string, and every `map`, `join` or `to_json` inside its `#{…}`, before the call is entered.
Do you agree with this assessment?
X24 · Document value interpolated into markup unescaped3.5 / 10Weak✓ Tool-verified
Other · Security — Whether text read out of the document being converted is escaped before it is written into generated markup — a value the document's author chose, interpolated into an attribute the surrounding literal delimits, can close that attribute and open another.
Method: Roslyn semantic model over the whole compilation: a string-typed `Value`/`InnerText`/`InnerXml`/`Text` member declared inside `DocumentFormat.OpenXml` or `System.Xml` is a taint SOURCE, propagated through assignments, returns, arguments, tuple elements and string composition to its transitive closure, then read at interpolated-string holes that sit in a markup position the surrounding literal itself delimits. Escaper/encoder calls and enclosing validator conditions cut the flow. Flow- and container-insensitive by construction. A second arm needs no provenance at all and reports a type that CONTRADICTS ITSELF — the same expression escaped at one delimited markup hole and interpolated raw at another hole in the same markup position of the same type, which the type's own escaping proves is a defect without knowing where the value came from. On a repository with no .NET source it reads JavaScript/TypeScript off the token stream with the same rule: a DOM read of raw document text (`getAttribute`, `textContent`, `innerText`, `nodeValue`) is the source, propagated through local bindings and string composition, and judged at template-literal and concatenation holes in the same two delimited markup positions; escapers and validating conditions cut it, and documentation-site, test, vendored and minified scripts are not read. Deterministic, provable per finding. Advisory.
`message` carries text this program read out of a document — an attribute or a text node, which the DOM hands back already decoded, so an entity its author wrote is a live character again — and it is written straight into the text of an element of markup built here with nothing escaping it on the way. The value is chosen by whoever authored that document, not by this program, so it can close the attribute or element it sits in and open another — a crafted document becomes markup in what this code renders. Escape `message` at this site, or validate it against the shape the position accepts before interpolating it. — admin/app/javascript/solidus_admin/web_components/solidus_select.js:63
`resultsHtml` is text this program did not author, and it is written into the text of an element through `innerHTML` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — admin/app/components/solidus_admin/ui/forms/search/component.js:94
`this.template(this.model.toJSON())` is text this program did not author, and it is written into the text of an element through `innerHTML` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — backend/app/assets/javascripts/spree/backend/views/images/upload_progress.js:30
`percent+'%'` is text this program did not author, and it is written into the text of an element through `innerHTML` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — backend/app/assets/javascripts/spree/backend/views/images/upload_progress.js:40
`content` is text this program did not author, and it is written into the text of an element through `insertAdjacentHTML` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. (×2) — promotions/app/javascript/backend/solidus_promotions/controllers/calculator_tiers_controller.js:14, promotions/app/javascript/backend/solidus_promotions/controllers/product_option_values_controller.js:15
`variantPrice` is text this program did not author, and it is written into the text of an element through `innerHTML` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — storefront/templates/app/assets/javascripts/product.js:31
`variant.dataset.price` is text this program did not author, and it is written into the text of an element through `innerHTML` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — storefront/templates/app/assets/javascripts/product_selection_component.js:84
`await response.text()` is text this program did not author, and it is written into the text of an element through `innerHTML` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — storefront/templates/app/javascript/controllers/top_bar_controller.js:11
What to do
Each finding names the expression, the attribute it lands in and the line. Confirm the value's origin from the read this analyzer traced, then escape it at the sink or validate it against the shape the attribute accepts before interpolating.
Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.
Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a walk over a `Hash` or `Set` (`each`, `each_pair`, `map`, `for … in` and the other block walks) leaves it alone — Ruby refuses `rehash`, `replace`, `compare_by_identity` and `transform_keys!` on a Hash, and `reset`, `replace`, `compare_by_identity` and `map!` on a Set, while it is being iterated: the call raises `RuntimeError` at once and the remaining entries are never seen.
Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.
Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.
Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.
`rescue` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×4) — promotions/app/patches/models/solidus_promotions/order_patch.rb:42, core/app/models/spree/order.rb:489, backend/app/controllers/spree/admin/orders_controller.rb:35, …
What to do
Swallowed exception (caught, then discarded)
Do you agree with this assessment?
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.
Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether Ruby's type checker checks nil and is not undermined by assertions — a file Sorbet reads at `# typed: true` or above, or a Steep target `check`s under its default or strict diagnostics, is one where a method call on a `T.nilable(String)` / `String?` is an error, and each `T.must`, `#: as !nil` or `# steep:ignore NoMethod` is the author telling the checker a value cannot be nil.
Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.
This repository commits no Sorbet configuration (`sorbet/config`) and no `Steepfile`, so nothing type-checks its 1201 Ruby product file(s): a nilable value reaches a method call silently and raises `NoMethodError: undefined method … for nil` the first time it is nil. A `# typed:` sigil does nothing without a `sorbet/config` beside the code; a Steep run configured only on a command line is not something this check can read.
What to do
Adopt a checker and raise it file by file: with Sorbet, `srb init` (or `bundle exec tapioca init`) commits `sorbet/config`, then move each file's sigil from `# typed: false` to `# typed: true` and on to `strict` as its methods get `sig`s — `spoom bump` does the moving; with Steep, write RBS signatures and `check` the product directories in the `Steepfile` under `D::Ruby.default` or `strict`, not `lenient`. Then pay down the assertions rather than adding to them: each `T.must` is a nil the checker could not rule out — narrow it (`return unless x`, `x&.`, `if (y = x)`), make the attribute non-nilable and set it in `initialize`, or change the method so the nil cannot arrive.
Do you agree with this assessment?
WCAG coverage — what static analysis assessed
Statically assessed 15 of 55 WCAG 2.2 Level A/AA success criteria (27%; ≈30% of the 50 WCAG 2.1 AA criteria for EN 301 549). The other 40 require runtime or manual evaluation. Partial signal only (a clean result is necessary, not sufficient; static analysis fully verifies none). This is accessibility readiness, not a conformance claim — a WCAG conformance claim requires manual evaluation (WCAG-EM 1.0).
The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.
Unscored — 1 check(s) recorded observations but carry no score
These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.
X10 Duplicated predicate — 17 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 3 control(s) we could not find positive evidence for
These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.
C3 Audit Trail — Repo shows no audit-logging mechanism (an audit-log table or model, a change-history gem on the models — paper_trail's has_paper_trail, audited, Logidze's has_logidze, public_activity's tracked — or an ActiveRecord callback or Sequel hook that records each change) for sensitive changes — absence of evidence is not evidence of a working control. Record an audit trail in code (or document where it lives) so this dimension can be scored.
C4 Data Retention — Repo shows no data-retention / TTL / cleanup mechanism for personal data — absence of evidence is not evidence of a working control. Define retention periods and a purge/cleanup job (or TTL) in code, or document where retention is enforced, so this dimension can be scored.
C5 Data-Subject Rights — Repo shows no corroborated data-subject-rights mechanism (erasure / export-portability / consent) tied to a subject id or GDPR vocabulary — absence of evidence is not evidence of a working control. Implement erasure, data export/portability and consent tracking over the subject's records.
Not included — 50 check(s) not relevant to this codebase
These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.
AX1 Captive dependencies — Not applicable: this repository's JavaScript imports no dependency-injection container and defines no container of its own — nothing that both registers and resolves bindings, and nothing that names two lifetimes — so nothing holds one lifetime's instance while handing out another's; this repository's Ruby imports no dependency-injection container and defines no container of its own — nothing that both registers and resolves bindings, and nothing that names two lifetimes — so nothing holds one lifetime's instance while handing out another's.
AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
AX7 Slice cohesion — not applicable — not a vertical-slice architecture
AX8 Test isolation — no test/production split to check
AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
AXR1 Runtime accessibility — compose up failed (exit 17 — an image could not be built) — failed to solve: process "/bin/sh -c curl -sSL https://www.postgresql.org/media/keys/ACCC4CF8.asc | apt-key add - && echo 'deb http://apt.postgresql.org/pub/repos/apt/ bookworm-pgdg main' $PG_VERSION > /etc/apt/sources.list.d/pgdg.list" did not complete successfully: exit code: 2; runtime evidence skipped This is a statement about this run, not a statement about your application: nothing here says the surface is inaccessible, only that it was never rendered.
D10 Test Quality — ~75437 lines of test source are present (.rb) but no test cases reached the test census for this repository — no test root we could resolve declared them, or the files we read declare no cases in a test framework we recognise — so skipped/assertion-free tests couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
D11 Test Reliability — Test reliability not included
D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
D19 Documentation Quality — D19 withholds "Documentation: empty section": 1 candidate(s) were measured and not published.
D21 Naming Consistency — N/A — too few peers to establish a naming convention (7448 declarations, no unit with a dominant convention).
D22 Internal API Consistency — API consistency is measured on C# only; the exposed Ruby surface was not measured.
D25 ADR Conformance — no ADRs to check
D27 Navigability — symbol resolution incomplete — navigability not assessed
D32 Data Compliance (PII/GDPR) — 1 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
D8 Code Coverage — Coverage not included — suite not readable by the collector
ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
P12 CI test-gate honesty — Reported, not scored — this card publishes what the CI gate does with the test inventory rather than grading it. The findings above are its output.
P7 Outbound HTTP resilience — no outbound HTTP usage detected — no HTTP client call or construction in the JavaScript/TypeScript, Ruby source (service entry point: storefront/templates/config/initializers/solidus_auth_devise_unauthorized_redirect.rb:1 (Rails.application))
P9 Domain vs controller coverage — coverage not measured: this check compares the coverage of the analyzer's own test run across the domain and web layers, and that run measured none here — Test coverage (D8) says why
PF1 Benchmark discipline — Not applicable: no benchmark suite was found. This check searched for `x.report(…)` entries in a `Benchmark.ips`/`bm`/`bmbm`/`benchmark`/`memory` block, `benchmark:` entries in a benchmark-driver YAML under a bench* directory, rspec-benchmark `perform_*` expectations where the gem is installed, or benchmark-ips, benchmark-memory, rspec-benchmark or benchmark-driver in a REDACTED or gemspec, and for a `*benchmark*` script that this repository's CI runs. Benchmarks are credited as a bonus, so their absence is neither scored nor deducted.
PF2 Allocation hygiene — Not scored: this check counted allocation-aware idioms (Span, pools, stackalloc) per line, which describes what kind of code a repository is rather than whether it has an allocation problem, so it was withdrawn. Nothing here is a finding about your code.
R11 Import Boundaries — No recognizable feature-sliced/layered src layout — boundary rules not applicable.
R4 Test Coverage — 6 test file(s) reach none of 171 production file(s) via imports — exercised outside the JS import graph (integration/bundled), not import-reachable
R5 Dependency Freshness — no package-lock.json — dependency freshness not measured (would require an npm lockfile); JS/npm CVEs are scored in D30 (Dependency Vulnerabilities), which answers every ecosystem
R6 Tooling — no package.json in the repository — test/lint/typecheck wiring is read from package.json scripts (corroborated against CI), so this project's own toolchain isn't measured here
R8 Dependency Hygiene — Not measured — no package.json declares any dependency, so there is nothing to check imports against (imports may resolve through a host runtime rather than node).
S1 Web-Security Posture — Not assessed: 1095 Ruby file(s) were read for weak hashes and ciphers, key material fixed in the source, disabled TLS certificate validation and obsolete TLS versions, and none was found. That half of the dimension is clean, but it is not scored on its own: a C# repository with the same clean reading is scored on its server controls as well, or is N/A for having no web surface, and neither can be decided here. The server controls — HTTPS enforcement, HSTS, cookie flags, input validation — are NOT assessed for Ruby: this reading covers the code's own cryptography and the TLS connections it opens as a client, and a Rails, Rack or Sinatra application's transport, header and validation settings are not modelled. Their absence here is not a finding about this repository.
X13 Undrained process stream — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X14 Bypassable address classification — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X15 Unvalidated length from an untrusted reader — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X17 Uncapped recursion over a caller-supplied document — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X18 Disposal-pattern correctness — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X20 Mistyped argument guard — This check asks whether an argument guard reports an EMPTY value as a NULL one, which needs a language that throws a null-specific argument exception — .NET's ArgumentNullException, the JVM's NullPointerException, Dart's ArgumentError.notNull. This repository contains none of those languages: the ones it is written in have a single exception for a bad argument, so there is no pair of exceptions to confuse and nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
X22 Contradicted release guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X26 Unsynchronised callback handoff — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X28 Index access outside its own emptiness guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
X4 Structured logging — This check asks whether log calls keep a message's values apart from its text, which needs a logger that can carry them as fields. This repository's Ruby was read, and it logs through none: the standard library's Logger, which Rails.logger is, takes one finished message and no template arguments or fields (as log4net does in C#), so an interpolated message there loses nothing the API could have kept. The console gem (`Console.info`), SemanticLogger, Ougai and dry-logger would be judged.
X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X7 Silent fallback defaults — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
Appendix A — Findings (grouped)
The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.
AC2 · Forms & labels· <label> that labels no control · ×20
<label> that labels no control admin/app/components/solidus_admin/layout/navigation/component.html.erb:25— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control admin/app/components/solidus_admin/ui/checkbox_row/component.html.erb:6— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control admin/app/components/solidus_admin/ui/checkbox_row/component.html.erb:21— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control admin/app/components/solidus_admin/ui/forms/checkbox/component.html.erb:2— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control admin/app/components/solidus_admin/ui/forms/field/component.html.erb:2— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control admin/app/components/solidus_admin/ui/forms/switch_field/component.html.erb:1— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control backend/app/views/spree/admin/adjustment_reasons/shared/_form.html.erb:14— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control backend/app/views/spree/admin/images/index.html.erb:24— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control backend/app/views/spree/admin/orders/_shipment.html.erb:20— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control backend/app/views/spree/admin/orders/customer_details/_form.html.erb:24— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control backend/app/views/spree/admin/orders/customer_details/_form.html.erb:30— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control backend/app/views/spree/admin/orders/customer_details/_form.html.erb:42— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control backend/app/views/spree/admin/orders/customer_details/_form.html.erb:71— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control backend/app/views/spree/admin/payment_methods/_form.html.erb:42— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control backend/app/views/spree/admin/payment_methods/_form.html.erb:48— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control backend/app/views/spree/admin/payment_methods/_form.html.erb:54— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control backend/app/views/spree/admin/payments/_form.html.erb:12— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control backend/app/views/spree/admin/payments/_form.html.erb:16— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control backend/app/views/spree/admin/payments/source_forms/_gateway.html.erb:7— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control backend/app/views/spree/admin/payments/source_forms/_gateway.html.erb:9— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
AC2 · Forms & labels· <input> without a programmatic label · ×4
<input> without a programmatic label admin/app/components/solidus_admin/ui/table/ransack_filter/component.html.erb:32— This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
<input> without a programmatic label backend/app/assets/javascripts/spree/backend/templates/orders/line_item.hbs:23— This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
<input> without a programmatic label backend/app/assets/javascripts/spree/backend/templates/orders/shipment_tracking.hbs:7— This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
<input> without a programmatic label backend/app/assets/javascripts/spree/backend/templates/variants/split.hbs:21— This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
AC1 · Text alternatives· <img> without a text alternative · ×3
<img> without a text alternative backend/app/assets/javascripts/spree/backend/templates/products/upload_progress.hbs:2— An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
<img> without a text alternative backend/app/views/spree/admin/style_guide/topics/tables/_building_tables.html.erb:18— An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
<img> without a text alternative backend/app/views/spree/admin/style_guide/topics/tables/_building_tables.html.erb:40— An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
AC2 · Forms & labels· <select> without a programmatic label · ×2
<select> without a programmatic label backend/app/assets/javascripts/spree/backend/templates/orders/shipping_method.hbs:8— This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
<select> without a programmatic label backend/app/assets/javascripts/spree/backend/templates/variants/split.hbs:5— This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
<html> without a lang admin/app/views/layouts/solidus_admin/preview.html.erb:2— The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
<html> without a lang core/app/views/layouts/spree/base_mailer.html.erb:2— The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
AC3 · Page structure· Document without a <title> · ×2
Document without a <title> admin/app/views/layouts/solidus_admin/preview.html.erb:2— A page with no <title> gives no name in the tab, history or screen-reader page list. Add a descriptive <title> in <head>.
Document without a <title> core/app/views/layouts/spree/base_mailer.html.erb:2— A page with no <title> gives no name in the tab, history or screen-reader page list. Add a descriptive <title> in <head>.
AC5 · ARIA correctness· aria-hidden on a focusable element · ×1
aria-hidden on a focusable element admin/app/components/solidus_admin/ui/modal/component.html.erb:9— aria-hidden="true" hides the element from assistive tech but leaves it keyboard-focusable — a confusing dead stop. Remove aria-hidden or make the element non-focusable.
AC5 · ARIA correctness· aria-hidden hides a focusable element · ×1
aria-hidden hides a focusable element backend/app/views/spree/admin/shared/_modal.html.erb:1— aria-hidden="true" here hides the subtree from assistive tech, but a focusable descendant stays in the tab order — a keyboard user can land on a control screen readers can't see. Add inert, take the descendants out of the tab order (tabindex="-1"), or drop aria-hidden.
Orphaned knowledge core/db/migrate/20160101010000_solidus_one_four.rb:1— No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
Serious — 306 finding(s)
AC3 · Page structure· Data table has no header cells · ×23
Data table has no header cells backend/app/views/spree/admin/stock_items/_stock_management.html.erb:37— A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
Data table has no header cells backend/app/views/spree/admin/stock_items/_stock_management.html.erb:53— A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
Data table has no header cells backend/app/views/spree/admin/stock_items/_stock_management.html.erb:65— A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
Data table has no header cells backend/app/views/spree/admin/store_credits/show.html.erb:17— A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
Data table has no header cells core/app/views/layouts/spree/base_mailer.html.erb:753— A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
Data table has no header cells core/app/views/layouts/spree/base_mailer.html.erb:758— A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
Data table has no header cells core/app/views/layouts/spree/base_mailer.html.erb:761— A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
Data table has no header cells core/app/views/layouts/spree/base_mailer.html.erb:764— A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
Data table has no header cells core/app/views/spree/carton_mailer/shipped_email.html.erb:1— A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
Data table has no header cells core/app/views/spree/carton_mailer/shipped_email.html.erb:13— A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
Data table has no header cells core/app/views/spree/order_mailer/cancel_email.html.erb:1— A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
Data table has no header cells core/app/views/spree/order_mailer/cancel_email.html.erb:13— A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
Data table has no header cells core/app/views/spree/order_mailer/confirm_email.html.erb:1— A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
Data table has no header cells core/app/views/spree/order_mailer/confirm_email.html.erb:13— A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
Data table has no header cells core/app/views/spree/order_mailer/inventory_cancellation_email.html.erb:1— A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
Data table has no header cells core/app/views/spree/order_mailer/inventory_cancellation_email.html.erb:13— A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
Data table has no header cells core/app/views/spree/reimbursement_mailer/reimbursement_email.html.erb:1— A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
Data table has no header cells core/app/views/spree/reimbursement_mailer/reimbursement_email.html.erb:20— A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
Data table has no header cells legacy_promotions/app/views/spree/order_mailer/cancel_email.html.erb:1— A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
Data table has no header cells legacy_promotions/app/views/spree/order_mailer/cancel_email.html.erb:13— A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
Data table has no header cells legacy_promotions/app/views/spree/order_mailer/confirm_email.html.erb:1— A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
Data table has no header cells legacy_promotions/app/views/spree/order_mailer/confirm_email.html.erb:13— A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
Data table has no header cells storefront/templates/app/views/products/_product_properties.html.erb:8— A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
AC2 · Forms & labels· <fieldset> without a <legend> · ×14
<fieldset> without a <legend> admin/app/components/solidus_admin/ui/table/ransack_filter/component.html.erb:1— A fieldset groups related controls but has no <legend> to name the group. Add a <legend> as its first child — or, if the group already has a visible caption beside it (or the fieldset is there only to disable its subtree and carries no group box), point aria-labelledby at that caption's id instead, which names the group without rendering a second one.
<fieldset> without a <legend> backend/app/assets/javascripts/spree/backend/templates/variants/line_items_autocomplete_stock.hbs:1— A fieldset groups related controls but has no <legend> to name the group. Add a <legend> as its first child — or, if the group already has a visible caption beside it (or the fieldset is there only to disable its subtree and carries no group box), point aria-labelledby at that caption's id instead, which names the group without rendering a second one.
<fieldset> without a <legend> backend/app/views/spree/admin/adjustment_reasons/edit.html.erb:11— A fieldset groups related controls but has no <legend> to name the group. Add a <legend> as its first child — or, if the group already has a visible caption beside it (or the fieldset is there only to disable its subtree and carries no group box), point aria-labelledby at that caption's id instead, which names the group without rendering a second one.
<fieldset> without a <legend> backend/app/views/spree/admin/adjustment_reasons/new.html.erb:14— A fieldset groups related controls but has no <legend> to name the group. Add a <legend> as its first child — or, if the group already has a visible caption beside it (or the fieldset is there only to disable its subtree and carries no group box), point aria-labelledby at that caption's id instead, which names the group without rendering a second one.
<fieldset> without a <legend> backend/app/views/spree/admin/adjustments/edit.html.erb:11— A fieldset groups related controls but has no <legend> to name the group. Add a <legend> as its first child — or, if the group already has a visible caption beside it (or the fieldset is there only to disable its subtree and carries no group box), point aria-labelledby at that caption's id instead, which names the group without rendering a second one.
<fieldset> without a <legend> backend/app/views/spree/admin/adjustments/new.html.erb:12— A fieldset groups related controls but has no <legend> to name the group. Add a <legend> as its first child — or, if the group already has a visible caption beside it (or the fieldset is there only to disable its subtree and carries no group box), point aria-labelledby at that caption's id instead, which names the group without rendering a second one.
<fieldset> without a <legend> backend/app/views/spree/admin/customer_returns/edit.html.erb:38— A fieldset groups related controls but has no <legend> to name the group. Add a <legend> as its first child — or, if the group already has a visible caption beside it (or the fieldset is there only to disable its subtree and carries no group box), point aria-labelledby at that caption's id instead, which names the group without rendering a second one.
<fieldset> without a <legend> backend/app/views/spree/admin/customer_returns/new.html.erb:13— A fieldset groups related controls but has no <legend> to name the group. Add a <legend> as its first child — or, if the group already has a visible caption beside it (or the fieldset is there only to disable its subtree and carries no group box), point aria-labelledby at that caption's id instead, which names the group without rendering a second one.
<fieldset> without a <legend> backend/app/views/spree/admin/orders/confirm/_customer_details.html.erb:6— A fieldset groups related controls but has no <legend> to name the group. Add a <legend> as its first child — or, if the group already has a visible caption beside it (or the fieldset is there only to disable its subtree and carries no group box), point aria-labelledby at that caption's id instead, which names the group without rendering a second one.
<fieldset> without a <legend> backend/app/views/spree/admin/orders/customer_details/_form.html.erb:1— A fieldset groups related controls but has no <legend> to name the group. Add a <legend> as its first child — or, if the group already has a visible caption beside it (or the fieldset is there only to disable its subtree and carries no group box), point aria-labelledby at that caption's id instead, which names the group without rendering a second one.
<fieldset> without a <legend> backend/app/views/spree/admin/payment_methods/edit.html.erb:14— A fieldset groups related controls but has no <legend> to name the group. Add a <legend> as its first child — or, if the group already has a visible caption beside it (or the fieldset is there only to disable its subtree and carries no group box), point aria-labelledby at that caption's id instead, which names the group without rendering a second one.
<fieldset> without a <legend> backend/app/views/spree/admin/payment_methods/new.html.erb:14— A fieldset groups related controls but has no <legend> to name the group. Add a <legend> as its first child — or, if the group already has a visible caption beside it (or the fieldset is there only to disable its subtree and carries no group box), point aria-labelledby at that caption's id instead, which names the group without rendering a second one.
<fieldset> without a <legend> backend/app/views/spree/admin/payments/credit.html.erb:8— A fieldset groups related controls but has no <legend> to name the group. Add a <legend> as its first child — or, if the group already has a visible caption beside it (or the fieldset is there only to disable its subtree and carries no group box), point aria-labelledby at that caption's id instead, which names the group without rendering a second one.
<fieldset> without a <legend> backend/app/views/spree/admin/payments/new.html.erb:13— A fieldset groups related controls but has no <legend> to name the group. Add a <legend> as its first child — or, if the group already has a visible caption beside it (or the fieldset is there only to disable its subtree and carries no group box), point aria-labelledby at that caption's id instead, which names the group without rendering a second one.
TodoComment core/spec/models/spree/ability_spec.rb:130— # TODO: change the Ability class so only users and customers get the extra premissions? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment core/spec/models/spree/order_shipping_spec.rb:230— # TODO: We can remove this once Shipment#ship! is called by — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment core/spec/models/spree/payment_spec.rb:232— # TODO: Is this really what we want to happen in this case? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment core/lib/spree/testing_support/order_walkthrough.rb:67— # TODO: maybe look at some way of making this payment_state change automatic — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment core/lib/spree/testing_support/factories/order_factory.rb:16— # TODO: Improve the name of order_with_totals factory. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment core/db/migrate/20180710170104_create_spree_store_credit_reasons_table.rb:27— # TODO: table spree_store_credit_update_reasons and column — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment core/app/models/spree/order_inventory.rb:103— # TODO: exclude all 'shipped' states — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment core/app/models/spree/order_shipping.rb:43— # TODO: Remove the `|| shipment.tracking` once Shipment#ship! is called by — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment core/app/models/spree/shipment.rb:24— # TODO: remove the suppress_mailer temporary variable once we are calling 'ship' — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment backend/app/controllers/spree/admin/resource_controller.rb:89— # TODO : create a global set_list_position on all concerned objects — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment backend/app/controllers/spree/admin/search_controller.rb:9— # TODO: Clean this up by moving searching out to user_class_extensions — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment api/config/routes.rb:15— # TODO: Use shallow option on Solidus v4.0 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment api/config/routes.rb:20— # TODO: Use only: :index on Solidus v4.0 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
Low cohesion: Order (LCOM4 30) core/app/models/spree/order.rb:21— Order's methods fall into 30 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 30 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: Shipment (LCOM4 9) core/app/models/spree/shipment.rb:6— Shipment's methods fall into 9 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 9 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: BaseController (LCOM4 8) api/app/controllers/spree/api/base_controller.rb:7— BaseController's methods fall into 8 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 8 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: CheckoutsController (LCOM4 7) storefront/templates/app/controllers/checkouts_controller.rb:7— CheckoutsController's methods fall into 7 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 7 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: StoreDeviseController (LCOM4 7) storefront/templates/app/controllers/store_devise_controller.rb:3— StoreDeviseController's methods fall into 7 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 7 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: OrdersController (LCOM4 5) storefront/templates/app/controllers/solidus_paypal_commerce_platform/orders_controller.rb:4— OrdersController's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: OrdersController (LCOM4 4) REDACTED:5— OrdersController's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: CustomerReturnsController (LCOM4 4) REDACTED:5— CustomerReturnsController's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: ProductsController (LCOM4 4) REDACTED:5— ProductsController's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: VariantsController (LCOM4 4) REDACTED:5— VariantsController's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: LineItem (LCOM4 4) core/app/models/spree/line_item.rb:12— LineItem's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
AC4 · Keyboard semantics· Anchor without href · ×10
Anchor without href backend/app/views/spree/admin/shared/_navigation_footer_fallback.html.erb:15— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href REDACTED:2— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href REDACTED:2— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href REDACTED:10— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href legacy_promotions/lib/views/backend/spree/admin/promotions/calculators/tiered_flat_rate/_fields.html.erb:28— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href legacy_promotions/lib/views/backend/spree/admin/promotions/calculators/tiered_percent/_fields.html.erb:28— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href promotions/lib/views/backend/solidus_promotions/admin/calculator_fields/tiered_flat_rate/_tier_fields.html.erb:29— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href promotions/lib/views/backend/solidus_promotions/admin/calculator_fields/tiered_percent/_tier_fields.html.erb:31— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href promotions/lib/views/backend/solidus_promotions/admin/calculator_fields/tiered_percent_on_eligible_item_quantity/_tier_fields.html.erb:33— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
Anchor without href promotions/lib/views/backend/solidus_promotions/admin/condition_fields/line_item_option_value/_option_value_fields.html.erb:25— An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
X24 · Document value interpolated into markup unescaped· Untrusted text written into markup unescaped · ×8
Untrusted text written into markup unescaped admin/app/components/solidus_admin/ui/forms/search/component.js:94— `resultsHtml` is text this program did not author, and it is written into the text of an element through `innerHTML` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped backend/app/assets/javascripts/spree/backend/views/images/upload_progress.js:30— `this.template(this.model.toJSON())` is text this program did not author, and it is written into the text of an element through `innerHTML` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped backend/app/assets/javascripts/spree/backend/views/images/upload_progress.js:40— `percent+'%'` is text this program did not author, and it is written into the text of an element through `innerHTML` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped promotions/app/javascript/backend/solidus_promotions/controllers/calculator_tiers_controller.js:14— `content` is text this program did not author, and it is written into the text of an element through `insertAdjacentHTML` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped promotions/app/javascript/backend/solidus_promotions/controllers/product_option_values_controller.js:15— `content` is text this program did not author, and it is written into the text of an element through `insertAdjacentHTML` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped storefront/templates/app/assets/javascripts/product.js:31— `variantPrice` is text this program did not author, and it is written into the text of an element through `innerHTML` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped storefront/templates/app/assets/javascripts/product_selection_component.js:84— `variant.dataset.price` is text this program did not author, and it is written into the text of an element through `innerHTML` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped storefront/templates/app/javascript/controllers/top_bar_controller.js:11— `await response.text()` is text this program did not author, and it is written into the text of an element through `innerHTML` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
AC6 · Visual & motion safety· Focus outline removed in CSS without a · ×6
Focus outline removed in CSS without a :focus replacement storefront/templates/app/assets/stylesheets/application.tailwind.css:44— `.text-input input` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement storefront/templates/app/assets/stylesheets/application.tailwind.css:58— `.select-input select` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement storefront/templates/app/assets/stylesheets/application.tailwind.css:89— `.theme-switcher` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement backend/app/assets/stylesheets/spree/backend/components/_navigation.scss:45— `#admin-nav-toggle.fa:focus` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement backend/app/assets/stylesheets/spree/backend/components/_navigation_solidus_admin.scss:204— `.solidus-admin--nav--footer summary` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement backend/app/assets/stylesheets/spree/backend/components/_switch_solidus_admin.scss:14— `.solidus-admin--nav--switch:focus` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
D4 · Code Duplication· Edited copy of a member (6 corresponding lines) · ×6
Edited copy of a member (6 corresponding lines) legacy_promotions/app/models/spree/calculator/tiered_percent.rb:46— legacy_promotions/app/models/spree/calculator/tiered_percent.rb:46-55 | promotions/app/models/solidus_promotions/calculators/tiered_percent.rb:126-131 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (6 corresponding lines) REDACTED:77— REDACTED:77-82 | core/app/models/spree/payment_method/simple_bogus_credit_card.rb:31-37 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (6 corresponding lines) admin/app/components/solidus_admin/orders/index/component.rb:171— admin/app/components/solidus_admin/orders/index/component.rb:171-176 | admin/app/components/solidus_admin/users/orders/component.rb:85-90 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (6 corresponding lines) admin/app/components/solidus_admin/orders/index/component.rb:180— admin/app/components/solidus_admin/orders/index/component.rb:180-185 | admin/app/components/solidus_admin/users/orders/component.rb:94-99 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (6 corresponding lines) legacy_promotions/app/models/spree/promotion.rb:214— legacy_promotions/app/models/spree/promotion.rb:214-219 | promotions/app/models/solidus_promotions/promotion.rb:106-111 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (6 corresponding lines) REDACTED:47— REDACTED:47-52 | REDACTED:36-41 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (8 lines × 2) core/db/migrate/20250129061658_add_metadata_to_spree_resources.rb:18— core/db/migrate/20250129061658_add_metadata_to_spree_resources.rb:18-25 | core/db/migrate/20250221152004_add_metadata_to_users.rb:4-11 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (8 lines × 2) core/db/default/spree/stores.rb:3— core/db/default/spree/stores.rb:3-10 | sample/db/samples/stores.rb:3-10 — before extracting anything, compare `core/db/default/spree/stores.rb` and `sample/db/samples/stores.rb` as WHOLE FILES: 100% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (8 lines × 2) legacy_promotions/app/models/spree/promotion/rules/first_order.rb:14— legacy_promotions/app/models/spree/promotion/rules/first_order.rb:14-21 | promotions/app/models/solidus_promotions/conditions/first_order.rb:12-19 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (8 lines × 2) legacy_promotions/lib/components/admin/solidus_admin/promotion_categories/index/component.rb:49— legacy_promotions/lib/components/admin/solidus_admin/promotion_categories/index/component.rb:49-56 | promotions/lib/components/admin/solidus_promotions/promotion_categories/index/component.rb:49-56 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (8 lines × 2) legacy_promotions/lib/components/admin/solidus_admin/promotion_categories/index/component.rb:60— legacy_promotions/lib/components/admin/solidus_admin/promotion_categories/index/component.rb:60-67 | promotions/lib/components/admin/solidus_promotions/promotion_categories/index/component.rb:60-67 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (8 lines × 2) core/lib/spree/testing_support/shared_examples/calculator.rb:3— core/lib/spree/testing_support/shared_examples/calculator.rb:3-10 | promotions/lib/solidus_promotions/testing_support/shared_examples/promotion_calculator.rb:3-11 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (12 lines × 2) admin/lib/solidus_admin/install_tailwindcss.rb:20— admin/lib/solidus_admin/install_tailwindcss.rb:20-31 | admin/lib/solidus_admin/testing_support/dummy_app/rake_tasks.rb:12-23 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `admin/lib/solidus_admin/install_tailwindcss.rb:20` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) core/db/migrate/20160101010000_solidus_one_four.rb:457— core/db/migrate/20160101010000_solidus_one_four.rb:457-468 | core/db/migrate/20160101010000_solidus_one_four.rb:488-499 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (12 lines × 2) legacy_promotions/app/models/spree/promotion/rules/first_repeat_purchase_since.rb:12— legacy_promotions/app/models/spree/promotion/rules/first_repeat_purchase_since.rb:12-31 | promotions/app/models/solidus_promotions/conditions/first_repeat_purchase_since.rb:17-28 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (12 lines × 2) core/app/models/spree/in_memory_order_updater.rb:103— core/app/models/spree/in_memory_order_updater.rb:103-114 | core/app/models/spree/order_updater.rb:79-90 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (12 lines × 2) core/app/models/spree/in_memory_order_updater.rb:196— core/app/models/spree/in_memory_order_updater.rb:196-207 | core/app/models/spree/order_updater.rb:231-242 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
AC3 · Page structure· Page without a main landmark · ×4
Page without a main landmark admin/app/views/layouts/solidus_admin/preview.html.erb:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark backend/app/views/spree/layouts/admin.html.erb:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark backend/app/views/spree/layouts/admin_style_guide.html.erb:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark core/app/views/layouts/spree/base_mailer.html.erb:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
FixmeComment core/spec/models/spree/variant/scopes_spec.rb:50— # FIXME leaky database - too many line_items — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment core/app/models/spree/payment_create.rb:89— # FIXME: does this work? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment core/app/models/spree/variant/scopes.rb:8— # FIXME: WARNING tested only under sqlite and postgresql — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment admin/spec/features/product_spec.rb:139— # FIXME: There is some kind of minor issue with this form that prevents — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TooManyMethods: Order core/app/models/spree/order.rb:21— TooManyMethods — 106 methods. The bar is 30 methods; this is 76 over it, 3.53× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: Shipment core/app/models/spree/shipment.rb:6— TooManyMethods — 46 methods. The bar is 30 methods; this is 16 over it, 1.53× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: Variant core/app/models/spree/variant.rb:18— TooManyMethods — 40 methods. The bar is 30 methods; this is 10 over it, 1.33× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ResourceController backend/app/controllers/spree/admin/resource_controller.rb:3— TooManyMethods — 32 methods. The bar is 30 methods; this is 2 over it, 1.07× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
Change coupling: adjust_line_item.rb ↔ adjust_shipment.rb promotions/app/models/solidus_promotions/benefits/adjust_line_item.rb:1— `promotions/app/models/solidus_promotions/benefits/adjust_line_item.rb` and `promotions/app/models/solidus_promotions/benefits/adjust_shipment.rb` change together 91% of the time (10 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency between them. They sit in the same directory, but in this ecosystem each file is its own module — a sibling reference still needs an import — so the missing import edge is real: the coupling runs through shared behaviour, not a declared dependency. If they duplicate structure, extract the common part into one unit; otherwise the coupling is hidden and worth breaking. You can check this without leaving the row: of the 10 shared commits counted here, the most recent 3 are `c08738a4` Change condition configuration to be flat; `ac699f3b` Change promotion system to use adjustments; `40204d02` Change Benefit#discount to dynamically call methods on benefits — run `git show` on any of them.
Change coupling: component.rb ↔ menu_item.rb admin/app/components/solidus_admin/layout/navigation/item/component.rb:1— `admin/app/components/solidus_admin/layout/navigation/item/component.rb` and `admin/lib/solidus_admin/menu_item.rb` change together 75% of the time (9 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 9 shared commits counted here, the most recent 3 are `67f99c59` Rename SolidusAdmin::MainNavItem to SolidusAdmin::MenuItem; `b0c39ca4` Mark the current admin link in the main mav for accessibility (at that commit the files were still `admin/app/components/solidus_admin/sidebar/item/component.rb` and `admin/lib/solidus_admin/main_nav_item.rb`); `cc7ed6e5` Use a context object to resolve admin man nav components (at that commit the files were still `admin/app/components/solidus_admin/sidebar/item/component.rb` and `admin/lib/solidus_admin/main_nav_item.rb`) — run `git show` on any of them.
Change coupling: REDACTED ↔ routes.rb REDACTED:1— `REDACTED` and `admin/config/routes.rb` change together 64% of the time (7 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `07a2d3a4` Move store_credits actions to their own controller; `9f24cce8` Add new users admin store credits page; `214ce640` Add new users admin items page — run `git show` on any of them.
Change coupling: REDACTED ↔ routes.rb REDACTED:1— `REDACTED` and `admin/config/routes.rb` change together 50% of the time (6 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `0517f293` Add new admin store credits create flow; `c734f99c` Add new admin store credits invalidate flow; `9639966e` Add new admin store credits edit_memo flow — run `git show` on any of them.
D4 · Code Duplication· Edited copy of a member (9 corresponding lines) · ×4
Edited copy of a member (9 corresponding lines) core/db/migrate/20250129061658_add_metadata_to_spree_resources.rb:6— core/db/migrate/20250129061658_add_metadata_to_spree_resources.rb:6-26 | core/db/migrate/20250221152004_add_metadata_to_users.rb:3-11 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) REDACTED:35— REDACTED:35-44 | REDACTED:38-46 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) legacy_promotions/lib/components/admin/solidus_legacy_promotions/orders/index/component.rb:5— legacy_promotions/lib/components/admin/solidus_legacy_promotions/orders/index/component.rb:5-13 | promotions/lib/components/admin/solidus_promotions/orders/index/component.rb:5-13 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) REDACTED:7— REDACTED:7-17 | REDACTED:23-31 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (4 corresponding lines) · ×4
Edited copy of a member (4 corresponding lines) REDACTED:119— REDACTED:119-122 | backend/app/controllers/spree/admin/users_controller.rb:77-85 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (4 corresponding lines) admin/app/components/concerns/solidus_admin/products/form_options.rb:9— admin/app/components/concerns/solidus_admin/products/form_options.rb:9-12 | admin/app/components/solidus_admin/products/show/categories/new/component.rb:12-15 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (4 corresponding lines) backend/app/controllers/spree/admin/cancellations_controller.rb:37— backend/app/controllers/spree/admin/cancellations_controller.rb:37-40 | backend/app/controllers/spree/admin/orders_controller.rb:170-173 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (4 corresponding lines) promotions/app/models/solidus_promotions/conditions/line_item_option_value.rb:12— promotions/app/models/solidus_promotions/conditions/line_item_option_value.rb:12-15 | promotions/app/models/solidus_promotions/conditions/price_option_value.rb:9-12 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 12+ corresponding lines) · ×4
Edited copies of one member (3 members, 12+ corresponding lines) core/db/migrate/20250708120317_add_adjustment_reason_foreign_keys.rb:13— core/db/migrate/20250708120317_add_adjustment_reason_foreign_keys.rb:13-24 | core/db/migrate/20250709084513_add_state_foreign_keys.rb:13-24 | core/db/migrate/20250726220709_add_fk_to_customer_return.rb:13-24 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 12 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Edited copies of one member (3 members, 12+ corresponding lines) core/db/migrate/20250530102541_add_addressbook_foreign_key.rb:12— core/db/migrate/20250530102541_add_addressbook_foreign_key.rb:12-23 | core/db/migrate/20250604072105_add_fk_products_variant_property_rules.rb:13-24 | core/db/migrate/20250626112117_add_foreign_key_to_spree_role_users.rb:13-24 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 12 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Edited copies of one member (3 members, 12+ corresponding lines) REDACTED:38— REDACTED:38-49 | REDACTED:43-54 | REDACTED:70-81 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 12 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Edited copies of one member (3 members, 12+ corresponding lines) admin/app/components/solidus_admin/orders/index/component.rb:118— admin/app/components/solidus_admin/orders/index/component.rb:118-129 | admin/app/components/solidus_admin/users/items/component.rb:102-114 | admin/app/components/solidus_admin/users/orders/component.rb:52-63 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 12 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Duplicated block (5 lines × 2) REDACTED:43— REDACTED:43-47 | REDACTED:53-57 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (5 lines × 2) REDACTED:78— REDACTED:78-82 | core/app/models/spree/payment_method/simple_bogus_credit_card.rb:33-37 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (5 lines × 2) legacy_promotions/app/models/spree/promotion.rb:195— legacy_promotions/app/models/spree/promotion.rb:195-199 | promotions/app/models/solidus_promotions/promotion.rb:98-102 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (5 lines × 2) core/app/models/spree/in_memory_order_updater.rb:173— core/app/models/spree/in_memory_order_updater.rb:173-177 | core/app/models/spree/order_updater.rb:175-179 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Dead file (~9 LoC) admin/app/components/solidus_admin/orders/show/address/component.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~9 LoC) admin/app/components/solidus_admin/ui/forms/search_field/component.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~9 LoC) admin/app/javascript/solidus_admin/controllers/application.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~9 LoC) promotions/app/javascript/backend/solidus_promotions/controllers/application.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
X2 · Cancellation propagation· Async function without AbortSignal · ×4
Async function without AbortSignal: updateCartLink storefront/templates/app/javascript/controllers/top_bar_controller.js:9— `updateCartLink` awaits `fetch(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `fetch(url, { signal })`.
Async function without AbortSignal: fetchOptions admin/app/javascript/solidus_admin/tom-select/plugins/remote_with_pagination.js:20— `fetchOptions` awaits `fetch(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `fetch(url, { signal })`.
Async function without AbortSignal: search admin/app/components/solidus_admin/orders/show/customer_search/component.js:6— `search` awaits `fetch(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `fetch(url, { signal })`.
Async function without AbortSignal: search admin/app/components/solidus_admin/orders/cart/component.js:13— `search` awaits `fetch(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `fetch(url, { signal })`.
Swallowed exception (caught, then discarded) promotions/app/patches/models/solidus_promotions/order_patch.rb:42— `rescue` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) core/app/models/spree/order.rb:489— `rescue` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) backend/app/controllers/spree/admin/orders_controller.rb:35— `rescue` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) backend/app/controllers/spree/admin/orders_controller.rb:43— `rescue` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
AC4 · Keyboard semantics· Modal dialog does not manage focus · ×3
Modal dialog does not manage focus admin/app/components/solidus_admin/ui/alert/component.html.erb:1— This <div role="dialog"> is a modal dialog, but nothing moves focus into it when it opens and nothing keeps focus inside it while it is open, so a keyboard or screen-reader user keeps acting on the content behind it (WCAG 2.4.3). Use a native <dialog> opened with showModal(), a dialog component that traps focus, or move focus to the dialog on open, trap Tab inside it (or make the page behind inert) and return focus to the control that opened it on close.
Modal dialog does not manage focus admin/app/components/solidus_admin/ui/toast/component.html.erb:1— This <div role="dialog"> is a modal dialog, but nothing moves focus into it when it opens and nothing keeps focus inside it while it is open, so a keyboard or screen-reader user keeps acting on the content behind it (WCAG 2.4.3). Use a native <dialog> opened with showModal(), a dialog component that traps focus, or move focus to the dialog on open, trap Tab inside it (or make the page behind inert) and return focus to the control that opened it on close.
Modal dialog does not manage focus backend/app/views/spree/admin/shared/_modal.html.erb:1— This <div role="dialog"> is a modal dialog, but nothing moves focus into it when it opens and nothing keeps focus inside it while it is open, so a keyboard or screen-reader user keeps acting on the content behind it (WCAG 2.4.3). Use a native <dialog> opened with showModal(), a dialog component that traps focus, or move focus to the dialog on open, trap Tab inside it (or make the page behind inert) and return focus to the control that opened it on close.
D4 · Code Duplication· Edited copy of a member (8 corresponding lines) · ×3
Edited copy of a member (8 corresponding lines) admin/app/components/solidus_admin/ui/forms/address/fieldsets/contact/component.rb:5— admin/app/components/solidus_admin/ui/forms/address/fieldsets/contact/component.rb:5-14 | admin/app/components/solidus_admin/ui/forms/address/fieldsets/location/component.rb:5-12 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) legacy_promotions/app/models/spree/promotion_code.rb:31— legacy_promotions/app/models/spree/promotion_code.rb:31-38 | promotions/app/models/solidus_promotions/promotion_code.rb:32-39 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) legacy_promotions/app/models/spree/promotion.rb:69— legacy_promotions/app/models/spree/promotion.rb:69-77 | promotions/app/models/solidus_promotions/promotion.rb:83-90 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (12 corresponding lines) · ×3
Edited copy of a member (12 corresponding lines) REDACTED:46— REDACTED:46-57 | REDACTED:69-80 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (12 corresponding lines) legacy_promotions/lib/controllers/backend/spree/admin/promotions_controller.rb:82— legacy_promotions/lib/controllers/backend/spree/admin/promotions_controller.rb:82-93 | promotions/lib/controllers/backend/solidus_promotions/admin/promotions_controller.rb:40-52 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (12 corresponding lines) REDACTED:9— REDACTED:9-21 | REDACTED:11-22 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (10 corresponding lines) · ×3
Edited copy of a member (10 corresponding lines) promotions/app/models/solidus_promotions/calculators/tiered_percent.rb:93— promotions/app/models/solidus_promotions/calculators/tiered_percent.rb:93-103 | promotions/app/models/solidus_promotions/calculators/tiered_percent_on_eligible_item_quantity.rb:88-97 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (10 corresponding lines) core/app/models/spree/tax_calculator/default.rb:87— core/app/models/spree/tax_calculator/default.rb:87-97 | core/app/models/spree/tax_calculator/shipping_rate.rb:31-40 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (10 corresponding lines) core/app/models/spree/simple_order_contents.rb:38— core/app/models/spree/simple_order_contents.rb:38-47 | legacy_promotions/app/models/spree/order_contents.rb:8-22 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (3 corresponding lines) · ×3
Edited copy of a member (3 corresponding lines) REDACTED:113— REDACTED:113-115 | backend/app/controllers/spree/admin/users_controller.rb:71-73 — These two members are one piece of code written twice and then edited apart: 3 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (3 corresponding lines) backend/app/controllers/spree/admin/shipping_methods_controller.rb:58— backend/app/controllers/spree/admin/shipping_methods_controller.rb:58-60 | backend/app/controllers/spree/admin/tax_rates_controller.rb:26-28 — These two members are one piece of code written twice and then edited apart: 3 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (3 corresponding lines) REDACTED:29— REDACTED:29-31 | api/app/controllers/spree/api/return_authorizations_controller.rb:22-24 — These two members are one piece of code written twice and then edited apart: 3 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (7 lines × 2) legacy_promotions/lib/components/admin/solidus_admin/promotions/index/component.rb:41— legacy_promotions/lib/components/admin/solidus_admin/promotions/index/component.rb:41-47 | promotions/lib/components/admin/solidus_promotions/promotions/index/component.rb:41-47 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (7 lines × 2) legacy_promotions/app/models/spree/promotion/rules/item_total.rb:35— legacy_promotions/app/models/spree/promotion/rules/item_total.rb:35-41 | promotions/app/models/solidus_promotions/conditions/item_total.rb:33-39 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (7 lines × 2) core/db/migrate/20160101010000_solidus_one_four.rb:209— core/db/migrate/20160101010000_solidus_one_four.rb:209-215 | core/db/migrate/20160101010000_solidus_one_four.rb:583-589 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Dead file (~37 LoC) admin/app/components/solidus_admin/orders/cart/component.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~37 LoC) REDACTED— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~37 LoC) promotions/app/javascript/backend/solidus_promotions/controllers/calculator_tiers_controller.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~12 LoC) admin/app/javascript/solidus_admin/controllers/custom_validity_controller.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~12 LoC) admin/app/javascript/solidus_admin/controllers/details_click_outside_controller.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~12 LoC) promotions/app/javascript/backend/solidus_promotions/web_components/product_picker.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
AC6 · Visual & motion safety· Animation without a prefers-reduced-motion guard · ×2
Animation without a prefers-reduced-motion guard backend/app/assets/stylesheets/spree/backend/components/_navigation.scss:41— `#admin-nav-toggle.fa:before` moves (`transition: transform .5s ease-in-out`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Animation without a prefers-reduced-motion guard backend/app/assets/stylesheets/spree/backend/components/_progress.scss:47— `.spinner` moves (`animation: spinner 1s infinite linear`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
FileTooLong: migrate/20160101010000_solidus_one_four.rb core/db/migrate/20160101010000_solidus_one_four.rb— FileTooLong — 892 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 392 over it, 1.78× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: spree/order.rb core/app/models/spree/order.rb— FileTooLong — 627 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 127 over it, 1.25× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
D4 · Code Duplication· Edited copy of a member (18 corresponding lines) · ×2
Edited copy of a member (18 corresponding lines) promotions/app/models/solidus_promotions/benefit.rb:273— promotions/app/models/solidus_promotions/benefit.rb:273-300 | promotions/app/models/solidus_promotions/promotion_eligibility_checker.rb:40-57 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (18 corresponding lines) legacy_promotions/lib/solidus_legacy_promotions/testing_support/factories/order_factory.rb:3— legacy_promotions/lib/solidus_legacy_promotions/testing_support/factories/order_factory.rb:3-22 | promotions/lib/solidus_promotions/testing_support/factories/completed_order_with_solidus_promotion_factory.rb:3-20 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (16 corresponding lines) · ×2
Edited copy of a member (16 corresponding lines) admin/app/components/solidus_admin/return_reasons/index/component.rb:49— admin/app/components/solidus_admin/return_reasons/index/component.rb:49-64 | admin/app/components/solidus_admin/store_credit_reasons/index/component.rb:49-64 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (16 corresponding lines) admin/app/components/solidus_admin/ui/forms/field/component.rb:18— admin/app/components/solidus_admin/ui/forms/field/component.rb:18-33 | admin/app/components/solidus_admin/ui/forms/field/component.rb:53-68 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (9 lines × 2) legacy_promotions/lib/controllers/backend/spree/admin/promotions_controller.rb:82— legacy_promotions/lib/controllers/backend/spree/admin/promotions_controller.rb:82-90 | promotions/lib/controllers/backend/solidus_promotions/admin/promotions_controller.rb:40-49 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) legacy_promotions/app/models/spree/promotion/rules/one_use_per_user.rb:12— legacy_promotions/app/models/spree/promotion/rules/one_use_per_user.rb:12-20 | promotions/app/models/solidus_promotions/conditions/one_use_per_user.rb:10-22 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (6 lines × 2) legacy_promotions/app/models/spree/calculator/tiered_percent.rb:47— legacy_promotions/app/models/spree/calculator/tiered_percent.rb:47-52 | promotions/app/models/solidus_promotions/calculators/tiered_percent.rb:126-131 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `legacy_promotions/app/models/spree/calculator/tiered_percent.rb:54` calls `add` and `promotions/app/models/solidus_promotions/calculators/tiered_percent.rb:133` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (6 lines × 2) legacy_promotions/app/models/spree/promotion/rules/option_value.rb:30— legacy_promotions/app/models/spree/promotion/rules/option_value.rb:30-35 | promotions/app/models/concerns/solidus_promotions/conditions/option_value_condition.rb:12-17 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (10 lines × 2) admin/app/components/solidus_admin/orders/index/component.rb:105— admin/app/components/solidus_admin/orders/index/component.rb:105-114 | admin/app/components/solidus_admin/users/orders/component.rb:39-48 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (10 lines × 2) promotions/app/models/solidus_promotions/conditions/line_item_taxon.rb:18— promotions/app/models/solidus_promotions/conditions/line_item_taxon.rb:18-27 | promotions/app/models/solidus_promotions/conditions/price_taxon.rb:15-24 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (8 lines × 2 locations) legacy_promotions/app/assets/javascripts/spree/backend/promotions.js:4— legacy_promotions/app/assets/javascripts/spree/backend/promotions.js:4 · legacy_promotions/app/assets/javascripts/spree/backend/promotions.js:13 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
Duplicated block (8 lines × 2 locations) storefront/templates/app/assets/javascripts/checkout/address.js:54— storefront/templates/app/assets/javascripts/checkout/address.js:54 · storefront/templates/app/assets/javascripts/checkout/address.js:66 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Dead file (~16 LoC) admin/app/components/solidus_admin/layout/navigation/account/component.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~16 LoC) admin/app/components/solidus_admin/ui/dropdown/component.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~14 LoC) admin/app/components/solidus_admin/layout/navigation/component.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~14 LoC) admin/app/javascript/solidus_admin/controllers/index.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~7 LoC) admin/app/components/solidus_admin/orders/show/component.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~7 LoC) promotions/app/javascript/backend/solidus_promotions/web_components/taxon_picker.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Low contrast colour pair in CSS (1.0:1) core/app/views/layouts/spree/base_mailer.html.erb:90— `hr` sets color: #d9d9d9 on background-color: #d9d9d9 — 1.0:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
Low contrast colour pair in CSS (2.8:1) core/app/views/layouts/spree/base_mailer.html.erb:436— `table.button td, table.tiny-button td, table.small-button td, table.medium-button td, table.large-button td` sets color: #ffffff on background-color: #2ba6cb — 2.8:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
InstallGenerator.prepare_options (cyclomatic 17) core/lib/generators/solidus/install/install_generator.rb:55— InstallGenerator.prepare_options has cyclomatic complexity 17 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
Preferable.convert_preference_value (cyclomatic 16) core/lib/spree/preferences/preferable.rb:158— Preferable.convert_preference_value has cyclomatic complexity 16 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
Floating git dependency: rails — Gem `rails` is declared in REDACTED from a git source (rails) with no immutable pin — no `ref:` or `tag:` is given, so Bundler resolves whatever the default branch points at today. Two `bundle install` runs of this commit can therefore install different code, and nothing in the repository records which revision a given build used. Pin it to a commit (`ref: "<sha>"`) or a release tag (`tag: "v1.2.3"`), or take the gem from rubygems.org if it publishes there.
HackComment storefront/templates/app/controllers/checkouts_controller.rb:171— # HACK: We can't remove `skip_state_validation?` as of now because it is — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
TodoComment repeated across 12 files promotions/app/models/solidus_promotions/conditions/first_order.rb:6— The identical TodoComment appears in 12 files (12 occurrences) — almost certainly one boilerplate line from a single migration or decision, not 12 independent debts. Fix the systemic cause once rather than file-by-file. Text: "# TODO: Remove in Solidus 5". Source code is not a task system: track the cleanup where tasks live. (Every occurrence still counts toward the score and metrics.)
(anonymous) (cognitive 31) storefront/templates/app/assets/javascripts/checkout/address.js:1— (anonymous) has cognitive complexity 31 (threshold 15). Drivers by points: if/else 15 (28 pts), ternaries 1 (3 pts) (nesting depth added 15). Most of this is not in the body itself: 1 of the 31 points is its own statement and the rest belongs to 17 function items inside it that branch (fillStates, update_shipping_form_state, updateState, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
address.window.addEventListener("DOMContentLoaded") (cognitive 28) storefront/templates/app/assets/javascripts/checkout/address.js:1— address.window.addEventListener("DOMContentLoaded") has cognitive complexity 28 (threshold 15). Drivers by points: if/else 15 (28 pts) (nesting depth added 13). Most of this is not in the body itself: 1 of the 28 points is its own statement and the rest belongs to 5 function items inside it that branch (fillStates, update_shipping_form_state, updateState, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
component.render (cognitive 17) admin/app/components/solidus_admin/ui/forms/search/component.js:89— component.render has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (13 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
InstallGenerator.prepare_options (cognitive 16) core/lib/generators/solidus/install/install_generator.rb:55— InstallGenerator.prepare_options has cognitive complexity 16 (threshold 15). Drivers by points: boolean chains 11, if/else 5. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D4 · Code Duplication· Edited copy of a member (41 corresponding lines) · ×1
Edited copy of a member (41 corresponding lines) legacy_promotions/lib/components/admin/solidus_admin/promotions/index/component.rb:62— legacy_promotions/lib/components/admin/solidus_admin/promotions/index/component.rb:62-102 | promotions/lib/components/admin/solidus_promotions/promotions/index/component.rb:62-104 — These two members are one piece of code written twice and then edited apart: 41 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (54 corresponding lines) · ×1
Edited copy of a member (54 corresponding lines) core/db/migrate/20250605105424_add_shipping_category_foreign_keys.rb:12— core/db/migrate/20250605105424_add_shipping_category_foreign_keys.rb:12-65 | core/db/migrate/20250709073151_add_country_foreign_keys.rb:13-67 — These two members are one piece of code written twice and then edited apart: 54 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 34+ corresponding lines) · ×1
Edited copies of one member (3 members, 34+ corresponding lines) core/db/migrate/20250604072555_add_fk_to_product_properties.rb:12— core/db/migrate/20250604072555_add_fk_to_product_properties.rb:12-45 | core/db/migrate/20250604072948_add_fk_to_product_option_types.rb:12-45 | core/db/migrate/20250604073219_add_fk_to_classifications.rb:12-45 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 34 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (22 corresponding lines) · ×1
Edited copy of a member (22 corresponding lines) legacy_promotions/app/models/spree/promotion/rules/product.rb:38— legacy_promotions/app/models/spree/promotion/rules/product.rb:38-59 | promotions/app/models/solidus_promotions/conditions/order_product.rb:24-48 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (20 corresponding lines) · ×1
Edited copy of a member (20 corresponding lines) promotions/lib/solidus_promotions/migrate_adjustments.rb:7— promotions/lib/solidus_promotions/migrate_adjustments.rb:7-26 | promotions/lib/solidus_promotions/migrate_adjustments.rb:30-50 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (4 members, 10+ corresponding lines) · ×1
Edited copies of one member (4 members, 10+ corresponding lines) core/app/models/spree/in_memory_order_updater.rb:168— core/app/models/spree/in_memory_order_updater.rb:168-180 | core/app/models/spree/order_updater.rb:170-182 | legacy_promotions/app/patches/models/solidus_legacy_promotions/spree_in_memory_order_updater_patch.rb:6-16 | legacy_promotions/app/patches/models/solidus_legacy_promotions/spree_order_updater_patch.rb:6-15 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 10 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (21 corresponding lines) · ×1
Edited copy of a member (21 corresponding lines) legacy_promotions/app/models/spree/promotion_code/batch_builder.rb:34— legacy_promotions/app/models/spree/promotion_code/batch_builder.rb:34-54 | promotions/app/models/solidus_promotions/promotion_code/batch_builder.rb:36-57 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (15 corresponding lines) · ×1
Edited copy of a member (15 corresponding lines) legacy_promotions/lib/controllers/backend/spree/admin/promotions_controller.rb:15— legacy_promotions/lib/controllers/backend/spree/admin/promotions_controller.rb:15-29 | promotions/lib/controllers/backend/solidus_promotions/admin/promotions_controller.rb:13-27 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (4 members, 7+ corresponding lines) · ×1
Edited copies of one member (4 members, 7+ corresponding lines) REDACTED:43— REDACTED:43-49 | REDACTED:53-59 | core/app/models/spree/payment_method/simple_bogus_credit_card.rb:11-17 | core/app/models/spree/payment_method/simple_bogus_credit_card.rb:21-27 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 7 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 14+ corresponding lines) · ×1
Edited copies of one member (3 members, 14+ corresponding lines) admin/app/components/solidus_admin/products/index/component.rb:89— admin/app/components/solidus_admin/products/index/component.rb:89-102 | admin/app/components/solidus_admin/stock_items/index/component.rb:73-86 | admin/app/components/solidus_admin/users/items/component.rb:47-60 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 14 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 13+ corresponding lines) · ×1
Edited copies of one member (3 members, 13+ corresponding lines) promotions/app/models/concerns/solidus_promotions/conditions/line_item_level_condition.rb:7— promotions/app/models/concerns/solidus_promotions/conditions/line_item_level_condition.rb:7-19 | promotions/app/models/concerns/solidus_promotions/conditions/order_level_condition.rb:7-19 | promotions/app/models/concerns/solidus_promotions/conditions/shipment_level_condition.rb:7-19 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (11 corresponding lines) · ×1
Edited copy of a member (11 corresponding lines) REDACTED:9— REDACTED:9-19 | api/app/controllers/spree/api/users_controller.rb:7-17 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (14 corresponding lines) · ×1
Edited copy of a member (14 corresponding lines) admin/app/components/solidus_admin/orders/show/component.rb:15— admin/app/components/solidus_admin/orders/show/component.rb:15-29 | admin/app/components/solidus_admin/orders/show/address/component.rb:34-47 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (19 corresponding lines) · ×1
Edited copy of a member (19 corresponding lines) api/app/controllers/spree/api/checkouts_controller.rb:70— api/app/controllers/spree/api/checkouts_controller.rb:70-88 | storefront/templates/app/controllers/checkouts_controller.rb:74-95 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (4 members, 8+ corresponding lines) · ×1
Edited copies of one member (4 members, 8+ corresponding lines) REDACTED:8— REDACTED:8-17 | REDACTED:21-28 | REDACTED:10-18 | REDACTED:22-29 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 8 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (7 corresponding lines) · ×1
Edited copy of a member (7 corresponding lines) backend/app/controllers/spree/admin/return_authorizations_controller.rb:30— backend/app/controllers/spree/admin/return_authorizations_controller.rb:30-38 | backend/app/controllers/spree/admin/option_types_controller.rb:21-27 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (7 members, 8+ corresponding lines) · ×1
Edited copies of one member (7 members, 8+ corresponding lines) admin/app/components/solidus_admin/adjustment_reasons/index/component.rb:17— admin/app/components/solidus_admin/adjustment_reasons/index/component.rb:17-24 | admin/app/components/solidus_admin/refund_reasons/index/component.rb:27-34 | admin/app/components/solidus_admin/return_reasons/index/component.rb:27-34 | admin/app/components/solidus_admin/shipping_categories/index/component.rb:9-16 | admin/app/components/solidus_admin/store_credit_reasons/index/component.rb:9-16 | admin/app/components/solidus_admin/tax_categories/index/component.rb:17-24 | admin/app/components/solidus_admin/zones/index/component.rb:29-36 — These 7 members are one piece of code written 7 times and then edited apart: every two of them correspond over at least 8 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 7 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (13 corresponding lines) · ×1
Edited copy of a member (13 corresponding lines) promotions/app/models/solidus_promotions/conditions/line_item_product.rb:17— promotions/app/models/solidus_promotions/conditions/line_item_product.rb:17-29 | promotions/app/models/solidus_promotions/conditions/price_product.rb:14-26 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 10+ corresponding lines) · ×1
Edited copies of one member (3 members, 10+ corresponding lines) admin/app/controllers/solidus_admin/reimbursement_types_controller.rb:8— admin/app/controllers/solidus_admin/reimbursement_types_controller.rb:8-17 | admin/app/controllers/solidus_admin/taxonomies_controller.rb:9-18 | REDACTED:17-26 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 10 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (1 corresponding lines) · ×1
Edited copy of a member (1 corresponding lines) core/app/models/spree/in_memory_order_updater.rb:211— core/app/models/spree/in_memory_order_updater.rb:211-211 | core/app/models/spree/order_updater.rb:151-151 — These two members are one piece of code written twice and then edited apart: 1 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 6+ corresponding lines) · ×1
Edited copies of one member (3 members, 6+ corresponding lines) REDACTED:31— REDACTED:31-36 | api/app/controllers/spree/api/return_authorizations_controller.rb:52-57 | api/app/controllers/spree/api/variants_controller.rb:51-56 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 6 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 4+ corresponding lines) · ×1
Edited copies of one member (3 members, 4+ corresponding lines) promotions/app/models/solidus_promotions/benefits/adjust_line_item.rb:11— promotions/app/models/solidus_promotions/benefits/adjust_line_item.rb:11-14 | promotions/app/models/solidus_promotions/benefits/adjust_shipment.rb:11-14 | promotions/app/models/solidus_promotions/benefits/create_discounted_item.rb:28-31 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 4 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 9+ corresponding lines) · ×1
Edited copies of one member (3 members, 9+ corresponding lines) api/app/controllers/spree/api/customer_returns_controller.rb:23— api/app/controllers/spree/api/customer_returns_controller.rb:23-33 | api/app/controllers/spree/api/product_properties_controller.rb:10-18 | api/app/controllers/spree/api/return_authorizations_controller.rb:28-38 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Duplicated block (29 lines × 2) legacy_promotions/lib/components/admin/solidus_admin/promotions/index/component.rb:74— legacy_promotions/lib/components/admin/solidus_admin/promotions/index/component.rb:74-102 | promotions/lib/components/admin/solidus_promotions/promotions/index/component.rb:76-104 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `legacy_promotions/lib/components/admin/solidus_admin/promotions/index/component.rb:74` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 2) legacy_promotions/app/models/spree/promotion/rules/product.rb:38— legacy_promotions/app/models/spree/promotion/rules/product.rb:38-54 | promotions/app/models/solidus_promotions/conditions/order_product.rb:24-40 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (19 lines × 2) legacy_promotions/app/models/spree/promotion/rules/nth_order.rb:14— legacy_promotions/app/models/spree/promotion/rules/nth_order.rb:14-40 | promotions/app/models/solidus_promotions/conditions/nth_order.rb:19-37 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (25 lines × 2) legacy_promotions/app/models/spree/promotion/rules/user_role.rb:13— legacy_promotions/app/models/spree/promotion/rules/user_role.rb:13-40 | promotions/app/models/solidus_promotions/conditions/user_role.rb:12-36 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (10 lines × 4) admin/app/controllers/solidus_admin/shipping_methods_controller.rb:8— admin/app/controllers/solidus_admin/shipping_methods_controller.rb:8-17 | admin/app/controllers/solidus_admin/stores_controller.rb:8-17 | legacy_promotions/lib/controllers/admin/solidus_admin/promotions_controller.rb:14-23 | promotions/lib/controllers/admin/solidus_promotions/promotions_controller.rb:14-23 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 4 times.
Duplicated block (6 lines × 4) admin/app/controllers/solidus_admin/shipping_methods_controller.rb:21— admin/app/controllers/solidus_admin/shipping_methods_controller.rb:21-26 | admin/app/controllers/solidus_admin/taxonomies_controller.rb:22-27 | legacy_promotions/lib/controllers/admin/solidus_admin/promotions_controller.rb:27-32 | promotions/lib/controllers/admin/solidus_promotions/promotions_controller.rb:27-32 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 4 times.
Duplicated block (7 lines × 4) REDACTED:30— REDACTED:30-36 | REDACTED:25-31 | REDACTED:19-25 | REDACTED:7-13 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 4 call sites, so a change lands once. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `REDACTED:21` calls `respond_with` and `REDACTED:26` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
No DR/backup evidence — A persistence guard (data volume / purge-protection) was found, but no backup, geo-recovery or RTO/RPO controls were evidenced — a volume that survives a container recreate is not a tested restore from catastrophic loss.
Duplication concentrated across 5 sibling directories (7 clone groups) backend/app/assets/javascripts/spree/backend/views/order/details_adjustments.js:1— 7 duplicated blocks under the repository root have copies in at least two of the sibling directories admin, backend, legacy_promotions, promotions, storefront — 6 of them are reported below, and 1 is counted here but not reported individually: those copies match on shape but no longer clear R10's bar for an individually reported row — either they kept neither their own names nor their values, or what was copied is too small to stand on its own (it reports near-exact duplication only, and only of substantial extent). What this row states is the concentration, which the detector measured over all 7 and which does not depend on how exactly each block's copies still match. That concentration is one structural fact, not 7 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 7 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on.
Duplicated block (35 lines × 2 locations) backend/app/assets/javascripts/spree/backend/views/order/details_adjustments.js:1— backend/app/assets/javascripts/spree/backend/views/order/details_adjustments.js:1 · legacy_promotions/app/assets/javascripts/spree/backend/views/order/details_adjustments.js:1 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
Duplicated block (26 lines × 2 locations) promotions/app/javascript/backend/solidus_promotions/controllers/calculator_tiers_controller.js:3— promotions/app/javascript/backend/solidus_promotions/controllers/calculator_tiers_controller.js:3 · promotions/app/javascript/backend/solidus_promotions/controllers/product_option_values_controller.js:3 — the 2 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it.
R10 · Code Duplication· Duplicated block with local edits (16 matched lines × 2 locations) · ×1
Duplicated block with local edits (16 matched lines × 2 locations) backend/app/assets/javascripts/spree/backend/views/stock/add_stock_item.js:50— backend/app/assets/javascripts/spree/backend/views/stock/add_stock_item.js:50 · backend/app/assets/javascripts/spree/backend/views/stock/edit_stock_item_row.js:86 — the two spans are one implementation copied and then locally edited — 71 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
Duplicated block (15 lines × 2 locations) promotions/eslint.config.mjs:8— promotions/eslint.config.mjs:8 · storefront/eslint.config.mjs:8 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
Duplicated block (12 lines × 3 locations) admin/eslint.config.mjs:8— admin/eslint.config.mjs:8 · promotions/eslint.config.mjs:8 · storefront/eslint.config.mjs:8 — the 3 copies are spread across 3 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. There is one copy in each of 3 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape — one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values — and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete.
Duplicated block (11 lines × 2 locations) backend/app/assets/javascripts/spree/backend/option_value_picker.js:7— backend/app/assets/javascripts/spree/backend/option_value_picker.js:7 · promotions/app/javascript/backend/solidus_promotions/web_components/option_value_picker.js:6 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
Duplicated block (10 lines × 4 locations) admin/eslint.config.mjs:6— admin/eslint.config.mjs:6 · eslint.config.mjs:6 · promotions/eslint.config.mjs:6 · storefront/eslint.config.mjs:6 — the 4 copies are spread across 4 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. There is one copy in each of 4 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape — one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values — and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete.
Duplicated block (9 lines × 2 locations) backend/app/assets/javascripts/spree/backend/views/cart/add_line_item_button.js:1— backend/app/assets/javascripts/spree/backend/views/cart/add_line_item_button.js:1 · backend/app/assets/javascripts/spree/backend/views/cart/empty_cart_button.js:1 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
Duplicated block (7 lines × 3 locations) backend/app/assets/javascripts/spree/backend/views/order/details_adjustments.js:1— backend/app/assets/javascripts/spree/backend/views/order/details_adjustments.js:1 · backend/app/assets/javascripts/spree/backend/views/order/details_total.js:1 · legacy_promotions/app/assets/javascripts/spree/backend/views/order/details_adjustments.js:1 — the 3 copies are spread across 3 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
Dead file (~174 LoC) REDACTED— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~116 LoC) admin/app/components/solidus_admin/ui/forms/search/component.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~75 LoC) admin/app/components/solidus_admin/ui/table/ransack_filter/component.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~69 LoC) promotions/app/javascript/backend/solidus_promotions/web_components/option_value_picker.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~68 LoC) admin/app/javascript/solidus_admin/tom-select/plugins/stash_on_search.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~67 LoC) admin/app/javascript/solidus_admin/tom-select/plugins/remote_with_pagination.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~63 LoC) admin/app/components/solidus_admin/ui/forms/address/fields/country_and_state/component.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~46 LoC) admin/app/components/solidus_admin/ui/toggletip/component.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~40 LoC) admin/app/javascript/solidus_admin/controllers/sortable_controller.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~39 LoC) promotions/app/javascript/backend/solidus_promotions/controllers/product_option_values_controller.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~35 LoC) promotions/app/javascript/backend/solidus_promotions/web_components/number_with_currency.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~32 LoC) admin/app/components/solidus_admin/zones/form/component.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~28 LoC) admin/app/components/solidus_admin/payment_methods/form/deployment/component.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~21 LoC) admin/app/components/solidus_admin/layout/confirm/component.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~20 LoC) admin/app/javascript/solidus_admin/controllers/alert_animation_controller.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~19 LoC) admin/app/javascript/solidus_admin/tom-select/plugins/patch_scroll.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~18 LoC) admin/app/components/solidus_admin/stock_items/edit/component.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~17 LoC) admin/app/javascript/solidus_admin/controllers/readonly_when_submitting_controller.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~15 LoC) admin/app/components/solidus_admin/orders/show/customer_search/component.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~13 LoC) admin/app/components/solidus_admin/ui/modal/component.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~11 LoC) promotions/app/javascript/backend/solidus_promotions/web_components/select_two.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~10 LoC) promotions/app/javascript/backend/solidus_promotions/controllers/flash_controller.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~8 LoC) promotions/app/javascript/backend/solidus_promotions/controllers/index.js— no import path from any entry point (130 application, 6 tooling, 6 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
X24 · Document value interpolated into markup unescaped· Document value reaches a markup attribute unescaped · ×1
Document value reaches a markup attribute unescaped admin/app/javascript/solidus_admin/web_components/solidus_select.js:63— `message` carries text this program read out of a document — an attribute or a text node, which the DOM hands back already decoded, so an entity its author wrote is a live character again — and it is written straight into the text of an element of markup built here with nothing escaping it on the way. The value is chosen by whoever authored that document, not by this program, so it can close the attribute or element it sits in and open another — a crafted document becomes markup in what this code renders. Escape `message` at this site, or validate it against the shape the position accepts before interpolating it.
Orphaned file REDACTED:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file REDACTED:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file REDACTED:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file core/app/models/spree/reimbursement.rb:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file core/lib/spree/preferences/configuration.rb:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file core/app/models/spree/order_merger.rb:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file core/app/models/spree/inventory_unit.rb:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file core/lib/spree/testing_support/preferences.rb:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file backend/config/routes.rb:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file core/app/models/spree/payment_method/store_credit.rb:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file core/app/models/spree/shipping_method.rb:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file backend/app/helpers/spree/admin/orders_helper.rb:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file backend/app/controllers/spree/admin/store_credits_controller.rb:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file core/lib/generators/solidus/update/update_generator.rb:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file legacy_promotions/app/models/spree/promotion_handler/coupon.rb:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file REDACTED:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file core/config/initializers/friendly_id.rb:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file api/config/routes.rb:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file core/lib/spree/testing_support/bus_helpers.rb:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file legacy_promotions/app/models/spree/promotion/rules/taxon.rb:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file REDACTED:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file REDACTED:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file core/app/models/spree/stock/availability.rb:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file admin/lib/solidus_admin/install_tailwindcss.rb:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file admin/lib/solidus_admin/menu_item.rb:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Duplicated predicate legacy_promotions/app/models/spree/promotion/rules/first_order.rb:17— `(user || email) && completed_orders.present? && completed_orders.first != order` appears character-identically in 2 files — legacy_promotions/app/models/spree/promotion/rules/first_order.rb, promotions/app/models/solidus_promotions/conditions/first_order.rb. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate api/app/controllers/spree/api/users_controller.rb:86— `action_name == "create" || can?(:update_email, @user)` appears character-identically in 2 files — api/app/controllers/spree/api/users_controller.rb, backend/app/controllers/spree/admin/users_controller.rb. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate core/app/helpers/spree/base_helper.rb:11— `current_order.nil? || current_order.item_count.zero?` appears character-identically in 2 files — core/app/helpers/spree/base_helper.rb, storefront/templates/app/components/link_to_cart_component.rb. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate promotions/app/models/solidus_promotions/benefits/adjust_line_item.rb:11— `find_adjustment(line_item) || build_adjustment(line_item)` appears character-identically in 2 files — promotions/app/models/solidus_promotions/benefits/adjust_line_item.rb, promotions/app/models/solidus_promotions/benefits/create_discounted_item.rb. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate core/app/helpers/spree/base_helper.rb:100— `max_level < 1 || root_taxon.children.empty?` appears character-identically in 2 files — core/app/helpers/spree/base_helper.rb, storefront/templates/app/components/taxons_tree_component.rb. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate promotions/app/models/solidus_promotions/benefit.rb:295— `message || I18n.t(:coupon_code_unknown_error, scope: [:solidus_promotions, :eligibility_errors])` appears character-identically in 2 files — promotions/app/models/solidus_promotions/benefit.rb, promotions/app/models/solidus_promotions/promotion_eligibility_checker.rb. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate core/app/models/spree/in_memory_order_updater.rb:105— `order.state == "canceled" && order.payment_total.zero?` appears character-identically in 2 files — core/app/models/spree/in_memory_order_updater.rb, core/app/models/spree/order_updater.rb. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate backend/app/controllers/spree/admin/orders_controller.rb:56— `params[:per_page] || Spree::Config.orders_per_page` appears character-identically in 2 files — backend/app/controllers/spree/admin/orders_controller.rb, REDACTED. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate REDACTED:99— `payment.completed? && payment.credit_allowed > 0` appears character-identically in 3 files — REDACTED, core/app/models/spree/payment_method/check.rb, core/app/models/spree/payment_source.rb. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate core/app/models/spree/in_memory_order_updater.rb:103— `payments.present? && payments.valid.empty? && order.outstanding_balance != 0` appears character-identically in 2 files — core/app/models/spree/in_memory_order_updater.rb, core/app/models/spree/order_updater.rb. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate legacy_promotions/app/models/spree/promotion/rules/user_role.rb:28— `preferred_match_policy == "all" && preferred_role_ids.present?` appears character-identically in 2 files — legacy_promotions/app/models/spree/promotion/rules/user_role.rb, promotions/app/models/solidus_promotions/conditions/user_role.rb. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate legacy_promotions/app/models/spree/order_promotion.rb:24— `promotion && !promotion.apply_automatically && promotion.codes.any?` appears character-identically in 2 files — legacy_promotions/app/models/spree/order_promotion.rb, promotions/app/models/solidus_promotions/order_promotion.rb. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate legacy_promotions/lib/components/admin/solidus_admin/promotions/index/component.rb:88— `promotion.usage_limit || icon_tag("infinity-line")` appears character-identically in 2 files — legacy_promotions/lib/components/admin/solidus_admin/promotions/index/component.rb, promotions/lib/components/admin/solidus_promotions/promotions/index/component.rb. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate legacy_promotions/app/models/spree/promotion_handler/coupon.rb:73— `promotion.usage_limit_exceeded? || promotion_code.usage_limit_exceeded?` appears character-identically in 2 files — legacy_promotions/app/models/spree/promotion_handler/coupon.rb, promotions/app/models/solidus_promotions/promotion_handler/coupon.rb. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate core/app/helpers/spree/core/controller_helpers/auth.rb:34— `session["spree_user_return_to"] || default` appears character-identically in 2 files — core/app/helpers/spree/core/controller_helpers/auth.rb, storefront/templates/app/controllers/user_sessions_controller.rb. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate core/app/models/spree/address.rb:88— `state.try(:abbr) || state.try(:name) || state_name` appears character-identically in 2 files — core/app/models/spree/address.rb, core/app/models/spree/stock_location.rb. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate legacy_promotions/app/models/spree/promotion/rules/store.rb:23— `stores.none? || stores.include?(order.store)` appears character-identically in 2 files — legacy_promotions/app/models/spree/promotion/rules/store.rb, promotions/app/models/solidus_promotions/conditions/store.rb. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 12 significant file(s) lose their only recent owner: promotions/app/models/solidus_promotions/benefit.rb, promotions/app/models/solidus_promotions/condition.rb, core/app/models/spree/payment/processing.rb, promotions/lib/solidus_promotions/configuration.rb, core/app/models/spree/order_inventory.rb, core/lib/spree/core/null_promotion_configuration.rb, promotions/app/models/solidus_promotions/benefits/adjust_line_item_quantity_groups.rb, promotions/app/models/solidus_promotions/promotion_handler/coupon.rb (+4 more). Pair on, review, or document these before any departure.
Off-boarding risk: anonymized user #2 — If anonymized user #2 becomes unavailable, 9 significant file(s) lose their only recent owner: core/app/models/spree/product/scopes.rb, backend/app/controllers/spree/admin/orders_controller.rb, REDACTED, core/app/models/spree/payment_create.rb, core/app/models/spree/refund.rb, core/app/helpers/spree/products_helper.rb, core/app/models/spree/permission_sets/default_customer.rb, core/app/models/spree/stock/estimator.rb (+1 more). Pair on, review, or document these before any departure.
Off-boarding risk: anonymized user #3 — If anonymized user #3 becomes unavailable, 3 significant file(s) lose their only recent owner: admin/app/components/solidus_admin/stock_locations/index/component.rb, admin/app/components/solidus_admin/tax_rates/index/component.rb, admin/app/components/solidus_admin/payment_methods/index/component.rb. Pair on, review, or document these before any departure.
X23 · Unguarded diagnostic materialisation· Diagnostic log message is built whether or not it is wanted · ×2
Diagnostic log message is built whether or not it is wanted REDACTED:116— `debug` at line 116 is called with an argument built by `full_messages.join` (line 116), whose cost grows with the collection it walks. Ruby evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because debug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: no `debug?` test, no debug flag, no block the logger calls only when the level is on.
Diagnostic log message is built whether or not it is wanted admin/app/components/solidus_admin/base_component.rb:24— `debug` at line 24 is called with an argument built by `keys.join(".")` (line 24), whose cost grows with the collection it walks. Ruby evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because debug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: no `debug?` test, no debug flag, no block the logger calls only when the level is on.
D16 · Bus Factor· Further sole-owners (lower concentration) · ×1
Further sole-owners (lower concentration) — 5 other contributor(s) are each the sole owner of a small amount of code below the off-boarding threshold — folded into the bus-factor score and metrics (31 single-owned of 195 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated, example/demo and scaffolding-template trees and test files identified by path convention, largest first; 195 of the 1216 production source files in this repository met that bar). They are anonymized user #4 (3 file(s)), anonymized user #5 (1 file(s)), anonymized user #6 (1 file(s)), anonymized user #7 (1 file(s)), anonymized user #8 (1 file(s)) — spread or document their files in the same way, at lower priority than the named off-boarding risks above. The files folded here: backend/app/controllers/spree/admin/resource_controller.rb, backend/app/controllers/spree/admin/payment_methods_controller.rb, api/app/controllers/spree/api/payments_controller.rb, core/lib/spree/core/product_filters.rb, core/lib/spree/preferences/preferable.rb, storefront/templates/app/components/breadcrumbs_component.rb, core/app/models/spree/log_entry.rb.
No ADRs found storefront/bin/rails:1— No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`. ADRs are expected here because `storefront/bin/rails` makes this repository a deployable product (line 1).
D26 · Project Cohesion· Projects may be oversized for their cohesion · ×1
Projects may be oversized for their cohesion — 4 of 9 project(s) overshoot their size bounds, lowering Project Cohesion to 1.2/10. The most over is `admin` (9166 LoC, 331 module-visible types across 181 directories). Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.
D28 · Secrets (history)· Rotate the exposed credentials · ×1
REDACTED
D34 · Knowledge Freshness· Further orphaned files (smaller) · ×1
Further orphaned files (smaller) — 42 smaller file(s) also have no living knowledge — folded into the freshness score and metrics rather than raised one row each — most significant first: REDACTED, REDACTED, core/app/models/spree/reimbursement.rb, core/app/models/spree/order_merger.rb, core/app/models/spree/inventory_unit.rb, core/lib/spree/testing_support/preferences.rb, core/app/models/spree/payment_method/store_credit.rb, core/app/models/spree/shipping_method.rb (and 34 more) (43 orphaned of 195 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated, example/demo and scaffolding-template trees and test files identified by path convention, largest first; 195 of the 1216 production source files in this repository met that bar). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway.
GD1 · Unfinished & placeholder code· Placeholder literal left in code · ×1
Placeholder literal left in code REDACTED:26— A placeholder string ("Lorem ipsum dolor sit amet") is still in shipped code — typical of generated boilerplate that was never filled in.
Disabled test backend/spec/features/admin/products/edit/taxons_spec.rb:48— A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
IC1 · Incompleteness & stubs· Empty method body · ×1
Empty method body core/app/models/spree/exchange.rb:40— `to_key` has an empty body — confirm it's an intentional no-op and not an unfinished method.
No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
README/code drift i18n/README.md:105— i18n/README.md links to `CONTRIBUTING.md`, but `i18n/CONTRIBUTING.md` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
No SAST REDACTED:3— No static application security testing detected. For this repository's stack, add brakeman for Rails apps, otherwise `semgrep --config=auto` or CodeQL's ruby pack as a CI step. What was searched, so you can tell an absence from a miss: the 13 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
P4 · Deployment & Rollback· No rollback/health safety · ×1
No rollback/health safety — Deployment automation exists but no readiness/liveness probes, rolling-update strategy, lifecycle hooks or migration job were evidenced — a bad release is harder to detect and reverse.
X2 · Cancellation propagation· Not all async functions that make a request accept an AbortSignal · ×1
Not all async functions that make a request accept an AbortSignal — Only 0/4 async functions that make a cancellable request (fetch, axios, ky, ofetch, got, undici, node:http) accept an AbortSignal or pass one on, so a request keeps running after whatever wanted it has given up — a page navigated away from, an unmounted component, a timed-out job. Take a `signal` (or an options object that carries one) and hand it to the request; where nothing could ever cancel the call, omitting it is a deliberate choice — judge against how the function is used.
X5 · Nullable reference types· Ruby's type checker does not check nil everywhere · ×1
Ruby's type checker does not check nil everywhere — This repository commits no Sorbet configuration (`sorbet/config`) and no `Steepfile`, so nothing type-checks its 1201 Ruby product file(s): a nilable value reaches a method call silently and raises `NoMethodError: undefined method … for nil` the first time it is nil. A `# typed:` sigil does nothing without a `sorbet/config` beside the code; a Steep run configured only on a command line is not something this check can read.
Appendix B — Reproduction & audit trail
Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.
semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 1 file(s) — `storefront/template.rb` — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.
disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
0
—
Run 01a1da72-3c1d-7d53-b322-84d2a6195468 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.
Issues: 176 · Warnings: 306 · Recommendations: 84 — Appendix A · all findings · full markdown report.
Generated by the Canine Code Analyzer: deterministic code-health analysis. 14-11-2026 @ 14:24 UTC.
Downloadable artifacts
Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.