Public report of rushiranpise/Shizuku-Next, published 17 November 2026. It has the same score, grades and number of findings as the full report. The details of security findings (where they are in the code, which known vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive report Measured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.11.4). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey → Signed and filed in the standard's public register, 17 November 2026, 15:51 UTC · Survey ID cd_35cbd7f654ca426eb5cc28c7d06f0a7d

rushiranpise/Shizuku-Next

Measured 17 November 2026, 15:51 UTC, at code version 3e93b2a

First survey, so nothing to compare with yet
CAI score 60.0out of 100 Adequate
CriticalWeakAdequateStrongExemplary

The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.

A medium codebase: 55,642 lines of product code in 9 projects, tests not counted · Estimated rebuild effort: about 0.4 person-years · Weakest lens: Production Readiness, 53.0

Findings by how serious they are

23 critical 323 serious 41 minor

11 dimensions are left out of the score. For each one, we either couldn't measure it in this code, or found no evidence of the safeguard we look for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.

This survey was produced by

Assert small markCanine Code Analyzer
Producer
Canine Development
Analyzer
Canine Code Analyzer engine 1.0.0
Measured
17 November 2026, 15:51 UTC

A measurement, not a certificate. The Code Assurance Index records a number together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee the code. The standard was written by Canine Development, which also builds the Canine Code Analyzer. It is open to any tool that implements it, and today the Canine Code Analyzer is the only one that does.

The score is deterministic, which means the same code always gets the same score. We work it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸

51of 51 dimensions measured by tools.
376of 387 findings point to an exact file and line, so you can open each one in the code. The other 11 concern the repository as a whole, such as missing documentation.
51dimensions across 6 lenses, read from 55,642 lines of product code in 9 projects.
Chapters

Executive summary

rushiranpise/Shizuku-Next falls short of our standard for production, held back most by its Production Readiness lens, the way the code is tested, built, released and run. It scores 60.0 out of 100 and is rated Adequate, and all 23 of its critical findings are security problems in the build pipeline and in its automatic dependency updates.

Production Readiness, at 53.0, is the weakest lens and counts most in the score. The best first step is recording design decisions, worth about 5.2 points. Adding automated security scanning would lift Production Readiness itself, worth about 3.6 points. Raising Production Readiness to 70 would lift the score to about 64.2.

Sixteen pipeline tools are referenced by a changeable name, so the build pipeline can be tampered with. Four secrets can leak from the build pipeline, and two pipeline steps put outside input straight into a shell command, so an attacker can run commands in the build pipeline. Pinning each tool to an exact version, limiting each secret to its own step and passing outside input through environment variables would close these risks. Setting a waiting period for automatic updates would fix the automatic dependency update that takes a new release at once.

The product code is 55,642 lines, about €65,000 to rebuild.

A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.

How the score is built: what each lens counts for The lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
Production Readiness 53.0 · counts for 46%Maturity 54.7 · counts for 25%Code Health 66.3 · counts for 14%Security and Compliance 74.8 · counts for 8%Architecture 97.6 · counts for 4%Performance 100.0 · counts for 2%

If Production Readiness rose from 53.0 to 70, the lowest score rated Strong, the score would rise from 60.0 to about 64.2.

Code composition: what the lines of code are
Product code 93%Tests 7%
Rebuild cost: about €65,000 · Estimate
Cost to rebuild€21,000 to €110,000, for 358 to 1,136 hours of work, about 0.4 person-years for one engineer
Difficulty of the problemStandard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor×0.8 at a score of 60. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
SizeMedium: 55,642 lines of product code
What it is notNot a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.

How the estimate is made: We price the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.

Top priorities

The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.

1
Resolve the 1 No ADRs found finding(s) in ADR Quality — start with build.gradle.
Raises the score by about 5.2 points · Low effort · ADR Quality
2
Resolve the 2 Off-boarding risk finding(s) in Bus Factor.
Raises the score by about 3.5 points · Low effort · Bus Factor
3
Record your significant design decisions.
Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Raises the score by about 4.8 points · Medium effort · Architecture documentation

Diagnosis: what the measurements show together

Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.

Where the investment is most exposed · Value at risk
This code would cost about €65,000 to build again, about 0.4 person-years of work. Its weakest lens is Production Readiness, at 53.0 (Adequate). Production Readiness is about whether the product is ready to run in production and to change without breaking. Because the weakest lens counts most in the score, work on Production Readiness also moves the score most.
Based on: the rebuild estimate · the Production Readiness grade · how much each lens counts
What to do: Start with the Production Readiness actions in Top priorities.
If you do one thing first · First action
Resolve the 1 No ADRs found finding(s) in ADR Quality. Of all the actions in this report, it raises the score most for the work it takes: about 5.2 points for low effort, because it clears the 1 ADR Quality findings. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
What hard-to-read code costs each year · Cost
Four dimensions measure how easy the code is to work in: two measure how tangled its logic is, one how much of it is copied, and one how well each part sticks to a single job. In this codebase they average 7.1 out of 10. Code at that level is slower to change than clean code, and we estimate the extra work at 2% to 5% on every change. The history of the code shows how much it changes: about 112,695 lines over the last 90 days, which is about 457,041 lines a year. At that pace, the extra work comes to an estimated 24.5 to 152.3 engineer-days a year, and it grows as more code changes.
How this is estimated: The number of changed lines is measured from the history of the code. The rest rests on two assumptions of our own: code scoring 8 out of 10 or more adds no extra work, and each point below 8 adds 2.5% to 5.6% to every change, never less than 2% to 5% and never more than 40% to 60% in all; and an engineer changes 150 to 400 lines in a day. The result is a range for planning, not a measurement.
Based on: Cyclomatic Complexity · Cognitive Complexity · Code Duplication · Cohesion (LCOM4) · the code's change history
What to do: Start with the files listed under Churn × Complexity Hotspots, which change often and are hard to read, because that is where the extra work is paid most often.

Architecture — module dependency graph

Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways, which only happens where the projects form a dependency cycle. A graph without cycles has none.

arch :common :common :manager :manager :server :server :manager->:server :starter :starter :manager->:starter :server->:common :server->:starter :shell :shell :starter->:common :stub :stub adb adb codehealth-iso-1a02f11f87d94bc5a6e84adf8c472b9b codehealth-iso-1a02f11f87d94bc5a6e84adf8c472b9b libshizuku.so so

Architecture: which parts of the code depend on which

The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.

178 modules, with 164 dependencies between them. 4 loops run through 11 of the modules, marked above the diagonal.

The table shows the 40 modules with the most connections; 138 more are left out to keep it readable.

Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
uses →1 adb.AdbPairingClient2 adb.AdbStarter3 app4 files.AppDataArchive5 files.FileOperations6 files.PrivilegedFiles7 install.AppInstall8 install.PackageInspect9 manage.Activities10 manage.DeviceInfo11 manage.Logcat12 manage.WifiBackup13 module14 receiver.ShizukuReceiverStarter15 shell16 start.StartTransport17 stealth18 ui.component19 utils.ShizukuStateMachine20 utils.UpdateHelper21 adb.AdbMdns22 adb.PairingPacketHeader23 authorization24 files25 install26 manage.Logcat.Scope27 manage.RotationOverride28 receiver29 start.AdbStartRun30 utils31 moe.shizuku.manager32 adb33 manage34 utils.SettingsPage35 adb.PeerInfo36 manage.LabSwitch37 service38 start39 ui.screen40 ui
1 adb.AdbPairingClient
2 adb.AdbStarter
3 app
4 files.AppDataArchive
5 files.FileOperations
6 files.PrivilegedFiles
7 install.AppInstall
8 install.PackageInspect
9 manage.Activities
10 manage.DeviceInfo
11 manage.Logcat
12 manage.WifiBackup
13 module
14 receiver.ShizukuReceiverStarter
15 shell
16 start.StartTransport
17 stealth
18 ui.component
19 utils.ShizukuStateMachine
20 utils.UpdateHelper
21 adb.AdbMdns2
22 adb.PairingPacketHeader1
23 authorization1
24 files553
25 install22
26 manage.Logcat.Scope2
27 manage.RotationOverride1
28 receiver1
29 start.AdbStartRun1
30 utils221
31 moe.shizuku.manager1
32 adb11111
33 manage410552
34 utils.SettingsPage6
35 adb.PeerInfo1
36 manage.LabSwitch16
37 service11
38 start1421
39 ui.screen121121121231111124
40 ui1
Uses a module listed above itPart of a loopThe module itself
1 adb.AdbPairingClient2 adb.AdbStarter3 app4 files.AppDataArchive5 files.FileOperations6 files.PrivilegedFiles7 install.AppInstall8 install.PackageInspect9 manage.Activities10 manage.DeviceInfo11 manage.Logcat12 manage.WifiBackup13 module14 receiver.ShizukuReceiverStarter15 shell16 start.StartTransport17 stealth18 ui.component19 utils.ShizukuStateMachine20 utils.UpdateHelper21 adb.AdbMdns22 adb.PairingPacketHeader23 authorization24 files25 install26 manage.Logcat.Scope27 manage.RotationOverride28 receiver29 start.AdbStartRun30 utils31 moe.shizuku.manager32 adb33 manage34 utils.SettingsPage35 adb.PeerInfo36 manage.LabSwitch37 service38 start39 ui.screen40 uiadb.AdbPairingClient1adb.AdbStarter2app3files.AppDataArchive4files.FileOperations5files.PrivilegedFiles6install.AppInstall7install.PackageInspect8manage.Activities9manage.DeviceInfo10manage.Logcat11manage.WifiBackup12module13receiver.ShizukuReceiverStarter14shell15start.StartTransport16stealth17ui.component18utils.ShizukuStateMachine19utils.UpdateHelper20adb.AdbMdns21adb.PairingPacketHeader22authorization23files24install25manage.Logcat.Scope26manage.RotationOverride27receiver28start.AdbStartRun29utils30moe.shizuku.manager31adb32manage33utils.SettingsPage34adb.PeerInfo35manage.LabSwitch36service37start38ui.screen39ui4021155322211122111111141055261161114211211211212311111241+138 more modules (most-connected shown)

At a glance — Code Health · 66.3 · Adequate ·

At a glance — Architecture · 97.6 · Exemplary ·

At a glance — Maturity · 54.7 · Adequate · gated by M2 ·

At a glance — Readiness · 53.0 · Adequate · gated by P3 ·

At a glance — Security · 74.8 · Adequate · gated by D29 ·

At a glance — Performance · 100.0 · Exemplary ·

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP categoryFindingsSeverity
A05:2025 — Injection27High / Critical
A03:2025 — Software Supply Chain Failures2Medium

Roadmap

Top priorities: Resolve the 1 No ADRs found finding(s) in ADR Quality — start with build.gradle; Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them; Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do thisHelpsEffortDimension
Resolve the 1 No ADRs found finding(s) in ADR Quality — start with build.gradle.+5.2 ptsLowADR Quality
Resolve the 2 Off-boarding risk finding(s) in Bus Factor.+3.5 ptsLowBus Factor
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.+4.8 ptsMediumArchitecture documentation
Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.+3.6 ptsMediumSecurity & performance tooling
Extend structured logging to the remaining runnable modules so everything you run is diagnosable in production.+2.2 ptsMediumObservability
Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.+2.1 ptsMediumRelease Hygiene
Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.+1.7 ptsMediumDocumentation (README)
Thread the coroutine's cancellation through suspend functions that make requests, so the work stops when its caller gives up.+1.5 ptsMediumCancellation propagation

File quality

Per-file score 0–10 — a quality signature. Of 82 files carrying findings, judged against the Production bar: 0% slop · 70% mixed · 30% near-clean.

FileScoreBandWorst signal
REDACTED4.4MixedStatic Analysis (SAST): High: REDACTED
REDACTED4.4MixedStatic Analysis (SAST): High: REDACTED
manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt5.5MixedCyclomatic Complexity: SettingsScreenKt.SettingsScreen (cyclomatic 98)
REDACTED5.8MixedStatic Analysis (SAST): High: REDACTED
server/src/main/java/rikka/shizuku/server/ShizukuService.java6.0MixedExplicit Debt: TodoComment
REDACTED6.3MixedStatic Analysis (SAST): Medium: REDACTED
manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt7.0MixedCyclomatic Complexity: AppsScreenKt.AppsScreen (cyclomatic 83)
manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt7.0MixedCyclomatic Complexity: AppDetailScreenKt.AppDetailScreen (cyclomatic 61)
manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt7.0MixedCyclomatic Complexity: ForceDarkScreenKt.ForceDarkScreen (cyclomatic 21)
server/src/main/java/rikka/shizuku/server/util/Android17Compat.java7.0MixedCognitive Complexity: Android17Compat.checkPermission (cognitive 20)
manager/src/main/java/moe/shizuku/manager/ui/screen/ActivitiesScreen.kt7.0MixedCyclomatic Complexity: ActivitiesScreenKt.ActivitiesScreen (cyclomatic 64)
manager/src/main/java/moe/shizuku/manager/ui/screen/AccessibilityScreen.kt7.0MixedCyclomatic Complexity: AccessibilityScreenKt.AccessibilityScreen (cyclomatic 18)
manager/src/main/java/moe/shizuku/manager/ui/screen/CatalogScreen.kt7.0MixedCyclomatic Complexity: CatalogScreenKt.CatalogScreen (cyclomatic 17)
manager/src/main/java/moe/shizuku/manager/ui/screen/ModulesScreen.kt7.0MixedCyclomatic Complexity: ModulesScreenKt.ModulesScreen (cyclomatic 28)
manager/src/main/java/moe/shizuku/manager/files/AppDataArchive.kt7.0MixedCyclomatic Complexity: AppDataArchive.import (cyclomatic 25)
manager/src/main/java/moe/shizuku/manager/ui/screen/LogScreen.kt7.0MixedCyclomatic Complexity: LogScreenKt.CaptureTab (cyclomatic 20)
manager/src/main/java/moe/shizuku/manager/ui/screen/DisplayScreen.kt7.0MixedCyclomatic Complexity: DisplayScreenKt.DisplayScreen (cyclomatic 16)
manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt7.1MixedCyclomatic Complexity: LabsToggleScreenKt.LabsToggleScreen (cyclomatic 95)
manager/src/main/java/moe/shizuku/manager/start/AdbStartRun.kt7.1MixedCyclomatic Complexity: AdbStartRun.startServer (cyclomatic 70)
manager/src/main/java/moe/shizuku/manager/ui/ShizukuApp.kt7.1MixedCyclomatic Complexity: ShizukuAppKt.TelevisionTabs (cyclomatic 24)

How the grades work

Every finding carries one of four grades. Three say how serious it is. The fourth says this survey could not settle it — and it is a grade, not a gap.

Critical — 23

A definite problem that already costs you something and drags the score down: a missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here tends to cause failures elsewhere.

Serious — 323

Likely wrong, but not failing yet. It degrades the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to carry for two years either.

Minor — 41

Recorded, with no effect on how the codebase functions. Present so the survey is complete, not because it needs doing.

Could not be resolved — 11

Something this survey could not settle from the outside, and which could be critical or serious. Either a control was required and no positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean result. These are excluded from the score rather than awarded a pass, so the number on the cover neither rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each one is named under Limitations.

Methodology & how to trust this report

This survey is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. All 51 evaluated dimensions are computed by tools and static analysis; no language model sets or judges any of them. Overall confidence is 0.9, the weighted average across measured dimensions.

Every figure here is one of two kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10.

What we checked — 51 dimensions across the health lenses
D1D2D3D4D5D6D13D14D15D16D17D19D20D21D26D27D28D29D34D35D36D37D44AX10AX3AX4AX6M1M2M3M4P1P2P3P4P6PF3X1X12X13X15X16X18X2X21X25X27X28X3X30X5

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions
  1. Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 376 of 387 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
  2. Is there a tool behind the number? Every score below names the method that produced it: Roslyn, git or a scanner, not a narrative.
  3. Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

MethodBacksVersionEvaluator
Roslyn static analysisComplexity, cohesion, coupling, dead code, API surface, layering5.3.0✓ deterministic
Native secret scannerHardcoded secrets / credentials1.0.0✓ deterministic
Canine Code Analyzer duplication detector (in-process)Code duplication1.0.0✓ deterministic
Coverage (coverlet / dotnet-coverage)Line & branch coverage10.0.400✓ deterministic
NuGet / dotnetOutdated, vulnerable & deprecated dependencies10.0.400✓ deterministic
git / LibGit2SharpChurn hotspots, knowledge concentration, history2.43.0 · 0.31.0✓ deterministic
gitleaks · semgrep · trivySecrets in history, SAST, CVEs, IaC & container, PII / GDPR1.86.0 · 0.69.3✓ deterministic

Every finding is locatable in findings.md. Run 01a1ea34-8460-7dff-82b8-4ddda8ce8a53.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

  • D8 Code Coverage — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT MEASURED: test source is present (.kt) but the built-in coverage collector has no runner for this repository's ecosystem — so this suite was never executed by it. Not scored — this is a gap in the analyzer's language coverage, not a defect in the repo.
  • D11 Test Reliability — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test source is present (.kt) and this repository declares a JVM test suite (repository root, Gradle), but it was not re-run: the analyzer environment could not run it. Not scored — this is a gap in the analyzer's language coverage, not a finding about this repository.
  • D12 Dependency Hygiene — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Not scored — a Gradle build resolved 343 artifact(s) across its subprojects (135 behind a shipped release, reported), but the currency signal was not established over the whole graph, so this dimension's own question is only partly answered. NOT a finding that these dependencies are current or healthy.
  • D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
  • D22 Internal API Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D22 identifies the intentionally-exposed surface from `IsPackable` and `.Contracts` project names, MSBuild conventions read off the loaded project set. This target exposed no such projects, so the probe never ran; this says nothing about whether the repository has a public API. This repository commits no C#/VB source at all, so there was never an MSBuild project set to read these conventions off. That is OUR side and it is a COLLECTOR gap, not an environment fault: it declares a published package (starter/build.gradle), but no published-package marker D22 reads admitted any project here, so this ecosystem's public API has no collector, and the remedy is to write one — no change to the scan image can close it.
  • D24 Comment Value — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover the language this repository's product is written in, so it had nothing of the product to read. That is a gap in this analyzer's language reach — not a finding about this repository.
  • D32 Data Compliance (PII/GDPR) — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `manager/src/main/java/moe/shizuku/manager/module/ModuleCatalog.kt`, `manager/src/main/java/moe/shizuku/manager/service/StartCircuitBreaker.kt`, `manager/src/main/java/moe/shizuku/manager/ui/component/ContributorAvatars.kt`, `manager/src/main/java/moe/shizuku/manager/ui/component/IntentForm.kt`, `manager/src/main/java/moe/shizuku/manager/ui/screen/CatalogScreen.kt`, … (+1 more) produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
  • AXR1 Runtime accessibility — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Boot via AndroidApp (manager). the Android app did not build — `./gradlew :manager:assembleDebug` exited 1: s.kotlin.platform.type' with value 'androidJvm' but: - No variants exist. * Try: > Creating consumable variants is explained in more detail at https://docs.gradle.org/8.14/userguide/declari…; runtime evidence skipped (launch chosen because manager/build.gradle applies the Android application plugin and gradlew builds it).
  • C2 Access Controls — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These authorization controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks authorization controls.
  • GD1 Unfinished & placeholder code — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, F#, JavaScript/TypeScript, Dart, Ruby, Scala, Rust and Java source only, and this repository's Kotlin, Python, c, cpp is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • IC1 Incompleteness & stubs — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, JavaScript/TypeScript, Java, Dart, Ruby, Scala and Rust source only, and this repository's Kotlin, Python, c, cpp is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • M4 Documentation accuracy — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. M4 checks only the claim kinds adjudicated at or above 95 % precision: links and versions (PREREGISTRATION version 9), and artefact counts an order of magnitude off. Paths, command arguments, installs, environment variables, settings, projects, packages, routes, cd targets, infrastructure products and removed modules are read but not checked, and none of them is reported or counted.
  • P1 CI/CD gates — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. A CI pipeline exists and the word "test" appears, but no explicit test-runner invocation (your stack's test command, or a test job) was matched — so either the gate runs tests through a step this pass could not recognise, or "test" is incidental here (a path, "latest", a reporter). Which of the two it is cannot be settled from this dimension's evidence; the coverage dimensions report whether a suite exists at all. You can widen what we reach: name the test runner explicitly in the pipeline step (your stack's test command, or a job named for the suite) so the gate is unambiguous to a reader and to this pass.
  • P5 DR & Backup — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. No backup/snapshot/replication config, RTO/RPO or restore-procedure documentation was found — and no production persistence was detected either (no data-access packages, no data-store services, no database resources), so there is nothing in this repository whose loss a DR control would recover. If this system's data lives in a platform or ops repo we can't see, that's where the DR evidence belongs.
  • S1 Web-Security Posture — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These web-security controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks web-security controls.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

We assess the repository exactly as committed, and only the repository. By design we do not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

  • D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
  • D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
  • D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
  • D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
  • D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
  • D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
  • D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
  • D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
  • D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
  • D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
  • D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
  • D19 Documentation Quality: Documentation quality publishes two things only: a runnable or packaged unit with no example, and a multi-project root README that maps none of its parts. It does not judge clarity, and its other checks (overview, licence, boilerplate, structure, empty sections, XML-doc coverage) are withheld after adjudication: their candidates are counted in the card's gaps, not shown as rows. A false statement in a document is M4's; units are .NET projects only.
  • D20 ADR Quality: ADR quality checks the structure of the decision records present: it cannot know about decisions made and never recorded, and it does not judge how well a record argues its case. Records in a language the section lexicon does not cover are not evaluated.
  • D21 Naming Consistency: Naming consistency compares each name with the convention its structural peers follow in this repository: it cannot tell whether a consistently used name is a good one, and languages other than C# and TypeScript are not measured.
  • D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
  • D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
  • D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
  • D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
  • D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
  • D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
  • D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
  • AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
  • M4 Documentation accuracy: Documentation accuracy checks links, versions and artefact counts against the tree: other claims (paths, commands, settings, routes) are read but not checked, and it cannot run the onboarding or measure how long a real new joiner takes.
  • P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
  • P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.

Dimensions

D1 · Cyclomatic Complexity6.0 / 10Adequate✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: Documented → Verified → Prevented · effective 6.0 / 10 · rule-coverage 100% · ceiling Prevented

41 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was SettingsScreenKt.SettingsScreen at 98. A further 6 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being FileKindKt.kindOf at 86 — they are counted neither in the figure above nor in this dimension's score. 5 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: manager/src/main/java/moe/shizuku/manager/files/FileKind.kt (FileKindKt.kindOf at 86), manager/src/main/java/moe/shizuku/manager/shell/ShellHostCommands.kt (ShellHostCommands.hintFor at 22), manager/src/main/java/moe/shizuku/manager/manage/PackageTools.kt (StandbyBucket.from at 17), manager/src/main/java/moe/shizuku/manager/install/PackageInspect.kt (PackageInspect.androidName at 16), manager/src/main/java/moe/shizuku/manager/manage/DeviceInfo.kt (DeviceInfo.drainLabel at 16). They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.

SettingsScreenKt.SettingsScreen (cyclomatic 98)manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt:209
LabsToggleScreenKt.LabsToggleScreen (cyclomatic 95)manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt:243
AppsScreenKt.AppsScreen (cyclomatic 83)manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:132
AdbStartRun.startServer (cyclomatic 70)manager/src/main/java/moe/shizuku/manager/start/AdbStartRun.kt:164
ShellScreenKt.ShellScreen (cyclomatic 67)manager/src/main/java/moe/shizuku/manager/ui/screen/ShellScreen.kt:193

+ 36 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 12 bodies over 30 down to 30 or less in Cyclomatic Complexity — start with SettingsScreenKt.SettingsScreen (cyclomatic 98), LabsToggleScreenKt.LabsToggleScreen (cyclomatic 95), AppsScreenKt.AppsScreen (cyclomatic 83). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 12 together lifts Cyclomatic Complexity from 6.0 to about 7.3/10, projected with the scoring formula itself and assuming each lands exactly at 30; a cleaner split scores higher.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

D2 · Cognitive Complexity4.3 / 10Weak✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: Documented → Verified → Prevented · effective 4.3 / 10 · rule-coverage 100% · ceiling Prevented

63 method(s) exceeded the cognitive complexity threshold of 15; the worst was SettingsScreenKt.SettingsScreen at 168.

SettingsScreenKt.SettingsScreen (cognitive 168)manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt:209
ShellScreenKt.ShellScreen (cognitive 121)manager/src/main/java/moe/shizuku/manager/ui/screen/ShellScreen.kt:193
LabsToggleScreenKt.LabsToggleScreen (cognitive 118)manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt:243
AdbStartRun.startServer (cognitive 105)manager/src/main/java/moe/shizuku/manager/start/AdbStartRun.kt:164
AppDetailScreenKt.AppDetailScreen (cognitive 98)manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt:116

+ 58 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 2 bodies over 120 down to 120 or less in Cognitive Complexity — start with SettingsScreenKt.SettingsScreen (cognitive 168), ShellScreenKt.ShellScreen (cognitive 121). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 2 together lifts Cognitive Complexity from 4.3 to about 4.8/10, projected with the scoring formula itself and assuming each lands exactly at 120; a cleaner split scores higher.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

D3 · God Classes7.2 / 10Strong✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: Documented → Verified → Prevented · effective 7.2 / 10 · rule-coverage 100% · ceiling Prevented

45 god class(es) detected.

MethodTooLong: HomeScreenKt.HomeScreen · ×21manager/src/main/java/moe/shizuku/manager/ui/screen/HomeScreen.kt:147
FileTooLong: screen/SettingsScreen.kt · ×16manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt
TooManyMethods: ShizukuSettings · ×5manager/src/main/java/moe/shizuku/manager/ShizukuSettings.java:27
ClassTooLong: ShizukuService · ×3server/src/main/java/rikka/shizuku/server/ShizukuService.java:71

What to do

  1. Resolve the 21 MethodTooLong finding(s) in God Classes — start with LogScreen.kt (2), HomeScreen.kt, ActivitiesScreen.kt. — One of this dimension's main actionable groups (21 warning-level).
  2. Resolve the 16 FileTooLong finding(s) in God Classes — start with SettingsScreen.kt, HomeScreen.kt, ShellScreen.kt. — One of this dimension's main actionable groups (16 warning-level).
  3. Resolve the 5 TooManyMethods finding(s) in God Classes — start with ShizukuSettings.java, Hiding.kt, PackageTools.kt. — One of this dimension's main actionable groups (5 warning-level).

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

D4 · Code Duplication8.2 / 10Strong✓ Tool-verified

What it measures: How much of the production code is copy-pasted: the share of production lines inside a reported copy (every copy of a duplicated block or of an edited member, each line once), 10 at none and 0 at a quarter of the lines.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), scored on the share of production lines inside a reported copy (each line once; 10 at none, 0 at a quarter). Deterministic.

Maturity: Documented → Verified → Prevented · effective 8.2 / 10 · rule-coverage 100% · ceiling Verified

72 duplicated block group(s) detected. 4.4 % of the production lines (2,440 of 55,642) are in a reported copy. A further 31 rows report members as variants of one another; the share counts each copied line once, however many rows cite it.

Duplicated block (11 lines × 2) · ×7manager/src/main/java/moe/shizuku/manager/ui/component/ScrollToTopButton.kt:64
Edited copy of a member (8 corresponding lines) · ×4manager/src/main/java/moe/shizuku/manager/manage/Hiding.kt:946
Duplicated block (8 lines × 2) · ×4manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:478
Duplicated block (6 lines × 2) · ×4manager/src/main/java/moe/shizuku/manager/manage/WifiControl.kt:314
Duplicated block (7 lines × 2) · ×4manager/src/main/java/moe/shizuku/manager/service/LabTileService.kt:97

+ 63 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 7 Duplicated block (11 lines × 2) finding(s) in Code Duplication — start with SettingsScreen.kt (3), ScrollToTopButton.kt, AccessibilityScreen.kt. — One of this dimension's main actionable groups (7 warning-level).
  2. Resolve the 4 Edited copy of a member (8 corresponding lines) finding(s) in Code Duplication — start with Hiding.kt, AppDetailScreen.kt, AccessibilityKeepAliveService.kt. — One of this dimension's main actionable groups (4 warning-level).
  3. Resolve the 4 Duplicated block (8 lines × 2) finding(s) in Code Duplication — start with AppsScreen.kt, AppDetailScreen.kt, IContentProviderUtils.java. — One of this dimension's main actionable groups (4 warning-level).

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

D5 · Coupling10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.

Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.

Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

9 production modules (Gradle+CMake), 0 dependency cycle(s), 0 unstable depended-on module(s). Read from the build's own module declarations; edges a convention plugin adds from buildSrc or build-logic are not visible there; 1 module(s) off the main sequence, with abstractness counted on 7 of the 9 (the rest declare no modelled class or interface, export only macros, declare types in source no model reads, or have no source directory of their own).

Off the main sequence: :common

✓ On the Gold path — maintain.

Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.

D6 · Cohesion (LCOM4)10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 31 classes have LCOM4 above 3.

✓ On the Gold path — maintain.

Detailed fixes: d6_recommendation.md.

D13 · Secret Scanning10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

Secret scan ran and found no leaked secrets.

✓ On the Gold path — maintain.

Detailed fixes: d13_recommendation.md.

D14 · License Compliance10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the licenses of third-party packages are compatible with your policy.

Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 27 declared JVM dependency artifact(s) use a banned license. Licences were resolved from the POMs Maven Central publishes, over the coordinates this repository's 7 Maven/Gradle manifest(s) declare with a version resolvable from the manifest itself — the same declaration-site closure this analysis reads for dependency currency. The JVM has no lockfile a checkout is guaranteed to carry, so this is deliberately NOT the transitive closure. A further 17 coordinate(s) are not published to Maven Central — another repository (Google's Maven hosts androidx), a SNAPSHOT, or a private artifact — so their licences are not readable from here and they are outside this verdict.

✓ On the Gold path — maintain.

Detailed fixes: d14_recommendation.md.

D15 · Churn × Complexity Hotspots8.2 / 10Strong✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: Documented → Verified → Prevented · effective 8.2 / 10 · rule-coverage 100% · ceiling Documented

Top hotspots: manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt (62×98=6076); manager/src/main/java/moe/shizuku/manager/ui/screen/HomeScreen.kt (100×43=4300); manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt (44×83=3652) Repeated repair below the complexity floor: manager/src/main/java/moe/shizuku/manager/worker/AdbStartWorker.kt (33 of 48 changes were fixes); manager/src/main/java/moe/shizuku/manager/adb/AdbStarter.kt (15 of 24 changes were fixes); manager/src/main/java/moe/shizuku/manager/utils/ShizukuStateMachine.kt (11 of 19 changes were fixes)

Hotspot: manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt · ×26manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt:209
Repeated repair: manager/src/main/java/moe/shizuku/manager/worker/AdbStartWorker.kt · ×15manager/src/main/java/moe/shizuku/manager/worker/AdbStartWorker.kt:109

What to do

  1. Resolve the 26 Hotspot finding(s) in Churn × Complexity Hotspots — start with SettingsScreen.kt, HomeScreen.kt, AppsScreen.kt. — One of this dimension's main actionable groups (26 warning-level).
  2. Resolve the 15 Repeated repair finding(s) in Churn × Complexity Hotspots — start with AdbStartWorker.kt, AdbStarter.kt, ShizukuStateMachine.kt. — One of this dimension's main actionable groups (15 warning-level).

Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.

D16 · Bus Factor5.2 / 10Adequate✓ Tool-verified

What it measures: Whether knowledge is concentrated in too few people (the "bus factor").

Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.

Maturity: Documented → Verified → Prevented · effective 5.2 / 10 · rule-coverage 100% · ceiling Documented

86 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt. Counted over 181 of the 256 production source files in this repository: 70 are under the ~2,400-byte size floor this dimension measures over, and the remaining 5 have no attributable history left to measure.

Off-boarding risk: anonymized user #1 · ×2

What to do

  1. Resolve the 2 Off-boarding risk finding(s) in Bus Factor. — One of this dimension's main actionable groups (2 recommendation-level).

Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.

D17 · Explicit Debt10.0 / 10Stronggated by 2 serious findings✓ Tool-verified

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

2 deducted task-comment markers across 55642 LoC (0.0/KLoC) → score 10.0. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.

TodoComment · ×2server/src/main/java/rikka/shizuku/server/ShizukuService.java:688

What to do

  1. Resolve the 2 TodoComment finding(s) in Explicit Debt — start with ShizukuService.java (2). — One of this dimension's main actionable groups (2 warning-level).

Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.

D19 · Documentation Quality10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the project's documentation is clear, complete, and useful.

Method: Every README, docs/ document and root guide parsed by its markup and measured in Unicode letters. Published: a runnable or packaged .NET project whose README (or a document it links, or a root guide) shows no example, and a root README naming none of three or more projects. Overview, licence, boilerplate, wall-of-text, empty-section and XML-doc rows are measured and withheld (counted in gaps) after adjudication. Deterministic, exhaustive, advisory.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

2 of 2 documentation facets pass in full. 3 document(s) read across 7 unit(s).

✓ On the Gold path — maintain.

Detailed fixes: d19_recommendation.md.

D20 · ADR Quality0.0 / 10Critical✓ Tool-verified

What it measures: Whether architecture decisions are recorded well (context, decision, consequences).

Method: Every ADR read by its section structure: nine located rules (a missing Decision, Context or Consequences section, a stale status, two records deciding the same question, a dangling supersede link, a number-only title, a single option, no named cost, no status where the log uses one, no enforcement field where the log adopted one), each a fixed deduction from 10; the score is the mean over evaluated records. Deterministic, no model. Advisory.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

No architecture decision records were found.

No ADRs foundstub/build.gradle:2

What to do

  1. Resolve the 1 No ADRs found finding(s) in ADR Quality — start with build.gradle. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d20_recommendation.md · top locations in Appendix A, every location in findings.md.

D21 · Naming Consistency10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether names — types, methods, variables — are clear and consistent.

Method: Seven vocabulary-free rules (N1-N7) mine each naming convention from the repository and flag a name that breaks a convention its structural peers in the same unit follow; production C# and TypeScript, each its own population. Deterministic, no model, no sample. Advisory.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 naming inconsistencies among 28 declarations measured against a convention their peers follow.

✓ On the Gold path — maintain.

Detailed fixes: d21_recommendation.md.

D26 · Project Cohesion7.1 / 10Strong✓ Tool-verified

What it measures: Whether each project is a focused, coherent unit rather than an oversized grab-bag.

Method: Project size overshoot penalties (LoC / public-type count / namespace count, 2-of-3 flag) weighted by log magnitude. Exhaustive across projects, deterministic.

Maturity: Documented → Verified → Prevented · effective 7.1 / 10 · rule-coverage 100% · ceiling Documented

1 of 7 build units (Gradle) flagged as possibly oversized/incoherent.

Projects may be oversized for their cohesionmanager/build.gradle:1

What to do

  1. Resolve the 1 Projects may be oversized for their cohesion finding(s) in Project Cohesion — start with build.gradle. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.

D27 · Navigability10.0 / 10Exemplary✓ Tool-verified

What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.

Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps. C# also names each pass-through layer (a class whose every public method only forwards its own parameters to one collaborator) as a located finding; the score is not affected.

Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

26 % of calls cross a namespace and 0 % go through an interface, but 100 % of collaborators are co-located — so a call's collaborators sit together and tracing stays easy. Baseline: small — navigation cost is tolerated.

✓ On the Gold path — maintain.

Detailed fixes: d27_recommendation.md.

D28 · Secrets (history)10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

gitleaks scanned the full history AND the current working tree and found no secrets.

✓ On the Gold path — maintain.

Detailed fixes: d28_recommendation.md.

D29 · Static Analysis (SAST)2.4 / 10Critical✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: Documented → Verified → Prevented · effective 2.4 / 10 · rule-coverage 100% · ceiling Documented

27 finding(s): 0 critical, 23 high, 4 medium, 0 low. 16 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. semgrep hit a parse error in 3 file(s) — `.github/scripts/virustotal-scan.sh` (line 4), `gradlew` (line 74, line 180), `manager/src/main/java/moe/shizuku/manager/ui/component/ContributorAvatars.kt` (line 150, line 159) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. Separately, one or more rules could not re-parse an embedded snippet in 2 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

+ 2 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 3 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (3). — One of this dimension's main actionable groups (3 issue-level).
  2. Resolve the 2 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2). — One of this dimension's main actionable groups (2 issue-level).
  3. No action in Static Analysis (SAST) — all 16 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (16 issue-level, 0 of them charged here).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

D34 · Knowledge Freshness9.4 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.

Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.

Maturity: Documented → Verified → Prevented · effective 9.4 / 10 · rule-coverage 100% · ceiling Documented

11 of 186 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is REDACTED. Counted over 186 of the 256 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.

Orphaned file · ×11REDACTED:1
Orphaned files with no living knowledge

✓ On the Gold path — maintain.

Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.

D35 · Change Coupling9.9 / 10Stronggated by 3 serious findings✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.

Maturity: Documented → Verified → Prevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Documented

Strongest change-coupling: StealthTutorialViewModel.kt↔ApkUtils.kt 62%; SettingsScreen.kt↔Theme.kt 60%; MainActivity.kt↔HomeScreen.kt 50%

Change coupling: StealthTutorialViewModel.kt ↔ ApkUtils.kt · ×3manager/src/main/java/moe/shizuku/manager/stealth/StealthTutorialViewModel.kt:1

What to do

  1. Resolve the 3 Change coupling finding(s) in Change Coupling — start with StealthTutorialViewModel.kt, SettingsScreen.kt, MainActivity.kt. — One of this dimension's main actionable groups (3 warning-level).

Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.

D36 · Supply-chain Provenance & Signing5.0 / 10Adequate✓ Tool-verified

What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.

Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.

Maturity: Documented → Verified → Prevented · effective 5.0 / 10 · rule-coverage 100% · ceiling Documented

2/4 supply-chain integrity signals present (provenance, signing, SBOM, pinned actions).

REDACTED
REDACTED

What to do

  1. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
  2. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.

D37 · Vulnerability-disclosure Policy10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the repository publishes a coordinated-vulnerability-disclosure policy (SECURITY.md or security.txt) with a reporting contact, so finders know how to report a vulnerability. Presence of a policy file with a contact, not whether the policy is adequate or honoured.

Method: Vulnerability-disclosure policy read deterministically from the repo: a SECURITY.md (root/.github/docs) or .well-known/security.txt / security.txt, regex-checked for a reporting contact (email / URL / mailto). Present + contact → 10; present without a contact → 4; NotApplicable when no policy file exists (it may live off-repo). Detects the policy file's presence + contact, not its adequacy.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

A vulnerability-disclosure policy (SECURITY.md) is published with a reporting contact.

✓ On the Gold path — maintain.

Detailed fixes: d37_recommendation.md.

D44 · Platform End-of-Life10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.

Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 2 platform declaration(s) and 45 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.

✓ On the Gold path — maintain.

Detailed fixes: d44_recommendation.md.

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AX10 · Code composition10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

AX3 · Project dependency cycles10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).

Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.

AX4 · Dependency direction10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.

Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.

AX6 · Interface segregation10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').

Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.

M1 · Documentation (README)6.7 / 10Adequate✓ Tool-verified

Maturity · Maturity — Whether the repository and its projects have a README, and whether it is substantive.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

What to do

  • Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
M2 · Architecture documentation0.0 / 10Critical✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

  • No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
  • No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.

What to do

  • Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
  • Add a C4 context/container diagram (Structurizr, PlantUML or Mermaid) or an architecture.md overview.
M3 · Folder & project structure10.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether the repository is organised deliberately: production code and tests are set apart in a way its ecosystem or the repository itself declares.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

M4 · Documentation accuracy10.0 / 10Exemplary○ Nothing flagged

Maturity · Maturity — Whether the project's current-state documentation describes the code that exists.

Method: Every current-state document's checkable claims looked up in the tree (links, versions, and artefact counts an order of magnitude off), plus two README checks: an advertised infrastructure product with no footprint, and a module the CHANGELOG records as removed. Deterministic, no model. Advisory.

P1 · CI/CD gates8.5 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

What to do

  • Run the test suite in CI via an explicit runner step (`./gradlew test` for the toolchain this pipeline already uses) and gate merges on it.
P2 · Observability4.8 / 10Weak✓ Tool-verified

Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.

Method: Filesystem/Roslyn scan: structured-logging frameworks (Serilog, NLog), OpenTelemetry, and health-check endpoint patterns. Exhaustive, deterministic.

  • Only 1/4 runnable modules use logging (modules with no entry point or server are excluded — they are libraries a runnable module hosts). Silent: `server`, `shell`, `starter`.

What to do

  • Extend structured logging to the remaining runnable modules so everything you run is diagnosable in production.
P3 · Security & performance tooling3.0 / 10Weak✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

  • No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 8 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner. — REDACTED:12
  • `REDACTED` schedules updates, but no `package-ecosystem` entry covers `gradle`, `gitsubmodule`, which this tree depends on — so those dependencies get no update pull requests and no advisory pressure, however complete the dep-scan credit looks. Add the missing entries to the `updates:` list. — REDACTED:10

What to do

  • Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
  • Dependabot is configured but does not watch `gradle`, `gitsubmodule` — add those `package-ecosystem` entries to REDACTED so those dependencies get the same automatic update and advisory pressure as the ones it already covers.
  • Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
P4 · Deployment & Rollback7.0 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.

Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.

P6 · Release Hygiene5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.

Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.

  • No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)

What to do

  • Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.
PF3 · Async & latency hygiene10.0 / 10Exemplary✓ Tool-verified

Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.

Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from each language's code model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.

X1 · Async correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.

Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.

X12 · Unreachable branch10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.

Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.

X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.

Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.

X15 · Unvalidated length from an untrusted reader2.7 / 10Weak✓ Tool-verified

Other · Security — Whether a length read out of the stream being parsed is bounded before it is allocated or read — an unchecked count taken from the input lets the input choose the allocation.

Method: Roslyn syntax + semantics: integer lengths read from a BinaryReader and spent on a bulk read or an array allocation, checked for any comparison or bounding call on the value anywhere in the method. Deterministic, provable per finding. Advisory.

  • `count` is read from the bytes being parsed at line 784 (`readInt`), then used to size a `new int[]` at line 785 — and nowhere in its scope is `count` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). Whoever wrote those bytes therefore chooses the allocation directly: a 32-bit length asks for up to 2 GiB before a single byte of the payload is known to exist, which either exhausts the heap with an `OutOfMemoryError` or, negative, throws `NegativeArraySizeException` out of a parser whose failure path was written for malformed input, not for hostile input. Bound `count` against the bytes actually remaining and a maximum the format allows before allocating. — server/src/main/java/rikka/shizuku/server/ShizukuService.java:785
  • `dataLength` is read from the bytes being parsed at line 143 (`int`), then used to size a `ByteArray` at line 148 — and nowhere in its scope is `dataLength` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). Whoever wrote those bytes therefore chooses the allocation directly: a 32-bit length asks for up to 2 GiB before a single byte of the payload is known to exist, which either exhausts the heap with an `OutOfMemoryError` or, negative, throws `NegativeArraySizeException` out of a parser whose failure path was written for malformed input, not for hostile input. Bound `dataLength` against the bytes actually remaining and a maximum the format allows before allocating. — manager/src/main/java/moe/shizuku/manager/adb/AdbClient.kt:148

What to do

  • Each finding names the read that takes the length from the input and the site that spends it, and states that the value is never compared in between. Confirm from the two, then bound the length against the remaining stream before using it.
X16 · Unfloored truncation loop10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.

Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.

X18 · Disposal-pattern correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.

Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.

X2 · Cancellation propagation4.0 / 10Weak✓ Tool-verified

Other · Code Health — Whether suspend functions that make a cancellable request accept or pass on the coroutine's cancellation (adoption curve).

Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.

  • Only 0/1 suspend functions that make a cancellable request (Ktor, OkHttp newCall, URL streams) accept the coroutine's cancellation or pass one on, so a request keeps running after whatever wanted it has given up — a screen navigated away from, a disposed widget, a superseded search. In a suspend function, make the request with a call that suspends — Ktor, OkHttp's `executeAsync()`, or a `suspendCancellableCoroutine` that cancels the `Call` — not a blocking `execute()`: `withContext(Dispatchers.IO)` moves the call off the caller's thread but does not make it cancellable; where nothing could ever cancel the call, omitting it is a deliberate choice — judge against how the function is used.
  • `download` suspends, but makes its request with `newCall(…).execute()`, which blocks: its caller's cancellation cannot reach the request, so it runs to its end after whatever wanted it has given up — `withContext(Dispatchers.IO)` moves it off the caller's thread and does not change that. Make the request with a call that suspends: Ktor, OkHttp's `executeAsync()`, or a `suspendCancellableCoroutine` over `enqueue` that cancels the `Call` in `invokeOnCancellation`. — manager/src/main/java/moe/shizuku/manager/utils/UpdateHelper.kt:389

What to do

  • Thread the coroutine's cancellation through suspend functions that make requests, so the work stops when its caller gives up.
X21 · Side-effecting pattern guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.

Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.

X25 · Inert configuration knob10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.

Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.

X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether an enhanced `for` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is iterating invalidates the fail-fast iterator it is holding, so the next `next()` throws `ConcurrentModificationException` and the remaining elements are never seen. Whether a `for` loop leaves the `dict`, `set` or `deque` it is walking alone — CPython's iterators over those check that the collection has not changed size since the loop began, so a body that removes from (or empties) the very collection the loop is walking makes the next step raise `RuntimeError: dictionary changed size during iteration` and the remaining items are never seen. Whether a `for (x in c)` or `c.forEach { … }` leaves the collection it is walking alone — a `mutableListOf`/`ArrayList`, `mutableMapOf`/`HashMap` or `mutableSetOf`/`HashSet` is a `java.util` collection on the JVM and is walked by its own fail-fast iterator, so a body that adds to or removes from the very collection the loop is walking makes the next step throw `ConcurrentModificationException` and the remaining elements are never seen.

Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.

X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.

Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.

X3 · Exception handling5.9 / 10Adequate✓ Tool-verified

Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.

Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.

  • An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. (×2) — manager/src/main/java/moe/shizuku/manager/utils/CustomTabsHelper.java:84, manager/src/main/java/moe/shizuku/manager/authorization/RequestPermissionActivity.kt:67
  • `catch (tr: Throwable)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. — manager/src/main/java/moe/shizuku/manager/utils/MoreApps.kt:49
  • `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×4) — manager/src/main/java/moe/shizuku/manager/legacy/LegacyIsNotSupportedActivity.kt:48, manager/src/main/java/moe/shizuku/manager/home/AdbPairDialogFragment.kt:77, manager/src/main/java/moe/shizuku/manager/authorization/RequestPermissionActivity.kt:109, …
  • An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `close()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: narrow the catch to the exception this release can actually raise, and record it through whatever this codebase already uses to report problems — or, if it truly cannot matter, say why in a comment on the catch. (×9) — manager/src/main/java/moe/shizuku/manager/adb/AdbClient.kt:162, manager/src/main/java/moe/shizuku/manager/adb/AdbClient.kt:166, manager/src/main/java/moe/shizuku/manager/adb/AdbClient.kt:170, …
  • `catch (Throwable)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. — common/src/main/java/moe/shizuku/common/util/OsUtils.java:15

What to do

  • Swallowed exception (empty catch)
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.

Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.

X5 · Nullable reference types9.9 / 10Exemplary✓ Tool-verified

Other · Code Health — Whether Kotlin's null safety is not undermined by not-null assertions — `String` cannot hold null and `String?` must be checked before use in every Kotlin module, and each `!!` is a run-time `NullPointerException` the author has told the compiler cannot happen.

Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

LensScoreRatingImpact
Code Health66.3AdequateAcceptable, with room to improve.
Architecture97.6ExemplarySolid.
Maturity54.7Adequate — gated by M2Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Readiness53.0Adequate — gated by P3Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Security74.8Adequate — gated by D29Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Performance100.0ExemplaryStrongest area.
Unscored — 2 check(s) recorded observations but carry no score

These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.

  • X10 Duplicated predicate — 7 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
  • X7 Silent fallback defaults — 9 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 1 control(s) we could not find positive evidence for

These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.

  • P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 62 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

  • AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
  • AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
  • AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
  • AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
  • AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
  • AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
  • AX1 Captive dependencies — Not applicable: this repository's Java imports no dependency-injection container and defines no container of its own — nothing that both registers and resolves bindings, and nothing that names two lifetimes — so nothing holds one lifetime's instance while handing out another's; this repository's Kotlin imports no dependency-injection container and defines no container of its own — nothing that both registers and resolves bindings, and nothing that names two lifetimes — so nothing holds one lifetime's instance while handing out another's.
  • AX2 Stateful singletons — No container singleton was found, so there is no shared instance for concurrent requests to race on. No class in this Java code is a Spring, JSR-330 or CDI singleton bean. No class in this Kotlin code is a Spring, JSR-330 or CDI singleton bean. No function in this Python code is served by a threaded web framework (a Flask, Bottle or FastAPI route, a Django or Pyramid view), so no module is shared between request threads.
  • AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX7 Slice cohesion — not applicable — not a vertical-slice architecture
  • AX8 Test isolation — no test/production split to check
  • AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
  • AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • AXR1 Runtime accessibility — the Android app did not build — `./gradlew :manager:assembleDebug` exited 1: s.kotlin.platform.type' with value 'androidJvm' but: - No variants exist. * Try: > Creating consumable variants is explained in more detail at https://docs.gradle.org/8.14/userguide/declari…; runtime evidence skipped (launch chosen because manager/build.gradle applies the Android application plugin and gradlew builds it) This is a statement about this run, not a statement about your application: nothing here says the app is inaccessible, only that it was never run.
  • C1 Data Protection — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no data at rest for these controls to protect.
  • C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C3 Audit Trail — No personal data detected in a persisted data model — no PII-named column (email, first_name, date_of_birth, phone_number, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no sensitive data whose changes an audit trail would record. If it does (through a store configured outside this repository, for instance), the trail belongs to wherever that data is stored.
  • C4 Data Retention — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no personal data whose lifetime a retention limit would bound.
  • C5 Data-Subject Rights — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no personal data for a data subject to erase, export or consent over.
  • D10 Test Quality — ~4505 lines of test source are present (.kt) but no test cases reached the test census for this repository — no test root we could resolve declared them, or the files we read declare no cases in a test framework we recognise — so skipped/assertion-free tests couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
  • D11 Test Reliability — Test reliability not included — the .kt suite was found but not re-run
  • D12 Dependency Hygiene — Not scored — a Gradle build resolved 343 artifact(s) across its subprojects (135 behind a shipped release, reported), but the currency signal was not established over the whole graph, so this dimension's own question is only partly answered. NOT a finding that these dependencies are current or healthy.
  • D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
  • D22 Internal API Consistency — The exposed public-API surface could not be collected — no C#/VB projects loaded.
  • D23 Boundary Type-Coupling — No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ sibling projects each declaring an entity of their own or taking another project's integration events. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
  • D24 Comment Value — D24 reads C#, Visual Basic, TypeScript and JavaScript comments only — this repository's production source is .java, .kt, .py, which was left unread. Not scored: this is a gap in the analyzer, not a verdict about this repository.
  • D25 ADR Conformance — no ADRs to check
  • D30 Dependency Vulnerabilities — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle build (build.gradle/build.gradle.kts) — not scanned yet).
  • D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
  • D32 Data Compliance (PII/GDPR) — 6 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
  • D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
  • D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
  • D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
  • D43 Malicious Dependencies — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle build (build.gradle/build.gradle.kts) — not scanned yet).
  • D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
  • D8 Code Coverage — Coverage not included — suite not readable by the collector
  • DM1 Domain Modelling — applicable but not scored (2 of 3 signals for this style — below the bar we score at): 111 value object(s); 6 domain event(s); its domain events are published by services or handlers — no domain entity raises one
  • ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
  • ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
  • ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
  • GD1 Unfinished & placeholder code — no source files were read — this check reads C#, F#, JavaScript/TypeScript, Dart, Ruby, Scala, Rust and Java, and none was read for this repository's product. That is a limit of the analyzer, not a finding about your code.
  • IC1 Incompleteness & stubs — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, and the automatic-re-run check to any GitHub-Actions workflow, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
  • P7 Outbound HTTP resilience — not applicable — no HTTP server, API framework or worker entry point was found in the JVM, Python source, so there is no service whose uptime a failing dependency could take down
  • P8 Schema migrations — no ORM, schema-migration tool or schema auto-create was found in this repository's dependency manifests or source, so there is no database schema for this check to judge
  • P9 Domain vs controller coverage — coverage not measured: this check compares the coverage of the analyzer's own test run across the domain and web layers, and that run measured none here — Test coverage (D8) says why
  • PF1 Benchmark discipline — Not applicable: no benchmark suite was found. This check searched for `@Benchmark` in a Java, Kotlin or Scala file importing JMH or kotlinx-benchmark, Jetpack Benchmark's `measureRepeated` in a file importing androidx.benchmark, or JMH/kotlinx-benchmark/androidx.benchmark in a pom.xml, Gradle or sbt build, and for a `*benchmark*` script that this repository's CI runs. Benchmarks are credited as a bonus, so their absence is neither scored nor deducted.
  • PF2 Allocation hygiene — Not scored: this check counted allocation-aware idioms (Span, pools, stackalloc) per line, which describes what kind of code a repository is rather than whether it has an allocation problem, so it was withdrawn. Nothing here is a finding about your code.
  • S1 Web-Security Posture — Not assessed: these web-security controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks web-security controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • X14 Bypassable address classification — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X17 Uncapped recursion over a caller-supplied document — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X19 Unrestored process-global state — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X20 Mistyped argument guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X22 Contradicted release guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X23 Unguarded diagnostic materialisation — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X24 Document value interpolated into markup unescaped — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X26 Unsynchronised callback handoff — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X29 Per-element action decided by a fixed element — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
  • X4 Structured logging — This check asks whether log calls keep a message's values apart from its text, which needs a logger that can carry them as fields. This repository's Kotlin was read, and it logs through none that an assembled message defeats: Android's `Log` and Timber, java.util.logging and log4j-api-kotlin take one finished message (as log4net does in C#), or it makes no call through a named logger at all. Calls made through SLF4J, log4j 2 or kotlin-logging (`LoggerFactory.getLogger`, `KotlinLogging.logger {}`) would be judged.
  • X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Critical — 23 finding(s)
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
Serious — 323 finding(s)
D15 · Churn × Complexity Hotspots · Hotspot · ×26
  • Hotspot: manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt:209 — manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt changed 62 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 98 in SettingsScreenKt.SettingsScreen at line 209. 23 of those changes were fix/bug commits, and the other 39 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: manager/src/main/java/moe/shizuku/manager/ui/screen/HomeScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/HomeScreen.kt:147 — manager/src/main/java/moe/shizuku/manager/ui/screen/HomeScreen.kt changed 100 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 43 in HomeScreenKt.HomeScreen at line 147. 51 of those changes were fix/bug commits, so the churn is repair rather than feature work. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/ui/screen/HomeScreen.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:132 — manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt changed 44 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 83 in AppsScreenKt.AppsScreen at line 132. 15 of those changes were fix/bug commits, and the other 29 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt:243 — manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt changed 33 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 95 in LabsToggleScreenKt.LabsToggleScreen at line 243. 11 of those changes were fix/bug commits, and the other 22 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: manager/src/main/java/moe/shizuku/manager/ui/screen/ManageScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/ManageScreen.kt:166 — manager/src/main/java/moe/shizuku/manager/ui/screen/ManageScreen.kt changed 31 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 62 in ManageScreenKt.ManageScreen at line 166. 11 of those changes were fix/bug commits, and the other 20 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/ui/screen/ManageScreen.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: manager/src/main/java/moe/shizuku/manager/ui/ShizukuApp.kt manager/src/main/java/moe/shizuku/manager/ui/ShizukuApp.kt:859 — manager/src/main/java/moe/shizuku/manager/ui/ShizukuApp.kt changed 62 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 24 in ShizukuAppKt.TelevisionTabs at line 859. 14 of those changes were fix/bug commits, and the other 48 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/ui/ShizukuApp.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: manager/src/main/java/moe/shizuku/manager/ui/screen/ShellScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/ShellScreen.kt:193 — manager/src/main/java/moe/shizuku/manager/ui/screen/ShellScreen.kt changed 21 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 67 in ShellScreenKt.ShellScreen at line 193. 6 of those changes were fix/bug commits, and the other 15 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/ui/screen/ShellScreen.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt:116 — manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt changed 21 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 61 in AppDetailScreenKt.AppDetailScreen at line 116. 6 of those changes were fix/bug commits, and the other 15 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: manager/src/main/java/moe/shizuku/manager/receiver/ShizukuReceiverStarter.kt manager/src/main/java/moe/shizuku/manager/receiver/ShizukuReceiverStarter.kt:249 — manager/src/main/java/moe/shizuku/manager/receiver/ShizukuReceiverStarter.kt changed 41 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 18 in ShizukuReceiverStarter.adbStart at line 249. 23 of those changes were fix/bug commits, so the churn is repair rather than feature work. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/receiver/ShizukuReceiverStarter.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: manager/src/main/java/moe/shizuku/manager/ui/screen/ActivitiesScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/ActivitiesScreen.kt:98 — manager/src/main/java/moe/shizuku/manager/ui/screen/ActivitiesScreen.kt changed 11 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 64 in ActivitiesScreenKt.ActivitiesScreen at line 98. 2 of those changes were fix/bug commits, and the other 9 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/ui/screen/ActivitiesScreen.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: manager/src/main/java/moe/shizuku/manager/ui/screen/ModulesScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/ModulesScreen.kt:134 — manager/src/main/java/moe/shizuku/manager/ui/screen/ModulesScreen.kt changed 23 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 28 in ModulesScreenKt.ModulesScreen at line 134. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/ui/screen/ModulesScreen.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: manager/src/main/java/moe/shizuku/manager/service/WatchdogService.kt manager/src/main/java/moe/shizuku/manager/service/WatchdogService.kt:221 — manager/src/main/java/moe/shizuku/manager/service/WatchdogService.kt changed 25 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 24 in WatchdogService.attemptRestart at line 221. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/service/WatchdogService.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: manager/src/main/java/moe/shizuku/manager/ui/screen/StealthScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/StealthScreen.kt:90 — manager/src/main/java/moe/shizuku/manager/ui/screen/StealthScreen.kt changed 13 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 22 in StealthScreenKt.StealthScreen at line 90. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/ui/screen/StealthScreen.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: manager/src/main/java/moe/shizuku/manager/start/AdbStartRun.kt manager/src/main/java/moe/shizuku/manager/start/AdbStartRun.kt:164 — manager/src/main/java/moe/shizuku/manager/start/AdbStartRun.kt changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 70 in AdbStartRun.startServer at line 164. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/start/AdbStartRun.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: server/src/main/java/rikka/shizuku/server/ShizukuService.java server/src/main/java/rikka/shizuku/server/ShizukuService.java:547 — server/src/main/java/rikka/shizuku/server/ShizukuService.java changed 15 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 17 in ShizukuService.dispatchPermissionConfirmationResult at line 547. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- server/src/main/java/rikka/shizuku/server/ShizukuService.java`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:84 — manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt changed 10 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 21 in ForceDarkScreenKt.ForceDarkScreen at line 84. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: manager/src/main/java/moe/shizuku/manager/ui/screen/WifiPasswordsScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/WifiPasswordsScreen.kt:117 — manager/src/main/java/moe/shizuku/manager/ui/screen/WifiPasswordsScreen.kt changed 6 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 32 in WifiPasswordsScreenKt.WifiPasswordsScreen at line 117. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/ui/screen/WifiPasswordsScreen.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: manager/src/main/java/moe/shizuku/manager/ui/screen/LogScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/LogScreen.kt:342 — manager/src/main/java/moe/shizuku/manager/ui/screen/LogScreen.kt changed 9 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 20 in LogScreenKt.CaptureTab at line 342. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/ui/screen/LogScreen.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: ci/check-translations.py ci/check-translations.py:144 — ci/check-translations.py changed 5 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 33 in check-translations.main at line 144. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- ci/check-translations.py`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: manager/src/main/java/moe/shizuku/manager/ui/screen/FilesScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/FilesScreen.kt:144 — manager/src/main/java/moe/shizuku/manager/ui/screen/FilesScreen.kt changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 40 in FilesScreenKt.FilesScreen at line 144. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/ui/screen/FilesScreen.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: manager/src/main/java/moe/shizuku/manager/ui/screen/CatalogScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/CatalogScreen.kt:196 — manager/src/main/java/moe/shizuku/manager/ui/screen/CatalogScreen.kt changed 8 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 17 in CatalogScreenKt.CatalogScreen at line 196. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/ui/screen/CatalogScreen.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: server/src/main/java/rikka/shizuku/server/ShizukuConfigManager.java server/src/main/java/rikka/shizuku/server/ShizukuConfigManager.java:123 — server/src/main/java/rikka/shizuku/server/ShizukuConfigManager.java changed 5 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 26 in ShizukuConfigManager.<init> at line 123. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- server/src/main/java/rikka/shizuku/server/ShizukuConfigManager.java`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: manager/src/main/java/moe/shizuku/manager/ui/screen/InstallerScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/InstallerScreen.kt:130 — manager/src/main/java/moe/shizuku/manager/ui/screen/InstallerScreen.kt changed 5 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 20 in InstallerScreenKt.InstallerScreen at line 130. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/ui/screen/InstallerScreen.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt:103 — manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 21 in RotationScreenKt.RotationScreen at line 103. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: manager/src/main/java/moe/shizuku/manager/ui/screen/HomeDiagnostics.kt manager/src/main/java/moe/shizuku/manager/ui/screen/HomeDiagnostics.kt:62 — manager/src/main/java/moe/shizuku/manager/ui/screen/HomeDiagnostics.kt changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 16 in HomeDiagnosticsKt.buildDiagnostics at line 62. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/ui/screen/HomeDiagnostics.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • + 1 more in this group — see findings.md.
D3 · God Classes · MethodTooLong · ×21
  • MethodTooLong: HomeScreenKt.HomeScreen manager/src/main/java/moe/shizuku/manager/ui/screen/HomeScreen.kt:147 — MethodTooLong — HomeScreen runs 497 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 397 over it, 4.97× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ActivitiesScreenKt.ActivitiesScreen manager/src/main/java/moe/shizuku/manager/ui/screen/ActivitiesScreen.kt:98 — MethodTooLong — ActivitiesScreen runs 384 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 284 over it, 3.84× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ManageScreenKt.ManageScreen manager/src/main/java/moe/shizuku/manager/ui/screen/ManageScreen.kt:166 — MethodTooLong — ManageScreen runs 347 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 247 over it, 3.47× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: FilesScreenKt.FilesScreen manager/src/main/java/moe/shizuku/manager/ui/screen/FilesScreen.kt:144 — MethodTooLong — FilesScreen runs 336 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 236 over it, 3.36× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: DeviceInfoScreenKt.DeviceInfoScreen manager/src/main/java/moe/shizuku/manager/ui/screen/DeviceInfoScreen.kt:74 — MethodTooLong — DeviceInfoScreen runs 308 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 208 over it, 3.08× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: AdbStartRun.startServer manager/src/main/java/moe/shizuku/manager/start/AdbStartRun.kt:164 — MethodTooLong — startServer runs 263 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 163 over it, 2.63× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: CatalogScreenKt.CatalogScreen manager/src/main/java/moe/shizuku/manager/ui/screen/CatalogScreen.kt:196 — MethodTooLong — CatalogScreen runs 242 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 142 over it, 2.42× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: RotationScreenKt.RotationScreen manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt:103 — MethodTooLong — RotationScreen runs 225 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 125 over it, 2.25× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: PermissionsScreenKt.PermissionsScreen manager/src/main/java/moe/shizuku/manager/ui/screen/PermissionsScreen.kt:88 — MethodTooLong — PermissionsScreen runs 205 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 105 over it, 2.05× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ForceDarkScreenKt.ForceDarkScreen manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:84 — MethodTooLong — ForceDarkScreen runs 197 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 97 over it, 1.97× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: StealthScreenKt.StealthScreen manager/src/main/java/moe/shizuku/manager/ui/screen/StealthScreen.kt:90 — MethodTooLong — StealthScreen runs 184 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 84 over it, 1.84× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: DisplayScreenKt.DisplayScreen manager/src/main/java/moe/shizuku/manager/ui/screen/DisplayScreen.kt:93 — MethodTooLong — DisplayScreen runs 183 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 83 over it, 1.83× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ShizukuAppKt.MainTabs manager/src/main/java/moe/shizuku/manager/ui/ShizukuApp.kt:509 — MethodTooLong — MainTabs runs 170 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 70 over it, 1.70× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ModuleRepoScreenKt.ModuleRepoScreen manager/src/main/java/moe/shizuku/manager/ui/screen/ModuleRepoScreen.kt:99 — MethodTooLong — ModuleRepoScreen runs 164 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 64 over it, 1.64× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ModulesScreenKt.ModuleCard manager/src/main/java/moe/shizuku/manager/ui/screen/ModulesScreen.kt:792 — MethodTooLong — ModuleCard runs 163 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 63 over it, 1.63× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SwitchIcon.draw manager/src/main/java/moe/shizuku/manager/manage/SwitchIcon.kt:70 — MethodTooLong — draw runs 141 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 41 over it, 1.41× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: IntentFormKt.IntentForm manager/src/main/java/moe/shizuku/manager/ui/component/IntentForm.kt:220 — MethodTooLong — IntentForm runs 123 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 23 over it, 1.23× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: LogScreenKt.CaptureTab manager/src/main/java/moe/shizuku/manager/ui/screen/LogScreen.kt:342 — MethodTooLong — CaptureTab runs 119 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 19 over it, 1.19× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SetupScreenKt.SetupScreen manager/src/main/java/moe/shizuku/manager/ui/screen/SetupScreen.kt:91 — MethodTooLong — SetupScreen runs 116 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 16 over it, 1.16× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: PowerScreenKt.PowerScreen manager/src/main/java/moe/shizuku/manager/ui/screen/PowerScreen.kt:144 — MethodTooLong — PowerScreen runs 107 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 7 over it, 1.07× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: LogScreenKt.AppLogTab manager/src/main/java/moe/shizuku/manager/ui/screen/LogScreen.kt:178 — MethodTooLong — AppLogTab runs 105 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 5 over it, 1.05× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
D3 · God Classes · FileTooLong · ×16
  • FileTooLong: screen/SettingsScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt — FileTooLong — 1343 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 843 over it, 2.69× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: screen/HomeScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/HomeScreen.kt — FileTooLong — 973 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 473 over it, 1.95× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: screen/ShellScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/ShellScreen.kt — FileTooLong — 900 significant lines (blank, comment-only and punctuation-only lines excluded), about 68% of them inside a single declaration: BARE_SU (180-1199). The bar is 500 significant lines; this is 400 over it, 1.80× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: screen/ModulesScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/ModulesScreen.kt — FileTooLong — 830 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 330 over it, 1.66× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: screen/LabsToggleScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt — FileTooLong — 780 significant lines (blank, comment-only and punctuation-only lines excluded), about 66% of them inside a single declaration: val (239-1089). The bar is 500 significant lines; this is 280 over it, 1.56× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: screen/AppDetailScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt — FileTooLong — 749 significant lines (blank, comment-only and punctuation-only lines excluded), about 69% of them inside a single declaration: DataJob (101-938). The bar is 500 significant lines; this is 249 over it, 1.50× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: screen/ManageScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/ManageScreen.kt — FileTooLong — 700 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 200 over it, 1.40× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: screen/FilesScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/FilesScreen.kt — FileTooLong — 643 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 143 over it, 1.29× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: screen/InstallerScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/InstallerScreen.kt — FileTooLong — 640 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 140 over it, 1.28× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: ui/ShizukuApp.kt manager/src/main/java/moe/shizuku/manager/ui/ShizukuApp.kt — FileTooLong — 629 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 129 over it, 1.26× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: screen/LogScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/LogScreen.kt — FileTooLong — 611 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 111 over it, 1.22× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: server/ShizukuService.java server/src/main/java/rikka/shizuku/server/ShizukuService.java — FileTooLong — 594 significant lines (blank, comment-only and punctuation-only lines excluded), about 89% of them inside a single declaration: ShizukuService (71-970). The bar is 500 significant lines; this is 94 over it, 1.19× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: screen/AppsScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt — FileTooLong — 564 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 64 over it, 1.13× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: screen/WifiPasswordsScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/WifiPasswordsScreen.kt — FileTooLong — 532 significant lines (blank, comment-only and punctuation-only lines excluded), about 72% of them inside a single declaration: WifiRow (90-710). The bar is 500 significant lines; this is 32 over it, 1.06× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: screen/ActivitiesScreen.kt manager/src/main/java/moe/shizuku/manager/ui/screen/ActivitiesScreen.kt — FileTooLong — 518 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 18 over it, 1.04× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: manage/PackageTools.kt manager/src/main/java/moe/shizuku/manager/manage/PackageTools.kt — FileTooLong — 513 significant lines (blank, comment-only and punctuation-only lines excluded), about 79% of them inside a single declaration: APP_OPS (187-981). The bar is 500 significant lines; this is 13 over it, 1.03× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
D15 · Churn × Complexity Hotspots · Repeated repair · ×15
  • Repeated repair: manager/src/main/java/moe/shizuku/manager/worker/AdbStartWorker.kt manager/src/main/java/moe/shizuku/manager/worker/AdbStartWorker.kt:109 — manager/src/main/java/moe/shizuku/manager/worker/AdbStartWorker.kt changed 48 times in last 90 days and 33 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 5 (its worst body is AdbStartWorker.enqueue at line 109), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(start): run intent starts expedited and replace stale attempts”; “fix(start): use adb root when no root shell is available”; “fix(watchdog): give a restart claim back when the restart cannot start”; “fix(start): keep hunting for the wireless port until the connection is made”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/worker/AdbStartWorker.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: manager/src/main/java/moe/shizuku/manager/adb/AdbStarter.kt manager/src/main/java/moe/shizuku/manager/adb/AdbStarter.kt:75 — manager/src/main/java/moe/shizuku/manager/adb/AdbStarter.kt changed 24 times in last 90 days and 15 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 15 (its worst body is AdbStarter.startAdb at line 75), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(start): honor wireless auto-disable after TCP start”; “fix(adb): do not hunt a new port after tcpip was sent”; “fix(start): keep hunting for the wireless port until the connection is made”; “fix(start): begin the boot start at unlock and log the boot timeline”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/adb/AdbStarter.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: manager/src/main/java/moe/shizuku/manager/utils/ShizukuStateMachine.kt manager/src/main/java/moe/shizuku/manager/utils/ShizukuStateMachine.kt:73 — manager/src/main/java/moe/shizuku/manager/utils/ShizukuStateMachine.kt changed 19 times in last 90 days and 11 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 13 (its worst body is ShizukuStateMachine.transition at line 73), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(start): begin the boot start at unlock and log the boot timeline”; “fix(start): stop a boot start from replacing the one already in flight”; “fix(start): drop a queued start once the server is up”; “fix(watchdog): do not start Shizuku after a reboot when start on boot is off”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/utils/ShizukuStateMachine.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: manager/src/main/java/moe/shizuku/manager/adb/AdbPairingAccessibilityService.kt manager/src/main/java/moe/shizuku/manager/adb/AdbPairingAccessibilityService.kt:336 — manager/src/main/java/moe/shizuku/manager/adb/AdbPairingAccessibilityService.kt changed 13 times in last 90 days and 9 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 10 (its worst body is AdbPairingAccessibilityService.pair at line 336), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(start): replace stale attempts and request hotspot access”; “fix(adb): arm the launch mark only when enabling the service”; “fix(adb): keep the settings launch pending until connection”; “fix(adb): make automatic pairing work on Google TV”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/adb/AdbPairingAccessibilityService.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: manager/src/main/java/moe/shizuku/manager/utils/EnvironmentUtils.kt manager/src/main/java/moe/shizuku/manager/utils/EnvironmentUtils.kt:100 — manager/src/main/java/moe/shizuku/manager/utils/EnvironmentUtils.kt changed 12 times in last 90 days and 9 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 6 (its worst body is EnvironmentUtils.isRooted at line 100), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(start): handle redacted wireless debugging on Android 17”; “fix(start): use adb root when no root shell is available”; “fix(home): gate debugging switches for Android 17”; “fix(start): let root coming back clear the wireless fallback”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/utils/EnvironmentUtils.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: manager/src/main/java/moe/shizuku/manager/start/ForcedWirelessDebugging.kt manager/src/main/java/moe/shizuku/manager/start/ForcedWirelessDebugging.kt:106 — manager/src/main/java/moe/shizuku/manager/start/ForcedWirelessDebugging.kt changed 12 times in last 90 days and 9 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 11 (its worst body is ForcedWirelessDebugging.nudge at line 106), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(start): replace stale attempts and request hotspot access”; “fix(start): promote before the hotspot and discover after it”; “fix(start): ask for wireless debugging at the cadence that was measured to work”; “fix(start): stop asking for wireless debugging that is already on”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/start/ForcedWirelessDebugging.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: manager/src/main/java/moe/shizuku/manager/ShizukuApplication.kt manager/src/main/java/moe/shizuku/manager/ShizukuApplication.kt:51 — manager/src/main/java/moe/shizuku/manager/ShizukuApplication.kt changed 12 times in last 90 days and 8 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 5 (its worst body is ShizukuApplication.init at line 51), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(adb): make automatic pairing work on Google TV”; “fix(start): begin the boot start at unlock and log the boot timeline”; “fix(watchdog): do not start Shizuku after a reboot when start on boot is off”; “fix(settings): apply the chosen language”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/ShizukuApplication.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: manager/src/main/java/moe/shizuku/manager/start/StartPermissions.kt manager/src/main/java/moe/shizuku/manager/start/StartPermissions.kt:157 — manager/src/main/java/moe/shizuku/manager/start/StartPermissions.kt changed 10 times in last 90 days and 6 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 8 (its worst body is StartPermissionsKt.writeGlobal at line 157), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(start): handle redacted wireless debugging on Android 17”; “fix(start): replace stale attempts and request hotspot access”; “fix(start): write secure settings through the server when no grant can arrive”; “fix(start): give the app the hotspot's permission through the server”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/start/StartPermissions.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: manager/src/main/java/moe/shizuku/manager/home/AccessibilityDialogHelper.kt manager/src/main/java/moe/shizuku/manager/home/AccessibilityDialogHelper.kt:138 — manager/src/main/java/moe/shizuku/manager/home/AccessibilityDialogHelper.kt changed 9 times in last 90 days and 6 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 5 (its worst body is AccessibilityDialogHelperKt.showNavigateDialog at line 138), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(adb): arm the launch mark only when enabling the service”; “fix(adb): make automatic pairing work on Google TV”; “fix(stealth): name the installed package in the permission advice”; “fix(pairing): name the restricted-settings way out of the accessibility prompt”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/home/AccessibilityDialogHelper.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: manager/src/main/java/moe/shizuku/manager/utils/ApkUtils.kt manager/src/main/java/moe/shizuku/manager/utils/ApkUtils.kt:209 — manager/src/main/java/moe/shizuku/manager/utils/ApkUtils.kt changed 9 times in last 90 days and 5 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 3 (its worst body is ApkUtilsKt.silentSessionParams at line 209), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(stealth): report why the repackaged APK could not be saved”; “fix(stealth): stop a hidden copy's name doubling on rename”; “fix(stealth): rename everything in the manifest, not only the package”; “fix(stealth): give the stub a version code no release can outrank”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/utils/ApkUtils.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: manager/src/main/java/moe/shizuku/manager/start/StartMethodFallback.kt manager/src/main/java/moe/shizuku/manager/start/StartMethodFallback.kt:57 — manager/src/main/java/moe/shizuku/manager/start/StartMethodFallback.kt changed 6 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 9 (its worst body is StartMethodGuard.resolve at line 57), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(start): use adb root when no root shell is available”; “fix(start): keep no-network start available”; “fix(start): hide no-network start on Android 17”; “fix(start): keep the root method when it falls back to wireless”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/start/StartMethodFallback.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: manager/src/main/java/moe/shizuku/manager/receiver/ManualStartReceiver.kt manager/src/main/java/moe/shizuku/manager/receiver/ManualStartReceiver.kt:8 — manager/src/main/java/moe/shizuku/manager/receiver/ManualStartReceiver.kt changed 5 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 2 (its worst body is ManualStartReceiver.onAuthenticated at line 8), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(start): run intent starts expedited and replace stale attempts”; “fix(start): stop a boot start from replacing the one already in flight”; “fix(stealth): stop addressing the app by its build-time package name”; “fix(start): let a start that arrives by broadcast wait for Wi-Fi”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/receiver/ManualStartReceiver.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: manager/src/main/java/moe/shizuku/manager/start/StartTransport.kt manager/src/main/java/moe/shizuku/manager/start/StartTransport.kt:128 — manager/src/main/java/moe/shizuku/manager/start/StartTransport.kt changed 5 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 7 (its worst body is StartTransport.rememberedPortVerdict at line 128), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(start): keep hunting for the wireless port until the connection is made”; “fix(start): only take the classic ADB port when it is listening”; “fix(start): take the classic ADB port before looking for a wireless one”; “fix(start): keep the wireless-debugging experiment alive long enough to work”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/start/StartTransport.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: manager/src/main/java/moe/shizuku/manager/receiver/BinderRequestReceiver.kt manager/src/main/java/moe/shizuku/manager/receiver/BinderRequestReceiver.kt:15 — manager/src/main/java/moe/shizuku/manager/receiver/BinderRequestReceiver.kt changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 6 (its worst body is BinderRequestReceiver.onReceive at line 15), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(start): begin the boot start at unlock and log the boot timeline”; “fix(start): stop a boot start from replacing the one already in flight”; “fix(start): ask the binder whether a server is running, and say when a start is refused”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/receiver/BinderRequestReceiver.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: manager/src/main/java/moe/shizuku/manager/start/AdbWithoutDeveloperOptions.kt manager/src/main/java/moe/shizuku/manager/start/AdbWithoutDeveloperOptions.kt:27 — manager/src/main/java/moe/shizuku/manager/start/AdbWithoutDeveloperOptions.kt changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 3 (its worst body is AdbWithoutDeveloperOptionsKt.applyAdbWithoutDeveloperOptions at line 27), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(settings): gate the switches that are nothing but a settings write”; “fix(prefs): stop reporting Developer options as hidden on Android 17”; “fix(home): stop offering screens Developer options is hiding”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-19..2026-11-17, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-19 12:02:34 +00:00' --until='2026-11-17 12:02:34 +00:00' --full-history --no-merges -- manager/src/main/java/moe/shizuku/manager/start/AdbWithoutDeveloperOptions.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
X3 · Exception handling · Swallowed exception (empty catch) · ×11
  • Swallowed exception (empty catch) manager/src/main/java/moe/shizuku/manager/utils/CustomTabsHelper.java:84 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) manager/src/main/java/moe/shizuku/manager/authorization/RequestPermissionActivity.kt:67 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) manager/src/main/java/moe/shizuku/manager/adb/AdbClient.kt:162 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `close()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: narrow the catch to the exception this release can actually raise, and record it through whatever this codebase already uses to report problems — or, if it truly cannot matter, say why in a comment on the catch.
  • Swallowed exception (empty catch) manager/src/main/java/moe/shizuku/manager/adb/AdbClient.kt:166 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `close()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: narrow the catch to the exception this release can actually raise, and record it through whatever this codebase already uses to report problems — or, if it truly cannot matter, say why in a comment on the catch.
  • Swallowed exception (empty catch) manager/src/main/java/moe/shizuku/manager/adb/AdbClient.kt:170 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `close()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: narrow the catch to the exception this release can actually raise, and record it through whatever this codebase already uses to report problems — or, if it truly cannot matter, say why in a comment on the catch.
  • Swallowed exception (empty catch) manager/src/main/java/moe/shizuku/manager/adb/AdbClient.kt:176 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `close()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: narrow the catch to the exception this release can actually raise, and record it through whatever this codebase already uses to report problems — or, if it truly cannot matter, say why in a comment on the catch.
  • Swallowed exception (empty catch) manager/src/main/java/moe/shizuku/manager/adb/AdbClient.kt:180 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `close()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: narrow the catch to the exception this release can actually raise, and record it through whatever this codebase already uses to report problems — or, if it truly cannot matter, say why in a comment on the catch.
  • Swallowed exception (empty catch) manager/src/main/java/moe/shizuku/manager/adb/AdbClient.kt:184 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `close()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: narrow the catch to the exception this release can actually raise, and record it through whatever this codebase already uses to report problems — or, if it truly cannot matter, say why in a comment on the catch.
  • Swallowed exception (empty catch) manager/src/main/java/moe/shizuku/manager/adb/AdbPairingClient.kt:291 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `close()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: narrow the catch to the exception this release can actually raise, and record it through whatever this codebase already uses to report problems — or, if it truly cannot matter, say why in a comment on the catch.
  • Swallowed exception (empty catch) manager/src/main/java/moe/shizuku/manager/adb/AdbPairingClient.kt:295 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `close()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: narrow the catch to the exception this release can actually raise, and record it through whatever this codebase already uses to report problems — or, if it truly cannot matter, say why in a comment on the catch.
  • Swallowed exception (empty catch) manager/src/main/java/moe/shizuku/manager/adb/AdbPairingClient.kt:299 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `close()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: narrow the catch to the exception this release can actually raise, and record it through whatever this codebase already uses to report problems — or, if it truly cannot matter, say why in a comment on the catch.
D4 · Code Duplication · Duplicated block (11 lines × 2) · ×7
  • Duplicated block (11 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/component/ScrollToTopButton.kt:64 — manager/src/main/java/moe/shizuku/manager/ui/component/ScrollToTopButton.kt:64-74 | manager/src/main/java/moe/shizuku/manager/ui/component/ScrollToTopButton.kt:98-108 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/component/ScrollToTopButton.kt:64` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/AccessibilityScreen.kt:248 — manager/src/main/java/moe/shizuku/manager/ui/screen/AccessibilityScreen.kt:248-258 | manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:560-570 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/AccessibilityScreen.kt:248` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt:871 — manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt:871-881 | manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:807-817 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt:871` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:368 — manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:368-378 | manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt:392-402 — before extracting anything, compare `manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt` and `manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 201 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:368` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt:1086 — manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt:1086-1096 | manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt:1119-1133 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt:1086` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt:1096` calls `SettingsIcon`, `Text`, `stringResource` and `manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt:1133` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (11 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt:1442 — manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt:1442-1452 | manager/src/main/java/moe/shizuku/manager/ui/screen/WifiPasswordsScreen.kt:570-580 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt:1442` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt:1454` calls `Text`, `stringResource` and `manager/src/main/java/moe/shizuku/manager/ui/screen/WifiPasswordsScreen.kt:582` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (11 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt:1476 — manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt:1476-1486 | manager/src/main/java/moe/shizuku/manager/ui/screen/WifiPasswordsScreen.kt:597-607 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt:1476` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
X3 · Exception handling · Swallowed exception (caught, then discarded) · ×6
  • Swallowed exception (caught, then discarded) manager/src/main/java/moe/shizuku/manager/utils/MoreApps.kt:49 — `catch (tr: Throwable)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) manager/src/main/java/moe/shizuku/manager/legacy/LegacyIsNotSupportedActivity.kt:48 — `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) manager/src/main/java/moe/shizuku/manager/home/AdbPairDialogFragment.kt:77 — `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) manager/src/main/java/moe/shizuku/manager/authorization/RequestPermissionActivity.kt:109 — `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) manager/src/main/java/moe/shizuku/manager/adb/AdbRoot.kt:125 — `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) common/src/main/java/moe/shizuku/common/util/OsUtils.java:15 — `catch (Throwable)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
D3 · God Classes · TooManyMethods · ×5
  • TooManyMethods: ShizukuSettings manager/src/main/java/moe/shizuku/manager/ShizukuSettings.java:27 — TooManyMethods — 63 methods. The bar is 30 methods; this is 33 over it, 2.10× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: Hiding manager/src/main/java/moe/shizuku/manager/manage/Hiding.kt:137 — TooManyMethods — 56 methods. The bar is 30 methods; this is 26 over it, 1.87× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: PackageTools manager/src/main/java/moe/shizuku/manager/manage/PackageTools.kt:219 — TooManyMethods — 43 methods. The bar is 30 methods; this is 13 over it, 1.43× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ShizukuService server/src/main/java/rikka/shizuku/server/ShizukuService.java:71 — TooManyMethods — 39 methods. The bar is 30 methods; this is 9 over it, 1.30× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: DeviceInfo manager/src/main/java/moe/shizuku/manager/manage/DeviceInfo.kt:39 — TooManyMethods — 31 methods. The bar is 30 methods; this is 1 over it, 1.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D4 · Code Duplication · Edited copy of a member (8 corresponding lines) · ×4
  • Edited copy of a member (8 corresponding lines) manager/src/main/java/moe/shizuku/manager/manage/Hiding.kt:946 — manager/src/main/java/moe/shizuku/manager/manage/Hiding.kt:946-955 | manager/src/main/java/moe/shizuku/manager/manage/Hiding.kt:961-968 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (8 corresponding lines) manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt:1009 — manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt:1009-1016 | manager/src/main/java/moe/shizuku/manager/ui/screen/InstallerScreen.kt:755-762 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (8 corresponding lines) manager/src/main/java/moe/shizuku/manager/accessibility/AccessibilityKeepAliveService.kt:172 — manager/src/main/java/moe/shizuku/manager/accessibility/AccessibilityKeepAliveService.kt:172-179 | manager/src/main/java/moe/shizuku/manager/service/HidingWatchService.kt:370-377 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (8 corresponding lines) manager/src/main/java/moe/shizuku/manager/ui/theme/Theme.kt:210 — manager/src/main/java/moe/shizuku/manager/ui/theme/Theme.kt:210-217 | manager/src/main/java/moe/shizuku/manager/utils/AppLocale.kt:152-159 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (8 lines × 2) · ×4
  • Duplicated block (8 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:478 — manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:478-485 | manager/src/main/java/moe/shizuku/manager/ui/screen/ManageScreen.kt:422-429 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (8 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt:1057 — manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt:1057-1064 | manager/src/main/java/moe/shizuku/manager/ui/screen/ManageScreen.kt:1020-1027 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (8 lines × 2) server/src/main/java/rikka/shizuku/server/api/IContentProviderUtils.java:22 — server/src/main/java/rikka/shizuku/server/api/IContentProviderUtils.java:22-29 | starter/src/main/java/moe/shizuku/starter/util/IContentProviderCompat.java:26-33 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `server/src/main/java/rikka/shizuku/server/api/IContentProviderUtils.java:22` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (8 lines × 2) server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:92 — server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:92-99 | server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:113-120 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:92` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (6 lines × 2) · ×4
  • Duplicated block (6 lines × 2) manager/src/main/java/moe/shizuku/manager/manage/WifiControl.kt:314 — manager/src/main/java/moe/shizuku/manager/manage/WifiControl.kt:314-319 | manager/src/main/java/moe/shizuku/manager/start/AdbPortPersistence.kt:87-92 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/manage/WifiControl.kt:314` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (6 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:591 — manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:591-600 | manager/src/main/java/moe/shizuku/manager/ui/screen/LogScreen.kt:775-780 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:591` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (6 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/CatalogScreen.kt:213 — manager/src/main/java/moe/shizuku/manager/ui/screen/CatalogScreen.kt:213-218 | manager/src/main/java/moe/shizuku/manager/ui/screen/ModuleRepoScreen.kt:104-109 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (6 lines × 2) server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:141 — server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:141-146 | server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:164-172 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:141` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (7 lines × 2) · ×4
  • Duplicated block (7 lines × 2) manager/src/main/java/moe/shizuku/manager/service/LabTileService.kt:97 — manager/src/main/java/moe/shizuku/manager/service/LabTileService.kt:97-103 | manager/src/main/java/moe/shizuku/manager/widget/LabWidgetProvider.kt:111-117 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (7 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/component/IntentForm.kt:490 — manager/src/main/java/moe/shizuku/manager/ui/component/IntentForm.kt:490-496 | manager/src/main/java/moe/shizuku/manager/ui/screen/DeviceInfoScreen.kt:710-716 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (7 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/ModuleRepoScreen.kt:600 — manager/src/main/java/moe/shizuku/manager/ui/screen/ModuleRepoScreen.kt:600-606 | manager/src/main/java/moe/shizuku/manager/ui/screen/ModulesScreen.kt:1203-1209 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (7 lines × 2) server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:203 — server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:203-209 | server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:233-239 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:203` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D29 · Static Analysis (SAST) · REDACTED · ×3
  • REDACTED
  • REDACTED
  • REDACTED
D3 · God Classes · ClassTooLong · ×3
  • ClassTooLong: ShizukuService server/src/main/java/rikka/shizuku/server/ShizukuService.java:71 — ClassTooLong — 530 significant lines (blank, comment-only and punctuation-only lines excluded), 39 methods. The bar is 400 significant lines; this is 130 over it, 1.33× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: DataJob manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt:101 — ClassTooLong — 520 significant lines (blank, comment-only and punctuation-only lines excluded), 1 methods. The bar is 400 significant lines; this is 120 over it, 1.30× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: AdbStartRun manager/src/main/java/moe/shizuku/manager/start/AdbStartRun.kt:61 — ClassTooLong — 423 significant lines (blank, comment-only and punctuation-only lines excluded), 8 methods. The bar is 400 significant lines; this is 23 over it, 1.06× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D35 · Change Coupling · Change coupling · ×3
  • Change coupling: StealthTutorialViewModel.kt ↔ ApkUtils.kt manager/src/main/java/moe/shizuku/manager/stealth/StealthTutorialViewModel.kt:1 — `manager/src/main/java/moe/shizuku/manager/stealth/StealthTutorialViewModel.kt` and `manager/src/main/java/moe/shizuku/manager/utils/ApkUtils.kt` change together 62% of the time (8 of the 13 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `9048510c` fix(stealth): report why the repackaged APK could not be saved; `589041a1` feat(stealth): let the hide flow name the copy that is built; `a7d2617f` feat(stealth): make the stub answer the binder request it holds the n… — run `git show` on any of them.
  • Change coupling: SettingsScreen.kt ↔ Theme.kt manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt:1 — `manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt` and `manager/src/main/java/moe/shizuku/manager/ui/theme/Theme.kt` change together 60% of the time (6 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `8083d233` feat(settings): add palette style selection; `80ed91ba` feat(settings): add amoled background, accent and contrast options; `cbf400e6` feat(theme): take the system palette whole, so ColorBlendr themes apply — run `git show` on any of them.
  • Change coupling: MainActivity.kt ↔ HomeScreen.kt manager/src/main/java/moe/shizuku/manager/MainActivity.kt:1 — `manager/src/main/java/moe/shizuku/manager/MainActivity.kt` and `manager/src/main/java/moe/shizuku/manager/ui/screen/HomeScreen.kt` change together 50% of the time (6 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `8d588084` feat(onboarding): add a guided first-run setup; `a94d8776` fix(start): stop a boot start from replacing the one already in flight; `c23f88d5` fix(start): stop a boot start from replacing the one already in flight — run `git show` on any of them.
D4 · Code Duplication · Edited copy of a member (14 corresponding lines) · ×3
  • Edited copy of a member (14 corresponding lines) server/src/main/java/rikka/shizuku/server/api/IContentProviderUtils.java:16 — server/src/main/java/rikka/shizuku/server/api/IContentProviderUtils.java:16-29 | starter/src/main/java/moe/shizuku/starter/util/IContentProviderCompat.java:16-33 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (14 corresponding lines) manager/src/main/java/moe/shizuku/manager/manage/WifiControl.kt:314 — manager/src/main/java/moe/shizuku/manager/manage/WifiControl.kt:314-335 | manager/src/main/java/moe/shizuku/manager/start/AdbPortPersistence.kt:87-100 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (14 corresponding lines) manager/src/main/java/moe/shizuku/manager/ui/screen/ModulesScreen.kt:1063 — manager/src/main/java/moe/shizuku/manager/ui/screen/ModulesScreen.kt:1063-1078 | manager/src/main/java/moe/shizuku/manager/ui/screen/ModulesScreen.kt:1089-1102 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (14–15 lines × 2) · ×3
  • Duplicated block (14–15 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:724 — manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:724-737 | manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt:1048-1062 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:724` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14–15 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/HomeScreen.kt:386 — manager/src/main/java/moe/shizuku/manager/ui/screen/HomeScreen.kt:386-399 | manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt:478-492 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/HomeScreen.kt:386` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (14–15 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/ManageScreen.kt:843 — manager/src/main/java/moe/shizuku/manager/ui/screen/ManageScreen.kt:843-857 | manager/src/main/java/moe/shizuku/manager/ui/screen/ManageScreen.kt:969-982 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/ManageScreen.kt:843` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (13 lines × 2) · ×3
  • Duplicated block (13 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt:773 — manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt:773-785 | manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:743-755 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt:773` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/DeviceInfoScreen.kt:606 — manager/src/main/java/moe/shizuku/manager/ui/screen/DeviceInfoScreen.kt:606-618 | manager/src/main/java/moe/shizuku/manager/ui/screen/DeviceInfoScreen.kt:683-695 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/DeviceInfoScreen.kt:606` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/DeviceInfoScreen.kt:666 — manager/src/main/java/moe/shizuku/manager/ui/screen/DeviceInfoScreen.kt:666-678 | manager/src/main/java/moe/shizuku/manager/ui/screen/InstallerScreen.kt:739-751 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (10 lines × 2) · ×3
  • Duplicated block (10 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:805 — manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:805-814 | manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:835-844 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:805` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:257 — manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:257-266 | manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt:276-285 — before extracting anything, compare `manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt` and `manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 201 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:257` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:367 — manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:367-376 | manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt:1031-1040 — before extracting anything, compare `manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt` and `manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 127 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:367` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D17 · Explicit Debt · TodoComment · ×2
  • TodoComment server/src/main/java/rikka/shizuku/server/ShizukuService.java:688 — // TODO kill user service using — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment server/src/main/java/rikka/shizuku/server/ShizukuService.java:696 — // TODO add runtime permission listener — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
D4 · Code Duplication · Edited copy of a member (23 corresponding lines) · ×2
  • Edited copy of a member (23 corresponding lines) server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:286 — server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:286-308 | server/src/main/java/rikka/shizuku/server/util/UsersCompat.java:186-210 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (23 corresponding lines) manager/src/main/java/moe/shizuku/manager/ui/component/ScrollToTopButton.kt:48 — manager/src/main/java/moe/shizuku/manager/ui/component/ScrollToTopButton.kt:48-74 | manager/src/main/java/moe/shizuku/manager/ui/component/ScrollToTopButton.kt:86-108 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (20 corresponding lines) · ×2
  • Edited copy of a member (20 corresponding lines) server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:89 — server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:89-108 | server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:110-129 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (20 corresponding lines) manager/src/main/java/moe/shizuku/manager/adb/AdbPairingService.kt:157 — manager/src/main/java/moe/shizuku/manager/adb/AdbPairingService.kt:157-176 | manager/src/main/java/moe/shizuku/manager/home/AdbPairDialogFragment.kt:179-202 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (11 corresponding lines) · ×2
  • Edited copy of a member (11 corresponding lines) manager/src/main/java/moe/shizuku/manager/shell/ShellBookmarks.kt:33 — manager/src/main/java/moe/shizuku/manager/shell/ShellBookmarks.kt:33-45 | manager/src/main/java/moe/shizuku/manager/shell/ShellHistory.kt:31-41 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (11 corresponding lines) manager/src/main/java/moe/shizuku/manager/files/AppDataArchive.kt:385 — manager/src/main/java/moe/shizuku/manager/files/AppDataArchive.kt:385-395 | manager/src/main/java/moe/shizuku/manager/files/FileOperations.kt:310-322 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (13 corresponding lines) · ×2
  • Edited copy of a member (13 corresponding lines) manager/src/main/java/moe/shizuku/manager/files/AppDataArchive.kt:397 — manager/src/main/java/moe/shizuku/manager/files/AppDataArchive.kt:397-409 | manager/src/main/java/moe/shizuku/manager/files/FileOperations.kt:294-307 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (13 corresponding lines) manager/src/main/java/moe/shizuku/manager/files/AppDataArchive.kt:416 — manager/src/main/java/moe/shizuku/manager/files/AppDataArchive.kt:416-428 | manager/src/main/java/moe/shizuku/manager/files/FileOperations.kt:333-347 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (7 corresponding lines) · ×2
  • Edited copy of a member (7 corresponding lines) server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:259 — server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:259-265 | server/src/main/java/rikka/shizuku/server/util/UsersCompat.java:157-165 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) manager/src/main/java/moe/shizuku/manager/start/StartStatus.kt:54 — manager/src/main/java/moe/shizuku/manager/start/StartStatus.kt:54-62 | manager/src/main/java/moe/shizuku/manager/start/StartStatus.kt:69-75 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (19 lines × 2) · ×2
  • Duplicated block (19 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/ModuleRepoScreen.kt:152 — manager/src/main/java/moe/shizuku/manager/ui/screen/ModuleRepoScreen.kt:152-170 | manager/src/main/java/moe/shizuku/manager/ui/screen/ModulesScreen.kt:327-345 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/ModuleRepoScreen.kt:152` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `manager/src/main/java/moe/shizuku/manager/ui/screen/ModulesScreen.kt:323` calls `rememberLazyListState`, `Box`, `fillMaxSize` and `manager/src/main/java/moe/shizuku/manager/ui/screen/ModuleRepoScreen.kt:149` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (19 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/ModuleWebUiScreen.kt:138 — manager/src/main/java/moe/shizuku/manager/ui/screen/ModuleWebUiScreen.kt:138-156 | manager/src/main/java/moe/shizuku/manager/ui/screen/ModulesScreen.kt:678-696 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/ModuleWebUiScreen.kt:138` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (12 lines × 2) · ×2
  • Duplicated block (12 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/component/ExpressiveCard.kt:85 — manager/src/main/java/moe/shizuku/manager/ui/component/ExpressiveCard.kt:85-96 | manager/src/main/java/moe/shizuku/manager/ui/component/FeaturePlateIcon.kt:28-39 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/component/ExpressiveCard.kt:85` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (12 lines × 2) manager/src/main/java/moe/shizuku/manager/start/AdbStartRun.kt:758 — manager/src/main/java/moe/shizuku/manager/start/AdbStartRun.kt:758-769 | manager/src/main/java/moe/shizuku/manager/start/AdbStartRun.kt:798-809 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/start/AdbStartRun.kt:758` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (10–12 lines × 2) · ×2
  • Duplicated block (10–12 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/AccessibilityScreen.kt:280 — manager/src/main/java/moe/shizuku/manager/ui/screen/AccessibilityScreen.kt:280-291 | manager/src/main/java/moe/shizuku/manager/ui/screen/LogScreen.kt:775-784 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/AccessibilityScreen.kt:280` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10–12 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/CatalogScreen.kt:590 — manager/src/main/java/moe/shizuku/manager/ui/screen/CatalogScreen.kt:590-601 | manager/src/main/java/moe/shizuku/manager/ui/screen/ModuleRepoScreen.kt:502-511 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (5 lines × 2) · ×2
  • Duplicated block (5 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:287 — manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:287-291 | manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt:417-421 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:287` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (5 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:284 — manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:284-288 | manager/src/main/java/moe/shizuku/manager/ui/screen/ManageScreen.kt:265-269 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:284` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:283` calls `trim` and `manager/src/main/java/moe/shizuku/manager/ui/screen/ManageScreen.kt:264` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
X15 · Unvalidated length from an untrusted reader · Length read from the parsed input is spent without ever being bounded · ×2
  • Length read from the parsed input is spent without ever being bounded server/src/main/java/rikka/shizuku/server/ShizukuService.java:785 — `count` is read from the bytes being parsed at line 784 (`readInt`), then used to size a `new int[]` at line 785 — and nowhere in its scope is `count` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). Whoever wrote those bytes therefore chooses the allocation directly: a 32-bit length asks for up to 2 GiB before a single byte of the payload is known to exist, which either exhausts the heap with an `OutOfMemoryError` or, negative, throws `NegativeArraySizeException` out of a parser whose failure path was written for malformed input, not for hostile input. Bound `count` against the bytes actually remaining and a maximum the format allows before allocating.
  • Length read from the parsed input is spent without ever being bounded manager/src/main/java/moe/shizuku/manager/adb/AdbClient.kt:148 — `dataLength` is read from the bytes being parsed at line 143 (`int`), then used to size a `ByteArray` at line 148 — and nowhere in its scope is `dataLength` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). Whoever wrote those bytes therefore chooses the allocation directly: a 32-bit length asks for up to 2 GiB before a single byte of the payload is known to exist, which either exhausts the heap with an `OutOfMemoryError` or, negative, throws `NegativeArraySizeException` out of a parser whose failure path was written for malformed input, not for hostile input. Bound `dataLength` against the bytes actually remaining and a maximum the format allows before allocating.
D1 · Cyclomatic Complexity · SettingsScreenKt.SettingsScreen (cyclomatic 98) · ×1
  • SettingsScreenKt.SettingsScreen (cyclomatic 98) manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt:209 — SettingsScreenKt.SettingsScreen has cyclomatic complexity 98 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LabsToggleScreenKt.LabsToggleScreen (cyclomatic 95) · ×1
  • LabsToggleScreenKt.LabsToggleScreen (cyclomatic 95) manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt:243 — LabsToggleScreenKt.LabsToggleScreen has cyclomatic complexity 95 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · AppsScreenKt.AppsScreen (cyclomatic 83) · ×1
  • AppsScreenKt.AppsScreen (cyclomatic 83) manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:132 — AppsScreenKt.AppsScreen has cyclomatic complexity 83 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · AdbStartRun.startServer (cyclomatic 70) · ×1
  • AdbStartRun.startServer (cyclomatic 70) manager/src/main/java/moe/shizuku/manager/start/AdbStartRun.kt:164 — AdbStartRun.startServer has cyclomatic complexity 70 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ShellScreenKt.ShellScreen (cyclomatic 67) · ×1
  • ShellScreenKt.ShellScreen (cyclomatic 67) manager/src/main/java/moe/shizuku/manager/ui/screen/ShellScreen.kt:193 — ShellScreenKt.ShellScreen has cyclomatic complexity 67 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ActivitiesScreenKt.ActivitiesScreen (cyclomatic 64) · ×1
  • ActivitiesScreenKt.ActivitiesScreen (cyclomatic 64) manager/src/main/java/moe/shizuku/manager/ui/screen/ActivitiesScreen.kt:98 — ActivitiesScreenKt.ActivitiesScreen has cyclomatic complexity 64 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · ManageScreenKt.ManageScreen (cyclomatic 62) · ×1
  • ManageScreenKt.ManageScreen (cyclomatic 62) manager/src/main/java/moe/shizuku/manager/ui/screen/ManageScreen.kt:166 — ManageScreenKt.ManageScreen has cyclomatic complexity 62 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · AppDetailScreenKt.AppDetailScreen (cyclomatic 61) · ×1
  • AppDetailScreenKt.AppDetailScreen (cyclomatic 61) manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt:116 — AppDetailScreenKt.AppDetailScreen has cyclomatic complexity 61 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · HomeScreenKt.HomeScreen (cyclomatic 43) · ×1
  • HomeScreenKt.HomeScreen (cyclomatic 43) manager/src/main/java/moe/shizuku/manager/ui/screen/HomeScreen.kt:147 — HomeScreenKt.HomeScreen has cyclomatic complexity 43 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · FilesScreenKt.FilesScreen (cyclomatic 40) · ×1
  • FilesScreenKt.FilesScreen (cyclomatic 40) manager/src/main/java/moe/shizuku/manager/ui/screen/FilesScreen.kt:144 — FilesScreenKt.FilesScreen has cyclomatic complexity 40 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · check-translations.main (cyclomatic 33) · ×1
  • check-translations.main (cyclomatic 33) ci/check-translations.py:144 — check-translations.main has cyclomatic complexity 33 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · WifiPasswordsScreenKt.WifiPasswordsScreen (cyclomatic 32) · ×1
  • WifiPasswordsScreenKt.WifiPasswordsScreen (cyclomatic 32) manager/src/main/java/moe/shizuku/manager/ui/screen/WifiPasswordsScreen.kt:117 — WifiPasswordsScreenKt.WifiPasswordsScreen has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SwitchIcon.draw (cyclomatic 29) · ×1
  • SwitchIcon.draw (cyclomatic 29) manager/src/main/java/moe/shizuku/manager/manage/SwitchIcon.kt:70 — SwitchIcon.draw has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ModulesScreenKt.ModulesScreen (cyclomatic 28) · ×1
  • ModulesScreenKt.ModulesScreen (cyclomatic 28) manager/src/main/java/moe/shizuku/manager/ui/screen/ModulesScreen.kt:134 — ModulesScreenKt.ModulesScreen has cyclomatic complexity 28 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · ShizukuConfigManager.<init> (cyclomatic 26) · ×1
  • ShizukuConfigManager.<init> (cyclomatic 26) server/src/main/java/rikka/shizuku/server/ShizukuConfigManager.java:123 — ShizukuConfigManager.<init> has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · AppDataArchive.import (cyclomatic 25) · ×1
  • AppDataArchive.import (cyclomatic 25) manager/src/main/java/moe/shizuku/manager/files/AppDataArchive.kt:198 — AppDataArchive.import has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · WatchdogService.attemptRestart (cyclomatic 24) · ×1
  • WatchdogService.attemptRestart (cyclomatic 24) manager/src/main/java/moe/shizuku/manager/service/WatchdogService.kt:221 — WatchdogService.attemptRestart has cyclomatic complexity 24 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · ShizukuAppKt.TelevisionTabs (cyclomatic 24) · ×1
  • ShizukuAppKt.TelevisionTabs (cyclomatic 24) manager/src/main/java/moe/shizuku/manager/ui/ShizukuApp.kt:859 — ShizukuAppKt.TelevisionTabs has cyclomatic complexity 24 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages. This is NOT this file's highest cyclomatic complexity: ShizukuAppKt.ShizukuApp (cyclomatic 30) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
D1 · Cyclomatic Complexity · ContributorWallCanvasKt.ContributorWall (cyclomatic 23) · ×1
  • ContributorWallCanvasKt.ContributorWall (cyclomatic 23) manager/src/main/java/moe/shizuku/manager/ui/component/ContributorWallCanvas.kt:111 — ContributorWallCanvasKt.ContributorWall has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ShizukuAppKt.MainTabs (cyclomatic 22) · ×1
  • ShizukuAppKt.MainTabs (cyclomatic 22) manager/src/main/java/moe/shizuku/manager/ui/ShizukuApp.kt:509 — ShizukuAppKt.MainTabs has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This is NOT this file's highest cyclomatic complexity: ShizukuAppKt.ShizukuApp (cyclomatic 30) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
D1 · Cyclomatic Complexity · StealthScreenKt.StealthScreen (cyclomatic 22) · ×1
  • StealthScreenKt.StealthScreen (cyclomatic 22) manager/src/main/java/moe/shizuku/manager/ui/screen/StealthScreen.kt:90 — StealthScreenKt.StealthScreen has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · repair-translations.main (cyclomatic 22) · ×1
  • repair-translations.main (cyclomatic 22) ci/repair-translations.py:292 — repair-translations.main has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ForceDarkScreenKt.ForceDarkScreen (cyclomatic 21) · ×1
  • ForceDarkScreenKt.ForceDarkScreen (cyclomatic 21) manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:84 — ForceDarkScreenKt.ForceDarkScreen has cyclomatic complexity 21 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · RotationScreenKt.RotationScreen (cyclomatic 21) · ×1
  • RotationScreenKt.RotationScreen (cyclomatic 21) manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt:103 — RotationScreenKt.RotationScreen has cyclomatic complexity 21 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · InstallerScreenKt.InstallerScreen (cyclomatic 20) · ×1
  • InstallerScreenKt.InstallerScreen (cyclomatic 20) manager/src/main/java/moe/shizuku/manager/ui/screen/InstallerScreen.kt:130 — InstallerScreenKt.InstallerScreen has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LogScreenKt.CaptureTab (cyclomatic 20) · ×1
  • LogScreenKt.CaptureTab (cyclomatic 20) manager/src/main/java/moe/shizuku/manager/ui/screen/LogScreen.kt:342 — LogScreenKt.CaptureTab has cyclomatic complexity 20 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · AdbRoot.setRoot (cyclomatic 18) · ×1
  • AdbRoot.setRoot (cyclomatic 18) manager/src/main/java/moe/shizuku/manager/adb/AdbRoot.kt:55 — AdbRoot.setRoot has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · ShizukuReceiverStarter.adbStart (cyclomatic 18) · ×1
  • ShizukuReceiverStarter.adbStart (cyclomatic 18) manager/src/main/java/moe/shizuku/manager/receiver/ShizukuReceiverStarter.kt:249 — ShizukuReceiverStarter.adbStart has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · AccessibilityScreenKt.AccessibilityScreen (cyclomatic 18) · ×1
  • AccessibilityScreenKt.AccessibilityScreen (cyclomatic 18) manager/src/main/java/moe/shizuku/manager/ui/screen/AccessibilityScreen.kt:79 — AccessibilityScreenKt.AccessibilityScreen has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · CatalogScreenKt.CatalogScreen (cyclomatic 17) · ×1
  • CatalogScreenKt.CatalogScreen (cyclomatic 17) manager/src/main/java/moe/shizuku/manager/ui/screen/CatalogScreen.kt:196 — CatalogScreenKt.CatalogScreen has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · LogScreenKt.AppLogTab (cyclomatic 17) · ×1
  • LogScreenKt.AppLogTab (cyclomatic 17) manager/src/main/java/moe/shizuku/manager/ui/screen/LogScreen.kt:178 — LogScreenKt.AppLogTab has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · ShizukuService.dispatchPermissionConfirmationResult (cyclomatic 17) · ×1
  • ShizukuService.dispatchPermissionConfirmationResult (cyclomatic 17) server/src/main/java/rikka/shizuku/server/ShizukuService.java:547 — ShizukuService.dispatchPermissionConfirmationResult has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · update-contributors.build (cyclomatic 17) · ×1
  • update-contributors.build (cyclomatic 17) ci/update-contributors.py:233 — update-contributors.build has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DeviceInfoScreenKt.DeviceInfoScreen (cyclomatic 16) · ×1
  • DeviceInfoScreenKt.DeviceInfoScreen (cyclomatic 16) manager/src/main/java/moe/shizuku/manager/ui/screen/DeviceInfoScreen.kt:74 — DeviceInfoScreenKt.DeviceInfoScreen has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · DisplayScreenKt.DisplayScreen (cyclomatic 16) · ×1
  • DisplayScreenKt.DisplayScreen (cyclomatic 16) manager/src/main/java/moe/shizuku/manager/ui/screen/DisplayScreen.kt:93 — DisplayScreenKt.DisplayScreen has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · HomeDiagnosticsKt.buildDiagnostics (cyclomatic 16) · ×1
  • HomeDiagnosticsKt.buildDiagnostics (cyclomatic 16) manager/src/main/java/moe/shizuku/manager/ui/screen/HomeDiagnostics.kt:62 — HomeDiagnosticsKt.buildDiagnostics has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · ModulesScreenKt.ModuleCard (cyclomatic 16) · ×1
  • ModulesScreenKt.ModuleCard (cyclomatic 16) manager/src/main/java/moe/shizuku/manager/ui/screen/ModulesScreen.kt:792 — ModulesScreenKt.ModuleCard has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · PowerScreenKt.PowerScreen (cyclomatic 16) · ×1
  • PowerScreenKt.PowerScreen (cyclomatic 16) manager/src/main/java/moe/shizuku/manager/ui/screen/PowerScreen.kt:144 — PowerScreenKt.PowerScreen has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · ApkChangedObserversKt.eventToString (cyclomatic 16) · ×1
  • ApkChangedObserversKt.eventToString (cyclomatic 16) server/src/main/java/rikka/shizuku/server/ApkChangedObservers.kt:122 — ApkChangedObserversKt.eventToString has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · repair-translations.find_bad_keys (cyclomatic 16) · ×1
  • repair-translations.find_bad_keys (cyclomatic 16) ci/repair-translations.py:128 — repair-translations.find_bad_keys has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · update-contributors.area_of (cyclomatic 16) · ×1
  • update-contributors.area_of (cyclomatic 16) ci/update-contributors.py:87 — update-contributors.area_of has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · SettingsScreenKt.SettingsScreen (cognitive 168) · ×1
  • SettingsScreenKt.SettingsScreen (cognitive 168) manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt:209 — SettingsScreenKt.SettingsScreen has cognitive complexity 168 (threshold 15). Drivers by points: if/else 93 (135 pts), boolean chains 21, match/switch 5 (12 pts) (nesting depth added 49). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ShellScreenKt.ShellScreen (cognitive 121) · ×1
  • ShellScreenKt.ShellScreen (cognitive 121) manager/src/main/java/moe/shizuku/manager/ui/screen/ShellScreen.kt:193 — ShellScreenKt.ShellScreen has cognitive complexity 121 (threshold 15). Drivers by points: if/else 76 (106 pts), boolean chains 8, error handling 1 (4 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 34). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LabsToggleScreenKt.LabsToggleScreen (cognitive 118) · ×1
  • LabsToggleScreenKt.LabsToggleScreen (cognitive 118) manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt:243 — LabsToggleScreenKt.LabsToggleScreen has cognitive complexity 118 (threshold 15). Drivers by points: if/else 75 (87 pts), boolean chains 18, match/switch 8 (13 pts) (nesting depth added 17). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · AdbStartRun.startServer (cognitive 105) · ×1
  • AdbStartRun.startServer (cognitive 105) manager/src/main/java/moe/shizuku/manager/start/AdbStartRun.kt:164 — AdbStartRun.startServer has cognitive complexity 105 (threshold 15). Drivers by points: if/else 46 (73 pts), boolean chains 13, error handling 6 (10 pts), match/switch 4 (6 pts), loops 2 (3 pts) (nesting depth added 34). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AppDetailScreenKt.AppDetailScreen (cognitive 98) · ×1
  • AppDetailScreenKt.AppDetailScreen (cognitive 98) manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt:116 — AppDetailScreenKt.AppDetailScreen has cognitive complexity 98 (threshold 15). Drivers by points: if/else 63 (81 pts), boolean chains 13, match/switch 3 (4 pts) (nesting depth added 19). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · ActivitiesScreenKt.ActivitiesScreen (cognitive 93) · ×1
  • ActivitiesScreenKt.ActivitiesScreen (cognitive 93) manager/src/main/java/moe/shizuku/manager/ui/screen/ActivitiesScreen.kt:98 — ActivitiesScreenKt.ActivitiesScreen has cognitive complexity 93 (threshold 15). Drivers by points: if/else 60 (73 pts), boolean chains 10, match/switch 6 (10 pts) (nesting depth added 17). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · AppsScreenKt.AppsScreen (cognitive 92) · ×1
  • AppsScreenKt.AppsScreen (cognitive 92) manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:132 — AppsScreenKt.AppsScreen has cognitive complexity 92 (threshold 15). Drivers by points: if/else 57 (66 pts), boolean chains 16, match/switch 6 (7 pts), loops 2 (3 pts) (nesting depth added 11). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · HomeScreenKt.HomeScreen (cognitive 62) · ×1
  • HomeScreenKt.HomeScreen (cognitive 62) manager/src/main/java/moe/shizuku/manager/ui/screen/HomeScreen.kt:147 — HomeScreenKt.HomeScreen has cognitive complexity 62 (threshold 15). Drivers by points: if/else 42 (52 pts), boolean chains 10 (nesting depth added 10). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · ManageScreenKt.ManageScreen (cognitive 62) · ×1
  • ManageScreenKt.ManageScreen (cognitive 62) manager/src/main/java/moe/shizuku/manager/ui/screen/ManageScreen.kt:166 — ManageScreenKt.ManageScreen has cognitive complexity 62 (threshold 15). Drivers by points: if/else 43 (47 pts), boolean chains 7, match/switch 6 (7 pts), loops 1 (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · check-translations.main (cognitive 58) · ×1
  • check-translations.main (cognitive 58) ci/check-translations.py:144 — check-translations.main has cognitive complexity 58 (threshold 15). Drivers by points: if/else 21 (41 pts), error handling 3 (6 pts), loops 4 (6 pts), boolean chains 3, ternaries 1 (2 pts) (nesting depth added 26). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ShizukuConfigManager.<init> (cognitive 54) · ×1
  • ShizukuConfigManager.<init> (cognitive 54) server/src/main/java/rikka/shizuku/server/ShizukuConfigManager.java:123 — ShizukuConfigManager.<init> has cognitive complexity 54 (threshold 15). Drivers by points: if/else 16 (38 pts), loops 5 (7 pts), ternaries 1 (4 pts), error handling 1 (3 pts), boolean chains 2 (nesting depth added 29). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FilesScreenKt.FilesScreen (cognitive 51) · ×1
  • FilesScreenKt.FilesScreen (cognitive 51) manager/src/main/java/moe/shizuku/manager/ui/screen/FilesScreen.kt:144 — FilesScreenKt.FilesScreen has cognitive complexity 51 (threshold 15). Drivers by points: if/else 29 (40 pts), match/switch 5 (7 pts), boolean chains 4 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · WifiPasswordsScreenKt.WifiPasswordsScreen (cognitive 46) · ×1
  • WifiPasswordsScreenKt.WifiPasswordsScreen (cognitive 46) manager/src/main/java/moe/shizuku/manager/ui/screen/WifiPasswordsScreen.kt:117 — WifiPasswordsScreenKt.WifiPasswordsScreen has cognitive complexity 46 (threshold 15). Drivers by points: if/else 25 (39 pts), match/switch 4 (5 pts), boolean chains 2 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ModulesScreenKt.ModulesScreen (cognitive 42) · ×1
  • ModulesScreenKt.ModulesScreen (cognitive 42) manager/src/main/java/moe/shizuku/manager/ui/screen/ModulesScreen.kt:134 — ModulesScreenKt.ModulesScreen has cognitive complexity 42 (threshold 15). Drivers by points: if/else 33 (37 pts), boolean chains 4, match/switch 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · ContributorWallCanvasKt.ContributorWall (cognitive 37) · ×1
  • ContributorWallCanvasKt.ContributorWall (cognitive 37) manager/src/main/java/moe/shizuku/manager/ui/component/ContributorWallCanvas.kt:111 — ContributorWallCanvasKt.ContributorWall has cognitive complexity 37 (threshold 15). Drivers by points: if/else 17 (29 pts), boolean chains 6, loops 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SwitchIcon.draw (cognitive 35) · ×1
  • SwitchIcon.draw (cognitive 35) manager/src/main/java/moe/shizuku/manager/manage/SwitchIcon.kt:70 — SwitchIcon.draw has cognitive complexity 35 (threshold 15). Drivers by points: if/else 16 (32 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · repair-translations.find_bad_keys (cognitive 33) · ×1
  • repair-translations.find_bad_keys (cognitive 33) ci/repair-translations.py:128 — repair-translations.find_bad_keys has cognitive complexity 33 (threshold 15). Drivers by points: if/else 7 (19 pts), error handling 3 (6 pts), loops 3 (6 pts), boolean chains 2 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AdbStarter.openTcpPort (cognitive 31) · ×1
  • AdbStarter.openTcpPort (cognitive 31) manager/src/main/java/moe/shizuku/manager/adb/AdbStarter.kt:390 — AdbStarter.openTcpPort has cognitive complexity 31 (threshold 15). Drivers by points: if/else 9 (22 pts), error handling 3 (6 pts), boolean chains 2, loops 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ForceDarkScreenKt.ForceDarkScreen (cognitive 30) · ×1
  • ForceDarkScreenKt.ForceDarkScreen (cognitive 30) manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:84 — ForceDarkScreenKt.ForceDarkScreen has cognitive complexity 30 (threshold 15). Drivers by points: if/else 23 (24 pts), boolean chains 3, match/switch 1 (3 pts) (nesting depth added 3). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · RotationScreenKt.RotationScreen (cognitive 29) · ×1
  • RotationScreenKt.RotationScreen (cognitive 29) manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt:103 — RotationScreenKt.RotationScreen has cognitive complexity 29 (threshold 15). Drivers by points: if/else 21 (22 pts), boolean chains 4, match/switch 1 (3 pts) (nesting depth added 3). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · ShizukuService.dispatchPermissionConfirmationResult (cognitive 29) · ×1
  • ShizukuService.dispatchPermissionConfirmationResult (cognitive 29) server/src/main/java/rikka/shizuku/server/ShizukuService.java:547 — ShizukuService.dispatchPermissionConfirmationResult has cognitive complexity 29 (threshold 15). Drivers by points: if/else 12 (21 pts), loops 2 (4 pts), boolean chains 2, ternaries 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · repair-translations.main (cognitive 29) · ×1
  • repair-translations.main (cognitive 29) ci/repair-translations.py:292 — repair-translations.main has cognitive complexity 29 (threshold 15). Drivers by points: if/else 11 (16 pts), loops 6 (8 pts), boolean chains 3, error handling 1 (2 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ShizukuAppKt.MainTabs (cognitive 28) · ×1
  • ShizukuAppKt.MainTabs (cognitive 28) manager/src/main/java/moe/shizuku/manager/ui/ShizukuApp.kt:509 — ShizukuAppKt.MainTabs has cognitive complexity 28 (threshold 15). Drivers by points: if/else 16 (23 pts), boolean chains 3, match/switch 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · InstallerScreenKt.InstallerScreen (cognitive 28) · ×1
  • InstallerScreenKt.InstallerScreen (cognitive 28) manager/src/main/java/moe/shizuku/manager/ui/screen/InstallerScreen.kt:130 — InstallerScreenKt.InstallerScreen has cognitive complexity 28 (threshold 15). Drivers by points: if/else 14 (21 pts), match/switch 2 (4 pts), boolean chains 3 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AppDataArchive.import (cognitive 27) · ×1
  • AppDataArchive.import (cognitive 27) manager/src/main/java/moe/shizuku/manager/files/AppDataArchive.kt:198 — AppDataArchive.import has cognitive complexity 27 (threshold 15). Drivers by points: if/else 13 (19 pts), loops 3, match/switch 2 (3 pts), error handling 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · HomeDiagnosticsKt.buildDiagnostics (cognitive 27) · ×1
  • HomeDiagnosticsKt.buildDiagnostics (cognitive 27) manager/src/main/java/moe/shizuku/manager/ui/screen/HomeDiagnostics.kt:62 — HomeDiagnosticsKt.buildDiagnostics has cognitive complexity 27 (threshold 15). Drivers by points: if/else 25, boolean chains 1, match/switch 1. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · update-contributors.build (cognitive 27) · ×1
  • update-contributors.build (cognitive 27) ci/update-contributors.py:233 — update-contributors.build has cognitive complexity 27 (threshold 15). Drivers by points: if/else 5 (12 pts), loops 6 (8 pts), ternaries 2 (4 pts), boolean chains 3 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AccessibilityScreenKt.AccessibilityScreen (cognitive 25) · ×1
  • AccessibilityScreenKt.AccessibilityScreen (cognitive 25) manager/src/main/java/moe/shizuku/manager/ui/screen/AccessibilityScreen.kt:79 — AccessibilityScreenKt.AccessibilityScreen has cognitive complexity 25 (threshold 15). Drivers by points: if/else 21 (23 pts), boolean chains 1, match/switch 1 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · MultiLocaleEntity.get (cognitive 25) · ×1
  • MultiLocaleEntity.get (cognitive 25) manager/src/main/java/moe/shizuku/manager/utils/MultiLocaleEntity.java:33 — MultiLocaleEntity.get has cognitive complexity 25 (threshold 15). Drivers by points: if/else 7 (17 pts), loops 4 (8 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · HidingWatchService.watch (cognitive 24) · ×1
  • HidingWatchService.watch (cognitive 24) manager/src/main/java/moe/shizuku/manager/service/HidingWatchService.kt:220 — HidingWatchService.watch has cognitive complexity 24 (threshold 15). Drivers by points: if/else 11 (21 pts), boolean chains 2, loops 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AdbStartRun.connectAndStart (cognitive 24) · ×1
  • AdbStartRun.connectAndStart (cognitive 24) manager/src/main/java/moe/shizuku/manager/start/AdbStartRun.kt:735 — AdbStartRun.connectAndStart has cognitive complexity 24 (threshold 15). Drivers by points: if/else 8 (16 pts), error handling 2 (4 pts), boolean chains 3, loops 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LogScreenKt.CaptureTab (cognitive 24) · ×1
  • LogScreenKt.CaptureTab (cognitive 24) manager/src/main/java/moe/shizuku/manager/ui/screen/LogScreen.kt:342 — LogScreenKt.CaptureTab has cognitive complexity 24 (threshold 15). Drivers by points: if/else 17 (19 pts), boolean chains 4, match/switch 1 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · StealthScreenKt.StealthScreen (cognitive 24) · ×1
  • StealthScreenKt.StealthScreen (cognitive 24) manager/src/main/java/moe/shizuku/manager/ui/screen/StealthScreen.kt:90 — StealthScreenKt.StealthScreen has cognitive complexity 24 (threshold 15). Drivers by points: if/else 11 (15 pts), match/switch 4 (5 pts), boolean chains 4 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ShizukuService.getApplications (cognitive 24) · ×1
  • ShizukuService.getApplications (cognitive 24) server/src/main/java/rikka/shizuku/server/ShizukuService.java:700 — ShizukuService.getApplications has cognitive complexity 24 (threshold 15). Drivers by points: if/else 8 (19 pts), loops 2 (3 pts), boolean chains 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ModulePackage.extract (cognitive 23) · ×1
  • ModulePackage.extract (cognitive 23) manager/src/main/java/moe/shizuku/manager/module/ModulePackage.kt:108 — ModulePackage.extract has cognitive complexity 23 (threshold 15). Drivers by points: if/else 9 (20 pts), loops 2 (3 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CatalogScreenKt.CatalogScreen (cognitive 23) · ×1
  • CatalogScreenKt.CatalogScreen (cognitive 23) manager/src/main/java/moe/shizuku/manager/ui/screen/CatalogScreen.kt:196 — CatalogScreenKt.CatalogScreen has cognitive complexity 23 (threshold 15). Drivers by points: if/else 15 (18 pts), boolean chains 4, match/switch 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · AdbRoot.setRoot (cognitive 22) · ×1
  • AdbRoot.setRoot (cognitive 22) manager/src/main/java/moe/shizuku/manager/adb/AdbRoot.kt:55 — AdbRoot.setRoot has cognitive complexity 22 (threshold 15). Drivers by points: if/else 12 (15 pts), boolean chains 4, error handling 2, loops 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · ShizukuAppKt.TelevisionTabs (cognitive 22) · ×1
  • ShizukuAppKt.TelevisionTabs (cognitive 22) manager/src/main/java/moe/shizuku/manager/ui/ShizukuApp.kt:859 — ShizukuAppKt.TelevisionTabs has cognitive complexity 22 (threshold 15). Drivers by points: if/else 15 (16 pts), boolean chains 4, match/switch 2 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · DisplayScreenKt.DisplayScreen (cognitive 22) · ×1
  • DisplayScreenKt.DisplayScreen (cognitive 22) manager/src/main/java/moe/shizuku/manager/ui/screen/DisplayScreen.kt:93 — DisplayScreenKt.DisplayScreen has cognitive complexity 22 (threshold 15). Drivers by points: if/else 17 (21 pts), boolean chains 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · ShizukuService.updateFlagsForUid (cognitive 22) · ×1
  • ShizukuService.updateFlagsForUid (cognitive 22) server/src/main/java/rikka/shizuku/server/ShizukuService.java:647 — ShizukuService.updateFlagsForUid has cognitive complexity 22 (threshold 15). Drivers by points: if/else 8 (17 pts), loops 2 (4 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AdbStarter.startAdb (cognitive 21) · ×1
  • AdbStarter.startAdb (cognitive 21) manager/src/main/java/moe/shizuku/manager/adb/AdbStarter.kt:75 — AdbStarter.startAdb has cognitive complexity 21 (threshold 15). Drivers by points: if/else 13 (16 pts), boolean chains 5 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · ModulesScreenKt.ModuleCard (cognitive 21) · ×1
  • ModulesScreenKt.ModuleCard (cognitive 21) manager/src/main/java/moe/shizuku/manager/ui/screen/ModulesScreen.kt:792 — ModulesScreenKt.ModuleCard has cognitive complexity 21 (threshold 15). Drivers by points: if/else 15 (18 pts), boolean chains 3 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · PermissionsScreenKt.PermissionsScreen (cognitive 21) · ×1
  • PermissionsScreenKt.PermissionsScreen (cognitive 21) manager/src/main/java/moe/shizuku/manager/ui/screen/PermissionsScreen.kt:88 — PermissionsScreenKt.PermissionsScreen has cognitive complexity 21 (threshold 15). Drivers by points: if/else 17 (20 pts), boolean chains 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · ThemeKt.ShizukuTheme (cognitive 21) · ×1
  • ThemeKt.ShizukuTheme (cognitive 21) manager/src/main/java/moe/shizuku/manager/ui/theme/Theme.kt:82 — ThemeKt.ShizukuTheme has cognitive complexity 21 (threshold 15). Drivers by points: if/else 13 (15 pts), boolean chains 4, match/switch 2 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · ShizukuStateMachine.transition (cognitive 21) · ×1
  • ShizukuStateMachine.transition (cognitive 21) manager/src/main/java/moe/shizuku/manager/utils/ShizukuStateMachine.kt:73 — ShizukuStateMachine.transition has cognitive complexity 21 (threshold 15). Drivers by points: if/else 10 (17 pts), boolean chains 2, match/switch 1 (2 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AuthorizationManager.getPackages (cognitive 20) · ×1
  • AuthorizationManager.getPackages (cognitive 20) manager/src/main/java/moe/shizuku/manager/authorization/AuthorizationManager.kt:52 — AuthorizationManager.getPackages has cognitive complexity 20 (threshold 15). Drivers by points: if/else 5 (11 pts), loops 2 (4 pts), error handling 1 (3 pts), boolean chains 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ForceDark.apply (cognitive 20) · ×1
  • ForceDark.apply (cognitive 20) manager/src/main/java/moe/shizuku/manager/manage/ForceDark.kt:150 — ForceDark.apply has cognitive complexity 20 (threshold 15). Drivers by points: if/else 10 (19 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ShizukuReceiverStarter.adbStart (cognitive 20) · ×1
  • ShizukuReceiverStarter.adbStart (cognitive 20) manager/src/main/java/moe/shizuku/manager/receiver/ShizukuReceiverStarter.kt:249 — ShizukuReceiverStarter.adbStart has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (11 pts), boolean chains 9 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · WatchdogService.attemptRestart (cognitive 20) · ×1
  • WatchdogService.attemptRestart (cognitive 20) manager/src/main/java/moe/shizuku/manager/service/WatchdogService.kt:221 — WatchdogService.attemptRestart has cognitive complexity 20 (threshold 15). Drivers by points: if/else 12 (13 pts), boolean chains 4, match/switch 2, error handling 1 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · DeviceInfoScreenKt.DeviceInfoScreen (cognitive 20) · ×1
  • DeviceInfoScreenKt.DeviceInfoScreen (cognitive 20) manager/src/main/java/moe/shizuku/manager/ui/screen/DeviceInfoScreen.kt:74 — DeviceInfoScreenKt.DeviceInfoScreen has cognitive complexity 20 (threshold 15). Drivers by points: if/else 17 (18 pts), boolean chains 2 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · LogScreenKt.AppLogTab (cognitive 20) · ×1
  • LogScreenKt.AppLogTab (cognitive 20) manager/src/main/java/moe/shizuku/manager/ui/screen/LogScreen.kt:178 — LogScreenKt.AppLogTab has cognitive complexity 20 (threshold 15). Drivers by points: if/else 13 (14 pts), boolean chains 5, match/switch 1 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · PowerScreenKt.PowerScreen (cognitive 20) · ×1
  • PowerScreenKt.PowerScreen (cognitive 20) manager/src/main/java/moe/shizuku/manager/ui/screen/PowerScreen.kt:144 — PowerScreenKt.PowerScreen has cognitive complexity 20 (threshold 15). Drivers by points: if/else 14 (15 pts), boolean chains 4, match/switch 1 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · Android17Compat.checkPermission (cognitive 20) · ×1
  • Android17Compat.checkPermission (cognitive 20) server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:161 — Android17Compat.checkPermission has cognitive complexity 20 (threshold 15). Drivers by points: if/else 4 (11 pts), loops 2 (5 pts), boolean chains 2, error handling 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Hiding.reconcile (cognitive 19) · ×1
  • Hiding.reconcile (cognitive 19) manager/src/main/java/moe/shizuku/manager/manage/Hiding.kt:440 — Hiding.reconcile has cognitive complexity 19 (threshold 15). Drivers by points: if/else 11 (16 pts), boolean chains 2, match/switch 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PackageTools.loadDetail (cognitive 19) · ×1
  • PackageTools.loadDetail (cognitive 19) manager/src/main/java/moe/shizuku/manager/manage/PackageTools.kt:236 — PackageTools.loadDetail has cognitive complexity 19 (threshold 15). Drivers by points: if/else 14, boolean chains 5. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · SegmentedListKt.SegmentedListItem (cognitive 19) · ×1
  • SegmentedListKt.SegmentedListItem (cognitive 19) manager/src/main/java/moe/shizuku/manager/ui/component/SegmentedList.kt:117 — SegmentedListKt.SegmentedListItem has cognitive complexity 19 (threshold 15). Drivers by points: if/else 15 (16 pts), boolean chains 2, match/switch 1 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · SetupScreenKt.PermissionsPage (cognitive 19) · ×1
  • SetupScreenKt.PermissionsPage (cognitive 19) manager/src/main/java/moe/shizuku/manager/ui/screen/SetupScreen.kt:369 — SetupScreenKt.PermissionsPage has cognitive complexity 19 (threshold 15). Drivers by points: if/else 12 (16 pts), boolean chains 3 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LabSwitch.apply (cognitive 18) · ×1
  • LabSwitch.apply (cognitive 18) manager/src/main/java/moe/shizuku/manager/manage/LabSwitch.kt:177 — LabSwitch.apply has cognitive complexity 18 (threshold 15). Drivers by points: if/else 10 (15 pts), match/switch 2 (3 pts) (nesting depth added 6). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · ServiceStarter.sendBinder (cognitive 18) · ×1
  • ServiceStarter.sendBinder (cognitive 18) starter/src/main/java/moe/shizuku/starter/ServiceStarter.java:107 — ServiceStarter.sendBinder has cognitive complexity 18 (threshold 15). Drivers by points: if/else 9 (12 pts), error handling 2 (3 pts), boolean chains 2, loops 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AppDataArchive.exportNow (cognitive 17) · ×1
  • AppDataArchive.exportNow (cognitive 17) manager/src/main/java/moe/shizuku/manager/files/AppDataArchive.kt:113 — AppDataArchive.exportNow has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (14 pts), loops 2 (3 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PackageTools.setFirewallMobileOnly (cognitive 16) · ×1
  • PackageTools.setFirewallMobileOnly (cognitive 16) manager/src/main/java/moe/shizuku/manager/manage/PackageTools.kt:613 — PackageTools.setFirewallMobileOnly has cognitive complexity 16 (threshold 15). Drivers by points: if/else 11 (15 pts), boolean chains 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · InstallerScreenKt.PackageDetailsCard (cognitive 16) · ×1
  • InstallerScreenKt.PackageDetailsCard (cognitive 16) manager/src/main/java/moe/shizuku/manager/ui/screen/InstallerScreen.kt:585 — InstallerScreenKt.PackageDetailsCard has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (11 pts), match/switch 2 (3 pts), boolean chains 2 (nesting depth added 5). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · ApkChangedObserversKt.eventToString (cognitive 16) · ×1
  • ApkChangedObserversKt.eventToString (cognitive 16) server/src/main/java/rikka/shizuku/server/ApkChangedObservers.kt:122 — ApkChangedObserversKt.eventToString has cognitive complexity 16 (threshold 15). Drivers by points: if/else 16. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D4 · Code Duplication · Members sharing a duplicated core (7 members, 50+ identical tokens) · ×1
  • Members sharing a duplicated core (7 members, 50+ identical tokens) manager/src/main/java/moe/shizuku/manager/ui/screen/AccessibilityScreen.kt:79 — manager/src/main/java/moe/shizuku/manager/ui/screen/AccessibilityScreen.kt:79-334 | manager/src/main/java/moe/shizuku/manager/ui/screen/ActivitiesScreen.kt:98-720 | manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:139-866 | manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:84-401 | manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt:247-1089 | manager/src/main/java/moe/shizuku/manager/ui/screen/ManageScreen.kt:169-708 | manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt:103-425 — These 7 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 7 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 7 times.
D4 · Code Duplication · Members sharing a duplicated core (6 members, 50+ identical tokens) · ×1
  • Members sharing a duplicated core (6 members, 50+ identical tokens) manager/src/main/java/moe/shizuku/manager/ui/screen/ActivitiesScreen.kt:98 — manager/src/main/java/moe/shizuku/manager/ui/screen/ActivitiesScreen.kt:98-720 | manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:84-401 | manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt:247-1089 | manager/src/main/java/moe/shizuku/manager/ui/screen/LogScreen.kt:656-711 | manager/src/main/java/moe/shizuku/manager/ui/screen/ManageScreen.kt:169-708 | manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt:103-425 — These 6 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 6 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 6 times.
D4 · Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) · ×1
  • Members sharing a duplicated core (4 members, 50+ identical tokens) manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt:121 — manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt:121-938 | manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:139-866 | manager/src/main/java/moe/shizuku/manager/ui/screen/ModulesScreen.kt:138-780 | manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt:216-1835 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication · Edited copy of a member (27 corresponding lines) · ×1
  • Edited copy of a member (27 corresponding lines) server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:200 — server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:200-226 | server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:230-256 — These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (30 corresponding lines) · ×1
  • Edited copy of a member (30 corresponding lines) manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt:1140 — manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt:1140-1169 | manager/src/main/java/moe/shizuku/manager/ui/screen/ManageScreen.kt:876-910 — These two members are one piece of code written twice and then edited apart: 30 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (33 corresponding lines) · ×1
  • Edited copy of a member (33 corresponding lines) manager/src/main/java/moe/shizuku/manager/ui/screen/CatalogScreen.kt:589 — manager/src/main/java/moe/shizuku/manager/ui/screen/CatalogScreen.kt:589-621 | manager/src/main/java/moe/shizuku/manager/ui/screen/ModuleRepoScreen.kt:501-538 — These two members are one piece of code written twice and then edited apart: 33 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (22 corresponding lines) · ×1
  • Edited copy of a member (22 corresponding lines) manager/src/main/java/moe/shizuku/manager/ui/screen/FilesScreen.kt:798 — manager/src/main/java/moe/shizuku/manager/ui/screen/FilesScreen.kt:798-819 | manager/src/main/java/moe/shizuku/manager/ui/screen/ShellScreen.kt:1309-1332 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (25 corresponding lines) · ×1
  • Edited copy of a member (25 corresponding lines) manager/src/main/java/moe/shizuku/manager/receiver/WatchdogAlarmReceiver.kt:95 — manager/src/main/java/moe/shizuku/manager/receiver/WatchdogAlarmReceiver.kt:95-120 | manager/src/main/java/moe/shizuku/manager/service/WatchdogService.kt:609-633 — These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 18+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 18+ corresponding lines) server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:51 — server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:51-68 | server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:70-87 | server/src/main/java/rikka/shizuku/server/util/UsersCompat.java:57-74 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 18 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (16 corresponding lines) · ×1
  • Edited copy of a member (16 corresponding lines) manager/src/main/java/moe/shizuku/manager/manage/Activities.kt:173 — manager/src/main/java/moe/shizuku/manager/manage/Activities.kt:173-193 | manager/src/main/java/moe/shizuku/manager/manage/Activities.kt:212-227 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (21 corresponding lines) · ×1
  • Edited copy of a member (21 corresponding lines) manager/src/main/java/moe/shizuku/manager/ui/component/SegmentedList.kt:41 — manager/src/main/java/moe/shizuku/manager/ui/component/SegmentedList.kt:41-67 | manager/src/main/java/moe/shizuku/manager/ui/component/SegmentedList.kt:81-101 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (12 corresponding lines) · ×1
  • Edited copy of a member (12 corresponding lines) manager/src/main/java/moe/shizuku/manager/shell/ShellBookmarks.kt:47 — manager/src/main/java/moe/shizuku/manager/shell/ShellBookmarks.kt:47-59 | manager/src/main/java/moe/shizuku/manager/shell/ShellHistory.kt:65-76 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (6 corresponding lines) · ×1
  • Edited copy of a member (6 corresponding lines) server/src/main/java/rikka/shizuku/server/util/InstalledPackagesCompat.java:121 — server/src/main/java/rikka/shizuku/server/util/InstalledPackagesCompat.java:121-131 | server/src/main/java/rikka/shizuku/server/util/InstalledPackagesCompat.java:134-139 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (3 corresponding lines) · ×1
  • Edited copy of a member (3 corresponding lines) manager/src/main/java/moe/shizuku/manager/files/AppDataArchive.kt:411 — manager/src/main/java/moe/shizuku/manager/files/AppDataArchive.kt:411-414 | manager/src/main/java/moe/shizuku/manager/files/FileOperations.kt:286-288 — These two members are one piece of code written twice and then edited apart: 3 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (23–24 lines × 2) · ×1
  • Duplicated block (23–24 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/ModuleRepoScreen.kt:180 — manager/src/main/java/moe/shizuku/manager/ui/screen/ModuleRepoScreen.kt:180-202 | manager/src/main/java/moe/shizuku/manager/ui/screen/ModulesScreen.kt:350-373 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/ModuleRepoScreen.kt:180` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `manager/src/main/java/moe/shizuku/manager/ui/screen/ModulesScreen.kt:349` calls `WindowInsets` and `manager/src/main/java/moe/shizuku/manager/ui/screen/ModuleRepoScreen.kt:179` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (22 lines × 4) · ×1
  • Duplicated block (22 lines × 4) manager/src/main/java/moe/shizuku/manager/ui/screen/DisplayScreen.kt:203 — manager/src/main/java/moe/shizuku/manager/ui/screen/DisplayScreen.kt:203-224 | manager/src/main/java/moe/shizuku/manager/ui/screen/HidingScreen.kt:145-166 | manager/src/main/java/moe/shizuku/manager/ui/screen/InstallerScreen.kt:243-264 | manager/src/main/java/moe/shizuku/manager/ui/screen/PowerScreen.kt:248-269 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 4 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/DisplayScreen.kt:203` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (14–22 lines × 3) · ×1
  • Duplicated block (14–22 lines × 3) manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:155 — manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:155-168 | manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt:427-448 | manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt:185-199 — before extracting anything, compare `manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt` and `manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 127 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:155` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt:449` calls `slotKey` and `manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt:200` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (22 lines × 2) · ×1
  • Duplicated block (22 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/ModuleRepoScreen.kt:516 — manager/src/main/java/moe/shizuku/manager/ui/screen/ModuleRepoScreen.kt:516-537 | manager/src/main/java/moe/shizuku/manager/ui/screen/ModulesScreen.kt:838-859 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/ModulesScreen.kt:838` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (15–20 lines × 4) · ×1
  • Duplicated block (15–20 lines × 4) manager/src/main/java/moe/shizuku/manager/ui/screen/AccessibilityScreen.kt:164 — manager/src/main/java/moe/shizuku/manager/ui/screen/AccessibilityScreen.kt:164-181 | manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:201-218 | manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt:619-638 | manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt:245-259 — before extracting anything, compare `manager/src/main/java/moe/shizuku/manager/ui/screen/AccessibilityScreen.kt` and `manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 50 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/AccessibilityScreen.kt:164` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (18–20 lines × 3) · ×1
  • Duplicated block (18–20 lines × 3) manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:280 — manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:280-299 | manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt:805-824 | manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt:299-316 — before extracting anything, compare `manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt` and `manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 127 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:280` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (18–20 lines × 2) · ×1
  • Duplicated block (18–20 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/DisplayScreen.kt:404 — manager/src/main/java/moe/shizuku/manager/ui/screen/DisplayScreen.kt:404-421 | manager/src/main/java/moe/shizuku/manager/ui/screen/DisplayScreen.kt:483-502 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/DisplayScreen.kt:404` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `manager/src/main/java/moe/shizuku/manager/ui/screen/DisplayScreen.kt:402` calls `toFloatOrNull`, `roundToInt` and `manager/src/main/java/moe/shizuku/manager/ui/screen/DisplayScreen.kt:482` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (20 lines × 2) · ×1
  • Duplicated block (20 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:382 — manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:382-401 | manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt:406-425 — before extracting anything, compare `manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt` and `manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 201 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:382` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (19 lines × 3) · ×1
  • Duplicated block (19 lines × 3) manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:382 — manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:382-400 | manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt:1052-1070 | manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt:406-424 — before extracting anything, compare `manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt` and `manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 127 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:382` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (16–18 lines × 2) · ×1
  • Duplicated block (16–18 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:98 — manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:98-115 | manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt:116-131 — before extracting anything, compare `manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt` and `manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 201 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:98` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:96` calls `mutableStateOf`, `usesSystemTheme` and `manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt:115` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (14–17 lines × 7) · ×1
  • Duplicated block (14–17 lines × 7) manager/src/main/java/moe/shizuku/manager/ui/screen/AccessibilityScreen.kt:260 — manager/src/main/java/moe/shizuku/manager/ui/screen/AccessibilityScreen.kt:260-276 | manager/src/main/java/moe/shizuku/manager/ui/screen/ActivitiesScreen.kt:452-468 | manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:572-586 | manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:296-312 | manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt:821-837 | manager/src/main/java/moe/shizuku/manager/ui/screen/ManageScreen.kt:479-492 | manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt:313-329 — before extracting anything, compare `manager/src/main/java/moe/shizuku/manager/ui/screen/AccessibilityScreen.kt` and `manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 50 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/AccessibilityScreen.kt:260` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (17 lines × 7) · ×1
  • Duplicated block (17 lines × 7) manager/src/main/java/moe/shizuku/manager/ui/screen/DisplayScreen.kt:210 — manager/src/main/java/moe/shizuku/manager/ui/screen/DisplayScreen.kt:210-226 | manager/src/main/java/moe/shizuku/manager/ui/screen/FilesScreen.kt:516-532 | manager/src/main/java/moe/shizuku/manager/ui/screen/HidingScreen.kt:152-168 | manager/src/main/java/moe/shizuku/manager/ui/screen/InstallerScreen.kt:250-266 | manager/src/main/java/moe/shizuku/manager/ui/screen/LabsScreen.kt:189-205 | manager/src/main/java/moe/shizuku/manager/ui/screen/PowerScreen.kt:255-271 | manager/src/main/java/moe/shizuku/manager/ui/screen/WifiPasswordsScreen.kt:379-395 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 7 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/DisplayScreen.kt:210` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (17 lines × 3) · ×1
  • Duplicated block (17 lines × 3) manager/src/main/java/moe/shizuku/manager/ui/screen/IntentsScreen.kt:68 — manager/src/main/java/moe/shizuku/manager/ui/screen/IntentsScreen.kt:68-84 | manager/src/main/java/moe/shizuku/manager/ui/screen/PermissionsScreen.kt:175-191 | manager/src/main/java/moe/shizuku/manager/ui/screen/TerminalScreen.kt:57-73 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/IntentsScreen.kt:68` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (16 lines × 7) · ×1
  • Duplicated block (16 lines × 7) manager/src/main/java/moe/shizuku/manager/ui/screen/DisplayScreen.kt:202 — manager/src/main/java/moe/shizuku/manager/ui/screen/DisplayScreen.kt:202-217 | manager/src/main/java/moe/shizuku/manager/ui/screen/HidingScreen.kt:144-159 | manager/src/main/java/moe/shizuku/manager/ui/screen/InstallerScreen.kt:242-257 | manager/src/main/java/moe/shizuku/manager/ui/screen/IntentsScreen.kt:67-82 | manager/src/main/java/moe/shizuku/manager/ui/screen/PermissionsScreen.kt:174-189 | manager/src/main/java/moe/shizuku/manager/ui/screen/PowerScreen.kt:247-262 | manager/src/main/java/moe/shizuku/manager/ui/screen/TerminalScreen.kt:56-71 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 7 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/DisplayScreen.kt:202` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (16 lines × 2) · ×1
  • Duplicated block (16 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:512 — manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:512-527 | manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt:751-766 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:512` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (32 lines × 2) · ×1
  • Duplicated block (32 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:503 — manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:503-534 | manager/src/main/java/moe/shizuku/manager/ui/screen/ManageScreen.kt:437-468 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (14 lines × 3) · ×1
  • Duplicated block (14 lines × 3) manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:264 — manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:264-277 | manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt:386-399 | manager/src/main/java/moe/shizuku/manager/ui/screen/ManageScreen.kt:227-240 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (8–13 lines × 2) · ×1
  • Duplicated block (8–13 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/AccessibilityScreen.kt:278 — manager/src/main/java/moe/shizuku/manager/ui/screen/AccessibilityScreen.kt:278-290 | manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt:321-328 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/AccessibilityScreen.kt:278` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (10–13 lines × 2) · ×1
  • Duplicated block (10–13 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/DeviceInfoScreen.kt:112 — manager/src/main/java/moe/shizuku/manager/ui/screen/DeviceInfoScreen.kt:112-121 | manager/src/main/java/moe/shizuku/manager/ui/screen/WifiPasswordsScreen.kt:233-245 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/DeviceInfoScreen.kt:112` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (12 lines × 6) · ×1
  • Duplicated block (12 lines × 6) manager/src/main/java/moe/shizuku/manager/ui/screen/AccessibilityScreen.kt:279 — manager/src/main/java/moe/shizuku/manager/ui/screen/AccessibilityScreen.kt:279-290 | manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:315-326 | manager/src/main/java/moe/shizuku/manager/ui/screen/HidingScreen.kt:156-168 | manager/src/main/java/moe/shizuku/manager/ui/screen/LabsScreen.kt:193-205 | manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt:332-343 | manager/src/main/java/moe/shizuku/manager/ui/screen/WifiPasswordsScreen.kt:383-395 — before extracting anything, compare `manager/src/main/java/moe/shizuku/manager/ui/screen/AccessibilityScreen.kt` and `manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 50 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/AccessibilityScreen.kt:279` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (12 lines × 4) · ×1
  • Duplicated block (12 lines × 4) manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt:871 — manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt:871-882 | manager/src/main/java/moe/shizuku/manager/ui/screen/ModulesScreen.kt:738-749 | manager/src/main/java/moe/shizuku/manager/ui/screen/ModulesScreen.kt:759-770 | manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt:1519-1530 — there are 4 copies across 3 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt:871` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9–12 lines × 3) · ×1
  • Duplicated block (9–12 lines × 3) manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:593 — manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:593-601 | manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:316-327 | manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt:333-344 — before extracting anything, compare `manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt` and `manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 201 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:593` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (12 lines × 3) · ×1
  • Duplicated block (12 lines × 3) manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt:1499 — manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt:1499-1510 | manager/src/main/java/moe/shizuku/manager/ui/screen/StealthScreen.kt:371-382 | manager/src/main/java/moe/shizuku/manager/ui/screen/WifiPasswordsScreen.kt:662-673 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt:1499` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (11–12 lines × 2) · ×1
  • Duplicated block (11–12 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt:1152 — manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt:1152-1163 | manager/src/main/java/moe/shizuku/manager/ui/screen/ManageScreen.kt:894-904 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt:1152` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `state` to `BulkToggleState.Running` in one and `BulkState.Running` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (10–11 lines × 2) · ×1
  • Duplicated block (10–11 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/ActivitiesScreen.kt:271 — manager/src/main/java/moe/shizuku/manager/ui/screen/ActivitiesScreen.kt:271-281 | manager/src/main/java/moe/shizuku/manager/ui/screen/LogScreen.kt:667-676 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/ActivitiesScreen.kt:271` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (19–20 lines × 3) · ×1
  • Duplicated block (19–20 lines × 3) manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:510 — manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:510-529 | manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt:750-768 | manager/src/main/java/moe/shizuku/manager/ui/screen/ManageScreen.kt:444-463 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:510` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (10 lines × 3) · ×1
  • Duplicated block (10 lines × 3) manager/src/main/java/moe/shizuku/manager/ui/screen/CatalogScreen.kt:308 — manager/src/main/java/moe/shizuku/manager/ui/screen/CatalogScreen.kt:308-317 | manager/src/main/java/moe/shizuku/manager/ui/screen/ModuleRepoScreen.kt:151-160 | manager/src/main/java/moe/shizuku/manager/ui/screen/ModulesScreen.kt:326-335 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/CatalogScreen.kt:308` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `manager/src/main/java/moe/shizuku/manager/ui/screen/ModulesScreen.kt:323` calls `rememberLazyListState`, `Box`, `fillMaxSize` and `manager/src/main/java/moe/shizuku/manager/ui/screen/CatalogScreen.kt:306` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (9 lines × 5) · ×1
  • Duplicated block (9 lines × 5) manager/src/main/java/moe/shizuku/manager/ui/screen/ActivitiesScreen.kt:272 — manager/src/main/java/moe/shizuku/manager/ui/screen/ActivitiesScreen.kt:272-280 | manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt:154-166 | manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt:426-444 | manager/src/main/java/moe/shizuku/manager/ui/screen/LogScreen.kt:668-676 | manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt:184-195 — before extracting anything, compare `manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt` and `manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 127 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (9 lines × 3) · ×1
  • Duplicated block (9 lines × 3) manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt:426 — manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt:426-434 | manager/src/main/java/moe/shizuku/manager/ui/screen/ManageScreen.kt:272-280 | manager/src/main/java/moe/shizuku/manager/ui/screen/RotationScreen.kt:184-192 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (9 lines × 2) · ×1
  • Duplicated block (9 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt:1094 — manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt:1094-1102 | manager/src/main/java/moe/shizuku/manager/ui/screen/ShellScreen.kt:1322-1332 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/AppDetailScreen.kt:1094` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (8–9 lines × 2) · ×1
  • Duplicated block (8–9 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/ModuleActionScreen.kt:115 — manager/src/main/java/moe/shizuku/manager/ui/screen/ModuleActionScreen.kt:115-122 | manager/src/main/java/moe/shizuku/manager/ui/screen/ModuleWebUiScreen.kt:76-84 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/ModuleActionScreen.kt:115` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (8 lines × 3) · ×1
  • Duplicated block (8 lines × 3) manager/src/main/java/moe/shizuku/manager/ui/screen/CatalogScreen.kt:338 — manager/src/main/java/moe/shizuku/manager/ui/screen/CatalogScreen.kt:338-345 | manager/src/main/java/moe/shizuku/manager/ui/screen/ModuleRepoScreen.kt:182-189 | manager/src/main/java/moe/shizuku/manager/ui/screen/ModulesScreen.kt:352-359 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/CatalogScreen.kt:338` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `manager/src/main/java/moe/shizuku/manager/ui/screen/ModuleRepoScreen.kt:181` calls `TelevisionRefreshButton` and `manager/src/main/java/moe/shizuku/manager/ui/screen/CatalogScreen.kt:337` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (7–8 lines × 2) · ×1
  • Duplicated block (7–8 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/screen/ActivitiesScreen.kt:284 — manager/src/main/java/moe/shizuku/manager/ui/screen/ActivitiesScreen.kt:284-291 | manager/src/main/java/moe/shizuku/manager/ui/screen/ActivitiesScreen.kt:300-306 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `manager/src/main/java/moe/shizuku/manager/ui/screen/ActivitiesScreen.kt:284` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `manager/src/main/java/moe/shizuku/manager/ui/screen/ActivitiesScreen.kt:306` calls `contains` and `manager/src/main/java/moe/shizuku/manager/ui/screen/ActivitiesScreen.kt:291` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (14 lines × 2) · ×1
  • Duplicated block (14 lines × 2) manager/src/main/java/moe/shizuku/manager/ui/component/IntentForm.kt:499 — manager/src/main/java/moe/shizuku/manager/ui/component/IntentForm.kt:499-512 | manager/src/main/java/moe/shizuku/manager/ui/screen/ActivitiesScreen.kt:790-803 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Note first that the copies are not typed on the same thing: the declarations holding them bind `error` to `Boolean` in one and `Boolean = false` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (17 lines × 2) · ×1
  • Duplicated block (17 lines × 2) server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:292 — server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:292-308 | server/src/main/java/rikka/shizuku/server/util/UsersCompat.java:194-210 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `server/src/main/java/rikka/shizuku/server/util/Android17Compat.java:292` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (5 lines × 3) · ×1
  • Duplicated block (5 lines × 3) server/src/main/java/rikka/shizuku/server/ShizukuService.java:589 — server/src/main/java/rikka/shizuku/server/ShizukuService.java:589-593 | server/src/main/java/rikka/shizuku/server/ShizukuService.java:619-623 | server/src/main/java/rikka/shizuku/server/ShizukuService.java:670-674 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `server/src/main/java/rikka/shizuku/server/ShizukuService.java:589` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
X2 · Cancellation propagation · Suspend function with a blocking request · ×1
  • Suspend function with a blocking request: download manager/src/main/java/moe/shizuku/manager/utils/UpdateHelper.kt:389 — `download` suspends, but makes its request with `newCall(…).execute()`, which blocks: its caller's cancellation cannot reach the request, so it runs to its end after whatever wanted it has given up — `withContext(Dispatchers.IO)` moves it off the caller's thread and does not change that. Make the request with a call that suspends: Ktor, OkHttp's `executeAsync()`, or a `suspendCancellableCoroutine` over `enqueue` that cancels the `Call` in `invokeOnCancellation`.
Minor — 40 finding(s)
D34 · Knowledge Freshness · Orphaned file · ×11
  • Orphaned file REDACTED:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file manager/src/main/java/moe/shizuku/manager/adb/AdbPairingClient.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file manager/src/main/java/moe/shizuku/manager/home/AdbPairDialogFragment.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file server/src/main/java/rikka/shizuku/server/BinderSender.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file manager/src/main/java/moe/shizuku/manager/adb/AdbMessage.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file manager/src/main/java/moe/shizuku/manager/utils/CustomTabsHelper.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file manager/src/main/java/moe/shizuku/manager/legacy/LegacyIsNotSupportedActivity.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file manager/src/main/java/moe/shizuku/manager/utils/Logger.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file manager/src/main/java/moe/shizuku/manager/ShizukuManagerProvider.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file manager/src/main/java/moe/shizuku/manager/Helps.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file manager/src/main/java/moe/shizuku/manager/utils/EmptySharedPreferencesImpl.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
X10 · Duplicated predicate · Duplicated predicate · ×7
  • Duplicated predicate manager/src/main/java/moe/shizuku/manager/install/AppInstall.kt:361 — `!entry.isDirectory && entry.name.endsWith(".apk", ignoreCase = true)` appears character-identically in 2 files — manager/src/main/java/moe/shizuku/manager/install/AppInstall.kt, manager/src/main/java/moe/shizuku/manager/install/PackageInspect.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate manager/src/main/java/moe/shizuku/manager/manage/WifiControl.kt:316 — `!rooted && !ShizukuStateMachine.isRunning()` appears character-identically in 2 files — manager/src/main/java/moe/shizuku/manager/manage/WifiControl.kt, manager/src/main/java/moe/shizuku/manager/start/AdbPortPersistence.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate manager/src/main/java/moe/shizuku/manager/adb/AdbPairingService.kt:120 — `Build.VERSION.SDK_INT >= Build.VERSION_CODES.S && e is ForegroundServiceStartNotAllowedException` appears character-identically in 2 files — manager/src/main/java/moe/shizuku/manager/adb/AdbPairingService.kt, manager/src/main/java/moe/shizuku/manager/adb/AdbPairingTutorialActivity.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate manager/src/main/java/moe/shizuku/manager/adb/AdbPairingAccessibilityService.kt:85 — `EnvironmentUtils.isTelevision() && EnvironmentUtils.isTlsSupported()` appears character-identically in 2 files — manager/src/main/java/moe/shizuku/manager/adb/AdbPairingAccessibilityService.kt, manager/src/main/java/moe/shizuku/manager/home/AccessibilityDialogHelper.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate manager/src/main/java/moe/shizuku/manager/ui/screen/ActivitiesScreen.kt:277 — `appLabel(pm, it).contains(trimmed, ignoreCase = true) || it.packageName.contains(trimmed, ignoreCase = true)` appears character-identically in 6 files — manager/src/main/java/moe/shizuku/manager/ui/screen/ActivitiesScreen.kt, manager/src/main/java/moe/shizuku/manager/ui/screen/ForceDarkScreen.kt, manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt, manager/src/main/java/moe/shizuku/manager/ui/screen/LogScreen.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt:269 — `it.applicationInfo != null && it.packageName !in systemPackages` appears character-identically in 3 files — manager/src/main/java/moe/shizuku/manager/ui/screen/AppsScreen.kt, manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt, manager/src/main/java/moe/shizuku/manager/ui/screen/ManageScreen.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate ci/check-translations.py:240 — `key not in base_texts or base_texts[key].strip()` appears character-identically in 2 files — ci/check-translations.py, ci/repair-translations.py. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
X7 · Silent fallback defaults · Silent fallback default in catch · ×7
  • Silent fallback default in catch manager/src/main/java/moe/shizuku/manager/files/AppDataArchive.kt:83 — `availableSections` swallows every exception into `emptyList()` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the KDoc, and the row stops firing.
  • Silent fallback default in catch manager/src/main/java/moe/shizuku/manager/install/AppInstall.kt:401 — `sizeOf` swallows every exception into `0L` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the KDoc, and the row stops firing.
  • Silent fallback default in catch manager/src/main/java/moe/shizuku/manager/manage/Activities.kt:341 — `targets` swallows every exception into `emptyList()` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the KDoc, and the row stops firing.
  • Silent fallback default in catch manager/src/main/java/moe/shizuku/manager/manage/Hiding.kt:781 — `vpnCandidates` swallows every exception into `emptyList()` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the KDoc, and the row stops firing.
  • Silent fallback default in catch manager/src/main/java/moe/shizuku/manager/shell/ShellBookmarks.kt:45 — `load` swallows every exception into `emptyList()` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the KDoc, and the row stops firing.
  • Silent fallback default in catch manager/src/main/java/moe/shizuku/manager/shell/ShellHistory.kt:41 — `load` swallows every exception into `emptyList()` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the KDoc, and the row stops firing.
  • Silent fallback default in catch manager/src/main/java/moe/shizuku/manager/utils/ShizukuSystemApis.kt:83 — `getInstalledPackagesAsShell` swallows every exception into `emptyList()` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the KDoc, and the row stops firing.
D16 · Bus Factor · Off-boarding risk · ×2
  • Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 82 significant file(s) lose their only recent owner: manager/src/main/java/moe/shizuku/manager/ui/screen/SettingsScreen.kt, manager/src/main/java/moe/shizuku/manager/ui/screen/HomeScreen.kt, manager/src/main/java/moe/shizuku/manager/ui/screen/ShellScreen.kt, manager/src/main/java/moe/shizuku/manager/ui/screen/LabsToggleScreen.kt, manager/src/main/java/moe/shizuku/manager/ui/screen/InstallerScreen.kt, manager/src/main/java/moe/shizuku/manager/manage/PackageTools.kt, manager/src/main/java/moe/shizuku/manager/ui/screen/ManageScreen.kt, manager/src/main/java/moe/shizuku/manager/ui/screen/FilesScreen.kt (+74 more). Pair on, review, or document these before any departure.
  • Off-boarding risk: anonymized user #2 — If anonymized user #2 becomes unavailable, 3 significant file(s) lose their only recent owner: manager/src/main/java/moe/shizuku/manager/ui/component/TelevisionFocus.kt, manager/src/main/java/moe/shizuku/manager/ui/component/TelevisionInput.kt, manager/src/main/java/moe/shizuku/manager/ui/component/TelevisionRefresh.kt. Pair on, review, or document these before any departure.
X7 · Silent fallback defaults · Silent fallback default on parse failure · ×2
  • Silent fallback default on parse failure manager/src/main/java/moe/shizuku/manager/ShizukuSettings.java:578 — `getTcpPort` returns `5555` when `NumberFormatException` is thrown, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the Javadoc, and the row stops firing.
  • Silent fallback default on parse failure ci/update-contributors.py:196 — `known_accounts` returns `{}` when `(OSError, ValueError)` is raised, with no log or raise — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment on the handler or in the docstring, and the row stops firing.
D20 · ADR Quality · No ADRs found · ×1
  • No ADRs found stub/build.gradle:2 — No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`. ADRs are expected here because `stub/build.gradle` makes this repository a deployable product (line 2).
D26 · Project Cohesion · Projects may be oversized for their cohesion · ×1
  • Projects may be oversized for their cohesion manager/build.gradle:1 — `manager` (51333 LoC, 790 module-visible types across 26 directories) overshoots its size bounds. 1 of 7 build unit(s) (Gradle) overshoot their size bounds, lowering Project Cohesion to 7.1/10. Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.
D34 · Knowledge Freshness · Orphaned files with no living knowledge · ×1
  • Orphaned files with no living knowledge — 11 of 186 analysed file(s) have no living knowledge left — their last meaningful change has decayed away, so if one breaks, no one currently understands it (counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated, example/demo and scaffolding-template trees and test files identified by path convention, largest first; 186 of the 256 production source files in this repository met that bar). None is large enough to earn a read-through of its own, so this row stands in for the per-file rows rather than raising one each — most significant first: REDACTED, manager/src/main/java/moe/shizuku/manager/adb/AdbPairingClient.kt, manager/src/main/java/moe/shizuku/manager/home/AdbPairDialogFragment.kt, server/src/main/java/rikka/shizuku/server/BinderSender.java, manager/src/main/java/moe/shizuku/manager/adb/AdbMessage.kt, manager/src/main/java/moe/shizuku/manager/utils/CustomTabsHelper.java, manager/src/main/java/moe/shizuku/manager/legacy/LegacyIsNotSupportedActivity.kt, manager/src/main/java/moe/shizuku/manager/utils/Logger.java (and 3 more). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway.
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
M2 · Architecture documentation · No ADRs · ×1
  • No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
M2 · Architecture documentation · No architecture diagram/doc · ×1
  • No architecture diagram/doc — No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.
P2 · Observability · Logging is not universal · ×1
  • Logging is not universal — Only 1/4 runnable modules use logging (modules with no entry point or server are excluded — they are libraries a runnable module hosts). Silent: `server`, `shell`, `starter`.
P3 · Security & performance tooling · No SAST · ×1
  • No SAST REDACTED:12 — No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 8 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
P3 · Security & performance tooling · Dependabot does not watch gradle/gitsubmodule · ×1
  • Dependabot does not watch gradle/gitsubmodule REDACTED:10 — `REDACTED` schedules updates, but no `package-ecosystem` entry covers `gradle`, `gitsubmodule`, which this tree depends on — so those dependencies get no update pull requests and no advisory pressure, however complete the dep-scan credit looks. Add the missing entries to the `updates:` list.
P6 · Release Hygiene · No changelog · ×1
  • No changelog — No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
X2 · Cancellation propagation · Not all suspend functions that make a request accept the coroutine's cancellation · ×1
  • Not all suspend functions that make a request accept the coroutine's cancellation — Only 0/1 suspend functions that make a cancellable request (Ktor, OkHttp newCall, URL streams) accept the coroutine's cancellation or pass one on, so a request keeps running after whatever wanted it has given up — a screen navigated away from, a disposed widget, a superseded search. In a suspend function, make the request with a call that suspends — Ktor, OkHttp's `executeAsync()`, or a `suspendCancellableCoroutine` that cancels the `Call` — not a blocking `execute()`: `withContext(Dispatchers.IO)` moves the call off the caller's thread but does not make it cancellable; where nothing could ever cancel the call, omitting it is a deliberate choice — judge against how the function is used.
Minor — 1 finding(s)
D5 · Coupling · Off the main sequence · ×1
  • Off the main sequence: :common — :common: abstractness 0.00, instability 0.00, distance 1.00 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

DimensionToolVersionCommandFindingsRaw output
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=0 --max-count=200" --report-format json --report-path /tmp/watchdog-gitleaks-eb8ce979888e4a55bcc3e3c6187f4f64/history.json --exit-code 0 --source .0artifacts/raw/gitleaks-history.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=200 --max-count=800" --report-format json --report-path /tmp/watchdog-gitleaks-eb8ce979888e4a55bcc3e3c6187f4f64/history-1.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-1.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=1000 --max-count=1127" --report-format json --report-path /tmp/watchdog-gitleaks-eb8ce979888e4a55bcc3e3c6187f4f64/history-2.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-2.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-git --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-eb8ce979888e4a55bcc3e3c6187f4f64/tree.json --exit-code 0 --source .0artifacts/raw/gitleaks-tree.json
D29 · Static Analysis (SAST)semgrep—semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --config /opt/semgrep-rules/canine-sast.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off --exclude *.arrow --exclude *.avro --exclude *.csv --exclude *.dat --exclude *.db --exclude *.feather --exclude *.geojson --exclude *.h5 --exclude *.hdf5 --exclude *.jsonl --exclude *.log --exclude *.ndjson --exclude *.npy --exclude *.npz --exclude *.orc --exclude *.parquet --exclude *.pickle --exclude *.pkl --exclude *.psv --exclude *.sqlite --exclude *.sqlite3 --exclude *.tfrecord --exclude *.tsv --exclude *.txt .27artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilitiesnone (dependency manifest found, not scanned for vulnerabilities here)—none (dependency manifest found, not scanned for vulnerabilities here): not applicable — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle build (build.gradle/build.gradle.kts) — not scanned yet).0—
D31 · IaC & Container Securitytrivy—trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.0—
D32 · Data Compliance (PII/GDPR)semgrep—semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 6 file(s) — `manager/src/main/java/moe/shizuku/manager/module/ModuleCatalog.kt`, `manager/src/main/java/moe/shizuku/manager/service/StartCircuitBreaker.kt`, `manager/src/main/java/moe/shizuku/manager/ui/component/ContributorAvatars.kt`, `manager/src/main/java/moe/shizuku/manager/ui/component/IntentForm.kt`, `manager/src/main/java/moe/shizuku/manager/ui/screen/CatalogScreen.kt`, … (+1 more) — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.0—
D40 · Network Egress Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.0—
D41 · Kernel & Syscall Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.0—
D42 · Runtime Threat Enforcementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.0—
D43 · Malicious Dependenciesnone (dependency manifest found, not scanned for vulnerabilities here)—none (dependency manifest found, not scanned for vulnerabilities here): not applicable — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle build (build.gradle/build.gradle.kts) — not scanned yet).0—

Run 01a1ea34-8460-7dff-82b8-4ddda8ce8a53 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Downloadable artifacts

Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.

⬇ Findings, MITRE CWE-tagged .sarif⬇ Health changelog .md