Public report of quickwit-oss/quickwit, published 14 November 2026. It has the same score, grades and number of
findings as the full report. The details of security findings (where they are in the code, which known
vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive reportMeasured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.11.4). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey →
Signed and filed in the standard's public register, 14 November 2026, 15:56 UTC · Survey ID cd_cb322600d0a14e159183513533ecb6c8
quickwit-oss/quickwit
Measured 14 November 2026, 15:55 UTC, at code version 96aa58f
Code coverage is not measured: JavaScript/TypeScript suite (CouldNotMeasureTestRunFailed).
CAI scoreAt riskUp 3 since the last survey
The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.
A large codebase: 229,957 lines of product code in 36 projects, tests not counted · Estimated rebuild effort: about 1.9 person-years · Weakest lens: Production Readiness, 53
Findings by how serious they are
64 critical665 serious137 minor
13 dimensions are left out of the score. For each one, we either couldn't measure it in this code, or found no evidence of the safeguard we look for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.
This survey was produced by
Canine Code Analyzer
Producer
Canine Development
Analyzer
Canine Code Analyzer engine 1.0.0
Measured
14 November 2026, 15:55 UTC
A measurement, not a certificate. The Code Assurance Index records a number
together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee
the code. The standard was written by Canine Development, which also builds the Canine Code Analyzer. It is open to any tool that
implements it, and today the Canine Code Analyzer is the only one that does.
A critical security finding is open, such as a library with a known critical vulnerability or a password or key found in the code. The score itself is unchanged, but its band shows At risk until the finding is fixed. See the Security and Compliance lens.
The score is deterministic, which means the same code always gets the same score. We work it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸
73of 73 dimensions measured by tools.
794of 866 findings point to an exact file and line, so you can open each one in the code. The other 72 concern the repository as a whole, such as missing documentation.
73dimensions across 9 lenses, read from 229,957 lines of product code in 36 projects.
quickwit-oss/quickwit is rated At risk because critical security findings are open. Its score is held back in part because it has uses of packages that aren't listed. It scores 61 out of 100, which the At risk rating leaves unchanged. We judged it as a preview release, against a lower bar.
Production Readiness, at 53, is the weakest lens and counts most in the score. The best first step is tidying the declared packages, worth about 6 points. Protecting outgoing calls with timeouts comes next, worth about 4 points. Raising Production Readiness to 62 would lift the score to about 64.
Eighteen settings leave the servers or containers unsafe. Seven pipeline steps put outside input straight into a shell command, so an attacker can run commands in the build pipeline, and seven pipeline steps run downloads nobody checks. Correcting the unsafe settings, passing outside input through environment variables and checking each download against a checksum would close these risks. Updating the vulnerable packages would fix the five packages with a known security hole, and the six pipeline steps that install packages without pinning their versions need the packages they install pinned to exact versions. The four parts of the code nobody has worked on for a long time need someone to learn and document them before anyone changes them.
The product code is 229,957 lines, about €270,000 to rebuild.
A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.
How the score is built: what each lens counts forThe lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
If Production Readiness rose from 53 to 62, the lowest score rated Strong, the score would rise from 61 to about 64.
Code composition: what the lines of code are
Product code 92%Tests 8%
New since the last survey: 157 findings
These 157 critical or serious findings weren't in the previous survey, on 27 October 2026. The first 100 are listed here, and the findings file in the download package lists them all.
God Classes · FunctionTooLong: quickwit_search::root::log_root_resource_stats quickwit/quickwit-search/src/root.rs
Code Duplication · Edited copy of a member (47 corresponding lines) quickwit/quickwit-cli/src/index.rs
Code Duplication · Edited copy of a member (48 corresponding lines) quickwit/quickwit-control-plane/src/model/mod.rs
Code Duplication · Edited copy of a member (50 corresponding lines) quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs
Code Duplication · Edited copy of a member (43 corresponding lines) quickwit/quickwit-common/src/sorted_iter.rs
Code Duplication · Edited copy of a member (35 corresponding lines) quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs
Code Duplication · Edited copy of a member (71 corresponding lines) quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs
Code Duplication · Edited copy of a member (35 corresponding lines) quickwit/quickwit-opentelemetry/src/otlp/logs.rs
Code Duplication · Edited copy of a member (41 corresponding lines) quickwit/quickwit-serve/src/lib.rs
Code Duplication · Edited copy of a member (22 corresponding lines) quickwit/quickwit-opentelemetry/src/otlp/logs.rs
Code Duplication · Edited copy of a member (30 corresponding lines) quickwit/quickwit-opentelemetry/src/otlp/logs.rs
Code Duplication · Edited copy of a member (29 corresponding lines) quickwit/quickwit-control-plane/src/control_plane.rs
Code Duplication · Edited copy of a member (27 corresponding lines) quickwit/quickwit-serve/src/otlp_api/rest_handler.rs
Code Duplication · Edited copy of a member (23 corresponding lines) quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs
Code Duplication · Edited copy of a member (28 corresponding lines) quickwit/quickwit-index-management/src/index.rs
Code Duplication · Edited copy of a member (17 corresponding lines) quickwit/quickwit-serve/src/otlp_api/rest_handler.rs
Code Duplication · Edited copy of a member (21 corresponding lines) quickwit/quickwit-search/src/list_fields/root.rs
Code Duplication · Edited copy of a member (23 corresponding lines) quickwit/quickwit-search/src/leaf.rs
Code Duplication · Edited copy of a member (35 corresponding lines) quickwit/quickwit-doc-mapper/src/doc_mapper/mapping_tree.rs
Code Duplication · Edited copy of a member (21 corresponding lines) quickwit/quickwit-proto/src/types/position.rs
Code Duplication · Edited copies of one member (4 members, 16+ corresponding lines) quickwit/quickwit-cli/src/index.rs
Code Duplication · Edited copy of a member (18 corresponding lines) quickwit/quickwit-doc-mapper/src/doc_mapper/tantivy_val_to_json.rs
Code Duplication · Edited copy of a member (21 corresponding lines) quickwit/quickwit-serve/src/index_api/source_resource.rs
Code Duplication · Edited copy of a member (17 corresponding lines) quickwit/quickwit-metrics/src/counter.rs
Code Duplication · Edited copy of a member (27 corresponding lines) quickwit/quickwit-doc-mapper/src/doc_mapper/date_time_type.rs
Code Duplication · Edited copy of a member (22 corresponding lines) quickwit/quickwit-rest-client/src/rest_client.rs
Code Duplication · Edited copy of a member (18 corresponding lines) quickwit/quickwit-proto/src/search/span_id.rs
Code Duplication · Edited copy of a member (22 corresponding lines) quickwit/quickwit-ingest/src/ingest_v2/broadcast/capacity_score.rs
Code Duplication · Edited copy of a member (15 corresponding lines) quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs
Code Duplication · Edited copy of a member (20 corresponding lines) quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs
Code Duplication · Edited copies of one member (3 members, 19+ corresponding lines) quickwit/quickwit-telemetry-exporters/src/otlp/logs.rs
Code Duplication · Edited copies of one member (3 members, 16+ corresponding lines) quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs
Code Duplication · Edited copy of a member (17 corresponding lines) quickwit/quickwit-common/src/uri.rs
Code Duplication · Edited copies of one member (3 members, 20+ corresponding lines) quickwit/quickwit-metastore/src/metastore/mod.rs
Code Duplication · Edited copy of a member (18 corresponding lines) quickwit/quickwit-search/src/collector.rs
Code Duplication · Edited copy of a member (19 corresponding lines) quickwit/quickwit-metastore/src/metastore/mod.rs
Code Duplication · Edited copy of a member (12 corresponding lines) quickwit/quickwit-proto/src/metastore/mod.rs
Code Duplication · Edited copy of a member (18 corresponding lines) quickwit/quickwit-rest-client/src/rest_client.rs
Code Duplication · Edited copies of one member (4 members, 13+ corresponding lines) quickwit/quickwit-serve/src/index_api/index_resource.rs
Code Duplication · Edited copy of a member (13 corresponding lines) quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs
Code Duplication · Edited copy of a member (16 corresponding lines) quickwit/quickwit-cli/src/index.rs
Code Duplication · Edited copy of a member (18 corresponding lines) quickwit/quickwit-serve/src/otlp_api/rest_handler.rs
Code Duplication · Edited copy of a member (17 corresponding lines) quickwit/quickwit-codegen/src/codegen.rs
Code Duplication · Edited copies of one member (4 members, 17+ corresponding lines) quickwit/quickwit-cli/src/index.rs
Code Duplication · Edited copies of one member (3 members, 13+ corresponding lines) quickwit/quickwit-metrics/src/counter.rs
Code Duplication · Edited copy of a member (16 corresponding lines) quickwit/quickwit-search/src/collector.rs
Code Duplication · Edited copy of a member (16 corresponding lines) quickwit/quickwit-config/src/metastore_config.rs
Code Duplication · Edited copy of a member (16 corresponding lines) quickwit/quickwit-search/src/collector.rs
Code Duplication · Edited copy of a member (14 corresponding lines) quickwit/quickwit-metastore/src/checkpoint.rs
Code Duplication · Edited copy of a member (12 corresponding lines) quickwit/quickwit-doc-mapper/src/query_builder.rs
Code Duplication · Edited copies of one member (3 members, 13+ corresponding lines) quickwit/quickwit-search/src/client.rs
Code Duplication · Edited copy of a member (17 corresponding lines) quickwit/quickwit-doc-mapper/src/doc_mapper/mapping_tree.rs
Code Duplication · Edited copy of a member (17 corresponding lines) quickwit/quickwit-rest-client/src/rest_client.rs
Code Duplication · Edited copy of a member (11 corresponding lines) quickwit/quickwit-common/src/fs.rs
Code Duplication · Edited copy of a member (11 corresponding lines) quickwit/quickwit-search/src/leaf.rs
Code Duplication · Edited copy of a member (15 corresponding lines) quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs
Code Duplication · Edited copy of a member (7 corresponding lines) quickwit/quickwit-doc-mapper/src/doc_mapper/doc_mapper_impl.rs
Code Duplication · Edited copy of a member (10 corresponding lines) quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs
Code Duplication · Edited copy of a member (10 corresponding lines) quickwit/quickwit-common/src/stream_utils.rs
Code Duplication · Edited copy of a member (17 corresponding lines) quickwit/quickwit-config/src/metastore_config.rs
Code Duplication · Edited copies of one member (3 members, 11+ corresponding lines) quickwit/quickwit-storage/src/cache/base_cache.rs
Code Duplication · Edited copy of a member (12 corresponding lines) quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs
Code Duplication · Edited copy of a member (9 corresponding lines) quickwit/quickwit-storage/src/debouncer.rs
Code Duplication · Edited copy of a member (8 corresponding lines) quickwit/quickwit-common/src/tower/metrics.rs
Code Duplication · Edited copies of one member (4 members, 13+ corresponding lines) quickwit/quickwit-ingest/src/mrecordlog_async.rs
Code Duplication · Edited copy of a member (13 corresponding lines) quickwit/quickwit-opentelemetry/src/otlp/traces.rs
Code Duplication · Edited copy of a member (8 corresponding lines) quickwit/quickwit-directories/src/caching_directory.rs
Code Duplication · Edited copy of a member (10 corresponding lines) quickwit/quickwit-search/src/client.rs
Code Duplication · Edited copy of a member (13 corresponding lines) quickwit/quickwit-opentelemetry/src/otlp/logs.rs
Code Duplication · Edited copy of a member (15 corresponding lines) quickwit/quickwit-search/src/leaf.rs
Code Duplication · Edited copies of one member (5 members, 14+ corresponding lines) quickwit/quickwit-cli/src/source.rs
Code Duplication · Edited copy of a member (14 corresponding lines) quickwit/quickwit-config/src/index_template/serialize.rs
Code Duplication · Edited copies of one member (4 members, 9+ corresponding lines) quickwit/quickwit-rest-client/src/rest_client.rs
Code Duplication · Edited copies of one member (3 members, 19+ corresponding lines) quickwit/quickwit-serve/src/elasticsearch_api/bulk.rs
Code Duplication · Edited copy of a member (10 corresponding lines) quickwit/quickwit-serve/src/template_api/rest_handler.rs
Code Duplication · Edited copy of a member (10 corresponding lines) quickwit/quickwit-compaction/src/planner/compaction_state.rs
Code Duplication · Edited copy of a member (8 corresponding lines) quickwit/quickwit-directories/src/debug_proxy_directory.rs
Code Duplication · Edited copy of a member (11 corresponding lines) quickwit/quickwit-storage/src/bundle_storage.rs
Code Duplication · Edited copy of a member (12 corresponding lines) quickwit/quickwit-cli/src/index.rs
Code Duplication · Edited copy of a member (17 corresponding lines) quickwit/quickwit-ingest/src/ingest_v2/mod.rs
Code Duplication · Edited copies of one member (3 members, 13+ corresponding lines) quickwit/quickwit-query/src/elastic_query_dsl/match_bool_prefix.rs
Code Duplication · Edited copy of a member (9 corresponding lines) quickwit/quickwit-query/src/query_ast/regex_extract_eq.rs
Code Duplication · Edited copy of a member (10 corresponding lines) quickwit/quickwit-indexing/src/models/raw_doc_batch.rs
Code Duplication · Edited copy of a member (11 corresponding lines) quickwit/quickwit-indexing/src/source/gcp_pubsub_source.rs
Code Duplication · Edited copy of a member (11 corresponding lines) quickwit/quickwit-metastore/src/metastore/file_backed/mod.rs
Code Duplication · Edited copy of a member (9 corresponding lines) quickwit/quickwit-metastore/src/metastore/postgres/model.rs
Code Duplication · Edited copies of one member (4 members, 11+ corresponding lines) quickwit/quickwit-proto/src/cluster/mod.rs
Code Duplication · Edited copy of a member (15 corresponding lines) quickwit/quickwit-search/src/top_k_collector.rs
Code Duplication · Edited copy of a member (10 corresponding lines) quickwit/quickwit-serve/src/index_api/source_resource.rs
Code Duplication · Edited copy of a member (12 corresponding lines) quickwit/quickwit-indexing/src/actors/doc_processor.rs
Code Duplication · Edited copy of a member (7 corresponding lines) quickwit/quickwit-search/src/top_k_collector.rs
Code Duplication · Edited copy of a member (10 corresponding lines) quickwit/quickwit-serve/src/index_api/split_resource.rs
Code Duplication · Edited copy of a member (13 corresponding lines) quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs
Code Duplication · Edited copy of a member (9 corresponding lines) quickwit/quickwit-doc-mapper/src/doc_mapper/tokenizer_entry.rs
Code Duplication · Edited copy of a member (7 corresponding lines) quickwit/quickwit-directories/src/caching_directory.rs
Code Duplication · Edited copy of a member (9 corresponding lines) quickwit/quickwit-serve/src/index_api/index_resource.rs
Code Duplication · Edited copy of a member (8 corresponding lines) quickwit/quickwit-opentelemetry/src/otlp/logs.rs
Code Duplication · Edited copy of a member (7 corresponding lines) quickwit/quickwit-indexing/src/source/kafka_source.rs
Code Duplication · Edited copy of a member (8 corresponding lines) quickwit/quickwit-metastore/src/metastore/index_metadata/mod.rs
Code Duplication · Edited copy of a member (7 corresponding lines) quickwit/quickwit-indexing/src/models/processed_doc.rs
We compare every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.
Fixed since the last survey: 64 findings
These 64 critical or serious findings were in the previous survey, on 27 October 2026, and are gone from this one.
God Classes · FunctionTooLong: quickwit_ingest::ingest_v2::fetch::fetch_stream_once quickwit/quickwit-ingest/src/ingest_v2/fetch.rs
Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) quickwit/quickwit-serve/src/elasticsearch_api/model/error.rs
Dependency Vulnerabilities · High CVE: [GHSA redacted] .github/workflows/requirements.txt
Dependency Vulnerabilities · Medium advisory (unmaintained): RUSTSEC-2026-0173 REDACTED
Dependency Vulnerabilities · Medium advisory (unsound): RUSTSEC-2026-0221 REDACTED
Dependency Vulnerabilities · Medium advisory (unsound): RUSTSEC-2026-0386 REDACTED
Dependency Vulnerabilities · Medium advisory (unsound): REDACTED REDACTED
Dependency Vulnerabilities · Medium advisory (unsound): REDACTED REDACTED
Dependency Vulnerabilities · Medium advisory (unsound): REDACTED REDACTED
Dependency Vulnerabilities · Medium advisory (unsound): REDACTED REDACTED
Dependency Vulnerabilities · Medium advisory (unsound): REDACTED REDACTED
Dependency Vulnerabilities · Medium advisory (unsound): REDACTED REDACTED
Dependency Vulnerabilities · Medium advisory (unsound): REDACTED REDACTED
Dependency Vulnerabilities · Medium advisory (unsound): REDACTED REDACTED
Dependency Vulnerabilities · Medium advisory (unsound): REDACTED REDACTED
Dependency Vulnerabilities · Medium advisory (unsound): REDACTED REDACTED
Dependency Vulnerabilities · Medium advisory (unsound): REDACTED REDACTED
Dependency Vulnerabilities · Medium advisory (unsound): REDACTED REDACTED
Dependency Vulnerabilities · Medium advisory (unsound): REDACTED REDACTED
Dependency Vulnerabilities · Medium advisory (unsound): REDACTED REDACTED
Dependency Vulnerabilities · Medium advisory (unsound): REDACTED REDACTED
Dependency Vulnerabilities · Medium advisory (unsound): REDACTED REDACTED
Dependency Vulnerabilities · Medium advisory (unsound): REDACTED REDACTED
Dependency Vulnerabilities · Medium advisory (unsound): REDACTED REDACTED
Dependency Vulnerabilities · Medium advisory (unsound): REDACTED REDACTED
Dependency Vulnerabilities · Medium advisory (unsound): REDACTED REDACTED
Dependency Vulnerabilities · Medium vulnerability: REDACTED REDACTED
Dependency Vulnerabilities · Medium vulnerability: REDACTED REDACTED
Dependency Vulnerabilities · Medium vulnerability: RUSTSEC-2026-0310 REDACTED
Dependency Vulnerabilities · Medium vulnerability: RUSTSEC-2026-0338 REDACTED
Dependency Vulnerabilities · Medium vulnerability: RUSTSEC-2026-0346 REDACTED
Dependency Vulnerabilities · Medium vulnerability: RUSTSEC-2026-0346 REDACTED
Dependency Vulnerabilities · Medium vulnerability: REDACTED REDACTED
Dependency Vulnerabilities · Medium vulnerability: REDACTED REDACTED
Dependency Vulnerabilities · Medium vulnerability: REDACTED REDACTED
Dependency Vulnerabilities · Medium vulnerability: REDACTED REDACTED
Dependency Vulnerabilities · Medium vulnerability: REDACTED REDACTED
Dependency Vulnerabilities · Medium vulnerability: RUSTSEC-2026-0410 REDACTED
Test Coverage · No test reaches this file quickwit/quickwit-ui/src/index.tsx
Forms & labels · <Select> field component without a label quickwit/quickwit-ui/src/components/QueryEditor/AggregationEditor.tsx
Forms & labels · <Select> field component without a label quickwit/quickwit-ui/src/components/QueryEditor/AggregationEditor.tsx
Forms & labels · <Select> field component without a label quickwit/quickwit-ui/src/components/QueryEditor/AggregationEditor.tsx
Forms & labels · <Select> field component without a label quickwit/quickwit-ui/src/components/QueryEditor/AggregationEditor.tsx
A11y enforcement · Accessibility enforcement below the top rung
Rebuild cost: about €270,000 · Estimate
Cost to rebuild
€91,000 to €450,000, for 1,509 to 4,788 hours of work, about 1.9 person-years for 1 to 4 engineers
Difficulty of the problem
Standard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor
×0.8 at a score of 61. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
Size
Large: 229,957 lines of product code
What it is not
Not a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.
How the estimate is made: We price the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.
Top priorities
The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.
1
Remove unused dependencies, declare unlisted imports explicitly, and demote type-/test-only packages to devDependencies.
Give every client a whole-request bound: `reqwest::Client::builder().timeout(Duration::from_secs(10))` (never `reqwest::get` or `Client::new()`, which have none), ureq's `timeout_global`, or wrap the call in `tokio::time::timeout`; add retry with back-off (`reqwest-retry`'s `RetryTransientMiddleware`, `backoff`) around dependencies that fail.
Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.
Where the investment is most exposed · Value at risk
This code would cost about €270,000 to build again, about 1.9 person-years of work. Its weakest lens is Production Readiness, at 53 (Adequate). Production Readiness is about whether the product is ready to run in production and to change without breaking. Because the weakest lens counts most in the score, work on Production Readiness also moves the score most.
Based on: the rebuild estimate · the Production Readiness grade · how much each lens counts
What to do: Start with the Production Readiness actions in Top priorities.
If you do one thing first · First action
Remove unused dependencies, declare unlisted imports explicitly, and demote type-/test-only packages to devDependencies. Of all the actions in this report, it raises the score most for the work it takes: about 6 points for medium effort. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
Architecture — module dependency graph
Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways, which only happens where the projects form a dependency cycle. A graph without cycles has none.
Architecture: which parts of the code depend on which
The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.
573 modules, with 1509 dependencies between them. 16 loops run through 63 of the modules, marked above the diagonal.
The table shows the 40 modules with the most connections; 533 more are left out to keep it readable.
Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
quickwit_actors.mailbox uses quickwit_actors.channel_with_priority, so a change to quickwit_actors.channel_with_priority can break quickwit_actors.mailbox, while a change to quickwit_actors.mailbox can't break quickwit_actors.channel_with_priority.
Position
Below the diagonal: quickwit_actors.mailbox uses a module listed above it, which is the healthy direction.
quickwit_actors.mailbox uses quickwit_metrics.gauge, so a change to quickwit_metrics.gauge can break quickwit_actors.mailbox, while a change to quickwit_actors.mailbox can't break quickwit_metrics.gauge.
Position
Below the diagonal: quickwit_actors.mailbox uses a module listed above it, which is the healthy direction.
quickwit_common.tower.metrics uses quickwit_metrics.gauge, so a change to quickwit_metrics.gauge can break quickwit_common.tower.metrics, while a change to quickwit_common.tower.metrics can't break quickwit_metrics.gauge.
Position
Below the diagonal: quickwit_common.tower.metrics uses a module listed above it, which is the healthy direction.
quickwit_config.index_config uses quickwit_common.uri, so a change to quickwit_common.uri can break quickwit_config.index_config, while a change to quickwit_config.index_config can't break quickwit_common.uri.
Position
Below the diagonal: quickwit_config.index_config uses a module listed above it, which is the healthy direction.
quickwit_config.source_config uses quickwit_common.uri, so a change to quickwit_common.uri can break quickwit_config.source_config, while a change to quickwit_config.source_config can't break quickwit_common.uri.
Position
Below the diagonal: quickwit_config.source_config uses a module listed above it, which is the healthy direction.
quickwit_metastore.split_metadata uses quickwit_proto.types.index_uid, so a change to quickwit_proto.types.index_uid can break quickwit_metastore.split_metadata, while a change to quickwit_metastore.split_metadata can't break quickwit_proto.types.index_uid.
Position
Below the diagonal: quickwit_metastore.split_metadata uses a module listed above it, which is the healthy direction.
quickwit_metastore.split_metadata uses quickwit_proto.types.split_id, so a change to quickwit_proto.types.split_id can break quickwit_metastore.split_metadata, while a change to quickwit_metastore.split_metadata can't break quickwit_proto.types.split_id.
Position
Below the diagonal: quickwit_metastore.split_metadata uses a module listed above it, which is the healthy direction.
quickwit_proto.types uses quickwit_proto.types.index_uid, so a change to quickwit_proto.types.index_uid can break quickwit_proto.types, while a change to quickwit_proto.types can't break quickwit_proto.types.index_uid.
Position
Below the diagonal: quickwit_proto.types uses a module listed above it, which is the healthy direction.
quickwit_query.query_ast uses quickwit_query.elastic_query_dsl, so a change to quickwit_query.elastic_query_dsl can break quickwit_query.query_ast, while a change to quickwit_query.query_ast can't break quickwit_query.elastic_query_dsl.
Position
Below the diagonal: quickwit_query.query_ast uses a module listed above it, which is the healthy direction.
quickwit_storage.storage_resolver uses quickwit_common.uri, so a change to quickwit_common.uri can break quickwit_storage.storage_resolver, while a change to quickwit_storage.storage_resolver can't break quickwit_common.uri.
Position
Below the diagonal: quickwit_storage.storage_resolver uses a module listed above it, which is the healthy direction.
quickwit_actors.spawn_builder uses quickwit_actors.channel_with_priority, so a change to quickwit_actors.channel_with_priority can break quickwit_actors.spawn_builder, while a change to quickwit_actors.spawn_builder can't break quickwit_actors.channel_with_priority.
Position
Below the diagonal: quickwit_actors.spawn_builder uses a module listed above it, which is the healthy direction.
quickwit_actors.spawn_builder uses quickwit_actors.mailbox, so a change to quickwit_actors.mailbox can break quickwit_actors.spawn_builder, while a change to quickwit_actors.spawn_builder can't break quickwit_actors.mailbox.
Position
Below the diagonal: quickwit_actors.spawn_builder uses a module listed above it, which is the healthy direction.
17→24 quickwit_actors.spawn_builder uses quickwit_actors.actor_contextpart of a loop✕
Connections
2 pairs of types, where a type in quickwit_actors.spawn_builder uses a type in quickwit_actors.actor_context.
quickwit_actors.spawn_builder uses quickwit_actors.actor_context, so a change to quickwit_actors.actor_context can break quickwit_actors.spawn_builder, while a change to quickwit_actors.spawn_builder can't break quickwit_actors.actor_context.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
17→27 quickwit_actors.spawn_builder uses quickwit_actors.actorpart of a loop✕
Connections
2 pairs of types, where a type in quickwit_actors.spawn_builder uses a type in quickwit_actors.actor.
quickwit_actors.spawn_builder uses quickwit_actors.actor, so a change to quickwit_actors.actor can break quickwit_actors.spawn_builder, while a change to quickwit_actors.spawn_builder can't break quickwit_actors.actor.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
quickwit_cluster.cluster uses quickwit_proto.types, so a change to quickwit_proto.types can break quickwit_cluster.cluster, while a change to quickwit_cluster.cluster can't break quickwit_proto.types.
Position
Below the diagonal: quickwit_cluster.cluster uses a module listed above it, which is the healthy direction.
quickwit_doc_mapper.doc_mapper.doc_mapper_impl uses quickwit_query.query_ast, so a change to quickwit_query.query_ast can break quickwit_doc_mapper.doc_mapper.doc_mapper_impl, while a change to quickwit_doc_mapper.doc_mapper.doc_mapper_impl can't break quickwit_query.query_ast.
Position
Below the diagonal: quickwit_doc_mapper.doc_mapper.doc_mapper_impl uses a module listed above it, which is the healthy direction.
quickwit_indexing.merge_policy uses quickwit_proto.types.split_id, so a change to quickwit_proto.types.split_id can break quickwit_indexing.merge_policy, while a change to quickwit_indexing.merge_policy can't break quickwit_proto.types.split_id.
Position
Below the diagonal: quickwit_indexing.merge_policy uses a module listed above it, which is the healthy direction.
quickwit_indexing.merge_policy uses quickwit_config.index_config, so a change to quickwit_config.index_config can break quickwit_indexing.merge_policy, while a change to quickwit_indexing.merge_policy can't break quickwit_config.index_config.
Position
Below the diagonal: quickwit_indexing.merge_policy uses a module listed above it, which is the healthy direction.
quickwit_indexing.merge_policy uses quickwit_metastore.split_metadata, so a change to quickwit_metastore.split_metadata can break quickwit_indexing.merge_policy, while a change to quickwit_indexing.merge_policy can't break quickwit_metastore.split_metadata.
Position
Below the diagonal: quickwit_indexing.merge_policy uses a module listed above it, which is the healthy direction.
quickwit_metastore.metastore.index_metadata uses quickwit_common.uri, so a change to quickwit_common.uri can break quickwit_metastore.metastore.index_metadata, while a change to quickwit_metastore.metastore.index_metadata can't break quickwit_common.uri.
Position
Below the diagonal: quickwit_metastore.metastore.index_metadata uses a module listed above it, which is the healthy direction.
quickwit_metastore.metastore.index_metadata uses quickwit_metastore.checkpoint, so a change to quickwit_metastore.checkpoint can break quickwit_metastore.metastore.index_metadata, while a change to quickwit_metastore.metastore.index_metadata can't break quickwit_metastore.checkpoint.
Position
Below the diagonal: quickwit_metastore.metastore.index_metadata uses a module listed above it, which is the healthy direction.
quickwit_metastore.metastore.index_metadata uses quickwit_proto.types.index_uid, so a change to quickwit_proto.types.index_uid can break quickwit_metastore.metastore.index_metadata, while a change to quickwit_metastore.metastore.index_metadata can't break quickwit_proto.types.index_uid.
Position
Below the diagonal: quickwit_metastore.metastore.index_metadata uses a module listed above it, which is the healthy direction.
quickwit_metastore.metastore.index_metadata uses quickwit_config.index_config, so a change to quickwit_config.index_config can break quickwit_metastore.metastore.index_metadata, while a change to quickwit_metastore.metastore.index_metadata can't break quickwit_config.index_config.
Position
Below the diagonal: quickwit_metastore.metastore.index_metadata uses a module listed above it, which is the healthy direction.
quickwit_metastore.metastore.index_metadata uses quickwit_config.source_config, so a change to quickwit_config.source_config can break quickwit_metastore.metastore.index_metadata, while a change to quickwit_metastore.metastore.index_metadata can't break quickwit_config.source_config.
Position
Below the diagonal: quickwit_metastore.metastore.index_metadata uses a module listed above it, which is the healthy direction.
quickwit_proto.indexing uses quickwit_common.pubsub, so a change to quickwit_common.pubsub can break quickwit_proto.indexing, while a change to quickwit_proto.indexing can't break quickwit_common.pubsub.
Position
Below the diagonal: quickwit_proto.indexing uses a module listed above it, which is the healthy direction.
quickwit_proto.indexing uses quickwit_proto.types.index_uid, so a change to quickwit_proto.types.index_uid can break quickwit_proto.indexing, while a change to quickwit_proto.indexing can't break quickwit_proto.types.index_uid.
Position
Below the diagonal: quickwit_proto.indexing uses a module listed above it, which is the healthy direction.
quickwit_proto.indexing uses quickwit_common.tower.metrics, so a change to quickwit_common.tower.metrics can break quickwit_proto.indexing, while a change to quickwit_proto.indexing can't break quickwit_common.tower.metrics.
Position
Below the diagonal: quickwit_proto.indexing uses a module listed above it, which is the healthy direction.
quickwit_proto.indexing uses quickwit_proto.types, so a change to quickwit_proto.types can break quickwit_proto.indexing, while a change to quickwit_proto.indexing can't break quickwit_proto.types.
Position
Below the diagonal: quickwit_proto.indexing uses a module listed above it, which is the healthy direction.
quickwit_query.query_ast.visitor uses quickwit_query.query_ast, so a change to quickwit_query.query_ast can break quickwit_query.query_ast.visitor, while a change to quickwit_query.query_ast.visitor can't break quickwit_query.query_ast.
Position
Below the diagonal: quickwit_query.query_ast.visitor uses a module listed above it, which is the healthy direction.
quickwit_actors.actor_context uses quickwit_actors.channel_with_priority, so a change to quickwit_actors.channel_with_priority can break quickwit_actors.actor_context, while a change to quickwit_actors.actor_context can't break quickwit_actors.channel_with_priority.
Position
Below the diagonal: quickwit_actors.actor_context uses a module listed above it, which is the healthy direction.
quickwit_actors.actor_context uses quickwit_actors.mailbox, so a change to quickwit_actors.mailbox can break quickwit_actors.actor_context, while a change to quickwit_actors.actor_context can't break quickwit_actors.mailbox.
Position
Below the diagonal: quickwit_actors.actor_context uses a module listed above it, which is the healthy direction.
quickwit_actors.actor_context uses quickwit_actors.spawn_builder, so a change to quickwit_actors.spawn_builder can break quickwit_actors.actor_context, while a change to quickwit_actors.actor_context can't break quickwit_actors.spawn_builder.
Position
Below the diagonal: quickwit_actors.actor_context uses a module listed above it, which is the healthy direction.
24→27 quickwit_actors.actor_context uses quickwit_actors.actorpart of a loop✕
Connections
2 pairs of types, where a type in quickwit_actors.actor_context uses a type in quickwit_actors.actor.
quickwit_actors.actor_context uses quickwit_actors.actor, so a change to quickwit_actors.actor can break quickwit_actors.actor_context, while a change to quickwit_actors.actor_context can't break quickwit_actors.actor.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
quickwit_config.node_config uses quickwit_common.uri, so a change to quickwit_common.uri can break quickwit_config.node_config, while a change to quickwit_config.node_config can't break quickwit_common.uri.
Position
Below the diagonal: quickwit_config.node_config uses a module listed above it, which is the healthy direction.
quickwit_config.node_config uses quickwit_proto.types, so a change to quickwit_proto.types can break quickwit_config.node_config, while a change to quickwit_config.node_config can't break quickwit_proto.types.
Position
Below the diagonal: quickwit_config.node_config uses a module listed above it, which is the healthy direction.
quickwit_config.node_config uses quickwit_proto.indexing, so a change to quickwit_proto.indexing can break quickwit_config.node_config, while a change to quickwit_config.node_config can't break quickwit_proto.indexing.
Position
Below the diagonal: quickwit_config.node_config uses a module listed above it, which is the healthy direction.
quickwit_indexing.models.indexed_split uses quickwit_metastore.checkpoint, so a change to quickwit_metastore.checkpoint can break quickwit_indexing.models.indexed_split, while a change to quickwit_indexing.models.indexed_split can't break quickwit_metastore.checkpoint.
Position
Below the diagonal: quickwit_indexing.models.indexed_split uses a module listed above it, which is the healthy direction.
quickwit_indexing.models.indexed_split uses quickwit_metrics.gauge, so a change to quickwit_metrics.gauge can break quickwit_indexing.models.indexed_split, while a change to quickwit_indexing.models.indexed_split can't break quickwit_metrics.gauge.
Position
Below the diagonal: quickwit_indexing.models.indexed_split uses a module listed above it, which is the healthy direction.
quickwit_indexing.models.indexed_split uses quickwit_proto.types.index_uid, so a change to quickwit_proto.types.index_uid can break quickwit_indexing.models.indexed_split, while a change to quickwit_indexing.models.indexed_split can't break quickwit_proto.types.index_uid.
Position
Below the diagonal: quickwit_indexing.models.indexed_split uses a module listed above it, which is the healthy direction.
quickwit_indexing.models.indexed_split uses quickwit_proto.types.split_id, so a change to quickwit_proto.types.split_id can break quickwit_indexing.models.indexed_split, while a change to quickwit_indexing.models.indexed_split can't break quickwit_proto.types.split_id.
Position
Below the diagonal: quickwit_indexing.models.indexed_split uses a module listed above it, which is the healthy direction.
quickwit_indexing.models.indexed_split uses quickwit_indexing.merge_policy, so a change to quickwit_indexing.merge_policy can break quickwit_indexing.models.indexed_split, while a change to quickwit_indexing.models.indexed_split can't break quickwit_indexing.merge_policy.
Position
Below the diagonal: quickwit_indexing.models.indexed_split uses a module listed above it, which is the healthy direction.
quickwit_indexing.models.indexed_split uses quickwit_proto.indexing, so a change to quickwit_proto.indexing can break quickwit_indexing.models.indexed_split, while a change to quickwit_indexing.models.indexed_split can't break quickwit_proto.indexing.
Position
Below the diagonal: quickwit_indexing.models.indexed_split uses a module listed above it, which is the healthy direction.
quickwit_actors.actor uses quickwit_actors.channel_with_priority, so a change to quickwit_actors.channel_with_priority can break quickwit_actors.actor, while a change to quickwit_actors.actor can't break quickwit_actors.channel_with_priority.
Position
Below the diagonal: quickwit_actors.actor uses a module listed above it, which is the healthy direction.
quickwit_actors.actor uses quickwit_actors.actor_context, so a change to quickwit_actors.actor_context can break quickwit_actors.actor, while a change to quickwit_actors.actor can't break quickwit_actors.actor_context.
Position
Below the diagonal: quickwit_actors.actor uses a module listed above it, which is the healthy direction.
quickwit_actors.actor_handle uses quickwit_actors.channel_with_priority, so a change to quickwit_actors.channel_with_priority can break quickwit_actors.actor_handle, while a change to quickwit_actors.actor_handle can't break quickwit_actors.channel_with_priority.
Position
Below the diagonal: quickwit_actors.actor_handle uses a module listed above it, which is the healthy direction.
quickwit_actors.actor_handle uses quickwit_actors.mailbox, so a change to quickwit_actors.mailbox can break quickwit_actors.actor_handle, while a change to quickwit_actors.actor_handle can't break quickwit_actors.mailbox.
Position
Below the diagonal: quickwit_actors.actor_handle uses a module listed above it, which is the healthy direction.
quickwit_actors.actor_handle uses quickwit_actors.actor_context, so a change to quickwit_actors.actor_context can break quickwit_actors.actor_handle, while a change to quickwit_actors.actor_handle can't break quickwit_actors.actor_context.
Position
Below the diagonal: quickwit_actors.actor_handle uses a module listed above it, which is the healthy direction.
quickwit_search.service uses quickwit_storage.storage_resolver, so a change to quickwit_storage.storage_resolver can break quickwit_search.service, while a change to quickwit_search.service can't break quickwit_storage.storage_resolver.
Position
Below the diagonal: quickwit_search.service uses a module listed above it, which is the healthy direction.
quickwit_search.service uses quickwit_config.node_config, so a change to quickwit_config.node_config can break quickwit_search.service, while a change to quickwit_search.service can't break quickwit_config.node_config.
Position
Below the diagonal: quickwit_search.service uses a module listed above it, which is the healthy direction.
quickwit_control_plane.control_plane uses quickwit_actors.channel_with_priority, so a change to quickwit_actors.channel_with_priority can break quickwit_control_plane.control_plane, while a change to quickwit_control_plane.control_plane can't break quickwit_actors.channel_with_priority.
Position
Below the diagonal: quickwit_control_plane.control_plane uses a module listed above it, which is the healthy direction.
quickwit_control_plane.control_plane uses quickwit_common.pubsub, so a change to quickwit_common.pubsub can break quickwit_control_plane.control_plane, while a change to quickwit_control_plane.control_plane can't break quickwit_common.pubsub.
Position
Below the diagonal: quickwit_control_plane.control_plane uses a module listed above it, which is the healthy direction.
quickwit_control_plane.control_plane uses quickwit_common.uri, so a change to quickwit_common.uri can break quickwit_control_plane.control_plane, while a change to quickwit_control_plane.control_plane can't break quickwit_common.uri.
Position
Below the diagonal: quickwit_control_plane.control_plane uses a module listed above it, which is the healthy direction.
quickwit_control_plane.control_plane uses quickwit_actors.mailbox, so a change to quickwit_actors.mailbox can break quickwit_control_plane.control_plane, while a change to quickwit_control_plane.control_plane can't break quickwit_actors.mailbox.
Position
Below the diagonal: quickwit_control_plane.control_plane uses a module listed above it, which is the healthy direction.
quickwit_control_plane.control_plane uses quickwit_proto.types, so a change to quickwit_proto.types can break quickwit_control_plane.control_plane, while a change to quickwit_control_plane.control_plane can't break quickwit_proto.types.
Position
Below the diagonal: quickwit_control_plane.control_plane uses a module listed above it, which is the healthy direction.
quickwit_control_plane.control_plane uses quickwit_proto.indexing, so a change to quickwit_proto.indexing can break quickwit_control_plane.control_plane, while a change to quickwit_control_plane.control_plane can't break quickwit_proto.indexing.
Position
Below the diagonal: quickwit_control_plane.control_plane uses a module listed above it, which is the healthy direction.
quickwit_control_plane.control_plane uses quickwit_actors.actor_context, so a change to quickwit_actors.actor_context can break quickwit_control_plane.control_plane, while a change to quickwit_control_plane.control_plane can't break quickwit_actors.actor_context.
Position
Below the diagonal: quickwit_control_plane.control_plane uses a module listed above it, which is the healthy direction.
quickwit_control_plane.control_plane uses quickwit_actors.actor, so a change to quickwit_actors.actor can break quickwit_control_plane.control_plane, while a change to quickwit_control_plane.control_plane can't break quickwit_actors.actor.
Position
Below the diagonal: quickwit_control_plane.control_plane uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.doc_processor uses quickwit_actors.channel_with_priority, so a change to quickwit_actors.channel_with_priority can break quickwit_indexing.actors.doc_processor, while a change to quickwit_indexing.actors.doc_processor can't break quickwit_actors.channel_with_priority.
Position
Below the diagonal: quickwit_indexing.actors.doc_processor uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.doc_processor uses quickwit_actors.mailbox, so a change to quickwit_actors.mailbox can break quickwit_indexing.actors.doc_processor, while a change to quickwit_indexing.actors.doc_processor can't break quickwit_actors.mailbox.
Position
Below the diagonal: quickwit_indexing.actors.doc_processor uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.doc_processor uses quickwit_config.source_config, so a change to quickwit_config.source_config can break quickwit_indexing.actors.doc_processor, while a change to quickwit_indexing.actors.doc_processor can't break quickwit_config.source_config.
Position
Below the diagonal: quickwit_indexing.actors.doc_processor uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.doc_processor uses quickwit_doc_mapper.doc_mapper.doc_mapper_impl, so a change to quickwit_doc_mapper.doc_mapper.doc_mapper_impl can break quickwit_indexing.actors.doc_processor, while a change to quickwit_indexing.actors.doc_processor can't break quickwit_doc_mapper.doc_mapper.doc_mapper_impl.
Position
Below the diagonal: quickwit_indexing.actors.doc_processor uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.doc_processor uses quickwit_actors.actor_context, so a change to quickwit_actors.actor_context can break quickwit_indexing.actors.doc_processor, while a change to quickwit_indexing.actors.doc_processor can't break quickwit_actors.actor_context.
Position
Below the diagonal: quickwit_indexing.actors.doc_processor uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.doc_processor uses quickwit_actors.actor, so a change to quickwit_actors.actor can break quickwit_indexing.actors.doc_processor, while a change to quickwit_indexing.actors.doc_processor can't break quickwit_actors.actor.
Position
Below the diagonal: quickwit_indexing.actors.doc_processor uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexer uses quickwit_actors.channel_with_priority, so a change to quickwit_actors.channel_with_priority can break quickwit_indexing.actors.indexer, while a change to quickwit_indexing.actors.indexer can't break quickwit_actors.channel_with_priority.
Position
Below the diagonal: quickwit_indexing.actors.indexer uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexer uses quickwit_metastore.checkpoint, so a change to quickwit_metastore.checkpoint can break quickwit_indexing.actors.indexer, while a change to quickwit_indexing.actors.indexer can't break quickwit_metastore.checkpoint.
Position
Below the diagonal: quickwit_indexing.actors.indexer uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexer uses quickwit_metrics.gauge, so a change to quickwit_metrics.gauge can break quickwit_indexing.actors.indexer, while a change to quickwit_indexing.actors.indexer can't break quickwit_metrics.gauge.
Position
Below the diagonal: quickwit_indexing.actors.indexer uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexer uses quickwit_actors.mailbox, so a change to quickwit_actors.mailbox can break quickwit_indexing.actors.indexer, while a change to quickwit_indexing.actors.indexer can't break quickwit_actors.mailbox.
Position
Below the diagonal: quickwit_indexing.actors.indexer uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexer uses quickwit_config.index_config, so a change to quickwit_config.index_config can break quickwit_indexing.actors.indexer, while a change to quickwit_indexing.actors.indexer can't break quickwit_config.index_config.
Position
Below the diagonal: quickwit_indexing.actors.indexer uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexer uses quickwit_doc_mapper.doc_mapper.doc_mapper_impl, so a change to quickwit_doc_mapper.doc_mapper.doc_mapper_impl can break quickwit_indexing.actors.indexer, while a change to quickwit_indexing.actors.indexer can't break quickwit_doc_mapper.doc_mapper.doc_mapper_impl.
Position
Below the diagonal: quickwit_indexing.actors.indexer uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexer uses quickwit_proto.indexing, so a change to quickwit_proto.indexing can break quickwit_indexing.actors.indexer, while a change to quickwit_indexing.actors.indexer can't break quickwit_proto.indexing.
Position
Below the diagonal: quickwit_indexing.actors.indexer uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexer uses quickwit_actors.actor_context, so a change to quickwit_actors.actor_context can break quickwit_indexing.actors.indexer, while a change to quickwit_indexing.actors.indexer can't break quickwit_actors.actor_context.
Position
Below the diagonal: quickwit_indexing.actors.indexer uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexer uses quickwit_indexing.models.indexed_split, so a change to quickwit_indexing.models.indexed_split can break quickwit_indexing.actors.indexer, while a change to quickwit_indexing.actors.indexer can't break quickwit_indexing.models.indexed_split.
Position
Below the diagonal: quickwit_indexing.actors.indexer uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexer uses quickwit_actors.actor, so a change to quickwit_actors.actor can break quickwit_indexing.actors.indexer, while a change to quickwit_indexing.actors.indexer can't break quickwit_actors.actor.
Position
Below the diagonal: quickwit_indexing.actors.indexer uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.uploader uses quickwit_actors.channel_with_priority, so a change to quickwit_actors.channel_with_priority can break quickwit_indexing.actors.uploader, while a change to quickwit_indexing.actors.uploader can't break quickwit_actors.channel_with_priority.
Position
Below the diagonal: quickwit_indexing.actors.uploader uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.uploader uses quickwit_common.pubsub, so a change to quickwit_common.pubsub can break quickwit_indexing.actors.uploader, while a change to quickwit_indexing.actors.uploader can't break quickwit_common.pubsub.
Position
Below the diagonal: quickwit_indexing.actors.uploader uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.uploader uses quickwit_metastore.checkpoint, so a change to quickwit_metastore.checkpoint can break quickwit_indexing.actors.uploader, while a change to quickwit_indexing.actors.uploader can't break quickwit_metastore.checkpoint.
Position
Below the diagonal: quickwit_indexing.actors.uploader uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.uploader uses quickwit_proto.types.index_uid, so a change to quickwit_proto.types.index_uid can break quickwit_indexing.actors.uploader, while a change to quickwit_indexing.actors.uploader can't break quickwit_proto.types.index_uid.
Position
Below the diagonal: quickwit_indexing.actors.uploader uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.uploader uses quickwit_actors.mailbox, so a change to quickwit_actors.mailbox can break quickwit_indexing.actors.uploader, while a change to quickwit_indexing.actors.uploader can't break quickwit_actors.mailbox.
Position
Below the diagonal: quickwit_indexing.actors.uploader uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.uploader uses quickwit_config.index_config, so a change to quickwit_config.index_config can break quickwit_indexing.actors.uploader, while a change to quickwit_indexing.actors.uploader can't break quickwit_config.index_config.
Position
Below the diagonal: quickwit_indexing.actors.uploader uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.uploader uses quickwit_metastore.split_metadata, so a change to quickwit_metastore.split_metadata can break quickwit_indexing.actors.uploader, while a change to quickwit_indexing.actors.uploader can't break quickwit_metastore.split_metadata.
Position
Below the diagonal: quickwit_indexing.actors.uploader uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.uploader uses quickwit_indexing.merge_policy, so a change to quickwit_indexing.merge_policy can break quickwit_indexing.actors.uploader, while a change to quickwit_indexing.actors.uploader can't break quickwit_indexing.merge_policy.
Position
Below the diagonal: quickwit_indexing.actors.uploader uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.uploader uses quickwit_actors.actor_context, so a change to quickwit_actors.actor_context can break quickwit_indexing.actors.uploader, while a change to quickwit_indexing.actors.uploader can't break quickwit_actors.actor_context.
Position
Below the diagonal: quickwit_indexing.actors.uploader uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.uploader uses quickwit_indexing.models.indexed_split, so a change to quickwit_indexing.models.indexed_split can break quickwit_indexing.actors.uploader, while a change to quickwit_indexing.actors.uploader can't break quickwit_indexing.models.indexed_split.
Position
Below the diagonal: quickwit_indexing.actors.uploader uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.uploader uses quickwit_actors.actor, so a change to quickwit_actors.actor can break quickwit_indexing.actors.uploader, while a change to quickwit_indexing.actors.uploader can't break quickwit_actors.actor.
Position
Below the diagonal: quickwit_indexing.actors.uploader uses a module listed above it, which is the healthy direction.
quickwit_indexing.source uses quickwit_common.pubsub, so a change to quickwit_common.pubsub can break quickwit_indexing.source, while a change to quickwit_indexing.source can't break quickwit_common.pubsub.
Position
Below the diagonal: quickwit_indexing.source uses a module listed above it, which is the healthy direction.
quickwit_indexing.source uses quickwit_metastore.checkpoint, so a change to quickwit_metastore.checkpoint can break quickwit_indexing.source, while a change to quickwit_indexing.source can't break quickwit_metastore.checkpoint.
Position
Below the diagonal: quickwit_indexing.source uses a module listed above it, which is the healthy direction.
quickwit_indexing.source uses quickwit_metrics.gauge, so a change to quickwit_metrics.gauge can break quickwit_indexing.source, while a change to quickwit_indexing.source can't break quickwit_metrics.gauge.
Position
Below the diagonal: quickwit_indexing.source uses a module listed above it, which is the healthy direction.
quickwit_indexing.source uses quickwit_proto.types.index_uid, so a change to quickwit_proto.types.index_uid can break quickwit_indexing.source, while a change to quickwit_indexing.source can't break quickwit_proto.types.index_uid.
Position
Below the diagonal: quickwit_indexing.source uses a module listed above it, which is the healthy direction.
quickwit_indexing.source uses quickwit_actors.mailbox, so a change to quickwit_actors.mailbox can break quickwit_indexing.source, while a change to quickwit_indexing.source can't break quickwit_actors.mailbox.
Position
Below the diagonal: quickwit_indexing.source uses a module listed above it, which is the healthy direction.
quickwit_indexing.source uses quickwit_config.index_config, so a change to quickwit_config.index_config can break quickwit_indexing.source, while a change to quickwit_indexing.source can't break quickwit_config.index_config.
Position
Below the diagonal: quickwit_indexing.source uses a module listed above it, which is the healthy direction.
quickwit_indexing.source uses quickwit_config.source_config, so a change to quickwit_config.source_config can break quickwit_indexing.source, while a change to quickwit_indexing.source can't break quickwit_config.source_config.
Position
Below the diagonal: quickwit_indexing.source uses a module listed above it, which is the healthy direction.
quickwit_indexing.source uses quickwit_proto.types, so a change to quickwit_proto.types can break quickwit_indexing.source, while a change to quickwit_indexing.source can't break quickwit_proto.types.
Position
Below the diagonal: quickwit_indexing.source uses a module listed above it, which is the healthy direction.
quickwit_indexing.source uses quickwit_storage.storage_resolver, so a change to quickwit_storage.storage_resolver can break quickwit_indexing.source, while a change to quickwit_indexing.source can't break quickwit_storage.storage_resolver.
Position
Below the diagonal: quickwit_indexing.source uses a module listed above it, which is the healthy direction.
quickwit_indexing.source uses quickwit_proto.indexing, so a change to quickwit_proto.indexing can break quickwit_indexing.source, while a change to quickwit_indexing.source can't break quickwit_proto.indexing.
Position
Below the diagonal: quickwit_indexing.source uses a module listed above it, which is the healthy direction.
quickwit_indexing.source uses quickwit_actors.actor, so a change to quickwit_actors.actor can break quickwit_indexing.source, while a change to quickwit_indexing.source can't break quickwit_actors.actor.
Position
Below the diagonal: quickwit_indexing.source uses a module listed above it, which is the healthy direction.
quickwit_search.leaf uses quickwit_common.uri, so a change to quickwit_common.uri can break quickwit_search.leaf, while a change to quickwit_search.leaf can't break quickwit_common.uri.
Position
Below the diagonal: quickwit_search.leaf uses a module listed above it, which is the healthy direction.
quickwit_search.leaf uses quickwit_storage.storage_resolver, so a change to quickwit_storage.storage_resolver can break quickwit_search.leaf, while a change to quickwit_search.leaf can't break quickwit_storage.storage_resolver.
Position
Below the diagonal: quickwit_search.leaf uses a module listed above it, which is the healthy direction.
quickwit_search.leaf uses quickwit_doc_mapper.doc_mapper.doc_mapper_impl, so a change to quickwit_doc_mapper.doc_mapper.doc_mapper_impl can break quickwit_search.leaf, while a change to quickwit_search.leaf can't break quickwit_doc_mapper.doc_mapper.doc_mapper_impl.
Position
Below the diagonal: quickwit_search.leaf uses a module listed above it, which is the healthy direction.
quickwit_search.leaf uses quickwit_query.query_ast.visitor, so a change to quickwit_query.query_ast.visitor can break quickwit_search.leaf, while a change to quickwit_search.leaf can't break quickwit_query.query_ast.visitor.
Position
Below the diagonal: quickwit_search.leaf uses a module listed above it, which is the healthy direction.
quickwit_search.leaf uses quickwit_search.service, so a change to quickwit_search.service can break quickwit_search.leaf, while a change to quickwit_search.leaf can't break quickwit_search.service.
Position
Below the diagonal: quickwit_search.leaf uses a module listed above it, which is the healthy direction.
quickwit_search.root uses quickwit_common.uri, so a change to quickwit_common.uri can break quickwit_search.root, while a change to quickwit_search.root can't break quickwit_common.uri.
Position
Below the diagonal: quickwit_search.root uses a module listed above it, which is the healthy direction.
quickwit_search.root uses quickwit_proto.types.index_uid, so a change to quickwit_proto.types.index_uid can break quickwit_search.root, while a change to quickwit_search.root can't break quickwit_proto.types.index_uid.
Position
Below the diagonal: quickwit_search.root uses a module listed above it, which is the healthy direction.
quickwit_search.root uses quickwit_metastore.split_metadata, so a change to quickwit_metastore.split_metadata can break quickwit_search.root, while a change to quickwit_search.root can't break quickwit_metastore.split_metadata.
Position
Below the diagonal: quickwit_search.root uses a module listed above it, which is the healthy direction.
quickwit_search.root uses quickwit_query.query_ast, so a change to quickwit_query.query_ast can break quickwit_search.root, while a change to quickwit_search.root can't break quickwit_query.query_ast.
Position
Below the diagonal: quickwit_search.root uses a module listed above it, which is the healthy direction.
quickwit_search.root uses quickwit_metastore.metastore.index_metadata, so a change to quickwit_metastore.metastore.index_metadata can break quickwit_search.root, while a change to quickwit_search.root can't break quickwit_metastore.metastore.index_metadata.
Position
Below the diagonal: quickwit_search.root uses a module listed above it, which is the healthy direction.
quickwit_search.root uses quickwit_query.query_ast.visitor, so a change to quickwit_query.query_ast.visitor can break quickwit_search.root, while a change to quickwit_search.root can't break quickwit_query.query_ast.visitor.
Position
Below the diagonal: quickwit_search.root uses a module listed above it, which is the healthy direction.
quickwit_search.root uses quickwit_search.service, so a change to quickwit_search.service can break quickwit_search.root, while a change to quickwit_search.root can't break quickwit_search.service.
Position
Below the diagonal: quickwit_search.root uses a module listed above it, which is the healthy direction.
quickwit_serve uses quickwit_actors.channel_with_priority, so a change to quickwit_actors.channel_with_priority can break quickwit_serve, while a change to quickwit_serve can't break quickwit_actors.channel_with_priority.
Position
Below the diagonal: quickwit_serve uses a module listed above it, which is the healthy direction.
quickwit_serve uses quickwit_common.pubsub, so a change to quickwit_common.pubsub can break quickwit_serve, while a change to quickwit_serve can't break quickwit_common.pubsub.
Position
Below the diagonal: quickwit_serve uses a module listed above it, which is the healthy direction.
quickwit_serve uses quickwit_common.uri, so a change to quickwit_common.uri can break quickwit_serve, while a change to quickwit_serve can't break quickwit_common.uri.
Position
Below the diagonal: quickwit_serve uses a module listed above it, which is the healthy direction.
quickwit_serve uses quickwit_actors.mailbox, so a change to quickwit_actors.mailbox can break quickwit_serve, while a change to quickwit_serve can't break quickwit_actors.mailbox.
Position
Below the diagonal: quickwit_serve uses a module listed above it, which is the healthy direction.
quickwit_serve uses quickwit_proto.types, so a change to quickwit_proto.types can break quickwit_serve, while a change to quickwit_serve can't break quickwit_proto.types.
Position
Below the diagonal: quickwit_serve uses a module listed above it, which is the healthy direction.
quickwit_serve uses quickwit_storage.storage_resolver, so a change to quickwit_storage.storage_resolver can break quickwit_serve, while a change to quickwit_serve can't break quickwit_storage.storage_resolver.
Position
Below the diagonal: quickwit_serve uses a module listed above it, which is the healthy direction.
quickwit_serve uses quickwit_actors.spawn_builder, so a change to quickwit_actors.spawn_builder can break quickwit_serve, while a change to quickwit_serve can't break quickwit_actors.spawn_builder.
Position
Below the diagonal: quickwit_serve uses a module listed above it, which is the healthy direction.
quickwit_serve uses quickwit_cluster.cluster, so a change to quickwit_cluster.cluster can break quickwit_serve, while a change to quickwit_serve can't break quickwit_cluster.cluster.
Position
Below the diagonal: quickwit_serve uses a module listed above it, which is the healthy direction.
quickwit_serve uses quickwit_config.node_config, so a change to quickwit_config.node_config can break quickwit_serve, while a change to quickwit_serve can't break quickwit_config.node_config.
Position
Below the diagonal: quickwit_serve uses a module listed above it, which is the healthy direction.
quickwit_serve uses quickwit_search.service, so a change to quickwit_search.service can break quickwit_serve, while a change to quickwit_serve can't break quickwit_search.service.
Position
Below the diagonal: quickwit_serve uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexing_pipeline uses quickwit_common.pubsub, so a change to quickwit_common.pubsub can break quickwit_indexing.actors.indexing_pipeline, while a change to quickwit_indexing.actors.indexing_pipeline can't break quickwit_common.pubsub.
Position
Below the diagonal: quickwit_indexing.actors.indexing_pipeline uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexing_pipeline uses quickwit_metrics.gauge, so a change to quickwit_metrics.gauge can break quickwit_indexing.actors.indexing_pipeline, while a change to quickwit_indexing.actors.indexing_pipeline can't break quickwit_metrics.gauge.
Position
Below the diagonal: quickwit_indexing.actors.indexing_pipeline uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexing_pipeline uses quickwit_actors.mailbox, so a change to quickwit_actors.mailbox can break quickwit_indexing.actors.indexing_pipeline, while a change to quickwit_indexing.actors.indexing_pipeline can't break quickwit_actors.mailbox.
Position
Below the diagonal: quickwit_indexing.actors.indexing_pipeline uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexing_pipeline uses quickwit_config.index_config, so a change to quickwit_config.index_config can break quickwit_indexing.actors.indexing_pipeline, while a change to quickwit_indexing.actors.indexing_pipeline can't break quickwit_config.index_config.
Position
Below the diagonal: quickwit_indexing.actors.indexing_pipeline uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexing_pipeline uses quickwit_config.source_config, so a change to quickwit_config.source_config can break quickwit_indexing.actors.indexing_pipeline, while a change to quickwit_indexing.actors.indexing_pipeline can't break quickwit_config.source_config.
Position
Below the diagonal: quickwit_indexing.actors.indexing_pipeline uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexing_pipeline uses quickwit_storage.storage_resolver, so a change to quickwit_storage.storage_resolver can break quickwit_indexing.actors.indexing_pipeline, while a change to quickwit_indexing.actors.indexing_pipeline can't break quickwit_storage.storage_resolver.
Position
Below the diagonal: quickwit_indexing.actors.indexing_pipeline uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexing_pipeline uses quickwit_doc_mapper.doc_mapper.doc_mapper_impl, so a change to quickwit_doc_mapper.doc_mapper.doc_mapper_impl can break quickwit_indexing.actors.indexing_pipeline, while a change to quickwit_indexing.actors.indexing_pipeline can't break quickwit_doc_mapper.doc_mapper.doc_mapper_impl.
Position
Below the diagonal: quickwit_indexing.actors.indexing_pipeline uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexing_pipeline uses quickwit_proto.indexing, so a change to quickwit_proto.indexing can break quickwit_indexing.actors.indexing_pipeline, while a change to quickwit_indexing.actors.indexing_pipeline can't break quickwit_proto.indexing.
Position
Below the diagonal: quickwit_indexing.actors.indexing_pipeline uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexing_pipeline uses quickwit_actors.actor_context, so a change to quickwit_actors.actor_context can break quickwit_indexing.actors.indexing_pipeline, while a change to quickwit_indexing.actors.indexing_pipeline can't break quickwit_actors.actor_context.
Position
Below the diagonal: quickwit_indexing.actors.indexing_pipeline uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexing_pipeline uses quickwit_actors.actor, so a change to quickwit_actors.actor can break quickwit_indexing.actors.indexing_pipeline, while a change to quickwit_indexing.actors.indexing_pipeline can't break quickwit_actors.actor.
Position
Below the diagonal: quickwit_indexing.actors.indexing_pipeline uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexing_pipeline uses quickwit_actors.actor_handle, so a change to quickwit_actors.actor_handle can break quickwit_indexing.actors.indexing_pipeline, while a change to quickwit_indexing.actors.indexing_pipeline can't break quickwit_actors.actor_handle.
Position
Below the diagonal: quickwit_indexing.actors.indexing_pipeline uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexing_pipeline uses quickwit_indexing.source, so a change to quickwit_indexing.source can break quickwit_indexing.actors.indexing_pipeline, while a change to quickwit_indexing.actors.indexing_pipeline can't break quickwit_indexing.source.
Position
Below the diagonal: quickwit_indexing.actors.indexing_pipeline uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.merge_pipeline uses quickwit_common.pubsub, so a change to quickwit_common.pubsub can break quickwit_indexing.actors.merge_pipeline, while a change to quickwit_indexing.actors.merge_pipeline can't break quickwit_common.pubsub.
Position
Below the diagonal: quickwit_indexing.actors.merge_pipeline uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.merge_pipeline uses quickwit_actors.mailbox, so a change to quickwit_actors.mailbox can break quickwit_indexing.actors.merge_pipeline, while a change to quickwit_indexing.actors.merge_pipeline can't break quickwit_actors.mailbox.
Position
Below the diagonal: quickwit_indexing.actors.merge_pipeline uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.merge_pipeline uses quickwit_config.index_config, so a change to quickwit_config.index_config can break quickwit_indexing.actors.merge_pipeline, while a change to quickwit_indexing.actors.merge_pipeline can't break quickwit_config.index_config.
Position
Below the diagonal: quickwit_indexing.actors.merge_pipeline uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.merge_pipeline uses quickwit_metastore.split_metadata, so a change to quickwit_metastore.split_metadata can break quickwit_indexing.actors.merge_pipeline, while a change to quickwit_indexing.actors.merge_pipeline can't break quickwit_metastore.split_metadata.
Position
Below the diagonal: quickwit_indexing.actors.merge_pipeline uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.merge_pipeline uses quickwit_actors.spawn_builder, so a change to quickwit_actors.spawn_builder can break quickwit_indexing.actors.merge_pipeline, while a change to quickwit_indexing.actors.merge_pipeline can't break quickwit_actors.spawn_builder.
Position
Below the diagonal: quickwit_indexing.actors.merge_pipeline uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.merge_pipeline uses quickwit_doc_mapper.doc_mapper.doc_mapper_impl, so a change to quickwit_doc_mapper.doc_mapper.doc_mapper_impl can break quickwit_indexing.actors.merge_pipeline, while a change to quickwit_indexing.actors.merge_pipeline can't break quickwit_doc_mapper.doc_mapper.doc_mapper_impl.
Position
Below the diagonal: quickwit_indexing.actors.merge_pipeline uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.merge_pipeline uses quickwit_proto.indexing, so a change to quickwit_proto.indexing can break quickwit_indexing.actors.merge_pipeline, while a change to quickwit_indexing.actors.merge_pipeline can't break quickwit_proto.indexing.
Position
Below the diagonal: quickwit_indexing.actors.merge_pipeline uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.merge_pipeline uses quickwit_actors.actor_context, so a change to quickwit_actors.actor_context can break quickwit_indexing.actors.merge_pipeline, while a change to quickwit_indexing.actors.merge_pipeline can't break quickwit_actors.actor_context.
Position
Below the diagonal: quickwit_indexing.actors.merge_pipeline uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.merge_pipeline uses quickwit_actors.actor, so a change to quickwit_actors.actor can break quickwit_indexing.actors.merge_pipeline, while a change to quickwit_indexing.actors.merge_pipeline can't break quickwit_actors.actor.
Position
Below the diagonal: quickwit_indexing.actors.merge_pipeline uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.merge_pipeline uses quickwit_actors.actor_handle, so a change to quickwit_actors.actor_handle can break quickwit_indexing.actors.merge_pipeline, while a change to quickwit_indexing.actors.merge_pipeline can't break quickwit_actors.actor_handle.
Position
Below the diagonal: quickwit_indexing.actors.merge_pipeline uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.merge_pipeline uses quickwit_indexing.actors.indexing_pipeline, so a change to quickwit_indexing.actors.indexing_pipeline can break quickwit_indexing.actors.merge_pipeline, while a change to quickwit_indexing.actors.merge_pipeline can't break quickwit_indexing.actors.indexing_pipeline.
Position
Below the diagonal: quickwit_indexing.actors.merge_pipeline uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexing_service uses quickwit_common.pubsub, so a change to quickwit_common.pubsub can break quickwit_indexing.actors.indexing_service, while a change to quickwit_indexing.actors.indexing_service can't break quickwit_common.pubsub.
Position
Below the diagonal: quickwit_indexing.actors.indexing_service uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexing_service uses quickwit_actors.mailbox, so a change to quickwit_actors.mailbox can break quickwit_indexing.actors.indexing_service, while a change to quickwit_indexing.actors.indexing_service can't break quickwit_actors.mailbox.
Position
Below the diagonal: quickwit_indexing.actors.indexing_service uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexing_service uses quickwit_config.index_config, so a change to quickwit_config.index_config can break quickwit_indexing.actors.indexing_service, while a change to quickwit_indexing.actors.indexing_service can't break quickwit_config.index_config.
Position
Below the diagonal: quickwit_indexing.actors.indexing_service uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexing_service uses quickwit_config.source_config, so a change to quickwit_config.source_config can break quickwit_indexing.actors.indexing_service, while a change to quickwit_indexing.actors.indexing_service can't break quickwit_config.source_config.
Position
Below the diagonal: quickwit_indexing.actors.indexing_service uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexing_service uses quickwit_metastore.split_metadata, so a change to quickwit_metastore.split_metadata can break quickwit_indexing.actors.indexing_service, while a change to quickwit_indexing.actors.indexing_service can't break quickwit_metastore.split_metadata.
Position
Below the diagonal: quickwit_indexing.actors.indexing_service uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexing_service uses quickwit_proto.types, so a change to quickwit_proto.types can break quickwit_indexing.actors.indexing_service, while a change to quickwit_indexing.actors.indexing_service can't break quickwit_proto.types.
Position
Below the diagonal: quickwit_indexing.actors.indexing_service uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexing_service uses quickwit_storage.storage_resolver, so a change to quickwit_storage.storage_resolver can break quickwit_indexing.actors.indexing_service, while a change to quickwit_indexing.actors.indexing_service can't break quickwit_storage.storage_resolver.
Position
Below the diagonal: quickwit_indexing.actors.indexing_service uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexing_service uses quickwit_cluster.cluster, so a change to quickwit_cluster.cluster can break quickwit_indexing.actors.indexing_service, while a change to quickwit_indexing.actors.indexing_service can't break quickwit_cluster.cluster.
Position
Below the diagonal: quickwit_indexing.actors.indexing_service uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexing_service uses quickwit_proto.indexing, so a change to quickwit_proto.indexing can break quickwit_indexing.actors.indexing_service, while a change to quickwit_indexing.actors.indexing_service can't break quickwit_proto.indexing.
Position
Below the diagonal: quickwit_indexing.actors.indexing_service uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexing_service uses quickwit_actors.actor_context, so a change to quickwit_actors.actor_context can break quickwit_indexing.actors.indexing_service, while a change to quickwit_indexing.actors.indexing_service can't break quickwit_actors.actor_context.
Position
Below the diagonal: quickwit_indexing.actors.indexing_service uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexing_service uses quickwit_config.node_config, so a change to quickwit_config.node_config can break quickwit_indexing.actors.indexing_service, while a change to quickwit_indexing.actors.indexing_service can't break quickwit_config.node_config.
Position
Below the diagonal: quickwit_indexing.actors.indexing_service uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexing_service uses quickwit_actors.actor, so a change to quickwit_actors.actor can break quickwit_indexing.actors.indexing_service, while a change to quickwit_indexing.actors.indexing_service can't break quickwit_actors.actor.
Position
Below the diagonal: quickwit_indexing.actors.indexing_service uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexing_service uses quickwit_actors.actor_handle, so a change to quickwit_actors.actor_handle can break quickwit_indexing.actors.indexing_service, while a change to quickwit_indexing.actors.indexing_service can't break quickwit_actors.actor_handle.
Position
Below the diagonal: quickwit_indexing.actors.indexing_service uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexing_service uses quickwit_indexing.actors.indexing_pipeline, so a change to quickwit_indexing.actors.indexing_pipeline can break quickwit_indexing.actors.indexing_service, while a change to quickwit_indexing.actors.indexing_service can't break quickwit_indexing.actors.indexing_pipeline.
Position
Below the diagonal: quickwit_indexing.actors.indexing_service uses a module listed above it, which is the healthy direction.
quickwit_indexing.actors.indexing_service uses quickwit_indexing.actors.merge_pipeline, so a change to quickwit_indexing.actors.merge_pipeline can break quickwit_indexing.actors.indexing_service, while a change to quickwit_indexing.actors.indexing_service can't break quickwit_indexing.actors.merge_pipeline.
Position
Below the diagonal: quickwit_indexing.actors.indexing_service uses a module listed above it, which is the healthy direction.
Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).
OWASP category
Findings
Severity
A03:2025 — Software Supply Chain Failures
50
High / Critical
A05:2025 — Injection
36
High / Critical
A02:2025 — Security Misconfiguration
32
High / Critical
Roadmap
Top priorities: Remove unused dependencies, declare unlisted imports explicitly, and demote type-/test-only packages to devDependencies; Give every client a whole-request bound: `reqwest::Client::builder().timeout(Duration::from_secs(10))` (never `reqwest::get` or `Client::new()`, which have none), ureq's `timeout_global`, or wrap the call in `tokio::time::timeout`; add retry with back-off (`reqwest-retry`'s `RetryTransientMiddleware`, `backoff`) around dependencies that fail; Review each MD5/SHA1 use by what it protects: replace it with SHA-256+ (or a KDF for passwords) where the digest is security-relevant, and switch it to a non-cryptographic hash (xxhash, murmurhash) where it only derives an identifier such as a cache key. This repository constructs a collision-broken hash (MD5/SHA1) at 4 sites, not one: `quickwit/quickwit-lambda-client/src/deploy.rs:77` (`md5::compute`), `quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:259` (`md5::compute`), `quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:562` (`md5::compute`), `quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:338` (`md5::Context::new`). Each is a separate decision — fixing only the line this row cites leaves the others in place.
Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.
Do this
Helps
Effort
Dimension
Remove unused dependencies, declare unlisted imports explicitly, and demote type-/test-only packages to devDependencies.
Give every client a whole-request bound: `reqwest::Client::builder().timeout(Duration::from_secs(10))` (never `reqwest::get` or `Client::new()`, which have none), ureq's `timeout_global`, or wrap the call in `tokio::time::timeout`; add retry with back-off (`reqwest-retry`'s `RetryTransientMiddleware`, `backoff`) around dependencies that fail.
Review each MD5/SHA1 use by what it protects: replace it with SHA-256+ (or a KDF for passwords) where the digest is security-relevant, and switch it to a non-cryptographic hash (xxhash, murmurhash) where it only derives an identifier such as a cache key. This repository constructs a collision-broken hash (MD5/SHA1) at 4 sites, not one: `quickwit/quickwit-lambda-client/src/deploy.rs:77` (`md5::compute`), `quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:259` (`md5::compute`), `quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:562` (`md5::compute`), `quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:338` (`md5::Context::new`). Each is a separate decision — fixing only the line this row cites leaves the others in place.
Name the access rules — roles and permissions declared once (an enum Role/Permission, actix-web-grants #[protect(…)], axum-login's permission_required!, a casbin or oso policy) and consulted where access is checked, so the rule set is reviewable and testable on its own.
Every finding carries one of four grades. Three say how serious it is. The fourth says this
survey could not settle it — and it is a grade, not a gap.
Critical — 64
A definite problem that already costs you something and drags the score down: a
missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here
tends to cause failures elsewhere.
Serious — 665
Likely wrong, but not failing yet. It degrades
the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to
carry for two years either.
Minor — 137
Recorded, with no effect on how the codebase functions.
Present so the survey is complete, not because it needs doing.
Could not be resolved — 13
Something this survey could not settle
from the outside, and which could be critical or serious. Either a control was required and no
positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves
nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean
result. These are excluded from the score rather than awarded a pass, so the number on the cover neither
rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each
one is named under Limitations.
Methodology & how to trust this report
This survey is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. All 73 evaluated dimensions are computed by tools and static analysis; no language model sets or judges any of them. Overall confidence is 0.9, the weighted average across measured dimensions.
Every figure here is one of two kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10.
What we checked — 73 dimensions across the health lenses
Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.
How to trust any code-health report — three questions
Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 794 of 866 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it: Roslyn, git or a scanner, not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.
This report answers yes to all three. That's the bar to hold any assessment to.
Tools & methods
The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.
Method
Backs
Version
Evaluator
Roslyn static analysis
Complexity, cohesion, coupling, dead code, API surface, layering
What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.
D10 Test Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The 10 test(s) behind this row are the ones the JavaScript/TypeScript census could read, and this repository also carries at least 56 test source file(s) (.rs) that it cannot: it reads JavaScript/TypeScript test declarations off disk, so a JUnit/pytest-style suite is invisible to it. Skipped tests, zero-assertion tests and the other quality signals on this row are UNMEASURED in that suite — their absence from the counts above is a gap in this analyzer's language coverage, not a finding that those tests are sound.
D11 Test Reliability — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test reliability NOT SCORED: this repository's production source includes .rs, and the rust executor ran against the .rs half and could not be re-run to completion inside our analyzer environment — so reliability was not measured for the repository as a whole. The JavaScript/TypeScript (jest via `yarn install --frozen-lockfile --ignore-scripts` in quickwit/quickwit-ui/ (7 tests)): measured (0 flaky) suite(s) did re-run, and came back with 0 flaky across 1 measured tier(s) — but that is a figure for one half of the product, and we do not publish a partial one as if it were complete. This is OUR limitation, not a defect in the repo — test reliability is excluded from the score rather than counted. The remedy is our analyzer environment, not a runner nobody has built.
D19 Documentation Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Each ecosystem's manifests (what makes a folder runnable or a published package) need their own proof before D19 judges its units. Until then those folders' READMEs are judged only as documents (boilerplate, structure), never counted as complete.
D19 Documentation Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This kind did not reach the 95 % precision gate in three adjudicated runs (docs/plans/deterministic-engine/adjudication/D19-sample3-v3.md), so by the pre-registered fallback it publishes no row until a re-measurement shows it does. The candidates are counted here, not reported as findings, and the score does not include them.
D21 Naming Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
D22 Internal API Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D22's deterministic call-shape rules are gated on C# first (docs/plans/deterministic-engine.md, P5): each other language is switched on only after its own concept suite and A/B gate pass. This says nothing about whether that surface is consistent.
D24 Comment Value — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Each source language's comment syntax, and the code a comment annotates in it, needs its own proof before D24 judges it. Until then those comments are left unread, not counted as clean.
D27 Navigability — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Navigability is taken over call sites whose callee resolved. For C# that population includes calls into referenced assemblies; for this language only calls declared inside the repository count, so the abstention threshold reads the repository's use of its standard library as a resolution failure. That is a limit of this analyzer, not a build problem in this repository.
D32 Data Compliance (PII/GDPR) — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `quickwit/quickwit-ui/vite.config.ts` produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
D44 Platform End-of-Life — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This dimension reads a project's own statement about the platform it runs on: a TargetFramework in a .NET project file, a .nvmrc or .python-version, a capped requires-python, a Rust toolchain file or Cargo.toml rust-version, a .go-version, .java-version, .ruby-version, .tool-versions or .sdkmanrc, a go.mod go directive, a Maven or Gradle Java level or toolchain, a Gemfile's ruby directive, a mix.exs elixir requirement, a rebar.config minimum_otp_vsn, a pubspec.yaml SDK constraint, a build.sbt scalaVersion, or a framework major pinned by a dependency constraint. This repository carries none of them, so nothing about its platform was established. That is a gap in this analyzer's coverage, NOT a finding that the platform is supported — a language whose runtime is declared elsewhere (Package.swift, a REDACTED) is simply not read here yet.
AX6 Interface segregation — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover most of the languages this repository's product is written in. What it read is kept, but it is too small a share to grade the product by. That is a gap in this analyzer's language reach — not a finding about this repository.
AXR1 Runtime accessibility — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Render strategy: boot via DockerCompose (docker-compose.yml). compose up failed (exit 1 — a container did not start, exited, or never became healthy) — no service selected; runtime evidence skipped.
ED5 Idempotency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check decides whether a handler's mutation is safe to re-run by recognising its persistence writes (a database save, a repository write, an event publish) and its guards. Those markers are .NET member names, so in this repository's language a write such as `repository.save(order)` is not recognised and a same-named call on an unrelated library type could be. The handlers were found; their idempotency was neither confirmed nor ruled out.
GD1 Unfinished & placeholder code — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, F#, JavaScript/TypeScript, Dart, Ruby and Scala source only, and this repository's Python, Rust is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
IC1 Incompleteness & stubs — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, JavaScript/TypeScript, Java, Dart, Ruby and Scala source only, and this repository's Python, Rust is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
M4 Documentation accuracy — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. M4 checks only the claim kinds adjudicated at or above 95 % precision: links and versions (PREREGISTRATION version 9), and artefact counts an order of magnitude off. Paths, command arguments, installs, environment variables, settings, projects, packages, routes, cd targets, infrastructure products and removed modules are read but not checked, and none of them is reported or counted.
X12 Unreachable branch — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover most of the languages this repository's product is written in. What it read is kept, but it is too small a share to grade the product by. That is a gap in this analyzer's language reach — not a finding about this repository.
X13 Undrained process stream — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover most of the languages this repository's product is written in. What it read is kept, but it is too small a share to grade the product by. That is a gap in this analyzer's language reach — not a finding about this repository.
X16 Unfloored truncation loop — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover most of the languages this repository's product is written in. What it read is kept, but it is too small a share to grade the product by. That is a gap in this analyzer's language reach — not a finding about this repository.
X3 Exception handling — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover most of the languages this repository's product is written in. What it read is kept, but it is too small a share to grade the product by. That is a gap in this analyzer's language reach — not a finding about this repository.
X4 Structured logging — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 157 further occurrence(s) are not listed individually; the score already reflects all 197.
Repo exclusion declarations: 1 pattern(s) declared (.gitattributes linguist-generated/vendored, .editorconfig generated_code) excluded 0 source file(s) from code-quality scoring. Declarations are the repo's own visible statement that a tree is machine-written or vendored — auditable in any diff, honored by GitHub the same way.
Limitations & what we did not check
We assess the repository exactly as committed, and only the repository. By design we do not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.
Per-dimension blind spots
For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.
D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
D12 Dependency Hygiene: Dependency health reads manifests and lockfiles — a vulnerability in a vendored/copied dependency, or risk from how a dependency is actually used, is outside this view.
D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
D19 Documentation Quality: Documentation quality publishes two things only: a runnable or packaged unit with no example, and a multi-project root README that maps none of its parts. It does not judge clarity, and its other checks (overview, licence, boilerplate, structure, empty sections, XML-doc coverage) are withheld after adjudication: their candidates are counted in the card's gaps, not shown as rows. A false statement in a document is M4's; units are .NET projects only.
D20 ADR Quality: ADR quality checks the structure of the decision records present: it cannot know about decisions made and never recorded, and it does not judge how well a record argues its case. Records in a language the section lexicon does not cover are not evaluated.
D24 Comment Value: Comment value is measured as redundancy only: a comment that repeats its code's words is found, but a paraphrase in other words, a vague comment, or one the code contradicts is not, and whether a comment is valuable is not claimed. Comments in other scripts or languages, and outside C#, are not judged.
D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
D31 IaC & Container Security: IaC scanning checks Dockerfiles/Terraform/Kubernetes against best-practice rules — it cannot see the live cloud account, runtime configuration, or drift between the committed config and what is actually deployed.
D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
AC1 Text alternatives: Alt-text is detected structurally — the scan sees that an alternative EXISTS, not whether it meaningfully describes the image, and decorative-vs-missing is judged by attribute shape; runtime-injected images and a non-role=img decorative svg are out of scope. This is accessibility readiness, never a WCAG conformance claim.
AC2 Forms & labels: Label association is read from static markup — a label wired up at runtime (JS-set aria-labelledby, framework-injected ids) reads as missing, a present label says nothing about whether its text is correct. A known UI-library field component (e.g. a JSX <TextField>) is now checked conservatively — flagged only when it carries NO label/aria-label/aria-labelledby/id/name — but wrapper/context-labelled libraries (Chakra/Radix FormControl+FormLabel) aren't statically visible (possible false positive) and non-JSX lowercased components are still skipped. A click handler on a plain element is now asked for a name too (it is a control the author declared), but the subtree test that answers it is deliberately generous: any DYNAMIC text expression in the subtree counts as a name, so an icon chosen by a ternary ({cond ? <IconA/> : <IconB/>}) reads as named, and a glyph component from a library the icon-import list does not know still names its parent. A clean result is "no unlabelled control found", not a labelling proof.
AC3 Page structure: Page structure is read from the static markup tree — landmarks, headings and lang injected at runtime aren't seen, heading ORDER is checked structurally (not against the rendered visual hierarchy), and lang/title/main fire only on full documents, never partials, and the data-table check sees header-cell presence (a <th> exists), not whether each header correctly associates with its cells. Static readiness, not conformance.
AC6 Visual & motion safety: Contrast and motion safety are PARTIAL by construction — literal colours (hex/rgb/hsl/named) in inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS top-level declarations are read (same-rule/same-element colour+background pairs only); computed/runtime/theme colour, external-CDN stylesheets, CSS-in-JS dynamic (${…}) and nested-selector colours, cross-element pairs and image contrast stay out of reach, so a clean result is bounded by what the static CSS itself shows.
AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
AX9 CQS / query purity: Handlers are found by interface/name convention — a query handler using neither is not seen. Mutation is a resolved write/publish invocation (SaveChanges/repository/bus), so a write hidden behind a hand-rolled wrapper, reflection, or a string-keyed service locator resolves to a non-persistence type and isn't flagged; it detects that a query writes state, not whether the write is a legitimate read-side cache update. Clean means "no resolved write/publish in a query body", not a proof of CQS purity.
DM4 Rich vs anemic domain model: Behaviour is detected as state mutation inside a method body — a method that enforces an invariant by validating-and-throwing without mutating reads as a query, and mutation delegated through an interface the scan can't resolve isn't credited; entities with zero public properties still drop out of the population. It detects that state changes, not whether the rule is correct.
DM6 Domain ↔ infrastructure boundary: Infrastructure reached through a hand-rolled wrapper, a domain-named facade, reflection, or a string-keyed service locator resolves to a non-infra type and isn't seen; the body scan is symbol resolution over syntax, not full dataflow. A clean result means "no resolved infra reference in a domain body", not a proof of purity.
M4 Documentation accuracy: Documentation accuracy checks links, versions and artefact counts against the tree: other claims (paths, commands, settings, routes) are read but not checked, and it cannot run the onboarding or measure how long a real new joiner takes.
P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
P5 DR & Backup: Backup/restore and disaster-recovery readiness is judged from in-repo evidence — a config that exists is not a tested restore, so the absence of positive evidence is reported as "not evidenced", never scored as present.
P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.
What it measures: How tangled the control flow is — methods with many branches are hard to test and change.
Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.
21 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was SortingFieldExtractorComponent::convert_to_u64_ff_val at 50. A further 4 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being quickwit_metastore_utils::bin::replay::replay_grpc_request at 18 — they are counted neither in the figure above nor in this dimension's score. 4 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold functions was excluded, so the exclusion is disclosed nowhere in the file itself: quickwit/quickwit-metastore-utils/src/bin/replay.rs (quickwit_metastore_utils::bin::replay::replay_grpc_request at 18), quickwit/quickwit-common/src/tower/metrics.rs (quickwit_common::tower::metrics::grpc_code_label at 17), quickwit/quickwit-query/src/elastic_query_dsl/mod.rs (ElasticQueryDslInner::convert_to_query_ast at 17), quickwit/quickwit-doc-mapper/src/tag_pruning.rs (quickwit_doc_mapper::tag_pruning::extract_unsimplified_tags_filter_ast at 16). They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.
+ 12 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 3 bodies over 30 down to 30 or less in Cyclomatic Complexity — start with SortingFieldExtractorComponent::convert_to_u64_ff_val (cyclomatic 50), quickwit_serve::serve_quickwit (cyclomatic 32), quickwit_serve::mcp_api::protocol::handle (cyclomatic 31). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 3 together lifts Cyclomatic Complexity from 7.1 to about 7.6/10, projected with the scoring formula itself and assuming each lands exactly at 30; a cleaner split scores higher.
Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How hard the code is for a person to follow, beyond raw branching.
Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.
+ 34 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 11 bodies over 30 down to 30 or less in Cognitive Complexity — start with SortingFieldExtractorComponent::convert_to_u64_ff_val (cognitive 56), quickwit_serve::serve_quickwit (cognitive 52), TantivyBoolQuery::simplify (cognitive 50). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 11 together lifts Cognitive Complexity from 6.6 to about 7.3/10, projected with the scoring formula itself and assuming each lands exactly at 30; a cleaner split scores higher.
Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D3 · God Classes9.0 / 10Stronggated by 66 serious findings✓ Tool-verified
What it measures: Over-large classes that try to do too much ("god classes").
Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.
+ 1 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 30 FileTooLong finding(s) in God Classes — start with mod.rs (6), lib.rs (2), leaf.rs. — One of this dimension's main actionable groups (30 warning-level).
Resolve the 14 FunctionTooLong finding(s) in God Classes — start with lib.rs (2), AggregationEditor.tsx, grpc.rs. — One of this dimension's main actionable groups (14 warning-level).
Resolve the 10 MethodTooLong finding(s) in God Classes — start with ingester.rs, metastore.rs, serialize.rs. — One of this dimension's main actionable groups (10 warning-level).
Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How much of the production code is copy-pasted: the share of production lines inside a reported copy (every copy of a duplicated block or of an edited member, each line once), 10 at none and 0 at a quarter of the lines.
Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), scored on the share of production lines inside a reported copy (each line once; 10 at none, 0 at a quarter). Deterministic.
76 duplicated block group(s) detected. 2.2 % of the production lines (5,022 of 229,957) are in a reported copy. A further 110 rows report members as variants of one another; the share counts each copied line once, however many rows cite it. 2 of the 186 are in trees this repository does not ship — vendored, example/demo, project-template, fixture and benchmark code — and are ranked below the shipped groups rather than excluded from them: the duplication there is real and is still counted in this dimension's score. The dimensions that publish a production-file census leave those trees out of theirs, so this count is deliberately drawn over the wider population.
+ 67 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 10 Duplicated block (8 lines × 2) finding(s) in Code Duplication — start with source.rs (2), index.rs, visitor.rs. — One of this dimension's main actionable groups (10 warning-level).
Resolve the 9 Duplicated block (9 lines × 2) finding(s) in Code Duplication — start with metastore_config.rs, ingester.rs, mrecordlog_utils.rs. — One of this dimension's main actionable groups (9 warning-level).
Resolve the 8 Edited copy of a member (17 corresponding lines) finding(s) in Code Duplication — start with rest_handler.rs, counter.rs, uri.rs. — One of this dimension's main actionable groups (8 warning-level).
Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D5 · Coupling6.6 / 10Adequate✓ Tool-verified
What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.
Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.
Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.
35 production modules (Cargo+npm), 0 dependency cycle(s), 8 unstable depended-on module(s). Read from the build's own module declarations; 6 module(s) off the main sequence, with abstractness counted on 34 of the 35 (the rest declare no modelled class or interface, export only macros, declare types in source no model reads, or have no source directory of their own).
Off the main sequence: quickwit-codegen · ×5
Unstable project quickwit-compaction
Unstable project quickwit-control-plane
Unstable project quickwit-jaeger
Unstable project quickwit-janitor
+ 5 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 5 Off the main sequence finding(s) in Coupling. — One of this dimension's main actionable groups (5 warning-level).
Resolve the 1 Unstable project quickwit-compaction finding(s) in Coupling. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 Unstable project quickwit-control-plane finding(s) in Coupling. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether a class's methods are focused on a single responsibility.
Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.
Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.
Resolve the 2 Low cohesion finding(s) in Cohesion (LCOM4) — start with codegen.rs, actor_context.rs. — One of this dimension's main actionable groups (2 warning-level).
Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D10 · Test Quality10.0 / 10Exemplary✓ Tool-verified
What it measures: Whether the tests truly assert behaviour rather than just running the code.
Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.
0 skipped, 0 zero-assertion, no mocking-framework packages referenced (hand-written doubles or no mocking) across 10 tests. Measured on the JavaScript/TypeScript suite only — at least 56 test source file(s) (.rs) went unread, so its test quality is unmeasured and is not in these counts.
What it measures: Whether dependencies are current, not deprecated, and not bloated. Known vulnerabilities are D30's.
Method: Manifest scan via dotnet list package across all projects; worst-signal-per-package deduction (capped-linear for deprecation, prerelease and outdated) per KLoC. Known-vulnerable packages are D30's and are not charged here (rubric-2026.11.2). Exhaustive.
36 outdated, 0 yanked direct Cargo dependencies. 173 of 174 direct crates were graded against crates.io (0 not published there, 1 not resolved by a committed REDACTED). Only DIRECT edges are graded: a transitive crate cannot be moved past what its parent's requirement admits, so reporting one would be advice its owner cannot take. A newer release is reported only where this repository's OWN requirement already admits it, so the remedy is `cargo update` and never a manifest edit — which means a release outside the declared range is deliberately NOT charged, because a written-down constraint is a decision rather than a defect. Note that a bare requirement is a CARET, and for a 0.x crate its ceiling is the minor. Whether any crate is UNMAINTAINED is not graded — crates.io publishes no maintenance status, and release age does not stand in for one. Known CVEs in this dependency graph are D30's question, read from REDACTED there.
Outdated: arc-swap · ×36
Detailed fixes: d12_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.
Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.
What it measures: Whether the licenses of third-party packages are compatible with your policy.
Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.
0 of 1043 shipped crate(s) use a banned license. Licences were resolved from crates.io over the crates a consumer compiles — this repository's REDACTED closed over its manifests' `[dependencies]` and `[build-dependencies]`. Crates it asks for ONLY under `[dev-dependencies]` are excluded: they are not compiled by anything that depends on this repository. A further 13 crate(s) in the closure resolve from git, a path or a private registry and publish no licence this pass can read; they are outside this verdict. This repository publishes itself under Apache-2.0, which is its own choice and is not judged here.
What it measures: Files that change often and are also complex — the riskiest hotspots.
Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.
Resolve the 5 Hotspot finding(s) in Churn × Complexity Hotspots — start with leaf.rs, lib.rs, field_mapping_entry.rs. — One of this dimension's main actionable groups (5 warning-level).
Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D16 · Bus Factor9.4 / 10Exemplary✓ Tool-verified
What it measures: Whether knowledge is concentrated in too few people (the "bus factor").
Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.
29 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is quickwit/quickwit-query/src/query_ast/regex_extract_eq.rs. Counted over 519 of the 633 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
Off-boarding risk: anonymized user #1 · ×4
Further sole-owners (lower concentration)
✓ On the Gold path — maintain.
Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.
Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.
214 deducted task-comment markers across 229957 LoC (0.1/KLoC) → score 9.8. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.
Resolve the 206 TodoComment finding(s) in Explicit Debt — start with mod.rs (15), control_plane.rs (9), lib.rs (8). — One of this dimension's main actionable groups (206 warning-level).
Resolve the 7 FixmeComment finding(s) in Explicit Debt — start with s3_compatible_storage.rs (2), mod.rs (2), metastore.rs (2). — One of this dimension's main actionable groups (7 warning-level).
Resolve the 1 HackComment finding(s) in Explicit Debt — start with quickwit_cache.rs. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the project's documentation is clear, complete, and useful.
Method: Every README, docs/ document and root guide parsed by its markup and measured in Unicode letters. Published: a runnable or packaged .NET project whose README (or a document it links, or a root guide) shows no example, and a root README naming none of three or more projects. Overview, licence, boilerplate, wall-of-text, empty-section and XML-doc rows are measured and withheld (counted in gaps) after adjudication. Deterministic, exhaustive, advisory.
1 of 1 documentation facets pass in full. 94 document(s) read across 2 unit(s).
✓ On the Gold path — maintain.
Detailed fixes: d19_recommendation.md.
Do you agree with this assessment?
D20 · ADR Quality0.0 / 10Critical✓ Tool-verified
What it measures: Whether architecture decisions are recorded well (context, decision, consequences).
Method: Every ADR read by its section structure: nine located rules (a missing Decision, Context or Consequences section, a stale status, two records deciding the same question, a dangling supersede link, a number-only title, a single option, no named cost, no status where the log uses one, no enforcement field where the log adopted one), each a fixed deduction from 10; the score is the mean over evaluated records. Deterministic, no model. Advisory.
What it measures: Whether comments are worth it — explaining WHY (valuable) rather than WHAT (redundant).
Method: Every inline C# comment compared word by word with the identifiers, literals and constructs of the code it annotates (taken from the syntax); a comment whose words that code already contains is redundant, as are closing-brace labels and generator template text. Comments giving a reason or a reference are kept; other scripts and languages are not judged. Deterministic, exhaustive, advisory.
3 of 36 build units (Cargo, Make, npm) flagged as possibly oversized/incoherent.
Projects may be oversized for their cohesion
What to do
Resolve the 1 Projects may be oversized for their cohesion finding(s) in Project Cohesion. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.
Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.
What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.
Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.
Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).
36 finding(s): 0 critical, 28 high, 8 medium, 0 low. semgrep hit a parse error in 8 file(s) — `quickwit/quickwit-doc-mapper/benches/data/simple-parse-bench.json`, `quickwit/quickwit-doc-mapper/benches/data/simple-routing-expression-bench.json`, `quickwit/quickwit-indexing/benches/data/bench_data.json`, `quickwit/quickwit-indexing/benches/data/bench_data_heavy_transform.json`, `quickwit/quickwit-indexing/benches/data/bench_data_light_transform.json`, … (+3 more) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. Separately, one or more rules could not re-parse an embedded snippet in 5 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
+ 8 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 7 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (6), REDACTED. — One of this dimension's main actionable groups (7 issue-level).
Resolve the 6 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (3), REDACTED, REDACTED. — One of this dimension's main actionable groups (6 issue-level).
Resolve the 5 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2), REDACTED, REDACTED. — One of this dimension's main actionable groups (5 issue-level).
Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.
Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05. Advisory since rubric-2026.11.2 (CAI decision 0006): every row is a match against a vulnerability database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.
+ 3 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 12 Medium advisory (unsound) finding(s) in Dependency Vulnerabilities — start with REDACTED (12). — One of this dimension's main actionable groups (12 warning-level).
Resolve the 4 High CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (3), REDACTED. — One of this dimension's main actionable groups (4 issue-level).
Resolve the 1 Critical CVE finding(s) in Dependency Vulnerabilities — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Detailed fixes: d30_recommendation.md · top locations in Appendix A, every location in findings.md.
Resolve the 17 High IaC finding(s) in IaC & Container Security — start with REDACTED (7), REDACTED (5), REDACTED (2). — One of this dimension's main actionable groups (17 issue-level).
Resolve the 12 Medium IaC finding(s) in IaC & Container Security — start with REDACTED (3), REDACTED (2), REDACTED (2). — One of this dimension's main actionable groups (12 warning-level).
Resolve the 1 Critical IaC finding(s) in IaC & Container Security — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Detailed fixes: d31_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.
Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.
28 of 519 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is quickwit/quickwit-serve/src/openapi.rs. Counted over 519 of the 633 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
Resolve the 4 Orphaned knowledge finding(s) in Knowledge Freshness — start with openapi.rs, shared_state.rs, model.rs. — One of this dimension's main actionable groups (4 issue-level).
Resolve the 24 Orphaned file finding(s) in Knowledge Freshness — start with index_resource.rs, temp_dir.rs, alloc_tracker.rs. — One of this dimension's main actionable groups (24 recommendation-level).
Resolve the 1 Further orphaned files (smaller) finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.
Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.
Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.
Resolve the 11 Change coupling finding(s) in Change Coupling — start with control_plane.rs (2), mod.rs, tests.rs. — One of this dimension's main actionable groups (11 warning-level).
Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.
Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.
Resolve the 4 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED (2), REDACTED (2). — One of this dimension's main actionable groups (4 warning-level).
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the repository publishes a coordinated-vulnerability-disclosure policy (SECURITY.md or security.txt) with a reporting contact, so finders know how to report a vulnerability. Presence of a policy file with a contact, not whether the policy is adequate or honoured.
Method: Vulnerability-disclosure policy read deterministically from the repo: a SECURITY.md (root/.github/docs) or .well-known/security.txt / security.txt, regex-checked for a reporting contact (email / URL / mailto). Present + contact → 10; present without a contact → 4; NotApplicable when no policy file exists (it may live off-repo). Detects the policy file's presence + contact, not its adequacy.
What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Reported apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.
Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. Advisory since rubric-2026.11.2 (CAI decision 0006): the malicious-package feed is a database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.
No dependency in any ecosystem this repository declares is published as malicious.
✓ On the Gold path — maintain.
Detailed fixes: d43_recommendation.md.
Do you agree with this assessment?
Frontend & cross-cutting dimensions
R = React/JS · M = Maturity · P = Readiness.
AC1 · Text alternatives10.0 / 10Exemplary○ Nothing flagged
Other · Accessibility — Whether non-text content carries a text alternative — img/area/input[type=image] have alt, a meaningful svg has a title or aria-label, video has a captions track, and object/embed/canvas have a name or fallback content. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: every img/area/input[type=image] checked for alt, svg[role=img] for a title/aria-label, video for a captions <track>. Components skipped, spreads suppressed. Deterministic, hard fact per element.
Coverage: Population: image/media elements — img, area, input[type=image], svg, video, object, embed, canvas — across the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and dynamic-attribute elements are skipped. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is NOT read by any producer, so it contributes no element to this population; where such a frontend is present the card discloses it as an analyzer gap rather than scoring around it.
Do you agree with this assessment?
AC2 · Forms & labels7.8 / 10Strong✓ Tool-verified
Other · Accessibility — Whether form controls have a programmatic label (an associated label, aria-label or aria-labelledby), buttons have text, links have an accessible name, a click handler on a plain element names the control it declares, fieldsets have a non-empty legend, known UI-library field components carry a label prop, and a placeholder isn't used as the only label. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: inputs/selects/textareas checked for an associated label[for]/wrapping label/aria-label/aria-labelledby (per document), buttons for accessible text, fieldsets for a legend; placeholder-only labelling flagged. Deterministic, hard fact per control.
Coverage: Population: form controls, buttons, links, fieldsets and known UI-library field components in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and spread/dynamic-attribute elements are skipped, so a control whose label arrives through a spread or a runtime expression is deliberately not judged. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
This UI-library field component has no label / aria-label / aria-labelledby / id at this call site, and nothing written inside it here carries one either (a name prop is the form-submission key, not a label; an id, even one the component sets on what it renders, names nothing until a label points at it) — so it likely renders an unlabelled control. Name it whichever way this library supports: a label prop, an aria-label, or an id on the rendered control with a <label htmlFor> pointing at it. For a group of controls, name the group itself (aria-label, or a fieldset with a legend) — labelling each item leaves the set unnamed. (×3) — quickwit/quickwit-ui/src/components/IndexSideBar.tsx:84, quickwit/quickwit-ui/src/components/QueryEditor/AggregationEditor.tsx:346, quickwit/quickwit-ui/src/components/QueryEditor/AggregationEditor.tsx:361
This UI-library field component has no label / aria-label / aria-labelledby / id, and nothing written inside it here carries one either (a name prop is the form-submission key, not a label; an id alone, wherever it is set, names nothing until a label points at it). The text inside it does not stand in for one: these compound APIs render a trigger with role="combobox" (or role="button"), and those roles take their name from the AUTHOR, not from their content — so the words on screen never reach the accessibility tree as a name. Name it whichever way this library supports: a label prop, an aria-label, or an id on the rendered control with a <label htmlFor> pointing at it. For a group of controls, name the group itself (aria-label, or a fieldset with a legend) — labelling each item leaves the set unnamed. (×2) — quickwit/quickwit-ui/src/components/QueryEditor/AggregationEditor.tsx:86, quickwit/quickwit-ui/src/components/QueryEditor/AggregationEditor.tsx:300
What to do
Give every control a programmatic label (a <label for> / wrapping <label> / aria-label) and every button text — a placeholder is not a label.
Do you agree with this assessment?
AC3 · Page structure7.7 / 10Strong✓ Tool-verified
Other · Accessibility — Whether pages declare a language (well-formed BCP-47) and a non-empty title, expose exactly one main landmark and a sane heading order with non-empty headings, keep zoom enabled, title their iframes, give data tables header cells, and avoid meta-refresh. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: html lang, document <title>, a main landmark and heading order on full documents only, plus zoom-disabling viewports, untitled iframes and meta-refresh anywhere. Deterministic, per structural checkpoint.
Coverage: Population: the PARSED MARKUP documents (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx). The page-level checks — lang, title, single main landmark — fire ONCE PER FULL DOCUMENT (an <html> root) and never on a partial or component fragment, so a repo of fragments is assessed only on the per-element checks (heading order, table headers, iframe titles, meta-refresh, zoom). Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en"). (×2) — quickwit/dependency-licenses.html:1, REDACTED:1
A page with no <title> gives no name in the tab, history or screen-reader page list. Add a descriptive <title> in <head>. (×2) — quickwit/dependency-licenses.html:1, REDACTED:1
What to do
Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh.
Other · Accessibility — Whether focus outlines aren't removed without a replacement, motion respects prefers-reduced-motion, and literal CSS colour pairs meet contrast — PARTIAL: inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS literals are read (hex/rgb/hsl/named), never computed/runtime/external-CDN colour. Static markup readiness, not a WCAG conformance claim.
Method: Static markup/CSS scan: inline outline:none/0, literal inline colour/background contrast against the 4.5:1 AA floor, and <style>-block animation without a prefers-reduced-motion guard. Deterministic but PARTIAL — only inline styles and in-repo CSS literals are visible.
Coverage: Population: styled elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx), plus in-repo <style> blocks, in-repo .css files and CSS-in-JS literals. Colour contrast is computed from LITERAL colour pairs only (hex/rgb/hsl/named, including var() tokens and Tailwind neutral utilities) — computed, runtime-themed and external-CDN colour is never resolved, so this is a partial read of contrast by construction. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
`.css-in-js` moves (`animation: _______ infinite 5s linear`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — quickwit/quickwit-ui/src/components/Loader.tsx:35
What to do
Keep a visible focus style (don't remove the outline without a replacement), guard animation with prefers-reduced-motion, and raise low-contrast colour pairs to at least 4.5:1.
Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.
Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.
Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.
Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).
Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.
Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.
Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.
Other · Architecture — Whether read (query) handlers stay side-effect-free — a query that writes persistent state or raises events breaks CQS and makes reads unsafe to retry, cache, or route to a read replica.
Method: Roslyn scan: CQRS handlers classified query-vs-command by interface (IQueryHandler/ICommandHandler/IRequestHandler<TQuery,TResult>) and name convention (*Query/Get*/Find* vs *Command); each query handler's body checked for persistent-state writes (SaveChanges/repository Add-Update) or event publishes by resolved invocation. Deterministic, type-level, exhaustive over the detected handlers.
Coverage: Population: CQRS handlers identified by IQueryHandler/ICommandHandler/IRequestHandler interface + *Query/Get*/Find*/*Command NAME convention; query purity then checked exhaustively within that set — a query handler using neither convention is invisible, and mutation is a resolved persistence/publish CALL, not full dataflow.
Do you agree with this assessment?
C2 · Access Controls7.0 / 10Strong✓ Tool-verified
Other · Security — Whether access is authorized by default — a framework authorization attribute/decorator or policy, or imperative guard methods (throw-on-violation) called from handlers.
Method: Roslyn scan: [Authorize] usage and authorization policies, plus imperative throw-on-violation guard methods detected via syntax. Deterministic.
Authorization IS enforced here (by route guards, auth middleware or checks that refuse a caller) — this is NOT a claim that endpoints are unprotected. What's missing is a NAMED rule set: who may do what is encoded inline where it is checked, so the rules can't be listed, reviewed or tested apart from the code that applies them. Recommendation, not a defect.
What to do
Name the access rules — roles and permissions declared once (an enum Role/Permission, actix-web-grants #[protect(…)], axum-login's permission_required!, a casbin or oso policy) and consulted where access is checked, so the rule set is reviewable and testable on its own.
Do you agree with this assessment?
DM4 · Rich vs anemic domain model10.0 / 10Exemplary✓ Tool-verified
Other · Domain Modelling — Whether domain entities own their behaviour (invariant-enforcing commands) rather than being data-only structs driven by a foreign service.
Method: Roslyn (DDD-gated): entity method BODIES classified mutator-vs-query — only methods that mutate the entity's own declared state count as invariant-protecting behaviour, so a getter/passthrough doesn't rescue an anemic class. Deterministic, exhaustive over domain-layer entities.
Coverage: Population: entities by name/base convention; rich-vs-anemic judged by classifying each method body mutator-vs-query — logic-bearing domain types outside the convention are invisible.
Other · Domain Modelling — Whether a domain type's identity-bearing field stays immutable — a `pub` mutable field under a hand-rolled Hash/PartialEq breaks the value-identity invariant.
Method: Roslyn (DDD-gated): entities scanned for publicly writable state — public setters, and (C#/VB) own mutable collections handed out through an auto-property, a public field or a bare-field expression getter, where a computed/copying getter is never charged. One finding per entity; score softened when Marten/EF rehydration frameworks present. Deterministic, framework-aware.
Coverage: Population: entities by convention; encapsulation (setter shape) checked exhaustively within the set.
`IndexUid` implements a hand-rolled `Hash`/`PartialEq` (identity semantics) over a `pub` mutable id/hash field — mutating it after the value is placed in a set/map silently corrupts the collection. Make the identity field private + immutable (set once in the constructor). — quickwit/quickwit-proto/src/types/index_uid.rs:31
What to do
Make the id/hash field private and immutable — value identity must be stable for the lifetime of the value.
Other · Domain Modelling — Whether the domain layer stays free of infrastructure dependencies — a domain aggregate fused to a persistence ORM (diesel/sea-orm/sqlx) on its own declaration (active-record) couples the domain to infrastructure. The clean-architecture dependency rule.
Method: Roslyn (DDD-gated): domain-layer types scanned for infrastructure usage in member SIGNATURES and inside method/accessor BODIES — resolved calls and object-creations into EF/Marten/HTTP/Mongo/Redis/message-bus types (not just a namespace allowlist). Deterministic, symbol-resolved, exhaustive over domain-layer bodies, DDD-native.
Coverage: Domain layer identified by NAMESPACE heuristic; infrastructure then resolved by symbol in member SIGNATURES and method/accessor BODIES — rename the layer and the check evaporates.
Other · Event Sourcing — Whether domain events stay immutable (private fields, set once) rather than carrying mutable state.
Method: Roslyn scan (event-sourcing gated): persisted events checked for public setters; immutability verified per property/field. Deterministic, hard fact.
Maturity · Maturity — Whether the repository and its projects have a README, and whether it is substantive.
Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.
Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.
Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.
No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
What to do
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Maturity · Maturity — Whether the repository is organised deliberately: production code and tests are set apart in a way its ecosystem or the repository itself declares.
Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.
Maturity · Maturity — Whether the project's current-state documentation describes the code that exists.
Method: Every current-state document's checkable claims looked up in the tree (links, versions, and artefact counts an order of magnitude off), plus two README checks: an advertised infrastructure product with no footprint, and a module the CHANGELOG records as removed. Deterministic, no model. Advisory.
quickwit/quickwit-control-plane/README.md links to `./src/scheduler.rs#L66`, but `quickwit/quickwit-control-plane/src/scheduler.rs` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — quickwit/quickwit-control-plane/README.md:36
What to do
Reconcile the README with reality: quickwit/quickwit-control-plane/README.md links to `./src/scheduler.rs#L66`, but `quickwit/quickwit-control-plane/src/scheduler.rs` does not exist.
Readiness · Readiness — Whether an automated pipeline builds and tests every change.
Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.
Do you agree with this assessment?
P10 · Library API & versioning10.0 / 10Exemplary✓ Tool-verified
Readiness · Readiness — For a library: a deliberate (small) public API surface and explicit semantic versioning so consumers can depend on it safely.
Method: Roslyn scan: public API surface area and semantic-versioning markers (SemVer attributes, changelog entries) for libraries; off .NET, a library is the ecosystem's publication act (an npm package that is not private and names an entry point, a PyPI distribution with a build system, a Rust library crate, a Maven/Gradle module that publishes, a Go module with no package main, a gemspec, a Composer library, a SwiftPM library product, a pub.dev or Hex package), its surface is the share of types the language's code model records as public (Rust, Swift, Java, Kotlin, Go, Dart; not measured where the model records no type visibility or, as in TypeScript, only module-level export), and its version is read from the manifest, a semver CHANGELOG, release tooling or semver git tags. Exhaustive, deterministic.
1 public type in `quickwit_search.service` is marked as implementation by its own namespace, folder or name: `SearchServiceImpl` (quickwit/quickwit-search/src/service.rs:49, name ends in `Impl`). While it is public, every consumer of the library can bind to it, so changing it is a breaking change for those consumers. — quickwit/quickwit-search/src/service.rs:49
What to do
Hide `quickwit_search.service` (`SearchServiceImpl`) (Rust: `pub(crate)`, or keep the module private): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
Only 28/30 runnable modules use logging (modules with no entry point or server are excluded — they are libraries a runnable module hosts). Silent: `quickwit/quickwit-metastore-utils`, `quickwit/quickwit-metrics-inventory`.
What to do
Extend structured logging to the remaining runnable modules so everything you run is diagnosable in production.
Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).
Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.
`REDACTED` schedules updates, but no `package-ecosystem` entry covers `pip`, which this tree depends on — so those dependencies get no update pull requests and no advisory pressure, however complete the dep-scan credit looks. Add the missing entry to the `updates:` list. — REDACTED:2
What to do
Dependabot is configured but does not watch `pip` — add that `package-ecosystem` entry to REDACTED so those dependencies get the same automatic update and advisory pressure as the ones it already covers.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.
Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.
Do you agree with this assessment?
P5 · DR & Backup7.0 / 10Strong✓ Tool-verified
Readiness · Readiness — Whether disaster recovery is planned and codified — backups, geo-recovery, RTO/RPO, persistence guarantees — from IaC + container manifests + docs, never the live cloud.
Method: Filesystem scan: disaster recovery, backup, geo-recovery, RTO/RPO, persistence guarantees from IaC, manifests, and docs. Exhaustive, deterministic, never a live environment.
What to do
Document RTO/RPO and a tested restore procedure (a backup config alone isn't disaster recovery).
Readiness · Readiness — Whether outbound HTTP calls are wrapped in resilience (retry/timeout/circuit-breaker) so a failing dependency doesn't cascade.
Method: Source scan: outbound HTTP clients and what bounds them — resilience handlers (Polly, AddStandardResilienceHandler) on .NET; on Go, the JVM, Python, JavaScript/TypeScript, Ruby, PHP, Rust, Elixir, Swift, Dart and Erlang, a timeout, deadline, retry or breaker beside each call, or a process-wide client default (a framework-wide deadline such as Drupal core's, Laravel's or actix's awc counts). Exhaustive, deterministic.
`reqwest::Client::new(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout. — quickwit/quickwit-indexing/src/source/pulsar_source.rs:624
What to do
Give every client a whole-request bound: `reqwest::Client::builder().timeout(Duration::from_secs(10))` (never `reqwest::get` or `Client::new()`, which have none), ureq's `timeout_global`, or wrap the call in `tokio::time::timeout`; add retry with back-off (`reqwest-retry`'s `RetryTransientMiddleware`, `backoff`) around dependencies that fail.
Readiness · Readiness — Whether database schema changes go through versioned migrations rather than being auto-created from the model at startup.
Method: Roslyn scan: EF Core DbContext for a versioned migrations directory versus bare EnsureCreated usage; off .NET, a file scan of dependency manifests, migration histories (Flyway, Liquibase, Alembic, Django, Rails, Prisma, TypeORM, Knex/Sequelize, golang-migrate, goose, Laravel, Doctrine, Diesel/sqlx) and schema auto-create in production source or config. Exhaustive, deterministic.
Readiness · Performance — Whether the code protects its performance with benchmarks — a benchmark suite, allocation/memory measurement, and (ideally) a CI gate. Presence is credited as a bonus, never a deduction.
Method: Repo + source scan: BenchmarkDotNet referenced (csproj/source), [Benchmark]/[MemoryDiagnoser] attribute counts, and a benchmark step in CI; off .NET, the same ladder over Go testing.B, Rust criterion/#[bench]/divan, JMH/kotlinx-benchmark, pytest-benchmark/asv/pyperf, tinybench/mitata/vitest bench/benchmark.js and Swift package-benchmark — scored as a bonus ladder (absence is neutral, never a deduction). Deterministic, presence detection.
Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.
Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from each language's code model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.
Do you agree with this assessment?
R1 · Type Safety7.8 / 10Strong✓ Tool-verified
React / JS · Code Health — How much of the frontend is typed TypeScript vs untyped JavaScript.
Method: Frontend file inventory: the share of typed TypeScript vs untyped JavaScript across the source tree. Deterministic, exhaustive over frontend files.
React / JS · Code Health — The share of the scored frontend lines inside a near-exact copy-pasted block of substantial extent (the D4 clone algorithm over JS/TS tokens, D-386; each line once, 10 at none and 0 at a quarter of the lines, as D4): a block is reported only where its copies still agree on most of their own identifiers and literals, or were renamed as they were pasted but kept most of their constants, and where the copies carry enough code to stand on their own or the copied extent reaches 30 lines — so a re-implementation sharing neither names nor values, and a small pasted declaration, are both found and deliberately not reported, and a clean R10 is not a claim that nothing was copied.
Method: Near-exact copy-pasted blocks of substantial extent across the frontend (the D4 clone algorithm run over JS/TS tokens). Masking finds the candidates; a block is reported when its copies still agree on most of their own identifiers and literals, or when a renamed copy still agrees on most of its constants, AND the copies carry enough code to stand on their own — or when the copied extent reaches 30 lines. So a re-implementation sharing neither names nor values, and a small pasted declaration, are deliberately not counted. Scored on the share of the scored frontend lines inside a reported copy, on the same curve as D4. Deterministic.
quickwit/quickwit-ui/src/components/TimeRangeSelect.tsx:233 · quickwit/quickwit-ui/src/components/TimeRangeSelect.tsx:252 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. — quickwit/quickwit-ui/src/components/TimeRangeSelect.tsx:233
quickwit/quickwit-ui/src/components/QueryEditor/AggregationEditor.tsx:189 · quickwit/quickwit-ui/src/components/QueryEditor/AggregationEditor.tsx:204 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — quickwit/quickwit-ui/src/components/QueryEditor/AggregationEditor.tsx:189
quickwit/quickwit-ui/src/components/SideBar.tsx:95 · quickwit/quickwit-ui/src/components/SideBar.tsx:105 — all 2 copies are in the same file, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are. — quickwit/quickwit-ui/src/components/SideBar.tsx:95
quickwit/quickwit-ui/src/views/NodeInfoView.tsx:65 · quickwit/quickwit-ui/src/views/NodeInfoView.tsx:75 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — quickwit/quickwit-ui/src/views/NodeInfoView.tsx:65
What to do
Act on each finding's own remediation rather than one rule: the move depends on what recurs. Where the copies are executable blocks, give the shared part one home and call it from each site; where they are declarations, a listing, a specialisation already delegating to its base, or one shape repeated per entity, there is no call site and the move is a shared type, a generated set or a factory — sometimes there is nothing to extract.
React / JS · Code Health — Per-function cyclomatic/cognitive complexity from the token-level function scanner (D-386) — real branching, not a regex heuristic.
Method: Per-function cyclomatic/cognitive complexity from a token-level function scanner (real branching, not a regex heuristic), computed over every frontend function. Deterministic.
parseSearchUrl has cyclomatic complexity 11 and cognitive complexity 12; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — quickwit/quickwit-ui/src/utils/urls.ts:28
Do you agree with this assessment?
R3 · Large Files10.0 / 10Exemplary✓ Tool-verified
React / JS · Code Health — How many source files exceed the large-file threshold.
Method: Components/modules exceeding the large-file threshold, counted exhaustively across the frontend source tree. Deterministic.
Do you agree with this assessment?
R4 · Test Coverage9.4 / 10Exemplary✓ Tool-verified
React / JS · Readiness — Static test reachability (D-386): the share of production files reachable from any test via the import graph — measured without running anything.
Method: Static test reachability: the share of production files reachable from any test via the import graph — measured without running anything. Deterministic.
No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one. (×2) — quickwit/quickwit-ui/src/providers/EditorProvider.tsx:1, quickwit/quickwit-ui/jest/setup.js:1
What to do
Add tests that import the unreached modules (directly or through their public entry).
Do you agree with this assessment?
R6 · Tooling10.0 / 10Exemplary✓ Tool-verified
React / JS · Readiness — Whether the project wires up test, lint and typecheck — detected from each package.json script's COMMAND (eslint / tsc / vitest / jest / playwright), not just its name, and corroborated against CI-workflow invocations so a tool run only in CI still counts.
Method: package.json scanned for test/lint/typecheck script wiring. Deterministic presence check.
Do you agree with this assessment?
R7 · Dead Code9.2 / 10Exemplary✓ Tool-verified
React / JS · Code Health — Files unreachable from every application/tooling/test entry point, and exports nothing imports (module-graph reachability, D-386).
Method: Dead code: files unreachable from every application/tooling/test entry point plus exports nothing imports, via module-graph reachability. Deterministic, exhaustive over the import graph.
Unreachable from the 7 application, 3 tooling and 11 test entry point(s) detected in this repo. Gate removals on `npm run build` — an undetected custom entry would make these reachable.
no import path from any entry point (7 application, 3 tooling, 11 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make — quickwit/quickwit-ui/src/providers/EditorProvider.tsx
Nothing imports this binding — it is safe to review for removal. (×8) — quickwit/quickwit-ui/src/components/QueryEditor/config.ts:183, quickwit/quickwit-ui/src/utils/models.ts:43, quickwit/quickwit-ui/src/utils/models.ts:242, …
What to do
Delete the dead files and unused exports — every line is maintenance cost and rebuild-estimate inflation with zero runtime value.
React / JS · Readiness — npm dependency truthfulness (D-386): unused dependencies, imports not declared anywhere, and type-/test-only packages shipped as production deps.
Method: npm dependency truthfulness: unused dependencies, imports declared nowhere, and type-/test-only packages shipped as production deps — from the manifest + import graph. Deterministic.
Imported but not declared in any reachable package.json — installs work only by hoisting accident. (×4) — quickwit/quickwit-ui/src/components/TopBar.tsx:27, quickwit/quickwit-ui/src/components/SideBar.tsx:24, quickwit/quickwit-ui/src/components/SideBar.tsx:26, …
Declared in quickwit/quickwit-ui/package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it. (×5)
Only test files import it (first: quickwit/quickwit-ui/src/index.test.js:16) — move it to devDependencies. — quickwit/quickwit-ui/package.json:23
What to do
Remove unused dependencies, declare unlisted imports explicitly, and demote type-/test-only packages to devDependencies.
React / JS · Architecture — Import cycles in the module graph (D-386) — files that can only be understood and changed together.
Method: Import cycles in the module graph, detected exhaustively over JS/TS imports (the same cycle detection as the .NET coupling dimension). Deterministic.
Other · Security — Read from this repository's Rust source: cryptographic hygiene (weak hash or cipher, key material fixed in the source) and outbound TLS (certificate validation, protocol version) — facts about code that hold whether or not it serves anything itself. This repository serves HTTP itself (`.serve_connection_with_upgrades(` (quickwit/quickwit-serve/src/rest.rs:399)), so its Rust source was also read for the server controls: TLS served or HSTS set, security response headers, cookie flags and inbound validation — each credited where its Rust spelling appears in production source, not proven on every route. A Rocket 0.5 application is credited the headers Rocket's default `Shield` sends unless it attaches its own, and its cookie jar's SameSite=Strict default; a session middleware its default cookie flags.
Method: Roslyn plus filesystem scan: HSTS/security headers, secure cookies, input validation, middleware order, weak crypto (MD5/SHA1/DES); HTTPS-metadata context-aware. On a repository with no .NET source it reads JavaScript/TypeScript, Dart, Ruby, Scala, Rust or Elixir source itself (test, vendored, generated and minified paths not) for the arms that hold whether or not the code serves HTTP: a weak hash or cipher, key material fixed in the source, a TLS client that accepts any certificate, and (JavaScript/TypeScript, Ruby, Scala, Rust and Elixir) an obsolete TLS version; the server controls are not assessed there, and a Dart, Ruby, Scala, Rust or Elixir repository that serves no HTTP of its own is N/A on them. Deterministic.
MD5/SHA1 is computed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ (`sha2::Sha256::digest(…)`) for content integrity, or a KDF (bcrypt/Argon2/scrypt) for password storage. If it only derives a non-security identifier (a cache key, an avatar URL, an ETag), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as xxhash or murmurhash says it in code — since the algorithm alone cannot distinguish the two uses. Where a protocol this code does not own fixes the digest (a k-anonymity range query, a legacy signature format), the protocol decides; say so beside the call. (×4) — quickwit/quickwit-lambda-client/src/deploy.rs:77, quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:259, quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:562, …
None of the 11 security response headers the OWASP Secure Headers Project recommends (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options, …) is set on a response this repository's Rust server sends — defense in depth, even when a proxy could set them. (−2.0 on this card.) The server: `.serve_connection_with_upgrades(` (quickwit/quickwit-serve/src/rest.rs:399).
What to do
Review each MD5/SHA1 use by what it protects: replace it with SHA-256+ (or a KDF for passwords) where the digest is security-relevant, and switch it to a non-cryptographic hash (xxhash, murmurhash) where it only derives an identifier such as a cache key. This repository constructs a collision-broken hash (MD5/SHA1) at 4 sites, not one: `quickwit/quickwit-lambda-client/src/deploy.rs:77` (`md5::compute`), `quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:259` (`md5::compute`), `quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:562` (`md5::compute`), `quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:338` (`md5::Context::new`). Each is a separate decision — fixing only the line this row cites leaves the others in place.
Set security response headers on what the server sends — actix-web's `DefaultHeaders::new().add((header::X_CONTENT_TYPE_OPTIONS, "nosniff"))`, tower-http's `SetResponseHeaderLayer::overriding(…)` on an axum router, or keep Rocket's default `Shield` — with `Content-Security-Policy`, `X-Content-Type-Options` and a frame policy on every response.
Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.
Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.
Other · Security — Whether a hand-rolled public/private IP check can be walked past — a method that unwraps IPv4-mapped IPv6 but returns the opposite verdict for the same host written as IPv4-compatible, 6to4 or NAT64.
Method: Roslyn syntax + semantics: methods that unwrap IPv4-mapped IPv6 and hand-roll IPv4 range carve-outs, checked for whether the IPv6 branch also accounts for the IPv4-compatible, 6to4 and NAT64 embeddings. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X15 · Unvalidated length from an untrusted reader3.5 / 10Weak✓ Tool-verified
Other · Security — Whether a length read out of the stream being parsed is bounded before it is allocated or read — an unchecked count taken from the input lets the input choose the allocation.
Method: Roslyn syntax + semantics: integer lengths read from a BinaryReader and spent on a bulk read or an array allocation, checked for any comparison or bounding call on the value anywhere in the method. Deterministic, provable per finding. Advisory.
`meta_len` is read from the bytes being parsed at line 63 (`struct.unpack("<I")`), then passed as the size of `read` at line 70 — and nowhere in its function is `meta_len` compared to anything, clamped, or bounded against the input that remains. Whoever wrote those bytes therefore chooses the allocation directly: the call reserves the whole length before a single byte of the payload is known to exist, so a 32-bit length asks for up to 4 GiB (a 64-bit one for more than any machine has), and the reservation either raises `MemoryError` out of a parser whose failure path was written for malformed input, not for hostile input, or succeeds and holds gigabytes for a few bytes on the wire. Bound `meta_len` against the bytes actually remaining and a maximum the format allows before reading. — quickwit/scripts/inspect_split.py:70
What to do
Each finding names the read that takes the length from the input and the site that spends it, and states that the value is never compared in between. Confirm from the two, then bound the length against the remaining stream before using it.
Other · Code Health — Whether async functions that make a cancellable request accept or pass on an AbortSignal (adoption curve).
Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.
Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.
Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.
Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.
Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.
Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `package.json` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.
`error!` at line 59 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-transport/src/accept.rs:59
`error!` at line 68 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-transport/src/accept.rs:68
`warn!` at line 113 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `warn!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-transport/src/tls.rs:113
`error!` at line 299 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-transport/src/tls.rs:299
`error!` at line 306 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-transport/src/tls.rs:306
`warn!` at line 1190 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `warn!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:1190
`warn!` at line 1203 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `warn!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:1203
`info!` at line 237 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `info!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-serve/src/lib.rs:237
`info!` at line 248 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `info!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-serve/src/lib.rs:248
`error!` at line 529 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-serve/src/lib.rs:529
`error!` at line 534 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-serve/src/lib.rs:534
`error!` at line 547 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-serve/src/lib.rs:547
`error!` at line 550 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-serve/src/lib.rs:550
`debug!` at line 566 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `debug!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-serve/src/lib.rs:566
`info!` at line 1210 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `info!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-serve/src/lib.rs:1210
`info!` at line 1441 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `info!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-serve/src/lib.rs:1441
`error!` at line 44 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-serve/src/metrics_api.rs:44
`info!` at line 358 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `info!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-serve/src/rest.rs:358
`error!` at line 394 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-serve/src/rest.rs:394
`info!` at line 412 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `info!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-serve/src/rest.rs:412
`info!` at line 417 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `info!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-serve/src/rest.rs:417
`info!` at line 421 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `info!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-serve/src/rest.rs:421
`error!` at line 453 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-serve/src/rest.rs:453
`error!` at line 476 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-serve/src/rest.rs:476
`error!` at line 614 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-serve/src/rest.rs:614
`error!` at line 311 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-serve/src/jaeger_api/rest_handler.rs:311
`error!` at line 328 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-serve/src/jaeger_api/rest_handler.rs:328
`warn!` at line 74 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `warn!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-serve/src/index_api/rest_handler.rs:74
`debug!` at line 72 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `debug!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-search/src/cluster_client.rs:72
`debug!` at line 118 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `debug!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-search/src/cluster_client.rs:118
`warn!` at line 1271 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `warn!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-search/src/leaf.rs:1271
`warn!` at line 1287 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `warn!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-search/src/leaf.rs:1287
`info!` at line 217 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `info!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-search/src/search_job_placer.rs:217
`warn!` at line 70 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `warn!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-rest-client/src/lib.rs:70
`warn!` at line 135 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `warn!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-proto/src/error.rs:135
`error!` at line 158 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-proto/src/error.rs:158
`error!` at line 65 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-proto/src/types/mod.rs:65
`info!` at line 768 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `info!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs:768
`info!` at line 936 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `info!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs:936
`info!` at line 1130 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `info!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs:1130
Other · Code Health — Whether strict null checking is enabled and not undermined by heavy `!` assertion — TypeScript's `strictNullChecks` (which `strict` turns on) is what makes `string` exclude `null` and `undefined`, and the postfix `!` is the operator that silences it.
Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.
~0.7 `!` null assertions per 1k TypeScript source lines — 3 assertion(s) across the 4301 source line(s) of the 34 TypeScript file(s) read, which is the only code the operator asserts anything in (a `!` in a `.js` file is not this operator and was not counted, and one in a file whose null checking is off silences nothing). Densest: quickwit/quickwit-ui/src/components/QueryEditor/AggregationEditor.tsx (2), quickwit/quickwit-ui/src/index.tsx (1). Each one tells the compiler to trust the author about null, suppressing the very diagnostic `strictNullChecks` exists to produce. Many are correct: each is a claim the checker could not verify, and it is wrong only where the value can in fact be missing, so review the densest places first.
What to do
The findings name the configuration each number was taken from and, for the assertions, the files that hold them. Turn null checking on where it is off — `"strict": true` in the base tsconfig that the others extend switches `strictNullChecks` on with the rest of the family — and then resolve the assertions rather than adding to them. A `!` on a value the checker could show to be null is a promise the author cannot check from where they are standing, and each one is a `TypeError: Cannot read properties of null` waiting for the path that makes it true; where the value genuinely cannot be null, say something the checker can see instead (narrow it with a test, make the property required, drop the `?`).
Do you agree with this assessment?
WCAG coverage — what static analysis assessed
Statically assessed 13 of 55 WCAG 2.2 Level A/AA success criteria (24%; ≈26% of the 50 WCAG 2.1 AA criteria for EN 301 549). The other 42 require runtime or manual evaluation. Partial signal only (a clean result is necessary, not sufficient; static analysis fully verifies none). This is accessibility readiness, not a conformance claim — a WCAG conformance claim requires manual evaluation (WCAG-EM 1.0).
The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.
Unscored — 3 check(s) recorded observations but carry no score
These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.
P12 CI test-gate honesty — 1 observation(s) recorded · Reported, not scored — this card publishes what the CI gate does with the test inventory rather than grading it. The findings above are its output.
X10 Duplicated predicate — 1 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
X7 Silent fallback defaults — 4 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not included — 60 check(s) not relevant to this codebase
These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.
AC4 Keyboard semantics — No interactive element found in the parsed markup — AC4 not applicable here.
AC5 ARIA correctness — No ARIA usage found in the parsed markup — AC5 not applicable here.
AX1 Captive dependencies — Not applicable: this repository's JavaScript imports no dependency-injection container and defines no container of its own — nothing that both registers and resolves bindings, and nothing that names two lifetimes — so nothing holds one lifetime's instance while handing out another's; this repository's Python imports no dependency-injection container and defines no container of its own — nothing that both registers and resolves bindings, and nothing that names two lifetimes — so nothing holds one lifetime's instance while handing out another's; Rust with no dependency-injection crate has no container to hand one lifetime's instance to another — every value is owned by the code that builds it, and the borrow checker rejects a longer-lived value keeping a borrow of a shorter-lived one; this repository's TypeScript imports no dependency-injection container and defines no container of its own — nothing that both registers and resolves bindings, and nothing that names two lifetimes — so nothing holds one lifetime's instance while handing out another's.
AX2 Stateful singletons — No container singleton was found, so there is no shared instance for concurrent requests to race on. No function in this Python code is served by a threaded web framework (a Flask, Bottle or FastAPI route, a Django or Pyramid view), so no module is shared between request threads. Rust's compiler refuses unsynchronised shared mutation — a value shared across threads must be Sync — so the race this check looks for cannot be written. TypeScript/JavaScript runs each process's requests on one event loop, so no two requests write a shared object at the same instant (interleaving across an await is a different defect).
AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
AX6 Interface segregation — AX6 reached only 2% of this repository's production lines — rust (225,739 lines), python (248 lines) was left unread. Not scored: a score over a minority of the product would be published as the whole of it.
AX7 Slice cohesion — not applicable — not a vertical-slice architecture
AX8 Test isolation — no test/production split to check
AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
AXR1 Runtime accessibility — compose up failed (exit 1 — a container did not start, exited, or never became healthy) — no service selected; runtime evidence skipped This is a statement about this run, not a statement about your application: nothing here says the surface is inaccessible, only that it was never rendered.
C1 Data Protection — No personal data detected in a persisted data model — no PII-named field (email, first_name, date_of_birth, phone, …) or stored credential in a Diesel schema, a SeaORM entity, a Diesel or sqlx row struct, or a SQL CREATE TABLE or ALTER TABLE — and no database or data-store crate (sqlx, Diesel, SeaORM, rusqlite, tokio-postgres, MongoDB, …) in the source either, so this repository keeps no data at rest for these controls to protect.
C3 Audit Trail — No personal data detected in a persisted data model — no PII-named field (email, first_name, date_of_birth, phone, …) or stored credential in a Diesel schema, a SeaORM entity, a Diesel or sqlx row struct, or a SQL CREATE TABLE or ALTER TABLE — and no database or data-store crate (sqlx, Diesel, SeaORM, rusqlite, tokio-postgres, MongoDB, …) in the source either, so this repository keeps no sensitive data whose changes an audit trail would record. If it does (through a store configured outside this repository, for instance), the trail belongs to wherever that data is stored.
C4 Data Retention — No personal data detected in a persisted data model — no PII-named field (email, first_name, date_of_birth, phone, …) or stored credential in a Diesel schema, a SeaORM entity, a Diesel or sqlx row struct, or a SQL CREATE TABLE or ALTER TABLE — and no database or data-store crate (sqlx, Diesel, SeaORM, rusqlite, tokio-postgres, MongoDB, …) in the source either, so this repository keeps no personal data whose lifetime a retention limit would bound.
C5 Data-Subject Rights — No personal data detected in a persisted data model — no PII-named field (email, first_name, date_of_birth, phone, …) or stored credential in a Diesel schema, a SeaORM entity, a Diesel or sqlx row struct, or a SQL CREATE TABLE or ALTER TABLE — and no database or data-store crate (sqlx, Diesel, SeaORM, rusqlite, tokio-postgres, MongoDB, …) in the source either, so this repository keeps no personal data for a data subject to erase, export or consent over.
D11 Test Reliability — Test reliability not scored — polyglot repository, one half's runner produced no measurement
D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
D21 Naming Consistency — D21 withholds its sibling role token rows: 2 candidate(s) found and not reported.
D22 Internal API Consistency — API consistency is measured on C# only; the exposed Rust surface was not measured.
D23 Boundary Type-Coupling — No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ sibling projects each declaring an entity of their own or taking another project's integration events. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
D25 ADR Conformance — no ADRs to check
D27 Navigability — D27 counts a call into the standard library or a dependency as unresolved for this repository's language (.rs), so too few call sites counted as resolved to assess navigability. Not scored: this is a gap in the analyzer, not a verdict about this repository.
D32 Data Compliance (PII/GDPR) — 1 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D44 Platform End-of-Life — Platform end-of-life not assessed — this repository declares no platform this pass reads
D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
D8 Code Coverage — Coverage NOT MEASURED: the JavaScript/TypeScript half could not be measured — the jest suite in quickwit/quickwit-ui/ ran and not one test passed (FAIL src/views/SearchView.test.jsx), so the coverage would describe the failed run, not the code. Coverage is excluded from the score rather than counted as a near-zero. The named suite step is one the repository's maintainers can perform; once it passes, the real number is measured on the next scan.
DM1 Aggregate boundaries — this Rust crate declares no domain aggregate (a struct with private state and its own command methods), so DM1's aggregate-boundary read has no population to be taken over
DM2 Strongly-typed ids — the crate defines newtype typed-ids but declares no domain aggregate that could carry an id — so DM2's adoption ratio has no population to be taken over
DM3 Integration-event coupling — not applicable: no DDD domain layer was detected (no aggregate, entity or value-object structure), so there is no domain model for this card to grade
DM7 Repository granularity — not applicable: no DDD domain layer was detected (no aggregate, entity or value-object structure), so there is no domain model for this card to grade
ED2 Event/command shape — not scored — deciding whether a command has more than one competing handler requires resolving the call graph, and a call made through an inferred or generic receiver has no resolvable owner in the source. Reported as guidance rather than measured
ED5 Idempotency — Not assessed, and this one is on us: 31 command handler(s) or message consumer(s) were found here, but this check does not yet recognise persistence writes in this repository's language. Idempotency was neither confirmed nor ruled out — this is a limit of the analyzer, not a finding about your code.
ES1 Fold determinism — not applicable — the code was read and holds no event-replay fold, so there is nothing for this check to judge
GD1 Unfinished & placeholder code — no source files were read — this check reads C#, F#, JavaScript/TypeScript, Dart, Ruby and Scala, and none was read for this repository's product. That is a limit of the analyzer, not a finding about your code.
IC1 Incompleteness & stubs — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
P9 Domain vs controller coverage — coverage not measured: this check compares the coverage of the analyzer's own test run across the domain and web layers, and that run measured none here — Test coverage (D8) says why
PF2 Allocation hygiene — Not scored: this check counted allocation-aware idioms (Span, pools, stackalloc) per line, which describes what kind of code a repository is rather than whether it has an allocation problem, so it was withdrawn. Nothing here is a finding about your code.
R11 Import Boundaries — No recognizable feature-sliced/layered src layout — boundary rules not applicable.
R5 Dependency Freshness — uses a yarn lockfile — dependency freshness not measured here; JS/npm CVEs are scored in D30 (Dependency Vulnerabilities), which answers every ecosystem
SC1 Supply-chain hygiene — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X12 Unreachable branch — X12 reached only 2% of this repository's production lines — rust (225,739 lines) was left unread. Not scored: a score over a minority of the product would be published as the whole of it.
X13 Undrained process stream — X13 reached only 2% of this repository's production lines — rust (225,739 lines) was left unread. Not scored: a score over a minority of the product would be published as the whole of it.
X16 Unfloored truncation loop — X16 reached only 2% of this repository's production lines — rust (225,739 lines), python (248 lines) was left unread. Not scored: a score over a minority of the product would be published as the whole of it.
X17 Uncapped recursion over a caller-supplied document — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X18 Disposal-pattern correctness — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X19 Unrestored process-global state — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X20 Mistyped argument guard — This check asks whether an argument guard reports an EMPTY value as a NULL one, which needs a language that throws a null-specific argument exception — .NET's ArgumentNullException, the JVM's NullPointerException, Dart's ArgumentError.notNull. This repository contains none of those languages: the ones it is written in have a single exception for a bad argument, so there is no pair of exceptions to confuse and nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
X22 Contradicted release guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X23 Unguarded diagnostic materialisation — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X24 Document value interpolated into markup unescaped — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X25 Inert configuration knob — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X26 Unsynchronised callback handoff — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X27 Collection changed while being enumerated — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X29 Per-element action decided by a fixed element — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X3 Exception handling — X3 reached only 2% of this repository's production lines — rust (225,739 lines) was left unread. Not scored: a score over a minority of the product would be published as the whole of it.
X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
Appendix A — Findings (grouped)
The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.
Orphaned knowledge quickwit/quickwit-serve/src/openapi.rs:1— No living knowledge remains for this large file — its last meaningful change has decayed away, so if it breaks, no one currently understands it. It does carry its own tests, so the behaviour is pinned even though the understanding is gone: schedule a read-through, using those tests as the specification, before the next change lands here.
Orphaned knowledge quickwit/quickwit-indexing/src/source/queue_sources/shared_state.rs:1— No living knowledge remains for this large file — its last meaningful change has decayed away, so if it breaks, no one currently understands it. It does carry its own tests, so the behaviour is pinned even though the understanding is gone: schedule a read-through, using those tests as the specification, before the next change lands here.
Orphaned knowledge quickwit/quickwit-serve/src/jaeger_api/model.rs:1— No living knowledge remains for this large file — its last meaningful change has decayed away, so if it breaks, no one currently understands it. It does carry its own tests, so the behaviour is pinned even though the understanding is gone: schedule a read-through, using those tests as the specification, before the next change lands here.
Orphaned knowledge quickwit/quickwit-indexing/src/source/doc_file_reader.rs:1— No living knowledge remains for this large file — its last meaningful change has decayed away, so if it breaks, no one currently understands it. It does carry its own tests, so the behaviour is pinned even though the understanding is gone: schedule a read-through, using those tests as the specification, before the next change lands here.
<html> without a lang quickwit/dependency-licenses.html:1— The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
<html> without a lang REDACTED:1— The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
AC3 · Page structure· Document without a <title> · ×2
Document without a <title> quickwit/dependency-licenses.html:1— A page with no <title> gives no name in the tab, history or screen-reader page list. Add a descriptive <title> in <head>.
Document without a <title> REDACTED:1— A page with no <title> gives no name in the tab, history or screen-reader page list. Add a descriptive <title> in <head>.
DM5 · Encapsulated state· Mutable field under value identity · ×1
Mutable field under value identity: IndexUid quickwit/quickwit-proto/src/types/index_uid.rs:31— `IndexUid` implements a hand-rolled `Hash`/`PartialEq` (identity semantics) over a `pub` mutable id/hash field — mutating it after the value is placed in a set/map silently corrupts the collection. Make the identity field private + immutable (set once in the constructor).
Unlisted import '@styled-icons/fa-brands' quickwit/quickwit-ui/src/components/TopBar.tsx:27— Imported but not declared in any reachable package.json — installs work only by hoisting accident.
Unlisted import '@styled-icons/feather' quickwit/quickwit-ui/src/components/SideBar.tsx:24— Imported but not declared in any reachable package.json — installs work only by hoisting accident.
Unlisted import '@styled-icons/material-outlined' quickwit/quickwit-ui/src/components/SideBar.tsx:26— Imported but not declared in any reachable package.json — installs work only by hoisting accident.
Unlisted import '@styled-icons/remix-line' quickwit/quickwit-ui/src/components/SideBar.tsx:27— Imported but not declared in any reachable package.json — installs work only by hoisting accident.
TodoComment quickwit/quickwit-ui/src/views/IndexView.tsx:88— // TODO: remove this css with magic number `48px`. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment quickwit/quickwit-ui/src/services/client.ts:45— // TODO: improve validation of request. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment quickwit/quickwit-ui/src/services/client.ts:96— // TODO: restrieve all the splits. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment quickwit/quickwit-ui/src/services/client.ts:147— // TODO: the trim should be done in the backend. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment quickwit/quickwit-ui/src/components/ApiUrlFooter.tsx:39— // TODO show generated aggregation — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment quickwit/quickwit-ui/src/components/QueryEditor/config.ts:47— // TODO: clean language features as I (fmassot) did not dig into it yet. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment quickwit/quickwit-ui/src/components/QueryEditor/AggregationEditor.tsx:46— // TODO add percentiles — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment quickwit/quickwit-storage/tests/google_cloud_storage.rs:82— // TODO: Uncomment storage_test_multi_part_upload when the XML API is — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment quickwit/quickwit-storage/src/error.rs:86— // TODO: This is swallowing the context of the source error. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment quickwit/quickwit-storage/src/file_descriptor_cache.rs:64— /// TODO It would be good to refactor this to enforce this with a bit of a refactoring. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment quickwit/quickwit-storage/src/timeout_and_retry_storage.rs:99— // TODO test avoid aborting timed out requests. #5468
TodoComment quickwit/quickwit-storage/src/opendal_storage/base.rs:44— /// # TODO — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment quickwit/quickwit-storage/src/cache/base_cache.rs:225— // TODO: It is sub-optimal that we might have needlessly evicted items in this — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment quickwit/quickwit-storage/src/cache/quickwit_cache.rs:113— /// TODO fixme — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment quickwit/quickwit-serve/src/lib.rs:1135— // TODO: I'm not sure that's such a good idea. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment quickwit/quickwit-serve/src/rest.rs:589— // TODO: we may want in the future revamp rejections as our usage does not exactly — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment quickwit/quickwit-serve/src/jaeger_api/model.rs:94— /// TODO: use also tags to identify processes. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment quickwit/quickwit-serve/src/jaeger_api/rest_handler.rs:478— // TODO(trinity) i think we have an off by 1 here, imo this should be rounded up — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment quickwit/quickwit-serve/src/index_api/rest_handler.rs:1252— // TODO — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment quickwit/quickwit-serve/src/elasticsearch_api/rest_handler.rs:251— // TODO — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment quickwit/quickwit-jaeger/src/lib.rs:763— // TODO — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment quickwit/quickwit-jaeger/src/lib.rs:769— // TODO — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment quickwit/quickwit-jaeger/src/lib.rs:770— // TODO — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FileTooLong: src/leaf.rs quickwit/quickwit-search/src/leaf.rs— FileTooLong — 1555 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), declaring 37 free functions. The bar is 500 significant lines; this is 1055 over it, 3.11× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: postgres/metastore.rs quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs— FileTooLong — 1535 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 80% of them inside a single declaration: PostgresqlMetastore (5 blocks, 91-2005). The bar is 500 significant lines; this is 1035 over it, 3.07× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: src/root.rs quickwit/quickwit-search/src/root.rs— FileTooLong — 1488 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), declaring 38 free functions. The bar is 500 significant lines; this is 988 over it, 2.98× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: src/lib.rs quickwit/quickwit-serve/src/lib.rs— FileTooLong — 1201 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 701 over it, 2.40× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: src/codegen.rs quickwit/quickwit-codegen/src/codegen.rs— FileTooLong — 986 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 486 over it, 1.97× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: ingest/ingest_controller.rs quickwit/quickwit-control-plane/src/ingest/ingest_controller.rs— FileTooLong — 932 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 70% of them inside a single declaration: IngestController (3 blocks, 299-1363). The bar is 500 significant lines; this is 432 over it, 1.86× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: doc_mapper/mapping_tree.rs quickwit/quickwit-doc-mapper/src/doc_mapper/mapping_tree.rs— FileTooLong — 927 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 427 over it, 1.85× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: object_storage/s3_compatible_storage.rs quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs— FileTooLong — 904 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 71% of them inside a single declaration: S3CompatibleObjectStorage (5 blocks, 97-1164). The bar is 500 significant lines; this is 404 over it, 1.81× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: elasticsearch_api/rest_handler.rs quickwit/quickwit-serve/src/elasticsearch_api/rest_handler.rs— FileTooLong — 895 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), declaring 50 free functions. The bar is 500 significant lines; this is 395 over it, 1.79× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: src/index.rs quickwit/quickwit-cli/src/index.rs— FileTooLong — 891 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 391 over it, 1.78× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: file_backed/mod.rs quickwit/quickwit-metastore/src/metastore/file_backed/mod.rs— FileTooLong — 887 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 89% of them inside a single declaration: FileBackedMetastore (5 blocks, 147-1326). The bar is 500 significant lines; this is 387 over it, 1.77× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: src/collector.rs quickwit/quickwit-search/src/collector.rs— FileTooLong — 855 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 355 over it, 1.71× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: ingest_v2/ingester.rs quickwit/quickwit-ingest/src/ingest_v2/ingester.rs— FileTooLong — 803 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 82% of them inside a single declaration: Ingester (4 blocks, 94-1035). The bar is 500 significant lines; this is 303 over it, 1.61× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: src/lib.rs quickwit/quickwit-jaeger/src/lib.rs— FileTooLong — 794 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 294 over it, 1.59× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: actors/indexing_service.rs quickwit/quickwit-indexing/src/actors/indexing_service.rs— FileTooLong — 785 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 90% of them inside a single declaration: IndexingService (11 blocks, 105-1054). The bar is 500 significant lines; this is 285 over it, 1.57× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: src/tool.rs quickwit/quickwit-cli/src/tool.rs— FileTooLong — 770 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 270 over it, 1.54× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: src/control_plane.rs quickwit/quickwit-control-plane/src/control_plane.rs— FileTooLong — 689 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 81% of them inside a single declaration: ControlPlane (21 blocks, 89-1052). The bar is 500 significant lines; this is 189 over it, 1.38× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: otlp/traces.rs quickwit/quickwit-opentelemetry/src/otlp/traces.rs— FileTooLong — 673 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 173 over it, 1.35× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: metastore/mod.rs quickwit/quickwit-metastore/src/metastore/mod.rs— FileTooLong — 643 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 143 over it, 1.29× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: indexing_scheduler/mod.rs quickwit/quickwit-control-plane/src/indexing_scheduler/mod.rs— FileTooLong — 641 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 141 over it, 1.28× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: node_config/mod.rs quickwit/quickwit-config/src/node_config/mod.rs— FileTooLong — 639 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 139 over it, 1.28× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: scheduling/mod.rs quickwit/quickwit-control-plane/src/indexing_scheduler/scheduling/mod.rs— FileTooLong — 615 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 115 over it, 1.23× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: src/cluster.rs quickwit/quickwit-cluster/src/cluster.rs— FileTooLong — 608 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 108 over it, 1.22× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: doc_mapper/field_mapping_entry.rs quickwit/quickwit-doc-mapper/src/doc_mapper/field_mapping_entry.rs— FileTooLong — 602 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 102 over it, 1.20× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: src/top_k_collector.rs quickwit/quickwit-search/src/top_k_collector.rs— FileTooLong — 583 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 83 over it, 1.17× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FunctionTooLong: quickwit_serve::serve_quickwit quickwit/quickwit-serve/src/lib.rs:571— FunctionTooLong — quickwit_serve::serve_quickwit runs 363 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 263 over it, 3.63× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: AggregationEditor.AggregationKind quickwit/quickwit-ui/src/components/QueryEditor/AggregationEditor.tsx:113— FunctionTooLong — AggregationKind runs 199 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 99 over it, 1.99× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: quickwit_serve::grpc::start_grpc_server quickwit/quickwit-serve/src/grpc.rs:46— FunctionTooLong — quickwit_serve::grpc::start_grpc_server runs 179 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 79 over it, 1.79× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: quickwit_search::root::log_root_resource_stats quickwit/quickwit-search/src/root.rs:762— FunctionTooLong — quickwit_search::root::log_root_resource_stats runs 141 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 41 over it, 1.41× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: quickwit_serve::elasticsearch_api::bulk_v2::make_elastic_bulk_response_v2 quickwit/quickwit-serve/src/elasticsearch_api/bulk_v2.rs:168— FunctionTooLong — quickwit_serve::elasticsearch_api::bulk_v2::make_elastic_bulk_response_v2 runs 133 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 33 over it, 1.33× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: quickwit_cli::index::build_index_command quickwit/quickwit-cli/src/index.rs:50— FunctionTooLong — quickwit_cli::index::build_index_command runs 131 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 31 over it, 1.31× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: quickwit_codegen::codegen::generate_client quickwit/quickwit-codegen/src/codegen.rs:598— FunctionTooLong — quickwit_codegen::codegen::generate_client runs 115 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 15 over it, 1.15× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: SearchView.SearchView quickwit/quickwit-ui/src/views/SearchView.tsx:63— FunctionTooLong — SearchView runs 111 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 11 over it, 1.11× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: quickwit_cli::tool::local_ingest_docs_cli quickwit/quickwit-cli/src/tool.rs:402— FunctionTooLong — quickwit_cli::tool::local_ingest_docs_cli runs 110 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 10 over it, 1.10× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: quickwit_doc_mapper::doc_mapper::mapping_tree::build_mapping_from_field_type quickwit/quickwit-doc-mapper/src/doc_mapper/mapping_tree.rs:1246— FunctionTooLong — quickwit_doc_mapper::doc_mapper::mapping_tree::build_mapping_from_field_type runs 110 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 10 over it, 1.10× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: quickwit_jaeger::build_search_query quickwit/quickwit-jaeger/src/lib.rs:560— FunctionTooLong — quickwit_jaeger::build_search_query runs 105 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 5 over it, 1.05× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: TimeRangeSelect.TimeRangeSelect quickwit/quickwit-ui/src/components/TimeRangeSelect.tsx:64— FunctionTooLong — TimeRangeSelect runs 102 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 2 over it, 1.02× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: quickwit_cli::source::build_source_command quickwit/quickwit-cli/src/source.rs:33— FunctionTooLong — quickwit_cli::source::build_source_command runs 101 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 1 over it, 1.01× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: IndexView.IndexView quickwit/quickwit-ui/src/views/IndexView.tsx:52— FunctionTooLong — IndexView runs 101 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 1 over it, 1.01× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
D30 · Dependency Vulnerabilities· Medium advisory (unsound) · ×12
Change coupling: mod.rs ↔ mod.rs quickwit/quickwit-proto/src/control_plane/mod.rs:1— `quickwit/quickwit-proto/src/control_plane/mod.rs` and `quickwit/quickwit-proto/src/ingest/mod.rs` change together 80% of the time (8 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `70bfc47d` Add `code` label to gRPC metrics (#6685); `9b3873bd` Add gRPC reflection service (#5697); `d4ad40db` Removing the last extern crate macro use old idiom (#5546) — run `git show` on any of them.
Change coupling: tests.rs ↔ lib.rs quickwit/quickwit-control-plane/src/tests.rs:1— `quickwit/quickwit-control-plane/src/tests.rs` and `quickwit/quickwit-serve/src/lib.rs` change together 67% of the time (10 of the 15 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 10 shared commits counted here, the most recent 3 are `55840e41` fix(control-plane): Avoid spawning a new control plan loop on every s…; `f3880d52` bugfix: dont schedule indexing tasks on retiring indexers (#6427); `b4bf3c42` Exit when chitchat server fails (#5819) — run `git show` on any of them.
Change coupling: lib.rs ↔ mod.rs quickwit/quickwit-search/src/lib.rs:1— `quickwit/quickwit-search/src/lib.rs` and `quickwit/quickwit-serve/src/search_api/mod.rs` change together 67% of the time (8 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `4c6a293f` Remove search stream endpoint (#5886); `ddcb138f` add api endpoint to get query ast (#5212); `ba382524` Add local search CLI. (#3564) — run `git show` on any of them.
Change coupling: leaf_cache.rs ↔ root.rs quickwit/quickwit-search/src/leaf_cache.rs:1— `quickwit/quickwit-search/src/leaf_cache.rs` and `quickwit/quickwit-search/src/root.rs` change together 62% of the time (8 of the 13 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency between them. They sit in the same directory, but in this ecosystem each file is its own module — a sibling reference still needs an import — so the missing import edge is real: the coupling runs through shared behaviour, not a declared dependency. If they duplicate structure, extract the common part into one unit; otherwise the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `55b58006` Add query source to search and resource-usage logs (#6983); `7062b13d` schedule leaf searches by (priority, remaining_splits) lexicographica…; `0bb78090` Forbid usage of some complex Option:: methods. (#5754) — run `git show` on any of them.
Change coupling: azure_blob_storage.rs ↔ s3_compatible_storage.rs quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:1— `quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs` and `quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs` change together 58% of the time (11 of the 19 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency between them. They sit in the same directory, but in this ecosystem each file is its own module — a sibling reference still needs an import — so the missing import edge is real: the coupling runs through shared behaviour, not a declared dependency. If they duplicate structure, extract the common part into one unit; otherwise the coupling is hidden and worth breaking. You can check this without leaving the row: of the 11 shared commits counted here, the most recent 3 are `be1054d6` Make `Storage::get_slice` zero copy for single-segment bodies (#6336); `4d0ffc32` Fix build warning (#5828); `ea35a535` Add in flight get slice metric (#5726) — run `git show` on any of them.
Change coupling: control_plane.rs ↔ shard_table.rs quickwit/quickwit-control-plane/src/control_plane.rs:1— `quickwit/quickwit-control-plane/src/control_plane.rs` and `quickwit/quickwit-control-plane/src/model/shard_table.rs` change together 57% of the time (13 of the 23 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 13 shared commits counted here, the most recent 3 are `0358ca36` Improve control plane logging (#6003); `f10654a2` Faster shard scaling (#5679); `69f700aa` Removing bias from shard allocation. (#5233) — run `git show` on any of them.
Change coupling: bulk.rs ↔ rest_handler.rs quickwit/quickwit-serve/src/elasticsearch_api/bulk.rs:1— `quickwit/quickwit-serve/src/elasticsearch_api/bulk.rs` and `quickwit/quickwit-serve/src/ingest_api/rest_handler.rs` change together 56% of the time (10 of the 18 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 10 shared commits counted here, the most recent 3 are `a35c3b24` Limit request body sizes on ingest endpoints (#6912); `4c2c51ea` Reuse HTTP request buffers for native ingest (#6869); `072d0fe7` Detailed ingest response (#5635) — run `git show` on any of them.
Change coupling: control_plane.rs ↔ shards.rs quickwit/quickwit-control-plane/src/control_plane.rs:1— `quickwit/quickwit-control-plane/src/control_plane.rs` and `quickwit/quickwit-metastore/src/metastore/file_backed/file_backed_index/shards.rs` change together 55% of the time (6 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `f3dd8f27` Debounce shard pruning request (#5374); `948329b3` Add update timestamp to Shard model (#5332); `80351aeb` Replace handwritten getters and use macro instead — run `git show` on any of them.
Change coupling: root.rs ↔ mod.rs quickwit/quickwit-search/src/root.rs:1— `quickwit/quickwit-search/src/root.rs` and `quickwit/quickwit-serve/src/search_api/mod.rs` change together 50% of the time (6 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `ddcb138f` add api endpoint to get query ast (#5212); `2d9b731d` Code simplification (#3568); `accb9315` Bypass gRPC stack when the search service is local (#3348) — run `git show` on any of them.
Change coupling: shard_positions.rs ↔ ingester.rs quickwit/quickwit-indexing/src/models/shard_positions.rs:1— `quickwit/quickwit-indexing/src/models/shard_positions.rs` and `quickwit/quickwit-ingest/src/ingest_v2/ingester.rs` change together 50% of the time (5 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 5 shared commits counted here, the most recent 3 are `cb5cbce9` Add more logs (#4648); `9c82b7aa` Adding more logs to diagnostic shard truncation problems. (#4635); `8e1f0bef` Initializing the shard positions actor with the existing cluster stat… — run `git show` on any of them.
Change coupling: search_response_rest.rs ↔ rest.rs quickwit/quickwit-search/src/search_response_rest.rs:1— `quickwit/quickwit-search/src/search_response_rest.rs` and `quickwit/quickwit-serve/src/rest.rs` change together 50% of the time (5 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 5 shared commits counted here, the most recent 3 are `ddcb138f` add api endpoint to get query ast (#5212); `c9f611e2` accept post requests, plug aggregation (#1142) (at that commit the files were still `quickwit-search/src/search_response_rest.rs` and `quickwit-serve/src/rest.rs`); `1313ab50` Add errors attributes to rest search response. (#974) (at that commit the files were still `quickwit-search/src/search_response_rest.rs` and `quickwit-serve/src/rest.rs`) — run `git show` on any of them.
MethodTooLong: Ingester.persist_inner quickwit/quickwit-ingest/src/ingest_v2/ingester.rs:387— MethodTooLong — persist_inner runs 231 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 131 over it, 2.31× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: PostgresqlMetastore.publish_splits quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs:777— MethodTooLong — publish_splits runs 140 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 40 over it, 1.40× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: NodeConfigBuilder.build_and_validate quickwit/quickwit-config/src/node_config/serialize.rs:255— MethodTooLong — build_and_validate runs 132 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 32 over it, 1.32× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: RangeQuery.build_tantivy_ast_impl quickwit/quickwit-query/src/query_ast/range_query.rs:108— MethodTooLong — build_tantivy_ast_impl runs 131 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 31 over it, 1.31× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: IndexingPipeline.spawn_pipeline quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs:317— MethodTooLong — spawn_pipeline runs 130 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 30 over it, 1.30× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: DocMapper.try_from quickwit/quickwit-doc-mapper/src/doc_mapper/doc_mapper_impl.rs:161— MethodTooLong — try_from runs 104 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 4 over it, 1.04× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Uploader.handle quickwit/quickwit-indexing/src/actors/uploader.rs:277— MethodTooLong — handle runs 104 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 4 over it, 1.04× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: JaegerService.stream_spans quickwit/quickwit-jaeger/src/lib.rs:302— MethodTooLong — stream_spans runs 102 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 2 over it, 1.02× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: TantivyBoolQuery.simplify quickwit/quickwit-query/src/query_ast/tantivy_query_ast.rs:179— MethodTooLong — simplify runs 102 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 2 over it, 1.02× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: FetchStreamTask.run quickwit/quickwit-ingest/src/ingest_v2/fetch.rs:106— MethodTooLong — run runs 101 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 1 over it, 1.01× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
Duplicated block (8 lines × 2) quickwit/quickwit-cli/src/index.rs:434— quickwit/quickwit-cli/src/index.rs:434-441 | quickwit/quickwit-cli/src/tool.rs:305-312 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (8 lines × 2) quickwit/quickwit-cli/src/source.rs:314— quickwit/quickwit-cli/src/source.rs:314-321 | quickwit/quickwit-cli/src/source.rs:357-364 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) quickwit/quickwit-query/src/query_ast/visitor.rs:175— quickwit/quickwit-query/src/query_ast/visitor.rs:175-182 | quickwit/quickwit-search/src/leaf.rs:1307-1314 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-query/src/query_ast/visitor.rs:175` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) quickwit/quickwit-serve/src/otlp_api/rest_handler.rs:250— quickwit/quickwit-serve/src/otlp_api/rest_handler.rs:250-257 | quickwit/quickwit-serve/src/otlp_api/rest_handler.rs:272-279 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) quickwit/quickwit-cli/src/source.rs:377— quickwit/quickwit-cli/src/source.rs:377-384 | quickwit/quickwit-cli/src/source.rs:394-401 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `args` to `CreateSourceArgs` in one and `UpdateSourceArgs` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (8 lines × 2) quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs:379— quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs:379-386 | quickwit/quickwit-indexing/src/actors/merge_pipeline.rs:294-301 — before extracting anything, compare `quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs` and `quickwit/quickwit-indexing/src/actors/merge_pipeline.rs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 57 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs:379` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs:377` calls `set_backpressure_micros_counter` and `quickwit/quickwit-indexing/src/actors/merge_pipeline.rs:292` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (8 lines × 2) quickwit/quickwit-cli/src/tool.rs:279— quickwit/quickwit-cli/src/tool.rs:279-286 | quickwit/quickwit-cli/src/tool.rs:329-336 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) quickwit/quickwit-serve/src/lib.rs:236— quickwit/quickwit-serve/src/lib.rs:236-243 | quickwit/quickwit-serve/src/lib.rs:247-254 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) quickwit/quickwit-common/src/runtimes/mod.rs:166— quickwit/quickwit-common/src/runtimes/mod.rs:166-173 | quickwit/quickwit-common/src/runtimes/mod.rs:180-187 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-common/src/runtimes/mod.rs:166` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:589— quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:589-596 | quickwit/quickwit-storage/src/opendal_storage/google_cloud_storage.rs:180-187 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:589` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) quickwit/quickwit-config/src/metastore_config.rs:59— quickwit/quickwit-config/src/metastore_config.rs:59-67 | quickwit/quickwit-config/src/storage_config.rs:112-120 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-config/src/metastore_config.rs:59` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) quickwit/quickwit-ingest/src/ingest_v2/ingester.rs:525— quickwit/quickwit-ingest/src/ingest_v2/ingester.rs:525-533 | quickwit/quickwit-ingest/src/ingest_v2/ingester.rs:559-567 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) quickwit/quickwit-ingest/src/ingest_v2/mrecordlog_utils.rs:64— quickwit/quickwit-ingest/src/ingest_v2/mrecordlog_utils.rs:64-72 | quickwit/quickwit-ingest/src/ingest_v2/mrecordlog_utils.rs:78-86 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) quickwit/quickwit-proto/src/search/span_id.rs:52— quickwit/quickwit-proto/src/search/span_id.rs:52-60 | quickwit/quickwit-proto/src/search/trace_id.rs:60-68 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-proto/src/search/span_id.rs:52` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (9 lines × 2) quickwit/quickwit-query/src/query_ast/tantivy_query_ast.rs:205— quickwit/quickwit-query/src/query_ast/tantivy_query_ast.rs:205-213 | quickwit/quickwit-query/src/query_ast/tantivy_query_ast.rs:224-232 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-query/src/query_ast/tantivy_query_ast.rs:205` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) quickwit/quickwit-search/src/collector.rs:1100— quickwit/quickwit-search/src/collector.rs:1100-1108 | quickwit/quickwit-search/src/collector.rs:1137-1147 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-search/src/collector.rs:1100` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note first that the copies are not typed on the same thing: the declarations holding them bind `other` to `&SegmentPartialHitSortingKey` in one and `&PartialHitSortingKey` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (9 lines × 2) quickwit/quickwit-serve/src/lib.rs:1204— quickwit/quickwit-serve/src/lib.rs:1204-1212 | quickwit/quickwit-serve/src/lib.rs:1435-1443 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-serve/src/lib.rs:1204` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) quickwit/quickwit-opentelemetry/src/otlp/logs.rs:211— quickwit/quickwit-opentelemetry/src/otlp/logs.rs:211-219 | quickwit/quickwit-opentelemetry/src/otlp/traces.rs:669-678 — before extracting anything, compare `quickwit/quickwit-opentelemetry/src/otlp/logs.rs` and `quickwit/quickwit-opentelemetry/src/otlp/traces.rs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 45 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (9 lines × 2) quickwit/quickwit-proto/src/control_plane/mod.rs:62— quickwit/quickwit-proto/src/control_plane/mod.rs:62-73 | quickwit/quickwit-proto/src/indexing/mod.rs:63-71 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-proto/src/control_plane/mod.rs:62` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
ClassTooLong: PostgresqlMetastore quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs:91— ClassTooLong — 1221 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 3 methods, 5 blocks, lines 91-2005. The bar is 400 significant lines; this is 821 over it, 3.05× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: FileBackedMetastore quickwit/quickwit-metastore/src/metastore/file_backed/mod.rs:147— ClassTooLong — 793 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 11 methods, 5 blocks, lines 147-1326. The bar is 400 significant lines; this is 393 over it, 1.98× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: IndexingService quickwit/quickwit-indexing/src/actors/indexing_service.rs:105— ClassTooLong — 707 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 19 methods, 11 blocks, lines 105-1054. The bar is 400 significant lines; this is 307 over it, 1.77× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: Ingester quickwit/quickwit-ingest/src/ingest_v2/ingester.rs:94— ClassTooLong — 660 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 15 methods, 4 blocks, lines 94-1035. The bar is 400 significant lines; this is 260 over it, 1.65× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: IngestController quickwit/quickwit-control-plane/src/ingest/ingest_controller.rs:299— ClassTooLong — 648 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 17 methods, 3 blocks, lines 299-1363. The bar is 400 significant lines; this is 248 over it, 1.62× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: S3CompatibleObjectStorage quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:97— ClassTooLong — 643 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 20 methods, 5 blocks, lines 97-1164. The bar is 400 significant lines; this is 243 over it, 1.61× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: ControlPlane quickwit/quickwit-control-plane/src/control_plane.rs:89— ClassTooLong — 558 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 5 methods, 21 blocks, lines 89-1052. The bar is 400 significant lines; this is 158 over it, 1.40× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: FileBackedIndex quickwit/quickwit-metastore/src/metastore/file_backed/file_backed_index/mod.rs:54— ClassTooLong — 425 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 32 methods, 4 blocks, lines 54-698. The bar is 400 significant lines; this is 25 over it, 1.06× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D4 · Code Duplication· Edited copy of a member (17 corresponding lines) · ×8
Edited copy of a member (17 corresponding lines) quickwit/quickwit-serve/src/otlp_api/rest_handler.rs:248— quickwit/quickwit-serve/src/otlp_api/rest_handler.rs:248-264 | quickwit/quickwit-serve/src/otlp_api/rest_handler.rs:270-286 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (17 corresponding lines) quickwit/quickwit-metrics/src/counter.rs:202— quickwit/quickwit-metrics/src/counter.rs:202-218 | quickwit/quickwit-metrics/src/gauge.rs:223-239 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (17 corresponding lines) quickwit/quickwit-common/src/uri.rs:170— quickwit/quickwit-common/src/uri.rs:170-192 | quickwit/quickwit-common/src/uri.rs:199-215 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (17 corresponding lines) quickwit/quickwit-codegen/src/codegen.rs:567— quickwit/quickwit-codegen/src/codegen.rs:567-584 | quickwit/quickwit-codegen/src/codegen.rs:869-885 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (17 corresponding lines) quickwit/quickwit-doc-mapper/src/doc_mapper/mapping_tree.rs:982— quickwit/quickwit-doc-mapper/src/doc_mapper/mapping_tree.rs:982-998 | quickwit/quickwit-doc-mapper/src/doc_mapper/mapping_tree.rs:1007-1023 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (17 corresponding lines) quickwit/quickwit-rest-client/src/rest_client.rs:410— quickwit/quickwit-rest-client/src/rest_client.rs:410-426 | quickwit/quickwit-rest-client/src/rest_client.rs:590-606 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (17 corresponding lines) quickwit/quickwit-config/src/metastore_config.rs:219— quickwit/quickwit-config/src/metastore_config.rs:219-235 | quickwit/quickwit-config/src/metastore_config.rs:237-253 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (17 corresponding lines) quickwit/quickwit-ingest/src/ingest_v2/mod.rs:106— quickwit/quickwit-ingest/src/ingest_v2/mod.rs:106-123 | quickwit/quickwit-ingest/src/ingest_v2/mod.rs:129-145 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (10 corresponding lines) · ×8
Edited copy of a member (10 corresponding lines) quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:945— quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:945-954 | quickwit/quickwit-storage/src/opendal_storage/base.rs:210-223 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (10 corresponding lines) quickwit/quickwit-common/src/stream_utils.rs:80— quickwit/quickwit-common/src/stream_utils.rs:80-89 | quickwit/quickwit-common/src/stream_utils.rs:96-105 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (10 corresponding lines) quickwit/quickwit-search/src/client.rs:206— quickwit/quickwit-search/src/client.rs:206-215 | quickwit/quickwit-search/src/client.rs:221-230 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (10 corresponding lines) quickwit/quickwit-serve/src/template_api/rest_handler.rs:60— quickwit/quickwit-serve/src/template_api/rest_handler.rs:60-69 | quickwit/quickwit-serve/src/template_api/rest_handler.rs:144-153 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (10 corresponding lines) quickwit/quickwit-compaction/src/planner/compaction_state.rs:136— quickwit/quickwit-compaction/src/planner/compaction_state.rs:136-145 | quickwit/quickwit-compaction/src/planner/compaction_state.rs:147-157 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (10 corresponding lines) quickwit/quickwit-indexing/src/models/raw_doc_batch.rs:36— quickwit/quickwit-indexing/src/models/raw_doc_batch.rs:36-46 | quickwit/quickwit-indexing/src/models/processed_doc.rs:57-66 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (10 corresponding lines) quickwit/quickwit-serve/src/index_api/source_resource.rs:283— quickwit/quickwit-serve/src/index_api/source_resource.rs:283-292 | quickwit/quickwit-serve/src/index_api/split_resource.rs:198-207 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (10 corresponding lines) quickwit/quickwit-serve/src/index_api/split_resource.rs:141— quickwit/quickwit-serve/src/index_api/split_resource.rs:141-150 | quickwit/quickwit-serve/src/index_api/index_resource.rs:442-451 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
FixmeComment quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:374— // FIXME: This may not work on Windows. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:389— // FIXME: This may not work on Windows. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment quickwit/quickwit-storage/src/cache/mod.rs:38— /// FIXME The current approach is quite horrible in that: — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs:319— // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment quickwit/quickwit-control-plane/src/indexing_scheduler/mod.rs:308— // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs:661— // FIXME: This is not idempotent. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment quickwit/quickwit-index-management/src/index.rs:445— // FIXME: return an error. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
quickwit_control_plane::indexing_scheduler::scheduling::convert_scheduling_solution_to_physical_plan (cognitive 32) quickwit/quickwit-control-plane/src/indexing_scheduler/scheduling/mod.rs:393— quickwit_control_plane::indexing_scheduler::scheduling::convert_scheduling_solution_to_physical_plan has cognitive complexity 32 (threshold 15). Drivers by points: if/else 6 (20 pts), loops 6 (11 pts), boolean chains 1 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
quickwit_control_plane::indexing_scheduler::format_indexing_task_map (cognitive 26) quickwit/quickwit-control-plane/src/indexing_scheduler/mod.rs:796— quickwit_control_plane::indexing_scheduler::format_indexing_task_map has cognitive complexity 26 (threshold 15). Drivers by points: if/else 9 (22 pts), loops 2 (4 pts) (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
quickwit_control_plane::indexing_scheduler::scheduling::convert_scheduling_solution_to_physical_plan_single_node_single_source (cognitive 26) quickwit/quickwit-control-plane/src/indexing_scheduler/scheduling/mod.rs:243— quickwit_control_plane::indexing_scheduler::scheduling::convert_scheduling_solution_to_physical_plan_single_node_single_source has cognitive complexity 26 (threshold 15). Drivers by points: if/else 9 (21 pts), loops 2 (4 pts), match/switch 1 (nesting depth added 14). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
quickwit_control_plane::indexing_scheduler::scheduling::convert_to_simplified_problem (cognitive 26) quickwit/quickwit-control-plane/src/indexing_scheduler/scheduling/mod.rs:918— quickwit_control_plane::indexing_scheduler::scheduling::convert_to_simplified_problem has cognitive complexity 26 (threshold 15). Drivers by points: if/else 6 (15 pts), loops 4 (11 pts) (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
quickwit_control_plane::indexing_scheduler::scheduling::convert_physical_plan_to_solution (cognitive 21) quickwit/quickwit-control-plane/src/indexing_scheduler/scheduling/mod.rs:135— quickwit_control_plane::indexing_scheduler::scheduling::convert_physical_plan_to_solution has cognitive complexity 21 (threshold 15). Drivers by points: match/switch 2 (11 pts), if/else 2 (6 pts), loops 2 (4 pts) (nesting depth added 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
quickwit_control_plane::indexing_scheduler::scheduling::scheduling_logic::remove_extraneous_shards (cognitive 19) quickwit/quickwit-control-plane/src/indexing_scheduler/scheduling/scheduling_logic.rs:149— quickwit_control_plane::indexing_scheduler::scheduling::scheduling_logic::remove_extraneous_shards has cognitive complexity 19 (threshold 15). Drivers by points: if/else 5 (10 pts), loops 6 (9 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
quickwit_control_plane::indexing_scheduler::scheduling::optimization::arrange_shards_in_home_zones (cognitive 18) quickwit/quickwit-control-plane/src/indexing_scheduler/scheduling/optimization.rs:290— quickwit_control_plane::indexing_scheduler::scheduling::optimization::arrange_shards_in_home_zones has cognitive complexity 18 (threshold 15). Drivers by points: if/else 5 (9 pts), loops 6 (9 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Duplicated block (11 lines × 2) quickwit/quickwit-common/src/thread_pool/simple.rs:37— quickwit/quickwit-common/src/thread_pool/simple.rs:37-47 | quickwit/quickwit-common/src/thread_pool/with_priority.rs:193-203 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `quickwit/quickwit-common/src/thread_pool/with_priority.rs:204` calls `current_num_threads` and `quickwit/quickwit-common/src/thread_pool/simple.rs:48` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (11 lines × 2) quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs:513— quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs:513-523 | quickwit/quickwit-indexing/src/actors/merge_pipeline.rs:530-540 — before extracting anything, compare `quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs` and `quickwit/quickwit-indexing/src/actors/merge_pipeline.rs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 57 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs:513` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `quickwit/quickwit-indexing/src/actors/merge_pipeline.rs:528` calls `Ok` and `quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs:512` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (11 lines × 2) quickwit/quickwit-proto/src/types/position.rs:267— quickwit/quickwit-proto/src/types/position.rs:267-277 | quickwit/quickwit-proto/src/types/shard_id.rs:98-108 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-proto/src/types/position.rs:267` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) quickwit/quickwit-query/src/elastic_query_dsl/visitor.rs:46— quickwit/quickwit-query/src/elastic_query_dsl/visitor.rs:46-56 | quickwit/quickwit-query/src/query_ast/visitor.rs:51-61 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (11 lines × 2) quickwit/quickwit-opentelemetry/src/otlp/logs.rs:321— quickwit/quickwit-opentelemetry/src/otlp/logs.rs:321-331 | quickwit/quickwit-opentelemetry/src/otlp/traces.rs:783-793 — before extracting anything, compare `quickwit/quickwit-opentelemetry/src/otlp/logs.rs` and `quickwit/quickwit-opentelemetry/src/otlp/traces.rs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 45 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-opentelemetry/src/otlp/logs.rs:321` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `request` to `ExportLogsServiceRequest` in one and `ExportTraceServiceRequest` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (11 lines × 2) quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:518— quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:518-528 | quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:1131-1141 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:518` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) quickwit/quickwit-macros/src/lib.rs:178— quickwit/quickwit-macros/src/lib.rs:178-188 | quickwit/quickwit-macros/src/lib.rs:196-206 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-macros/src/lib.rs:178` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 2) quickwit/quickwit-metrics/src/counter.rs:204— quickwit/quickwit-metrics/src/counter.rs:204-208 | quickwit/quickwit-metrics/src/gauge.rs:225-229 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-metrics/src/counter.rs:204` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 2) quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs:142— quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs:142-146 | quickwit/quickwit-indexing/src/actors/merge_pipeline.rs:131-135 — before extracting anything, compare `quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs` and `quickwit/quickwit-indexing/src/actors/merge_pipeline.rs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 57 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (5 lines × 2) quickwit/quickwit-proto/src/types/doc_uid.rs:60— quickwit/quickwit-proto/src/types/doc_uid.rs:60-64 | quickwit/quickwit-proto/src/types/pipeline_uid.rs:71-75 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (5 lines × 2) quickwit/quickwit-opentelemetry/src/otlp/logs.rs:522— quickwit/quickwit-opentelemetry/src/otlp/logs.rs:522-526 | quickwit/quickwit-opentelemetry/src/otlp/traces.rs:862-866 — before extracting anything, compare `quickwit/quickwit-opentelemetry/src/otlp/logs.rs` and `quickwit/quickwit-opentelemetry/src/otlp/traces.rs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 45 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (5 lines × 2) quickwit/quickwit-opentelemetry/src/otlp/logs.rs:528— quickwit/quickwit-opentelemetry/src/otlp/logs.rs:528-532 | quickwit/quickwit-opentelemetry/src/otlp/traces.rs:870-874 — before extracting anything, compare `quickwit/quickwit-opentelemetry/src/otlp/logs.rs` and `quickwit/quickwit-opentelemetry/src/otlp/traces.rs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 45 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-opentelemetry/src/otlp/traces.rs:870` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 2) quickwit/quickwit-cli/src/tool.rs:404— quickwit/quickwit-cli/src/tool.rs:404-409 | quickwit/quickwit-cli/src/tool.rs:582-586 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `args` to `LocalIngestDocsArgs` in one and `MergeArgs` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (5 lines × 2) quickwit/quickwit-ingest/src/ingest_v2/broadcast/local_shards.rs:81— quickwit/quickwit-ingest/src/ingest_v2/broadcast/local_shards.rs:81-85 | quickwit/quickwit-ingest/src/ingest_v2/broadcast/local_shards.rs:88-92 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
quickwit_serve::serve_quickwit (cognitive 52) quickwit/quickwit-serve/src/lib.rs:571— quickwit_serve::serve_quickwit has cognitive complexity 52 (threshold 15). Drivers by points: if/else 37 (41 pts), boolean chains 6, match/switch 1 (3 pts), loops 1 (2 pts) (nesting depth added 7). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
quickwit_serve::grpc::start_grpc_server (cognitive 35) quickwit/quickwit-serve/src/grpc.rs:46— quickwit_serve::grpc::start_grpc_server has cognitive complexity 35 (threshold 15). Drivers by points: if/else 32 (35 pts) (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
quickwit_serve::mcp_api::protocol::handle (cognitive 31) quickwit/quickwit-serve/src/mcp_api/protocol.rs:35— quickwit_serve::mcp_api::protocol::handle has cognitive complexity 31 (threshold 15). Drivers by points: if/else 13 (15 pts), boolean chains 13, match/switch 3 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
quickwit_serve::elasticsearch_api::rest_handler::filter_source (cognitive 26) quickwit/quickwit-serve/src/elasticsearch_api/rest_handler.rs:848— quickwit_serve::elasticsearch_api::rest_handler::filter_source has cognitive complexity 26 (threshold 15). Drivers by points: if/else 10 (19 pts), loops 3 (5 pts), match/switch 1 (2 pts) (nesting depth added 12). Most of this is not in the body itself: 4 of the 26 points are its own statements and the rest belongs to 2 function items inside it that branch (remove_path, retain_includes). Those helpers are already separate functions, so extracting the branching again is not available. To reduce it, move them out of the body to the enclosing scope, where each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
quickwit_serve::rest::get_status_with_error (cognitive 19) quickwit/quickwit-serve/src/rest.rs:629— quickwit_serve::rest::get_status_with_error has cognitive complexity 19 (threshold 15). Drivers by points: if/else 19. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
quickwit_serve::developer_api::debug::get_node_debug_infos (cognitive 17) quickwit/quickwit-serve/src/developer_api/debug.rs:64— quickwit_serve::developer_api::debug::get_node_debug_infos has cognitive complexity 17 (threshold 15). Drivers by points: match/switch 4 (9 pts), if/else 5 (6 pts), loops 2 (nesting depth added 6). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D30 · Dependency Vulnerabilities· Medium advisory (unmaintained) · ×6
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
D4 · Code Duplication· Edited copy of a member (11 corresponding lines) · ×6
Edited copy of a member (11 corresponding lines) quickwit/quickwit-common/src/fs.rs:22— quickwit/quickwit-common/src/fs.rs:22-32 | quickwit/quickwit-indexing/src/split_store/indexing_split_cache.rs:75-88 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (11 corresponding lines) quickwit/quickwit-search/src/leaf.rs:410— quickwit/quickwit-search/src/leaf.rs:410-423 | quickwit/quickwit-search/src/leaf.rs:426-436 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (11 corresponding lines) quickwit/quickwit-storage/src/bundle_storage.rs:510— quickwit/quickwit-storage/src/bundle_storage.rs:510-520 | quickwit/quickwit-storage/src/bundle_storage.rs:530-541 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (11 corresponding lines) quickwit/quickwit-indexing/src/source/gcp_pubsub_source.rs:222— quickwit/quickwit-indexing/src/source/gcp_pubsub_source.rs:222-232 | quickwit/quickwit-indexing/src/source/pulsar_source.rs:281-292 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (11 corresponding lines) quickwit/quickwit-metastore/src/metastore/file_backed/mod.rs:733— quickwit/quickwit-metastore/src/metastore/file_backed/mod.rs:733-743 | quickwit/quickwit-metastore/src/metastore/file_backed/mod.rs:746-756 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (11 corresponding lines) quickwit/quickwit-ingest/src/ingest_v2/broadcast/capacity_score.rs:86— quickwit/quickwit-ingest/src/ingest_v2/broadcast/capacity_score.rs:86-96 | quickwit/quickwit-ingest/src/ingest_v2/broadcast/local_shards.rs:338-350 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (7 corresponding lines) · ×6
Edited copy of a member (7 corresponding lines) quickwit/quickwit-doc-mapper/src/doc_mapper/doc_mapper_impl.rs:472— quickwit/quickwit-doc-mapper/src/doc_mapper/doc_mapper_impl.rs:472-480 | quickwit/quickwit-doc-mapper/src/doc_mapper/doc_mapper_impl.rs:486-492 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (7 corresponding lines) quickwit/quickwit-search/src/top_k_collector.rs:459— quickwit/quickwit-search/src/top_k_collector.rs:459-465 | quickwit/quickwit-search/src/collector.rs:408-414 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (7 corresponding lines) quickwit/quickwit-directories/src/caching_directory.rs:124— quickwit/quickwit-directories/src/caching_directory.rs:124-131 | quickwit/quickwit-directories/src/bundle_directory.rs:192-198 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (7 corresponding lines) quickwit/quickwit-indexing/src/source/kafka_source.rs:223— quickwit/quickwit-indexing/src/source/kafka_source.rs:223-230 | quickwit/quickwit-indexing/src/source/kinesis/kinesis_source.rs:99-105 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (7 corresponding lines) quickwit/quickwit-indexing/src/models/processed_doc.rs:70— quickwit/quickwit-indexing/src/models/processed_doc.rs:70-76 | quickwit/quickwit-indexing/src/models/raw_doc_batch.rs:57-64 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (7 corresponding lines) quickwit/quickwit-serve/src/developer_api/debug.rs:56— quickwit/quickwit-serve/src/developer_api/debug.rs:56-62 | quickwit/quickwit-serve/src/node_info_handler.rs:43-49 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (8 corresponding lines) · ×6
Edited copy of a member (8 corresponding lines) quickwit/quickwit-common/src/tower/metrics.rs:177— quickwit/quickwit-common/src/tower/metrics.rs:177-184 | quickwit/quickwit-common/src/tower/metrics.rs:190-197 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) quickwit/quickwit-directories/src/caching_directory.rs:78— quickwit/quickwit-directories/src/caching_directory.rs:78-85 | quickwit/quickwit-directories/src/caching_directory.rs:87-97 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) quickwit/quickwit-directories/src/debug_proxy_directory.rs:162— quickwit/quickwit-directories/src/debug_proxy_directory.rs:162-169 | quickwit/quickwit-directories/src/debug_proxy_directory.rs:171-178 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) quickwit/quickwit-opentelemetry/src/otlp/logs.rs:346— quickwit/quickwit-opentelemetry/src/otlp/logs.rs:346-353 | quickwit/quickwit-opentelemetry/src/otlp/traces.rs:808-815 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) quickwit/quickwit-metastore/src/metastore/index_metadata/mod.rs:184— quickwit/quickwit-metastore/src/metastore/index_metadata/mod.rs:184-193 | quickwit/quickwit-metastore/src/metastore/file_backed/file_backed_index/mod.rs:613-620 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) quickwit/quickwit-serve/src/index_api/source_resource.rs:344— quickwit/quickwit-serve/src/index_api/source_resource.rs:344-352 | quickwit/quickwit-serve/src/template_api/rest_handler.rs:202-209 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (6 lines × 2) quickwit/quickwit-indexing/src/source/kafka_source.rs:451— quickwit/quickwit-indexing/src/source/kafka_source.rs:451-456 | quickwit/quickwit-indexing/src/source/queue_sources/coordinator.rs:161-166 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-indexing/src/source/kafka_source.rs:451` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) quickwit/quickwit-serve/src/lib.rs:934— quickwit/quickwit-serve/src/lib.rs:934-939 | quickwit/quickwit-serve/src/lib.rs:954-961 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-serve/src/lib.rs:954` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs:374— quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs:374-379 | quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs:410-415 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs:374` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs:347— quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs:347-352 | quickwit/quickwit-indexing/src/actors/merge_pipeline.rs:273-278 — before extracting anything, compare `quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs` and `quickwit/quickwit-indexing/src/actors/merge_pipeline.rs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 57 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs:347` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) quickwit/quickwit-cli/src/tool.rs:674— quickwit/quickwit-cli/src/tool.rs:674-679 | quickwit/quickwit-cli/src/tool.rs:745-750 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `args` to `GarbageCollectIndexArgs` in one and `ExtractSplitArgs` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (6 lines × 2) quickwit/quickwit-query/src/elastic_query_dsl/range_query.rs:109— quickwit/quickwit-query/src/elastic_query_dsl/range_query.rs:109-114 | quickwit/quickwit-query/src/elastic_query_dsl/range_query.rs:117-122 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-query/src/elastic_query_dsl/range_query.rs:109` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Hotspot: quickwit/quickwit-search/src/leaf.rs quickwit/quickwit-search/src/leaf.rs:1129— quickwit/quickwit-search/src/leaf.rs changed 18 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 19 in quickwit_search::leaf::normalize_timestamp_range at line 1129. 3 of those changes were fix/bug commits, and the other 15 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 12:17:00 +00:00' --until='2026-11-14 12:17:00 +00:00' --full-history --no-merges -- quickwit/quickwit-search/src/leaf.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: quickwit/quickwit-serve/src/lib.rs quickwit/quickwit-serve/src/lib.rs:571— quickwit/quickwit-serve/src/lib.rs changed 10 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 32 in quickwit_serve::serve_quickwit at line 571. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 12:17:00 +00:00' --until='2026-11-14 12:17:00 +00:00' --full-history --no-merges -- quickwit/quickwit-serve/src/lib.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: quickwit/quickwit-doc-mapper/src/doc_mapper/field_mapping_entry.rs quickwit/quickwit-doc-mapper/src/doc_mapper/field_mapping_entry.rs:721— quickwit/quickwit-doc-mapper/src/doc_mapper/field_mapping_entry.rs changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 22 in quickwit_doc_mapper::doc_mapper::field_mapping_entry::deserialize_mapping_type at line 721. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 12:17:00 +00:00' --until='2026-11-14 12:17:00 +00:00' --full-history --no-merges -- quickwit/quickwit-doc-mapper/src/doc_mapper/field_mapping_entry.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: quickwit/quickwit-query/src/query_ast/range_query.rs quickwit/quickwit-query/src/query_ast/range_query.rs:108— quickwit/quickwit-query/src/query_ast/range_query.rs changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 19 in RangeQuery::build_tantivy_ast_impl at line 108. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 12:17:00 +00:00' --until='2026-11-14 12:17:00 +00:00' --full-history --no-merges -- quickwit/quickwit-query/src/query_ast/range_query.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: quickwit/quickwit-metastore/src/metastore/postgres/utils.rs quickwit/quickwit-metastore/src/metastore/postgres/utils.rs:115— quickwit/quickwit-metastore/src/metastore/postgres/utils.rs changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 20 in quickwit_metastore::metastore::postgres::utils::append_query_filters_and_order_by at line 115. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-16..2026-11-14, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-16 12:17:00 +00:00' --until='2026-11-14 12:17:00 +00:00' --full-history --no-merges -- quickwit/quickwit-metastore/src/metastore/postgres/utils.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
D4 · Code Duplication· Edited copy of a member (18 corresponding lines) · ×5
Edited copy of a member (18 corresponding lines) quickwit/quickwit-doc-mapper/src/doc_mapper/tantivy_val_to_json.rs:138— quickwit/quickwit-doc-mapper/src/doc_mapper/tantivy_val_to_json.rs:138-155 | quickwit/quickwit-doc-mapper/src/doc_mapper/tantivy_val_to_json.rs:160-177 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (18 corresponding lines) quickwit/quickwit-proto/src/search/span_id.rs:45— quickwit/quickwit-proto/src/search/span_id.rs:45-62 | quickwit/quickwit-proto/src/search/trace_id.rs:53-74 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (18 corresponding lines) quickwit/quickwit-search/src/collector.rs:1094— quickwit/quickwit-search/src/collector.rs:1094-1111 | quickwit/quickwit-search/src/collector.rs:1131-1152 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (18 corresponding lines) quickwit/quickwit-rest-client/src/rest_client.rs:544— quickwit/quickwit-rest-client/src/rest_client.rs:544-563 | quickwit/quickwit-rest-client/src/rest_client.rs:647-664 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (18 corresponding lines) quickwit/quickwit-serve/src/otlp_api/rest_handler.rs:131— quickwit/quickwit-serve/src/otlp_api/rest_handler.rs:131-148 | quickwit/quickwit-serve/src/otlp_api/rest_handler.rs:205-222 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (12 corresponding lines) · ×5
Edited copy of a member (12 corresponding lines) quickwit/quickwit-proto/src/metastore/mod.rs:510— quickwit/quickwit-proto/src/metastore/mod.rs:510-521 | quickwit/quickwit-proto/src/metastore/mod.rs:554-566 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (12 corresponding lines) quickwit/quickwit-doc-mapper/src/query_builder.rs:315— quickwit/quickwit-doc-mapper/src/query_builder.rs:315-326 | quickwit/quickwit-doc-mapper/src/query_builder.rs:328-340 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (12 corresponding lines) quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs:475— quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs:475-486 | quickwit/quickwit-indexing/src/actors/merge_pipeline.rs:370-382 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (12 corresponding lines) quickwit/quickwit-cli/src/index.rs:303— quickwit/quickwit-cli/src/index.rs:303-314 | quickwit/quickwit-cli/src/index.rs:458-471 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (12 corresponding lines) quickwit/quickwit-indexing/src/actors/doc_processor.rs:560— quickwit/quickwit-indexing/src/actors/doc_processor.rs:560-571 | quickwit/quickwit-indexing/src/actors/indexer.rs:455-468 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (9 corresponding lines) · ×5
Edited copy of a member (9 corresponding lines) quickwit/quickwit-storage/src/debouncer.rs:182— quickwit/quickwit-storage/src/debouncer.rs:182-190 | quickwit/quickwit-storage/src/debouncer.rs:213-222 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) quickwit/quickwit-query/src/query_ast/regex_extract_eq.rs:41— quickwit/quickwit-query/src/query_ast/regex_extract_eq.rs:41-49 | quickwit/quickwit-query/src/query_ast/regex_extract_eq.rs:57-65 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) quickwit/quickwit-metastore/src/metastore/postgres/model.rs:136— quickwit/quickwit-metastore/src/metastore/postgres/model.rs:136-145 | quickwit/quickwit-metastore/src/metastore/postgres/model.rs:148-156 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) quickwit/quickwit-doc-mapper/src/doc_mapper/tokenizer_entry.rs:78— quickwit/quickwit-doc-mapper/src/doc_mapper/tokenizer_entry.rs:78-86 | quickwit/quickwit-query/src/query_ast/range_query.rs:94-105 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) quickwit/quickwit-serve/src/index_api/index_resource.rs:402— quickwit/quickwit-serve/src/index_api/index_resource.rs:402-410 | quickwit/quickwit-serve/src/index_api/source_resource.rs:236-244 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (7 lines × 2) quickwit/quickwit-rest-client/src/rest_client.rs:639— quickwit/quickwit-rest-client/src/rest_client.rs:639-645 | quickwit/quickwit-rest-client/src/rest_client.rs:704-710 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-rest-client/src/rest_client.rs:639` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:254— quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:254-260 | quickwit/quickwit-storage/src/opendal_storage/google_cloud_storage.rs:185-191 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:254` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) quickwit/quickwit-cli/src/jemalloc.rs:101— quickwit/quickwit-cli/src/jemalloc.rs:101-107 | quickwit/quickwit-telemetry-exporters/src/logs.rs:32-38 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (7 lines × 2) quickwit/quickwit-cli/src/jemalloc.rs:180— quickwit/quickwit-cli/src/jemalloc.rs:180-186 | quickwit/quickwit-telemetry-exporters/src/lib.rs:88-94 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (7 lines × 2) quickwit/quickwit-serve/src/elasticsearch_api/mod.rs:156— quickwit/quickwit-serve/src/elasticsearch_api/mod.rs:156-162 | quickwit/quickwit-serve/src/jaeger_api/rest_handler.rs:344-350 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-serve/src/elasticsearch_api/mod.rs:156` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Off the main sequence: quickwit-codegen — quickwit-codegen: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 2 project(s), so it's rigid to change.
Off the main sequence: quickwit-datetime — quickwit-datetime: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 2 project(s), so it's rigid to change.
Off the main sequence: quickwit-metrics — quickwit-metrics: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 20 project(s), so it's rigid to change.
Off the main sequence: quickwit-config — quickwit-config: abstractness 0.02, instability 0.14, distance 0.84 — zone of pain — concrete and depended on by 18 project(s), so it's rigid to change.
Off the main sequence: quickwit-proto — quickwit-proto: abstractness 0.07, instability 0.13, distance 0.80 — zone of pain — concrete and depended on by 20 project(s), so it's rigid to change.
AC2 · Forms & labels· <Select> field component without a label · ×4
<Select> field component without a label quickwit/quickwit-ui/src/components/QueryEditor/AggregationEditor.tsx:86— This UI-library field component has no label / aria-label / aria-labelledby / id, and nothing written inside it here carries one either (a name prop is the form-submission key, not a label; an id alone, wherever it is set, names nothing until a label points at it). The text inside it does not stand in for one: these compound APIs render a trigger with role="combobox" (or role="button"), and those roles take their name from the AUTHOR, not from their content — so the words on screen never reach the accessibility tree as a name. Name it whichever way this library supports: a label prop, an aria-label, or an id on the rendered control with a <label htmlFor> pointing at it. For a group of controls, name the group itself (aria-label, or a fieldset with a legend) — labelling each item leaves the set unnamed.
<Select> field component without a label quickwit/quickwit-ui/src/components/QueryEditor/AggregationEditor.tsx:300— This UI-library field component has no label / aria-label / aria-labelledby / id, and nothing written inside it here carries one either (a name prop is the form-submission key, not a label; an id alone, wherever it is set, names nothing until a label points at it). The text inside it does not stand in for one: these compound APIs render a trigger with role="combobox" (or role="button"), and those roles take their name from the AUTHOR, not from their content — so the words on screen never reach the accessibility tree as a name. Name it whichever way this library supports: a label prop, an aria-label, or an id on the rendered control with a <label htmlFor> pointing at it. For a group of controls, name the group itself (aria-label, or a fieldset with a legend) — labelling each item leaves the set unnamed.
<Select> field component without a label quickwit/quickwit-ui/src/components/QueryEditor/AggregationEditor.tsx:346— This UI-library field component has no label / aria-label / aria-labelledby / id at this call site, and nothing written inside it here carries one either (a name prop is the form-submission key, not a label; an id, even one the component sets on what it renders, names nothing until a label points at it) — so it likely renders an unlabelled control. Name it whichever way this library supports: a label prop, an aria-label, or an id on the rendered control with a <label htmlFor> pointing at it. For a group of controls, name the group itself (aria-label, or a fieldset with a legend) — labelling each item leaves the set unnamed.
<Select> field component without a label quickwit/quickwit-ui/src/components/QueryEditor/AggregationEditor.tsx:361— This UI-library field component has no label / aria-label / aria-labelledby / id at this call site, and nothing written inside it here carries one either (a name prop is the form-submission key, not a label; an id, even one the component sets on what it renders, names nothing until a label points at it) — so it likely renders an unlabelled control. Name it whichever way this library supports: a label prop, an aria-label, or an id on the rendered control with a <label htmlFor> pointing at it. For a group of controls, name the group itself (aria-label, or a fieldset with a legend) — labelling each item leaves the set unnamed.
quickwit_serve::serve_quickwit (cyclomatic 32) quickwit/quickwit-serve/src/lib.rs:571— quickwit_serve::serve_quickwit has cyclomatic complexity 32 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
quickwit_serve::mcp_api::protocol::handle (cyclomatic 31) quickwit/quickwit-serve/src/mcp_api/protocol.rs:35— quickwit_serve::mcp_api::protocol::handle has cyclomatic complexity 31 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
quickwit_serve::rest::get_status_with_error (cyclomatic 19) quickwit/quickwit-serve/src/rest.rs:629— quickwit_serve::rest::get_status_with_error has cyclomatic complexity 19 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
quickwit_serve::grpc::start_grpc_server (cyclomatic 18) quickwit/quickwit-serve/src/grpc.rs:46— quickwit_serve::grpc::start_grpc_server has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
quickwit_search::leaf::run_offloaded_search_tasks (cognitive 27) quickwit/quickwit-search/src/leaf.rs:1791— quickwit_search::leaf::run_offloaded_search_tasks has cognitive complexity 27 (threshold 15). Drivers by points: if/else 4 (13 pts), loops 4 (8 pts), match/switch 2 (6 pts) (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
quickwit_search::leaf::normalize_timestamp_range (cognitive 26) quickwit/quickwit-search/src/leaf.rs:1129— quickwit_search::leaf::normalize_timestamp_range has cognitive complexity 26 (threshold 15). Drivers by points: if/else 13 (19 pts), boolean chains 5, match/switch 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
quickwit_search::leaf::leaf_search_single_split (cognitive 19) quickwit/quickwit-search/src/leaf.rs:674— quickwit_search::leaf::leaf_search_single_split has cognitive complexity 19 (threshold 15). Drivers by points: if/else 16 (17 pts), boolean chains 1, match/switch 1 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
quickwit_search::root::convert_search_after_datetime_values (cognitive 16) quickwit/quickwit-search/src/root.rs:1743— quickwit_search::root::convert_search_after_datetime_values has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (12 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D4 · Code Duplication· Edited copy of a member (15 corresponding lines) · ×4
Edited copy of a member (15 corresponding lines) quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs:1264— quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs:1264-1278 | quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs:1311-1325 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (15 corresponding lines) quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:514— quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:514-528 | quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:1126-1141 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (15 corresponding lines) quickwit/quickwit-search/src/leaf.rs:1267— quickwit/quickwit-search/src/leaf.rs:1267-1281 | quickwit/quickwit-search/src/leaf.rs:1283-1297 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (15 corresponding lines) quickwit/quickwit-search/src/top_k_collector.rs:592— quickwit/quickwit-search/src/top_k_collector.rs:592-607 | quickwit/quickwit-search/src/top_k_collector.rs:803-817 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (13 corresponding lines) · ×4
Edited copy of a member (13 corresponding lines) quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs:1234— quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs:1234-1246 | quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs:1249-1261 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (13 corresponding lines) quickwit/quickwit-opentelemetry/src/otlp/traces.rs:446— quickwit/quickwit-opentelemetry/src/otlp/traces.rs:446-458 | quickwit/quickwit-opentelemetry/src/otlp/traces.rs:460-472 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (13 corresponding lines) quickwit/quickwit-opentelemetry/src/otlp/logs.rs:488— quickwit/quickwit-opentelemetry/src/otlp/logs.rs:488-500 | quickwit/quickwit-opentelemetry/src/otlp/traces.rs:828-840 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (13 corresponding lines) quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:1088— quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:1088-1101 | quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:459-471 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (16 corresponding lines) · ×4
Edited copy of a member (16 corresponding lines) quickwit/quickwit-cli/src/index.rs:316— quickwit/quickwit-cli/src/index.rs:316-331 | quickwit/quickwit-cli/src/index.rs:333-352 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (16 corresponding lines) quickwit/quickwit-search/src/collector.rs:1040— quickwit/quickwit-search/src/collector.rs:1040-1055 | quickwit/quickwit-search/src/collector.rs:1061-1080 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (16 corresponding lines) quickwit/quickwit-config/src/metastore_config.rs:54— quickwit/quickwit-config/src/metastore_config.rs:54-72 | quickwit/quickwit-config/src/storage_config.rs:110-125 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (16 corresponding lines) quickwit/quickwit-search/src/collector.rs:527— quickwit/quickwit-search/src/collector.rs:527-544 | quickwit/quickwit-search/src/collector.rs:547-562 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (10 lines × 2) quickwit/quickwit-codegen/src/codegen.rs:683— quickwit/quickwit-codegen/src/codegen.rs:683-692 | quickwit/quickwit-codegen/src/codegen.rs:702-711 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-codegen/src/codegen.rs:683` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) quickwit/quickwit-control-plane/src/control_plane.rs:695— quickwit/quickwit-control-plane/src/control_plane.rs:695-704 | quickwit/quickwit-control-plane/src/control_plane.rs:734-743 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `request` to `AddSourceRequest` in one and `UpdateSourceRequest` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (10 lines × 2) quickwit/quickwit-query/src/query_ast/phrase_prefix_query.rs:56— quickwit/quickwit-query/src/query_ast/phrase_prefix_query.rs:56-65 | quickwit/quickwit-query/src/query_ast/regex_query.rs:107-116 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-query/src/query_ast/phrase_prefix_query.rs:56` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) quickwit/quickwit-search/src/list_terms.rs:160— quickwit/quickwit-search/src/list_terms.rs:160-169 | quickwit/quickwit-search/src/list_terms.rs:402-411 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Weak hash algorithm quickwit/quickwit-lambda-client/src/deploy.rs:77— MD5/SHA1 is computed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ (`sha2::Sha256::digest(…)`) for content integrity, or a KDF (bcrypt/Argon2/scrypt) for password storage. If it only derives a non-security identifier (a cache key, an avatar URL, an ETag), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as xxhash or murmurhash says it in code — since the algorithm alone cannot distinguish the two uses. Where a protocol this code does not own fixes the digest (a k-anonymity range query, a legacy signature format), the protocol decides; say so beside the call.
Weak hash algorithm quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:259— MD5/SHA1 is computed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ (`sha2::Sha256::digest(…)`) for content integrity, or a KDF (bcrypt/Argon2/scrypt) for password storage. If it only derives a non-security identifier (a cache key, an avatar URL, an ETag), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as xxhash or murmurhash says it in code — since the algorithm alone cannot distinguish the two uses. Where a protocol this code does not own fixes the digest (a k-anonymity range query, a legacy signature format), the protocol decides; say so beside the call.
Weak hash algorithm quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:562— MD5/SHA1 is computed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ (`sha2::Sha256::digest(…)`) for content integrity, or a KDF (bcrypt/Argon2/scrypt) for password storage. If it only derives a non-security identifier (a cache key, an avatar URL, an ETag), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as xxhash or murmurhash says it in code — since the algorithm alone cannot distinguish the two uses. Where a protocol this code does not own fixes the digest (a k-anonymity range query, a legacy signature format), the protocol decides; say so beside the call.
Weak hash algorithm quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:338— MD5/SHA1 is computed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ (`sha2::Sha256::digest(…)`) for content integrity, or a KDF (bcrypt/Argon2/scrypt) for password storage. If it only derives a non-security identifier (a cache key, an avatar URL, an ETag), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as xxhash or murmurhash says it in code — since the algorithm alone cannot distinguish the two uses. Where a protocol this code does not own fixes the digest (a k-anonymity range query, a legacy signature format), the protocol decides; say so beside the call.
DocMapper::doc_to_json (cognitive 29) quickwit/quickwit-doc-mapper/src/doc_mapper/doc_mapper_impl.rs:574— DocMapper::doc_to_json has cognitive complexity 29 (threshold 15). Drivers by points: if/else 10 (24 pts), loops 2 (5 pts) (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DocMapper::try_from (cognitive 24) quickwit/quickwit-doc-mapper/src/doc_mapper/doc_mapper_impl.rs:161— DocMapper::try_from has cognitive complexity 24 (threshold 15). Drivers by points: if/else 14 (19 pts), loops 4, boolean chains 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DocMapper::doc_from_json_obj (cognitive 16) quickwit/quickwit-doc-mapper/src/doc_mapper/doc_mapper_impl.rs:496— DocMapper::doc_from_json_obj has cognitive complexity 16 (threshold 15). Drivers by points: loops 3 (9 pts), if/else 5 (6 pts), boolean chains 1 (nesting depth added 7). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
quickwit_doc_mapper::doc_mapper::mapping_tree::extract_json_val (cognitive 24) quickwit/quickwit-doc-mapper/src/doc_mapper/mapping_tree.rs:471— quickwit_doc_mapper::doc_mapper::mapping_tree::extract_json_val has cognitive complexity 24 (threshold 15). Drivers by points: if/else 7 (17 pts), loops 2 (6 pts), match/switch 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
quickwit_doc_mapper::doc_mapper::mapping_tree::build_mapping_tree_from_entries (cognitive 23) quickwit/quickwit-doc-mapper/src/doc_mapper/mapping_tree.rs:1057— quickwit_doc_mapper::doc_mapper::mapping_tree::build_mapping_tree_from_entries has cognitive complexity 23 (threshold 15). Drivers by points: if/else 7 (16 pts), loops 4 (7 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
quickwit_doc_mapper::doc_mapper::mapping_tree::extract_val_from_tantivy_val (cognitive 18) quickwit/quickwit-doc-mapper/src/doc_mapper/mapping_tree.rs:533— quickwit_doc_mapper::doc_mapper::mapping_tree::extract_val_from_tantivy_val has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (10 pts), loops 3 (4 pts), match/switch 1 (4 pts) (nesting depth added 7). Of this number, 12 points are the body's own statements and 6 belong to one function item inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TooManyMethods: ControlPlaneModel quickwit/quickwit-control-plane/src/model/mod.rs:54— TooManyMethods — 34 methods. The bar is 30 methods; this is 4 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ListSplitsQuery quickwit/quickwit-metastore/src/metastore/mod.rs:646— TooManyMethods — 34 methods. The bar is 30 methods; this is 4 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: FileBackedIndex quickwit/quickwit-metastore/src/metastore/file_backed/file_backed_index/mod.rs:54— TooManyMethods — 32 methods. The bar is 30 methods; this is 2 over it, 1.07× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D4 · Code Duplication· Edited copy of a member (35 corresponding lines) · ×3
Edited copy of a member (35 corresponding lines) quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:416— quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:416-456 | quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:744-778 — These two members are one piece of code written twice and then edited apart: 35 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (35 corresponding lines) quickwit/quickwit-opentelemetry/src/otlp/logs.rs:225— quickwit/quickwit-opentelemetry/src/otlp/logs.rs:225-259 | quickwit/quickwit-opentelemetry/src/otlp/traces.rs:684-721 — These two members are one piece of code written twice and then edited apart: 35 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (35 corresponding lines) quickwit/quickwit-doc-mapper/src/doc_mapper/mapping_tree.rs:674— quickwit/quickwit-doc-mapper/src/doc_mapper/mapping_tree.rs:674-713 | quickwit/quickwit-doc-mapper/src/doc_mapper/mapping_tree.rs:715-749 — These two members are one piece of code written twice and then edited apart: 35 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (22 corresponding lines) · ×3
Edited copy of a member (22 corresponding lines) quickwit/quickwit-opentelemetry/src/otlp/logs.rs:316— quickwit/quickwit-opentelemetry/src/otlp/logs.rs:316-337 | quickwit/quickwit-opentelemetry/src/otlp/traces.rs:778-799 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (22 corresponding lines) quickwit/quickwit-rest-client/src/rest_client.rs:434— quickwit/quickwit-rest-client/src/rest_client.rs:434-455 | quickwit/quickwit-rest-client/src/rest_client.rs:614-635 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (22 corresponding lines) quickwit/quickwit-ingest/src/ingest_v2/broadcast/capacity_score.rs:174— quickwit/quickwit-ingest/src/ingest_v2/broadcast/capacity_score.rs:174-197 | quickwit/quickwit-ingest/src/ingest_v2/broadcast/local_shards.rs:378-399 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (21 corresponding lines) · ×3
Edited copy of a member (21 corresponding lines) quickwit/quickwit-search/src/list_fields/root.rs:160— quickwit/quickwit-search/src/list_fields/root.rs:160-184 | quickwit/quickwit-search/src/list_terms.rs:191-211 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (21 corresponding lines) quickwit/quickwit-proto/src/types/position.rs:264— quickwit/quickwit-proto/src/types/position.rs:264-284 | quickwit/quickwit-proto/src/types/shard_id.rs:95-115 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (21 corresponding lines) quickwit/quickwit-serve/src/index_api/source_resource.rs:319— quickwit/quickwit-serve/src/index_api/source_resource.rs:319-340 | quickwit/quickwit-serve/src/index_api/source_resource.rs:371-391 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 13+ corresponding lines) · ×3
Edited copies of one member (3 members, 13+ corresponding lines) quickwit/quickwit-metrics/src/counter.rs:57— quickwit/quickwit-metrics/src/counter.rs:57-69 | quickwit/quickwit-metrics/src/gauge.rs:58-70 | quickwit/quickwit-metrics/src/histogram.rs:72-84 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Edited copies of one member (3 members, 13+ corresponding lines) quickwit/quickwit-search/src/client.rs:236— quickwit/quickwit-search/src/client.rs:236-248 | quickwit/quickwit-search/src/client.rs:254-266 | quickwit/quickwit-search/src/client.rs:272-284 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Edited copies of one member (3 members, 13+ corresponding lines) quickwit/quickwit-query/src/elastic_query_dsl/match_bool_prefix.rs:33— quickwit/quickwit-query/src/elastic_query_dsl/match_bool_prefix.rs:33-48 | quickwit/quickwit-query/src/elastic_query_dsl/match_phrase_query.rs:45-59 | quickwit/quickwit-query/src/elastic_query_dsl/match_query.rs:46-58 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Duplicated block (16 lines × 2) quickwit/quickwit-doc-mapper/src/doc_mapper/mapping_tree.rs:414— quickwit/quickwit-doc-mapper/src/doc_mapper/mapping_tree.rs:414-429 | quickwit/quickwit-doc-mapper/src/doc_mapper/mapping_tree.rs:434-449 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (16 lines × 2) quickwit/quickwit-storage/src/cache/base_cache.rs:327— quickwit/quickwit-storage/src/cache/base_cache.rs:327-342 | quickwit/quickwit-storage/src/cache/base_cache.rs:439-454 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (16 lines × 2) quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:428— quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:428-443 | quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:585-600 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:428` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
quickwit_metastore::metastore::file_backed::file_backed_index::split_query_predicate (cyclomatic 23) quickwit/quickwit-metastore/src/metastore/file_backed/file_backed_index/mod.rs:724— quickwit_metastore::metastore::file_backed::file_backed_index::split_query_predicate has cyclomatic complexity 23 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
quickwit_metastore::metastore::postgres::utils::append_query_filters_and_order_by (cyclomatic 20) quickwit/quickwit-metastore/src/metastore/postgres/utils.rs:115— quickwit_metastore::metastore::postgres::utils::append_query_filters_and_order_by has cyclomatic complexity 20 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
quickwit_metastore::metastore::file_backed::file_backed_index::split_query_predicate (cognitive 25) quickwit/quickwit-metastore/src/metastore/file_backed/file_backed_index/mod.rs:724— quickwit_metastore::metastore::file_backed::file_backed_index::split_query_predicate has cognitive complexity 25 (threshold 15). Drivers by points: if/else 14 (18 pts), boolean chains 6, match/switch 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
quickwit_metastore::metastore::postgres::metastore::build_index_id_patterns_sql_query (cognitive 17) quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs:1948— quickwit_metastore::metastore::postgres::metastore::build_index_id_patterns_sql_query has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (13 pts), loops 3, boolean chains 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
quickwit_indexing::docs_clustering::tokenizer::is_ipv4 (cognitive 22) quickwit/quickwit-indexing/src/docs_clustering/tokenizer.rs:228— quickwit_indexing::docs_clustering::tokenizer::is_ipv4 has cognitive complexity 22 (threshold 15). Drivers by points: if/else 6 (13 pts), boolean chains 6, loops 2 (3 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
quickwit_indexing::source::kafka_source::spawn_consumer_poll_loop (cognitive 18) quickwit/quickwit-indexing/src/source/kafka_source.rs:554— quickwit_indexing::source::kafka_source::spawn_consumer_poll_loop has cognitive complexity 18 (threshold 15). Drivers by points: if/else 5 (11 pts), loops 2 (4 pts), match/switch 1 (3 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D4 · Code Duplication· Edited copy of a member (27 corresponding lines) · ×2
Edited copy of a member (27 corresponding lines) quickwit/quickwit-serve/src/otlp_api/rest_handler.rs:90— quickwit/quickwit-serve/src/otlp_api/rest_handler.rs:90-116 | quickwit/quickwit-serve/src/otlp_api/rest_handler.rs:164-190 — These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (27 corresponding lines) quickwit/quickwit-doc-mapper/src/doc_mapper/date_time_type.rs:71— quickwit/quickwit-doc-mapper/src/doc_mapper/date_time_type.rs:71-98 | quickwit/quickwit-doc-mapper/src/doc_mapper/date_time_type.rs:100-126 — These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (23 corresponding lines) · ×2
Edited copy of a member (23 corresponding lines) quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs:512— quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs:512-534 | quickwit/quickwit-indexing/src/actors/merge_pipeline.rs:526-551 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (23 corresponding lines) quickwit/quickwit-search/src/leaf.rs:1078— quickwit/quickwit-search/src/leaf.rs:1078-1100 | quickwit/quickwit-search/src/leaf.rs:1104-1126 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 19+ corresponding lines) · ×2
Edited copies of one member (3 members, 19+ corresponding lines) quickwit/quickwit-telemetry-exporters/src/otlp/logs.rs:26— quickwit/quickwit-telemetry-exporters/src/otlp/logs.rs:26-44 | quickwit/quickwit-telemetry-exporters/src/otlp/metrics.rs:28-46 | quickwit/quickwit-telemetry-exporters/src/otlp/traces.rs:26-44 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 19 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Edited copies of one member (3 members, 19+ corresponding lines) quickwit/quickwit-serve/src/elasticsearch_api/bulk.rs:44— quickwit/quickwit-serve/src/elasticsearch_api/bulk.rs:44-62 | quickwit/quickwit-serve/src/elasticsearch_api/bulk.rs:72-93 | quickwit/quickwit-serve/src/ingest_api/rest_handler.rs:111-130 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 19 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (4 members, 13+ corresponding lines) · ×2
Edited copies of one member (4 members, 13+ corresponding lines) quickwit/quickwit-serve/src/index_api/index_resource.rs:237— quickwit/quickwit-serve/src/index_api/index_resource.rs:237-251 | quickwit/quickwit-serve/src/index_api/index_resource.rs:302-316 | quickwit/quickwit-serve/src/index_api/source_resource.rs:40-52 | quickwit/quickwit-serve/src/index_api/source_resource.rs:118-131 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
Edited copies of one member (4 members, 13+ corresponding lines) quickwit/quickwit-ingest/src/mrecordlog_async.rs:118— quickwit/quickwit-ingest/src/mrecordlog_async.rs:118-130 | quickwit/quickwit-ingest/src/mrecordlog_async.rs:133-145 | quickwit/quickwit-ingest/src/mrecordlog_async.rs:153-165 | quickwit/quickwit-ingest/src/mrecordlog_async.rs:168-180 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (14 corresponding lines) · ×2
Edited copy of a member (14 corresponding lines) quickwit/quickwit-metastore/src/checkpoint.rs:341— quickwit/quickwit-metastore/src/checkpoint.rs:341-354 | quickwit/quickwit-metastore/src/checkpoint.rs:400-414 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (14 corresponding lines) quickwit/quickwit-config/src/index_template/serialize.rs:75— quickwit/quickwit-config/src/index_template/serialize.rs:75-88 | quickwit/quickwit-config/src/index_template/serialize.rs:92-105 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 11+ corresponding lines) · ×2
Edited copies of one member (3 members, 11+ corresponding lines) quickwit/quickwit-storage/src/cache/base_cache.rs:184— quickwit/quickwit-storage/src/cache/base_cache.rs:184-194 | quickwit/quickwit-storage/src/cache/base_cache.rs:311-321 | quickwit/quickwit-storage/src/cache/base_cache.rs:421-433 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Edited copies of one member (3 members, 11+ corresponding lines) quickwit/quickwit-integration-tests/src/test_utils/cluster_sandbox.rs:399— quickwit/quickwit-integration-tests/src/test_utils/cluster_sandbox.rs:399-409 | quickwit/quickwit-integration-tests/src/test_utils/cluster_sandbox.rs:434-445 | quickwit/quickwit-integration-tests/src/test_utils/cluster_sandbox.rs:448-459 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (6 corresponding lines) · ×2
Edited copy of a member (6 corresponding lines) quickwit/quickwit-serve/src/elasticsearch_api/filter.rs:213— quickwit/quickwit-serve/src/elasticsearch_api/filter.rs:213-218 | quickwit/quickwit-serve/src/search_api/rest_handler.rs:299-304 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (6 corresponding lines) quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:90— quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:90-95 | quickwit/quickwit-storage/src/prefix_storage.rs:40-45 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (19 lines × 2) quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs:204— quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs:204-222 | quickwit/quickwit-indexing/src/actors/merge_pipeline.rs:190-208 — before extracting anything, compare `quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs` and `quickwit/quickwit-indexing/src/actors/merge_pipeline.rs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 57 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs:204` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (19 lines × 2) quickwit/quickwit-janitor/src/actors/garbage_collector.rs:105— quickwit/quickwit-janitor/src/actors/garbage_collector.rs:105-123 | quickwit/quickwit-janitor/src/actors/retention_policy_executor.rs:79-97 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (17 lines × 2) quickwit/quickwit-index-management/src/index.rs:491— quickwit/quickwit-index-management/src/index.rs:491-507 | quickwit/quickwit-index-management/src/index.rs:525-541 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-index-management/src/index.rs:491` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 2) quickwit/quickwit-metastore/src/metastore/mod.rs:771— quickwit/quickwit-metastore/src/metastore/mod.rs:771-787 | quickwit/quickwit-metastore/src/metastore/mod.rs:819-835 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-metastore/src/metastore/mod.rs:771` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13–14 lines × 2) quickwit/quickwit-indexing/src/source/kinesis/helpers.rs:21— quickwit/quickwit-indexing/src/source/kinesis/helpers.rs:21-33 | quickwit/quickwit-indexing/src/source/queue_sources/sqs_queue.rs:204-217 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (13–14 lines × 2) quickwit/quickwit-search/src/root.rs:1469— quickwit/quickwit-search/src/root.rs:1469-1482 | quickwit/quickwit-search/src/root.rs:1628-1640 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-search/src/root.rs:1469` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) quickwit/quickwit-opentelemetry/src/otlp/logs.rs:269— quickwit/quickwit-opentelemetry/src/otlp/logs.rs:269-282 | quickwit/quickwit-opentelemetry/src/otlp/traces.rs:731-744 — before extracting anything, compare `quickwit/quickwit-opentelemetry/src/otlp/logs.rs` and `quickwit/quickwit-opentelemetry/src/otlp/traces.rs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 45 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (14 lines × 2) quickwit/quickwit-rest-client/src/rest_client.rs:442— quickwit/quickwit-rest-client/src/rest_client.rs:442-455 | quickwit/quickwit-rest-client/src/rest_client.rs:622-635 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-rest-client/src/rest_client.rs:442` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) quickwit/quickwit-jaeger/src/v2.rs:207— quickwit/quickwit-jaeger/src/v2.rs:207-218 | quickwit/quickwit-jaeger/src/v2.rs:277-288 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-jaeger/src/v2.rs:207` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `request` to `Request<FindTracesRequest>` in one and `Request<quickwit_proto::jaeger::storage::v2::FindTracesRequest>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (12 lines × 2) quickwit/quickwit-metastore/src/split_metadata_version.rs:121— quickwit/quickwit-metastore/src/split_metadata_version.rs:121-132 | quickwit/quickwit-metastore/src/split_metadata_version.rs:143-154 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-metastore/src/split_metadata_version.rs:121` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 3) quickwit/quickwit-proto/src/compaction/mod.rs:92— quickwit/quickwit-proto/src/compaction/mod.rs:92-102 | quickwit/quickwit-proto/src/control_plane/mod.rs:122-132 | quickwit/quickwit-proto/src/indexing/mod.rs:105-115 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Note first that the copies are not typed on the same thing: the declarations holding them bind `error` to `AskError<CompactionError>` in one and `AskError<ControlPlaneError>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (11 lines × 3) quickwit/quickwit-proto/src/types/doc_mapping_uid.rs:103— quickwit/quickwit-proto/src/types/doc_mapping_uid.rs:103-113 | quickwit/quickwit-proto/src/types/doc_uid.rs:102-112 | quickwit/quickwit-proto/src/types/pipeline_uid.rs:106-116 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-proto/src/types/doc_mapping_uid.rs:103` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Low cohesion: CodegenBuilder (LCOM4 6) quickwit/quickwit-codegen/src/codegen.rs:64— CodegenBuilder's methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: ActorContext (LCOM4 5) quickwit/quickwit-actors/src/actor_context.rs:39— ActorContext's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Duplicated block (10 lines × 2 locations) quickwit/quickwit-ui/src/components/SideBar.tsx:95— quickwit/quickwit-ui/src/components/SideBar.tsx:95 · quickwit/quickwit-ui/src/components/SideBar.tsx:105 — all 2 copies are in the same file, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are.
Duplicated block (10 lines × 2 locations) quickwit/quickwit-ui/src/views/NodeInfoView.tsx:65— quickwit/quickwit-ui/src/views/NodeInfoView.tsx:65 · quickwit/quickwit-ui/src/views/NodeInfoView.tsx:75 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R4 · Test Coverage· No test reaches this file · ×2
No test reaches this file quickwit/quickwit-ui/src/providers/EditorProvider.tsx:1— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file quickwit/quickwit-ui/jest/setup.js:1— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
AC2 · Forms & labels· <Autocomplete> field component without a label · ×1
<Autocomplete> field component without a label quickwit/quickwit-ui/src/components/IndexSideBar.tsx:84— This UI-library field component has no label / aria-label / aria-labelledby / id at this call site, and nothing written inside it here carries one either (a name prop is the form-submission key, not a label; an id, even one the component sets on what it renders, names nothing until a label points at it) — so it likely renders an unlabelled control. Name it whichever way this library supports: a label prop, an aria-label, or an id on the rendered control with a <label htmlFor> pointing at it. For a group of controls, name the group itself (aria-label, or a fieldset with a legend) — labelling each item leaves the set unnamed.
AC6 · Visual & motion safety· Animation without a prefers-reduced-motion guard · ×1
Animation without a prefers-reduced-motion guard quickwit/quickwit-ui/src/components/Loader.tsx:35— `.css-in-js` moves (`animation: _______ infinite 5s linear`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
SortingFieldExtractorComponent::convert_to_u64_ff_val (cyclomatic 50) quickwit/quickwit-search/src/collector.rs:214— SortingFieldExtractorComponent::convert_to_u64_ff_val has cyclomatic complexity 50 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
TantivyBoolQuery::simplify (cyclomatic 30) quickwit/quickwit-query/src/query_ast/tantivy_query_ast.rs:179— TantivyBoolQuery::simplify has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
quickwit_doc_mapper::doc_mapper::field_mapping_entry::deserialize_mapping_type (cyclomatic 22) quickwit/quickwit-doc-mapper/src/doc_mapper/field_mapping_entry.rs:721— quickwit_doc_mapper::doc_mapper::field_mapping_entry::deserialize_mapping_type has cyclomatic complexity 22 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
quickwit_ingest::ingest_v2::router::update_ingest_metrics (cyclomatic 22) quickwit/quickwit-ingest/src/ingest_v2/router.rs:507— quickwit_ingest::ingest_v2::router::update_ingest_metrics has cyclomatic complexity 22 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
quickwit_jaeger::build_search_query (cyclomatic 22) quickwit/quickwit-jaeger/src/lib.rs:560— quickwit_jaeger::build_search_query has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
quickwit_query::query_ast::user_input_query::convert_user_input_ast_to_query_ast (cyclomatic 22) quickwit/quickwit-query/src/query_ast/user_input_query.rs:97— quickwit_query::query_ast::user_input_query::convert_user_input_ast_to_query_ast has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AggregationEditor.AggregationKind (cyclomatic 22) quickwit/quickwit-ui/src/components/QueryEditor/AggregationEditor.tsx:113— AggregationEditor.AggregationKind has cyclomatic complexity 22 (threshold 15). Most of this is not in the body itself: 1 of the 22 points is its own statement and the rest belongs to 9 function items inside it that branch (makeOptions, a function literal at line 156, a function literal at line 123, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
Ingester::persist_inner (cyclomatic 20) quickwit/quickwit-ingest/src/ingest_v2/ingester.rs:387— Ingester::persist_inner has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
RangeQuery::build_tantivy_ast_impl (cyclomatic 19) quickwit/quickwit-query/src/query_ast/range_query.rs:108— RangeQuery::build_tantivy_ast_impl has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SearchJobPlacer::assign_jobs_inner (cyclomatic 19) quickwit/quickwit-search/src/search_job_placer.rs:193— SearchJobPlacer::assign_jobs_inner has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
quickwit_search::leaf::normalize_timestamp_range (cyclomatic 19) quickwit/quickwit-search/src/leaf.rs:1129— quickwit_search::leaf::normalize_timestamp_range has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
quickwit_cli::generate_markdown::markdown_for_command_helper (cyclomatic 18) quickwit/quickwit-cli/src/generate_markdown.rs:65— quickwit_cli::generate_markdown::markdown_for_command_helper has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DocMapper::try_from (cyclomatic 16) quickwit/quickwit-doc-mapper/src/doc_mapper/doc_mapper_impl.rs:161— DocMapper::try_from has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FetchStreamTask::run (cyclomatic 16) quickwit/quickwit-ingest/src/ingest_v2/fetch.rs:106— FetchStreamTask::run has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SearchView.SearchView (cyclomatic 16) quickwit/quickwit-ui/src/views/SearchView.tsx:63— SearchView.SearchView has cyclomatic complexity 16 (threshold 15). Most of this is not in the body itself: 4 of the 16 points are its own statements and the rest belongs to 4 function items inside it that branch (a function literal at line 133, runSearch, a function literal at line 122, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
HackComment quickwit/quickwit-storage/src/cache/quickwit_cache.rs:112— /// HACK! We use `0..usize::MAX` to signify the "entire file". — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
SortingFieldExtractorComponent::convert_to_u64_ff_val (cognitive 56) quickwit/quickwit-search/src/collector.rs:214— SortingFieldExtractorComponent::convert_to_u64_ff_val has cognitive complexity 56 (threshold 15). Drivers by points: if/else 12 (32 pts), boolean chains 17, match/switch 4 (7 pts) (nesting depth added 23). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
TantivyBoolQuery::simplify (cognitive 50) quickwit/quickwit-query/src/query_ast/tantivy_query_ast.rs:179— TantivyBoolQuery::simplify has cognitive complexity 50 (threshold 15). Drivers by points: if/else 17 (28 pts), loops 7 (9 pts), match/switch 3 (7 pts), boolean chains 6 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
S3CompatibleObjectStorage::bulk_delete_multi (cognitive 36) quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:782— S3CompatibleObjectStorage::bulk_delete_multi has cognitive complexity 36 (threshold 15). Drivers by points: if/else 5 (17 pts), loops 4 (10 pts), match/switch 2 (8 pts), boolean chains 1 (nesting depth added 24). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
quickwit_cli::generate_markdown::markdown_for_command_helper (cognitive 34) quickwit/quickwit-cli/src/generate_markdown.rs:65— quickwit_cli::generate_markdown::markdown_for_command_helper has cognitive complexity 34 (threshold 15). Drivers by points: if/else 12 (21 pts), loops 5 (11 pts), boolean chains 2 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Ingester::persist_inner (cognitive 33) quickwit/quickwit-ingest/src/ingest_v2/ingester.rs:387— Ingester::persist_inner has cognitive complexity 33 (threshold 15). Drivers by points: if/else 12 (18 pts), loops 5 (8 pts), match/switch 3 (7 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
quickwit_opentelemetry::otlp::logs::parse_otlp_logs (cognitive 33) quickwit/quickwit-opentelemetry/src/otlp/logs.rs:356— quickwit_opentelemetry::otlp::logs::parse_otlp_logs has cognitive complexity 33 (threshold 15). Drivers by points: if/else 10 (25 pts), loops 3 (6 pts), match/switch 1 (2 pts) (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
quickwit_query::query_ast::user_input_query::convert_user_input_ast_to_query_ast (cognitive 33) quickwit/quickwit-query/src/query_ast/user_input_query.rs:97— quickwit_query::query_ast::user_input_query::convert_user_input_ast_to_query_ast has cognitive complexity 33 (threshold 15). Drivers by points: if/else 11 (19 pts), match/switch 4 (9 pts), loops 2 (5 pts) (nesting depth added 16). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
KinesisSource::emit_batches (cognitive 30) quickwit/quickwit-indexing/src/source/kinesis/kinesis_source.rs:219— KinesisSource::emit_batches has cognitive complexity 30 (threshold 15). Drivers by points: if/else 5 (16 pts), loops 3 (9 pts), match/switch 2 (5 pts) (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FetchStreamTask::run (cognitive 30) quickwit/quickwit-ingest/src/ingest_v2/fetch.rs:106— FetchStreamTask::run has cognitive complexity 30 (threshold 15). Drivers by points: if/else 12 (24 pts), boolean chains 3, loops 2 (3 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
quickwit_jaeger::build_search_query (cognitive 30) quickwit/quickwit-jaeger/src/lib.rs:560— quickwit_jaeger::build_search_query has cognitive complexity 30 (threshold 15). Drivers by points: if/else 17 (23 pts), boolean chains 5, loops 1 (2 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MappingLeaf::doc_from_json (cognitive 28) quickwit/quickwit-doc-mapper/src/doc_mapper/mapping_tree.rs:387— MappingLeaf::doc_from_json has cognitive complexity 28 (threshold 15). Drivers by points: loops 5 (16 pts), if/else 7 (12 pts) (nesting depth added 16). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
SearchJobPlacer::assign_jobs_inner (cognitive 28) quickwit/quickwit-search/src/search_job_placer.rs:193— SearchJobPlacer::assign_jobs_inner has cognitive complexity 28 (threshold 15). Drivers by points: if/else 10 (15 pts), loops 4 (6 pts), match/switch 2 (5 pts), boolean chains 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
IngestRouter::process_persist_results (cognitive 24) quickwit/quickwit-ingest/src/ingest_v2/router.rs:276— IngestRouter::process_persist_results has cognitive complexity 24 (threshold 15). Drivers by points: loops 4 (11 pts), if/else 3 (7 pts), match/switch 2 (6 pts) (nesting depth added 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
quickwit_lambda_client::deploy::garbage_collect_old_versions (cognitive 24) quickwit/quickwit-lambda-client/src/deploy.rs:517— quickwit_lambda_client::deploy::garbage_collect_old_versions has cognitive complexity 24 (threshold 15). Drivers by points: if/else 8 (19 pts), loops 3 (4 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
QuickwitClient::ingest (cognitive 24) quickwit/quickwit-rest-client/src/rest_client.rs:314— QuickwitClient::ingest has cognitive complexity 24 (threshold 15). Drivers by points: if/else 8 (16 pts), match/switch 2 (4 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AggregationEditor.AggregationKind (cognitive 22) quickwit/quickwit-ui/src/components/QueryEditor/AggregationEditor.tsx:113— AggregationEditor.AggregationKind has cognitive complexity 22 (threshold 15). Drivers by points: if/else 16 (19 pts), boolean chains 1, loops 1, match/switch 1 (nesting depth added 3). None of this is in the body itself: all 22 points belong to 9 function items inside it that branch (makeOptions, a function literal at line 123, getAggregationKind, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
IngestSource::truncate (cognitive 21) quickwit/quickwit-indexing/src/source/ingest/mod.rs:295— IngestSource::truncate has cognitive complexity 21 (threshold 15). Drivers by points: if/else 7 (15 pts), loops 4 (5 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
quickwit_macros::generate_proxy_struct (cognitive 21) quickwit/quickwit-macros/src/lib.rs:137— quickwit_macros::generate_proxy_struct has cognitive complexity 21 (threshold 15). Drivers by points: if/else 8 (11 pts), match/switch 2 (6 pts), loops 2 (4 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
quickwit_codegen::codegen::generate_grpc_server_adapter_methods (cognitive 19) quickwit/quickwit-codegen/src/codegen.rs:1373— quickwit_codegen::codegen::generate_grpc_server_adapter_methods has cognitive complexity 19 (threshold 15). Drivers by points: if/else 12 (18 pts), loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
quickwit_directories::hot_directory::write_hotcache (cognitive 19) quickwit/quickwit-directories/src/hot_directory.rs:481— quickwit_directories::hot_directory::write_hotcache has cognitive complexity 19 (threshold 15). Drivers by points: if/else 4 (10 pts), loops 5 (8 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FileByteRangeCacheState::put_slice (cognitive 19) quickwit/quickwit-storage/src/cache/byte_range_cache.rs:59— FileByteRangeCacheState::put_slice has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (14 pts), boolean chains 2, match/switch 2, loops 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
JaegerService::stream_spans (cognitive 18) quickwit/quickwit-jaeger/src/lib.rs:302— JaegerService::stream_spans has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (11 pts), loops 3, match/switch 2 (3 pts), boolean chains 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
quickwit_storage::object_storage::s3_compatible_storage::convert_list_objects (cognitive 18) quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:1167— quickwit_storage::object_storage::s3_compatible_storage::convert_list_objects has cognitive complexity 18 (threshold 15). Drivers by points: match/switch 4 (10 pts), if/else 3 (6 pts), boolean chains 1, loops 1 (nesting depth added 9). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
IngestController::compute_shards_to_rebalance (cognitive 17) quickwit/quickwit-control-plane/src/ingest/ingest_controller.rs:1226— IngestController::compute_shards_to_rebalance has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (14 pts), loops 3 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
IndexingService::spawn_pipelines (cognitive 17) quickwit/quickwit-indexing/src/actors/indexing_service.rs:733— IndexingService::spawn_pipelines has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (15 pts), boolean chains 1, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
quickwit_ingest::ingest_v2::fetch::fetch_stream_once (cognitive 17) quickwit/quickwit-ingest/src/ingest_v2/fetch.rs:409— quickwit_ingest::ingest_v2::fetch::fetch_stream_once has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (10 pts), match/switch 3 (6 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PostgresqlMetastore::indexes_metadata (cognitive 17) quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs:557— PostgresqlMetastore::indexes_metadata has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (12 pts), loops 3 (5 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CodeTokenStreamState::advance (cognitive 17) quickwit/quickwit-query/src/tokenizers/code_tokenizer.rs:162— CodeTokenStreamState::advance has cognitive complexity 17 (threshold 15). Drivers by points: if/else 4 (8 pts), match/switch 4 (7 pts), boolean chains 2 (nesting depth added 7). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
quickwit_index_management::garbage_collection::delete_splits_marked_for_deletion_several_indexes (cognitive 16) quickwit/quickwit-index-management/src/garbage_collection.rs:312— quickwit_index_management::garbage_collection::delete_splits_marked_for_deletion_several_indexes has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (11 pts), loops 2 (3 pts), match/switch 1 (2 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Uploader::handle (cognitive 16) quickwit/quickwit-indexing/src/actors/uploader.rs:277— Uploader::handle has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (10 pts), match/switch 3 (4 pts), loops 2 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MultiKeyOptions::parse (cognitive 16) quickwit/quickwit-macros/src/lib.rs:410— MultiKeyOptions::parse has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (13 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GenericQuickwitSegmentTopKCollector::collect_top_k_block (cognitive 16) quickwit/quickwit-search/src/top_k_collector.rs:711— GenericQuickwitSegmentTopKCollector::collect_top_k_block has cognitive complexity 16 (threshold 15). Drivers by points: loops 4 (10 pts), if/else 4 (6 pts) (nesting depth added 8). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
TooManyFields: SearchQueryParams quickwit/quickwit-serve/src/elasticsearch_api/model/search_query_params.rs:31— TooManyFields — 49 stored fields beside 3 methods. The bar is 30 stored fields; this is 19 over it, 1.63× the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member — each reader then names only the group it uses.
D30 · Dependency Vulnerabilities· Medium advisory (notice) · ×1
REDACTED
D4 · Code Duplication· Members sharing a duplicated core (4 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (4 members, 50+ identical tokens) quickwit/quickwit-proto/src/types/doc_mapping_uid.rs:87— quickwit/quickwit-proto/src/types/doc_mapping_uid.rs:87-113 | quickwit/quickwit-proto/src/types/doc_uid.rs:86-112 | quickwit/quickwit-proto/src/types/index_uid.rs:118-151 | quickwit/quickwit-proto/src/types/pipeline_uid.rs:90-116 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication· Edited copy of a member (47 corresponding lines) · ×1
Edited copy of a member (47 corresponding lines) quickwit/quickwit-cli/src/index.rs:410— quickwit/quickwit-cli/src/index.rs:410-456 | quickwit/quickwit-cli/src/tool.rs:278-326 — These two members are one piece of code written twice and then edited apart: 47 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (48 corresponding lines) · ×1
Edited copy of a member (48 corresponding lines) quickwit/quickwit-control-plane/src/model/mod.rs:470— quickwit/quickwit-control-plane/src/model/mod.rs:470-517 | quickwit/quickwit-control-plane/src/model/mod.rs:524-575 — These two members are one piece of code written twice and then edited apart: 48 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (50 corresponding lines) · ×1
Edited copy of a member (50 corresponding lines) quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs:202— quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs:202-251 | quickwit/quickwit-indexing/src/actors/merge_pipeline.rs:188-240 — These two members are one piece of code written twice and then edited apart: 50 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (43 corresponding lines) · ×1
Edited copy of a member (43 corresponding lines) quickwit/quickwit-common/src/sorted_iter.rs:55— quickwit/quickwit-common/src/sorted_iter.rs:55-97 | quickwit/quickwit-common/src/sorted_iter.rs:141-186 — These two members are one piece of code written twice and then edited apart: 43 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (71 corresponding lines) · ×1
Edited copy of a member (71 corresponding lines) quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs:1075— quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs:1075-1145 | quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs:1148-1231 — These two members are one piece of code written twice and then edited apart: 71 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (41 corresponding lines) · ×1
Edited copy of a member (41 corresponding lines) quickwit/quickwit-serve/src/lib.rs:1203— quickwit/quickwit-serve/src/lib.rs:1203-1248 | quickwit/quickwit-serve/src/lib.rs:1434-1474 — These two members are one piece of code written twice and then edited apart: 41 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (30 corresponding lines) · ×1
Edited copy of a member (30 corresponding lines) quickwit/quickwit-opentelemetry/src/otlp/logs.rs:265— quickwit/quickwit-opentelemetry/src/otlp/logs.rs:265-294 | quickwit/quickwit-opentelemetry/src/otlp/traces.rs:727-756 — These two members are one piece of code written twice and then edited apart: 30 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (29 corresponding lines) · ×1
Edited copy of a member (29 corresponding lines) quickwit/quickwit-control-plane/src/control_plane.rs:694— quickwit/quickwit-control-plane/src/control_plane.rs:694-722 | quickwit/quickwit-control-plane/src/control_plane.rs:733-763 — These two members are one piece of code written twice and then edited apart: 29 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (28 corresponding lines) · ×1
Edited copy of a member (28 corresponding lines) quickwit/quickwit-index-management/src/index.rs:474— quickwit/quickwit-index-management/src/index.rs:474-507 | quickwit/quickwit-index-management/src/index.rs:514-541 — These two members are one piece of code written twice and then edited apart: 28 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (4 members, 16+ corresponding lines) · ×1
Edited copies of one member (4 members, 16+ corresponding lines) quickwit/quickwit-cli/src/index.rs:505— quickwit/quickwit-cli/src/index.rs:505-532 | quickwit/quickwit-cli/src/index.rs:534-566 | quickwit/quickwit-cli/src/source.rs:374-389 | quickwit/quickwit-cli/src/source.rs:391-411 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 16 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (20 corresponding lines) · ×1
Edited copy of a member (20 corresponding lines) quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs:1424— quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs:1424-1443 | quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs:1452-1480 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 16+ corresponding lines) · ×1
Edited copies of one member (3 members, 16+ corresponding lines) quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:585— quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:585-600 | quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:245-260 | quickwit/quickwit-storage/src/opendal_storage/google_cloud_storage.rs:176-191 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 16 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 20+ corresponding lines) · ×1
Edited copies of one member (3 members, 20+ corresponding lines) quickwit/quickwit-metastore/src/metastore/mod.rs:768— quickwit/quickwit-metastore/src/metastore/mod.rs:768-787 | quickwit/quickwit-metastore/src/metastore/mod.rs:791-813 | quickwit/quickwit-metastore/src/metastore/mod.rs:816-835 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 20 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (19 corresponding lines) · ×1
Edited copy of a member (19 corresponding lines) quickwit/quickwit-metastore/src/metastore/mod.rs:1061— quickwit/quickwit-metastore/src/metastore/mod.rs:1061-1079 | quickwit/quickwit-metastore/src/metastore/mod.rs:1082-1100 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (4 members, 17+ corresponding lines) · ×1
Edited copies of one member (4 members, 17+ corresponding lines) quickwit/quickwit-cli/src/index.rs:487— quickwit/quickwit-cli/src/index.rs:487-503 | quickwit/quickwit-cli/src/source.rs:432-452 | quickwit/quickwit-cli/src/source.rs:571-591 | quickwit/quickwit-cli/src/split.rs:317-337 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 17 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (5 members, 14+ corresponding lines) · ×1
Edited copies of one member (5 members, 14+ corresponding lines) quickwit/quickwit-cli/src/source.rs:254— quickwit/quickwit-cli/src/source.rs:254-268 | quickwit/quickwit-cli/src/source.rs:296-311 | quickwit/quickwit-cli/src/source.rs:313-328 | quickwit/quickwit-cli/src/source.rs:330-343 | quickwit/quickwit-cli/src/source.rs:356-371 — These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 14 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (4 members, 9+ corresponding lines) · ×1
Edited copies of one member (4 members, 9+ corresponding lines) quickwit/quickwit-rest-client/src/rest_client.rs:637— quickwit/quickwit-rest-client/src/rest_client.rs:637-645 | quickwit/quickwit-rest-client/src/rest_client.rs:666-674 | quickwit/quickwit-rest-client/src/rest_client.rs:692-700 | quickwit/quickwit-rest-client/src/rest_client.rs:702-710 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (4 members, 11+ corresponding lines) · ×1
Edited copies of one member (4 members, 11+ corresponding lines) quickwit/quickwit-proto/src/cluster/mod.rs:44— quickwit/quickwit-proto/src/cluster/mod.rs:44-54 | quickwit/quickwit-proto/src/compaction/mod.rs:50-60 | quickwit/quickwit-proto/src/control_plane/mod.rs:59-73 | quickwit/quickwit-proto/src/indexing/mod.rs:60-71 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (5 corresponding lines) · ×1
Edited copy of a member (5 corresponding lines) quickwit/quickwit-common/src/uri.rs:345— quickwit/quickwit-common/src/uri.rs:345-349 | quickwit/quickwit-proto/src/types/index_uid.rs:89-93 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (4 members, 8+ corresponding lines) · ×1
Edited copies of one member (4 members, 8+ corresponding lines) quickwit/quickwit-serve/src/delete_task_api/handler.rs:69— quickwit/quickwit-serve/src/delete_task_api/handler.rs:69-76 | quickwit/quickwit-serve/src/index_api/index_resource.rs:179-187 | quickwit/quickwit-serve/src/index_api/source_resource.rs:202-210 | quickwit/quickwit-serve/src/template_api/rest_handler.rs:110-117 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 8 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 8+ corresponding lines) · ×1
Edited copies of one member (3 members, 8+ corresponding lines) quickwit/quickwit-serve/src/index_api/index_resource.rs:44— quickwit/quickwit-serve/src/index_api/index_resource.rs:44-52 | quickwit/quickwit-serve/src/index_api/source_resource.rs:395-403 | quickwit/quickwit-serve/src/template_api/rest_handler.rs:235-242 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 8 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Duplicated block (33–34 lines × 2) quickwit/quickwit-jaeger/src/lib.rs:316— quickwit/quickwit-jaeger/src/lib.rs:316-349 | quickwit/quickwit-jaeger/src/v2.rs:360-392 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-jaeger/src/lib.rs:316` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (34 lines × 2) quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:423— quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:423-456 | quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:745-778 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs:423` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (20–21 lines × 2) quickwit/quickwit-indexing/src/source/kafka_source.rs:479— quickwit/quickwit-indexing/src/source/kafka_source.rs:479-498 | quickwit/quickwit-indexing/src/source/pulsar_source.rs:236-256 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-indexing/src/source/kafka_source.rs:479` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (18–19 lines × 2) quickwit/quickwit-cli/src/index.rs:414— quickwit/quickwit-cli/src/index.rs:414-432 | quickwit/quickwit-cli/src/tool.rs:286-303 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (15–18 lines × 2) quickwit/quickwit-search/src/list_fields/root.rs:119— quickwit/quickwit-search/src/list_fields/root.rs:119-136 | quickwit/quickwit-search/src/list_terms.rs:120-134 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-search/src/list_fields/root.rs:119` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) quickwit/quickwit-query/src/query_ast/wildcard_query.rs:129— quickwit/quickwit-query/src/query_ast/wildcard_query.rs:129-141 | quickwit/quickwit-query/src/query_ast/wildcard_query.rs:148-160 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-query/src/query_ast/wildcard_query.rs:129` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (10–11 lines × 2) quickwit/quickwit-ingest/src/ingest_v2/routing_table.rs:260— quickwit/quickwit-ingest/src/ingest_v2/routing_table.rs:260-270 | quickwit/quickwit-ingest/src/ingest_v2/routing_table.rs:304-313 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-ingest/src/ingest_v2/routing_table.rs:260` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9–10 lines × 2) quickwit/quickwit-search/src/list_fields/root.rs:161— quickwit/quickwit-search/src/list_fields/root.rs:161-170 | quickwit/quickwit-search/src/list_terms.rs:192-200 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-search/src/list_fields/root.rs:161` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `request` to `&ListFieldsRequest` in one and `&ListTermsRequest` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (33 lines × 2) quickwit/quickwit-codegen/example/src/error.rs:40— quickwit/quickwit-codegen/example/src/error.rs:40-86 | quickwit/quickwit-proto/src/developer/mod.rs:42-74 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-codegen/example/src/error.rs:40` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (8 lines × 3) quickwit/quickwit-compaction/src/compaction_pipeline.rs:85— quickwit/quickwit-compaction/src/compaction_pipeline.rs:85-92 | quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs:101-108 | quickwit/quickwit-indexing/src/actors/merge_pipeline.rs:86-93 — before extracting anything, compare `quickwit/quickwit-indexing/src/actors/indexing_pipeline.rs` and `quickwit/quickwit-indexing/src/actors/merge_pipeline.rs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 57 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (8 lines × 6) quickwit/quickwit-config/src/metastore_config.rs:74— quickwit/quickwit-config/src/metastore_config.rs:74-81 | quickwit/quickwit-config/src/storage_config.rs:127-134 | quickwit/quickwit-config/src/storage_config.rs:136-143 | quickwit/quickwit-config/src/storage_config.rs:145-152 | quickwit/quickwit-config/src/storage_config.rs:154-161 | quickwit/quickwit-config/src/storage_config.rs:163-170 — there are 6 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 6 sites; resolving a subset leaves the remainder to drift apart.
Duplicated block (12 lines × 3) quickwit/quickwit-indexing/src/source/ingest/mod.rs:480— quickwit/quickwit-indexing/src/source/ingest/mod.rs:480-491 | quickwit/quickwit-indexing/src/source/kafka_source.rs:484-495 | quickwit/quickwit-indexing/src/source/pulsar_source.rs:241-253 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-indexing/src/source/ingest/mod.rs:480` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (10 lines × 4) quickwit/quickwit-proto/src/types/doc_mapping_uid.rs:98— quickwit/quickwit-proto/src/types/doc_mapping_uid.rs:98-107 | quickwit/quickwit-proto/src/types/doc_uid.rs:97-106 | quickwit/quickwit-proto/src/types/index_uid.rs:136-145 | quickwit/quickwit-proto/src/types/pipeline_uid.rs:101-110 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 4 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `quickwit/quickwit-proto/src/types/doc_mapping_uid.rs:98` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication· Edited copies of one member (3 members, 32+ corresponding lines) · ×1
Edited copies of one member (3 members, 32+ corresponding lines) quickwit/quickwit-integration-tests/src/test_utils/cluster_sandbox.rs:476— quickwit/quickwit-integration-tests/src/test_utils/cluster_sandbox.rs:476-508 | quickwit/quickwit-integration-tests/src/test_utils/cluster_sandbox.rs:516-547 | quickwit/quickwit-integration-tests/src/test_utils/cluster_sandbox.rs:555-593 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 32 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Coverage not measured — JavaScript/TypeScript suite — Coverage NOT MEASURED: the JavaScript/TypeScript half could not be measured — the jest suite in quickwit/quickwit-ui/ ran and not one test passed (FAIL src/views/SearchView.test.jsx), so the coverage would describe the failed run, not the code. Coverage is excluded from the score rather than counted as a near-zero. The named suite step is one the repository's maintainers can perform; once it passes, the real number is measured on the next scan.
P12 · CI test-gate honesty· Coverage collected but not gated · ×1
Coverage collected but not gated — CI collects a coverage report but no step enforces a minimum — coverage could halve and CI stays green. Add a step that fails the build when coverage drops below a floor (your coverage tool's minimum-threshold flag, or a coverage-gate action) so the number guards something. What was searched, so you can tell an absence from a miss: this repository's CI files AND its coverage configuration — the well-known coverage and test-runner config files, read at the repository root and inside workspace package directories two levels down, so a floor declared beside the tests rather than in the pipeline is credited — matched against the threshold settings this check knows by name. A floor set in your coverage service's web UI rather than in a committed file, or under a setting whose name is not one of those, is not seen here.
Outbound HTTP without resilience quickwit/quickwit-indexing/src/source/pulsar_source.rs:624— `reqwest::Client::new(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
Duplicated block (17 lines × 2 locations) quickwit/quickwit-ui/src/components/TimeRangeSelect.tsx:233— quickwit/quickwit-ui/src/components/TimeRangeSelect.tsx:233 · quickwit/quickwit-ui/src/components/TimeRangeSelect.tsx:252 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (13 lines × 2 locations) quickwit/quickwit-ui/src/components/QueryEditor/AggregationEditor.tsx:189— quickwit/quickwit-ui/src/components/QueryEditor/AggregationEditor.tsx:189 · quickwit/quickwit-ui/src/components/QueryEditor/AggregationEditor.tsx:204 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
Complex function parseSearchUrl (cyclomatic 11, cognitive 12) quickwit/quickwit-ui/src/utils/urls.ts:28— parseSearchUrl has cyclomatic complexity 11 and cognitive complexity 12; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Dead file (~54 LoC) quickwit/quickwit-ui/src/providers/EditorProvider.tsx— no import path from any entry point (7 application, 3 tooling, 11 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Unused dependency '@emotion/react' — Declared in quickwit/quickwit-ui/package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
Unused dependency '@mui/system' — Declared in quickwit/quickwit-ui/package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
Unused dependency '@testing-library/user-event' — Declared in quickwit/quickwit-ui/package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
Unused dependency 'styled-components' — Declared in quickwit/quickwit-ui/package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
Unused dependency 'styled-icons' — Declared in quickwit/quickwit-ui/package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
X15 · Unvalidated length from an untrusted reader· Length read from the parsed input is spent without ever being bounded · ×1
Length read from the parsed input is spent without ever being bounded quickwit/scripts/inspect_split.py:70— `meta_len` is read from the bytes being parsed at line 63 (`struct.unpack("<I")`), then passed as the size of `read` at line 70 — and nowhere in its function is `meta_len` compared to anything, clamped, or bounded against the input that remains. Whoever wrote those bytes therefore chooses the allocation directly: the call reserves the whole length before a single byte of the payload is known to exist, so a 32-bit length asks for up to 4 GiB (a 64-bit one for more than any machine has), and the reservation either raises `MemoryError` out of a parser whose failure path was written for malformed input, not for hostile input, or succeeds and holds gigabytes for a few bytes on the wire. Bound `meta_len` against the bytes actually remaining and a maximum the format allows before reading.
Interpolated log message defeats structured logging quickwit/quickwit-transport/src/accept.rs:59— `error!` at line 59 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging quickwit/quickwit-transport/src/accept.rs:68— `error!` at line 68 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging quickwit/quickwit-transport/src/tls.rs:113— `warn!` at line 113 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `warn!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging quickwit/quickwit-transport/src/tls.rs:299— `error!` at line 299 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging quickwit/quickwit-transport/src/tls.rs:306— `error!` at line 306 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:1190— `warn!` at line 1190 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `warn!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging quickwit/quickwit-storage/src/object_storage/s3_compatible_storage.rs:1203— `warn!` at line 1203 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `warn!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging quickwit/quickwit-serve/src/lib.rs:237— `info!` at line 237 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `info!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging quickwit/quickwit-serve/src/lib.rs:248— `info!` at line 248 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `info!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging quickwit/quickwit-serve/src/lib.rs:529— `error!` at line 529 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging quickwit/quickwit-serve/src/lib.rs:534— `error!` at line 534 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging quickwit/quickwit-serve/src/lib.rs:547— `error!` at line 547 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging quickwit/quickwit-serve/src/lib.rs:550— `error!` at line 550 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging quickwit/quickwit-serve/src/lib.rs:566— `debug!` at line 566 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `debug!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging quickwit/quickwit-serve/src/lib.rs:1210— `info!` at line 1210 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `info!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging quickwit/quickwit-serve/src/lib.rs:1441— `info!` at line 1441 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `info!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging quickwit/quickwit-serve/src/metrics_api.rs:44— `error!` at line 44 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging quickwit/quickwit-serve/src/rest.rs:358— `info!` at line 358 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `info!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging quickwit/quickwit-serve/src/rest.rs:394— `error!` at line 394 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging quickwit/quickwit-serve/src/rest.rs:412— `info!` at line 412 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `info!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging quickwit/quickwit-serve/src/rest.rs:417— `info!` at line 417 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `info!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging quickwit/quickwit-serve/src/rest.rs:421— `info!` at line 421 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `info!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging quickwit/quickwit-serve/src/rest.rs:453— `error!` at line 453 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging quickwit/quickwit-serve/src/rest.rs:476— `error!` at line 476 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging quickwit/quickwit-serve/src/rest.rs:614— `error!` at line 614 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Orphaned file quickwit/quickwit-serve/src/index_api/index_resource.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file quickwit/quickwit-common/src/temp_dir.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file quickwit/quickwit-common/src/alloc_tracker.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file quickwit/quickwit-serve/src/index_api/source_resource.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file quickwit/quickwit-indexing/src/source/queue_sources/message.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file quickwit/quickwit-ingest/src/doc_batch.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file quickwit/quickwit-indexing/src/source/queue_sources/visibility.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file quickwit/quickwit-ingest/src/ingest_v2/publish_tracker.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file quickwit/quickwit-common/src/jemalloc_profiled.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file quickwit/quickwit-serve/src/ingest_api/response.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file quickwit/quickwit-directories/src/debug_proxy_directory.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file quickwit/quickwit-indexing/src/source/queue_sources/memory_queue.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file quickwit/quickwit-serve/src/index_api/split_resource.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file quickwit/quickwit-control-plane/src/cooldown_map.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file quickwit/quickwit-jaeger/src/v1.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file quickwit/quickwit-ingest/src/notifications.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file quickwit/quickwit-search/src/metrics_trackers.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file quickwit/quickwit-indexing/src/source/queue_sources/local_state.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file quickwit/quickwit-query/src/elastic_query_dsl/wildcard_query.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file quickwit/quickwit-serve/src/jaeger_api/parse_duration.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file quickwit/quickwit-indexing/src/source/queue_sources/helpers.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file quickwit/quickwit-query/src/elastic_query_dsl/prefix_query.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file quickwit/quickwit-indexing/src/source/queue_sources/mod.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file quickwit/quickwit-serve/src/elasticsearch_api/model/search_response.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 7 significant file(s) lose their only recent owner: quickwit/quickwit-query/src/query_ast/regex_extract_eq.rs, quickwit/quickwit-metrics/src/lib.rs, quickwit/quickwit-indexing/src/docs_clustering/fingerprinter.rs, quickwit/quickwit-config/src/docs_clustering.rs, quickwit/quickwit-metrics/src/inner.rs, quickwit/quickwit-indexing/src/docs_clustering/clusterer.rs, quickwit/quickwit-indexing/src/docs_clustering/mod.rs. Pair on, review, or document these before any departure.
Off-boarding risk: anonymized user #2 — If anonymized user #2 becomes unavailable, 5 significant file(s) lose their only recent owner: quickwit/quickwit-serve/src/mcp_api/tests.rs, quickwit/quickwit-serve/src/mcp_api/tools.rs, quickwit/quickwit-serve/src/mcp_api/mod.rs, quickwit/quickwit-serve/src/mcp_api/protocol.rs, quickwit/quickwit-ingest/src/ndjson.rs. Pair on, review, or document these before any departure.
Off-boarding risk: anonymized user #3 — If anonymized user #3 becomes unavailable, 4 significant file(s) lose their only recent owner: quickwit/quickwit-control-plane/src/indexing_scheduler/scheduling/optimization.rs, quickwit/quickwit-compaction/src/compaction_pipeline.rs, quickwit/quickwit-config/src/config_value.rs, quickwit/quickwit-compaction/src/lib.rs. Pair on, review, or document these before any departure.
Off-boarding risk: anonymized user #4 — If anonymized user #4 becomes unavailable, 4 significant file(s) lose their only recent owner: quickwit/quickwit-ingest/src/ingest_v2/mrecordlog_utils.rs, quickwit/quickwit-actors/src/registry.rs, quickwit/scripts/inspect_split.py, quickwit/quickwit-serve/src/build_info.rs. Pair on, review, or document these before any departure.
X7 · Silent fallback defaults· Pending state with no failure state · ×2
Pending state with no failure state quickwit/quickwit-ui/src/views/IndexView.tsx:86— The view draws `<Loader/>` under `loading || index === undefined`, but `loading` is settled by a load that can fail and the component draws no failure state, so a failed load is shown as "not yet" for ever, or as the loaded state over its initial value. Give the component a failure state and draw it.
Pending state with no failure state quickwit/quickwit-ui/src/views/NodeInfoView.tsx:90— The view draws `<Loader/>` under `loadingCounter !== 0`, but `loadingCounter` is settled by a load that can fail and the component draws no failure state, so a failed load is shown as "not yet" for ever, or as the loaded state over its initial value. Give the component a failure state and draw it.
Silent fallback default on Err quickwit/quickwit-ingest/src/ingest_v2/broadcast/local_shards.rs:264— `snapshot_local_shards` turns every `Err` into `Some(LocalShardsSnapshot::default())` — a failure becomes a plausible value and a silent behavior change with no trail. Log the error or propagate it with `?`. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment on the arm or in the doc comment, and the row stops firing.
Silent fallback default on Err quickwit/quickwit-proto/src/error.rs:182— `decode_error` turns every `Err` into `"invalid JSON".to_string()` — a failure becomes a plausible value and a silent behavior change with no trail. Log the error or propagate it with `?`. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment on the arm or in the doc comment, and the row stops firing.
C2 · Access Controls· No named authorization policies · ×1
No named authorization policies — Authorization IS enforced here (by route guards, auth middleware or checks that refuse a caller) — this is NOT a claim that endpoints are unprotected. What's missing is a NAMED rule set: who may do what is encoded inline where it is checked, so the rules can't be listed, reviewed or tested apart from the code that applies them. Recommendation, not a defect.
D16 · Bus Factor· Further sole-owners (lower concentration) · ×1
Further sole-owners (lower concentration) — 7 other contributor(s) are each the sole owner of a small amount of code below the off-boarding threshold — folded into the bus-factor score and metrics (29 single-owned of 519 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated, example/demo and scaffolding-template trees and test files identified by path convention, largest first; 519 of the 633 production source files in this repository met that bar). They are anonymized user #5 (2 file(s)), anonymized user #6 (1 file(s)), anonymized user #7 (1 file(s)), anonymized user #8 (1 file(s)), anonymized user #9 (1 file(s)), anonymized user #10 (1 file(s)) (+1 more) — spread or document their files in the same way, at lower priority than the named off-boarding risks above. The files folded here: quickwit/quickwit-lambda-server/src/handler.rs, quickwit/quickwit-aws/src/dns.rs, quickwit/quickwit-query/src/query_ast/required_terms.rs, quickwit/quickwit-search/src/retry/search.rs, quickwit/quickwit-proto/src/types/doc_uid.rs, quickwit/quickwit-ui/src/components/SearchResult/Row.tsx, quickwit/quickwit-indexing/src/actors/sequencer.rs, quickwit/quickwit-query/src/elastic_query_dsl/term_query.rs.
No ADRs found quickwit/quickwit-metrics-inventory/src/main.rs:1— No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`. ADRs are expected here because `quickwit/quickwit-metrics-inventory/src/main.rs` makes this repository a deployable product (line 1).
D26 · Project Cohesion· Projects may be oversized for their cohesion · ×1
Projects may be oversized for their cohesion — 3 of 36 project(s) overshoot their size bounds, lowering Project Cohesion to 8.4/10. The most over is `quickwit/quickwit-indexing` (32262 LoC, 160 module-visible types across 11 directories). Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.
D34 · Knowledge Freshness· Further orphaned files (smaller) · ×1
Further orphaned files (smaller) — 24 smaller file(s) also have no living knowledge — folded into the freshness score and metrics rather than raised one row each — most significant first: quickwit/quickwit-serve/src/index_api/index_resource.rs, quickwit/quickwit-common/src/temp_dir.rs, quickwit/quickwit-common/src/alloc_tracker.rs, quickwit/quickwit-serve/src/index_api/source_resource.rs, quickwit/quickwit-indexing/src/source/queue_sources/message.rs, quickwit/quickwit-ingest/src/doc_batch.rs, quickwit/quickwit-indexing/src/source/queue_sources/visibility.rs, quickwit/quickwit-ingest/src/ingest_v2/publish_tracker.rs (and 16 more) (28 orphaned of 519 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated, example/demo and scaffolding-template trees and test files identified by path convention, largest first; 519 of the 633 production source files in this repository met that bar). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway.
No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
README/code drift quickwit/quickwit-control-plane/README.md:36— quickwit/quickwit-control-plane/README.md links to `./src/scheduler.rs#L66`, but `quickwit/quickwit-control-plane/src/scheduler.rs` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
P10 · Library API & versioning· Implementation type on the public API · ×1
Implementation type on the public API quickwit/quickwit-search/src/service.rs:49— 1 public type in `quickwit_search.service` is marked as implementation by its own namespace, folder or name: `SearchServiceImpl` (quickwit/quickwit-search/src/service.rs:49, name ends in `Impl`). While it is public, every consumer of the library can bind to it, so changing it is a breaking change for those consumers.
Logging is not universal — Only 28/30 runnable modules use logging (modules with no entry point or server are excluded — they are libraries a runnable module hosts). Silent: `quickwit/quickwit-metastore-utils`, `quickwit/quickwit-metrics-inventory`.
P3 · Security & performance tooling· Dependabot does not watch pip · ×1
Dependabot does not watch pip REDACTED:2— `REDACTED` schedules updates, but no `package-ecosystem` entry covers `pip`, which this tree depends on — so those dependencies get no update pull requests and no advisory pressure, however complete the dep-scan credit looks. Add the missing entry to the `updates:` list.
R7 · Dead Code· Unused export 'setErrorMarker' · ×1
Unused export 'setErrorMarker' quickwit/quickwit-ui/src/components/QueryEditor/config.ts:183— Nothing imports this binding — it is safe to review for removal.
R7 · Dead Code· Unused export 'DATE_TIME_WITH_MILLISECONDS_FORMAT' · ×1
Unused export 'DATE_TIME_WITH_MILLISECONDS_FORMAT' quickwit/quickwit-ui/src/utils/models.ts:43— Nothing imports this binding — it is safe to review for removal.
R7 · Dead Code· Unused export 'EMPTY_INDEX_METADATA' · ×1
Unused export 'EMPTY_INDEX_METADATA' quickwit/quickwit-ui/src/utils/models.ts:242— Nothing imports this binding — it is safe to review for removal.
Unused export 'QUICKWIT_RED' quickwit/quickwit-ui/src/utils/theme.ts:22— Nothing imports this binding — it is safe to review for removal.
R7 · Dead Code· Unused export 'QUICKWIT_GREEN' · ×1
Unused export 'QUICKWIT_GREEN' quickwit/quickwit-ui/src/utils/theme.ts:23— Nothing imports this binding — it is safe to review for removal.
R7 · Dead Code· Unused export 'QUICKWIT_GREY' · ×1
Unused export 'QUICKWIT_GREY' quickwit/quickwit-ui/src/utils/theme.ts:24— Nothing imports this binding — it is safe to review for removal.
R7 · Dead Code· Unused export 'QUICKWIT_BLACK' · ×1
Unused export 'QUICKWIT_BLACK' quickwit/quickwit-ui/src/utils/theme.ts:27— Nothing imports this binding — it is safe to review for removal.
R8 · Dependency Hygiene· Test-only dependency '@testing-library/react' in production deps · ×1
Test-only dependency '@testing-library/react' in production deps quickwit/quickwit-ui/package.json:23— Only test files import it (first: quickwit/quickwit-ui/src/index.test.js:16) — move it to devDependencies.
No security response headers detected — None of the 11 security response headers the OWASP Secure Headers Project recommends (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options, …) is set on a response this repository's Rust server sends — defense in depth, even when a proxy could set them. (−2.0 on this card.) The server: `.serve_connection_with_upgrades(` (quickwit/quickwit-serve/src/rest.rs:399).
Duplicated predicate quickwit/quickwit-config/src/node_config/mod.rs:139— `self.max_connection_age_grace.is_some() && self.max_connection_age.is_none()` appears character-identically in 2 files — quickwit/quickwit-config/src/node_config/mod.rs, quickwit/quickwit-config/src/node_config/serialize.rs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Null assertions (`!`) override strict null checking — ~0.7 `!` null assertions per 1k TypeScript source lines — 3 assertion(s) across the 4301 source line(s) of the 34 TypeScript file(s) read, which is the only code the operator asserts anything in (a `!` in a `.js` file is not this operator and was not counted, and one in a file whose null checking is off silences nothing). Densest: quickwit/quickwit-ui/src/components/QueryEditor/AggregationEditor.tsx (2), quickwit/quickwit-ui/src/index.tsx (1). Each one tells the compiler to trust the author about null, suppressing the very diagnostic `strictNullChecks` exists to produce. Many are correct: each is a claim the checker could not verify, and it is wrong only where the value can in fact be missing, so review the densest places first.
Outdated: arc-swap — `arc-swap` is locked at 1.9.3 but 1.9.5 is the current stable release on crates.io, and it already satisfies the `"1.9"` requirement declared in quickwit/quickwit-indexing/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p arc-swap` and commit the updated REDACTED.
Outdated: async-compression — `async-compression` is locked at 0.4.51 but 0.4.52 is the current stable release on crates.io, and it already satisfies the `"0.4"` requirement declared in quickwit/quickwit-indexing/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p async-compression` and commit the updated REDACTED.
Outdated: aws-config — `aws-config` is locked at 1.13.0 but 1.13.2 is the current stable release on crates.io, and it already satisfies the `"1.13"` requirement declared in quickwit/quickwit-aws/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p aws-config` and commit the updated REDACTED.
Outdated: aws-runtime — `aws-runtime` is locked at 1.10.2 but 1.10.4 is the current stable release on crates.io, and it already satisfies the `"1.10"` requirement declared in quickwit/quickwit-aws/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p aws-runtime` and commit the updated REDACTED.
Outdated: aws-sdk-kinesis — `aws-sdk-kinesis` is locked at 1.127.0 but 1.132.0 is the current stable release on crates.io, and it already satisfies the `"1.126"` requirement declared in quickwit/quickwit-aws/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p aws-sdk-kinesis` and commit the updated REDACTED.
Outdated: aws-sdk-lambda — `aws-sdk-lambda` is locked at 1.153.0 but 1.159.0 is the current stable release on crates.io, and it already satisfies the `"1"` requirement declared in quickwit/quickwit-lambda-client/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p aws-sdk-lambda` and commit the updated REDACTED.
Outdated: aws-sdk-s3 — `aws-sdk-s3` is locked at 1.154.0 but 1.159.0 is the current stable release on crates.io, and it already satisfies the `"1.153"` requirement declared in quickwit/quickwit-aws/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p aws-sdk-s3` and commit the updated REDACTED.
Outdated: aws-sdk-sqs — `aws-sdk-sqs` is locked at 1.116.0 but 1.121.0 is the current stable release on crates.io, and it already satisfies the `"1.115"` requirement declared in quickwit/quickwit-aws/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p aws-sdk-sqs` and commit the updated REDACTED.
Outdated: aws-smithy-http-client — `aws-smithy-http-client` is locked at 1.5.1 but 1.5.2 is the current stable release on crates.io, and it already satisfies the `"1.5"` requirement declared in quickwit/quickwit-aws/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p aws-smithy-http-client` and commit the updated REDACTED.
Outdated: aws-smithy-runtime-api — `aws-smithy-runtime-api` is locked at 1.19.1 but 1.21.0 is the current stable release on crates.io, and it already satisfies the `"1.19"` requirement declared in quickwit/quickwit-aws/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p aws-smithy-runtime-api` and commit the updated REDACTED.
Outdated: aws-smithy-types — `aws-smithy-types` is locked at 1.9.0 but 1.9.4 is the current stable release on crates.io, and it already satisfies the `"1.9"` requirement declared in quickwit/quickwit-aws/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p aws-smithy-types` and commit the updated REDACTED.
Outdated: backtrace — `backtrace` is locked at 0.3.76 but 0.3.77 is the current stable release on crates.io, and it already satisfies the `"0.3"` requirement declared in quickwit/quickwit-cli/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p backtrace` and commit the updated REDACTED.
Outdated: bytestring — `bytestring` is locked at 1.5.1 but 1.6.0 is the current stable release on crates.io, and it already satisfies the `"1.5"` requirement declared in quickwit/quickwit-proto/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p bytestring` and commit the updated REDACTED.
Outdated: const_format — `const_format` is locked at 0.2.36 but 0.2.37 is the current stable release on crates.io, and it already satisfies the `"0.2"` requirement declared in quickwit/quickwit-metrics/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p const_format` and commit the updated REDACTED.
Outdated: flate2 — `flate2` is locked at 1.1.10 but 1.1.11 is the current stable release on crates.io, and it already satisfies the `"1.1"` requirement declared in quickwit/quickwit-serve/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p flate2` and commit the updated REDACTED.
Outdated: libz-sys — `libz-sys` is locked at 1.1.30 but 1.1.33 is the current stable release on crates.io, and it already satisfies the `"1.1"` requirement declared in quickwit/quickwit-indexing/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p libz-sys` and commit the updated REDACTED.
Outdated: openssl — `openssl` is locked at 0.10.81 but 0.10.82 is the current stable release on crates.io, and it already satisfies the `"0.10"` requirement declared in quickwit/quickwit-indexing/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p openssl` and commit the updated REDACTED.
Outdated: openssl-probe — `openssl-probe` is locked at 0.2.1 but 0.2.2 is the current stable release on crates.io, and it already satisfies the `"0.2"` requirement declared in quickwit/quickwit-cli/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p openssl-probe` and commit the updated REDACTED.
Outdated: prost — `prost` is locked at 0.14.4 but 0.14.6 is the current stable release on crates.io, and it already satisfies the `"0.14"` requirement declared in quickwit/quickwit-ingest/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p prost` and commit the updated REDACTED.
Outdated: prost-build — `prost-build` is locked at 0.14.4 but 0.14.6 is the current stable release on crates.io, and it already satisfies the `"0.14"` requirement declared in quickwit/quickwit-codegen/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p prost-build` and commit the updated REDACTED.
Outdated: prost-types — `prost-types` is locked at 0.14.4 but 0.14.6 is the current stable release on crates.io, and it already satisfies the `"0.14"` requirement declared in quickwit/quickwit-jaeger/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p prost-types` and commit the updated REDACTED.
Outdated: rust-embed — `rust-embed` is locked at 8.13.0 but 8.14.0 is the current stable release on crates.io, and it already satisfies the `"8.13"` requirement declared in quickwit/quickwit-serve/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p rust-embed` and commit the updated REDACTED.
Outdated: smallvec — `smallvec` is locked at 1.16.3 but 1.16.5 is the current stable release on crates.io, and it already satisfies the `"1"` requirement declared in quickwit/quickwit-control-plane/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p smallvec` and commit the updated REDACTED.
Outdated: syn — `syn` is locked at 3.0.9 but 3.0.10 is the current stable release on crates.io, and it already satisfies the `"3.0"` requirement declared in quickwit/quickwit-codegen/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p syn` and commit the updated REDACTED.
Outdated: sysinfo — `sysinfo` is locked at 0.40.1 but 0.40.3 is the current stable release on crates.io, and it already satisfies the `"0.40"` requirement declared in quickwit/quickwit-common/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p sysinfo` and commit the updated REDACTED.
Off the main sequence: quickwit-common — quickwit-common: abstractness 0.16, instability 0.04, distance 0.80 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.
Appendix B — Reproduction & audit trail
Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.
semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 1 file(s) — `quickwit/quickwit-ui/vite.config.ts` — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
Run 01a1dac5-9746-7baa-86c1-716c47c78c7e · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.
Issues: 64 · Warnings: 665 · Recommendations: 100 · Info: 37 — Appendix A · all findings · full markdown report.
Generated by the Canine Code Analyzer: deterministic code-health analysis. 14-11-2026 @ 15:55 UTC.
Downloadable artifacts
Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.