Public report of phili67/ecclesiacrm, published 17 November 2026. It has the same score, grades and number of findings as the full report. The details of security findings (where they are in the code, which known vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive report Measured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.11.4). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey → Signed and filed in the standard's public register, 17 November 2026, 13:48 UTC · Survey ID cd_0e5b8965bc3644d28b4929aafbe96ec1

phili67/ecclesiacrm

Measured 17 November 2026, 13:45 UTC, at code version a8ae63b

First survey, so nothing to compare with yet Supply-chain provenance & signing: not measured

Supply-chain provenance & signing is not measured: Supply-chain provenance is not scored (this pipeline releases no artifact), but its build steps or GitHub Actions workflows have integrity defects, or nothing watches its dependency set for published advisories.

CAI score 23.6out of 100 At risk

The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.

A large codebase: 130,080 lines of product code in 4 projects, tests not counted · Estimated rebuild effort: about 0.8 person-years · Weakest lens: Production Readiness, 10.3

Findings by how serious they are

189 critical 1675 serious 86 minor

14 dimensions are left out of the score. For each one, we either couldn't measure it in this code, or found no evidence of the safeguard we look for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.

This survey was produced by

Assert small markCanine Code Analyzer
Producer
Canine Development
Analyzer
Canine Code Analyzer engine 1.0.0
Measured
17 November 2026, 13:45 UTC

A measurement, not a certificate. The Code Assurance Index records a number together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee the code. The standard was written by Canine Development, which also builds the Canine Code Analyzer. It is open to any tool that implements it, and today the Canine Code Analyzer is the only one that does.

A critical security finding is open, such as a library with a known critical vulnerability or a password or key found in the code. The score itself is unchanged, but its band shows At risk until the finding is fixed. See the Security and Compliance lens.

The score is deterministic, which means the same code always gets the same score. We work it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸

70of 70 dimensions measured by tools.
1934of 1950 findings point to an exact file and line, so you can open each one in the code. The other 16 concern the repository as a whole, such as missing documentation.
70dimensions across 7 lenses, read from 130,080 lines of product code in 4 projects.
Chapters

Executive summary

phili67/ecclesiacrm is rated At risk because critical security findings are open. Its score is held back because the project has no automated tests and five passwords or keys sit in the current code. It scores 23.6 out of 100, which the At risk rating leaves unchanged.

Production Readiness, at 10.3, is the weakest lens and counts most in the score. The best first steps are replacing the five exposed passwords or keys and switching the old ones off and adding automated tests, each worth about 12.0 points. Raising Production Readiness to 70 would lift the score to about 34.6.

Forty-three settings leave the servers or containers unsafe. Twenty-nine weaknesses in the code could be used by an attacker, and twenty-three passwords or keys in the code's history and five in the code are open to anyone who can read the repository. Correcting the unsafe settings, fixing the weaknesses the scanner points to and replacing each exposed password or key would close these risks. Updating the vulnerable packages would fix the package with a known security hole, and the pipeline step that runs a download without checking it needs each download checked against a known checksum first. The 26 form fields without a label need a label.

The product code is 130,080 lines, about €110,000 to rebuild.

A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.

How the score is built: what each lens counts for The lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
Production Readiness 10.3 · counts for 46%Code Health 16.7 · counts for 25%Accessibility 38.0 · counts for 14%Security and Compliance 51.0 · counts for 8%Maturity 52.8 · counts for 4%Architecture 91.9 · counts for 2%Performance 100.0 · counts for 1%

If Production Readiness rose from 10.3 to 70, the lowest score rated Strong, the score would rise from 23.6 to about 34.6.

Code composition: what the lines of code are
Product code 100%
Rebuild cost: about €110,000 · Estimate
Cost to rebuild€37,000 to €180,000, for 613 to 1,945 hours of work, about 0.8 person-years for 1 to 2 engineers
Difficulty of the problemStandard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor×0.7 at a score of 24. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
SizeLarge: 130,080 lines of product code
What it is notNot a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.

How the estimate is made: We price the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.

Top priorities

The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.

1
Resolve the 5 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED (2), REDACTED, REDACTED.
Raises the score by about 12.0 points · Low effort · REDACTED Scanning
2
Resolve the 1 No automated tests finding(s) in Code Coverage.
Raises the score by about 12.0 points · High effort · Code Coverage
3
Resolve the 1 No ADRs found finding(s) in ADR Quality — start with composer.json.
Raises the score by about 1.4 points · Low effort · ADR Quality

Diagnosis: what the measurements show together

Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.

Where the investment is most exposed · Value at risk
This code would cost about €110,000 to build again, about 0.8 person-years of work. Its weakest lens is Production Readiness, at 10.3 (Critical). Production Readiness is about whether the product is ready to run in production and to change without breaking. Because the weakest lens counts most in the score, work on Production Readiness also moves the score most.
Based on: the rebuild estimate · the Production Readiness grade · how much each lens counts
What to do: Start with the Production Readiness actions in Top priorities.
If you do one thing first · First action
Resolve the 5 Leaked secret finding(s) in REDACTED Scanning. Of all the actions in this report, it raises the score most for the work it takes: about 12.0 points for low effort, because it clears the 5 REDACTED Scanning findings. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
What hard-to-read code costs each year · Cost
Four dimensions measure how easy the code is to work in: two measure how tangled its logic is, one how much of it is copied, and one how well each part sticks to a single job. In this codebase they average 4.2 out of 10. Code at that level is slower to change than clean code, and we estimate the extra work at 10% to 21% on every change. The history of the code shows how much it changes: about 811,125 lines over the last 90 days, which is about 3,289,562 lines a year. At that pace, the extra work comes to an estimated 781.5 to 4688.9 engineer-days a year, and it grows as more code changes.
How this is estimated: The number of changed lines is measured from the history of the code. The rest rests on two assumptions of our own: code scoring 8 out of 10 or more adds no extra work, and each point below 8 adds 2.5% to 5.6% to every change, never less than 2% to 5% and never more than 40% to 60% in all; and an engineer changes 150 to 400 lines in a day. The result is a range for planning, not a measurement.
Based on: Cyclomatic Complexity · Cognitive Complexity · Code Duplication · Cohesion (LCOM4) · the code's change history
What to do: Start with the files listed under Churn × Complexity Hotspots, which change often and are hard to read, because that is where the extra work is paid most often.

Architecture: which parts of the code depend on which

The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.

80 modules, with 27 dependencies between them. Every module uses only modules listed above it, so there are no loops.

The table shows the 40 modules with the most connections; 40 more are left out to keep it readable.

Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
uses →1 Documentation2 EcclesiaCRM.Auth3 EcclesiaCRM.Backup4 EcclesiaCRM.Base5 EcclesiaCRM.Emails6 EcclesiaCRM.MenuBar7 EcclesiaCRM.MyVCalendar8 EcclesiaCRM.PersonalServer9 EcclesiaCRM.Reports10 EcclesiaCRM.Search11 EcclesiaCRM.Slim12 EcclesiaCRM.Slim.Error13 EcclesiaCRM.Synchronize14 EcclesiaCRM.Tasks15 EcclesiaCRM.Utils16 EcclesiaCRM.Utils.CSVImport17 EcclesiaCRM.WebDav18 EcclesiaCRM.WebDav.Utils19 EcclesiaCRM.data20 Propel.Runtime.ActiveQuery21 Psr.Container22 Sabre.WebDAV.Backend23 Slim.Http24 (global)25 EcclesiaCRM26 EcclesiaCRM.MyPDO27 EcclesiaCRM.Slim.Middleware28 EcclesiaCRM.VIEWControllers29 EcclesiaCRM.VIEWControllers.BackupRestore30 PluginStore.Base31 PluginStore.Map32 Plugins.APIControllers33 Plugins.Synchronize34 Plugins.VIEWControllers35 EcclesiaCRM.CardDav36 EcclesiaCRM.Service37 EcclesiaCRM.dto38 PluginStore39 Sabre.DAVACL.FS40 EcclesiaCRM.APIControllers
1 Documentation
2 EcclesiaCRM.Auth
3 EcclesiaCRM.Backup
4 EcclesiaCRM.Base
5 EcclesiaCRM.Emails
6 EcclesiaCRM.MenuBar
7 EcclesiaCRM.MyVCalendar
8 EcclesiaCRM.PersonalServer
9 EcclesiaCRM.Reports
10 EcclesiaCRM.Search
11 EcclesiaCRM.Slim
12 EcclesiaCRM.Slim.Error
13 EcclesiaCRM.Synchronize
14 EcclesiaCRM.Tasks
15 EcclesiaCRM.Utils
16 EcclesiaCRM.Utils.CSVImport
17 EcclesiaCRM.WebDav
18 EcclesiaCRM.WebDav.Utils
19 EcclesiaCRM.data
20 Propel.Runtime.ActiveQuery
21 Psr.Container
22 Sabre.WebDAV.Backend
23 Slim.Http
24 (global)7
25 EcclesiaCRM11
26 EcclesiaCRM.MyPDO1
27 EcclesiaCRM.Slim.Middleware1
28 EcclesiaCRM.VIEWControllers2956
29 EcclesiaCRM.VIEWControllers.BackupRestore24
30 PluginStore.Base16
31 PluginStore.Map8
32 Plugins.APIControllers510
33 Plugins.Synchronize5
34 Plugins.VIEWControllers24
35 EcclesiaCRM.CardDav1
36 EcclesiaCRM.Service3
37 EcclesiaCRM.dto21
38 PluginStore16
39 Sabre.DAVACL.FS24
40 EcclesiaCRM.APIControllers459211
Uses a module listed above itPart of a loopThe module itself
1 Documentation2 EcclesiaCRM.Auth3 EcclesiaCRM.Backup4 EcclesiaCRM.Base5 EcclesiaCRM.Emails6 EcclesiaCRM.MenuBar7 EcclesiaCRM.MyVCalendar8 EcclesiaCRM.PersonalServer9 EcclesiaCRM.Reports10 EcclesiaCRM.Search11 EcclesiaCRM.Slim12 EcclesiaCRM.Slim.Error13 EcclesiaCRM.Synchronize14 EcclesiaCRM.Tasks15 EcclesiaCRM.Utils16 EcclesiaCRM.Utils.CSVImport17 EcclesiaCRM.WebDav18 EcclesiaCRM.WebDav.Utils19 EcclesiaCRM.data20 Propel.Runtime.ActiveQuery21 Psr.Container22 Sabre.WebDAV.Backend23 Slim.Http24 (global)25 EcclesiaCRM26 EcclesiaCRM.MyPDO27 EcclesiaCRM.Slim.Middleware28 EcclesiaCRM.VIEWControllers29 EcclesiaCRM.VIEWControllers.BackupRestore30 PluginStore.Base31 PluginStore.Map32 Plugins.APIControllers33 Plugins.Synchronize34 Plugins.VIEWControllers35 EcclesiaCRM.CardDav36 EcclesiaCRM.Service37 EcclesiaCRM.dto38 PluginStore39 Sabre.DAVACL.FS40 EcclesiaCRM.APIControllersDocumentation1EcclesiaCRM.Auth2EcclesiaCRM.Backup3EcclesiaCRM.Base4EcclesiaCRM.Emails5EcclesiaCRM.MenuBar6EcclesiaCRM.MyVCalendar7EcclesiaCRM.PersonalServer8EcclesiaCRM.Reports9EcclesiaCRM.Search10EcclesiaCRM.Slim11EcclesiaCRM.Slim.Error12EcclesiaCRM.Synchronize13EcclesiaCRM.Tasks14EcclesiaCRM.Utils15EcclesiaCRM.Utils.CSVImport16EcclesiaCRM.WebDav17EcclesiaCRM.WebDav.Utils18EcclesiaCRM.data19Propel.Runtime.ActiveQuery20Psr.Container21Sabre.WebDAV.Backend22Slim.Http23(global)24EcclesiaCRM25EcclesiaCRM.MyPDO26EcclesiaCRM.Slim.Middleware27EcclesiaCRM.VIEWControllers28EcclesiaCRM.VIEWControllers.BackupRestore29PluginStore.Base30PluginStore.Map31Plugins.APIControllers32Plugins.Synchronize33Plugins.VIEWControllers34EcclesiaCRM.CardDav35EcclesiaCRM.Service36EcclesiaCRM.dto37PluginStore38Sabre.DAVACL.FS39EcclesiaCRM.APIControllers407111129562416851052413211624459211+40 more modules (most-connected shown)

At a glance — Code Health · 16.7 · Critical · gated by D1, D2, R1, R10, R7, X3, X5 ·

At a glance — Architecture · 91.9 · Exemplary ·

At a glance — Maturity · 52.8 · Adequate · gated by M2 ·

At a glance — Readiness · 10.3 · Critical · gated by D8, D13, R4, R6, R8, P3, P7 ·

At a glance — Security · 51.0 · Adequate · gated by D28, D29, D31 ·

At a glance — Accessibility · 38.0 · Weak · gated by AC1, AC4 ·

At a glance — Performance · 100.0 · Exemplary ·

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP categoryFindingsSeverity
A05:2025 — Injection206High / Critical
A02:2025 — Security Misconfiguration54High / Critical
A07:2025 — Authentication Failures29High / Critical
A01:2025 — Broken Access Control4Medium
A03:2025 — Software Supply Chain Failures1High / Critical

Roadmap

Top priorities: Resolve the 5 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED (2), REDACTED, REDACTED; Resolve the 1 No automated tests finding(s) in Code Coverage; Add a SAST step to CI running what this repository's stack ships: phpstan or psalm — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do thisHelpsEffortDimension
Resolve the 5 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED (2), REDACTED, REDACTED.+12.0 ptsLowREDACTED Scanning
Resolve the 1 No automated tests finding(s) in Code Coverage.+12.0 ptsHighCode Coverage
Resolve the 1 No ADRs found finding(s) in ADR Quality — start with composer.json.+1.4 ptsLowADR Quality
Add a SAST step to CI running what this repository's stack ships: phpstan or psalm — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.+2.1 ptsMediumSecurity & performance tooling
Add tests that import the unreached modules (directly or through their public entry).+2.1 ptsMediumTest Coverage
Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href.+1.9 ptsMediumKeyboard semantics
Remove unused dependencies, declare unlisted imports explicitly, and demote type-/test-only packages to devDependencies.+1.8 ptsMediumDependency Hygiene
Adopt TypeScript for the frontend: add a typecheck step to the build, then either type-check the existing JavaScript in place (`checkJs`/JSDoc types) or convert the highest-traffic modules first — no file is typed today, so this is an adoption, not a clean-up.+1.8 ptsMediumType Safety

File quality

Per-file score 0–10 — a quality signature. Of 313 files carrying findings, judged against the Production bar: 5% slop · 75% mixed · 20% near-clean.

FileScoreBandWorst signal
REDACTED0.0SlopStatic Analysis (SAST): High: REDACTED
REDACTED0.0SlopREDACTED Scanning: Leaked secret: REDACTED
REDACTED0.0SlopStatic Analysis (SAST): High: REDACTED
REDACTED0.5SlopStatic Analysis (SAST): High: REDACTED
REDACTED0.6SlopStatic Analysis (SAST): High: REDACTED
REDACTED0.6SlopStatic Analysis (SAST): High: REDACTED
REDACTED1.7SlopStatic Analysis (SAST): High: REDACTED
REDACTED2.3SlopIaC & Container Security: High IaC: REDACTED
REDACTED2.3SlopIaC & Container Security: High IaC: REDACTED
REDACTED2.3SlopIaC & Container Security: High IaC: REDACTED
REDACTED2.3SlopIaC & Container Security: High IaC: REDACTED
REDACTED3.3SlopSecrets (history): High secret: REDACTED
REDACTED3.3SlopStatic Analysis (SAST): High: REDACTED
REDACTED3.5SlopStatic Analysis (SAST): High: REDACTED
REDACTED3.5SlopStatic Analysis (SAST): High: REDACTED
REDACTED4.0MixedStatic Analysis (SAST): Medium: REDACTED
REDACTED4.0MixedStatic Analysis (SAST): Medium: REDACTED
REDACTED4.0MixedStatic Analysis (SAST): Medium: REDACTED
REDACTED4.0MixedStatic Analysis (SAST): Medium: REDACTED
REDACTED4.0MixedStatic Analysis (SAST): Medium: REDACTED

How the grades work

Every finding carries one of four grades. Three say how serious it is. The fourth says this survey could not settle it — and it is a grade, not a gap.

Critical — 189

A definite problem that already costs you something and drags the score down: a missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here tends to cause failures elsewhere.

Serious — 1675

Likely wrong, but not failing yet. It degrades the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to carry for two years either.

Minor — 86

Recorded, with no effect on how the codebase functions. Present so the survey is complete, not because it needs doing.

Could not be resolved — 14

Something this survey could not settle from the outside, and which could be critical or serious. Either a control was required and no positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean result. These are excluded from the score rather than awarded a pass, so the number on the cover neither rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each one is named under Limitations.

Methodology & how to trust this report

This survey is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. All 70 evaluated dimensions are computed by tools and static analysis; no language model sets or judges any of them. Overall confidence is 0.8, the weighted average across measured dimensions.

Every figure here is one of two kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10.

What we checked — 70 dimensions across the health lenses
D1D2D3D4D5D6D8D13D15D16D17D19D20D24D26D27D28D29D30D31D32D34D35D37D43D44AC1AC2AC3AC4AC5AC6AX10AX3AX4AX6M1M2M3P1P2P3P4P5P6P7PF3R1R10R2R3R4R6R7R8R9S1X16X18X19X2X21X23X27X28X29X3X30X4X5

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions
  1. Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 1934 of 1950 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
  2. Is there a tool behind the number? Every score below names the method that produced it: Roslyn, git or a scanner, not a narrative.
  3. Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

MethodBacksVersionEvaluator
Roslyn static analysisComplexity, cohesion, coupling, dead code, API surface, layering5.3.0✓ deterministic
Native secret scannerHardcoded secrets / credentials1.0.0✓ deterministic
Canine Code Analyzer duplication detector (in-process)Code duplication1.0.0✓ deterministic
Coverage (coverlet / dotnet-coverage)Line & branch coverage10.0.400✓ deterministic
NuGet / dotnetOutdated, vulnerable & deprecated dependencies10.0.400✓ deterministic
git / LibGit2SharpChurn hotspots, knowledge concentration, history2.43.0 · 0.31.0✓ deterministic
gitleaks · semgrep · trivySecrets in history, SAST, CVEs, IaC & container, PII / GDPR1.86.0 · 0.69.3✓ deterministic

Every finding is locatable in findings.md. Run 01a1e9c1-5e2d-7e17-a035-46590924627c.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

  • D12 Dependency Hygiene — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Not scored — 0 shipped Python distribution(s) were read, but the outdated signal needs pypi.org, and the index lookup answered not published for every exact pin asked about (0 lookup(s)), so this dimension's own question is only partly answered. NOT a finding that these dependencies are current or healthy.
  • D14 License Compliance — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Not scored — this repository declares package.json manifests but commits no lockfile this pass can resolve (npm, pnpm, yarn and bun each write a different one, and `bun.lockb` is a binary format with no published shape), so the set of packages it actually ships is not resolvable from the checkout: its declarations carry version RANGES, and grading whichever release happens to be newest today would be a verdict about a dependency graph this repository has not pinned. Commit the lock and this dimension grades its production dependencies against registry.npmjs.org. NOT a finding that this repository's licences are compliant: this dimension asserts nothing about its licensing in either direction.
  • D19 Documentation Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This kind did not reach the 95 % precision gate in three adjudicated runs (docs/plans/deterministic-engine/adjudication/D19-sample3-v3.md), so by the pre-registered fallback it publishes no row until a re-measurement shows it does. The candidates are counted here, not reported as findings, and the score does not include them.
  • D21 Naming Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D21's naming rules read C# through Roslyn and every other language through its sidecar model; these languages are left out (PHP's reading is its own change, a Roslyn-loaded VB or F# project has no population builder yet). Their declarations carry no naming verdict this run — this says nothing about whether their names are consistent.
  • D22 Internal API Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D22 identifies the intentionally-exposed surface from `IsPackable` and `.Contracts` project names, MSBuild conventions read off the loaded project set. This target exposed no such projects, so the probe never ran; this says nothing about whether the repository has a public API. This repository commits no C#/VB source at all, so there was never an MSBuild project set to read these conventions off. That is OUR side and it is an ADMISSION gap, not an environment fault: no published-package marker D22 reads admitted any project here. D22 DOES collect the public API of every language in this tree, and admits a project only when its manifest makes that ecosystem's publication act in a form the marker recognises — so what is missing is not a collector but an admission rule for the publication act this repository makes, if it makes one. The remedy is a better discriminator for that marker — not a collector, and no change to the scan image can close it. The marker's rules are measured to refuse applications, so one refused repository is the rule working as calibrated; several are the evidence that it is too strict. For npm the surface is what a published package.json's entry points (exports, main, module, types) export, followed through the source; an entry that names build output the tree does not commit (dist/, build/) is not followed back to source, because only a tsconfig outDir/rootDir pair states that mapping and a bundler's input lives in executable configuration this engine does not evaluate.
  • D24 Comment Value — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Each source language's comment syntax, and the code a comment annotates in it, needs its own proof before D24 judges it. Until then those comments are left unread, not counted as clean.
  • D31 IaC & Container Security — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Checkov ran but its report could not be read (checkov produced no output — not a clean result). Every misconfiguration only checkov reports — most of its Terraform, CloudFormation, Bicep and Ansible policies — is absent from this card, so its absence here is not evidence those resources are configured correctly.
  • AC2 Forms & labels — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 605 further occurrence(s) are not listed individually; the score already reflects all 645.
  • AC3 Page structure — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 31 further occurrence(s) are not listed individually; the score already reflects all 71.
  • AC4 Keyboard semantics — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 49 further occurrence(s) are not listed individually; the score already reflects all 89.
  • AX1 Captive dependencies — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads Microsoft.Extensions.DependencyInjection registrations in C# and Spring beans in Java/Kotlin only, and this repository's container is PHP-DI and a PSR-11 container (Psr\Container), whose lifetimes are not modelled yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • AXR1 Runtime accessibility — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Render strategy: boot via DockerCompose (REDACTED). compose up failed (exit 1 — a container did not start, exited, or never became healthy) — time="2026-11-17T13:47:22Z" level=warning msg="The \"COLLABORA_ADMIN_PASSWORD\" variable is not set. Defaulting to a blank string." time="2026-11-17T13:47:22Z" level=warning msg="The \"COLLABORA_HTTPS_PORT\" variable is not set. Defaulting to a blank string." services.webserver: container name "docker-" is already in use by service {}"; runtime evidence skipped.
  • C1 Data Protection — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. 'mysqli' is imported (src/setup/routes/setup.php:43), but no entity, schema, table or model declaration this check reads was found beside it, so whether personal data is stored could not be decided.
  • C3 Audit Trail — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. 'mysqli' is imported (src/setup/routes/setup.php:43), but no entity, schema, table or model declaration this check reads was found beside it, so whether personal data is stored could not be decided.
  • C4 Data Retention — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. 'mysqli' is imported (src/setup/routes/setup.php:43), but no entity, schema, table or model declaration this check reads was found beside it, so whether personal data is stored could not be decided.
  • C5 Data-Subject Rights — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. 'mysqli' is imported (src/setup/routes/setup.php:43), but no entity, schema, table or model declaration this check reads was found beside it, so whether personal data is stored could not be decided.
  • GD1 Unfinished & placeholder code — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, F#, JavaScript/TypeScript, Dart, Ruby, Scala, Rust and Java source only, and this repository's PHP, Python is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • IC1 Incompleteness & stubs — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, JavaScript/TypeScript, Java, Dart, Ruby, Scala and Rust source only, and this repository's PHP, Python is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • R10 Code Duplication — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 239 further occurrence(s) are not listed individually; the score already reflects all 279.
  • R7 Dead Code — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 642 further occurrence(s) are not listed individually; the score already reflects all 682.
  • X1 Async correctness — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover most of the languages this repository's product is written in. What it read is kept, but it is too small a share to grade the product by. That is a gap in this analyzer's language reach — not a finding about this repository.
  • X10 Duplicated predicate — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. 34 further occurrence(s) are not listed individually; the score already reflects all 74.
  • X12 Unreachable branch — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover most of the languages this repository's product is written in. What it read is kept, but it is too small a share to grade the product by. That is a gap in this analyzer's language reach — not a finding about this repository.
  • X24 Document value interpolated into markup unescaped — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover most of the languages this repository's product is written in. What it read is kept, but it is too small a share to grade the product by. That is a gap in this analyzer's language reach — not a finding about this repository.
  • X24 Document value interpolated into markup unescaped — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. 416 further occurrence(s) are not listed individually; the score already reflects all 456.
  • X27 Collection changed while being enumerated — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This check's reader does not cover every language in this repository. The score describes the part it read, which is most of the product; the rest is a gap in this analyzer's language reach.
  • X3 Exception handling — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 464 further occurrence(s) are not listed individually; the score already reflects all 504.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

We assess the repository exactly as committed, and only the repository. By design we do not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

  • D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
  • D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
  • D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
  • D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
  • D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
  • D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
  • D8 Code Coverage: Coverage is measured by building and running the test suite inside our isolated image — the target repo is never modified, and nothing on your systems runs. So coverage exists only when the suite builds and runs within the inline time budget; one that needs external services, can't build, or exceeds the budget yields no coverage (D8 then degrades to not-measured, not a low score). Line coverage also says nothing about assertion quality.
  • D13 REDACTED Scanning: REDACTED detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
  • D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
  • D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
  • D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
  • D19 Documentation Quality: Documentation quality publishes two things only: a runnable or packaged unit with no example, and a multi-project root README that maps none of its parts. It does not judge clarity, and its other checks (overview, licence, boilerplate, structure, empty sections, XML-doc coverage) are withheld after adjudication: their candidates are counted in the card's gaps, not shown as rows. A false statement in a document is M4's; units are .NET projects only.
  • D20 ADR Quality: ADR quality checks the structure of the decision records present: it cannot know about decisions made and never recorded, and it does not judge how well a record argues its case. Records in a language the section lexicon does not cover are not evaluated.
  • D24 Comment Value: Comment value is measured as redundancy only: a comment that repeats its code's words is found, but a paraphrase in other words, a vague comment, or one the code contradicts is not, and whether a comment is valuable is not claimed. Comments in other scripts or languages, and outside C#, are not judged.
  • D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
  • D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
  • D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
  • D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
  • D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
  • D31 IaC & Container Security: IaC scanning checks Dockerfiles/Terraform/Kubernetes against best-practice rules — it cannot see the live cloud account, runtime configuration, or drift between the committed config and what is actually deployed.
  • D32 Data Compliance (PII/GDPR): PII/GDPR signals are heuristic pattern matches in code — they flag likely handling concerns, not legal compliance, and cannot trace where data actually flows at runtime.
  • D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
  • D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
  • D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
  • D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a REDACTED (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
  • AC1 Text alternatives: Alt-text is detected structurally — the scan sees that an alternative EXISTS, not whether it meaningfully describes the image, and decorative-vs-missing is judged by attribute shape; runtime-injected images and a non-role=img decorative svg are out of scope. This is accessibility readiness, never a WCAG conformance claim.
  • AC2 Forms & labels: Label association is read from static markup — a label wired up at runtime (JS-set aria-labelledby, framework-injected ids) reads as missing, a present label says nothing about whether its text is correct. A known UI-library field component (e.g. a JSX <TextField>) is now checked conservatively — flagged only when it carries NO label/aria-label/aria-labelledby/id/name — but wrapper/context-labelled libraries (Chakra/Radix FormControl+FormLabel) aren't statically visible (possible false positive) and non-JSX lowercased components are still skipped. A click handler on a plain element is now asked for a name too (it is a control the author declared), but the subtree test that answers it is deliberately generous: any DYNAMIC text expression in the subtree counts as a name, so an icon chosen by a ternary ({cond ? <IconA/> : <IconB/>}) reads as named, and a glyph component from a library the icon-import list does not know still names its parent. A clean result is "no unlabelled control found", not a labelling proof.
  • AC3 Page structure: Page structure is read from the static markup tree — landmarks, headings and lang injected at runtime aren't seen, heading ORDER is checked structurally (not against the rendered visual hierarchy), and lang/title/main fire only on full documents, never partials, and the data-table check sees header-cell presence (a <th> exists), not whether each header correctly associates with its cells. Static readiness, not conformance.
  • AC4 Keyboard semantics: Keyboard semantics are inferred from markup attributes — interactivity wired purely in script, focus managed at runtime, and component-level handlers are invisible. A clean result means "no static keyboard-trap shape", not a keyboard-operability proof.
  • AC5 ARIA correctness: ARIA correctness is checked against the static role/attribute shape — roles/attributes set dynamically aren't seen, a valid role says nothing about whether it matches the element's real behaviour, and required-state checks are suppressed when a JSX spread could supply them. The two-branch toggle check (a control whose state is conveyed only by which of two mutually exclusive branches renders) reads CONDITIONALS THAT ARE ATTRIBUTES — Vue v-if/v-else/v-show and Alpine x-if/x-show — so the same toggle written as a Svelte {#if} block or a JSX ternary is control flow the markup model never projects as a branch and is not seen at all.
  • AC6 Visual & motion safety: Contrast and motion safety are PARTIAL by construction — literal colours (hex/rgb/hsl/named) in inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS top-level declarations are read (same-rule/same-element colour+background pairs only); computed/runtime/theme colour, external-CDN stylesheets, CSS-in-JS dynamic (${…}) and nested-selector colours, cross-element pairs and image contrast stay out of reach, so a clean result is bounded by what the static CSS itself shows.
  • AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
  • P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
  • P5 DR & Backup: Backup/restore and disaster-recovery readiness is judged from in-repo evidence — a config that exists is not a tested restore, so the absence of positive evidence is reported as "not evidenced", never scored as present.
  • P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.

Dimensions

D1 · Cyclomatic Complexity3.7 / 10Weak✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: Documented → Verified → Prevented · effective 3.7 / 10 · rule-coverage 100% · ceiling Prevented

173 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was (anonymous) at 135. A further 5 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being MiscUtils.FileIcon at 46 — they are counted neither in the figure above nor in this dimension's score. 1 file carries no cyclomatic complexity row at all for this reason — every one of its over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: src/EcclesiaCRM/utils/GeoUtils.php (GeoUtils.LatLonBearing at 21). They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.

(anonymous)::eventDidMount (cyclomatic 36) · ×5src/skin/js/calendar/CalendarV2.js:368
(anonymous) (cyclomatic 19) · ×5src/Plugins/ToDoListDashboard/skin/js/ToDoListDashboard.js:1
(anonymous) (cyclomatic 26) · ×4src/skin/js/calendar/EventsList.js:1
(anonymous) (cyclomatic 17) · ×3REDACTED:7
(anonymous) (cyclomatic 23) · ×2src/skin/js/group/GroupEditor.js:1

+ 146 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 1 body over 120 down to 120 or less in Cyclomatic Complexity — start with (anonymous) (cyclomatic 135). — Refactoring it lifts Cyclomatic Complexity from 3.7 to about 3.9/10.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

D2 · Cognitive Complexity2.0 / 10Critical✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: Documented → Verified → Prevented · effective 2.0 / 10 · rule-coverage 100% · ceiling Prevented

270 method(s) exceeded the cognitive complexity threshold of 15; the worst was CalendarService.realEvents at 499.

(anonymous)::eventDidMount (cognitive 31) · ×3src/skin/js/calendar/CalendarV2.js:368
(anonymous) (cognitive 33) · ×2src/Plugins/ToDoListDashboard/skin/js/ToDoListDashboard.js:1
(anonymous) (cognitive 32) · ×2src/skin/js/people/letterandlabels.js:1
(anonymous) (cognitive 24) · ×2src/skin/js/people/AddRemoveCart.js:1
(anonymous) (cognitive 23) · ×2src/skin/js/user/UserEditor.js:46

+ 247 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 44 bodies over 60 down to 60 or less in Cognitive Complexity — start with CalendarService.realEvents (cognitive 499), CalendarEventV2Controller.manageEvent (cognitive 287), PDF_ConfirmReport.run (cognitive 251). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 44 together lifts Cognitive Complexity from 2.0 to about 3.8/10, projected with the scoring formula itself and assuming each lands exactly at 60; a cleaner split scores higher.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

D3 · God Classes7.4 / 10Strong✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: Documented → Verified → Prevented · effective 7.4 / 10 · rule-coverage 100% · ceiling Prevented

133 god class(es) detected.

MethodTooLong: VIEWUserController.argumentsrenderUserEditorArray · ×48src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:291
FileTooLong: REDACTED · ×29REDACTED
ClassTooLong: CalendarService · ×28src/EcclesiaCRM/Service/CalendarService.php:47
TooManyMethods: User · ×17src/EcclesiaCRM/model/EcclesiaCRM/User.php:70
FunctionTooLong: CalendarV2.document.addEventListener("DOMContentLoaded") · ×11src/skin/js/calendar/CalendarV2.js:12

What to do

  1. Resolve the 48 MethodTooLong finding(s) in God Classes — start with CalendarService.php (4), REDACTED (3), REDACTED (3). — One of this dimension's main actionable groups (48 warning-level).
  2. Resolve the 29 FileTooLong finding(s) in God Classes — start with REDACTED, CalendarService.php, MiscUtils.php. — One of this dimension's main actionable groups (29 warning-level).
  3. Resolve the 28 ClassTooLong finding(s) in God Classes — start with CalendarService.php, REDACTED, User.php. — One of this dimension's main actionable groups (28 warning-level).

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

D4 · Code Duplication5.2 / 10Adequate✓ Tool-verified

What it measures: How much of the production code is copy-pasted: the share of production lines inside a reported copy (every copy of a duplicated block or of an edited member, each line once), 10 at none and 0 at a quarter of the lines.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), scored on the share of production lines inside a reported copy (each line once; 10 at none, 0 at a quarter). Deterministic.

Maturity: Documented → Verified → Prevented · effective 5.2 / 10 · rule-coverage 100% · ceiling Verified

362 duplicated block group(s) detected. 12.1 % of the production lines (15,756 of 130,080) are in a reported copy. A further 213 rows report members as variants of one another; the share counts each copied line once, however many rows cite it.

Duplicated block (10 lines × 2) · ×20src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:370
Duplicated block (8 lines × 2) · ×18src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:382
Duplicated block (7 lines × 2) · ×18src/EcclesiaCRM/APIControllers/CartController.php:159
Duplicated block (11 lines × 2) · ×14src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:362
Edited copy of a member (7 corresponding lines) · ×13src/EcclesiaCRM/APIControllers/PastoralCareController.php:109

+ 239 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 20 Duplicated block (10 lines × 2) finding(s) in Code Duplication — start with PeopleGroupController.php (2), MenuBar.php (2), PDF_Attendance.php (2). — One of this dimension's main actionable groups (20 warning-level).
  2. Resolve the 18 Duplicated block (8 lines × 2) finding(s) in Code Duplication — start with VIEWDepositController.php (2), PeopleAttendeesController.php, PeopleController.php. — One of this dimension's main actionable groups (18 warning-level).
  3. Resolve the 18 Duplicated block (7 lines × 2) finding(s) in Code Duplication — start with SidebarPropertiesController.php (2), REDACTED (2), CartController.php. — One of this dimension's main actionable groups (18 warning-level).

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

D5 · Coupling10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.

Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.

Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

2 production modules (npm+Composer), 0 dependency cycle(s), 0 unstable depended-on module(s). Read from the build's own module declarations; 0 module(s) off the main sequence.

✓ On the Gold path — maintain.

Detailed fixes: d5_recommendation.md.

D6 · Cohesion (LCOM4)6.0 / 10Adequate✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 6.0 / 10 · rule-coverage 100% · ceiling Verified

46 of 137 classes have LCOM4 above 3.

Low cohesion: PeopleGroupController (LCOM4 30) · ×46src/EcclesiaCRM/APIControllers/PeopleGroupController.php:49

What to do

  1. Resolve the 46 Low cohesion finding(s) in Cohesion (LCOM4) — start with PeopleGroupController.php, MailchimpController.php, CalendarV2Controller.php. — One of this dimension's main actionable groups (46 warning-level).

Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.

D8 · Code Coverage0.0 / 10Critical✓ Tool-verified

What it measures: How much of the code is actually exercised by tests.

Method: Coverage from the analyzer's own run of the suite, computed per-file with structured exclusions for generated, trivial, and glue code. A coverage report found in the repository is never read. When the suite can't be built/run in-image, coverage is reported NOT-MEASURED (excluded from the score) with the precondition to make it measurable — never a LoC-ratio proxy folded in as if measured. Deterministic.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Verified

No automated tests — no test code was found in this repository.

No automated tests

What to do

  1. Resolve the 1 No automated tests finding(s) in Code Coverage. — One of this dimension's main actionable groups (1 issue-level).

Detailed fixes: d8_recommendation.md · top locations in Appendix A, every location in findings.md.

D13 · REDACTED Scanning0.0 / 10Critical✓ Tool-verified

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Prevented

4 secret(s) detected.

REDACTED

What to do

  1. Resolve the 5 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED (2), REDACTED, REDACTED. — One of this dimension's main actionable groups (5 issue-level).

Detailed fixes: d13_recommendation.md · top locations in Appendix A, every location in findings.md.

D15 · Churn × Complexity Hotspots9.8 / 10Stronggated by 9 serious findings✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: Documented → Verified → Prevented · effective 9.8 / 10 · rule-coverage 100% · ceiling Documented

Top hotspots: src/skin/js/filemanager.js (16×30=480); src/skin/js/ckeditor/ckeditorextension.js (6×60=360); src/EcclesiaCRM/utils/MiscUtils.php (4×71=284)

Hotspot: src/skin/js/filemanager.js · ×9src/skin/js/filemanager.js:769

What to do

  1. Resolve the 9 Hotspot finding(s) in Churn × Complexity Hotspots — start with filemanager.js, ckeditorextension.js, MiscUtils.php. — One of this dimension's main actionable groups (9 warning-level).

Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.

D16 · Bus Factor4.7 / 10Weak✓ Tool-verified

What it measures: Whether knowledge is concentrated in too few people (the "bus factor").

Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.

Maturity: Documented → Verified → Prevented · effective 4.7 / 10 · rule-coverage 100% · ceiling Documented

189 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is src/v2/templates/people/personview.php. Counted over 359 of the 782 production source files in this repository: 410 are under the ~2,400-byte size floor this dimension measures over, and the remaining 13 have no attributable history left to measure.

Off-boarding risk: anonymized user #1

What to do

  1. Resolve the 1 Off-boarding risk finding(s) in Bus Factor. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.

D17 · Explicit Debt10.0 / 10Stronggated by 7 serious findings✓ Tool-verified

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

7 deducted task-comment markers across 130080 LoC (0.0/KLoC) → score 10.0. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.

TodoComment · ×7src/v2/templates/user/userseditor.php:585

What to do

  1. Resolve the 7 TodoComment finding(s) in Explicit Debt — start with Bootstrapper.php (2), userseditor.php, VIEWUserController.php. — One of this dimension's main actionable groups (7 warning-level).

Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.

D19 · Documentation Quality10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the project's documentation is clear, complete, and useful.

Method: Every README, docs/ document and root guide parsed by its markup and measured in Unicode letters. Published: a runnable or packaged .NET project whose README (or a document it links, or a root guide) shows no example, and a root README naming none of three or more projects. Overview, licence, boilerplate, wall-of-text, empty-section and XML-doc rows are measured and withheld (counted in gaps) after adjudication. Deterministic, exhaustive, advisory.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

1 of 1 documentation facets pass in full. 167 document(s) read across 3 unit(s).

✓ On the Gold path — maintain.

Detailed fixes: d19_recommendation.md.

D20 · ADR Quality0.0 / 10Critical✓ Tool-verified

What it measures: Whether architecture decisions are recorded well (context, decision, consequences).

Method: Every ADR read by its section structure: nine located rules (a missing Decision, Context or Consequences section, a stale status, two records deciding the same question, a dangling supersede link, a number-only title, a single option, no named cost, no status where the log uses one, no enforcement field where the log adopted one), each a fixed deduction from 10; the score is the mean over evaluated records. Deterministic, no model. Advisory.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

No architecture decision records were found.

No ADRs foundsrc/composer.json:5

What to do

  1. Resolve the 1 No ADRs found finding(s) in ADR Quality — start with composer.json. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d20_recommendation.md · top locations in Appendix A, every location in findings.md.

D24 · Comment Value6.7 6.2 / 10Adequate✓ Tool-verified

What it measures: Whether comments are worth it — explaining WHY (valuable) rather than WHAT (redundant).

Method: Every inline C# comment compared word by word with the identifiers, literals and constructs of the code it annotates (taken from the syntax); a comment whose words that code already contains is redundant, as are closing-brace labels and generator template text. Comments giving a reason or a reference are kept; other scripts and languages are not judged. Deterministic, exhaustive, advisory.

Maturity: Documented → Verified → Prevented · effective 6.2 / 10 · rule-coverage 93% · ceiling Documented

12 of 365 judged comments only repeat the code they sit on (3.3 %). 47 comment(s) in another language or script were not judged.

redundant comment · ×12REDACTED:2145
doc comments repeat the namessrc/skin/js/fundraiser/paddleNumList.js:111

What to do

  1. Resolve the 12 redundant comment finding(s) in Comment Value — start with REDACTED (2), GoogleMapEvent.js (2), OpenStreetMapEvent.js (2). — One of this dimension's main actionable groups (12 recommendation-level).

Detailed fixes: d24_recommendation.md · top locations in Appendix A, every location in findings.md.

D26 · Project Cohesion5.0 / 10Adequate✓ Tool-verified

What it measures: Whether each project is a focused, coherent unit rather than an oversized grab-bag.

Method: Project size overshoot penalties (LoC / public-type count / namespace count, 2-of-3 flag) weighted by log magnitude. Exhaustive across projects, deterministic.

Maturity: Documented → Verified → Prevented · effective 5.0 / 10 · rule-coverage 100% · ceiling Documented

1 of 4 build units (Composer, Python, npm) flagged as possibly oversized/incoherent.

Projects may be oversized for their cohesionsrc/composer.json:1

What to do

  1. Resolve the 1 Projects may be oversized for their cohesion finding(s) in Project Cohesion — start with composer.json. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.

D27 · Navigability5.2 / 10Adequate✓ Tool-verified

What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.

Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps. C# also names each pass-through layer (a class whose every public method only forwards its own parameters to one collaborator) as a located finding; the score is not affected.

Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.

Maturity: Documented → Verified → Prevented · effective 5.2 / 10 · rule-coverage 100% · ceiling Documented

97 % of calls cross a namespace and 0 % go through an interface, but 1 % of collaborators are co-located — so following a call takes several hops. Baseline: small — navigation cost is tolerated.

Scattered collaborators

What to do

  1. Resolve the 1 Scattered collaborators finding(s) in Navigability. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d27_recommendation.md · top locations in Appendix A, every location in findings.md.

D28 · Secrets (history)0.0 / 10Critical✓ Tool-verified

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: REDACTED scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

23 finding(s): 0 critical, 23 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.

REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 18 High secret finding(s) in Secrets (history) — start with REDACTED (4), REDACTED (3), REDACTED (3). — One of this dimension's main actionable groups (18 issue-level).
  2. Resolve the 5 REDACTED finding(s) in Secrets (history) — start with REDACTED (2), REDACTED, REDACTED. — One of this dimension's main actionable groups (5 issue-level).
  3. Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.

D29 · Static Analysis (SAST)0.0 / 10Critical✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

207 finding(s): 0 critical, 31 high, 172 medium, 4 low. semgrep hit a parse error in 5 file(s) — `Documentation/doc-en/site/assets/javascripts/lunr/wordcut.js`, `Documentation/doc-fr/site/assets/javascripts/lunr/wordcut.js`, `docker/dev_build_container.sh` (line 128), `locale/JSONKeys_JS/en_US.json`, `REDACTED` — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them.

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

+ 13 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 29 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (5), REDACTED (5), REDACTED (5). — One of this dimension's main actionable groups (29 issue-level).
  2. Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
  3. Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

D30 · Dependency Vulnerabilities8.8 / 10Adequategated by 1 critical finding✓ Tool-verified

What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.

Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05. Advisory since rubric-2026.11.2 (CAI decision 0006): every row is a match against a vulnerability database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.

Maturity: Documented → Verified → Prevented · effective 8.8 / 10 · rule-coverage 100% · ceiling Documented

1 finding(s): 1 critical, 0 high, 0 medium, 0 low.

REDACTED

What to do

  1. Resolve the 1 Critical CVE finding(s) in Dependency Vulnerabilities — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).

Detailed fixes: d30_recommendation.md · top locations in Appendix A, every location in findings.md.

D31 · IaC & Container Security0.0 / 10Critical✓ Tool-verified

What it measures: Whether Dockerfiles / Terraform / Kubernetes config follow security best practices.

Method: IaC/container misconfiguration scan via trivy config (REDACTED/Terraform/K8s/Helm/CloudFormation); severity rules to 0-10 moderate normalizer. NotApplicable without manifests. Exhaustive, deterministic.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

54 finding(s): 0 critical, 43 high, 4 medium, 7 low.

REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 43 High IaC finding(s) in IaC & Container Security — start with REDACTED (39), REDACTED (4). — One of this dimension's main actionable groups (43 issue-level).
  2. Resolve the 7 Low IaC finding(s) in IaC & Container Security — start with REDACTED (7). — One of this dimension's main actionable groups (7 recommendation-level).
  3. Resolve the 4 Medium IaC finding(s) in IaC & Container Security — start with REDACTED (4). — One of this dimension's main actionable groups (4 warning-level).

Detailed fixes: d31_recommendation.md · top locations in Appendix A, every location in findings.md.

D32 · Data Compliance (PII/GDPR)6.6 / 10Adequate✓ Tool-verified

What it measures: Likely personal-data (PII / GDPR) handling concerns — logging or storing data without safeguards.

Method: Heuristic PII/GDPR LEAK scan via semgrep across the repo, using our own ruleset: personal data crossing a boundary it should not — reaching a log/console sink, a URL or query string, or unprotected browser storage. Matches map to severity and a 0-10 wide normalizer. A clean sweep is unscored rather than an unearned 10, and is a statement about the leak paths checked only — this dimension does not inventory the personal data a repository holds (the personal-data map and the C1-C5 compliance cards do that), so it never reports that a repository has no personal-data surface. Reported LOUDLY as a measurement gap if the ruleset is missing from the analyzer image. Exhaustive over the leak paths, advisory-leaning; degrades on parse failure.

Maturity: Documented → Verified → Prevented · effective 6.6 / 10 · rule-coverage 100% · ceiling Documented

4 finding(s): 0 critical, 0 high, 4 medium, 0 low.

REDACTED

What to do

  1. Resolve the 4 REDACTED finding(s) in Data Compliance (PII/GDPR) — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (4 warning-level).

Detailed fixes: d32_recommendation.md · top locations in Appendix A, every location in findings.md.

D34 · Knowledge Freshness9.8 / 10Adequategated by 2 critical findings✓ Tool-verified

What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.

Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.

Maturity: Documented → Verified → Prevented · effective 9.8 / 10 · rule-coverage 100% · ceiling Documented

6 of 372 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is REDACTED. Counted over 372 of the 782 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.

Orphaned knowledge · ×2REDACTED:1
Orphaned file · ×4src/external/routes/register.php:1
Further orphaned files (smaller)

What to do

  1. Resolve the 2 Orphaned knowledge finding(s) in Knowledge Freshness — start with REDACTED, REDACTED. — One of this dimension's main actionable groups (2 issue-level).
  2. Resolve the 4 Orphaned file finding(s) in Knowledge Freshness — start with register.php, EnvelopeReport.php, NameTags.php. — One of this dimension's main actionable groups (4 recommendation-level).
  3. Resolve the 1 Further orphaned files (smaller) finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.

D35 · Change Coupling10.0 / 10Stronggated by 1 serious finding✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

Strongest change-coupling: DocumentShareController.php↔filemanager.js 54%

Change coupling: DocumentShareController.php ↔ filemanager.jssrc/EcclesiaCRM/APIControllers/DocumentShareController.php:1

What to do

  1. Resolve the 1 Change coupling finding(s) in Change Coupling — start with DocumentShareController.php. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.

D37 · Vulnerability-disclosure Policy10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the repository publishes a coordinated-vulnerability-disclosure policy (SECURITY.md or security.txt) with a reporting contact, so finders know how to report a vulnerability. Presence of a policy file with a contact, not whether the policy is adequate or honoured.

Method: Vulnerability-disclosure policy read deterministically from the repo: a SECURITY.md (root/.github/docs) or .well-known/security.txt / security.txt, regex-checked for a reporting contact (email / URL / mailto). Present + contact → 10; present without a contact → 4; NotApplicable when no policy file exists (it may live off-repo). Detects the policy file's presence + contact, not its adequacy.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

A vulnerability-disclosure policy (SECURITY.md) is published with a reporting contact.

✓ On the Gold path — maintain.

Detailed fixes: d37_recommendation.md.

D43 · Malicious Dependencies10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Reported apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.

Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. Advisory since rubric-2026.11.2 (CAI decision 0006): the malicious-package feed is a database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No dependency in any ecosystem this repository declares is published as malicious.

✓ On the Gold path — maintain.

Detailed fixes: d43_recommendation.md.

D44 · Platform End-of-Life10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.

Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 0 platform declaration(s) and 48 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.

✓ On the Gold path — maintain.

Detailed fixes: d44_recommendation.md.

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AC1 · Text alternatives3.7 / 10Weak✓ Tool-verified

Other · Accessibility — Whether non-text content carries a text alternative — img/area/input[type=image] have alt, a meaningful svg has a title or aria-label, video has a captions track, and object/embed/canvas have a name or fallback content. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: every img/area/input[type=image] checked for alt, svg[role=img] for a title/aria-label, video for a captions <track>. Components skipped, spreads suppressed. Deterministic, hard fact per element.

Coverage: Population: image/media elements — img, area, input[type=image], svg, video, object, embed, canvas — across the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and dynamic-attribute elements are skipped. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is NOT read by any producer, so it contributes no element to this population; where such a frontend is present the card discloses it as an analyzer gap rather than scoring around it.

  • A <canvas> with no aria-label/title and no inner fallback content can't be described by assistive tech. Add a name or fallback content. (×6) — src/Plugins/FinanceDashboard/v2/templates/View.php:50, src/v2/templates/deposit/depositslipeditor.php:100, src/v2/templates/deposit/depositslipeditor.php:116, …
  • An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative. (×18) — src/Plugins/MailChimp/v2/templates/campaign.php:72, src/Plugins/MailChimp/v2/templates/dashboard.php:48, src/Plugins/MailChimp/v2/templates/duplicateemails.php:20, …

What to do

  • Add a text alternative — alt on images (alt="" for purely decorative ones), a title or aria-label on meaningful svg, an aria-label or inner fallback content on canvas, and a captions <track> on video.
AC2 · Forms & labels4.4 / 10Weak✓ Tool-verified

Other · Accessibility — Whether form controls have a programmatic label (an associated label, aria-label or aria-labelledby), buttons have text, links have an accessible name, a click handler on a plain element names the control it declares, fieldsets have a non-empty legend, known UI-library field components carry a label prop, and a placeholder isn't used as the only label. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: inputs/selects/textareas checked for an associated label[for]/wrapping label/aria-label/aria-labelledby (per document), buttons for accessible text, fieldsets for a legend; placeholder-only labelling flagged. Deterministic, hard fact per control.

Coverage: Population: form controls, buttons, links, fieldsets and known UI-library field components in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and spread/dynamic-attribute elements are skipped, so a control whose label arrives through a spread or a runtime expression is deliberately not judged. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

  • A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one). (×6) — src/Plugins/CurrentUsersDashboard/v2/templates/View.php:57, src/Plugins/MailChimp/v2/templates/campaign.php:121, src/Plugins/MailChimp/v2/templates/campaign.php:140, …
  • This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id. (×8) — src/Plugins/CurrentUsersDashboard/v2/templates/View.php:66, src/Plugins/MailChimp/v2/templates/campaign.php:101, src/Plugins/MailChimp/v2/templates/campaign.php:149, …
  • This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label. (×15) — src/Plugins/MailChimp/v2/templates/campaign.php:103, src/Plugins/MeetingJitsi/v2/templates/meetingsettings.php:37, src/Plugins/MeetingJitsi/v2/templates/meetingsettings.php:55, …
  • This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it. (×11) — src/Plugins/MailChimp/v2/templates/campaign.php:111, src/Plugins/MailChimp/v2/templates/managelist.php:73, src/Plugins/NoteDashboard/v2/templates/View.php:50, …

What to do

  • Give every control a programmatic label (a <label for> / wrapping <label> / aria-label) and every button text — a placeholder is not a label.
AC3 · Page structure5.3 / 10Adequate✓ Tool-verified

Other · Accessibility — Whether pages declare a language (well-formed BCP-47) and a non-empty title, expose exactly one main landmark and a sane heading order with non-empty headings, keep zoom enabled, title their iframes, give data tables header cells, and avoid meta-refresh. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: html lang, document <title>, a main landmark and heading order on full documents only, plus zoom-disabling viewports, untitled iframes and meta-refresh anywhere. Deterministic, per structural checkpoint.

Coverage: Population: the PARSED MARKUP documents (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx). The page-level checks — lang, title, single main landmark — fire ONCE PER FULL DOCUMENT (an <html> root) and never on a partial or component fragment, so a repo of fragments is assessed only on the per-element checks (heading order, table headers, iframe titles, meta-refresh, zoom). Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

  • Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one. (×14) — src/Plugins/MailChimp/v2/templates/managelist.php:100, src/v2/templates/calendar/calendar.php:201, REDACTED:254, …
  • An empty heading appears in the document outline announced with no text. Give the heading text, or remove it if it's decorative. (×4) — src/kiosk/templates/kioskDevices/sunday-school-class-view.php:15, src/v2/templates/calendar/calendar.php:201, src/v2/templates/calendar/eventslist.php:119, …
  • A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope). (×16) — src/setup/templates/setup-steps.php:121, src/v2/templates/calendar/eventnames.php:294, src/v2/templates/deposit/financialReports.php:64, …
  • The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en"). (×2) — src/skin/js/ckeditor/ckeditorextension.js:563, src/skin/js/edrive/CollaboraEditor.js:34
  • A page with no <title> gives no name in the tab, history or screen-reader page list. Add a descriptive <title> in <head>. — src/skin/js/ckeditor/ckeditorextension.js:563
  • No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>. (×2) — src/skin/js/ckeditor/ckeditorextension.js:563, src/skin/js/edrive/CollaboraEditor.js:34
  • An iframe with no title (or an empty one) is announced only as "frame". Add a non-empty title describing its content, or an aria-label. — src/skin/js/edrive/CollaboraEditor.js:39

What to do

  • Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh.
AC4 · Keyboard semantics1.4 / 10Critical✓ Tool-verified

Other · Accessibility — Whether interactive behaviour is keyboard-reachable — no click handler on a non-interactive element lacking a role, tabindex and key handler, no element the repo's own CSS styles `cursor: pointer` without giving it any of the three, no unfocusable element whose only binding is a mouse enter/leave pair or a double-click, no positive tabindex, no href-less anchor, no placeholder-href (#/javascript) link acting as a button. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: click handlers on non-interactive elements lacking role+tabindex+key handler, positive tabindex values, and href-less anchors. Components skipped, spreads suppressed. Deterministic, hard fact per element.

Coverage: Population: elements that pose a keyboard-semantics question, in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx) — a non-natively-interactive element carrying a click handler, a double-click or hover enter/leave binding, a pointer-only gesture on a tabindex="0" element, or `cursor: pointer` from the repo's own CSS; an href-less or placeholder-href (#, javascript:) anchor; and any element with a positive tabindex. Natively interactive elements used correctly (<button>, <a href>, form controls) are NOT in the population — there is nothing to judge — so a page of nothing but correct controls gives AC4 nothing to measure. Keyboard reachability is judged from the markup, never from a rendered page. ★ An interactive element declared in a tagged-template (html`…`) or hyperscript frontend is NOT in this population — no producer reads either — so an empty population is reported as an analyzer gap, never as "this repository has no interactive elements".

  • An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action. (×26) — REDACTED:39, REDACTED:47, REDACTED:54, …
  • A positive tabindex forces a manual tab order that fights the DOM and is fragile. Use tabindex="0" (or restructure the DOM). (×10) — src/ident/templates/verify/verify-family-info.php:83, src/ident/templates/verify/verify-person-info.php:76, REDACTED:247, …
  • An <a href="#"> (or javascript:) with a click handler is a button dressed as a link — it announces the wrong role and stops working without JS. Use a <button> for an action. (×3) — src/v2/templates/deposit/electronicPaymentList.php:187, REDACTED:401, src/v2/templates/group/groupview.php:196
  • This <div role="dialog"> is a modal dialog, but nothing moves focus into it when it opens and nothing keeps focus inside it while it is open, so a keyboard or screen-reader user keeps acting on the content behind it (WCAG 2.4.3). Use a native <dialog> opened with showModal(), a dialog component that traps focus, or move focus to the dialog on open, trap Tab inside it (or make the page behind inert) and return focus to the control that opened it on close. — src/v2/templates/group/groupedit.php:31

What to do

  • Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href.
AC5 · ARIA correctness6.4 / 10Adequate✓ Tool-verified

Other · Accessibility — Whether ARIA is used correctly — valid non-abstract roles, the ARIA state a role requires, valid (non-misspelled) aria-* attribute names, in-enum values for token-typed aria-* attributes, and no aria-hidden on (or wrapping) a focusable element. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: role values checked against the WAI-ARIA role set (abstract/invalid flagged), required ARIA state for a role, and aria-hidden on a focusable element. Deterministic, role/attribute level.

Coverage: Population: elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx) that carry a role or an aria-* attribute; roles and token values are checked against the ARIA enums exhaustively within that set. An expression-valued (dynamic) role or aria-* value is skipped rather than guessed, and markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

  • aria-hidden="true" hides the element from assistive tech but leaves it keyboard-focusable — a confusing dead stop. Remove aria-hidden or make the element non-focusable. (×14) — src/ident/templates/verify/verify-family-info.php:83, src/ident/templates/verify/verify-person-info.php:76, src/v2/templates/BackupRestore/backup.php:29, …
  • aria-hidden="true" here hides the subtree from assistive tech, but a focusable descendant stays in the tab order — a keyboard user can land on a control screen readers can't see. Add inert, take the descendants out of the tab order (tabindex="-1"), or drop aria-hidden. (×7) — REDACTED:127, src/v2/templates/group/groupedit.php:31, src/v2/templates/people/familyview.php:975, …

What to do

  • Use valid, non-abstract roles, supply the ARIA state each role requires, and never put aria-hidden on a focusable element.
AC6 · Visual & motion safety6.8 / 10Adequate✓ Tool-verified

Other · Accessibility — Whether focus outlines aren't removed without a replacement, motion respects prefers-reduced-motion, and literal CSS colour pairs meet contrast — PARTIAL: inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS literals are read (hex/rgb/hsl/named), never computed/runtime/external-CDN colour. Static markup readiness, not a WCAG conformance claim.

Method: Static markup/CSS scan: inline outline:none/0, literal inline colour/background contrast against the 4.5:1 AA floor, and <style>-block animation without a prefers-reduced-motion guard. Deterministic but PARTIAL — only inline styles and in-repo CSS literals are visible.

Coverage: Population: styled elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx), plus in-repo <style> blocks, in-repo .css files and CSS-in-JS literals. Colour contrast is computed from LITERAL colour pairs only (hex/rgb/hsl/named, including var() tokens and Tailwind neutral utilities) — computed, runtime-themed and external-CDN colour is never resolved, so this is a partial read of contrast by construction. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

  • `.btn-sm` sets color: white on background-color: #62b1d0 — 2.4:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. (×2) — src/ident/templates/verify/verify-family-info.php:129, src/ident/templates/verify/verify-person-info.php:122
  • `.settings-tab-link.active` sets color: #fff on background-color: #0ea5e9 — 2.8:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — src/v2/templates/sidebar/systemsettings.php:45
  • `.dark-mode .settings-tab-link.active` sets color: #f8fafc on background-color: #0284c7 — 3.9:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — src/v2/templates/sidebar/systemsettings.php:112
  • `.bg-gradient-blue` sets color: rgb(255, 255, 255) on background-color: linear-gradient(to top right, rgb(38, 143, 255), rgb(74, 106, 140)) repeat-x rgb(0, 123, 255) — 3.3:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. (×2) — src/skin/scss/_adminLTE_update.scss:681, src/skin/scss/_adminLTE_update.scss:701
  • `.edrive-upload-icon` sets color: #287c98 on background-color: #e2f1f7 — 4.1:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — src/skin/scss/_fileManager.scss:95
  • `.print-table-header` sets color: white on background-color: gray — 3.9:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — src/skin/scss/_print.scss:13
  • `.wizard > .steps .number` sets color: #007bff on background-color: #e9f2ff — 3.5:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — src/skin/scss/_setup.scss:81
  • `.wizard > .steps .current a, .wizard > .steps .current a:hover, .wizard > .steps .current a:active` sets color: #fff on background-color: #007bff — 4.0:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — src/skin/scss/_setup.scss:99
  • `.wizard > .steps .done .number` sets color: #1e7e34 on background-color: #d4edda — 4.1:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — src/skin/scss/_setup.scss:119
  • `.wizard > .steps .disabled a, .wizard > .steps .disabled a:hover, .wizard > .steps .disabled a:active` sets color: #6c757d on background-color: #f8f9fa — 4.4:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — src/skin/scss/_setup.scss:126
  • `.wizard > .actions a.btn-primary, .wizard > .actions a.btn-primary:hover, .wizard > .actions a.btn-primary:active, .wizard > .actions a.btn-primary:focus` sets color: #fff on background-color: #007bff — 4.0:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — src/skin/scss/_setup.scss:185
  • `.upgrade-timeline-badge` sets color: #94a3b8 on background-color: #fff — 2.6:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — src/skin/scss/_upgrade_system.scss:113
  • `.upgrade-step-card.is-locked .step-icon, .upgrade-timeline-step.is-locked .upgrade-timeline-badge` sets color: #94a3b8 on background-color: #fff — 2.6:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — src/skin/scss/_upgrade_system.scss:256
  • `.upgrade-step-card.is-locked .step-status` sets color: #64748b on background-color: #e2e8f0 — 3.9:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — src/skin/scss/_upgrade_system.scss:263
  • `.navbar-search-form` moves (`transition: flex-basis 0.2s ease, width 0.2s ease, max-width 0.2s ease`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — src/skin/scss/_adminLTE_update.scss:418
  • `.crm-global-message__close` moves (`transition: opacity 0.2s ease, background-color 0.2s ease, transform 0.2s ease`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — src/skin/scss/_alert.scss:55
  • `.crm-ckeditor-upload-progress-bar` moves (`transition: width 150ms linear`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — src/skin/scss/_ckeditorExtension.scss:225
  • `.map-shell-button` moves (`transition: transform 0.18s ease, box-shadow 0.18s ease, background-color 0.18s ease, border-color 0.18s ease`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — src/skin/scss/_maps.scss:61
  • `div .legenditem` moves (`transition: transform 0.18s ease, box-shadow 0.18s ease, background-color 0.18s ease`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — src/skin/scss/_maps.scss:213
  • `.quick-access-entry-icon` moves (`transition: transform 0.2s ease`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — src/skin/scss/_quick_access.scss:75
  • `.upgrade-step-card` moves (`transition: transform 0.25s ease, box-shadow 0.25s ease, border-color 0.25s ease, opacity 0.25s ease`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — src/skin/scss/_upgrade_system.scss:145

What to do

  • Keep a visible focus style (don't remove the outline without a replacement), guard animation with prefers-reduced-motion, and raise low-contrast colour pairs to at least 4.5:1.
AX10 · Code composition9.8 / 10Exemplary✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

AX3 · Project dependency cycles10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).

Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.

AX4 · Dependency direction10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.

Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.

AX6 · Interface segregation10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').

Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.

M1 · Documentation (README)6.0 / 10Adequate✓ Tool-verified

Maturity · Maturity — Whether the repository and its projects have a README, and whether it is substantive.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

What to do

  • Add a build/run (quick start) section to the root README — the first thing a newcomer needs.
  • Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
M2 · Architecture documentation2.0 / 10Critical✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

  • No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.

What to do

  • Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
M3 · Folder & project structure8.0 / 10Strong✓ Tool-verified

Maturity · Maturity — Whether the repository is organised deliberately: production code and tests are set apart in a way its ecosystem or the repository itself declares.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

P1 · CI/CD gates5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

  • The pipeline is well-formed, but the only CI definition is `.travis.yml`, and `.travis.yml` still points at `travis-ci.org` — a service shut down in June 2021. No other CI is configured in this repository, so nothing has been building or testing changes here since that shutdown — the steps below describe a gate that is not running. Porting it is mostly mechanical: the build and test commands already written here are what a replacement pipeline would run.

What to do

  • Port the existing pipeline to a CI service that is still operating — the build and test steps are already specified — and remove the dead configuration and its badge so the repository stops advertising a gate that no longer exists.
P2 · Observability7.0 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.

Method: Filesystem/Roslyn scan: structured-logging frameworks (Serilog, NLog), OpenTelemetry, and health-check endpoint patterns. Exhaustive, deterministic.

What to do

  • Add a health-check endpoint (Laravel's /up health route or a /health route) so orchestrators and load balancers can probe liveness/readiness.
P3 · Security & performance tooling0.0 / 10Critical✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

  • No static application security testing detected. For this repository's stack, add phpstan or psalm (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 1 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
  • `package.json` declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices — including after an advisory is published against it. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per ecosystem the tree uses (or an enabled `renovate.json`), and gate pull requests with `actions/dependency-review-action`. — package.json:22

What to do

  • Add a SAST step to CI running what this repository's stack ships: phpstan or psalm — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
  • Enable Dependabot/Renovate or a dependency-review gate.
  • Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
P4 · Deployment & Rollback5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.

Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.

  • Deployment is orchestrated by compose, but no service declares a `healthcheck:` and nothing pins a previous image to fall back to — the runtime can tell that the container is up, not that it is serving, so a bad release is harder to detect and reverse.

What to do

  • Add a `healthcheck:` to the served compose service — probing the endpoint it already answers on where it has one — with `depends_on: condition: service_healthy` on whatever waits for it, and keep the deployed image tag immutable and recorded so rolling back is re-pointing at the previous tag rather than rebuilding.
  • Add an approval/environment gate (required reviewers / protection rules) before production promotion.
P5 · DR & Backup7.0 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether disaster recovery is planned and codified — backups, geo-recovery, RTO/RPO, persistence guarantees — from IaC + container manifests + docs, never the live cloud.

Method: Filesystem scan: disaster recovery, backup, geo-recovery, RTO/RPO, persistence guarantees from IaC, manifests, and docs. Exhaustive, deterministic, never a live environment.

What to do

  • Document RTO/RPO and a tested restore procedure (a backup config alone isn't disaster recovery).
P6 · Release Hygiene10.0 / 10Exemplary✓ Tool-verified

Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.

Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.

P7 · Outbound HTTP resilience3.0 / 10Weak✓ Tool-verified

Readiness · Readiness — Whether outbound HTTP calls are wrapped in resilience (retry/timeout/circuit-breaker) so a failing dependency doesn't cascade.

Method: Source scan: outbound HTTP clients and what bounds them — resilience handlers (Polly, AddStandardResilienceHandler) on .NET; on Go, the JVM, Python, JavaScript/TypeScript, Ruby, PHP, Rust, Elixir, Swift, Dart and Erlang, a timeout, deadline, retry or breaker beside each call, or a process-wide client default (a framework-wide deadline such as Drupal core's, Laravel's or actix's awc counts). Exhaustive, deterministic.

  • `curl_exec (` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout. — src/EcclesiaCRM/BackupManager.php:704
  • `curl_exec(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout. — REDACTED:414

What to do

  • Give every client an explicit bound: `new Client(['timeout' => 10, 'connect_timeout' => 3])` for Guzzle (whose default is to wait forever), `CURLOPT_TIMEOUT`/`CURLOPT_CONNECTTIMEOUT` before `curl_exec`, `timeout`/`max_duration` on Symfony HttpClient (or `framework.http_client.default_options`), and a stream-context `timeout` or `connection_timeout` for `file_get_contents`/`SoapClient`. In Drupal, use the `http_client` service, which carries core's site-wide timeout, rather than `new Client()`. Add retries with back-off (Guzzle `Middleware::retry`, Symfony `RetryableHttpClient`, Laravel `->retry()`) around dependencies that fail.
PF3 · Async & latency hygiene10.0 / 10Exemplary✓ Tool-verified

Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.

Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from each language's code model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.

R1 · Type Safety0.0 / 10Critical✓ Tool-verified

React / JS · Code Health — How much of the frontend is typed TypeScript vs untyped JavaScript.

Method: Frontend file inventory: the share of typed TypeScript vs untyped JavaScript across the source tree. Deterministic, exhaustive over frontend files.

  • 0 typed · 681 plain JS — the untyped files are scripts/test-edrive-actions.js, src/Plugins/BirthdayAnniversaryDashboard/locale/js/ar_EG.js, src/Plugins/BirthdayAnniversaryDashboard/locale/js/da_DK.js, src/Plugins/BirthdayAnniversaryDashboard/locale/js/de_DE.js, src/Plugins/BirthdayAnniversaryDashboard/locale/js/el_GR.js, src/Plugins/BirthdayAnniversaryDashboard/locale/js/en_AU.js (+675 more).

What to do

  • Adopt TypeScript for the frontend: add a typecheck step to the build, then either type-check the existing JavaScript in place (`checkJs`/JSDoc types) or convert the highest-traffic modules first — no file is typed today, so this is an adoption, not a clean-up.
R10 · Code Duplication0.0 / 10Critical✓ Tool-verified

React / JS · Code Health — The share of the scored frontend lines inside a near-exact copy-pasted block of substantial extent (the D4 clone algorithm over JS/TS tokens, D-386; each line once, 10 at none and 0 at a quarter of the lines, as D4): a block is reported only where its copies still agree on most of their own identifiers and literals, or were renamed as they were pasted but kept most of their constants, and where the copies carry enough code to stand on their own or the copied extent reaches 30 lines — so a re-implementation sharing neither names nor values, and a small pasted declaration, are both found and deliberately not reported, and a clean R10 is not a claim that nothing was copied.

Method: Near-exact copy-pasted blocks of substantial extent across the frontend (the D4 clone algorithm run over JS/TS tokens). Masking finds the candidates; a block is reported when its copies still agree on most of their own identifiers and literals, or when a renamed copy still agrees on most of its constants, AND the copies carry enough code to stand on their own — or when the copied extent reaches 30 lines. So a re-implementation sharing neither names nor values, and a small pasted declaration, are deliberately not counted. Scored on the share of the scored frontend lines inside a reported copy, on the same curve as D4. Deterministic.

  • 64 duplicated blocks under src/skin/js/ have copies in at least two of the sibling directories Search, calendar, event, finance, gdpr, group (+10 more sibling(s) not listed) — 48 of them are reported below, and 16 are counted here but not reported individually: those copies match on shape but no longer clear R10's bar for an individually reported row — either they kept neither their own names nor their values, or what was copied is too small to stand on its own (it reports near-exact duplication only, and only of substantial extent). What this row states is the concentration, which the detector measured over all 64 and which does not depend on how exactly each block's copies still match. That concentration is one structural fact, not 64 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 64 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on. — REDACTED:332
  • 21 duplicated blocks under src/ have copies in at least two of the sibling directories Plugins, skin — 12 of them are reported below, and 9 are counted here but not reported individually: those copies match on shape but no longer clear R10's bar for an individually reported row — either they kept neither their own names nor their values, or what was copied is too small to stand on its own (it reports near-exact duplication only, and only of substantial extent). What this row states is the concentration, which the detector measured over all 21 and which does not depend on how exactly each block's copies still match. That concentration is one structural fact, not 21 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 21 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on. — src/Plugins/MailChimp/skin/js/DuplicateEmails.js:10
  • REDACTED:332 · src/skin/js/volunteer/VolunteerOpportunityView.js:3 — the two spans are one implementation copied and then locally edited — 2298 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — REDACTED:332
  • src/skin/js/people/FamilyVerify.js:9 · src/skin/js/people/PersonVerify.js:9 — the two spans are one implementation copied and then locally edited — 1091 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/skin/js/people/FamilyVerify.js:9
  • src/skin/js/pastoralcare/PastoralCareFamily.js:9 · src/skin/js/pastoralcare/PastoralCarePerson.js:9 — these 2 files are line-for-line copies of one another — 127 lines are identical, in the same order, in every one of them — so this is one fact about the file set, not a block to extract. An edit made to one file and not the others changes behaviour silently, which is the failure a wholesale copy guarantees. Pick one file as the single source and derive the others from it (re-export it, spread it into the local overrides each variant genuinely needs, or generate the copies at build time) — the few lines that differ between the files are exactly the part each variant should still own. Check first whether the copies are deliberately standalone deliverables (a translation file seeded from its sibling and waiting to be translated); where they are, the duplication is the design, and the honest move is to mark the seeded file as untranslated rather than to let it pass as done. — src/skin/js/pastoralcare/PastoralCareFamily.js:9
  • src/skin/js/people/FamilyView.js:604 · src/skin/js/people/PersonView.js:1413 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/skin/js/people/FamilyView.js:604
  • src/skin/js/calendar/CalendarSideBar.js:722 · REDACTED:816 — the two spans are one implementation copied and then locally edited — 511 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/skin/js/calendar/CalendarSideBar.js:722
  • src/skin/js/Search/Search.js:644 · src/skin/js/Search/Search.js:725 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. — src/skin/js/Search/Search.js:644
  • src/skin/js/sidebar/PropertyList.js:103 · src/skin/js/sidebar/PropertyTypeList.js:133 — the two spans are one implementation copied and then locally edited — 362 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/skin/js/sidebar/PropertyList.js:103
  • src/skin/js/people/FamilyView.js:445 · src/skin/js/people/PersonView.js:1261 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/skin/js/people/FamilyView.js:445
  • src/skin/js/sidebar/FamilyCustomFieldsEditor.js:1 · src/skin/js/sidebar/PersonCustomFieldsEditor.js:1 — the 2 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it. — src/skin/js/sidebar/FamilyCustomFieldsEditor.js:1
  • REDACTED:954 · src/skin/js/sundayschool/SundaySchoolDashboard.js:56 — the two spans are one implementation copied and then locally edited — 350 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — REDACTED:954
  • src/skin/js/sidebar/FundList.js:148 · src/skin/js/sidebar/PastoralCareList.js:140 — the 2 copies are spread across 2 files, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are. — src/skin/js/sidebar/FundList.js:148
  • src/Plugins/MailChimp/skin/js/NotInMailChimpFamilies.js:10 · src/Plugins/MailChimp/skin/js/NotInMailChimpPersons.js:10 — the 2 copies are spread across 2 files, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are. — src/Plugins/MailChimp/skin/js/NotInMailChimpFamilies.js:10
  • src/skin/js/people/FamilyView.js:549 · src/skin/js/people/PersonView.js:1358 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/skin/js/people/FamilyView.js:549
  • src/Plugins/ToDoListDashboard/skin/js/ToDoListDashboard.js:353 · src/Plugins/ToDoListDashboard/skin/js/ToDoListDashboard.js:458 — the two spans are one implementation copied and then locally edited — 280 tokens are still identical, in the same order in both spans, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/Plugins/ToDoListDashboard/skin/js/ToDoListDashboard.js:353
  • src/skin/js/people/FamilyView.js:722 · src/skin/js/people/PersonView.js:1608 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/skin/js/people/FamilyView.js:722
  • REDACTED:1950 · src/skin/js/system/SettingsIndividual.js:77 — the 2 copies are spread across 2 files, and what repeats is a LIST OF ENTRIES rather than behaviour — the same entries written out more than once. Extract them into one shared, exported constant and spread that constant into each site, rather than into a function the sites call: a list like this often lives in declarative metadata (a decorator's options object, a static configuration table) that a build step must be able to read statically, where a function call is not allowed. Adding an entry to one copy and not the other is the failure this prevents. — REDACTED:1950
  • src/skin/js/people/FamilyView.js:789 · src/skin/js/people/PersonView.js:1550 — the two spans are one implementation copied and then locally edited — 406 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/skin/js/people/FamilyView.js:789
  • src/Plugins/MailChimp/skin/js/Dashboard.js:267 · src/Plugins/MailChimp/skin/js/ManageList.js:1005 — the two spans are one implementation copied and then locally edited — 271 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/Plugins/MailChimp/skin/js/Dashboard.js:267
  • src/skin/js/people/FamilyList.js:22 · src/skin/js/people/PersonList.js:22 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/skin/js/people/FamilyList.js:22
  • src/skin/js/filemanager.js:990 · src/skin/js/filemanager.js:1057 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. — src/skin/js/filemanager.js:990
  • src/skin/js/pastoralcare/PastoralCareDashboard.js:96 · src/skin/js/pastoralcare/PastoralCareMembersList.js:14 — the two spans are one implementation copied and then locally edited — 288 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/skin/js/pastoralcare/PastoralCareDashboard.js:96
  • src/skin/js/calendar/CalendarSideBar.js:463 · src/skin/js/calendar/CalendarSideBar.js:626 — the two spans are one implementation copied and then locally edited — 285 tokens are still identical, in the same order in both spans, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/skin/js/calendar/CalendarSideBar.js:463
  • src/skin/js/calendar/CalendarSideBar.js:1137 · src/skin/js/calendar/CalendarSideBar.js:1174 · src/skin/js/calendar/CalendarSideBar.js:1211 · src/skin/js/calendar/CalendarSideBar.js:1248 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. — src/skin/js/calendar/CalendarSideBar.js:1137
  • src/skin/js/people/online-pending-verify.js:1 · src/skin/js/people/self-verify-updates.js:1 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/skin/js/people/online-pending-verify.js:1
  • src/skin/js/sidebar/FundList.js:1 · src/skin/js/sidebar/FundList.js:122 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/skin/js/sidebar/FundList.js:1
  • REDACTED:689 · REDACTED:720 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. — REDACTED:689
  • src/Plugins/MailChimp/skin/js/ManageList.js:526 · src/Plugins/MailChimp/skin/js/ManageList.js:1021 — the two spans are one implementation copied and then locally edited — 247 tokens are still identical, in the same order in both spans, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/Plugins/MailChimp/skin/js/ManageList.js:526
  • src/Plugins/PersonInfosDashboard/skin/js/synchronize/PersonDashboardItemPlugin.js:2 · src/Plugins/PersonInfosDashboard/skin/js/synchronize/PersonDashboardItemPlugin.js:45 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/Plugins/PersonInfosDashboard/skin/js/synchronize/PersonDashboardItemPlugin.js:2
  • src/skin/js/calendar/CalendarSideBar.js:49 · src/skin/js/calendar/CalendarSideBar.js:140 · src/skin/js/calendar/CalendarSideBar.js:225 · src/skin/js/calendar/CalendarSideBar.js:302 — all 4 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/skin/js/calendar/CalendarSideBar.js:49
  • REDACTED:227 · src/skin/js/volunteer/VolunteerOpportunityView.js:495 — the 2 copies are spread across 2 files, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are. — REDACTED:227
  • src/skin/js/pastoralcare/PastoralCareDashboard.js:257 · src/skin/js/pastoralcare/PastoralCareDashboard.js:304 · src/skin/js/pastoralcare/PastoralCareDashboard.js:359 · src/skin/js/pastoralcare/PastoralCareDashboard.js:414 · +2 more site(s) not listed — the 6 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/skin/js/pastoralcare/PastoralCareDashboard.js:257
  • REDACTED:1137 · REDACTED:1237 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — REDACTED:1137
  • src/skin/js/ckeditor/ckeditorextension.js:215 · src/skin/js/ckeditor/ckeditorextension.js:318 — the two spans are one implementation copied and then locally edited — 189 tokens are still identical, in the same order in both spans, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/skin/js/ckeditor/ckeditorextension.js:215
  • src/skin/js/fundraiser/fundraiserEditor.js:25 · src/skin/js/fundraiser/paddleNumList.js:7 — the 2 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it. — src/skin/js/fundraiser/fundraiserEditor.js:25
  • src/skin/js/people/letterandlabels.js:45 · src/skin/js/people/letterandlabels.js:78 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. — src/skin/js/people/letterandlabels.js:45
  • src/skin/js/event/Checkin.js:20 · src/skin/js/event/EventNames.js:13 — the two spans are one implementation copied and then locally edited — 172 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/skin/js/event/Checkin.js:20
  • src/skin/js/plugins/Plugins.js:3 · src/skin/js/user/UserList.js:3 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — src/skin/js/plugins/Plugins.js:3
  • src/skin/js/event/EditEventAttendees.js:76 · REDACTED:231 · REDACTED:182 · REDACTED:226 · +1 more site(s) not listed — the 5 copies are spread across 4 files, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are. — src/skin/js/event/EditEventAttendees.js:76

What to do

  • Act on each finding's own remediation rather than one rule: the move depends on what recurs. Where the copies are executable blocks, give the shared part one home and call it from each site; where they are declarations, a listing, a specialisation already delegating to its base, or one shape repeated per entity, there is no call site and the move is a shared type, a generated set or a factory — sometimes there is nothing to extract.
R2 · Cyclomatic Complexity9.5 / 10Exemplary✓ Tool-verified

React / JS · Code Health — Per-function cyclomatic/cognitive complexity from the token-level function scanner (D-386) — real branching, not a regex heuristic.

Method: Per-function cyclomatic/cognitive complexity from a token-level function scanner (real branching, not a regex heuristic), computed over every frontend function. Deterministic.

  • eventDidMount has cyclomatic complexity 36 and cognitive complexity 31; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/skin/js/calendar/CalendarV2.js:368
  • (anonymous) has cyclomatic complexity 30 and cognitive complexity 29; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/skin/js/filemanager.js:769
  • buildAddress has cyclomatic complexity 29 and cognitive complexity 9; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/skin/js/pastoralcare/PastoralCareMembersList.js:58
  • callback has cyclomatic complexity 26 and cognitive complexity 28; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/skin/js/ckeditor/ckeditorextension.js:1202
  • reloadLabel has cyclomatic complexity 23 and cognitive complexity 16; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/skin/js/BadgeSticker.js:12
  • buildAddress has cyclomatic complexity 17 and cognitive complexity 9; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/skin/js/pastoralcare/PastoralCareDashboard.js:141
  • render has cyclomatic complexity 16 and cognitive complexity 20; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/skin/js/filemanager.js:283
  • (anonymous) has cyclomatic complexity 15 and cognitive complexity 30; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/Plugins/MailChimp/skin/js/ManageList.js:58
  • renderRestoreProgress has cyclomatic complexity 15 and cognitive complexity 14; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/skin/js/backup/restore.js:35
  • render has cyclomatic complexity 15 and cognitive complexity 11; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/skin/js/Search/Search.js:531
  • (anonymous) has cyclomatic complexity 14 and cognitive complexity 32; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/Plugins/MailChimp/skin/js/Dashboard.js:27
  • buildToolbar has cyclomatic complexity 14 and cognitive complexity 17; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/skin/js/ckeditor/ckeditorextension.js:159
  • (anonymous) has cyclomatic complexity 14 and cognitive complexity 16; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/skin/js/fundraiser/batchWinnerEntry.js:36
  • promptActivationToggle has cyclomatic complexity 14 and cognitive complexity 12; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/Plugins/BirthdayAnniversaryDashboard/skin/js/BirthdayAnniversaryDashboard.js:118
  • (anonymous) has cyclomatic complexity 13 and cognitive complexity 14; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — REDACTED:22
  • receiveFile has cyclomatic complexity 13 and cognitive complexity 10; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/skin/js/ckeditor/ckeditorextension.js:1063
  • (anonymous) has cyclomatic complexity 12 and cognitive complexity 20; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — REDACTED:2153
  • (anonymous) has cyclomatic complexity 12 and cognitive complexity 16; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. (×2) — src/skin/js/BadgeSticker.js:52, src/skin/js/system/KioskJSOM.js:257
  • (anonymous) has cyclomatic complexity 12 and cognitive complexity 12; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/skin/js/system/setup.js:500
  • (anonymous) has cyclomatic complexity 12 and cognitive complexity 11; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/skin/js/calendar/CalendarSideBar.js:888
  • SundaySchoolDisplay has cyclomatic complexity 11 and cognitive complexity 10; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — REDACTED:1741
  • createEditor has cyclomatic complexity 11 and cognitive complexity 10; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/skin/js/ckeditor/ckeditorextension.js:1284
  • (anonymous) has cyclomatic complexity 11 and cognitive complexity 10; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/skin/js/people/PersonView.js:1549
R3 · Large Files8.8 / 10Strong✓ Tool-verified

React / JS · Code Health — How many source files exceed the large-file threshold.

Method: Components/modules exceeding the large-file threshold, counted exhaustively across the frontend source tree. Deterministic.

  • REDACTED has 2075 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — REDACTED:1
  • src/skin/js/filemanager.js has 1530 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — src/skin/js/filemanager.js:1
  • src/skin/js/people/PersonView.js has 1514 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — src/skin/js/people/PersonView.js:1
  • src/skin/js/ckeditor/ckeditorextension.js has 1373 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — src/skin/js/ckeditor/ckeditorextension.js:1
  • src/skin/js/calendar/CalendarSideBar.js has 1133 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — src/skin/js/calendar/CalendarSideBar.js:1
  • REDACTED has 1131 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — REDACTED:1
  • src/Plugins/MailChimp/skin/js/ManageList.js has 1110 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — src/Plugins/MailChimp/skin/js/ManageList.js:1
  • REDACTED has 877 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — REDACTED:1
  • src/skin/js/calendar/EventEditor.js has 865 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — src/skin/js/calendar/EventEditor.js:1
  • src/skin/js/people/FamilyView.js has 783 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — src/skin/js/people/FamilyView.js:1
  • src/skin/js/calendar/CalendarV2.js has 752 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — src/skin/js/calendar/CalendarV2.js:1
  • src/skin/js/Search/Search.js has 738 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — src/skin/js/Search/Search.js:1
  • src/skin/js/pastoralcare/PastoralCareDashboard.js has 521 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — src/skin/js/pastoralcare/PastoralCareDashboard.js:1
  • src/skin/js/calendar/EventsList.js has 500 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — src/skin/js/calendar/EventsList.js:1
  • src/skin/js/volunteer/VolunteerOpportunityView.js has 488 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — src/skin/js/volunteer/VolunteerOpportunityView.js:1
  • src/Plugins/ToDoListDashboard/skin/js/ToDoListDashboard.js has 482 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — src/Plugins/ToDoListDashboard/skin/js/ToDoListDashboard.js:1
  • src/skin/js/system/setup.js has 460 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — src/skin/js/system/setup.js:1
  • src/skin/js/event/Checkin.js has 455 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — src/skin/js/event/Checkin.js:1
  • src/skin/js/system/KioskJSOM.js has 441 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — src/skin/js/system/KioskJSOM.js:1
  • src/skin/js/finance/DepositSlipEditor.js has 417 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — src/skin/js/finance/DepositSlipEditor.js:1

What to do

  • Split each oversized file along the responsibilities already in it, into smaller focused modules in the same package.
R4 · Test Coverage0.0 / 10Critical✓ Tool-verified

React / JS · Readiness — Static test reachability (D-386): the share of production files reachable from any test via the import graph — measured without running anything.

Method: Static test reachability: the share of production files reachable from any test via the import graph — measured without running anything. Deterministic.

  • 0% of 680 production file(s) reachable from 0 test file(s) via the import graph — 'production' here is the RESIDUE: every source file left once tests, tooling, generated output, config, declarations and declaration-only modules, fixture corpora, type fixtures, behaviour-free data modules, re-export barrels, registration/constant data modules and service workers are set aside, so the percentage is taken over a smaller denominator than the workspace's file count

What to do

  • Add tests that import the unreached modules (directly or through their public entry).
R6 · Tooling3.4 / 10Weak✓ Tool-verified

React / JS · Readiness — Whether the project wires up test, lint and typecheck — detected from each package.json script's COMMAND (eslint / tsc / vitest / jest / playwright), not just its name, and corroborated against CI-workflow invocations so a tool run only in CI still counts.

Method: package.json scanned for test/lint/typecheck script wiring. Deterministic presence check.

  • test ✓ · lint ✗ · typecheck ✗ — read from this repository's package.json scripts and corroborated against its CI workflows. A script counts when its name or command matches the step: `test` for the suite, `lint` or `prettier` for linting, `typecheck`/`type-check`/`tsc` for type checking. ✗ therefore means no script or CI step under those names was found, NOT that the step is absent from your pipeline — a task invoked by a runner this check does not read, or named something else entirely, is not seen and is worth confirming before acting on a cross. A ✓ means the wiring is DECLARED — a script or CI step under those names exists. It is not a statement that the step passes, or that it runs at all: nothing here installs a dependency or executes a suite.

What to do

  • Add eslint and type checking (adopt TypeScript, or type-check the existing JavaScript with `checkJs`) as package.json scripts and run them in CI.
R7 · Dead Code0.0 / 10Critical✓ Tool-verified

React / JS · Code Health — Files unreachable from every application/tooling/test entry point, and exports nothing imports (module-graph reachability, D-386).

Method: Dead code: files unreachable from every application/tooling/test entry point plus exports nothing imports, via module-graph reachability. Deterministic, exhaustive over the import graph.

  • Unreachable from the 1 application, 1 tooling and 0 test entry point(s) detected in this repo. Nothing this repository declares compiles or type-checks these files, so a wrong deletion here would raise no compile error — gate removals on `npm test`, which loads the modules, and note that it only covers what it exercises. An undetected custom entry would make these reachable.
  • no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make (×39) — REDACTED, src/skin/js/filemanager.js, src/skin/js/people/PersonView.js, …

What to do

  • Delete the dead files and unused exports — every line is maintenance cost and rebuild-estimate inflation with zero runtime value.
R8 · Dependency Hygiene0.5 / 10Critical✓ Tool-verified

React / JS · Readiness — npm dependency truthfulness (D-386): unused dependencies, imports not declared anywhere, and type-/test-only packages shipped as production deps.

Method: npm dependency truthfulness: unused dependencies, imports declared nowhere, and type-/test-only packages shipped as production deps — from the manifest + import graph. Deterministic.

  • Declared in the root package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it. (×19) — package.json:46, package.json:51, package.json:53, …

What to do

  • Remove unused dependencies, declare unlisted imports explicitly, and demote type-/test-only packages to devDependencies.
R9 · Circular Imports10.0 / 10Exemplary✓ Tool-verified

React / JS · Architecture — Import cycles in the module graph (D-386) — files that can only be understood and changed together.

Method: Import cycles in the module graph, detected exhaustively over JS/TS imports (the same cycle detection as the .NET coupling dimension). Deterministic.

S1 · Web-Security Posture6.0 / 10Adequate✓ Tool-verified

Other · Security — Only what this repository's own non-C# files could be read for was assessed — markup this repository SHIPS is scored for third-party script integrity whether or not the repository serves it itself, since a page handed to a consumer runs in that consumer’s origin — and because this repository commits the configuration that serves its own HTTP surface, that configuration could be read in full for the security response headers it sets. Nothing else in this dimension was assessed: the transport, cookie, input-validation and crypto controls are read from a source model that was not loaded for this repository’s language, so their absence here is not a finding about this repository.

Method: Roslyn plus filesystem scan: HSTS/security headers, secure cookies, input validation, middleware order, weak crypto (MD5/SHA1/DES); HTTPS-metadata context-aware. On a repository with no .NET source it reads JavaScript/TypeScript, Dart, Ruby, Scala, Rust or Elixir source itself (test, vendored, generated and minified paths not) for the arms that hold whether or not the code serves HTTP: a weak hash or cipher, key material fixed in the source, a TLS client that accepts any certificate, and (JavaScript/TypeScript, Ruby, Scala, Rust and Elixir) an obsolete TLS version; the server controls are not assessed there, and a Dart, Ruby, Scala, Rust or Elixir repository that serves no HTTP of its own is N/A on them. Deterministic.

  • `https://unpkg.com/jsqr@1.4.0/dist/jsQR.js` is executed by this page with no Subresource Integrity. Whoever can answer that request — the CDN, anyone who compromises it, anyone on the network path — runs arbitrary script in this page's origin, with its session. — src/v2/templates/people/ConfirmReportCheck.php:209
  • None of the 11 security response headers the OWASP Secure Headers Project recommends (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options, …) is configured — defense in depth, even when a reverse proxy could set them. This is reported because `default.conf` is committed to this repository and declares the server that serves it, so the configuration that would carry these headers is in this repository and was read in full. (−2.0 on this card.) — docker/config/vhosts/default.conf:1

What to do

  • Pin third-party scripts and verify them: name an exact version in the URL and add an `integrity="sha384-…"` hash alongside `crossorigin="anonymous"` (both are required — an integrity hash on a cross-origin script without `crossorigin` is not evaluated, it blocks the script). Where the vendor ships a continuously-updated loader and publishes no stable hash (tag managers, analytics, chat widgets), Subresource Integrity is not available: constrain it instead with a `Content-Security-Policy` that names the exact origins allowed to execute, and drop the script from the pages that do not need it. Where the page is shipped inside a package that others host, prefer vendoring the asset and serving it from the app’s own origin, so no consumer inherits a third-party dependency they did not choose.
  • Set security response headers on the surface this repository serves: an `add_header` directive per header in the nginx/Caddy/Apache config, a `_headers` / `vercel.json` / `netlify.toml` entry for a static host, or `helmet()` in the HTTP server. `Content-Security-Policy` is the one that pays for itself first — it is what contains an injected script once one reaches the page — followed by `X-Content-Type-Options: nosniff` and a frame policy (`X-Frame-Options: DENY`, or CSP `frame-ancestors`). Where the app is served from a build container, the header configuration belongs in the image beside the built assets, so it ships with them rather than depending on where it lands.
X16 · Unfloored truncation loop10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.

Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.

X18 · Disposal-pattern correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.

Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.

X19 · Unrestored process-global state10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.

Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.

X2 · Cancellation propagation4.0 / 10Weak✓ Tool-verified

Other · Code Health — Whether async functions that make a cancellable request accept or pass on an AbortSignal (adoption curve).

Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.

  • Only 0/1 async functions that make a cancellable request (fetch, axios, ky, ofetch, got, undici, node:http) accept an AbortSignal or pass one on, so a request keeps running after whatever wanted it has given up — a page navigated away from, an unmounted component, a timed-out job. Take a `signal` (or an options object that carries one) and hand it to the request; where nothing could ever cancel the call, omitting it is a deliberate choice — judge against how the function is used.
  • `VerifyThenLoadAPIContent` awaits `fetch(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `fetch(url, { signal })`. — REDACTED:385

What to do

  • Thread an AbortSignal through async functions that make requests, so the work stops when its caller gives up.
X21 · Side-effecting pattern guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.

Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.

X23 · Unguarded diagnostic materialisation10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.

Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.

X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `for` loop leaves the `dict`, `set` or `deque` it is walking alone — CPython's iterators over those check that the collection has not changed size since the loop began, so a body that removes from (or empties) the very collection the loop is walking makes the next step raise `RuntimeError: dictionary changed size during iteration` and the remaining items are never seen. Whether a `foreach` leaves the array or collection it is walking alone — PHP raises nothing, but the loop's view and the collection part: an array walked by value (and a Doctrine or Laravel collection) is walked as the snapshot taken when the loop began, so an element added in the body is never visited and one removed is visited anyway; an array walked by reference (`as &$v`) and an SPL container (`SplObjectStorage`, `ArrayObject`, `SplQueue`) are walked live, so an added element is walked too and a removal skips the next one; and after an `array_splice`, `array_shift` or sort every later key names a different element.

Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.

X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.

Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.

X29 · Per-element action decided by a fixed element7.9 / 10Strong✓ Tool-verified

Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.

Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.

  • This loop runs once per element of `$personStats`, and the statement it guards acts on the element it is on — `$value`. The test deciding whether that statement runs does not: `$personStats['ClassificationCount'] > 0` reads `$personStats['ClassificationCount']`, a subscript that does not move, so whatever it answers for that one element it answers for ALL of them. One `if` names the same collection at two different subscripts, which is the contradiction: either the test was meant to be per-element, in which case every element that differs from the fixed one is handled wrongly and all in the same direction, or it really is one answer for the whole collection, in which case it is being re-asked on every pass and belongs above the loop. The `if` is in the wrong place under both readings. Give the test the loop variable, or hoist it out. — src/v2/templates/people/peopledashboard.php:361

What to do

  • Each finding names the test and the statement it guards, which index the same collection at two different subscripts — one fixed, one the loop variable. Confirm from the two, then decide which subscript the test meant. If it was meant to be per-element, give it the loop variable so each element is judged on itself. If it really is one answer for the whole collection, hoist the test OUT of the loop, where a reader can see it is asked once and where it is not re-evaluated on every pass — leaving it inside, reading a fixed element, is the one arrangement that cannot be right under either reading.
X3 · Exception handling2.0 / 10Critical✓ Tool-verified

Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.

Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.

  • An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. (×39) — src/v2/templates/calendar/eventnames.php:70, src/Plugins/VolunteerDashboardWidget/locale/js/ar_EG.js:1, src/Plugins/VolunteerDashboardWidget/locale/js/da_DK.js:1, …
  • `catch (e)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, or keep only the failure you expect and rethrow the rest (`catch (e) { if (!(e instanceof SyntaxError)) throw e; … }`, or test `e.name`), because a JavaScript catch takes every exception, programming errors included. — src/skin/js/edrive/CollaboraEditor.js:53

What to do

  • Swallowed exception (empty catch)
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.

Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.

X4 · Structured logging7.5 / 10Strong✓ Tool-verified

Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.

Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `package.json` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.

  • `debug` at line 382 is handed a double-quoted string with variables interpolated into it as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Pass a constant message and the values in the PSR-3 context array instead: `$logger->debug('Order {order_id} moved to {status}', ['order_id' => $orderId, 'status' => $status])`, which Monolog and every PSR-3 handler keep as fields beside the message (Monolog's PsrLogMessageProcessor fills the placeholders), or `Log::debug('order moved', ['order_id' => $orderId])` with Laravel's facade. — REDACTED:382
  • `debug` at line 389 is handed a double-quoted string with variables interpolated into it as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Pass a constant message and the values in the PSR-3 context array instead: `$logger->debug('Order {order_id} moved to {status}', ['order_id' => $orderId, 'status' => $status])`, which Monolog and every PSR-3 handler keep as fields beside the message (Monolog's PsrLogMessageProcessor fills the placeholders), or `Log::debug('order moved', ['order_id' => $orderId])` with Laravel's facade. — REDACTED:389
  • `debug` at line 407 is handed a double-quoted string with variables interpolated into it as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Pass a constant message and the values in the PSR-3 context array instead: `$logger->debug('Order {order_id} moved to {status}', ['order_id' => $orderId, 'status' => $status])`, which Monolog and every PSR-3 handler keep as fields beside the message (Monolog's PsrLogMessageProcessor fills the placeholders), or `Log::debug('order moved', ['order_id' => $orderId])` with Laravel's facade. — REDACTED:407

What to do

  • Interpolated log message defeats structured logging
X5 · Nullable reference types2.0 / 10Critical✓ Tool-verified

Other · Code Health — Whether PHP's static analysis checks null and is not undermined by a nullness baseline — PHPStan from level 8 (`checkNullables`) or Psalm at `errorLevel` 3 or stricter is what makes `?User` a type whose method call is an error, and the null entries of a baseline, `@psalm-suppress PossiblyNull…` and `@phpstan-ignore *.nonObject` are what silence it.

Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.

  • This repository commits no PHPStan or Psalm configuration (`phpstan.neon[.dist]`, `phpstan.dist.neon`, `psalm.xml[.dist]`, or one a composer.json script names with `--configuration`), so nothing checks null: a `?Customer` reaches `->name()` silently and throws `Error: Call to a member function name() on null` the first time it is null. If the build passes a level on a command line instead, put it in a committed configuration — this check reads configuration, and configuration is all it can read.

What to do

  • Raise PHPStan to level 8 (`level: 8` in `phpstan.neon.dist`, or `max`) or Psalm to `errorLevel="3"` or stricter, so `?Type` is a type the checker holds you to; generate a baseline for what that surfaces only to pay it down, not to keep it. Then resolve the baselined nullness errors rather than adding to them: each is a call on a value the checker showed could be null — narrow it (`if ($x === null) { … }`, `?->`, an early return), make the property non-nullable and initialise it in the constructor, or change the return type so the null cannot arrive.

WCAG coverage — what static analysis assessed

Statically assessed 15 of 55 WCAG 2.2 Level A/AA success criteria (27%; ≈30% of the 50 WCAG 2.1 AA criteria for EN 301 549). The other 40 require runtime or manual evaluation. Partial signal only (a clean result is necessary, not sufficient; static analysis fully verifies none). This is accessibility readiness, not a conformance claim — a WCAG conformance claim requires manual evaluation (WCAG-EM 1.0).

DimensionWCAG 2.2 A/AA criteriaCoverage
AC1 · Text alternatives1.1.1, 1.2.2, 1.2.5Partial signal
AC2 · Forms & labels1.3.1, 3.3.2, 4.1.2Partial signal
AC3 · Page structure1.4.4, 2.2.1, 2.4.1, 2.4.2, 3.1.1, 4.1.2Partial signal
AC4 · Keyboard semantics2.1.1, 2.4.3Partial signal
AC5 · ARIA correctness4.1.2Partial signal
AC6 · Visual & motion safety1.4.3, 2.4.7Partial — literal CSS only

Not statically assessed — these 40 Level A/AA criteria need runtime or manual evaluation (WCAG-EM): 1.2.1, 1.2.3, 1.2.4, 1.3.2, 1.3.3, 1.3.4, 1.3.5, 1.4.1, 1.4.2, 1.4.5, 1.4.10, 1.4.11, 1.4.12, 1.4.13, 2.1.2, 2.1.4, 2.2.2, 2.3.1, 2.4.4, 2.4.5, 2.4.6, 2.4.11, 2.5.1, 2.5.2, 2.5.3, 2.5.4, 2.5.7, 2.5.8, 3.1.2, 3.2.1, 3.2.2, 3.2.3, 3.2.4, 3.2.6, 3.3.1, 3.3.3, 3.3.4, 3.3.7, 3.3.8, 4.1.3.

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

LensScoreRatingImpact
Code Health16.7Critical — gated by D1, D2, R1, R10, R7, X3, X5Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Architecture91.9ExemplarySolid.
Maturity52.8Adequate — gated by M2Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Readiness10.3Critical — gated by D8, D13, R4, R6, R8, P3, P7Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Security51.0Adequate — gated by D28, D29, D31Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Accessibility38.0Weak — gated by AC1, AC4Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Performance100.0ExemplaryStrongest area.
Unscored — 3 check(s) recorded observations but carry no score

These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.

  • SC1 Supply-chain hygiene — 1 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
  • X10 Duplicated predicate — 40 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
  • X7 Silent fallback defaults — 1 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 3 control(s) we could not find positive evidence for

These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.

  • C3 Audit Trail — Not assessed: this repository stores data through 'mysqli' (src/setup/routes/setup.php:43) but declares no persisted model this check reads (Laravel migration columns, Eloquent $fillable/$hidden lists, Doctrine #[ORM\Column] properties). Personal data may be written through raw SQL or a hosted backend, so whether its changes need an audit trail could not be established, and the trail's absence is not scored.
  • C4 Data Retention — Not assessed: this repository stores data through 'mysqli' (src/setup/routes/setup.php:43) but declares no persisted model this check reads (Laravel migration columns, Eloquent $fillable/$hidden lists, Doctrine #[ORM\Column] properties). Personal data may be written through raw SQL or a hosted backend, so whether a retention limit applies here could not be established, and its absence is not scored.
  • C5 Data-Subject Rights — Not assessed: this repository stores data through 'mysqli' (src/setup/routes/setup.php:43) but declares no persisted model this check reads (Laravel migration columns, Eloquent $fillable/$hidden lists, Doctrine #[ORM\Column] properties). Personal data may be written through raw SQL or a hosted backend, so whether data-subject rights apply here could not be established, and their absence is not scored.
Not included — 52 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

  • AX1 Captive dependencies — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX2 Stateful singletons — Not applicable: PHP builds its object graph per request and shares none of it between requests. TypeScript/JavaScript runs each process's requests on one event loop, so no two requests write a shared object at the same instant (interleaving across an await is a different defect).
  • AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX7 Slice cohesion — not applicable — not a vertical-slice architecture
  • AX8 Test isolation — no test/production split to check
  • AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
  • AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • AXR1 Runtime accessibility — compose up failed (exit 1 — a container did not start, exited, or never became healthy) — time="2026-11-17T13:47:22Z" level=warning msg="The \"COLLABORA_ADMIN_PASSWORD\" variable is not set. Defaulting to a blank string." time="2026-11-17T13:47:22Z" level=warning msg="The \"COLLABORA_HTTPS_PORT\" variable is not set. Defaulting to a blank string." services.webserver: container name "docker-" is already in use by service {}"; runtime evidence skipped This is a statement about this run, not a statement about your application: nothing here says the surface is inaccessible, only that it was never rendered.
  • C1 Data Protection — Not assessed: this repository stores data through 'mysqli' (src/setup/routes/setup.php:43) but declares no persisted model this check reads (Laravel migration columns, Eloquent $fillable/$hidden lists, Doctrine #[ORM\Column] properties). Personal data may be written through raw SQL or a hosted backend, so the absence of a personal-data field here is not evidence that none is stored, and encryption at rest is not scored over a subject that could not be established.
  • C2 Access Controls — No access-control surface detected in the analyzed source — this repository registers no route (no Laravel Route::…, no Symfony #[Route], no Filament panel, no WordPress REST route or AJAX action). Access control is therefore N/A here — a Composer library is authorized by the application that mounts it, not by itself. If this codebase grows request handlers, the dimension reactivates and a default-deny posture is expected then.
  • D10 Test Quality — No tests were found in the analyzed repository to assess for quality.
  • D11 Test Reliability — No test suite was found to re-run, so reliability couldn't be assessed. Two searches produced that zero and both came back empty: the classifier that reads the loaded workspace recognised no suite it could run, and a walk of the source on disk — which covers the JS/TS `*.test.*` and `*.spec.*` conventions and probes for a Pester suite — found no test source in any other ecosystem either. Neither search reaches a suite that is missing from the loaded workspace and carries no name either walk recognises, so this is 'no suite found by those two searches', not a verdict that the repository has none.
  • D12 Dependency Hygiene — Not scored — 0 shipped Python distribution(s) were read, but the outdated signal needs pypi.org, and the index lookup answered not published for every exact pin asked about (0 lookup(s)), so this dimension's own question is only partly answered. NOT a finding that these dependencies are current or healthy.
  • D14 License Compliance — npm licences not graded — this npm repository commits no lockfile this pass can resolve
  • D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
  • D21 Naming Consistency — Naming consistency does not read PHP yet; not measured.
  • D22 Internal API Consistency — The exposed public-API surface could not be collected — no C#/VB projects loaded.
  • D23 Boundary Type-Coupling — No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ sibling projects each declaring an entity of their own or taking another project's integration events. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
  • D25 ADR Conformance — no ADRs to check
  • D36 Supply-chain Provenance & Signing — The CI pipeline publishes no artifact — no package publish, container push or release with files to download. Supply-chain provenance, signing and an SBOM describe a PUBLISHED artifact for the people who obtain it, so there is nothing to attest here; a deployment of the service itself publishes nothing for anyone else to verify. Add them to the release pipeline when this repo starts publishing artifacts (a package, a container image, or a release with downloadable files). Build integrity and workflow-token hygiene are reported below: they describe what the CI runs and the token it runs with, neither of which is affected by whether the pipeline ships an artifact.
  • D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
  • D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
  • D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
  • D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
  • DM1 Domain Modelling — not scored — this repository shows none of the 3 signals this lens looks for
  • ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
  • ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
  • ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
  • GD1 Unfinished & placeholder code — no source files were read — this check reads C#, F#, JavaScript/TypeScript, Dart, Ruby, Scala, Rust and Java, and none was read for this repository's product. That is a limit of the analyzer, not a finding about your code.
  • IC1 Incompleteness & stubs — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • M4 Documentation accuracy — Not applicable: the 167 current-state document(s) make no claim of a kind M4 checks. 23 claim(s) of kinds M4 does not check were not checked (path 7, command argument 6, environment variable 7, cd 3); M4 checks only links and versions and artefact counts.
  • P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, and the automatic-re-run check to any GitHub-Actions workflow, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
  • P8 Schema migrations — no ORM, schema-migration tool or schema auto-create was found in this repository's dependency manifests or source, so there is no database schema for this check to judge
  • P9 Domain vs controller coverage — coverage not measured: this check compares the coverage of the analyzer's own test run across the domain and web layers, and that run measured none here — Test coverage (D8) says why
  • PF1 Benchmark discipline — Not applicable: no benchmark suite was found. This check searched for PHPBench subjects (`bench*` methods, or `@Subject`/`#[Subject]` ones) in a file importing PhpBench or carrying its annotations, `bench*` methods in a `*Bench.php` file where PHPBench is installed, or phpbench/phpbench in a composer.json or a phpbench.json, and for a `*benchmark*` script that this repository's CI runs. Benchmarks are credited as a bonus, so their absence is neither scored nor deducted.
  • PF2 Allocation hygiene — Not scored: this check counted allocation-aware idioms (Span, pools, stackalloc) per line, which describes what kind of code a repository is rather than whether it has an allocation problem, so it was withdrawn. Nothing here is a finding about your code.
  • R11 Import Boundaries — No recognizable feature-sliced/layered src layout — boundary rules not applicable.
  • R5 Dependency Freshness — no package-lock.json — dependency freshness not measured (would require an npm lockfile); JS/npm CVEs are scored in D30 (Dependency Vulnerabilities), which answers every ecosystem
  • X1 Async correctness — X1 reached only 20% of this repository's production lines — php (128,426 lines) was left unread. Not scored: a score over a minority of the product would be published as the whole of it.
  • X12 Unreachable branch — X12 reached only 20% of this repository's production lines — php (128,426 lines) was left unread. Not scored: a score over a minority of the product would be published as the whole of it.
  • X13 Undrained process stream — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X14 Bypassable address classification — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X15 Unvalidated length from an untrusted reader — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X17 Uncapped recursion over a caller-supplied document — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X20 Mistyped argument guard — This check asks whether an argument guard reports an EMPTY value as a NULL one, which needs a language that throws a null-specific argument exception — .NET's ArgumentNullException, the JVM's NullPointerException, Dart's ArgumentError.notNull. This repository contains none of those languages: the ones it is written in have a single exception for a bad argument, so there is no pair of exceptions to confuse and nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
  • X22 Contradicted release guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X24 Document value interpolated into markup unescaped — X24 reached only 20% of this repository's production lines — php (128,426 lines) was left unread. Not scored: a score over a minority of the product would be published as the whole of it.
  • X25 Inert configuration knob — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X26 Unsynchronised callback handoff — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
  • X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Critical — 189 finding(s)
D31 · IaC & Container Security · High IaC · ×43
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • + 18 more in this group — see findings.md.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • + 4 more in this group — see findings.md.
AC2 · Forms & labels · <input> without a programmatic label · ×20
  • <input> without a programmatic label src/Plugins/MailChimp/v2/templates/campaign.php:103 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label src/Plugins/MeetingJitsi/v2/templates/meetingsettings.php:37 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label src/Plugins/MeetingJitsi/v2/templates/meetingsettings.php:55 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label src/Plugins/MeetingJitsi/v2/templates/meetingsettings.php:73 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label src/Plugins/ToDoListDashboard/skin/js/ToDoListDashboard.js:50 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <input> without a programmatic label src/Plugins/ToDoListDashboard/skin/js/ToDoListDashboard.js:302 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <input> without a programmatic label src/Plugins/ToDoListDashboard/skin/js/ToDoListDashboard.js:316 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label src/Plugins/ToDoListDashboard/skin/js/ToDoListDashboard.js:327 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <input> without a programmatic label src/external/templates/password/enter-username.php:37 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label src/external/templates/registration/family-register-members.php:83 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label src/external/templates/registration/family-register-members.php:87 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label src/external/templates/registration/family-register-members.php:95 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label src/external/templates/registration/family-register-members.php:119 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label src/external/templates/registration/family-register-members.php:139 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <input> without a programmatic label src/external/templates/registration/family-register-members.php:145 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <input> without a programmatic label src/external/templates/registration/family-register.php:40 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label src/external/templates/registration/family-register.php:51 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label src/external/templates/registration/family-register.php:63 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label src/external/templates/registration/family-register.php:78 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label src/external/templates/registration/family-register.php:90 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
AC1 · Text alternatives · <img> without a text alternative · ×18
  • <img> without a text alternative src/Plugins/MailChimp/v2/templates/campaign.php:72 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative src/Plugins/MailChimp/v2/templates/dashboard.php:48 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative src/Plugins/MailChimp/v2/templates/duplicateemails.php:20 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative src/Plugins/MailChimp/v2/templates/managelist.php:24 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative src/Plugins/MailChimp/v2/templates/notinmailchimpemailsfamilies.php:20 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative src/Plugins/MailChimp/v2/templates/notinmailchimpemailspersons.php:20 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative src/ident/templates/verify/verify-family-info.php:31 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative src/skin/js/sidebar/OptionManager.js:139 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative src/v2/templates/cart/carttobadge.php:233 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative src/v2/templates/fundraiser/donatedItemEditor.php:154 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative src/v2/templates/map/MapUsingGoogle.php:67 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative src/v2/templates/map/MapUsingLeaflet.php:58 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative src/v2/templates/pastoralcare/pastoralcarePersonPrint.php:203 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative src/v2/templates/pastoralcare/pastoralcarefamily.php:39 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative src/v2/templates/pastoralcare/pastoralcareperson.php:37 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative src/v2/templates/people/familyview.php:60 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative src/v2/templates/people/personPrint.php:218 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative REDACTED:965 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
D28 · Secrets (history) · High secret · ×18
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
AC5 · ARIA correctness · aria-hidden on a focusable element · ×14
  • aria-hidden on a focusable element src/ident/templates/verify/verify-family-info.php:83 — aria-hidden="true" hides the element from assistive tech but leaves it keyboard-focusable — a confusing dead stop. Remove aria-hidden or make the element non-focusable.
  • aria-hidden on a focusable element src/ident/templates/verify/verify-person-info.php:76 — aria-hidden="true" hides the element from assistive tech but leaves it keyboard-focusable — a confusing dead stop. Remove aria-hidden or make the element non-focusable.
  • aria-hidden on a focusable element src/v2/templates/BackupRestore/backup.php:29 — aria-hidden="true" hides the element from assistive tech but leaves it keyboard-focusable — a confusing dead stop. Remove aria-hidden or make the element non-focusable.
  • aria-hidden on a focusable element src/v2/templates/dashboard/maindashboard.php:29 — aria-hidden="true" hides the element from assistive tech but leaves it keyboard-focusable — a confusing dead stop. Remove aria-hidden or make the element non-focusable.
  • aria-hidden on a focusable element src/v2/templates/group/groupedit.php:220 — aria-hidden="true" hides the element from assistive tech but leaves it keyboard-focusable — a confusing dead stop. Remove aria-hidden or make the element non-focusable.
  • aria-hidden on a focusable element REDACTED:100 — aria-hidden="true" hides the element from assistive tech but leaves it keyboard-focusable — a confusing dead stop. Remove aria-hidden or make the element non-focusable.
  • aria-hidden on a focusable element src/v2/templates/people/familyview.php:981 — aria-hidden="true" hides the element from assistive tech but leaves it keyboard-focusable — a confusing dead stop. Remove aria-hidden or make the element non-focusable.
  • aria-hidden on a focusable element src/v2/templates/people/familyview.php:1002 — aria-hidden="true" hides the element from assistive tech but leaves it keyboard-focusable — a confusing dead stop. Remove aria-hidden or make the element non-focusable.
  • aria-hidden on a focusable element REDACTED:918 — aria-hidden="true" hides the element from assistive tech but leaves it keyboard-focusable — a confusing dead stop. Remove aria-hidden or make the element non-focusable.
  • aria-hidden on a focusable element REDACTED:925 — aria-hidden="true" hides the element from assistive tech but leaves it keyboard-focusable — a confusing dead stop. Remove aria-hidden or make the element non-focusable.
  • aria-hidden on a focusable element src/v2/templates/people/personview.php:1732 — aria-hidden="true" hides the element from assistive tech but leaves it keyboard-focusable — a confusing dead stop. Remove aria-hidden or make the element non-focusable.
  • aria-hidden on a focusable element src/v2/templates/people/personview.php:1757 — aria-hidden="true" hides the element from assistive tech but leaves it keyboard-focusable — a confusing dead stop. Remove aria-hidden or make the element non-focusable.
  • aria-hidden on a focusable element src/v2/templates/sundayschool/sundayschooldashboard.php:314 — aria-hidden="true" hides the element from assistive tech but leaves it keyboard-focusable — a confusing dead stop. Remove aria-hidden or make the element non-focusable.
  • aria-hidden on a focusable element src/v2/templates/user/changepassword.php:22 — aria-hidden="true" hides the element from assistive tech but leaves it keyboard-focusable — a confusing dead stop. Remove aria-hidden or make the element non-focusable.
AC2 · Forms & labels · <label> that labels no control · ×8
  • <label> that labels no control src/Plugins/CurrentUsersDashboard/v2/templates/View.php:66 — This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
  • <label> that labels no control src/Plugins/MailChimp/v2/templates/campaign.php:101 — This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
  • <label> that labels no control src/Plugins/MailChimp/v2/templates/campaign.php:149 — This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
  • <label> that labels no control src/Plugins/MailChimp/v2/templates/campaign.php:158 — This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
  • <label> that labels no control src/Plugins/MailChimp/v2/templates/managelist.php:70 — This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
  • <label> that labels no control src/Plugins/MeetingJitsi/v2/templates/meetingsettings.php:35 — This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
  • <label> that labels no control src/Plugins/MeetingJitsi/v2/templates/meetingsettings.php:53 — This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
  • <label> that labels no control src/Plugins/MeetingJitsi/v2/templates/meetingsettings.php:71 — This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
AC5 · ARIA correctness · aria-hidden hides a focusable element · ×7
  • aria-hidden hides a focusable element REDACTED:127 — aria-hidden="true" here hides the subtree from assistive tech, but a focusable descendant stays in the tab order — a keyboard user can land on a control screen readers can't see. Add inert, take the descendants out of the tab order (tabindex="-1"), or drop aria-hidden.
  • aria-hidden hides a focusable element src/v2/templates/group/groupedit.php:31 — aria-hidden="true" here hides the subtree from assistive tech, but a focusable descendant stays in the tab order — a keyboard user can land on a control screen readers can't see. Add inert, take the descendants out of the tab order (tabindex="-1"), or drop aria-hidden.
  • aria-hidden hides a focusable element src/v2/templates/people/familyview.php:975 — aria-hidden="true" here hides the subtree from assistive tech, but a focusable descendant stays in the tab order — a keyboard user can land on a control screen readers can't see. Add inert, take the descendants out of the tab order (tabindex="-1"), or drop aria-hidden.
  • aria-hidden hides a focusable element src/v2/templates/people/familyview.php:996 — aria-hidden="true" here hides the subtree from assistive tech, but a focusable descendant stays in the tab order — a keyboard user can land on a control screen readers can't see. Add inert, take the descendants out of the tab order (tabindex="-1"), or drop aria-hidden.
  • aria-hidden hides a focusable element src/v2/templates/people/personview.php:1726 — aria-hidden="true" here hides the subtree from assistive tech, but a focusable descendant stays in the tab order — a keyboard user can land on a control screen readers can't see. Add inert, take the descendants out of the tab order (tabindex="-1"), or drop aria-hidden.
  • aria-hidden hides a focusable element src/v2/templates/people/personview.php:1751 — aria-hidden="true" here hides the subtree from assistive tech, but a focusable descendant stays in the tab order — a keyboard user can land on a control screen readers can't see. Add inert, take the descendants out of the tab order (tabindex="-1"), or drop aria-hidden.
  • aria-hidden hides a focusable element src/v2/templates/sundayschool/sundayschooldashboard.php:306 — aria-hidden="true" here hides the subtree from assistive tech, but a focusable descendant stays in the tab order — a keyboard user can land on a control screen readers can't see. Add inert, take the descendants out of the tab order (tabindex="-1"), or drop aria-hidden.
AC2 · Forms & labels · <button> with no accessible text · ×6
  • <button> with no accessible text src/Plugins/CurrentUsersDashboard/v2/templates/View.php:57 — A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one).
  • <button> with no accessible text src/Plugins/MailChimp/v2/templates/campaign.php:121 — A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one).
  • <button> with no accessible text src/Plugins/MailChimp/v2/templates/campaign.php:140 — A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one).
  • <button> with no accessible text src/Plugins/NoteDashboard/v2/templates/View.php:41 — A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one).
  • <button> with no accessible text src/Plugins/PastoralCareDashboard/v2/templates/View.php:136 — A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one).
  • <button> with no accessible text src/Plugins/ToDoListDashboard/v2/templates/View.php:48 — A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one).
D13 · REDACTED Scanning · Leaked secret · ×5
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D28 · Secrets (history) · REDACTED · ×5
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
AC2 · Forms & labels · <select> without a programmatic label · ×4
  • <select> without a programmatic label src/Plugins/MailChimp/v2/templates/managelist.php:73 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <select> without a programmatic label src/external/templates/registration/family-register-members.php:50 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <select> without a programmatic label src/external/templates/registration/family-register-members.php:73 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <select> without a programmatic label src/external/templates/registration/family-register-members.php:110 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
AC2 · Forms & labels · <textarea> without a programmatic label · ×2
  • <textarea> without a programmatic label src/Plugins/MailChimp/v2/templates/campaign.php:111 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <textarea> without a programmatic label src/Plugins/NoteDashboard/v2/templates/View.php:50 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
AC3 · Page structure · <html> without a lang · ×2
  • <html> without a lang src/skin/js/ckeditor/ckeditorextension.js:563 — The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
  • <html> without a lang src/skin/js/edrive/CollaboraEditor.js:34 — The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
D34 · Knowledge Freshness · Orphaned knowledge · ×2
  • Orphaned knowledge REDACTED:1 — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge REDACTED:1 — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
AC3 · Page structure · Document without a <title> · ×1
  • Document without a <title> src/skin/js/ckeditor/ckeditorextension.js:563 — A page with no <title> gives no name in the tab, history or screen-reader page list. Add a descriptive <title> in <head>.
AC3 · Page structure · <iframe> without a title · ×1
  • <iframe> without a title src/skin/js/edrive/CollaboraEditor.js:39 — An iframe with no title (or an empty one) is announced only as "frame". Add a non-empty title describing its content, or an aria-label.
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D30 · Dependency Vulnerabilities · Critical CVE · ×1
  • REDACTED
D8 · Code Coverage · No automated tests · ×1
  • No automated tests — No automated tests — no test code was found in this repository. Untested code is the largest single risk to changing it safely. Start with the code you change most often: add a suite in a framework a runner can collect (PHPUnit or Pest), and run it in CI so the gap cannot reopen.
Serious — 1675 finding(s)
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • + 71 more in this group — see findings.md.
D3 · God Classes · MethodTooLong · ×48
  • MethodTooLong: VIEWUserController.argumentsrenderUserEditorArray src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:291 — MethodTooLong — argumentsrenderUserEditorArray runs 466 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 366 over it, 4.66× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: CalendarService.realEvents src/EcclesiaCRM/Service/CalendarService.php:155 — MethodTooLong — realEvents runs 419 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 319 over it, 4.19× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: PDF_ConfirmReport.run REDACTED:332 — MethodTooLong — run runs 392 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 292 over it, 3.92× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: VIEWDepositController.argumentsPledgeEditorArray src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:477 — MethodTooLong — argumentsPledgeEditorArray runs 378 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 278 over it, 3.78× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: CalendarService.getEventsOld src/EcclesiaCRM/Service/CalendarService.php:815 — MethodTooLong — getEventsOld runs 370 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 270 over it, 3.70× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: VIEWPeopleController.argumentsPeoplePersonViewArray REDACTED:312 — MethodTooLong — argumentsPeoplePersonViewArray runs 348 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 248 over it, 3.48× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: CRMEditorTools.init src/skin/js/ckeditor/ckeditorextension.js:880 — MethodTooLong — init runs 299 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 199 over it, 2.99× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: CalendarEventV2Controller.manageEvent src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:335 — MethodTooLong — manageEvent runs 250 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 150 over it, 2.50× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: CalendarService.modifyEventFromCalendar src/EcclesiaCRM/Service/CalendarService.php:1877 — MethodTooLong — modifyEventFromCalendar runs 245 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 145 over it, 2.45× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: PDFLabel.ZipBundleSort REDACTED:243 — MethodTooLong — ZipBundleSort runs 228 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 128 over it, 2.28× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: PersonSearchRes.buildSearch src/EcclesiaCRM/Search/PersonSearchRes.php:51 — MethodTooLong — buildSearch runs 225 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 125 over it, 2.25× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SidebarGeneralRolesController.getAllGeneralRoles src/EcclesiaCRM/APIControllers/SidebarGeneralRolesController.php:47 — MethodTooLong — getAllGeneralRoles runs 217 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 117 over it, 2.17× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: EmailUsers.renderFamily REDACTED:208 — MethodTooLong — renderFamily runs 217 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 117 over it, 2.17× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: PDF_Attendance.DrawRealAttendanceCalendar src/EcclesiaCRM/Reports/PDF_Attendance.php:365 — MethodTooLong — DrawRealAttendanceCalendar runs 211 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 111 over it, 2.11× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SystemConfig.buildConfigs src/EcclesiaCRM/dto/SystemConfig.php:86 — MethodTooLong — buildConfigs runs 199 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 99 over it, 1.99× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ConfirmReportService.getPersonStandardTextFields src/EcclesiaCRM/Service/ConfirmReportService.php:130 — MethodTooLong — getPersonStandardTextFields runs 190 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 90 over it, 1.90× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: VIEWPeopleController.argumentsPeopleFamilyViewArray REDACTED:828 — MethodTooLong — argumentsPeopleFamilyViewArray runs 186 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 86 over it, 1.86× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: PDF_Attendance.DrawAttendanceCalendar src/EcclesiaCRM/Reports/PDF_Attendance.php:39 — MethodTooLong — DrawAttendanceCalendar runs 178 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 78 over it, 1.78× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: GroupSearchRes.buildSearch src/EcclesiaCRM/Search/GroupSearchRes.php:29 — MethodTooLong — buildSearch runs 170 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 70 over it, 1.70× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: VIEWPastoralCareController.argumentsPastoralPersonListArray src/EcclesiaCRM/VIEWControllers/VIEWPastoralCareController.php:204 — MethodTooLong — argumentsPastoralPersonListArray runs 169 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 69 over it, 1.69× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: EmailUsers.renderPerson REDACTED:520 — MethodTooLong — renderPerson runs 164 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 64 over it, 1.64× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: MenuBar.addGroups src/EcclesiaCRM/MenuBar/MenuBar.php:279 — MethodTooLong — addGroups runs 161 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 61 over it, 1.61× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: DepositSearchRes.buildSearch src/EcclesiaCRM/Search/DepositSearchRes.php:53 — MethodTooLong — buildSearch runs 159 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 59 over it, 1.59× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: EmailUsers.renderAndSend REDACTED:759 — MethodTooLong — renderAndSend runs 155 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 55 over it, 1.55× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: CalendarService.createEventForCalendar src/EcclesiaCRM/Service/CalendarService.php:1603 — MethodTooLong — createEventForCalendar runs 155 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 55 over it, 1.55× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • + 23 more in this group — see findings.md.
D6 · Cohesion (LCOM4) · Low cohesion · ×46
  • Low cohesion: PeopleGroupController (LCOM4 30) src/EcclesiaCRM/APIControllers/PeopleGroupController.php:49 — PeopleGroupController's methods fall into 30 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 30 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: MailchimpController (LCOM4 30) src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:42 — MailchimpController's methods fall into 30 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 30 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: CalendarV2Controller (LCOM4 20) src/EcclesiaCRM/APIControllers/CalendarV2Controller.php:35 — CalendarV2Controller's methods fall into 20 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 20 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: PeopleFamilyController (LCOM4 20) REDACTED:48 — PeopleFamilyController's methods fall into 20 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 20 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: VolunteerOpportunityController (LCOM4 20) src/EcclesiaCRM/APIControllers/VolunteerOpportunityController.php:31 — VolunteerOpportunityController's methods fall into 20 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 20 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: PeoplePersonController (LCOM4 19) REDACTED:57 — PeoplePersonController's methods fall into 19 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 19 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: VIEWPeopleController (LCOM4 19) REDACTED:64 — VIEWPeopleController's methods fall into 19 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 19 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: CartController (LCOM4 17) src/EcclesiaCRM/APIControllers/CartController.php:27 — CartController's methods fall into 17 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 17 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: PastoralCareController (LCOM4 16) src/EcclesiaCRM/APIControllers/PastoralCareController.php:29 — PastoralCareController's methods fall into 16 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 16 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: SidebarPropertiesController (LCOM4 16) src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:33 — SidebarPropertiesController's methods fall into 16 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 16 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: Person (LCOM4 16) src/EcclesiaCRM/model/EcclesiaCRM/Person.php:35 — Person's methods fall into 16 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 16 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: FundraiserController (LCOM4 13) src/EcclesiaCRM/APIControllers/FundraiserController.php:38 — FundraiserController's methods fall into 13 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 13 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: PeopleAttendeesController (LCOM4 13) src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:39 — PeopleAttendeesController's methods fall into 13 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 13 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: DocumentFileManagerController (LCOM4 12) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:27 — DocumentFileManagerController's methods fall into 12 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 12 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: CalendarEventV2Controller (LCOM4 11) src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:36 — CalendarEventV2Controller's methods fall into 11 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 11 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: UserUsersController (LCOM4 11) src/EcclesiaCRM/APIControllers/UserUsersController.php:31 — UserUsersController's methods fall into 11 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 11 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: ToDoListDashboardController (LCOM4 11) src/Plugins/ToDoListDashboard/core/APIControllers/ToDoListDashboardController.php:33 — ToDoListDashboardController's methods fall into 11 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 11 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: DocumentShareController (LCOM4 10) src/EcclesiaCRM/APIControllers/DocumentShareController.php:32 — DocumentShareController's methods fall into 10 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 10 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: PluginsController (LCOM4 10) src/EcclesiaCRM/APIControllers/PluginsController.php:29 — PluginsController's methods fall into 10 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 10 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: VIEWDepositController (LCOM4 10) src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:39 — VIEWDepositController's methods fall into 10 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 10 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: VIEWSystemController (LCOM4 10) src/EcclesiaCRM/VIEWControllers/VIEWSystemController.php:30 — VIEWSystemController's methods fall into 10 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 10 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: FinanceDepositController (LCOM4 9) src/EcclesiaCRM/APIControllers/FinanceDepositController.php:25 — FinanceDepositController's methods fall into 9 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 9 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: FinancePaymentController (LCOM4 9) src/EcclesiaCRM/APIControllers/FinancePaymentController.php:25 — FinancePaymentController's methods fall into 9 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 9 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: KiosksController (LCOM4 7) src/EcclesiaCRM/APIControllers/KiosksController.php:24 — KiosksController's methods fall into 7 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 7 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: SidebarMenuLinksController (LCOM4 7) src/EcclesiaCRM/APIControllers/SidebarMenuLinksController.php:22 — SidebarMenuLinksController's methods fall into 7 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 7 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • + 21 more in this group — see findings.md.
X3 · Exception handling · Swallowed exception (empty catch) · ×39
  • Swallowed exception (empty catch) src/v2/templates/calendar/eventnames.php:70 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Plugins/VolunteerDashboardWidget/locale/js/ar_EG.js:1 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Plugins/VolunteerDashboardWidget/locale/js/da_DK.js:1 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Plugins/VolunteerDashboardWidget/locale/js/de_DE.js:1 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Plugins/VolunteerDashboardWidget/locale/js/el_GR.js:1 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Plugins/VolunteerDashboardWidget/locale/js/es_ES.js:1 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Plugins/VolunteerDashboardWidget/locale/js/fi_FI.js:1 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Plugins/VolunteerDashboardWidget/locale/js/fr_BE.js:1 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Plugins/VolunteerDashboardWidget/locale/js/fr_CA.js:1 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Plugins/VolunteerDashboardWidget/locale/js/fr_CH.js:1 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Plugins/VolunteerDashboardWidget/locale/js/fr_FR.js:1 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Plugins/VolunteerDashboardWidget/locale/js/hu_HU.js:1 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Plugins/VolunteerDashboardWidget/locale/js/id_ID.js:1 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Plugins/VolunteerDashboardWidget/locale/js/it_IT.js:1 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Plugins/VolunteerDashboardWidget/locale/js/ja_JP.js:1 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Plugins/VolunteerDashboardWidget/locale/js/ko_KR.js:1 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Plugins/VolunteerDashboardWidget/locale/js/nb_NO.js:1 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Plugins/VolunteerDashboardWidget/locale/js/nl_NL.js:1 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Plugins/VolunteerDashboardWidget/locale/js/pl_PL.js:1 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Plugins/VolunteerDashboardWidget/locale/js/pt_BR.js:1 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Plugins/VolunteerDashboardWidget/locale/js/pt_PT.js:1 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Plugins/VolunteerDashboardWidget/locale/js/ro_RO.js:1 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Plugins/VolunteerDashboardWidget/locale/js/ru_RU.js:1 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Plugins/VolunteerDashboardWidget/locale/js/sq_AL.js:1 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Plugins/VolunteerDashboardWidget/locale/js/sv_SE.js:1 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • + 14 more in this group — see findings.md.
D3 · God Classes · FileTooLong · ×29
  • FileTooLong: REDACTED REDACTED — FileTooLong — 1541 significant lines (blank, comment-only and punctuation-only lines excluded; the length bar is tripled for a single-responsibility module of 4 or fewer top-level units). The bar is 1500 significant lines; this is 41 over it, 1.03× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Service/CalendarService.php src/EcclesiaCRM/Service/CalendarService.php — FileTooLong — 1518 significant lines (blank, comment-only and punctuation-only lines excluded), about 98% of them inside a single declaration: CalendarService (47-2246). The bar is 500 significant lines; this is 1018 over it, 3.04× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: utils/MiscUtils.php src/EcclesiaCRM/utils/MiscUtils.php — FileTooLong — 1450 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 950 over it, 2.90× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: REDACTED REDACTED — FileTooLong — 1125 significant lines (blank, comment-only and punctuation-only lines excluded), about 96% of them inside a single declaration: VIEWPeopleController (64-1736). The bar is 500 significant lines; this is 625 over it, 2.25× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: ckeditor/ckeditorextension.js src/skin/js/ckeditor/ckeditorextension.js — FileTooLong — 1067 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 567 over it, 2.13× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: calendar/CalendarSideBar.js src/skin/js/calendar/CalendarSideBar.js — FileTooLong — 919 significant lines (blank, comment-only and punctuation-only lines excluded; the length bar is tripled for a single-responsibility module of 4 or fewer top-level units). The bar is 500 significant lines; this is 419 over it, 1.84× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: EcclesiaCRM/User.php src/EcclesiaCRM/model/EcclesiaCRM/User.php — FileTooLong — 819 significant lines (blank, comment-only and punctuation-only lines excluded), about 95% of them inside a single declaration: User (70-1445). The bar is 500 significant lines; this is 319 over it, 1.64× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: REDACTED REDACTED — FileTooLong — 811 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 311 over it, 1.62× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: VIEWControllers/VIEWUserController.php src/EcclesiaCRM/VIEWControllers/VIEWUserController.php — FileTooLong — 775 significant lines (blank, comment-only and punctuation-only lines excluded), about 97% of them inside a single declaration: VIEWUserController (42-1175). The bar is 500 significant lines; this is 275 over it, 1.55× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: Services/MailChimpService.php src/Plugins/MailChimp/core/Services/MailChimpService.php — FileTooLong — 747 significant lines (blank, comment-only and punctuation-only lines excluded), about 97% of them inside a single declaration: MailChimpService (50-1360). The bar is 500 significant lines; this is 247 over it, 1.49× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: calendar/EventEditor.js src/skin/js/calendar/EventEditor.js — FileTooLong — 739 significant lines (blank, comment-only and punctuation-only lines excluded; the length bar is tripled for a single-responsibility module of 4 or fewer top-level units). The bar is 500 significant lines; this is 239 over it, 1.48× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: APIControllers/DocumentFileManagerController.php src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php — FileTooLong — 727 significant lines (blank, comment-only and punctuation-only lines excluded), about 97% of them inside a single declaration: DocumentFileManagerController (27-1212). The bar is 500 significant lines; this is 227 over it, 1.45× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: VIEWControllers/VIEWDepositController.php src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php — FileTooLong — 680 significant lines (blank, comment-only and punctuation-only lines excluded), about 97% of them inside a single declaration: VIEWDepositController (39-1125). The bar is 500 significant lines; this is 180 over it, 1.36× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: REDACTED REDACTED — FileTooLong — 666 significant lines (blank, comment-only and punctuation-only lines excluded), about 87% of them inside a single declaration: EmailUsers (142-1007). The bar is 500 significant lines; this is 166 over it, 1.33× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: Service/ConfirmReportService.php src/EcclesiaCRM/Service/ConfirmReportService.php — FileTooLong — 646 significant lines (blank, comment-only and punctuation-only lines excluded), about 98% of them inside a single declaration: ConfirmReportService (29-908). The bar is 500 significant lines; this is 146 over it, 1.29× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: APIControllers/PeopleGroupController.php src/EcclesiaCRM/APIControllers/PeopleGroupController.php — FileTooLong — 636 significant lines (blank, comment-only and punctuation-only lines excluded), about 95% of them inside a single declaration: PeopleGroupController (49-1031). The bar is 500 significant lines; this is 136 over it, 1.27× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: REDACTED REDACTED — FileTooLong — 627 significant lines (blank, comment-only and punctuation-only lines excluded), about 66% of them inside a single declaration: initDataTable (332-961). The bar is 500 significant lines; this is 127 over it, 1.25× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: MenuBar/MenuBar.php src/EcclesiaCRM/MenuBar/MenuBar.php — FileTooLong — 614 significant lines (blank, comment-only and punctuation-only lines excluded), about 97% of them inside a single declaration: MenuBar (35-986). The bar is 500 significant lines; this is 114 over it, 1.23× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: templates/setup-steps.php src/setup/templates/setup-steps.php — FileTooLong — 602 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 102 over it, 1.20× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: CalDav/CalDavPDO.php src/EcclesiaCRM/sabre/CalDav/CalDavPDO.php — FileTooLong — 585 significant lines (blank, comment-only and punctuation-only lines excluded), about 98% of them inside a single declaration: CalDavPDO (27-1394). The bar is 500 significant lines; this is 85 over it, 1.17× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: REDACTED REDACTED — FileTooLong — 584 significant lines (blank, comment-only and punctuation-only lines excluded), about 95% of them inside a single declaration: PDF_ConfirmReport (38-921). The bar is 500 significant lines; this is 84 over it, 1.17× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: utils/PhpWordHTMLExtension.php src/EcclesiaCRM/utils/PhpWordHTMLExtension.php — FileTooLong — 562 significant lines (blank, comment-only and punctuation-only lines excluded), about 98% of them inside a single declaration: PhpWordHTMLExtension (34-1078). The bar is 500 significant lines; this is 62 over it, 1.12× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: calendar/CalendarV2.js src/skin/js/calendar/CalendarV2.js — FileTooLong — 553 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 53 over it, 1.11× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: APIControllers/MailchimpController.php src/Plugins/MailChimp/core/APIControllers/MailchimpController.php — FileTooLong — 550 significant lines (blank, comment-only and punctuation-only lines excluded), about 96% of them inside a single declaration: MailchimpController (42-979). The bar is 500 significant lines; this is 50 over it, 1.10× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: REDACTED REDACTED — FileTooLong — 544 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: sha1 (1-806). The bar is 500 significant lines; this is 44 over it, 1.09× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • + 4 more in this group — see findings.md.
D3 · God Classes · ClassTooLong · ×28
  • ClassTooLong: CalendarService src/EcclesiaCRM/Service/CalendarService.php:47 — ClassTooLong — 1490 significant lines (blank, comment-only and punctuation-only lines excluded), 9 methods. The bar is 400 significant lines; this is 1090 over it, 3.73× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: VIEWPeopleController REDACTED:64 — ClassTooLong — 1083 significant lines (blank, comment-only and punctuation-only lines excluded), 39 methods. The bar is 400 significant lines; this is 683 over it, 2.71× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: User src/EcclesiaCRM/model/EcclesiaCRM/User.php:70 — ClassTooLong — 775 significant lines (blank, comment-only and punctuation-only lines excluded), 87 methods. The bar is 400 significant lines; this is 375 over it, 1.94× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: VIEWUserController src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:42 — ClassTooLong — 750 significant lines (blank, comment-only and punctuation-only lines excluded), 11 methods. The bar is 400 significant lines; this is 350 over it, 1.88× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: MailChimpService src/Plugins/MailChimp/core/Services/MailChimpService.php:50 — ClassTooLong — 721 significant lines (blank, comment-only and punctuation-only lines excluded), 62 methods. The bar is 400 significant lines; this is 321 over it, 1.80× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: DocumentFileManagerController src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:27 — ClassTooLong — 706 significant lines (blank, comment-only and punctuation-only lines excluded), 28 methods. The bar is 400 significant lines; this is 306 over it, 1.77× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: VIEWDepositController src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:39 — ClassTooLong — 658 significant lines (blank, comment-only and punctuation-only lines excluded), 22 methods. The bar is 400 significant lines; this is 258 over it, 1.65× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: ConfirmReportService src/EcclesiaCRM/Service/ConfirmReportService.php:29 — ClassTooLong — 631 significant lines (blank, comment-only and punctuation-only lines excluded), 11 methods. The bar is 400 significant lines; this is 231 over it, 1.58× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: PeopleGroupController src/EcclesiaCRM/APIControllers/PeopleGroupController.php:49 — ClassTooLong — 603 significant lines (blank, comment-only and punctuation-only lines excluded), 37 methods. The bar is 400 significant lines; this is 203 over it, 1.51× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: MenuBar src/EcclesiaCRM/MenuBar/MenuBar.php:35 — ClassTooLong — 597 significant lines (blank, comment-only and punctuation-only lines excluded), 23 methods. The bar is 400 significant lines; this is 197 over it, 1.49× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: EmailUsers REDACTED:142 — ClassTooLong — 582 significant lines (blank, comment-only and punctuation-only lines excluded), 4 methods. The bar is 400 significant lines; this is 182 over it, 1.46× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: CalDavPDO src/EcclesiaCRM/sabre/CalDav/CalDavPDO.php:27 — ClassTooLong — 574 significant lines (blank, comment-only and punctuation-only lines excluded), 23 methods. The bar is 400 significant lines; this is 174 over it, 1.44× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: PDF_ConfirmReport REDACTED:38 — ClassTooLong — 555 significant lines (blank, comment-only and punctuation-only lines excluded), 11 methods. The bar is 400 significant lines; this is 155 over it, 1.39× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: PhpWordHTMLExtension src/EcclesiaCRM/utils/PhpWordHTMLExtension.php:34 — ClassTooLong — 552 significant lines (blank, comment-only and punctuation-only lines excluded), 29 methods. The bar is 400 significant lines; this is 152 over it, 1.38× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: MailchimpController src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:42 — ClassTooLong — 529 significant lines (blank, comment-only and punctuation-only lines excluded), 31 methods. The bar is 400 significant lines; this is 129 over it, 1.32× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: NewsDashboard src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:30 — ClassTooLong — 506 significant lines (blank, comment-only and punctuation-only lines excluded), 68 methods. The bar is 400 significant lines; this is 106 over it, 1.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: MailChimpParams src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:28 — ClassTooLong — 498 significant lines (blank, comment-only and punctuation-only lines excluded), 69 methods. The bar is 400 significant lines; this is 98 over it, 1.25× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: OutputUtils src/EcclesiaCRM/utils/OutputUtils.php:14 — ClassTooLong — 497 significant lines (blank, comment-only and punctuation-only lines excluded), 23 methods. The bar is 400 significant lines; this is 97 over it, 1.24× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: ToDoListDashboardItem src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:30 — ClassTooLong — 477 significant lines (blank, comment-only and punctuation-only lines excluded), 67 methods. The bar is 400 significant lines; this is 77 over it, 1.19× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: PeopleAttendeesController src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:39 — ClassTooLong — 477 significant lines (blank, comment-only and punctuation-only lines excluded), 16 methods. The bar is 400 significant lines; this is 77 over it, 1.19× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: FinancialService src/EcclesiaCRM/Service/FinancialService.php:15 — ClassTooLong — 460 significant lines (blank, comment-only and punctuation-only lines excluded), 26 methods. The bar is 400 significant lines; this is 60 over it, 1.15× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: Person src/EcclesiaCRM/model/EcclesiaCRM/Person.php:35 — ClassTooLong — 455 significant lines (blank, comment-only and punctuation-only lines excluded), 40 methods. The bar is 400 significant lines; this is 55 over it, 1.14× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: PeoplePersonController REDACTED:57 — ClassTooLong — 453 significant lines (blank, comment-only and punctuation-only lines excluded), 28 methods. The bar is 400 significant lines; this is 53 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: PluginPrefJitsiMeeting src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:28 — ClassTooLong — 432 significant lines (blank, comment-only and punctuation-only lines excluded), 64 methods. The bar is 400 significant lines; this is 32 over it, 1.08× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: CalendarEventV2Controller src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:36 — ClassTooLong — 431 significant lines (blank, comment-only and punctuation-only lines excluded), 13 methods. The bar is 400 significant lines; this is 31 over it, 1.08× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • + 3 more in this group — see findings.md.
AC4 · Keyboard semantics · Anchor without href · ×26
  • Anchor without href REDACTED:39 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href REDACTED:47 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href REDACTED:54 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href REDACTED:58 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href src/Plugins/MeetingJitsi/v2/templates/meetingsettings.php:40 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href src/Plugins/MeetingJitsi/v2/templates/meetingsettings.php:58 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href src/Plugins/MeetingJitsi/v2/templates/meetingsettings.php:76 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href src/skin/js/sidebar/MenuLinksList.js:212 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href src/skin/js/sidebar/MenuLinksList.js:215 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href src/v2/templates/calendar/checkin.php:32 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href src/v2/templates/calendar/eventattendeesedit.php:95 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href src/v2/templates/calendar/eventattendeesedit.php:124 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href src/v2/templates/cart/cartview.php:36 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href src/v2/templates/group/groupview.php:41 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href src/v2/templates/group/groupview.php:45 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href src/v2/templates/group/groupview.php:60 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href src/v2/templates/group/groupview.php:71 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href src/v2/templates/group/groupview.php:296 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href src/v2/templates/pastoralcare/pastoralcarefamily.php:305 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href src/v2/templates/pastoralcare/pastoralcarefamily.php:309 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href src/v2/templates/pastoralcare/pastoralcarefamily.php:318 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href src/v2/templates/pastoralcare/pastoralcareperson.php:136 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href src/v2/templates/pastoralcare/pastoralcareperson.php:140 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href src/v2/templates/pastoralcare/pastoralcareperson.php:444 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href src/v2/templates/pastoralcare/pastoralcareperson.php:448 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • + 1 more in this group — see findings.md.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Duplicated block (10 lines × 2) · ×20
  • Duplicated block (10 lines × 2) src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:370 — src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:370-379 | src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:594-603 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:370` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:365` calls `setAllday`, `is_null`, `save` and `src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:590` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (10 lines × 2) src/EcclesiaCRM/APIControllers/FinanceDonationFundController.php:59 — src/EcclesiaCRM/APIControllers/FinanceDonationFundController.php:59-68 | src/EcclesiaCRM/APIControllers/FinanceDonationFundController.php:92-101 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/FinanceDonationFundController.php:59` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) REDACTED:409 — REDACTED:409-418 | REDACTED:444-453 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:409` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (10 lines × 2) src/EcclesiaCRM/APIControllers/PeopleGroupController.php:686 — src/EcclesiaCRM/APIControllers/PeopleGroupController.php:686-695 | src/EcclesiaCRM/APIControllers/VolunteerOpportunityController.php:44-53 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/PeopleGroupController.php:686` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) src/EcclesiaCRM/APIControllers/PeopleGroupController.php:703 — src/EcclesiaCRM/APIControllers/PeopleGroupController.php:703-712 | src/EcclesiaCRM/APIControllers/VolunteerOpportunityController.php:112-121 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/PeopleGroupController.php:703` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) src/EcclesiaCRM/APIControllers/PluginsController.php:309 — src/EcclesiaCRM/APIControllers/PluginsController.php:309-318 | src/EcclesiaCRM/APIControllers/PluginsController.php:331-340 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/PluginsController.php:309` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) src/EcclesiaCRM/APIControllers/PublicRegisterController.php:55 — src/EcclesiaCRM/APIControllers/PublicRegisterController.php:55-64 | REDACTED:158-167 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (10 lines × 2) src/EcclesiaCRM/APIControllers/VolunteerOpportunityController.php:256 — src/EcclesiaCRM/APIControllers/VolunteerOpportunityController.php:256-265 | src/EcclesiaCRM/APIControllers/VolunteerOpportunityController.php:276-285 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/VolunteerOpportunityController.php:256` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) src/EcclesiaCRM/MenuBar/MenuBar.php:297 — src/EcclesiaCRM/MenuBar/MenuBar.php:297-306 | src/EcclesiaCRM/MenuBar/MenuBar.php:551-560 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/MenuBar/MenuBar.php:297` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/EcclesiaCRM/MenuBar/MenuBar.php:296` calls `filterByActive` and `src/EcclesiaCRM/MenuBar/MenuBar.php:550` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (10 lines × 2) src/EcclesiaCRM/Reports/PDF_Attendance.php:72 — src/EcclesiaCRM/Reports/PDF_Attendance.php:72-81 | src/EcclesiaCRM/Reports/PDF_Attendance.php:392-401 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Reports/PDF_Attendance.php:72` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/EcclesiaCRM/Reports/PDF_Attendance.php:389` calls `unset` and `src/EcclesiaCRM/Reports/PDF_Attendance.php:69` does not — after which the two agree again for 5 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (10 lines × 2) src/EcclesiaCRM/Reports/PDF_Attendance.php:572 — src/EcclesiaCRM/Reports/PDF_Attendance.php:572-581 | src/EcclesiaCRM/Reports/PDF_Attendance.php:584-593 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Reports/PDF_Attendance.php:572` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (10 lines × 2) src/EcclesiaCRM/Reports/PDF_Badge.php:64 — src/EcclesiaCRM/Reports/PDF_Badge.php:64-73 | REDACTED:138-147 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (10 lines × 2) src/EcclesiaCRM/Service/ConfirmReportService.php:639 — src/EcclesiaCRM/Service/ConfirmReportService.php:639-648 | REDACTED:515-524 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (10 lines × 2) REDACTED:434 — REDACTED:434-443 | REDACTED:979-988 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (10 lines × 2) REDACTED:1145 — REDACTED:1145-1154 | REDACTED:1157-1166 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (10 lines × 2) src/EcclesiaCRM/dto/CanvassUtilities.php:97 — src/EcclesiaCRM/dto/CanvassUtilities.php:97-106 | src/EcclesiaCRM/dto/CanvassUtilities.php:133-143 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (10 lines × 2) src/EcclesiaCRM/MenuBar/MenuBar.php:655 — src/EcclesiaCRM/MenuBar/MenuBar.php:655-664 | src/EcclesiaCRM/MenuBar/MenuBar.php:718-727 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/MenuBar/MenuBar.php:655` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) src/EcclesiaCRM/Theme/Theme.php:40 — src/EcclesiaCRM/Theme/Theme.php:40-49 | src/EcclesiaCRM/model/EcclesiaCRM/User.php:1061-1070 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Theme/Theme.php:40` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) src/EcclesiaCRM/Service/CalendarService.php:502 — src/EcclesiaCRM/Service/CalendarService.php:502-511 | src/EcclesiaCRM/sabre/CalDav/VObjectExtract.php:173-182 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Service/CalendarService.php:502` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) src/EcclesiaCRM/APIControllers/SystemSettingsIndividualController.php:34 — src/EcclesiaCRM/APIControllers/SystemSettingsIndividualController.php:34-43 | src/EcclesiaCRM/utils/MiscUtils.php:73-82 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
D4 · Code Duplication · Duplicated block (8 lines × 2) · ×18
  • Duplicated block (8 lines × 2) src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:382 — src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:382-389 | src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:414-421 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:382` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) src/EcclesiaCRM/APIControllers/PeopleController.php:380 — src/EcclesiaCRM/APIControllers/PeopleController.php:380-387 | src/EcclesiaCRM/APIControllers/PeopleController.php:406-413 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/PeopleController.php:380` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) REDACTED:422 — REDACTED:422-429 | REDACTED:444-451 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:422` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) src/EcclesiaCRM/APIControllers/SidebarMenuLinksController.php:111 — src/EcclesiaCRM/APIControllers/SidebarMenuLinksController.php:111-118 | src/EcclesiaCRM/APIControllers/SidebarMenuLinksController.php:135-142 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/SidebarMenuLinksController.php:111` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) src/EcclesiaCRM/APIControllers/UserRoleController.php:66 — src/EcclesiaCRM/APIControllers/UserRoleController.php:66-73 | src/EcclesiaCRM/APIControllers/UserRoleController.php:122-129 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/UserRoleController.php:66` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) src/EcclesiaCRM/APIControllers/UserUsersController.php:166 — src/EcclesiaCRM/APIControllers/UserUsersController.php:166-173 | src/EcclesiaCRM/APIControllers/UserUsersController.php:189-196 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/UserUsersController.php:166` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) REDACTED:532 — REDACTED:532-539 | src/EcclesiaCRM/Service/ConfirmReportService.php:594-601 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (8 lines × 2) src/EcclesiaCRM/Reports/PDF_FundRaiserReport.php:30 — src/EcclesiaCRM/Reports/PDF_FundRaiserReport.php:30-37 | src/EcclesiaCRM/Reports/PDF_FundRaiserReport.php:49-56 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/EcclesiaCRM/Reports/PDF_FundRaiserReport.php:57` calls `Write`, `_`, `SetFont` and `src/EcclesiaCRM/Reports/PDF_FundRaiserReport.php:38` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (8 lines × 2) src/EcclesiaCRM/Service/FinancialService.php:403 — src/EcclesiaCRM/Service/FinancialService.php:403-410 | src/EcclesiaCRM/model/EcclesiaCRM/Deposit.php:264-271 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/EcclesiaCRM/model/EcclesiaCRM/Deposit.php:263` calls `stdClass` and `src/EcclesiaCRM/Service/FinancialService.php:402` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (8 lines × 2) REDACTED:463 — REDACTED:463-470 | REDACTED:477-484 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (8 lines × 2) src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:54 — src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:54-61 | src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:227-234 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (8 lines × 2) src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:431 — src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:431-438 | src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:1028-1035 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (8 lines × 2) src/EcclesiaCRM/VIEWControllers/VIEWSystemController.php:41 — src/EcclesiaCRM/VIEWControllers/VIEWSystemController.php:41-48 | src/EcclesiaCRM/VIEWControllers/VIEWSystemController.php:53-60 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (8 lines × 2) src/EcclesiaCRM/model/EcclesiaCRM/Group.php:54 — src/EcclesiaCRM/model/EcclesiaCRM/Group.php:54-61 | src/EcclesiaCRM/model/EcclesiaCRM/VolunteerOpportunity.php:33-40 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (8 lines × 2) src/EcclesiaCRM/utils/MiscUtils.php:972 — src/EcclesiaCRM/utils/MiscUtils.php:972-979 | src/EcclesiaCRM/utils/MiscUtils.php:1180-1187 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/utils/MiscUtils.php:972` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) src/EcclesiaCRM/Service/CalendarService.php:1857 — src/EcclesiaCRM/Service/CalendarService.php:1857-1864 | src/EcclesiaCRM/Service/CalendarService.php:1925-1932 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (8 lines × 2) REDACTED:406 — REDACTED:406-413 | REDACTED:608-615 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (8 lines × 2) src/Plugins/MailChimp/core/Services/MailChimpService.php:369 — src/Plugins/MailChimp/core/Services/MailChimpService.php:369-376 | src/Plugins/MailChimp/core/Services/MailChimpService.php:886-893 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (7 lines × 2) · ×18
  • Duplicated block (7 lines × 2) src/EcclesiaCRM/APIControllers/CartController.php:159 — src/EcclesiaCRM/APIControllers/CartController.php:159-165 | src/EcclesiaCRM/APIControllers/CartController.php:174-180 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (7 lines × 2) src/EcclesiaCRM/APIControllers/DocumentShareController.php:331 — src/EcclesiaCRM/APIControllers/DocumentShareController.php:331-337 | src/EcclesiaCRM/APIControllers/DocumentShareController.php:430-436 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/DocumentShareController.php:331` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:483 — src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:483-489 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:555-561 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (7 lines × 2) src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:518 — src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:518-524 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:566-572 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (7 lines × 2) REDACTED:59 — REDACTED:59-65 | REDACTED:82-88 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (7 lines × 2) src/EcclesiaCRM/APIControllers/SystemGDRPController.php:99 — src/EcclesiaCRM/APIControllers/SystemGDRPController.php:99-105 | src/EcclesiaCRM/APIControllers/SystemGDRPController.php:126-132 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/SystemGDRPController.php:99` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) REDACTED:330 — REDACTED:330-336 | REDACTED:897-903 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:330` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `REDACTED:329` calls `filterByFamId`, `getId` and `REDACTED:896` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (7 lines × 2) REDACTED:794 — REDACTED:794-800 | REDACTED:935-941 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (7 lines × 2) src/EcclesiaCRM/Search/FamilyCustomSearchRes.php:76 — src/EcclesiaCRM/Search/FamilyCustomSearchRes.php:76-82 | src/EcclesiaCRM/Search/FamilyPastoralCareSearchRes.php:100-106 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (7 lines × 2) src/EcclesiaCRM/Search/FamilyPropsSearchRes.php:71 — src/EcclesiaCRM/Search/FamilyPropsSearchRes.php:71-77 | src/EcclesiaCRM/Search/GroupPropsSearchRes.php:51-57 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (7 lines × 2) src/EcclesiaCRM/Service/FinancialService.php:421 — src/EcclesiaCRM/Service/FinancialService.php:421-427 | src/EcclesiaCRM/model/EcclesiaCRM/Deposit.php:283-289 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (7 lines × 2) src/EcclesiaCRM/VIEWControllers/People/VIEWFamilyListController.php:37 — src/EcclesiaCRM/VIEWControllers/People/VIEWFamilyListController.php:37-43 | src/EcclesiaCRM/VIEWControllers/People/VIEWPersonListController.php:36-42 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/VIEWControllers/People/VIEWFamilyListController.php:37` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/EcclesiaCRM/VIEWControllers/People/VIEWFamilyListController.php:44` calls `strtolower`, `getUser`, `isEditRecordsEnabled` and `src/EcclesiaCRM/VIEWControllers/People/VIEWPersonListController.php:43` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (7 lines × 2) src/EcclesiaCRM/VIEWControllers/VIEWPastoralCareController.php:193 — src/EcclesiaCRM/VIEWControllers/VIEWPastoralCareController.php:193-199 | src/EcclesiaCRM/VIEWControllers/VIEWPastoralCareController.php:412-418 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (7 lines × 2) src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:948 — src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:948-954 | src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:981-987 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (7 lines × 2) src/EcclesiaCRM/model/EcclesiaCRM/Family.php:390 — src/EcclesiaCRM/model/EcclesiaCRM/Family.php:390-396 | src/EcclesiaCRM/model/EcclesiaCRM/Person.php:594-600 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (7 lines × 2) src/EcclesiaCRM/model/EcclesiaCRM/Person.php:686 — src/EcclesiaCRM/model/EcclesiaCRM/Person.php:686-692 | src/EcclesiaCRM/model/EcclesiaCRM/Person.php:725-731 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (7 lines × 2) src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:1158 — src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:1158-1164 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:890-896 — before extracting anything, compare `src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php` and `src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 166 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:1158` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) src/EcclesiaCRM/sabre/CalDav/CalDavPDO.php:31 — src/EcclesiaCRM/sabre/CalDav/CalDavPDO.php:31-37 | src/EcclesiaCRM/sabre/CardDav/CardDavPDO.php:32-38 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D3 · God Classes · TooManyMethods · ×17
  • TooManyMethods: User src/EcclesiaCRM/model/EcclesiaCRM/User.php:70 — TooManyMethods — 87 methods. The bar is 30 methods; this is 57 over it, 2.90× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: MiscUtils src/EcclesiaCRM/utils/MiscUtils.php:30 — TooManyMethods — 69 methods. The bar is 30 methods; this is 39 over it, 2.30× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: MailChimpParams src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:28 — TooManyMethods — 69 methods. The bar is 30 methods; this is 39 over it, 2.30× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: NewsDashboard src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:30 — TooManyMethods — 68 methods. The bar is 30 methods; this is 38 over it, 2.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ToDoListDashboardItem src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:30 — TooManyMethods — 67 methods. The bar is 30 methods; this is 37 over it, 2.23× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: PluginPrefJitsiMeeting src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:28 — TooManyMethods — 64 methods. The bar is 30 methods; this is 34 over it, 2.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ToDoListDashboard src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:28 — TooManyMethods — 63 methods. The bar is 30 methods; this is 33 over it, 2.10× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: MailChimpService src/Plugins/MailChimp/core/Services/MailChimpService.php:50 — TooManyMethods — 62 methods. The bar is 30 methods; this is 32 over it, 2.07× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: PersonJitsiMeeting src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:30 — TooManyMethods — 62 methods. The bar is 30 methods; this is 32 over it, 2.07× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: NoteDashboard src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:28 — TooManyMethods — 60 methods. The bar is 30 methods; this is 30 over it, 2.00× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: PersonLastJitsiMeeting src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:28 — TooManyMethods — 59 methods. The bar is 30 methods; this is 29 over it, 1.97× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: Person src/EcclesiaCRM/model/EcclesiaCRM/Person.php:35 — TooManyMethods — 40 methods. The bar is 30 methods; this is 10 over it, 1.33× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: VIEWPeopleController REDACTED:64 — TooManyMethods — 39 methods. The bar is 30 methods; this is 9 over it, 1.30× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: PeopleGroupController src/EcclesiaCRM/APIControllers/PeopleGroupController.php:49 — TooManyMethods — 37 methods. The bar is 30 methods; this is 7 over it, 1.23× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: Cart src/EcclesiaCRM/dto/Cart.php:18 — TooManyMethods — 37 methods. The bar is 30 methods; this is 7 over it, 1.23× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: Family src/EcclesiaCRM/model/EcclesiaCRM/Family.php:26 — TooManyMethods — 34 methods. The bar is 30 methods; this is 4 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: MailchimpController src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:42 — TooManyMethods — 31 methods. The bar is 30 methods; this is 1 over it, 1.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
AC3 · Page structure · Data table has no header cells · ×16
  • Data table has no header cells src/setup/templates/setup-steps.php:121 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells src/v2/templates/calendar/eventnames.php:294 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells src/v2/templates/deposit/financialReports.php:64 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells src/v2/templates/deposit/financialReports.php:133 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells src/v2/templates/pastoralcare/pastoralcarePersonPrint.php:183 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells src/v2/templates/pastoralcare/pastoralcarePersonPrint.php:200 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells src/v2/templates/pastoralcare/pastoralcarePersonPrint.php:238 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells src/v2/templates/pastoralcare/pastoralcarePersonPrint.php:241 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells src/v2/templates/pastoralcare/pastoralcarePersonPrint.php:295 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells src/v2/templates/pastoralcare/pastoralcarePersonPrint.php:353 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells src/v2/templates/pastoralcare/pastoralcarePersonPrint.php:416 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells src/v2/templates/pastoralcare/pastoralcarePersonPrint.php:484 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells src/v2/templates/pastoralcare/pastoralcarePersonPrint.php:522 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells src/v2/templates/pastoralcare/pastoralcarePersonPrint.php:524 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells src/v2/templates/pastoralcare/pastoralcarePersonPrint.php:579 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells src/v2/templates/people/geopage.php:179 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
D4 · Code Duplication · Duplicated block (11 lines × 2) · ×14
  • Duplicated block (11 lines × 2) src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:362 — src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:362-372 | src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:394-404 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:362` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) src/EcclesiaCRM/APIControllers/PeopleController.php:55 — src/EcclesiaCRM/APIControllers/PeopleController.php:55-65 | src/EcclesiaCRM/APIControllers/PeopleController.php:113-123 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/PeopleController.php:55` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/EcclesiaCRM/APIControllers/PeopleController.php:112` calls `filterByDateDeactivated` and `src/EcclesiaCRM/APIControllers/PeopleController.php:54` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (11 lines × 2) src/EcclesiaCRM/APIControllers/PeopleController.php:390 — src/EcclesiaCRM/APIControllers/PeopleController.php:390-401 | src/EcclesiaCRM/APIControllers/PeopleController.php:415-425 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/PeopleController.php:390` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) REDACTED:51 — REDACTED:51-61 | REDACTED:134-144 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:51` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) src/EcclesiaCRM/Service/FinancialService.php:484 — src/EcclesiaCRM/Service/FinancialService.php:484-494 | src/EcclesiaCRM/model/EcclesiaCRM/Deposit.php:356-366 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Service/FinancialService.php:484` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) src/EcclesiaCRM/VIEWControllers/VIEWMapController.php:116 — src/EcclesiaCRM/VIEWControllers/VIEWMapController.php:116-126 | src/EcclesiaCRM/VIEWControllers/VIEWMapController.php:143-153 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/VIEWControllers/VIEWMapController.php:116` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:180 — src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:180-190 | src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:764-774 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (11 lines × 2) src/EcclesiaCRM/model/EcclesiaCRM/Family.php:406 — src/EcclesiaCRM/model/EcclesiaCRM/Family.php:406-416 | src/EcclesiaCRM/model/EcclesiaCRM/Person.php:610-620 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/model/EcclesiaCRM/Family.php:406` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) src/EcclesiaCRM/model/EcclesiaCRM/Person.php:675 — src/EcclesiaCRM/model/EcclesiaCRM/Person.php:675-685 | src/EcclesiaCRM/model/EcclesiaCRM/Person.php:693-703 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/EcclesiaCRM/model/EcclesiaCRM/Person.php:704` calls `getLastName` and `src/EcclesiaCRM/model/EcclesiaCRM/Person.php:686` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (11 lines × 2) src/EcclesiaCRM/model/EcclesiaCRM/User.php:1229 — src/EcclesiaCRM/model/EcclesiaCRM/User.php:1229-1239 | src/EcclesiaCRM/model/EcclesiaCRM/User.php:1248-1258 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/model/EcclesiaCRM/User.php:1229` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) src/Plugins/MailChimp/core/Services/MailChimpService.php:730 — src/Plugins/MailChimp/core/Services/MailChimpService.php:730-740 | src/Plugins/MailChimp/core/Services/MailChimpService.php:773-783 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Plugins/MailChimp/core/Services/MailChimpService.php:730` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) src/tools/integrity-check.php:93 — src/tools/integrity-check.php:93-103 | src/tools/integrity-check.php:178-188 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/tools/integrity-check.php:93` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) src/EcclesiaCRM/APIControllers/SearchController.php:249 — src/EcclesiaCRM/APIControllers/SearchController.php:249-259 | src/EcclesiaCRM/APIControllers/SearchController.php:261-271 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/EcclesiaCRM/APIControllers/SearchController.php:261` calls `in_array`, `isset` and `src/EcclesiaCRM/APIControllers/SearchController.php:273` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (11 lines × 2) src/EcclesiaCRM/model/EcclesiaCRM/Deposit.php:102 — src/EcclesiaCRM/model/EcclesiaCRM/Deposit.php:102-112 | src/EcclesiaCRM/model/EcclesiaCRM/Deposit.php:118-128 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Edited copy of a member (7 corresponding lines) · ×13
  • Edited copy of a member (7 corresponding lines) src/EcclesiaCRM/APIControllers/PastoralCareController.php:109 — src/EcclesiaCRM/APIControllers/PastoralCareController.php:109-122 | src/EcclesiaCRM/APIControllers/PastoralCareController.php:167-173 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) src/EcclesiaCRM/APIControllers/SidebarMenuLinksController.php:215 — src/EcclesiaCRM/APIControllers/SidebarMenuLinksController.php:215-221 | src/EcclesiaCRM/APIControllers/VolunteerOpportunityController.php:290-296 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) src/EcclesiaCRM/VIEWControllers/Sidebar/VIEWPropertyTypeListController.php:32 — src/EcclesiaCRM/VIEWControllers/Sidebar/VIEWPropertyTypeListController.php:32-38 | src/EcclesiaCRM/VIEWControllers/VIEWVolunteerOpportunityController.php:35-41 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) src/EcclesiaCRM/VIEWControllers/VIEWGdprController.php:39 — src/EcclesiaCRM/VIEWControllers/VIEWGdprController.php:39-45 | src/EcclesiaCRM/VIEWControllers/VIEWGdprController.php:61-67 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) REDACTED:1111 — REDACTED:1111-1117 | REDACTED:1134-1140 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) REDACTED:1330 — REDACTED:1330-1336 | REDACTED:1353-1359 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) REDACTED:1432 — REDACTED:1432-1438 | REDACTED:1453-1459 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) src/EcclesiaCRM/Reports/PDF_GroupDirectory.php:119 — src/EcclesiaCRM/Reports/PDF_GroupDirectory.php:119-125 | src/EcclesiaCRM/Reports/PDF_GroupDirectory.php:131-139 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) src/EcclesiaCRM/APIControllers/FinanceDonationFundController.php:42 — src/EcclesiaCRM/APIControllers/FinanceDonationFundController.php:42-48 | src/EcclesiaCRM/APIControllers/FinanceDonationFundController.php:73-82 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) src/EcclesiaCRM/APIControllers/PeopleGroupController.php:420 — src/EcclesiaCRM/APIControllers/PeopleGroupController.php:420-426 | src/EcclesiaCRM/APIControllers/PeopleGroupController.php:484-493 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) src/EcclesiaCRM/APIControllers/SundaySchoolController.php:53 — src/EcclesiaCRM/APIControllers/SundaySchoolController.php:53-59 | src/EcclesiaCRM/APIControllers/SundaySchoolController.php:63-73 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) src/EcclesiaCRM/Reports/PDF_Attendance.php:29 — src/EcclesiaCRM/Reports/PDF_Attendance.php:29-36 | REDACTED:40-46 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) REDACTED:52 — REDACTED:52-59 | REDACTED:194-200 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (14 lines × 2) · ×13
  • Duplicated block (14 lines × 2) src/EcclesiaCRM/APIControllers/CartController.php:429 — src/EcclesiaCRM/APIControllers/CartController.php:429-442 | src/EcclesiaCRM/VIEWControllers/VIEWCartController.php:125-138 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (14 lines × 2) src/EcclesiaCRM/APIControllers/PastoralCareController.php:213 — src/EcclesiaCRM/APIControllers/PastoralCareController.php:213-226 | src/EcclesiaCRM/APIControllers/PastoralCareController.php:344-357 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (14 lines × 2) REDACTED:387 — REDACTED:387-400 | REDACTED:422-435 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (14 lines × 2) src/EcclesiaCRM/APIControllers/UserUsersController.php:237 — src/EcclesiaCRM/APIControllers/UserUsersController.php:237-250 | src/EcclesiaCRM/APIControllers/UserUsersController.php:267-280 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/UserUsersController.php:237` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) src/EcclesiaCRM/Reports/PDF_AddressReport.php:84 — src/EcclesiaCRM/Reports/PDF_AddressReport.php:84-97 | src/Reports/EnvelopeReport.php:52-65 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (14 lines × 2) REDACTED:314 — REDACTED:314-327 | src/Reports/CanvassReports.php:253-266 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (14 lines × 2) REDACTED:349 — REDACTED:349-362 | REDACTED:1684-1697 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (14 lines × 2) src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:231 — src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:231-244 | src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:267-280 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:231` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) src/EcclesiaCRM/dto/Cart.php:388 — src/EcclesiaCRM/dto/Cart.php:388-401 | src/EcclesiaCRM/dto/Cart.php:408-421 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/dto/Cart.php:388` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) src/EcclesiaCRM/sabre/WebDav/MyHomeCollectionSharing.php:190 — src/EcclesiaCRM/sabre/WebDav/MyHomeCollectionSharing.php:190-203 | src/EcclesiaCRM/utils/SabreUtils.php:165-178 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/sabre/WebDav/MyHomeCollectionSharing.php:190` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) REDACTED:287 — REDACTED:287-300 | REDACTED:279-292 — before extracting anything, compare `REDACTED` and `REDACTED` as WHOLE FILES: 83% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (14 lines × 2) REDACTED:616 — REDACTED:616-629 | REDACTED:719-732 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (14 lines × 2) src/EcclesiaCRM/MenuBar/MenuBar.php:329 — src/EcclesiaCRM/MenuBar/MenuBar.php:329-342 | src/EcclesiaCRM/MenuBar/MenuBar.php:348-361 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/EcclesiaCRM/MenuBar/MenuBar.php:326` calls `useGroupTypeQuery`, `filterByListOptionId`, `endUse` and `src/EcclesiaCRM/MenuBar/MenuBar.php:347` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D29 · Static Analysis (SAST) · REDACTED · ×12
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Duplicated block (9 lines × 2) · ×12
  • Duplicated block (9 lines × 2) src/EcclesiaCRM/APIControllers/DocumentCollaboraController.php:386 — src/EcclesiaCRM/APIControllers/DocumentCollaboraController.php:386-394 | src/EcclesiaCRM/APIControllers/DocumentCollaboraController.php:405-413 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (9 lines × 2) src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:496 — src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:496-504 | src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:733-741 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:505` calls `setGroupId`, `getId` and `src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:742` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (9 lines × 2) src/EcclesiaCRM/APIControllers/SearchController.php:459 — src/EcclesiaCRM/APIControllers/SearchController.php:459-467 | src/EcclesiaCRM/APIControllers/SearchController.php:472-480 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/SearchController.php:459` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) src/EcclesiaCRM/APIControllers/SystemGDRPController.php:183 — src/EcclesiaCRM/APIControllers/SystemGDRPController.php:183-191 | src/EcclesiaCRM/VIEWControllers/People/VIEWPersonListController.php:54-62 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/VIEWControllers/People/VIEWPersonListController.php:54` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) src/EcclesiaCRM/APIControllers/UserUsersController.php:91 — src/EcclesiaCRM/APIControllers/UserUsersController.php:91-99 | src/EcclesiaCRM/APIControllers/UserUsersController.php:110-122 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/UserUsersController.php:91` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) src/EcclesiaCRM/Search/FamilyPastoralCareSearchRes.php:30 — src/EcclesiaCRM/Search/FamilyPastoralCareSearchRes.php:30-39 | src/EcclesiaCRM/Search/PersonPastoralCareSearchRes.php:34-42 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Search/FamilyPastoralCareSearchRes.php:30` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) src/EcclesiaCRM/Service/CalendarService.php:1830 — src/EcclesiaCRM/Service/CalendarService.php:1830-1838 | src/EcclesiaCRM/Service/CalendarService.php:2234-2242 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Service/CalendarService.php:1830` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/EcclesiaCRM/Service/CalendarService.php:2231` calls `DateTime`, `getDateTime`, `format` and `src/EcclesiaCRM/Service/CalendarService.php:1827` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (9 lines × 2) src/EcclesiaCRM/Service/PastoralCareService.php:48 — src/EcclesiaCRM/Service/PastoralCareService.php:48-56 | src/EcclesiaCRM/Service/PastoralCareService.php:70-78 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (9 lines × 2) src/EcclesiaCRM/Theme/Theme.php:159 — src/EcclesiaCRM/Theme/Theme.php:159-167 | src/EcclesiaCRM/Theme/Theme.php:174-182 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (9 lines × 2) REDACTED:1020 — REDACTED:1020-1028 | src/EcclesiaCRM/VIEWControllers/VIEWPastoralCareController.php:471-479 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:1020` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `REDACTED:1015` calls `array`, `getUser`, `isEditRecordsEnabled` and `src/EcclesiaCRM/VIEWControllers/VIEWPastoralCareController.php:468` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (9 lines × 2) src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:805 — src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:805-813 | src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:853-861 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:862` calls `setPledgeorpayment`, `setFundid`, `setDepid` and `src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:814` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (9 lines × 2) src/EcclesiaCRM/utils/SabreUtils.php:514 — src/EcclesiaCRM/utils/SabreUtils.php:514-522 | src/EcclesiaCRM/utils/SabreUtils.php:554-562 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/utils/SabreUtils.php:514` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D3 · God Classes · FunctionTooLong · ×11
  • FunctionTooLong: CalendarV2.document.addEventListener("DOMContentLoaded") src/skin/js/calendar/CalendarV2.js:12 — FunctionTooLong — document.addEventListener("DOMContentLoaded") runs 519 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 419 over it, 5.19× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • FunctionTooLong: GroupView.initDataTable REDACTED:332 — FunctionTooLong — initDataTable runs 411 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 311 over it, 4.11× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • FunctionTooLong: setup.document.addEventListener("DOMContentLoaded") src/skin/js/system/setup.js:156 — FunctionTooLong — document.addEventListener("DOMContentLoaded") runs 262 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 162 over it, 2.62× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • FunctionTooLong: EventEditor.BootboxContent src/skin/js/calendar/EventEditor.js:559 — FunctionTooLong — BootboxContent runs 241 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 141 over it, 2.41× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • FunctionTooLong: MenuLinksList.document.addEventListener("DOMContentLoaded") src/skin/js/sidebar/MenuLinksList.js:1 — FunctionTooLong — document.addEventListener("DOMContentLoaded") runs 201 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 101 over it, 2.01× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • FunctionTooLong: PropertyTypeList.document.addEventListener("DOMContentLoaded") src/skin/js/sidebar/PropertyTypeList.js:1 — FunctionTooLong — document.addEventListener("DOMContentLoaded") runs 172 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 72 over it, 1.72× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • FunctionTooLong: EventEditor.createEventEditorWindow src/skin/js/calendar/EventEditor.js:822 — FunctionTooLong — createEventEditorWindow runs 128 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 28 over it, 1.28× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • FunctionTooLong: ckeditorextension.createEditor src/skin/js/ckeditor/ckeditorextension.js:1284 — FunctionTooLong — createEditor runs 122 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 22 over it, 1.22× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • FunctionTooLong: CalendarSideBar.createShareWindow src/skin/js/calendar/CalendarSideBar.js:718 — FunctionTooLong — createShareWindow runs 110 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 10 over it, 1.10× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • FunctionTooLong: ckeditorextension.createFileDropPlugin src/skin/js/ckeditor/ckeditorextension.js:353 — FunctionTooLong — createFileDropPlugin runs 109 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 9 over it, 1.09× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • FunctionTooLong: backup.document.addEventListener("DOMContentLoaded") src/skin/js/backup/backup.js:1 — FunctionTooLong — document.addEventListener("DOMContentLoaded") runs 102 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 2 over it, 1.02× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
AC3 · Page structure · Heading level jumps from h3 to h5 · ×10
  • Heading level jumps from h3 to h5 src/Plugins/MailChimp/v2/templates/managelist.php:100 — Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one.
  • Heading level jumps from h3 to h5 src/v2/templates/calendar/calendar.php:201 — Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one.
  • Heading level jumps from h3 to h5 REDACTED:254 — Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one.
  • Heading level jumps from h3 to h5 src/v2/templates/deposit/financialReports.php:136 — Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one.
  • Heading level jumps from h3 to h5 src/v2/templates/fundraiser/donatedItemEditor.php:27 — Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one.
  • Heading level jumps from h3 to h5 REDACTED:210 — Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one.
  • Heading level jumps from h3 to h5 src/v2/templates/pastoralcare/pastoralcareperson.php:160 — Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one.
  • Heading level jumps from h3 to h5 REDACTED:380 — Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one.
  • Heading level jumps from h3 to h5 src/v2/templates/people/familyview.php:703 — Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one.
  • Heading level jumps from h3 to h5 src/v2/templates/people/lettersandlabels.php:227 — Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one.
D4 · Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) · ×10
  • Members sharing a duplicated core (4 members, 50+ identical tokens) src/EcclesiaCRM/APIControllers/CartController.php:191 — src/EcclesiaCRM/APIControllers/CartController.php:191-208 | src/EcclesiaCRM/APIControllers/CartController.php:212-229 | src/EcclesiaCRM/APIControllers/CartController.php:248-264 | src/EcclesiaCRM/APIControllers/CartController.php:268-285 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) src/EcclesiaCRM/APIControllers/PastoralCareController.php:40 — src/EcclesiaCRM/APIControllers/PastoralCareController.php:40-94 | src/EcclesiaCRM/APIControllers/PastoralCareController.php:414-483 | src/EcclesiaCRM/Service/PastoralCareService.php:40-81 | src/EcclesiaCRM/VIEWControllers/VIEWPastoralCareController.php:81-153 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) src/EcclesiaCRM/APIControllers/PastoralCareController.php:178 — src/EcclesiaCRM/APIControllers/PastoralCareController.php:178-208 | src/EcclesiaCRM/APIControllers/PastoralCareController.php:247-278 | src/EcclesiaCRM/APIControllers/PastoralCareController.php:284-339 | src/EcclesiaCRM/APIControllers/PastoralCareController.php:378-409 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) src/EcclesiaCRM/APIControllers/PeopleGroupController.php:497 — src/EcclesiaCRM/APIControllers/PeopleGroupController.php:497-517 | src/EcclesiaCRM/APIControllers/PeopleGroupController.php:522-554 | src/EcclesiaCRM/APIControllers/PeopleGroupController.php:560-597 | src/EcclesiaCRM/APIControllers/PeopleGroupController.php:601-632 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) src/EcclesiaCRM/APIControllers/PeopleGroupController.php:809 — src/EcclesiaCRM/APIControllers/PeopleGroupController.php:809-900 | src/EcclesiaCRM/Service/DashboardItemService.php:25-133 | src/EcclesiaCRM/Synchronize/SundaySchoolDashboardItem.php:38-139 | src/Reports/PhotoBook.php:149-212 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) REDACTED:209 — REDACTED:209-517 | REDACTED:521-750 | REDACTED:334-919 | src/Reports/CanvassReports.php:158-354 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) REDACTED:209 — REDACTED:209-517 | REDACTED:761-1005 | REDACTED:334-919 | src/Reports/CanvassReports.php:158-354 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) src/EcclesiaCRM/Service/PastoralCareService.php:281 — src/EcclesiaCRM/Service/PastoralCareService.php:281-300 | src/EcclesiaCRM/Service/PastoralCareService.php:305-324 | src/EcclesiaCRM/Service/PastoralCareService.php:358-378 | src/EcclesiaCRM/Service/PastoralCareService.php:383-404 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:149 — src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:149-156 | src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:183-190 | src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:212-219 | src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:364-371 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) src/Plugins/ToDoListDashboard/core/APIControllers/ToDoListDashboardController.php:178 — src/Plugins/ToDoListDashboard/core/APIControllers/ToDoListDashboardController.php:178-216 | src/Plugins/ToDoListDashboard/core/APIControllers/ToDoListDashboardController.php:221-266 | src/Plugins/ToDoListDashboard/core/APIControllers/ToDoListDashboardController.php:312-349 | src/Plugins/ToDoListDashboard/core/APIControllers/ToDoListDashboardController.php:369-407 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication · Duplicated block (12 lines × 2) · ×10
  • Duplicated block (12 lines × 2) src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:580 — src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:580-591 | src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:615-626 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:580` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:593` calls `DateTime`, `DateTimeZone`, `getValue` and `src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:629` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (12 lines × 2) src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:68 — src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:68-79 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:218-230 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:218` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (12 lines × 2) src/EcclesiaCRM/APIControllers/SystemGDRPController.php:200 — src/EcclesiaCRM/APIControllers/SystemGDRPController.php:200-211 | src/EcclesiaCRM/APIControllers/SystemGDRPController.php:254-265 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/SystemGDRPController.php:200` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) src/EcclesiaCRM/APIControllers/SystemSettingsIndividualController.php:125 — src/EcclesiaCRM/APIControllers/SystemSettingsIndividualController.php:125-136 | src/EcclesiaCRM/APIControllers/UserUsersController.php:248-259 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (12 lines × 2) src/EcclesiaCRM/MenuBar/MenuBar.php:284 — src/EcclesiaCRM/MenuBar/MenuBar.php:284-295 | src/EcclesiaCRM/MenuBar/MenuBar.php:539-550 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/MenuBar/MenuBar.php:284` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/EcclesiaCRM/MenuBar/MenuBar.php:296` calls `filterByActive` and `src/EcclesiaCRM/MenuBar/MenuBar.php:551` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (12 lines × 2) src/EcclesiaCRM/VIEWControllers/VIEWDashboardController.php:153 — src/EcclesiaCRM/VIEWControllers/VIEWDashboardController.php:153-165 | src/EcclesiaCRM/VIEWControllers/VIEWDashboardController.php:168-179 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (12 lines × 2) src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:312 — src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:312-323 | src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:393-404 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:312` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) src/EcclesiaCRM/model/EcclesiaCRM/User.php:483 — src/EcclesiaCRM/model/EcclesiaCRM/User.php:483-494 | src/EcclesiaCRM/model/EcclesiaCRM/User.php:508-519 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/model/EcclesiaCRM/User.php:483` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/EcclesiaCRM/model/EcclesiaCRM/User.php:495` calls `create`, `filterById`, `getRoleListId` and `src/EcclesiaCRM/model/EcclesiaCRM/User.php:520` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (12 lines × 2) src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:529 — src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:529-540 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:676-687 — before extracting anything, compare `src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php` and `src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php` as WHOLE FILES: this scan already matched 14 separate duplicated blocks between them, totalling at least 182 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:529` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (12 lines × 2) src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:454 — src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:454-465 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:645-656 — before extracting anything, compare `src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php` and `src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 171 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:454` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (5 lines × 2) · ×10
  • Duplicated block (5 lines × 2) src/EcclesiaCRM/APIControllers/DocumentCollaboraController.php:78 — src/EcclesiaCRM/APIControllers/DocumentCollaboraController.php:78-82 | src/EcclesiaCRM/APIControllers/DocumentCollaboraController.php:207-211 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/DocumentCollaboraController.php:78` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) src/EcclesiaCRM/APIControllers/DocumentCollaboraController.php:102 — src/EcclesiaCRM/APIControllers/DocumentCollaboraController.php:102-106 | src/EcclesiaCRM/APIControllers/DocumentCollaboraController.php:222-227 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/DocumentCollaboraController.php:222` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (5 lines × 2) src/EcclesiaCRM/APIControllers/PastoralCareController.php:238 — src/EcclesiaCRM/APIControllers/PastoralCareController.php:238-242 | src/EcclesiaCRM/APIControllers/PastoralCareController.php:369-373 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/PastoralCareController.php:238` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:450 — src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:450-454 | src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:688-692 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:447` calls `getName` and `src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:685` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (5 lines × 2) REDACTED:72 — REDACTED:72-77 | REDACTED:82-86 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (5 lines × 2) src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:948 — src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:948-952 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:966-970 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:948` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:946` calls `foreach`, `getHeadPeople` and `src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:965` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (5 lines × 2) src/EcclesiaCRM/model/EcclesiaCRM/Family.php:371 — src/EcclesiaCRM/model/EcclesiaCRM/Family.php:371-375 | src/EcclesiaCRM/model/EcclesiaCRM/Person.php:625-629 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (5 lines × 2) REDACTED:50 — REDACTED:50-54 | REDACTED:198-203 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (5 lines × 2) src/EcclesiaCRM/tasks/PersonClassificationDataCheck.php:15 — src/EcclesiaCRM/tasks/PersonClassificationDataCheck.php:15-19 | src/EcclesiaCRM/tasks/PersonGenderDataCheck.php:15-19 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (5 lines × 2) REDACTED:507 — REDACTED:507-511 | REDACTED:747-751 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D15 · Churn × Complexity Hotspots · Hotspot · ×9
  • Hotspot: src/skin/js/filemanager.js src/skin/js/filemanager.js:769 — src/skin/js/filemanager.js changed 16 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 30 in (anonymous) at line 769. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-14..2026-11-12, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-14 20:50:44 +01:00' --until='2026-11-12 20:50:44 +01:00' --full-history --no-merges -- src/skin/js/filemanager.js`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/skin/js/ckeditor/ckeditorextension.js src/skin/js/ckeditor/ckeditorextension.js:880 — src/skin/js/ckeditor/ckeditorextension.js changed 6 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 60 in CRMEditorTools.init at line 880. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-14..2026-11-12, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-14 20:50:44 +01:00' --until='2026-11-12 20:50:44 +01:00' --full-history --no-merges -- src/skin/js/ckeditor/ckeditorextension.js`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/EcclesiaCRM/utils/MiscUtils.php src/EcclesiaCRM/utils/MiscUtils.php:878 — src/EcclesiaCRM/utils/MiscUtils.php changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 71 in MiscUtils.simpleEmbedFiles at line 878. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-14..2026-11-12, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-14 20:50:44 +01:00' --until='2026-11-12 20:50:44 +01:00' --full-history --no-merges -- src/EcclesiaCRM/utils/MiscUtils.php`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/skin/js/calendar/CalendarV2.js src/skin/js/calendar/CalendarV2.js:12 — src/skin/js/calendar/CalendarV2.js changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 91 in CalendarV2.document.addEventListener("DOMContentLoaded") at line 12. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-14..2026-11-12, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-14 20:50:44 +01:00' --until='2026-11-12 20:50:44 +01:00' --full-history --no-merges -- src/skin/js/calendar/CalendarV2.js`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/EcclesiaCRM/Service/CalendarService.php src/EcclesiaCRM/Service/CalendarService.php:1329 — src/EcclesiaCRM/Service/CalendarService.php changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 37 in CalendarService.createCalendarItemForGetEvents at line 1329. 1 of those changes was a fix/bug commit, and the other 3 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-14..2026-11-12, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-14 20:50:44 +01:00' --until='2026-11-12 20:50:44 +01:00' --full-history --no-merges -- src/EcclesiaCRM/Service/CalendarService.php`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/EcclesiaCRM/VIEWControllers/VIEWEdriveController.php src/EcclesiaCRM/VIEWControllers/VIEWEdriveController.php:108 — src/EcclesiaCRM/VIEWControllers/VIEWEdriveController.php changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 47 in VIEWEdriveController.renderShares at line 108. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-14..2026-11-12, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-14 20:50:44 +01:00' --until='2026-11-12 20:50:44 +01:00' --full-history --no-merges -- src/EcclesiaCRM/VIEWControllers/VIEWEdriveController.php`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/EcclesiaCRM/utils/InputUtils.php src/EcclesiaCRM/utils/InputUtils.php:129 — src/EcclesiaCRM/utils/InputUtils.php changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 31 in InputUtils.cleanNode at line 129. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-14..2026-11-12, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-14 20:50:44 +01:00' --until='2026-11-12 20:50:44 +01:00' --full-history --no-merges -- src/EcclesiaCRM/utils/InputUtils.php`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/EcclesiaCRM/APIControllers/DocumentCollaboraController.php src/EcclesiaCRM/APIControllers/DocumentCollaboraController.php:119 — src/EcclesiaCRM/APIControllers/DocumentCollaboraController.php changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 18 in DocumentCollaboraController.resolveSharedAlias at line 119. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-14..2026-11-12, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-14 20:50:44 +01:00' --until='2026-11-12 20:50:44 +01:00' --full-history --no-merges -- src/EcclesiaCRM/APIControllers/DocumentCollaboraController.php`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/EcclesiaCRM/Service/SharedDocumentService.php src/EcclesiaCRM/Service/SharedDocumentService.php:12 — src/EcclesiaCRM/Service/SharedDocumentService.php changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 20 in SharedDocumentService.resolve at line 12. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-14..2026-11-12, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-14 20:50:44 +01:00' --until='2026-11-12 20:50:44 +01:00' --full-history --no-merges -- src/EcclesiaCRM/Service/SharedDocumentService.php`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
D4 · Code Duplication · Members sharing a duplicated core (8 members, 50+ identical tokens) · ×9
  • Members sharing a duplicated core (8 members, 50+ identical tokens) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:354 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:354-364 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:329-339 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:306-316 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:338-348 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:354-364 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:320-330 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:331-341 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:349-359 — These 8 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 8 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 8 times.
  • Members sharing a duplicated core (8 members, 50+ identical tokens) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:712 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:712-737 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:573-598 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:498-523 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:608-633 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:720-745 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:516-541 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:586-611 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:689-714 — These 8 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 8 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 8 times.
  • Members sharing a duplicated core (8 members, 50+ identical tokens) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:786 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:786-820 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:647-681 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:572-606 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:682-716 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:794-828 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:590-624 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:660-694 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:763-797 — These 8 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 8 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 8 times.
  • Members sharing a duplicated core (8 members, 50+ identical tokens) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:836 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:836-855 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:697-716 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:622-641 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:732-751 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:844-863 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:640-659 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:710-729 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:813-832 — These 8 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 8 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 8 times.
  • Members sharing a duplicated core (8 members, 50+ identical tokens) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:1257 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:1257-1268 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:1062-1073 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:963-974 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:1113-1124 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:1273-1284 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:981-992 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:1071-1082 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:1218-1229 — These 8 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 8 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 8 times.
  • Members sharing a duplicated core (8 members, 50+ identical tokens) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:1492 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:1492-1520 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:1291-1319 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:1189-1217 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:1344-1372 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:1508-1536 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:1208-1236 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:1300-1328 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:1451-1479 — These 8 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 8 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 8 times.
  • Members sharing a duplicated core (8 members, 50+ identical tokens) src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:143 — src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:143-166 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeetingQuery.php:125-148 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeetingQuery.php:119-142 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeetingQuery.php:131-154 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboardQuery.php:143-166 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboardQuery.php:119-142 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItemQuery.php:137-160 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardQuery.php:125-148 — These 8 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 8 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 8 times.
  • Members sharing a duplicated core (8 members, 50+ identical tokens) src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:182 — src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:182-200 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeetingQuery.php:164-182 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeetingQuery.php:158-176 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeetingQuery.php:170-188 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboardQuery.php:182-200 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboardQuery.php:158-176 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItemQuery.php:176-194 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardQuery.php:164-182 — These 8 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 8 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 8 times.
  • Members sharing a duplicated core (8 members, 50+ identical tokens) src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:234 — src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:234-243 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeetingQuery.php:216-225 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeetingQuery.php:210-219 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeetingQuery.php:222-231 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboardQuery.php:234-243 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboardQuery.php:210-219 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItemQuery.php:228-237 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardQuery.php:216-225 — These 8 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 8 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 8 times.
D29 · Static Analysis (SAST) · REDACTED · ×8
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×8
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Duplicated block (15 lines × 2) · ×8
  • Duplicated block (15 lines × 2) src/EcclesiaCRM/APIControllers/FinancePaymentController.php:177 — src/EcclesiaCRM/APIControllers/FinancePaymentController.php:177-191 | src/EcclesiaCRM/APIControllers/FinancePaymentController.php:196-210 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (15 lines × 2) src/EcclesiaCRM/APIControllers/PeopleController.php:291 — src/EcclesiaCRM/APIControllers/PeopleController.php:291-305 | src/EcclesiaCRM/APIControllers/PeopleController.php:328-342 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/PeopleController.php:291` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 2) src/EcclesiaCRM/MenuBar/MenuBar.php:365 — src/EcclesiaCRM/MenuBar/MenuBar.php:365-379 | src/EcclesiaCRM/MenuBar/MenuBar.php:600-614 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/MenuBar/MenuBar.php:365` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/EcclesiaCRM/MenuBar/MenuBar.php:380` calls `filterByType` and `src/EcclesiaCRM/MenuBar/MenuBar.php:615` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (15 lines × 2) src/EcclesiaCRM/Reports/PDF_Attendance.php:303 — src/EcclesiaCRM/Reports/PDF_Attendance.php:303-317 | src/EcclesiaCRM/Reports/PDF_Attendance.php:657-671 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Reports/PDF_Attendance.php:303` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/EcclesiaCRM/Reports/PDF_Attendance.php:301` calls `WriteAt`, `mb_substr`, `_` and `src/EcclesiaCRM/Reports/PDF_Attendance.php:655` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (15 lines × 2) REDACTED:473 — REDACTED:473-489 | REDACTED:714-728 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:473` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `REDACTED:729` calls `withColumn` and `REDACTED:490` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (15 lines × 2) REDACTED:881 — REDACTED:881-895 | REDACTED:568-582 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `REDACTED:584` calls `filterByFamId`, `getId` and `REDACTED:897` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (15 lines × 2) src/EcclesiaCRM/utils/InputUtils.php:346 — src/EcclesiaCRM/utils/InputUtils.php:346-360 | src/EcclesiaCRM/utils/InputUtils.php:362-376 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/utils/InputUtils.php:346` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (15 lines × 2) REDACTED:448 — REDACTED:448-462 | REDACTED:675-689 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:448` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (11 lines × 3) · ×8
  • Duplicated block (11 lines × 3) REDACTED:491 — REDACTED:491-501 | REDACTED:731-742 | src/Reports/CanvassReports.php:311-321 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:491` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `REDACTED:729` calls `withColumn` and `REDACTED:489` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (11 lines × 3) src/EcclesiaCRM/Search/PersonCustomSearchRes.php:114 — src/EcclesiaCRM/Search/PersonCustomSearchRes.php:114-124 | src/EcclesiaCRM/Search/PersonGroupManagerSearchRes.php:105-115 | src/EcclesiaCRM/Search/PersonPropsSearchRes.php:97-107 — before extracting anything, compare `src/EcclesiaCRM/Search/PersonGroupManagerSearchRes.php` and `src/EcclesiaCRM/Search/PersonPropsSearchRes.php` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 81 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Search/PersonCustomSearchRes.php:114` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/EcclesiaCRM/Search/PersonGroupManagerSearchRes.php:102` calls `getId` and `src/EcclesiaCRM/Search/PersonCustomSearchRes.php:112` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (11 lines × 3) src/EcclesiaCRM/Service/CalendarService.php:374 — src/EcclesiaCRM/Service/CalendarService.php:374-384 | src/EcclesiaCRM/Service/CalendarService.php:633-643 | src/EcclesiaCRM/Service/CalendarService.php:1086-1096 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
  • Duplicated block (11 lines × 3) src/EcclesiaCRM/VIEWControllers/VIEWDashboardController.php:126 — src/EcclesiaCRM/VIEWControllers/VIEWDashboardController.php:126-136 | src/EcclesiaCRM/VIEWControllers/VIEWDashboardController.php:154-165 | src/EcclesiaCRM/VIEWControllers/VIEWDashboardController.php:169-179 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
  • Duplicated block (11 lines × 3) src/EcclesiaCRM/utils/MiscUtils.php:1002 — src/EcclesiaCRM/utils/MiscUtils.php:1002-1012 | src/EcclesiaCRM/utils/MiscUtils.php:1174-1184 | src/EcclesiaCRM/utils/MiscUtils.php:1260-1270 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/utils/MiscUtils.php:1002` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 3) src/Plugins/MailChimp/core/VIEWControllers/VIEWMailchimpController.php:178 — src/Plugins/MailChimp/core/VIEWControllers/VIEWMailchimpController.php:178-188 | src/Plugins/MailChimp/core/VIEWControllers/VIEWMailchimpController.php:208-218 | src/Plugins/MailChimp/core/VIEWControllers/VIEWMailchimpController.php:237-247 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
  • Duplicated block (11 lines × 3) src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:883 — src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:883-893 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:1067-1077 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:1021-1031 — before extracting anything, compare `src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php` and `src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php` as WHOLE FILES: this scan already matched 14 separate duplicated blocks between them, totalling at least 182 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (11 lines × 3) src/EcclesiaCRM/APIControllers/PeopleGroupController.php:884 — src/EcclesiaCRM/APIControllers/PeopleGroupController.php:884-894 | src/EcclesiaCRM/Service/DashboardItemService.php:112-122 | src/EcclesiaCRM/Synchronize/SundaySchoolDashboardItem.php:122-132 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
D4 · Code Duplication · Duplicated block (6 lines × 2) · ×8
  • Duplicated block (6 lines × 2) src/EcclesiaCRM/APIControllers/PastoralCareController.php:250 — src/EcclesiaCRM/APIControllers/PastoralCareController.php:250-255 | src/EcclesiaCRM/APIControllers/PastoralCareController.php:381-386 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/PastoralCareController.php:250` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (6 lines × 2) REDACTED:125 — REDACTED:125-130 | REDACTED:310-315 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:125` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) src/EcclesiaCRM/VIEWControllers/People/VIEWFamilyListController.php:69 — src/EcclesiaCRM/VIEWControllers/People/VIEWFamilyListController.php:69-74 | src/EcclesiaCRM/VIEWControllers/People/VIEWPersonListController.php:64-69 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/VIEWControllers/People/VIEWFamilyListController.php:69` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) src/EcclesiaCRM/dto/ReportUtilities.php:60 — src/EcclesiaCRM/dto/ReportUtilities.php:60-65 | REDACTED:108-113 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/dto/ReportUtilities.php:60` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:422 — src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:422-427 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:506-511 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:422` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) src/tools/integrity-check.php:86 — src/tools/integrity-check.php:86-91 | src/tools/integrity-check.php:171-176 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/tools/integrity-check.php:86` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) src/EcclesiaCRM/Reports/PDF_CanvassBriefingReport.php:10 — src/EcclesiaCRM/Reports/PDF_CanvassBriefingReport.php:10-15 | src/Reports/VotingMembers.php:41-47 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (6 lines × 2) src/EcclesiaCRM/Service/FinancialService.php:414 — src/EcclesiaCRM/Service/FinancialService.php:414-419 | src/EcclesiaCRM/model/EcclesiaCRM/Deposit.php:276-281 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
AC6 · Visual & motion safety · Animation without a prefers-reduced-motion guard · ×7
  • Animation without a prefers-reduced-motion guard src/skin/scss/_adminLTE_update.scss:418 — `.navbar-search-form` moves (`transition: flex-basis 0.2s ease, width 0.2s ease, max-width 0.2s ease`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
  • Animation without a prefers-reduced-motion guard src/skin/scss/_alert.scss:55 — `.crm-global-message__close` moves (`transition: opacity 0.2s ease, background-color 0.2s ease, transform 0.2s ease`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
  • Animation without a prefers-reduced-motion guard src/skin/scss/_ckeditorExtension.scss:225 — `.crm-ckeditor-upload-progress-bar` moves (`transition: width 150ms linear`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
  • Animation without a prefers-reduced-motion guard src/skin/scss/_maps.scss:61 — `.map-shell-button` moves (`transition: transform 0.18s ease, box-shadow 0.18s ease, background-color 0.18s ease, border-color 0.18s ease`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
  • Animation without a prefers-reduced-motion guard src/skin/scss/_maps.scss:213 — `div .legenditem` moves (`transition: transform 0.18s ease, box-shadow 0.18s ease, background-color 0.18s ease`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
  • Animation without a prefers-reduced-motion guard src/skin/scss/_quick_access.scss:75 — `.quick-access-entry-icon` moves (`transition: transform 0.2s ease`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
  • Animation without a prefers-reduced-motion guard src/skin/scss/_upgrade_system.scss:145 — `.upgrade-step-card` moves (`transition: transform 0.25s ease, box-shadow 0.25s ease, border-color 0.25s ease, opacity 0.25s ease`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
D17 · Explicit Debt · TodoComment · ×7
  • TodoComment src/v2/templates/user/userseditor.php:585 — // todo dates !!!! PL — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:811 — // todo dates !!!! PL — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/setup/templates/setup-steps.php:47 — //TODO this is not correct we need 2 flags — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/EcclesiaCRM/Bootstrapper.php:408 — // TODO: This function needs to stop creating global variable-variables. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/EcclesiaCRM/Bootstrapper.php:419 — //TODO: THESE Variable-Variables must go awawy — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/EcclesiaCRM/model/EcclesiaCRM/PluginQuery.php:66 — // TODO: Change the autogenerated stub — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/EcclesiaCRM/dto/SystemURLs.php:118 — // jump to the first whitelisted url (TODO: maybe pick a ranodm URL?) — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
D29 · Static Analysis (SAST) · REDACTED · ×7
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×7
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Edited copy of a member (18 corresponding lines) · ×7
  • Edited copy of a member (18 corresponding lines) src/Plugins/NewsDashboard/core/APIControllers/NewsDashboardController.php:69 — src/Plugins/NewsDashboard/core/APIControllers/NewsDashboardController.php:69-86 | src/Plugins/NewsDashboard/core/APIControllers/NewsDashboardController.php:91-114 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (18 corresponding lines) src/EcclesiaCRM/APIControllers/UserUsersController.php:296 — src/EcclesiaCRM/APIControllers/UserUsersController.php:296-313 | src/EcclesiaCRM/APIControllers/UserUsersController.php:318-335 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (18 corresponding lines) src/EcclesiaCRM/Reports/PDF_AddressReport.php:84 — src/EcclesiaCRM/Reports/PDF_AddressReport.php:84-101 | src/Reports/EnvelopeReport.php:52-71 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (18 corresponding lines) src/EcclesiaCRM/dto/CountryDropDown.php:10 — src/EcclesiaCRM/dto/CountryDropDown.php:10-27 | src/EcclesiaCRM/dto/StateDropDown.php:14-40 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (18 corresponding lines) src/EcclesiaCRM/MICRFunctions.php:20 — src/EcclesiaCRM/MICRFunctions.php:20-37 | src/EcclesiaCRM/utils/MICRReader.php:20-39 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (18 corresponding lines) src/EcclesiaCRM/sabre/WebDav/WebDavPDO.php:66 — src/EcclesiaCRM/sabre/WebDav/WebDavPDO.php:66-84 | src/EcclesiaCRM/utils/SabreUtils.php:373-390 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (18 corresponding lines) src/EcclesiaCRM/Service/ConfirmReportService.php:864 — src/EcclesiaCRM/Service/ConfirmReportService.php:864-881 | src/EcclesiaCRM/Service/ConfirmReportService.php:888-905 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (21 corresponding lines) · ×7
  • Edited copy of a member (21 corresponding lines) src/EcclesiaCRM/APIControllers/DocumentShareController.php:324 — src/EcclesiaCRM/APIControllers/DocumentShareController.php:324-344 | src/EcclesiaCRM/APIControllers/DocumentShareController.php:423-443 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (21 corresponding lines) REDACTED:88 — REDACTED:88-108 | REDACTED:292-321 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (21 corresponding lines) src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:296 — src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:296-316 | src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:367-387 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (21 corresponding lines) src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeetingQuery.php:284 — src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeetingQuery.php:284-304 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeetingQuery.php:327-347 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (21 corresponding lines) src/Plugins/NoteDashboard/core/model/Base/NoteDashboardQuery.php:272 — src/Plugins/NoteDashboard/core/model/Base/NoteDashboardQuery.php:272-292 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboardQuery.php:315-335 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (21 corresponding lines) src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardQuery.php:278 — src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardQuery.php:278-298 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardQuery.php:349-369 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (21 corresponding lines) src/EcclesiaCRM/APIControllers/CalendarV2Controller.php:384 — src/EcclesiaCRM/APIControllers/CalendarV2Controller.php:384-404 | src/EcclesiaCRM/APIControllers/CalendarV2Controller.php:408-428 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (7 lines × 3) · ×7
  • Duplicated block (7 lines × 3) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:613 — src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:613-619 | src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:651-658 | src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:703-709 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:613` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 3) src/EcclesiaCRM/APIControllers/SystemGDRPController.php:90 — src/EcclesiaCRM/APIControllers/SystemGDRPController.php:90-96 | src/EcclesiaCRM/APIControllers/SystemGDRPController.php:117-123 | src/EcclesiaCRM/APIControllers/SystemGDRPController.php:135-141 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/SystemGDRPController.php:90` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 3) src/EcclesiaCRM/Reports/PDF_Badge.php:68 — src/EcclesiaCRM/Reports/PDF_Badge.php:68-74 | REDACTED:107-113 | REDACTED:142-148 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart.
  • Duplicated block (7 lines × 3) src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:232 — src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:232-238 | src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:434-440 | src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:1031-1037 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:232` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 3) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:519 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:519-525 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:466-472 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:496-502 — before extracting anything, compare `src/Plugins/MailChimp/core/model/Base/MailChimpParams.php` and `src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 166 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (7 lines × 3) src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:965 — src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:965-971 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:872-878 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:1010-1016 — before extracting anything, compare `src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php` and `src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 166 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:965` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 3) src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:410 — src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:410-416 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItemQuery.php:376-382 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardQuery.php:392-398 — before extracting anything, compare `src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php` and `src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItemQuery.php` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 64 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
AC1 · Text alternatives · <canvas> without a text alternative · ×6
  • <canvas> without a text alternative src/Plugins/FinanceDashboard/v2/templates/View.php:50 — A <canvas> with no aria-label/title and no inner fallback content can't be described by assistive tech. Add a name or fallback content.
  • <canvas> without a text alternative src/v2/templates/deposit/depositslipeditor.php:100 — A <canvas> with no aria-label/title and no inner fallback content can't be described by assistive tech. Add a name or fallback content.
  • <canvas> without a text alternative src/v2/templates/deposit/depositslipeditor.php:116 — A <canvas> with no aria-label/title and no inner fallback content can't be described by assistive tech. Add a name or fallback content.
  • <canvas> without a text alternative src/v2/templates/deposit/finddepositslip.php:88 — A <canvas> with no aria-label/title and no inner fallback content can't be described by assistive tech. Add a name or fallback content.
  • <canvas> without a text alternative src/v2/templates/people/peopledashboard.php:401 — A <canvas> with no aria-label/title and no inner fallback content can't be described by assistive tech. Add a name or fallback content.
  • <canvas> without a text alternative src/v2/templates/people/peopledashboard.php:415 — A <canvas> with no aria-label/title and no inner fallback content can't be described by assistive tech. Add a name or fallback content.
D4 · Code Duplication · Duplicated block (16 lines × 2) · ×6
  • Duplicated block (16 lines × 2) src/EcclesiaCRM/APIControllers/PeopleController.php:180 — src/EcclesiaCRM/APIControllers/PeopleController.php:180-195 | src/EcclesiaCRM/APIControllers/PeopleController.php:250-265 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/PeopleController.php:180` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (16 lines × 2) REDACTED:495 — REDACTED:495-510 | REDACTED:735-750 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:495` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (16 lines × 2) REDACTED:371 — REDACTED:371-386 | REDACTED:394-409 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:371` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (16 lines × 2) src/EcclesiaCRM/VIEWControllers/VIEWFundraiserController.php:211 — src/EcclesiaCRM/VIEWControllers/VIEWFundraiserController.php:211-226 | src/EcclesiaCRM/VIEWControllers/VIEWFundraiserController.php:264-279 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (16 lines × 2) src/EcclesiaCRM/utils/MiscUtils.php:1042 — src/EcclesiaCRM/utils/MiscUtils.php:1042-1057 | src/EcclesiaCRM/utils/MiscUtils.php:1312-1327 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/utils/MiscUtils.php:1042` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (16 lines × 2) src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:164 — src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:164-179 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:202-217 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:164` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (15–16 lines × 2) · ×6
  • Duplicated block (15–16 lines × 2) src/EcclesiaCRM/Reports/CSV_RealAttendance.php:103 — src/EcclesiaCRM/Reports/CSV_RealAttendance.php:103-117 | src/EcclesiaCRM/Reports/PDF_RealAttendance.php:105-120 — before extracting anything, compare `src/EcclesiaCRM/Reports/CSV_RealAttendance.php` and `src/EcclesiaCRM/Reports/PDF_RealAttendance.php` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Reports/CSV_RealAttendance.php:103` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15–16 lines × 2) src/EcclesiaCRM/Service/PastoralCareService.php:305 — src/EcclesiaCRM/Service/PastoralCareService.php:305-319 | src/EcclesiaCRM/Service/PastoralCareService.php:358-373 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Service/PastoralCareService.php:305` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15–16 lines × 2) src/EcclesiaCRM/VIEWControllers/People/VIEWFamilyListController.php:126 — src/EcclesiaCRM/VIEWControllers/People/VIEWFamilyListController.php:126-140 | src/EcclesiaCRM/VIEWControllers/People/VIEWFamilyListController.php:142-157 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/VIEWControllers/People/VIEWFamilyListController.php:142` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (15–16 lines × 2) src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:115 — src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:115-129 | src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:806-821 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (15–16 lines × 2) src/EcclesiaCRM/utils/MiscUtils.php:2032 — src/EcclesiaCRM/utils/MiscUtils.php:2032-2047 | src/EcclesiaCRM/utils/MiscUtils.php:2137-2151 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (15–16 lines × 2) src/Plugins/MailChimp/core/Services/MailChimpService.php:688 — src/Plugins/MailChimp/core/Services/MailChimpService.php:688-703 | src/Plugins/MailChimp/core/Services/MailChimpService.php:723-737 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Plugins/MailChimp/core/Services/MailChimpService.php:688` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (13 lines × 2) · ×6
  • Duplicated block (13 lines × 2) src/EcclesiaCRM/Reports/PDF_Attendance.php:324 — src/EcclesiaCRM/Reports/PDF_Attendance.php:324-336 | src/EcclesiaCRM/Reports/PDF_Attendance.php:677-689 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Reports/PDF_Attendance.php:324` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/EcclesiaCRM/Reports/PDF_Attendance.php:339` calls `WriteAt` and `src/EcclesiaCRM/Reports/PDF_Attendance.php:692` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (13 lines × 2) REDACTED:429 — REDACTED:429-442 | REDACTED:655-667 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:429` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) REDACTED:108 — REDACTED:108-120 | REDACTED:143-155 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (13 lines × 2) src/EcclesiaCRM/Service/CalendarService.php:1761 — src/EcclesiaCRM/Service/CalendarService.php:1761-1773 | src/EcclesiaCRM/Service/CalendarService.php:2163-2175 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/EcclesiaCRM/Service/CalendarService.php:1776` calls `setCreatorUserId`, `getId`, `setGroupId` and `src/EcclesiaCRM/Service/CalendarService.php:2177` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (13 lines × 2) src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:132 — src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:132-144 | src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:830-842 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:132` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) src/Plugins/MailChimp/core/VIEWControllers/VIEWMailchimpController.php:84 — src/Plugins/MailChimp/core/VIEWControllers/VIEWMailchimpController.php:84-96 | src/Plugins/MailChimp/core/VIEWControllers/VIEWMailchimpController.php:130-142 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D1 · Cyclomatic Complexity · (anonymous) · ×5
  • (anonymous)::eventDidMount (cyclomatic 36) src/skin/js/calendar/CalendarV2.js:368 — (anonymous)::eventDidMount has cyclomatic complexity 36 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
  • (anonymous)::buildAddress (cyclomatic 29) src/skin/js/pastoralcare/PastoralCareMembersList.js:58 — (anonymous)::buildAddress has cyclomatic complexity 29 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
  • (anonymous)::reloadLabel (cyclomatic 23) src/skin/js/BadgeSticker.js:12 — (anonymous)::reloadLabel has cyclomatic complexity 23 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
  • (anonymous)::buildAddress (cyclomatic 17) src/skin/js/pastoralcare/PastoralCareDashboard.js:141 — (anonymous)::buildAddress has cyclomatic complexity 17 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
  • (anonymous)::render (cyclomatic 16) src/skin/js/filemanager.js:283 — (anonymous)::render has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 19) · ×5
  • (anonymous) (cyclomatic 19) src/Plugins/ToDoListDashboard/skin/js/ToDoListDashboard.js:1 — (anonymous) has cyclomatic complexity 19 (threshold 15). Most of this is not in the body itself: 2 of the 19 points are its own statements and the rest belongs to 38 function items inside it that branch (a function literal at line 202, addElementsToDoList, a function literal at line 155, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
  • (anonymous) (cyclomatic 19) src/Plugins/MailChimp/skin/js/Dashboard.js:10 — (anonymous) has cyclomatic complexity 19 (threshold 15). Most of this is not in the body itself: 1 of the 19 points is its own statement and the rest belongs to 13 function items inside it that branch (a function literal at line 27, a function literal at line 297, render_container, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
  • (anonymous) (cyclomatic 19) src/skin/js/user/UserList.js:1 — (anonymous) has cyclomatic complexity 19 (threshold 15). Most of this is not in the body itself: 2 of the 19 points are its own statements and the rest belongs to 28 function items inside it that branch (a function literal at line 68, a function literal at line 100, a function literal at line 5, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
  • (anonymous) (cyclomatic 19) src/skin/js/people/AddRemoveCart.js:1 — (anonymous) has cyclomatic complexity 19 (threshold 15). Most of this is not in the body itself: 1 of the 19 points is its own statement and the rest belongs to 17 function items inside it that branch (a function literal at line 28, a function literal at line 51, a function literal at line 79, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
  • (anonymous) (cyclomatic 19) src/skin/js/fundraiser/batchWinnerEntry.js:1 — (anonymous) has cyclomatic complexity 19 (threshold 15). Most of this is not in the body itself: 1 of the 19 points is its own statement and the rest belongs to 3 function literals inside it that branch (lines 36, 6, 28). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D29 · Static Analysis (SAST) · REDACTED · ×5
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Members sharing a duplicated core (5 members, 50+ identical tokens) · ×5
  • Members sharing a duplicated core (5 members, 50+ identical tokens) src/EcclesiaCRM/APIControllers/CartController.php:474 — src/EcclesiaCRM/APIControllers/CartController.php:474-498 | REDACTED:467-488 | src/EcclesiaCRM/APIControllers/PeopleGroupController.php:135-164 | REDACTED:640-661 | src/EcclesiaCRM/APIControllers/VolunteerOpportunityController.php:75-104 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
  • Members sharing a duplicated core (5 members, 50+ identical tokens) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:609 — src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:609-642 | src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:647-692 | src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:697-784 | src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:789-947 | src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:952-987 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
  • Members sharing a duplicated core (5 members, 50+ identical tokens) REDACTED:208 — REDACTED:208-251 | REDACTED:282-311 | REDACTED:665-703 | REDACTED:734-763 | REDACTED:761-1005 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
  • Members sharing a duplicated core (5 members, 50+ identical tokens) src/EcclesiaCRM/Search/FamilyPastoralCareSearchRes.php:30 — src/EcclesiaCRM/Search/FamilyPastoralCareSearchRes.php:30-153 | src/EcclesiaCRM/Search/FamilyPropsSearchRes.php:36-169 | src/EcclesiaCRM/Search/GroupPropsSearchRes.php:37-152 | src/EcclesiaCRM/Search/PersonGroupManagerSearchRes.php:35-176 | src/EcclesiaCRM/Search/PersonPropsSearchRes.php:39-166 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
  • Members sharing a duplicated core (5 members, 50+ identical tokens) src/EcclesiaCRM/Search/PersonAssignToGroupSearchRes.php:36 — src/EcclesiaCRM/Search/PersonAssignToGroupSearchRes.php:36-166 | src/EcclesiaCRM/Search/PersonCustomSearchRes.php:35-189 | src/EcclesiaCRM/Search/PersonGroupManagerSearchRes.php:35-176 | src/EcclesiaCRM/Search/PersonPastoralCareSearchRes.php:34-148 | src/EcclesiaCRM/Search/PersonPropsSearchRes.php:39-166 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
D4 · Code Duplication · Edited copy of a member (20 corresponding lines) · ×5
  • Edited copy of a member (20 corresponding lines) src/EcclesiaCRM/APIControllers/SidebarMenuLinksController.php:111 — src/EcclesiaCRM/APIControllers/SidebarMenuLinksController.php:111-130 | src/EcclesiaCRM/APIControllers/SidebarMenuLinksController.php:135-154 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (20 corresponding lines) src/EcclesiaCRM/Theme/Theme.php:30 — src/EcclesiaCRM/Theme/Theme.php:30-49 | src/EcclesiaCRM/model/EcclesiaCRM/User.php:1050-1072 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (20 corresponding lines) src/EcclesiaCRM/APIControllers/PeopleController.php:380 — src/EcclesiaCRM/APIControllers/PeopleController.php:380-401 | src/EcclesiaCRM/APIControllers/PeopleController.php:406-425 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (20 corresponding lines) REDACTED:241 — REDACTED:241-260 | REDACTED:264-288 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (20 corresponding lines) src/EcclesiaCRM/sabre/CalDav/CalDavPDO.php:49 — src/EcclesiaCRM/sabre/CalDav/CalDavPDO.php:49-74 | src/EcclesiaCRM/sabre/CalDav/CalDavPDO.php:641-660 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (19 corresponding lines) · ×5
  • Edited copy of a member (19 corresponding lines) REDACTED:457 — REDACTED:457-475 | REDACTED:479-497 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (19 corresponding lines) REDACTED:47 — REDACTED:47-65 | REDACTED:69-88 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (19 corresponding lines) src/EcclesiaCRM/model/EcclesiaCRM/Note.php:56 — src/EcclesiaCRM/model/EcclesiaCRM/Note.php:56-76 | src/EcclesiaCRM/model/EcclesiaCRM/Note.php:81-99 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (19 corresponding lines) src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:234 — src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:234-252 | src/Plugins/MailChimp/core/Synchronize/MailchimpDashboardItemPlugin.php:21-39 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (19 corresponding lines) src/EcclesiaCRM/dto/ImageTreatment.php:8 — src/EcclesiaCRM/dto/ImageTreatment.php:8-36 | src/EcclesiaCRM/dto/ImageTreatment.php:40-58 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (15 corresponding lines) · ×5
  • Edited copy of a member (15 corresponding lines) src/EcclesiaCRM/APIControllers/FinanceDonationFundController.php:53 — src/EcclesiaCRM/APIControllers/FinanceDonationFundController.php:53-68 | src/EcclesiaCRM/APIControllers/FinanceDonationFundController.php:87-101 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (15 corresponding lines) src/EcclesiaCRM/APIControllers/FinanceDepositController.php:36 — src/EcclesiaCRM/APIControllers/FinanceDepositController.php:36-50 | src/EcclesiaCRM/APIControllers/FinanceDepositController.php:78-94 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (15 corresponding lines) src/EcclesiaCRM/APIControllers/UserUsersController.php:67 — src/EcclesiaCRM/APIControllers/UserUsersController.php:67-86 | src/EcclesiaCRM/APIControllers/UserUsersController.php:91-105 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (15 corresponding lines) src/EcclesiaCRM/model/EcclesiaCRM/User.php:1229 — src/EcclesiaCRM/model/EcclesiaCRM/User.php:1229-1243 | src/EcclesiaCRM/model/EcclesiaCRM/User.php:1248-1262 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (15 corresponding lines) src/EcclesiaCRM/Reports/PDF_Directory.php:34 — src/EcclesiaCRM/Reports/PDF_Directory.php:34-51 | src/EcclesiaCRM/Reports/PDF_GroupDirectory.php:23-37 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (23 lines × 2) · ×5
  • Duplicated block (23 lines × 2) src/EcclesiaCRM/APIControllers/PeopleController.php:69 — src/EcclesiaCRM/APIControllers/PeopleController.php:69-91 | src/EcclesiaCRM/APIControllers/PeopleController.php:126-148 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/PeopleController.php:69` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (23 lines × 2) REDACTED:501 — REDACTED:501-523 | REDACTED:777-799 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:501` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (23 lines × 2) src/EcclesiaCRM/Search/DepositSearchRes.php:159 — src/EcclesiaCRM/Search/DepositSearchRes.php:159-181 | src/EcclesiaCRM/Search/DepositSearchRes.php:255-277 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Search/DepositSearchRes.php:255` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (23 lines × 2) src/EcclesiaCRM/Service/CalendarService.php:268 — src/EcclesiaCRM/Service/CalendarService.php:268-290 | src/EcclesiaCRM/Service/CalendarService.php:1015-1037 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (23 lines × 2) src/EcclesiaCRM/Synchronize/PersonDashboardItem.php:76 — src/EcclesiaCRM/Synchronize/PersonDashboardItem.php:76-98 | src/Plugins/PersonInfosDashboard/core/Synchronize/PersonDashboardItemPlugin.php:60-82 — before extracting anything, compare `src/EcclesiaCRM/Synchronize/PersonDashboardItem.php` and `src/Plugins/PersonInfosDashboard/core/Synchronize/PersonDashboardItemPlugin.php` as WHOLE FILES: 85% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Synchronize/PersonDashboardItem.php:76` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (20 lines × 2) · ×5
  • Duplicated block (20 lines × 2) REDACTED:91 — REDACTED:91-110 | REDACTED:121-140 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:91` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (20 lines × 2) REDACTED:836 — REDACTED:836-855 | REDACTED:881-900 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `REDACTED:857` calls `FinishPage` and `REDACTED:902` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (20 lines × 2) src/EcclesiaCRM/Service/ConfirmReportService.php:56 — src/EcclesiaCRM/Service/ConfirmReportService.php:56-75 | src/EcclesiaCRM/Service/ConfirmReportService.php:486-505 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (20 lines × 2) src/Plugins/MailChimp/core/Services/MailChimpService.php:549 — src/Plugins/MailChimp/core/Services/MailChimpService.php:549-568 | src/Plugins/MailChimp/core/Services/MailChimpService.php:697-716 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Plugins/MailChimp/core/Services/MailChimpService.php:549` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (20 lines × 2) src/EcclesiaCRM/Emails/users/PasswordChangeEmail.php:11 — src/EcclesiaCRM/Emails/users/PasswordChangeEmail.php:11-30 | src/EcclesiaCRM/Emails/users/ResetPasswordEmail.php:11-30 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Emails/users/PasswordChangeEmail.php:11` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (18 lines × 2) · ×5
  • Duplicated block (18 lines × 2) src/EcclesiaCRM/APIControllers/PeopleGroupController.php:499 — src/EcclesiaCRM/APIControllers/PeopleGroupController.php:499-516 | src/EcclesiaCRM/APIControllers/PeopleGroupController.php:531-548 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (18 lines × 2) REDACTED:319 — REDACTED:319-336 | REDACTED:574-591 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:319` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (18 lines × 2) REDACTED:363 — REDACTED:363-380 | REDACTED:597-614 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:363` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (18 lines × 2) src/EcclesiaCRM/Search/PersonGroupManagerSearchRes.php:105 — src/EcclesiaCRM/Search/PersonGroupManagerSearchRes.php:105-122 | src/EcclesiaCRM/Search/PersonPropsSearchRes.php:97-114 — before extracting anything, compare `src/EcclesiaCRM/Search/PersonGroupManagerSearchRes.php` and `src/EcclesiaCRM/Search/PersonPropsSearchRes.php` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 81 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Search/PersonGroupManagerSearchRes.php:105` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (18 lines × 2) src/EcclesiaCRM/Search/PersonVolunteerOpportunitySearch.php:182 — src/EcclesiaCRM/Search/PersonVolunteerOpportunitySearch.php:182-199 | src/EcclesiaCRM/Search/PersonVolunteerOpportunitySearch.php:218-235 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Search/PersonVolunteerOpportunitySearch.php:182` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (8 lines × 3) · ×5
  • Duplicated block (8 lines × 3) src/EcclesiaCRM/APIControllers/PeopleGroupController.php:716 — src/EcclesiaCRM/APIControllers/PeopleGroupController.php:716-723 | src/EcclesiaCRM/APIControllers/PeopleGroupController.php:764-771 | src/EcclesiaCRM/APIControllers/PeopleGroupController.php:786-793 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/PeopleGroupController.php:716` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 3) REDACTED:411 — REDACTED:411-418 | REDACTED:457-464 | REDACTED:479-486 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:411` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 3) src/EcclesiaCRM/MenuBar/MenuBar.php:436 — src/EcclesiaCRM/MenuBar/MenuBar.php:436-443 | src/EcclesiaCRM/MenuBar/MenuBar.php:668-675 | REDACTED:463-470 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Note first that the copies are not typed on the same thing: `Person2group2roleP2g2rQuery` names `EcclesiaCRM\Base\Person2group2roleP2g2rQuery` in one and `EcclesiaCRM\Person2group2roleP2g2rQuery` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (8 lines × 3) src/EcclesiaCRM/model/EcclesiaCRM/Person.php:678 — src/EcclesiaCRM/model/EcclesiaCRM/Person.php:678-685 | src/EcclesiaCRM/model/EcclesiaCRM/Person.php:696-703 | src/EcclesiaCRM/model/EcclesiaCRM/Person.php:714-721 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/EcclesiaCRM/model/EcclesiaCRM/Person.php:704` calls `getLastName` and `src/EcclesiaCRM/model/EcclesiaCRM/Person.php:686` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (8 lines × 3) src/EcclesiaCRM/utils/SabreUtils.php:471 — src/EcclesiaCRM/utils/SabreUtils.php:471-478 | src/EcclesiaCRM/utils/SabreUtils.php:513-520 | src/EcclesiaCRM/utils/SabreUtils.php:553-560 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/utils/SabreUtils.php:471` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (6 lines × 4) · ×5
  • Duplicated block (6 lines × 4) src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:528 — src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:528-533 | src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:667-672 | src/EcclesiaCRM/Service/CalendarService.php:1665-1670 | src/EcclesiaCRM/Service/CalendarService.php:2042-2048 — there are 4 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:528` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/EcclesiaCRM/Service/CalendarService.php:1673` calls `empty` and `src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:535` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (6 lines × 4) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:629 — src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:629-634 | src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:675-680 | src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:734-740 | src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:769-775 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:636` calls `delTree`, `withJson`, `numberOfFiles` and `src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:776` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (6 lines × 4) src/EcclesiaCRM/APIControllers/PeopleGroupController.php:509 — src/EcclesiaCRM/APIControllers/PeopleGroupController.php:509-514 | src/EcclesiaCRM/APIControllers/PeopleGroupController.php:541-546 | src/EcclesiaCRM/APIControllers/PeopleGroupController.php:586-591 | src/EcclesiaCRM/APIControllers/PeopleGroupController.php:621-626 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
  • Duplicated block (6 lines × 4) src/EcclesiaCRM/Reports/PDF_Badge.php:179 — src/EcclesiaCRM/Reports/PDF_Badge.php:179-184 | src/EcclesiaCRM/Reports/PDF_Badge.php:205-210 | src/EcclesiaCRM/Reports/PDF_Badge.php:337-342 | src/EcclesiaCRM/Reports/PDF_Badge.php:363-368 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
  • Duplicated block (6 lines × 4) src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:149 — src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:149-154 | src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:183-188 | src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:212-217 | src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:364-369 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
AC3 · Page structure · Heading level jumps from h3 to h6 · ×4
  • Heading level jumps from h3 to h6 REDACTED:307 — Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one.
  • Heading level jumps from h3 to h6 REDACTED:115 — Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one.
  • Heading level jumps from h3 to h6 src/v2/templates/pastoralcare/pastoralcaredashboard.php:285 — Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one.
  • Heading level jumps from h3 to h6 src/v2/templates/people/lettersandlabels.php:377 — Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 26) · ×4
  • (anonymous) (cyclomatic 26) src/skin/js/calendar/EventsList.js:1 — (anonymous) has cyclomatic complexity 26 (threshold 15). Most of this is not in the body itself: 2 of the 26 points are its own statements and the rest belongs to 42 function items inside it that branch (a function literal at line 228, a function literal at line 452, a function literal at line 214, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
  • (anonymous) (cyclomatic 26) src/skin/js/document.js:9 — (anonymous) has cyclomatic complexity 26 (threshold 15). Most of this is not in the body itself: 1 of the 26 points is its own statement and the rest belongs to 19 function items inside it that branch (a function literal at line 57, DocumentEditorWindow::callback, a function literal at line 12, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
  • (anonymous) (cyclomatic 26) src/skin/js/people/letterandlabels.js:1 — (anonymous) has cyclomatic complexity 26 (threshold 15). Most of this is not in the body itself: 1 of the 26 points is its own statement and the rest belongs to 30 function items inside it that branch (a function literal at line 184, a function literal at line 16, a function literal at line 341, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
  • (anonymous) (cyclomatic 26) src/skin/js/Footer.js:30 — (anonymous) has cyclomatic complexity 26 (threshold 15). Most of this is not in the body itself: 8 of the 26 points are its own statements and the rest belongs to 24 function items inside it that branch (a function literal at line 148, a function literal at line 170, a function literal at line 155, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D31 · IaC & Container Security · Medium IaC · ×4
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D32 · Data Compliance (PII/GDPR) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Edited copy of a member (22 corresponding lines) · ×4
  • Edited copy of a member (22 corresponding lines) REDACTED:117 — REDACTED:117-138 | REDACTED:294-329 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (22 corresponding lines) src/EcclesiaCRM/APIControllers/DocumentDocumentController.php:36 — src/EcclesiaCRM/APIControllers/DocumentDocumentController.php:36-57 | src/EcclesiaCRM/APIControllers/DocumentDocumentController.php:130-152 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (22 corresponding lines) src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:799 — src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:799-820 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:874-900 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (22 corresponding lines) src/EcclesiaCRM/VIEWControllers/VIEWPastoralCareController.php:168 — src/EcclesiaCRM/VIEWControllers/VIEWPastoralCareController.php:168-189 | src/EcclesiaCRM/VIEWControllers/VIEWPastoralCareController.php:540-566 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (13 corresponding lines) · ×4
  • Edited copy of a member (13 corresponding lines) src/EcclesiaCRM/Service/FinancialService.php:521 — src/EcclesiaCRM/Service/FinancialService.php:521-533 | src/EcclesiaCRM/model/EcclesiaCRM/Deposit.php:395-407 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (13 corresponding lines) src/EcclesiaCRM/Service/PastoralCareService.php:605 — src/EcclesiaCRM/Service/PastoralCareService.php:605-617 | src/EcclesiaCRM/Service/PastoralCareService.php:621-633 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (13 corresponding lines) src/EcclesiaCRM/APIControllers/DocumentDocumentController.php:106 — src/EcclesiaCRM/APIControllers/DocumentDocumentController.php:106-126 | src/EcclesiaCRM/APIControllers/DocumentDocumentController.php:156-168 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (13 corresponding lines) src/EcclesiaCRM/dto/Cart.php:102 — src/EcclesiaCRM/dto/Cart.php:102-114 | src/EcclesiaCRM/dto/Cart.php:120-132 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (12 corresponding lines) · ×4
  • Edited copy of a member (12 corresponding lines) src/EcclesiaCRM/APIControllers/PastoralCareController.php:231 — src/EcclesiaCRM/APIControllers/PastoralCareController.php:231-242 | src/EcclesiaCRM/APIControllers/PastoralCareController.php:362-373 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (12 corresponding lines) src/EcclesiaCRM/APIControllers/PeopleGroupController.php:205 — src/EcclesiaCRM/APIControllers/PeopleGroupController.php:205-216 | src/EcclesiaCRM/APIControllers/VolunteerOpportunityController.php:233-246 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (12 corresponding lines) src/EcclesiaCRM/APIControllers/PluginsController.php:75 — src/EcclesiaCRM/APIControllers/PluginsController.php:75-86 | src/EcclesiaCRM/APIControllers/PluginsController.php:91-102 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (12 corresponding lines) src/Plugins/NewsDashboard/core/APIControllers/NewsDashboardController.php:119 — src/Plugins/NewsDashboard/core/APIControllers/NewsDashboardController.php:119-132 | src/Plugins/NewsDashboard/core/APIControllers/NewsDashboardController.php:137-148 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (14 corresponding lines) · ×4
  • Edited copy of a member (14 corresponding lines) src/EcclesiaCRM/APIControllers/DocumentCollaboraController.php:386 — src/EcclesiaCRM/APIControllers/DocumentCollaboraController.php:386-400 | src/EcclesiaCRM/APIControllers/DocumentCollaboraController.php:405-418 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (14 corresponding lines) REDACTED:258 — REDACTED:258-277 | REDACTED:1403-1416 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (14 corresponding lines) src/EcclesiaCRM/APIControllers/FundraiserController.php:332 — src/EcclesiaCRM/APIControllers/FundraiserController.php:332-347 | src/EcclesiaCRM/APIControllers/FundraiserController.php:429-442 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (14 corresponding lines) src/EcclesiaCRM/APIControllers/CalendarV2Controller.php:468 — src/EcclesiaCRM/APIControllers/CalendarV2Controller.php:468-482 | src/EcclesiaCRM/APIControllers/CalendarV2Controller.php:718-731 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (16 corresponding lines) · ×4
  • Edited copy of a member (16 corresponding lines) src/EcclesiaCRM/APIControllers/PastoralCareController.php:127 — src/EcclesiaCRM/APIControllers/PastoralCareController.php:127-142 | src/EcclesiaCRM/APIControllers/PastoralCareController.php:147-162 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (16 corresponding lines) src/EcclesiaCRM/dto/Cart.php:388 — src/EcclesiaCRM/dto/Cart.php:388-403 | src/EcclesiaCRM/dto/Cart.php:408-423 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (16 corresponding lines) src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:350 — src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:350-366 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:498-513 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (16 corresponding lines) src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:207 — src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:207-222 | src/EcclesiaCRM/dto/Cart.php:489-507 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (17 corresponding lines) · ×4
  • Edited copy of a member (17 corresponding lines) src/EcclesiaCRM/model/EcclesiaCRM/Group.php:46 — src/EcclesiaCRM/model/EcclesiaCRM/Group.php:46-63 | src/EcclesiaCRM/model/EcclesiaCRM/VolunteerOpportunity.php:26-42 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (17 corresponding lines) src/EcclesiaCRM/APIControllers/SystemGDRPController.php:158 — src/EcclesiaCRM/APIControllers/SystemGDRPController.php:158-174 | src/EcclesiaCRM/APIControllers/SystemGDRPController.php:216-232 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (17 corresponding lines) src/EcclesiaCRM/Service/GroupService.php:355 — src/EcclesiaCRM/Service/GroupService.php:355-377 | src/EcclesiaCRM/Service/GroupService.php:382-398 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (17 corresponding lines) src/EcclesiaCRM/Synchronize/ClassificationDashboardItem.php:15 — src/EcclesiaCRM/Synchronize/ClassificationDashboardItem.php:15-31 | src/EcclesiaCRM/Synchronize/PersonDashboardItem.php:103-122 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 16+ corresponding lines) · ×4
  • Edited copies of one member (3 members, 16+ corresponding lines) src/EcclesiaCRM/APIControllers/UserRoleController.php:66 — src/EcclesiaCRM/APIControllers/UserRoleController.php:66-85 | src/EcclesiaCRM/APIControllers/UserRoleController.php:90-106 | src/EcclesiaCRM/APIControllers/UserRoleController.php:122-137 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 16 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 16+ corresponding lines) src/EcclesiaCRM/Service/PastoralCareService.php:214 — src/EcclesiaCRM/Service/PastoralCareService.php:214-229 | src/EcclesiaCRM/Service/PastoralCareService.php:234-252 | src/EcclesiaCRM/Service/PastoralCareService.php:257-275 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 16 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 16+ corresponding lines) src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:121 — src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:121-136 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:141-157 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:272-289 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 16 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 16+ corresponding lines) src/EcclesiaCRM/APIControllers/VolunteerOpportunityController.php:413 — src/EcclesiaCRM/APIControllers/VolunteerOpportunityController.php:413-431 | src/EcclesiaCRM/APIControllers/VolunteerOpportunityController.php:436-451 | src/EcclesiaCRM/APIControllers/VolunteerOpportunityController.php:456-473 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 16 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 13+ corresponding lines) · ×4
  • Edited copies of one member (4 members, 13+ corresponding lines) src/EcclesiaCRM/APIControllers/VolunteerOpportunityController.php:251 — src/EcclesiaCRM/APIControllers/VolunteerOpportunityController.php:251-265 | src/EcclesiaCRM/APIControllers/VolunteerOpportunityController.php:301-317 | src/EcclesiaCRM/APIControllers/VolunteerOpportunityController.php:322-334 | src/EcclesiaCRM/APIControllers/VolunteerOpportunityController.php:339-351 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
  • Edited copies of one member (4 members, 13+ corresponding lines) src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:963 — src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:963-978 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:870-882 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:888-900 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:972-987 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
  • Edited copies of one member (4 members, 13+ corresponding lines) src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:926 — src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:926-941 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:836-848 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:854-866 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:935-950 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
  • Edited copies of one member (4 members, 13+ corresponding lines) src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:838 — src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:838-853 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:756-768 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:774-786 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:851-866 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (4 corresponding lines) · ×4
  • Edited copy of a member (4 corresponding lines) src/EcclesiaCRM/APIControllers/PeopleGroupController.php:405 — src/EcclesiaCRM/APIControllers/PeopleGroupController.php:405-408 | src/EcclesiaCRM/APIControllers/PeopleGroupController.php:412-416 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (4 corresponding lines) src/EcclesiaCRM/model/EcclesiaCRM/Family.php:381 — src/EcclesiaCRM/model/EcclesiaCRM/Family.php:381-384 | src/EcclesiaCRM/model/EcclesiaCRM/Person.php:585-588 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (4 corresponding lines) src/EcclesiaCRM/MICRFunctions.php:50 — src/EcclesiaCRM/MICRFunctions.php:50-53 | src/EcclesiaCRM/utils/MICRReader.php:52-55 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (4 corresponding lines) src/EcclesiaCRM/MICRFunctions.php:42 — src/EcclesiaCRM/MICRFunctions.php:42-45 | src/EcclesiaCRM/utils/MICRReader.php:44-47 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (24 lines × 2) · ×4
  • Duplicated block (24 lines × 2) REDACTED:204 — REDACTED:204-227 | src/EcclesiaCRM/VIEWControllers/BackupRestore/VIEWBackupController.php:45-68 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (24 lines × 2) src/EcclesiaCRM/Service/CalendarService.php:209 — src/EcclesiaCRM/Service/CalendarService.php:209-232 | src/EcclesiaCRM/Service/CalendarService.php:941-964 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (24 lines × 2) src/EcclesiaCRM/Service/CalendarService.php:1930 — src/EcclesiaCRM/Service/CalendarService.php:1930-1953 | src/EcclesiaCRM/Service/CalendarService.php:1983-2006 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (24 lines × 2) src/EcclesiaCRM/model/EcclesiaCRM/Family.php:289 — src/EcclesiaCRM/model/EcclesiaCRM/Family.php:289-312 | src/EcclesiaCRM/model/EcclesiaCRM/Person.php:406-429 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (21 lines × 2) · ×4
  • Duplicated block (21 lines × 2) src/EcclesiaCRM/Reports/CSV_RealAttendance.php:140 — src/EcclesiaCRM/Reports/CSV_RealAttendance.php:140-160 | src/EcclesiaCRM/Reports/PDF_RealAttendance.php:144-164 — before extracting anything, compare `src/EcclesiaCRM/Reports/CSV_RealAttendance.php` and `src/EcclesiaCRM/Reports/PDF_RealAttendance.php` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Reports/CSV_RealAttendance.php:140` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (21 lines × 2) src/EcclesiaCRM/Reports/PDF_Attendance.php:121 — src/EcclesiaCRM/Reports/PDF_Attendance.php:121-141 | src/EcclesiaCRM/Reports/PDF_Attendance.php:433-453 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Reports/PDF_Attendance.php:121` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (21 lines × 2) src/EcclesiaCRM/Service/CalendarService.php:474 — src/EcclesiaCRM/Service/CalendarService.php:474-494 | src/EcclesiaCRM/sabre/CalDav/VObjectExtract.php:145-165 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Service/CalendarService.php:474` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (21 lines × 2) src/EcclesiaCRM/sabre/CalDav/CalDavPDO.php:490 — src/EcclesiaCRM/sabre/CalDav/CalDavPDO.php:490-510 | src/EcclesiaCRM/sabre/CalDav/CalDavPDO.php:517-537 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (19–20 lines × 2) · ×4
  • Duplicated block (19–20 lines × 2) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:841 — src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:841-860 | src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:915-933 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:841` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (19–20 lines × 2) src/EcclesiaCRM/Reports/CSV_RealAttendance.php:118 — src/EcclesiaCRM/Reports/CSV_RealAttendance.php:118-137 | src/EcclesiaCRM/Reports/PDF_RealAttendance.php:123-141 — before extracting anything, compare `src/EcclesiaCRM/Reports/CSV_RealAttendance.php` and `src/EcclesiaCRM/Reports/PDF_RealAttendance.php` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (19–20 lines × 2) src/EcclesiaCRM/Search/FamilyPastoralCareSearchRes.php:57 — src/EcclesiaCRM/Search/FamilyPastoralCareSearchRes.php:57-75 | src/EcclesiaCRM/Search/PersonPastoralCareSearchRes.php:62-81 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (19–20 lines × 2) src/tools/integrity-check.php:47 — src/tools/integrity-check.php:47-66 | src/tools/integrity-check.php:130-148 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/tools/integrity-check.php:47` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (17 lines × 2) · ×4
  • Duplicated block (17 lines × 2) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:213 — src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:213-229 | src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:352-368 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (17 lines × 2) src/EcclesiaCRM/MICRFunctions.php:84 — src/EcclesiaCRM/MICRFunctions.php:84-100 | src/EcclesiaCRM/utils/MICRReader.php:86-102 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (17 lines × 2) src/EcclesiaCRM/Reports/PDF_GroupDirectory.php:80 — src/EcclesiaCRM/Reports/PDF_GroupDirectory.php:80-96 | src/Reports/EnvelopeReport.php:76-92 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (17 lines × 2) REDACTED:399 — REDACTED:399-415 | REDACTED:960-976 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:399` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (8–9 lines × 2) · ×4
  • Duplicated block (8–9 lines × 2) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:734 — src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:734-741 | src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:769-777 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:734` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8–9 lines × 2) src/EcclesiaCRM/APIControllers/SystemGDRPController.php:87 — src/EcclesiaCRM/APIControllers/SystemGDRPController.php:87-95 | src/EcclesiaCRM/APIControllers/SystemGDRPController.php:115-122 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/SystemGDRPController.php:87` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8–9 lines × 2) src/EcclesiaCRM/VIEWControllers/People/VIEWFamilyListController.php:56 — src/EcclesiaCRM/VIEWControllers/People/VIEWFamilyListController.php:56-63 | src/EcclesiaCRM/VIEWControllers/VIEWDashboardController.php:75-83 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/VIEWControllers/People/VIEWFamilyListController.php:56` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8–9 lines × 2) src/EcclesiaCRM/model/EcclesiaCRM/User.php:842 — src/EcclesiaCRM/model/EcclesiaCRM/User.php:842-849 | src/EcclesiaCRM/model/EcclesiaCRM/User.php:867-875 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (5 lines × 3) · ×4
  • Duplicated block (5 lines × 3) src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:483 — src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:483-487 | src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:582-587 | src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:721-726 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:582` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (5 lines × 3) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:733 — src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:733-738 | src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:768-773 | src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:914-918 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:733` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 3) src/EcclesiaCRM/Service/ConfirmReportService.php:52 — src/EcclesiaCRM/Service/ConfirmReportService.php:52-60 | src/EcclesiaCRM/Service/ConfirmReportService.php:482-490 | src/EcclesiaCRM/Service/ConfirmReportService.php:560-564 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Service/ConfirmReportService.php:52` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 3) src/EcclesiaCRM/model/EcclesiaCRM/EventAttend.php:22 — src/EcclesiaCRM/model/EcclesiaCRM/EventAttend.php:22-26 | src/EcclesiaCRM/model/EcclesiaCRM/EventAttend.php:31-35 | src/EcclesiaCRM/model/EcclesiaCRM/EventAttend.php:40-44 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
AC4 · Keyboard semantics · Positive tabindex (4) · ×3
  • Positive tabindex (4) src/v2/templates/calendar/checkin.php:206 — A positive tabindex forces a manual tab order that fights the DOM and is fragile. Use tabindex="0" (or restructure the DOM).
  • Positive tabindex (4) src/v2/templates/calendar/checkin.php:299 — A positive tabindex forces a manual tab order that fights the DOM and is fragile. Use tabindex="0" (or restructure the DOM).
  • Positive tabindex (4) src/v2/templates/calendar/checkin.php:305 — A positive tabindex forces a manual tab order that fights the DOM and is fragile. Use tabindex="0" (or restructure the DOM).
AC4 · Keyboard semantics · Link used as a button (placeholder href) · ×3
  • Link used as a button (placeholder href) src/v2/templates/deposit/electronicPaymentList.php:187 — An <a href="#"> (or javascript:) with a click handler is a button dressed as a link — it announces the wrong role and stops working without JS. Use a <button> for an action.
  • Link used as a button (placeholder href) REDACTED:401 — An <a href="#"> (or javascript:) with a click handler is a button dressed as a link — it announces the wrong role and stops working without JS. Use a <button> for an action.
  • Link used as a button (placeholder href) src/v2/templates/group/groupview.php:196 — An <a href="#"> (or javascript:) with a click handler is a button dressed as a link — it announces the wrong role and stops working without JS. Use a <button> for an action.
AC6 · Visual & motion safety · Low contrast colour pair in CSS (3.9 · ×3
  • Low contrast colour pair in CSS (3.9:1) src/v2/templates/sidebar/systemsettings.php:112 — `.dark-mode .settings-tab-link.active` sets color: #f8fafc on background-color: #0284c7 — 3.9:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
  • Low contrast colour pair in CSS (3.9:1) src/skin/scss/_print.scss:13 — `.print-table-header` sets color: white on background-color: gray — 3.9:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
  • Low contrast colour pair in CSS (3.9:1) src/skin/scss/_upgrade_system.scss:263 — `.upgrade-step-card.is-locked .step-status` sets color: #64748b on background-color: #e2e8f0 — 3.9:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 17) · ×3
  • (anonymous) (cyclomatic 17) REDACTED:7 — (anonymous) has cyclomatic complexity 17 (threshold 15). Most of this is not in the body itself: 1 of the 17 points is its own statement and the rest belongs to 39 function items inside it that branch (a function literal at line 125, a function literal at line 160, a function literal at line 197, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
  • (anonymous) (cyclomatic 17) src/skin/js/user/UserEditor.js:46 — (anonymous) has cyclomatic complexity 17 (threshold 15). Most of this is not in the body itself: 1 of the 17 points is its own statement and the rest belongs to 22 function items inside it that branch (a function literal at line 313, a function literal at line 221, a function literal at line 248, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
  • (anonymous) (cyclomatic 17) src/Plugins/NewsDashboard/skin/js/NewsDashboard.js:1 — (anonymous) has cyclomatic complexity 17 (threshold 15). Most of this is not in the body itself: 1 of the 17 points is its own statement and the rest belongs to 16 function items inside it that branch (a function literal at line 181, addElementsToNewsDashboardList, NewsEditorWindow::callback, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · (anonymous) · ×3
  • (anonymous)::eventDidMount (cognitive 31) src/skin/js/calendar/CalendarV2.js:368 — (anonymous)::eventDidMount has cognitive complexity 31 (threshold 15). Drivers by points: if/else 13 (16 pts), boolean chains 15 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
  • (anonymous)::render (cognitive 20) src/skin/js/filemanager.js:283 — (anonymous)::render has cognitive complexity 20 (threshold 15). Drivers by points: ternaries 7 (14 pts), boolean chains 3, if/else 3 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
  • (anonymous)::reloadLabel (cognitive 16) src/skin/js/BadgeSticker.js:12 — (anonymous)::reloadLabel has cognitive complexity 16 (threshold 15). Drivers by points: boolean chains 11, if/else 3, ternaries 1 (2 pts) (nesting depth added 1). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D29 · Static Analysis (SAST) · REDACTED · ×3
  • REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Members sharing a duplicated core (6 members, 50+ identical tokens) · ×3
  • Members sharing a duplicated core (6 members, 50+ identical tokens) REDACTED:70 — REDACTED:70-84 | src/EcclesiaCRM/APIControllers/PeopleGroupController.php:117-130 | REDACTED:325-343 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:346-403 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:408-441 | REDACTED:315-788 — These 6 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 6 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 6 times.
  • Members sharing a duplicated core (6 members, 50+ identical tokens) src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:346 — src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:346-403 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:408-441 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:446-489 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:494-513 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:518-561 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:566-585 — These 6 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 6 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 6 times.
  • Members sharing a duplicated core (6 members, 50+ identical tokens) src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:264 — src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:264-280 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:310-326 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:330-346 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:371-394 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:472-493 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:776-795 — These 6 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 6 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 6 times.
D4 · Code Duplication · Edited copies of one member (4 members, 19+ corresponding lines) · ×3
  • Edited copies of one member (4 members, 19+ corresponding lines) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:1140 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:1140-1164 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:1008-1026 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:1156-1180 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:1107-1128 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 19 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
  • Edited copies of one member (4 members, 19+ corresponding lines) REDACTED:422 — REDACTED:422-440 | REDACTED:444-462 | src/EcclesiaCRM/APIControllers/PeopleGroupController.php:764-782 | src/EcclesiaCRM/APIControllers/PeopleGroupController.php:786-804 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 19 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
  • Edited copies of one member (4 members, 19+ corresponding lines) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:998 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:998-1022 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:880-898 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:1006-1030 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:968-989 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 19 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 10+ corresponding lines) · ×3
  • Edited copies of one member (3 members, 10+ corresponding lines) src/EcclesiaCRM/VIEWControllers/People/VIEWFamilyListController.php:37 — src/EcclesiaCRM/VIEWControllers/People/VIEWFamilyListController.php:37-50 | REDACTED:1376-1385 | src/EcclesiaCRM/VIEWControllers/People/VIEWPersonListController.php:36-48 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 10 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 10+ corresponding lines) src/EcclesiaCRM/sabre/CardDav/CardDavPDO.php:578 — src/EcclesiaCRM/sabre/CardDav/CardDavPDO.php:578-590 | src/EcclesiaCRM/sabre/CardDav/CardDavPDO.php:615-625 | src/EcclesiaCRM/sabre/CardDav/CardDavPDO.php:643-652 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 10 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 10+ corresponding lines) src/EcclesiaCRM/dto/Cart.php:193 — src/EcclesiaCRM/dto/Cart.php:193-204 | src/EcclesiaCRM/dto/Cart.php:209-218 | src/EcclesiaCRM/dto/Cart.php:288-297 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 10 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 14+ corresponding lines) · ×3
  • Edited copies of one member (3 members, 14+ corresponding lines) src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:393 — src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:393-406 | src/EcclesiaCRM/VIEWControllers/VIEWFundraiserController.php:211-228 | src/EcclesiaCRM/VIEWControllers/VIEWFundraiserController.php:264-281 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 14 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 14+ corresponding lines) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:519 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:519-532 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:466-479 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:496-509 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 14 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 14+ corresponding lines) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:605 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:605-622 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:511-524 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:611-624 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 14 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 7+ corresponding lines) · ×3
  • Edited copies of one member (3 members, 7+ corresponding lines) src/EcclesiaCRM/utils/OutputUtils.php:19 — src/EcclesiaCRM/utils/OutputUtils.php:19-25 | src/EcclesiaCRM/utils/OutputUtils.php:30-37 | src/EcclesiaCRM/utils/OutputUtils.php:42-54 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 7 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 7+ corresponding lines) REDACTED:86 — REDACTED:86-92 | REDACTED:97-103 | REDACTED:83-92 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 7 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 7+ corresponding lines) src/EcclesiaCRM/VIEWControllers/VIEWFundraiserController.php:45 — src/EcclesiaCRM/VIEWControllers/VIEWFundraiserController.php:45-51 | src/EcclesiaCRM/VIEWControllers/VIEWFundraiserController.php:92-98 | src/EcclesiaCRM/VIEWControllers/VIEWSundaySchoolController.php:79-87 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 7 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (11 corresponding lines) · ×3
  • Edited copy of a member (11 corresponding lines) src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:549 — src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:549-559 | src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:564-575 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (11 corresponding lines) src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:113 — src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:113-126 | src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:131-141 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (11 corresponding lines) src/EcclesiaCRM/dto/Cart.php:32 — src/EcclesiaCRM/dto/Cart.php:32-42 | src/EcclesiaCRM/dto/Cart.php:47-57 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (10 corresponding lines) · ×3
  • Edited copy of a member (10 corresponding lines) REDACTED:187 — REDACTED:187-196 | REDACTED:351-360 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) src/EcclesiaCRM/APIControllers/KiosksController.php:140 — src/EcclesiaCRM/APIControllers/KiosksController.php:140-149 | src/EcclesiaCRM/APIControllers/KiosksController.php:154-163 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:1060 — src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:1060-1069 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:1078-1088 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 6+ corresponding lines) · ×3
  • Edited copies of one member (3 members, 6+ corresponding lines) src/EcclesiaCRM/sabre/EcclesiaCRMServer.php:58 — src/EcclesiaCRM/sabre/EcclesiaCRMServer.php:58-63 | src/EcclesiaCRM/sabre/EcclesiaCRMServer.php:67-72 | src/EcclesiaCRM/sabre/EcclesiaCRMServer.php:76-81 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 6 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 6+ corresponding lines) src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:1120 — src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:1120-1126 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:1021-1026 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:1039-1044 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 6 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 6+ corresponding lines) src/EcclesiaCRM/Emails/verify/FamilyVerificationEmail.php:39 — src/EcclesiaCRM/Emails/verify/FamilyVerificationEmail.php:39-45 | src/EcclesiaCRM/Emails/verify/FamilyVerificationValidation.php:37-42 | src/EcclesiaCRM/Emails/verify/PersonVerificationValidation.php:37-42 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 6 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Duplicated block (13–14 lines × 2) · ×3
  • Duplicated block (13–14 lines × 2) src/EcclesiaCRM/APIControllers/SystemGDRPController.php:101 — src/EcclesiaCRM/APIControllers/SystemGDRPController.php:101-113 | src/EcclesiaCRM/APIControllers/SystemGDRPController.php:137-150 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/SystemGDRPController.php:101` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (13–14 lines × 2) src/EcclesiaCRM/Reports/CSV_RealAttendance.php:69 — src/EcclesiaCRM/Reports/CSV_RealAttendance.php:69-82 | src/EcclesiaCRM/Reports/PDF_RealAttendance.php:68-80 — before extracting anything, compare `src/EcclesiaCRM/Reports/CSV_RealAttendance.php` and `src/EcclesiaCRM/Reports/PDF_RealAttendance.php` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Reports/CSV_RealAttendance.php:69` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13–14 lines × 2) src/EcclesiaCRM/utils/OutputUtils.php:725 — src/EcclesiaCRM/utils/OutputUtils.php:725-737 | src/EcclesiaCRM/utils/OutputUtils.php:739-752 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/utils/OutputUtils.php:739` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
AC3 · Page structure · Page without a main landmark · ×2
  • Page without a main landmark src/skin/js/ckeditor/ckeditorextension.js:563 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark src/skin/js/edrive/CollaboraEditor.js:34 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
AC4 · Keyboard semantics · Positive tabindex (888) · ×2
  • Positive tabindex (888) src/ident/templates/verify/verify-family-info.php:83 — A positive tabindex forces a manual tab order that fights the DOM and is fragile. Use tabindex="0" (or restructure the DOM).
  • Positive tabindex (888) src/ident/templates/verify/verify-person-info.php:76 — A positive tabindex forces a manual tab order that fights the DOM and is fragile. Use tabindex="0" (or restructure the DOM).
AC4 · Keyboard semantics · Positive tabindex (100) · ×2
  • Positive tabindex (100) REDACTED:247 — A positive tabindex forces a manual tab order that fights the DOM and is fragile. Use tabindex="0" (or restructure the DOM).
  • Positive tabindex (100) REDACTED:258 — A positive tabindex forces a manual tab order that fights the DOM and is fragile. Use tabindex="0" (or restructure the DOM).
AC6 · Visual & motion safety · Low contrast colour pair in CSS (2.4 · ×2
  • Low contrast colour pair in CSS (2.4:1) src/ident/templates/verify/verify-family-info.php:129 — `.btn-sm` sets color: white on background-color: #62b1d0 — 2.4:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
  • Low contrast colour pair in CSS (2.4:1) src/ident/templates/verify/verify-person-info.php:122 — `.btn-sm` sets color: white on background-color: #62b1d0 — 2.4:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
AC6 · Visual & motion safety · Low contrast colour pair in CSS (3.3 · ×2
  • Low contrast colour pair in CSS (3.3:1) src/skin/scss/_adminLTE_update.scss:681 — `.bg-gradient-blue` sets color: rgb(255, 255, 255) on background-color: linear-gradient(to top right, rgb(38, 143, 255), rgb(74, 106, 140)) repeat-x rgb(0, 123, 255) — 3.3:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
  • Low contrast colour pair in CSS (3.3:1) src/skin/scss/_adminLTE_update.scss:701 — `.bg-gradient-blue` sets color: rgb(255, 255, 255) on background-color: linear-gradient(to top right, rgb(38, 143, 255), rgb(74, 106, 140)) repeat-x rgb(0, 123, 255) — 3.3:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
AC6 · Visual & motion safety · Low contrast colour pair in CSS (4.1 · ×2
  • Low contrast colour pair in CSS (4.1:1) src/skin/scss/_fileManager.scss:95 — `.edrive-upload-icon` sets color: #287c98 on background-color: #e2f1f7 — 4.1:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
  • Low contrast colour pair in CSS (4.1:1) src/skin/scss/_setup.scss:119 — `.wizard > .steps .done .number` sets color: #1e7e34 on background-color: #d4edda — 4.1:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
AC6 · Visual & motion safety · Low contrast colour pair in CSS (4.0 · ×2
  • Low contrast colour pair in CSS (4.0:1) src/skin/scss/_setup.scss:99 — `.wizard > .steps .current a, .wizard > .steps .current a:hover, .wizard > .steps .current a:active` sets color: #fff on background-color: #007bff — 4.0:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
  • Low contrast colour pair in CSS (4.0:1) src/skin/scss/_setup.scss:185 — `.wizard > .actions a.btn-primary, .wizard > .actions a.btn-primary:hover, .wizard > .actions a.btn-primary:active, .wizard > .actions a.btn-primary:focus` sets color: #fff on background-color: #007bff — 4.0:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
AC6 · Visual & motion safety · Low contrast colour pair in CSS (2.6 · ×2
  • Low contrast colour pair in CSS (2.6:1) src/skin/scss/_upgrade_system.scss:113 — `.upgrade-timeline-badge` sets color: #94a3b8 on background-color: #fff — 2.6:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
  • Low contrast colour pair in CSS (2.6:1) src/skin/scss/_upgrade_system.scss:256 — `.upgrade-step-card.is-locked .step-icon, .upgrade-timeline-step.is-locked .upgrade-timeline-badge` sets color: #94a3b8 on background-color: #fff — 2.6:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 23) · ×2
  • (anonymous) (cyclomatic 23) src/skin/js/group/GroupEditor.js:1 — (anonymous) has cyclomatic complexity 23 (threshold 15). Most of this is not in the body itself: 1 of the 23 points is its own statement and the rest belongs to 24 function items inside it that branch (render, render, a function literal at line 68, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
  • (anonymous) (cyclomatic 23) src/Plugins/MailChimp/skin/js/settings.js:1 — (anonymous) has cyclomatic complexity 23 (threshold 15). Most of this is not in the body itself: 5 of the 23 points are its own statements and the rest belongs to 14 function items inside it that branch (getPayload, updateDirtyState, a function literal at line 90, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 18) · ×2
  • (anonymous) (cyclomatic 18) src/skin/js/fundraiser/fundraiserEditor.js:1 — (anonymous) has cyclomatic complexity 18 (threshold 15). Most of this is not in the body itself: 1 of the 18 points is its own statement and the rest belongs to 20 function items inside it that branch (render, cleanPictureUrl, render, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
  • (anonymous) (cyclomatic 18) src/skin/js/people/ConfirmReportCheck.js:1 — (anonymous) has cyclomatic complexity 18 (threshold 15). Most of this is not in the body itself: 1 of the 18 points is its own statement and the rest belongs to 7 function items inside it that branch (a function literal at line 92, a function literal at line 60, render, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · (anonymous) (cognitive 33) · ×2
  • (anonymous) (cognitive 33) src/Plugins/ToDoListDashboard/skin/js/ToDoListDashboard.js:1 — (anonymous) has cognitive complexity 33 (threshold 15). Drivers by points: if/else 15 (21 pts), loops 4 (7 pts), ternaries 3 (5 pts) (nesting depth added 11). Most of this is not in the body itself: 2 of the 33 points are its own statements and the rest belongs to 38 function items inside it that branch (a function literal at line 202, addElementsToDoList, a function literal at line 155, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
  • (anonymous) (cognitive 33) src/skin/js/event/Checkin.js:12 — (anonymous) has cognitive complexity 33 (threshold 15). Drivers by points: if/else 18 (21 pts), ternaries 7 (8 pts), boolean chains 4 (nesting depth added 4). Most of this is not in the body itself: 1 of the 33 points is its own statement and the rest belongs to 49 function items inside it that branch (a function literal at line 24, renderAttendanceButton, setToggleButtonState, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · (anonymous) (cognitive 32) · ×2
  • (anonymous) (cognitive 32) src/skin/js/people/letterandlabels.js:1 — (anonymous) has cognitive complexity 32 (threshold 15). Drivers by points: if/else 20 (28 pts), boolean chains 2, error handling 1, match/switch 1 (nesting depth added 8). None of this is in the body itself: all 32 points belong to 30 function items inside it that branch (a function literal at line 184, a function literal at line 16, a function literal at line 216, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
  • (anonymous) (cognitive 32) src/skin/js/people/PeopleMailServices.js:1 — (anonymous) has cognitive complexity 32 (threshold 15). Drivers by points: if/else 17 (32 pts) (nesting depth added 15). Most of this is not in the body itself: 3 of the 32 points are its own statements and the rest belongs to 3 function literals inside it that branch (lines 8, 58, 33). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D2 · Cognitive Complexity · (anonymous) (cognitive 24) · ×2
  • (anonymous) (cognitive 24) src/skin/js/people/AddRemoveCart.js:1 — (anonymous) has cognitive complexity 24 (threshold 15). Drivers by points: if/else 14 (20 pts), boolean chains 3, ternaries 1 (nesting depth added 6). None of this is in the body itself: all 24 points belong to 17 function items inside it that branch (a function literal at line 28, a function literal at line 51, a function literal at line 79, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
  • (anonymous) (cognitive 24) src/Plugins/MailChimp/skin/js/settings.js:1 — (anonymous) has cognitive complexity 24 (threshold 15). Drivers by points: if/else 7 (8 pts), ternaries 5 (6 pts), boolean chains 5, other 5 (nesting depth added 2). Most of this is not in the body itself: 4 of the 24 points are its own statements and the rest belongs to 14 function items inside it that branch (getPayload, updateDirtyState, a function literal at line 90, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · (anonymous) (cognitive 23) · ×2
  • (anonymous) (cognitive 23) src/skin/js/user/UserEditor.js:46 — (anonymous) has cognitive complexity 23 (threshold 15). Drivers by points: if/else 16 (18 pts), ternaries 2 (3 pts), boolean chains 2 (nesting depth added 3). None of this is in the body itself: all 23 points belong to 22 function items inside it that branch (a function literal at line 221, a function literal at line 248, a function literal at line 313, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
  • (anonymous) (cognitive 23) src/skin/js/backup/backup.js:1 — (anonymous) has cognitive complexity 23 (threshold 15). Drivers by points: if/else 15 (21 pts), error handling 1 (2 pts) (nesting depth added 7). Most of this is not in the body itself: 2 of the 23 points are its own statements and the rest belongs to 15 function items inside it that branch (doBackup, a function literal at line 118, a function literal at line 30, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · (anonymous) (cognitive 22) · ×2
  • (anonymous) (cognitive 22) src/skin/js/people/ConfirmReportCheck.js:1 — (anonymous) has cognitive complexity 22 (threshold 15). Drivers by points: if/else 9 (11 pts), boolean chains 7, ternaries 2 (4 pts) (nesting depth added 4). None of this is in the body itself: all 22 points belong to 7 function items inside it that branch (a function literal at line 92, render, render, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
  • (anonymous) (cognitive 22) src/skin/js/fundraiser/batchWinnerEntry.js:1 — (anonymous) has cognitive complexity 22 (threshold 15). Drivers by points: if/else 9 (14 pts), boolean chains 7, loops 1 (nesting depth added 5). None of this is in the body itself: all 22 points belong to 3 function literals inside it that branch (lines 36, 6, 28). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D2 · Cognitive Complexity · (anonymous) (cognitive 21) · ×2
  • (anonymous) (cognitive 21) src/skin/js/system/KioskManager.js:1 — (anonymous) has cognitive complexity 21 (threshold 15). Drivers by points: if/else 14 (17 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 4). None of this is in the body itself: all 21 points belong to 17 function items inside it that branch (renderKioskAssignment, a function literal at line 33, (anonymous)::data, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
  • (anonymous) (cognitive 21) src/skin/js/pastoralcare/PastoralCareMembersList.js:1 — (anonymous) has cognitive complexity 21 (threshold 15). Drivers by points: boolean chains 13, if/else 7, ternaries 1. None of this is in the body itself: all 21 points belong to 18 function items inside it that branch (buildAddress, toPhoneLink, buildIdentityLink, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · (anonymous) (cognitive 20) · ×2
  • (anonymous) (cognitive 20) REDACTED:7 — (anonymous) has cognitive complexity 20 (threshold 15). Drivers by points: if/else 14 (17 pts), boolean chains 3 (nesting depth added 3). None of this is in the body itself: all 20 points belong to 39 function items inside it that branch (a function literal at line 125, a function literal at line 160, a function literal at line 197, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
  • (anonymous) (cognitive 20) src/skin/js/fundraiser/fundraiserEditor.js:1 — (anonymous) has cognitive complexity 20 (threshold 15). Drivers by points: if/else 12 (13 pts), ternaries 3 (5 pts), boolean chains 2 (nesting depth added 3). None of this is in the body itself: all 20 points belong to 20 function items inside it that branch (render, render, cleanPictureUrl, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D4 · Code Duplication · Edited copy of a member (31 corresponding lines) · ×2
  • Edited copy of a member (31 corresponding lines) src/EcclesiaCRM/model/EcclesiaCRM/Group.php:249 — src/EcclesiaCRM/model/EcclesiaCRM/Group.php:249-283 | src/EcclesiaCRM/model/EcclesiaCRM/VolunteerOpportunity.php:93-128 — These two members are one piece of code written twice and then edited apart: 31 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (31 corresponding lines) src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:580 — src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:580-610 | src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:615-645 — These two members are one piece of code written twice and then edited apart: 31 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (24 corresponding lines) · ×2
  • Edited copy of a member (24 corresponding lines) REDACTED:200 — REDACTED:200-235 | src/EcclesiaCRM/VIEWControllers/BackupRestore/VIEWBackupController.php:45-84 — These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (24 corresponding lines) src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:227 — src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:227-253 | src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:258-281 — These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (28 corresponding lines) · ×2
  • Edited copy of a member (28 corresponding lines) src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:362 — src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:362-389 | src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:394-421 — These two members are one piece of code written twice and then edited apart: 28 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (28 corresponding lines) src/EcclesiaCRM/utils/SabreUtils.php:513 — src/EcclesiaCRM/utils/SabreUtils.php:513-540 | src/EcclesiaCRM/utils/SabreUtils.php:553-593 — These two members are one piece of code written twice and then edited apart: 28 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (30 corresponding lines) · ×2
  • Edited copy of a member (30 corresponding lines) src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:225 — src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:225-254 | src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:259-288 — These two members are one piece of code written twice and then edited apart: 30 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (30 corresponding lines) src/EcclesiaCRM/APIControllers/CartController.php:304 — src/EcclesiaCRM/APIControllers/CartController.php:304-333 | src/EcclesiaCRM/APIControllers/CartController.php:337-366 — These two members are one piece of code written twice and then edited apart: 30 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 27+ corresponding lines) · ×2
  • Edited copies of one member (3 members, 27+ corresponding lines) src/EcclesiaCRM/APIControllers/DocumentShareController.php:123 — src/EcclesiaCRM/APIControllers/DocumentShareController.php:123-149 | src/EcclesiaCRM/APIControllers/DocumentShareController.php:184-214 | src/EcclesiaCRM/APIControllers/DocumentShareController.php:247-277 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 27 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 27+ corresponding lines) REDACTED:1474 — REDACTED:1474-1503 | src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:431-474 | src/EcclesiaCRM/VIEWControllers/VIEWSystemController.php:226-252 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 27 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (25 corresponding lines) · ×2
  • Edited copy of a member (25 corresponding lines) src/EcclesiaCRM/APIControllers/SidebarMapIconsController.php:45 — src/EcclesiaCRM/APIControllers/SidebarMapIconsController.php:45-69 | src/EcclesiaCRM/APIControllers/SidebarMapIconsController.php:74-99 — These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (25 corresponding lines) src/EcclesiaCRM/APIControllers/UserUsersController.php:237 — src/EcclesiaCRM/APIControllers/UserUsersController.php:237-262 | src/EcclesiaCRM/APIControllers/UserUsersController.php:267-291 — These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (26 corresponding lines) · ×2
  • Edited copy of a member (26 corresponding lines) src/EcclesiaCRM/APIControllers/DocumentShareController.php:218 — src/EcclesiaCRM/APIControllers/DocumentShareController.php:218-243 | src/EcclesiaCRM/APIControllers/DocumentShareController.php:281-306 — These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (26 corresponding lines) src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:940 — src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:940-965 | src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:970-995 — These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (32 corresponding lines) · ×2
  • Edited copy of a member (32 corresponding lines) REDACTED:492 — REDACTED:492-523 | REDACTED:768-799 — These two members are one piece of code written twice and then edited apart: 32 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (32 corresponding lines) src/Plugins/MailChimp/core/Services/MailChimpService.php:723 — src/Plugins/MailChimp/core/Services/MailChimpService.php:723-754 | src/Plugins/MailChimp/core/Services/MailChimpService.php:759-797 — These two members are one piece of code written twice and then edited apart: 32 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 21+ corresponding lines) · ×2
  • Edited copies of one member (3 members, 21+ corresponding lines) src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeetingQuery.php:278 — src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeetingQuery.php:278-298 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeetingQuery.php:321-341 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeetingQuery.php:394-414 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 21 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 21+ corresponding lines) src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeetingQuery.php:272 — src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeetingQuery.php:272-292 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeetingQuery.php:315-335 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeetingQuery.php:358-378 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 21 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 21+ corresponding lines) · ×2
  • Edited copies of one member (4 members, 21+ corresponding lines) src/Plugins/NewsDashboard/core/model/Base/NewsDashboardQuery.php:296 — src/Plugins/NewsDashboard/core/model/Base/NewsDashboardQuery.php:296-316 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboardQuery.php:339-359 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboardQuery.php:468-488 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboardQuery.php:513-533 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 21 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
  • Edited copies of one member (4 members, 21+ corresponding lines) src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItemQuery.php:290 — src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItemQuery.php:290-310 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItemQuery.php:333-353 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItemQuery.php:435-455 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItemQuery.php:478-498 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 21 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 22+ corresponding lines) · ×2
  • Edited copies of one member (3 members, 22+ corresponding lines) src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:872 — src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:872-893 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:1049-1077 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:1008-1031 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 22 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 22+ corresponding lines) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:1094 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:1094-1118 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:1110-1134 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:1064-1085 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 22 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 19+ corresponding lines) · ×2
  • Edited copies of one member (3 members, 19+ corresponding lines) src/EcclesiaCRM/APIControllers/CalendarV2Controller.php:102 — src/EcclesiaCRM/APIControllers/CalendarV2Controller.php:102-120 | src/EcclesiaCRM/APIControllers/CalendarV2Controller.php:338-356 | src/EcclesiaCRM/APIControllers/CalendarV2Controller.php:360-380 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 19 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 19+ corresponding lines) src/EcclesiaCRM/APIControllers/PluginsController.php:282 — src/EcclesiaCRM/APIControllers/PluginsController.php:282-305 | src/EcclesiaCRM/APIControllers/PluginsController.php:309-327 | src/EcclesiaCRM/APIControllers/PluginsController.php:331-354 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 19 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (5 corresponding lines) · ×2
  • Edited copy of a member (5 corresponding lines) src/EcclesiaCRM/model/EcclesiaCRM/EventAttend.php:22 — src/EcclesiaCRM/model/EcclesiaCRM/EventAttend.php:22-26 | src/EcclesiaCRM/model/EcclesiaCRM/EventAttend.php:40-45 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (5 corresponding lines) src/EcclesiaCRM/utils/MiscUtils.php:439 — src/EcclesiaCRM/utils/MiscUtils.php:439-445 | src/mysql/upgrade/2.10.4-delete-ChurchCRM-folder.php:13-17 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 9+ corresponding lines) · ×2
  • Edited copies of one member (3 members, 9+ corresponding lines) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:1315 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:1315-1324 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:1331-1340 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:1276-1284 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 9+ corresponding lines) REDACTED:255 — REDACTED:255-266 | REDACTED:270-278 | REDACTED:707-718 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Duplicated block (47 lines × 2) · ×2
  • Duplicated block (47 lines × 2) src/EcclesiaCRM/MenuBar/MenuBar.php:425 — src/EcclesiaCRM/MenuBar/MenuBar.php:425-471 | src/EcclesiaCRM/MenuBar/MenuBar.php:657-703 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/MenuBar/MenuBar.php:425` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/EcclesiaCRM/MenuBar/MenuBar.php:423` calls `addLink`, `getID` and `src/EcclesiaCRM/MenuBar/MenuBar.php:656` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (47 lines × 2) src/EcclesiaCRM/Reports/PDF_AddressReport.php:22 — src/EcclesiaCRM/Reports/PDF_AddressReport.php:22-68 | src/EcclesiaCRM/Reports/PDF_Directory.php:135-181 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (33–34 lines × 2) · ×2
  • Duplicated block (33–34 lines × 2) src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:457 — src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:457-490 | src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:695-727 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:457` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (33–34 lines × 2) src/Plugins/MeetingJitsi/core/VIEWControllers/VIEWMeetingController.php:55 — src/Plugins/MeetingJitsi/core/VIEWControllers/VIEWMeetingController.php:55-87 | src/Plugins/MeetingJitsi/core/VIEWControllers/VIEWMeetingController.php:102-135 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (30 lines × 2) · ×2
  • Duplicated block (30 lines × 2) src/EcclesiaCRM/Service/ConfirmReportService.php:378 — src/EcclesiaCRM/Service/ConfirmReportService.php:378-407 | src/EcclesiaCRM/Service/ConfirmReportService.php:603-632 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (30 lines × 2) src/EcclesiaCRM/Service/ConfirmReportService.php:432 — src/EcclesiaCRM/Service/ConfirmReportService.php:432-461 | src/EcclesiaCRM/Service/ConfirmReportService.php:829-858 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Service/ConfirmReportService.php:432` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
D4 · Code Duplication · Duplicated block (27 lines × 2) · ×2
  • Duplicated block (27 lines × 2) src/EcclesiaCRM/APIControllers/PeopleGroupController.php:571 — src/EcclesiaCRM/APIControllers/PeopleGroupController.php:571-597 | src/EcclesiaCRM/APIControllers/PeopleGroupController.php:606-632 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/EcclesiaCRM/APIControllers/PeopleGroupController.php:566` calls `getType`, `getFamId`, `withJson` and `src/EcclesiaCRM/APIControllers/PeopleGroupController.php:605` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (27 lines × 2) src/EcclesiaCRM/Search/GroupPropsSearchRes.php:64 — src/EcclesiaCRM/Search/GroupPropsSearchRes.php:64-90 | src/EcclesiaCRM/Search/GroupSearchRes.php:60-86 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Search/GroupPropsSearchRes.php:64` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (26 lines × 2) · ×2
  • Duplicated block (26 lines × 2) REDACTED:286 — REDACTED:286-311 | REDACTED:738-763 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:286` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (26 lines × 2) src/EcclesiaCRM/MenuBar/MenuBar.php:381 — src/EcclesiaCRM/MenuBar/MenuBar.php:381-406 | src/EcclesiaCRM/MenuBar/MenuBar.php:615-640 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/MenuBar/MenuBar.php:381` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/EcclesiaCRM/MenuBar/MenuBar.php:380` calls `filterByType` and `src/EcclesiaCRM/MenuBar/MenuBar.php:614` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (24–25 lines × 2) · ×2
  • Duplicated block (24–25 lines × 2) src/EcclesiaCRM/APIControllers/DocumentShareController.php:96 — src/EcclesiaCRM/APIControllers/DocumentShareController.php:96-119 | src/EcclesiaCRM/APIControllers/DocumentShareController.php:447-471 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (24–25 lines × 2) REDACTED:214 — REDACTED:214-237 | REDACTED:833-857 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication · Duplicated block (24 lines × 3) · ×2
  • Duplicated block (24 lines × 3) src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:356 — src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:356-379 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:456-479 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:528-551 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
  • Duplicated block (24 lines × 3) src/Plugins/ToDoListDashboard/core/APIControllers/ToDoListDashboardController.php:241 — src/Plugins/ToDoListDashboard/core/APIControllers/ToDoListDashboardController.php:241-264 | src/Plugins/ToDoListDashboard/core/APIControllers/ToDoListDashboardController.php:324-347 | src/Plugins/ToDoListDashboard/core/APIControllers/ToDoListDashboardController.php:382-405 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Plugins/ToDoListDashboard/core/APIControllers/ToDoListDashboardController.php:241` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (22 lines × 2) · ×2
  • Duplicated block (22 lines × 2) src/EcclesiaCRM/Reports/PDF_Directory.php:393 — src/EcclesiaCRM/Reports/PDF_Directory.php:393-414 | src/EcclesiaCRM/Reports/PDF_Directory.php:450-471 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/EcclesiaCRM/Reports/PDF_Directory.php:391` calls `strlen` and `src/EcclesiaCRM/Reports/PDF_Directory.php:448` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (22 lines × 2) src/EcclesiaCRM/Synchronize/PersonDashboardItem.php:45 — src/EcclesiaCRM/Synchronize/PersonDashboardItem.php:45-66 | src/Plugins/PersonInfosDashboard/core/Synchronize/PersonDashboardItemPlugin.php:29-50 — before extracting anything, compare `src/EcclesiaCRM/Synchronize/PersonDashboardItem.php` and `src/Plugins/PersonInfosDashboard/core/Synchronize/PersonDashboardItemPlugin.php` as WHOLE FILES: 85% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Synchronize/PersonDashboardItem.php:45` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (19 lines × 2) · ×2
  • Duplicated block (19 lines × 2) src/EcclesiaCRM/MICRFunctions.php:60 — src/EcclesiaCRM/MICRFunctions.php:60-78 | src/EcclesiaCRM/utils/MICRReader.php:62-80 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (19 lines × 2) src/EcclesiaCRM/Service/ConfirmReportService.php:231 — src/EcclesiaCRM/Service/ConfirmReportService.php:231-253 | src/EcclesiaCRM/Service/ConfirmReportService.php:255-273 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (16–17 lines × 2) · ×2
  • Duplicated block (16–17 lines × 2) REDACTED:523 — REDACTED:523-539 | src/EcclesiaCRM/dto/Cart.php:338-353 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (16–17 lines × 2) src/EcclesiaCRM/Service/ConfirmReportService.php:90 — src/EcclesiaCRM/Service/ConfirmReportService.php:90-105 | src/EcclesiaCRM/Service/ConfirmReportService.php:511-527 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Service/ConfirmReportService.php:90` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (15 lines × 4) · ×2
  • Duplicated block (15 lines × 4) src/EcclesiaCRM/APIControllers/PeopleGroupController.php:860 — src/EcclesiaCRM/APIControllers/PeopleGroupController.php:860-874 | src/EcclesiaCRM/Service/DashboardItemService.php:87-101 | src/EcclesiaCRM/Synchronize/SundaySchoolDashboardItem.php:97-111 | src/Reports/PhotoBook.php:185-199 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 4 times. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/PeopleGroupController.php:860` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 4) src/EcclesiaCRM/MenuBar/MenuBar.php:392 — src/EcclesiaCRM/MenuBar/MenuBar.php:392-406 | src/EcclesiaCRM/MenuBar/MenuBar.php:456-470 | src/EcclesiaCRM/MenuBar/MenuBar.php:626-640 | src/EcclesiaCRM/MenuBar/MenuBar.php:688-702 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/MenuBar/MenuBar.php:392` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (14–15 lines × 3) · ×2
  • Duplicated block (14–15 lines × 3) src/EcclesiaCRM/Service/PastoralCareService.php:285 — src/EcclesiaCRM/Service/PastoralCareService.php:285-299 | src/EcclesiaCRM/Service/PastoralCareService.php:310-323 | src/EcclesiaCRM/Service/PastoralCareService.php:363-377 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Service/PastoralCareService.php:285` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/EcclesiaCRM/Service/PastoralCareService.php:309` calls `addAsColumn`, `PersonCountcount` and `src/EcclesiaCRM/Service/PastoralCareService.php:284` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (14–15 lines × 3) src/EcclesiaCRM/utils/InputUtils.php:496 — src/EcclesiaCRM/utils/InputUtils.php:496-509 | src/EcclesiaCRM/utils/InputUtils.php:512-525 | src/EcclesiaCRM/utils/InputUtils.php:528-542 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (14–15 lines × 2) · ×2
  • Duplicated block (14–15 lines × 2) src/EcclesiaCRM/model/EcclesiaCRM/Person.php:118 — src/EcclesiaCRM/model/EcclesiaCRM/Person.php:118-131 | src/EcclesiaCRM/model/EcclesiaCRM/Person.php:146-160 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/model/EcclesiaCRM/Person.php:146` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (14–15 lines × 2) src/Reports/PDFBadgeGroup.php:50 — src/Reports/PDFBadgeGroup.php:50-64 | src/Reports/PDFBadgeGroup.php:89-102 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Reports/PDFBadgeGroup.php:50` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (13 lines × 6) · ×2
  • Duplicated block (13 lines × 6) REDACTED:212 — REDACTED:212-224 | REDACTED:292-304 | REDACTED:669-681 | REDACTED:744-756 | REDACTED:831-843 | REDACTED:972-984 — there are 6 copies across 3 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 6 sites; resolving a subset leaves the remainder to drift apart.
  • Duplicated block (13 lines × 6) REDACTED:315 — REDACTED:315-327 | REDACTED:367-379 | REDACTED:883-895 | REDACTED:570-582 | REDACTED:601-613 | src/Reports/CanvassReports.php:254-266 — there are 6 copies across 3 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 6 sites; resolving a subset leaves the remainder to drift apart. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `REDACTED:329` calls `filterByFamId`, `getId` and `REDACTED:897` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (12 lines × 8) · ×2
  • Duplicated block (12 lines × 8) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:1257 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:1257-1268 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:1062-1073 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:963-974 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:1113-1124 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:1273-1284 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:981-992 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:1071-1082 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:1218-1229 — before extracting anything, compare `src/Plugins/MailChimp/core/model/Base/MailChimpParams.php` and `src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 159 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (12 lines × 8) src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:113 — src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:113-124 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeetingQuery.php:95-106 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeetingQuery.php:89-100 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeetingQuery.php:101-112 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboardQuery.php:113-124 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboardQuery.php:89-100 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItemQuery.php:107-118 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardQuery.php:95-106 — before extracting anything, compare `src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php` and `src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeetingQuery.php` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 57 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (12 lines × 3) · ×2
  • Duplicated block (12 lines × 3) src/EcclesiaCRM/APIControllers/PastoralCareController.php:197 — src/EcclesiaCRM/APIControllers/PastoralCareController.php:197-208 | src/EcclesiaCRM/APIControllers/PastoralCareController.php:267-278 | src/EcclesiaCRM/APIControllers/PastoralCareController.php:398-409 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/PastoralCareController.php:197` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (12 lines × 3) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:668 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:668-679 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:564-575 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:472-483 — before extracting anything, compare `src/Plugins/MailChimp/core/model/Base/MailChimpParams.php` and `src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 171 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:668` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (11–12 lines × 2) · ×2
  • Duplicated block (11–12 lines × 2) src/EcclesiaCRM/APIControllers/PeopleGroupController.php:455 — src/EcclesiaCRM/APIControllers/PeopleGroupController.php:455-466 | src/EcclesiaCRM/APIControllers/VolunteerOpportunityController.php:373-383 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/PeopleGroupController.php:455` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. Note first that the copies are not typed on the same thing: `FamilyQuery` names `EcclesiaCRM\Base\FamilyQuery` in one and `EcclesiaCRM\FamilyQuery` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (11–12 lines × 2) src/Plugins/NewsDashboard/core/APIControllers/NewsDashboardController.php:74 — src/Plugins/NewsDashboard/core/APIControllers/NewsDashboardController.php:74-84 | src/Plugins/NewsDashboard/core/APIControllers/NewsDashboardController.php:100-111 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Plugins/NewsDashboard/core/APIControllers/NewsDashboardController.php:74` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (11 lines × 8) · ×2
  • Duplicated block (11 lines × 8) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:354 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:354-364 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:329-339 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:306-316 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:338-348 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:354-364 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:320-330 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:331-341 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:349-359 — before extracting anything, compare `src/Plugins/MailChimp/core/model/Base/MailChimpParams.php` and `src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 159 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (11 lines × 8) src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:182 — src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:182-192 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeetingQuery.php:164-174 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeetingQuery.php:158-168 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeetingQuery.php:170-180 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboardQuery.php:182-192 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboardQuery.php:158-168 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItemQuery.php:176-186 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardQuery.php:164-174 — before extracting anything, compare `src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php` and `src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeetingQuery.php` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 57 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:182` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (10–11 lines × 2) · ×2
  • Duplicated block (10–11 lines × 2) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:280 — src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:280-290 | src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:1146-1155 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (10–11 lines × 2) src/EcclesiaCRM/Reports/PDF_Attendance.php:189 — src/EcclesiaCRM/Reports/PDF_Attendance.php:189-199 | src/EcclesiaCRM/Reports/PDF_Attendance.php:539-548 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Reports/PDF_Attendance.php:189` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (10 lines × 8) · ×2
  • Duplicated block (10 lines × 8) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:728 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:728-737 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:589-598 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:514-523 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:624-633 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:736-745 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:532-541 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:602-611 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:705-714 — before extracting anything, compare `src/Plugins/MailChimp/core/model/Base/MailChimpParams.php` and `src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 159 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (10 lines × 8) src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:234 — src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:234-243 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeetingQuery.php:216-225 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeetingQuery.php:210-219 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeetingQuery.php:222-231 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboardQuery.php:234-243 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboardQuery.php:210-219 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItemQuery.php:228-237 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardQuery.php:216-225 — before extracting anything, compare `src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php` and `src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeetingQuery.php` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 57 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (10 lines × 5) · ×2
  • Duplicated block (10 lines × 5) REDACTED:72 — REDACTED:72-81 | REDACTED:331-340 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:391-400 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:429-438 | REDACTED:419-428 — there are 5 copies across 4 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 5 sites; resolving a subset leaves the remainder to drift apart.
  • Duplicated block (10 lines × 5) REDACTED:490 — REDACTED:490-499 | REDACTED:730-739 | REDACTED:835-844 | REDACTED:880-889 | src/Reports/CanvassReports.php:310-319 — there are 5 copies across 3 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 5 sites; resolving a subset leaves the remainder to drift apart. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `REDACTED:729` calls `withColumn` and `REDACTED:489` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (10 lines × 3) · ×2
  • Duplicated block (10 lines × 3) src/EcclesiaCRM/APIControllers/PastoralCareController.php:67 — src/EcclesiaCRM/APIControllers/PastoralCareController.php:67-76 | src/EcclesiaCRM/Service/PastoralCareService.php:61-70 | src/EcclesiaCRM/VIEWControllers/VIEWPastoralCareController.php:107-116 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (10 lines × 3) src/EcclesiaCRM/Reports/PDF_AddressReport.php:87 — src/EcclesiaCRM/Reports/PDF_AddressReport.php:87-97 | src/EcclesiaCRM/Reports/PDF_GroupDirectory.php:28-37 | src/Reports/EnvelopeReport.php:55-65 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
D4 · Code Duplication · Duplicated block (9 lines × 6) · ×2
  • Duplicated block (9 lines × 6) src/EcclesiaCRM/MenuBar/MenuBar.php:302 — src/EcclesiaCRM/MenuBar/MenuBar.php:302-310 | src/EcclesiaCRM/MenuBar/MenuBar.php:413-421 | src/EcclesiaCRM/MenuBar/MenuBar.php:478-486 | src/EcclesiaCRM/MenuBar/MenuBar.php:556-564 | src/EcclesiaCRM/MenuBar/MenuBar.php:647-655 | src/EcclesiaCRM/MenuBar/MenuBar.php:710-718 — all 6 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/MenuBar/MenuBar.php:302` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/EcclesiaCRM/MenuBar/MenuBar.php:312` calls `addLink`, `getID` and `src/EcclesiaCRM/MenuBar/MenuBar.php:657` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (9 lines × 6) src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:272 — src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:272-280 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:318-326 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:338-346 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:386-394 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:485-493 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:787-795 — all 6 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:272` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9 lines × 3) · ×2
  • Duplicated block (9 lines × 3) REDACTED:1486 — REDACTED:1486-1496 | src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:325-335 | src/EcclesiaCRM/VIEWControllers/VIEWSystemController.php:237-245 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:1486` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 3) REDACTED:554 — REDACTED:554-562 | REDACTED:564-572 | REDACTED:573-583 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:554` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (7 lines × 4) · ×2
  • Duplicated block (7 lines × 4) src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:346 — src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:346-352 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:408-414 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:446-452 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:494-500 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
  • Duplicated block (7 lines × 4) src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:233 — src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:233-240 | src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:279-286 | src/EcclesiaCRM/VIEWControllers/VIEWSystemController.php:161-167 | src/EcclesiaCRM/VIEWControllers/VIEWSystemController.php:197-203 — there are 4 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:233` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (6 lines × 3) · ×2
  • Duplicated block (6 lines × 3) src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:347 — src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:347-352 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:447-452 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:519-524 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:347` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 3) src/EcclesiaCRM/Service/ConfirmReportService.php:62 — src/EcclesiaCRM/Service/ConfirmReportService.php:62-70 | src/EcclesiaCRM/Service/ConfirmReportService.php:492-500 | src/EcclesiaCRM/Service/ConfirmReportService.php:566-571 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Service/ConfirmReportService.php:62` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (5–6 lines × 2) · ×2
  • Duplicated block (5–6 lines × 2) REDACTED:428 — REDACTED:428-432 | REDACTED:434-439 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:434` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (5–6 lines × 2) src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:379 — src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:379-383 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:440-445 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:440` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (5 lines × 8) · ×2
  • Duplicated block (5 lines × 8) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:290 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:290-294 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:265-269 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:242-246 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:274-278 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:290-294 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:256-260 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:267-271 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:285-289 — before extracting anything, compare `src/Plugins/MailChimp/core/model/Base/MailChimpParams.php` and `src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 159 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (5 lines × 8) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:339 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:339-343 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:314-318 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:291-295 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:323-327 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:339-343 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:305-309 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:316-320 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:334-338 — before extracting anything, compare `src/Plugins/MailChimp/core/model/Base/MailChimpParams.php` and `src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 159 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
P7 · Outbound HTTP resilience · Outbound HTTP without resilience · ×2
  • Outbound HTTP without resilience src/EcclesiaCRM/BackupManager.php:704 — `curl_exec (` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience REDACTED:414 — `curl_exec(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
R10 · Code Duplication · Duplicated block (48 lines × 2 locations) · ×2
  • Duplicated block (48 lines × 2 locations) src/Plugins/MailChimp/skin/js/NotInMailChimpFamilies.js:10 — src/Plugins/MailChimp/skin/js/NotInMailChimpFamilies.js:10 · src/Plugins/MailChimp/skin/js/NotInMailChimpPersons.js:10 — the 2 copies are spread across 2 files, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are.
  • Duplicated block (48 lines × 2 locations) src/skin/js/people/FamilyView.js:549 — src/skin/js/people/FamilyView.js:549 · src/skin/js/people/PersonView.js:1358 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block (26 lines × 2 locations) · ×2
  • Duplicated block (26 lines × 2 locations) src/skin/js/fundraiser/fundraiserEditor.js:25 — src/skin/js/fundraiser/fundraiserEditor.js:25 · src/skin/js/fundraiser/paddleNumList.js:7 — the 2 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it.
  • Duplicated block (26 lines × 2 locations) src/skin/js/people/letterandlabels.js:45 — src/skin/js/people/letterandlabels.js:45 · src/skin/js/people/letterandlabels.js:78 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
R2 · Cyclomatic Complexity · Complex function (anonymous) (cyclomatic 12, cognitive 16) · ×2
  • Complex function (anonymous) (cyclomatic 12, cognitive 16) src/skin/js/BadgeSticker.js:52 — (anonymous) has cyclomatic complexity 12 and cognitive complexity 16; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
  • Complex function (anonymous) (cyclomatic 12, cognitive 16) src/skin/js/system/KioskJSOM.js:257 — (anonymous) has cyclomatic complexity 12 and cognitive complexity 16; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R7 · Dead Code · Dead file (~357 LoC) · ×2
  • Dead file (~357 LoC) src/skin/js/fundraiser/paddleNumList.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
  • Dead file (~357 LoC) src/skin/js/volunteer/VolunteerOpportunity.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~283 LoC) · ×2
  • Dead file (~283 LoC) src/skin/js/group/GroupEditor.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
  • Dead file (~283 LoC) src/skin/js/people/PersonVerify.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~254 LoC) · ×2
  • Dead file (~254 LoC) src/skin/js/backup/restore.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
  • Dead file (~254 LoC) REDACTED — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
AC3 · Page structure · Empty <h1> heading · ×1
  • Empty <h1> heading src/kiosk/templates/kioskDevices/sunday-school-class-view.php:15 — An empty heading appears in the document outline announced with no text. Give the heading text, or remove it if it's decorative.
AC3 · Page structure · Empty <h5> heading · ×1
  • Empty <h5> heading src/v2/templates/calendar/calendar.php:201 — An empty heading appears in the document outline announced with no text. Give the heading text, or remove it if it's decorative.
AC3 · Page structure · Empty <h3> heading · ×1
  • Empty <h3> heading src/v2/templates/calendar/eventslist.php:119 — An empty heading appears in the document outline announced with no text. Give the heading text, or remove it if it's decorative.
AC3 · Page structure · Empty <h4> heading · ×1
  • Empty <h4> heading src/v2/templates/group/groupedit.php:35 — An empty heading appears in the document outline announced with no text. Give the heading text, or remove it if it's decorative.
AC4 · Keyboard semantics · Positive tabindex (1) · ×1
  • Positive tabindex (1) src/v2/templates/calendar/checkin.php:263 — A positive tabindex forces a manual tab order that fights the DOM and is fragile. Use tabindex="0" (or restructure the DOM).
AC4 · Keyboard semantics · Positive tabindex (2) · ×1
  • Positive tabindex (2) src/v2/templates/calendar/checkin.php:283 — A positive tabindex forces a manual tab order that fights the DOM and is fragile. Use tabindex="0" (or restructure the DOM).
AC4 · Keyboard semantics · Positive tabindex (3) · ×1
  • Positive tabindex (3) src/v2/templates/calendar/checkin.php:293 — A positive tabindex forces a manual tab order that fights the DOM and is fragile. Use tabindex="0" (or restructure the DOM).
AC4 · Keyboard semantics · Modal dialog does not manage focus · ×1
  • Modal dialog does not manage focus src/v2/templates/group/groupedit.php:31 — This <div role="dialog"> is a modal dialog, but nothing moves focus into it when it opens and nothing keeps focus inside it while it is open, so a keyboard or screen-reader user keeps acting on the content behind it (WCAG 2.4.3). Use a native <dialog> opened with showModal(), a dialog component that traps focus, or move focus to the dialog on open, trap Tab inside it (or make the page behind inert) and return focus to the control that opened it on close.
AC6 · Visual & motion safety · Low contrast colour pair in CSS (2.8 · ×1
  • Low contrast colour pair in CSS (2.8:1) src/v2/templates/sidebar/systemsettings.php:45 — `.settings-tab-link.active` sets color: #fff on background-color: #0ea5e9 — 2.8:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
AC6 · Visual & motion safety · Low contrast colour pair in CSS (3.5 · ×1
  • Low contrast colour pair in CSS (3.5:1) src/skin/scss/_setup.scss:81 — `.wizard > .steps .number` sets color: #007bff on background-color: #e9f2ff — 3.5:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
AC6 · Visual & motion safety · Low contrast colour pair in CSS (4.4 · ×1
  • Low contrast colour pair in CSS (4.4:1) src/skin/scss/_setup.scss:126 — `.wizard > .steps .disabled a, .wizard > .steps .disabled a:hover, .wizard > .steps .disabled a:active` sets color: #6c757d on background-color: #f8f9fa — 4.4:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 135) · ×1
  • (anonymous) (cyclomatic 135) src/skin/js/people/PersonView.js:1 — (anonymous) has cyclomatic complexity 135 (threshold 15). Most of this is not in the body itself: 1 of the 135 points is its own statement and the rest belongs to 165 function items inside it that branch (a function literal at line 1549, setButtonBusy, openConfirmDialog, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · VIEWDepositController.argumentsPledgeEditorArray (cyclomatic 106) · ×1
  • VIEWDepositController.argumentsPledgeEditorArray (cyclomatic 106) src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:477 — VIEWDepositController.argumentsPledgeEditorArray has cyclomatic complexity 106 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 97) · ×1
  • (anonymous) (cyclomatic 97) src/Plugins/MailChimp/skin/js/ManageList.js:11 — (anonymous) has cyclomatic complexity 97 (threshold 15). Most of this is not in the body itself: 1 of the 97 points is its own statement and the rest belongs to 111 function items inside it that branch (a function literal at line 58, a function literal at line 660, a function literal at line 599, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · CalendarService.realEvents (cyclomatic 92) · ×1
  • CalendarService.realEvents (cyclomatic 92) src/EcclesiaCRM/Service/CalendarService.php:155 — CalendarService.realEvents has cyclomatic complexity 92 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · CalendarV2.document.addEventListener("DOMContentLoaded") (cyclomatic 91) · ×1
  • CalendarV2.document.addEventListener("DOMContentLoaded") (cyclomatic 91) src/skin/js/calendar/CalendarV2.js:12 — CalendarV2.document.addEventListener("DOMContentLoaded") has cyclomatic complexity 91 (threshold 15). Of this number, 26 points are the body's own statements and 65 belong to 22 function literals inside it that branch. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · PDF_ConfirmReport.run (cyclomatic 82) · ×1
  • PDF_ConfirmReport.run (cyclomatic 82) REDACTED:332 — PDF_ConfirmReport.run has cyclomatic complexity 82 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 80) · ×1
  • (anonymous) (cyclomatic 80) src/skin/js/Search/Search.js:1 — (anonymous) has cyclomatic complexity 80 (threshold 15). Most of this is not in the body itself: 7 of the 80 points are its own statements and the rest belongs to 94 function items inside it that branch (render, a function literal at line 275, a function literal at line 39, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · CalendarService.getEventsOld (cyclomatic 76) · ×1
  • CalendarService.getEventsOld (cyclomatic 76) src/EcclesiaCRM/Service/CalendarService.php:815 — CalendarService.getEventsOld has cyclomatic complexity 76 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · CalendarEventV2Controller.manageEvent (cyclomatic 74) · ×1
  • CalendarEventV2Controller.manageEvent (cyclomatic 74) src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:335 — CalendarEventV2Controller.manageEvent has cyclomatic complexity 74 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 74) · ×1
  • (anonymous) (cyclomatic 74) REDACTED:1 — (anonymous) has cyclomatic complexity 74 (threshold 15). Most of this is not in the body itself: 1 of the 74 points is its own statement and the rest belongs to 88 function items inside it that branch (render, a function literal at line 43, render, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · MiscUtils.simpleEmbedFiles (cyclomatic 71) · ×1
  • MiscUtils.simpleEmbedFiles (cyclomatic 71) src/EcclesiaCRM/utils/MiscUtils.php:878 — MiscUtils.simpleEmbedFiles has cyclomatic complexity 71 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · VIEWUserController.argumentsrenderUserEditorArray (cyclomatic 67) · ×1
  • VIEWUserController.argumentsrenderUserEditorArray (cyclomatic 67) src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:291 — VIEWUserController.argumentsrenderUserEditorArray has cyclomatic complexity 67 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · CRMEditorTools.init (cyclomatic 60) · ×1
  • CRMEditorTools.init (cyclomatic 60) src/skin/js/ckeditor/ckeditorextension.js:880 — CRMEditorTools.init has cyclomatic complexity 60 (threshold 15). Most of this is not in the body itself: 6 of the 60 points are its own statements and the rest belongs to 13 function literals inside it that branch (lines 1202, 1063, 1119, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D1 · Cyclomatic Complexity · PersonSearchRes.buildSearch (cyclomatic 58) · ×1
  • PersonSearchRes.buildSearch (cyclomatic 58) src/EcclesiaCRM/Search/PersonSearchRes.php:51 — PersonSearchRes.buildSearch has cyclomatic complexity 58 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 56) · ×1
  • (anonymous) (cyclomatic 56) src/skin/js/people/FamilyView.js:1 — (anonymous) has cyclomatic complexity 56 (threshold 15). Most of this is not in the body itself: 1 of the 56 points is its own statement and the rest belongs to 89 function items inside it that branch (a function literal at line 788, updateLittleButtons, a function literal at line 338, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · SidebarGeneralRolesController.getAllGeneralRoles (cyclomatic 54) · ×1
  • SidebarGeneralRolesController.getAllGeneralRoles (cyclomatic 54) src/EcclesiaCRM/APIControllers/SidebarGeneralRolesController.php:47 — SidebarGeneralRolesController.getAllGeneralRoles has cyclomatic complexity 54 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 53) · ×1
  • (anonymous) (cyclomatic 53) src/skin/js/system/setup.js:156 — (anonymous) has cyclomatic complexity 53 (threshold 15). Most of this is not in the body itself: 6 of the 53 points are its own statements and the rest belongs to 32 function items inside it that branch (a function literal at line 500, canMoveToStep, setConfirmPasswordValidity, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · setup.document.addEventListener("DOMContentLoaded") (cyclomatic 52) · ×1
  • setup.document.addEventListener("DOMContentLoaded") (cyclomatic 52) src/skin/js/system/setup.js:156 — setup.document.addEventListener("DOMContentLoaded") has cyclomatic complexity 52 (threshold 15). Most of this is not in the body itself: 6 of the 52 points are its own statements and the rest belongs to 16 function items inside it that branch (a function literal at line 500, canMoveToStep, setConfirmPasswordValidity, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 52) · ×1
  • (anonymous) (cyclomatic 52) src/Plugins/BirthdayAnniversaryDashboard/skin/js/BirthdayAnniversaryDashboard.js:1 — (anonymous) has cyclomatic complexity 52 (threshold 15). Most of this is not in the body itself: 1 of the 52 points is its own statement and the rest belongs to 24 function items inside it that branch (promptActivationToggle, openPastoralNoteDialog::(anonymous)::callback, a function literal at line 101, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · PDF_Attendance.DrawRealAttendanceCalendar (cyclomatic 49) · ×1
  • PDF_Attendance.DrawRealAttendanceCalendar (cyclomatic 49) src/EcclesiaCRM/Reports/PDF_Attendance.php:365 — PDF_Attendance.DrawRealAttendanceCalendar has cyclomatic complexity 49 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · VIEWEdriveController.renderShares (cyclomatic 47) · ×1
  • VIEWEdriveController.renderShares (cyclomatic 47) src/EcclesiaCRM/VIEWControllers/VIEWEdriveController.php:108 — VIEWEdriveController.renderShares has cyclomatic complexity 47 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MenuEventsCount.getNumberEventsOfToday (cyclomatic 46) · ×1
  • MenuEventsCount.getNumberEventsOfToday (cyclomatic 46) src/EcclesiaCRM/dto/MenuEventsCount.php:46 — MenuEventsCount.getNumberEventsOfToday has cyclomatic complexity 46 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MiscUtils.embedFiles (cyclomatic 46) · ×1
  • MiscUtils.embedFiles (cyclomatic 46) src/EcclesiaCRM/utils/MiscUtils.php:1281 — MiscUtils.embedFiles has cyclomatic complexity 46 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · SidebarGeneralRolesController.generalRoleAssign (cyclomatic 43) · ×1
  • SidebarGeneralRolesController.generalRoleAssign (cyclomatic 43) src/EcclesiaCRM/APIControllers/SidebarGeneralRolesController.php:379 — SidebarGeneralRolesController.generalRoleAssign has cyclomatic complexity 43 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Person.getFormattedName (cyclomatic 43) · ×1
  • Person.getFormattedName (cyclomatic 43) src/EcclesiaCRM/model/EcclesiaCRM/Person.php:663 — Person.getFormattedName has cyclomatic complexity 43 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DocumentFileManagerController.getPreview (cyclomatic 42) · ×1
  • DocumentFileManagerController.getPreview (cyclomatic 42) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:325 — DocumentFileManagerController.getPreview has cyclomatic complexity 42 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · PhpWordHTMLExtension.parseStyle (cyclomatic 42) · ×1
  • PhpWordHTMLExtension.parseStyle (cyclomatic 42) src/EcclesiaCRM/utils/PhpWordHTMLExtension.php:631 — PhpWordHTMLExtension.parseStyle has cyclomatic complexity 42 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · EmailUsers.renderAndSend (cyclomatic 41) · ×1
  • EmailUsers.renderAndSend (cyclomatic 41) REDACTED:759 — EmailUsers.renderAndSend has cyclomatic complexity 41 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · VIEWSundaySchoolController.argumentsSundayschoolReportsArray (cyclomatic 41) · ×1
  • VIEWSundaySchoolController.argumentsSundayschoolReportsArray (cyclomatic 41) src/EcclesiaCRM/VIEWControllers/VIEWSundaySchoolController.php:143 — VIEWSundaySchoolController.argumentsSundayschoolReportsArray has cyclomatic complexity 41 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · VObjectExtract.calendarData (cyclomatic 41) · ×1
  • VObjectExtract.calendarData (cyclomatic 41) src/EcclesiaCRM/sabre/CalDav/VObjectExtract.php:23 — VObjectExtract.calendarData has cyclomatic complexity 41 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PDFLabel.ZipBundleSort (cyclomatic 38) · ×1
  • PDFLabel.ZipBundleSort (cyclomatic 38) REDACTED:243 — PDFLabel.ZipBundleSort has cyclomatic complexity 38 (threshold 15). This file's own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes — or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages.
D1 · Cyclomatic Complexity · CalendarService.createCalendarItemForGetEvents (cyclomatic 37) · ×1
  • CalendarService.createCalendarItemForGetEvents (cyclomatic 37) src/EcclesiaCRM/Service/CalendarService.php:1329 — CalendarService.createCalendarItemForGetEvents has cyclomatic complexity 37 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · CalendarService.modifyEventFromCalendar (cyclomatic 35) · ×1
  • CalendarService.modifyEventFromCalendar (cyclomatic 35) src/EcclesiaCRM/Service/CalendarService.php:1877 — CalendarService.modifyEventFromCalendar has cyclomatic complexity 35 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · VIEWPeopleController.argumentsPeoplePersonViewArray (cyclomatic 35) · ×1
  • VIEWPeopleController.argumentsPeoplePersonViewArray (cyclomatic 35) REDACTED:312 — VIEWPeopleController.argumentsPeoplePersonViewArray has cyclomatic complexity 35 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · User.ApplyRole (cyclomatic 34) · ×1
  • User.ApplyRole (cyclomatic 34) src/EcclesiaCRM/model/EcclesiaCRM/User.php:321 — User.ApplyRole has cyclomatic complexity 34 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MenuBar.addGroups (cyclomatic 33) · ×1
  • MenuBar.addGroups (cyclomatic 33) src/EcclesiaCRM/MenuBar/MenuBar.php:279 — MenuBar.addGroups has cyclomatic complexity 33 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · FamilySearchRes.buildSearch (cyclomatic 33) · ×1
  • FamilySearchRes.buildSearch (cyclomatic 33) src/EcclesiaCRM/Search/FamilySearchRes.php:30 — FamilySearchRes.buildSearch has cyclomatic complexity 33 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 33) · ×1
  • (anonymous) (cyclomatic 33) src/skin/js/finance/DepositSlipEditor.js:1 — (anonymous) has cyclomatic complexity 33 (threshold 15). Most of this is not in the body itself: 1 of the 33 points is its own statement and the rest belongs to 36 function items inside it that branch (initCharts::applyDatasetStyle, a function literal at line 97, a function literal at line 154, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · EmailUsers.renderFamily (cyclomatic 32) · ×1
  • EmailUsers.renderFamily (cyclomatic 32) REDACTED:208 — EmailUsers.renderFamily has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PluginUpgradeService.getMigrationPlan (cyclomatic 32) · ×1
  • PluginUpgradeService.getMigrationPlan (cyclomatic 32) src/EcclesiaCRM/Service/PluginUpgradeService.php:125 — PluginUpgradeService.getMigrationPlan has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · OutputUtils.formCustomField (cyclomatic 32) · ×1
  • OutputUtils.formCustomField (cyclomatic 32) src/EcclesiaCRM/utils/OutputUtils.php:290 — OutputUtils.formCustomField has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MenuBar.addSundaySchoolGroups (cyclomatic 31) · ×1
  • MenuBar.addSundaySchoolGroups (cyclomatic 31) src/EcclesiaCRM/MenuBar/MenuBar.php:533 — MenuBar.addSundaySchoolGroups has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · InputUtils.cleanNode (cyclomatic 31) · ×1
  • InputUtils.cleanNode (cyclomatic 31) src/EcclesiaCRM/utils/InputUtils.php:129 — InputUtils.cleanNode has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 31) · ×1
  • (anonymous) (cyclomatic 31) src/Plugins/MailChimp/skin/js/Campaign.js:10 — (anonymous) has cyclomatic complexity 31 (threshold 15). Most of this is not in the body itself: 4 of the 31 points are its own statements and the rest belongs to 12 function items inside it that branch (a function literal at line 116, a function literal at line 52, a function literal at line 160, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · PDF_Attendance.DrawAttendanceCalendar (cyclomatic 30) · ×1
  • PDF_Attendance.DrawAttendanceCalendar (cyclomatic 30) src/EcclesiaCRM/Reports/PDF_Attendance.php:39 — PDF_Attendance.DrawAttendanceCalendar has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · GroupSearchRes.buildSearch (cyclomatic 30) · ×1
  • GroupSearchRes.buildSearch (cyclomatic 30) src/EcclesiaCRM/Search/GroupSearchRes.php:29 — GroupSearchRes.buildSearch has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PDFLabel.GroupBySalutation (cyclomatic 30) · ×1
  • PDFLabel.GroupBySalutation (cyclomatic 30) REDACTED:35 — PDFLabel.GroupBySalutation has cyclomatic complexity 30 (threshold 15). This file's own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes — or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages.
D1 · Cyclomatic Complexity · GroupView.initDataTable (cyclomatic 30) · ×1
  • GroupView.initDataTable (cyclomatic 30) REDACTED:332 — GroupView.initDataTable has cyclomatic complexity 30 (threshold 15). Most of this is not in the body itself: 2 of the 30 points are its own statements and the rest belongs to 24 function items inside it that branch (a function literal at line 731, a function literal at line 366, a function literal at line 788, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 30) · ×1
  • (anonymous) (cyclomatic 30) src/skin/js/plugins/Plugins.js:1 — (anonymous) has cyclomatic complexity 30 (threshold 15). Most of this is not in the body itself: 2 of the 30 points are its own statements and the rest belongs to 38 function items inside it that branch (a function literal at line 193, showPluginUpdates, a function literal at line 216, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · CalendarV2Controller.getAllCalendarsForUser (cyclomatic 29) · ×1
  • CalendarV2Controller.getAllCalendarsForUser (cyclomatic 29) src/EcclesiaCRM/APIControllers/CalendarV2Controller.php:160 — CalendarV2Controller.getAllCalendarsForUser has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · CalendarService.createEventForCalendar (cyclomatic 29) · ×1
  • CalendarService.createEventForCalendar (cyclomatic 29) src/EcclesiaCRM/Service/CalendarService.php:1603 — CalendarService.createEventForCalendar has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · CalDavPDO.calendarQuery (cyclomatic 29) · ×1
  • CalDavPDO.calendarQuery (cyclomatic 29) src/EcclesiaCRM/sabre/CalDav/CalDavPDO.php:949 — CalDavPDO.calendarQuery has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DocumentFileManagerController.movefiles (cyclomatic 28) · ×1
  • DocumentFileManagerController.movefiles (cyclomatic 28) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:787 — DocumentFileManagerController.movefiles has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MiscUtils.checkEmail (cyclomatic 28) · ×1
  • MiscUtils.checkEmail (cyclomatic 28) src/EcclesiaCRM/utils/MiscUtils.php:217 — MiscUtils.checkEmail has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This is NOT this file's highest cyclomatic complexity: MiscUtils.FileIcon (cyclomatic 46) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
D1 · Cyclomatic Complexity · PDFLabel.GenerateLabels (cyclomatic 28) · ×1
  • PDFLabel.GenerateLabels (cyclomatic 28) REDACTED:624 — PDFLabel.GenerateLabels has cyclomatic complexity 28 (threshold 15). This file's own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes — or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages.
D1 · Cyclomatic Complexity · CRMJSOM.CRM.edriveModalOpen (cyclomatic 28) · ×1
  • CRMJSOM.CRM.edriveModalOpen (cyclomatic 28) REDACTED:2068 — CRMJSOM.CRM.edriveModalOpen has cyclomatic complexity 28 (threshold 15). Most of this is not in the body itself: 3 of the 28 points are its own statements and the rest belongs to 6 function literals inside it that branch (lines 2153, 2221, 2120, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D1 · Cyclomatic Complexity · CartController.renderBadgePreview (cyclomatic 27) · ×1
  • CartController.renderBadgePreview (cyclomatic 27) src/EcclesiaCRM/APIControllers/CartController.php:539 — CartController.renderBadgePreview has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PeopleController.searchpeople (cyclomatic 26) · ×1
  • PeopleController.searchpeople (cyclomatic 26) src/EcclesiaCRM/APIControllers/PeopleController.php:201 — PeopleController.searchpeople has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · CardDavPDO.updateCard (cyclomatic 26) · ×1
  • CardDavPDO.updateCard (cyclomatic 26) src/EcclesiaCRM/sabre/CardDav/CardDavPDO.php:706 — CardDavPDO.updateCard has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · OutputUtils.createTimeDropdown (cyclomatic 26) · ×1
  • OutputUtils.createTimeDropdown (cyclomatic 26) src/EcclesiaCRM/utils/OutputUtils.php:695 — OutputUtils.createTimeDropdown has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · init · ×1
  • init::(anonymous)::callback (cyclomatic 26) src/skin/js/ckeditor/ckeditorextension.js:1202 — init::(anonymous)::callback has cyclomatic complexity 26 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · PhpWordHTMLExtension.parseImage (cyclomatic 25) · ×1
  • PhpWordHTMLExtension.parseImage (cyclomatic 25) src/EcclesiaCRM/utils/PhpWordHTMLExtension.php:798 — PhpWordHTMLExtension.parseImage has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · createEditor (cyclomatic 25) · ×1
  • createEditor (cyclomatic 25) src/skin/js/ckeditor/ckeditorextension.js:1284 — createEditor has cyclomatic complexity 25 (threshold 15). Most of this is not in the body itself: 11 of the 25 points are its own statements and the rest belongs to 10 function items inside it that branch (a function literal at line 1325, a function literal at line 1303, a function literal at line 1313, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 25) · ×1
  • (anonymous) (cyclomatic 25) src/skin/js/event/Checkin.js:12 — (anonymous) has cyclomatic complexity 25 (threshold 15). Most of this is not in the body itself: 2 of the 25 points are its own statements and the rest belongs to 49 function items inside it that branch (renderAttendanceButton, render, setToggleButtonState, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · EmailUsers.renderPerson (cyclomatic 24) · ×1
  • EmailUsers.renderPerson (cyclomatic 24) REDACTED:520 — EmailUsers.renderPerson has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PDF_RealAttendance.render (cyclomatic 24) · ×1
  • PDF_RealAttendance.render (cyclomatic 24) src/EcclesiaCRM/Reports/PDF_RealAttendance.php:54 — PDF_RealAttendance.render has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PersonCustomSearchRes.buildSearch (cyclomatic 24) · ×1
  • PersonCustomSearchRes.buildSearch (cyclomatic 24) src/EcclesiaCRM/Search/PersonCustomSearchRes.php:33 — PersonCustomSearchRes.buildSearch has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PastoralCareService.stats (cyclomatic 24) · ×1
  • PastoralCareService.stats (cyclomatic 24) src/EcclesiaCRM/Service/PastoralCareService.php:407 — PastoralCareService.stats has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · AddressSearchRes.buildSearch (cyclomatic 23) · ×1
  • AddressSearchRes.buildSearch (cyclomatic 23) src/EcclesiaCRM/Search/AddressSearchRes.php:28 — AddressSearchRes.buildSearch has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DashboardItemService.getDetails (cyclomatic 23) · ×1
  • DashboardItemService.getDetails (cyclomatic 23) src/EcclesiaCRM/Service/DashboardItemService.php:23 — DashboardItemService.getDetails has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · VIEWPeopleController.argumentsPeopleGeoPageArray (cyclomatic 23) · ×1
  • VIEWPeopleController.argumentsPeopleGeoPageArray (cyclomatic 23) REDACTED:1143 — VIEWPeopleController.argumentsPeopleGeoPageArray has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MiscUtils.sqlCustomField (cyclomatic 23) · ×1
  • MiscUtils.sqlCustomField (cyclomatic 23) src/EcclesiaCRM/utils/MiscUtils.php:115 — MiscUtils.sqlCustomField has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This is NOT this file's highest cyclomatic complexity: MiscUtils.FileIcon (cyclomatic 46) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
D1 · Cyclomatic Complexity · OutputUtils.displayCustomField (cyclomatic 23) · ×1
  • OutputUtils.displayCustomField (cyclomatic 23) src/EcclesiaCRM/utils/OutputUtils.php:188 — OutputUtils.displayCustomField has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · VolunteerOpportunityController.getMembers (cyclomatic 22) · ×1
  • VolunteerOpportunityController.getMembers (cyclomatic 22) src/EcclesiaCRM/APIControllers/VolunteerOpportunityController.php:354 — VolunteerOpportunityController.getMembers has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DepositSearchRes.buildSearch (cyclomatic 22) · ×1
  • DepositSearchRes.buildSearch (cyclomatic 22) src/EcclesiaCRM/Search/DepositSearchRes.php:53 — DepositSearchRes.buildSearch has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SundaySchoolDashboardItem.getDetails (cyclomatic 22) · ×1
  • SundaySchoolDashboardItem.getDetails (cyclomatic 22) src/EcclesiaCRM/Synchronize/SundaySchoolDashboardItem.php:36 — SundaySchoolDashboardItem.getDetails has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Plugin.getPluginSecurityName (cyclomatic 22) · ×1
  • Plugin.getPluginSecurityName (cyclomatic 22) src/EcclesiaCRM/model/EcclesiaCRM/Plugin.php:23 — Plugin.getPluginSecurityName has cyclomatic complexity 22 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · restore.renderRestoreProgress (cyclomatic 22) · ×1
  • restore.renderRestoreProgress (cyclomatic 22) src/skin/js/backup/restore.js:35 — restore.renderRestoreProgress has cyclomatic complexity 22 (threshold 15). Of this number, 15 points are the body's own statements and 7 belong to one function literal inside it that branches. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 22) · ×1
  • (anonymous) (cyclomatic 22) src/skin/js/fundraiser/paddleNumList.js:1 — (anonymous) has cyclomatic complexity 22 (threshold 15). Most of this is not in the body itself: 1 of the 22 points is its own statement and the rest belongs to 31 function items inside it that branch (a function literal at line 59, createOrEditBuyer, updateCountBadge, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · CSV_RealAttendance.render (cyclomatic 21) · ×1
  • CSV_RealAttendance.render (cyclomatic 21) src/EcclesiaCRM/Reports/CSV_RealAttendance.php:48 — CSV_RealAttendance.render has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PDF_Directory.sGetHeadString (cyclomatic 21) · ×1
  • PDF_Directory.sGetHeadString (cyclomatic 21) src/EcclesiaCRM/Reports/PDF_Directory.php:345 — PDF_Directory.sGetHeadString has cyclomatic complexity 21 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · PersonGroupManagerSearchRes.buildSearch (cyclomatic 21) · ×1
  • PersonGroupManagerSearchRes.buildSearch (cyclomatic 21) src/EcclesiaCRM/Search/PersonGroupManagerSearchRes.php:33 — PersonGroupManagerSearchRes.buildSearch has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · User.allSecuritiesBits (cyclomatic 21) · ×1
  • User.allSecuritiesBits (cyclomatic 21) src/EcclesiaCRM/model/EcclesiaCRM/User.php:1265 — User.allSecuritiesBits has cyclomatic complexity 21 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages. This is NOT this file's highest cyclomatic complexity: User.isSecurityEnableForPlugin (cyclomatic 22) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
D1 · Cyclomatic Complexity · InputUtils.validateCustomField (cyclomatic 21) · ×1
  • InputUtils.validateCustomField (cyclomatic 21) src/EcclesiaCRM/utils/InputUtils.php:314 — InputUtils.validateCustomField has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · OutputUtils.FormatFullName (cyclomatic 21) · ×1
  • OutputUtils.FormatFullName (cyclomatic 21) src/EcclesiaCRM/utils/OutputUtils.php:763 — OutputUtils.FormatFullName has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · NewsDashboard.doInsert (cyclomatic 21) · ×1
  • NewsDashboard.doInsert (cyclomatic 21) src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:874 — NewsDashboard.doInsert has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · createFileDropPlugin (cyclomatic 21) · ×1
  • createFileDropPlugin (cyclomatic 21) src/skin/js/ckeditor/ckeditorextension.js:353 — createFileDropPlugin has cyclomatic complexity 21 (threshold 15). Most of this is not in the body itself: 1 of the 21 points is its own statement and the rest belongs to 22 function items inside it that branch (a function literal at line 361, a function literal at line 431, a function literal at line 412, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 21) · ×1
  • (anonymous) (cyclomatic 21) src/skin/js/volunteer/VolunteerOpportunityView.js:1 — (anonymous) has cyclomatic complexity 21 (threshold 15). Most of this is not in the body itself: 1 of the 21 points is its own statement and the rest belongs to 61 function items inside it that branch (initDataTable::render, initDataTable::render, initDataTable::render, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · DocumentFileManagerController.renameFile (cyclomatic 20) · ×1
  • DocumentFileManagerController.renameFile (cyclomatic 20) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:990 — DocumentFileManagerController.renameFile has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SharedDocumentService.resolve (cyclomatic 20) · ×1
  • SharedDocumentService.resolve (cyclomatic 20) src/EcclesiaCRM/Service/SharedDocumentService.php:12 — SharedDocumentService.resolve has cyclomatic complexity 20 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · VIEWUserController.argumentsRenderChangePasswordArray (cyclomatic 20) · ×1
  • VIEWUserController.argumentsRenderChangePasswordArray (cyclomatic 20) src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:998 — VIEWUserController.argumentsRenderChangePasswordArray has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · OutputUtils.securityFilter (cyclomatic 20) · ×1
  • OutputUtils.securityFilter (cyclomatic 20) src/EcclesiaCRM/utils/OutputUtils.php:111 — OutputUtils.securityFilter has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MailchimpController.searchList (cyclomatic 20) · ×1
  • MailchimpController.searchList (cyclomatic 20) src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:52 — MailchimpController.searchList has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · CRMFileDropUpload.init (cyclomatic 20) · ×1
  • CRMFileDropUpload.init (cyclomatic 20) src/skin/js/ckeditor/ckeditorextension.js:359 — CRMFileDropUpload.init has cyclomatic complexity 20 (threshold 15). Most of this is not in the body itself: 1 of the 20 points is its own statement and the rest belongs to 9 function literals inside it that branch (lines 361, 431, 412, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D1 · Cyclomatic Complexity · DocumentCollaboraController.edit (cyclomatic 19) · ×1
  • DocumentCollaboraController.edit (cyclomatic 19) src/EcclesiaCRM/APIControllers/DocumentCollaboraController.php:38 — DocumentCollaboraController.edit has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DocumentFileManagerController.uploadFile (cyclomatic 19) · ×1
  • DocumentFileManagerController.uploadFile (cyclomatic 19) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:1066 — DocumentFileManagerController.uploadFile has cyclomatic complexity 19 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · SearchController.extractCartResultIds (cyclomatic 19) · ×1
  • SearchController.extractCartResultIds (cyclomatic 19) src/EcclesiaCRM/APIControllers/SearchController.php:215 — SearchController.extractCartResultIds has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SidebarSystemSettingsController.saveSettings (cyclomatic 19) · ×1
  • SidebarSystemSettingsController.saveSettings (cyclomatic 19) src/EcclesiaCRM/APIControllers/SidebarSystemSettingsController.php:32 — SidebarSystemSettingsController.saveSettings has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SystemGDRPController.setGdprComment (cyclomatic 19) · ×1
  • SystemGDRPController.setGdprComment (cyclomatic 19) src/EcclesiaCRM/APIControllers/SystemGDRPController.php:78 — SystemGDRPController.setGdprComment has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · TimelineService.noteToTimelineItem (cyclomatic 19) · ×1
  • TimelineService.noteToTimelineItem (cyclomatic 19) src/EcclesiaCRM/Service/TimelineService.php:207 — TimelineService.noteToTimelineItem has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LabelUtils.FontSelect (cyclomatic 19) · ×1
  • LabelUtils.FontSelect (cyclomatic 19) src/EcclesiaCRM/utils/LabelUtils.php:9 — LabelUtils.FontSelect has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MiscUtils.RenderDOMNode (cyclomatic 19) · ×1
  • MiscUtils.RenderDOMNode (cyclomatic 19) src/EcclesiaCRM/utils/MiscUtils.php:1888 — MiscUtils.RenderDOMNode has cyclomatic complexity 19 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions. This is NOT this file's highest cyclomatic complexity: MiscUtils.FileIcon (cyclomatic 46) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
D1 · Cyclomatic Complexity · MailChimpParams.doInsert (cyclomatic 19) · ×1
  • MailChimpParams.doInsert (cyclomatic 19) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:866 — MailChimpParams.doInsert has cyclomatic complexity 19 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · NewsDashboard.hydrate (cyclomatic 19) · ×1
  • NewsDashboard.hydrate (cyclomatic 19) src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:645 — NewsDashboard.hydrate has cyclomatic complexity 19 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · PDFBadgeGroup.GenerateLabels (cyclomatic 19) · ×1
  • PDFBadgeGroup.GenerateLabels (cyclomatic 19) src/Reports/PDFBadgeGroup.php:33 — PDFBadgeGroup.GenerateLabels has cyclomatic complexity 19 (threshold 15). This file's own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes — or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages.
D1 · Cyclomatic Complexity · csvImport.ParseDate (cyclomatic 19) · ×1
  • csvImport.ParseDate (cyclomatic 19) REDACTED:1031 — csvImport.ParseDate has cyclomatic complexity 19 (threshold 15). This file's own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes — or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages.
D1 · Cyclomatic Complexity · CartController.cartOperation (cyclomatic 18) · ×1
  • CartController.cartOperation (cyclomatic 18) src/EcclesiaCRM/APIControllers/CartController.php:57 — CartController.cartOperation has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · DocumentCollaboraController.resolveSharedAlias (cyclomatic 18) · ×1
  • DocumentCollaboraController.resolveSharedAlias (cyclomatic 18) src/EcclesiaCRM/APIControllers/DocumentCollaboraController.php:119 — DocumentCollaboraController.resolveSharedAlias has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · FundraiserController.donatedItemSubmitFundraiser (cyclomatic 18) · ×1
  • FundraiserController.donatedItemSubmitFundraiser (cyclomatic 18) src/EcclesiaCRM/APIControllers/FundraiserController.php:350 — FundraiserController.donatedItemSubmitFundraiser has cyclomatic complexity 18 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · PeopleGroupController.groupSundaySchool (cyclomatic 18) · ×1
  • PeopleGroupController.groupSundaySchool (cyclomatic 18) src/EcclesiaCRM/APIControllers/PeopleGroupController.php:807 — PeopleGroupController.groupSundaySchool has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PeopleGroupController.renderBadge (cyclomatic 18) · ×1
  • PeopleGroupController.renderBadge (cyclomatic 18) src/EcclesiaCRM/APIControllers/PeopleGroupController.php:942 — PeopleGroupController.renderBadge has cyclomatic complexity 18 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · PDF_Badge.Add_PDF_Badge_Titles (cyclomatic 18) · ×1
  • PDF_Badge.Add_PDF_Badge_Titles (cyclomatic 18) src/EcclesiaCRM/Reports/PDF_Badge.php:95 — PDF_Badge.Add_PDF_Badge_Titles has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages. This shape REPEATS in the file: one other method here (PDF_Badge.Add_PDF_Badge) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D1 · Cyclomatic Complexity · PDF_Badge.Add_PDF_Badge (cyclomatic 18) · ×1
  • PDF_Badge.Add_PDF_Badge (cyclomatic 18) src/EcclesiaCRM/Reports/PDF_Badge.php:253 — PDF_Badge.Add_PDF_Badge has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages. This shape REPEATS in the file: one other method here (PDF_Badge.Add_PDF_Badge_Titles) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D1 · Cyclomatic Complexity · FamilyCustomSearchRes.buildSearch (cyclomatic 18) · ×1
  • FamilyCustomSearchRes.buildSearch (cyclomatic 18) src/EcclesiaCRM/Search/FamilyCustomSearchRes.php:30 — FamilyCustomSearchRes.buildSearch has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ConfirmReportService.getPersonStandardTextFields (cyclomatic 18) · ×1
  • ConfirmReportService.getPersonStandardTextFields (cyclomatic 18) src/EcclesiaCRM/Service/ConfirmReportService.php:130 — ConfirmReportService.getPersonStandardTextFields has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · VIEWPeopleController.argumentsPeopleFamilyViewArray (cyclomatic 18) · ×1
  • VIEWPeopleController.argumentsPeopleFamilyViewArray (cyclomatic 18) REDACTED:828 — VIEWPeopleController.argumentsPeopleFamilyViewArray has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ToDoListDashboardItem.doInsert (cyclomatic 18) · ×1
  • ToDoListDashboardItem.doInsert (cyclomatic 18) src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:843 — ToDoListDashboardItem.doInsert has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · CanvassReports.CanvassBriefingSheets (cyclomatic 18) · ×1
  • CanvassReports.CanvassBriefingSheets (cyclomatic 18) src/Reports/CanvassReports.php:155 — CanvassReports.CanvassBriefingSheets has cyclomatic complexity 18 (threshold 15). This file's own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes — or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages.
D1 · Cyclomatic Complexity · settings.document.addEventListener("DOMContentLoaded") (cyclomatic 18) · ×1
  • settings.document.addEventListener("DOMContentLoaded") (cyclomatic 18) src/Plugins/MailChimp/skin/js/settings.js:1 — settings.document.addEventListener("DOMContentLoaded") has cyclomatic complexity 18 (threshold 15). Most of this is not in the body itself: 5 of the 18 points are its own statements and the rest belongs to 6 function items inside it that branch (updateDirtyState, a function literal at line 90, showSavedState, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · APIRequest (cyclomatic 18) · ×1
  • APIRequest (cyclomatic 18) REDACTED:5 — APIRequest has cyclomatic complexity 18 (threshold 15). Most of this is not in the body itself: 4 of the 18 points are its own statements and the rest belongs to 3 function literals inside it that branch (lines 22, 55, 61). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D1 · Cyclomatic Complexity · DocumentWopiController.resolveSharedAlias (cyclomatic 17) · ×1
  • DocumentWopiController.resolveSharedAlias (cyclomatic 17) src/EcclesiaCRM/APIControllers/DocumentWopiController.php:184 — DocumentWopiController.resolveSharedAlias has cyclomatic complexity 17 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · PeoplePersonController.activateDeacticate (cyclomatic 17) · ×1
  • PeoplePersonController.activateDeacticate (cyclomatic 17) REDACTED:502 — PeoplePersonController.activateDeacticate has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · FamilyPastoralCareSearchRes.buildSearch (cyclomatic 17) · ×1
  • FamilyPastoralCareSearchRes.buildSearch (cyclomatic 17) src/EcclesiaCRM/Search/FamilyPastoralCareSearchRes.php:28 — FamilyPastoralCareSearchRes.buildSearch has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MailChimpParams.hydrate (cyclomatic 17) · ×1
  • MailChimpParams.hydrate (cyclomatic 17) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:643 — MailChimpParams.hydrate has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · MailChimpParamsQuery.findPk (cyclomatic 17) · ×1
  • MailChimpParamsQuery.findPk (cyclomatic 17) src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:141 — MailChimpParamsQuery.findPk has cyclomatic complexity 17 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · PersonJitsiMeetingQuery.findPk (cyclomatic 17) · ×1
  • PersonJitsiMeetingQuery.findPk (cyclomatic 17) src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeetingQuery.php:123 — PersonJitsiMeetingQuery.findPk has cyclomatic complexity 17 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · PersonLastJitsiMeetingQuery.findPk (cyclomatic 17) · ×1
  • PersonLastJitsiMeetingQuery.findPk (cyclomatic 17) src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeetingQuery.php:117 — PersonLastJitsiMeetingQuery.findPk has cyclomatic complexity 17 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · PluginPrefJitsiMeetingQuery.findPk (cyclomatic 17) · ×1
  • PluginPrefJitsiMeetingQuery.findPk (cyclomatic 17) src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeetingQuery.php:129 — PluginPrefJitsiMeetingQuery.findPk has cyclomatic complexity 17 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · NewsDashboardQuery.findPk (cyclomatic 17) · ×1
  • NewsDashboardQuery.findPk (cyclomatic 17) src/Plugins/NewsDashboard/core/model/Base/NewsDashboardQuery.php:141 — NewsDashboardQuery.findPk has cyclomatic complexity 17 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · NoteDashboardQuery.findPk (cyclomatic 17) · ×1
  • NoteDashboardQuery.findPk (cyclomatic 17) src/Plugins/NoteDashboard/core/model/Base/NoteDashboardQuery.php:117 — NoteDashboardQuery.findPk has cyclomatic complexity 17 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · ToDoListDashboardItemQuery.findPk (cyclomatic 17) · ×1
  • ToDoListDashboardItemQuery.findPk (cyclomatic 17) src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItemQuery.php:135 — ToDoListDashboardItemQuery.findPk has cyclomatic complexity 17 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · ToDoListDashboardQuery.findPk (cyclomatic 17) · ×1
  • ToDoListDashboardQuery.findPk (cyclomatic 17) src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardQuery.php:123 — ToDoListDashboardQuery.findPk has cyclomatic complexity 17 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · EventEditor.createEventEditorWindow (cyclomatic 17) · ×1
  • EventEditor.createEventEditorWindow (cyclomatic 17) src/skin/js/calendar/EventEditor.js:822 — EventEditor.createEventEditorWindow has cyclomatic complexity 17 (threshold 15). Most of this is not in the body itself: 7 of the 17 points are its own statements and the rest belongs to 2 function literals inside it that branch (lines 868, 972). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D1 · Cyclomatic Complexity · DocumentFileManagerController.deleteFiles (cyclomatic 16) · ×1
  • DocumentFileManagerController.deleteFiles (cyclomatic 16) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:695 — DocumentFileManagerController.deleteFiles has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PeopleAttendeesController.attendeesGroups (cyclomatic 16) · ×1
  • PeopleAttendeesController.attendeesGroups (cyclomatic 16) src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:648 — PeopleAttendeesController.attendeesGroups has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SearchController.getSearchResultByName (cyclomatic 16) · ×1
  • SearchController.getSearchResultByName (cyclomatic 16) src/EcclesiaCRM/APIControllers/SearchController.php:302 — SearchController.getSearchResultByName has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MenuBar.addPluginMenus (cyclomatic 16) · ×1
  • MenuBar.addPluginMenus (cyclomatic 16) src/EcclesiaCRM/MenuBar/MenuBar.php:48 — MenuBar.addPluginMenus has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · FamilyPropsSearchRes.buildSearch (cyclomatic 16) · ×1
  • FamilyPropsSearchRes.buildSearch (cyclomatic 16) src/EcclesiaCRM/Search/FamilyPropsSearchRes.php:34 — FamilyPropsSearchRes.buildSearch has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PersonAssignToGroupSearchRes.buildSearch (cyclomatic 16) · ×1
  • PersonAssignToGroupSearchRes.buildSearch (cyclomatic 16) src/EcclesiaCRM/Search/PersonAssignToGroupSearchRes.php:34 — PersonAssignToGroupSearchRes.buildSearch has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PersonPastoralCareSearchRes.buildSearch (cyclomatic 16) · ×1
  • PersonPastoralCareSearchRes.buildSearch (cyclomatic 16) src/EcclesiaCRM/Search/PersonPastoralCareSearchRes.php:32 — PersonPastoralCareSearchRes.buildSearch has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PersonPropsSearchRes.buildSearch (cyclomatic 16) · ×1
  • PersonPropsSearchRes.buildSearch (cyclomatic 16) src/EcclesiaCRM/Search/PersonPropsSearchRes.php:37 — PersonPropsSearchRes.buildSearch has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · VIEWUserController.argumentsrenderUserSettingsArray (cyclomatic 16) · ×1
  • VIEWUserController.argumentsrenderUserSettingsArray (cyclomatic 16) src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:103 — VIEWUserController.argumentsrenderUserSettingsArray has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · OutputUtils.FormatBirthDate (cyclomatic 16) · ×1
  • OutputUtils.FormatBirthDate (cyclomatic 16) src/EcclesiaCRM/utils/OutputUtils.php:635 — OutputUtils.FormatBirthDate has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ToDoListDashboardItem.hydrate (cyclomatic 16) · ×1
  • ToDoListDashboardItem.hydrate (cyclomatic 16) src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:620 — ToDoListDashboardItem.hydrate has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 16) · ×1
  • (anonymous) (cyclomatic 16) src/skin/js/system/SettingsIndividual.js:1 — (anonymous) has cyclomatic complexity 16 (threshold 15). Most of this is not in the body itself: 6 of the 16 points are its own statements and the rest belongs to 20 function items inside it that branch (a function literal at line 142, a function literal at line 167, a function literal at line 207, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · CalendarService.realEvents (cognitive 499) · ×1
  • CalendarService.realEvents (cognitive 499) src/EcclesiaCRM/Service/CalendarService.php:155 — CalendarService.realEvents has cognitive complexity 499 (threshold 15). Drivers by points: if/else 81 (381 pts), loops 11 (66 pts), ternaries 7 (36 pts), boolean chains 16 (nesting depth added 384). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · CalendarEventV2Controller.manageEvent (cognitive 287) · ×1
  • CalendarEventV2Controller.manageEvent (cognitive 287) src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:335 — CalendarEventV2Controller.manageEvent has cognitive complexity 287 (threshold 15). Drivers by points: if/else 56 (213 pts), loops 7 (41 pts), boolean chains 25, ternaries 2 (8 pts) (nesting depth added 197). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · PDF_ConfirmReport.run (cognitive 251) · ×1
  • PDF_ConfirmReport.run (cognitive 251) REDACTED:332 — PDF_ConfirmReport.run has cognitive complexity 251 (threshold 15). Drivers by points: if/else 63 (180 pts), loops 11 (40 pts), ternaries 4 (17 pts), boolean chains 14 (nesting depth added 159). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · VIEWUserController.argumentsrenderUserEditorArray (cognitive 235) · ×1
  • VIEWUserController.argumentsrenderUserEditorArray (cognitive 235) src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:291 — VIEWUserController.argumentsrenderUserEditorArray has cognitive complexity 235 (threshold 15). Drivers by points: if/else 96 (226 pts), loops 3 (5 pts), boolean chains 4 (nesting depth added 132). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · VIEWDepositController.argumentsPledgeEditorArray (cognitive 233) · ×1
  • VIEWDepositController.argumentsPledgeEditorArray (cognitive 233) src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:477 — VIEWDepositController.argumentsPledgeEditorArray has cognitive complexity 233 (threshold 15). Drivers by points: if/else 89 (199 pts), boolean chains 21, loops 6 (13 pts) (nesting depth added 117). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · PersonSearchRes.buildSearch (cognitive 228) · ×1
  • PersonSearchRes.buildSearch (cognitive 228) src/EcclesiaCRM/Search/PersonSearchRes.php:51 — PersonSearchRes.buildSearch has cognitive complexity 228 (threshold 15). Drivers by points: if/else 42 (142 pts), ternaries 9 (47 pts), loops 5 (25 pts), boolean chains 12, error handling 1 (2 pts) (nesting depth added 159). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · CalendarService.getEventsOld (cognitive 226) · ×1
  • CalendarService.getEventsOld (cognitive 226) src/EcclesiaCRM/Service/CalendarService.php:815 — CalendarService.getEventsOld has cognitive complexity 226 (threshold 15). Drivers by points: if/else 48 (157 pts), loops 9 (32 pts), boolean chains 22, ternaries 4 (15 pts) (nesting depth added 143). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · (anonymous) (cognitive 155) · ×1
  • (anonymous) (cognitive 155) src/Plugins/MailChimp/skin/js/ManageList.js:11 — (anonymous) has cognitive complexity 155 (threshold 15). Drivers by points: if/else 82 (116 pts), ternaries 4 (16 pts), boolean chains 12, loops 5 (11 pts) (nesting depth added 52). None of this is in the body itself: all 155 points belong to 111 function items inside it that branch (a function literal at line 58, a function literal at line 660, a function literal at line 599, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · (anonymous) (cognitive 154) · ×1
  • (anonymous) (cognitive 154) src/skin/js/people/PersonView.js:1 — (anonymous) has cognitive complexity 154 (threshold 15). Drivers by points: if/else 74 (89 pts), boolean chains 51, ternaries 8, loops 3 (5 pts), match/switch 1 (nesting depth added 17). None of this is in the body itself: all 154 points belong to 165 function items inside it that branch (a function literal at line 1549, setButtonBusy, openConfirmDialog, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · DocumentFileManagerController.movefiles (cognitive 129) · ×1
  • DocumentFileManagerController.movefiles (cognitive 129) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:787 — DocumentFileManagerController.movefiles has cognitive complexity 129 (threshold 15). Drivers by points: if/else 27 (108 pts), loops 3 (17 pts), boolean chains 4 (nesting depth added 95). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · VObjectExtract.calendarData (cognitive 126) · ×1
  • VObjectExtract.calendarData (cognitive 126) src/EcclesiaCRM/sabre/CalDav/VObjectExtract.php:23 — VObjectExtract.calendarData has cognitive complexity 126 (threshold 15). Drivers by points: if/else 30 (99 pts), loops 4 (15 pts), ternaries 2 (6 pts), boolean chains 5, error handling 1 (nesting depth added 84). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · MenuEventsCount.getNumberEventsOfToday (cognitive 124) · ×1
  • MenuEventsCount.getNumberEventsOfToday (cognitive 124) src/EcclesiaCRM/dto/MenuEventsCount.php:46 — MenuEventsCount.getNumberEventsOfToday has cognitive complexity 124 (threshold 15). Drivers by points: if/else 13 (85 pts), boolean chains 20, loops 4 (12 pts), match/switch 1 (7 pts) (nesting depth added 86). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MenuBar.addSundaySchoolGroups (cognitive 117) · ×1
  • MenuBar.addSundaySchoolGroups (cognitive 117) src/EcclesiaCRM/MenuBar/MenuBar.php:533 — MenuBar.addSundaySchoolGroups has cognitive complexity 117 (threshold 15). Drivers by points: if/else 19 (80 pts), loops 9 (34 pts), boolean chains 3 (nesting depth added 86). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · GroupSearchRes.buildSearch (cognitive 106) · ×1
  • GroupSearchRes.buildSearch (cognitive 106) src/EcclesiaCRM/Search/GroupSearchRes.php:29 — GroupSearchRes.buildSearch has cognitive complexity 106 (threshold 15). Drivers by points: if/else 16 (39 pts), ternaries 8 (37 pts), loops 4 (16 pts), match/switch 2 (9 pts), boolean chains 3, error handling 1 (2 pts) (nesting depth added 72). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · MenuBar.addGroups (cognitive 99) · ×1
  • MenuBar.addGroups (cognitive 99) src/EcclesiaCRM/MenuBar/MenuBar.php:279 — MenuBar.addGroups has cognitive complexity 99 (threshold 15). Drivers by points: if/else 20 (66 pts), loops 10 (30 pts), boolean chains 3 (nesting depth added 66). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · (anonymous) (cognitive 97) · ×1
  • (anonymous) (cognitive 97) REDACTED:1 — (anonymous) has cognitive complexity 97 (threshold 15). Drivers by points: if/else 57 (69 pts), ternaries 12 (18 pts), boolean chains 6, loops 3, match/switch 1 (nesting depth added 18). None of this is in the body itself: all 97 points belong to 88 function items inside it that branch (a function literal at line 43, render, render, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · FamilySearchRes.buildSearch (cognitive 95) · ×1
  • FamilySearchRes.buildSearch (cognitive 95) src/EcclesiaCRM/Search/FamilySearchRes.php:30 — FamilySearchRes.buildSearch has cognitive complexity 95 (threshold 15). Drivers by points: if/else 14 (39 pts), ternaries 6 (29 pts), loops 3 (15 pts), boolean chains 10, error handling 1 (2 pts) (nesting depth added 61). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · EmailUsers.renderAndSend (cognitive 91) · ×1
  • EmailUsers.renderAndSend (cognitive 91) REDACTED:759 — EmailUsers.renderAndSend has cognitive complexity 91 (threshold 15). Drivers by points: if/else 24 (71 pts), boolean chains 11, loops 3 (9 pts) (nesting depth added 53). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · (anonymous) (cognitive 90) · ×1
  • (anonymous) (cognitive 90) src/skin/js/Search/Search.js:1 — (anonymous) has cognitive complexity 90 (threshold 15). Drivers by points: if/else 48 (57 pts), boolean chains 15, ternaries 8 (10 pts), loops 4 (8 pts) (nesting depth added 15). Most of this is not in the body itself: 6 of the 90 points are its own statements and the rest belongs to 94 function items inside it that branch (render, a function literal at line 387, a function literal at line 39, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · ChurchInfoReportTCPDF.setFont (cognitive 89) · ×1
  • ChurchInfoReportTCPDF.setFont (cognitive 89) src/EcclesiaCRM/Reports/ChurchInfoReportTCPDF.php:75 — ChurchInfoReportTCPDF.setFont has cognitive complexity 89 (threshold 15). Drivers by points: if/else 23 (89 pts) (nesting depth added 66). This file's own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes — or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages.
D2 · Cognitive Complexity · SystemGDRPController.setGdprComment (cognitive 87) · ×1
  • SystemGDRPController.setGdprComment (cognitive 87) src/EcclesiaCRM/APIControllers/SystemGDRPController.php:78 — SystemGDRPController.setGdprComment has cognitive complexity 87 (threshold 15). Drivers by points: if/else 22 (85 pts), boolean chains 2 (nesting depth added 63). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · MiscUtils.checkEmail (cognitive 87) · ×1
  • MiscUtils.checkEmail (cognitive 87) src/EcclesiaCRM/utils/MiscUtils.php:217 — MiscUtils.checkEmail has cognitive complexity 87 (threshold 15). Drivers by points: if/else 22 (69 pts), loops 3 (14 pts), boolean chains 4 (nesting depth added 58). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · DepositSearchRes.buildSearch (cognitive 85) · ×1
  • DepositSearchRes.buildSearch (cognitive 85) src/EcclesiaCRM/Search/DepositSearchRes.php:53 — DepositSearchRes.buildSearch has cognitive complexity 85 (threshold 15). Drivers by points: if/else 14 (57 pts), loops 5 (21 pts), error handling 2 (6 pts), boolean chains 1 (nesting depth added 63). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · PDF_Attendance.DrawRealAttendanceCalendar (cognitive 84) · ×1
  • PDF_Attendance.DrawRealAttendanceCalendar (cognitive 84) src/EcclesiaCRM/Reports/PDF_Attendance.php:365 — PDF_Attendance.DrawRealAttendanceCalendar has cognitive complexity 84 (threshold 15). Drivers by points: if/else 13 (52 pts), loops 12 (22 pts), match/switch 2 (7 pts), boolean chains 3 (nesting depth added 54). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MiscUtils.simpleEmbedFiles (cognitive 84) · ×1
  • MiscUtils.simpleEmbedFiles (cognitive 84) src/EcclesiaCRM/utils/MiscUtils.php:878 — MiscUtils.simpleEmbedFiles has cognitive complexity 84 (threshold 15). Drivers by points: if/else 29 (71 pts), loops 3 (6 pts), boolean chains 5, match/switch 1, ternaries 1 (nesting depth added 45). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SidebarGeneralRolesController.generalRoleAssign (cognitive 81) · ×1
  • SidebarGeneralRolesController.generalRoleAssign (cognitive 81) src/EcclesiaCRM/APIControllers/SidebarGeneralRolesController.php:379 — SidebarGeneralRolesController.generalRoleAssign has cognitive complexity 81 (threshold 15). Drivers by points: if/else 15 (52 pts), loops 3 (15 pts), match/switch 3 (6 pts), boolean chains 5, ternaries 1 (3 pts) (nesting depth added 54). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · SidebarGeneralRolesController.getAllGeneralRoles (cognitive 78) · ×1
  • SidebarGeneralRolesController.getAllGeneralRoles (cognitive 78) src/EcclesiaCRM/APIControllers/SidebarGeneralRolesController.php:47 — SidebarGeneralRolesController.getAllGeneralRoles has cognitive complexity 78 (threshold 15). Drivers by points: if/else 29 (57 pts), loops 6 (13 pts), boolean chains 4, match/switch 2, ternaries 1 (2 pts) (nesting depth added 36). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FamilyCustomSearchRes.buildSearch (cognitive 78) · ×1
  • FamilyCustomSearchRes.buildSearch (cognitive 78) src/EcclesiaCRM/Search/FamilyCustomSearchRes.php:30 — FamilyCustomSearchRes.buildSearch has cognitive complexity 78 (threshold 15). Drivers by points: if/else 7 (31 pts), ternaries 5 (30 pts), loops 4 (14 pts), error handling 1 (2 pts), boolean chains 1 (nesting depth added 60). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · (anonymous) (cognitive 78) · ×1
  • (anonymous) (cognitive 78) src/skin/js/people/FamilyView.js:1 — (anonymous) has cognitive complexity 78 (threshold 15). Drivers by points: if/else 49 (61 pts), boolean chains 13, ternaries 4 (nesting depth added 12). None of this is in the body itself: all 78 points belong to 89 function items inside it that branch (updateLittleButtons, a function literal at line 788, a function literal at line 338, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · CardDavPDO.updateCard (cognitive 77) · ×1
  • CardDavPDO.updateCard (cognitive 77) src/EcclesiaCRM/sabre/CardDav/CardDavPDO.php:706 — CardDavPDO.updateCard has cognitive complexity 77 (threshold 15). Drivers by points: if/else 21 (58 pts), loops 5 (17 pts), boolean chains 2 (nesting depth added 49). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · CRMEditorTools.init (cognitive 75) · ×1
  • CRMEditorTools.init (cognitive 75) src/skin/js/ckeditor/ckeditorextension.js:880 — CRMEditorTools.init has cognitive complexity 75 (threshold 15). Drivers by points: if/else 33 (48 pts), boolean chains 17, error handling 4 (6 pts), ternaries 2 (4 pts) (nesting depth added 19). Most of this is not in the body itself: 6 of the 75 points are its own statements and the rest belongs to 13 function literals inside it that branch (lines 1202, 1063, 1119, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D2 · Cognitive Complexity · PersonCustomSearchRes.buildSearch (cognitive 74) · ×1
  • PersonCustomSearchRes.buildSearch (cognitive 74) src/EcclesiaCRM/Search/PersonCustomSearchRes.php:33 — PersonCustomSearchRes.buildSearch has cognitive complexity 74 (threshold 15). Drivers by points: if/else 12 (39 pts), ternaries 4 (20 pts), loops 5 (11 pts), boolean chains 2, error handling 1 (2 pts) (nesting depth added 50). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PDF_RealAttendance.render (cognitive 73) · ×1
  • PDF_RealAttendance.render (cognitive 73) src/EcclesiaCRM/Reports/PDF_RealAttendance.php:54 — PDF_RealAttendance.render has cognitive complexity 73 (threshold 15). Drivers by points: if/else 15 (46 pts), loops 8 (22 pts), ternaries 1 (4 pts), boolean chains 1 (nesting depth added 48). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · VIEWSundaySchoolController.argumentsSundayschoolReportsArray (cognitive 71) · ×1
  • VIEWSundaySchoolController.argumentsSundayschoolReportsArray (cognitive 71) src/EcclesiaCRM/VIEWControllers/VIEWSundaySchoolController.php:143 — VIEWSundaySchoolController.argumentsSundayschoolReportsArray has cognitive complexity 71 (threshold 15). Drivers by points: if/else 24 (56 pts), boolean chains 12, loops 1 (3 pts) (nesting depth added 34). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PDF_Attendance.DrawAttendanceCalendar (cognitive 70) · ×1
  • PDF_Attendance.DrawAttendanceCalendar (cognitive 70) src/EcclesiaCRM/Reports/PDF_Attendance.php:39 — PDF_Attendance.DrawAttendanceCalendar has cognitive complexity 70 (threshold 15). Drivers by points: if/else 17 (48 pts), loops 10 (17 pts), ternaries 1 (3 pts), boolean chains 2 (nesting depth added 40). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Person.getFormattedName (cognitive 70) · ×1
  • Person.getFormattedName (cognitive 70) src/EcclesiaCRM/model/EcclesiaCRM/Person.php:663 — Person.getFormattedName has cognitive complexity 70 (threshold 15). Drivers by points: if/else 30 (60 pts), boolean chains 9, match/switch 1 (nesting depth added 30). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · EmailUsers.renderFamily (cognitive 67) · ×1
  • EmailUsers.renderFamily (cognitive 67) REDACTED:208 — EmailUsers.renderFamily has cognitive complexity 67 (threshold 15). Drivers by points: if/else 23 (49 pts), loops 8 (14 pts), ternaries 2 (3 pts), boolean chains 1 (nesting depth added 33). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PDFLabel.ZipBundleSort (cognitive 67) · ×1
  • PDFLabel.ZipBundleSort (cognitive 67) REDACTED:243 — PDFLabel.ZipBundleSort has cognitive complexity 67 (threshold 15). Drivers by points: if/else 25 (45 pts), loops 13 (22 pts) (nesting depth added 29). This file's own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes — or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages.
D2 · Cognitive Complexity · PluginUpgradeService.getMigrationPlan (cognitive 66) · ×1
  • PluginUpgradeService.getMigrationPlan (cognitive 66) src/EcclesiaCRM/Service/PluginUpgradeService.php:125 — PluginUpgradeService.getMigrationPlan has cognitive complexity 66 (threshold 15). Drivers by points: if/else 14 (41 pts), boolean chains 11, loops 5 (11 pts), ternaries 1 (3 pts) (nesting depth added 35). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CalendarService.modifyEventFromCalendar (cognitive 65) · ×1
  • CalendarService.modifyEventFromCalendar (cognitive 65) src/EcclesiaCRM/Service/CalendarService.php:1877 — CalendarService.modifyEventFromCalendar has cognitive complexity 65 (threshold 15). Drivers by points: if/else 24 (40 pts), loops 3 (8 pts), boolean chains 7, error handling 2 (6 pts), ternaries 2 (4 pts) (nesting depth added 27). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CRMJSOM.CRM.edriveModalOpen (cognitive 65) · ×1
  • CRMJSOM.CRM.edriveModalOpen (cognitive 65) REDACTED:2068 — CRMJSOM.CRM.edriveModalOpen has cognitive complexity 65 (threshold 15). Drivers by points: if/else 16 (53 pts), boolean chains 11, error handling 1 (nesting depth added 37). Most of this is not in the body itself: 2 of the 65 points are its own statements and the rest belongs to 6 function literals inside it that branch (lines 2153, 2120, 2134, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D2 · Cognitive Complexity · CalendarService.createCalendarItemForGetEvents (cognitive 64) · ×1
  • CalendarService.createCalendarItemForGetEvents (cognitive 64) src/EcclesiaCRM/Service/CalendarService.php:1329 — CalendarService.createCalendarItemForGetEvents has cognitive complexity 64 (threshold 15). Drivers by points: if/else 21 (32 pts), ternaries 12 (26 pts), match/switch 2 (3 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 27). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CSV_RealAttendance.render (cognitive 63) · ×1
  • CSV_RealAttendance.render (cognitive 63) src/EcclesiaCRM/Reports/CSV_RealAttendance.php:48 — CSV_RealAttendance.render has cognitive complexity 63 (threshold 15). Drivers by points: if/else 12 (40 pts), loops 8 (22 pts), boolean chains 1 (nesting depth added 42). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AddressSearchRes.buildSearch (cognitive 63) · ×1
  • AddressSearchRes.buildSearch (cognitive 63) src/EcclesiaCRM/Search/AddressSearchRes.php:28 — AddressSearchRes.buildSearch has cognitive complexity 63 (threshold 15). Drivers by points: if/else 9 (24 pts), ternaries 5 (19 pts), loops 3 (13 pts), boolean chains 5, error handling 1 (2 pts) (nesting depth added 40). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · VIEWEdriveController.renderShares (cognitive 60) · ×1
  • VIEWEdriveController.renderShares (cognitive 60) src/EcclesiaCRM/VIEWControllers/VIEWEdriveController.php:108 — VIEWEdriveController.renderShares has cognitive complexity 60 (threshold 15). Drivers by points: ternaries 17 (32 pts), boolean chains 21, if/else 3 (4 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PersonGroupManagerSearchRes.buildSearch (cognitive 59) · ×1
  • PersonGroupManagerSearchRes.buildSearch (cognitive 59) src/EcclesiaCRM/Search/PersonGroupManagerSearchRes.php:33 — PersonGroupManagerSearchRes.buildSearch has cognitive complexity 59 (threshold 15). Drivers by points: if/else 11 (28 pts), ternaries 5 (22 pts), boolean chains 4, loops 1 (3 pts), error handling 1 (2 pts) (nesting depth added 37). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · CalendarService.createEventForCalendar (cognitive 57) · ×1
  • CalendarService.createEventForCalendar (cognitive 57) src/EcclesiaCRM/Service/CalendarService.php:1603 — CalendarService.createEventForCalendar has cognitive complexity 57 (threshold 15). Drivers by points: if/else 21 (36 pts), loops 3 (8 pts), boolean chains 5, error handling 1 (4 pts), ternaries 2 (4 pts) (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DashboardItemService.getDetails (cognitive 57) · ×1
  • DashboardItemService.getDetails (cognitive 57) src/EcclesiaCRM/Service/DashboardItemService.php:23 — DashboardItemService.getDetails has cognitive complexity 57 (threshold 15). Drivers by points: if/else 11 (37 pts), loops 4 (10 pts), boolean chains 6, ternaries 1 (4 pts) (nesting depth added 35). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · InputUtils.cleanNode (cognitive 57) · ×1
  • InputUtils.cleanNode (cognitive 57) src/EcclesiaCRM/utils/InputUtils.php:129 — InputUtils.cleanNode has cognitive complexity 57 (threshold 15). Drivers by points: if/else 15 (40 pts), boolean chains 9, loops 4 (8 pts) (nesting depth added 29). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · OutputUtils.createTimeDropdown (cognitive 57) · ×1
  • OutputUtils.createTimeDropdown (cognitive 57) src/EcclesiaCRM/utils/OutputUtils.php:695 — OutputUtils.createTimeDropdown has cognitive complexity 57 (threshold 15). Drivers by points: if/else 17 (43 pts), boolean chains 11, loops 2 (3 pts) (nesting depth added 27). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PDFLabel.GenerateLabels (cognitive 57) · ×1
  • PDFLabel.GenerateLabels (cognitive 57) REDACTED:624 — PDFLabel.GenerateLabels has cognitive complexity 57 (threshold 15). Drivers by points: if/else 17 (34 pts), loops 6 (14 pts), boolean chains 9 (nesting depth added 25). This file's own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes — or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages.
D2 · Cognitive Complexity · DocumentFileManagerController.deleteFiles (cognitive 56) · ×1
  • DocumentFileManagerController.deleteFiles (cognitive 56) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:695 — DocumentFileManagerController.deleteFiles has cognitive complexity 56 (threshold 15). Drivers by points: if/else 12 (50 pts), boolean chains 3, loops 1 (3 pts) (nesting depth added 40). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · SundaySchoolDashboardItem.getDetails (cognitive 56) · ×1
  • SundaySchoolDashboardItem.getDetails (cognitive 56) src/EcclesiaCRM/Synchronize/SundaySchoolDashboardItem.php:36 — SundaySchoolDashboardItem.getDetails has cognitive complexity 56 (threshold 15). Drivers by points: if/else 10 (36 pts), loops 4 (10 pts), boolean chains 6, ternaries 1 (4 pts) (nesting depth added 35). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · (anonymous) (cognitive 56) · ×1
  • (anonymous) (cognitive 56) src/skin/js/system/setup.js:156 — (anonymous) has cognitive complexity 56 (threshold 15). Drivers by points: if/else 30 (33 pts), boolean chains 13, ternaries 8, error handling 1, loops 1 (nesting depth added 3). Most of this is not in the body itself: 5 of the 56 points are its own statements and the rest belongs to 32 function items inside it that branch (a function literal at line 500, canMoveToStep, setConfirmPasswordValidity, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · initDataTable (cognitive 55) · ×1
  • initDataTable (cognitive 55) REDACTED:332 — initDataTable has cognitive complexity 55 (threshold 15). Drivers by points: if/else 42 (50 pts), loops 2 (3 pts), ternaries 1 (2 pts) (nesting depth added 10). Most of this is not in the body itself: 1 of the 55 points is its own statement and the rest belongs to 68 function items inside it that branch (a function literal at line 731, render, a function literal at line 788, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · (anonymous) (cognitive 55) · ×1
  • (anonymous) (cognitive 55) src/Plugins/BirthdayAnniversaryDashboard/skin/js/BirthdayAnniversaryDashboard.js:1 — (anonymous) has cognitive complexity 55 (threshold 15). Drivers by points: if/else 18 (22 pts), ternaries 16 (17 pts), boolean chains 15, error handling 1 (nesting depth added 5). None of this is in the body itself: all 55 points belong to 24 function items inside it that branch (promptActivationToggle, openPastoralNoteDialog::(anonymous)::callback, a function literal at line 101, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · PastoralCareService.stats (cognitive 53) · ×1
  • PastoralCareService.stats (cognitive 53) src/EcclesiaCRM/Service/PastoralCareService.php:407 — PastoralCareService.stats has cognitive complexity 53 (threshold 15). Drivers by points: if/else 35 (53 pts) (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · setup.document.addEventListener("DOMContentLoaded") (cognitive 53) · ×1
  • setup.document.addEventListener("DOMContentLoaded") (cognitive 53) src/skin/js/system/setup.js:156 — setup.document.addEventListener("DOMContentLoaded") has cognitive complexity 53 (threshold 15). Drivers by points: if/else 30 (33 pts), boolean chains 13, ternaries 6, loops 1 (nesting depth added 3). Most of this is not in the body itself: 5 of the 53 points are its own statements and the rest belongs to 16 function items inside it that branch (a function literal at line 500, canMoveToStep, setConfirmPasswordValidity, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · CalendarV2Controller.getAllCalendarsForUser (cognitive 52) · ×1
  • CalendarV2Controller.getAllCalendarsForUser (cognitive 52) src/EcclesiaCRM/APIControllers/CalendarV2Controller.php:160 — CalendarV2Controller.getAllCalendarsForUser has cognitive complexity 52 (threshold 15). Drivers by points: if/else 7 (18 pts), ternaries 6 (17 pts), boolean chains 12, match/switch 1 (3 pts), loops 1 (2 pts) (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DocumentFileManagerController.getPreview (cognitive 52) · ×1
  • DocumentFileManagerController.getPreview (cognitive 52) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:325 — DocumentFileManagerController.getPreview has cognitive complexity 52 (threshold 15). Drivers by points: boolean chains 35, if/else 8 (17 pts) (nesting depth added 9). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · FamilyPastoralCareSearchRes.buildSearch (cognitive 52) · ×1
  • FamilyPastoralCareSearchRes.buildSearch (cognitive 52) src/EcclesiaCRM/Search/FamilyPastoralCareSearchRes.php:28 — FamilyPastoralCareSearchRes.buildSearch has cognitive complexity 52 (threshold 15). Drivers by points: ternaries 5 (22 pts), if/else 9 (19 pts), loops 2 (8 pts), error handling 1 (2 pts), boolean chains 1 (nesting depth added 34). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · PersonAssignToGroupSearchRes.buildSearch (cognitive 52) · ×1
  • PersonAssignToGroupSearchRes.buildSearch (cognitive 52) src/EcclesiaCRM/Search/PersonAssignToGroupSearchRes.php:34 — PersonAssignToGroupSearchRes.buildSearch has cognitive complexity 52 (threshold 15). Drivers by points: if/else 10 (25 pts), ternaries 5 (22 pts), loops 1 (3 pts), error handling 1 (2 pts) (nesting depth added 35). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · (anonymous) (cognitive 52) · ×1
  • (anonymous) (cognitive 52) src/Plugins/MailChimp/skin/js/Dashboard.js:10 — (anonymous) has cognitive complexity 52 (threshold 15). Drivers by points: if/else 11 (22 pts), ternaries 4 (15 pts), loops 4 (14 pts), boolean chains 1 (nesting depth added 32). None of this is in the body itself: all 52 points belong to 13 function items inside it that branch (a function literal at line 27, render_container, createListEditorWindow::callback, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · PeopleController.searchpeople (cognitive 51) · ×1
  • PeopleController.searchpeople (cognitive 51) src/EcclesiaCRM/APIControllers/PeopleController.php:201 — PeopleController.searchpeople has cognitive complexity 51 (threshold 15). Drivers by points: if/else 14 (30 pts), loops 3 (9 pts), boolean chains 6, error handling 3 (6 pts) (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · VolunteerOpportunityController.getMembers (cognitive 51) · ×1
  • VolunteerOpportunityController.getMembers (cognitive 51) src/EcclesiaCRM/APIControllers/VolunteerOpportunityController.php:354 — VolunteerOpportunityController.getMembers has cognitive complexity 51 (threshold 15). Drivers by points: ternaries 14 (42 pts), boolean chains 5, if/else 2 (3 pts), loops 1 (nesting depth added 29). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · EmailUsers.renderPerson (cognitive 51) · ×1
  • EmailUsers.renderPerson (cognitive 51) REDACTED:520 — EmailUsers.renderPerson has cognitive complexity 51 (threshold 15). Drivers by points: if/else 19 (38 pts), loops 4 (7 pts), boolean chains 3, ternaries 2 (3 pts) (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FamilyPropsSearchRes.buildSearch (cognitive 51) · ×1
  • FamilyPropsSearchRes.buildSearch (cognitive 51) src/EcclesiaCRM/Search/FamilyPropsSearchRes.php:34 — FamilyPropsSearchRes.buildSearch has cognitive complexity 51 (threshold 15). Drivers by points: ternaries 6 (27 pts), if/else 7 (14 pts), loops 2 (8 pts), error handling 1 (2 pts) (nesting depth added 35). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · DocumentFileManagerController.renameFile (cognitive 50) · ×1
  • DocumentFileManagerController.renameFile (cognitive 50) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:990 — DocumentFileManagerController.renameFile has cognitive complexity 50 (threshold 15). Drivers by points: if/else 11 (33 pts), boolean chains 6, ternaries 2 (6 pts), loops 1 (5 pts) (nesting depth added 30). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · PeopleAttendeesController.attendeesGroups (cognitive 50) · ×1
  • PeopleAttendeesController.attendeesGroups (cognitive 50) src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:648 — PeopleAttendeesController.attendeesGroups has cognitive complexity 50 (threshold 15). Drivers by points: if/else 10 (30 pts), loops 3 (10 pts), error handling 1 (6 pts), boolean chains 4 (nesting depth added 32). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PersonPropsSearchRes.buildSearch (cognitive 50) · ×1
  • PersonPropsSearchRes.buildSearch (cognitive 50) src/EcclesiaCRM/Search/PersonPropsSearchRes.php:37 — PersonPropsSearchRes.buildSearch has cognitive complexity 50 (threshold 15). Drivers by points: if/else 9 (23 pts), ternaries 5 (22 pts), loops 1 (3 pts), error handling 1 (2 pts) (nesting depth added 34). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · CanvassReports.CanvassBriefingSheets (cognitive 50) · ×1
  • CanvassReports.CanvassBriefingSheets (cognitive 50) src/Reports/CanvassReports.php:155 — CanvassReports.CanvassBriefingSheets has cognitive complexity 50 (threshold 15). Drivers by points: if/else 13 (35 pts), loops 5 (13 pts), boolean chains 2 (nesting depth added 30). This file's own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes — or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages.
D2 · Cognitive Complexity · (anonymous) (cognitive 50) · ×1
  • (anonymous) (cognitive 50) src/skin/js/document.js:9 — (anonymous) has cognitive complexity 50 (threshold 15). Drivers by points: if/else 29 (49 pts), ternaries 1 (nesting depth added 20). None of this is in the body itself: all 50 points belong to 19 function items inside it that branch (a function literal at line 57, DocumentEditorWindow::callback, a function literal at line 12, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · PDFBadgeGroup.GenerateLabels (cognitive 49) · ×1
  • PDFBadgeGroup.GenerateLabels (cognitive 49) src/Reports/PDFBadgeGroup.php:33 — PDFBadgeGroup.GenerateLabels has cognitive complexity 49 (threshold 15). Drivers by points: if/else 13 (33 pts), loops 4 (12 pts), boolean chains 4 (nesting depth added 28). This file's own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes — or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages.
D2 · Cognitive Complexity · GroupPropsSearchRes.buildSearch (cognitive 48) · ×1
  • GroupPropsSearchRes.buildSearch (cognitive 48) src/EcclesiaCRM/Search/GroupPropsSearchRes.php:35 — GroupPropsSearchRes.buildSearch has cognitive complexity 48 (threshold 15). Drivers by points: if/else 7 (17 pts), ternaries 4 (17 pts), loops 3 (12 pts), error handling 1 (2 pts) (nesting depth added 33). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · PersonPastoralCareSearchRes.buildSearch (cognitive 48) · ×1
  • PersonPastoralCareSearchRes.buildSearch (cognitive 48) src/EcclesiaCRM/Search/PersonPastoralCareSearchRes.php:32 — PersonPastoralCareSearchRes.buildSearch has cognitive complexity 48 (threshold 15). Drivers by points: ternaries 5 (22 pts), if/else 9 (20 pts), loops 1 (3 pts), error handling 1 (2 pts), boolean chains 1 (nesting depth added 31). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · PluginsController.upgrade (cognitive 47) · ×1
  • PluginsController.upgrade (cognitive 47) src/EcclesiaCRM/APIControllers/PluginsController.php:171 — PluginsController.upgrade has cognitive complexity 47 (threshold 15). Drivers by points: if/else 7 (25 pts), loops 4 (19 pts), error handling 1 (3 pts) (nesting depth added 35). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · MenuBar.addPluginMenus (cognitive 47) · ×1
  • MenuBar.addPluginMenus (cognitive 47) src/EcclesiaCRM/MenuBar/MenuBar.php:48 — MenuBar.addPluginMenus has cognitive complexity 47 (threshold 15). Drivers by points: if/else 12 (35 pts), loops 3 (6 pts), ternaries 1 (4 pts), boolean chains 2 (nesting depth added 29). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · VIEWPeopleController.argumentsPeoplePersonViewArray (cognitive 46) · ×1
  • VIEWPeopleController.argumentsPeoplePersonViewArray (cognitive 46) REDACTED:312 — VIEWPeopleController.argumentsPeoplePersonViewArray has cognitive complexity 46 (threshold 15). Drivers by points: if/else 23 (31 pts), boolean chains 6, ternaries 6, loops 2 (3 pts) (nesting depth added 9). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · (anonymous) (cognitive 46) · ×1
  • (anonymous) (cognitive 46) src/skin/js/pastoralcare/PastoralCareDashboard.js:1 — (anonymous) has cognitive complexity 46 (threshold 15). Drivers by points: if/else 23 (25 pts), boolean chains 16, ternaries 3, match/switch 1 (2 pts) (nesting depth added 3). Most of this is not in the body itself: 1 of the 46 points is its own statement and the rest belongs to 51 function items inside it that branch (setBusyState, buildAddress, a function literal at line 541, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · PDFLabel.GroupBySalutation (cognitive 45) · ×1
  • PDFLabel.GroupBySalutation (cognitive 45) REDACTED:35 — PDFLabel.GroupBySalutation has cognitive complexity 45 (threshold 15). Drivers by points: if/else 24 (35 pts), loops 3 (6 pts), boolean chains 4 (nesting depth added 14). This file's own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes — or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages.
D2 · Cognitive Complexity · PledgeSearchRes.buildSearch (cognitive 44) · ×1
  • PledgeSearchRes.buildSearch (cognitive 44) src/EcclesiaCRM/Search/PledgeSearchRes.php:27 — PledgeSearchRes.buildSearch has cognitive complexity 44 (threshold 15). Drivers by points: if/else 10 (35 pts), loops 1 (4 pts), error handling 1 (3 pts), boolean chains 2 (nesting depth added 30). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · CalDavPDO.calendarQuery (cognitive 44) · ×1
  • CalDavPDO.calendarQuery (cognitive 44) src/EcclesiaCRM/sabre/CalDav/CalDavPDO.php:949 — CalDavPDO.calendarQuery has cognitive complexity 44 (threshold 15). Drivers by points: if/else 15 (23 pts), boolean chains 12, loops 3 (9 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AppIntegrityService.verifyPluginsIntegrity (cognitive 42) · ×1
  • AppIntegrityService.verifyPluginsIntegrity (cognitive 42) REDACTED:125 — AppIntegrityService.verifyPluginsIntegrity has cognitive complexity 42 (threshold 15). Drivers by points: if/else 11 (35 pts), loops 2 (6 pts), boolean chains 1 (nesting depth added 28). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · OutputUtils.formCustomField (cognitive 42) · ×1
  • OutputUtils.formCustomField (cognitive 42) src/EcclesiaCRM/utils/OutputUtils.php:290 — OutputUtils.formCustomField has cognitive complexity 42 (threshold 15). Drivers by points: if/else 12 (27 pts), ternaries 3 (6 pts), loops 2 (5 pts), boolean chains 3, match/switch 1 (nesting depth added 21). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · PhpWordHTMLExtension.parseImage (cognitive 42) · ×1
  • PhpWordHTMLExtension.parseImage (cognitive 42) src/EcclesiaCRM/utils/PhpWordHTMLExtension.php:798 — PhpWordHTMLExtension.parseImage has cognitive complexity 42 (threshold 15). Drivers by points: if/else 11 (28 pts), match/switch 2 (7 pts), loops 2 (4 pts), boolean chains 3 (nesting depth added 24). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · (anonymous) (cognitive 41) · ×1
  • (anonymous) (cognitive 41) src/skin/js/calendar/EventsList.js:1 — (anonymous) has cognitive complexity 41 (threshold 15). Drivers by points: if/else 29 (37 pts), ternaries 3, boolean chains 1 (nesting depth added 8). Most of this is not in the body itself: 2 of the 41 points are its own statements and the rest belongs to 42 function items inside it that branch (a function literal at line 228, a function literal at line 452, a function literal at line 194, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · TimelineService.noteToTimelineItem (cognitive 40) · ×1
  • TimelineService.noteToTimelineItem (cognitive 40) src/EcclesiaCRM/Service/TimelineService.php:207 — TimelineService.noteToTimelineItem has cognitive complexity 40 (threshold 15). Drivers by points: if/else 14 (26 pts), ternaries 3 (8 pts), boolean chains 6 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · VIEWPeopleController.argumentsPeopleGeoPageArray (cognitive 40) · ×1
  • VIEWPeopleController.argumentsPeopleGeoPageArray (cognitive 40) REDACTED:1143 — VIEWPeopleController.argumentsPeopleGeoPageArray has cognitive complexity 40 (threshold 15). Drivers by points: if/else 14 (32 pts), loops 4 (6 pts), boolean chains 2 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FinancialService.insertPledgeorPayment (cognitive 39) · ×1
  • FinancialService.insertPledgeorPayment (cognitive 39) src/EcclesiaCRM/Service/FinancialService.php:223 — FinancialService.insertPledgeorPayment has cognitive complexity 39 (threshold 15). Drivers by points: if/else 7 (23 pts), ternaries 5 (15 pts), loops 1 (nesting depth added 26). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · VIEWUserController.argumentsRenderChangePasswordArray (cognitive 38) · ×1
  • VIEWUserController.argumentsRenderChangePasswordArray (cognitive 38) src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:998 — VIEWUserController.argumentsRenderChangePasswordArray has cognitive complexity 38 (threshold 15). Drivers by points: if/else 15 (36 pts), boolean chains 2 (nesting depth added 21). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · (anonymous) (cognitive 38) · ×1
  • (anonymous) (cognitive 38) src/Plugins/MailChimp/skin/js/Campaign.js:10 — (anonymous) has cognitive complexity 38 (threshold 15). Drivers by points: if/else 25 (29 pts), boolean chains 7, ternaries 2 (nesting depth added 4). Most of this is not in the body itself: 5 of the 38 points are its own statements and the rest belongs to 12 function items inside it that branch (a function literal at line 52, a function literal at line 116, a function literal at line 81, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · PeopleGroupController.groupSundaySchool (cognitive 37) · ×1
  • PeopleGroupController.groupSundaySchool (cognitive 37) src/EcclesiaCRM/APIControllers/PeopleGroupController.php:807 — PeopleGroupController.groupSundaySchool has cognitive complexity 37 (threshold 15). Drivers by points: if/else 9 (24 pts), loops 3 (6 pts), boolean chains 4, ternaries 1 (3 pts) (nesting depth added 20). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · (anonymous) (cognitive 37) · ×1
  • (anonymous) (cognitive 37) src/skin/js/group/GroupEditor.js:1 — (anonymous) has cognitive complexity 37 (threshold 15). Drivers by points: if/else 28 (34 pts), boolean chains 3 (nesting depth added 6). None of this is in the body itself: all 37 points belong to 24 function items inside it that branch (render, render, render, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · CartController.renderBadgePreview (cognitive 36) · ×1
  • CartController.renderBadgePreview (cognitive 36) src/EcclesiaCRM/APIControllers/CartController.php:539 — CartController.renderBadgePreview has cognitive complexity 36 (threshold 15). Drivers by points: if/else 13 (21 pts), boolean chains 12, ternaries 1 (3 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PeoplePersonController.activateDeacticate (cognitive 36) · ×1
  • PeoplePersonController.activateDeacticate (cognitive 36) REDACTED:502 — PeoplePersonController.activateDeacticate has cognitive complexity 36 (threshold 15). Drivers by points: if/else 12 (29 pts), ternaries 3 (6 pts), boolean chains 1 (nesting depth added 20). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · (anonymous) (cognitive 36) · ×1
  • (anonymous) (cognitive 36) src/skin/js/finance/DepositSlipEditor.js:1 — (anonymous) has cognitive complexity 36 (threshold 15). Drivers by points: if/else 21 (23 pts), boolean chains 7, loops 4, ternaries 2 (nesting depth added 2). None of this is in the body itself: all 36 points belong to 36 function items inside it that branch (a function literal at line 97, initCharts::applyDatasetStyle, a function literal at line 154, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · SearchController.extractCartResultIds (cognitive 35) · ×1
  • SearchController.extractCartResultIds (cognitive 35) src/EcclesiaCRM/APIControllers/SearchController.php:215 — SearchController.extractCartResultIds has cognitive complexity 35 (threshold 15). Drivers by points: if/else 7 (16 pts), loops 4 (12 pts), boolean chains 7 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AppIntegrityService.verifyApplicationIntegrity (cognitive 35) · ×1
  • AppIntegrityService.verifyApplicationIntegrity (cognitive 35) REDACTED:46 — AppIntegrityService.verifyApplicationIntegrity has cognitive complexity 35 (threshold 15). Drivers by points: if/else 11 (26 pts), loops 2 (8 pts), boolean chains 1 (nesting depth added 21). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · FamilyImportUtils.AssignRoles (cognitive 35) · ×1
  • FamilyImportUtils.AssignRoles (cognitive 35) src/EcclesiaCRM/utils/CsvImportFamily.php:57 — FamilyImportUtils.AssignRoles has cognitive complexity 35 (threshold 15). Drivers by points: if/else 9 (29 pts), boolean chains 4, loops 1 (2 pts) (nesting depth added 21). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · (anonymous) (cognitive 35) · ×1
  • (anonymous) (cognitive 35) src/skin/js/plugins/Plugins.js:1 — (anonymous) has cognitive complexity 35 (threshold 15). Drivers by points: if/else 21 (27 pts), ternaries 4 (5 pts), boolean chains 2, match/switch 1 (nesting depth added 7). Most of this is not in the body itself: 2 of the 35 points are its own statements and the rest belongs to 38 function items inside it that branch (a function literal at line 193, showPluginUpdates, BootboxContent, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · User.ApplyRole (cognitive 34) · ×1
  • User.ApplyRole (cognitive 34) src/EcclesiaCRM/model/EcclesiaCRM/User.php:321 — User.ApplyRole has cognitive complexity 34 (threshold 15). Drivers by points: if/else 9 (26 pts), loops 2 (4 pts), match/switch 1 (3 pts), boolean chains 1 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · (anonymous) (cognitive 34) · ×1
  • (anonymous) (cognitive 34) src/skin/js/volunteer/VolunteerOpportunityView.js:1 — (anonymous) has cognitive complexity 34 (threshold 15). Drivers by points: if/else 33 (34 pts) (nesting depth added 1). None of this is in the body itself: all 34 points belong to 61 function items inside it that branch (initDataTable::render, initDataTable::render, initDataTable::render, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · FundraiserController.addPaddleNum (cognitive 33) · ×1
  • FundraiserController.addPaddleNum (cognitive 33) src/EcclesiaCRM/APIControllers/FundraiserController.php:113 — FundraiserController.addPaddleNum has cognitive complexity 33 (threshold 15). Drivers by points: if/else 11 (26 pts), boolean chains 4, loops 1 (3 pts) (nesting depth added 17). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · OutputUtils.FormatFullName (cognitive 33) · ×1
  • OutputUtils.FormatFullName (cognitive 33) src/EcclesiaCRM/utils/OutputUtils.php:763 — OutputUtils.FormatFullName has cognitive complexity 33 (threshold 15). Drivers by points: if/else 16 (32 pts), match/switch 1 (nesting depth added 16). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · PersonVolunteerOpportunitySearchRes.buildSearch (cognitive 32) · ×1
  • PersonVolunteerOpportunitySearchRes.buildSearch (cognitive 32) src/EcclesiaCRM/Search/PersonVolunteerOpportunitySearch.php:145 — PersonVolunteerOpportunitySearchRes.buildSearch has cognitive complexity 32 (threshold 15). Drivers by points: if/else 10 (20 pts), loops 2 (7 pts), error handling 1 (2 pts), ternaries 1 (2 pts), boolean chains 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · VIEWUserController.argumentsrenderUserSettingsArray (cognitive 32) · ×1
  • VIEWUserController.argumentsrenderUserSettingsArray (cognitive 32) src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:103 — VIEWUserController.argumentsrenderUserSettingsArray has cognitive complexity 32 (threshold 15). Drivers by points: if/else 10 (24 pts), loops 2 (4 pts), ternaries 1 (3 pts), boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Photo.photoHunt (cognitive 32) · ×1
  • Photo.photoHunt (cognitive 32) src/EcclesiaCRM/dto/Photo.php:52 — Photo.photoHunt has cognitive complexity 32 (threshold 15). Drivers by points: if/else 9 (28 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 20). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · CartController.removePersonCart (cognitive 31) · ×1
  • CartController.removePersonCart (cognitive 31) src/EcclesiaCRM/APIControllers/CartController.php:369 — CartController.removePersonCart has cognitive complexity 31 (threshold 15). Drivers by points: if/else 8 (24 pts), loops 2 (6 pts), boolean chains 1 (nesting depth added 20). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · Menu.renderMenu (cognitive 31) · ×1
  • Menu.renderMenu (cognitive 31) src/EcclesiaCRM/MenuBar/Menu.php:301 — Menu.renderMenu has cognitive complexity 31 (threshold 15). Drivers by points: if/else 8 (21 pts), loops 2 (5 pts), ternaries 2 (5 pts) (nesting depth added 19). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · InputUtils.validateCustomField (cognitive 31) · ×1
  • InputUtils.validateCustomField (cognitive 31) src/EcclesiaCRM/utils/InputUtils.php:314 — InputUtils.validateCustomField has cognitive complexity 31 (threshold 15). Drivers by points: if/else 11 (27 pts), boolean chains 3, match/switch 1 (nesting depth added 16). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · PhpWordHTMLExtension.parseStyle (cognitive 31) · ×1
  • PhpWordHTMLExtension.parseStyle (cognitive 31) src/EcclesiaCRM/utils/PhpWordHTMLExtension.php:631 — PhpWordHTMLExtension.parseStyle has cognitive complexity 31 (threshold 15). Drivers by points: if/else 9 (24 pts), match/switch 2 (5 pts), boolean chains 1, loops 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · (anonymous) (cognitive 31) · ×1
  • (anonymous) (cognitive 31) src/skin/js/user/UserList.js:1 — (anonymous) has cognitive complexity 31 (threshold 15). Drivers by points: if/else 24 (31 pts) (nesting depth added 7). Most of this is not in the body itself: 2 of the 31 points are its own statements and the rest belongs to 28 function items inside it that branch (a function literal at line 68, a function literal at line 100, a function literal at line 5, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · Person.getAddressForMailService (cognitive 30) · ×1
  • Person.getAddressForMailService (cognitive 30) src/EcclesiaCRM/model/EcclesiaCRM/Person.php:491 — Person.getAddressForMailService has cognitive complexity 30 (threshold 15). Drivers by points: if/else 13 (29 pts), boolean chains 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PDF_PhotoBook.drawGroupMembersByRole (cognitive 30) · ×1
  • PDF_PhotoBook.drawGroupMembersByRole (cognitive 30) src/Reports/PhotoBook.php:147 — PDF_PhotoBook.drawGroupMembersByRole has cognitive complexity 30 (threshold 15). Drivers by points: if/else 6 (20 pts), loops 2 (5 pts), ternaries 2 (5 pts) (nesting depth added 20). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · (anonymous) (cognitive 30) · ×1
  • (anonymous) (cognitive 30) src/skin/js/Footer.js:30 — (anonymous) has cognitive complexity 30 (threshold 15). Drivers by points: if/else 15 (20 pts), boolean chains 9, ternaries 1 (nesting depth added 5). Most of this is not in the body itself: 10 of the 30 points are its own statements and the rest belongs to 24 function items inside it that branch (a function literal at line 148, a function literal at line 170, a function literal at line 155, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · DocumentCollaboraController.resolveSharedAlias (cognitive 29) · ×1
  • DocumentCollaboraController.resolveSharedAlias (cognitive 29) src/EcclesiaCRM/APIControllers/DocumentCollaboraController.php:119 — DocumentCollaboraController.resolveSharedAlias has cognitive complexity 29 (threshold 15). Drivers by points: if/else 11 (23 pts), boolean chains 5, loops 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · UpgradeService.upgradeDatabaseVersion (cognitive 29) · ×1
  • UpgradeService.upgradeDatabaseVersion (cognitive 29) src/EcclesiaCRM/Service/UpgradeService.php:20 — UpgradeService.upgradeDatabaseVersion has cognitive complexity 29 (threshold 15). Drivers by points: if/else 6 (18 pts), loops 4 (10 pts), error handling 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MailchimpController.searchList (cognitive 29) · ×1
  • MailchimpController.searchList (cognitive 29) src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:52 — MailchimpController.searchList has cognitive complexity 29 (threshold 15). Drivers by points: if/else 11 (18 pts), loops 3 (6 pts), error handling 3, boolean chains 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MailChimpService.removeMembersFromSegment (cognitive 29) · ×1
  • MailChimpService.removeMembersFromSegment (cognitive 29) src/Plugins/MailChimp/core/Services/MailChimpService.php:721 — MailChimpService.removeMembersFromSegment has cognitive complexity 29 (threshold 15). Drivers by points: loops 4 (15 pts), if/else 3 (13 pts), boolean chains 1 (nesting depth added 21). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · LabelUtils.FontSelect (cognitive 28) · ×1
  • LabelUtils.FontSelect (cognitive 28) src/EcclesiaCRM/utils/LabelUtils.php:9 — LabelUtils.FontSelect has cognitive complexity 28 (threshold 15). Drivers by points: if/else 6 (16 pts), boolean chains 10, loops 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MiscUtils.sqlCustomField (cognitive 28) · ×1
  • MiscUtils.sqlCustomField (cognitive 28) src/EcclesiaCRM/utils/MiscUtils.php:115 — MiscUtils.sqlCustomField has cognitive complexity 28 (threshold 15). Drivers by points: if/else 16 (25 pts), match/switch 2 (3 pts) (nesting depth added 10). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · SabreUtils.shareFileOrDirectory (cognitive 28) · ×1
  • SabreUtils.shareFileOrDirectory (cognitive 28) src/EcclesiaCRM/utils/SabreUtils.php:147 — SabreUtils.shareFileOrDirectory has cognitive complexity 28 (threshold 15). Drivers by points: if/else 12 (26 pts), boolean chains 1, loops 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MailChimpService.removeMembersFromAllSegments (cognitive 28) · ×1
  • MailChimpService.removeMembersFromAllSegments (cognitive 28) src/Plugins/MailChimp/core/Services/MailChimpService.php:757 — MailChimpService.removeMembersFromAllSegments has cognitive complexity 28 (threshold 15). Drivers by points: loops 5 (16 pts), if/else 2 (12 pts) (nesting depth added 21). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · createFileDropPlugin (cognitive 28) · ×1
  • createFileDropPlugin (cognitive 28) src/skin/js/ckeditor/ckeditorextension.js:353 — createFileDropPlugin has cognitive complexity 28 (threshold 15). Drivers by points: if/else 14 (20 pts), boolean chains 4, ternaries 3, error handling 1 (nesting depth added 6). None of this is in the body itself: all 28 points belong to 22 function items inside it that branch (a function literal at line 361, a function literal at line 431, a function literal at line 412, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · init · ×1
  • init::(anonymous)::callback (cognitive 28) src/skin/js/ckeditor/ckeditorextension.js:1202 — init::(anonymous)::callback has cognitive complexity 28 (threshold 15). Drivers by points: if/else 15 (16 pts), boolean chains 7, error handling 2 (3 pts), ternaries 1 (2 pts) (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
D2 · Cognitive Complexity · PeopleAttendeesController.attendeesStudent (cognitive 27) · ×1
  • PeopleAttendeesController.attendeesStudent (cognitive 27) src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:424 — PeopleAttendeesController.attendeesStudent has cognitive complexity 27 (threshold 15). Drivers by points: if/else 8 (18 pts), error handling 1 (4 pts), loops 1 (3 pts), boolean chains 2 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PeoplePersonController.personCartView (cognitive 27) · ×1
  • PeoplePersonController.personCartView (cognitive 27) REDACTED:150 — PeoplePersonController.personCartView has cognitive complexity 27 (threshold 15). Drivers by points: if/else 8 (16 pts), ternaries 3 (6 pts), loops 3, boolean chains 2 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PDF_Directory.sGetHeadString (cognitive 27) · ×1
  • PDF_Directory.sGetHeadString (cognitive 27) src/EcclesiaCRM/Reports/PDF_Directory.php:345 — PDF_Directory.sGetHeadString has cognitive complexity 27 (threshold 15). Drivers by points: if/else 17 (21 pts), boolean chains 6 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · MiscUtils.SelectWhichAddress (cognitive 27) · ×1
  • MiscUtils.SelectWhichAddress (cognitive 27) src/EcclesiaCRM/utils/MiscUtils.php:1660 — MiscUtils.SelectWhichAddress has cognitive complexity 27 (threshold 15). Drivers by points: if/else 13 (24 pts), boolean chains 3 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · OutputUtils.displayCustomField (cognitive 27) · ×1
  • OutputUtils.displayCustomField (cognitive 27) src/EcclesiaCRM/utils/OutputUtils.php:188 — OutputUtils.displayCustomField has cognitive complexity 27 (threshold 15). Drivers by points: if/else 15 (26 pts), match/switch 1 (nesting depth added 11). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · PDFLabel.MakeADCArray (cognitive 27) · ×1
  • PDFLabel.MakeADCArray (cognitive 27) REDACTED:190 — PDFLabel.MakeADCArray has cognitive complexity 27 (threshold 15). Drivers by points: if/else 6 (17 pts), loops 3 (10 pts) (nesting depth added 18). This file's own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes — or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages.
D2 · Cognitive Complexity · EventEditor.createEventEditorWindow (cognitive 27) · ×1
  • EventEditor.createEventEditorWindow (cognitive 27) src/skin/js/calendar/EventEditor.js:822 — EventEditor.createEventEditorWindow has cognitive complexity 27 (threshold 15). Drivers by points: if/else 19 (25 pts), loops 1 (2 pts) (nesting depth added 7). Most of this is not in the body itself: 7 of the 27 points are its own statements and the rest belongs to 2 function literals inside it that branch (lines 868, 972). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D2 · Cognitive Complexity · (anonymous) (cognitive 27) · ×1
  • (anonymous) (cognitive 27) src/Plugins/NewsDashboard/skin/js/NewsDashboard.js:1 — (anonymous) has cognitive complexity 27 (threshold 15). Drivers by points: if/else 17 (26 pts), loops 1 (nesting depth added 9). None of this is in the body itself: all 27 points belong to 16 function items inside it that branch (a function literal at line 181, NewsEditorWindow::callback, addElementsToNewsDashboardList, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · DocumentFileManagerController.folderBack (cognitive 26) · ×1
  • DocumentFileManagerController.folderBack (cognitive 26) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:556 — DocumentFileManagerController.folderBack has cognitive complexity 26 (threshold 15). Drivers by points: if/else 5 (13 pts), ternaries 2 (8 pts), loops 1 (3 pts), boolean chains 2 (nesting depth added 16). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · DocumentShareController.addFamilyToShare (cognitive 26) · ×1
  • DocumentShareController.addFamilyToShare (cognitive 26) src/EcclesiaCRM/APIControllers/DocumentShareController.php:183 — DocumentShareController.addFamilyToShare has cognitive complexity 26 (threshold 15). Drivers by points: if/else 5 (19 pts), boolean chains 5, loops 1 (2 pts) (nesting depth added 15). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function. This shape REPEATS in the file: one other method here (DocumentShareController.addGroupToShare) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · DocumentShareController.addGroupToShare (cognitive 26) · ×1
  • DocumentShareController.addGroupToShare (cognitive 26) src/EcclesiaCRM/APIControllers/DocumentShareController.php:246 — DocumentShareController.addGroupToShare has cognitive complexity 26 (threshold 15). Drivers by points: if/else 5 (19 pts), boolean chains 5, loops 1 (2 pts) (nesting depth added 15). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function. This shape REPEATS in the file: one other method here (DocumentShareController.addFamilyToShare) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · SidebarPropertiesController.getAllPropertyTypes (cognitive 26) · ×1
  • SidebarPropertiesController.getAllPropertyTypes (cognitive 26) src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:42 — SidebarPropertiesController.getAllPropertyTypes has cognitive complexity 26 (threshold 15). Drivers by points: if/else 9 (17 pts), match/switch 1 (4 pts), loops 2 (3 pts), boolean chains 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CalendarService.anniversariesBirthdaysEvents (cognitive 26) · ×1
  • CalendarService.anniversariesBirthdaysEvents (cognitive 26) src/EcclesiaCRM/Service/CalendarService.php:58 — CalendarService.anniversariesBirthdaysEvents has cognitive complexity 26 (threshold 15). Drivers by points: if/else 7 (15 pts), loops 3 (8 pts), boolean chains 3 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MiscUtils.embedFiles (cognitive 26) · ×1
  • MiscUtils.embedFiles (cognitive 26) src/EcclesiaCRM/utils/MiscUtils.php:1281 — MiscUtils.embedFiles has cognitive complexity 26 (threshold 15). Drivers by points: if/else 13 (25 pts), match/switch 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · OutputUtils.FormatBirthDate (cognitive 26) · ×1
  • OutputUtils.FormatBirthDate (cognitive 26) src/EcclesiaCRM/utils/OutputUtils.php:635 — OutputUtils.FormatBirthDate has cognitive complexity 26 (threshold 15). Drivers by points: if/else 12 (20 pts), boolean chains 6 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · (anonymous) (cognitive 26) · ×1
  • (anonymous) (cognitive 26) src/skin/js/fundraiser/paddleNumList.js:1 — (anonymous) has cognitive complexity 26 (threshold 15). Drivers by points: if/else 16 (18 pts), ternaries 4 (5 pts), boolean chains 2, loops 1 (nesting depth added 3). None of this is in the body itself: all 26 points belong to 31 function items inside it that branch (a function literal at line 59, createOrEditBuyer, updateCountBadge, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · VIEWFamilyListController.argumentsFamilyListArray (cognitive 25) · ×1
  • VIEWFamilyListController.argumentsFamilyListArray (cognitive 25) src/EcclesiaCRM/VIEWControllers/People/VIEWFamilyListController.php:53 — VIEWFamilyListController.argumentsFamilyListArray has cognitive complexity 25 (threshold 15). Drivers by points: if/else 12 (20 pts), boolean chains 2, ternaries 1 (2 pts), match/switch 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CalDavPDO.updateInvites (cognitive 25) · ×1
  • CalDavPDO.updateInvites (cognitive 25) src/EcclesiaCRM/sabre/CalDav/CalDavPDO.php:84 — CalDavPDO.updateInvites has cognitive complexity 25 (threshold 15). Drivers by points: ternaries 4 (12 pts), if/else 5 (9 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CalendarV2.document.addEventListener("DOMContentLoaded") (cognitive 25) · ×1
  • CalendarV2.document.addEventListener("DOMContentLoaded") (cognitive 25) src/skin/js/calendar/CalendarV2.js:12 — CalendarV2.document.addEventListener("DOMContentLoaded") has cognitive complexity 25 (threshold 15). Drivers by points: boolean chains 25. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · CRMFileDropUpload.init (cognitive 25) · ×1
  • CRMFileDropUpload.init (cognitive 25) src/skin/js/ckeditor/ckeditorextension.js:359 — CRMFileDropUpload.init has cognitive complexity 25 (threshold 15). Drivers by points: if/else 14 (18 pts), boolean chains 4, ternaries 3 (nesting depth added 4). None of this is in the body itself: all 25 points belong to 9 function literals inside it that branch (lines 361, 431, 412, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D2 · Cognitive Complexity · createEditor (cognitive 25) · ×1
  • createEditor (cognitive 25) src/skin/js/ckeditor/ckeditorextension.js:1284 — createEditor has cognitive complexity 25 (threshold 15). Drivers by points: boolean chains 9, if/else 7 (8 pts), ternaries 7, error handling 1 (nesting depth added 1). Most of this is not in the body itself: 10 of the 25 points are its own statements and the rest belongs to 10 function items inside it that branch (a function literal at line 1325, a function literal at line 1303, a function literal at line 1313, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · FundraiserController.donatedItemSubmitFundraiser (cognitive 24) · ×1
  • FundraiserController.donatedItemSubmitFundraiser (cognitive 24) src/EcclesiaCRM/APIControllers/FundraiserController.php:350 — FundraiserController.donatedItemSubmitFundraiser has cognitive complexity 24 (threshold 15). Drivers by points: boolean chains 12, if/else 6 (12 pts) (nesting depth added 6). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · PeopleAttendeesController.attendeesEvent (cognitive 24) · ×1
  • PeopleAttendeesController.attendeesEvent (cognitive 24) src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:273 — PeopleAttendeesController.attendeesEvent has cognitive complexity 24 (threshold 15). Drivers by points: if/else 8 (13 pts), ternaries 5 (10 pts), loops 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PaymentSearchRes.buildSearch (cognitive 24) · ×1
  • PaymentSearchRes.buildSearch (cognitive 24) src/EcclesiaCRM/Search/PaymentSearchRes.php:26 — PaymentSearchRes.buildSearch has cognitive complexity 24 (threshold 15). Drivers by points: if/else 5 (16 pts), loops 1 (4 pts), error handling 1 (3 pts), boolean chains 1 (nesting depth added 16). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · VIEWPeopleController.argumentsPeopleFamilyViewArray (cognitive 24) · ×1
  • VIEWPeopleController.argumentsPeopleFamilyViewArray (cognitive 24) REDACTED:828 — VIEWPeopleController.argumentsPeopleFamilyViewArray has cognitive complexity 24 (threshold 15). Drivers by points: if/else 14 (20 pts), boolean chains 3, loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CalDavPDO.checkIfEventIsInResourceSlotCalendar (cognitive 24) · ×1
  • CalDavPDO.checkIfEventIsInResourceSlotCalendar (cognitive 24) src/EcclesiaCRM/sabre/CalDav/CalDavPDO.php:1085 — CalDavPDO.checkIfEventIsInResourceSlotCalendar has cognitive complexity 24 (threshold 15). Drivers by points: if/else 6 (10 pts), loops 4 (9 pts), boolean chains 5 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MailChimpService.delete_Segment (cognitive 24) · ×1
  • MailChimpService.delete_Segment (cognitive 24) src/Plugins/MailChimp/core/Services/MailChimpService.php:597 — MailChimpService.delete_Segment has cognitive complexity 24 (threshold 15). Drivers by points: if/else 4 (13 pts), loops 4 (11 pts) (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MailChimpService.update_list_member (cognitive 24) · ×1
  • MailChimpService.update_list_member (cognitive 24) src/Plugins/MailChimp/core/Services/MailChimpService.php:1219 — MailChimpService.update_list_member has cognitive complexity 24 (threshold 15). Drivers by points: if/else 5 (18 pts), loops 2 (4 pts), boolean chains 2 (nesting depth added 15). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · ConfirmReportService.getPersonStandardTextFields (cognitive 23) · ×1
  • ConfirmReportService.getPersonStandardTextFields (cognitive 23) src/EcclesiaCRM/Service/ConfirmReportService.php:130 — ConfirmReportService.getPersonStandardTextFields has cognitive complexity 23 (threshold 15). Drivers by points: ternaries 10 (13 pts), if/else 4 (6 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DocumentCollaboraController.edit (cognitive 22) · ×1
  • DocumentCollaboraController.edit (cognitive 22) src/EcclesiaCRM/APIControllers/DocumentCollaboraController.php:38 — DocumentCollaboraController.edit has cognitive complexity 22 (threshold 15). Drivers by points: if/else 11 (15 pts), boolean chains 7 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SidebarSystemSettingsController.saveSettings (cognitive 22) · ×1
  • SidebarSystemSettingsController.saveSettings (cognitive 22) src/EcclesiaCRM/APIControllers/SidebarSystemSettingsController.php:32 — SidebarSystemSettingsController.saveSettings has cognitive complexity 22 (threshold 15). Drivers by points: if/else 7 (16 pts), boolean chains 4, loops 1 (2 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SystemSettingsIndividualController.verify2FA (cognitive 22) · ×1
  • SystemSettingsIndividualController.verify2FA (cognitive 22) src/EcclesiaCRM/APIControllers/SystemSettingsIndividualController.php:81 — SystemSettingsIndividualController.verify2FA has cognitive complexity 22 (threshold 15). Drivers by points: if/else 6 (17 pts), loops 1 (5 pts) (nesting depth added 15). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · AppIntegrityService.hasModRewrite (cognitive 22) · ×1
  • AppIntegrityService.hasModRewrite (cognitive 22) REDACTED:359 — AppIntegrityService.hasModRewrite has cognitive complexity 22 (threshold 15). Drivers by points: if/else 8 (16 pts), loops 1 (3 pts), ternaries 1 (3 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CardDavACLPluginExtension.getCurrentUserPrivilegeSet (cognitive 22) · ×1
  • CardDavACLPluginExtension.getCurrentUserPrivilegeSet (cognitive 22) src/EcclesiaCRM/sabre/CardDav/CardDavACLPlugin.php:33 — CardDavACLPluginExtension.getCurrentUserPrivilegeSet has cognitive complexity 22 (threshold 15). Drivers by points: if/else 6 (15 pts), loops 3 (4 pts), match/switch 1 (2 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CardDavPDO.updateInvites (cognitive 22) · ×1
  • CardDavPDO.updateInvites (cognitive 22) src/EcclesiaCRM/sabre/CardDav/CardDavPDO.php:387 — CardDavPDO.updateInvites has cognitive complexity 22 (threshold 15). Drivers by points: ternaries 3 (10 pts), if/else 5 (9 pts), loops 2 (3 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · WebDavACLPlugin.getCurrentUserPrivilegeSet (cognitive 22) · ×1
  • WebDavACLPlugin.getCurrentUserPrivilegeSet (cognitive 22) src/EcclesiaCRM/sabre/WebDav/WebDavACLPlugin.php:45 — WebDavACLPlugin.getCurrentUserPrivilegeSet has cognitive complexity 22 (threshold 15). Drivers by points: if/else 6 (15 pts), loops 3 (4 pts), match/switch 1 (2 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · OutputUtils.FormatAge (cognitive 22) · ×1
  • OutputUtils.FormatAge (cognitive 22) src/EcclesiaCRM/utils/OutputUtils.php:513 — OutputUtils.FormatAge has cognitive complexity 22 (threshold 15). Drivers by points: if/else 11 (20 pts), boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · renderRestoreProgress (cognitive 22) · ×1
  • renderRestoreProgress (cognitive 22) src/skin/js/backup/restore.js:35 — renderRestoreProgress has cognitive complexity 22 (threshold 15). Drivers by points: if/else 9, boolean chains 8, ternaries 3 (5 pts) (nesting depth added 2). Of this number, 14 points are the body's own statements and 8 belong to 2 function literals inside it that branch. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · PeopleAttendeesController.qrcodeCallAttendees (cognitive 21) · ×1
  • PeopleAttendeesController.qrcodeCallAttendees (cognitive 21) src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:48 — PeopleAttendeesController.qrcodeCallAttendees has cognitive complexity 21 (threshold 15). Drivers by points: if/else 9 (19 pts), boolean chains 2 (nesting depth added 10). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · PeopleFamilyController.isMailServiceActiveFamily (cognitive 21) · ×1
  • PeopleFamilyController.isMailServiceActiveFamily (cognitive 21) REDACTED:87 — PeopleFamilyController.isMailServiceActiveFamily has cognitive complexity 21 (threshold 15). Drivers by points: ternaries 3 (11 pts), if/else 5 (8 pts), boolean chains 2 (nesting depth added 11). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · PeopleGroupController.renderBadge (cognitive 21) · ×1
  • PeopleGroupController.renderBadge (cognitive 21) src/EcclesiaCRM/APIControllers/PeopleGroupController.php:942 — PeopleGroupController.renderBadge has cognitive complexity 21 (threshold 15). Drivers by points: boolean chains 13, if/else 6 (8 pts) (nesting depth added 2). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · PeoplePersonController.isMailServiceActivePerson (cognitive 21) · ×1
  • PeoplePersonController.isMailServiceActivePerson (cognitive 21) REDACTED:291 — PeoplePersonController.isMailServiceActivePerson has cognitive complexity 21 (threshold 15). Drivers by points: ternaries 3 (11 pts), if/else 5 (8 pts), boolean chains 2 (nesting depth added 11). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · SidebarMenuLinksController.getMenuLinksForUser (cognitive 21) · ×1
  • SidebarMenuLinksController.getMenuLinksForUser (cognitive 21) src/EcclesiaCRM/APIControllers/SidebarMenuLinksController.php:31 — SidebarMenuLinksController.getMenuLinksForUser has cognitive complexity 21 (threshold 15). Drivers by points: if/else 9 (15 pts), boolean chains 3, loops 2 (3 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SidebarPropertiesController.getAllProperties (cognitive 21) · ×1
  • SidebarPropertiesController.getAllProperties (cognitive 21) src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:192 — SidebarPropertiesController.getAllProperties has cognitive complexity 21 (threshold 15). Drivers by points: if/else 7 (13 pts), loops 2 (3 pts), match/switch 1 (3 pts), boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Person.setSendNewsletter (cognitive 21) · ×1
  • Person.setSendNewsletter (cognitive 21) src/EcclesiaCRM/model/EcclesiaCRM/Person.php:106 — Person.setSendNewsletter has cognitive complexity 21 (threshold 15). Drivers by points: if/else 9 (18 pts), boolean chains 2, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Plugin.getPluginSecurityName (cognitive 21) · ×1
  • Plugin.getPluginSecurityName (cognitive 21) src/EcclesiaCRM/model/EcclesiaCRM/Plugin.php:23 — Plugin.getPluginSecurityName has cognitive complexity 21 (threshold 15). Drivers by points: if/else 21. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · SabreUtils.getFileOrDirectoryInfos (cognitive 21) · ×1
  • SabreUtils.getFileOrDirectoryInfos (cognitive 21) src/EcclesiaCRM/utils/SabreUtils.php:283 — SabreUtils.getFileOrDirectoryInfos has cognitive complexity 21 (threshold 15). Drivers by points: if/else 8 (19 pts), loops 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MailchimpController.campaignSave (cognitive 21) · ×1
  • MailchimpController.campaignSave (cognitive 21) src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:534 — MailchimpController.campaignSave has cognitive complexity 21 (threshold 15). Drivers by points: if/else 7 (12 pts), boolean chains 9 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · backup.document.addEventListener("DOMContentLoaded") (cognitive 21) · ×1
  • backup.document.addEventListener("DOMContentLoaded") (cognitive 21) src/skin/js/backup/backup.js:1 — backup.document.addEventListener("DOMContentLoaded") has cognitive complexity 21 (threshold 15). Drivers by points: if/else 15 (21 pts) (nesting depth added 6). Most of this is not in the body itself: 2 of the 21 points are its own statements and the rest belongs to 3 function items inside it that branch (doBackup, a function literal at line 118, a function literal at line 30). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · DocumentFileManagerController.getAllFileNoteForPerson (cognitive 20) · ×1
  • DocumentFileManagerController.getAllFileNoteForPerson (cognitive 20) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:170 — DocumentFileManagerController.getAllFileNoteForPerson has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (13 pts), boolean chains 6, loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PeoplePersonController.deletePersonField (cognitive 20) · ×1
  • PeoplePersonController.deletePersonField (cognitive 20) REDACTED:410 — PeoplePersonController.deletePersonField has cognitive complexity 20 (threshold 15). Drivers by points: if/else 6 (13 pts), boolean chains 4, loops 1 (3 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SearchController.getSearchResultByName (cognitive 20) · ×1
  • SearchController.getSearchResultByName (cognitive 20) src/EcclesiaCRM/APIControllers/SearchController.php:302 — SearchController.getSearchResultByName has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (13 pts), loops 2 (5 pts), boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PDF_Badge.Add_PDF_Badge_Titles (cognitive 20) · ×1
  • PDF_Badge.Add_PDF_Badge_Titles (cognitive 20) src/EcclesiaCRM/Reports/PDF_Badge.php:95 — PDF_Badge.Add_PDF_Badge_Titles has cognitive complexity 20 (threshold 15). Drivers by points: if/else 11 (14 pts), boolean chains 3, match/switch 3 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level. This shape REPEATS in the file: one other method here (PDF_Badge.Add_PDF_Badge) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · PDF_Badge.Add_PDF_Badge (cognitive 20) · ×1
  • PDF_Badge.Add_PDF_Badge (cognitive 20) src/EcclesiaCRM/Reports/PDF_Badge.php:253 — PDF_Badge.Add_PDF_Badge has cognitive complexity 20 (threshold 15). Drivers by points: if/else 11 (14 pts), boolean chains 3, match/switch 3 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level. This shape REPEATS in the file: one other method here (PDF_Badge.Add_PDF_Badge_Titles) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · SharedDocumentService.resolve (cognitive 20) · ×1
  • SharedDocumentService.resolve (cognitive 20) src/EcclesiaCRM/Service/SharedDocumentService.php:12 — SharedDocumentService.resolve has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9, boolean chains 6, ternaries 5. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · VIEWMapController.renderMapArray (cognitive 20) · ×1
  • VIEWMapController.renderMapArray (cognitive 20) src/EcclesiaCRM/VIEWControllers/VIEWMapController.php:62 — VIEWMapController.renderMapArray has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (15 pts), loops 2 (3 pts), boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · User.allSecuritiesBits (cognitive 20) · ×1
  • User.allSecuritiesBits (cognitive 20) src/EcclesiaCRM/model/EcclesiaCRM/User.php:1265 — User.allSecuritiesBits has cognitive complexity 20 (threshold 15). Drivers by points: if/else 20. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · MiscUtils.RenderDOMNode (cognitive 20) · ×1
  • MiscUtils.RenderDOMNode (cognitive 20) src/EcclesiaCRM/utils/MiscUtils.php:1888 — MiscUtils.RenderDOMNode has cognitive complexity 20 (threshold 15). Drivers by points: if/else 5 (13 pts), loops 2 (4 pts), match/switch 1 (3 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MailchimpController.notInMailChimpEmails (cognitive 20) · ×1
  • MailchimpController.notInMailChimpEmails (cognitive 20) src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:931 — MailchimpController.notInMailChimpEmails has cognitive complexity 20 (threshold 15). Drivers by points: if/else 5 (12 pts), loops 3 (8 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · APIRequest (cognitive 20) · ×1
  • APIRequest (cognitive 20) REDACTED:5 — APIRequest has cognitive complexity 20 (threshold 15). Drivers by points: if/else 6 (7 pts), ternaries 3 (6 pts), boolean chains 5, error handling 2 (nesting depth added 4). Most of this is not in the body itself: 3 of the 20 points are its own statements and the rest belongs to 3 function literals inside it that branch (lines 22, 55, 61). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D2 · Cognitive Complexity · DocumentFileManagerController.getRealFile (cognitive 19) · ×1
  • DocumentFileManagerController.getRealFile (cognitive 19) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:259 — DocumentFileManagerController.getRealFile has cognitive complexity 19 (threshold 15). Drivers by points: if/else 6 (15 pts), boolean chains 4 (nesting depth added 9). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · PastoralCareController.createRandomlyPastoralCare (cognitive 19) · ×1
  • PastoralCareController.createRandomlyPastoralCare (cognitive 19) src/EcclesiaCRM/APIControllers/PastoralCareController.php:606 — PastoralCareController.createRandomlyPastoralCare has cognitive complexity 19 (threshold 15). Drivers by points: if/else 6 (16 pts), match/switch 1 (2 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PeopleGroupController.deleteGroupField (cognitive 19) · ×1
  • PeopleGroupController.deleteGroupField (cognitive 19) src/EcclesiaCRM/APIControllers/PeopleGroupController.php:715 — PeopleGroupController.deleteGroupField has cognitive complexity 19 (threshold 15). Drivers by points: if/else 6 (13 pts), boolean chains 3, loops 1 (3 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Menu.buildSubMenu (cognitive 19) · ×1
  • Menu.buildSubMenu (cognitive 19) src/EcclesiaCRM/MenuBar/Menu.php:263 — Menu.buildSubMenu has cognitive complexity 19 (threshold 15). Drivers by points: ternaries 5 (12 pts), if/else 3 (6 pts), loops 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PDF_AddressReport.num_lines_in_tcfpdf_cell (cognitive 19) · ×1
  • PDF_AddressReport.num_lines_in_tcfpdf_cell (cognitive 19) src/EcclesiaCRM/Reports/PDF_AddressReport.php:19 — PDF_AddressReport.num_lines_in_tcfpdf_cell has cognitive complexity 19 (threshold 15). Drivers by points: if/else 9 (17 pts), boolean chains 1, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PDF_Directory.NbLines (cognitive 19) · ×1
  • PDF_Directory.NbLines (cognitive 19) src/EcclesiaCRM/Reports/PDF_Directory.php:132 — PDF_Directory.NbLines has cognitive complexity 19 (threshold 15). Drivers by points: if/else 9 (17 pts), boolean chains 1, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SQLUtils.clearSQL (cognitive 19) · ×1
  • SQLUtils.clearSQL (cognitive 19) src/EcclesiaCRM/SQLUtils.php:171 — SQLUtils.clearSQL has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (18 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · VIEWCalendarController.argumentsCalendarCheckinArray (cognitive 19) · ×1
  • VIEWCalendarController.argumentsCalendarCheckinArray (cognitive 19) src/EcclesiaCRM/VIEWControllers/VIEWCalendarController.php:202 — VIEWCalendarController.argumentsCalendarCheckinArray has cognitive complexity 19 (threshold 15). Drivers by points: if/else 14 (18 pts), boolean chains 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · InputUtils.assembleYearMonthDay (cognitive 19) · ×1
  • InputUtils.assembleYearMonthDay (cognitive 19) src/EcclesiaCRM/utils/InputUtils.php:401 — InputUtils.assembleYearMonthDay has cognitive complexity 19 (threshold 15). Drivers by points: if/else 14 (19 pts) (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · OutputUtils.securityFilter (cognitive 19) · ×1
  • OutputUtils.securityFilter (cognitive 19) src/EcclesiaCRM/utils/OutputUtils.php:111 — OutputUtils.securityFilter has cognitive complexity 19 (threshold 15). Drivers by points: if/else 9 (18 pts), match/switch 1 (nesting depth added 9). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · NewsDashboard.doInsert (cognitive 19) · ×1
  • NewsDashboard.doInsert (cognitive 19) src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:874 — NewsDashboard.doInsert has cognitive complexity 19 (threshold 15). Drivers by points: if/else 8, ternaries 2 (6 pts), error handling 2, match/switch 1 (2 pts), loops 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · IntegrityChecker.toText (cognitive 19) · ×1
  • IntegrityChecker.toText (cognitive 19) src/tools/integrity-check.php:234 — IntegrityChecker.toText has cognitive complexity 19 (threshold 15). Drivers by points: loops 3 (7 pts), if/else 3 (6 pts), ternaries 3 (5 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DocumentFileManagerController.deleteOneFile (cognitive 18) · ×1
  • DocumentFileManagerController.deleteOneFile (cognitive 18) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:645 — DocumentFileManagerController.deleteOneFile has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (15 pts), boolean chains 3 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DocumentFileManagerController.uploadFile (cognitive 18) · ×1
  • DocumentFileManagerController.uploadFile (cognitive 18) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:1066 — DocumentFileManagerController.uploadFile has cognitive complexity 18 (threshold 15). Drivers by points: if/else 14, boolean chains 4. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · PastoralCareController.addPastoralCareFamily (cognitive 18) · ×1
  • PastoralCareController.addPastoralCareFamily (cognitive 18) src/EcclesiaCRM/APIControllers/PastoralCareController.php:282 — PastoralCareController.addPastoralCareFamily has cognitive complexity 18 (threshold 15). Drivers by points: if/else 4 (9 pts), boolean chains 6, loops 1 (3 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PeopleFamilyController.deleteFamilyField (cognitive 18) · ×1
  • PeopleFamilyController.deleteFamilyField (cognitive 18) REDACTED:375 — PeopleFamilyController.deleteFamilyField has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (13 pts), loops 1 (3 pts), boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · UserUsersController.lockUnlock (cognitive 18) · ×1
  • UserUsersController.lockUnlock (cognitive 18) src/EcclesiaCRM/APIControllers/UserUsersController.php:108 — UserUsersController.lockUnlock has cognitive complexity 18 (threshold 15). Drivers by points: ternaries 3 (9 pts), if/else 5 (8 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CreateBackup.FullBackupFile (cognitive 18) · ×1
  • CreateBackup.FullBackupFile (cognitive 18) src/EcclesiaCRM/BackupManager.php:548 — CreateBackup.FullBackupFile has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (12 pts), boolean chains 3, loops 3 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ConfirmReportService.getPersonStandardInfos (cognitive 18) · ×1
  • ConfirmReportService.getPersonStandardInfos (cognitive 18) src/EcclesiaCRM/Service/ConfirmReportService.php:31 — ConfirmReportService.getPersonStandardInfos has cognitive complexity 18 (threshold 15). Drivers by points: if/else 9 (11 pts), ternaries 3 (4 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
D2 · Cognitive Complexity · FinancialService.validateFund (cognitive 18) · ×1
  • FinancialService.validateFund (cognitive 18) src/EcclesiaCRM/Service/FinancialService.php:151 — FinancialService.validateFund has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (14 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · VIEWSessionController.renderLogout (cognitive 18) · ×1
  • VIEWSessionController.renderLogout (cognitive 18) src/EcclesiaCRM/VIEWControllers/Session/VIEWSessionController.php:80 — VIEWSessionController.renderLogout has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (15 pts), boolean chains 3 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MailChimpService.getListsFromCache (cognitive 18) · ×1
  • MailChimpService.getListsFromCache (cognitive 18) src/Plugins/MailChimp/core/Services/MailChimpService.php:94 — MailChimpService.getListsFromCache has cognitive complexity 18 (threshold 15). Drivers by points: loops 4 (11 pts), if/else 3 (4 pts), boolean chains 3 (nesting depth added 8). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · NewsDashboard.hydrate (cognitive 18) · ×1
  • NewsDashboard.hydrate (cognitive 18) src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:645 — NewsDashboard.hydrate has cognitive complexity 18 (threshold 15). Drivers by points: ternaries 14, if/else 3, error handling 1. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · (anonymous) (cognitive 18) · ×1
  • (anonymous) (cognitive 18) src/skin/js/system/SettingsIndividual.js:1 — (anonymous) has cognitive complexity 18 (threshold 15). Drivers by points: if/else 14, boolean chains 3, ternaries 1. Most of this is not in the body itself: 5 of the 18 points are its own statements and the rest belongs to 20 function items inside it that branch (a function literal at line 142, a function literal at line 167, a function literal at line 262, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · CalendarV2Controller.calendarInfo (cognitive 17) · ×1
  • CalendarV2Controller.calendarInfo (cognitive 17) src/EcclesiaCRM/APIControllers/CalendarV2Controller.php:253 — CalendarV2Controller.calendarInfo has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (11 pts), ternaries 2 (4 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PDF_Directory.sGetFamilyString (cognitive 17) · ×1
  • PDF_Directory.sGetFamilyString (cognitive 17) src/EcclesiaCRM/Reports/PDF_Directory.php:296 — PDF_Directory.sGetFamilyString has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (12 pts), boolean chains 5 (nesting depth added 3). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NotificationService.getNotifications (cognitive 17) · ×1
  • NotificationService.getNotifications (cognitive 17) src/EcclesiaCRM/Service/NotificationService.php:36 — NotificationService.getNotifications has cognitive complexity 17 (threshold 15). Drivers by points: if/else 4 (12 pts), loops 1 (3 pts), boolean chains 2 (nesting depth added 10). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · MiscUtils.getFamilyList (cognitive 17) · ×1
  • MiscUtils.getFamilyList (cognitive 17) src/EcclesiaCRM/utils/MiscUtils.php:352 — MiscUtils.getFamilyList has cognitive complexity 17 (threshold 15). Drivers by points: if/else 10 (14 pts), loops 2, boolean chains 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MailChimpService.delete_list_member (cognitive 17) · ×1
  • MailChimpService.delete_list_member (cognitive 17) src/Plugins/MailChimp/core/Services/MailChimpService.php:1144 — MailChimpService.delete_list_member has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (13 pts), loops 2 (4 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ToDoListDashboardController.removeList (cognitive 17) · ×1
  • ToDoListDashboardController.removeList (cognitive 17) src/Plugins/ToDoListDashboard/core/APIControllers/ToDoListDashboardController.php:107 — ToDoListDashboardController.removeList has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (11 pts), loops 2 (6 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · settings.document.addEventListener("DOMContentLoaded") (cognitive 17) · ×1
  • settings.document.addEventListener("DOMContentLoaded") (cognitive 17) src/Plugins/MailChimp/skin/js/settings.js:1 — settings.document.addEventListener("DOMContentLoaded") has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (8 pts), boolean chains 5, ternaries 3 (4 pts) (nesting depth added 2). Most of this is not in the body itself: 4 of the 17 points are its own statements and the rest belongs to 6 function items inside it that branch (a function literal at line 90, updateDirtyState, showSavedState, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · EventEditor.addAttendees (cognitive 17) · ×1
  • EventEditor.addAttendees (cognitive 17) src/skin/js/calendar/EventEditor.js:258 — EventEditor.addAttendees has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (12 pts), boolean chains 3, loops 1 (2 pts) (nesting depth added 4). Most of this is not in the body itself: 4 of the 17 points are its own statements and the rest belongs to one function literal inside it that branches (line 288). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
D2 · Cognitive Complexity · ckeditorextension.buildToolbar (cognitive 17) · ×1
  • ckeditorextension.buildToolbar (cognitive 17) src/skin/js/ckeditor/ckeditorextension.js:159 — ckeditorextension.buildToolbar has cognitive complexity 17 (threshold 15). Drivers by points: if/else 12 (14 pts), boolean chains 3 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · DocumentDocumentController.getDocument (cognitive 16) · ×1
  • DocumentDocumentController.getDocument (cognitive 16) src/EcclesiaCRM/APIControllers/DocumentDocumentController.php:60 — DocumentDocumentController.getDocument has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (12 pts), boolean chains 4 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DocumentFileManagerController.changeFolder (cognitive 16) · ×1
  • DocumentFileManagerController.changeFolder (cognitive 16) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:515 — DocumentFileManagerController.changeFolder has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (9 pts), ternaries 1 (4 pts), boolean chains 3 (nesting depth added 8). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · DocumentShareController.addPersonToShare (cognitive 16) · ×1
  • DocumentShareController.addPersonToShare (cognitive 16) src/EcclesiaCRM/APIControllers/DocumentShareController.php:122 — DocumentShareController.addPersonToShare has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (10 pts), boolean chains 6 (nesting depth added 6). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · DocumentWopiController.resolveSharedAlias (cognitive 16) · ×1
  • DocumentWopiController.resolveSharedAlias (cognitive 16) src/EcclesiaCRM/APIControllers/DocumentWopiController.php:184 — DocumentWopiController.resolveSharedAlias has cognitive complexity 16 (threshold 15). Drivers by points: boolean chains 9, if/else 7. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · PeopleAttendeesController.attendeesCheckAll (cognitive 16) · ×1
  • PeopleAttendeesController.attendeesCheckAll (cognitive 16) src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:578 — PeopleAttendeesController.attendeesCheckAll has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (11 pts), boolean chains 3, loops 1 (2 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SidebarPropertiesController.propertiesGroupsAssign (cognitive 16) · ×1
  • SidebarPropertiesController.propertiesGroupsAssign (cognitive 16) src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:516 — SidebarPropertiesController.propertiesGroupsAssign has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (9 pts), boolean chains 4, ternaries 3 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · RestoreBackup.RestoreFullArchive_TAR_GZ (cognitive 16) · ×1
  • RestoreBackup.RestoreFullArchive_TAR_GZ (cognitive 16) src/EcclesiaCRM/BackupManager.php:288 — RestoreBackup.RestoreFullArchive_TAR_GZ has cognitive complexity 16 (threshold 15). Drivers by points: loops 3 (9 pts), if/else 3 (7 pts) (nesting depth added 10). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · TimelineService.notesForPerson (cognitive 16) · ×1
  • TimelineService.notesForPerson (cognitive 16) src/EcclesiaCRM/Service/TimelineService.php:113 — TimelineService.notesForPerson has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (12 pts), loops 3 (4 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · VIEWCartController.argumentsCartViewArray (cognitive 16) · ×1
  • VIEWCartController.argumentsCartViewArray (cognitive 16) src/EcclesiaCRM/VIEWControllers/VIEWCartController.php:68 — VIEWCartController.argumentsCartViewArray has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (13 pts), loops 2, boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MiscUtils.removeOfficePreviewCache (cognitive 16) · ×1
  • MiscUtils.removeOfficePreviewCache (cognitive 16) src/EcclesiaCRM/utils/MiscUtils.php:844 — MiscUtils.removeOfficePreviewCache has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (10 pts), loops 3 (5 pts), ternaries 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MailChimpService.addMembersToSegment (cognitive 16) · ×1
  • MailChimpService.addMembersToSegment (cognitive 16) src/Plugins/MailChimp/core/Services/MailChimpService.php:686 — MailChimpService.addMembersToSegment has cognitive complexity 16 (threshold 15). Drivers by points: loops 3 (9 pts), if/else 2 (6 pts), boolean chains 1 (nesting depth added 10). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · MailChimpParams.hydrate (cognitive 16) · ×1
  • MailChimpParams.hydrate (cognitive 16) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:643 — MailChimpParams.hydrate has cognitive complexity 16 (threshold 15). Drivers by points: ternaries 14, error handling 1, if/else 1. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · MailChimpParamsQuery.findPk (cognitive 16) · ×1
  • MailChimpParamsQuery.findPk (cognitive 16) src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:141 — MailChimpParamsQuery.findPk has cognitive complexity 16 (threshold 15). Drivers by points: boolean chains 11, if/else 4, ternaries 1. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · PersonJitsiMeetingQuery.findPk (cognitive 16) · ×1
  • PersonJitsiMeetingQuery.findPk (cognitive 16) src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeetingQuery.php:123 — PersonJitsiMeetingQuery.findPk has cognitive complexity 16 (threshold 15). Drivers by points: boolean chains 11, if/else 4, ternaries 1. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · PersonLastJitsiMeetingQuery.findPk (cognitive 16) · ×1
  • PersonLastJitsiMeetingQuery.findPk (cognitive 16) src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeetingQuery.php:117 — PersonLastJitsiMeetingQuery.findPk has cognitive complexity 16 (threshold 15). Drivers by points: boolean chains 11, if/else 4, ternaries 1. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · PluginPrefJitsiMeetingQuery.findPk (cognitive 16) · ×1
  • PluginPrefJitsiMeetingQuery.findPk (cognitive 16) src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeetingQuery.php:129 — PluginPrefJitsiMeetingQuery.findPk has cognitive complexity 16 (threshold 15). Drivers by points: boolean chains 11, if/else 4, ternaries 1. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · NewsDashboardQuery.findPk (cognitive 16) · ×1
  • NewsDashboardQuery.findPk (cognitive 16) src/Plugins/NewsDashboard/core/model/Base/NewsDashboardQuery.php:141 — NewsDashboardQuery.findPk has cognitive complexity 16 (threshold 15). Drivers by points: boolean chains 11, if/else 4, ternaries 1. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · NoteDashboardQuery.findPk (cognitive 16) · ×1
  • NoteDashboardQuery.findPk (cognitive 16) src/Plugins/NoteDashboard/core/model/Base/NoteDashboardQuery.php:117 — NoteDashboardQuery.findPk has cognitive complexity 16 (threshold 15). Drivers by points: boolean chains 11, if/else 4, ternaries 1. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · ToDoListDashboardItemQuery.findPk (cognitive 16) · ×1
  • ToDoListDashboardItemQuery.findPk (cognitive 16) src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItemQuery.php:135 — ToDoListDashboardItemQuery.findPk has cognitive complexity 16 (threshold 15). Drivers by points: boolean chains 11, if/else 4, ternaries 1. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · ToDoListDashboardQuery.findPk (cognitive 16) · ×1
  • ToDoListDashboardQuery.findPk (cognitive 16) src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardQuery.php:123 — ToDoListDashboardQuery.findPk has cognitive complexity 16 (threshold 15). Drivers by points: boolean chains 11, if/else 4, ternaries 1. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · CanvassReports.CanvassProgressReport (cognitive 16) · ×1
  • CanvassReports.CanvassProgressReport (cognitive 16) src/Reports/CanvassReports.php:60 — CanvassReports.CanvassProgressReport has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (10 pts), loops 3 (6 pts) (nesting depth added 9). This file's own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes — or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages.
D2 · Cognitive Complexity · IntegrityChecker.checkApplication (cognitive 16) · ×1
  • IntegrityChecker.checkApplication (cognitive 16) src/tools/integrity-check.php:45 — IntegrityChecker.checkApplication has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (12 pts), boolean chains 3, loops 1 (nesting depth added 3). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (IntegrityChecker.checkPlugin) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · IntegrityChecker.checkPlugin (cognitive 16) · ×1
  • IntegrityChecker.checkPlugin (cognitive 16) src/tools/integrity-check.php:126 — IntegrityChecker.checkPlugin has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (12 pts), boolean chains 3, loops 1 (nesting depth added 3). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (IntegrityChecker.checkApplication) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · CRMJSOM_MAIL.CRM.mail (cognitive 16) · ×1
  • CRMJSOM_MAIL.CRM.mail (cognitive 16) src/skin/js/CRMJSOM_MAIL.js:35 — CRMJSOM_MAIL.CRM.mail has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (16 pts) (nesting depth added 7). Of this number, 10 points are the body's own statements and 6 belong to 3 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · heartbeat (cognitive 16) · ×1
  • heartbeat (cognitive 16) src/skin/js/system/KioskJSOM.js:254 — heartbeat has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (12 pts), boolean chains 4 (nesting depth added 3). None of this is in the body itself: all 16 points belong to 2 function literals inside it that branch (lines 257, 274). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D2 · Cognitive Complexity · (anonymous) (cognitive 16) · ×1
  • (anonymous) (cognitive 16) src/skin/js/people/PersonEditor.js:1 — (anonymous) has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (13 pts), boolean chains 2, ternaries 1 (nesting depth added 4). Most of this is not in the body itself: 3 of the 16 points are its own statements and the rest belongs to 7 function items inside it that branch (applyFamilyMode, a function literal at line 96, loadExistingFamily, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D35 · Change Coupling · Change coupling · ×1
  • Change coupling: DocumentShareController.php ↔ filemanager.js src/EcclesiaCRM/APIControllers/DocumentShareController.php:1 — `src/EcclesiaCRM/APIControllers/DocumentShareController.php` and `src/skin/js/filemanager.js` change together 54% of the time (7 of the 13 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) and are written in DIFFERENT LANGUAGES, so no import can join them and they cannot be co-located into one unit — they compile and ship as separate artifacts. What binds them is a CONTRACT across that boundary — an event or message name, a route, a serialised shape — that each side currently spells out on its own, which is exactly why a change to one drags the other. Declare that contract once where both sides read it (a shared schema, a generated constants file, an interface-definition file) so a change on one side fails the other's build instead of drifting silently; where the surface is too small to be worth that, name the counterpart in a comment on both sides so the next reader finds it. There is nothing here to merge. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `6d7fe070` Filemanager : update; `4d2ece0a` Last modifications; `1c56313e` Share folder enhancement — run `git show` on any of them.
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D4 · Code Duplication · Near-duplicate member family (8 members, 31 shared lines) · ×1
  • Near-duplicate member family (8 members, 31 shared lines) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:868 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:868-952 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:729-792 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:654-710 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:764-834 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:876-960 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:672-728 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:742-805 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:845-922 — These 8 members are variants of one another: a block of 31 lines reported below appears in every one of them, and the pairwise near-duplicate rows they would otherwise produce are collapsed into this row. Read them as one construct written 8 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 8 times.
D4 · Code Duplication · Near-duplicate member family (4 members, 4 shared lines) · ×1
  • Near-duplicate member family (4 members, 4 shared lines) src/EcclesiaCRM/Reports/ChurchInfoReportTCPDF.php:177 — src/EcclesiaCRM/Reports/ChurchInfoReportTCPDF.php:177-219 | src/Reports/CanvassReports.php:63-152 | src/Reports/CanvassReports.php:360-430 | src/Reports/CanvassReports.php:436-478 — These 4 members are variants of one another: a block of 4 lines reported below appears in every one of them, and the pairwise near-duplicate rows they would otherwise produce are collapsed into this row. Read them as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication · Near-duplicate member pair (232 shared lines) · ×1
  • Near-duplicate member pair (232 shared lines) src/EcclesiaCRM/Service/CalendarService.php:157 — src/EcclesiaCRM/Service/CalendarService.php:157-794 | src/EcclesiaCRM/Service/CalendarService.php:817-1326 — These two members are variants of one another: 232 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Near-duplicate member pair (180 shared lines) · ×1
  • Near-duplicate member pair (180 shared lines) src/EcclesiaCRM/MenuBar/MenuBar.php:281 — src/EcclesiaCRM/MenuBar/MenuBar.php:281-511 | src/EcclesiaCRM/MenuBar/MenuBar.php:535-745 — These two members are variants of one another: 180 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Near-duplicate member pair (101 shared lines) · ×1
  • Near-duplicate member pair (101 shared lines) src/EcclesiaCRM/Reports/CSV_RealAttendance.php:52 — src/EcclesiaCRM/Reports/CSV_RealAttendance.php:52-263 | src/EcclesiaCRM/Reports/PDF_RealAttendance.php:57-285 — These two members are variants of one another: 101 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Near-duplicate member pair (74 shared lines) · ×1
  • Near-duplicate member pair (74 shared lines) src/EcclesiaCRM/Service/CalendarService.php:1624 — src/EcclesiaCRM/Service/CalendarService.php:1624-1840 | src/EcclesiaCRM/Service/CalendarService.php:1898-2244 — These two members are variants of one another: 74 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Near-duplicate member pair (70 shared lines) · ×1
  • Near-duplicate member pair (70 shared lines) src/EcclesiaCRM/APIControllers/PeopleController.php:203 — src/EcclesiaCRM/APIControllers/PeopleController.php:203-344 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:54-219 — These two members are variants of one another: 70 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Near-duplicate member pair (65 shared lines) · ×1
  • Near-duplicate member pair (65 shared lines) src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:426 — src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:426-544 | src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:650-787 — These two members are variants of one another: 65 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Near-duplicate member pair (36 shared lines) · ×1
  • Near-duplicate member pair (36 shared lines) src/tools/integrity-check.php:46 — src/tools/integrity-check.php:46-109 | src/tools/integrity-check.php:127-196 — These two members are variants of one another: 36 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Near-duplicate member pair (32 shared lines) · ×1
  • Near-duplicate member pair (32 shared lines) src/EcclesiaCRM/Service/FinancialService.php:399 — src/EcclesiaCRM/Service/FinancialService.php:399-515 | src/EcclesiaCRM/model/EcclesiaCRM/Deposit.php:254-390 — These two members are variants of one another: 32 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Edited copy of a member (83 corresponding lines) · ×1
  • Edited copy of a member (83 corresponding lines) src/EcclesiaCRM/Service/ConfirmReportService.php:33 — src/EcclesiaCRM/Service/ConfirmReportService.php:33-122 | src/EcclesiaCRM/Service/ConfirmReportService.php:465-547 — These two members are one piece of code written twice and then edited apart: 83 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 35+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 35+ corresponding lines) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:645 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:645-679 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:647-687 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:622-656 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 35 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (49 corresponding lines) · ×1
  • Edited copy of a member (49 corresponding lines) src/EcclesiaCRM/Service/ConfirmReportService.php:413 — src/EcclesiaCRM/Service/ConfirmReportService.php:413-461 | src/EcclesiaCRM/Service/ConfirmReportService.php:810-858 — These two members are one piece of code written twice and then edited apart: 49 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 43+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 43+ corresponding lines) REDACTED:376 — REDACTED:376-418 | src/EcclesiaCRM/APIControllers/PeopleGroupController.php:716-760 | REDACTED:411-453 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 43 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (39 corresponding lines) · ×1
  • Edited copy of a member (39 corresponding lines) src/EcclesiaCRM/model/EcclesiaCRM/Family.php:274 — src/EcclesiaCRM/model/EcclesiaCRM/Family.php:274-312 | src/EcclesiaCRM/model/EcclesiaCRM/Person.php:385-429 — These two members are one piece of code written twice and then edited apart: 39 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (75 corresponding lines) · ×1
  • Edited copy of a member (75 corresponding lines) src/EcclesiaCRM/utils/MiscUtils.php:601 — src/EcclesiaCRM/utils/MiscUtils.php:601-675 | src/EcclesiaCRM/utils/MiscUtils.php:680-773 — These two members are one piece of code written twice and then edited apart: 75 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (47 corresponding lines) · ×1
  • Edited copy of a member (47 corresponding lines) src/EcclesiaCRM/Service/ConfirmReportService.php:361 — src/EcclesiaCRM/Service/ConfirmReportService.php:361-407 | src/EcclesiaCRM/Service/ConfirmReportService.php:586-632 — These two members are one piece of code written twice and then edited apart: 47 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (34 corresponding lines) · ×1
  • Edited copy of a member (34 corresponding lines) src/EcclesiaCRM/APIControllers/DocumentCKEditorController.php:136 — src/EcclesiaCRM/APIControllers/DocumentCKEditorController.php:136-169 | REDACTED:600-636 — These two members are one piece of code written twice and then edited apart: 34 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 39+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 39+ corresponding lines) src/EcclesiaCRM/APIControllers/SidebarMenuLinksController.php:33 — src/EcclesiaCRM/APIControllers/SidebarMenuLinksController.php:33-71 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:44-100 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:194-247 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 39 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 46+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 46+ corresponding lines) src/EcclesiaCRM/APIControllers/PeopleController.php:41 — src/EcclesiaCRM/APIControllers/PeopleController.php:41-91 | src/EcclesiaCRM/APIControllers/PeopleController.php:96-148 | src/EcclesiaCRM/APIControllers/PeopleController.php:153-198 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 46 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (29 corresponding lines) · ×1
  • Edited copy of a member (29 corresponding lines) src/EcclesiaCRM/APIControllers/SystemGDRPController.php:179 — src/EcclesiaCRM/APIControllers/SystemGDRPController.php:179-211 | src/EcclesiaCRM/APIControllers/SystemGDRPController.php:237-265 — These two members are one piece of code written twice and then edited apart: 29 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (50 corresponding lines) · ×1
  • Edited copy of a member (50 corresponding lines) src/EcclesiaCRM/Synchronize/PersonDashboardItem.php:127 — src/EcclesiaCRM/Synchronize/PersonDashboardItem.php:127-177 | src/EcclesiaCRM/Synchronize/PersonDemographicDashboardItem.php:15-64 — These two members are one piece of code written twice and then edited apart: 50 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (8 members, 5+ corresponding lines) · ×1
  • Edited copies of one member (8 members, 5+ corresponding lines) src/Plugins/MailChimp/core/model/Map/MailChimpParamsTableMap.php:265 — src/Plugins/MailChimp/core/model/Map/MailChimpParamsTableMap.php:265-269 | src/Plugins/MeetingJitsi/core/model/Map/PersonJitsiMeetingTableMap.php:223-227 | src/Plugins/MeetingJitsi/core/model/Map/PersonLastJitsiMeetingTableMap.php:209-213 | src/Plugins/MeetingJitsi/core/model/Map/PluginPrefJitsiMeetingTableMap.php:237-241 | src/Plugins/NewsDashboard/core/model/Map/NewsDashboardTableMap.php:265-269 | src/Plugins/NoteDashboard/core/model/Map/NoteDashboardTableMap.php:209-213 | src/Plugins/ToDoListDashboard/core/model/Map/ToDoListDashboardItemTableMap.php:251-255 | src/Plugins/ToDoListDashboard/core/model/Map/ToDoListDashboardTableMap.php:223-227 — These 8 members are one piece of code written 8 times and then edited apart: every two of them correspond over at least 5 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 8 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 23+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 23+ corresponding lines) src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:512 — src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:512-540 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:443-465 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:461-483 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:528-553 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 23 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (37 corresponding lines) · ×1
  • Edited copy of a member (37 corresponding lines) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:517 — src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:517-553 | src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:558-604 — These two members are one piece of code written twice and then edited apart: 37 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (35 corresponding lines) · ×1
  • Edited copy of a member (35 corresponding lines) src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:738 — src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:738-772 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:825-870 — These two members are one piece of code written twice and then edited apart: 35 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (27 corresponding lines) · ×1
  • Edited copy of a member (27 corresponding lines) REDACTED:91 — REDACTED:91-117 | REDACTED:121-147 — These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (48 corresponding lines) · ×1
  • Edited copy of a member (48 corresponding lines) src/EcclesiaCRM/APIControllers/CalendarV2Controller.php:555 — src/EcclesiaCRM/APIControllers/CalendarV2Controller.php:555-605 | src/EcclesiaCRM/APIControllers/CalendarV2Controller.php:609-656 — These two members are one piece of code written twice and then edited apart: 48 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 26+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 26+ corresponding lines) src/EcclesiaCRM/model/EcclesiaCRM/Family.php:48 — src/EcclesiaCRM/model/EcclesiaCRM/Family.php:48-73 | src/EcclesiaCRM/model/EcclesiaCRM/Family.php:78-105 | src/EcclesiaCRM/model/EcclesiaCRM/Person.php:461-488 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 26 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 23+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 23+ corresponding lines) src/EcclesiaCRM/Reports/PDF_Badge.php:64 — src/EcclesiaCRM/Reports/PDF_Badge.php:64-90 | REDACTED:103-126 | REDACTED:138-160 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 23 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (8 members, 26+ corresponding lines) · ×1
  • Edited copies of one member (8 members, 26+ corresponding lines) src/Plugins/MailChimp/core/model/Map/MailChimpParamsTableMap.php:467 — src/Plugins/MailChimp/core/model/Map/MailChimpParamsTableMap.php:467-492 | src/Plugins/MeetingJitsi/core/model/Map/PersonJitsiMeetingTableMap.php:413-438 | src/Plugins/MeetingJitsi/core/model/Map/PersonLastJitsiMeetingTableMap.php:395-420 | src/Plugins/MeetingJitsi/core/model/Map/PluginPrefJitsiMeetingTableMap.php:431-456 | src/Plugins/NewsDashboard/core/model/Map/NewsDashboardTableMap.php:467-492 | src/Plugins/NoteDashboard/core/model/Map/NoteDashboardTableMap.php:395-420 | src/Plugins/ToDoListDashboard/core/model/Map/ToDoListDashboardItemTableMap.php:449-474 | src/Plugins/ToDoListDashboard/core/model/Map/ToDoListDashboardTableMap.php:413-438 — These 8 members are one piece of code written 8 times and then edited apart: every two of them correspond over at least 26 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 8 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 17+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 17+ corresponding lines) src/EcclesiaCRM/APIControllers/UserUsersController.php:42 — src/EcclesiaCRM/APIControllers/UserUsersController.php:42-61 | src/EcclesiaCRM/APIControllers/UserUsersController.php:157-173 | src/EcclesiaCRM/APIControllers/UserUsersController.php:178-196 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 17 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (8 members, 23+ corresponding lines) · ×1
  • Edited copies of one member (8 members, 23+ corresponding lines) src/Plugins/MailChimp/core/model/Map/MailChimpParamsTableMap.php:517 — src/Plugins/MailChimp/core/model/Map/MailChimpParamsTableMap.php:517-539 | src/Plugins/MeetingJitsi/core/model/Map/PersonJitsiMeetingTableMap.php:463-485 | src/Plugins/MeetingJitsi/core/model/Map/PersonLastJitsiMeetingTableMap.php:445-467 | src/Plugins/MeetingJitsi/core/model/Map/PluginPrefJitsiMeetingTableMap.php:481-503 | src/Plugins/NewsDashboard/core/model/Map/NewsDashboardTableMap.php:517-539 | src/Plugins/NoteDashboard/core/model/Map/NoteDashboardTableMap.php:445-467 | src/Plugins/ToDoListDashboard/core/model/Map/ToDoListDashboardItemTableMap.php:499-521 | src/Plugins/ToDoListDashboard/core/model/Map/ToDoListDashboardTableMap.php:463-485 — These 8 members are one piece of code written 8 times and then edited apart: every two of them correspond over at least 23 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 8 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (8 members, 18+ corresponding lines) · ×1
  • Edited copies of one member (8 members, 18+ corresponding lines) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:751 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:751-768 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:612-629 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:537-554 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:647-664 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:759-776 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:555-572 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:625-642 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:728-745 — These 8 members are one piece of code written 8 times and then edited apart: every two of them correspond over at least 18 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 8 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (5 members, 13+ corresponding lines) · ×1
  • Edited copies of one member (5 members, 13+ corresponding lines) src/Plugins/MailChimp/core/VIEWControllers/VIEWMailchimpController.php:84 — src/Plugins/MailChimp/core/VIEWControllers/VIEWMailchimpController.php:84-98 | src/Plugins/MailChimp/core/VIEWControllers/VIEWMailchimpController.php:130-144 | src/Plugins/MailChimp/core/VIEWControllers/VIEWMailchimpController.php:178-190 | src/Plugins/MailChimp/core/VIEWControllers/VIEWMailchimpController.php:208-220 | src/Plugins/MailChimp/core/VIEWControllers/VIEWMailchimpController.php:237-249 — These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 14+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 14+ corresponding lines) src/EcclesiaCRM/model/EcclesiaCRM/Family.php:401 — src/EcclesiaCRM/model/EcclesiaCRM/Family.php:401-416 | src/EcclesiaCRM/model/EcclesiaCRM/Family.php:419-432 | src/EcclesiaCRM/model/EcclesiaCRM/Person.php:605-620 | src/EcclesiaCRM/model/EcclesiaCRM/Person.php:634-647 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 14 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (23 corresponding lines) · ×1
  • Edited copy of a member (23 corresponding lines) src/EcclesiaCRM/Service/FinancialService.php:105 — src/EcclesiaCRM/Service/FinancialService.php:105-127 | src/EcclesiaCRM/Service/FinancialService.php:667-693 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (5 members, 15+ corresponding lines) · ×1
  • Edited copies of one member (5 members, 15+ corresponding lines) src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:413 — src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:413-429 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:433-447 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:451-465 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:626-647 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:651-669 — These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 15 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 24+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 24+ corresponding lines) src/EcclesiaCRM/APIControllers/CalendarV2Controller.php:486 — src/EcclesiaCRM/APIControllers/CalendarV2Controller.php:486-509 | src/EcclesiaCRM/APIControllers/CalendarV2Controller.php:660-684 | src/EcclesiaCRM/APIControllers/CalendarV2Controller.php:688-714 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 24 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (8 members, 22+ corresponding lines) · ×1
  • Edited copies of one member (8 members, 22+ corresponding lines) src/Plugins/MailChimp/core/model/Map/MailChimpParamsTableMap.php:352 — src/Plugins/MailChimp/core/model/Map/MailChimpParamsTableMap.php:352-373 | src/Plugins/MeetingJitsi/core/model/Map/PersonJitsiMeetingTableMap.php:310-331 | src/Plugins/MeetingJitsi/core/model/Map/PersonLastJitsiMeetingTableMap.php:296-317 | src/Plugins/MeetingJitsi/core/model/Map/PluginPrefJitsiMeetingTableMap.php:324-345 | src/Plugins/NewsDashboard/core/model/Map/NewsDashboardTableMap.php:352-373 | src/Plugins/NoteDashboard/core/model/Map/NoteDashboardTableMap.php:296-317 | src/Plugins/ToDoListDashboard/core/model/Map/ToDoListDashboardItemTableMap.php:338-359 | src/Plugins/ToDoListDashboard/core/model/Map/ToDoListDashboardTableMap.php:310-331 — These 8 members are one piece of code written 8 times and then edited apart: every two of them correspond over at least 22 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 8 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 18+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 18+ corresponding lines) src/EcclesiaCRM/APIControllers/FinancePaymentController.php:70 — src/EcclesiaCRM/APIControllers/FinancePaymentController.php:70-88 | src/EcclesiaCRM/APIControllers/FinancePledgeController.php:32-51 | src/EcclesiaCRM/APIControllers/FinancePledgeController.php:56-73 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 18 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (6 members, 15+ corresponding lines) · ×1
  • Edited copies of one member (6 members, 15+ corresponding lines) src/EcclesiaCRM/APIControllers/PastoralCareController.php:488 — src/EcclesiaCRM/APIControllers/PastoralCareController.php:488-502 | src/EcclesiaCRM/APIControllers/PastoralCareController.php:507-521 | src/EcclesiaCRM/APIControllers/PastoralCareController.php:526-540 | src/EcclesiaCRM/APIControllers/PastoralCareController.php:545-559 | src/EcclesiaCRM/APIControllers/PastoralCareController.php:564-578 | src/EcclesiaCRM/APIControllers/PastoralCareController.php:583-602 — These 6 members are one piece of code written 6 times and then edited apart: every two of them correspond over at least 15 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 6 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (5 members, 14+ corresponding lines) · ×1
  • Edited copies of one member (5 members, 14+ corresponding lines) src/EcclesiaCRM/APIControllers/PeopleGroupController.php:682 — src/EcclesiaCRM/APIControllers/PeopleGroupController.php:682-695 | src/EcclesiaCRM/APIControllers/PeopleGroupController.php:699-712 | src/EcclesiaCRM/APIControllers/VolunteerOpportunityController.php:40-53 | src/EcclesiaCRM/APIControllers/VolunteerOpportunityController.php:57-70 | src/EcclesiaCRM/APIControllers/VolunteerOpportunityController.php:108-121 — These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 14 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (8 members, 15+ corresponding lines) · ×1
  • Edited copies of one member (8 members, 15+ corresponding lines) src/Plugins/MailChimp/core/model/Map/MailChimpParamsTableMap.php:324 — src/Plugins/MailChimp/core/model/Map/MailChimpParamsTableMap.php:324-338 | src/Plugins/MeetingJitsi/core/model/Map/PersonJitsiMeetingTableMap.php:282-296 | src/Plugins/MeetingJitsi/core/model/Map/PersonLastJitsiMeetingTableMap.php:268-282 | src/Plugins/MeetingJitsi/core/model/Map/PluginPrefJitsiMeetingTableMap.php:296-310 | src/Plugins/NewsDashboard/core/model/Map/NewsDashboardTableMap.php:324-338 | src/Plugins/NoteDashboard/core/model/Map/NoteDashboardTableMap.php:268-282 | src/Plugins/ToDoListDashboard/core/model/Map/ToDoListDashboardItemTableMap.php:310-324 | src/Plugins/ToDoListDashboard/core/model/Map/ToDoListDashboardTableMap.php:282-296 — These 8 members are one piece of code written 8 times and then edited apart: every two of them correspond over at least 15 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 8 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (8 members, 21+ corresponding lines) · ×1
  • Edited copies of one member (8 members, 21+ corresponding lines) src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:557 — src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:557-577 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeetingQuery.php:471-491 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeetingQuery.php:435-455 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeetingQuery.php:488-508 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboardQuery.php:590-610 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboardQuery.php:420-440 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItemQuery.php:555-575 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardQuery.php:455-475 — These 8 members are one piece of code written 8 times and then edited apart: every two of them correspond over at least 21 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 8 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (5 members, 17+ corresponding lines) · ×1
  • Edited copies of one member (5 members, 17+ corresponding lines) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:1041 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:1041-1061 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:787-803 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:917-935 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:805-821 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:885-902 — These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 17 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 13+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 13+ corresponding lines) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:1198 — src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:1198-1210 | src/EcclesiaCRM/APIControllers/UserUsersController.php:201-214 | src/EcclesiaCRM/APIControllers/UserUsersController.php:219-232 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 10+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 10+ corresponding lines) src/EcclesiaCRM/Emails/verify/FamilyVerificationEmail.php:25 — src/EcclesiaCRM/Emails/verify/FamilyVerificationEmail.php:25-34 | src/EcclesiaCRM/Emails/verify/FamilyVerificationValidation.php:23-32 | src/EcclesiaCRM/Emails/verify/PersonVerificationEmail.php:28-38 | src/EcclesiaCRM/Emails/verify/PersonVerificationValidation.php:23-32 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 10 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (6 members, 9+ corresponding lines) · ×1
  • Edited copies of one member (6 members, 9+ corresponding lines) src/EcclesiaCRM/Theme/Theme.php:55 — src/EcclesiaCRM/Theme/Theme.php:55-65 | src/EcclesiaCRM/Theme/Theme.php:98-106 | src/EcclesiaCRM/Theme/Theme.php:129-139 | src/EcclesiaCRM/Theme/Theme.php:144-154 | src/EcclesiaCRM/Theme/Theme.php:159-169 | src/EcclesiaCRM/Theme/Theme.php:174-184 — These 6 members are one piece of code written 6 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 6 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 16+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 16+ corresponding lines) src/EcclesiaCRM/model/EcclesiaCRM/Event.php:29 — src/EcclesiaCRM/model/EcclesiaCRM/Event.php:29-44 | src/EcclesiaCRM/model/EcclesiaCRM/Event.php:49-64 | src/EcclesiaCRM/model/EcclesiaCRM/Event.php:69-84 | src/EcclesiaCRM/model/EcclesiaCRM/Event.php:89-104 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 16 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (8 members, 12+ corresponding lines) · ×1
  • Edited copies of one member (8 members, 12+ corresponding lines) src/EcclesiaCRM/APIControllers/CartController.php:114 — src/EcclesiaCRM/APIControllers/CartController.php:114-125 | src/EcclesiaCRM/APIControllers/CartController.php:129-140 | src/EcclesiaCRM/APIControllers/CartController.php:159-170 | src/EcclesiaCRM/APIControllers/CartController.php:174-187 | src/EcclesiaCRM/APIControllers/CartController.php:233-244 | src/EcclesiaCRM/APIControllers/CartController.php:289-300 | src/EcclesiaCRM/APIControllers/CartController.php:504-517 | src/EcclesiaCRM/APIControllers/CartController.php:525-536 — These 8 members are one piece of code written 8 times and then edited apart: every two of them correspond over at least 12 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 8 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 12+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 12+ corresponding lines) src/EcclesiaCRM/APIControllers/FinancePaymentController.php:142 — src/EcclesiaCRM/APIControllers/FinancePaymentController.php:142-156 | src/EcclesiaCRM/APIControllers/FinancePaymentController.php:161-172 | src/EcclesiaCRM/APIControllers/FinancePledgeController.php:78-91 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 12 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (8 members, 17+ corresponding lines) · ×1
  • Edited copies of one member (8 members, 17+ corresponding lines) src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:527 — src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:527-543 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeetingQuery.php:441-457 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeetingQuery.php:405-421 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeetingQuery.php:458-474 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboardQuery.php:560-576 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboardQuery.php:390-406 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItemQuery.php:525-541 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardQuery.php:425-441 — These 8 members are one piece of code written 8 times and then edited apart: every two of them correspond over at least 17 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 8 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (6 members, 7+ corresponding lines) · ×1
  • Edited copies of one member (6 members, 7+ corresponding lines) src/EcclesiaCRM/VIEWControllers/Sidebar/VIEWPastoralcareListController.php:33 — src/EcclesiaCRM/VIEWControllers/Sidebar/VIEWPastoralcareListController.php:33-39 | src/EcclesiaCRM/VIEWControllers/VIEWPastoralCareController.php:157-163 | src/EcclesiaCRM/VIEWControllers/VIEWPastoralCareController.php:193-201 | src/EcclesiaCRM/VIEWControllers/VIEWPastoralCareController.php:412-420 | src/EcclesiaCRM/VIEWControllers/VIEWPastoralCareController.php:528-535 | src/EcclesiaCRM/VIEWControllers/VIEWPastoralCareController.php:570-578 — These 6 members are one piece of code written 6 times and then edited apart: every two of them correspond over at least 7 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 6 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (6 members, 12+ corresponding lines) · ×1
  • Edited copies of one member (6 members, 12+ corresponding lines) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:1358 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:1358-1372 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:1160-1171 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:1212-1224 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:1374-1388 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:1169-1180 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:1318-1331 — These 6 members are one piece of code written 6 times and then edited apart: every two of them correspond over at least 12 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 6 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (5 members, 7+ corresponding lines) · ×1
  • Edited copies of one member (5 members, 7+ corresponding lines) src/EcclesiaCRM/VIEWControllers/Sidebar/VIEWSystemSettingsController.php:38 — src/EcclesiaCRM/VIEWControllers/Sidebar/VIEWSystemSettingsController.php:38-44 | src/EcclesiaCRM/VIEWControllers/Sidebar/VIEWSystemSettingsController.php:67-75 | src/EcclesiaCRM/VIEWControllers/VIEWCalendarController.php:343-349 | src/EcclesiaCRM/VIEWControllers/VIEWCalendarController.php:368-374 | src/EcclesiaCRM/VIEWControllers/VIEWQueryController.php:119-126 — These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 7 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 3+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 3+ corresponding lines) REDACTED:58 — REDACTED:58-60 | REDACTED:72-78 | REDACTED:82-87 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 3 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (8 corresponding lines) · ×1
  • Edited copy of a member (8 corresponding lines) src/EcclesiaCRM/model/EcclesiaCRM/Event.php:136 — src/EcclesiaCRM/model/EcclesiaCRM/Event.php:136-143 | src/EcclesiaCRM/model/EcclesiaCRM/Event.php:162-169 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (6 corresponding lines) · ×1
  • Edited copy of a member (6 corresponding lines) src/EcclesiaCRM/Reports/CSV_RealAttendance.php:40 — src/EcclesiaCRM/Reports/CSV_RealAttendance.php:40-45 | src/EcclesiaCRM/Reports/PDF_RealAttendance.php:44-51 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (41–81 lines × 2) · ×1
  • Duplicated block (41–81 lines × 2) REDACTED:594 — REDACTED:594-634 | REDACTED:852-932 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (80 lines × 2) · ×1
  • Duplicated block (80 lines × 2) src/EcclesiaCRM/Service/CalendarService.php:71 — src/EcclesiaCRM/Service/CalendarService.php:71-150 | src/EcclesiaCRM/Service/CalendarService.php:824-903 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Service/CalendarService.php:71` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/EcclesiaCRM/Service/CalendarService.php:67` calls `format` and `src/EcclesiaCRM/Service/CalendarService.php:821` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (67–73 lines × 2) · ×1
  • Duplicated block (67–73 lines × 2) src/EcclesiaCRM/utils/MiscUtils.php:607 — src/EcclesiaCRM/utils/MiscUtils.php:607-673 | src/EcclesiaCRM/utils/MiscUtils.php:697-769 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/utils/MiscUtils.php:607` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (146 lines × 2) · ×1
  • Duplicated block (146 lines × 2) src/EcclesiaCRM/Reports/PDF_Badge.php:103 — src/EcclesiaCRM/Reports/PDF_Badge.php:103-248 | src/EcclesiaCRM/Reports/PDF_Badge.php:261-406 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (68 lines × 2) · ×1
  • Duplicated block (68 lines × 2) src/EcclesiaCRM/sabre/CardDav/CardDavACLPlugin.php:35 — src/EcclesiaCRM/sabre/CardDav/CardDavACLPlugin.php:35-102 | src/EcclesiaCRM/sabre/WebDav/WebDavACLPlugin.php:47-114 — before extracting anything, compare `src/EcclesiaCRM/sabre/CardDav/CardDavACLPlugin.php` and `src/EcclesiaCRM/sabre/WebDav/WebDavACLPlugin.php` as WHOLE FILES: 98% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/sabre/CardDav/CardDavACLPlugin.php:35` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (70–73 lines × 2) · ×1
  • Duplicated block (70–73 lines × 2) src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:518 — src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:518-590 | src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:660-729 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:518` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (55 lines × 2) · ×1
  • Duplicated block (55 lines × 2) src/EcclesiaCRM/SQLUtils.php:42 — src/EcclesiaCRM/SQLUtils.php:42-96 | src/EcclesiaCRM/SQLUtils.php:106-160 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/SQLUtils.php:42` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (100 lines × 2) · ×1
  • Duplicated block (100 lines × 2) src/EcclesiaCRM/Service/DashboardItemService.php:28 — src/EcclesiaCRM/Service/DashboardItemService.php:28-127 | src/EcclesiaCRM/Synchronize/SundaySchoolDashboardItem.php:38-137 — before extracting anything, compare `src/EcclesiaCRM/Service/DashboardItemService.php` and `src/EcclesiaCRM/Synchronize/SundaySchoolDashboardItem.php` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 162 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (49 lines × 2) · ×1
  • Duplicated block (49 lines × 2) src/EcclesiaCRM/utils/MiscUtils.php:907 — src/EcclesiaCRM/utils/MiscUtils.php:907-955 | src/EcclesiaCRM/utils/MiscUtils.php:1191-1239 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/utils/MiscUtils.php:907` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/EcclesiaCRM/utils/MiscUtils.php:905` calls `getAppLogger`, `error` and `src/EcclesiaCRM/utils/MiscUtils.php:1190` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (25–46 lines × 5) · ×1
  • Duplicated block (25–46 lines × 5) src/EcclesiaCRM/Search/FamilyPastoralCareSearchRes.php:108 — src/EcclesiaCRM/Search/FamilyPastoralCareSearchRes.php:108-153 | src/EcclesiaCRM/Search/FamilyPropsSearchRes.php:145-169 | src/EcclesiaCRM/Search/GroupPropsSearchRes.php:128-152 | src/EcclesiaCRM/Search/PersonGroupManagerSearchRes.php:150-176 | src/EcclesiaCRM/Search/PersonPropsSearchRes.php:142-166 — before extracting anything, compare `src/EcclesiaCRM/Search/PersonGroupManagerSearchRes.php` and `src/EcclesiaCRM/Search/PersonPropsSearchRes.php` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 81 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Search/FamilyPastoralCareSearchRes.php:108` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (43–44 lines × 2) · ×1
  • Duplicated block (43–44 lines × 2) src/EcclesiaCRM/Service/CalendarService.php:1233 — src/EcclesiaCRM/Service/CalendarService.php:1233-1276 | src/EcclesiaCRM/Service/CalendarService.php:1278-1320 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Service/CalendarService.php:1233` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (41–42 lines × 2) · ×1
  • Duplicated block (41–42 lines × 2) src/EcclesiaCRM/Service/CalendarService.php:1786 — src/EcclesiaCRM/Service/CalendarService.php:1786-1827 | src/EcclesiaCRM/Service/CalendarService.php:2189-2229 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Service/CalendarService.php:1786` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/EcclesiaCRM/Service/CalendarService.php:2231` calls `DateTime`, `getDateTime`, `format` and `src/EcclesiaCRM/Service/CalendarService.php:1830` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (40 lines × 2) · ×1
  • Duplicated block (40 lines × 2) src/EcclesiaCRM/Synchronize/PersonDashboardItem.php:138 — src/EcclesiaCRM/Synchronize/PersonDashboardItem.php:138-177 | src/EcclesiaCRM/Synchronize/PersonDemographicDashboardItem.php:25-64 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Synchronize/PersonDashboardItem.php:138` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (38–39 lines × 3) · ×1
  • Duplicated block (38–39 lines × 3) src/EcclesiaCRM/Service/CalendarService.php:706 — src/EcclesiaCRM/Service/CalendarService.php:706-743 | src/EcclesiaCRM/Service/CalendarService.php:1235-1273 | src/EcclesiaCRM/Service/CalendarService.php:1278-1316 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Service/CalendarService.php:706` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (37 lines × 2) · ×1
  • Duplicated block (37 lines × 2) src/EcclesiaCRM/Service/SundaySchoolService.php:189 — src/EcclesiaCRM/Service/SundaySchoolService.php:189-225 | src/EcclesiaCRM/Service/SundaySchoolService.php:231-267 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
D4 · Code Duplication · Duplicated block (35–36 lines × 2) · ×1
  • Duplicated block (35–36 lines × 2) src/EcclesiaCRM/Service/CalendarService.php:549 — src/EcclesiaCRM/Service/CalendarService.php:549-583 | src/EcclesiaCRM/Service/CalendarService.php:1180-1215 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Service/CalendarService.php:549` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (32–35 lines × 5) · ×1
  • Duplicated block (32–35 lines × 5) src/EcclesiaCRM/Reports/CSV_RealAttendance.php:189 — src/EcclesiaCRM/Reports/CSV_RealAttendance.php:189-220 | src/EcclesiaCRM/Reports/PDF_RealAttendance.php:202-233 | src/EcclesiaCRM/Service/CalendarService.php:400-434 | src/EcclesiaCRM/Service/CalendarService.php:659-693 | src/EcclesiaCRM/Service/CalendarService.php:1106-1140 — before extracting anything, compare `src/EcclesiaCRM/Reports/CSV_RealAttendance.php` and `src/EcclesiaCRM/Reports/PDF_RealAttendance.php` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (30–32 lines × 2) · ×1
  • Duplicated block (30–32 lines × 2) src/EcclesiaCRM/APIControllers/PeopleController.php:309 — src/EcclesiaCRM/APIControllers/PeopleController.php:309-338 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:182-213 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/PeopleController.php:309` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (32 lines × 2) · ×1
  • Duplicated block (32 lines × 2) REDACTED:804 — REDACTED:804-835 | REDACTED:945-976 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (30–31 lines × 2) · ×1
  • Duplicated block (30–31 lines × 2) src/EcclesiaCRM/model/EcclesiaCRM/Group.php:254 — src/EcclesiaCRM/model/EcclesiaCRM/Group.php:254-283 | src/EcclesiaCRM/model/EcclesiaCRM/VolunteerOpportunity.php:98-128 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (29 lines × 8) · ×1
  • Duplicated block (29 lines × 8) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:1492 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:1492-1520 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:1291-1319 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:1189-1217 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:1344-1372 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:1508-1536 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:1208-1236 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:1300-1328 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:1451-1479 — before extracting anything, compare `src/Plugins/MailChimp/core/model/Base/MailChimpParams.php` and `src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 159 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (28–29 lines × 2) · ×1
  • Duplicated block (28–29 lines × 2) src/EcclesiaCRM/APIControllers/PeopleController.php:165 — src/EcclesiaCRM/APIControllers/PeopleController.php:165-192 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:107-135 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/EcclesiaCRM/APIControllers/PeopleController.php:164` calls `filterByDateDeactivated` and `src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:106` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (36 lines × 3) · ×1
  • Duplicated block (36 lines × 3) src/EcclesiaCRM/APIControllers/PeopleGroupController.php:842 — src/EcclesiaCRM/APIControllers/PeopleGroupController.php:842-877 | src/EcclesiaCRM/Service/DashboardItemService.php:69-104 | src/EcclesiaCRM/Synchronize/SundaySchoolDashboardItem.php:79-114 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/PeopleGroupController.php:842` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (25–26 lines × 2) · ×1
  • Duplicated block (25–26 lines × 2) src/EcclesiaCRM/APIControllers/PeopleController.php:277 — src/EcclesiaCRM/APIControllers/PeopleController.php:277-301 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:150-175 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/PeopleController.php:277` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (25 lines × 3) · ×1
  • Duplicated block (25 lines × 3) src/EcclesiaCRM/Service/CalendarService.php:352 — src/EcclesiaCRM/Service/CalendarService.php:352-376 | src/EcclesiaCRM/Service/CalendarService.php:611-635 | src/EcclesiaCRM/Service/CalendarService.php:1058-1082 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Service/CalendarService.php:352` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (23–25 lines × 2) · ×1
  • Duplicated block (23–25 lines × 2) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:531 — src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:531-553 | src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:580-604 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:531` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (25 lines × 2) · ×1
  • Duplicated block (25 lines × 2) src/EcclesiaCRM/Search/DepositSearchRes.php:125 — src/EcclesiaCRM/Search/DepositSearchRes.php:125-149 | src/EcclesiaCRM/Search/DepositSearchRes.php:183-207 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Search/DepositSearchRes.php:125` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (18–23 lines × 3) · ×1
  • Duplicated block (18–23 lines × 3) src/EcclesiaCRM/APIControllers/CartController.php:386 — src/EcclesiaCRM/APIControllers/CartController.php:386-408 | src/EcclesiaCRM/APIControllers/CartController.php:417-437 | src/EcclesiaCRM/VIEWControllers/VIEWCartController.php:77-94 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/CartController.php:386` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (23 lines × 3) · ×1
  • Duplicated block (23 lines × 3) src/EcclesiaCRM/APIControllers/PastoralCareController.php:46 — src/EcclesiaCRM/APIControllers/PastoralCareController.php:46-68 | src/EcclesiaCRM/APIControllers/PastoralCareController.php:432-454 | src/EcclesiaCRM/VIEWControllers/VIEWPastoralCareController.php:86-108 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/PastoralCareController.php:46` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (22–23 lines × 2) · ×1
  • Duplicated block (22–23 lines × 2) src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:485 — src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:485-507 | src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:629-650 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:485` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:653` calls `searchAndDeleteOneEvent` and `src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:511` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (20–23 lines × 2) · ×1
  • Duplicated block (20–23 lines × 2) src/EcclesiaCRM/MenuBar/MenuBar.php:492 — src/EcclesiaCRM/MenuBar/MenuBar.php:492-511 | src/EcclesiaCRM/MenuBar/MenuBar.php:722-744 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/MenuBar/MenuBar.php:492` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/EcclesiaCRM/MenuBar/MenuBar.php:488` calls `addLink`, `getID` and `src/EcclesiaCRM/MenuBar/MenuBar.php:719` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (22 lines × 4) · ×1
  • Duplicated block (22 lines × 4) src/Plugins/ToDoListDashboard/core/APIControllers/ToDoListDashboardController.php:195 — src/Plugins/ToDoListDashboard/core/APIControllers/ToDoListDashboardController.php:195-216 | src/Plugins/ToDoListDashboard/core/APIControllers/ToDoListDashboardController.php:245-266 | src/Plugins/ToDoListDashboard/core/APIControllers/ToDoListDashboardController.php:328-349 | src/Plugins/ToDoListDashboard/core/APIControllers/ToDoListDashboardController.php:386-407 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Plugins/ToDoListDashboard/core/APIControllers/ToDoListDashboardController.php:195` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (20 lines × 8) · ×1
  • Duplicated block (20 lines × 8) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:836 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:836-855 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:697-716 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:622-641 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:732-751 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:844-863 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:640-659 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:710-729 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:813-832 — before extracting anything, compare `src/Plugins/MailChimp/core/model/Base/MailChimpParams.php` and `src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 159 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
D4 · Code Duplication · Duplicated block (19 lines × 3) · ×1
  • Duplicated block (19 lines × 3) src/EcclesiaCRM/APIControllers/PastoralCareController.php:70 — src/EcclesiaCRM/APIControllers/PastoralCareController.php:70-88 | src/EcclesiaCRM/APIControllers/PastoralCareController.php:457-475 | src/EcclesiaCRM/VIEWControllers/VIEWPastoralCareController.php:110-128 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/PastoralCareController.php:70` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (17–18 lines × 2) · ×1
  • Duplicated block (17–18 lines × 2) src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:524 — src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:524-540 | src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:765-782 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/PeopleAttendeesController.php:524` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (16–18 lines × 2) · ×1
  • Duplicated block (16–18 lines × 2) src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:514 — src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:514-531 | src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:575-590 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:512` calls `setRoleId` and `src/EcclesiaCRM/VIEWControllers/VIEWUserController.php:574` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (17 lines × 8) · ×1
  • Duplicated block (17 lines × 8) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:936 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:936-952 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:776-792 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:694-710 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:818-834 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:944-960 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:712-728 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:789-805 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:906-922 — before extracting anything, compare `src/Plugins/MailChimp/core/model/Base/MailChimpParams.php` and `src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 159 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:936` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:774` calls `bindValue`, `format` and `src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:934` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (17 lines × 3) · ×1
  • Duplicated block (17 lines × 3) src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:409 — src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:409-425 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:495-511 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:567-583 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:409` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (14–17 lines × 2) · ×1
  • Duplicated block (14–17 lines × 2) src/EcclesiaCRM/Search/AddressSearchRes.php:67 — src/EcclesiaCRM/Search/AddressSearchRes.php:67-80 | src/EcclesiaCRM/Search/FamilySearchRes.php:92-108 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Search/AddressSearchRes.php:67` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (16 lines × 8) · ×1
  • Duplicated block (16 lines × 8) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:798 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:798-813 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:659-674 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:584-599 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:694-709 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:806-821 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:602-617 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:672-687 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:775-790 — before extracting anything, compare `src/Plugins/MailChimp/core/model/Base/MailChimpParams.php` and `src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 159 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:798` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (16 lines × 3) · ×1
  • Duplicated block (16 lines × 3) src/EcclesiaCRM/APIControllers/SidebarMenuLinksController.php:56 — src/EcclesiaCRM/APIControllers/SidebarMenuLinksController.php:56-71 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:85-100 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:232-247 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/SidebarMenuLinksController.php:56` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
D4 · Code Duplication · Duplicated block (13–16 lines × 3) · ×1
  • Duplicated block (13–16 lines × 3) REDACTED:1488 — REDACTED:1488-1501 | src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:440-455 | src/EcclesiaCRM/VIEWControllers/VIEWSystemController.php:238-250 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:1488` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (14–16 lines × 2) · ×1
  • Duplicated block (14–16 lines × 2) src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:877 — src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:877-890 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:1013-1028 — before extracting anything, compare `src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php` and `src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php` as WHOLE FILES: this scan already matched 14 separate duplicated blocks between them, totalling at least 186 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (13–15 lines × 5) · ×1
  • Duplicated block (13–15 lines × 5) src/EcclesiaCRM/APIControllers/CartController.php:486 — src/EcclesiaCRM/APIControllers/CartController.php:486-498 | REDACTED:476-488 | src/EcclesiaCRM/APIControllers/PeopleGroupController.php:150-164 | REDACTED:649-661 | src/EcclesiaCRM/APIControllers/VolunteerOpportunityController.php:90-104 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 5 call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (15 lines × 3) · ×1
  • Duplicated block (15 lines × 3) src/EcclesiaCRM/APIControllers/PeopleController.php:178 — src/EcclesiaCRM/APIControllers/PeopleController.php:178-192 | src/EcclesiaCRM/APIControllers/PeopleController.php:248-262 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:120-135 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/PeopleController.php:178` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (14 lines × 8) · ×1
  • Duplicated block (14 lines × 8) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:896 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:896-909 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:748-761 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:670-683 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:786-799 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:904-917 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:688-701 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:761-774 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:870-883 — before extracting anything, compare `src/Plugins/MailChimp/core/model/Base/MailChimpParams.php` and `src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 159 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:896` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (14 lines × 4) · ×1
  • Duplicated block (14 lines × 4) REDACTED:211 — REDACTED:211-224 | REDACTED:668-681 | REDACTED:830-843 | REDACTED:971-984 — there are 4 copies across 3 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart.
D4 · Code Duplication · Duplicated block (14 lines × 3) · ×1
  • Duplicated block (14 lines × 3) src/EcclesiaCRM/Service/PastoralCareService.php:216 — src/EcclesiaCRM/Service/PastoralCareService.php:216-229 | src/EcclesiaCRM/Service/PastoralCareService.php:239-252 | src/EcclesiaCRM/Service/PastoralCareService.php:262-275 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/EcclesiaCRM/Service/PastoralCareService.php:238` calls `filterByBirthYear`, `format` and `src/EcclesiaCRM/Service/PastoralCareService.php:215` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (13–14 lines × 3) · ×1
  • Duplicated block (13–14 lines × 3) REDACTED:1477 — REDACTED:1477-1490 | src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:316-329 | src/EcclesiaCRM/VIEWControllers/VIEWGroupController.php:310-322 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:1477` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (12–14 lines × 2) · ×1
  • Duplicated block (12–14 lines × 2) src/EcclesiaCRM/model/EcclesiaCRM/Family.php:54 — src/EcclesiaCRM/model/EcclesiaCRM/Family.php:54-67 | src/EcclesiaCRM/model/EcclesiaCRM/Person.php:468-479 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (3–14 lines × 3) · ×1
  • Duplicated block (3–14 lines × 3) src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:718 — src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:718-720 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:756-769 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:853-866 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:756` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:716` calls `Create`, `findOneById` and `src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:754` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (13 lines × 4) · ×1
  • Duplicated block (13 lines × 4) REDACTED:727 — REDACTED:727-739 | REDACTED:832-844 | REDACTED:877-889 | src/Reports/CanvassReports.php:307-319 — there are 4 copies across 3 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart.
D4 · Code Duplication · Duplicated block (13 lines × 3) · ×1
  • Duplicated block (13 lines × 3) src/EcclesiaCRM/Service/CalendarService.php:509 — src/EcclesiaCRM/Service/CalendarService.php:509-521 | src/EcclesiaCRM/Service/CalendarService.php:531-543 | src/EcclesiaCRM/sabre/CalDav/VObjectExtract.php:202-214 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Service/CalendarService.php:509` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/EcclesiaCRM/sabre/CalDav/VObjectExtract.php:195` calls `array_merge` and `src/EcclesiaCRM/Service/CalendarService.php:521` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (4–13 lines × 4) · ×1
  • Duplicated block (4–13 lines × 4) src/EcclesiaCRM/Reports/ChurchInfoReportTCPDF.php:191 — src/EcclesiaCRM/Reports/ChurchInfoReportTCPDF.php:191-194 | src/Reports/CanvassReports.php:65-75 | src/Reports/CanvassReports.php:364-376 | src/Reports/CanvassReports.php:440-450 — there are 4 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/Reports/CanvassReports.php:65` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Reports/CanvassReports.php:76` calls `WriteAt`, `getValue` and `src/EcclesiaCRM/Reports/ChurchInfoReportTCPDF.php:195` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (12 lines × 5) · ×1
  • Duplicated block (12 lines × 5) src/EcclesiaCRM/Service/PastoralCareService.php:487 — src/EcclesiaCRM/Service/PastoralCareService.php:487-498 | src/EcclesiaCRM/Service/PastoralCareService.php:500-511 | src/EcclesiaCRM/Service/PastoralCareService.php:513-524 | src/EcclesiaCRM/Service/PastoralCareService.php:526-537 | src/EcclesiaCRM/Service/PastoralCareService.php:539-552 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Service/PastoralCareService.php:487` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (13–14 lines × 4) · ×1
  • Duplicated block (13–14 lines × 4) src/EcclesiaCRM/Service/CalendarService.php:508 — src/EcclesiaCRM/Service/CalendarService.php:508-521 | src/EcclesiaCRM/Service/CalendarService.php:530-542 | src/EcclesiaCRM/sabre/CalDav/VObjectExtract.php:179-192 | src/EcclesiaCRM/sabre/CalDav/VObjectExtract.php:201-213 — there are 4 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/EcclesiaCRM/sabre/CalDav/VObjectExtract.php:195` calls `array_merge` and `src/EcclesiaCRM/Service/CalendarService.php:526` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (11 lines × 5) · ×1
  • Duplicated block (11 lines × 5) src/EcclesiaCRM/APIControllers/PastoralCareController.php:192 — src/EcclesiaCRM/APIControllers/PastoralCareController.php:192-202 | src/EcclesiaCRM/APIControllers/PastoralCareController.php:262-272 | src/EcclesiaCRM/APIControllers/PastoralCareController.php:298-308 | src/EcclesiaCRM/APIControllers/PastoralCareController.php:321-331 | src/EcclesiaCRM/APIControllers/PastoralCareController.php:393-403 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
D4 · Code Duplication · Duplicated block (10–11 lines × 4) · ×1
  • Duplicated block (10–11 lines × 4) src/EcclesiaCRM/APIControllers/CartController.php:191 — src/EcclesiaCRM/APIControllers/CartController.php:191-201 | src/EcclesiaCRM/APIControllers/CartController.php:212-222 | src/EcclesiaCRM/APIControllers/CartController.php:248-257 | src/EcclesiaCRM/APIControllers/CartController.php:268-278 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/CartController.php:191` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (11 lines × 4) · ×1
  • Duplicated block (11 lines × 4) src/EcclesiaCRM/Service/PastoralCareService.php:290 — src/EcclesiaCRM/Service/PastoralCareService.php:290-300 | src/EcclesiaCRM/Service/PastoralCareService.php:314-324 | src/EcclesiaCRM/Service/PastoralCareService.php:368-378 | src/EcclesiaCRM/Service/PastoralCareService.php:394-404 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/EcclesiaCRM/Service/PastoralCareService.php:392` calls `filterByFamilyId`, `_or`, `filterByDate` and `src/EcclesiaCRM/Service/PastoralCareService.php:288` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (9–11 lines × 4) · ×1
  • Duplicated block (9–11 lines × 4) REDACTED:260 — REDACTED:260-270 | REDACTED:1480-1490 | src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:319-329 | src/EcclesiaCRM/VIEWControllers/VIEWGroupController.php:314-322 — there are 4 copies across 3 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:260` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (7–11 lines × 4) · ×1
  • Duplicated block (7–11 lines × 4) src/EcclesiaCRM/APIControllers/SidebarGeneralRolesController.php:168 — src/EcclesiaCRM/APIControllers/SidebarGeneralRolesController.php:168-178 | src/EcclesiaCRM/APIControllers/SidebarGeneralRolesController.php:183-193 | src/EcclesiaCRM/APIControllers/SidebarGeneralRolesController.php:198-208 | src/EcclesiaCRM/APIControllers/SidebarGeneralRolesController.php:210-216 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/SidebarGeneralRolesController.php:168` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/EcclesiaCRM/APIControllers/SidebarGeneralRolesController.php:182` calls `count`, `withJson` and `src/EcclesiaCRM/APIControllers/SidebarGeneralRolesController.php:210` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (11–13 lines × 2) · ×1
  • Duplicated block (11–13 lines × 2) src/EcclesiaCRM/APIControllers/DocumentDocumentController.php:42 — src/EcclesiaCRM/APIControllers/DocumentDocumentController.php:42-52 | src/EcclesiaCRM/APIControllers/DocumentDocumentController.php:135-147 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/EcclesiaCRM/APIControllers/DocumentDocumentController.php:149` calls `withJson`, `toArray` and `src/EcclesiaCRM/APIControllers/DocumentDocumentController.php:54` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (9–11 lines × 2) · ×1
  • Duplicated block (9–11 lines × 2) src/EcclesiaCRM/Search/PersonAssignToGroupSearchRes.php:78 — src/EcclesiaCRM/Search/PersonAssignToGroupSearchRes.php:78-88 | src/EcclesiaCRM/Search/PersonPastoralCareSearchRes.php:79-87 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Search/PersonAssignToGroupSearchRes.php:78` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (8–10 lines × 6) · ×1
  • Duplicated block (8–10 lines × 6) src/EcclesiaCRM/APIControllers/PluginsController.php:223 — src/EcclesiaCRM/APIControllers/PluginsController.php:223-232 | src/EcclesiaCRM/APIControllers/PluginsController.php:234-243 | src/EcclesiaCRM/APIControllers/PluginsController.php:244-251 | src/EcclesiaCRM/Service/UpgradeService.php:50-59 | src/EcclesiaCRM/Service/UpgradeService.php:61-70 | src/EcclesiaCRM/Service/UpgradeService.php:71-78 — there are 6 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 6 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/PluginsController.php:223` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/EcclesiaCRM/APIControllers/PluginsController.php:223` calls `info` and `src/EcclesiaCRM/APIControllers/PluginsController.php:244` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (12 lines × 4) · ×1
  • Duplicated block (12 lines × 4) src/EcclesiaCRM/MenuBar/MenuBar.php:310 — src/EcclesiaCRM/MenuBar/MenuBar.php:310-321 | src/EcclesiaCRM/MenuBar/MenuBar.php:421-432 | src/EcclesiaCRM/MenuBar/MenuBar.php:486-497 | src/EcclesiaCRM/MenuBar/MenuBar.php:564-575 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/MenuBar/MenuBar.php:310` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/EcclesiaCRM/MenuBar/MenuBar.php:324` calls `getUser`, `isManageGroupsEnabled` and `src/EcclesiaCRM/MenuBar/MenuBar.php:578` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (9–10 lines × 4) · ×1
  • Duplicated block (9–10 lines × 4) src/EcclesiaCRM/MenuBar/MenuBar.php:408 — src/EcclesiaCRM/MenuBar/MenuBar.php:408-417 | src/EcclesiaCRM/MenuBar/MenuBar.php:474-482 | src/EcclesiaCRM/MenuBar/MenuBar.php:642-651 | src/EcclesiaCRM/MenuBar/MenuBar.php:706-714 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/MenuBar/MenuBar.php:408` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9–10 lines × 3) · ×1
  • Duplicated block (9–10 lines × 3) src/EcclesiaCRM/Search/AddressSearchRes.php:137 — src/EcclesiaCRM/Search/AddressSearchRes.php:137-145 | src/EcclesiaCRM/Search/FamilyPropsSearchRes.php:104-113 | src/EcclesiaCRM/Search/FamilySearchRes.php:169-177 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (9–10 lines × 2) · ×1
  • Duplicated block (9–10 lines × 2) src/EcclesiaCRM/Service/CalendarService.php:1661 — src/EcclesiaCRM/Service/CalendarService.php:1661-1669 | src/EcclesiaCRM/Service/CalendarService.php:2038-2047 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Service/CalendarService.php:1661` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/EcclesiaCRM/Service/CalendarService.php:2052` calls `unset` and `src/EcclesiaCRM/Service/CalendarService.php:1673` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (9 lines × 8) · ×1
  • Duplicated block (9 lines × 8) src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:151 — src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:151-159 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeetingQuery.php:133-141 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeetingQuery.php:127-135 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeetingQuery.php:139-147 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboardQuery.php:151-159 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboardQuery.php:127-135 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItemQuery.php:145-153 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardQuery.php:133-141 — before extracting anything, compare `src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php` and `src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeetingQuery.php` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 57 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (7–9 lines × 8) · ×1
  • Duplicated block (7–9 lines × 8) src/EcclesiaCRM/dto/MenuEventsCount.php:113 — src/EcclesiaCRM/dto/MenuEventsCount.php:113-119 | src/EcclesiaCRM/dto/MenuEventsCount.php:120-128 | src/EcclesiaCRM/dto/MenuEventsCount.php:130-138 | src/EcclesiaCRM/dto/MenuEventsCount.php:140-148 | src/EcclesiaCRM/dto/MenuEventsCount.php:150-158 | src/EcclesiaCRM/dto/MenuEventsCount.php:160-168 | src/EcclesiaCRM/dto/MenuEventsCount.php:170-178 | src/EcclesiaCRM/dto/MenuEventsCount.php:180-188 — all 8 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/dto/MenuEventsCount.php:113` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/EcclesiaCRM/dto/MenuEventsCount.php:128` calls `format` and `src/EcclesiaCRM/dto/MenuEventsCount.php:119` does not — after which the two agree again for 5 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (9 lines × 4) · ×1
  • Duplicated block (9 lines × 4) src/EcclesiaCRM/APIControllers/PastoralCareController.php:68 — src/EcclesiaCRM/APIControllers/PastoralCareController.php:68-76 | src/EcclesiaCRM/APIControllers/PastoralCareController.php:455-463 | src/EcclesiaCRM/Service/PastoralCareService.php:62-70 | src/EcclesiaCRM/VIEWControllers/VIEWPastoralCareController.php:108-116 — there are 4 copies across 3 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (13–17 lines × 3) · ×1
  • Duplicated block (13–17 lines × 3) src/EcclesiaCRM/Service/ConfirmReportService.php:100 — src/EcclesiaCRM/Service/ConfirmReportService.php:100-116 | src/EcclesiaCRM/Service/ConfirmReportService.php:341-353 | src/EcclesiaCRM/Service/ConfirmReportService.php:522-538 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (4–9 lines × 3) · ×1
  • Duplicated block (4–9 lines × 3) src/Reports/CanvassReports.php:79 — src/Reports/CanvassReports.php:79-82 | src/Reports/CanvassReports.php:381-389 | src/Reports/CanvassReports.php:455-463 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Reports/CanvassReports.php:79` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Reports/CanvassReports.php:381` calls `WriteAt`, `getValue` and `src/Reports/CanvassReports.php:79` does not — after which the two agree again for 5 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (8 lines × 5) · ×1
  • Duplicated block (8 lines × 5) REDACTED:1494 — REDACTED:1494-1501 | src/EcclesiaCRM/VIEWControllers/Session/VIEWSessionController.php:53-61 | src/EcclesiaCRM/VIEWControllers/VIEWFundraiserController.php:219-226 | src/EcclesiaCRM/VIEWControllers/VIEWFundraiserController.php:272-279 | src/EcclesiaCRM/VIEWControllers/VIEWSystemController.php:243-250 — there are 5 copies across 4 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 5 sites; resolving a subset leaves the remainder to drift apart.
D4 · Code Duplication · Duplicated block (8 lines × 4) · ×1
  • Duplicated block (8 lines × 4) src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:440 — src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:440-447 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:458-465 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:614-621 | src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:662-669 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Plugins/MailChimp/core/APIControllers/MailchimpController.php:440` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (7–8 lines × 2) · ×1
  • Duplicated block (7–8 lines × 2) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:613 — src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:613-619 | src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:651-658 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:613` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (7 lines × 6) · ×1
  • Duplicated block (7 lines × 6) REDACTED:70 — REDACTED:70-76 | src/EcclesiaCRM/APIControllers/PeopleGroupController.php:117-123 | REDACTED:329-335 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:389-395 | src/EcclesiaCRM/APIControllers/SidebarPropertiesController.php:427-433 | REDACTED:417-423 — there are 6 copies across 5 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 6 sites; resolving a subset leaves the remainder to drift apart. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `REDACTED:78` calls `addAsColumn` and `src/EcclesiaCRM/APIControllers/PeopleGroupController.php:125` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (3–7 lines × 3) · ×1
  • Duplicated block (3–7 lines × 3) src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:589 — src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:589-594 | src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:743-749 | src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:759-761 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:589` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (3–7 lines × 15) · ×1
  • Duplicated block (3–7 lines × 15) REDACTED:473 — REDACTED:473-479 | REDACTED:482-484 | REDACTED:487-489 | REDACTED:492-494 | REDACTED:497-499 | REDACTED:502-504 | REDACTED:519-521 | REDACTED:525-527 | REDACTED:644-650 | REDACTED:654-656 | REDACTED:659-661 | REDACTED:664-666 | REDACTED:669-671 | REDACTED:674-676 | REDACTED:684-686 — all 15 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:473` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `REDACTED:682` calls `getFmrId` and `REDACTED:501` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (6 lines × 7) · ×1
  • Duplicated block (6 lines × 7) src/EcclesiaCRM/MenuBar/MenuBar.php:306 — src/EcclesiaCRM/MenuBar/MenuBar.php:306-311 | src/EcclesiaCRM/MenuBar/MenuBar.php:417-422 | src/EcclesiaCRM/MenuBar/MenuBar.php:482-487 | src/EcclesiaCRM/MenuBar/MenuBar.php:560-565 | src/EcclesiaCRM/MenuBar/MenuBar.php:591-596 | src/EcclesiaCRM/MenuBar/MenuBar.php:651-656 | src/EcclesiaCRM/MenuBar/MenuBar.php:714-719 — all 7 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/EcclesiaCRM/MenuBar/MenuBar.php:312` calls `addLink`, `getID` and `src/EcclesiaCRM/MenuBar/MenuBar.php:657` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (6 lines × 5) · ×1
  • Duplicated block (6 lines × 5) src/EcclesiaCRM/Search/PersonAssignToGroupSearchRes.php:106 — src/EcclesiaCRM/Search/PersonAssignToGroupSearchRes.php:106-111 | src/EcclesiaCRM/Search/PersonCustomSearchRes.php:122-127 | src/EcclesiaCRM/Search/PersonGroupManagerSearchRes.php:113-118 | src/EcclesiaCRM/Search/PersonPastoralCareSearchRes.php:96-101 | src/EcclesiaCRM/Search/PersonPropsSearchRes.php:105-110 — before extracting anything, compare `src/EcclesiaCRM/Search/PersonGroupManagerSearchRes.php` and `src/EcclesiaCRM/Search/PersonPropsSearchRes.php` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 81 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/EcclesiaCRM/Search/PersonAssignToGroupSearchRes.php:104` calls `isset` and `src/EcclesiaCRM/Search/PersonCustomSearchRes.php:120` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (5–6 lines × 4) · ×1
  • Duplicated block (5–6 lines × 4) src/EcclesiaCRM/Reports/PDF_Badge.php:195 — src/EcclesiaCRM/Reports/PDF_Badge.php:195-199 | src/EcclesiaCRM/Reports/PDF_Badge.php:221-226 | src/EcclesiaCRM/Reports/PDF_Badge.php:353-357 | src/EcclesiaCRM/Reports/PDF_Badge.php:379-384 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Reports/PDF_Badge.php:221` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (5 lines × 4) · ×1
  • Duplicated block (5 lines × 4) src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:613 — src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:613-617 | src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:651-655 | src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:792-797 | src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:956-960 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php:613` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (35 lines × 2) · ×1
  • Duplicated block (35 lines × 2) src/EcclesiaCRM/Emails/users/CalendarEmail.php:17 — src/EcclesiaCRM/Emails/users/CalendarEmail.php:17-51 | src/EcclesiaCRM/Emails/users/DocumentEmail.php:17-51 — before extracting anything, compare `src/EcclesiaCRM/Emails/users/CalendarEmail.php` and `src/EcclesiaCRM/Emails/users/DocumentEmail.php` as WHOLE FILES: 87% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/EcclesiaCRM/Emails/users/CalendarEmail.php:17` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (9 lines × 5) · ×1
  • Duplicated block (9 lines × 5) src/EcclesiaCRM/VIEWControllers/Sidebar/VIEWFundListController.php:44 — src/EcclesiaCRM/VIEWControllers/Sidebar/VIEWFundListController.php:44-53 | src/EcclesiaCRM/VIEWControllers/Sidebar/VIEWKioskManagerController.php:45-53 | src/EcclesiaCRM/VIEWControllers/Sidebar/VIEWPastoralcareListController.php:45-54 | src/EcclesiaCRM/VIEWControllers/Sidebar/VIEWPropertyTypeListController.php:44-54 | src/EcclesiaCRM/VIEWControllers/VIEWVolunteerOpportunityController.php:47-56 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 5 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 5 times.
D4 · Code Duplication · Duplicated block (12 lines × 6) · ×1
  • Duplicated block (12 lines × 6) src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:196 — src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:196-207 | src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:296-307 | src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:343-359 | src/EcclesiaCRM/VIEWControllers/VIEWDepositController.php:377-388 | src/EcclesiaCRM/VIEWControllers/VIEWQueryController.php:100-114 | src/EcclesiaCRM/VIEWControllers/VIEWQueryController.php:132-144 — there are 6 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 6 sites; resolving a subset leaves the remainder to drift apart.
D4 · Code Duplication · Duplicated block (13 lines × 8) · ×1
  • Duplicated block (13 lines × 8) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:244 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:244-256 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:219-231 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:196-208 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:228-240 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:244-256 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:210-222 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:221-233 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:239-251 — before extracting anything, compare `src/Plugins/MailChimp/core/model/Base/MailChimpParams.php` and `src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 159 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (7 lines × 8) · ×1
  • Duplicated block (7 lines × 8) src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:1188 — src/Plugins/MailChimp/core/model/Base/MailChimpParams.php:1188-1194 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php:1002-1008 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeeting.php:906-912 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeeting.php:1050-1056 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboard.php:1204-1210 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboard.php:924-930 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboard.php:1011-1017 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItem.php:1152-1158 — before extracting anything, compare `src/Plugins/MailChimp/core/model/Base/MailChimpParams.php` and `src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeeting.php` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 159 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
D4 · Code Duplication · Duplicated block (6 lines × 8) · ×1
  • Duplicated block (6 lines × 8) src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:214 — src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:214-219 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeetingQuery.php:196-201 | src/Plugins/MeetingJitsi/core/model/Base/PersonLastJitsiMeetingQuery.php:190-195 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeetingQuery.php:202-207 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboardQuery.php:214-219 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboardQuery.php:190-195 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItemQuery.php:208-213 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardQuery.php:196-201 — before extracting anything, compare `src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php` and `src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeetingQuery.php` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 57 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (9 lines × 14) · ×1
  • Duplicated block (9 lines × 14) src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:336 — src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:336-344 | src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:436-444 | src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:464-472 | src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php:492-500 | src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeetingQuery.php:361-369 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeetingQuery.php:367-375 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeetingQuery.php:395-403 | src/Plugins/MeetingJitsi/core/model/Base/PluginPrefJitsiMeetingQuery.php:423-431 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboardQuery.php:379-387 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboardQuery.php:407-415 | src/Plugins/NewsDashboard/core/model/Base/NewsDashboardQuery.php:435-443 | src/Plugins/NoteDashboard/core/model/Base/NoteDashboardQuery.php:355-363 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardItemQuery.php:402-410 | src/Plugins/ToDoListDashboard/core/model/Base/ToDoListDashboardQuery.php:318-326 — before extracting anything, compare `src/Plugins/MailChimp/core/model/Base/MailChimpParamsQuery.php` and `src/Plugins/MeetingJitsi/core/model/Base/PersonJitsiMeetingQuery.php` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 57 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
P1 · CI/CD gates · CI pipeline targets a decommissioned service · ×1
  • CI pipeline targets a decommissioned service — The pipeline is well-formed, but the only CI definition is `.travis.yml`, and `.travis.yml` still points at `travis-ci.org` — a service shut down in June 2021. No other CI is configured in this repository, so nothing has been building or testing changes here since that shutdown — the steps below describe a gate that is not running. Porting it is mostly mechanical: the build and test commands already written here are what a replacement pipeline would run.
R1 · Type Safety · Type Safety · ×1
  • Type Safety — 0 typed · 681 plain JS — the untyped files are scripts/test-edrive-actions.js, src/Plugins/BirthdayAnniversaryDashboard/locale/js/ar_EG.js, src/Plugins/BirthdayAnniversaryDashboard/locale/js/da_DK.js, src/Plugins/BirthdayAnniversaryDashboard/locale/js/de_DE.js, src/Plugins/BirthdayAnniversaryDashboard/locale/js/el_GR.js, src/Plugins/BirthdayAnniversaryDashboard/locale/js/en_AU.js (+675 more).
R10 · Code Duplication · Duplication concentrated across 16 sibling directories (64 clone groups) · ×1
  • Duplication concentrated across 16 sibling directories (64 clone groups) REDACTED:332 — 64 duplicated blocks under src/skin/js/ have copies in at least two of the sibling directories Search, calendar, event, finance, gdpr, group (+10 more sibling(s) not listed) — 48 of them are reported below, and 16 are counted here but not reported individually: those copies match on shape but no longer clear R10's bar for an individually reported row — either they kept neither their own names nor their values, or what was copied is too small to stand on its own (it reports near-exact duplication only, and only of substantial extent). What this row states is the concentration, which the detector measured over all 64 and which does not depend on how exactly each block's copies still match. That concentration is one structural fact, not 64 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 64 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on.
R10 · Code Duplication · Duplication concentrated across 2 sibling directories (21 clone groups) · ×1
  • Duplication concentrated across 2 sibling directories (21 clone groups) src/Plugins/MailChimp/skin/js/DuplicateEmails.js:10 — 21 duplicated blocks under src/ have copies in at least two of the sibling directories Plugins, skin — 12 of them are reported below, and 9 are counted here but not reported individually: those copies match on shape but no longer clear R10's bar for an individually reported row — either they kept neither their own names nor their values, or what was copied is too small to stand on its own (it reports near-exact duplication only, and only of substantial extent). What this row states is the concentration, which the detector measured over all 21 and which does not depend on how exactly each block's copies still match. That concentration is one structural fact, not 21 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 21 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on.
R10 · Code Duplication · Duplicated block with local edits (321 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (321 matched lines × 2 locations) REDACTED:332 — REDACTED:332 · src/skin/js/volunteer/VolunteerOpportunityView.js:3 — the two spans are one implementation copied and then locally edited — 2298 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block with local edits (155 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (155 matched lines × 2 locations) src/skin/js/people/FamilyVerify.js:9 — src/skin/js/people/FamilyVerify.js:9 · src/skin/js/people/PersonVerify.js:9 — the two spans are one implementation copied and then locally edited — 1091 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Wholesale file copy (127 identical lines × 2 files) · ×1
  • Wholesale file copy (127 identical lines × 2 files) src/skin/js/pastoralcare/PastoralCareFamily.js:9 — src/skin/js/pastoralcare/PastoralCareFamily.js:9 · src/skin/js/pastoralcare/PastoralCarePerson.js:9 — these 2 files are line-for-line copies of one another — 127 lines are identical, in the same order, in every one of them — so this is one fact about the file set, not a block to extract. An edit made to one file and not the others changes behaviour silently, which is the failure a wholesale copy guarantees. Pick one file as the single source and derive the others from it (re-export it, spread it into the local overrides each variant genuinely needs, or generate the copies at build time) — the few lines that differ between the files are exactly the part each variant should still own. Check first whether the copies are deliberately standalone deliverables (a translation file seeded from its sibling and waiting to be translated); where they are, the duplication is the design, and the honest move is to mark the seeded file as untranslated rather than to let it pass as done.
R10 · Code Duplication · Duplicated block (91 lines × 2 locations) · ×1
  • Duplicated block (91 lines × 2 locations) src/skin/js/people/FamilyView.js:604 — src/skin/js/people/FamilyView.js:604 · src/skin/js/people/PersonView.js:1413 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block with local edits (89 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (89 matched lines × 2 locations) src/skin/js/calendar/CalendarSideBar.js:722 — src/skin/js/calendar/CalendarSideBar.js:722 · REDACTED:816 — the two spans are one implementation copied and then locally edited — 511 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block (63 lines × 2 locations) · ×1
  • Duplicated block (63 lines × 2 locations) src/skin/js/Search/Search.js:644 — src/skin/js/Search/Search.js:644 · src/skin/js/Search/Search.js:725 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
R10 · Code Duplication · Duplicated block with local edits (60 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (60 matched lines × 2 locations) src/skin/js/sidebar/PropertyList.js:103 — src/skin/js/sidebar/PropertyList.js:103 · src/skin/js/sidebar/PropertyTypeList.js:133 — the two spans are one implementation copied and then locally edited — 362 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block (58 lines × 2 locations) · ×1
  • Duplicated block (58 lines × 2 locations) src/skin/js/people/FamilyView.js:445 — src/skin/js/people/FamilyView.js:445 · src/skin/js/people/PersonView.js:1261 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block (53 lines × 2 locations) · ×1
  • Duplicated block (53 lines × 2 locations) src/skin/js/sidebar/FamilyCustomFieldsEditor.js:1 — src/skin/js/sidebar/FamilyCustomFieldsEditor.js:1 · src/skin/js/sidebar/PersonCustomFieldsEditor.js:1 — the 2 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it.
R10 · Code Duplication · Duplicated block with local edits (53 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (53 matched lines × 2 locations) REDACTED:954 — REDACTED:954 · src/skin/js/sundayschool/SundaySchoolDashboard.js:56 — the two spans are one implementation copied and then locally edited — 350 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block (52 lines × 2 locations) · ×1
  • Duplicated block (52 lines × 2 locations) src/skin/js/sidebar/FundList.js:148 — src/skin/js/sidebar/FundList.js:148 · src/skin/js/sidebar/PastoralCareList.js:140 — the 2 copies are spread across 2 files, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are.
R10 · Code Duplication · Duplicated block with local edits (47 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (47 matched lines × 2 locations) src/Plugins/ToDoListDashboard/skin/js/ToDoListDashboard.js:353 — src/Plugins/ToDoListDashboard/skin/js/ToDoListDashboard.js:353 · src/Plugins/ToDoListDashboard/skin/js/ToDoListDashboard.js:458 — the two spans are one implementation copied and then locally edited — 280 tokens are still identical, in the same order in both spans, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block (47 lines × 2 locations) · ×1
  • Duplicated block (47 lines × 2 locations) src/skin/js/people/FamilyView.js:722 — src/skin/js/people/FamilyView.js:722 · src/skin/js/people/PersonView.js:1608 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block (46 lines × 2 locations) · ×1
  • Duplicated block (46 lines × 2 locations) REDACTED:1950 — REDACTED:1950 · src/skin/js/system/SettingsIndividual.js:77 — the 2 copies are spread across 2 files, and what repeats is a LIST OF ENTRIES rather than behaviour — the same entries written out more than once. Extract them into one shared, exported constant and spread that constant into each site, rather than into a function the sites call: a list like this often lives in declarative metadata (a decorator's options object, a static configuration table) that a build step must be able to read statically, where a function call is not allowed. Adding an entry to one copy and not the other is the failure this prevents.
R10 · Code Duplication · Duplicated block with local edits (45 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (45 matched lines × 2 locations) src/skin/js/people/FamilyView.js:789 — src/skin/js/people/FamilyView.js:789 · src/skin/js/people/PersonView.js:1550 — the two spans are one implementation copied and then locally edited — 406 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block with local edits (44 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (44 matched lines × 2 locations) src/Plugins/MailChimp/skin/js/Dashboard.js:267 — src/Plugins/MailChimp/skin/js/Dashboard.js:267 · src/Plugins/MailChimp/skin/js/ManageList.js:1005 — the two spans are one implementation copied and then locally edited — 271 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block (42 lines × 2 locations) · ×1
  • Duplicated block (42 lines × 2 locations) src/skin/js/people/FamilyList.js:22 — src/skin/js/people/FamilyList.js:22 · src/skin/js/people/PersonList.js:22 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block (41 lines × 2 locations) · ×1
  • Duplicated block (41 lines × 2 locations) src/skin/js/filemanager.js:990 — src/skin/js/filemanager.js:990 · src/skin/js/filemanager.js:1057 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
R10 · Code Duplication · Duplicated block with local edits (41 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (41 matched lines × 2 locations) src/skin/js/pastoralcare/PastoralCareDashboard.js:96 — src/skin/js/pastoralcare/PastoralCareDashboard.js:96 · src/skin/js/pastoralcare/PastoralCareMembersList.js:14 — the two spans are one implementation copied and then locally edited — 288 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block with local edits (40 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (40 matched lines × 2 locations) src/skin/js/calendar/CalendarSideBar.js:463 — src/skin/js/calendar/CalendarSideBar.js:463 · src/skin/js/calendar/CalendarSideBar.js:626 — the two spans are one implementation copied and then locally edited — 285 tokens are still identical, in the same order in both spans, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block (36 lines × 4 locations) · ×1
  • Duplicated block (36 lines × 4 locations) src/skin/js/calendar/CalendarSideBar.js:1137 — src/skin/js/calendar/CalendarSideBar.js:1137 · src/skin/js/calendar/CalendarSideBar.js:1174 · src/skin/js/calendar/CalendarSideBar.js:1211 · src/skin/js/calendar/CalendarSideBar.js:1248 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
R10 · Code Duplication · Duplicated block (36 lines × 2 locations) · ×1
  • Duplicated block (36 lines × 2 locations) src/skin/js/people/online-pending-verify.js:1 — src/skin/js/people/online-pending-verify.js:1 · src/skin/js/people/self-verify-updates.js:1 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block (33 lines × 2 locations) · ×1
  • Duplicated block (33 lines × 2 locations) src/skin/js/sidebar/FundList.js:1 — src/skin/js/sidebar/FundList.js:1 · src/skin/js/sidebar/FundList.js:122 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block (31 lines × 2 locations) · ×1
  • Duplicated block (31 lines × 2 locations) REDACTED:689 — REDACTED:689 · REDACTED:720 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
R10 · Code Duplication · Duplicated block with local edits (30 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (30 matched lines × 2 locations) src/Plugins/MailChimp/skin/js/ManageList.js:526 — src/Plugins/MailChimp/skin/js/ManageList.js:526 · src/Plugins/MailChimp/skin/js/ManageList.js:1021 — the two spans are one implementation copied and then locally edited — 247 tokens are still identical, in the same order in both spans, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block (30 lines × 2 locations) · ×1
  • Duplicated block (30 lines × 2 locations) src/Plugins/PersonInfosDashboard/skin/js/synchronize/PersonDashboardItemPlugin.js:2 — src/Plugins/PersonInfosDashboard/skin/js/synchronize/PersonDashboardItemPlugin.js:2 · src/Plugins/PersonInfosDashboard/skin/js/synchronize/PersonDashboardItemPlugin.js:45 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block (29 lines × 4 locations) · ×1
  • Duplicated block (29 lines × 4 locations) src/skin/js/calendar/CalendarSideBar.js:49 — src/skin/js/calendar/CalendarSideBar.js:49 · src/skin/js/calendar/CalendarSideBar.js:140 · src/skin/js/calendar/CalendarSideBar.js:225 · src/skin/js/calendar/CalendarSideBar.js:302 — all 4 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block (29 lines × 2 locations) · ×1
  • Duplicated block (29 lines × 2 locations) REDACTED:227 — REDACTED:227 · src/skin/js/volunteer/VolunteerOpportunityView.js:495 — the 2 copies are spread across 2 files, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are.
R10 · Code Duplication · Duplicated block (28 lines × 6 locations) · ×1
  • Duplicated block (28 lines × 6 locations) src/skin/js/pastoralcare/PastoralCareDashboard.js:257 — src/skin/js/pastoralcare/PastoralCareDashboard.js:257 · src/skin/js/pastoralcare/PastoralCareDashboard.js:304 · src/skin/js/pastoralcare/PastoralCareDashboard.js:359 · src/skin/js/pastoralcare/PastoralCareDashboard.js:414 · +2 more site(s) not listed — the 6 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block (27 lines × 2 locations) · ×1
  • Duplicated block (27 lines × 2 locations) REDACTED:1137 — REDACTED:1137 · REDACTED:1237 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block with local edits (26 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (26 matched lines × 2 locations) src/skin/js/ckeditor/ckeditorextension.js:215 — src/skin/js/ckeditor/ckeditorextension.js:215 · src/skin/js/ckeditor/ckeditorextension.js:318 — the two spans are one implementation copied and then locally edited — 189 tokens are still identical, in the same order in both spans, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block with local edits (25 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (25 matched lines × 2 locations) src/skin/js/event/Checkin.js:20 — src/skin/js/event/Checkin.js:20 · src/skin/js/event/EventNames.js:13 — the two spans are one implementation copied and then locally edited — 172 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block (25 lines × 2 locations) · ×1
  • Duplicated block (25 lines × 2 locations) src/skin/js/plugins/Plugins.js:3 — src/skin/js/plugins/Plugins.js:3 · src/skin/js/user/UserList.js:3 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
R10 · Code Duplication · Duplicated block (24 lines × 5 locations) · ×1
  • Duplicated block (24 lines × 5 locations) src/skin/js/event/EditEventAttendees.js:76 — src/skin/js/event/EditEventAttendees.js:76 · REDACTED:231 · REDACTED:182 · REDACTED:226 · +1 more site(s) not listed — the 5 copies are spread across 4 files, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are.
R2 · Cyclomatic Complexity · Complex function eventDidMount (cyclomatic 36, cognitive 31) · ×1
  • Complex function eventDidMount (cyclomatic 36, cognitive 31) src/skin/js/calendar/CalendarV2.js:368 — eventDidMount has cyclomatic complexity 36 and cognitive complexity 31; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function (anonymous) (cyclomatic 30, cognitive 29) · ×1
  • Complex function (anonymous) (cyclomatic 30, cognitive 29) src/skin/js/filemanager.js:769 — (anonymous) has cyclomatic complexity 30 and cognitive complexity 29; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function buildAddress (cyclomatic 29, cognitive 9) · ×1
  • Complex function buildAddress (cyclomatic 29, cognitive 9) src/skin/js/pastoralcare/PastoralCareMembersList.js:58 — buildAddress has cyclomatic complexity 29 and cognitive complexity 9; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function callback (cyclomatic 26, cognitive 28) · ×1
  • Complex function callback (cyclomatic 26, cognitive 28) src/skin/js/ckeditor/ckeditorextension.js:1202 — callback has cyclomatic complexity 26 and cognitive complexity 28; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function reloadLabel (cyclomatic 23, cognitive 16) · ×1
  • Complex function reloadLabel (cyclomatic 23, cognitive 16) src/skin/js/BadgeSticker.js:12 — reloadLabel has cyclomatic complexity 23 and cognitive complexity 16; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function buildAddress (cyclomatic 17, cognitive 9) · ×1
  • Complex function buildAddress (cyclomatic 17, cognitive 9) src/skin/js/pastoralcare/PastoralCareDashboard.js:141 — buildAddress has cyclomatic complexity 17 and cognitive complexity 9; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function render (cyclomatic 16, cognitive 20) · ×1
  • Complex function render (cyclomatic 16, cognitive 20) src/skin/js/filemanager.js:283 — render has cyclomatic complexity 16 and cognitive complexity 20; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function (anonymous) (cyclomatic 15, cognitive 30) · ×1
  • Complex function (anonymous) (cyclomatic 15, cognitive 30) src/Plugins/MailChimp/skin/js/ManageList.js:58 — (anonymous) has cyclomatic complexity 15 and cognitive complexity 30; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function renderRestoreProgress (cyclomatic 15, cognitive 14) · ×1
  • Complex function renderRestoreProgress (cyclomatic 15, cognitive 14) src/skin/js/backup/restore.js:35 — renderRestoreProgress has cyclomatic complexity 15 and cognitive complexity 14; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function render (cyclomatic 15, cognitive 11) · ×1
  • Complex function render (cyclomatic 15, cognitive 11) src/skin/js/Search/Search.js:531 — render has cyclomatic complexity 15 and cognitive complexity 11; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function (anonymous) (cyclomatic 14, cognitive 32) · ×1
  • Complex function (anonymous) (cyclomatic 14, cognitive 32) src/Plugins/MailChimp/skin/js/Dashboard.js:27 — (anonymous) has cyclomatic complexity 14 and cognitive complexity 32; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function buildToolbar (cyclomatic 14, cognitive 17) · ×1
  • Complex function buildToolbar (cyclomatic 14, cognitive 17) src/skin/js/ckeditor/ckeditorextension.js:159 — buildToolbar has cyclomatic complexity 14 and cognitive complexity 17; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function (anonymous) (cyclomatic 14, cognitive 16) · ×1
  • Complex function (anonymous) (cyclomatic 14, cognitive 16) src/skin/js/fundraiser/batchWinnerEntry.js:36 — (anonymous) has cyclomatic complexity 14 and cognitive complexity 16; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function promptActivationToggle (cyclomatic 14, cognitive 12) · ×1
  • Complex function promptActivationToggle (cyclomatic 14, cognitive 12) src/Plugins/BirthdayAnniversaryDashboard/skin/js/BirthdayAnniversaryDashboard.js:118 — promptActivationToggle has cyclomatic complexity 14 and cognitive complexity 12; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function (anonymous) (cyclomatic 13, cognitive 14) · ×1
  • Complex function (anonymous) (cyclomatic 13, cognitive 14) REDACTED:22 — (anonymous) has cyclomatic complexity 13 and cognitive complexity 14; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function receiveFile (cyclomatic 13, cognitive 10) · ×1
  • Complex function receiveFile (cyclomatic 13, cognitive 10) src/skin/js/ckeditor/ckeditorextension.js:1063 — receiveFile has cyclomatic complexity 13 and cognitive complexity 10; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function (anonymous) (cyclomatic 12, cognitive 20) · ×1
  • Complex function (anonymous) (cyclomatic 12, cognitive 20) REDACTED:2153 — (anonymous) has cyclomatic complexity 12 and cognitive complexity 20; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function (anonymous) (cyclomatic 12, cognitive 12) · ×1
  • Complex function (anonymous) (cyclomatic 12, cognitive 12) src/skin/js/system/setup.js:500 — (anonymous) has cyclomatic complexity 12 and cognitive complexity 12; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function (anonymous) (cyclomatic 12, cognitive 11) · ×1
  • Complex function (anonymous) (cyclomatic 12, cognitive 11) src/skin/js/calendar/CalendarSideBar.js:888 — (anonymous) has cyclomatic complexity 12 and cognitive complexity 11; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function SundaySchoolDisplay (cyclomatic 11, cognitive 10) · ×1
  • Complex function SundaySchoolDisplay (cyclomatic 11, cognitive 10) REDACTED:1741 — SundaySchoolDisplay has cyclomatic complexity 11 and cognitive complexity 10; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function createEditor (cyclomatic 11, cognitive 10) · ×1
  • Complex function createEditor (cyclomatic 11, cognitive 10) src/skin/js/ckeditor/ckeditorextension.js:1284 — createEditor has cyclomatic complexity 11 and cognitive complexity 10; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function (anonymous) (cyclomatic 11, cognitive 10) · ×1
  • Complex function (anonymous) (cyclomatic 11, cognitive 10) src/skin/js/people/PersonView.js:1549 — (anonymous) has cyclomatic complexity 11 and cognitive complexity 10; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R3 · Large Files · REDACTED · ×1
  • REDACTED: 2075 lines of code REDACTED:1 — REDACTED has 2075 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files · src/skin/js/filemanager.js · ×1
  • src/skin/js/filemanager.js: 1530 lines of code src/skin/js/filemanager.js:1 — src/skin/js/filemanager.js has 1530 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files · src/skin/js/people/PersonView.js · ×1
  • src/skin/js/people/PersonView.js: 1514 lines of code src/skin/js/people/PersonView.js:1 — src/skin/js/people/PersonView.js has 1514 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files · src/skin/js/ckeditor/ckeditorextension.js · ×1
  • src/skin/js/ckeditor/ckeditorextension.js: 1373 lines of code src/skin/js/ckeditor/ckeditorextension.js:1 — src/skin/js/ckeditor/ckeditorextension.js has 1373 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files · src/skin/js/calendar/CalendarSideBar.js · ×1
  • src/skin/js/calendar/CalendarSideBar.js: 1133 lines of code src/skin/js/calendar/CalendarSideBar.js:1 — src/skin/js/calendar/CalendarSideBar.js has 1133 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files · REDACTED · ×1
  • REDACTED: 1131 lines of code REDACTED:1 — REDACTED has 1131 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files · src/Plugins/MailChimp/skin/js/ManageList.js · ×1
  • src/Plugins/MailChimp/skin/js/ManageList.js: 1110 lines of code src/Plugins/MailChimp/skin/js/ManageList.js:1 — src/Plugins/MailChimp/skin/js/ManageList.js has 1110 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files · REDACTED · ×1
  • REDACTED: 877 lines of code REDACTED:1 — REDACTED has 877 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files · src/skin/js/calendar/EventEditor.js · ×1
  • src/skin/js/calendar/EventEditor.js: 865 lines of code src/skin/js/calendar/EventEditor.js:1 — src/skin/js/calendar/EventEditor.js has 865 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files · src/skin/js/people/FamilyView.js · ×1
  • src/skin/js/people/FamilyView.js: 783 lines of code src/skin/js/people/FamilyView.js:1 — src/skin/js/people/FamilyView.js has 783 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files · src/skin/js/calendar/CalendarV2.js · ×1
  • src/skin/js/calendar/CalendarV2.js: 752 lines of code src/skin/js/calendar/CalendarV2.js:1 — src/skin/js/calendar/CalendarV2.js has 752 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files · src/skin/js/Search/Search.js · ×1
  • src/skin/js/Search/Search.js: 738 lines of code src/skin/js/Search/Search.js:1 — src/skin/js/Search/Search.js has 738 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files · src/skin/js/pastoralcare/PastoralCareDashboard.js · ×1
  • src/skin/js/pastoralcare/PastoralCareDashboard.js: 521 lines of code src/skin/js/pastoralcare/PastoralCareDashboard.js:1 — src/skin/js/pastoralcare/PastoralCareDashboard.js has 521 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files · src/skin/js/calendar/EventsList.js · ×1
  • src/skin/js/calendar/EventsList.js: 500 lines of code src/skin/js/calendar/EventsList.js:1 — src/skin/js/calendar/EventsList.js has 500 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files · src/skin/js/volunteer/VolunteerOpportunityView.js · ×1
  • src/skin/js/volunteer/VolunteerOpportunityView.js: 488 lines of code src/skin/js/volunteer/VolunteerOpportunityView.js:1 — src/skin/js/volunteer/VolunteerOpportunityView.js has 488 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files · src/Plugins/ToDoListDashboard/skin/js/ToDoListDashboard.js · ×1
  • src/Plugins/ToDoListDashboard/skin/js/ToDoListDashboard.js: 482 lines of code src/Plugins/ToDoListDashboard/skin/js/ToDoListDashboard.js:1 — src/Plugins/ToDoListDashboard/skin/js/ToDoListDashboard.js has 482 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files · src/skin/js/system/setup.js · ×1
  • src/skin/js/system/setup.js: 460 lines of code src/skin/js/system/setup.js:1 — src/skin/js/system/setup.js has 460 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files · src/skin/js/event/Checkin.js · ×1
  • src/skin/js/event/Checkin.js: 455 lines of code src/skin/js/event/Checkin.js:1 — src/skin/js/event/Checkin.js has 455 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files · src/skin/js/system/KioskJSOM.js · ×1
  • src/skin/js/system/KioskJSOM.js: 441 lines of code src/skin/js/system/KioskJSOM.js:1 — src/skin/js/system/KioskJSOM.js has 441 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files · src/skin/js/finance/DepositSlipEditor.js · ×1
  • src/skin/js/finance/DepositSlipEditor.js: 417 lines of code src/skin/js/finance/DepositSlipEditor.js:1 — src/skin/js/finance/DepositSlipEditor.js has 417 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R4 · Test Coverage · Test Coverage · ×1
  • Test Coverage — 0% of 680 production file(s) reachable from 0 test file(s) via the import graph — 'production' here is the RESIDUE: every source file left once tests, tooling, generated output, config, declarations and declaration-only modules, fixture corpora, type fixtures, behaviour-free data modules, re-export barrels, registration/constant data modules and service workers are set aside, so the percentage is taken over a smaller denominator than the workspace's file count
R6 · Tooling · No lint or typecheck script · ×1
  • No lint or typecheck script — test ✓ · lint ✗ · typecheck ✗ — read from this repository's package.json scripts and corroborated against its CI workflows. A script counts when its name or command matches the step: `test` for the suite, `lint` or `prettier` for linting, `typecheck`/`type-check`/`tsc` for type checking. ✗ therefore means no script or CI step under those names was found, NOT that the step is absent from your pipeline — a task invoked by a runner this check does not read, or named something else entirely, is not seen and is worth confirming before acting on a cross. A ✓ means the wiring is DECLARED — a script or CI step under those names exists. It is not a statement that the step passes, or that it runs at all: nothing here installs a dependency or executes a suite.
R7 · Dead Code · Dead file (~2284 LoC) · ×1
  • Dead file (~2284 LoC) REDACTED — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~1743 LoC) · ×1
  • Dead file (~1743 LoC) src/skin/js/filemanager.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~1684 LoC) · ×1
  • Dead file (~1684 LoC) src/skin/js/people/PersonView.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~1478 LoC) · ×1
  • Dead file (~1478 LoC) src/skin/js/ckeditor/ckeditorextension.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~1310 LoC) · ×1
  • Dead file (~1310 LoC) REDACTED — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~1285 LoC) · ×1
  • Dead file (~1285 LoC) src/skin/js/calendar/CalendarSideBar.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~1251 LoC) · ×1
  • Dead file (~1251 LoC) src/Plugins/MailChimp/skin/js/ManageList.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~1059 LoC) · ×1
  • Dead file (~1059 LoC) src/skin/js/calendar/EventEditor.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~961 LoC) · ×1
  • Dead file (~961 LoC) REDACTED — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~867 LoC) · ×1
  • Dead file (~867 LoC) src/skin/js/Search/Search.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~855 LoC) · ×1
  • Dead file (~855 LoC) src/skin/js/people/FamilyView.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~837 LoC) · ×1
  • Dead file (~837 LoC) src/skin/js/calendar/CalendarV2.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~570 LoC) · ×1
  • Dead file (~570 LoC) src/skin/js/system/setup.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~567 LoC) · ×1
  • Dead file (~567 LoC) src/Plugins/ToDoListDashboard/skin/js/ToDoListDashboard.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~566 LoC) · ×1
  • Dead file (~566 LoC) src/skin/js/pastoralcare/PastoralCareDashboard.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~563 LoC) · ×1
  • Dead file (~563 LoC) src/skin/js/calendar/EventsList.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~533 LoC) · ×1
  • Dead file (~533 LoC) src/skin/js/volunteer/VolunteerOpportunityView.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~527 LoC) · ×1
  • Dead file (~527 LoC) src/skin/js/event/Checkin.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~490 LoC) · ×1
  • Dead file (~490 LoC) src/skin/js/system/KioskJSOM.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~475 LoC) · ×1
  • Dead file (~475 LoC) src/skin/js/finance/DepositSlipEditor.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~390 LoC) · ×1
  • Dead file (~390 LoC) src/skin/js/people/letterandlabels.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~377 LoC) · ×1
  • Dead file (~377 LoC) src/skin/js/plugins/Plugins.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~376 LoC) · ×1
  • Dead file (~376 LoC) src/skin/js/system/SettingsIndividual.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~371 LoC) · ×1
  • Dead file (~371 LoC) src/Plugins/MailChimp/skin/js/Dashboard.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~362 LoC) · ×1
  • Dead file (~362 LoC) src/skin/js/people/FamilyVerify.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~348 LoC) · ×1
  • Dead file (~348 LoC) src/skin/js/document.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~331 LoC) · ×1
  • Dead file (~331 LoC) src/Plugins/BirthdayAnniversaryDashboard/skin/js/BirthdayAnniversaryDashboard.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~327 LoC) · ×1
  • Dead file (~327 LoC) src/skin/js/user/UserEditor.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~304 LoC) · ×1
  • Dead file (~304 LoC) src/skin/js/user/UserList.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~303 LoC) · ×1
  • Dead file (~303 LoC) src/skin/js/sidebar/MenuLinksList.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~266 LoC) · ×1
  • Dead file (~266 LoC) src/Plugins/NewsDashboard/skin/js/NewsDashboard.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~247 LoC) · ×1
  • Dead file (~247 LoC) src/skin/js/sidebar/PropertyTypeList.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~244 LoC) · ×1
  • Dead file (~244 LoC) src/skin/js/sidebar/PropertyList.js — no import path from any entry point (1 application, 1 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R8 · Dependency Hygiene · Unused dependency 'bootstrap-show-password' · ×1
  • Unused dependency 'bootstrap-show-password' package.json:46 — Declared in the root package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
R8 · Dependency Hygiene · Unused dependency 'cryptiles' · ×1
  • Unused dependency 'cryptiles' package.json:51 — Declared in the root package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
R8 · Dependency Hygiene · Unused dependency 'datatables.net-autofill' · ×1
  • Unused dependency 'datatables.net-autofill' package.json:53 — Declared in the root package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
R8 · Dependency Hygiene · Unused dependency 'datatables.net-autofill-dt' · ×1
  • Unused dependency 'datatables.net-autofill-dt' package.json:54 — Declared in the root package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
R8 · Dependency Hygiene · Unused dependency 'grunt-confirm' · ×1
  • Unused dependency 'grunt-confirm' package.json:24 — Declared in the root package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
R8 · Dependency Hygiene · Unused dependency 'grunt-contrib-clean' · ×1
  • Unused dependency 'grunt-contrib-clean' package.json:25 — Declared in the root package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
R8 · Dependency Hygiene · Unused dependency 'grunt-contrib-compress' · ×1
  • Unused dependency 'grunt-contrib-compress' package.json:26 — Declared in the root package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
R8 · Dependency Hygiene · Unused dependency 'grunt-contrib-copy' · ×1
  • Unused dependency 'grunt-contrib-copy' package.json:27 — Declared in the root package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
R8 · Dependency Hygiene · Unused dependency 'grunt-curl' · ×1
  • Unused dependency 'grunt-curl' package.json:28 — Declared in the root package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
R8 · Dependency Hygiene · Unused dependency 'grunt-exec' · ×1
  • Unused dependency 'grunt-exec' package.json:29 — Declared in the root package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
R8 · Dependency Hygiene · Unused dependency 'grunt-git' · ×1
  • Unused dependency 'grunt-git' package.json:31 — Declared in the root package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
R8 · Dependency Hygiene · Unused dependency 'grunt-http' · ×1
  • Unused dependency 'grunt-http' package.json:32 — Declared in the root package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
R8 · Dependency Hygiene · Unused dependency 'grunt-lineending' · ×1
  • Unused dependency 'grunt-lineending' package.json:30 — Declared in the root package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
R8 · Dependency Hygiene · Unused dependency 'grunt-sass' · ×1
  • Unused dependency 'grunt-sass' package.json:33 — Declared in the root package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
R8 · Dependency Hygiene · Unused dependency 'i18n' · ×1
  • Unused dependency 'i18n' package.json:70 — Declared in the root package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
R8 · Dependency Hygiene · Unused dependency 'initial-js' · ×1
  • Unused dependency 'initial-js' package.json:74 — Declared in the root package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
R8 · Dependency Hygiene · Unused dependency 'is-my-json-valid' · ×1
  • Unused dependency 'is-my-json-valid' package.json:75 — Declared in the root package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
R8 · Dependency Hygiene · Unused dependency 'morris.js.so' · ×1
  • Unused dependency 'morris.js.so' package.json:82 — Declared in the root package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
R8 · Dependency Hygiene · Unused dependency 'package.json' · ×1
  • Unused dependency 'package.json' package.json:84 — Declared in the root package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
S1 · Web-Security Posture · Third-party script without Subresource Integrity · ×1
  • Third-party script without Subresource Integrity src/v2/templates/people/ConfirmReportCheck.php:209 — `https://unpkg.com/jsqr@1.4.0/dist/jsQR.js` is executed by this page with no Subresource Integrity. Whoever can answer that request — the CDN, anyone who compromises it, anyone on the network path — runs arbitrary script in this page's origin, with its session.
SC1 · Supply-chain hygiene · JavaScript dependencies are not locked · ×1
  • JavaScript dependencies are not locked package.json:22 — package.json declares dependencies that no committed lockfile resolves — there is no package-lock.json / yarn.lock / pnpm-lock.yaml / bun.lock beside it, and no locked workspace above it names it — so its installs aren't reproducible (SSDF PW.4.4). Commit its package manager's lockfile (or add it to the locked workspace) and install from it (`npm ci`, `yarn --immutable`, `pnpm i --frozen-lockfile` or `bun i --frozen-lockfile`). Advisory — never scored.
X2 · Cancellation propagation · Async function without AbortSignal · ×1
  • Async function without AbortSignal: VerifyThenLoadAPIContent REDACTED:385 — `VerifyThenLoadAPIContent` awaits `fetch(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `fetch(url, { signal })`.
X29 · Per-element action decided by a fixed element · Per-element action decided by a fixed element · ×1
  • Per-element action decided by a fixed element src/v2/templates/people/peopledashboard.php:361 — This loop runs once per element of `$personStats`, and the statement it guards acts on the element it is on — `$value`. The test deciding whether that statement runs does not: `$personStats['ClassificationCount'] > 0` reads `$personStats['ClassificationCount']`, a subscript that does not move, so whatever it answers for that one element it answers for ALL of them. One `if` names the same collection at two different subscripts, which is the contradiction: either the test was meant to be per-element, in which case every element that differs from the fixed one is handled wrongly and all in the same direction, or it really is one answer for the whole collection, in which case it is being re-asked on every pass and belongs above the loop. The `if` is in the wrong place under both readings. Give the test the loop variable, or hoist it out.
X3 · Exception handling · Swallowed exception (caught, then discarded) · ×1
  • Swallowed exception (caught, then discarded) src/skin/js/edrive/CollaboraEditor.js:53 — `catch (e)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, or keep only the failure you expect and rethrow the rest (`catch (e) { if (!(e instanceof SyntaxError)) throw e; … }`, or test `e.name`), because a JavaScript catch takes every exception, programming errors included.
Minor — 85 finding(s)
X10 · Duplicated predicate · Duplicated predicate · ×40
  • Duplicated predicate src/skin/js/pastoralcare/PastoralCareDashboard.js:143 — `explicit && String(explicit).trim() !== ''` appears character-identically in 2 files — src/skin/js/pastoralcare/PastoralCareDashboard.js, src/skin/js/pastoralcare/PastoralCareMembersList.js. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/skin/js/calendar/BingMapEvent.js:97 — `longitude !== undefined && latitude !== undefined && longitude > 0 && latitude > 0` appears character-identically in 3 files — src/skin/js/calendar/BingMapEvent.js, src/skin/js/calendar/GoogleMapEvent.js, src/skin/js/calendar/OpenStreetMapEvent.js. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate REDACTED:188 — `settings.cancelLabel || i18next.t('Cancel')` appears character-identically in 2 files — REDACTED, src/skin/js/people/PersonView.js. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate REDACTED:192 — `settings.confirmLabel || i18next.t('Confirm')` appears character-identically in 2 files — REDACTED, src/skin/js/people/PersonView.js. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate REDACTED:233 — `settings.confirmLabel || i18next.t('Save')` appears character-identically in 2 files — REDACTED, src/skin/js/people/PersonView.js. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate REDACTED:163 — `settings.title || i18next.t('Information')` appears character-identically in 2 files — REDACTED, src/skin/js/people/PersonView.js. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate REDACTED:184 — `settings.title || i18next.t('Please confirm')` appears character-identically in 2 files — REDACTED, src/skin/js/people/PersonView.js. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate REDACTED:211 — `settings.title || i18next.t('Update information')` appears character-identically in 2 files — REDACTED, src/skin/js/people/PersonView.js. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/v2/templates/pastoralcare/pastoralcarefamily.php:154 — `!$bHideLatLon && !SystemConfig::getBooleanValue('bHideLatLon')` appears character-identically in 2 files — src/v2/templates/pastoralcare/pastoralcarefamily.php, src/v2/templates/people/familyview.php. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php:530 — `!empty($latLng['Latitude']) && !empty($latLng['Longitude'])` appears character-identically in 4 files — src/EcclesiaCRM/APIControllers/CalendarEventV2Controller.php, src/EcclesiaCRM/Service/CalendarService.php, src/EcclesiaCRM/dto/ChurchMetaData.php, src/EcclesiaCRM/model/EcclesiaCRM/Person.php. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/EcclesiaCRM/sabre/CardDav/VCardUtils.php:38 — `!empty($person->getAddress1()) || !empty($person->getCity()) || !empty($person->getZip())` appears character-identically in 2 files — src/EcclesiaCRM/sabre/CardDav/VCardUtils.php, src/mysql/upgrade/5.3.0-upgrade.php. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/EcclesiaCRM/model/EcclesiaCRM/Family.php:149 — `!empty($this->getDateLastEdited()) and $this` appears character-identically in 2 files — src/EcclesiaCRM/model/EcclesiaCRM/Family.php, src/EcclesiaCRM/model/EcclesiaCRM/Person.php. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate REDACTED:1085 — `!is_null($aCustomData) && array_key_exists($customField['CustomField'], $aCustomData)` appears character-identically in 2 files — REDACTED, REDACTED. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate REDACTED:157 — `!is_null($braveCanvassers) && $braveCanvassers` appears character-identically in 3 files — REDACTED, REDACTED, REDACTED. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/EcclesiaCRM/Reports/CSV_RealAttendance.php:160 — `!is_null($eventAttendee) && !empty($eventAttendee->getCheckinDate())` appears character-identically in 2 files — src/EcclesiaCRM/Reports/CSV_RealAttendance.php, src/EcclesiaCRM/Reports/PDF_RealAttendance.php. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/EcclesiaCRM/APIControllers/PeopleGroupController.php:459 — `!is_null($fam) && !is_null($fam->getAddress1()) && !is_null($fam->getAddress2()) && !is_null($fam->getCity()) && !is_null($fam->getState()) …` appears character-identically in 2 files — src/EcclesiaCRM/APIControllers/PeopleGroupController.php, src/EcclesiaCRM/APIControllers/VolunteerOpportunityController.php. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/EcclesiaCRM/utils/OutputUtils.php:542 — `$Month > date('m') || ($Month == date('m') && $Day > date('d'))` appears character-identically in 2 files — src/EcclesiaCRM/utils/OutputUtils.php, REDACTED. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/EcclesiaCRM/Synchronize/GroupsDashboardItem.php:57 — `$PageName == "/v2/dashboard" || $PageName == "/v2/people/dashboard"` appears character-identically in 2 files — src/EcclesiaCRM/Synchronize/GroupsDashboardItem.php, src/EcclesiaCRM/Synchronize/VolunteersDashboardItem.php. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/Plugins/FamilyDashboardWidget/core/Synchronize/FamilyDashboardWidgetDashboardItemPlugin.php:24 — `$PageName === '/v2/dashboard' || $PageName === '/v2/people/dashboard'` appears character-identically in 3 files — src/Plugins/FamilyDashboardWidget/core/Synchronize/FamilyDashboardWidgetDashboardItemPlugin.php, src/Plugins/FamilyInfosDashboard/core/Synchronize/FamilyInfosDashboardItemPlugin.php, src/Plugins/PersonDashboardWidget/core/Synchronize/PersonDashboardWidgetDashboardItemPlugin.php. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/EcclesiaCRM/Synchronize/PersonDashboardItem.php:199 — `$PageName=="/v2/dashboard" or $PageName == "/v2/people/dashboard"` appears character-identically in 2 files — src/EcclesiaCRM/Synchronize/PersonDashboardItem.php, src/Plugins/PersonInfosDashboard/core/Synchronize/PersonDashboardItemPlugin.php. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/EcclesiaCRM/model/EcclesiaCRM/Group.php:54 — `$addressbook['id'] != 0 && !$carddavBackend` appears character-identically in 2 files — src/EcclesiaCRM/model/EcclesiaCRM/Group.php, src/EcclesiaCRM/model/EcclesiaCRM/VolunteerOpportunity.php. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/EcclesiaCRM/Reports/PDF_Directory.php:284 — `$bDirBirthday && $per_BirthMonth && $per_BirthDay` appears character-identically in 2 files — src/EcclesiaCRM/Reports/PDF_Directory.php, REDACTED. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/EcclesiaCRM/Reports/PDF_Directory.php:412 — `$bDirPersonalWorkEmail && strlen($per_WorkEmail)` appears character-identically in 2 files — src/EcclesiaCRM/Reports/PDF_Directory.php, REDACTED. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/EcclesiaCRM/Service/CalendarService.php:195 — `$calendar['present'] == 0 || $calendar['visible'] == 0` appears character-identically in 3 files — src/EcclesiaCRM/Service/CalendarService.php, src/EcclesiaCRM/VIEWControllers/VIEWMapController.php, src/EcclesiaCRM/dto/MenuEventsCount.php. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/EcclesiaCRM/APIControllers/CalendarV2Controller.php:206 — `$calendar['share-access'] == 1 || $calendar['share-access'] == 3` appears character-identically in 3 files — src/EcclesiaCRM/APIControllers/CalendarV2Controller.php, src/EcclesiaCRM/Service/CalendarService.php, src/EcclesiaCRM/sabre/CalDav/CalDavPDO.php. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • + 15 more in this group — see findings.md.
D24 · Comment Value · redundant comment · ×12
  • redundant comment REDACTED:2145 — "Call API to get real link" repeats the code it sits on: 5 of its 5 words (call, api, get, real, link) are already in `window.CRM.APIRequest({`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment REDACTED:2186 — "Call the callback with the file URL" repeats the code it sits on: 4 of its 4 words (call, callback, file, url) are already in `callback(fileUrl);`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment src/skin/js/calendar/BingMapEvent.js:114 — "Add marker and infowindow" repeats the code it sits on: 3 of its 3 words (add, marker, infowindow) are already in `marker = addMarkerWithInfowindow(window.CRM.map, centerCard, icon, Name, contentString);`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment src/skin/js/calendar/CalendarSideBar.js:466 — "to add PresenceShare" repeats the code it sits on: 3 of its 3 words (add, presence, share) are already in `const addShareCalendarPresence = (type) =>`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment src/skin/js/calendar/EventEditor.js:822 — "dialogType : createEvent or modifyEvent, eventID is when you modify and event" repeats the code it sits on: 5 of its 6 words (dialog, type, create, event, id) are already in `function createEventEditorWindow(start, end, dialogType, eventID, reccurenceID, page, windowtitle, title)`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment src/skin/js/calendar/GoogleMapEvent.js:62 — "Add marker and infowindow" repeats the code it sits on: 3 of its 3 words (add, marker, infowindow) are already in `marker = addMarkerWithInfowindow(window.CRM.map, latlng, image, Name, contentString);`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment src/skin/js/calendar/GoogleMapEvent.js:153 — "Add marker and infowindow" repeats the code it sits on: 3 of its 3 words (add, marker, infowindow) are already in `marker = addMarkerWithInfowindow(window.CRM.map, latlng, image, Name, contentString);`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment src/skin/js/calendar/OpenStreetMapEvent.js:64 — "Add marker and infowindow" repeats the code it sits on: 3 of its 3 words (add, marker, infowindow) are already in `marker = addMarkerWithInfowindow(window.CRM.map, centerCard, icon, Name, contentString);`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment src/skin/js/calendar/OpenStreetMapEvent.js:125 — "Add marker and infowindow" repeats the code it sits on: 3 of its 3 words (add, marker, infowindow) are already in `marker = addMarkerWithInfowindow(window.CRM.map, centerCard, icon, Name, contentString);`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment src/skin/js/filemanager.js:337 — "$(row).attr('id', data.id)" repeats the code it sits on: 4 of its 4 words (row, attr, id, data) are already in `$(row).attr('id', data.name);`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment src/skin/js/people/FamilyVerify.js:294 — "Add marker and infowindow" repeats the code it sits on: 3 of its 3 words (add, marker, infowindow) are already in `addMarkerWithInfowindow(window.CRM.map, centerCard, icon, '', contentString);`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment src/skin/js/people/PersonVerify.js:210 — "Add marker and infowindow" repeats the code it sits on: 3 of its 3 words (add, marker, infowindow) are already in `addMarkerWithInfowindow(window.CRM.map, centerCard, icon, '', contentString);`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
D31 · IaC & Container Security · Low IaC · ×7
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D34 · Knowledge Freshness · Orphaned file · ×4
  • Orphaned file src/external/routes/register.php:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/Reports/EnvelopeReport.php:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/Reports/NameTags.php:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file locale/extract-db-locale-terms.php:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
X4 · Structured logging · Interpolated log message defeats structured logging · ×3
  • Interpolated log message defeats structured logging REDACTED:382 — `debug` at line 382 is handed a double-quoted string with variables interpolated into it as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Pass a constant message and the values in the PSR-3 context array instead: `$logger->debug('Order {order_id} moved to {status}', ['order_id' => $orderId, 'status' => $status])`, which Monolog and every PSR-3 handler keep as fields beside the message (Monolog's PsrLogMessageProcessor fills the placeholders), or `Log::debug('order moved', ['order_id' => $orderId])` with Laravel's facade.
  • Interpolated log message defeats structured logging REDACTED:389 — `debug` at line 389 is handed a double-quoted string with variables interpolated into it as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Pass a constant message and the values in the PSR-3 context array instead: `$logger->debug('Order {order_id} moved to {status}', ['order_id' => $orderId, 'status' => $status])`, which Monolog and every PSR-3 handler keep as fields beside the message (Monolog's PsrLogMessageProcessor fills the placeholders), or `Log::debug('order moved', ['order_id' => $orderId])` with Laravel's facade.
  • Interpolated log message defeats structured logging REDACTED:407 — `debug` at line 407 is handed a double-quoted string with variables interpolated into it as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Pass a constant message and the values in the PSR-3 context array instead: `$logger->debug('Order {order_id} moved to {status}', ['order_id' => $orderId, 'status' => $status])`, which Monolog and every PSR-3 handler keep as fields beside the message (Monolog's PsrLogMessageProcessor fills the placeholders), or `Log::debug('order moved', ['order_id' => $orderId])` with Laravel's facade.
D29 · Static Analysis (SAST) · REDACTED · ×2
  • REDACTED
  • REDACTED
D16 · Bus Factor · Off-boarding risk · ×1
  • Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 189 significant file(s) lose their only recent owner: src/v2/templates/people/personview.php, src/EcclesiaCRM/Service/CalendarService.php, src/EcclesiaCRM/utils/MiscUtils.php, REDACTED, src/v2/templates/people/familyview.php, src/v2/templates/user/userseditor.php, src/EcclesiaCRM/APIControllers/DocumentFileManagerController.php, src/EcclesiaCRM/model/EcclesiaCRM/User.php (+181 more). Pair on, review, or document these before any departure.
D20 · ADR Quality · No ADRs found · ×1
  • No ADRs found src/composer.json:5 — No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`. ADRs are expected here because `src/composer.json` makes this repository a deployable product (line 5).
D26 · Project Cohesion · Projects may be oversized for their cohesion · ×1
  • Projects may be oversized for their cohesion src/composer.json:1 — `src` (150740 LoC, 533 module-visible types across 84 directories) overshoots its size bounds. 1 of 4 build unit(s) (Composer, Python, npm) overshoot their size bounds, lowering Project Cohesion to 5.0/10. Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.
D27 · Navigability · Scattered collaborators · ×1
  • Scattered collaborators — 97 % of calls cross a namespace and only 1 % of collaborators are co-located — group each feature's code into a vertical slice so a call's collaborators sit together.
D28 · Secrets (history) · Rotate the exposed credentials · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D34 · Knowledge Freshness · Further orphaned files (smaller) · ×1
  • Further orphaned files (smaller) — 4 smaller file(s) also have no living knowledge — folded into the freshness score and metrics rather than raised one row each — most significant first: src/external/routes/register.php, src/Reports/EnvelopeReport.php, src/Reports/NameTags.php, locale/extract-db-locale-terms.php (6 orphaned of 372 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated, example/demo and scaffolding-template trees and test files identified by path convention, largest first; 372 of the 782 production source files in this repository met that bar). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway.
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
M2 · Architecture documentation · No ADRs · ×1
  • No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
P3 · Security & performance tooling · No SAST · ×1
  • No SAST — No static application security testing detected. For this repository's stack, add phpstan or psalm (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 1 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
P3 · Security & performance tooling · No dependency-update automation · ×1
  • No dependency-update automation package.json:22 — `package.json` declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices — including after an advisory is published against it. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per ecosystem the tree uses (or an enabled `renovate.json`), and gate pull requests with `actions/dependency-review-action`.
P4 · Deployment & Rollback · No rollback/health safety · ×1
  • No rollback/health safety — Deployment is orchestrated by compose, but no service declares a `healthcheck:` and nothing pins a previous image to fall back to — the runtime can tell that the container is up, not that it is serving, so a bad release is harder to detect and reverse.
S1 · Web-Security Posture · No security response headers detected · ×1
  • No security response headers detected docker/config/vhosts/default.conf:1 — None of the 11 security response headers the OWASP Secure Headers Project recommends (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options, …) is configured — defense in depth, even when a reverse proxy could set them. This is reported because `default.conf` is committed to this repository and declares the server that serves it, so the configuration that would carry these headers is in this repository and was read in full. (−2.0 on this card.)
X2 · Cancellation propagation · Not all async functions that make a request accept an AbortSignal · ×1
  • Not all async functions that make a request accept an AbortSignal — Only 0/1 async functions that make a cancellable request (fetch, axios, ky, ofetch, got, undici, node:http) accept an AbortSignal or pass one on, so a request keeps running after whatever wanted it has given up — a page navigated away from, an unmounted component, a timed-out job. Take a `signal` (or an options object that carries one) and hand it to the request; where nothing could ever cancel the call, omitting it is a deliberate choice — judge against how the function is used.
X5 · Nullable reference types · PHP static analysis does not check null everywhere · ×1
  • PHP static analysis does not check null everywhere — This repository commits no PHPStan or Psalm configuration (`phpstan.neon[.dist]`, `phpstan.dist.neon`, `psalm.xml[.dist]`, or one a composer.json script names with `--configuration`), so nothing checks null: a `?Customer` reaches `->name()` silently and throws `Error: Call to a member function name() on null` the first time it is null. If the build passes a level on a command line instead, put it in a committed configuration — this check reads configuration, and configuration is all it can read.
X7 · Silent fallback defaults · Silent fallback default in catch · ×1
  • Silent fallback default in catch src/EcclesiaCRM/utils/OutputUtils.php:485 — `change_time_for_place_holder` swallows every exception into `return ""` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the docblock, and the row stops firing.
Minor — 1 finding(s)
D24 · Comment Value · doc comments repeat the names · ×1
  • doc comments repeat the names src/skin/js/fundraiser/paddleNumList.js:111 — 0 of 0 documented parameters and 1 of 6 summaries in `EcclesiaCRM` only repeat the member or parameter name (e.g. "Create or edit buyer" for `createOrEditBuyer`). Delete the restating tags, or add what the name does not say.

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

DimensionToolVersionCommandFindingsRaw output
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=0 --max-count=200" --report-format json --report-path /tmp/watchdog-gitleaks-c8f053d5dfdd49d0a07c5e4cafa9cfac/history.json --exit-code 0 --source .0artifacts/raw/gitleaks-history.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=200 --max-count=800" --report-format json --report-path /tmp/watchdog-gitleaks-c8f053d5dfdd49d0a07c5e4cafa9cfac/history-1.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-1.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=1000 --max-count=3052" --report-format json --report-path /tmp/watchdog-gitleaks-c8f053d5dfdd49d0a07c5e4cafa9cfac/history-2.json --exit-code 0 --source .1artifacts/raw/gitleaks-history-2.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=4052 --max-count=4715" --report-format json --report-path /tmp/watchdog-gitleaks-c8f053d5dfdd49d0a07c5e4cafa9cfac/history-3.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-3.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=8767 --max-count=6869" --report-format json --report-path /tmp/watchdog-gitleaks-c8f053d5dfdd49d0a07c5e4cafa9cfac/history-4.json --exit-code 0 --source .6artifacts/raw/gitleaks-history-4.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=15636 --max-count=104" --report-format json --report-path /tmp/watchdog-gitleaks-c8f053d5dfdd49d0a07c5e4cafa9cfac/history-5.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-5.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-git --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-c8f053d5dfdd49d0a07c5e4cafa9cfac/tree.json --exit-code 0 --source .2artifacts/raw/gitleaks-tree.json
D29 · Static Analysis (SAST)semgrep—semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --config /opt/semgrep-rules/canine-sast.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off --exclude *.arrow --exclude *.avro --exclude *.csv --exclude *.dat --exclude *.db --exclude *.feather --exclude *.geojson --exclude *.h5 --exclude *.hdf5 --exclude *.jsonl --exclude *.log --exclude *.ndjson --exclude *.npy --exclude *.npz --exclude *.orc --exclude *.parquet --exclude *.pickle --exclude *.pkl --exclude *.psv --exclude *.sqlite --exclude *.sqlite3 --exclude *.tfrecord --exclude *.tsv --exclude *.txt --exclude Documentation/doc-en/site/assets/javascripts/lunr/min --exclude Documentation/doc-fr/site/assets/javascripts/lunr/min .207artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilitiestrivy—trivy fs --scanners vuln --format json --quiet --severity CRITICAL,HIGH,MEDIUM,LOW --skip-dirs **/bin/** --skip-dirs **/obj/** .1artifacts/raw/trivy-fs.json
D31 · IaC & Container Securitytrivy—trivy config --format json --quiet .54artifacts/raw/trivy-config.json
D32 · Data Compliance (PII/GDPR)semgrep—semgrep --config /opt/semgrep-rules/gdpr.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off --exclude *.arrow --exclude *.avro --exclude *.csv --exclude *.dat --exclude *.db --exclude *.feather --exclude *.geojson --exclude *.h5 --exclude *.hdf5 --exclude *.jsonl --exclude *.log --exclude *.ndjson --exclude *.npy --exclude *.npz --exclude *.orc --exclude *.parquet --exclude *.pickle --exclude *.pkl --exclude *.psv --exclude *.sqlite --exclude *.sqlite3 --exclude *.tfrecord --exclude *.tsv --exclude *.txt --exclude Documentation/doc-en/site/assets/javascripts/lunr/min --exclude Documentation/doc-fr/site/assets/javascripts/lunr/min .4artifacts/raw/semgrep-gdpr.json
D40 · Network Egress Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.0—
D41 · Kernel & Syscall Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.0—
D42 · Runtime Threat Enforcementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.0—
D43 · Malicious Dependenciestrivy—trivy fs --scanners vuln --format json --quiet --severity CRITICAL,HIGH,MEDIUM,LOW --skip-dirs **/bin/** --skip-dirs **/obj/** .0artifacts/raw/trivy-fs.json

Run 01a1e9c1-5e2d-7e17-a035-46590924627c · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Downloadable artifacts

Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.

⬇ Findings, MITRE CWE-tagged .sarif⬇ Health changelog .md