{"$schema":"https://json.schemastore.org/sarif-2.1.0.json","version":"2.1.0","runs":[{"tool":{"driver":{"name":"codehealth","informationUri":"https://codehealth.canine.dev","rules":[{"id":"D1","name":"Cyclomatic Complexity","shortDescription":{"text":"Cyclomatic Complexity"},"helpUri":"https://codehealth.canine.dev/dimensions/D1"},{"id":"D2","name":"Cognitive Complexity","shortDescription":{"text":"Cognitive Complexity"},"helpUri":"https://codehealth.canine.dev/dimensions/D2"},{"id":"D3","name":"God Classes","shortDescription":{"text":"God Classes"},"helpUri":"https://codehealth.canine.dev/dimensions/D3"},{"id":"D4","name":"Code Duplication","shortDescription":{"text":"Code Duplication"},"helpUri":"https://codehealth.canine.dev/dimensions/D4"},{"id":"D6","name":"Cohesion (LCOM4)","shortDescription":{"text":"Cohesion (LCOM4)"},"helpUri":"https://codehealth.canine.dev/dimensions/D6"},{"id":"D10","name":"Test Quality","shortDescription":{"text":"Test Quality"},"helpUri":"https://codehealth.canine.dev/dimensions/D10"},{"id":"D13","name":"Secret Scanning","shortDescription":{"text":"Secret Scanning"},"helpUri":"https://codehealth.canine.dev/dimensions/D13","relationships":[{"target":{"id":"CWE-798","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-798","CWE-259"],"owasp":"A07:2025"}},{"id":"D15","name":"Churn \u00D7 Complexity Hotspots","shortDescription":{"text":"Churn \u00D7 Complexity Hotspots"},"helpUri":"https://codehealth.canine.dev/dimensions/D15"},{"id":"D16","name":"Bus Factor","shortDescription":{"text":"Bus Factor"},"helpUri":"https://codehealth.canine.dev/dimensions/D16"},{"id":"D17","name":"Explicit Debt","shortDescription":{"text":"Explicit Debt"},"helpUri":"https://codehealth.canine.dev/dimensions/D17"},{"id":"D24","name":"Comment Value","shortDescription":{"text":"Comment Value"},"helpUri":"https://codehealth.canine.dev/dimensions/D24"},{"id":"D27","name":"Navigability","shortDescription":{"text":"Navigability"},"helpUri":"https://codehealth.canine.dev/dimensions/D27"},{"id":"D28","name":"Secrets (history)","shortDescription":{"text":"Secrets (history)"},"helpUri":"https://codehealth.canine.dev/dimensions/D28","relationships":[{"target":{"id":"CWE-798","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-798","CWE-259"],"owasp":"A07:2025"}},{"id":"D29","name":"Static Analysis (SAST)","shortDescription":{"text":"Static Analysis (SAST)"},"helpUri":"https://codehealth.canine.dev/dimensions/D29","relationships":[{"target":{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-89","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-78","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-94","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-77","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-79","CWE-89","CWE-78","CWE-94","CWE-77"],"owasp":"A05:2025"}},{"id":"D34","name":"Knowledge Freshness","shortDescription":{"text":"Knowledge Freshness"},"helpUri":"https://codehealth.canine.dev/dimensions/D34"},{"id":"D35","name":"Change Coupling","shortDescription":{"text":"Change Coupling"},"helpUri":"https://codehealth.canine.dev/dimensions/D35"},{"id":"AX10","name":"Code composition","shortDescription":{"text":"Code composition"},"helpUri":"https://codehealth.canine.dev/dimensions/AX10"},{"id":"AX3","name":"Project dependency cycles","shortDescription":{"text":"Project dependency cycles"},"helpUri":"https://codehealth.canine.dev/dimensions/AX3"},{"id":"AX5","name":"Architecture \u0026 structure","shortDescription":{"text":"Architecture \u0026 structure"},"helpUri":"https://codehealth.canine.dev/dimensions/AX5"},{"id":"AXB1","name":"Runtime evidence locked \u2014 no reproducible boot","shortDescription":{"text":"Runtime evidence locked \u2014 no reproducible boot"},"helpUri":"https://codehealth.canine.dev/dimensions/AXB1"},{"id":"ED5","name":"Idempotency","shortDescription":{"text":"Idempotency"},"helpUri":"https://codehealth.canine.dev/dimensions/ED5"},{"id":"M1","name":"Documentation (README)","shortDescription":{"text":"Documentation (README)"},"helpUri":"https://codehealth.canine.dev/dimensions/M1"},{"id":"M2","name":"Architecture documentation","shortDescription":{"text":"Architecture documentation"},"helpUri":"https://codehealth.canine.dev/dimensions/M2"},{"id":"M3","name":"Folder \u0026 project structure","shortDescription":{"text":"Folder \u0026 project structure"},"helpUri":"https://codehealth.canine.dev/dimensions/M3"},{"id":"M4","name":"Documentation accuracy","shortDescription":{"text":"Documentation accuracy"},"helpUri":"https://codehealth.canine.dev/dimensions/M4"},{"id":"P1","name":"CI/CD gates","shortDescription":{"text":"CI/CD gates"},"helpUri":"https://codehealth.canine.dev/dimensions/P1"},{"id":"P2","name":"Observability","shortDescription":{"text":"Observability"},"helpUri":"https://codehealth.canine.dev/dimensions/P2"},{"id":"P3","name":"Security \u0026 performance tooling","shortDescription":{"text":"Security \u0026 performance tooling"},"helpUri":"https://codehealth.canine.dev/dimensions/P3"},{"id":"P6","name":"Release Hygiene","shortDescription":{"text":"Release Hygiene"},"helpUri":"https://codehealth.canine.dev/dimensions/P6"},{"id":"P7","name":"Outbound HTTP resilience","shortDescription":{"text":"Outbound HTTP resilience"},"helpUri":"https://codehealth.canine.dev/dimensions/P7"},{"id":"R1","name":"Type Safety","shortDescription":{"text":"Type Safety"},"helpUri":"https://codehealth.canine.dev/dimensions/R1"},{"id":"R10","name":"Code Duplication","shortDescription":{"text":"Code Duplication"},"helpUri":"https://codehealth.canine.dev/dimensions/R10"},{"id":"R2","name":"Cyclomatic Complexity","shortDescription":{"text":"Cyclomatic Complexity"},"helpUri":"https://codehealth.canine.dev/dimensions/R2"},{"id":"R3","name":"Large Files","shortDescription":{"text":"Large Files"},"helpUri":"https://codehealth.canine.dev/dimensions/R3"},{"id":"R9","name":"Circular Imports","shortDescription":{"text":"Circular Imports"},"helpUri":"https://codehealth.canine.dev/dimensions/R9"},{"id":"X10","name":"Duplicated predicate","shortDescription":{"text":"Duplicated predicate"},"helpUri":"https://codehealth.canine.dev/dimensions/X10"},{"id":"X13","name":"Undrained process stream","shortDescription":{"text":"Undrained process stream"},"helpUri":"https://codehealth.canine.dev/dimensions/X13"},{"id":"X14","name":"Bypassable address classification","shortDescription":{"text":"Bypassable address classification"},"helpUri":"https://codehealth.canine.dev/dimensions/X14"},{"id":"X15","name":"Unvalidated length from an untrusted reader","shortDescription":{"text":"Unvalidated length from an untrusted reader"},"helpUri":"https://codehealth.canine.dev/dimensions/X15"},{"id":"X16","name":"Unfloored truncation loop","shortDescription":{"text":"Unfloored truncation loop"},"helpUri":"https://codehealth.canine.dev/dimensions/X16"},{"id":"X17","name":"Uncapped recursion over a caller-supplied document","shortDescription":{"text":"Uncapped recursion over a caller-supplied document"},"helpUri":"https://codehealth.canine.dev/dimensions/X17"},{"id":"X18","name":"Disposal-pattern correctness","shortDescription":{"text":"Disposal-pattern correctness"},"helpUri":"https://codehealth.canine.dev/dimensions/X18"},{"id":"X19","name":"Unrestored process-global state","shortDescription":{"text":"Unrestored process-global state"},"helpUri":"https://codehealth.canine.dev/dimensions/X19"},{"id":"X20","name":"Mistyped argument guard","shortDescription":{"text":"Mistyped argument guard"},"helpUri":"https://codehealth.canine.dev/dimensions/X20"},{"id":"X21","name":"Side-effecting pattern guard","shortDescription":{"text":"Side-effecting pattern guard"},"helpUri":"https://codehealth.canine.dev/dimensions/X21"},{"id":"X22","name":"Contradicted release guard","shortDescription":{"text":"Contradicted release guard"},"helpUri":"https://codehealth.canine.dev/dimensions/X22"},{"id":"X23","name":"Unguarded diagnostic materialisation","shortDescription":{"text":"Unguarded diagnostic materialisation"},"helpUri":"https://codehealth.canine.dev/dimensions/X23"},{"id":"X24","name":"Document value interpolated into markup unescaped","shortDescription":{"text":"Document value interpolated into markup unescaped"},"helpUri":"https://codehealth.canine.dev/dimensions/X24"},{"id":"X25","name":"Inert configuration knob","shortDescription":{"text":"Inert configuration knob"},"helpUri":"https://codehealth.canine.dev/dimensions/X25"},{"id":"X26","name":"Unsynchronised callback handoff","shortDescription":{"text":"Unsynchronised callback handoff"},"helpUri":"https://codehealth.canine.dev/dimensions/X26"},{"id":"X28","name":"Index access outside its own emptiness guard","shortDescription":{"text":"Index access outside its own emptiness guard"},"helpUri":"https://codehealth.canine.dev/dimensions/X28"},{"id":"X3","name":"Exception handling","shortDescription":{"text":"Exception handling"},"helpUri":"https://codehealth.canine.dev/dimensions/X3"},{"id":"X30","name":"Support guard that admits what it rejects","shortDescription":{"text":"Support guard that admits what it rejects"},"helpUri":"https://codehealth.canine.dev/dimensions/X30"},{"id":"X32","name":"Type resolved by simple name across every loaded assembly","shortDescription":{"text":"Type resolved by simple name across every loaded assembly"},"helpUri":"https://codehealth.canine.dev/dimensions/X32"},{"id":"X5","name":"Nullable reference types","shortDescription":{"text":"Nullable reference types"},"helpUri":"https://codehealth.canine.dev/dimensions/X5"},{"id":"X6","name":"Hand-rolled structured-format parsing","shortDescription":{"text":"Hand-rolled structured-format parsing"},"helpUri":"https://codehealth.canine.dev/dimensions/X6"},{"id":"X7","name":"Silent fallback defaults","shortDescription":{"text":"Silent fallback defaults"},"helpUri":"https://codehealth.canine.dev/dimensions/X7"},{"id":"X9","name":"Subsumed condition operand","shortDescription":{"text":"Subsumed condition operand"},"helpUri":"https://codehealth.canine.dev/dimensions/X9"}]}},"results":[{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorAuthRegisterController.handleRequest (cyclomatic 88): PhabricatorAuthRegisterController.handleRequest has cyclomatic complexity 88 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthRegisterController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"496bbcf1c730841baf45b19ceb85021b46af6f3c2f1f35b0a02905bdbbe7727a"}},{"ruleId":"D1","level":"warning","message":{"text":"behavior-pholio-mock-view.JX.behavior(\u0022pholio-mock-view\u0022) (cyclomatic 75): behavior-pholio-mock-view.JX.behavior(\u0022pholio-mock-view\u0022) has cyclomatic complexity 75 (threshold 15). Most of this is not in the body itself: 2 of the 75 points are its own statements and the rest belongs to 29 function items inside it that branch (redraw_inlines, resize_selection, render_image_info, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"cc5f4495f43555adcc86ccf5d90e39d125aa3f5444fab559effae41117573cb4"}},{"ruleId":"D1","level":"warning","message":{"text":"(anonymous) (cyclomatic 75): (anonymous) has cyclomatic complexity 75 (threshold 15). Most of this is not in the body itself: 2 of the 75 points are its own statements and the rest belongs to 50 function items inside it that branch (redraw_inlines, resize_selection, render_image_info, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"99842fbd6ff7c9185fcce05f1ad6e3882b19de6940e67c636d1bef2394f8502f"}},{"ruleId":"D1","level":"warning","message":{"text":"qsprintf.xsprintf_query (cyclomatic 69): qsprintf.xsprintf_query has cyclomatic complexity 69 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/xsprintf/qsprintf.php"},"region":{"startLine":90}}}],"partialFingerprints":{"codehealthFindingId/v1":"35d4238aeae914cc8133907b9b9531782b909b3b1f09432744e18ab869c70768"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialChangesetParser.render (cyclomatic 65): DifferentialChangesetParser.render has cyclomatic complexity 65 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialChangesetParser.php"},"region":{"startLine":749}}}],"partialFingerprints":{"codehealthFindingId/v1":"e7796f942805bf64e5e32f28e03c961b79093f4402e71858b4ed89df1e4ce7e1"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorApplicationTransaction.getTitle (cyclomatic 65): PhabricatorApplicationTransaction.getTitle has cyclomatic complexity 65 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorApplicationTransaction.php"},"region":{"startLine":943}}}],"partialFingerprints":{"codehealthFindingId/v1":"ddf99b7fcc648059366e65e06f3c638d9b1d4e118b088c3a503570a63d749486"}},{"ruleId":"D1","level":"warning","message":{"text":"repository-crossreference.JX.behavior(\u0022repository-crossreference\u0022) (cyclomatic 64): repository-crossreference.JX.behavior(\u0022repository-crossreference\u0022) has cyclomatic complexity 64 (threshold 15). Most of this is not in the body itself: 3 of the 64 points are its own statements and the rest belongs to 13 function items inside it that branch (openSearch, a function literal at line 58, a function literal at line 325, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/repository/repository-crossreference.js"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"61ccb3f10f152a805a604a8eaeac479078af61649e859fcc690e331b83afc48d"}},{"ruleId":"D1","level":"warning","message":{"text":"(anonymous) (cyclomatic 64): (anonymous) has cyclomatic complexity 64 (threshold 15). Most of this is not in the body itself: 3 of the 64 points are its own statements and the rest belongs to 18 function items inside it that branch (openSearch, a function literal at line 58, a function literal at line 325, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/repository/repository-crossreference.js"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"af0a40ddf49ae156e4b38e28fc6afceaa96f04d8f83dc7b9662c18bb74bc9911"}},{"ruleId":"D1","level":"warning","message":{"text":"PhutilSearchQueryCompiler.tokenizeQuery (cyclomatic 62): PhutilSearchQueryCompiler.tokenizeQuery has cyclomatic complexity 62 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/compiler/PhutilSearchQueryCompiler.php"},"region":{"startLine":104}}}],"partialFingerprints":{"codehealthFindingId/v1":"b3d49ccc43e6b74d8fc3b39f008a61f97d9c40cddc1d6d6978c98732cf247bd6"}},{"ruleId":"D1","level":"warning","message":{"text":"HarbormasterBuildLogRenderController.handleRequest (cyclomatic 60): HarbormasterBuildLogRenderController.handleRequest has cyclomatic complexity 60 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"552dae395bb799c0ced60fab71aa5fcc2604ab2af7dd6027b31bdcff4b6aeedf"}},{"ruleId":"D1","level":"warning","message":{"text":"behavior-document-engine.JX.behavior(\u0022document-engine\u0022) (cyclomatic 59): behavior-document-engine.JX.behavior(\u0022document-engine\u0022) has cyclomatic complexity 59 (threshold 15). Most of this is not in the body itself: 6 of the 59 points are its own statements and the rest belongs to 14 function items inside it that branch (blame, onview, getHSV, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/files/behavior-document-engine.js"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"d888c2dccdf9f105a2ec9555078b83684372794f5905eb61592c8b8c0721c684"}},{"ruleId":"D1","level":"warning","message":{"text":"(anonymous) (cyclomatic 59): (anonymous) has cyclomatic complexity 59 (threshold 15). Most of this is not in the body itself: 6 of the 59 points are its own statements and the rest belongs to 18 function items inside it that branch (blame, onview, getHSV, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/files/behavior-document-engine.js"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"d7a0e1f4535d9e2a4ae42df58b755d7a0ba2ed0808ea2c1a872fa16810f37d55"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialRevisionViewController.handleRequest (cyclomatic 57): DifferentialRevisionViewController.handleRequest has cyclomatic complexity 57 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/controller/DifferentialRevisionViewController.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"e02c3d4f370892426a9b956dc2e44413b26c4efa62d898bca84f3310436367a8"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialChangesetHTMLRenderer.renderChangeTypeHeader (cyclomatic 57): DifferentialChangesetHTMLRenderer.renderChangeTypeHeader has cyclomatic complexity 57 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform \u2014 the same kind of value, with no behaviour of its own \u2014 a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetHTMLRenderer.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"9340ac0aa517cf7ba28650960c6a8524959e00e98535e7da6656608469842db6"}},{"ruleId":"D1","level":"warning","message":{"text":"behavior-fancy-datepicker.JX.behavior(\u0022fancy-datepicker\u0022) (cyclomatic 57): behavior-fancy-datepicker.JX.behavior(\u0022fancy-datepicker\u0022) has cyclomatic complexity 57 (threshold 15). Most of this is not in the body itself: 2 of the 57 points are its own statements and the rest belongs to 14 function items inside it that branch (write_date, getValidDate, render_day, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-fancy-datepicker.js"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"171f2009bbedcc4c9fc20e697081f4042a6dc3eacee7c7bad1f8ad3770565aa9"}},{"ruleId":"D1","level":"warning","message":{"text":"(anonymous) (cyclomatic 57): (anonymous) has cyclomatic complexity 57 (threshold 15). Most of this is not in the body itself: 2 of the 57 points are its own statements and the rest belongs to 18 function items inside it that branch (write_date, getValidDate, render_day, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-fancy-datepicker.js"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"431520c243e1d913d11f46e95fcac488c1e70ad0842fa7dbaf23ba27220f4a54"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorRepository.generateURI (cyclomatic 56): PhabricatorRepository.generateURI has cyclomatic complexity 56 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform \u2014 the same kind of value, with no behaviour of its own \u2014 a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepository.php"},"region":{"startLine":681}}}],"partialFingerprints":{"codehealthFindingId/v1":"9399db83e8847ef57e052bd6075562468d90a256704b96ac9ab02de1bb863903"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorRepositorySvnCommitChangeParserWorker.parseCommitChanges (cyclomatic 54): PhabricatorRepositorySvnCommitChangeParserWorker.parseCommitChanges has cyclomatic complexity 54 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/commitchangeparser/PhabricatorRepositorySvnCommitChangeParserWorker.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"0db9ef1fa6c5b13a186d38705e4764237e265dfad42c53c7d2aaed8897fe5d14"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialChangesetTwoUpRenderer.renderTextChange (cyclomatic 53): DifferentialChangesetTwoUpRenderer.renderTextChange has cyclomatic complexity 53 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"0411d95c4d54e6f8463527ada6ff9827739f7ed663103f385b5df0a8c00dbbe5"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorCalendarImportEngine.importEventDocument (cyclomatic 51): PhabricatorCalendarImportEngine.importEventDocument has cyclomatic complexity 51 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/import/PhabricatorCalendarImportEngine.php"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"828ad281652e77dc0f46f5e0fa60a58304a2e3def8c2e6b2d1bce8e8ecef088a"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorApplicationSearchController.processSearchRequest (cyclomatic 51): PhabricatorApplicationSearchController.processSearchRequest has cyclomatic complexity 51 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/controller/PhabricatorApplicationSearchController.php"},"region":{"startLine":95}}}],"partialFingerprints":{"codehealthFindingId/v1":"200038089323d4251a8aced8f25e8f4ab312ff7d802d4501a09500adf7c24be1"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorApplicationTransactionEditor.applyTransactions (cyclomatic 50): PhabricatorApplicationTransactionEditor.applyTransactions has cyclomatic complexity 50 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":1175}}}],"partialFingerprints":{"codehealthFindingId/v1":"d1b6401912b52d6b027d00cd13cd5361f43ff7367775ff13b24c85cd2ca98cca"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorRepositoryMercurialCommitChangeParserWorker.parseCommitChanges (cyclomatic 49): PhabricatorRepositoryMercurialCommitChangeParserWorker.parseCommitChanges has cyclomatic complexity 49 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryMercurialCommitChangeParserWorker.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"60137da48d136a562533ebce4621525630993d8007a297a0b4d8e844dcb78e88"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorStorageManagementDumpWorkflow.didExecute (cyclomatic 49): PhabricatorStorageManagementDumpWorkflow.didExecute has cyclomatic complexity 49 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php"},"region":{"startLine":64}}}],"partialFingerprints":{"codehealthFindingId/v1":"96b6682f04cb1c2abfa7bf6ccb73e099b80b3868f6d85e20edfebdb9aa6d2a01"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorStorageManagementWorkflow.doAdjustSchemata (cyclomatic 49): PhabricatorStorageManagementWorkflow.doAdjustSchemata has cyclomatic complexity 49 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php"},"region":{"startLine":159}}}],"partialFingerprints":{"codehealthFindingId/v1":"8f0cc0ebf5a11c772f05114a087623e3b509d575cf7ff98d76096312f0c61142"}},{"ruleId":"D1","level":"warning","message":{"text":"DiffusionCommitQuery.buildWhereClauseParts (cyclomatic 48): DiffusionCommitQuery.buildWhereClauseParts has cyclomatic complexity 48 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/DiffusionCommitQuery.php"},"region":{"startLine":536}}}],"partialFingerprints":{"codehealthFindingId/v1":"b3668404ffd30de4ff516b521a9e7e037c91a5336ff5f29075f895a56683dbf7"}},{"ruleId":"D1","level":"warning","message":{"text":"DiffusionCommitController.handleRequest (cyclomatic 47): DiffusionCommitController.handleRequest has cyclomatic complexity 47 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionCommitController.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"9bb2c9207b14365572ab6e9f190d35b60b8b64e989dfa1f954e30f24f7959711"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorProfileMenuEngine.buildResponse (cyclomatic 47): PhabricatorProfileMenuEngine.buildResponse has cyclomatic complexity 47 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorProfileMenuEngine.php"},"region":{"startLine":102}}}],"partialFingerprints":{"codehealthFindingId/v1":"49b6489b5947ff8cf9080d5acdeb122c46b10e64903269ea8409f1965096eb71"}},{"ruleId":"D1","level":"warning","message":{"text":"PHUIDiffInlineCommentDetailView.render (cyclomatic 46): PHUIDiffInlineCommentDetailView.render has cyclomatic complexity 46 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php"},"region":{"startLine":78}}}],"partialFingerprints":{"codehealthFindingId/v1":"7f0db53b5d3502ff821ba2c7a266358bcfdca61e2561675a4787bbbd194e71e1"}},{"ruleId":"D1","level":"warning","message":{"text":"PHUIObjectItemView.getTagContent (cyclomatic 46): PHUIObjectItemView.getTagContent has cyclomatic complexity 46 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIObjectItemView.php"},"region":{"startLine":383}}}],"partialFingerprints":{"codehealthFindingId/v1":"cf0060cb5cc4cbfc567acdf8ba03361f5e02c9965c44240a2cdefff39cb1ddc7"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorStorageManagementWorkflow.doUpgradeSchemata (cyclomatic 45): PhabricatorStorageManagementWorkflow.doUpgradeSchemata has cyclomatic complexity 45 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php"},"region":{"startLine":918}}}],"partialFingerprints":{"codehealthFindingId/v1":"0701a1064ca543f36af2638ec83bf654d246de4b883187a1959c07b85ee174c7"}},{"ruleId":"D1","level":"warning","message":{"text":"HeraldAdapter.doesConditionMatch (cyclomatic 43): HeraldAdapter.doesConditionMatch has cyclomatic complexity 43 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/adapter/HeraldAdapter.php"},"region":{"startLine":444}}}],"partialFingerprints":{"codehealthFindingId/v1":"4745a55a2bb895c887a5fde321db26296f3e59427d00aee60ac61532af6dc400"}},{"ruleId":"D1","level":"warning","message":{"text":"behavior-oncopy.JX.behavior(\u0022phabricator-oncopy\u0022) (cyclomatic 43): behavior-oncopy.JX.behavior(\u0022phabricator-oncopy\u0022) has cyclomatic complexity 43 (threshold 15). Most of this is not in the body itself: 1 of the 43 points is its own statement and the rest belongs to 8 function items inside it that branch (onstartselect, extract_text, oncopy, \u2026). Those helpers are already separate functions, so extracting the branching again is not available. To reduce it, move them out of the body to the enclosing scope, where each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-oncopy.js"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"721cabdb69df733c412fc94e7b71365302e4f5458b2cde2022aae808fc4c9553"}},{"ruleId":"D1","level":"warning","message":{"text":"(anonymous) (cyclomatic 43): (anonymous) has cyclomatic complexity 43 (threshold 15). Most of this is not in the body itself: 1 of the 43 points is its own statement and the rest belongs to 8 function items inside it that branch (onstartselect, extract_text, oncopy, \u2026). Those helpers are already separate functions, so extracting the branching again is not available. To reduce it, move them out of the body to the enclosing scope, where each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-oncopy.js"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"8eafde383c84f4c105b89217b3e31f08e2c33f560068beb53fd35c5f75179dc7"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorApplicationTransaction.shouldHide (cyclomatic 42): PhabricatorApplicationTransaction.shouldHide has cyclomatic complexity 42 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorApplicationTransaction.php"},"region":{"startLine":588}}}],"partialFingerprints":{"codehealthFindingId/v1":"2f57243fecd7ea23cde015c1f1a3c6c514689edd77a2653a4e5d01ba68c120e5"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorInlineCommentAdjustmentEngine.execute (cyclomatic 42): PhabricatorInlineCommentAdjustmentEngine.execute has cyclomatic complexity 42 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"3a56ec5101cf0054e55c5f3e0603c642f08c0be2374946c38fbf42981bc921bd"}},{"ruleId":"D1","level":"warning","message":{"text":"DiffusionServeController.serveRequest (cyclomatic 41): DiffusionServeController.serveRequest has cyclomatic complexity 41 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionServeController.php"},"region":{"startLine":176}}}],"partialFingerprints":{"codehealthFindingId/v1":"91677eba71924b42724efbae82985d7c3e2316167a6e2486a01ee9f10ecc19f5"}},{"ruleId":"D1","level":"warning","message":{"text":"AphrontTableView.render (cyclomatic 41): AphrontTableView.render has cyclomatic complexity 41 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/control/AphrontTableView.php"},"region":{"startLine":131}}}],"partialFingerprints":{"codehealthFindingId/v1":"67322e3304943c21603466a37e7ef652d28dcc077dae385dda142463aef10fb7"}},{"ruleId":"D1","level":"warning","message":{"text":"behavior-dark-console.JX.behavior(\u0022dark-console\u0022) (cyclomatic 41): behavior-dark-console.JX.behavior(\u0022dark-console\u0022) has cyclomatic complexity 41 (threshold 15). Most of this is not in the body itself: 9 of the 41 points are its own statements and the rest belongs to 16 function items inside it that branch (render_request, leader_log, a function literal at line 382, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/darkconsole/behavior-dark-console.js"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"87a51151bca085eee296798b1270bd0f8b43b5d710ac01db79196861efcee419"}},{"ruleId":"D1","level":"warning","message":{"text":"(anonymous) (cyclomatic 41): (anonymous) has cyclomatic complexity 41 (threshold 15). Most of this is not in the body itself: 9 of the 41 points are its own statements and the rest belongs to 25 function items inside it that branch (render_request, leader_log, a function literal at line 382, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/darkconsole/behavior-dark-console.js"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"357312e67450a5f2fd9669f1935e791981e3370b0ea9a699b668263c1a13d448"}},{"ruleId":"D1","level":"warning","message":{"text":"DiffusionURIEditor.validateTransaction (cyclomatic 40): DiffusionURIEditor.validateTransaction has cyclomatic complexity 40 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/editor/DiffusionURIEditor.php"},"region":{"startLine":156}}}],"partialFingerprints":{"codehealthFindingId/v1":"efb228bf9b65a96cea5fe14594d4bb8a570f26529751343ae93db6519e2ab50c"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorManiphestTaskFactEngine.newDatapointsForObject (cyclomatic 39): PhabricatorManiphestTaskFactEngine.newDatapointsForObject has cyclomatic complexity 39 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fact/engine/PhabricatorManiphestTaskFactEngine.php"},"region":{"startLine":86}}}],"partialFingerprints":{"codehealthFindingId/v1":"ba2b960202fd734d6bffbac3a65ce3abe8dd718a8b6fe875a4ee79b81d766de2"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorRepositoryManagementReparseWorkflow.execute (cyclomatic 39): PhabricatorRepositoryManagementReparseWorkflow.execute has cyclomatic complexity 39 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/management/PhabricatorRepositoryManagementReparseWorkflow.php"},"region":{"startLine":81}}}],"partialFingerprints":{"codehealthFindingId/v1":"f0342e30300fe794165bfd1ee3d72d729dc88040c8eebef05f8cdac093b3d2da"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorEditEngine.buildEditResponse (cyclomatic 39): PhabricatorEditEngine.buildEditResponse has cyclomatic complexity 39 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editengine/PhabricatorEditEngine.php"},"region":{"startLine":1033}}}],"partialFingerprints":{"codehealthFindingId/v1":"0cd08a3a709c17c1cb954dca57fbdde31e667511e3729b871fcabf66143045bd"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorWorkerManagementWorkflow.loadTasks (cyclomatic 39): PhabricatorWorkerManagementWorkflow.loadTasks has cyclomatic complexity 39 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementWorkflow.php"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"156be2c5596a98c23e78c77ea6238149368c4ad293c8702e011e3b0dc9a0fc7b"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialChangesetViewController.handleRequest (cyclomatic 38): DifferentialChangesetViewController.handleRequest has cyclomatic complexity 38 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/controller/DifferentialChangesetViewController.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"9b103934a82df27b0ee442be04989c1a3eac3b1ab8543d463ef5a7c5e22df7ca"}},{"ruleId":"D1","level":"warning","message":{"text":"DiffusionRepositoryBasicsManagementPanel.buildRepositoryStatus (cyclomatic 38): DiffusionRepositoryBasicsManagementPanel.buildRepositoryStatus has cyclomatic complexity 38 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php"},"region":{"startLine":336}}}],"partialFingerprints":{"codehealthFindingId/v1":"32122bc24302dc69f4c822317d110f5a3e3500f2601c0a4d6da129e4d7bb0fdd"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorFilesManagementIntegrityWorkflow.execute (cyclomatic 38): PhabricatorFilesManagementIntegrityWorkflow.execute has cyclomatic complexity 38 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/management/PhabricatorFilesManagementIntegrityWorkflow.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"594ad0078b06b55e0dbf5892585610472a5e5a4b1959f28edad40e4b574df898"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorSearchManagementIndexWorkflow.execute (cyclomatic 38): PhabricatorSearchManagementIndexWorkflow.execute has cyclomatic complexity 38 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php"},"region":{"startLine":74}}}],"partialFingerprints":{"codehealthFindingId/v1":"77115473eb126bcc21426a7c6a12a7fc39d4a15310e2d316ddc1f5ff410e959c"}},{"ruleId":"D1","level":"warning","message":{"text":"behavior-menu.JX.behavior(\u0022conpherence-menu\u0022) (cyclomatic 38): behavior-menu.JX.behavior(\u0022conpherence-menu\u0022) has cyclomatic complexity 38 (threshold 15). Most of this is not in the body itself: 1 of the 38 points is its own statement and the rest belongs to 15 function items inside it that branch (onDeviceChange, redrawThread, updatePageData, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/conpherence/behavior-menu.js"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"2652069abfe38a92eb852671f4a2543cedd311d6a44d5bcd0a85e14d1eb82dc2"}},{"ruleId":"D1","level":"warning","message":{"text":"(anonymous) (cyclomatic 38): (anonymous) has cyclomatic complexity 38 (threshold 15). Most of this is not in the body itself: 1 of the 38 points is its own statement and the rest belongs to 30 function items inside it that branch (onDeviceChange, redrawThread, updatePageData, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/conpherence/behavior-menu.js"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"34d891c52c2b6a79da8e87d42c8531704ead0edf6092e7cb058e92cf3981610b"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorController.willBeginExecution (cyclomatic 37): PhabricatorController.willBeginExecution has cyclomatic complexity 37 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/base/controller/PhabricatorController.php"},"region":{"startLine":64}}}],"partialFingerprints":{"codehealthFindingId/v1":"0f07de954206d675014ac4204cd593347a4c62fcbe475b9b2070d2759ed112a1"}},{"ruleId":"D1","level":"warning","message":{"text":"qsprintf.qsprintf_check_scalar_type (cyclomatic 37): qsprintf.qsprintf_check_scalar_type has cyclomatic complexity 37 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform \u2014 the same kind of value, with no behaviour of its own \u2014 a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/xsprintf/qsprintf.php"},"region":{"startLine":398}}}],"partialFingerprints":{"codehealthFindingId/v1":"a21c5de9b7363b7e8e056b55b278f1f41fc20c5e1174961e67a4f74f944503f6"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorStorageManagementWorkflow.findAdjustments (cyclomatic 36): PhabricatorStorageManagementWorkflow.findAdjustments has cyclomatic complexity 36 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php"},"region":{"startLine":534}}}],"partialFingerprints":{"codehealthFindingId/v1":"c6fccc70256925d4bc6d2f1757f4ae4aea53fecb7f85bf392d1a3aed46ecba71"}},{"ruleId":"D1","level":"warning","message":{"text":"PhutilCalendarRecurrenceRule.newDaysSet (cyclomatic 35): PhutilCalendarRecurrenceRule.newDaysSet has cyclomatic complexity 35 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php"},"region":{"startLine":1178}}}],"partialFingerprints":{"codehealthFindingId/v1":"ee35555277ae5a0eec6bdd68abec3ac93007dc2594ffcfc6c6c837d381df2482"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorEditEngineConfigurationQuery.loadPage (cyclomatic 35): PhabricatorEditEngineConfigurationQuery.loadPage has cyclomatic complexity 35 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/query/PhabricatorEditEngineConfigurationQuery.php"},"region":{"startLine":71}}}],"partialFingerprints":{"codehealthFindingId/v1":"e7de71ac190db92ebbf8a383562c811a3ec70e20d2d8f5f38009a67f6529405c"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorConduitAPIController.authenticateUser (cyclomatic 34): PhabricatorConduitAPIController.authenticateUser has cyclomatic complexity 34 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conduit/controller/PhabricatorConduitAPIController.php"},"region":{"startLine":167}}}],"partialFingerprints":{"codehealthFindingId/v1":"8f97b9f1437064d684eac8f395ee457795bab29f97c73e36702a0cc34bc7ed7c"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialChangesetOneUpRenderer.renderDocumentEngineBlocks (cyclomatic 34): DifferentialChangesetOneUpRenderer.renderDocumentEngineBlocks has cyclomatic complexity 34 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetOneUpRenderer.php"},"region":{"startLine":270}}}],"partialFingerprints":{"codehealthFindingId/v1":"f18a735cef36cead99ad8134c7b4a35f22e1e5133eca2c752b5f1c58279f660d"}},{"ruleId":"D1","level":"warning","message":{"text":"behavior-aphlict-dropdown.JX.behavior(\u0022aphlict-dropdown\u0022) (cyclomatic 34): behavior-aphlict-dropdown.JX.behavior(\u0022aphlict-dropdown\u0022) has cyclomatic complexity 34 (threshold 15). Most of this is not in the body itself: 5 of the 34 points are its own statements and the rest belongs to 9 function items inside it that branch (a function literal at line 178, update_counts, set_visible, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"a1249524e071b73cf7e1c426369d5ad592e319fe84088d2a2a7d4b15a93da4a2"}},{"ruleId":"D1","level":"warning","message":{"text":"(anonymous) (cyclomatic 34): (anonymous) has cyclomatic complexity 34 (threshold 15). Most of this is not in the body itself: 5 of the 34 points are its own statements and the rest belongs to 12 function items inside it that branch (a function literal at line 178, update_counts, set_visible, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"dee5bc74dee60f635ddb73a10a9e08a5439dedaaf4ad4781f81681b74d5d579b"}},{"ruleId":"D1","level":"warning","message":{"text":"ConpherenceThreadSearchEngine.loadContextMessages (cyclomatic 33): ConpherenceThreadSearchEngine.loadContextMessages has cyclomatic complexity 33 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/query/ConpherenceThreadSearchEngine.php"},"region":{"startLine":233}}}],"partialFingerprints":{"codehealthFindingId/v1":"83a8f84aee0db9cc3c16e986820525bddb24b26dd3ecb4332149d5bc47c20aa4"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorFactObjectController.handleRequest (cyclomatic 33): PhabricatorFactObjectController.handleRequest has cyclomatic complexity 33 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fact/controller/PhabricatorFactObjectController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"16eb78b01d48ceeff59d833dee6326a437f2d607fd78929f19ccdc8ae360bb25"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorInlineCommentController.processRequest (cyclomatic 33): PhabricatorInlineCommentController.processRequest has cyclomatic complexity 33 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/PhabricatorInlineCommentController.php"},"region":{"startLine":93}}}],"partialFingerprints":{"codehealthFindingId/v1":"023be7ddf08ebc87ff97c249c4867abed24e4161bbf5e3ca509ec3f38cfca703"}},{"ruleId":"D1","level":"warning","message":{"text":"ConpherenceUpdateController.handleRequest (cyclomatic 32): ConpherenceUpdateController.handleRequest has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceUpdateController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"d2bae04c26b5c91db742ee24ef8209592a0520406162304f551dbf8bef64769d"}},{"ruleId":"D1","level":"warning","message":{"text":"PhortunePaymentMethodCreateController.handleRequest (cyclomatic 32): PhortunePaymentMethodCreateController.handleRequest has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/paymentmethod/PhortunePaymentMethodCreateController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"34db68807278708eb7507131f0d88a94172b27c69f4756ecbcbc34688a3a7f66"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorProjectBoardViewController.handleRequest (cyclomatic 32): PhabricatorProjectBoardViewController.handleRequest has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectBoardViewController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"02f4d38ab66e5be2bc1c99f2741147de16303ab63c1a909838572a835c29953c"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorProjectColumnBulkMoveController.handleRequest (cyclomatic 32): PhabricatorProjectColumnBulkMoveController.handleRequest has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectColumnBulkMoveController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"64bfb114a54ed5aaf54344861809c4b97895d2259b5dfbc44de554e92f1387f8"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorRepositoryManagementThawWorkflow.execute (cyclomatic 32): PhabricatorRepositoryManagementThawWorkflow.execute has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/management/PhabricatorRepositoryManagementThawWorkflow.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"b733876ba937deceee3cb8ca166dcf4cceb10ab99aa44196745e92d8d9167d11"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorEditEngine.buildResponse (cyclomatic 32): PhabricatorEditEngine.buildResponse has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editengine/PhabricatorEditEngine.php"},"region":{"startLine":882}}}],"partialFingerprints":{"codehealthFindingId/v1":"0310610c7e397dc90364f0aa3563ede623285b8395c06fca2d2e928d80a78b63"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorEditEngine.buildCommentResponse (cyclomatic 32): PhabricatorEditEngine.buildCommentResponse has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editengine/PhabricatorEditEngine.php"},"region":{"startLine":1875}}}],"partialFingerprints":{"codehealthFindingId/v1":"3e48fbe4f52466b9b3a1b121fec05037169ac1b07fb0cecabde905426a49572e"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorAuthManagementStripWorkflow.execute (cyclomatic 31): PhabricatorAuthManagementStripWorkflow.execute has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/management/PhabricatorAuthManagementStripWorkflow.php"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"15bd9a8c55ab4c2e727aa7b4d682faae17c7184c4c461d4eb768214d83fae2cc"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialRevision.newReviewerForceAcceptMap (cyclomatic 31): DifferentialRevision.newReviewerForceAcceptMap has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialRevision.php"},"region":{"startLine":253}}}],"partialFingerprints":{"codehealthFindingId/v1":"664fe7fb1cd0e79f67c916cc683ec4187db9837f219c73510a1891b28654eaa0"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorRepositoryQuery.willFilterPage (cyclomatic 31): PhabricatorRepositoryQuery.willFilterPage has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/query/PhabricatorRepositoryQuery.php"},"region":{"startLine":236}}}],"partialFingerprints":{"codehealthFindingId/v1":"841d63a3cde64b23fc2cf71d6e9bc2aea0343cb1764fc41b8f4dfd3daf721ad4"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorAphlictManagementWorkflow.parseLaunchArguments (cyclomatic 30): PhabricatorAphlictManagementWorkflow.parseLaunchArguments has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"7904aa2a271d1010153c3dc6f4e7abe1630cd1e20dc31b30e5dad0b855e169f8"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorAuthSessionEngine.newHighSecurityToken (cyclomatic 30): PhabricatorAuthSessionEngine.newHighSecurityToken has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/engine/PhabricatorAuthSessionEngine.php"},"region":{"startLine":446}}}],"partialFingerprints":{"codehealthFindingId/v1":"d9828e7f8c09bd9b30beeb9eecdecb103c939df24298ea17d279c3e94f1ab358"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialChangesetEngine.detectCopiedCode (cyclomatic 30): DifferentialChangesetEngine.detectCopiedCode has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/engine/DifferentialChangesetEngine.php"},"region":{"startLine":162}}}],"partialFingerprints":{"codehealthFindingId/v1":"99405d1a60286210a1554223088c27df4d56fd201efc130ca539380b7517f76d"}},{"ruleId":"D1","level":"warning","message":{"text":"DiffusionCommitHookEngine.findMercurialChangegroupRefUpdates (cyclomatic 30): DiffusionCommitHookEngine.findMercurialChangegroupRefUpdates has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/engine/DiffusionCommitHookEngine.php"},"region":{"startLine":743}}}],"partialFingerprints":{"codehealthFindingId/v1":"e645b32fd45d0d4d147f6e76127231e05cb04b707ca2b8e33b1b8e86347f293d"}},{"ruleId":"D1","level":"warning","message":{"text":"HeraldAdapter.willSaveCondition (cyclomatic 30): HeraldAdapter.willSaveCondition has cyclomatic complexity 30 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform \u2014 the same kind of value, with no behaviour of its own \u2014 a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/adapter/HeraldAdapter.php"},"region":{"startLine":613}}}],"partialFingerprints":{"codehealthFindingId/v1":"e7d9ddceb3e5bb9bf26b2d974317bd70b079c26bd284c603fb19b81b70a4c7e4"}},{"ruleId":"D1","level":"warning","message":{"text":"LegalpadDocumentSignController.handleRequest (cyclomatic 30): LegalpadDocumentSignController.handleRequest has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/legalpad/controller/LegalpadDocumentSignController.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"dce4b0edf85ade5b9dc34a11f58fef882301ee72f04e2e673832e23ed9c6f811"}},{"ruleId":"D1","level":"warning","message":{"text":"ManiphestReportController.renderBurn (cyclomatic 30): ManiphestReportController.renderBurn has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/controller/ManiphestReportController.php"},"region":{"startLine":74}}}],"partialFingerprints":{"codehealthFindingId/v1":"85c7851f43bdd706f14c8b62f1c12eb6bc1c19cca5de073051e0f652d2d41fff"}},{"ruleId":"D1","level":"warning","message":{"text":"ManiphestReportController.renderOpenTasks (cyclomatic 30): ManiphestReportController.renderOpenTasks has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/controller/ManiphestReportController.php"},"region":{"startLine":487}}}],"partialFingerprints":{"codehealthFindingId/v1":"48bbfc896c70e4da440976c683614fab2cbb291569bb7a8db0a7c9a7f53d913d"}},{"ruleId":"D1","level":"warning","message":{"text":"ManiphestTransactionEditor.buildMoveTransaction (cyclomatic 30): ManiphestTransactionEditor.buildMoveTransaction has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/editor/ManiphestTransactionEditor.php"},"region":{"startLine":438}}}],"partialFingerprints":{"codehealthFindingId/v1":"54a731fa37699b6c18cbc8e11485cb4396f93e7c676659a04b7c2f88635d219d"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorApplicationQuery.loadPage (cyclomatic 30): PhabricatorApplicationQuery.loadPage has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/meta/query/PhabricatorApplicationQuery.php"},"region":{"startLine":71}}}],"partialFingerprints":{"codehealthFindingId/v1":"1c70cd3ab01ccb2abea805c6d3b26006501582aa94fd5ddae54ef858c346ebbd"}},{"ruleId":"D1","level":"warning","message":{"text":"PhortunePayPalPaymentProvider.processControllerRequest (cyclomatic 30): PhortunePayPalPaymentProvider.processControllerRequest has cyclomatic complexity 30 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform \u2014 the same kind of value, with no behaviour of its own \u2014 a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/provider/PhortunePayPalPaymentProvider.php"},"region":{"startLine":287}}}],"partialFingerprints":{"codehealthFindingId/v1":"19a5a203d0d29c2e0fbd4f6daf38666598fdf9d9beefb540b6786380bb41cddf"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorCursorPagedPolicyAwareQuery.buildFerretWhereClause (cyclomatic 30): PhabricatorCursorPagedPolicyAwareQuery.buildFerretWhereClause has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php"},"region":{"startLine":2208}}}],"partialFingerprints":{"codehealthFindingId/v1":"aca6907235de02803f1f26560e00897b948a71612d28f7b6b4d6b03d19324889"}},{"ruleId":"D1","level":"warning","message":{"text":"PHUIHeaderView.getTagContent (cyclomatic 30): PHUIHeaderView.getTagContent has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIHeaderView.php"},"region":{"startLine":190}}}],"partialFingerprints":{"codehealthFindingId/v1":"c5eacdfcaf78a7e844080f63602450bf5a8e95786d18095b44879642ef6a63cd"}},{"ruleId":"D1","level":"warning","message":{"text":"_update (cyclomatic 30): _update has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/phuix/PHUIXAutocomplete.js"},"region":{"startLine":428}}}],"partialFingerprints":{"codehealthFindingId/v1":"7d3103e9d5513fde32bf2ef613f5a7374ec1c1ebd944bab3ae3c24c920f6d36d"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorCalendarEventQuery.willFilterPage (cyclomatic 29): PhabricatorCalendarEventQuery.willFilterPage has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/query/PhabricatorCalendarEventQuery.php"},"region":{"startLine":515}}}],"partialFingerprints":{"codehealthFindingId/v1":"5eaf4da9d7f6414eaffea2340f14e2e7f7d368e694b69b9bb9ab3351dcd4db00"}},{"ruleId":"D1","level":"warning","message":{"text":"DiffusionBrowseQueryConduitAPIMethod.getGitResult (cyclomatic 29): DiffusionBrowseQueryConduitAPIMethod.getGitResult has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"0c51db66cf198dae0f9b22811662917e714e464a807af76406f1f3d160795af7"}},{"ruleId":"D1","level":"warning","message":{"text":"PassphraseCredentialEditController.handleRequest (cyclomatic 29): PassphraseCredentialEditController.handleRequest has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/passphrase/controller/PassphraseCredentialEditController.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"7081ce373f9830bcc8355d8473ba62f05c9cc0761c4ca309abf7e6e7bafb9bcc"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorProjectQuery.buildWhereClauseParts (cyclomatic 29): PhabricatorProjectQuery.buildWhereClauseParts has cyclomatic complexity 29 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/query/PhabricatorProjectQuery.php"},"region":{"startLine":457}}}],"partialFingerprints":{"codehealthFindingId/v1":"b5ecbd2f34c5f732d10a28f59141dbb168aaecd949f16276dfd454105ba72456"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorApplicationTransactionView.renderEvent (cyclomatic 29): PhabricatorApplicationTransactionView.renderEvent has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/view/PhabricatorApplicationTransactionView.php"},"region":{"startLine":422}}}],"partialFingerprints":{"codehealthFindingId/v1":"a9612d8ceb2987ce50dc7dd04248b605a65c4a88ff5c79003b873f5eb5ec0a60"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorTypeaheadModularDatasourceController.handleRequest (cyclomatic 29): PhabricatorTypeaheadModularDatasourceController.handleRequest has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"839e2906f010ed98c572149c5eeebfb835adfe909fd8f4f2ceb301ed616c1ba0"}},{"ruleId":"D1","level":"warning","message":{"text":"behavior-phabricator-remarkup-assist.JX.behavior(\u0022phabricator-remarkup-assist\u0022)::assist (cyclomatic 29): behavior-phabricator-remarkup-assist.JX.behavior(\u0022phabricator-remarkup-assist\u0022)::assist has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js"},"region":{"startLine":188}}}],"partialFingerprints":{"codehealthFindingId/v1":"dc4c3b2f946c71e39bba47644c6fd36880a65bfe31204b08b36e4e4aa322f6af"}},{"ruleId":"D1","level":"warning","message":{"text":"(anonymous)::assist (cyclomatic 29): (anonymous)::assist has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js"},"region":{"startLine":188}}}],"partialFingerprints":{"codehealthFindingId/v1":"ec29dcb59d82c8f9bff66ca296e093d61ba7783db3b4806f1ea72ff46a0f1621"}},{"ruleId":"D1","level":"warning","message":{"text":"PhutilSpriteSheet.generate (cyclomatic 28): PhutilSpriteSheet.generate has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/sprite/PhutilSpriteSheet.php"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"f7df44a609a9d8069d49ae71971ec49f567eaaee7de589da3f99cb5a46c47d64"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorCalendarNotificationEngine.sendNotifications (cyclomatic 28): PhabricatorCalendarNotificationEngine.sendNotifications has cyclomatic complexity 28 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/notifications/PhabricatorCalendarNotificationEngine.php"},"region":{"startLine":73}}}],"partialFingerprints":{"codehealthFindingId/v1":"630a1e0b64133970aeff9419f6664f4e8b5487e598b6a33670b805c672d0d856"}},{"ruleId":"D1","level":"warning","message":{"text":"DivinerAtomController.handleRequest (cyclomatic 28): DivinerAtomController.handleRequest has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/controller/DivinerAtomController.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"830878b4bbb7708694a32caa3d66524722137f8d455793750eab0e9f02de1c7b"}},{"ruleId":"D1","level":"warning","message":{"text":"DoorkeeperAsanaFeedWorker.publishFeedStory (cyclomatic 28): DoorkeeperAsanaFeedWorker.publishFeedStory has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/worker/DoorkeeperAsanaFeedWorker.php"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"10390f2dc4aedb6424df43cd97f492756ebcdd8613be13ba3d3e12e2bd7fc3ad"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorMailManagementShowOutboundWorkflow.execute (cyclomatic 28): PhabricatorMailManagementShowOutboundWorkflow.execute has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/management/PhabricatorMailManagementShowOutboundWorkflow.php"},"region":{"startLine":29}}}],"partialFingerprints":{"codehealthFindingId/v1":"3fd406b8d230878d6a3e6b9a7b8f7b373d57cfee6845f1607a9b51343639db94"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorMetaMTAMail.loadActors (cyclomatic 28): PhabricatorMetaMTAMail.loadActors has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/storage/PhabricatorMetaMTAMail.php"},"region":{"startLine":895}}}],"partialFingerprints":{"codehealthFindingId/v1":"ac4002993aeef94816b88e270eb38be2a8a6ef197dc2770020506a48d267acdd"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorPeopleNewController.handleRequest (cyclomatic 28): PhabricatorPeopleNewController.handleRequest has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/controller/PhabricatorPeopleNewController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"671984bb0df5dbcf95d3c74fd72eda5dc0900afa9a913dfca44c6b0d147648e3"}},{"ruleId":"D1","level":"warning","message":{"text":"PhrictionDocumentController.handleRequest (cyclomatic 28): PhrictionDocumentController.handleRequest has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/controller/PhrictionDocumentController.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"204a2cbb967bad783b3cafa19c4686f604e3260303883c2d3cdd68aaeae80b6f"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorBoardLayoutEngine.layoutBoard (cyclomatic 28): PhabricatorBoardLayoutEngine.layoutBoard has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/engine/PhabricatorBoardLayoutEngine.php"},"region":{"startLine":422}}}],"partialFingerprints":{"codehealthFindingId/v1":"bea0b781cd605f198cee6347442c0474908bc15b3e60df31b9300b277658e5d5"}},{"ruleId":"D1","level":"warning","message":{"text":"PhutilRemarkupListBlockRule.renderTree (cyclomatic 28): PhutilRemarkupListBlockRule.renderTree has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/blockrule/PhutilRemarkupListBlockRule.php"},"region":{"startLine":428}}}],"partialFingerprints":{"codehealthFindingId/v1":"13058080b1b016453d0e230f255dbc56499715b9a5b8ad7c69ccba3d44ca8e9f"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorPolicyAwareQuery.execute (cyclomatic 28): PhabricatorPolicyAwareQuery.execute has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php"},"region":{"startLine":204}}}],"partialFingerprints":{"codehealthFindingId/v1":"9f083a81c402603db5b4d09d4f947684038c06928a43bcc0b45ef6c5a8388269"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorSQLPatchList.buildAllPatches (cyclomatic 28): PhabricatorSQLPatchList.buildAllPatches has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/patch/PhabricatorSQLPatchList.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"bf4311df6a374b31ccfb313383008eb7f4d602e3ef2a5fa642252f2a13aa5292"}},{"ruleId":"D1","level":"warning","message":{"text":"PHUITimelineEventView.render (cyclomatic 28): PHUITimelineEventView.render has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUITimelineEventView.php"},"region":{"startLine":318}}}],"partialFingerprints":{"codehealthFindingId/v1":"e9222c7c013876915ca806c6f3bdd00bcef13d3661845299a71c3e0d26bfb1a2"}},{"ruleId":"D1","level":"warning","message":{"text":"behavior-lightbox-attachments.JX.behavior(\u0022lightbox-attachments\u0022) (cyclomatic 28): behavior-lightbox-attachments.JX.behavior(\u0022lightbox-attachments\u0022) has cyclomatic complexity 28 (threshold 15). Most of this is not in the body itself: 1 of the 28 points is its own statement and the rest belongs to 6 function items inside it that branch (activateLightbox, lightBoxHandleKeyDown, loadLightBox, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-lightbox-attachments.js"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"f1789f04d701b8646d01fe1c080de43bad9c7543d0083744c2578becf1edfb37"}},{"ruleId":"D1","level":"warning","message":{"text":"(anonymous) (cyclomatic 28): (anonymous) has cyclomatic complexity 28 (threshold 15). Most of this is not in the body itself: 1 of the 28 points is its own statement and the rest belongs to 13 function items inside it that branch (activateLightbox, lightBoxHandleKeyDown, loadLightBox, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-lightbox-attachments.js"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"1db79e167d870b769c1611f9040657abe2ad07d759133407e79525a03bbe69f3"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorAuditManagementDeleteWorkflow.execute (cyclomatic 27): PhabricatorAuditManagementDeleteWorkflow.execute has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/management/PhabricatorAuditManagementDeleteWorkflow.php"},"region":{"startLine":62}}}],"partialFingerprints":{"codehealthFindingId/v1":"b7d7ef271a07796c7d6c255c1b253e7bbf51a3dab14ef7378367816f57731310"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorAuditTransaction.getTitle (cyclomatic 27): PhabricatorAuditTransaction.getTitle has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/storage/PhabricatorAuditTransaction.php"},"region":{"startLine":162}}}],"partialFingerprints":{"codehealthFindingId/v1":"834485162e3e294c4354eb4ac4c5b19487a539c99bef2693c2e579246bc99aeb"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorAuthStartController.handleRequest (cyclomatic 27): PhabricatorAuthStartController.handleRequest has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthStartController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"cfddd38e282510ac6dacae254f88725b6c8820c23ba27816d6e84f64394771d6"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorAuthEditController.handleRequest (cyclomatic 27): PhabricatorAuthEditController.handleRequest has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/config/PhabricatorAuthEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"124a3c4e73d343051e3468ad29c1f6b4e0aff7165ab9a7c327d738d31fe56899"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorWebServerSetupCheck.executeChecks (cyclomatic 27): PhabricatorWebServerSetupCheck.executeChecks has cyclomatic complexity 27 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/check/PhabricatorWebServerSetupCheck.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"7d0436624774521ded11640abab9a122cf854c9f0bb0358f250479caa796ea30"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialChangesetOneUpRenderer.renderPrimitives (cyclomatic 27): DifferentialChangesetOneUpRenderer.renderPrimitives has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetOneUpRenderer.php"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"d214036b1db43c315895cc8ad50df6ba11f5447e6eae64b28cf4b2497421a8b6"}},{"ruleId":"D1","level":"warning","message":{"text":"HarbormasterBuildEngine.updateBuildSteps (cyclomatic 27): HarbormasterBuildEngine.updateBuildSteps has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/engine/HarbormasterBuildEngine.php"},"region":{"startLine":165}}}],"partialFingerprints":{"codehealthFindingId/v1":"a5485d54c541504a752e567e573f0634ed718d7bb2c4766ebfb1827c645aac11"}},{"ruleId":"D1","level":"warning","message":{"text":"PhutilXHPASTSyntaxHighlighterFuture.applyXHPHighlight (cyclomatic 27): PhutilXHPASTSyntaxHighlighterFuture.applyXHPHighlight has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/syntax/highlighter/xhpast/PhutilXHPASTSyntaxHighlighterFuture.php"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"65039428f8e7258a5b1ef4da4be0dc87f49a8d33ee5086dc29237b80f1cbd13b"}},{"ruleId":"D1","level":"warning","message":{"text":"behavior-day-view.JX.behavior(\u0022day-view\u0022) (cyclomatic 27): behavior-day-view.JX.behavior(\u0022day-view\u0022) has cyclomatic complexity 27 (threshold 15). Most of this is not in the body itself: 2 of the 27 points are its own statements and the rest belongs to 10 function items inside it that branch (findTodayClusters, updateEventsFromCluster, drawRows, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/calendar/behavior-day-view.js"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"66acdbe80d418c6351032a7d3219e7cd621841d03b4400c77985d8d872a58378"}},{"ruleId":"D1","level":"warning","message":{"text":"behavior-comment-actions.JX.behavior(\u0022comment-actions\u0022) (cyclomatic 27): behavior-comment-actions.JX.behavior(\u0022comment-actions\u0022) has cyclomatic complexity 27 (threshold 15). Most of this is not in the body itself: 3 of the 27 points are its own statements and the rest belongs to 11 function items inside it that branch (add_row, find_option, redraw, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/transactions/behavior-comment-actions.js"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"658ad80dd2ad80b2cdc570094011b662844f4ff121c56ea8551eede97fc2b778"}},{"ruleId":"D1","level":"warning","message":{"text":"(anonymous) (cyclomatic 27): (anonymous) has cyclomatic complexity 27 (threshold 15). Most of this is not in the body itself: 2 of the 27 points are its own statements and the rest belongs to 12 function items inside it that branch (findTodayClusters, updateEventsFromCluster, drawRows, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/calendar/behavior-day-view.js"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"5638318c1b115f40a4acdd29536f6ac14a79412fb7dddf5ec9f542fbd087a58d"}},{"ruleId":"D1","level":"warning","message":{"text":"(anonymous) (cyclomatic 27): (anonymous) has cyclomatic complexity 27 (threshold 15). Most of this is not in the body itself: 3 of the 27 points are its own statements and the rest belongs to 15 function items inside it that branch (add_row, find_option, redraw, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/transactions/behavior-comment-actions.js"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"1122f94de87755adfc0a97f140d1ea9fb0a9ea95314ea76a3fb83dad9e8a0415"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorCalendarEventQuery.loadPage (cyclomatic 26): PhabricatorCalendarEventQuery.loadPage has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/query/PhabricatorCalendarEventQuery.php"},"region":{"startLine":161}}}],"partialFingerprints":{"codehealthFindingId/v1":"30a674e010818fa4e5d6ff8a2dd424e2846f489064e39cf6b894a78056b0379f"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialHunkParser.parseHunksForHighlightMasks (cyclomatic 26): DifferentialHunkParser.parseHunksForHighlightMasks has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialHunkParser.php"},"region":{"startLine":566}}}],"partialFingerprints":{"codehealthFindingId/v1":"80b113a92935f225c1114ea5f9ad6f92a3e5637baa426a4a0a2bdc4ef3877379"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialReviewersView.render (cyclomatic 26): DifferentialReviewersView.render has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/view/DifferentialReviewersView.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"eec1d5feeb763a0ec96f9e8045b3497680b3776fd5d1c3cb21682ea514f0b2d1"}},{"ruleId":"D1","level":"warning","message":{"text":"DiffusionCommitController.buildPropertyListView (cyclomatic 26): DiffusionCommitController.buildPropertyListView has cyclomatic complexity 26 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionCommitController.php"},"region":{"startLine":524}}}],"partialFingerprints":{"codehealthFindingId/v1":"875e8a9275c93ac6e511f5a70359e43debd9a9f7686126846713ac410d7f8ce6"}},{"ruleId":"D1","level":"warning","message":{"text":"MultimeterSampleController.handleRequest (cyclomatic 26): MultimeterSampleController.handleRequest has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/multimeter/controller/MultimeterSampleController.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"513cbe64038f5090b18677526ea618e6ede1273a0336494089080735b3e3fc2a"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorObjectListQuery.execute (cyclomatic 26): PhabricatorObjectListQuery.execute has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phid/query/PhabricatorObjectListQuery.php"},"region":{"startLine":56}}}],"partialFingerprints":{"codehealthFindingId/v1":"ba10f837c6a050a87f45207c39a171ab86265f2a10b4ba332a5284da159869c9"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorApplicationTransactionEditor.getTransactionOldValue (cyclomatic 26): PhabricatorApplicationTransactionEditor.getTransactionOldValue has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":490}}}],"partialFingerprints":{"codehealthFindingId/v1":"3576b00d06218467c498ec17f47e3bc326882c4c96e0e4e22d1ae69eca4f6000"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorDifferenceEngine.applyIntralineDiff (cyclomatic 26): PhabricatorDifferenceEngine.applyIntralineDiff has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/PhabricatorDifferenceEngine.php"},"region":{"startLine":172}}}],"partialFingerprints":{"codehealthFindingId/v1":"983ad5d3268779dd1c9659c8a40f8543a22d4b99fe80d9199f7b558c3a367d6d"}},{"ruleId":"D1","level":"warning","message":{"text":"PHUIDiffTableOfContentsListView.render (cyclomatic 26): PHUIDiffTableOfContentsListView.render has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/view/PHUIDiffTableOfContentsListView.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"0b2bf4fd4509c42fe951e7d68c30fa6940166720c1154cc6ff118fc38a246064"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorCursorPagedPolicyAwareQuery.buildSpacesWhereClause (cyclomatic 26): PhabricatorCursorPagedPolicyAwareQuery.buildSpacesWhereClause has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php"},"region":{"startLine":3139}}}],"partialFingerprints":{"codehealthFindingId/v1":"8d40f152ab3f600a6c6f7f5b7e55871d720e734d1c96b97d66df3ac4144f0672"}},{"ruleId":"D1","level":"warning","message":{"text":"start (cyclomatic 26): start has cyclomatic complexity 26 (threshold 15). Most of this is not in the body itself: 4 of the 26 points are its own statements and the rest belongs to 7 function items inside it that branch (a function literal at line 185, a function literal at line 105, contains, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/DragAndDropFileUpload.js"},"region":{"startLine":75}}}],"partialFingerprints":{"codehealthFindingId/v1":"9d7b00f002c0c1424b41aa3f1534fb12f35011ac73dc10bed5cf954dd6603c16"}},{"ruleId":"D1","level":"warning","message":{"text":"updateCard (cyclomatic 26): updateCard has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/projects/WorkboardBoard.js"},"region":{"startLine":601}}}],"partialFingerprints":{"codehealthFindingId/v1":"c171987abec574c541f672db29bb4e6bb69543fcb6ba3f6798b0523898519868"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorAuthManagementRevokeWorkflow.execute (cyclomatic 25): PhabricatorAuthManagementRevokeWorkflow.execute has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/management/PhabricatorAuthManagementRevokeWorkflow.php"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"ab93e4a678bd9736eb8d0139e9b0292dcd876fd609dfb9afaf07c80334ac24aa"}},{"ruleId":"D1","level":"warning","message":{"text":"PhutilCalendarRecurrenceSet.getEventsBetween (cyclomatic 25): PhutilCalendarRecurrenceSet.getEventsBetween has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/data/PhutilCalendarRecurrenceSet.php"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"1ab6cc811738e0dc4239e4776eb29461f65cc76b2857ce9c84f0fea35d3a3e46"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialHunkParser.makeContextDiff (cyclomatic 25): DifferentialHunkParser.makeContextDiff has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialHunkParser.php"},"region":{"startLine":665}}}],"partialFingerprints":{"codehealthFindingId/v1":"8a81b7ab340eea376601636d784f4bbf51900eccc7a029bf6e35008bea6112c4"}},{"ruleId":"D1","level":"warning","message":{"text":"DivinerAtomQuery.willFilterPage (cyclomatic 25): DivinerAtomQuery.willFilterPage has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/query/DivinerAtomQuery.php"},"region":{"startLine":139}}}],"partialFingerprints":{"codehealthFindingId/v1":"f1266a4f6a7a499252dc9c51a80d5e7a30d43dc551a4c0ad85990cbe1731f8eb"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorFeedStory.loadAllFromRows (cyclomatic 25): PhabricatorFeedStory.loadAllFromRows has cyclomatic complexity 25 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/feed/story/PhabricatorFeedStory.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"c3f36c0d4da0254210cf4e392412f57e3f814c52b587d2532b42fb0c1e17e95a"}},{"ruleId":"D1","level":"warning","message":{"text":"ManiphestTaskSearchEngine.buildQueryFromParameters (cyclomatic 25): ManiphestTaskSearchEngine.buildQueryFromParameters has cyclomatic complexity 25 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/query/ManiphestTaskSearchEngine.php"},"region":{"startLine":190}}}],"partialFingerprints":{"codehealthFindingId/v1":"5a8728c599b704240bb870bb1b9c3f703637cb88b23c0f0eb1c331df137e3d99"}},{"ruleId":"D1","level":"warning","message":{"text":"PholioMockEditController.handleRequest (cyclomatic 25): PholioMockEditController.handleRequest has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/pholio/controller/PholioMockEditController.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"cc2c32b217b5633136f358828846b81c1b13a2b6d3681596705c37be48def6c8"}},{"ruleId":"D1","level":"warning","message":{"text":"PhrequentTimeBlock.getObjectTimeRanges (cyclomatic 25): PhrequentTimeBlock.getObjectTimeRanges has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phrequent/storage/PhrequentTimeBlock.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"bc1239b4b7764bea700d67b5347cdb383390b3b2e4c0e4587e19afb0b3243f0b"}},{"ruleId":"D1","level":"warning","message":{"text":"PhrictionRemarkupRule.didMarkupText (cyclomatic 25): PhrictionRemarkupRule.didMarkupText has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/markup/PhrictionRemarkupRule.php"},"region":{"startLine":86}}}],"partialFingerprints":{"codehealthFindingId/v1":"6a13e837a871bf895b36737afa422e1fecae24b414222b919cc845a502125d24"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorPolicyEditController.handleRequest (cyclomatic 25): PhabricatorPolicyEditController.handleRequest has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/controller/PhabricatorPolicyEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"05e6c062a8f6251c0b86c9e449ca312db13b08917fadec4ae38b85f5d717ba52"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorPolicyFilter.apply (cyclomatic 25): PhabricatorPolicyFilter.apply has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/filter/PhabricatorPolicyFilter.php"},"region":{"startLine":156}}}],"partialFingerprints":{"codehealthFindingId/v1":"9fc961e95c43d71cb15fd6d2d28f19b6b1ac4e372ced1c1ae2adc195ba79a651"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorRepositoryQuery.buildWhereClauseParts (cyclomatic 25): PhabricatorRepositoryQuery.buildWhereClauseParts has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/query/PhabricatorRepositoryQuery.php"},"region":{"startLine":533}}}],"partialFingerprints":{"codehealthFindingId/v1":"7b236289bd2af7e3a5413ad40b428092d76a861cbe1251f9defd168aa525aa74"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorFerretFulltextEngineExtension.indexFulltextObject (cyclomatic 25): PhabricatorFerretFulltextEngineExtension.indexFulltextObject has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engineextension/PhabricatorFerretFulltextEngineExtension.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"0a245f71fb0932990574f675d3b640b97d0596840ac69be6309227bdea008b05"}},{"ruleId":"D1","level":"warning","message":{"text":"PHUIDiffGraphView.renderRawGraph (cyclomatic 25): PHUIDiffGraphView.renderRawGraph has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/view/PHUIDiffGraphView.php"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"ac0a768bd29cd6fc4fdaafada150c45ca85852ef201a953db6b0acd315956c73"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorCursorPagedPolicyAwareQuery.buildFerretJoinClause (cyclomatic 25): PhabricatorCursorPagedPolicyAwareQuery.buildFerretJoinClause has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php"},"region":{"startLine":1995}}}],"partialFingerprints":{"codehealthFindingId/v1":"268b405b65d03cf57da83c08b1f7175f41ef6d61fadb1c6114b189776486f67c"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorActionView.render (cyclomatic 25): PhabricatorActionView.render has cyclomatic complexity 25 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/layout/PhabricatorActionView.php"},"region":{"startLine":198}}}],"partialFingerprints":{"codehealthFindingId/v1":"0e15816a53f6892724ce1f9db1e567ddcbb75d9a1f7ff34f7e51a50f25cc83e1"}},{"ruleId":"D1","level":"warning","message":{"text":"behavior-search-typeahead.JX.behavior(\u0022phabricator-search-typeahead\u0022) (cyclomatic 25): behavior-search-typeahead.JX.behavior(\u0022phabricator-search-typeahead\u0022) has cyclomatic complexity 25 (threshold 15). Most of this is not in the body itself: 1 of the 25 points is its own statement and the rest belongs to 6 function items inside it that branch (sort_handler, a function literal at line 217, transform, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-search-typeahead.js"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"2aad0022ee754b8c018f1958b5d7e37aedab004497c9bfb62c083c6ea1630954"}},{"ruleId":"D1","level":"warning","message":{"text":"(anonymous) (cyclomatic 25): (anonymous) has cyclomatic complexity 25 (threshold 15). Most of this is not in the body itself: 1 of the 25 points is its own statement and the rest belongs to 12 function items inside it that branch (sort_handler, a function literal at line 217, transform, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-search-typeahead.js"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"0cbb66d662d536e8449cade9d4b807bbcf41c0205809ca94d7f42616538303b6"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialQueryConduitAPIMethod.execute (cyclomatic 24): DifferentialQueryConduitAPIMethod.execute has cyclomatic complexity 24 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php"},"region":{"startLine":65}}}],"partialFingerprints":{"codehealthFindingId/v1":"3cb410e18ab9097641196f69cc5a6c8de45436064ccd7dc96057c4ae75a7d659"}},{"ruleId":"D1","level":"warning","message":{"text":"DiffusionBrowseQueryConduitAPIMethod.getSVNResult (cyclomatic 24): DiffusionBrowseQueryConduitAPIMethod.getSVNResult has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php"},"region":{"startLine":363}}}],"partialFingerprints":{"codehealthFindingId/v1":"0d46ea333405167868931493e30f08976968c2f449fc9dfbd78b6ab76e9e25f9"}},{"ruleId":"D1","level":"warning","message":{"text":"DiffusionCommitQuery.didFilterPage (cyclomatic 24): DiffusionCommitQuery.didFilterPage has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/DiffusionCommitQuery.php"},"region":{"startLine":361}}}],"partialFingerprints":{"codehealthFindingId/v1":"a4c0c67dac327c6ef99d7ceb69c1a2c5026b4a21acaf89b6f9e5ec1a7c364d3d"}},{"ruleId":"D1","level":"warning","message":{"text":"HarbormasterBuildViewController.handleRequest (cyclomatic 24): HarbormasterBuildViewController.handleRequest has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterBuildViewController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"3ed08f806f78dd5262e34b61bca1e3a8a2cb7f424a6be6333fe0ef6ea7bdb2d4"}},{"ruleId":"D1","level":"warning","message":{"text":"HeraldEngine.getRuleMatchResult (cyclomatic 24): HeraldEngine.getRuleMatchResult has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/engine/HeraldEngine.php"},"region":{"startLine":379}}}],"partialFingerprints":{"codehealthFindingId/v1":"0929fe38132eed3072ccec8ccd634ff057a427e4d81d68fd418077e0f1959447"}},{"ruleId":"D1","level":"warning","message":{"text":"ManiphestTaskQuery.buildWhereClauseParts (cyclomatic 24): ManiphestTaskQuery.buildWhereClauseParts has cyclomatic complexity 24 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/query/ManiphestTaskQuery.php"},"region":{"startLine":354}}}],"partialFingerprints":{"codehealthFindingId/v1":"b69b796239710b146f27ac0708b7e2664b4969a9348e14c66f885427ba024e45"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorMetaMTAMailViewController.buildDeliveryProperties (cyclomatic 24): PhabricatorMetaMTAMailViewController.buildDeliveryProperties has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/controller/PhabricatorMetaMTAMailViewController.php"},"region":{"startLine":216}}}],"partialFingerprints":{"codehealthFindingId/v1":"203cd3b56289473372be40bd57897117bf2a7e3aa2afae888d8136b8ca89cbaf"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorMailEmailEngine.newMessage (cyclomatic 24): PhabricatorMailEmailEngine.newMessage has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/engine/PhabricatorMailEmailEngine.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"386bfe137b3f767936e659a336d9d1a6366703d02b9a394093b327748f298adf"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorMetaMTAReceivedMail.processReceivedMail (cyclomatic 24): PhabricatorMetaMTAReceivedMail.processReceivedMail has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php"},"region":{"startLine":146}}}],"partialFingerprints":{"codehealthFindingId/v1":"fd14323bb74de4684902cd48f028357bd09e57e6bf648acfe76a264d2817e38c"}},{"ruleId":"D1","level":"warning","message":{"text":"PassphraseQueryConduitAPIMethod.execute (cyclomatic 24): PassphraseQueryConduitAPIMethod.execute has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/passphrase/conduit/PassphraseQueryConduitAPIMethod.php"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"8d06265249888c300f7b4df9341d117b540052da27eb0496e622b095ee2acf93"}},{"ruleId":"D1","level":"warning","message":{"text":"PhrictionEditController.handleRequest (cyclomatic 24): PhrictionEditController.handleRequest has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/controller/PhrictionEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"5c563def76d465095a5b58e44309070d1da282421356b9251d33c12528c3617a"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorPolicyFilter.checkCapability (cyclomatic 24): PhabricatorPolicyFilter.checkCapability has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/filter/PhabricatorPolicyFilter.php"},"region":{"startLine":502}}}],"partialFingerprints":{"codehealthFindingId/v1":"decd79f4701f2aea32d5fa755d56583e1978875a027d39cc485a827024d7f734"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorProjectQuery.willFilterPage (cyclomatic 24): PhabricatorProjectQuery.willFilterPage has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/query/PhabricatorProjectQuery.php"},"region":{"startLine":239}}}],"partialFingerprints":{"codehealthFindingId/v1":"72a5716c3184cf34018a5d491baa73b9d26befa4ec54bd2b0d063dcaa99e2032"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorProjectSearchEngine.buildQueryFromParameters (cyclomatic 24): PhabricatorProjectSearchEngine.buildQueryFromParameters has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/query/PhabricatorProjectSearchEngine.php"},"region":{"startLine":130}}}],"partialFingerprints":{"codehealthFindingId/v1":"5570097cfedffbed91ac81349209ca906eb1cd5c6dc5fa2304fdf3210830e631"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorRepositoryPullLocalDaemon.run (cyclomatic 24): PhabricatorRepositoryPullLocalDaemon.run has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"10e3172728296d2eee0101b533a591ba4c381aa1eb023af45e8dc4cfae43b6d4"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorDatabaseRefParser.newRefs (cyclomatic 24): PhabricatorDatabaseRefParser.newRefs has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/cluster/PhabricatorDatabaseRefParser.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"3fcb975312b49eda7771a9c8985b3c6c75c749dfa8e4b02675c039bf78577535"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorStorageManagementRenamespaceWorkflow.didExecute (cyclomatic 24): PhabricatorStorageManagementRenamespaceWorkflow.didExecute has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/management/workflow/PhabricatorStorageManagementRenamespaceWorkflow.php"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"ce8dcff536cfef421e9bf72da664354beb24c4e6dcee499518b73b2c0f44c93e"}},{"ruleId":"D1","level":"warning","message":{"text":"_onjumpkey (cyclomatic 24): _onjumpkey has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":650}}}],"partialFingerprints":{"codehealthFindingId/v1":"2820215f3b1f33f45f23883936d46bddd6ef67c1e897a2ae013dc84bee44d25f"}},{"ruleId":"D1","level":"warning","message":{"text":"AphrontMultipartParser.continueParse (cyclomatic 23): AphrontMultipartParser.continueParse has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/multipartparser/AphrontMultipartParser.php"},"region":{"startLine":62}}}],"partialFingerprints":{"codehealthFindingId/v1":"893eda9c79a9f99524dc3a6b396a69e610995e09a9031401543be967624cc0a0"}},{"ruleId":"D1","level":"warning","message":{"text":"PhutilICSParser.unescapeFieldValue (cyclomatic 23): PhutilICSParser.unescapeFieldValue has cyclomatic complexity 23 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform \u2014 the same kind of value, with no behaviour of its own \u2014 a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/ics/PhutilICSParser.php"},"region":{"startLine":386}}}],"partialFingerprints":{"codehealthFindingId/v1":"cd35ad54f2f6868499a81af87394f5d1b1d62c0f955277cf635cdbfc6c2c1067"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialTransactionEditor.didApplyHeraldRules (cyclomatic 23): DifferentialTransactionEditor.didApplyHeraldRules has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/editor/DifferentialTransactionEditor.php"},"region":{"startLine":1034}}}],"partialFingerprints":{"codehealthFindingId/v1":"5acb415a9dd1d5100a10ebe1404397bee3700827609dec102650ed87c4b2139f"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialChangesetTwoUpRenderer.renderDocumentEngineBlocks (cyclomatic 23): DifferentialChangesetTwoUpRenderer.renderDocumentEngineBlocks has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php"},"region":{"startLine":368}}}],"partialFingerprints":{"codehealthFindingId/v1":"2a30d45255706707709cf5126031134e12434ba1179d06ebf229b76e3ecc9258"}},{"ruleId":"D1","level":"warning","message":{"text":"DiffusionLowLevelResolveRefsQuery.resolveGitRefs (cyclomatic 23): DiffusionLowLevelResolveRefsQuery.resolveGitRefs has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/lowlevel/DiffusionLowLevelResolveRefsQuery.php"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"667e781508fd0d0f5f9cdbaa626ad3bae68d94ac5a179bede5b7582459b96ad3"}},{"ruleId":"D1","level":"warning","message":{"text":"DivinerAtomController.renderFullSignature (cyclomatic 23): DivinerAtomController.renderFullSignature has cyclomatic complexity 23 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform \u2014 the same kind of value, with no behaviour of its own \u2014 a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/controller/DivinerAtomController.php"},"region":{"startLine":479}}}],"partialFingerprints":{"codehealthFindingId/v1":"0ef9bccce1e05535ccf8c6e0b3e6fcbc4223b0c2a56c2543449ad9c8aeda441e"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorFileViewController.buildPropertyViews (cyclomatic 23): PhabricatorFileViewController.buildPropertyViews has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/controller/PhabricatorFileViewController.php"},"region":{"startLine":218}}}],"partialFingerprints":{"codehealthFindingId/v1":"3097306393691701e47b24f8e2c41e152cab3b98282ed22d5ae585cb16956843"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorEmbedFileRemarkupRule.renderImageFile (cyclomatic 23): PhabricatorEmbedFileRemarkupRule.renderImageFile has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php"},"region":{"startLine":129}}}],"partialFingerprints":{"codehealthFindingId/v1":"967a368db21b951f4968be329edb6985f5ff5e8b3e3e505e1a240241532b899d"}},{"ruleId":"D1","level":"warning","message":{"text":"HeraldRuleQuery.willFilterPage (cyclomatic 23): HeraldRuleQuery.willFilterPage has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/query/HeraldRuleQuery.php"},"region":{"startLine":89}}}],"partialFingerprints":{"codehealthFindingId/v1":"b4b3ecee06341621ef0a2dd3d0239a35931eaf7852cb21b3131aee877f82af22"}},{"ruleId":"D1","level":"warning","message":{"text":"ManiphestTaskDetailController.newChangesView (cyclomatic 23): ManiphestTaskDetailController.newChangesView has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/controller/ManiphestTaskDetailController.php"},"region":{"startLine":545}}}],"partialFingerprints":{"codehealthFindingId/v1":"f7e61caadab6521a5a2026d2a63fb454bb7ec6b742fd9fd047de3d142dd791b4"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorOwnersPackage.findLongestPathsPerPackage (cyclomatic 23): PhabricatorOwnersPackage.findLongestPathsPerPackage has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/owners/storage/PhabricatorOwnersPackage.php"},"region":{"startLine":378}}}],"partialFingerprints":{"codehealthFindingId/v1":"5c88bd878ec1f8027a22726de3250bd3a22191f6b283a682f04f93f3a0cbbc35"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorPeopleProfilePictureController.handleRequest (cyclomatic 23): PhabricatorPeopleProfilePictureController.handleRequest has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/controller/PhabricatorPeopleProfilePictureController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"2165f05a6e7ea1ef059417f3a51bef2a10191b4d8a41be7417da3225b5fe7c36"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorProjectDatasource.loadResults (cyclomatic 23): PhabricatorProjectDatasource.loadResults has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/typeahead/PhabricatorProjectDatasource.php"},"region":{"startLine":18}}}],"partialFingerprints":{"codehealthFindingId/v1":"a97545141f9def8607353f503c3e9c7bd4350f55411ce0045c182e041d352bb7"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorRepositoryGitCommitChangeParserWorker.parseCommitChanges (cyclomatic 23): PhabricatorRepositoryGitCommitChangeParserWorker.parseCommitChanges has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryGitCommitChangeParserWorker.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"b77f68cd95bddab6a3d4fa43cfc6a54abf37009554966f414c4a6910bd9f8689"}},{"ruleId":"D1","level":"warning","message":{"text":"TransactionSearchConduitAPIMethod.execute (cyclomatic 23): TransactionSearchConduitAPIMethod.execute has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php"},"region":{"startLine":102}}}],"partialFingerprints":{"codehealthFindingId/v1":"bd67b245b2c8f847e7e7d74f91f4eddb8b86065c00e3de02c2aa9506219d9ff0"}},{"ruleId":"D1","level":"warning","message":{"text":"PhutilRemarkupCodeBlockRule.markupText (cyclomatic 23): PhutilRemarkupCodeBlockRule.markupText has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/blockrule/PhutilRemarkupCodeBlockRule.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"7926f7e185ecdf46f9f7627d1ee1fbc6ba1b1ec9eeea9f8b0a247efaf25f469b"}},{"ruleId":"D1","level":"warning","message":{"text":"AphrontDialogView.render (cyclomatic 23): AphrontDialogView.render has cyclomatic complexity 23 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/AphrontDialogView.php"},"region":{"startLine":255}}}],"partialFingerprints":{"codehealthFindingId/v1":"a37b3b0f4149a6b6968230dd3b3087913374a01146f9c1c63a99c963d67e4a20"}},{"ruleId":"D1","level":"warning","message":{"text":"behavior-commit-graph.JX.behavior(\u0022diffusion-commit-graph\u0022) (cyclomatic 23): behavior-commit-graph.JX.behavior(\u0022diffusion-commit-graph\u0022) has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diffusion/behavior-commit-graph.js"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"cae62a12d48fd45804f831349ec9465579c730f1c5ed02acece356ff1f3be593"}},{"ruleId":"D1","level":"warning","message":{"text":"behavior-line-linker.JX.behavior(\u0022phabricator-line-linker\u0022) (cyclomatic 23): behavior-line-linker.JX.behavior(\u0022phabricator-line-linker\u0022) has cyclomatic complexity 23 (threshold 15). Most of this is not in the body itself: 5 of the 23 points are its own statements and the rest belongs to 4 function items inside it that branch (highlight, a function literal at line 39, a function literal at line 138, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-line-linker.js"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"d0575099fea48a1d8e6cbdad90343e7af2c5fa2b82c0429ee8b10270772ea6b3"}},{"ruleId":"D1","level":"warning","message":{"text":"buildTokenizer (cyclomatic 23): buildTokenizer has cyclomatic complexity 23 (threshold 15). Most of this is not in the body itself: 11 of the 23 points are its own statements and the rest belongs to one function literal inside it that branches (line 113). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal\u0027s work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/Prefab.js"},"region":{"startLine":73}}}],"partialFingerprints":{"codehealthFindingId/v1":"dec141ddf8c136f4ce74f40c7e375bfe7c64d1ac96f3d8117a6834af63978d10"}},{"ruleId":"D1","level":"warning","message":{"text":"(anonymous) (cyclomatic 23): (anonymous) has cyclomatic complexity 23 (threshold 15). Most of this is not in the body itself: 5 of the 23 points are its own statements and the rest belongs to 5 function items inside it that branch (highlight, a function literal at line 39, a function literal at line 138, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-line-linker.js"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"db7f8100f65e21920640cd183534e8dd23af436120bbfd81ba8aa36dea4170fa"}},{"ruleId":"D1","level":"warning","message":{"text":"(anonymous) (cyclomatic 23): (anonymous) has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diffusion/behavior-commit-graph.js"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"02190277f72c068fc419d06e24d657e82b10de49fb9afe80a1c9fe46445caf95"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorAuditTransaction.getTitleForFeed (cyclomatic 22): PhabricatorAuditTransaction.getTitleForFeed has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/storage/PhabricatorAuditTransaction.php"},"region":{"startLine":297}}}],"partialFingerprints":{"codehealthFindingId/v1":"91da445205e826188e696aa284a62cd60afb2f4141a00a5475cede6a9a5dcee6"}},{"ruleId":"D1","level":"warning","message":{"text":"CelerityResourceController.serveResource (cyclomatic 22): CelerityResourceController.serveResource has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/celerity/controller/CelerityResourceController.php"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"48c2a360eedce4f0b6f658aa9889832054f76978575056fb4911b548f4ac9a3d"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorConfigEditController.handleRequest (cyclomatic 22): PhabricatorConfigEditController.handleRequest has cyclomatic complexity 22 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/settings/PhabricatorConfigEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"c5ae068b1028f798a063b15602ffd22714367013e69fdfdcba71cdb115f46bbf"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialChangesetParser.replaceTabsWithSpaces (cyclomatic 22): DifferentialChangesetParser.replaceTabsWithSpaces has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialChangesetParser.php"},"region":{"startLine":1615}}}],"partialFingerprints":{"codehealthFindingId/v1":"6eae00cdf71fa370730e99568b8d4445ba25da71929c9adcbfc6dd229073fcc7"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialRevisionQuery.buildWhereClause (cyclomatic 22): DifferentialRevisionQuery.buildWhereClause has cyclomatic complexity 22 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/query/DifferentialRevisionQuery.php"},"region":{"startLine":630}}}],"partialFingerprints":{"codehealthFindingId/v1":"18f4dce78320c193b5121fe4c34cd04b2c32df598b2ec16973a2d03254607dc4"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialTransaction.getTitleForFeed (cyclomatic 22): DifferentialTransaction.getTitleForFeed has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialTransaction.php"},"region":{"startLine":281}}}],"partialFingerprints":{"codehealthFindingId/v1":"a549994c943551a1c166cf461ddc67169946118ee83fcacc6daa777836b3f46d"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialRevisionReviewersTransaction.renderReviewerEditTitle (cyclomatic 22): DifferentialRevisionReviewersTransaction.renderReviewerEditTitle has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php"},"region":{"startLine":165}}}],"partialFingerprints":{"codehealthFindingId/v1":"e5957f28a89e081ed7807c1ef106d4561d6bddf224156b172813e1cf0eae799f"}},{"ruleId":"D1","level":"warning","message":{"text":"DivinerAtomQuery.buildWhereClause (cyclomatic 22): DivinerAtomQuery.buildWhereClause has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/query/DivinerAtomQuery.php"},"region":{"startLine":302}}}],"partialFingerprints":{"codehealthFindingId/v1":"8d037eea0385ea5c076678a0b6bf503dc7f01d898aa90d8e78d5b0d1708a9863"}},{"ruleId":"D1","level":"warning","message":{"text":"ManiphestConduitAPIMethod.applyRequest (cyclomatic 22): ManiphestConduitAPIMethod.applyRequest has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"ed932c86c5296bbeeda2f6280fde2405a117fa211ca73a29528ea4bc46b73980"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorPeopleInviteSendController.handleRequest (cyclomatic 22): PhabricatorPeopleInviteSendController.handleRequest has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/controller/PhabricatorPeopleInviteSendController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"3d8d5178e3c0a36d37f9be41e364dd3d4ac329e336c51a8458d046545563b103"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorRepository.getAlmanacServiceRefs (cyclomatic 22): PhabricatorRepository.getAlmanacServiceRefs has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepository.php"},"region":{"startLine":1858}}}],"partialFingerprints":{"codehealthFindingId/v1":"980c0f537e13aa3cab34a4c74665c9618bb063526bd45539aa872fbda7d4ece4"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorApplicationSearchEngine.buildConduitResponse (cyclomatic 22): PhabricatorApplicationSearchEngine.buildConduitResponse has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorApplicationSearchEngine.php"},"region":{"startLine":1144}}}],"partialFingerprints":{"codehealthFindingId/v1":"bb4e223a6d198c280488d979bac817f68ee5a05cfa464c9a1ec53ee2b5e831d0"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorSlowvoteEditController.handleRequest (cyclomatic 22): PhabricatorSlowvoteEditController.handleRequest has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"04213312d6d8e71b31a38e7ed7a988845fda6cf7dd02512045250c68080d8205"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorApplicationTransactionEditor.getTransactionNewValue (cyclomatic 22): PhabricatorApplicationTransactionEditor.getTransactionNewValue has cyclomatic complexity 22 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform \u2014 the same kind of value, with no behaviour of its own \u2014 a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":588}}}],"partialFingerprints":{"codehealthFindingId/v1":"72c1eb68f79216ae7cba9c3974f7f58eef634f92183760b026dc6ab923bf76a9"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorApplicationTransaction.getTitleForFeed (cyclomatic 22): PhabricatorApplicationTransaction.getTitleForFeed has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorApplicationTransaction.php"},"region":{"startLine":1335}}}],"partialFingerprints":{"codehealthFindingId/v1":"1ce3e8c292e8a74818a0ccfa84592e2c56d5164ea92afb17c5ff0b60e070891a"}},{"ruleId":"D1","level":"warning","message":{"text":"PhutilRemarkupListBlockRule.markupText (cyclomatic 22): PhutilRemarkupListBlockRule.markupText has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/blockrule/PhutilRemarkupListBlockRule.php"},"region":{"startLine":88}}}],"partialFingerprints":{"codehealthFindingId/v1":"b2e0bbfe02805a0097712049cfcf02347cc043937ed714d5377f8d9722798563"}},{"ruleId":"D1","level":"warning","message":{"text":"behavior-durable-column.JX.behavior(\u0022durable-column\u0022) (cyclomatic 22): behavior-durable-column.JX.behavior(\u0022durable-column\u0022) has cyclomatic complexity 22 (threshold 15). Most of this is not in the body itself: 3 of the 22 points are its own statements and the rest belongs to 11 function items inside it that branch (a function literal at line 172, a function literal at line 334, _minimizeColumn, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/conpherence/behavior-durable-column.js"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"4c5d49c30dd97c258d489ba9a46151fbd06107b87b1c6d1f1f7b67feb9d5fc6e"}},{"ruleId":"D1","level":"warning","message":{"text":"(anonymous) (cyclomatic 22): (anonymous) has cyclomatic complexity 22 (threshold 15). Most of this is not in the body itself: 3 of the 22 points are its own statements and the rest belongs to 29 function items inside it that branch (a function literal at line 172, a function literal at line 334, _minimizeColumn, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/conpherence/behavior-durable-column.js"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"c8c2d6f80b364dcf377fd89bdfd7c3fc2bdb23f629598149739aa15e611e0e6d"}},{"ruleId":"D1","level":"warning","message":{"text":"PhutilCalendarRecurrenceRule.newYearMap (cyclomatic 21): PhutilCalendarRecurrenceRule.newYearMap has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php"},"region":{"startLine":1349}}}],"partialFingerprints":{"codehealthFindingId/v1":"4e88bc7e4b0d04113e5dfdc24a7e4c73041b5c31249764b5903eb5918f713df1"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorConfigClusterRepositoriesController.buildClusterRepositoryStatus (cyclomatic 21): PhabricatorConfigClusterRepositoriesController.buildClusterRepositoryStatus has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/services/PhabricatorConfigClusterRepositoriesController.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"bfa09cfe441bec63919ba5db3b2c2607304b7bdb9ff0a28146de3445923b94ab"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorDashboardPanelTabsController.handleRequest (cyclomatic 21): PhabricatorDashboardPanelTabsController.handleRequest has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/panel/PhabricatorDashboardPanelTabsController.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"955d7cc65faac7bf2b8a1bf235ad431eafd984aadfa0501cba3a765adf8c3915"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorDashboardTabsPanelType.renderPanelContent (cyclomatic 21): PhabricatorDashboardTabsPanelType.renderPanelContent has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"52ddbc29be92a777de616856bb812b6cb67e5adc4ca28256dce99c0765a0c90d"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialTransactionEditor.expandTransaction (cyclomatic 21): DifferentialTransactionEditor.expandTransaction has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/editor/DifferentialTransactionEditor.php"},"region":{"startLine":152}}}],"partialFingerprints":{"codehealthFindingId/v1":"b87ffe536259a7358a9c1117411df376a63fd9b586db336a3e2a1b128c1d4a5a"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialTransactionEditor.updateReviewStatus (cyclomatic 21): DifferentialTransactionEditor.updateReviewStatus has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/editor/DifferentialTransactionEditor.php"},"region":{"startLine":403}}}],"partialFingerprints":{"codehealthFindingId/v1":"d5e2e2b5c053e8c09cdfca77703b3d5e01db615d9d83ac91148f13bd9c7b673c"}},{"ruleId":"D1","level":"warning","message":{"text":"DiffusionSymbolController.handleRequest (cyclomatic 21): DiffusionSymbolController.handleRequest has cyclomatic complexity 21 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionSymbolController.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"0cfabb7c3ef15770c79eb9ca4067a293c9245d2fe86eb28a5f5d6fc5342c718b"}},{"ruleId":"D1","level":"warning","message":{"text":"DiffusionGitUploadPackWireProtocol.willReadBytes (cyclomatic 21): DiffusionGitUploadPackWireProtocol.willReadBytes has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/protocol/DiffusionGitUploadPackWireProtocol.php"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"74b1311f08b333c9474aaeeae92f990ad957bcbc46ea55170a1c02f9f71a54cf"}},{"ruleId":"D1","level":"warning","message":{"text":"DiffusionMercurialWireClientSSHProtocolChannel.decodeStream (cyclomatic 21): DiffusionMercurialWireClientSSHProtocolChannel.decodeStream has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/ssh/DiffusionMercurialWireClientSSHProtocolChannel.php"},"region":{"startLine":79}}}],"partialFingerprints":{"codehealthFindingId/v1":"2438fdd200adbf5ea4ee22d263ae7a7fcc62003e63eb76798fd476825d7cdbac"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorFileQuery.buildWhereClauseParts (cyclomatic 21): PhabricatorFileQuery.buildWhereClauseParts has cyclomatic complexity 21 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/query/PhabricatorFileQuery.php"},"region":{"startLine":396}}}],"partialFingerprints":{"codehealthFindingId/v1":"c6c7c89224fccaf0b447c793730fafee728f9d81e2c78e54b1a2b528e3c78a96"}},{"ruleId":"D1","level":"warning","message":{"text":"HeraldAction.loadStandardTargets (cyclomatic 21): HeraldAction.loadStandardTargets has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/action/HeraldAction.php"},"region":{"startLine":206}}}],"partialFingerprints":{"codehealthFindingId/v1":"cc86dcc3fbadb6265b7570bbd58ac9fa32407a416ac7e26bbb2185b637fcbe19"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorMetaMTAMail.newMailers (cyclomatic 21): PhabricatorMetaMTAMail.newMailers has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/storage/PhabricatorMetaMTAMail.php"},"region":{"startLine":558}}}],"partialFingerprints":{"codehealthFindingId/v1":"9851e6f056d190495413cd3f4e4353c7ac96d0de31366642e6ef89b6f09fe660"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorMentionRemarkupRule.didMarkupText (cyclomatic 21): PhabricatorMentionRemarkupRule.didMarkupText has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/markup/PhabricatorMentionRemarkupRule.php"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"fdbf676e5da0c400d7da16a30b29fd872dad11ea41228e871744974b628bc843"}},{"ruleId":"D1","level":"warning","message":{"text":"PhrictionDocumentQuery.buildWhereClauseParts (cyclomatic 21): PhrictionDocumentQuery.buildWhereClauseParts has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/query/PhrictionDocumentQuery.php"},"region":{"startLine":199}}}],"partialFingerprints":{"codehealthFindingId/v1":"361d80c1e483b4f984a187cad5251a2f3a9b794e3e97d543fe7260b2dbe00bb5"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorRepositoryPullEngine.pullRepositoryWithLock (cyclomatic 21): PhabricatorRepositoryPullEngine.pullRepositoryWithLock has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/engine/PhabricatorRepositoryPullEngine.php"},"region":{"startLine":51}}}],"partialFingerprints":{"codehealthFindingId/v1":"0e832a9dd6c09cc9c94d38e085c9ae6b347d4e84002bee8f0d567b82d0961102"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorSearchHovercardController.handleRequest (cyclomatic 21): PhabricatorSearchHovercardController.handleRequest has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/controller/PhabricatorSearchHovercardController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"6fabe085bc6209e58e7e7cabb80bbf5202a7135346c5c22d47c2fe4dc76285a2"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorProfileMenuEngine.buildItemConfigureContent (cyclomatic 21): PhabricatorProfileMenuEngine.buildItemConfigureContent has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorProfileMenuEngine.php"},"region":{"startLine":683}}}],"partialFingerprints":{"codehealthFindingId/v1":"4f9cdf9737a8302281a9cab490b6f29c77b227e384ce0dcb6f276fb189271276"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorSearchResultView.emboldenQuery (cyclomatic 21): PhabricatorSearchResultView.emboldenQuery has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/view/PhabricatorSearchResultView.php"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"b9a126080ac5e771a5625537059e1693cdaf81389ec037b09e86bba0814ff8fb"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorSubscriptionsHeraldAction.applySubscribe (cyclomatic 21): PhabricatorSubscriptionsHeraldAction.applySubscribe has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/subscriptions/herald/PhabricatorSubscriptionsHeraldAction.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"db270c42d32fbd401f3817bbcce4bb7482c285f2f77cafe6a59bc17ede66d514"}},{"ruleId":"D1","level":"warning","message":{"text":"PHUIDiffTableOfContentsListView.newComponentView (cyclomatic 21): PHUIDiffTableOfContentsListView.newComponentView has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/view/PHUIDiffTableOfContentsListView.php"},"region":{"startLine":387}}}],"partialFingerprints":{"codehealthFindingId/v1":"aba4f7af3216997dc6c7eb851a40366c76ca0fe893eb6946c213c8ecc06a6d45"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorCursorPagedPolicyAwareQuery.buildPagingClauseFromMultipleColumns (cyclomatic 21): PhabricatorCursorPagedPolicyAwareQuery.buildPagingClauseFromMultipleColumns has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php"},"region":{"startLine":727}}}],"partialFingerprints":{"codehealthFindingId/v1":"4f623c4de67f0f114cf6eb58cbb41da6f65cab104114b1c8789a7b9517e01dab"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorStandardPageView.willRenderPage (cyclomatic 21): PhabricatorStandardPageView.willRenderPage has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/page/PhabricatorStandardPageView.php"},"region":{"startLine":199}}}],"partialFingerprints":{"codehealthFindingId/v1":"de45b900c38fe9586cde4677b50807e2086800808b97d072c9c079578c7dabf2"}},{"ruleId":"D1","level":"warning","message":{"text":"redraw (cyclomatic 21): redraw has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffTreeView.js"},"region":{"startLine":87}}}],"partialFingerprints":{"codehealthFindingId/v1":"13c6a6c3c81c7be62b1b4aff0996ea267141bbea8b556d7bbbc87c71a842f573"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorAuthOneTimeLoginController.handleRequest (cyclomatic 20): PhabricatorAuthOneTimeLoginController.handleRequest has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthOneTimeLoginController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"f61de40801e36b0f33d70d279509010b05aae3290794eab9aef4468886d5c6fc"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorEmailLoginController.handleRequest (cyclomatic 20): PhabricatorEmailLoginController.handleRequest has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorEmailLoginController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"67dc934e1087c44fea9f4d99791fc45cd3edb6e81c16d805488c84cf13731ab2"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorAuthInviteAction.newActionListFromAddresses (cyclomatic 20): PhabricatorAuthInviteAction.newActionListFromAddresses has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/data/PhabricatorAuthInviteAction.php"},"region":{"startLine":94}}}],"partialFingerprints":{"codehealthFindingId/v1":"828e0ab944020d383711909c910b27a1abd3d1a91c4530218360571d8d086941"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorAuthPasswordEngine.checkNewPassword (cyclomatic 20): PhabricatorAuthPasswordEngine.checkNewPassword has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/engine/PhabricatorAuthPasswordEngine.php"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"5be162abb96511f8491bfc7dcc1a81a63a35237c0e8d8e6d3c9f7c577f062293"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorCalendarEventCancelController.handleRequest (cyclomatic 20): PhabricatorCalendarEventCancelController.handleRequest has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/controller/PhabricatorCalendarEventCancelController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"bb21cb0e8073d73510147e9e222db58064d1f032c8e4dd86ae7e793a09015d46"}},{"ruleId":"D1","level":"warning","message":{"text":"PhutilCalendarRecurrenceRule.advanceCursorState (cyclomatic 20): PhutilCalendarRecurrenceRule.advanceCursorState has cyclomatic complexity 20 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php"},"region":{"startLine":1685}}}],"partialFingerprints":{"codehealthFindingId/v1":"890d0417e61d76ce8d92a122bdf320002921d4302efa9e1539974ac033bf195b"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorCalendarEventQuery.buildWhereClauseParts (cyclomatic 20): PhabricatorCalendarEventQuery.buildWhereClauseParts has cyclomatic complexity 20 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/query/PhabricatorCalendarEventQuery.php"},"region":{"startLine":357}}}],"partialFingerprints":{"codehealthFindingId/v1":"e9710dca08895e4859b1cca8c5598636ffc2a1bb898f8eb9abeb9fa8c1a4e78c"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorConduitAPIController.handleRequest (cyclomatic 20): PhabricatorConduitAPIController.handleRequest has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conduit/controller/PhabricatorConduitAPIController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"f2e58694b6ed135a596e67c9043c2a768e6cb6be314e1b08280dc888f184fb5b"}},{"ruleId":"D1","level":"warning","message":{"text":"DarkConsoleServicesPlugin.generateData (cyclomatic 20): DarkConsoleServicesPlugin.generateData has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/console/plugin/DarkConsoleServicesPlugin.php"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"399a14cb67b451499c9c8984a783076c231202ce86279693ba3f0a885f5c650f"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialGetCommitMessageConduitAPIMethod.execute (cyclomatic 20): DifferentialGetCommitMessageConduitAPIMethod.execute has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"256f3ea300acfb1eef2ed4b3e058720ea70aed7f87d5fd8bf644ca072a1945b3"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialTransactionEditor.buildMailBody (cyclomatic 20): DifferentialTransactionEditor.buildMailBody has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/editor/DifferentialTransactionEditor.php"},"region":{"startLine":662}}}],"partialFingerprints":{"codehealthFindingId/v1":"ee6cd98b2efd3b43529ff75159de86d4d734886661719839f61e79a77902d262"}},{"ruleId":"D1","level":"warning","message":{"text":"DiffusionController.buildCrumbList (cyclomatic 20): DiffusionController.buildCrumbList has cyclomatic complexity 20 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionController.php"},"region":{"startLine":128}}}],"partialFingerprints":{"codehealthFindingId/v1":"7c420f5a97be91379f9061d154ce749878226a7f0a33edaaa90b754136ec9d35"}},{"ruleId":"D1","level":"warning","message":{"text":"DiffusionLowLevelResolveRefsQuery.resolveMercurialRefs (cyclomatic 20): DiffusionLowLevelResolveRefsQuery.resolveMercurialRefs has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/lowlevel/DiffusionLowLevelResolveRefsQuery.php"},"region":{"startLine":243}}}],"partialFingerprints":{"codehealthFindingId/v1":"257c8cbd3d65b62c14b864fd7a9c9d65211ee0f373d3f341e6fb3ee94e7b3fa5"}},{"ruleId":"D1","level":"warning","message":{"text":"HarbormasterBuildEngine.updateBuildable (cyclomatic 20): HarbormasterBuildEngine.updateBuildable has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/engine/HarbormasterBuildEngine.php"},"region":{"startLine":442}}}],"partialFingerprints":{"codehealthFindingId/v1":"715fb2b425f6d586cb58a3f2ca97aad8b4f0e1a7a2aa4da4fd18978bbb01439a"}},{"ruleId":"D1","level":"warning","message":{"text":"ManiphestTaskStatus.validateConfiguration (cyclomatic 20): ManiphestTaskStatus.validateConfiguration has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/constants/ManiphestTaskStatus.php"},"region":{"startLine":261}}}],"partialFingerprints":{"codehealthFindingId/v1":"e5ef3d562958f19d6ab7855e98e24c35bc074c423538e1b9c6620d443f332756"}},{"ruleId":"D1","level":"warning","message":{"text":"PhortuneCartCheckoutController.handleCartRequest (cyclomatic 20): PhortuneCartCheckoutController.handleCartRequest has cyclomatic complexity 20 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/cart/PhortuneCartCheckoutController.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"ad779550d52bb73c0199ca3769813dd01bb367b0cdbadfcd0c0292381414f718"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorBulkManagementExportWorkflow.newQueries (cyclomatic 20): PhabricatorBulkManagementExportWorkflow.newQueries has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/bulk/management/PhabricatorBulkManagementExportWorkflow.php"},"region":{"startLine":152}}}],"partialFingerprints":{"codehealthFindingId/v1":"28e8026771b59facb35e346c109a611491a372944ec35b786aa8cc5f503032b8"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorApplicationTransaction.getIcon (cyclomatic 20): PhabricatorApplicationTransaction.getIcon has cyclomatic complexity 20 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform \u2014 the same kind of value, with no behaviour of its own \u2014 a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorApplicationTransaction.php"},"region":{"startLine":473}}}],"partialFingerprints":{"codehealthFindingId/v1":"6a2cc1544526b5da0ccb3232acb36a0047d6adf6675312aaf403b95e682d6988"}},{"ruleId":"D1","level":"warning","message":{"text":"PHUIObjectBoxView.getTagContent (cyclomatic 20): PHUIObjectBoxView.getTagContent has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIObjectBoxView.php"},"region":{"startLine":181}}}],"partialFingerprints":{"codehealthFindingId/v1":"a92d1a9471220d19109a4600c2449cd8b735240df386df6e35e1bcf65d2df7ee"}},{"ruleId":"D1","level":"warning","message":{"text":"PHUIObjectItemView.getTagAttributes (cyclomatic 20): PHUIObjectItemView.getTagAttributes has cyclomatic complexity 20 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIObjectItemView.php"},"region":{"startLine":287}}}],"partialFingerprints":{"codehealthFindingId/v1":"dd84166fa0aa6cc6d49c46b0138897da2503a3a45e1e19d1ff04224a91eca71a"}},{"ruleId":"D1","level":"warning","message":{"text":"behavior-populate.JX.behavior(\u0022differential-populate\u0022) (cyclomatic 20): behavior-populate.JX.behavior(\u0022differential-populate\u0022) has cyclomatic complexity 20 (threshold 15). Most of this is not in the body itself: 5 of the 20 points are its own statements and the rest belongs to 3 function items inside it that branch (a function literal at line 95, onredraw, get_lists). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/differential/behavior-populate.js"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"8461148674d969c37c0d4409076c7ac0b078861103b5c56608ee09e96d5b6c22"}},{"ruleId":"D1","level":"warning","message":{"text":"behavior-object-selector.JX.behavior(\u0022phabricator-object-selector\u0022) (cyclomatic 20): behavior-object-selector.JX.behavior(\u0022phabricator-object-selector\u0022) has cyclomatic complexity 20 (threshold 15). Most of this is not in the body itself: 4 of the 20 points are its own statements and the rest belongs to 7 function items inside it that branch (redrawList, onreceive, redrawAttached, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-object-selector.js"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"34526bb4c3cef8121662f1fe1e8dcff55c29e2082bbf84191b75d89203920b41"}},{"ruleId":"D1","level":"warning","message":{"text":"(anonymous) (cyclomatic 20): (anonymous) has cyclomatic complexity 20 (threshold 15). Most of this is not in the body itself: 4 of the 20 points are its own statements and the rest belongs to 11 function items inside it that branch (redrawList, onreceive, redrawAttached, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-object-selector.js"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"5e46594e754d1013e8ccb9904ddbdefa3501632253d097ac96e0e5c6300be18f"}},{"ruleId":"D1","level":"warning","message":{"text":"(anonymous) (cyclomatic 20): (anonymous) has cyclomatic complexity 20 (threshold 15). Most of this is not in the body itself: 5 of the 20 points are its own statements and the rest belongs to 4 function items inside it that branch (a function literal at line 95, onredraw, get_lists, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/differential/behavior-populate.js"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"03ea31731384fcad23a58dc9da0c3fb58ea0ce55058bb3daf702895a5b33fa92"}},{"ruleId":"D1","level":"warning","message":{"text":"AphrontHTTPHeaderParser.getHeaderContentAsPairs (cyclomatic 19): AphrontHTTPHeaderParser.getHeaderContentAsPairs has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/headerparser/AphrontHTTPHeaderParser.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"fa5706f7f8b3dadb5de2d9873c9bdca5b78a89c7535086086b48ed7652ac10fb"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorAuthProviderConfigTransaction.getTitle (cyclomatic 19): PhabricatorAuthProviderConfigTransaction.getTitle has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/storage/PhabricatorAuthProviderConfigTransaction.php"},"region":{"startLine":61}}}],"partialFingerprints":{"codehealthFindingId/v1":"71716d9ff1b16b8235905fa535843ba53ab54cc3ac245785edeedcd5329aa724"}},{"ruleId":"D1","level":"warning","message":{"text":"PhutilCalendarRecurrenceRule.resetSource (cyclomatic 19): PhutilCalendarRecurrenceRule.resetSource has cyclomatic complexity 19 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform \u2014 the same kind of value, with no behaviour of its own \u2014 a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php"},"region":{"startLine":566}}}],"partialFingerprints":{"codehealthFindingId/v1":"a45cad6907b2c4a76382818f90f4b35060d081a6eaf2f4f125a1da6fa0a41731"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorBinariesSetupCheck.executeChecks (cyclomatic 19): PhabricatorBinariesSetupCheck.executeChecks has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/check/PhabricatorBinariesSetupCheck.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"a5f7e0bfb79021d2672034b9cb844c4f7d3df131c49e0996b893b15ca6e0a0f8"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorExtraConfigSetupCheck.executeChecks (cyclomatic 19): PhabricatorExtraConfigSetupCheck.executeChecks has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/check/PhabricatorExtraConfigSetupCheck.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"801c35d38c8c993213e2b28f0de110dd66671239561e829c12eea22a71cdce65"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialChangesetRenderer.buildPrimitives (cyclomatic 19): DifferentialChangesetRenderer.buildPrimitives has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetRenderer.php"},"region":{"startLine":453}}}],"partialFingerprints":{"codehealthFindingId/v1":"bcc102e0a640cd17464097418d75f174285586e91f2ee5a8bacb8e52117cfde9"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialLocalCommitsView.render (cyclomatic 19): DifferentialLocalCommitsView.render has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/view/DifferentialLocalCommitsView.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"ff88d66311573258d4cdf0afc750520fdfec52d2df1af3ae4d9aaa5675a44e7d"}},{"ruleId":"D1","level":"warning","message":{"text":"DiffusionRepositoryStorageManagementPanel.buildClusterStatusPanel (cyclomatic 19): DiffusionRepositoryStorageManagementPanel.buildClusterStatusPanel has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/management/DiffusionRepositoryStorageManagementPanel.php"},"region":{"startLine":79}}}],"partialFingerprints":{"codehealthFindingId/v1":"4557ea6b89e22309a442e2462e2dfdadaff8a8ed9f31662efbe672fbe1886ba2"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorFilesManagementMigrateWorkflow.execute (cyclomatic 19): PhabricatorFilesManagementMigrateWorkflow.execute has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/management/PhabricatorFilesManagementMigrateWorkflow.php"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"4c571582a6b662a330ca7f35078f5b6fb2571666fead6e7ef8423c976652a017"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorOAuthServerTokenController.handleRequest (cyclomatic 19): PhabricatorOAuthServerTokenController.handleRequest has cyclomatic complexity 19 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/oauthserver/controller/PhabricatorOAuthServerTokenController.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"e7e26232f956bff42ca8961b10f8cfe6ac4b24af2c3a40c0b3d520ef258b477b"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorOwnersPackageQuery.getControllingPackagesForPath (cyclomatic 19): PhabricatorOwnersPackageQuery.getControllingPackagesForPath has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/owners/query/PhabricatorOwnersPackageQuery.php"},"region":{"startLine":369}}}],"partialFingerprints":{"codehealthFindingId/v1":"1ec20d33c092ee54eeabadbe5580bdf2cf3be7adb5fa4927d81bcb2a7d3081ee"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorPeopleQuery.fillUserCaches (cyclomatic 19): PhabricatorPeopleQuery.fillUserCaches has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/query/PhabricatorPeopleQuery.php"},"region":{"startLine":514}}}],"partialFingerprints":{"codehealthFindingId/v1":"47cd7e079cc7b5af81177c4a72b8f36ecde5678b6030ecde85ee1f1f0696d8bc"}},{"ruleId":"D1","level":"warning","message":{"text":"PhortuneCartCancelController.handleCartRequest (cyclomatic 19): PhortuneCartCancelController.handleCartRequest has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/cart/PhortuneCartCancelController.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"e4354982e489e6235cc077ded3091057480e0f738f702e95a18d123f44b2e8a1"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorPhortuneManagementInvoiceWorkflow.execute (cyclomatic 19): PhabricatorPhortuneManagementInvoiceWorkflow.execute has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/management/PhabricatorPhortuneManagementInvoiceWorkflow.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"7956f0a3fb2e4a7016360e8248a92211b09e9f7e7fe7d161f5caff74a4afdc8b"}},{"ruleId":"D1","level":"warning","message":{"text":"PhortunePayPalPaymentProvider.updateCharge (cyclomatic 19): PhortunePayPalPaymentProvider.updateCharge has cyclomatic complexity 19 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform \u2014 the same kind of value, with no behaviour of its own \u2014 a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/provider/PhortunePayPalPaymentProvider.php"},"region":{"startLine":194}}}],"partialFingerprints":{"codehealthFindingId/v1":"7a9b7862b29a969ffebdea276614ba63ebb73906f35bed4028b03bfcdfae824c"}},{"ruleId":"D1","level":"warning","message":{"text":"PhrictionDocumentQuery.willFilterPage (cyclomatic 19): PhrictionDocumentQuery.willFilterPage has cyclomatic complexity 19 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/query/PhrictionDocumentQuery.php"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"17037c438900479e3021dd793bec872f91c65417ad01e31374334c7af8b5567f"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorProjectIconSet.validateConfiguration (cyclomatic 19): PhabricatorProjectIconSet.validateConfiguration has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/icon/PhabricatorProjectIconSet.php"},"region":{"startLine":195}}}],"partialFingerprints":{"codehealthFindingId/v1":"fac05faad12d0d82fb22b8ec23e3d768a5671a04c3cae99cfcf48c3b778ed4aa"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorRepositoryManagementParentsWorkflow.rebuildRepository (cyclomatic 19): PhabricatorRepositoryManagementParentsWorkflow.rebuildRepository has cyclomatic complexity 19 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/management/PhabricatorRepositoryManagementParentsWorkflow.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"ddc569de5b21252119a477e40d0d0e48d3642263f63b4e4698481be9bddbec2e"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorRepositoryManagementRebuildIdentitiesWorkflow.execute (cyclomatic 19): PhabricatorRepositoryManagementRebuildIdentitiesWorkflow.execute has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/management/PhabricatorRepositoryManagementRebuildIdentitiesWorkflow.php"},"region":{"startLine":63}}}],"partialFingerprints":{"codehealthFindingId/v1":"b66249de92f273da9f2a44529b5e4a73d61100d0ed3e7c94512f6ae2dbac428a"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorSearchRelationshipController.handleRequest (cyclomatic 19): PhabricatorSearchRelationshipController.handleRequest has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/controller/PhabricatorSearchRelationshipController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"f42f84ea3f9918f2e7000530ec748958e1191d3a9262ef713131f9626fc51598"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorApplicationTransactionEditor.addHeadersAndCommentsToMailBody (cyclomatic 19): PhabricatorApplicationTransactionEditor.addHeadersAndCommentsToMailBody has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":3859}}}],"partialFingerprints":{"codehealthFindingId/v1":"0fef53853f9b1e86a5ecd47cf656b4fb4d6ba9bd4d6cb76acb7bfcdf37925d48"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorApplicationTransaction.getRequiredHandlePHIDs (cyclomatic 19): PhabricatorApplicationTransaction.getRequiredHandlePHIDs has cyclomatic complexity 19 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform \u2014 the same kind of value, with no behaviour of its own \u2014 a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorApplicationTransaction.php"},"region":{"startLine":329}}}],"partialFingerprints":{"codehealthFindingId/v1":"c185cc5908bffb3c4b72f62727067ffef8e5166d3f86a675c2c11f56e5f1636d"}},{"ruleId":"D1","level":"warning","message":{"text":"PhutilProseDifferenceEngine.buildDiff (cyclomatic 19): PhutilProseDifferenceEngine.buildDiff has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/prose/PhutilProseDifferenceEngine.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"e5d41ae5ea2a3980d8615f71a42bf3fd30cc363504eb3981dd2b352720dc6cf8"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorDiffInlineCommentQuery.willFilterPage (cyclomatic 19): PhabricatorDiffInlineCommentQuery.willFilterPage has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/query/PhabricatorDiffInlineCommentQuery.php"},"region":{"startLine":144}}}],"partialFingerprints":{"codehealthFindingId/v1":"7b0ff8f2c13e0be0d9145bfd1379f81c7855a34f0d27ca170bf150f79ca1cc16"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorJavelinLinter.lintPath (cyclomatic 19): PhabricatorJavelinLinter.lintPath has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/lint/linter/PhabricatorJavelinLinter.php"},"region":{"startLine":104}}}],"partialFingerprints":{"codehealthFindingId/v1":"5f6b48c29f58c65738a362544558c4d7fe4d8d43f8d1484b08ac6fb3391f81f3"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorManagementWorkflow.loadUsersFromArguments (cyclomatic 19): PhabricatorManagementWorkflow.loadUsersFromArguments has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/management/PhabricatorManagementWorkflow.php"},"region":{"startLine":70}}}],"partialFingerprints":{"codehealthFindingId/v1":"185b638b354d9ab8afd970d296d63c4361560e45b130350990c3df5f8035f179"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorCursorPagedPolicyAwareQuery.buildEdgeLogicJoinClause (cyclomatic 19): PhabricatorCursorPagedPolicyAwareQuery.buildEdgeLogicJoinClause has cyclomatic complexity 19 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php"},"region":{"startLine":2694}}}],"partialFingerprints":{"codehealthFindingId/v1":"429aed1a6e8f9b59c1b89bcb461c4e4844f3f08793d8d227023443e4135296bd"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorRemarkupControl.renderInput (cyclomatic 19): PhabricatorRemarkupControl.renderInput has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/form/control/PhabricatorRemarkupControl.php"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"97aa890058ab50433ff787a5db6d7d1997bd5cdea0538947c2c56d41418aba21"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorMainMenuView.render (cyclomatic 19): PhabricatorMainMenuView.render has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/page/menu/PhabricatorMainMenuView.php"},"region":{"startLine":51}}}],"partialFingerprints":{"codehealthFindingId/v1":"cf3be248134ed52b0e198c58c9d3ffa457e6e29a3d2df7f119300b772bd6734f"}},{"ruleId":"D1","level":"warning","message":{"text":"PHUIPagerView.render (cyclomatic 19): PHUIPagerView.render has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIPagerView.php"},"region":{"startLine":119}}}],"partialFingerprints":{"codehealthFindingId/v1":"b828c4260d5a9086931382a6ce72388af4656e156031d6597a2c0995fd0a52d1"}},{"ruleId":"D1","level":"warning","message":{"text":"behavior-project-boards.JX.behavior(\u0022project-boards\u0022) (cyclomatic 19): behavior-project-boards.JX.behavior(\u0022project-boards\u0022) has cyclomatic complexity 19 (threshold 15). Of this number, 15 points are the body\u0027s own statements and 4 belong to 3 function literals inside it that branch. To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/projects/behavior-project-boards.js"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"e0744883eb0347539e3944c6587e42cb9bb8e5cb91e0b3b77cf316a60a4dfad1"}},{"ruleId":"D1","level":"warning","message":{"text":"_getFragmentLocation (cyclomatic 19): _getFragmentLocation has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":2643}}}],"partialFingerprints":{"codehealthFindingId/v1":"b60f5281e8cdce123bbe7056dc96caf96425504fa6fdb9bcf65b0e237b769c1b"}},{"ruleId":"D1","level":"warning","message":{"text":"(anonymous) (cyclomatic 19): (anonymous) has cyclomatic complexity 19 (threshold 15). Of this number, 15 points are the body\u0027s own statements and 4 belong to 5 function items inside it that branch. To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/projects/behavior-project-boards.js"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"bd25ee51e85346195f0790e7332e73d1af53cfc3c77bb308ae530e4255f81620"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorDuoAuthFactor.processAddFactorForm (cyclomatic 18): PhabricatorDuoAuthFactor.processAddFactorForm has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/factor/PhabricatorDuoAuthFactor.php"},"region":{"startLine":155}}}],"partialFingerprints":{"codehealthFindingId/v1":"53041389dfbcd0050204db77cc765a78e8ee4742bac5fec4d617d0c7e50fa740"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorConfigConsoleController.loadVersions (cyclomatic 18): PhabricatorConfigConsoleController.loadVersions has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/PhabricatorConfigConsoleController.php"},"region":{"startLine":139}}}],"partialFingerprints":{"codehealthFindingId/v1":"fc81833b5eebe6a7b707b2521568d749f0c2eab52d2cfbddaee184822fa56978"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorDashboardObjectInstallWorkflow.handleRequest (cyclomatic 18): PhabricatorDashboardObjectInstallWorkflow.handleRequest has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/install/PhabricatorDashboardObjectInstallWorkflow.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"ee82a9ddfce4d7b6ce7b45a9e63e909d48e1ab2c4b070dfbaf2aa17c748165c7"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialTransactionEditor.didApplyTransactions (cyclomatic 18): DifferentialTransactionEditor.didApplyTransactions has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/editor/DifferentialTransactionEditor.php"},"region":{"startLine":1529}}}],"partialFingerprints":{"codehealthFindingId/v1":"4619141cb3519d4384e7a24b71d8e340e27f77719fb962fd5f1a9f3fcbc90288"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialCommitMessageParser.parseCorpus (cyclomatic 18): DifferentialCommitMessageParser.parseCorpus has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialCommitMessageParser.php"},"region":{"startLine":136}}}],"partialFingerprints":{"codehealthFindingId/v1":"80b720c79193f1b933f5c3d05e11c19f396f97e55bd2108d05d0d50b33373f47"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialRevisionListView.render (cyclomatic 18): DifferentialRevisionListView.render has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/view/DifferentialRevisionListView.php"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"05875b7afd2f69a53fcee84b40906c3da893063c5299e4d2e5c05cea0493747c"}},{"ruleId":"D1","level":"warning","message":{"text":"DiffusionLintSaveRunner.run (cyclomatic 18): DiffusionLintSaveRunner.run has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/DiffusionLintSaveRunner.php"},"region":{"startLine":45}}}],"partialFingerprints":{"codehealthFindingId/v1":"472fb290525cabb6c97388e8aaf8607dcc75f83edeb46fdbc44805384318645d"}},{"ruleId":"D1","level":"warning","message":{"text":"DiffusionRefTableController.handleRequest (cyclomatic 18): DiffusionRefTableController.handleRequest has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRefTableController.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"c60d46b856ac11998e34e327e33a3b7826970f9e0986308a0f8632eb96f8a3a1"}},{"ruleId":"D1","level":"warning","message":{"text":"DiffusionRepositoryProfilePictureController.handleRequest (cyclomatic 18): DiffusionRepositoryProfilePictureController.handleRequest has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"4e0c599b94343719801825c5ec2d74bc1ad2c0a43fff187702d2367fa1b7d4af"}},{"ruleId":"D1","level":"warning","message":{"text":"DiffusionSubversionWireProtocol.writeData (cyclomatic 18): DiffusionSubversionWireProtocol.writeData has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This is NOT this file\u0027s highest cyclomatic complexity: DiffusionSubversionWireProtocol.isReadOnlyCommand (cyclomatic 28) is higher and carries no row of its own \u2014 it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension\u0027s figures nor in its score."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/protocol/DiffusionSubversionWireProtocol.php"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"6c188462f74f5f2732e13998e6f31dbc47b537dda1d2e83c8534a6ab100a3d14"}},{"ruleId":"D1","level":"warning","message":{"text":"DiffusionCommitGraphView.newObjectItemViews (cyclomatic 18): DiffusionCommitGraphView.newObjectItemViews has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/view/DiffusionCommitGraphView.php"},"region":{"startLine":105}}}],"partialFingerprints":{"codehealthFindingId/v1":"421318db7e7bca92e77eb0ce963f10525a34fdf5b485131329cc8229057fb92d"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorChartStackedAreaDataset.newChartDisplayData (cyclomatic 18): PhabricatorChartStackedAreaDataset.newChartDisplayData has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fact/chart/PhabricatorChartStackedAreaDataset.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"1e48c7b3e50f82fdfd2b91df48256779f2bf99aa4751278f1fb0313015b834eb"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorChartRenderingEngine.newTabularView (cyclomatic 18): PhabricatorChartRenderingEngine.newTabularView has cyclomatic complexity 18 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fact/engine/PhabricatorChartRenderingEngine.php"},"region":{"startLine":112}}}],"partialFingerprints":{"codehealthFindingId/v1":"be5692b1e32a9ed11df48f8498fcff73a3fa765ed7ade5f28cfb216f4db96b71"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorFileDataController.handleRequest (cyclomatic 18): PhabricatorFileDataController.handleRequest has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/controller/PhabricatorFileDataController.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"5be11daaf8d326fee8e27ce459c09dfb51d73e21bfa98c13358122b6fffc9a35"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorFileQuery.loadPage (cyclomatic 18): PhabricatorFileQuery.loadPage has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/query/PhabricatorFileQuery.php"},"region":{"startLine":166}}}],"partialFingerprints":{"codehealthFindingId/v1":"18896b68a56a4e9e705400e4110d5b7fdfb3dd0bf87f2439e15aa7578c5a4fd8"}},{"ruleId":"D1","level":"warning","message":{"text":"HarbormasterUIEventListener.handlePropertyEvent (cyclomatic 18): HarbormasterUIEventListener.handlePropertyEvent has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/event/HarbormasterUIEventListener.php"},"region":{"startLine":18}}}],"partialFingerprints":{"codehealthFindingId/v1":"7d5a779cb8351f109027af0c78e5e70a93fcc633b377a06f4e726539782993ce"}},{"ruleId":"D1","level":"warning","message":{"text":"HeraldRuleController.saveRule (cyclomatic 18): HeraldRuleController.saveRule has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/controller/HeraldRuleController.php"},"region":{"startLine":263}}}],"partialFingerprints":{"codehealthFindingId/v1":"4b9efa7c0246b70369386970e56bb7fdf2e59283b0c89e8d998d481445ec660e"}},{"ruleId":"D1","level":"warning","message":{"text":"HeraldEngine.applyRules (cyclomatic 18): HeraldEngine.applyRules has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/engine/HeraldEngine.php"},"region":{"startLine":126}}}],"partialFingerprints":{"codehealthFindingId/v1":"1088ceb00166aa30fb17203e89ce13717924fead9894e302ce48a14f320a455b"}},{"ruleId":"D1","level":"warning","message":{"text":"HeraldEngine.applyEffects (cyclomatic 18): HeraldEngine.applyEffects has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/engine/HeraldEngine.php"},"region":{"startLine":258}}}],"partialFingerprints":{"codehealthFindingId/v1":"86a8710e8f892790c6754012bfb42b8ac3387972fe7901dd05a426d893e91a86"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorMacroQuery.buildWhereClauseParts (cyclomatic 18): PhabricatorMacroQuery.buildWhereClauseParts has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/macro/query/PhabricatorMacroQuery.php"},"region":{"startLine":103}}}],"partialFingerprints":{"codehealthFindingId/v1":"15f584d333d35438ebf61a7bcc7e132d0aafb62521b4e7e18b125222b565ece4"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorMailSMTPAdapter.sendMessage (cyclomatic 18): PhabricatorMailSMTPAdapter.sendMessage has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/adapter/PhabricatorMailSMTPAdapter.php"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"1117c5f4863510f91bf06db3d29ece39539dae7a8185cd4cba8bec15544dc623"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorNotificationServersConfigType.validateStoredValue (cyclomatic 18): PhabricatorNotificationServersConfigType.validateStoredValue has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/notification/config/PhabricatorNotificationServersConfigType.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"b5ce06f9d8266fc85969b1f472e3ea001d3e30ce0d49f69ae8368584386f9838"}},{"ruleId":"D1","level":"warning","message":{"text":"NuanceGitHubImportCursor.pullDataFromSource (cyclomatic 18): NuanceGitHubImportCursor.pullDataFromSource has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/cursor/NuanceGitHubImportCursor.php"},"region":{"startLine":56}}}],"partialFingerprints":{"codehealthFindingId/v1":"dfbb8cf62b24df468b9cac2d4987a63ac45da365410ffa2e666d5a506055541d"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorOAuthServerAuthController.handleRequest (cyclomatic 18): PhabricatorOAuthServerAuthController.handleRequest has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/oauthserver/controller/PhabricatorOAuthServerAuthController.php"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"f3f81ec485244e85f9a2e0b345d787b84536a8c8387cd5c292a3fb9a85d8c920"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorPolicyFilter.applyExtendedPolicyChecks (cyclomatic 18): PhabricatorPolicyFilter.applyExtendedPolicyChecks has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/filter/PhabricatorPolicyFilter.php"},"region":{"startLine":302}}}],"partialFingerprints":{"codehealthFindingId/v1":"70851965e7ec40ff8162585435169e5618a7011d82259140c75290d3b6aeb803"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorRepositoryGraphCache.loadLastModifiedCommitID (cyclomatic 18): PhabricatorRepositoryGraphCache.loadLastModifiedCommitID has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/graphcache/PhabricatorRepositoryGraphCache.php"},"region":{"startLine":75}}}],"partialFingerprints":{"codehealthFindingId/v1":"1ceef3c7cc5a8744a28463054ca93a9f7c18f91558499b61a174ecae804b526c"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorProfileMenuItemView.newListItemView (cyclomatic 18): PhabricatorProfileMenuItemView.newListItemView has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorProfileMenuItemView.php"},"region":{"startLine":138}}}],"partialFingerprints":{"codehealthFindingId/v1":"0858e8c949b0a2db4842f4cada56abb0c7755518c0e68fd512bd35f90b52528d"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorApplicationTransaction.shouldHideForMail (cyclomatic 18): PhabricatorApplicationTransaction.shouldHideForMail has cyclomatic complexity 18 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform \u2014 the same kind of value, with no behaviour of its own \u2014 a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorApplicationTransaction.php"},"region":{"startLine":728}}}],"partialFingerprints":{"codehealthFindingId/v1":"89b9f26e0a6208bd954fa63b2906cdac295e5a2d17d48208f92f922043554542"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorSSHPassthruCommand.execute (cyclomatic 18): PhabricatorSSHPassthruCommand.execute has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/ssh/PhabricatorSSHPassthruCommand.php"},"region":{"startLine":87}}}],"partialFingerprints":{"codehealthFindingId/v1":"0a4c3b7a53c0ae9b81d5296ef740c17b27385ec56bba04d9ab4a7194898285a9"}},{"ruleId":"D1","level":"warning","message":{"text":"PHUIListItemView.getTagContent (cyclomatic 18): PHUIListItemView.getTagContent has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIListItemView.php"},"region":{"startLine":286}}}],"partialFingerprints":{"codehealthFindingId/v1":"3ad6161cc884d86a409a01e1def54d196396666e5990ee7ef2dbe1ef6f8967f2"}},{"ruleId":"D1","level":"warning","message":{"text":"PHUITimelineView.buildEvents (cyclomatic 18): PHUITimelineView.buildEvents has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUITimelineView.php"},"region":{"startLine":101}}}],"partialFingerprints":{"codehealthFindingId/v1":"199b99f5af845eafe94e00e7490eb58854b111b18429507720242ff8e515a6b8"}},{"ruleId":"D1","level":"warning","message":{"text":"behavior-form.JX.behavior(\u0022aphront-form-disable-on-submit\u0022) (cyclomatic 18): behavior-form.JX.behavior(\u0022aphront-form-disable-on-submit\u0022) has cyclomatic complexity 18 (threshold 15). Most of this is not in the body itself: 1 of the 18 points is its own statement and the rest belongs to 5 function items inside it that branch (a function literal at line 18, a function literal at line 57, a function literal at line 12, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-form.js"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"1a1426936c1d663a07a4ad846813a75367bb15b2209b7a44a5b0e3bafea6b077"}},{"ruleId":"D1","level":"warning","message":{"text":"(anonymous) (cyclomatic 18): (anonymous) has cyclomatic complexity 18 (threshold 15). Most of this is not in the body itself: 1 of the 18 points is its own statement and the rest belongs to 5 function items inside it that branch (a function literal at line 18, a function literal at line 57, a function literal at line 12, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-form.js"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"85126f1998bef261f7b55fc231711a13c4abfff4354b0517f9678bb89c7cffb0"}},{"ruleId":"D1","level":"warning","message":{"text":"getSelectableItems (cyclomatic 18): getSelectableItems has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangeset.js"},"region":{"startLine":435}}}],"partialFingerprints":{"codehealthFindingId/v1":"b25cdc0059de9c14c9b8e3dc6c8ded14dc07612088e03b3b161ffb71b19a95f6"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorConfigClusterDatabasesController.buildClusterDatabaseStatus (cyclomatic 17): PhabricatorConfigClusterDatabasesController.buildClusterDatabaseStatus has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/services/PhabricatorConfigClusterDatabasesController.php"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"2fd0b1f35db6110b08f8a1e63e2b0d4905a1070ebe82d0ad743b68d2824456c6"}},{"ruleId":"D1","level":"warning","message":{"text":"ConpherenceViewController.handleRequest (cyclomatic 17): ConpherenceViewController.handleRequest has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceViewController.php"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"6eadd8d0e449d35064ecc8f3b11db1d6056a5b9394996355cab342b0df5b7d10"}},{"ruleId":"D1","level":"warning","message":{"text":"ConpherenceThreadSearchEngine.renderResultList (cyclomatic 17): ConpherenceThreadSearchEngine.renderResultList has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/query/ConpherenceThreadSearchEngine.php"},"region":{"startLine":94}}}],"partialFingerprints":{"codehealthFindingId/v1":"3b591e1ae97cbd80659c480db1f827985142d1789021547ff24f9d881f48eeec"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialChangesetParser.newDocumentEngine (cyclomatic 17): DifferentialChangesetParser.newDocumentEngine has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialChangesetParser.php"},"region":{"startLine":1746}}}],"partialFingerprints":{"codehealthFindingId/v1":"6bb6f1c8c6202cc55e70a4e3a964d9b494eb474867705ff8a5ae261d69c7a8ab"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialChangesetOneUpMailRenderer.renderPrimitives (cyclomatic 17): DifferentialChangesetOneUpMailRenderer.renderPrimitives has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetOneUpMailRenderer.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"1502a9dac851b7b8aecdd88464fe7f90d84f82fc103c42d7b13101241e5f6af5"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialRevisionUpdateHistoryView.render (cyclomatic 17): DifferentialRevisionUpdateHistoryView.render has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"1c2d610274a3e3adda6b3b86ea3086a67dd78a5e6fb4d53ad9084205564bd92b"}},{"ruleId":"D1","level":"warning","message":{"text":"DiffusionCompareController.handleRequest (cyclomatic 17): DiffusionCompareController.handleRequest has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionCompareController.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"03c55b273ed0ef6392e3ceae5d44ae33292a8befd5c355e632d74e67651d99ea"}},{"ruleId":"D1","level":"warning","message":{"text":"DiffusionSourceLinkRemarkupRule.didMarkupText (cyclomatic 17): DiffusionSourceLinkRemarkupRule.didMarkupText has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/remarkup/DiffusionSourceLinkRemarkupRule.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"654a5bc23a7791a46c310098055d78253213b0ef1db5304aa2fc82f2e19ab0af"}},{"ruleId":"D1","level":"warning","message":{"text":"DivinerPHPAtomizer.executeAtomize (cyclomatic 17): DivinerPHPAtomizer.executeAtomize has cyclomatic complexity 17 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/atomizer/DivinerPHPAtomizer.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"5ee9ee38c99935903b858bcded7456637935ebc07d2d8feade094cdcd546fe34"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorJupyterDocumentEngine.newCells (cyclomatic 17): PhabricatorJupyterDocumentEngine.newCells has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/document/PhabricatorJupyterDocumentEngine.php"},"region":{"startLine":307}}}],"partialFingerprints":{"codehealthFindingId/v1":"b86b01fa83542d7483e2272b447e0f6b52dc9ec612edf6099cd9189a8c84563a"}},{"ruleId":"D1","level":"warning","message":{"text":"HeraldRuleController.setupEditorBehavior (cyclomatic 17): HeraldRuleController.setupEditorBehavior has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/controller/HeraldRuleController.php"},"region":{"startLine":400}}}],"partialFingerprints":{"codehealthFindingId/v1":"9b8b286f06ac0af9983033e4f35b000df32f4e0db3e10778f8a9accaf6d45daf"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorPeopleQuery.buildWhereClauseParts (cyclomatic 17): PhabricatorPeopleQuery.buildWhereClauseParts has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/query/PhabricatorPeopleQuery.php"},"region":{"startLine":242}}}],"partialFingerprints":{"codehealthFindingId/v1":"e0541a0b2e9ced07a137c29ee3f6e0c0bd8aa90bb67fde9c1e9ed7f795b1b401"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorPeopleQuery.rebuildAvailabilityCache (cyclomatic 17): PhabricatorPeopleQuery.rebuildAvailabilityCache has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/query/PhabricatorPeopleQuery.php"},"region":{"startLine":385}}}],"partialFingerprints":{"codehealthFindingId/v1":"a8f34057fb81daa89eff951824aa13478efc1e511b2e7ad64cd5711bd4c7bd4a"}},{"ruleId":"D1","level":"warning","message":{"text":"PhameLiveController.setupLiveEnvironment (cyclomatic 17): PhameLiveController.setupLiveEnvironment has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/PhameLiveController.php"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"48817007d4f670eaf72d8cbad48b034423616d5efbcc54b31a32af375ccee8cb"}},{"ruleId":"D1","level":"warning","message":{"text":"PhluxEditController.handleRequest (cyclomatic 17): PhluxEditController.handleRequest has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phlux/controller/PhluxEditController.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"2b5459139e6f2df58e223a565e7ace62989ea7ca04c948bab3a3a5c55118089a"}},{"ruleId":"D1","level":"warning","message":{"text":"PhortuneMerchantProviderEditController.handleMerchantRequest (cyclomatic 17): PhortuneMerchantProviderEditController.handleMerchantRequest has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/merchant/PhortuneMerchantProviderEditController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"9ca82142cc2c7d9ab5610ef7d4f1e95af85fc1e8e317932f8144437649444d9f"}},{"ruleId":"D1","level":"warning","message":{"text":"PhortuneOrderSummaryView.newMessagesView (cyclomatic 17): PhortuneOrderSummaryView.newMessagesView has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/view/PhortuneOrderSummaryView.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"c8f12fd844f77d01a9ef4f9b49bbd0d6b755be06d9aac913964ad39c7a09fcf6"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorProjectBoardReorderController.handleRequest (cyclomatic 17): PhabricatorProjectBoardReorderController.handleRequest has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectBoardReorderController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"ab9d9dd55802a61ae49f9f9f3eb4507bf5af9e365198817482edcd55a7089298"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorProjectEditPictureController.handleRequest (cyclomatic 17): PhabricatorProjectEditPictureController.handleRequest has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectEditPictureController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"3c0314edcbad5b2be36a0779f4a6157a5f9ee5ead4bc3e66dbe4c6dfb40f6afc"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorProjectUserListView.render (cyclomatic 17): PhabricatorProjectUserListView.render has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/view/PhabricatorProjectUserListView.php"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"c50a165f5df1d3d2fb886b1b39adaadc156b7c77ab9220be2aed8adbd252adb2"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorRepositorySvnCommitChangeParserWorker.parseRecursiveListFileData (cyclomatic 17): PhabricatorRepositorySvnCommitChangeParserWorker.parseRecursiveListFileData has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/commitchangeparser/PhabricatorRepositorySvnCommitChangeParserWorker.php"},"region":{"startLine":676}}}],"partialFingerprints":{"codehealthFindingId/v1":"0ac3dcb74f002adc429b1597dde9a8b3caa43fb1c4cc1546dc22cfbfb4ae696b"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorApplicationTransactionEditor.filterTransactions (cyclomatic 17): PhabricatorApplicationTransactionEditor.filterTransactions has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This is NOT this file\u0027s highest cyclomatic complexity: PhabricatorApplicationTransactionEditor.applyInternalEffects (cyclomatic 18) is higher and carries no row of its own \u2014 it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension\u0027s figures nor in its score."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":2772}}}],"partialFingerprints":{"codehealthFindingId/v1":"ad5ea45844ee7d2d41ffd512e7b2651df4a7d43ffe5b556221ed00f9d01ac9fe"}},{"ruleId":"D1","level":"warning","message":{"text":"PhutilDaemonHandle.update (cyclomatic 17): PhutilDaemonHandle.update has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/PhutilDaemonHandle.php"},"region":{"startLine":136}}}],"partialFingerprints":{"codehealthFindingId/v1":"f4baa555b47a12313d3b006b25b2c9abea2b5e86bec4aaba05e7bbaded234723"}},{"ruleId":"D1","level":"warning","message":{"text":"PhutilDefaultSyntaxHighlighterEngine.getHighlightFuture (cyclomatic 17): PhutilDefaultSyntaxHighlighterEngine.getHighlightFuture has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/syntax/engine/PhutilDefaultSyntaxHighlighterEngine.php"},"region":{"startLine":42}}}],"partialFingerprints":{"codehealthFindingId/v1":"7c2b48e157624eae4af5cfb9224cb6fdad713a067e8f25d9de8a84dc35037ed5"}},{"ruleId":"D1","level":"warning","message":{"text":"PhutilXHPASTSyntaxHighlighterFuture.findInterestingSymbols (cyclomatic 17): PhutilXHPASTSyntaxHighlighterFuture.findInterestingSymbols has cyclomatic complexity 17 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/syntax/highlighter/xhpast/PhutilXHPASTSyntaxHighlighterFuture.php"},"region":{"startLine":164}}}],"partialFingerprints":{"codehealthFindingId/v1":"112f16ccb41ae60c63220e5735835f75cf8d4e79ed4227968c198e7553c907fe"}},{"ruleId":"D1","level":"warning","message":{"text":"PHUICalendarMonthView.render (cyclomatic 17): PHUICalendarMonthView.render has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/calendar/PHUICalendarMonthView.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"acc97d34eced5439f2ab853a51da47d4395587dd6bdc80db869283e5aae12471"}},{"ruleId":"D1","level":"warning","message":{"text":"behavior-batch-selector.JX.behavior(\u0022maniphest-batch-selector\u0022) (cyclomatic 17): behavior-batch-selector.JX.behavior(\u0022maniphest-batch-selector\u0022) has cyclomatic complexity 17 (threshold 15). Most of this is not in the body itself: 1 of the 17 points is its own statement and the rest belongs to 6 function items inside it that branch (a function literal at line 96, clear_selection, change, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/maniphest/behavior-batch-selector.js"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"b44d0180e512683e713a03b441e9b1bb9e18639b95553726e1d18477a8a45f72"}},{"ruleId":"D1","level":"warning","message":{"text":"sortHandler (cyclomatic 17): sortHandler has cyclomatic complexity 17 (threshold 15). Most of this is not in the body itself: 6 of the 17 points are its own statements and the rest belongs to one function literal inside it that branches (line 221). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal\u0027s work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/Prefab.js"},"region":{"startLine":192}}}],"partialFingerprints":{"codehealthFindingId/v1":"06250e148687aed1d780e7c195d1a7992628591d783a3ba78ed426a5c71215ae"}},{"ruleId":"D1","level":"warning","message":{"text":"_getInlinesByType (cyclomatic 17): _getInlinesByType has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":1968}}}],"partialFingerprints":{"codehealthFindingId/v1":"7b434e1d6da8371374427116adfe37e8810095d208ec3fe96d599ff33b7bdab1"}},{"ruleId":"D1","level":"warning","message":{"text":"(anonymous) (cyclomatic 17): (anonymous) has cyclomatic complexity 17 (threshold 15). Most of this is not in the body itself: 1 of the 17 points is its own statement and the rest belongs to 10 function items inside it that branch (a function literal at line 96, clear_selection, change, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/maniphest/behavior-batch-selector.js"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"30511d5e9d5630174acb36a273ea19c82842a4783bc024f2d09abc083dc5092d"}},{"ruleId":"D1","level":"warning","message":{"text":"PhutilICSParser.parseICSProperty (cyclomatic 16): PhutilICSParser.parseICSProperty has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/ics/PhutilICSParser.php"},"region":{"startLine":191}}}],"partialFingerprints":{"codehealthFindingId/v1":"759d8f45c11f2c4eef36c99ca74fb1b57e78dbc68bdd096449f2b2573d9b1656"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorConduitMethodQuery.filterMethods (cyclomatic 16): PhabricatorConduitMethodQuery.filterMethods has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conduit/query/PhabricatorConduitMethodQuery.php"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"c014b7d9b746dc32fefb5e9d93fb3c92a340ba08caddc89d06fe36ee6891ec08"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorPathSetupCheck.executeChecks (cyclomatic 16): PhabricatorPathSetupCheck.executeChecks has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/check/PhabricatorPathSetupCheck.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"1c95775892f5dbbcb80cdaa5b6dbdd50de6e1619e82a5b56b7ad3ea606be5a11"}},{"ruleId":"D1","level":"warning","message":{"text":"ConpherenceTransactionRenderer.renderTransactions (cyclomatic 16): ConpherenceTransactionRenderer.renderTransactions has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/ConpherenceTransactionRenderer.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"7f217533664a2e4ce2cf90e808723f5afcf6333d821c18a0ced018bf69147b10"}},{"ruleId":"D1","level":"warning","message":{"text":"ConpherenceRoomPictureController.handleRequest (cyclomatic 16): ConpherenceRoomPictureController.handleRequest has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceRoomPictureController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"e1eb860338e7f5c0dfdfd08ff9fee330c3d14c9c56dfef84ac0b4daf052c46a4"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialDiffCreateController.handleRequest (cyclomatic 16): DifferentialDiffCreateController.handleRequest has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/controller/DifferentialDiffCreateController.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"c9ac74e6575cec16df8bb3564451c9532f3b6b85e771f85841cf7922a9062b05"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialTransactionEditor.expandCustomRemarkupBlockTransactions (cyclomatic 16): DifferentialTransactionEditor.expandCustomRemarkupBlockTransactions has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/editor/DifferentialTransactionEditor.php"},"region":{"startLine":807}}}],"partialFingerprints":{"codehealthFindingId/v1":"8ca7ea39919a59e1bb2a87cba7bc65db680bc40ad7fd702975031b25fcac99e1"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialDiffExtractionEngine.isDiffChangedBeforeCommit (cyclomatic 16): DifferentialDiffExtractionEngine.isDiffChangedBeforeCommit has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/engine/DifferentialDiffExtractionEngine.php"},"region":{"startLine":119}}}],"partialFingerprints":{"codehealthFindingId/v1":"cbb43cd12d6b58e4ef2d39382cf972d82696350b6b0662f43bd94f62ee8cbc63"}},{"ruleId":"D1","level":"warning","message":{"text":"DifferentialRevisionReviewTransaction.applyReviewerEffect (cyclomatic 16): DifferentialRevisionReviewTransaction.applyReviewerEffect has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/xaction/DifferentialRevisionReviewTransaction.php"},"region":{"startLine":163}}}],"partialFingerprints":{"codehealthFindingId/v1":"e6b7385a02fdb894579596069e59e7a437648578e52b9cbb0419f53a5b4d0b60"}},{"ruleId":"D1","level":"warning","message":{"text":"DrydockManagementLeaseWorkflow.execute (cyclomatic 16): DrydockManagementLeaseWorkflow.execute has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/management/DrydockManagementLeaseWorkflow.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"d1fbe49215a318eafc8dafe740a3e79901375c78ebde71635250aea650fde6cd"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorTransactionFactEngine.groupTransactions (cyclomatic 16): PhabricatorTransactionFactEngine.groupTransactions has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fact/engine/PhabricatorTransactionFactEngine.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"d5f626bcbfcb6729d38b38c5c00bae291f62cce5cb7e30d5f60d4a6cdb9a4276"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorFeedTransactionQuery.loadPage (cyclomatic 16): PhabricatorFeedTransactionQuery.loadPage has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/feed/query/PhabricatorFeedTransactionQuery.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"b38c9faab8ae77089bfb3b0971d47db7f72de3c4ea4daeeecd81576efb772e62"}},{"ruleId":"D1","level":"warning","message":{"text":"FileAllocateConduitAPIMethod.execute (cyclomatic 16): FileAllocateConduitAPIMethod.execute has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/conduit/FileAllocateConduitAPIMethod.php"},"region":{"startLine":28}}}],"partialFingerprints":{"codehealthFindingId/v1":"cf7d2311efe35c5ab109723c63e029c3fa4f027557db78324728494d78235464"}},{"ruleId":"D1","level":"warning","message":{"text":"HeraldRuleController.handleRequest (cyclomatic 16): HeraldRuleController.handleRequest has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/controller/HeraldRuleController.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"f460afd89f9f46d2f1e160422beaf39ee9045ef33edc3d176f05265ba6714597"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorMetaMTAMemberQuery.execute (cyclomatic 16): PhabricatorMetaMTAMemberQuery.execute has cyclomatic complexity 16 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/query/PhabricatorMetaMTAMemberQuery.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"263dafbf34785479c3dbe78e9a3f7a9faee27496c5db634f75470dfe20ae13a6"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorPeopleSearchEngine.renderResultList (cyclomatic 16): PhabricatorPeopleSearchEngine.renderResultList has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/query/PhabricatorPeopleSearchEngine.php"},"region":{"startLine":233}}}],"partialFingerprints":{"codehealthFindingId/v1":"f3ce5bea05a30553bd120b673437cc691d7d10bc22d0fe337534e7fca4c724db"}},{"ruleId":"D1","level":"warning","message":{"text":"PhameBlogProfilePictureController.handleRequest (cyclomatic 16): PhameBlogProfilePictureController.handleRequest has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/blog/PhameBlogProfilePictureController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"b884f2b918adffa14ac8eb418de290779b33a47521eae2c7036dda164eabf435"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorProjectColumnQuery.didFilterPage (cyclomatic 16): PhabricatorProjectColumnQuery.didFilterPage has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/query/PhabricatorProjectColumnQuery.php"},"region":{"startLine":88}}}],"partialFingerprints":{"codehealthFindingId/v1":"bd83ffd9ecb97996d591fe299335a6e1ac8edf6fcf366ef74f0ea227138563bd"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorRepositoryPullEngine.executeGitUpdate (cyclomatic 16): PhabricatorRepositoryPullEngine.executeGitUpdate has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/engine/PhabricatorRepositoryPullEngine.php"},"region":{"startLine":275}}}],"partialFingerprints":{"codehealthFindingId/v1":"46563bcebdc7f9228c71036850a8639aeca057c73aeca2dc95aceba1a1949105"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorRepositoryRefEngine.updateCursors (cyclomatic 16): PhabricatorRepositoryRefEngine.updateCursors has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/engine/PhabricatorRepositoryRefEngine.php"},"region":{"startLine":258}}}],"partialFingerprints":{"codehealthFindingId/v1":"fb3f04d8dcffbecd3ba4ea55738d655031257decd3650df962bf6877fc311c69"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorElasticFulltextStorageEngine.buildSpec (cyclomatic 16): PhabricatorElasticFulltextStorageEngine.buildSpec has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/fulltextstorage/PhabricatorElasticFulltextStorageEngine.php"},"region":{"startLine":108}}}],"partialFingerprints":{"codehealthFindingId/v1":"1821cf979ae6dbe0ba2bb5c394859c9398e261e48738e967d02fb1010279af5c"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorEmailAddressesSettingsPanel.returnNewAddressResponse (cyclomatic 16): PhabricatorEmailAddressesSettingsPanel.returnNewAddressResponse has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php"},"region":{"startLine":158}}}],"partialFingerprints":{"codehealthFindingId/v1":"f239d53f4816c42d5c3c4b52ea75a0db431d0988bb13bb06dec80efe8c88aec0"}},{"ruleId":"D1","level":"warning","message":{"text":"PhabricatorInternationalizationManagementExtractWorkflow.extractFiles (cyclomatic 16): PhabricatorInternationalizationManagementExtractWorkflow.extractFiles has cyclomatic complexity 16 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/internationalization/management/PhabricatorInternationalizationManagementExtractWorkflow.php"},"region":{"startLine":127}}}],"partialFingerprints":{"codehealthFindingId/v1":"71be560bb0b4c7d51d10f4b3932595c4edf531f9e26875bd3f926ba8b5809644"}},{"ruleId":"D1","level":"warning","message":{"text":"PhutilRemarkupListBlockRule.getMatchingLineCount (cyclomatic 16): PhutilRemarkupListBlockRule.getMatchingLineCount has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/blockrule/PhutilRemarkupListBlockRule.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"76563a0905647e3a9d77679d9539d82f3998eb7aed59d592307d3efbc60d908c"}},{"ruleId":"D1","level":"warning","message":{"text":"PHUIButtonView.getTagAttributes (cyclomatic 16): PHUIButtonView.getTagAttributes has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIButtonView.php"},"region":{"startLine":172}}}],"partialFingerprints":{"codehealthFindingId/v1":"50f68a18bbe16fa378a76b6f87bd067cc18226f65ddde8f38fe6ca7d3f64bc91"}},{"ruleId":"D1","level":"warning","message":{"text":"behavior-desktop-notifications-control.JX.behavior(\u0022desktop-notifications-control\u0022) (cyclomatic 16): behavior-desktop-notifications-control.JX.behavior(\u0022desktop-notifications-control\u0022) has cyclomatic complexity 16 (threshold 15). Most of this is not in the body itself: 3 of the 16 points are its own statements and the rest belongs to 5 function items inside it that branch (updateFormStatus, updateBrowserStatus, a function literal at line 82, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/aphlict/behavior-desktop-notifications-control.js"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"3377d9dc3571d7a19d7411101767dce28d8ebff534d2c85da49d6c25a64f6275"}},{"ruleId":"D1","level":"warning","message":{"text":"behavior-policy-control.JX.behavior(\u0022policy-control\u0022) (cyclomatic 16): behavior-policy-control.JX.behavior(\u0022policy-control\u0022) has cyclomatic complexity 16 (threshold 15). Most of this is not in the body itself: 2 of the 16 points are its own statements and the rest belongs to 5 function items inside it that branch (a function literal at line 30, add_policy, render_option, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/policy/behavior-policy-control.js"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"0f94e6adfdef518e1aac981a12ea588d7312b8519495c83447afe72a2b48ce12"}},{"ruleId":"D1","level":"warning","message":{"text":"behavior-time-typeahead.JX.behavior(\u0022time-typeahead\u0022)::getNewValue (cyclomatic 16): behavior-time-typeahead.JX.behavior(\u0022time-typeahead\u0022)::getNewValue has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-time-typeahead.js"},"region":{"startLine":82}}}],"partialFingerprints":{"codehealthFindingId/v1":"6813227519dc1dba2db1a8a2d057277fea19c9e7a86f5f48c6102dc09540ad33"}},{"ruleId":"D1","level":"warning","message":{"text":"behavior-watch-anchor.JX.behavior(\u0022phabricator-watch-anchor\u0022)::seek_anchor (cyclomatic 16): behavior-watch-anchor.JX.behavior(\u0022phabricator-watch-anchor\u0022)::seek_anchor has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-watch-anchor.js"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"1f8eb8f600e28092e355bf641714a8727612515b8f6700b91858f55b62f8ea08"}},{"ruleId":"D1","level":"warning","message":{"text":"(anonymous)::getNewValue (cyclomatic 16): (anonymous)::getNewValue has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-time-typeahead.js"},"region":{"startLine":82}}}],"partialFingerprints":{"codehealthFindingId/v1":"f839547c454e3d4a2a407f254a8cc611ed670b2b11f88e89d2a9f3ea660543ca"}},{"ruleId":"D1","level":"warning","message":{"text":"(anonymous)::seek_anchor (cyclomatic 16): (anonymous)::seek_anchor has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-watch-anchor.js"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"85fd1e7e1ff6092ee8d5e5af85b0f15fc8c30d35ecd168085dc8b6289e7af8ea"}},{"ruleId":"D1","level":"warning","message":{"text":"_onresults (cyclomatic 16): _onresults has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This is NOT this file\u0027s highest cyclomatic complexity: _activate (cyclomatic 17) is higher and carries no row of its own \u2014 it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension\u0027s figures nor in its score."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/phuix/PHUIXAutocomplete.js"},"region":{"startLine":230}}}],"partialFingerprints":{"codehealthFindingId/v1":"ce21499bc78bbdb96ff110a27248d07e9b4b3c86bd5313fcee9badaedfa4f833"}},{"ruleId":"D1","level":"warning","message":{"text":"(anonymous) (cyclomatic 16): (anonymous) has cyclomatic complexity 16 (threshold 15). Most of this is not in the body itself: 3 of the 16 points are its own statements and the rest belongs to 9 function items inside it that branch (updateFormStatus, updateBrowserStatus, a function literal at line 82, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/aphlict/behavior-desktop-notifications-control.js"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"5f706903417cbda399362f9ebb30bd6ca7152337e811c0c0442c0897075de2bf"}},{"ruleId":"D1","level":"warning","message":{"text":"_onmenu (cyclomatic 16): _onmenu has cyclomatic complexity 16 (threshold 15). Most of this is not in the body itself: 4 of the 16 points are its own statements and the rest belongs to 13 function items inside it that branch (a function literal at line 1112, a function literal at line 972, add_link, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":900}}}],"partialFingerprints":{"codehealthFindingId/v1":"7fc6244c825f4681e390ce1528650acba856fe8b50da09ba6674e114351c3795"}},{"ruleId":"D1","level":"warning","message":{"text":"_newHoverMap (cyclomatic 16): _newHoverMap has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":1539}}}],"partialFingerprints":{"codehealthFindingId/v1":"535690e5f5266b45c2205921c4a9e6adf0ffb8df9c1a9732b4c41882e50409b2"}},{"ruleId":"D1","level":"warning","message":{"text":"(anonymous) (cyclomatic 16): (anonymous) has cyclomatic complexity 16 (threshold 15). Most of this is not in the body itself: 2 of the 16 points are its own statements and the rest belongs to 13 function items inside it that branch (a function literal at line 30, add_policy, render_option, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/policy/behavior-policy-control.js"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"6406d280aaaa45063d9b584c6d591c5abaae9b40b9df0210e196493f24758b68"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorAuthRegisterController.handleRequest (cognitive 208): PhabricatorAuthRegisterController.handleRequest has cognitive complexity 208 (threshold 15). Drivers by points: if/else 91 (187 pts), boolean chains 10, error handling 2 (6 pts), ternaries 4 (5 pts) (nesting depth added 101). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthRegisterController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"97c6f84f3d1867bed9a626923bfed053b14d8d3f59d0af8414414ab446a3e67f"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialChangesetTwoUpRenderer.renderTextChange (cognitive 174): DifferentialChangesetTwoUpRenderer.renderTextChange has cognitive complexity 174 (threshold 15). Drivers by points: if/else 45 (132 pts), ternaries 4 (16 pts), loops 5 (14 pts), boolean chains 12 (nesting depth added 108). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"743cc57d72ea675b371df297e8bbecff15df422975960f17c488946a80b6bddb"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransaction.getTitle (cognitive 163): PhabricatorApplicationTransaction.getTitle has cognitive complexity 163 (threshold 15). Drivers by points: if/else 62 (141 pts), boolean chains 11, loops 3 (8 pts), error handling 1 (2 pts), match/switch 1 (nesting depth added 85). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorApplicationTransaction.php"},"region":{"startLine":943}}}],"partialFingerprints":{"codehealthFindingId/v1":"fc69032d03e5c0e5df3361d73b97cd22b03c35d66d9e10c722316e58a488d48a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilSearchQueryCompiler.tokenizeQuery (cognitive 154): PhutilSearchQueryCompiler.tokenizeQuery has cognitive complexity 154 (threshold 15). Drivers by points: if/else 51 (130 pts), loops 5 (10 pts), match/switch 3 (8 pts), boolean chains 6 (nesting depth added 89). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/compiler/PhutilSearchQueryCompiler.php"},"region":{"startLine":104}}}],"partialFingerprints":{"codehealthFindingId/v1":"4c7994ca1ba98ffbbd79f0c96b8246808d284a30931bd6a47e4f1f7a23a9a15b"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorStorageManagementWorkflow.doAdjustSchemata (cognitive 154): PhabricatorStorageManagementWorkflow.doAdjustSchemata has cognitive complexity 154 (threshold 15). Drivers by points: if/else 41 (125 pts), match/switch 3 (15 pts), loops 5 (8 pts), boolean chains 3, error handling 1 (3 pts) (nesting depth added 101). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php"},"region":{"startLine":159}}}],"partialFingerprints":{"codehealthFindingId/v1":"3d7e4575670c5ade26e4a9c5685a4e8036ba061859e70e8ccbe11b6e23669aae"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionCommitController.handleRequest (cognitive 152): DiffusionCommitController.handleRequest has cognitive complexity 152 (threshold 15). Drivers by points: if/else 44 (114 pts), loops 4 (25 pts), match/switch 1 (7 pts), boolean chains 6 (nesting depth added 97). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionCommitController.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"39f27336579e940f8489a41a63ad7ef1fa9c15ba19ebfc6b8d76625c205eeccc"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialChangesetParser.render (cognitive 150): DifferentialChangesetParser.render has cognitive complexity 150 (threshold 15). Drivers by points: if/else 57 (120 pts), loops 11 (21 pts), boolean chains 8, match/switch 1 (nesting depth added 73). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialChangesetParser.php"},"region":{"startLine":749}}}],"partialFingerprints":{"codehealthFindingId/v1":"bc3f9fa00837275684e30559cd2d6db791e3372be5b7389ec0090537507e454a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositorySvnCommitChangeParserWorker.parseCommitChanges (cognitive 149): PhabricatorRepositorySvnCommitChangeParserWorker.parseCommitChanges has cognitive complexity 149 (threshold 15). Drivers by points: if/else 36 (113 pts), loops 17 (28 pts), match/switch 2 (5 pts), boolean chains 3 (nesting depth added 91). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/commitchangeparser/PhabricatorRepositorySvnCommitChangeParserWorker.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"1af77665ec5972035ff27080ab57d27e1df17bac590f3577953bb549be881032"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorStorageManagementWorkflow.doUpgradeSchemata (cognitive 126): PhabricatorStorageManagementWorkflow.doUpgradeSchemata has cognitive complexity 126 (threshold 15). Drivers by points: if/else 34 (96 pts), loops 12 (26 pts), boolean chains 4 (nesting depth added 76). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php"},"region":{"startLine":918}}}],"partialFingerprints":{"codehealthFindingId/v1":"543c3f44ca514ca622a98fd3f29ef302609f2c3488b91c31cfabdb1791258264"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryMercurialCommitChangeParserWorker.parseCommitChanges (cognitive 123): PhabricatorRepositoryMercurialCommitChangeParserWorker.parseCommitChanges has cognitive complexity 123 (threshold 15). Drivers by points: if/else 43 (97 pts), loops 15 (18 pts), ternaries 3 (6 pts), boolean chains 2 (nesting depth added 60). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryMercurialCommitChangeParserWorker.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"8fc851904f79023a19a91127beaa60bf3d6c5110b9916d27fb5b6224a3663c3c"}},{"ruleId":"D2","level":"warning","message":{"text":"HarbormasterBuildLogRenderController.handleRequest (cognitive 117): HarbormasterBuildLogRenderController.handleRequest has cognitive complexity 117 (threshold 15). Drivers by points: if/else 43 (89 pts), loops 15 (23 pts), boolean chains 5 (nesting depth added 54). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"d0227c5c41ae168fdc8f5bc3f4a3b2179acfbe945b0954f15a5fdcc2aade9483"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialChangesetEngine.detectCopiedCode (cognitive 115): DifferentialChangesetEngine.detectCopiedCode has cognitive complexity 115 (threshold 15). Drivers by points: if/else 15 (71 pts), loops 12 (35 pts), ternaries 2 (9 pts) (nesting depth added 86). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/engine/DifferentialChangesetEngine.php"},"region":{"startLine":162}}}],"partialFingerprints":{"codehealthFindingId/v1":"e38794fa079b6750ae50b9a24e46ff62355cb8c1cc605a26fcd072f870c47e2f"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationSearchController.processSearchRequest (cognitive 112): PhabricatorApplicationSearchController.processSearchRequest has cognitive complexity 112 (threshold 15). Drivers by points: if/else 40 (78 pts), loops 5 (16 pts), boolean chains 8, error handling 4 (8 pts), ternaries 1 (2 pts) (nesting depth added 54). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/controller/PhabricatorApplicationSearchController.php"},"region":{"startLine":95}}}],"partialFingerprints":{"codehealthFindingId/v1":"df844f67cd552fb0e6d9d38b62cce4e7daeeebc6c633d9aa69e705553ef963a0"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionCommitQuery.buildWhereClauseParts (cognitive 111): DiffusionCommitQuery.buildWhereClauseParts has cognitive complexity 111 (threshold 15). Drivers by points: if/else 48 (96 pts), loops 5 (12 pts), error handling 1 (3 pts) (nesting depth added 57). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/DiffusionCommitQuery.php"},"region":{"startLine":536}}}],"partialFingerprints":{"codehealthFindingId/v1":"1464858da01a31fab7e83d142276715ad9962466b2c4379f661114c43ecb53e8"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionMercurialWireClientSSHProtocolChannel.decodeStream (cognitive 111): DiffusionMercurialWireClientSSHProtocolChannel.decodeStream has cognitive complexity 111 (threshold 15). Drivers by points: if/else 30 (109 pts), boolean chains 1, loops 1 (nesting depth added 79). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/ssh/DiffusionMercurialWireClientSSHProtocolChannel.php"},"region":{"startLine":79}}}],"partialFingerprints":{"codehealthFindingId/v1":"3e2291b33db6de2b3febc38b4aebb4c08a32353649427423588caf41b8987e64"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorStorageManagementWorkflow.findAdjustments (cognitive 111): PhabricatorStorageManagementWorkflow.findAdjustments has cognitive complexity 111 (threshold 15). Drivers by points: if/else 25 (86 pts), loops 8 (22 pts), boolean chains 3 (nesting depth added 75). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php"},"region":{"startLine":534}}}],"partialFingerprints":{"codehealthFindingId/v1":"7726a951e00ccba71dda367fd749d062e8110d98232ebfbcc51321cbe888a1b4"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionURIEditor.validateTransaction (cognitive 105): DiffusionURIEditor.validateTransaction has cognitive complexity 105 (threshold 15). Drivers by points: if/else 23 (81 pts), loops 7 (16 pts), match/switch 2 (4 pts), error handling 1 (3 pts), boolean chains 1 (nesting depth added 71). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/editor/DiffusionURIEditor.php"},"region":{"startLine":156}}}],"partialFingerprints":{"codehealthFindingId/v1":"97b345e28138ac67f807547893dcdd8daa9b64090cbaa8943e0f44fac41cb988"}},{"ruleId":"D2","level":"warning","message":{"text":"AphrontTableView.render (cognitive 105): AphrontTableView.render has cognitive complexity 105 (threshold 15). Drivers by points: if/else 30 (76 pts), loops 12 (26 pts), boolean chains 3 (nesting depth added 60). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/control/AphrontTableView.php"},"region":{"startLine":131}}}],"partialFingerprints":{"codehealthFindingId/v1":"b5d1269d6fa7d131b0b3f077d4945210a68af1e97c64796f7d3054aaae7c44bf"}},{"ruleId":"D2","level":"warning","message":{"text":"qsprintf.xsprintf_query (cognitive 102): qsprintf.xsprintf_query has cognitive complexity 102 (threshold 15). Drivers by points: if/else 28 (61 pts), loops 8 (24 pts), match/switch 6 (12 pts), boolean chains 4, ternaries 1 (nesting depth added 55). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/xsprintf/qsprintf.php"},"region":{"startLine":90}}}],"partialFingerprints":{"codehealthFindingId/v1":"a9c0b90818c7fd61fbd36ae9244a826afb163496855809e4345c10235c796674"}},{"ruleId":"D2","level":"warning","message":{"text":"HeraldEngine.getRuleMatchResult (cognitive 100): HeraldEngine.getRuleMatchResult has cognitive complexity 100 (threshold 15). Drivers by points: if/else 21 (63 pts), error handling 4 (28 pts), loops 1 (6 pts), boolean chains 3 (nesting depth added 71). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/engine/HeraldEngine.php"},"region":{"startLine":379}}}],"partialFingerprints":{"codehealthFindingId/v1":"cdf670a7371f64ddf02c8d8017f1bab207241037b20bcb336c6759e37424df15"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorManiphestTaskFactEngine.newDatapointsForObject (cognitive 99): PhabricatorManiphestTaskFactEngine.newDatapointsForObject has cognitive complexity 99 (threshold 15). Drivers by points: if/else 24 (68 pts), loops 8 (20 pts), match/switch 2 (7 pts), boolean chains 4 (nesting depth added 61). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fact/engine/PhabricatorManiphestTaskFactEngine.php"},"region":{"startLine":86}}}],"partialFingerprints":{"codehealthFindingId/v1":"45abe52d75580907c751dc00d24ff177957a70496d698b7d6421ad7f7f0d0c12"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCalendarImportEngine.importEventDocument (cognitive 97): PhabricatorCalendarImportEngine.importEventDocument has cognitive complexity 97 (threshold 15). Drivers by points: if/else 29 (61 pts), loops 18 (28 pts), error handling 1 (3 pts), match/switch 1 (3 pts), boolean chains 2 (nesting depth added 46). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/import/PhabricatorCalendarImportEngine.php"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"202ab981a7e9ee874d38421dc2f62de7a54e8fb07250e43eeda35efc176c87e3"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransactionEditor.applyTransactions (cognitive 97): PhabricatorApplicationTransactionEditor.applyTransactions has cognitive complexity 97 (threshold 15). Drivers by points: if/else 39 (73 pts), loops 12 (21 pts), error handling 2, boolean chains 1 (nesting depth added 43). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":1175}}}],"partialFingerprints":{"codehealthFindingId/v1":"cedcec8b3b1b8b767e285d9c59c0b106800f79e3f3c21c798de06a79dc687c39"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorInlineCommentAdjustmentEngine.execute (cognitive 97): PhabricatorInlineCommentAdjustmentEngine.execute has cognitive complexity 97 (threshold 15). Drivers by points: if/else 37 (77 pts), loops 13 (17 pts), ternaries 1 (3 pts) (nesting depth added 46). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"70eb6c182c7bae59369c0856c9f65e2b421c92128c71a30e308f8e0c23385216"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionCommitHookEngine.findMercurialChangegroupRefUpdates (cognitive 92): DiffusionCommitHookEngine.findMercurialChangegroupRefUpdates has cognitive complexity 92 (threshold 15). Drivers by points: if/else 21 (60 pts), loops 10 (28 pts), boolean chains 4 (nesting depth added 57). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/engine/DiffusionCommitHookEngine.php"},"region":{"startLine":743}}}],"partialFingerprints":{"codehealthFindingId/v1":"a45d10f87554dad8f323ace87007a4238b394c47402a4cab1aeea4f6f4374aee"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorEditEngine.buildEditResponse (cognitive 92): PhabricatorEditEngine.buildEditResponse has cognitive complexity 92 (threshold 15). Drivers by points: if/else 30 (63 pts), loops 9 (23 pts), boolean chains 4, error handling 1 (2 pts) (nesting depth added 48). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editengine/PhabricatorEditEngine.php"},"region":{"startLine":1033}}}],"partialFingerprints":{"codehealthFindingId/v1":"c88d59d2579ac18deeda92ac1cb89ca16c1ec5945a7bd6cbee04571b11855fa2"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous) (cognitive 91): (anonymous) has cognitive complexity 91 (threshold 15). Drivers by points: if/else 66 (76 pts), loops 8, boolean chains 5, ternaries 2 (nesting depth added 10). Most of this is not in the body itself: 1 of the 91 points is its own statement and the rest belongs to 50 function items inside it that branch (redraw_inlines, render_image_info, resize_selection, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"eee4d41af475b44fc27ac21b4d15e48d1250b2696ff11b41930698a38c05d590"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionSubversionWireProtocol.writeData (cognitive 89): DiffusionSubversionWireProtocol.writeData has cognitive complexity 89 (threshold 15). Drivers by points: if/else 26 (88 pts), loops 1 (nesting depth added 62). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/protocol/DiffusionSubversionWireProtocol.php"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"c88506dd1614ba9933ddc3618839ea6bb51189ceb4cedef2570766a403704e6d"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilCalendarRecurrenceRule.newDaysSet (cognitive 88): PhutilCalendarRecurrenceRule.newDaysSet has cognitive complexity 88 (threshold 15). Drivers by points: if/else 30 (76 pts), loops 3 (7 pts), boolean chains 5 (nesting depth added 50). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php"},"region":{"startLine":1178}}}],"partialFingerprints":{"codehealthFindingId/v1":"5d4c8cce73e921bff7ed910f81868a6079f3658358cc081e1221f613850f21f9"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorStorageManagementDumpWorkflow.didExecute (cognitive 88): PhabricatorStorageManagementDumpWorkflow.didExecute has cognitive complexity 88 (threshold 15). Drivers by points: if/else 40 (69 pts), loops 7 (11 pts), error handling 2 (3 pts), match/switch 1 (3 pts), boolean chains 2 (nesting depth added 36). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php"},"region":{"startLine":64}}}],"partialFingerprints":{"codehealthFindingId/v1":"2672008ac2656d4e8932af01af6335479c2b423a0f28418b79147ccc0039619f"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-pholio-mock-view.JX.behavior(\u0022pholio-mock-view\u0022) (cognitive 88): behavior-pholio-mock-view.JX.behavior(\u0022pholio-mock-view\u0022) has cognitive complexity 88 (threshold 15). Drivers by points: if/else 64 (74 pts), loops 7, boolean chains 5, ternaries 2 (nesting depth added 10). Most of this is not in the body itself: 1 of the 88 points is its own statement and the rest belongs to 29 function items inside it that branch (redraw_inlines, render_image_info, resize_selection, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"ef3ffdcf512fdb0eae514ce61d037916f60d1376097ac93e230c498383290643"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialChangesetOneUpRenderer.renderDocumentEngineBlocks (cognitive 87): DifferentialChangesetOneUpRenderer.renderDocumentEngineBlocks has cognitive complexity 87 (threshold 15). Drivers by points: if/else 30 (69 pts), loops 8 (15 pts), boolean chains 3 (nesting depth added 46). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetOneUpRenderer.php"},"region":{"startLine":270}}}],"partialFingerprints":{"codehealthFindingId/v1":"945d9bcbe58bafd64aca1a928fbf632c832584d8bd55d85a9767950839eca767"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialRevisionViewController.handleRequest (cognitive 86): DifferentialRevisionViewController.handleRequest has cognitive complexity 86 (threshold 15). Drivers by points: if/else 45 (57 pts), loops 16 (24 pts), boolean chains 4, ternaries 1 (nesting depth added 20). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/controller/DifferentialRevisionViewController.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"cbbcf8d539e3e3e791465198deaf3848962494c864dde8a125802f1c4d9da17f"}},{"ruleId":"D2","level":"warning","message":{"text":"PhrictionDocumentController.handleRequest (cognitive 86): PhrictionDocumentController.handleRequest has cognitive complexity 86 (threshold 15). Drivers by points: if/else 41 (84 pts), boolean chains 1, loops 1 (nesting depth added 43). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/controller/PhrictionDocumentController.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"92173e4f3fd2fc78b4ed5d8d73306fa64a63b958ed59ffdfbc868bca39d6aa22"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorFilesManagementIntegrityWorkflow.execute (cognitive 85): PhabricatorFilesManagementIntegrityWorkflow.execute has cognitive complexity 85 (threshold 15). Drivers by points: if/else 39 (74 pts), boolean chains 7, error handling 1 (3 pts), loops 1 (nesting depth added 37). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/management/PhabricatorFilesManagementIntegrityWorkflow.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"97dd04a0b690ac7ac90d19e5f9a3234d7f6daf7d055ddcdf785369d277c0743f"}},{"ruleId":"D2","level":"warning","message":{"text":"PHUIDiffGraphView.renderRawGraph (cognitive 85): PHUIDiffGraphView.renderRawGraph has cognitive complexity 85 (threshold 15). Drivers by points: if/else 19 (58 pts), loops 9 (26 pts), boolean chains 1 (nesting depth added 56). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/view/PHUIDiffGraphView.php"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"7aba20d69852f0e54377e3935ffb9b04bef7529e08e0f6166b9a1006b1a4609e"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialHunkParser.makeContextDiff (cognitive 84): DifferentialHunkParser.makeContextDiff has cognitive complexity 84 (threshold 15). Drivers by points: if/else 17 (73 pts), boolean chains 7, loops 2 (4 pts) (nesting depth added 58). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialHunkParser.php"},"region":{"startLine":665}}}],"partialFingerprints":{"codehealthFindingId/v1":"b78e3621ee5e7ccfc28c576bd5cef6e565c346a2fd1c8d6f534b7bb0f7bc2c51"}},{"ruleId":"D2","level":"warning","message":{"text":"PhortunePaymentMethodCreateController.handleRequest (cognitive 84): PhortunePaymentMethodCreateController.handleRequest has cognitive complexity 84 (threshold 15). Drivers by points: if/else 33 (69 pts), error handling 3 (11 pts), boolean chains 2, loops 2 (nesting depth added 44). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/paymentmethod/PhortunePaymentMethodCreateController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"d367bef2530cbf80d67770f9fe09c7eb8ef885428a58e5d471e21dc8a38275b7"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialChangesetOneUpRenderer.renderPrimitives (cognitive 83): DifferentialChangesetOneUpRenderer.renderPrimitives has cognitive complexity 83 (threshold 15). Drivers by points: if/else 28 (79 pts), match/switch 1 (2 pts), boolean chains 1, loops 1 (nesting depth added 52). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetOneUpRenderer.php"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"a66902e5271377dc5f2d3b3ea29b766ea62868cbdd09f146ba45b65e302f95ed"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectColumnBulkMoveController.handleRequest (cognitive 83): PhabricatorProjectColumnBulkMoveController.handleRequest has cognitive complexity 83 (threshold 15). Drivers by points: if/else 37 (75 pts), loops 4 (8 pts) (nesting depth added 42). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectColumnBulkMoveController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"4e8783fd85757f5274004661f80d3d87c300379d9a2d0ccf9a2aca6c1de8a3de"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryManagementReparseWorkflow.execute (cognitive 82): PhabricatorRepositoryManagementReparseWorkflow.execute has cognitive complexity 82 (threshold 15). Drivers by points: if/else 33 (68 pts), boolean chains 6, error handling 1 (3 pts), loops 2 (3 pts), match/switch 1 (2 pts) (nesting depth added 39). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/management/PhabricatorRepositoryManagementReparseWorkflow.php"},"region":{"startLine":81}}}],"partialFingerprints":{"codehealthFindingId/v1":"6c89e1bec3091c3aa79fd974ad608612418c4c950fd108e732b048389e102e57"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilRemarkupListBlockRule.renderTree (cognitive 81): PhutilRemarkupListBlockRule.renderTree has cognitive complexity 81 (threshold 15). Drivers by points: if/else 23 (54 pts), loops 4 (12 pts), match/switch 3 (9 pts), ternaries 1 (5 pts), boolean chains 1 (nesting depth added 49). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/blockrule/PhutilRemarkupListBlockRule.php"},"region":{"startLine":428}}}],"partialFingerprints":{"codehealthFindingId/v1":"9db9b00f84457229c313775bb532b812562d1723258de611edb6e08ef413eb47"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorFactObjectController.handleRequest (cognitive 80): PhabricatorFactObjectController.handleRequest has cognitive complexity 80 (threshold 15). Drivers by points: if/else 18 (41 pts), loops 19 (39 pts) (nesting depth added 43). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fact/controller/PhabricatorFactObjectController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"141e10efdac84ab91181e86e2c6c52d041a8d97d011598c2018ef70d2f430132"}},{"ruleId":"D2","level":"warning","message":{"text":"repository-crossreference.JX.behavior(\u0022repository-crossreference\u0022) (cognitive 80): repository-crossreference.JX.behavior(\u0022repository-crossreference\u0022) has cognitive complexity 80 (threshold 15). Drivers by points: if/else 42 (55 pts), boolean chains 14, loops 6 (8 pts), error handling 3 (nesting depth added 15). Most of this is not in the body itself: 2 of the 80 points are its own statements and the rest belongs to 13 function items inside it that branch (a function literal at line 325, openSearch, a function literal at line 58, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/repository/repository-crossreference.js"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"0e5d0045e81ddcef5e005049815b7ac00b0740f41ebb3c758b9bf84414feb454"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorTypeaheadModularDatasourceController.handleRequest (cognitive 77): PhabricatorTypeaheadModularDatasourceController.handleRequest has cognitive complexity 77 (threshold 15). Drivers by points: if/else 26 (62 pts), loops 3 (5 pts), ternaries 1 (4 pts), error handling 1 (3 pts), match/switch 1 (3 pts) (nesting depth added 45). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"9d092cc4e77041ae99f530a6bfe2f73f823d80c9e3db506efcd3f1b10c0dc8e1"}},{"ruleId":"D2","level":"warning","message":{"text":"ConpherenceThreadSearchEngine.loadContextMessages (cognitive 76): ConpherenceThreadSearchEngine.loadContextMessages has cognitive complexity 76 (threshold 15). Drivers by points: if/else 17 (42 pts), loops 19 (34 pts) (nesting depth added 40). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/query/ConpherenceThreadSearchEngine.php"},"region":{"startLine":233}}}],"partialFingerprints":{"codehealthFindingId/v1":"fa06715ce3221f1a71636e31f588a1edb6cd76ae7ef21e978ca16d3c9cc790f0"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionServeController.serveRequest (cognitive 76): DiffusionServeController.serveRequest has cognitive complexity 76 (threshold 15). Drivers by points: if/else 33 (58 pts), boolean chains 7, error handling 3 (7 pts), match/switch 2 (4 pts) (nesting depth added 31). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionServeController.php"},"region":{"startLine":176}}}],"partialFingerprints":{"codehealthFindingId/v1":"3a68382f9e8ccef0cb8d42cf891706fa8a327f03edf32e3080d22f488c2f44df"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionRepositoryBasicsManagementPanel.buildRepositoryStatus (cognitive 76): DiffusionRepositoryBasicsManagementPanel.buildRepositoryStatus has cognitive complexity 76 (threshold 15). Drivers by points: if/else 31 (56 pts), match/switch 5 (13 pts), loops 2 (6 pts), boolean chains 1 (nesting depth added 37). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php"},"region":{"startLine":336}}}],"partialFingerprints":{"codehealthFindingId/v1":"26b1ac99ef6fdd6e2dd97a7c037b9f0670aebc8861aea7ba2c1eb6fa7561efc8"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorSQLPatchList.buildAllPatches (cognitive 74): PhabricatorSQLPatchList.buildAllPatches has cognitive complexity 74 (threshold 15). Drivers by points: if/else 19 (57 pts), loops 7 (13 pts), match/switch 1 (3 pts), boolean chains 1 (nesting depth added 46). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/patch/PhabricatorSQLPatchList.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"47c2345a473c5ad67fb2ae595511f70da5b1b488fa6e767bb82540f93725771b"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorAuthSessionEngine.newHighSecurityToken (cognitive 71): PhabricatorAuthSessionEngine.newHighSecurityToken has cognitive complexity 71 (threshold 15). Drivers by points: if/else 22 (55 pts), loops 7 (15 pts), boolean chains 1 (nesting depth added 41). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/engine/PhabricatorAuthSessionEngine.php"},"region":{"startLine":446}}}],"partialFingerprints":{"codehealthFindingId/v1":"1de5c565a2be11877e80aefaf9c92f7cf87bb2d7753304a3ae3085ed2ff613ea"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProfileMenuEngine.buildResponse (cognitive 71): PhabricatorProfileMenuEngine.buildResponse has cognitive complexity 71 (threshold 15). Drivers by points: if/else 34 (58 pts), match/switch 3 (6 pts), error handling 1 (3 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 30). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorProfileMenuEngine.php"},"region":{"startLine":102}}}],"partialFingerprints":{"codehealthFindingId/v1":"35107a05e4ae4f189272debbe9e2a92474a9e32e90b8658974d310e5a512abcb"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCursorPagedPolicyAwareQuery.buildFerretWhereClause (cognitive 71): PhabricatorCursorPagedPolicyAwareQuery.buildFerretWhereClause has cognitive complexity 71 (threshold 15). Drivers by points: if/else 36 (68 pts), boolean chains 2, loops 1 (nesting depth added 32). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php"},"region":{"startLine":2208}}}],"partialFingerprints":{"codehealthFindingId/v1":"3ac13ba91e07e7e09f763b62162a073b06d389a18ffb07cfbdaf58169f194637"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMetaMTAMailViewController.buildDeliveryProperties (cognitive 69): PhabricatorMetaMTAMailViewController.buildDeliveryProperties has cognitive complexity 69 (threshold 15). Drivers by points: if/else 28 (54 pts), loops 4 (12 pts), match/switch 1 (3 pts) (nesting depth added 36). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/controller/PhabricatorMetaMTAMailViewController.php"},"region":{"startLine":216}}}],"partialFingerprints":{"codehealthFindingId/v1":"d29fd9cf82c60d4665bf83537459adb0d586bf5a8500de9ec1beee72ca2497e7"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMailManagementShowOutboundWorkflow.execute (cognitive 68): PhabricatorMailManagementShowOutboundWorkflow.execute has cognitive complexity 68 (threshold 15). Drivers by points: if/else 25 (50 pts), loops 8 (18 pts) (nesting depth added 35). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/management/PhabricatorMailManagementShowOutboundWorkflow.php"},"region":{"startLine":29}}}],"partialFingerprints":{"codehealthFindingId/v1":"2fbad919a3832a697b88b310c7aecb32e50be80f5ef6a6f783b00522dc51d942"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorConduitAPIController.authenticateUser (cognitive 67): PhabricatorConduitAPIController.authenticateUser has cognitive complexity 67 (threshold 15). Drivers by points: if/else 35 (64 pts), error handling 1 (2 pts), boolean chains 1 (nesting depth added 30). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conduit/controller/PhabricatorConduitAPIController.php"},"region":{"startLine":167}}}],"partialFingerprints":{"codehealthFindingId/v1":"37b6cc42a49d1616fbadf3d4921f23c88052fc150f39456c8bf969f10e78037f"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorConfigClusterRepositoriesController.buildClusterRepositoryStatus (cognitive 67): PhabricatorConfigClusterRepositoriesController.buildClusterRepositoryStatus has cognitive complexity 67 (threshold 15). Drivers by points: if/else 23 (55 pts), loops 4 (9 pts), boolean chains 3 (nesting depth added 37). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/services/PhabricatorConfigClusterRepositoriesController.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"63285f51ab2f634348b18db3a389eed8c92e8f9bca678920658549c7e47931ec"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorOwnersPackage.findLongestPathsPerPackage (cognitive 67): PhabricatorOwnersPackage.findLongestPathsPerPackage has cognitive complexity 67 (threshold 15). Drivers by points: if/else 12 (38 pts), loops 12 (29 pts) (nesting depth added 43). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/owners/storage/PhabricatorOwnersPackage.php"},"region":{"startLine":378}}}],"partialFingerprints":{"codehealthFindingId/v1":"2745fee97f8092b2744c3297b7e25ef3ddb47680feb4089ea92f19ef4b52900e"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMentionRemarkupRule.didMarkupText (cognitive 67): PhabricatorMentionRemarkupRule.didMarkupText has cognitive complexity 67 (threshold 15). Drivers by points: if/else 21 (57 pts), loops 5 (10 pts) (nesting depth added 41). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/markup/PhabricatorMentionRemarkupRule.php"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"a8ef6146f3487f843dcee7e4442967f061d93c9163db6ab190afb190e1957880"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorBoardLayoutEngine.layoutBoard (cognitive 67): PhabricatorBoardLayoutEngine.layoutBoard has cognitive complexity 67 (threshold 15). Drivers by points: if/else 17 (36 pts), loops 13 (29 pts), boolean chains 2 (nesting depth added 35). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/engine/PhabricatorBoardLayoutEngine.php"},"region":{"startLine":422}}}],"partialFingerprints":{"codehealthFindingId/v1":"6a5051773d9eee696a777e097bff54c363793d55b132724d90cdb863f73a267b"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialReviewersView.render (cognitive 66): DifferentialReviewersView.render has cognitive complexity 66 (threshold 15). Drivers by points: if/else 26 (59 pts), boolean chains 3, loops 2, match/switch 1 (2 pts) (nesting depth added 34). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/view/DifferentialReviewersView.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"d6a75b6f5bd6972f38c9c0e9192eb7c995ca4189ae36fb19f740cb5811a8d03b"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionBrowseQueryConduitAPIMethod.getGitResult (cognitive 66): DiffusionBrowseQueryConduitAPIMethod.getGitResult has cognitive complexity 66 (threshold 15). Drivers by points: if/else 28 (53 pts), loops 3 (7 pts), boolean chains 3, error handling 1 (2 pts), ternaries 1 (nesting depth added 30). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"9bae8fccb491a6fc93a0a4e81e121dab8db86721c5c81783cf3f16caf19c751f"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryPullLocalDaemon.run (cognitive 66): PhabricatorRepositoryPullLocalDaemon.run has cognitive complexity 66 (threshold 15). Drivers by points: if/else 14 (45 pts), loops 8 (20 pts), boolean chains 1 (nesting depth added 43). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"fd559fe052d7a06115e3533e333de759884b642e8ccd6838bb0dcc755ca2839d"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryManagementThawWorkflow.execute (cognitive 66): PhabricatorRepositoryManagementThawWorkflow.execute has cognitive complexity 66 (threshold 15). Drivers by points: if/else 24 (50 pts), loops 4 (8 pts), boolean chains 5, error handling 1 (3 pts) (nesting depth added 32). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/management/PhabricatorRepositoryManagementThawWorkflow.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"2b3a7b59e8aa506afb6b3647577432a4c8b2f99bfdb5962061bacad855b489ea"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorEditEngineConfigurationQuery.loadPage (cognitive 66): PhabricatorEditEngineConfigurationQuery.loadPage has cognitive complexity 66 (threshold 15). Drivers by points: if/else 23 (44 pts), loops 13 (22 pts) (nesting depth added 30). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/query/PhabricatorEditEngineConfigurationQuery.php"},"region":{"startLine":71}}}],"partialFingerprints":{"codehealthFindingId/v1":"d45884e136677b35f14072626382e9afa081a55a89157f7096d6553f4b9a68c2"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorDatabaseRefParser.newRefs (cognitive 66): PhabricatorDatabaseRefParser.newRefs has cognitive complexity 66 (threshold 15). Drivers by points: if/else 25 (56 pts), loops 6 (10 pts) (nesting depth added 35). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/cluster/PhabricatorDatabaseRefParser.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"bbf01730136e8df471e31767b657383b03191abe951ab24576b3b4008fa05c1f"}},{"ruleId":"D2","level":"warning","message":{"text":"PHUIDiffInlineCommentDetailView.render (cognitive 66): PHUIDiffInlineCommentDetailView.render has cognitive complexity 66 (threshold 15). Drivers by points: if/else 37 (50 pts), boolean chains 9, ternaries 1 (3 pts), loops 1 (2 pts), match/switch 1 (2 pts) (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php"},"region":{"startLine":78}}}],"partialFingerprints":{"codehealthFindingId/v1":"06c0e7bd08ca57011d87115404af6d6aef018b2d5b767ee7f04edb89ba8a77e7"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorPolicyAwareQuery.execute (cognitive 66): PhabricatorPolicyAwareQuery.execute has cognitive complexity 66 (threshold 15). Drivers by points: if/else 24 (52 pts), loops 4 (8 pts), boolean chains 3, error handling 1 (3 pts) (nesting depth added 34). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php"},"region":{"startLine":204}}}],"partialFingerprints":{"codehealthFindingId/v1":"f05c487e6766b10eb8098956c00dde1e714010c7b0165c5fb97379558f112317"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorController.willBeginExecution (cognitive 65): PhabricatorController.willBeginExecution has cognitive complexity 65 (threshold 15). Drivers by points: if/else 29 (56 pts), boolean chains 8, loops 1 (nesting depth added 27). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/base/controller/PhabricatorController.php"},"region":{"startLine":64}}}],"partialFingerprints":{"codehealthFindingId/v1":"f2a63ca1caaf2d2880adba884b72fac3bc8b9c3b4665588606d5b5dfc3eae8f8"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCalendarEventQuery.willFilterPage (cognitive 65): PhabricatorCalendarEventQuery.willFilterPage has cognitive complexity 65 (threshold 15). Drivers by points: if/else 18 (33 pts), loops 13 (32 pts) (nesting depth added 34). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/query/PhabricatorCalendarEventQuery.php"},"region":{"startLine":515}}}],"partialFingerprints":{"codehealthFindingId/v1":"dede6cd1062a72e3a7c8688ef8ad952388d29a5268b97ae293788be6082c6490"}},{"ruleId":"D2","level":"warning","message":{"text":"DivinerAtomQuery.willFilterPage (cognitive 65): DivinerAtomQuery.willFilterPage has cognitive complexity 65 (threshold 15). Drivers by points: if/else 19 (46 pts), loops 8 (19 pts) (nesting depth added 38). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/query/DivinerAtomQuery.php"},"region":{"startLine":139}}}],"partialFingerprints":{"codehealthFindingId/v1":"c97b438b866b84bb092a932fb26beea6b1fa9c0dc6fcb7629bd75a85421e1ab2"}},{"ruleId":"D2","level":"warning","message":{"text":"PHUIObjectItemView.getTagContent (cognitive 65): PHUIObjectItemView.getTagContent has cognitive complexity 65 (threshold 15). Drivers by points: if/else 34 (41 pts), loops 6 (12 pts), ternaries 3 (7 pts), boolean chains 5 (nesting depth added 17). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIObjectItemView.php"},"region":{"startLine":383}}}],"partialFingerprints":{"codehealthFindingId/v1":"59451d2b95fd2e20f02c36fa784bd55f7c43143bedc2737ae8d6616ab118ee50"}},{"ruleId":"D2","level":"warning","message":{"text":"DivinerAtomController.handleRequest (cognitive 64): DivinerAtomController.handleRequest has cognitive complexity 64 (threshold 15). Drivers by points: if/else 18 (36 pts), loops 8 (21 pts), ternaries 3 (7 pts) (nesting depth added 35). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/controller/DivinerAtomController.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"1ac1c6d12957ea2e445bd71474655d54b32a243df84cfa4aaa8081ec7856ed3d"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorPeopleNewController.handleRequest (cognitive 64): PhabricatorPeopleNewController.handleRequest has cognitive complexity 64 (threshold 15). Drivers by points: if/else 27 (56 pts), boolean chains 3, error handling 1 (3 pts), match/switch 1, ternaries 1 (nesting depth added 31). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/controller/PhabricatorPeopleNewController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"c5836f0526e02ee7a00e919fc8a70afb0e918c3c029f0a6fdbddf9c8a11a404e"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectBoardViewController.handleRequest (cognitive 64): PhabricatorProjectBoardViewController.handleRequest has cognitive complexity 64 (threshold 15). Drivers by points: if/else 26 (48 pts), loops 8 (14 pts), boolean chains 2 (nesting depth added 28). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectBoardViewController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"21072711cd39198029bcbc91d0c5da860785b17f7135acda26e023c7a8ffba50"}},{"ruleId":"D2","level":"warning","message":{"text":"MultimeterSampleController.handleRequest (cognitive 63): MultimeterSampleController.handleRequest has cognitive complexity 63 (threshold 15). Drivers by points: if/else 28 (57 pts), loops 4, ternaries 1 (2 pts) (nesting depth added 30). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/multimeter/controller/MultimeterSampleController.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"5bb0f3c6778c187a78236019be0e2b593fc6d4f3aaa792ba634079a69a86f7fb"}},{"ruleId":"D2","level":"warning","message":{"text":"PhrequentTimeBlock.getObjectTimeRanges (cognitive 63): PhrequentTimeBlock.getObjectTimeRanges has cognitive complexity 63 (threshold 15). Drivers by points: if/else 12 (38 pts), loops 9 (16 pts), ternaries 2 (6 pts), match/switch 1 (3 pts) (nesting depth added 39). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phrequent/storage/PhrequentTimeBlock.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"e61ccbe0a7cccfc005659a3fdc8dc406ab7edfaa15f24bd8facbb15d0d155ef7"}},{"ruleId":"D2","level":"warning","message":{"text":"PholioMockEditController.handleRequest (cognitive 62): PholioMockEditController.handleRequest has cognitive complexity 62 (threshold 15). Drivers by points: if/else 24 (44 pts), ternaries 3 (10 pts), loops 4 (7 pts), boolean chains 1 (nesting depth added 30). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/pholio/controller/PholioMockEditController.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"538cefaf200900b855b0499d5b85b1f3390ba94268654828855746dd21c9399a"}},{"ruleId":"D2","level":"warning","message":{"text":"HarbormasterBuildEngine.updateBuildSteps (cognitive 61): HarbormasterBuildEngine.updateBuildSteps has cognitive complexity 61 (threshold 15). Drivers by points: if/else 17 (41 pts), loops 8 (18 pts), boolean chains 2 (nesting depth added 34). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/engine/HarbormasterBuildEngine.php"},"region":{"startLine":165}}}],"partialFingerprints":{"codehealthFindingId/v1":"3dbe87d27fa7f1a864bb44b64e718ef94323f14478b6b696cc8033ffae04ea46"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialHunkParser.parseHunksForHighlightMasks (cognitive 60): DifferentialHunkParser.parseHunksForHighlightMasks has cognitive complexity 60 (threshold 15). Drivers by points: if/else 17 (47 pts), boolean chains 9, loops 3 (4 pts) (nesting depth added 31). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialHunkParser.php"},"region":{"startLine":566}}}],"partialFingerprints":{"codehealthFindingId/v1":"cc0e25d82194aa84ea89736147ecd4fe32068ebb67ea8a7f93edbe6468d2fb30"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialRevision.newReviewerForceAcceptMap (cognitive 60): DifferentialRevision.newReviewerForceAcceptMap has cognitive complexity 60 (threshold 15). Drivers by points: if/else 17 (40 pts), loops 11 (18 pts), boolean chains 1, error handling 1 (nesting depth added 30). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialRevision.php"},"region":{"startLine":253}}}],"partialFingerprints":{"codehealthFindingId/v1":"c727327e0f0831ca030f169e2759675fd4c570d1eb899529bff64bf35b77232a"}},{"ruleId":"D2","level":"warning","message":{"text":"PassphraseCredentialEditController.handleRequest (cognitive 60): PassphraseCredentialEditController.handleRequest has cognitive complexity 60 (threshold 15). Drivers by points: if/else 25 (49 pts), error handling 3 (8 pts), boolean chains 2, ternaries 1 (nesting depth added 29). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/passphrase/controller/PassphraseCredentialEditController.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"fb6f52fb0db1482aac9e89cb48e2ddd9ea1c94d6e6bac287b366a15bbad9d8e1"}},{"ruleId":"D2","level":"warning","message":{"text":"PhrictionRemarkupRule.didMarkupText (cognitive 60): PhrictionRemarkupRule.didMarkupText has cognitive complexity 60 (threshold 15). Drivers by points: if/else 20 (46 pts), loops 8 (13 pts), boolean chains 1 (nesting depth added 31). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/markup/PhrictionRemarkupRule.php"},"region":{"startLine":86}}}],"partialFingerprints":{"codehealthFindingId/v1":"6fc7d7f140695a897fa2bb621b952c43782f823aac601c7c5b9f269131ef5699"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-fancy-datepicker.JX.behavior(\u0022fancy-datepicker\u0022) (cognitive 59): behavior-fancy-datepicker.JX.behavior(\u0022fancy-datepicker\u0022) has cognitive complexity 59 (threshold 15). Drivers by points: if/else 30 (38 pts), boolean chains 8, loops 7, match/switch 4 (6 pts) (nesting depth added 10). Most of this is not in the body itself: 1 of the 59 points is its own statement and the rest belongs to 14 function items inside it that branch (render_day, write_date, getValidDate, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-fancy-datepicker.js"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"8756948296d242f5bbbcec68c02e761a942ace68d2cb97e145b8fde3fd0ad34c"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-dark-console.JX.behavior(\u0022dark-console\u0022) (cognitive 59): behavior-dark-console.JX.behavior(\u0022dark-console\u0022) has cognitive complexity 59 (threshold 15). Drivers by points: if/else 33 (47 pts), boolean chains 4, loops 2 (3 pts), error handling 1 (2 pts), match/switch 1 (2 pts), ternaries 1 (nesting depth added 17). Most of this is not in the body itself: 9 of the 59 points are its own statements and the rest belongs to 16 function items inside it that branch (a function literal at line 355, render_request, a function literal at line 263, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/darkconsole/behavior-dark-console.js"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"d245e0e07cea5e4736287da90ff29de0758f7dd0f13b200b560c5943244c7ee3"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous) (cognitive 59): (anonymous) has cognitive complexity 59 (threshold 15). Drivers by points: if/else 30 (38 pts), boolean chains 8, loops 7, match/switch 4 (6 pts) (nesting depth added 10). Most of this is not in the body itself: 1 of the 59 points is its own statement and the rest belongs to 18 function items inside it that branch (render_day, write_date, getValidDate, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-fancy-datepicker.js"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"a4e71c661e4d6f0b7b5d1436408a7f33e917180d03a45dcb3d99a23c58846908"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous) (cognitive 59): (anonymous) has cognitive complexity 59 (threshold 15). Drivers by points: if/else 33 (47 pts), boolean chains 4, loops 2 (3 pts), error handling 1 (2 pts), match/switch 1 (2 pts), ternaries 1 (nesting depth added 17). Most of this is not in the body itself: 9 of the 59 points are its own statements and the rest belongs to 25 function items inside it that branch (a function literal at line 355, render_request, a function literal at line 263, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/darkconsole/behavior-dark-console.js"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"4cb15dbcbbca72f88595a1f8046c52239c841b285c1837006c9c64aa2108ddc1"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorAuthEditController.handleRequest (cognitive 58): PhabricatorAuthEditController.handleRequest has cognitive complexity 58 (threshold 15). Drivers by points: if/else 28 (49 pts), loops 2 (5 pts), error handling 1 (3 pts), boolean chains 1 (nesting depth added 26). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/config/PhabricatorAuthEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"6bfdbf1d68f590db865ee0adf2d25465e681f673927a893cb739d9c154a4c602"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialChangesetTwoUpRenderer.renderDocumentEngineBlocks (cognitive 58): DifferentialChangesetTwoUpRenderer.renderDocumentEngineBlocks has cognitive complexity 58 (threshold 15). Drivers by points: if/else 27 (50 pts), loops 3 (7 pts), boolean chains 1 (nesting depth added 27). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php"},"region":{"startLine":368}}}],"partialFingerprints":{"codehealthFindingId/v1":"e7405de43ceb6b8124f75e9b5eb4ab2c9b1d52a729cd2b12d0fc839970b5327d"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionRepositoryStorageManagementPanel.buildClusterStatusPanel (cognitive 58): DiffusionRepositoryStorageManagementPanel.buildClusterStatusPanel has cognitive complexity 58 (threshold 15). Drivers by points: if/else 19 (48 pts), error handling 1 (5 pts), loops 2 (4 pts), boolean chains 1 (nesting depth added 35). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/management/DiffusionRepositoryStorageManagementPanel.php"},"region":{"startLine":79}}}],"partialFingerprints":{"codehealthFindingId/v1":"f662f2b782f60d6cbaeb00e4ae1b7519a055fb83ba9e49a4cc4b1de2abee1007"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorSearchManagementIndexWorkflow.execute (cognitive 58): PhabricatorSearchManagementIndexWorkflow.execute has cognitive complexity 58 (threshold 15). Drivers by points: if/else 26 (38 pts), boolean chains 11, loops 4 (7 pts), error handling 1 (2 pts) (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php"},"region":{"startLine":74}}}],"partialFingerprints":{"codehealthFindingId/v1":"23f50eddbe17344558c17fe6d28843312462eb239157baa722823976662f6444"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorAuthManagementStripWorkflow.execute (cognitive 57): PhabricatorAuthManagementStripWorkflow.execute has cognitive complexity 57 (threshold 15). Drivers by points: if/else 25 (41 pts), loops 5 (10 pts), boolean chains 6 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/management/PhabricatorAuthManagementStripWorkflow.php"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"426c26cf1006ed80b32689e6ff4b3c5bdc2bdc84c47253f08c8f005285aad1b2"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryQuery.willFilterPage (cognitive 57): PhabricatorRepositoryQuery.willFilterPage has cognitive complexity 57 (threshold 15). Drivers by points: if/else 15 (35 pts), loops 9 (18 pts), match/switch 2 (4 pts) (nesting depth added 31). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/query/PhabricatorRepositoryQuery.php"},"region":{"startLine":236}}}],"partialFingerprints":{"codehealthFindingId/v1":"68dbd2e1c5472b6405cede369ff630cbbdbad486f39b7657a176f17007612857"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorPeopleInviteSendController.handleRequest (cognitive 56): PhabricatorPeopleInviteSendController.handleRequest has cognitive complexity 56 (threshold 15). Drivers by points: if/else 21 (44 pts), loops 3 (9 pts), ternaries 2, boolean chains 1 (nesting depth added 29). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/controller/PhabricatorPeopleInviteSendController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"ba890017436dda4fd44f82e36c1e3ea22a490c11856fddddc0db959a0a0ac113"}},{"ruleId":"D2","level":"warning","message":{"text":"AphrontMultipartParser.continueParse (cognitive 55): AphrontMultipartParser.continueParse has cognitive complexity 55 (threshold 15). Drivers by points: if/else 16 (52 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 37). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/multipartparser/AphrontMultipartParser.php"},"region":{"startLine":62}}}],"partialFingerprints":{"codehealthFindingId/v1":"3378a0b19f7019692e58c8598b52ff56780ae077e5d24dce8edb774278b5d72c"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationQuery.loadPage (cognitive 55): PhabricatorApplicationQuery.loadPage has cognitive complexity 55 (threshold 15). Drivers by points: if/else 18 (36 pts), loops 9 (18 pts), match/switch 1 (nesting depth added 27). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/meta/query/PhabricatorApplicationQuery.php"},"region":{"startLine":71}}}],"partialFingerprints":{"codehealthFindingId/v1":"ce94bdbec84912fa387b301dadf2fd88d4431eadd0cc86c56131af8e825769ae"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorWorkerManagementWorkflow.loadTasks (cognitive 55): PhabricatorWorkerManagementWorkflow.loadTasks has cognitive complexity 55 (threshold 15). Drivers by points: if/else 34 (45 pts), boolean chains 7, loops 2 (3 pts) (nesting depth added 12). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementWorkflow.php"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"832ee4b9ce31591249d249c3da85d3af0003b70c274a26a27fd87e93210badcd"}},{"ruleId":"D2","level":"warning","message":{"text":"PHUIDiffTableOfContentsListView.render (cognitive 55): PHUIDiffTableOfContentsListView.render has cognitive complexity 55 (threshold 15). Drivers by points: if/else 29 (51 pts), loops 4 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/view/PHUIDiffTableOfContentsListView.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"ae5bffec6f37c55fefb5e6d7fff0453ddc309c964e9d00b8b1f7755c0fa0b359"}},{"ruleId":"D2","level":"warning","message":{"text":"HarbormasterBuildViewController.handleRequest (cognitive 54): HarbormasterBuildViewController.handleRequest has cognitive complexity 54 (threshold 15). Drivers by points: if/else 28 (48 pts), loops 3 (5 pts), boolean chains 1 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterBuildViewController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"c3ca541c4a20b8cbaeaa527f1ec092bf004a8cd1179090b9c09d162c3d5c484d"}},{"ruleId":"D2","level":"warning","message":{"text":"LegalpadDocumentSignController.handleRequest (cognitive 54): LegalpadDocumentSignController.handleRequest has cognitive complexity 54 (threshold 15). Drivers by points: if/else 25 (47 pts), boolean chains 4, match/switch 2 (3 pts) (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/legalpad/controller/LegalpadDocumentSignController.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"72abecd88de31def91c7cf7d5d2284ebe7f9b786a779c55d936186cc88427433"}},{"ruleId":"D2","level":"warning","message":{"text":"ManiphestReportController.renderOpenTasks (cognitive 54): ManiphestReportController.renderOpenTasks has cognitive complexity 54 (threshold 15). Drivers by points: if/else 15 (27 pts), loops 9 (19 pts), match/switch 3 (4 pts), ternaries 1 (3 pts), boolean chains 1 (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/controller/ManiphestReportController.php"},"region":{"startLine":487}}}],"partialFingerprints":{"codehealthFindingId/v1":"60ab8e3c2c9bad40a359f75653d7b074d477d38479e5e4229dca900609918ee9"}},{"ruleId":"D2","level":"warning","message":{"text":"ManiphestTransactionEditor.buildMoveTransaction (cognitive 54): ManiphestTransactionEditor.buildMoveTransaction has cognitive complexity 54 (threshold 15). Drivers by points: if/else 25 (42 pts), loops 7 (10 pts), boolean chains 2 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/editor/ManiphestTransactionEditor.php"},"region":{"startLine":438}}}],"partialFingerprints":{"codehealthFindingId/v1":"41afd6f4d70ca1055e72787826e25818ae6b2d5a723558460721caf988da132d"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorObjectListQuery.execute (cognitive 54): PhabricatorObjectListQuery.execute has cognitive complexity 54 (threshold 15). Drivers by points: if/else 16 (32 pts), loops 11 (21 pts), boolean chains 1 (nesting depth added 26). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phid/query/PhabricatorObjectListQuery.php"},"region":{"startLine":56}}}],"partialFingerprints":{"codehealthFindingId/v1":"1e161306b43bf9a5ac6cb932afaedd561cecb43044b117289608b0e477237e93"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorEditEngine.buildCommentResponse (cognitive 54): PhabricatorEditEngine.buildCommentResponse has cognitive complexity 54 (threshold 15). Drivers by points: if/else 21 (38 pts), loops 4 (8 pts), error handling 4 (5 pts), boolean chains 3 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editengine/PhabricatorEditEngine.php"},"region":{"startLine":1875}}}],"partialFingerprints":{"codehealthFindingId/v1":"13f320e9242c1c21ab98560b75cfcf4de97628ce6c4534b7ee75a6639f101372"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilCalendarRecurrenceSet.getEventsBetween (cognitive 53): PhutilCalendarRecurrenceSet.getEventsBetween has cognitive complexity 53 (threshold 15). Drivers by points: if/else 19 (41 pts), loops 5 (8 pts), boolean chains 4 (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/data/PhutilCalendarRecurrenceSet.php"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"d9064902b4cb605bdd6f0637d4d60e00bc8505f109ee410fb27e674e03d51256"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialRevisionReviewersTransaction.renderReviewerEditTitle (cognitive 53): DifferentialRevisionReviewersTransaction.renderReviewerEditTitle has cognitive complexity 53 (threshold 15). Drivers by points: if/else 27 (48 pts), boolean chains 4, loops 1 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php"},"region":{"startLine":165}}}],"partialFingerprints":{"codehealthFindingId/v1":"864aa62fd3250163e41e5d81c46fe1af1878e2d4064c82c7bbbdaa836299566b"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProfileMenuEngine.buildItemConfigureContent (cognitive 53): PhabricatorProfileMenuEngine.buildItemConfigureContent has cognitive complexity 53 (threshold 15). Drivers by points: if/else 22 (49 pts), loops 3, boolean chains 1 (nesting depth added 27). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorProfileMenuEngine.php"},"region":{"startLine":683}}}],"partialFingerprints":{"codehealthFindingId/v1":"04be1a24f7d2087538892ce956af4e96ed50955928c94d24909d2f274b30f947"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransactionView.renderEvent (cognitive 53): PhabricatorApplicationTransactionView.renderEvent has cognitive complexity 53 (threshold 15). Drivers by points: if/else 21 (44 pts), boolean chains 9 (nesting depth added 23). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/view/PhabricatorApplicationTransactionView.php"},"region":{"startLine":422}}}],"partialFingerprints":{"codehealthFindingId/v1":"6717ce3724045566bb2927bcd94cc67aadc8ad15c849c7ca803092e8d96086f7"}},{"ruleId":"D2","level":"warning","message":{"text":"PHUIHeaderView.getTagContent (cognitive 53): PHUIHeaderView.getTagContent has cognitive complexity 53 (threshold 15). Drivers by points: if/else 25 (40 pts), loops 3 (7 pts), boolean chains 3, match/switch 1 (3 pts) (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIHeaderView.php"},"region":{"startLine":190}}}],"partialFingerprints":{"codehealthFindingId/v1":"727d42e32d7f485317ce34c8511d5bac4c220cf878d601317f55899849f160d9"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialChangesetViewController.handleRequest (cognitive 52): DifferentialChangesetViewController.handleRequest has cognitive complexity 52 (threshold 15). Drivers by points: if/else 33 (42 pts), boolean chains 4, loops 3 (4 pts), match/switch 1 (2 pts) (nesting depth added 11). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/controller/DifferentialChangesetViewController.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"5538173e173e242da4c8159a1af5380b56b14e476adf7822f6e6c3cbeaceddf8"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorPolicyFilter.checkCapability (cognitive 52): PhabricatorPolicyFilter.checkCapability has cognitive complexity 52 (threshold 15). Drivers by points: if/else 27 (50 pts), boolean chains 1, match/switch 1 (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/filter/PhabricatorPolicyFilter.php"},"region":{"startLine":502}}}],"partialFingerprints":{"codehealthFindingId/v1":"5e5d4f3b7696a766ae6bd1b1a818fe32aacdfdc1173ac81f4fda0e71aa04b4a4"}},{"ruleId":"D2","level":"warning","message":{"text":"updateCard (cognitive 52): updateCard has cognitive complexity 52 (threshold 15). Drivers by points: if/else 13 (33 pts), loops 12 (18 pts), boolean chains 1 (nesting depth added 26). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/projects/WorkboardBoard.js"},"region":{"startLine":601}}}],"partialFingerprints":{"codehealthFindingId/v1":"9a18eb870d37b10fc0a96ac9f701cca2a8ce9baf4c771476fda74af87b5237fd"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionGitUploadPackWireProtocol.willReadBytes (cognitive 51): DiffusionGitUploadPackWireProtocol.willReadBytes has cognitive complexity 51 (threshold 15). Drivers by points: if/else 15 (40 pts), loops 4 (6 pts), match/switch 2 (4 pts), boolean chains 1 (nesting depth added 29). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/protocol/DiffusionGitUploadPackWireProtocol.php"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"03ab446b9e27211bfd59cb5fbe3bc9b44676339349de6e09862918926f884b12"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionCommitQuery.didFilterPage (cognitive 51): DiffusionCommitQuery.didFilterPage has cognitive complexity 51 (threshold 15). Drivers by points: if/else 12 (24 pts), loops 10 (24 pts), error handling 1 (3 pts) (nesting depth added 28). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/DiffusionCommitQuery.php"},"region":{"startLine":361}}}],"partialFingerprints":{"codehealthFindingId/v1":"cc392823b529fdaddec58c3d26492b7bba2b67e383a05e461155d1149d7077ad"}},{"ruleId":"D2","level":"warning","message":{"text":"PHUIDiffTableOfContentsListView.newComponentView (cognitive 51): PHUIDiffTableOfContentsListView.newComponentView has cognitive complexity 51 (threshold 15). Drivers by points: if/else 23 (45 pts), boolean chains 3, loops 3 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/view/PHUIDiffTableOfContentsListView.php"},"region":{"startLine":387}}}],"partialFingerprints":{"codehealthFindingId/v1":"54fefaae6f6289cc501b844ae7ef81695cbd6d57d716a7f244bd084d38780108"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCursorPagedPolicyAwareQuery.buildSpacesWhereClause (cognitive 51): PhabricatorCursorPagedPolicyAwareQuery.buildSpacesWhereClause has cognitive complexity 51 (threshold 15). Drivers by points: if/else 25 (43 pts), boolean chains 4, loops 2 (4 pts) (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php"},"region":{"startLine":3139}}}],"partialFingerprints":{"codehealthFindingId/v1":"1bb30666918afc25c7ba532e60fb297f6456fd3728106d8794985a8098573e94"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-menu.JX.behavior(\u0022conpherence-menu\u0022) (cognitive 51): behavior-menu.JX.behavior(\u0022conpherence-menu\u0022) has cognitive complexity 51 (threshold 15). Drivers by points: if/else 33 (40 pts), boolean chains 6, error handling 3 (5 pts) (nesting depth added 9). None of this is in the body itself: all 51 points belong to 15 function items inside it that branch (onDeviceChange, redrawThread, didLoadThreads, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/conpherence/behavior-menu.js"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"38105731260e9a5c78d574a157b50ba04feec7e7554e8c9d4e410073f58954a4"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous) (cognitive 51): (anonymous) has cognitive complexity 51 (threshold 15). Drivers by points: if/else 33 (40 pts), boolean chains 6, error handling 3 (5 pts) (nesting depth added 9). None of this is in the body itself: all 51 points belong to 30 function items inside it that branch (onDeviceChange, redrawThread, didLoadThreads, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/conpherence/behavior-menu.js"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"7b58d8c27c70dfcfa674a3a730a401c2844abfadded6c050e4359e678d544567"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilSpriteSheet.generate (cognitive 50): PhutilSpriteSheet.generate has cognitive complexity 50 (threshold 15). Drivers by points: if/else 13 (30 pts), loops 11 (17 pts), boolean chains 2, match/switch 1 (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/sprite/PhutilSpriteSheet.php"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"51209cdc52402a571844991a7ad055963577abaf023867c7b010c902962824c9"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorAuthManagementRevokeWorkflow.execute (cognitive 50): PhabricatorAuthManagementRevokeWorkflow.execute has cognitive complexity 50 (threshold 15). Drivers by points: if/else 24 (41 pts), boolean chains 6, loops 2 (3 pts) (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/management/PhabricatorAuthManagementRevokeWorkflow.php"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"080221d9c6d81d11293c06905443ddad3176890952a90e7d6099f537971bd104"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionBrowseQueryConduitAPIMethod.getSVNResult (cognitive 50): DiffusionBrowseQueryConduitAPIMethod.getSVNResult has cognitive complexity 50 (threshold 15). Drivers by points: if/else 24 (45 pts), loops 3, boolean chains 2 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php"},"region":{"startLine":363}}}],"partialFingerprints":{"codehealthFindingId/v1":"eac1ab4373a6ab44dfefb49061d86e933d926ed4e77ddfe32caafd986f780299"}},{"ruleId":"D2","level":"warning","message":{"text":"PhortuneCartCancelController.handleCartRequest (cognitive 50): PhortuneCartCancelController.handleCartRequest has cognitive complexity 50 (threshold 15). Drivers by points: if/else 17 (38 pts), error handling 3 (8 pts), loops 1 (3 pts), match/switch 1 (nesting depth added 28). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/cart/PhortuneCartCancelController.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"3903939a21ec1e68d22ac053cd9f62641366b81bdd9cc92cedc964039d78e087"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilProseDifferenceEngine.buildDiff (cognitive 50): PhutilProseDifferenceEngine.buildDiff has cognitive complexity 50 (threshold 15). Drivers by points: if/else 17 (38 pts), loops 3 (9 pts), match/switch 1 (2 pts), boolean chains 1 (nesting depth added 28). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/prose/PhutilProseDifferenceEngine.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"1c58091646e84b9d397204376bccf0e840efdf394292850aef6a6d3084bb356d"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCalendarNotificationEngine.sendNotifications (cognitive 49): PhabricatorCalendarNotificationEngine.sendNotifications has cognitive complexity 49 (threshold 15). Drivers by points: loops 16 (26 pts), if/else 10 (20 pts), error handling 1 (2 pts), boolean chains 1 (nesting depth added 21). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/notifications/PhabricatorCalendarNotificationEngine.php"},"region":{"startLine":73}}}],"partialFingerprints":{"codehealthFindingId/v1":"7f0fa875af7c9a36f001500faf9ad42cb0e2192f2ce932b92457754ca122375a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorConfigClusterDatabasesController.buildClusterDatabaseStatus (cognitive 49): PhabricatorConfigClusterDatabasesController.buildClusterDatabaseStatus has cognitive complexity 49 (threshold 15). Drivers by points: if/else 21 (44 pts), match/switch 1 (4 pts), loops 1 (nesting depth added 26). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/services/PhabricatorConfigClusterDatabasesController.php"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"f2261c5084935d3be9b9da4f9fbb63404e2f92c157a4965117733a51bd0a4913"}},{"ruleId":"D2","level":"warning","message":{"text":"ConpherenceThreadSearchEngine.renderResultList (cognitive 49): ConpherenceThreadSearchEngine.renderResultList has cognitive complexity 49 (threshold 15). Drivers by points: if/else 10 (27 pts), loops 6 (19 pts), boolean chains 3 (nesting depth added 30). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/query/ConpherenceThreadSearchEngine.php"},"region":{"startLine":94}}}],"partialFingerprints":{"codehealthFindingId/v1":"c69b819278d08e5c747a177639d53c26ded79e3192ad2e76ceafa11c8b3ca81e"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialChangesetRenderer.processPrimitivesForOneUp (cognitive 49): DifferentialChangesetRenderer.processPrimitivesForOneUp has cognitive complexity 49 (threshold 15). Drivers by points: if/else 16 (47 pts), boolean chains 1, loops 1 (nesting depth added 31). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetRenderer.php"},"region":{"startLine":567}}}],"partialFingerprints":{"codehealthFindingId/v1":"7803d289916e60fccf1077766b5ce15ae49015dbbc93f1970d40575b8e243fec"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorSlowvoteEditController.handleRequest (cognitive 49): PhabricatorSlowvoteEditController.handleRequest has cognitive complexity 49 (threshold 15). Drivers by points: if/else 25 (40 pts), loops 3 (9 pts) (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"751e1c3ab40818631922fed5f071340e4a37f0013c3be0b6f7385a4873091d85"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorEditEngine.buildResponse (cognitive 49): PhabricatorEditEngine.buildResponse has cognitive complexity 49 (threshold 15). Drivers by points: if/else 22 (43 pts), boolean chains 4, match/switch 2 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editengine/PhabricatorEditEngine.php"},"region":{"startLine":882}}}],"partialFingerprints":{"codehealthFindingId/v1":"9a3e0f5ba202ab1e587d54290e2956691c94f61559b695cc33091b04c682675d"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorAuditTransaction.getTitle (cognitive 48): PhabricatorAuditTransaction.getTitle has cognitive complexity 48 (threshold 15). Drivers by points: if/else 22 (42 pts), match/switch 3 (4 pts), boolean chains 2 (nesting depth added 21). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/storage/PhabricatorAuditTransaction.php"},"region":{"startLine":162}}}],"partialFingerprints":{"codehealthFindingId/v1":"577c880066b963bd4c82df3d0db056e7999e5a3a1ab0384414237e91be53a080"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorEmailLoginController.handleRequest (cognitive 48): PhabricatorEmailLoginController.handleRequest has cognitive complexity 48 (threshold 15). Drivers by points: if/else 22 (43 pts), error handling 1 (4 pts), boolean chains 1 (nesting depth added 24). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorEmailLoginController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"209abd10f95adf6db7155683e670c4b3dc012b7ab4517e29a8d4aebc5ae2f19a"}},{"ruleId":"D2","level":"warning","message":{"text":"DarkConsoleServicesPlugin.generateData (cognitive 48): DarkConsoleServicesPlugin.generateData has cognitive complexity 48 (threshold 15). Drivers by points: if/else 12 (36 pts), loops 2 (4 pts), match/switch 1 (4 pts), error handling 1 (3 pts), boolean chains 1 (nesting depth added 31). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/console/plugin/DarkConsoleServicesPlugin.php"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"77b47139ceeaa3625df9d4b885b5a12ef07501bcb7bd9bd71718b553ddb41fba"}},{"ruleId":"D2","level":"warning","message":{"text":"DoorkeeperAsanaFeedWorker.publishFeedStory (cognitive 48): DoorkeeperAsanaFeedWorker.publishFeedStory has cognitive complexity 48 (threshold 15). Drivers by points: if/else 22 (37 pts), loops 7 (8 pts), boolean chains 3 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/worker/DoorkeeperAsanaFeedWorker.php"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"5fdfc3122ef6e1db211af439206df5356d32cff1ef28fbf0204898104d13b81f"}},{"ruleId":"D2","level":"warning","message":{"text":"PhrictionEditController.handleRequest (cognitive 48): PhrictionEditController.handleRequest has cognitive complexity 48 (threshold 15). Drivers by points: if/else 28 (42 pts), boolean chains 4, error handling 1 (2 pts) (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/controller/PhrictionEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"8aeece87e5998d01b19a59344ef3d1da84af9ab303079f74e4b989676831dade"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialChangesetParser.replaceTabsWithSpaces (cognitive 47): DifferentialChangesetParser.replaceTabsWithSpaces has cognitive complexity 47 (threshold 15). Drivers by points: if/else 18 (37 pts), loops 5 (10 pts) (nesting depth added 24). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialChangesetParser.php"},"region":{"startLine":1615}}}],"partialFingerprints":{"codehealthFindingId/v1":"c7a96d1dba3f1c1d8e5aadca1b896fb5ed2291d862d2386384e06345771b1bb2"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionLowLevelResolveRefsQuery.resolveGitRefs (cognitive 47): DiffusionLowLevelResolveRefsQuery.resolveGitRefs has cognitive complexity 47 (threshold 15). Drivers by points: if/else 16 (35 pts), loops 6 (10 pts), match/switch 1 (2 pts) (nesting depth added 24). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/lowlevel/DiffusionLowLevelResolveRefsQuery.php"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"6b60fef60a7f01f6046c31e5147b378a1ea501f55fa5dd77cf0a33cde841b3ce"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorChartRenderingEngine.newTabularView (cognitive 47): PhabricatorChartRenderingEngine.newTabularView has cognitive complexity 47 (threshold 15). Drivers by points: loops 13 (32 pts), if/else 5 (15 pts) (nesting depth added 29). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fact/engine/PhabricatorChartRenderingEngine.php"},"region":{"startLine":112}}}],"partialFingerprints":{"codehealthFindingId/v1":"49b6c3be68132f1d56c04a030be604d29ea190d5de3fe86fb6ce019ede804d50"}},{"ruleId":"D2","level":"warning","message":{"text":"HeraldNewController.handleRequest (cognitive 47): HeraldNewController.handleRequest has cognitive complexity 47 (threshold 15). Drivers by points: if/else 17 (47 pts) (nesting depth added 30). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/controller/HeraldNewController.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"623d7d19e829fd119e792d5d04d9d92a2539f2cadaa3216e10bfa7f590a4d4b3"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMetaMTAMail.loadActors (cognitive 47): PhabricatorMetaMTAMail.loadActors has cognitive complexity 47 (threshold 15). Drivers by points: if/else 15 (30 pts), loops 10 (15 pts), match/switch 1 (2 pts) (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/storage/PhabricatorMetaMTAMail.php"},"region":{"startLine":895}}}],"partialFingerprints":{"codehealthFindingId/v1":"4bb384272554ca16aafbcf3a8c59f33a3636b980a5fa00fe3b4e2ecd4b3fa127"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorDifferenceEngine.applyIntralineDiff (cognitive 47): PhabricatorDifferenceEngine.applyIntralineDiff has cognitive complexity 47 (threshold 15). Drivers by points: if/else 14 (33 pts), boolean chains 7, loops 2 (4 pts), match/switch 1 (3 pts) (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/PhabricatorDifferenceEngine.php"},"region":{"startLine":172}}}],"partialFingerprints":{"codehealthFindingId/v1":"9d549ffce5a9d050fd51bb207a7d7762d010f02f05ec54cef08ebfc22bdcb9ab"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCursorPagedPolicyAwareQuery.buildFerretJoinClause (cognitive 47): PhabricatorCursorPagedPolicyAwareQuery.buildFerretJoinClause has cognitive complexity 47 (threshold 15). Drivers by points: if/else 22 (38 pts), loops 6 (8 pts), boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php"},"region":{"startLine":1995}}}],"partialFingerprints":{"codehealthFindingId/v1":"0bd8965a1ef1c048e3362ffe82c9d704d49389d47fb4714be531f18c7ddbdaa0"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCalendarEventQuery.loadPage (cognitive 46): PhabricatorCalendarEventQuery.loadPage has cognitive complexity 46 (threshold 15). Drivers by points: if/else 16 (34 pts), loops 8 (10 pts), boolean chains 2 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/query/PhabricatorCalendarEventQuery.php"},"region":{"startLine":161}}}],"partialFingerprints":{"codehealthFindingId/v1":"562f59374fda23b01f7555ff13ea3a9cba76c1fa3713adcd8682c46a7234889c"}},{"ruleId":"D2","level":"warning","message":{"text":"HeraldAdapter.doesConditionMatch (cognitive 46): HeraldAdapter.doesConditionMatch has cognitive complexity 46 (threshold 15). Drivers by points: if/else 13 (34 pts), loops 3 (6 pts), error handling 2 (5 pts), match/switch 1 (nesting depth added 27). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/adapter/HeraldAdapter.php"},"region":{"startLine":444}}}],"partialFingerprints":{"codehealthFindingId/v1":"a8445e5afa8e9d928d5a41e39d9247b2eb56d3774c4c6bdb45e483bc76b549d8"}},{"ruleId":"D2","level":"warning","message":{"text":"ManiphestReportController.renderBurn (cognitive 46): ManiphestReportController.renderBurn has cognitive complexity 46 (threshold 15). Drivers by points: if/else 23 (35 pts), loops 4, boolean chains 3, match/switch 1 (2 pts), ternaries 1 (2 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/controller/ManiphestReportController.php"},"region":{"startLine":74}}}],"partialFingerprints":{"codehealthFindingId/v1":"8c2336f544822feed4040a59d536ac94c0d07be420ea55e29c462a5cd80df515"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorPeopleQuery.rebuildAvailabilityCache (cognitive 46): PhabricatorPeopleQuery.rebuildAvailabilityCache has cognitive complexity 46 (threshold 15). Drivers by points: if/else 9 (29 pts), loops 7 (16 pts), boolean chains 1 (nesting depth added 29). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/query/PhabricatorPeopleQuery.php"},"region":{"startLine":385}}}],"partialFingerprints":{"codehealthFindingId/v1":"7e5b8a404bf09a5e97cff71814433e9feff9535add57e2871a47bcee389fab4a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorBoardLayoutEngine.queueAddPosition (cognitive 46): PhabricatorBoardLayoutEngine.queueAddPosition has cognitive complexity 46 (threshold 15). Drivers by points: if/else 11 (37 pts), loops 4 (9 pts) (nesting depth added 31). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/engine/PhabricatorBoardLayoutEngine.php"},"region":{"startLine":138}}}],"partialFingerprints":{"codehealthFindingId/v1":"37f8eec91e6f148504d68e339d247074bb9fb3f8a711ff42d925cf9970a26055"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorDiffInlineCommentQuery.willFilterPage (cognitive 46): PhabricatorDiffInlineCommentQuery.willFilterPage has cognitive complexity 46 (threshold 15). Drivers by points: if/else 14 (35 pts), loops 4 (10 pts), boolean chains 1 (nesting depth added 27). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/query/PhabricatorDiffInlineCommentQuery.php"},"region":{"startLine":144}}}],"partialFingerprints":{"codehealthFindingId/v1":"ebe4a2a427d996e181a348f0cb884501cdc177be44fb740aa03f16c56baa1e4f"}},{"ruleId":"D2","level":"warning","message":{"text":"_update (cognitive 46): _update has cognitive complexity 46 (threshold 15). Drivers by points: if/else 24 (36 pts), boolean chains 5, ternaries 1 (3 pts), loops 2 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/phuix/PHUIXAutocomplete.js"},"region":{"startLine":428}}}],"partialFingerprints":{"codehealthFindingId/v1":"a08f072b663ecbeeb9fa28849b78fab80e6dabbe81eb93988cc19f5db1d04454"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorPeopleProfilePictureController.handleRequest (cognitive 45): PhabricatorPeopleProfilePictureController.handleRequest has cognitive complexity 45 (threshold 15). Drivers by points: if/else 23 (41 pts), loops 3, boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/controller/PhabricatorPeopleProfilePictureController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"fa378c05b4cd5f0c1e35d28f5b2aed147cdf237a7c53af38514d80b68bc70f45"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorPolicyFilter.apply (cognitive 45): PhabricatorPolicyFilter.apply has cognitive complexity 45 (threshold 15). Drivers by points: if/else 17 (33 pts), loops 7 (11 pts), boolean chains 1 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/filter/PhabricatorPolicyFilter.php"},"region":{"startLine":156}}}],"partialFingerprints":{"codehealthFindingId/v1":"703a57c70e876f194247d13e755b4a9d90c0a973665f5c18931add42a46d763c"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilRemarkupListBlockRule.markupText (cognitive 45): PhutilRemarkupListBlockRule.markupText has cognitive complexity 45 (threshold 15). Drivers by points: if/else 21 (39 pts), loops 4 (5 pts), boolean chains 1 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/blockrule/PhutilRemarkupListBlockRule.php"},"region":{"startLine":88}}}],"partialFingerprints":{"codehealthFindingId/v1":"e41b9d476d42e30319a2581beb69e766d303faeca396b5548642c0a5849a7b27"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilICSParser.parseICSProperty (cognitive 44): PhutilICSParser.parseICSProperty has cognitive complexity 44 (threshold 15). Drivers by points: if/else 12 (37 pts), loops 2 (5 pts), boolean chains 1, match/switch 1 (nesting depth added 28). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/ics/PhutilICSParser.php"},"region":{"startLine":191}}}],"partialFingerprints":{"codehealthFindingId/v1":"1ab535c3a63e6a46b0a13cd4c06131795208b2599dbdac3e20e79a425c87e814"}},{"ruleId":"D2","level":"warning","message":{"text":"ConpherenceUpdateController.handleRequest (cognitive 44): ConpherenceUpdateController.handleRequest has cognitive complexity 44 (threshold 15). Drivers by points: if/else 14 (31 pts), match/switch 4 (7 pts), error handling 1 (3 pts), boolean chains 2, ternaries 1 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceUpdateController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"831fcc1cda6cfc1a017164e7050afa238ee5998b1805d9e140d3752ed5a44cd6"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionServeController.isVCSRequest (cognitive 44): DiffusionServeController.isVCSRequest has cognitive complexity 44 (threshold 15). Drivers by points: if/else 16 (44 pts) (nesting depth added 28). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionServeController.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"4f6764823ca02e25d156829d850e827dab8110af96a5e1f009fc58d8dc235210"}},{"ruleId":"D2","level":"warning","message":{"text":"ManiphestTaskDetailController.newChangesView (cognitive 44): ManiphestTaskDetailController.newChangesView has cognitive complexity 44 (threshold 15). Drivers by points: if/else 19 (32 pts), loops 5 (7 pts), ternaries 2 (4 pts), boolean chains 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/controller/ManiphestTaskDetailController.php"},"region":{"startLine":545}}}],"partialFingerprints":{"codehealthFindingId/v1":"eda0b7d060682cbec69c63472a273c697122098489aa9f89cae471a62266abf4"}},{"ruleId":"D2","level":"warning","message":{"text":"PhrictionDocumentQuery.buildWhereClauseParts (cognitive 44): PhrictionDocumentQuery.buildWhereClauseParts has cognitive complexity 44 (threshold 15). Drivers by points: if/else 17 (36 pts), loops 3 (7 pts), boolean chains 1 (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/query/PhrictionDocumentQuery.php"},"region":{"startLine":199}}}],"partialFingerprints":{"codehealthFindingId/v1":"35b8bac7089e51b0797e9be416886f822a22d2b69650be64bf2588f712577000"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorBulkManagementExportWorkflow.newQueries (cognitive 44): PhabricatorBulkManagementExportWorkflow.newQueries has cognitive complexity 44 (threshold 15). Drivers by points: if/else 19 (36 pts), loops 5 (8 pts) (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/bulk/management/PhabricatorBulkManagementExportWorkflow.php"},"region":{"startLine":152}}}],"partialFingerprints":{"codehealthFindingId/v1":"aefed2cd0b8729906188f1b53b9803c58dd5e3d253390a19e6914ff94cd5e969"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-aphlict-dropdown.JX.behavior(\u0022aphlict-dropdown\u0022) (cognitive 44): behavior-aphlict-dropdown.JX.behavior(\u0022aphlict-dropdown\u0022) has cognitive complexity 44 (threshold 15). Drivers by points: if/else 32 (39 pts), boolean chains 3, loops 1, ternaries 1 (nesting depth added 7). Most of this is not in the body itself: 4 of the 44 points are its own statements and the rest belongs to 9 function items inside it that branch (a function literal at line 178, set_visible, update_counts, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"cb696b581c10128df7264b5eeaa056b34f7beff15f544cb7b513945532eee87c"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous) (cognitive 44): (anonymous) has cognitive complexity 44 (threshold 15). Drivers by points: if/else 32 (39 pts), boolean chains 3, loops 1, ternaries 1 (nesting depth added 7). Most of this is not in the body itself: 4 of the 44 points are its own statements and the rest belongs to 12 function items inside it that branch (a function literal at line 178, set_visible, update_counts, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"3ee095ebc38a0652db4a738034a22ad61bfbc0ca91857a1eee8f22609861ec01"}},{"ruleId":"D2","level":"warning","message":{"text":"_onjumpkey (cognitive 44): _onjumpkey has cognitive complexity 44 (threshold 15). Drivers by points: if/else 16 (36 pts), boolean chains 7, loops 1 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":650}}}],"partialFingerprints":{"codehealthFindingId/v1":"455fc12592765d55b3244e0d07411201dd8c474128e883e03d94376ae67d0467"}},{"ruleId":"D2","level":"warning","message":{"text":"_getInlinesByType (cognitive 44): _getInlinesByType has cognitive complexity 44 (threshold 15). Drivers by points: if/else 15 (39 pts), loops 3 (5 pts) (nesting depth added 26). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":1968}}}],"partialFingerprints":{"codehealthFindingId/v1":"9895c1a0685a1ad4aab606e95f445db91631accbf333eeec89b9e129207919a3"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorConfigConsoleController.loadVersions (cognitive 43): PhabricatorConfigConsoleController.loadVersions has cognitive complexity 43 (threshold 15). Drivers by points: if/else 16 (38 pts), loops 4 (5 pts) (nesting depth added 23). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/PhabricatorConfigConsoleController.php"},"region":{"startLine":139}}}],"partialFingerprints":{"codehealthFindingId/v1":"d67fdeee9329c14de4800b1d44b377855088c87e9c2c7fabae0babe72b226e2b"}},{"ruleId":"D2","level":"warning","message":{"text":"HeraldRuleQuery.willFilterPage (cognitive 43): HeraldRuleQuery.willFilterPage has cognitive complexity 43 (threshold 15). Drivers by points: if/else 16 (28 pts), loops 8 (14 pts), boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/query/HeraldRuleQuery.php"},"region":{"startLine":89}}}],"partialFingerprints":{"codehealthFindingId/v1":"38638e42ecd9ccdbd1da16becf3de7dd8703985cca0bf18fbe4c7c48f872def8"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransaction.shouldHide (cognitive 43): PhabricatorApplicationTransaction.shouldHide has cognitive complexity 43 (threshold 15). Drivers by points: if/else 17 (35 pts), match/switch 3 (5 pts), boolean chains 3 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorApplicationTransaction.php"},"region":{"startLine":588}}}],"partialFingerprints":{"codehealthFindingId/v1":"a8b795695ee6bcad4e6f7b4725f3bf746e482f7a4a1eda94490be4ad22846ef8"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCursorPagedPolicyAwareQuery.buildPagingClauseFromMultipleColumns (cognitive 43): PhabricatorCursorPagedPolicyAwareQuery.buildPagingClauseFromMultipleColumns has cognitive complexity 43 (threshold 15). Drivers by points: if/else 17 (33 pts), match/switch 1 (3 pts), ternaries 1 (3 pts), boolean chains 2, loops 2 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php"},"region":{"startLine":727}}}],"partialFingerprints":{"codehealthFindingId/v1":"a461e5622d0ecfc77ab507903682e1921ccaab3c86de5abdf087318fa99aa8f9"}},{"ruleId":"D2","level":"warning","message":{"text":"PHUITimelineEventView.render (cognitive 43): PHUITimelineEventView.render has cognitive complexity 43 (threshold 15). Drivers by points: if/else 18 (26 pts), loops 6 (9 pts), ternaries 3 (5 pts), boolean chains 3 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUITimelineEventView.php"},"region":{"startLine":318}}}],"partialFingerprints":{"codehealthFindingId/v1":"3563413055e99e1bafae2b004d853d3d07b84f292aee3448f7bf05abddd60906"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorExtraConfigSetupCheck.executeChecks (cognitive 42): PhabricatorExtraConfigSetupCheck.executeChecks has cognitive complexity 42 (threshold 15). Drivers by points: if/else 15 (36 pts), loops 4 (6 pts) (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/check/PhabricatorExtraConfigSetupCheck.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"16afdd094b281e61551d5329f3052a46e14f6b658438b0b26cc23b5a186a74d4"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorPathSetupCheck.executeChecks (cognitive 42): PhabricatorPathSetupCheck.executeChecks has cognitive complexity 42 (threshold 15). Drivers by points: if/else 15 (36 pts), loops 3 (5 pts), boolean chains 1 (nesting depth added 23). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/check/PhabricatorPathSetupCheck.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"11be9e58a5c4bbf331653c7db0bbe97f42c9b13a4ecacc8284356f436efd0aa4"}},{"ruleId":"D2","level":"warning","message":{"text":"HarbormasterBuildUnitMessage.newUnitMessageDetailsView (cognitive 42): HarbormasterBuildUnitMessage.newUnitMessageDetailsView has cognitive complexity 42 (threshold 15). Drivers by points: if/else 20 (41 pts), boolean chains 1 (nesting depth added 21). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/storage/build/HarbormasterBuildUnitMessage.php"},"region":{"startLine":174}}}],"partialFingerprints":{"codehealthFindingId/v1":"baeb35767c8f4d769cdeffd275add0ef78972bf2e19a52e0273c8d49b382f36e"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMetaMTAReceivedMail.processReceivedMail (cognitive 42): PhabricatorMetaMTAReceivedMail.processReceivedMail has cognitive complexity 42 (threshold 15). Drivers by points: if/else 14 (28 pts), loops 4 (7 pts), error handling 3 (5 pts), match/switch 1 (2 pts) (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php"},"region":{"startLine":146}}}],"partialFingerprints":{"codehealthFindingId/v1":"e932539439fdc4266719aa07d5e0ba0209b9f57f6dc1e0cc463a15f707ced299"}},{"ruleId":"D2","level":"warning","message":{"text":"PassphraseQueryConduitAPIMethod.execute (cognitive 42): PassphraseQueryConduitAPIMethod.execute has cognitive complexity 42 (threshold 15). Drivers by points: if/else 16 (37 pts), boolean chains 2, match/switch 1 (2 pts), loops 1 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/passphrase/conduit/PassphraseQueryConduitAPIMethod.php"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"8555a3c8f0b71025b985a9458d92b91363033fa5431600bd174271cf9ff7784a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorPolicyFilter.applyExtendedPolicyChecks (cognitive 42): PhabricatorPolicyFilter.applyExtendedPolicyChecks has cognitive complexity 42 (threshold 15). Drivers by points: if/else 11 (27 pts), loops 8 (15 pts) (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/filter/PhabricatorPolicyFilter.php"},"region":{"startLine":302}}}],"partialFingerprints":{"codehealthFindingId/v1":"97b95bbd9b6bbfde187fc9a2efc89c24a6d4212b254a8b5e2c7f8f69fb7c668a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectIconSet.validateConfiguration (cognitive 42): PhabricatorProjectIconSet.validateConfiguration has cognitive complexity 42 (threshold 15). Drivers by points: if/else 19 (40 pts), loops 2 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/icon/PhabricatorProjectIconSet.php"},"region":{"startLine":195}}}],"partialFingerprints":{"codehealthFindingId/v1":"3f4a8db5bf70236be2f85514abcb617f484d06ef8cce3f1668aad30cb1dee2fc"}},{"ruleId":"D2","level":"warning","message":{"text":"TransactionSearchConduitAPIMethod.execute (cognitive 42): TransactionSearchConduitAPIMethod.execute has cognitive complexity 42 (threshold 15). Drivers by points: if/else 13 (24 pts), match/switch 3 (9 pts), loops 4 (6 pts), error handling 1 (3 pts) (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php"},"region":{"startLine":102}}}],"partialFingerprints":{"codehealthFindingId/v1":"6b11761b3dbf79bf53627f4fd0527fa5e0b4e1e6f20f0124d56a378fb405ebf8"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorInternationalizationManagementExtractWorkflow.extractFiles (cognitive 42): PhabricatorInternationalizationManagementExtractWorkflow.extractFiles has cognitive complexity 42 (threshold 15). Drivers by points: match/switch 3 (16 pts), if/else 3 (13 pts), loops 5 (8 pts), error handling 2 (5 pts) (nesting depth added 29). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/internationalization/management/PhabricatorInternationalizationManagementExtractWorkflow.php"},"region":{"startLine":127}}}],"partialFingerprints":{"codehealthFindingId/v1":"946e0d95aa701526f22dd6ea2803bfe011c31dcbbfdb89e130512a0554e0cb0a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorAphlictManagementWorkflow.parseLaunchArguments (cognitive 41): PhabricatorAphlictManagementWorkflow.parseLaunchArguments has cognitive complexity 41 (threshold 15). Drivers by points: if/else 14 (21 pts), error handling 5 (6 pts), boolean chains 5, loops 4 (5 pts), match/switch 2 (4 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"751e596e8a413155df30ee4e160907bb29788f97b963ae267fef06b481645c66"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCalendarEventCancelController.handleRequest (cognitive 41): PhabricatorCalendarEventCancelController.handleRequest has cognitive complexity 41 (threshold 15). Drivers by points: if/else 17 (29 pts), loops 2 (6 pts), boolean chains 3, error handling 1 (3 pts) (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/controller/PhabricatorCalendarEventCancelController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"a1e27118c4c533b101329fe0ab6b8dd4e9ed532d247c0d2b5f53bcbdc2aaca10"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialHunkParser.generateIntraLineDiffs (cognitive 41): DifferentialHunkParser.generateIntraLineDiffs has cognitive complexity 41 (threshold 15). Drivers by points: if/else 9 (32 pts), loops 3 (7 pts), boolean chains 2 (nesting depth added 27). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialHunkParser.php"},"region":{"startLine":270}}}],"partialFingerprints":{"codehealthFindingId/v1":"db000f528fea963cdee492dc7e51a0a619b4ea122f9f651f8e4f9b74885315b6"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialChangesetRenderer.buildPrimitives (cognitive 41): DifferentialChangesetRenderer.buildPrimitives has cognitive complexity 41 (threshold 15). Drivers by points: if/else 14 (31 pts), loops 3 (7 pts), boolean chains 3 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetRenderer.php"},"region":{"startLine":453}}}],"partialFingerprints":{"codehealthFindingId/v1":"1eb6bdf8a0366fa180559790db52394cc2cec1e82e217044a903282b34fd9b52"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionCommitQuery.willFilterPage (cognitive 41): DiffusionCommitQuery.willFilterPage has cognitive complexity 41 (threshold 15). Drivers by points: if/else 10 (25 pts), loops 5 (16 pts) (nesting depth added 26). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/DiffusionCommitQuery.php"},"region":{"startLine":293}}}],"partialFingerprints":{"codehealthFindingId/v1":"34edb4776ea0ccd185fbe492da56509c0205b2bf653011f601feb0907321f5b9"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorChartStackedAreaDataset.newChartDisplayData (cognitive 41): PhabricatorChartStackedAreaDataset.newChartDisplayData has cognitive complexity 41 (threshold 15). Drivers by points: if/else 10 (26 pts), loops 9 (15 pts) (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fact/chart/PhabricatorChartStackedAreaDataset.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"9ca1f6d5785756450ce22bc38a4722767f6c493b3e113d69c9484093bca520db"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorFeedTransactionQuery.loadPage (cognitive 41): PhabricatorFeedTransactionQuery.loadPage has cognitive complexity 41 (threshold 15). Drivers by points: if/else 18 (38 pts), loops 2 (3 pts) (nesting depth added 21). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/feed/query/PhabricatorFeedTransactionQuery.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"720248620d3ab7719309c68062b5a13e6d2423706e5a8cee6836a75752d10eed"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMetaMTAMail.newMailers (cognitive 41): PhabricatorMetaMTAMail.newMailers has cognitive complexity 41 (threshold 15). Drivers by points: if/else 12 (26 pts), loops 8 (15 pts) (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/storage/PhabricatorMetaMTAMail.php"},"region":{"startLine":558}}}],"partialFingerprints":{"codehealthFindingId/v1":"a93694ebef12a06d3489169702d11b6a373d68b2ff479b831777c57f36133c0c"}},{"ruleId":"D2","level":"warning","message":{"text":"PhortuneMerchantProviderEditController.handleMerchantRequest (cognitive 41): PhortuneMerchantProviderEditController.handleMerchantRequest has cognitive complexity 41 (threshold 15). Drivers by points: if/else 15 (28 pts), loops 2 (7 pts), error handling 1 (4 pts), boolean chains 2 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/merchant/PhortuneMerchantProviderEditController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"c478dac1026cc88e13d0a6a2a59dfcea00ca79ebcd96f56e00c4e54c8c70765a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorPolicyEditController.handleRequest (cognitive 41): PhabricatorPolicyEditController.handleRequest has cognitive complexity 41 (threshold 15). Drivers by points: if/else 17 (29 pts), loops 4 (6 pts), match/switch 2 (4 pts), error handling 1 (2 pts) (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/controller/PhabricatorPolicyEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"27903fa6565066641014905fa09f2e4f0f5f2a8c269c36404f1ef7502b21b726"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectDatasource.loadResults (cognitive 41): PhabricatorProjectDatasource.loadResults has cognitive complexity 41 (threshold 15). Drivers by points: if/else 18 (31 pts), loops 3 (6 pts), boolean chains 4 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/typeahead/PhabricatorProjectDatasource.php"},"region":{"startLine":18}}}],"partialFingerprints":{"codehealthFindingId/v1":"e09f9382b1ca6260e8592a31dbc192fbc6304a6e845e0c02afb1f8d262213c4e"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryGraphCache.loadLastModifiedCommitID (cognitive 41): PhabricatorRepositoryGraphCache.loadLastModifiedCommitID has cognitive complexity 41 (threshold 15). Drivers by points: if/else 14 (34 pts), loops 3 (5 pts), boolean chains 2 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/graphcache/PhabricatorRepositoryGraphCache.php"},"region":{"startLine":75}}}],"partialFingerprints":{"codehealthFindingId/v1":"b074980a0922991932a83e7e0a333c96cf699e5b837f027aea8b3aa4eeb97a01"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryQuery.buildWhereClauseParts (cognitive 41): PhabricatorRepositoryQuery.buildWhereClauseParts has cognitive complexity 41 (threshold 15). Drivers by points: if/else 21 (34 pts), boolean chains 4, loops 1 (3 pts) (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/query/PhabricatorRepositoryQuery.php"},"region":{"startLine":533}}}],"partialFingerprints":{"codehealthFindingId/v1":"8f143d58a9536b456ba8fdd6c3e5309261fbbec5f58a97b2b8e0e0fee450edc8"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-comment-actions.JX.behavior(\u0022comment-actions\u0022) (cognitive 41): behavior-comment-actions.JX.behavior(\u0022comment-actions\u0022) has cognitive complexity 41 (threshold 15). Drivers by points: if/else 20 (32 pts), loops 5 (6 pts), boolean chains 3 (nesting depth added 13). Most of this is not in the body itself: 2 of the 41 points are its own statements and the rest belongs to 11 function items inside it that branch (add_row, ondevicechange, find_option, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/transactions/behavior-comment-actions.js"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"73246e8117743272c04accd2df79daefbebe9778933ead6d09b0d68eb9190369"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous) (cognitive 41): (anonymous) has cognitive complexity 41 (threshold 15). Drivers by points: if/else 20 (32 pts), loops 5 (6 pts), boolean chains 3 (nesting depth added 13). Most of this is not in the body itself: 2 of the 41 points are its own statements and the rest belongs to 15 function items inside it that branch (add_row, ondevicechange, find_option, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/transactions/behavior-comment-actions.js"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"eda2461cab58964bb66cffd2ced2d5ec8209acc3f9a199fcbe91e8060d85356c"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorAuthStartController.handleRequest (cognitive 40): PhabricatorAuthStartController.handleRequest has cognitive complexity 40 (threshold 15). Drivers by points: if/else 21 (30 pts), loops 5 (7 pts), match/switch 1 (2 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthStartController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"3271fce20ce759c4c78972b2ed912e41c38c8bec65c305f4b40c6d968fe4a84a"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionRefTableController.handleRequest (cognitive 40): DiffusionRefTableController.handleRequest has cognitive complexity 40 (threshold 15). Drivers by points: if/else 11 (23 pts), loops 6 (9 pts), ternaries 2 (8 pts) (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRefTableController.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"3753e9e3c3adf6d2e009036fbb3fe2c20f1955afa0aca6c74f68256b6b7ef5db"}},{"ruleId":"D2","level":"warning","message":{"text":"PhameLiveController.setupLiveEnvironment (cognitive 40): PhameLiveController.setupLiveEnvironment has cognitive complexity 40 (threshold 15). Drivers by points: if/else 20 (38 pts), boolean chains 2 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/PhameLiveController.php"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"0ad89a6c977812c972673606dabdccdde8440a6465f82ca0ebbcec46dd90d950"}},{"ruleId":"D2","level":"warning","message":{"text":"PhrictionTransactionEditor.validateTransaction (cognitive 40): PhrictionTransactionEditor.validateTransaction has cognitive complexity 40 (threshold 15). Drivers by points: if/else 11 (37 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 27). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/editor/PhrictionTransactionEditor.php"},"region":{"startLine":348}}}],"partialFingerprints":{"codehealthFindingId/v1":"68ddf74cafbc41a31fd934b5777424d017e5e8519ab6d7fec0206fd6e8bb781d"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryManagementParentsWorkflow.rebuildRepository (cognitive 40): PhabricatorRepositoryManagementParentsWorkflow.rebuildRepository has cognitive complexity 40 (threshold 15). Drivers by points: loops 13 (24 pts), if/else 7 (16 pts) (nesting depth added 20). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/management/PhabricatorRepositoryManagementParentsWorkflow.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"5e44b22e894b8499d4cc5f889092dcd19fdcbb6a40abee030be67d75bbebb085"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorSearchHovercardController.handleRequest (cognitive 40): PhabricatorSearchHovercardController.handleRequest has cognitive complexity 40 (threshold 15). Drivers by points: if/else 13 (28 pts), loops 8 (12 pts) (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/controller/PhabricatorSearchHovercardController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"aebb6a62835ab6ff263b5f943900576ba73c699d4de6b25e60c53910fc640a9d"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCacheEngine.updateObject (cognitive 40): PhabricatorCacheEngine.updateObject has cognitive complexity 40 (threshold 15). Drivers by points: if/else 10 (30 pts), loops 5 (10 pts) (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/system/engine/PhabricatorCacheEngine.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"8ed69ea12716998cd9ab1bbfd11cd9f7f0c5e134c679e4e0dfe073a4d68cadd7"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorInlineCommentController.processRequest (cognitive 40): PhabricatorInlineCommentController.processRequest has cognitive complexity 40 (threshold 15). Drivers by points: if/else 19 (36 pts), match/switch 2 (3 pts), boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/PhabricatorInlineCommentController.php"},"region":{"startLine":93}}}],"partialFingerprints":{"codehealthFindingId/v1":"82a4b71fafb519e54c7e30766fad1bc572775ad60192674cd5c986acbaab6720"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorStorageManagementRenamespaceWorkflow.didExecute (cognitive 40): PhabricatorStorageManagementRenamespaceWorkflow.didExecute has cognitive complexity 40 (threshold 15). Drivers by points: if/else 23 (33 pts), error handling 2 (3 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/management/workflow/PhabricatorStorageManagementRenamespaceWorkflow.php"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"aa1bef5e57d511a0d0add231154b3f3641a5d53a624263ad8d9744be07fa6772"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorAuthInviteAction.newActionListFromAddresses (cognitive 39): PhabricatorAuthInviteAction.newActionListFromAddresses has cognitive complexity 39 (threshold 15). Drivers by points: if/else 11 (26 pts), loops 7 (10 pts), match/switch 1 (3 pts) (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/data/PhabricatorAuthInviteAction.php"},"region":{"startLine":94}}}],"partialFingerprints":{"codehealthFindingId/v1":"d647fbeb2dd63e4be7094605ddefe3a8407b21f117270e952e272eb0f0bfe36b"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialRevisionUpdateHistoryView.render (cognitive 39): DifferentialRevisionUpdateHistoryView.render has cognitive complexity 39 (threshold 15). Drivers by points: if/else 15 (27 pts), ternaries 3 (9 pts), loops 2, boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"e24e15e10bd3befcaa271ca73cc60184e49084736981495505e96f7cdfed284d"}},{"ruleId":"D2","level":"warning","message":{"text":"PhrictionDocumentQuery.willFilterPage (cognitive 39): PhrictionDocumentQuery.willFilterPage has cognitive complexity 39 (threshold 15). Drivers by points: loops 9 (20 pts), if/else 9 (19 pts) (nesting depth added 21). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/query/PhrictionDocumentQuery.php"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"907140b8b868271b24a14c158b606f313ed751a1c0d5ed06d63b5060bf675d72"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-commit-graph.JX.behavior(\u0022diffusion-commit-graph\u0022) (cognitive 39): behavior-commit-graph.JX.behavior(\u0022diffusion-commit-graph\u0022) has cognitive complexity 39 (threshold 15). Drivers by points: if/else 6 (13 pts), ternaries 2 (10 pts), loops 5 (9 pts), match/switch 2 (6 pts), boolean chains 1 (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diffusion/behavior-commit-graph.js"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"b72276bcb90ab784e2698b64b61cd5bf2678faea91c9f6af8b94bd26c5dfed5f"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous) (cognitive 39): (anonymous) has cognitive complexity 39 (threshold 15). Drivers by points: if/else 6 (13 pts), ternaries 2 (10 pts), loops 5 (9 pts), match/switch 2 (6 pts), boolean chains 1 (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diffusion/behavior-commit-graph.js"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"3e55afcaf11adc06238404fbde1dd8cff3d5ca2fb098264fe57749bf163b3841"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorAuditManagementDeleteWorkflow.execute (cognitive 38): PhabricatorAuditManagementDeleteWorkflow.execute has cognitive complexity 38 (threshold 15). Drivers by points: if/else 14 (23 pts), loops 6 (9 pts), boolean chains 6 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/management/PhabricatorAuditManagementDeleteWorkflow.php"},"region":{"startLine":62}}}],"partialFingerprints":{"codehealthFindingId/v1":"b17296a2d7b834e81fd35f69a291087a278a0867d01ef258a2bd7935c87ee662"}},{"ruleId":"D2","level":"warning","message":{"text":"CelerityResourceController.serveResource (cognitive 38): CelerityResourceController.serveResource has cognitive complexity 38 (threshold 15). Drivers by points: if/else 17 (25 pts), error handling 2 (6 pts), boolean chains 4, loops 1 (3 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/celerity/controller/CelerityResourceController.php"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"6aaaa309b6784ce066626a7472b690f0d476cfffb3e94357d5ef78e1f316da60"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorDashboardTabsPanelType.renderPanelContent (cognitive 38): PhabricatorDashboardTabsPanelType.renderPanelContent has cognitive complexity 38 (threshold 15). Drivers by points: if/else 18 (30 pts), boolean chains 3, loops 3, ternaries 1 (2 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"43c35d733cdbd806572213e670c99756138528bdee00c6a99f66894b17b62c9f"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialGetCommitMessageConduitAPIMethod.execute (cognitive 38): DifferentialGetCommitMessageConduitAPIMethod.execute has cognitive complexity 38 (threshold 15). Drivers by points: if/else 15 (28 pts), boolean chains 5, loops 4 (5 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"55a8dab90bda7de56c5404ad0e6f84e038a247b4e1966ad42dfb3053957d886f"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionRepositoryProfilePictureController.handleRequest (cognitive 38): DiffusionRepositoryProfilePictureController.handleRequest has cognitive complexity 38 (threshold 15). Drivers by points: if/else 19 (35 pts), loops 2, boolean chains 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"dfd13eaa2a5caa7c3ce228da4533f12b6f78ef4ea9f1aa862c886b1e3c1445f4"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorFeedStory.loadAllFromRows (cognitive 38): PhabricatorFeedStory.loadAllFromRows has cognitive complexity 38 (threshold 15). Drivers by points: loops 14 (20 pts), if/else 8 (15 pts), error handling 1 (2 pts), boolean chains 1 (nesting depth added 14). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/feed/story/PhabricatorFeedStory.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"f38a8d7a1df1101e549ec47e73eeff30f776ce5be09421dad238dcc1abac747b"}},{"ruleId":"D2","level":"warning","message":{"text":"HeraldEngine.applyRules (cognitive 38): HeraldEngine.applyRules has cognitive complexity 38 (threshold 15). Drivers by points: if/else 9 (18 pts), loops 4 (10 pts), error handling 4 (8 pts), boolean chains 2 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/engine/HeraldEngine.php"},"region":{"startLine":126}}}],"partialFingerprints":{"codehealthFindingId/v1":"b66be8aeeeca7c63298e492ad09c93463e7ce530d774c8e56309cdab040e088a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorEmailAddressesSettingsPanel.returnNewAddressResponse (cognitive 38): PhabricatorEmailAddressesSettingsPanel.returnNewAddressResponse has cognitive complexity 38 (threshold 15). Drivers by points: if/else 15 (34 pts), error handling 1 (3 pts), boolean chains 1 (nesting depth added 21). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php"},"region":{"startLine":158}}}],"partialFingerprints":{"codehealthFindingId/v1":"3593a009014adf790338385a21904e9cad30c27704b4e1333500c330f96e63b3"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCursorPagedPolicyAwareQuery.buildEdgeLogicJoinClause (cognitive 38): PhabricatorCursorPagedPolicyAwareQuery.buildEdgeLogicJoinClause has cognitive complexity 38 (threshold 15). Drivers by points: loops 7 (24 pts), if/else 3 (7 pts), match/switch 2 (7 pts) (nesting depth added 26). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php"},"region":{"startLine":2694}}}],"partialFingerprints":{"codehealthFindingId/v1":"5c3920f4c03cde1f737382bbeb7e89c3c9abdb202c9ce9829b379ab208bfdf55"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorConfigDatabaseIssueController.handleRequest (cognitive 37): PhabricatorConfigDatabaseIssueController.handleRequest has cognitive complexity 37 (threshold 15). Drivers by points: loops 11 (33 pts), if/else 3 (4 pts) (nesting depth added 23). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/services/PhabricatorConfigDatabaseIssueController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"d94372d5be965350124c21338814b87976ee351639f2ff9eec19bdd23274e38d"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionLowLevelResolveRefsQuery.resolveMercurialRefs (cognitive 37): DiffusionLowLevelResolveRefsQuery.resolveMercurialRefs has cognitive complexity 37 (threshold 15). Drivers by points: if/else 9 (19 pts), loops 9 (16 pts), error handling 1 (2 pts) (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/lowlevel/DiffusionLowLevelResolveRefsQuery.php"},"region":{"startLine":243}}}],"partialFingerprints":{"codehealthFindingId/v1":"967f2670d9984a09797bb7198878ee9634a05a17d01897c3fe29897efe5999c6"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionCommitGraphView.newObjectItemViews (cognitive 37): DiffusionCommitGraphView.newObjectItemViews has cognitive complexity 37 (threshold 15). Drivers by points: if/else 11 (25 pts), loops 6 (12 pts) (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/view/DiffusionCommitGraphView.php"},"region":{"startLine":105}}}],"partialFingerprints":{"codehealthFindingId/v1":"b016fa1d866e15271464b20974054962326613e204e8fa919af87195bd34b156"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorOwnersPackageQuery.getControllingPackagesForPath (cognitive 37): PhabricatorOwnersPackageQuery.getControllingPackagesForPath has cognitive complexity 37 (threshold 15). Drivers by points: if/else 12 (26 pts), loops 6 (10 pts), boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/owners/query/PhabricatorOwnersPackageQuery.php"},"region":{"startLine":369}}}],"partialFingerprints":{"codehealthFindingId/v1":"817c0fbf746933dcce775ca209a8dc56a8b96d047a592483ba5b87a4cd157c8a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectColumnQuery.didFilterPage (cognitive 37): PhabricatorProjectColumnQuery.didFilterPage has cognitive complexity 37 (threshold 15). Drivers by points: if/else 14 (31 pts), loops 4 (6 pts) (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/query/PhabricatorProjectColumnQuery.php"},"region":{"startLine":88}}}],"partialFingerprints":{"codehealthFindingId/v1":"33c11772412a7ea7d257c0767f5ddb6195b4e669b5df43cc5c237b1c3ad978a3"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectQuery.willFilterPage (cognitive 37): PhabricatorProjectQuery.willFilterPage has cognitive complexity 37 (threshold 15). Drivers by points: if/else 18 (26 pts), loops 6 (8 pts), boolean chains 3 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/query/PhabricatorProjectQuery.php"},"region":{"startLine":239}}}],"partialFingerprints":{"codehealthFindingId/v1":"a278ff27cfc1dd54249eb25d880bc7ea59caee30a1abc117b8632c5df90ec7b7"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryPullEngine.pullRepositoryWithLock (cognitive 37): PhabricatorRepositoryPullEngine.pullRepositoryWithLock has cognitive complexity 37 (threshold 15). Drivers by points: if/else 20 (33 pts), loops 1 (2 pts), error handling 1, match/switch 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/engine/PhabricatorRepositoryPullEngine.php"},"region":{"startLine":51}}}],"partialFingerprints":{"codehealthFindingId/v1":"012d5fdcc0ac2df85d9a06c78f98081635a60cafc2d434c32f84287de944d81f"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryRefEngine.updateCursors (cognitive 37): PhabricatorRepositoryRefEngine.updateCursors has cognitive complexity 37 (threshold 15). Drivers by points: if/else 12 (25 pts), loops 6 (11 pts), boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/engine/PhabricatorRepositoryRefEngine.php"},"region":{"startLine":258}}}],"partialFingerprints":{"codehealthFindingId/v1":"8f85c49f28e97d2de51128364a19cfbef768d9cbd59b7ba09b14e44d521f243e"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationSearchEngine.buildConduitResponse (cognitive 37): PhabricatorApplicationSearchEngine.buildConduitResponse has cognitive complexity 37 (threshold 15). Drivers by points: if/else 11 (19 pts), loops 11 (17 pts), boolean chains 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorApplicationSearchEngine.php"},"region":{"startLine":1144}}}],"partialFingerprints":{"codehealthFindingId/v1":"f6f384a804b7ef9a4a86061ce12cdc4dea2405e9109ea4e607a3f1f8521fe510"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilRemarkupCodeBlockRule.markupText (cognitive 37): PhutilRemarkupCodeBlockRule.markupText has cognitive complexity 37 (threshold 15). Drivers by points: if/else 19 (30 pts), loops 4 (6 pts), boolean chains 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/blockrule/PhutilRemarkupCodeBlockRule.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"edc9915f7065df075d65b22d9723b6f48c2d006987260a6afdfbecf9a4b461b4"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorActionView.render (cognitive 37): PhabricatorActionView.render has cognitive complexity 37 (threshold 15). Drivers by points: if/else 26 (34 pts), loops 1 (2 pts), ternaries 1 (nesting depth added 9). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/layout/PhabricatorActionView.php"},"region":{"startLine":198}}}],"partialFingerprints":{"codehealthFindingId/v1":"76ff5a640ca67d80cf9fc26f51f1030898322a8d03a049abe0903d8bad97fd75"}},{"ruleId":"D2","level":"warning","message":{"text":"start (cognitive 37): start has cognitive complexity 37 (threshold 15). Drivers by points: if/else 21 (31 pts), loops 4 (5 pts), boolean chains 1 (nesting depth added 11). Most of this is not in the body itself: 4 of the 37 points are its own statements and the rest belongs to 7 function items inside it that branch (a function literal at line 185, a function literal at line 105, contains, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/DragAndDropFileUpload.js"},"region":{"startLine":75}}}],"partialFingerprints":{"codehealthFindingId/v1":"f400d636e686b1f7db391f2ddd31bbc0f5ad9b2c9340616a36995ba226299177"}},{"ruleId":"D2","level":"warning","message":{"text":"ConpherenceTransactionRenderer.renderTransactions (cognitive 36): ConpherenceTransactionRenderer.renderTransactions has cognitive complexity 36 (threshold 15). Drivers by points: if/else 15 (33 pts), loops 2, boolean chains 1 (nesting depth added 18). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/ConpherenceTransactionRenderer.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"5d3ea4087b2713efdf334f98b8dc01be7992ac3438766950d4b9f0f0b567980f"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialTransactionEditor.buildMailBody (cognitive 36): DifferentialTransactionEditor.buildMailBody has cognitive complexity 36 (threshold 15). Drivers by points: if/else 13 (25 pts), boolean chains 4, error handling 1 (3 pts), loops 2, match/switch 1 (2 pts) (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/editor/DifferentialTransactionEditor.php"},"region":{"startLine":662}}}],"partialFingerprints":{"codehealthFindingId/v1":"6252a637206dffaccdefe6c1935388e04e35f263a11c4af7c54bd0fc1064b85b"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialTransaction.getTitleForFeed (cognitive 36): DifferentialTransaction.getTitleForFeed has cognitive complexity 36 (threshold 15). Drivers by points: if/else 12 (30 pts), boolean chains 3, match/switch 2 (3 pts) (nesting depth added 19). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialTransaction.php"},"region":{"startLine":281}}}],"partialFingerprints":{"codehealthFindingId/v1":"b9dc3df3e81d19cb15ad45933dee6deaf3301b0fc60b1cea91588b285379fe4c"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialRevisionListView.render (cognitive 36): DifferentialRevisionListView.render has cognitive complexity 36 (threshold 15). Drivers by points: if/else 17 (29 pts), loops 4 (6 pts), boolean chains 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/view/DifferentialRevisionListView.php"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"d734b07af42b3334fecd046ed4beb14eb83036dfa4a8961463c2278256d92c8b"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialRevisionReviewTransaction.applyReviewerEffect (cognitive 36): DifferentialRevisionReviewTransaction.applyReviewerEffect has cognitive complexity 36 (threshold 15). Drivers by points: if/else 13 (29 pts), loops 2 (4 pts), error handling 1 (3 pts) (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/xaction/DifferentialRevisionReviewTransaction.php"},"region":{"startLine":163}}}],"partialFingerprints":{"codehealthFindingId/v1":"f1d536a5e8e5640446d4a31ff5aa5037dcf8b2d240e75a3245e82ab682b5a207"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionCommitController.buildPropertyListView (cognitive 36): DiffusionCommitController.buildPropertyListView has cognitive complexity 36 (threshold 15). Drivers by points: if/else 20 (25 pts), loops 5 (10 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionCommitController.php"},"region":{"startLine":524}}}],"partialFingerprints":{"codehealthFindingId/v1":"083ea36d34eb2824edf09ab008234b4fcfedbc7713c7fa81fe5fbaf5dc52c2f1"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorFileViewController.buildPropertyViews (cognitive 36): PhabricatorFileViewController.buildPropertyViews has cognitive complexity 36 (threshold 15). Drivers by points: if/else 19 (24 pts), ternaries 2 (6 pts), boolean chains 3, loops 1 (3 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/controller/PhabricatorFileViewController.php"},"region":{"startLine":218}}}],"partialFingerprints":{"codehealthFindingId/v1":"814effaa5063b782d6580256c8ba69a5b38b28b207609aa7a90a6ce0159a7b8e"}},{"ruleId":"D2","level":"warning","message":{"text":"HarbormasterBuildEngine.updateBuildable (cognitive 36): HarbormasterBuildEngine.updateBuildable has cognitive complexity 36 (threshold 15). Drivers by points: if/else 15 (29 pts), loops 2 (3 pts), boolean chains 2, match/switch 1 (2 pts) (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/engine/HarbormasterBuildEngine.php"},"region":{"startLine":442}}}],"partialFingerprints":{"codehealthFindingId/v1":"611f01793f281959dab81688f5a5ac749310423c2c7cfe11048c59e12dac833e"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectEditPictureController.handleRequest (cognitive 36): PhabricatorProjectEditPictureController.handleRequest has cognitive complexity 36 (threshold 15). Drivers by points: if/else 18 (33 pts), loops 2, boolean chains 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectEditPictureController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"8305abb12913eb4f56394acf3492a47bb379beb2da2ccec32480c1df5c68fcc2"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepository.generateURI (cognitive 36): PhabricatorRepository.generateURI has cognitive complexity 36 (threshold 15). Drivers by points: if/else 17 (25 pts), boolean chains 9, match/switch 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepository.php"},"region":{"startLine":681}}}],"partialFingerprints":{"codehealthFindingId/v1":"fe0dceb0300edb010363c32d35f63f2ee7df93ff4ccdf98f5c702db722cb790a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorSubscriptionsHeraldAction.applySubscribe (cognitive 36): PhabricatorSubscriptionsHeraldAction.applySubscribe has cognitive complexity 36 (threshold 15). Drivers by points: if/else 19 (29 pts), loops 4 (7 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/subscriptions/herald/PhabricatorSubscriptionsHeraldAction.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"1f2a990df4fabe6062a104c003bce71077f7f3913402915f60201d3aa7dd1afd"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilXHPASTSyntaxHighlighterFuture.applyXHPHighlight (cognitive 36): PhutilXHPASTSyntaxHighlighterFuture.applyXHPHighlight has cognitive complexity 36 (threshold 15). Drivers by points: if/else 13 (28 pts), loops 2 (4 pts), match/switch 1 (3 pts), boolean chains 1 (nesting depth added 19). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/syntax/highlighter/xhpast/PhutilXHPASTSyntaxHighlighterFuture.php"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"b293fe0d4f32da4f73c3dc379c25dc623998c5a7ec3f4733ebadf9ae48e75310"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorStandardPageView.willRenderPage (cognitive 36): PhabricatorStandardPageView.willRenderPage has cognitive complexity 36 (threshold 15). Drivers by points: if/else 19 (28 pts), ternaries 2 (8 pts) (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/page/PhabricatorStandardPageView.php"},"region":{"startLine":199}}}],"partialFingerprints":{"codehealthFindingId/v1":"516ca931cd8a8c1e90f5d660d0a22e22035439dab6bb8e4306d867991f903634"}},{"ruleId":"D2","level":"warning","message":{"text":"redraw (cognitive 36): redraw has cognitive complexity 36 (threshold 15). Drivers by points: if/else 14 (26 pts), loops 8 (9 pts), boolean chains 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffTreeView.js"},"region":{"startLine":87}}}],"partialFingerprints":{"codehealthFindingId/v1":"f7fb60254d0135d3164458c502cd3297f0c2933b23a1b82f3db03f7e95837733"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorAuditTransaction.getTitleForFeed (cognitive 35): PhabricatorAuditTransaction.getTitleForFeed has cognitive complexity 35 (threshold 15). Drivers by points: if/else 16 (30 pts), match/switch 3 (4 pts), boolean chains 1 (nesting depth added 15). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/storage/PhabricatorAuditTransaction.php"},"region":{"startLine":297}}}],"partialFingerprints":{"codehealthFindingId/v1":"a1cfca0bf04a8944f967f1d74d5cfca5d785f110b8c0b8062c709be19ac27a79"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorAuthLoginController.handleRequest (cognitive 35): PhabricatorAuthLoginController.handleRequest has cognitive complexity 35 (threshold 15). Drivers by points: if/else 20 (33 pts), boolean chains 1, error handling 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthLoginController.php"},"region":{"startLine":28}}}],"partialFingerprints":{"codehealthFindingId/v1":"90868aca83d9f16e5880ad24b661f402524b416179295ba9f0e1a9af6e083567"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorDuoAuthFactor.processAddFactorForm (cognitive 35): PhabricatorDuoAuthFactor.processAddFactorForm has cognitive complexity 35 (threshold 15). Drivers by points: if/else 13 (23 pts), match/switch 2 (8 pts), ternaries 1 (3 pts), boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/factor/PhabricatorDuoAuthFactor.php"},"region":{"startLine":155}}}],"partialFingerprints":{"codehealthFindingId/v1":"5b5f03274d6cdc679a49a4c08a3dc3456e524e7136efea417ed2c7c616b66cb3"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilCalendarRecurrenceRule.newYearMap (cognitive 35): PhutilCalendarRecurrenceRule.newYearMap has cognitive complexity 35 (threshold 15). Drivers by points: if/else 18 (27 pts), loops 5, boolean chains 2, ternaries 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php"},"region":{"startLine":1349}}}],"partialFingerprints":{"codehealthFindingId/v1":"c00af5f2e47c0cdd9817c6b0ee177f274f24d3c8d88720a5679068e329f13cc3"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorWebServerSetupCheck.executeChecks (cognitive 35): PhabricatorWebServerSetupCheck.executeChecks has cognitive complexity 35 (threshold 15). Drivers by points: if/else 20 (25 pts), boolean chains 5, error handling 3, loops 2 (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/check/PhabricatorWebServerSetupCheck.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"d942ac1971abea166e6fa3f66e2abc4f2939a9e895c178ea625f1b85cf8ea974"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorConfigEditController.handleRequest (cognitive 35): PhabricatorConfigEditController.handleRequest has cognitive complexity 35 (threshold 15). Drivers by points: if/else 24 (29 pts), error handling 1 (3 pts), boolean chains 2, loops 1 (nesting depth added 7). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/settings/PhabricatorConfigEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"942b390494a9796d901c0cd16cbc5e1e015b4538a3d6041dd534d6689c269571"}},{"ruleId":"D2","level":"warning","message":{"text":"ConpherenceRoomPictureController.handleRequest (cognitive 35): ConpherenceRoomPictureController.handleRequest has cognitive complexity 35 (threshold 15). Drivers by points: if/else 18 (33 pts), boolean chains 1, loops 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceRoomPictureController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"48cd96171793f7d1bc594dbd8c005df296d94d51eda6b769f26f68f0fbaff5e1"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialTransactionEditor.updateReviewStatus (cognitive 35): DifferentialTransactionEditor.updateReviewStatus has cognitive complexity 35 (threshold 15). Drivers by points: if/else 14 (27 pts), boolean chains 5, match/switch 1 (2 pts), loops 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/editor/DifferentialTransactionEditor.php"},"region":{"startLine":403}}}],"partialFingerprints":{"codehealthFindingId/v1":"6bae12224ef3cdc959cdd8b47ed5a14b74e614a7becb5e8b71cc35eb874e4c66"}},{"ruleId":"D2","level":"warning","message":{"text":"DivinerAtomQuery.buildWhereClause (cognitive 35): DivinerAtomQuery.buildWhereClause has cognitive complexity 35 (threshold 15). Drivers by points: if/else 21 (30 pts), loops 2 (4 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/query/DivinerAtomQuery.php"},"region":{"startLine":302}}}],"partialFingerprints":{"codehealthFindingId/v1":"7cc4ba6fa05e8045e5087fe953b71f31bf01c2f03254ce5778d078b957a2c3b2"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorFileQuery.loadPage (cognitive 35): PhabricatorFileQuery.loadPage has cognitive complexity 35 (threshold 15). Drivers by points: if/else 14 (25 pts), loops 6 (10 pts) (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/query/PhabricatorFileQuery.php"},"region":{"startLine":166}}}],"partialFingerprints":{"codehealthFindingId/v1":"637b267544fc2f9689aa29bc32dfc1501886d82df9736cc92e94188600d15c17"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMailEmailEngine.newMessage (cognitive 35): PhabricatorMailEmailEngine.newMessage has cognitive complexity 35 (threshold 15). Drivers by points: if/else 19 (27 pts), loops 3 (5 pts), boolean chains 3 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/engine/PhabricatorMailEmailEngine.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"92d296f8b99a3b937ddcc3595f7dd86261ba60e9fc397d23b9d9af05176d83dc"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMetaMTAMemberQuery.execute (cognitive 35): PhabricatorMetaMTAMemberQuery.execute has cognitive complexity 35 (threshold 15). Drivers by points: loops 10 (24 pts), if/else 4 (9 pts), match/switch 1 (2 pts) (nesting depth added 20). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/query/PhabricatorMetaMTAMemberQuery.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"a94f721b72042ca266413b0ac7406df34b6ab130d7ff331847dc9085f31ce3a1"}},{"ruleId":"D2","level":"warning","message":{"text":"PhameBlogProfilePictureController.handleRequest (cognitive 35): PhameBlogProfilePictureController.handleRequest has cognitive complexity 35 (threshold 15). Drivers by points: if/else 18 (33 pts), boolean chains 1, loops 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/blog/PhameBlogProfilePictureController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"f60c50aeafc2f8415336de6e5fe5b4cc4e28044f9d842d2468b6b254c1a775cb"}},{"ruleId":"D2","level":"warning","message":{"text":"PhrequentUserTimeQuery.didFilterPage (cognitive 35): PhrequentUserTimeQuery.didFilterPage has cognitive complexity 35 (threshold 15). Drivers by points: if/else 7 (26 pts), loops 3 (7 pts), boolean chains 2 (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phrequent/query/PhrequentUserTimeQuery.php"},"region":{"startLine":159}}}],"partialFingerprints":{"codehealthFindingId/v1":"8acb3063bfd0a4965617336e8d04ee8d48901871feba57e1e9f9ad57a615e65a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectSearchEngine.buildQueryFromParameters (cognitive 35): PhabricatorProjectSearchEngine.buildQueryFromParameters has cognitive complexity 35 (threshold 15). Drivers by points: if/else 23 (32 pts), boolean chains 3 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/query/PhabricatorProjectSearchEngine.php"},"region":{"startLine":130}}}],"partialFingerprints":{"codehealthFindingId/v1":"ff3f8a07026d729ad2b0cb79fac02cb64e66969851089833d2523bc90ebc75ed"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorSearchRelationshipController.handleRequest (cognitive 35): PhabricatorSearchRelationshipController.handleRequest has cognitive complexity 35 (threshold 15). Drivers by points: if/else 13 (23 pts), loops 2 (5 pts), error handling 2 (4 pts), boolean chains 3 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/controller/PhabricatorSearchRelationshipController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"c0d511f5646ab8c5afcc33f04e6c689d2cac991d3c7f19dfc30cdeac946fcef4"}},{"ruleId":"D2","level":"warning","message":{"text":"PHUICalendarMonthView.render (cognitive 35): PHUICalendarMonthView.render has cognitive complexity 35 (threshold 15). Drivers by points: if/else 9 (22 pts), loops 7 (12 pts), boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/calendar/PHUICalendarMonthView.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"8ffdd3febed948b751cf304999be62d58a1d180e62527c3cfe6b26269f946c50"}},{"ruleId":"D2","level":"warning","message":{"text":"_getFragmentLocation (cognitive 35): _getFragmentLocation has cognitive complexity 35 (threshold 15). Drivers by points: if/else 21 (31 pts), error handling 2, boolean chains 1, loops 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":2643}}}],"partialFingerprints":{"codehealthFindingId/v1":"ad2e8a74695ffcf55995ec3bdc9ad717946f3ec271c6037bd6ec8fb93e731762"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorConfigSchemaQuery.loadActualSchemaForServer (cognitive 34): PhabricatorConfigSchemaQuery.loadActualSchemaForServer has cognitive complexity 34 (threshold 15). Drivers by points: loops 8 (16 pts), if/else 6 (14 pts), error handling 2 (4 pts) (nesting depth added 18). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/schema/PhabricatorConfigSchemaQuery.php"},"region":{"startLine":64}}}],"partialFingerprints":{"codehealthFindingId/v1":"443f22952cbd6be99dedbb8e03ebcf8fc553b539b5cdcb8df373503803359346"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialRevisionViewController.getOldDiffID (cognitive 34): DifferentialRevisionViewController.getOldDiffID has cognitive complexity 34 (threshold 15). Drivers by points: if/else 12 (26 pts), loops 2 (7 pts), boolean chains 1 (nesting depth added 19). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/controller/DifferentialRevisionViewController.php"},"region":{"startLine":1321}}}],"partialFingerprints":{"codehealthFindingId/v1":"a16630b1171eaff731efd06cce486e4dd9efe617ec4a178ad00d68fe03639764"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialChangesetParser.newDocumentEngine (cognitive 34): DifferentialChangesetParser.newDocumentEngine has cognitive complexity 34 (threshold 15). Drivers by points: if/else 24 (32 pts), boolean chains 1, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialChangesetParser.php"},"region":{"startLine":1746}}}],"partialFingerprints":{"codehealthFindingId/v1":"14136990705fceace859241782c5ee0bcba615c46ea3fdcd1c38d4a41278dfdd"}},{"ruleId":"D2","level":"warning","message":{"text":"DivinerPHPAtomizer.executeAtomize (cognitive 34): DivinerPHPAtomizer.executeAtomize has cognitive complexity 34 (threshold 15). Drivers by points: loops 8 (21 pts), if/else 3 (7 pts), match/switch 1 (6 pts) (nesting depth added 22). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/atomizer/DivinerPHPAtomizer.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"2104cd372831ba62e6fdaa6f39f7879de6e3397aba7fd80c5d517a6a8368a9e2"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorFilesManagementRebuildWorkflow.execute (cognitive 34): PhabricatorFilesManagementRebuildWorkflow.execute has cognitive complexity 34 (threshold 15). Drivers by points: if/else 12 (25 pts), loops 3 (5 pts), error handling 1 (3 pts), boolean chains 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/management/PhabricatorFilesManagementRebuildWorkflow.php"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"f27bb3dbd8189cb04f6278ca99279a6d675a5e13659493ed5791f0c6145fa273"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorFile.newFromFileDownload (cognitive 34): PhabricatorFile.newFromFileDownload has cognitive complexity 34 (threshold 15). Drivers by points: if/else 13 (28 pts), loops 2 (4 pts), error handling 1 (2 pts) (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/storage/PhabricatorFile.php"},"region":{"startLine":589}}}],"partialFingerprints":{"codehealthFindingId/v1":"fc9b006a352a484a9cb03e572d49b496224ae0866bf8954ff83181a4aba33149"}},{"ruleId":"D2","level":"warning","message":{"text":"ManiphestConduitAPIMethod.applyRequest (cognitive 34): ManiphestConduitAPIMethod.applyRequest has cognitive complexity 34 (threshold 15). Drivers by points: if/else 20 (30 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"f8333913137594c76eae8774c683b74d6432fe85401e2a53ef5a86985b950a60"}},{"ruleId":"D2","level":"warning","message":{"text":"NuanceGitHubImportCursor.pullDataFromSource (cognitive 34): NuanceGitHubImportCursor.pullDataFromSource has cognitive complexity 34 (threshold 15). Drivers by points: if/else 13 (26 pts), loops 5 (8 pts) (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/cursor/NuanceGitHubImportCursor.php"},"region":{"startLine":56}}}],"partialFingerprints":{"codehealthFindingId/v1":"ffa5426f47105c64f97c2f3a361e717197ad5c2c4120ca33e7f721e64ceafaa6"}},{"ruleId":"D2","level":"warning","message":{"text":"PhortuneMerchantPictureController.handleMerchantRequest (cognitive 34): PhortuneMerchantPictureController.handleMerchantRequest has cognitive complexity 34 (threshold 15). Drivers by points: if/else 17 (32 pts), boolean chains 1, loops 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/merchant/PhortuneMerchantPictureController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"7864c1f206a25c0edb707fbba635420dfbd974698aa8bee3af1b370eebb766bf"}},{"ruleId":"D2","level":"warning","message":{"text":"PhrequentTrackController.processRequest (cognitive 34): PhrequentTrackController.processRequest has cognitive complexity 34 (threshold 15). Drivers by points: if/else 15 (33 pts), match/switch 1 (nesting depth added 18). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phrequent/controller/PhrequentTrackController.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"e60179726abc429649e2bfb12039a5f51cf2eea80d887317a5e55e17ca65d528"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectTriggerSearchEngine.renderResultList (cognitive 34): PhabricatorProjectTriggerSearchEngine.renderResultList has cognitive complexity 34 (threshold 15). Drivers by points: if/else 14 (32 pts), loops 2 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/query/PhabricatorProjectTriggerSearchEngine.php"},"region":{"startLine":72}}}],"partialFingerprints":{"codehealthFindingId/v1":"0282adfa5cc384f8d98952ff91121e8e7c7e2b8606c2685ba22da267fc234d4a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransactionEditor.addHeadersAndCommentsToMailBody (cognitive 34): PhabricatorApplicationTransactionEditor.addHeadersAndCommentsToMailBody has cognitive complexity 34 (threshold 15). Drivers by points: if/else 13 (28 pts), loops 4, boolean chains 2 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":3859}}}],"partialFingerprints":{"codehealthFindingId/v1":"47670658033095f5ea23d6e7ae220f447b373a58a14224f37c3c38d2b60a2fb4"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilRemarkupSimpleTableBlockRule.markupText (cognitive 34): PhutilRemarkupSimpleTableBlockRule.markupText has cognitive complexity 34 (threshold 15). Drivers by points: if/else 9 (26 pts), loops 3 (7 pts), boolean chains 1 (nesting depth added 21). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/blockrule/PhutilRemarkupSimpleTableBlockRule.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"2aaf8e33d69a7f20273b22bbe7c378008ffaeec00e1ef3c9ac996edbe4330796"}},{"ruleId":"D2","level":"warning","message":{"text":"render.phutil_escape_html (cognitive 34): render.phutil_escape_html has cognitive complexity 34 (threshold 15). Drivers by points: if/else 12 (24 pts), error handling 1 (6 pts), loops 1 (4 pts) (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/render.php"},"region":{"startLine":107}}}],"partialFingerprints":{"codehealthFindingId/v1":"7cff1a3e6e865e04b800dbea3f12a76fb53bc6e76265063078aefaa30c36a568"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionCommitHookEngine.findGitChangeFlags (cognitive 33): DiffusionCommitHookEngine.findGitChangeFlags has cognitive complexity 33 (threshold 15). Drivers by points: if/else 11 (31 pts), boolean chains 1, loops 1 (nesting depth added 20). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/engine/DiffusionCommitHookEngine.php"},"region":{"startLine":526}}}],"partialFingerprints":{"codehealthFindingId/v1":"91a390b3966fbdaa43fa1e9a035d2cfe9eaa2987dd9d33408e27e337516ea69f"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionRepositoryClusterEngine.synchronizeWorkingCopyBeforeRead (cognitive 33): DiffusionRepositoryClusterEngine.synchronizeWorkingCopyBeforeRead has cognitive complexity 33 (threshold 15). Drivers by points: if/else 15 (25 pts), loops 2 (6 pts), boolean chains 1, error handling 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php"},"region":{"startLine":153}}}],"partialFingerprints":{"codehealthFindingId/v1":"a79312848188837093c6fd4601f922e7585f35668f71c8b022b5f5262034b6b3"}},{"ruleId":"D2","level":"warning","message":{"text":"HeraldTranscriptController.buildActionTranscriptPanel (cognitive 33): HeraldTranscriptController.buildActionTranscriptPanel has cognitive complexity 33 (threshold 15). Drivers by points: if/else 11 (25 pts), loops 4 (8 pts) (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/controller/HeraldTranscriptController.php"},"region":{"startLine":226}}}],"partialFingerprints":{"codehealthFindingId/v1":"8a0b1e70edd3adf25a05349ac30b99d645677abd72f151bce4529f9ff9fd5e31"}},{"ruleId":"D2","level":"warning","message":{"text":"PhluxEditController.handleRequest (cognitive 33): PhluxEditController.handleRequest has cognitive complexity 33 (threshold 15). Drivers by points: if/else 17 (27 pts), error handling 1 (3 pts), boolean chains 2, ternaries 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phlux/controller/PhluxEditController.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"9914e6bb9eaba16034a10a33007de9d57e65caa5605ba5c4edb9f227f6ca2c89"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorPhortuneManagementInvoiceWorkflow.execute (cognitive 33): PhabricatorPhortuneManagementInvoiceWorkflow.execute has cognitive complexity 33 (threshold 15). Drivers by points: if/else 14 (25 pts), boolean chains 7, ternaries 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/management/PhabricatorPhortuneManagementInvoiceWorkflow.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"d68dd7741b6945864d1b79316330aceecfbc0fbc6db3dafe541dfcc8e74e8187"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepository.getAlmanacServiceRefs (cognitive 33): PhabricatorRepository.getAlmanacServiceRefs has cognitive complexity 33 (threshold 15). Drivers by points: if/else 18 (27 pts), loops 3 (4 pts), boolean chains 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepository.php"},"region":{"startLine":1858}}}],"partialFingerprints":{"codehealthFindingId/v1":"9a2da66655e76e09f5d9448f8bef1c0f03153b1d487797225872f8524fa7d813"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositorySvnCommitChangeParserWorker.parseRecursiveListFileData (cognitive 33): PhabricatorRepositorySvnCommitChangeParserWorker.parseRecursiveListFileData has cognitive complexity 33 (threshold 15). Drivers by points: if/else 12 (30 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/commitchangeparser/PhabricatorRepositorySvnCommitChangeParserWorker.php"},"region":{"startLine":676}}}],"partialFingerprints":{"codehealthFindingId/v1":"1d8af2e32adb970ae12914cba2401138031b89b1bf9113cd1cc119f826901690"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationSearchController.newQueryListView (cognitive 33): PhabricatorApplicationSearchController.newQueryListView has cognitive complexity 33 (threshold 15). Drivers by points: if/else 16 (31 pts), boolean chains 1, loops 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/controller/PhabricatorApplicationSearchController.php"},"region":{"startLine":621}}}],"partialFingerprints":{"codehealthFindingId/v1":"0d54f307bfef215e8d9230bec6101cb6683c9b0b299048c47f705a4b7609e536"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorFerretFulltextEngineExtension.indexFulltextObject (cognitive 33): PhabricatorFerretFulltextEngineExtension.indexFulltextObject has cognitive complexity 33 (threshold 15). Drivers by points: if/else 12 (21 pts), loops 5 (6 pts), match/switch 2 (4 pts), error handling 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engineextension/PhabricatorFerretFulltextEngineExtension.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"c5b847bf4b2c670f3e7864b9c3906df72bab301c76ff8c9c37e42cb6dfffd348"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorDatabaseRef.queryRefs (cognitive 33): PhabricatorDatabaseRef.queryRefs has cognitive complexity 33 (threshold 15). Drivers by points: if/else 9 (24 pts), error handling 3 (6 pts), boolean chains 2, loops 1 (nesting depth added 18). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/cluster/PhabricatorDatabaseRef.php"},"region":{"startLine":342}}}],"partialFingerprints":{"codehealthFindingId/v1":"865d5baf87c0355d771b2bbc4f3f02c75d3d13e21f22d478196bc24e14b9a927"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilRemarkupListBlockRule.getMatchingLineCount (cognitive 33): PhutilRemarkupListBlockRule.getMatchingLineCount has cognitive complexity 33 (threshold 15). Drivers by points: if/else 11 (28 pts), boolean chains 4, loops 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/blockrule/PhutilRemarkupListBlockRule.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"bf8becdf93d94ba89c7f23af116794619138748f2d8646679d10698c784cfbaa"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous) (cognitive 33): (anonymous) has cognitive complexity 33 (threshold 15). Drivers by points: if/else 10 (22 pts), loops 4 (6 pts), ternaries 1 (4 pts), boolean chains 1 (nesting depth added 17). Most of this is not in the body itself: 1 of the 33 points is its own statement and the rest belongs to 13 function items inside it that branch (a function literal at line 30, add_policy, render_option, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/policy/behavior-policy-control.js"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"1f93eb2dc236fc6e429cd30859050f25f99f1d6233ffb460a5a15c6bf4ca8650"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialLocalCommitsView.render (cognitive 32): DifferentialLocalCommitsView.render has cognitive complexity 32 (threshold 15). Drivers by points: if/else 16 (27 pts), loops 3 (4 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/view/DifferentialLocalCommitsView.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"8bc93f0e58c6bc942e1de38a04386b7aa82948cc6f3ff2c9adfb8a72d5ba711c"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorFilesManagementMigrateWorkflow.execute (cognitive 32): PhabricatorFilesManagementMigrateWorkflow.execute has cognitive complexity 32 (threshold 15). Drivers by points: if/else 15 (25 pts), error handling 2 (4 pts), boolean chains 2, loops 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/management/PhabricatorFilesManagementMigrateWorkflow.php"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"d8afe70e5c472527f248a7286b35868af571b46a9bf81beedf417d63281e5c0c"}},{"ruleId":"D2","level":"warning","message":{"text":"ManiphestTaskQuery.buildWhereClauseParts (cognitive 32): ManiphestTaskQuery.buildWhereClauseParts has cognitive complexity 32 (threshold 15). Drivers by points: if/else 20 (25 pts), loops 3 (7 pts) (nesting depth added 9). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/query/ManiphestTaskQuery.php"},"region":{"startLine":354}}}],"partialFingerprints":{"codehealthFindingId/v1":"e29d6073f23d7f5e411aad6c60d8c69d5846062b32fee78add9782413f098ab4"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilDaemonOverseer.run (cognitive 32): PhutilDaemonOverseer.run has cognitive complexity 32 (threshold 15). Drivers by points: if/else 10 (28 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/PhutilDaemonOverseer.php"},"region":{"startLine":162}}}],"partialFingerprints":{"codehealthFindingId/v1":"a82f99a7f86491bcee71baf62e8dff6427fb1437487edb31f9cda059ceda1b7d"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorTaskmasterDaemon.run (cognitive 32): PhabricatorTaskmasterDaemon.run has cognitive complexity 32 (threshold 15). Drivers by points: if/else 10 (28 pts), loops 2 (4 pts) (nesting depth added 20). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemon.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"ec93bc5d22e7feafcec1dda0e60237aea34ff07a696de9f1402ee5e2301acb4f"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilRemarkupBlockRule.renderRemarkupTable (cognitive 32): PhutilRemarkupBlockRule.renderRemarkupTable has cognitive complexity 32 (threshold 15). Drivers by points: loops 7 (17 pts), if/else 5 (10 pts), ternaries 1 (5 pts) (nesting depth added 19). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/blockrule/PhutilRemarkupBlockRule.php"},"region":{"startLine":105}}}],"partialFingerprints":{"codehealthFindingId/v1":"5b823f6160aee427bd8006d6feea4b9760ce83be3f0dbe266a4f2d12ad780e1e"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMainMenuView.render (cognitive 32): PhabricatorMainMenuView.render has cognitive complexity 32 (threshold 15). Drivers by points: if/else 14 (24 pts), loops 6 (8 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/page/menu/PhabricatorMainMenuView.php"},"region":{"startLine":51}}}],"partialFingerprints":{"codehealthFindingId/v1":"6ba62d9e0dece452ab8fc806bbc619a13232c2a7f9a30369e1e10367f5a0bc4e"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorAuthProviderConfigTransaction.getTitle (cognitive 31): PhabricatorAuthProviderConfigTransaction.getTitle has cognitive complexity 31 (threshold 15). Drivers by points: if/else 18 (30 pts), match/switch 1 (nesting depth added 12). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/storage/PhabricatorAuthProviderConfigTransaction.php"},"region":{"startLine":61}}}],"partialFingerprints":{"codehealthFindingId/v1":"01174d6773fb5f5874204ed7efa360af4c9df696c5726a4c46c75531b3f169d2"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorConduitAPIController.handleRequest (cognitive 31): PhabricatorConduitAPIController.handleRequest has cognitive complexity 31 (threshold 15). Drivers by points: if/else 16 (25 pts), error handling 2 (3 pts), boolean chains 1, match/switch 1, ternaries 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conduit/controller/PhabricatorConduitAPIController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"97fe7eb1da9e5070c0df79c6c2fd4c8af39c05497e4eb5b5a0321c8ed5ea1ac2"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorBinariesSetupCheck.executeChecks (cognitive 31): PhabricatorBinariesSetupCheck.executeChecks has cognitive complexity 31 (threshold 15). Drivers by points: if/else 13 (23 pts), loops 2 (4 pts), match/switch 2 (4 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/check/PhabricatorBinariesSetupCheck.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"1cea3c72f9526f811bfd7d47b0790139879426b9cae89526a196f4afe4c14661"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorDashboardPanelsTransaction.validateTransactions (cognitive 31): PhabricatorDashboardPanelsTransaction.validateTransactions has cognitive complexity 31 (threshold 15). Drivers by points: if/else 8 (22 pts), loops 3 (6 pts), error handling 1 (3 pts) (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/xaction/dashboard/PhabricatorDashboardPanelsTransaction.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"999bf1e9c90801bac8c80e3d9b80da2f29931a6162441dcb45bc5f80133d5e03"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialCommitMessageParser.parseCorpus (cognitive 31): DifferentialCommitMessageParser.parseCorpus has cognitive complexity 31 (threshold 15). Drivers by points: if/else 11 (23 pts), loops 4 (5 pts), boolean chains 3 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialCommitMessageParser.php"},"region":{"startLine":136}}}],"partialFingerprints":{"codehealthFindingId/v1":"5a8935ccadf5250fc38217c79f7eef893c18d179470d22f6de646a9473856ed5"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialLineAdjustmentMap.mapLine (cognitive 31): DifferentialLineAdjustmentMap.mapLine has cognitive complexity 31 (threshold 15). Drivers by points: if/else 12 (25 pts), loops 1 (4 pts), boolean chains 2 (nesting depth added 16). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialLineAdjustmentMap.php"},"region":{"startLine":65}}}],"partialFingerprints":{"codehealthFindingId/v1":"5a22f26e93dc3e9bbf9f53f1cbe8cb03adb766033b94c4077af853f05aa905be"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionLintSaveRunner.run (cognitive 31): DiffusionLintSaveRunner.run has cognitive complexity 31 (threshold 15). Drivers by points: if/else 17 (26 pts), error handling 1 (2 pts), ternaries 1 (2 pts), loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/DiffusionLintSaveRunner.php"},"region":{"startLine":45}}}],"partialFingerprints":{"codehealthFindingId/v1":"7a52d437706f039d87cc466fee04a8e6685be3b903a16bcae8d51b7419f4fa6d"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionRepositoryURIViewController.buildPropertySection (cognitive 31): DiffusionRepositoryURIViewController.buildPropertySection has cognitive complexity 31 (threshold 15). Drivers by points: if/else 14 (31 pts) (nesting depth added 17). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php"},"region":{"startLine":178}}}],"partialFingerprints":{"codehealthFindingId/v1":"5b33f8d613640f25c6d89945a5810448fbd66ab4199fde9f8528f5497c3d73e6"}},{"ruleId":"D2","level":"warning","message":{"text":"HeraldEngine.isForbidden (cognitive 31): HeraldEngine.isForbidden has cognitive complexity 31 (threshold 15). Drivers by points: if/else 7 (17 pts), loops 4 (8 pts), error handling 2 (6 pts) (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/engine/HeraldEngine.php"},"region":{"startLine":790}}}],"partialFingerprints":{"codehealthFindingId/v1":"6dac25b9e9fead95da60924c098e3542971fef56d8f8bd2c11292508807805b7"}},{"ruleId":"D2","level":"warning","message":{"text":"LegalpadDocumentSignatureAddController.handleRequest (cognitive 31): LegalpadDocumentSignatureAddController.handleRequest has cognitive complexity 31 (threshold 15). Drivers by points: if/else 16 (31 pts) (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/legalpad/controller/LegalpadDocumentSignatureAddController.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"c1324ab83738c00ecd885bf0cfbe1732d7ed7134ba42355d551a2b245642b03f"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorLipsumGenerateWorkflow.execute (cognitive 31): PhabricatorLipsumGenerateWorkflow.execute has cognitive complexity 31 (threshold 15). Drivers by points: if/else 11 (23 pts), loops 4 (8 pts) (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/lipsum/management/PhabricatorLipsumGenerateWorkflow.php"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"36d8e6ee02d697a10747bafbf280f0cd0f5182dd013b973553a1f72ce90f84f3"}},{"ruleId":"D2","level":"warning","message":{"text":"ManiphestTaskStatus.validateConfiguration (cognitive 31): ManiphestTaskStatus.validateConfiguration has cognitive complexity 31 (threshold 15). Drivers by points: if/else 10 (23 pts), loops 4, boolean chains 2, match/switch 1 (2 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/constants/ManiphestTaskStatus.php"},"region":{"startLine":261}}}],"partialFingerprints":{"codehealthFindingId/v1":"edbd5847c33265552d137cf425c0b6b6ab14c3b3f175a25c17022d0ae8237010"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorPeopleSearchEngine.renderResultList (cognitive 31): PhabricatorPeopleSearchEngine.renderResultList has cognitive complexity 31 (threshold 15). Drivers by points: if/else 13 (28 pts), boolean chains 2, loops 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/query/PhabricatorPeopleSearchEngine.php"},"region":{"startLine":233}}}],"partialFingerprints":{"codehealthFindingId/v1":"98be46ef26fa8424887e0008e96cbe64ea16a06934962082e4a09d7cfd9f9a79"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorPeopleDatasource.loadResults (cognitive 31): PhabricatorPeopleDatasource.loadResults has cognitive complexity 31 (threshold 15). Drivers by points: if/else 15 (29 pts), boolean chains 1, loops 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/typeahead/PhabricatorPeopleDatasource.php"},"region":{"startLine":18}}}],"partialFingerprints":{"codehealthFindingId/v1":"1c6cb7dcafeedecfe9c8a63804b657dfd31eccccb87fe0670c19af80d9682762"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectBoardReorderController.handleRequest (cognitive 31): PhabricatorProjectBoardReorderController.handleRequest has cognitive complexity 31 (threshold 15). Drivers by points: if/else 12 (24 pts), loops 3 (5 pts), boolean chains 2 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectBoardReorderController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"1f795f3db238d337ec5e195b58dc5d5f3fb296a53989ac93b8dc758438e0b57b"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectQuery.buildWhereClauseParts (cognitive 31): PhabricatorProjectQuery.buildWhereClauseParts has cognitive complexity 31 (threshold 15). Drivers by points: if/else 23 (25 pts), loops 2 (4 pts), match/switch 1 (2 pts) (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/query/PhabricatorProjectQuery.php"},"region":{"startLine":457}}}],"partialFingerprints":{"codehealthFindingId/v1":"2983e0c808ddb520bf26d8c383cd95db48be946cb9f5dbb43298e2f9344cf1ac"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorSearchResultView.emboldenQuery (cognitive 31): PhabricatorSearchResultView.emboldenQuery has cognitive complexity 31 (threshold 15). Drivers by points: if/else 13 (22 pts), loops 6 (7 pts), match/switch 1 (2 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/view/PhabricatorSearchResultView.php"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"8885f21072deb1011a130e37b307a97298d95242e0365f873a2395dd12adfd9b"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransactionEditor.mergePHIDOrEdgeTransactions (cognitive 31): PhabricatorApplicationTransactionEditor.mergePHIDOrEdgeTransactions has cognitive complexity 31 (threshold 15). Drivers by points: if/else 9 (26 pts), loops 2 (5 pts) (nesting depth added 20). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":2481}}}],"partialFingerprints":{"codehealthFindingId/v1":"ba149b546a7c9da4b9f38cc43378a8a724beb39e0cce6163a29293592924e5a3"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorJavelinLinter.lintPath (cognitive 31): PhabricatorJavelinLinter.lintPath has cognitive complexity 31 (threshold 15). Drivers by points: if/else 11 (22 pts), loops 6 (7 pts), boolean chains 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/lint/linter/PhabricatorJavelinLinter.php"},"region":{"startLine":104}}}],"partialFingerprints":{"codehealthFindingId/v1":"e31b4cbc65521f54294e9e0d97ffec783c375372ccd40139defa7a5baccfd3f8"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorManagementWorkflow.loadUsersFromArguments (cognitive 31): PhabricatorManagementWorkflow.loadUsersFromArguments has cognitive complexity 31 (threshold 15). Drivers by points: if/else 10 (17 pts), loops 7 (13 pts), boolean chains 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/management/PhabricatorManagementWorkflow.php"},"region":{"startLine":70}}}],"partialFingerprints":{"codehealthFindingId/v1":"1a2b6b618844853e4a8a28bd2f48c5ef83e4237de3c6a220eac85ace831e847b"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilXHPASTSyntaxHighlighterFuture.findInterestingSymbols (cognitive 31): PhutilXHPASTSyntaxHighlighterFuture.findInterestingSymbols has cognitive complexity 31 (threshold 15). Drivers by points: loops 8 (15 pts), if/else 6 (14 pts), boolean chains 2 (nesting depth added 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/syntax/highlighter/xhpast/PhutilXHPASTSyntaxHighlighterFuture.php"},"region":{"startLine":164}}}],"partialFingerprints":{"codehealthFindingId/v1":"e7d865f904075a95099b61267065030a7ba56521cffbfb257ff9ba981ad0e794"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCursorPagedPolicyAwareQuery.buildEdgeLogicWhereClause (cognitive 31): PhabricatorCursorPagedPolicyAwareQuery.buildEdgeLogicWhereClause has cognitive complexity 31 (threshold 15). Drivers by points: if/else 6 (15 pts), loops 4 (12 pts), match/switch 1 (3 pts), boolean chains 1 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php"},"region":{"startLine":2814}}}],"partialFingerprints":{"codehealthFindingId/v1":"186b7714f0cc5fb18dc02247464f19dd1d6be90ba034f5176031da47b87cd856"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorSourceCodeView.render (cognitive 31): PhabricatorSourceCodeView.render has cognitive complexity 31 (threshold 15). Drivers by points: if/else 16 (28 pts), loops 2 (3 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/layout/PhabricatorSourceCodeView.php"},"region":{"startLine":72}}}],"partialFingerprints":{"codehealthFindingId/v1":"3cfd7b6f4421c589b89da92a687211f1c20c07ec2498e752c519b4d3d6797e74"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCalendarEventViewController.buildPropertySection (cognitive 30): PhabricatorCalendarEventViewController.buildPropertySection has cognitive complexity 30 (threshold 15). Drivers by points: if/else 11 (25 pts), loops 3 (5 pts) (nesting depth added 16). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/controller/PhabricatorCalendarEventViewController.php"},"region":{"startLine":275}}}],"partialFingerprints":{"codehealthFindingId/v1":"351e1021104d0df2c614a2bb09695da2aeb450bf7a53e655dddc14c11b7d64f9"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorConfigManagementSetWorkflow.execute (cognitive 30): PhabricatorConfigManagementSetWorkflow.execute has cognitive complexity 30 (threshold 15). Drivers by points: if/else 13 (18 pts), match/switch 2 (6 pts), error handling 3 (5 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/management/PhabricatorConfigManagementSetWorkflow.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"9520359fb0b5e75320f8a1bb7ce2e77d4b3567e333aa18d734fa08fe0d76374d"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorDashboardObjectInstallWorkflow.handleRequest (cognitive 30): PhabricatorDashboardObjectInstallWorkflow.handleRequest has cognitive complexity 30 (threshold 15). Drivers by points: if/else 20 (28 pts), boolean chains 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/install/PhabricatorDashboardObjectInstallWorkflow.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"fe4d06f4ae766e238b9cf1444df5c8c90cf2165277e2ee211a5637d7bed34e0f"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialQueryConduitAPIMethod.execute (cognitive 30): DifferentialQueryConduitAPIMethod.execute has cognitive complexity 30 (threshold 15). Drivers by points: if/else 20 (25 pts), loops 2 (3 pts), boolean chains 2 (nesting depth added 6). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php"},"region":{"startLine":65}}}],"partialFingerprints":{"codehealthFindingId/v1":"3d7f85530255b027f0bba688d9321cb8a3e5d52c2c491091ebea75650d806d5f"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialTransactionEditor.expandTransaction (cognitive 30): DifferentialTransactionEditor.expandTransaction has cognitive complexity 30 (threshold 15). Drivers by points: if/else 12 (24 pts), match/switch 3 (5 pts), boolean chains 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/editor/DifferentialTransactionEditor.php"},"region":{"startLine":152}}}],"partialFingerprints":{"codehealthFindingId/v1":"e802ad392726129a3d36e1b8ee47e5e125d87569d5f8355d47a951064bd1d638"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialDiffExtractionEngine.isDiffChangedBeforeCommit (cognitive 30): DifferentialDiffExtractionEngine.isDiffChangedBeforeCommit has cognitive complexity 30 (threshold 15). Drivers by points: if/else 10 (22 pts), loops 4, error handling 1 (3 pts), boolean chains 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/engine/DifferentialDiffExtractionEngine.php"},"region":{"startLine":119}}}],"partialFingerprints":{"codehealthFindingId/v1":"d2f35d32fa50e364bb69ebcb2bd1cd77a9cea62bb7ffd9ad57baa70e1425d39b"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionLocalRepositoryFilter.execute (cognitive 30): DiffusionLocalRepositoryFilter.execute has cognitive complexity 30 (threshold 15). Drivers by points: if/else 13 (26 pts), loops 3 (4 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/data/DiffusionLocalRepositoryFilter.php"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"45152a74c988da1cbf0a4d61f9a79dcd68481b0e363fd8ae1d1590214fabda8b"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorFactDatapointQuery.execute (cognitive 30): PhabricatorFactDatapointQuery.execute has cognitive complexity 30 (threshold 15). Drivers by points: if/else 11 (23 pts), loops 5 (6 pts), boolean chains 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fact/query/PhabricatorFactDatapointQuery.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"208c2470c97cbfbe01d4c8f8b95d9a6626960d2bc71f0643bd15c402f715ac58"}},{"ruleId":"D2","level":"warning","message":{"text":"ManiphestTaskSearchEngine.buildQueryFromParameters (cognitive 30): ManiphestTaskSearchEngine.buildQueryFromParameters has cognitive complexity 30 (threshold 15). Drivers by points: if/else 22 (26 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/query/ManiphestTaskSearchEngine.php"},"region":{"startLine":190}}}],"partialFingerprints":{"codehealthFindingId/v1":"b2544d24511a633b1227ec6424f4ac359ef5e1ba22629fcd8a0846394a362d19"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorPeopleQuery.fillUserCaches (cognitive 30): PhabricatorPeopleQuery.fillUserCaches has cognitive complexity 30 (threshold 15). Drivers by points: if/else 9 (18 pts), loops 7 (10 pts), boolean chains 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/query/PhabricatorPeopleQuery.php"},"region":{"startLine":514}}}],"partialFingerprints":{"codehealthFindingId/v1":"d06fea273ac59bab57e5bfce95913fe75ac64973e019c6bfc6f70e1528ccf1dd"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryPullEngine.executeGitUpdate (cognitive 30): PhabricatorRepositoryPullEngine.executeGitUpdate has cognitive complexity 30 (threshold 15). Drivers by points: if/else 17 (26 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/engine/PhabricatorRepositoryPullEngine.php"},"region":{"startLine":275}}}],"partialFingerprints":{"codehealthFindingId/v1":"c1007118e873ffe97b7db076b2e54cf5e11750b1b8ec0c09de720b76350852c3"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryPushMailWorker.renderRefs (cognitive 30): PhabricatorRepositoryPushMailWorker.renderRefs has cognitive complexity 30 (threshold 15). Drivers by points: if/else 11 (27 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 17). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/PhabricatorRepositoryPushMailWorker.php"},"region":{"startLine":135}}}],"partialFingerprints":{"codehealthFindingId/v1":"f2f07dd7f2db53948f2d269d1995f062d83790024807b98f426830e6e025fba6"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransaction.getTitleForFeed (cognitive 30): PhabricatorApplicationTransaction.getTitleForFeed has cognitive complexity 30 (threshold 15). Drivers by points: if/else 14 (25 pts), loops 1 (3 pts), boolean chains 1, match/switch 1 (nesting depth added 13). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorApplicationTransaction.php"},"region":{"startLine":1335}}}],"partialFingerprints":{"codehealthFindingId/v1":"d486bbcf06c6727ff32dd54ee4ca6c1495c890aac55d6431147ac994814337d9"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilRemarkupLiteralBlockRule.getMatchingLineCount (cognitive 30): PhutilRemarkupLiteralBlockRule.getMatchingLineCount has cognitive complexity 30 (threshold 15). Drivers by points: if/else 11 (28 pts), boolean chains 1, loops 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/blockrule/PhutilRemarkupLiteralBlockRule.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"810b94215b7ba7e3392d154261a00c065efada9a127f4c7c7a5abcbb858e58cd"}},{"ruleId":"D2","level":"warning","message":{"text":"PHUITimelineEventView.renderExtra (cognitive 30): PHUITimelineEventView.renderExtra has cognitive complexity 30 (threshold 15). Drivers by points: if/else 12 (26 pts), loops 2 (4 pts) (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUITimelineEventView.php"},"region":{"startLine":560}}}],"partialFingerprints":{"codehealthFindingId/v1":"b3f2c634f241e460818a3ef11d8c03729bae01e83f70a08f2eacac31fe1ead8f"}},{"ruleId":"D2","level":"warning","message":{"text":"getSelectableItems (cognitive 30): getSelectableItems has cognitive complexity 30 (threshold 15). Drivers by points: if/else 9 (19 pts), boolean chains 6, loops 3 (5 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangeset.js"},"region":{"startLine":435}}}],"partialFingerprints":{"codehealthFindingId/v1":"4f1e8b4f2801f0b05982077595bc9cea2ba1580c286cc49deff93b07403b3b59"}},{"ruleId":"D2","level":"warning","message":{"text":"_onmenu (cognitive 30): _onmenu has cognitive complexity 30 (threshold 15). Drivers by points: if/else 22 (27 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 6). Most of this is not in the body itself: 5 of the 30 points are its own statements and the rest belongs to 13 function items inside it that branch (a function literal at line 972, a function literal at line 1112, add_link, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":900}}}],"partialFingerprints":{"codehealthFindingId/v1":"1599e2bb51e8627d4bbb332e386bdb5771f2a45dfad78a8e2f4569d893aac457"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorAuthPasswordEngine.checkNewPassword (cognitive 29): PhabricatorAuthPasswordEngine.checkNewPassword has cognitive complexity 29 (threshold 15). Drivers by points: if/else 14 (21 pts), loops 5 (7 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/engine/PhabricatorAuthPasswordEngine.php"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"665da476e4736729ccfac5916dd46ed4b676c80a8cc4ab469c51609d6700052f"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorPasswordAuthProvider.processLoginRequest (cognitive 29): PhabricatorPasswordAuthProvider.processLoginRequest has cognitive complexity 29 (threshold 15). Drivers by points: if/else 9 (23 pts), ternaries 1 (3 pts), error handling 1 (2 pts), boolean chains 1 (nesting depth added 17). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorPasswordAuthProvider.php"},"region":{"startLine":251}}}],"partialFingerprints":{"codehealthFindingId/v1":"f2089a38de9e1aff74991e67e319598e5472fe5f42c010312f9305315df63a73"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilCalendarRecurrenceRule.advanceCursorState (cognitive 29): PhutilCalendarRecurrenceRule.advanceCursorState has cognitive complexity 29 (threshold 15). Drivers by points: if/else 6 (13 pts), loops 4 (10 pts), match/switch 3 (6 pts) (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php"},"region":{"startLine":1685}}}],"partialFingerprints":{"codehealthFindingId/v1":"f0b1681e0626100b510348e76b63582c2bc8d1833a1490ad6a1ece89d7e067fe"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorConduitMethodQuery.filterMethods (cognitive 29): PhabricatorConduitMethodQuery.filterMethods has cognitive complexity 29 (threshold 15). Drivers by points: if/else 10 (20 pts), loops 5 (9 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conduit/query/PhabricatorConduitMethodQuery.php"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"4ae7656458f6875e597a45f9410a0627339a1972a424da757d1a5da72459910c"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorDashboardPanelTabsController.handleMoveOperation (cognitive 29): PhabricatorDashboardPanelTabsController.handleMoveOperation has cognitive complexity 29 (threshold 15). Drivers by points: if/else 12 (24 pts), boolean chains 3, loops 1 (2 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/panel/PhabricatorDashboardPanelTabsController.php"},"region":{"startLine":301}}}],"partialFingerprints":{"codehealthFindingId/v1":"41322cdfa16e98422979aebdf2e1b72a81081074e51e6b977a7321d74655251d"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionGitUploadPackWireProtocol.newProtocolRefMessage (cognitive 29): DiffusionGitUploadPackWireProtocol.newProtocolRefMessage has cognitive complexity 29 (threshold 15). Drivers by points: if/else 15 (26 pts), loops 3 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/protocol/DiffusionGitUploadPackWireProtocol.php"},"region":{"startLine":165}}}],"partialFingerprints":{"codehealthFindingId/v1":"8b7e9d042b7641875334ba4f5d07cb586a10d57d62479106d5204e3965371740"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionLowLevelGitRefQuery.executeQuery (cognitive 29): DiffusionLowLevelGitRefQuery.executeQuery has cognitive complexity 29 (threshold 15). Drivers by points: if/else 16 (27 pts), boolean chains 1, loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/lowlevel/DiffusionLowLevelGitRefQuery.php"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"384e07ef663127c687b58e0aa5169acb81ec11b6dc3802b72128d6365b95df78"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionSourceLinkRemarkupRule.didMarkupText (cognitive 29): DiffusionSourceLinkRemarkupRule.didMarkupText has cognitive complexity 29 (threshold 15). Drivers by points: if/else 14 (25 pts), loops 3 (4 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/remarkup/DiffusionSourceLinkRemarkupRule.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"8e3fa5d32efdf0072584171aaa72f7dff486b20b055f2568da2f37d744baabd2"}},{"ruleId":"D2","level":"warning","message":{"text":"HeraldAction.loadStandardTargets (cognitive 29): HeraldAction.loadStandardTargets has cognitive complexity 29 (threshold 15). Drivers by points: if/else 15 (23 pts), loops 4 (5 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/action/HeraldAction.php"},"region":{"startLine":206}}}],"partialFingerprints":{"codehealthFindingId/v1":"e6e498f7047112567db68705dc972442b8195683b0a80d0ffad5f9199a33208a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationEditController.handleRequest (cognitive 29): PhabricatorApplicationEditController.handleRequest has cognitive complexity 29 (threshold 15). Drivers by points: if/else 9 (23 pts), loops 2 (3 pts), error handling 1 (2 pts), boolean chains 1 (nesting depth added 16). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/meta/controller/PhabricatorApplicationEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"3e9bdd45aad7b088b1ccbd258c8a47d5101186666c7404eb14d80635325a1e53"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMailReplyHandler.expandRecipientPHIDs (cognitive 29): PhabricatorMailReplyHandler.expandRecipientPHIDs has cognitive complexity 29 (threshold 15). Drivers by points: if/else 5 (19 pts), loops 4 (10 pts) (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php"},"region":{"startLine":281}}}],"partialFingerprints":{"codehealthFindingId/v1":"d4ed2a446ff8efa1e680b013727a902b6a0b3e78206eb4af8075cf9c804692ab"}},{"ruleId":"D2","level":"warning","message":{"text":"PhrictionRemarkupRule.markupDocumentLink (cognitive 29): PhrictionRemarkupRule.markupDocumentLink has cognitive complexity 29 (threshold 15). Drivers by points: if/else 12 (25 pts), loops 1 (3 pts), boolean chains 1 (nesting depth added 15). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/markup/PhrictionRemarkupRule.php"},"region":{"startLine":18}}}],"partialFingerprints":{"codehealthFindingId/v1":"daacec146710feb6bbe01ed4dea5a8ed3fcb75ce323f25f2ac7dc9509760bdb5"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilDaemonHandle.update (cognitive 29): PhutilDaemonHandle.update has cognitive complexity 29 (threshold 15). Drivers by points: if/else 14 (21 pts), error handling 2 (4 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/PhutilDaemonHandle.php"},"region":{"startLine":136}}}],"partialFingerprints":{"codehealthFindingId/v1":"6e9921ee0de799c4709ec73b15ac65d0c5f6951f1497bf248aa7d5937b8cfbf5"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorObjectGraph.newGraphTable (cognitive 29): PhabricatorObjectGraph.newGraphTable has cognitive complexity 29 (threshold 15). Drivers by points: if/else 11 (21 pts), loops 4 (8 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/graph/PhabricatorObjectGraph.php"},"region":{"startLine":163}}}],"partialFingerprints":{"codehealthFindingId/v1":"5d23e3e15908d4f4d1efcdff848f952439395edb5a0d51b959ce62cad16f65f9"}},{"ruleId":"D2","level":"warning","message":{"text":"markup.javelin_tag (cognitive 29): markup.javelin_tag has cognitive complexity 29 (threshold 15). Drivers by points: if/else 11 (22 pts), match/switch 1 (3 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/javelin/markup.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"3a587303097b863e466e0d6032e1ed654488b9c295afe4188ea8e9849933e11f"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilRemarkupEngine.splitTextIntoBlocks (cognitive 29): PhutilRemarkupEngine.splitTextIntoBlocks has cognitive complexity 29 (threshold 15). Drivers by points: if/else 8 (19 pts), loops 6 (9 pts), boolean chains 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/remarkup/PhutilRemarkupEngine.php"},"region":{"startLine":156}}}],"partialFingerprints":{"codehealthFindingId/v1":"519c6a55be3ace2b206af0dad46473f1e8308dd0adf5dc84ace53545c66dd03b"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCursorPagedPolicyAwareQuery.validateEdgeLogicConstraints (cognitive 29): PhabricatorCursorPagedPolicyAwareQuery.validateEdgeLogicConstraints has cognitive complexity 29 (threshold 15). Drivers by points: if/else 5 (13 pts), loops 5 (8 pts), match/switch 2 (6 pts), boolean chains 2 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php"},"region":{"startLine":3000}}}],"partialFingerprints":{"codehealthFindingId/v1":"3291d2ae1925691121e408baf9d5b9e8a2ae004cefc83c466ba9e663f8b095b1"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorSQLPatchList.getPHPPatchAttributes (cognitive 29): PhabricatorSQLPatchList.getPHPPatchAttributes has cognitive complexity 29 (threshold 15). Drivers by points: if/else 7 (24 pts), match/switch 1 (4 pts), loops 1 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/patch/PhabricatorSQLPatchList.php"},"region":{"startLine":260}}}],"partialFingerprints":{"codehealthFindingId/v1":"6a80decfe9c50032f22e442d11a7254daa84964be7b96dcd213d2db7cf441c06"}},{"ruleId":"D2","level":"warning","message":{"text":"PHUIObjectBoxView.getTagContent (cognitive 29): PHUIObjectBoxView.getTagContent has cognitive complexity 29 (threshold 15). Drivers by points: if/else 13 (18 pts), ternaries 4 (6 pts), loops 2 (4 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIObjectBoxView.php"},"region":{"startLine":181}}}],"partialFingerprints":{"codehealthFindingId/v1":"97393ac413e02f4583fb1691ad8349348f2c06e1041b7f20605b9438c89c5dd9"}},{"ruleId":"D2","level":"warning","message":{"text":"PHUIPagerView.render (cognitive 29): PHUIPagerView.render has cognitive complexity 29 (threshold 15). Drivers by points: if/else 15 (22 pts), loops 3 (4 pts), ternaries 1 (2 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIPagerView.php"},"region":{"startLine":119}}}],"partialFingerprints":{"codehealthFindingId/v1":"6a827087a5523a9c2fc9be0ef2edb09e977517ef306f824964d1ad42575acded"}},{"ruleId":"D2","level":"warning","message":{"text":"PHUITimelineView.buildEvents (cognitive 29): PHUITimelineView.buildEvents has cognitive complexity 29 (threshold 15). Drivers by points: if/else 17 (25 pts), match/switch 1 (2 pts), boolean chains 1, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUITimelineView.php"},"region":{"startLine":101}}}],"partialFingerprints":{"codehealthFindingId/v1":"f0abc3d4c8660c1ad77c45f928c67adae8b62ed426fb8b2f1e742dcee8c11a5c"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-populate.JX.behavior(\u0022differential-populate\u0022) (cognitive 29): behavior-populate.JX.behavior(\u0022differential-populate\u0022) has cognitive complexity 29 (threshold 15). Drivers by points: if/else 17 (24 pts), loops 3 (4 pts), boolean chains 1 (nesting depth added 8). Most of this is not in the body itself: 5 of the 29 points are its own statements and the rest belongs to 3 function items inside it that branch (a function literal at line 95, onredraw, get_lists). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/differential/behavior-populate.js"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"e2e1eea3ed9c4ca39fb0083f47c397ce3ab956c1dc625b54d3cfac2e3165e2df"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-lightbox-attachments.JX.behavior(\u0022lightbox-attachments\u0022) (cognitive 29): behavior-lightbox-attachments.JX.behavior(\u0022lightbox-attachments\u0022) has cognitive complexity 29 (threshold 15). Drivers by points: if/else 19 (22 pts), boolean chains 3, loops 2, match/switch 1, ternaries 1 (nesting depth added 3). None of this is in the body itself: all 29 points belong to 6 function items inside it that branch (activateLightbox, lightBoxHandleKeyDown, loadLightBox, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-lightbox-attachments.js"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"1b3db235ca4f1dd71e9cf558773640c6fb2ee71e616349f57e1d7d1aac0d6aae"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous) (cognitive 29): (anonymous) has cognitive complexity 29 (threshold 15). Drivers by points: if/else 19 (22 pts), boolean chains 3, loops 2, match/switch 1, ternaries 1 (nesting depth added 3). None of this is in the body itself: all 29 points belong to 13 function items inside it that branch (activateLightbox, lightBoxHandleKeyDown, loadLightBox, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-lightbox-attachments.js"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"bf93cbcfa5f14e48de190a010cce2093d67b50b94fa932f2aaa56aec15a5c78a"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous) (cognitive 29): (anonymous) has cognitive complexity 29 (threshold 15). Drivers by points: if/else 17 (24 pts), loops 3 (4 pts), boolean chains 1 (nesting depth added 8). Most of this is not in the body itself: 5 of the 29 points are its own statements and the rest belongs to 4 function items inside it that branch (a function literal at line 95, onredraw, get_lists, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/differential/behavior-populate.js"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"99c48da550dc4e1d2739087f29a9341e5e2871a1ed391530b2c7812c578f2644"}},{"ruleId":"D2","level":"warning","message":{"text":"AphrontHTTPHeaderParser.getHeaderContentAsPairs (cognitive 28): AphrontHTTPHeaderParser.getHeaderContentAsPairs has cognitive complexity 28 (threshold 15). Drivers by points: if/else 9 (23 pts), boolean chains 2, match/switch 1 (2 pts), loops 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/headerparser/AphrontHTTPHeaderParser.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"b729e6e4d03b3d3455ea3e246f836d258aca667012fe1302d360ae74f3aeadd3"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorPHPPreflightSetupCheck.executeChecks (cognitive 28): PhabricatorPHPPreflightSetupCheck.executeChecks has cognitive complexity 28 (threshold 15). Drivers by points: if/else 9 (21 pts), loops 2 (5 pts), boolean chains 2 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"7f8de6ad15d4f81438831a9513c5d062136022d59aacd94ec479269611e92e04"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialDiffCreateController.handleRequest (cognitive 28): DifferentialDiffCreateController.handleRequest has cognitive complexity 28 (threshold 15). Drivers by points: if/else 18 (25 pts), error handling 1 (3 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/controller/DifferentialDiffCreateController.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"99917e468ce7bfbff7b0d35b2d2a36b58eff741ee6668a7168bfca1f1c2cf8fc"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialTransactionEditor.didApplyTransactions (cognitive 28): DifferentialTransactionEditor.didApplyTransactions has cognitive complexity 28 (threshold 15). Drivers by points: if/else 13 (22 pts), boolean chains 6 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/editor/DifferentialTransactionEditor.php"},"region":{"startLine":1529}}}],"partialFingerprints":{"codehealthFindingId/v1":"05c30f443f8b245717e32eb19e99d7f025b0643eb58cffb71d17a340a5989ba1"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialRevisionQuery.buildWhereClause (cognitive 28): DifferentialRevisionQuery.buildWhereClause has cognitive complexity 28 (threshold 15). Drivers by points: if/else 21 (26 pts), loops 1 (2 pts) (nesting depth added 6). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/query/DifferentialRevisionQuery.php"},"region":{"startLine":630}}}],"partialFingerprints":{"codehealthFindingId/v1":"82ad433604382a1953f56af8a23d04cc219218493b17e05dfe341d67053b5d7a"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialChangesetOneUpMailRenderer.renderPrimitives (cognitive 28): DifferentialChangesetOneUpMailRenderer.renderPrimitives has cognitive complexity 28 (threshold 15). Drivers by points: if/else 11 (21 pts), loops 4, match/switch 1 (2 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetOneUpMailRenderer.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"2912c58a4fe15e193aa1678c81bed2db1260047d006b42a0eb205630b58f0549"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialRevisionReviewTransaction.isViewerReviewerStatusFully (cognitive 28): DifferentialRevisionReviewTransaction.isViewerReviewerStatusFully has cognitive complexity 28 (threshold 15). Drivers by points: if/else 11 (27 pts), loops 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/xaction/DifferentialRevisionReviewTransaction.php"},"region":{"startLine":97}}}],"partialFingerprints":{"codehealthFindingId/v1":"bb1f147736737b6cb89fdc986fc40e53bb0e62c2fc5b0afe947733a04647dc2b"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionBlameController.handleRequest (cognitive 28): DiffusionBlameController.handleRequest has cognitive complexity 28 (threshold 15). Drivers by points: if/else 13 (21 pts), loops 4 (5 pts), ternaries 1 (2 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionBlameController.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"1853fd6fd738752819114476398c7e66b88429ccdd6eb30b30188877ff2175fe"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionCompareController.handleRequest (cognitive 28): DiffusionCompareController.handleRequest has cognitive complexity 28 (threshold 15). Drivers by points: if/else 15 (25 pts), boolean chains 2, error handling 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionCompareController.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"c9f7a03467a7dd243b6624c1ecfa7aea49d24c6e5502e38f96d9a9b298a0710c"}},{"ruleId":"D2","level":"warning","message":{"text":"HeraldRuleController.setupEditorBehavior (cognitive 28): HeraldRuleController.setupEditorBehavior has cognitive complexity 28 (threshold 15). Drivers by points: if/else 8 (13 pts), loops 8 (11 pts), error handling 2 (4 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/controller/HeraldRuleController.php"},"region":{"startLine":400}}}],"partialFingerprints":{"codehealthFindingId/v1":"af0cf5f7c4d8c656fe18153f502d07fbf8ac52608700c480a48aab6386f79c62"}},{"ruleId":"D2","level":"warning","message":{"text":"ManiphestTransactionEditor.getLockValidationErrors (cognitive 28): ManiphestTransactionEditor.getLockValidationErrors has cognitive complexity 28 (threshold 15). Drivers by points: if/else 11 (23 pts), boolean chains 2, match/switch 1 (2 pts), loops 1 (nesting depth added 13). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/editor/ManiphestTransactionEditor.php"},"region":{"startLine":774}}}],"partialFingerprints":{"codehealthFindingId/v1":"7f688a7e16407839cac0a4fb1a1dd727533c8d343849396c8e6db6bfeaaeb20c"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryManagementRebuildIdentitiesWorkflow.execute (cognitive 28): PhabricatorRepositoryManagementRebuildIdentitiesWorkflow.execute has cognitive complexity 28 (threshold 15). Drivers by points: if/else 14 (19 pts), loops 2 (5 pts), boolean chains 4 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/management/PhabricatorRepositoryManagementRebuildIdentitiesWorkflow.php"},"region":{"startLine":63}}}],"partialFingerprints":{"codehealthFindingId/v1":"9330532e3d7a19ad1c07fad562c37b43f0eea52fd990c3c01bdd8e1e8027be81"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryManagementUnpublishWorkflow.unpublishEdgeTransaction (cognitive 28): PhabricatorRepositoryManagementUnpublishWorkflow.unpublishEdgeTransaction has cognitive complexity 28 (threshold 15). Drivers by points: if/else 10 (21 pts), loops 3 (7 pts) (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/management/PhabricatorRepositoryManagementUnpublishWorkflow.php"},"region":{"startLine":154}}}],"partialFingerprints":{"codehealthFindingId/v1":"4f6f51c2f928ca07cebdb7a32f901d284406c8cdefd935473fb7b7eff76c7655"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryGitCommitChangeParserWorker.parseCommitChanges (cognitive 28): PhabricatorRepositoryGitCommitChangeParserWorker.parseCommitChanges has cognitive complexity 28 (threshold 15). Drivers by points: if/else 9 (16 pts), loops 6, match/switch 2 (4 pts), ternaries 1 (2 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryGitCommitChangeParserWorker.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"657ae205b98ae38a7cc61bdb2b465d636b8881839b5bca155aa2e37eb3197e3e"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransactionView.buildEvents (cognitive 28): PhabricatorApplicationTransactionView.buildEvents has cognitive complexity 28 (threshold 15). Drivers by points: if/else 7 (18 pts), loops 4 (8 pts), boolean chains 2 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/view/PhabricatorApplicationTransactionView.php"},"region":{"startLine":129}}}],"partialFingerprints":{"codehealthFindingId/v1":"120fed2b810b413bf8e604747ec4bf9b161a93e4f26488197693e732b01b53a3"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilRemarkupTableBlockRule.newTable (cognitive 28): PhutilRemarkupTableBlockRule.newTable has cognitive complexity 28 (threshold 15). Drivers by points: if/else 7 (20 pts), loops 4 (7 pts), boolean chains 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/blockrule/PhutilRemarkupTableBlockRule.php"},"region":{"startLine":63}}}],"partialFingerprints":{"codehealthFindingId/v1":"c3e2c7bfbcb01d41968209cb8ce3b88803319451a7d40b41997e3f20eee34595"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCursorPagedPolicyAwareQuery.buildApplicationSearchJoinClause (cognitive 28): PhabricatorCursorPagedPolicyAwareQuery.buildApplicationSearchJoinClause has cognitive complexity 28 (threshold 15). Drivers by points: if/else 9 (20 pts), loops 3 (5 pts), match/switch 1 (2 pts), boolean chains 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php"},"region":{"startLine":1535}}}],"partialFingerprints":{"codehealthFindingId/v1":"f9337a9fffdb6b557b1655621261e4e7cb047a799d3d0cd3f14e602d887c271d"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRemarkupControl.renderInput (cognitive 28): PhabricatorRemarkupControl.renderInput has cognitive complexity 28 (threshold 15). Drivers by points: if/else 19 (26 pts), loops 1, ternaries 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/form/control/PhabricatorRemarkupControl.php"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"614475b8ed3c1ff8ec293e78613e5e7b55fa0801eafb3814a30b92d2c4dba563"}},{"ruleId":"D2","level":"warning","message":{"text":"_newHoverMap (cognitive 28): _newHoverMap has cognitive complexity 28 (threshold 15). Drivers by points: if/else 10 (20 pts), boolean chains 5, loops 3 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":1539}}}],"partialFingerprints":{"codehealthFindingId/v1":"ef7f61c8a59769e00a4cae01c2e699d4119413542130557ad6c2358389b93f9c"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionRepositoryController.handleRequest (cognitive 27): DiffusionRepositoryController.handleRequest has cognitive complexity 27 (threshold 15). Drivers by points: if/else 17 (25 pts), loops 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRepositoryController.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"80a9fa3e832150893013104215db5fc30bd9ec67c5ecd07e1331662dc21eb537"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionSymbolController.handleRequest (cognitive 27): DiffusionSymbolController.handleRequest has cognitive complexity 27 (threshold 15). Drivers by points: if/else 17 (22 pts), error handling 1 (2 pts), loops 2, boolean chains 1 (nesting depth added 6). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionSymbolController.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"eb4272ad479475b41f9d7415b44e4a826a8aa08dbe072dce57fa70949d5aa175"}},{"ruleId":"D2","level":"warning","message":{"text":"DivinerSymbolRemarkupRule.didMarkupText (cognitive 27): DivinerSymbolRemarkupRule.didMarkupText has cognitive complexity 27 (threshold 15). Drivers by points: if/else 11 (23 pts), match/switch 1 (3 pts), loops 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/markup/DivinerSymbolRemarkupRule.php"},"region":{"startLine":87}}}],"partialFingerprints":{"codehealthFindingId/v1":"6b98ad9c2a5e8436af2c26b83f8a15ce8b2934cd1053dd9c59d13a36345c544f"}},{"ruleId":"D2","level":"warning","message":{"text":"DoorkeeperImportEngine.execute (cognitive 27): DoorkeeperImportEngine.execute has cognitive complexity 27 (threshold 15). Drivers by points: if/else 7 (16 pts), loops 5 (11 pts) (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/engine/DoorkeeperImportEngine.php"},"region":{"startLine":65}}}],"partialFingerprints":{"codehealthFindingId/v1":"8df8aecadde96402f992cece8b2b7503867474f7936d588b65aa06cc23cf8f04"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorJupyterDocumentEngine.newCells (cognitive 27): PhabricatorJupyterDocumentEngine.newCells has cognitive complexity 27 (threshold 15). Drivers by points: if/else 11 (16 pts), loops 4 (9 pts), boolean chains 1, error handling 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/document/PhabricatorJupyterDocumentEngine.php"},"region":{"startLine":307}}}],"partialFingerprints":{"codehealthFindingId/v1":"3ad4dc64b4c6394a3c8cc4453e1d4c701d3f52afe69ea57c214089172a5f36ce"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorFile.readPropertiesFromParameters (cognitive 27): PhabricatorFile.readPropertiesFromParameters has cognitive complexity 27 (threshold 15). Drivers by points: if/else 14 (25 pts), boolean chains 1, ternaries 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/storage/PhabricatorFile.php"},"region":{"startLine":1453}}}],"partialFingerprints":{"codehealthFindingId/v1":"f7c5b837246bc3aed82601bcd347cf78f989b9d7767850eeddd450b5e775fd5d"}},{"ruleId":"D2","level":"warning","message":{"text":"HarbormasterPlanViewController.buildArtifactList (cognitive 27): HarbormasterPlanViewController.buildArtifactList has cognitive complexity 27 (threshold 15). Drivers by points: if/else 13 (26 pts), loops 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterPlanViewController.php"},"region":{"startLine":284}}}],"partialFingerprints":{"codehealthFindingId/v1":"b8e51328ed964375002269d6a3564300a692598b9a098c203579360fea902a6b"}},{"ruleId":"D2","level":"warning","message":{"text":"HeraldEngine.applyEffects (cognitive 27): HeraldEngine.applyEffects has cognitive complexity 27 (threshold 15). Drivers by points: if/else 10 (16 pts), loops 6 (9 pts), boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/engine/HeraldEngine.php"},"region":{"startLine":258}}}],"partialFingerprints":{"codehealthFindingId/v1":"245647b65342a57e92abd6e75041afcaff7aa091cc6e2e93a334e9982cd3b6fc"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorNotificationServersConfigType.validateStoredValue (cognitive 27): PhabricatorNotificationServersConfigType.validateStoredValue has cognitive complexity 27 (threshold 15). Drivers by points: if/else 8 (17 pts), match/switch 2 (4 pts), boolean chains 2, error handling 1 (2 pts), loops 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/notification/config/PhabricatorNotificationServersConfigType.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"a7060887b7302ad094f507c10fdbdf692aa54289668e97d50efa23dcfe1fe442"}},{"ruleId":"D2","level":"warning","message":{"text":"PholioInlineController.handleRequest (cognitive 27): PholioInlineController.handleRequest has cognitive complexity 27 (threshold 15). Drivers by points: if/else 15 (24 pts), loops 1 (2 pts), match/switch 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/pholio/controller/PholioInlineController.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"d0284639c0d1fa68628d725c59f46e847829dde0a0bbab3e6427595f612e041e"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectEditController.handleRequest (cognitive 27): PhabricatorProjectEditController.handleRequest has cognitive complexity 27 (threshold 15). Drivers by points: if/else 12 (27 pts) (nesting depth added 15). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectEditController.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"55cfcb0d13b16f7cd10714bdf7335e138188ac08a76a306a00315d8920da62ae"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectQuery.loadSlugs (cognitive 27): PhabricatorProjectQuery.loadSlugs has cognitive complexity 27 (threshold 15). Drivers by points: if/else 14 (22 pts), loops 4 (5 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/query/PhabricatorProjectQuery.php"},"region":{"startLine":799}}}],"partialFingerprints":{"codehealthFindingId/v1":"6a235c88f1357baabd43b8c1c93c448b09d6af3449a975fd6c983f8305b2b9ee"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectUserListView.render (cognitive 27): PhabricatorProjectUserListView.render has cognitive complexity 27 (threshold 15). Drivers by points: if/else 13 (19 pts), ternaries 2 (4 pts), boolean chains 2, loops 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/view/PhabricatorProjectUserListView.php"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"601ac8c950d6971e2b821e5c6dc79be418fded9bc85985468ba97a4b7d289405"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationSearchController.processExportRequest (cognitive 27): PhabricatorApplicationSearchController.processExportRequest has cognitive complexity 27 (threshold 15). Drivers by points: if/else 19 (26 pts), loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/controller/PhabricatorApplicationSearchController.php"},"region":{"startLine":399}}}],"partialFingerprints":{"codehealthFindingId/v1":"bb14be59869b8069b9880dc78d96d976783582d4ee39cc49d5c12f8b76106f7d"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransactionEditor.combineTransactions (cognitive 27): PhabricatorApplicationTransactionEditor.combineTransactions has cognitive complexity 27 (threshold 15). Drivers by points: if/else 5 (20 pts), loops 3 (5 pts), boolean chains 2 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":2430}}}],"partialFingerprints":{"codehealthFindingId/v1":"ed8c379b418070552b267b26e9906d319d0648422470f8e9f88050248c69a83f"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransactionEditor.filterTransactions (cognitive 27): PhabricatorApplicationTransactionEditor.filterTransactions has cognitive complexity 27 (threshold 15). Drivers by points: if/else 14 (22 pts), boolean chains 3, loops 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":2772}}}],"partialFingerprints":{"codehealthFindingId/v1":"a979b702d12ac4c8b301f8350d1aaa6e599b8049fac75207f5d2475a26130ed1"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorTypeaheadCompositeDatasource.loadResultsForPhase (cognitive 27): PhabricatorTypeaheadCompositeDatasource.loadResultsForPhase has cognitive complexity 27 (threshold 15). Drivers by points: if/else 10 (23 pts), loops 2 (4 pts) (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/typeahead/datasource/PhabricatorTypeaheadCompositeDatasource.php"},"region":{"startLine":67}}}],"partialFingerprints":{"codehealthFindingId/v1":"35b80cfb804a0fff748bcb7fa2745e916dac6a89697e4f823fdb2965fa6e3d07"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorTypeaheadDatasource.renderTokens (cognitive 27): PhabricatorTypeaheadDatasource.renderTokens has cognitive complexity 27 (threshold 15). Drivers by points: if/else 9 (16 pts), loops 6 (11 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php"},"region":{"startLine":274}}}],"partialFingerprints":{"codehealthFindingId/v1":"dca3453de6a14ced3ad6395c19e575aab82fc5bad18ed8bfea4885724bc7b342"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorEdgeQuery.execute (cognitive 27): PhabricatorEdgeQuery.execute has cognitive complexity 27 (threshold 15). Drivers by points: loops 6 (15 pts), if/else 6 (12 pts) (nesting depth added 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/edges/query/PhabricatorEdgeQuery.php"},"region":{"startLine":167}}}],"partialFingerprints":{"codehealthFindingId/v1":"d7d2d4b947f00f094d200076c1d31449f897e4f09d7b6d7825ad02fe00ba763c"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilPygmentizeParser.parse (cognitive 27): PhutilPygmentizeParser.parse has cognitive complexity 27 (threshold 15). Drivers by points: if/else 8 (24 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/parser/PhutilPygmentizeParser.php"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"52a9c5079065437781f613262bded1401bb68e77be99f1f416dff6d85615bf94"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorSSHPassthruCommand.execute (cognitive 27): PhabricatorSSHPassthruCommand.execute has cognitive complexity 27 (threshold 15). Drivers by points: if/else 10 (19 pts), boolean chains 5, loops 2 (3 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/ssh/PhabricatorSSHPassthruCommand.php"},"region":{"startLine":87}}}],"partialFingerprints":{"codehealthFindingId/v1":"0f4745a9029c9ec9c6a31961702e19f2a2919ec92907b792d3d0f44b197041da"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-line-linker.JX.behavior(\u0022phabricator-line-linker\u0022) (cognitive 27): behavior-line-linker.JX.behavior(\u0022phabricator-line-linker\u0022) has cognitive complexity 27 (threshold 15). Drivers by points: if/else 17 (19 pts), loops 3 (4 pts), error handling 2 (3 pts), ternaries 1 (nesting depth added 4). Most of this is not in the body itself: 5 of the 27 points are its own statements and the rest belongs to 4 function items inside it that branch (highlight, a function literal at line 39, a function literal at line 138, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-line-linker.js"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"78efd2b646b487853197081e4d316e0a5b1a6bd87b14d10b1387054741598732"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous) (cognitive 27): (anonymous) has cognitive complexity 27 (threshold 15). Drivers by points: if/else 17 (19 pts), loops 3 (4 pts), error handling 2 (3 pts), ternaries 1 (nesting depth added 4). Most of this is not in the body itself: 5 of the 27 points are its own statements and the rest belongs to 5 function items inside it that branch (highlight, a function literal at line 39, a function literal at line 138, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-line-linker.js"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"4bfd0795c307a1149581f91c87b752bcd8c4dc15f4736728777d9764dc628eb3"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCalendarEventSearchEngine.getQueryDateRange (cognitive 26): PhabricatorCalendarEventSearchEngine.getQueryDateRange has cognitive complexity 26 (threshold 15). Drivers by points: if/else 11 (21 pts), boolean chains 5 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php"},"region":{"startLine":149}}}],"partialFingerprints":{"codehealthFindingId/v1":"cf7dbd9a939f0a3988a148b7f2a6a6fb80e62da0ec20ef216996814b451134c9"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorDashboardPanelTabsController.handleRequest (cognitive 26): PhabricatorDashboardPanelTabsController.handleRequest has cognitive complexity 26 (threshold 15). Drivers by points: if/else 12 (19 pts), loops 2 (4 pts), match/switch 2 (3 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/panel/PhabricatorDashboardPanelTabsController.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"ea7cc5e1914e3debb3c40fce86ab8405acbacff551f9a5516dd534efd62443c9"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialChangesetHTMLRenderer.renderShowContextLinks (cognitive 26): DifferentialChangesetHTMLRenderer.renderShowContextLinks has cognitive complexity 26 (threshold 15). Drivers by points: if/else 16 (26 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetHTMLRenderer.php"},"region":{"startLine":499}}}],"partialFingerprints":{"codehealthFindingId/v1":"b45dab9f599e52ff443b4ec060b1170e450aa256b4459209da9a3f47925d2368"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionLintController.handleRequest (cognitive 26): DiffusionLintController.handleRequest has cognitive complexity 26 (threshold 15). Drivers by points: if/else 20 (25 pts), loops 1 (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionLintController.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"b2f99b120b158b3ef452ac50d78f4c9a07c2677e92755807275dc3f328c7af5d"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionSetPasswordSettingsPanel.processRequest (cognitive 26): DiffusionSetPasswordSettingsPanel.processRequest has cognitive complexity 26 (threshold 15). Drivers by points: if/else 16 (22 pts), error handling 2 (4 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/panel/DiffusionSetPasswordSettingsPanel.php"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"8df9b7c2892cd3f5dfb615ba42779c478c2bd5ae3a7f4e456f4400ac4a3b8a79"}},{"ruleId":"D2","level":"warning","message":{"text":"DrydockLandRepositoryOperation.getBarrierToLanding (cognitive 26): DrydockLandRepositoryOperation.getBarrierToLanding has cognitive complexity 26 (threshold 15). Drivers by points: if/else 16 (24 pts), loops 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/operation/DrydockLandRepositoryOperation.php"},"region":{"startLine":225}}}],"partialFingerprints":{"codehealthFindingId/v1":"3a5a43a3958cf41d2d41569aa0eb7b4c4986e13cd1cb2b25f89bdab5a876888a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorFileQuery.buildWhereClauseParts (cognitive 26): PhabricatorFileQuery.buildWhereClauseParts has cognitive complexity 26 (threshold 15). Drivers by points: if/else 21 (24 pts), loops 1 (2 pts) (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/query/PhabricatorFileQuery.php"},"region":{"startLine":396}}}],"partialFingerprints":{"codehealthFindingId/v1":"a699d1bc135933294881f992eaa9b577d2d3629ee3e98f37252c8599e078f67a"}},{"ruleId":"D2","level":"warning","message":{"text":"HarbormasterUIEventListener.handlePropertyEvent (cognitive 26): HarbormasterUIEventListener.handlePropertyEvent has cognitive complexity 26 (threshold 15). Drivers by points: if/else 11 (15 pts), loops 5 (9 pts), boolean chains 1, error handling 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/event/HarbormasterUIEventListener.php"},"region":{"startLine":18}}}],"partialFingerprints":{"codehealthFindingId/v1":"5aa19df8488410f308c128b1dfa421f1d29ccdc4ddbe4d391bf4f1f0bb1df09c"}},{"ruleId":"D2","level":"warning","message":{"text":"HeraldRuleController.handleRequest (cognitive 26): HeraldRuleController.handleRequest has cognitive complexity 26 (threshold 15). Drivers by points: if/else 13 (22 pts), error handling 1 (2 pts), boolean chains 1, ternaries 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/controller/HeraldRuleController.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"50b8f8f03b4db254304f92469b7f62d56e618cb9402bc559fc2b9f3cac12b39a"}},{"ruleId":"D2","level":"warning","message":{"text":"HeraldRuleController.saveRule (cognitive 26): HeraldRuleController.saveRule has cognitive complexity 26 (threshold 15). Drivers by points: if/else 10 (15 pts), error handling 4 (7 pts), boolean chains 2, loops 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/controller/HeraldRuleController.php"},"region":{"startLine":263}}}],"partialFingerprints":{"codehealthFindingId/v1":"d9714e15c672f84bebaca4a2e06295ee10c20d3da50d813326eff10e2ea475a0"}},{"ruleId":"D2","level":"warning","message":{"text":"ManiphestTaskStatusTransaction.getTitle (cognitive 26): ManiphestTaskStatusTransaction.getTitle has cognitive complexity 26 (threshold 15). Drivers by points: if/else 14 (24 pts), boolean chains 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ManiphestTaskStatusTransaction.getTitleForFeed) has the same decision points, in the same order, at the same nesting depths \u2014 so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/xaction/ManiphestTaskStatusTransaction.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"097c14880567f12374f6129952d5a28fd67dfe8af44b11ba8e2c7fa6d59a6cae"}},{"ruleId":"D2","level":"warning","message":{"text":"ManiphestTaskStatusTransaction.getTitleForFeed (cognitive 26): ManiphestTaskStatusTransaction.getTitleForFeed has cognitive complexity 26 (threshold 15). Drivers by points: if/else 14 (24 pts), boolean chains 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ManiphestTaskStatusTransaction.getTitle) has the same decision points, in the same order, at the same nesting depths \u2014 so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/xaction/ManiphestTaskStatusTransaction.php"},"region":{"startLine":119}}}],"partialFingerprints":{"codehealthFindingId/v1":"39ecd051b9f2d10f141324cf98edb4c2c299ba64edd9994b15aec27e415a0ae7"}},{"ruleId":"D2","level":"warning","message":{"text":"PhamePostListView.getTagContent (cognitive 26): PhamePostListView.getTagContent has cognitive complexity 26 (threshold 15). Drivers by points: if/else 14 (24 pts), loops 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/view/PhamePostListView.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"ee5d4ef9be5c1199bcd04d185a397960b0b4ec8a5db53b1c1a11825428cad0c3"}},{"ruleId":"D2","level":"warning","message":{"text":"PhrictionDocumentController.renderDocumentChildren (cognitive 26): PhrictionDocumentController.renderDocumentChildren has cognitive complexity 26 (threshold 15). Drivers by points: if/else 10 (17 pts), loops 5 (8 pts), ternaries 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/controller/PhrictionDocumentController.php"},"region":{"startLine":510}}}],"partialFingerprints":{"codehealthFindingId/v1":"4e1500f747638282f7ebd7457056afad3fc2e0366de1595f54a247f5261851c6"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorPolicyQuery.loadPage (cognitive 26): PhabricatorPolicyQuery.loadPage has cognitive complexity 26 (threshold 15). Drivers by points: if/else 11 (18 pts), loops 4 (7 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/query/PhabricatorPolicyQuery.php"},"region":{"startLine":58}}}],"partialFingerprints":{"codehealthFindingId/v1":"464f8e86f58c2f0463a30a5632b9fc5a112a208b6159cc7c6f2982865e8c1fc8"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectTransaction.getTitle (cognitive 26): PhabricatorProjectTransaction.getTitle has cognitive complexity 26 (threshold 15). Drivers by points: if/else 9 (22 pts), boolean chains 3, match/switch 1 (nesting depth added 13). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/storage/PhabricatorProjectTransaction.php"},"region":{"startLine":77}}}],"partialFingerprints":{"codehealthFindingId/v1":"713f5626d2015798085e216cb039713d7cd4264ddb8a2b221f4d01cc61798abd"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorSearchController.handleRequest (cognitive 26): PhabricatorSearchController.handleRequest has cognitive complexity 26 (threshold 15). Drivers by points: if/else 10 (22 pts), boolean chains 2, error handling 1 (2 pts) (nesting depth added 13). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/controller/PhabricatorSearchController.php"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"2170891d8fdb436f20fd4385220e227366813fa7126d44d0fb3f4e54449953e2"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorEditEngineSubtype.validateConfiguration (cognitive 26): PhabricatorEditEngineSubtype.validateConfiguration has cognitive complexity 26 (threshold 15). Drivers by points: if/else 9 (18 pts), loops 4 (7 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editengine/PhabricatorEditEngineSubtype.php"},"region":{"startLine":148}}}],"partialFingerprints":{"codehealthFindingId/v1":"c92fd37c593682643f456ae89c50abb2152bd7e8fbcbae7767f60d1efc2d4924"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMainMenuView.renderNotificationMenu (cognitive 26): PhabricatorMainMenuView.renderNotificationMenu has cognitive complexity 26 (threshold 15). Drivers by points: if/else 15 (25 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/page/menu/PhabricatorMainMenuView.php"},"region":{"startLine":365}}}],"partialFingerprints":{"codehealthFindingId/v1":"295fccde5552282b94022ddc4f23cb76b7d31c0a514f964a5a10b5a4c702e5ee"}},{"ruleId":"D2","level":"warning","message":{"text":"PHUIListItemView.getTagContent (cognitive 26): PHUIListItemView.getTagContent has cognitive complexity 26 (threshold 15). Drivers by points: if/else 15 (23 pts), ternaries 2, boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIListItemView.php"},"region":{"startLine":286}}}],"partialFingerprints":{"codehealthFindingId/v1":"a4949dffc1f78fb427c206dc578b07336b338ff096401bed2fe6a012a5084f39"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-object-selector.JX.behavior(\u0022phabricator-object-selector\u0022) (cognitive 26): behavior-object-selector.JX.behavior(\u0022phabricator-object-selector\u0022) has cognitive complexity 26 (threshold 15). Drivers by points: if/else 13 (17 pts), loops 6 (8 pts), ternaries 1 (nesting depth added 6). Most of this is not in the body itself: 4 of the 26 points are its own statements and the rest belongs to 7 function items inside it that branch (redrawList, onreceive, redrawAttached, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-object-selector.js"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"a7b9dbdbe32f0a24aa70eb48913aa3b165c4e59b111c11e1f1af41be157fe894"}},{"ruleId":"D2","level":"warning","message":{"text":"sortHandler (cognitive 26): sortHandler has cognitive complexity 26 (threshold 15). Drivers by points: if/else 12 (18 pts), ternaries 3 (6 pts), boolean chains 1, loops 1 (nesting depth added 9). Most of this is not in the body itself: 8 of the 26 points are its own statements and the rest belongs to one function literal inside it that branches (line 221). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal\u0027s work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/Prefab.js"},"region":{"startLine":192}}}],"partialFingerprints":{"codehealthFindingId/v1":"65fa667adda4c6a77847b29376662b91ac233261e091176d8b197dbcf8f3332a"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous) (cognitive 26): (anonymous) has cognitive complexity 26 (threshold 15). Drivers by points: if/else 13 (17 pts), loops 6 (8 pts), ternaries 1 (nesting depth added 6). Most of this is not in the body itself: 4 of the 26 points are its own statements and the rest belongs to 11 function items inside it that branch (redrawList, onreceive, redrawAttached, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-object-selector.js"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"3a171937e5d852b5ca3dfa6639ed629e9146b52692cb4a5ff956dee56114f72a"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous)::assist (cognitive 26): (anonymous)::assist has cognitive complexity 26 (threshold 15). Drivers by points: ternaries 5 (10 pts), if/else 6 (9 pts), boolean chains 6, match/switch 1 (nesting depth added 8). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js"},"region":{"startLine":188}}}],"partialFingerprints":{"codehealthFindingId/v1":"3c9251050c39cec6ded105eb86a4035e801e0880d252a2fe7e16ae1ef9a5f52d"}},{"ruleId":"D2","level":"warning","message":{"text":"AphrontApplicationConfiguration.readHTTPPOSTData (cognitive 25): AphrontApplicationConfiguration.readHTTPPOSTData has cognitive complexity 25 (threshold 15). Drivers by points: if/else 9 (19 pts), loops 2 (6 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/configuration/AphrontApplicationConfiguration.php"},"region":{"startLine":800}}}],"partialFingerprints":{"codehealthFindingId/v1":"c9da71497d9e7a7ef5d981e82bc2eee6a932ce60fc34ce77f2b7e2366c02e457"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorSetupIssueView.renderPhabricatorConfig (cognitive 25): PhabricatorSetupIssueView.renderPhabricatorConfig has cognitive complexity 25 (threshold 15). Drivers by points: if/else 11 (18 pts), loops 4 (6 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/view/PhabricatorSetupIssueView.php"},"region":{"startLine":245}}}],"partialFingerprints":{"codehealthFindingId/v1":"05a871e951de6fe93bfe8eeef3f212bd69bfb05043939ce092249e6341eb55f8"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialReviewersField.getWarningsForRevisionHeader (cognitive 25): DifferentialReviewersField.getWarningsForRevisionHeader has cognitive complexity 25 (threshold 15). Drivers by points: if/else 13 (24 pts), loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/customfield/DifferentialReviewersField.php"},"region":{"startLine":68}}}],"partialFingerprints":{"codehealthFindingId/v1":"839dcc4dd83ec9b13bf6ca2f304aef2df2f66ce3d8121002d2a7e1dbcc8a22f3"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialTransactionEditor.didApplyHeraldRules (cognitive 25): DifferentialTransactionEditor.didApplyHeraldRules has cognitive complexity 25 (threshold 15). Drivers by points: if/else 11 (18 pts), loops 4 (5 pts), match/switch 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/editor/DifferentialTransactionEditor.php"},"region":{"startLine":1034}}}],"partialFingerprints":{"codehealthFindingId/v1":"74c3a3000a9dbe66506567e7ef90ad33f8e346ace591a9bea770994a1786fb5a"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialDiffExtractionEngine.loadConcerningBuilds (cognitive 25): DifferentialDiffExtractionEngine.loadConcerningBuilds has cognitive complexity 25 (threshold 15). Drivers by points: if/else 7 (21 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/engine/DifferentialDiffExtractionEngine.php"},"region":{"startLine":335}}}],"partialFingerprints":{"codehealthFindingId/v1":"b07cfb0fccebf7184098fa1628b691feff0e89f7b24d58f87893da997d925cec"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionBrowseController.browseFile (cognitive 25): DiffusionBrowseController.browseFile has cognitive complexity 25 (threshold 15). Drivers by points: if/else 13 (23 pts), match/switch 1 (2 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionBrowseController.php"},"region":{"startLine":100}}}],"partialFingerprints":{"codehealthFindingId/v1":"fcabf054db85454883e74a5a391289fe3e6dc8d0567ff17091cc02ea17578bfe"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionExternalController.handleRequest (cognitive 25): DiffusionExternalController.handleRequest has cognitive complexity 25 (threshold 15). Drivers by points: if/else 11 (20 pts), loops 2 (5 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionExternalController.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"69a37b6c6d7af58ee7d401b11a1d48444af74faf4039efe4dcebd768a814d468"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionRepositoryURICredentialController.handleRequest (cognitive 25): DiffusionRepositoryURICredentialController.handleRequest has cognitive complexity 25 (threshold 15). Drivers by points: if/else 18 (25 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRepositoryURICredentialController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"52e8989ab693f449f0b66023c295a32bd27e3a5ea20bac179a50627aaa13eb06"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionServeController.serveGitLFSBatchRequest (cognitive 25): DiffusionServeController.serveGitLFSBatchRequest has cognitive complexity 25 (threshold 15). Drivers by points: if/else 12 (22 pts), loops 2, match/switch 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionServeController.php"},"region":{"startLine":1068}}}],"partialFingerprints":{"codehealthFindingId/v1":"7fb12181835044f79fe4f70b0fbf2d4c5e3eb4d4f0c90d9bb164d0fe1cceeee3"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionBranchListView.render (cognitive 25): DiffusionBranchListView.render has cognitive complexity 25 (threshold 15). Drivers by points: if/else 12 (24 pts), loops 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/view/DiffusionBranchListView.php"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"24daed9856c03de0f0697b43bf5312e1e13294072ecffc4e9ea044a551a1c3c6"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionPatternSearchView.render (cognitive 25): DiffusionPatternSearchView.render has cognitive complexity 25 (threshold 15). Drivers by points: if/else 7 (18 pts), loops 3 (7 pts) (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/view/DiffusionPatternSearchView.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"b2420d3d52a2db9133b235f2e777ee869a263e95e5ff65c22c19c2d75ac12d0a"}},{"ruleId":"D2","level":"warning","message":{"text":"DivinerAtomController.renderFullSignature (cognitive 25): DivinerAtomController.renderFullSignature has cognitive complexity 25 (threshold 15). Drivers by points: if/else 7 (12 pts), match/switch 5 (7 pts), loops 1 (3 pts), ternaries 3 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/controller/DivinerAtomController.php"},"region":{"startLine":479}}}],"partialFingerprints":{"codehealthFindingId/v1":"7c21a01c8cd5d321dd54dcacc8c65f3299a88aa66c61c767e3015133be13bc6e"}},{"ruleId":"D2","level":"warning","message":{"text":"DivinerAtomizeWorkflow.execute (cognitive 25): DivinerAtomizeWorkflow.execute has cognitive complexity 25 (threshold 15). Drivers by points: if/else 10 (16 pts), loops 6 (9 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/workflow/DivinerAtomizeWorkflow.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"e28752b5c5c3c68342b526682c2888522c00361d784c45d810466d93a4532d44"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorTransactionFactEngine.groupTransactions (cognitive 25): PhabricatorTransactionFactEngine.groupTransactions has cognitive complexity 25 (threshold 15). Drivers by points: if/else 9 (19 pts), boolean chains 4, loops 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fact/engine/PhabricatorTransactionFactEngine.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"2eabaa6cabc120374afb37f61ca6f1760b6923e35596e3b4bc8383f2feb72950"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMemeEngine.getMetrics (cognitive 25): PhabricatorMemeEngine.getMetrics has cognitive complexity 25 (threshold 15). Drivers by points: if/else 7 (19 pts), loops 2 (5 pts), boolean chains 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/macro/engine/PhabricatorMemeEngine.php"},"region":{"startLine":308}}}],"partialFingerprints":{"codehealthFindingId/v1":"5547390475bb8b3185ca82983c133474d3c2bb196b39fbf69a79e7c030faec1d"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationPolicyChangeTransaction.validateTransactions (cognitive 25): PhabricatorApplicationPolicyChangeTransaction.validateTransactions has cognitive complexity 25 (threshold 15). Drivers by points: if/else 9 (19 pts), loops 4 (5 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/meta/xactions/PhabricatorApplicationPolicyChangeTransaction.php"},"region":{"startLine":73}}}],"partialFingerprints":{"codehealthFindingId/v1":"706be0e53adafe9179c87b0fae18e9bee16fe82acb03441c5bef03e943f8d362"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMailSMTPAdapter.sendMessage (cognitive 25): PhabricatorMailSMTPAdapter.sendMessage has cognitive complexity 25 (threshold 15). Drivers by points: if/else 14 (17 pts), loops 4 (8 pts) (nesting depth added 7). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/adapter/PhabricatorMailSMTPAdapter.php"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"3dfe307342987a24cbddd383f6a00266d95b4af9fae4dcb4788baa86888220a5"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMailManagementShowInboundWorkflow.execute (cognitive 25): PhabricatorMailManagementShowInboundWorkflow.execute has cognitive complexity 25 (threshold 15). Drivers by points: if/else 9 (17 pts), loops 4 (8 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/management/PhabricatorMailManagementShowInboundWorkflow.php"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"8dfb7b2eb2d907d77450f59d15adfabc5c8908a508f99dbba5c57157008cfbc2"}},{"ruleId":"D2","level":"warning","message":{"text":"PhortuneAccountEditor.validateTransaction (cognitive 25): PhortuneAccountEditor.validateTransaction has cognitive complexity 25 (threshold 15). Drivers by points: if/else 3 (14 pts), loops 2 (6 pts), match/switch 2 (4 pts), boolean chains 1 (nesting depth added 17). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/editor/PhortuneAccountEditor.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"61c0d6c174c36a2d27bf20cd7341319226589a44dd7769e9a23dc82f4fd87b94"}},{"ruleId":"D2","level":"warning","message":{"text":"PhrequentTimeBlock.sortTimeline (cognitive 25): PhrequentTimeBlock.sortTimeline has cognitive complexity 25 (threshold 15). Drivers by points: ternaries 5 (14 pts), if/else 7 (9 pts), boolean chains 2 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phrequent/storage/PhrequentTimeBlock.php"},"region":{"startLine":291}}}],"partialFingerprints":{"codehealthFindingId/v1":"ec44bd95fe8673c069cfd08992c2175ac69f68fbde31a04af7228f476dd714c4"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorPolicy.getSpecialRules (cognitive 25): PhabricatorPolicy.getSpecialRules has cognitive complexity 25 (threshold 15). Drivers by points: if/else 8 (22 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 15). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/storage/PhabricatorPolicy.php"},"region":{"startLine":441}}}],"partialFingerprints":{"codehealthFindingId/v1":"c1b80731a271e7664c475b00237053e72530aff7d321e64ed99d1bfddc0b2d9a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectColumnHideController.handleRequest (cognitive 25): PhabricatorProjectColumnHideController.handleRequest has cognitive complexity 25 (threshold 15). Drivers by points: if/else 16 (23 pts), loops 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectColumnHideController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"c0c883f78abc93727eeac12b25eefb5e41e92f20ef2580290899b9c3bab03e07"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransaction.shouldDisplayGroupWith (cognitive 25): PhabricatorApplicationTransaction.shouldDisplayGroupWith has cognitive complexity 25 (threshold 15). Drivers by points: if/else 12 (24 pts), loops 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorApplicationTransaction.php"},"region":{"startLine":1684}}}],"partialFingerprints":{"codehealthFindingId/v1":"e837de52988b643e817b2fff7bc9d3bb402a1df7c8bd2665150b10ff40fadb25"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransactionCommentView.renderCommentPanel (cognitive 25): PhabricatorApplicationTransactionCommentView.renderCommentPanel has cognitive complexity 25 (threshold 15). Drivers by points: if/else 11 (20 pts), loops 2 (5 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php"},"region":{"startLine":296}}}],"partialFingerprints":{"codehealthFindingId/v1":"069df6f674809d3f19e19c6aaf9a224ec91116d7a33d8ef446c65d99d9293457"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorInlineSummaryView.renderTable (cognitive 25): PhabricatorInlineSummaryView.renderTable has cognitive complexity 25 (threshold 15). Drivers by points: if/else 6 (14 pts), ternaries 2 (6 pts), loops 3 (5 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/view/PhabricatorInlineSummaryView.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"3f76be8e4f2e4ee9b82a44b172e55391251abc0c85b3a7723a924be023e58a6d"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCursorPagedPolicyAwareQuery.buildApplicationSearchWhereClause (cognitive 25): PhabricatorCursorPagedPolicyAwareQuery.buildApplicationSearchWhereClause has cognitive complexity 25 (threshold 15). Drivers by points: match/switch 3 (11 pts), if/else 3 (9 pts), loops 2 (5 pts) (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php"},"region":{"startLine":1657}}}],"partialFingerprints":{"codehealthFindingId/v1":"5f7907269b1eb7d80bcc01c7c2275c6efe39a7eca81780be0f7cb65291f0c226"}},{"ruleId":"D2","level":"warning","message":{"text":"PHUICrumbsView.render (cognitive 25): PHUICrumbsView.render has cognitive complexity 25 (threshold 15). Drivers by points: if/else 10 (23 pts), loops 1 (2 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUICrumbsView.php"},"region":{"startLine":48}}}],"partialFingerprints":{"codehealthFindingId/v1":"f093d034eb60b8004a928a2d3eb6e1b792f5e9c58bfe49d5cca43ee20999e21d"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-policy-control.JX.behavior(\u0022policy-control\u0022) (cognitive 25): behavior-policy-control.JX.behavior(\u0022policy-control\u0022) has cognitive complexity 25 (threshold 15). Drivers by points: if/else 8 (14 pts), loops 4 (6 pts), ternaries 1 (4 pts), boolean chains 1 (nesting depth added 11). Most of this is not in the body itself: 1 of the 25 points is its own statement and the rest belongs to 5 function items inside it that branch (a function literal at line 30, add_policy, render_option, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/policy/behavior-policy-control.js"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"5ff8fcd5de730ff9a2f6f68caf2831d0405b973d6fb833451c16389d346438e2"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-audio-source.JX.behavior(\u0022audio-source\u0022)::onupdate (cognitive 25): behavior-audio-source.JX.behavior(\u0022audio-source\u0022)::onupdate has cognitive complexity 25 (threshold 15). Drivers by points: if/else 8 (20 pts), error handling 1 (3 pts), boolean chains 1, loops 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-audio-source.js"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"f0988fb54fa20d69c5f5467c129b24f18cbe08c0de41e54646ae989dbae94cf1"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-watch-anchor.JX.behavior(\u0022phabricator-watch-anchor\u0022)::seek_anchor (cognitive 25): behavior-watch-anchor.JX.behavior(\u0022phabricator-watch-anchor\u0022)::seek_anchor has cognitive complexity 25 (threshold 15). Drivers by points: if/else 10 (16 pts), error handling 3 (5 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-watch-anchor.js"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"9f17f12dfe7931fbfef86eea9c80783e28f77b977ebc79af15d9680424e2e835"}},{"ruleId":"D2","level":"warning","message":{"text":"buildTokenizer (cognitive 25): buildTokenizer has cognitive complexity 25 (threshold 15). Drivers by points: if/else 15, boolean chains 9, error handling 1. Most of this is not in the body itself: 11 of the 25 points are its own statements and the rest belongs to one function literal inside it that branches (line 113). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal\u0027s work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/Prefab.js"},"region":{"startLine":73}}}],"partialFingerprints":{"codehealthFindingId/v1":"3421c37341240d10e570e39d9b24fa2137cc66fe2d4148f905f46682efaa58ac"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous)::onupdate (cognitive 25): (anonymous)::onupdate has cognitive complexity 25 (threshold 15). Drivers by points: if/else 8 (20 pts), error handling 1 (3 pts), boolean chains 1, loops 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-audio-source.js"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"ab6d05c542c14d488299ca2eb288bac723f16486f0d5c682701c74d3ab925f82"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous)::seek_anchor (cognitive 25): (anonymous)::seek_anchor has cognitive complexity 25 (threshold 15). Drivers by points: if/else 10 (16 pts), error handling 3 (5 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-watch-anchor.js"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"f13ba53b91ad38c79a4b1c2245030957a721c809f8584ebf19dfd41d222745f1"}},{"ruleId":"D2","level":"warning","message":{"text":"ConpherenceListController.handleRequest (cognitive 24): ConpherenceListController.handleRequest has cognitive complexity 24 (threshold 15). Drivers by points: if/else 10 (20 pts), loops 1 (2 pts), match/switch 2 (nesting depth added 11). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceListController.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"d3687710f711c72a63eab412f7a88b237621e04a5920a47ac119ab48b76aba3c"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialRevisionReviewersTransaction.generateNewValue (cognitive 24): DifferentialRevisionReviewersTransaction.generateNewValue has cognitive complexity 24 (threshold 15). Drivers by points: if/else 9 (16 pts), loops 4 (5 pts), boolean chains 3 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php"},"region":{"startLine":15}}}],"partialFingerprints":{"codehealthFindingId/v1":"dc9584d5672af7201fc86bb6385db59bfacef7ebe33cbda4d004ce482fa6f0a9"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionSubversionServeSSHWorkflow.willReadMessageCallback (cognitive 24): DiffusionSubversionServeSSHWorkflow.willReadMessageCallback has cognitive complexity 24 (threshold 15). Drivers by points: if/else 6 (13 pts), loops 2 (6 pts), match/switch 1 (4 pts), boolean chains 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/ssh/DiffusionSubversionServeSSHWorkflow.php"},"region":{"startLine":278}}}],"partialFingerprints":{"codehealthFindingId/v1":"eec927069556e07fa394abcca0da10206616a4adda74e9d9b0342feee3f4b897"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionSourceLinkView.render (cognitive 24): DiffusionSourceLinkView.render has cognitive complexity 24 (threshold 15). Drivers by points: if/else 12 (22 pts), boolean chains 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/view/DiffusionSourceLinkView.php"},"region":{"startLine":157}}}],"partialFingerprints":{"codehealthFindingId/v1":"cde854c9e634e3c2f7d734e547f6671a325850690f8709eb33e2c9af891dadbc"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorChartFunctionArgumentParser.parseArguments (cognitive 24): PhabricatorChartFunctionArgumentParser.parseArguments has cognitive complexity 24 (threshold 15). Drivers by points: if/else 10 (20 pts), error handling 1 (2 pts), boolean chains 1, loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fact/chart/PhabricatorChartFunctionArgumentParser.php"},"region":{"startLine":111}}}],"partialFingerprints":{"codehealthFindingId/v1":"934d9df6bfe4618e62107f2baef65de8b8f584cbee1db69ee6f83c635eb4b718"}},{"ruleId":"D2","level":"warning","message":{"text":"HarbormasterBuildLog.updateLineMap (cognitive 24): HarbormasterBuildLog.updateLineMap has cognitive complexity 24 (threshold 15). Drivers by points: if/else 10 (19 pts), loops 2 (3 pts), boolean chains 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/storage/build/HarbormasterBuildLog.php"},"region":{"startLine":552}}}],"partialFingerprints":{"codehealthFindingId/v1":"3b82bc6b3da33153d5ac3d826e6949532c5bba008de568ecb5b5cd3f530c1770"}},{"ruleId":"D2","level":"warning","message":{"text":"HeraldTranscriptController.getTranscriptPHIDs (cognitive 24): HeraldTranscriptController.getTranscriptPHIDs has cognitive complexity 24 (threshold 15). Drivers by points: if/else 5 (13 pts), loops 5 (9 pts), match/switch 1 (2 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/controller/HeraldTranscriptController.php"},"region":{"startLine":131}}}],"partialFingerprints":{"codehealthFindingId/v1":"242cd040b497ed106e9bcdfc3f0bceeac7703cf03ff365998042c42b507ec15a"}},{"ruleId":"D2","level":"warning","message":{"text":"LegalpadDocumentSignatureSearchEngine.renderResultList (cognitive 24): LegalpadDocumentSignatureSearchEngine.renderResultList has cognitive complexity 24 (threshold 15). Drivers by points: if/else 11 (21 pts), ternaries 1 (2 pts), loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/legalpad/query/LegalpadDocumentSignatureSearchEngine.php"},"region":{"startLine":150}}}],"partialFingerprints":{"codehealthFindingId/v1":"5ab1f0a7369047044bb30b000248609d6dd0cf404e05bda91394e07ec4033822"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorImageMacroRemarkupRule.didMarkupText (cognitive 24): PhabricatorImageMacroRemarkupRule.didMarkupText has cognitive complexity 24 (threshold 15). Drivers by points: if/else 10 (18 pts), match/switch 1 (3 pts), loops 2, boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/macro/markup/PhabricatorImageMacroRemarkupRule.php"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"1ab1bc0e55cbce2fe1b3ac49093b1fedda7e446f1452cd530d1101e52760a95a"}},{"ruleId":"D2","level":"warning","message":{"text":"NuanceGitHubRawEvent.getTargetObjectName (cognitive 24): NuanceGitHubRawEvent.getTargetObjectName has cognitive complexity 24 (threshold 15). Drivers by points: if/else 8 (15 pts), match/switch 2 (9 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/github/NuanceGitHubRawEvent.php"},"region":{"startLine":244}}}],"partialFingerprints":{"codehealthFindingId/v1":"06bc39687bf8286429cffbd3741c7af67d8e0c14a34d65df14b58ccdd0e69c1a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorOAuthServerAuthController.handleRequest (cognitive 24): PhabricatorOAuthServerAuthController.handleRequest has cognitive complexity 24 (threshold 15). Drivers by points: if/else 17 (20 pts), error handling 2, loops 1 (2 pts) (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/oauthserver/controller/PhabricatorOAuthServerAuthController.php"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"649cfc132df1b7c8ffe5cedf496c38ecf5e9b26eb0baa161f0dac5f6a49cc92a"}},{"ruleId":"D2","level":"warning","message":{"text":"PholioMockThumbGridView.render (cognitive 24): PholioMockThumbGridView.render has cognitive complexity 24 (threshold 15). Drivers by points: if/else 8 (15 pts), loops 6 (8 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/pholio/view/PholioMockThumbGridView.php"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"d6328dfd4e9e930e74fe027908f00232b7049b9c47c1fe4161dd59e015adda5a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhortunePayPalPaymentProvider.processControllerRequest (cognitive 24): PhortunePayPalPaymentProvider.processControllerRequest has cognitive complexity 24 (threshold 15). Drivers by points: if/else 11 (20 pts), match/switch 3 (4 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/provider/PhortunePayPalPaymentProvider.php"},"region":{"startLine":287}}}],"partialFingerprints":{"codehealthFindingId/v1":"e745c3acd6179c42027194cec4382dd77ade4f6a1b8b1bb31d3aa59b7810cadb"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectMembersViewController.buildCurtainView (cognitive 24): PhabricatorProjectMembersViewController.buildCurtainView has cognitive complexity 24 (threshold 15). Drivers by points: if/else 15 (18 pts), boolean chains 6 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectMembersViewController.php"},"region":{"startLine":70}}}],"partialFingerprints":{"codehealthFindingId/v1":"0369e7e4e0299b3969b13f20f5468feec77604f7ceb39cde3f13b41658d6ea9b"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectTriggerEditController.handleRequest (cognitive 24): PhabricatorProjectTriggerEditController.handleRequest has cognitive complexity 24 (threshold 15). Drivers by points: if/else 17 (22 pts), error handling 1 (2 pts) (nesting depth added 6). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/trigger/PhabricatorProjectTriggerEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"f6d4167cec3775466e066366c4c400115c396025825a7912e9b7b4528f82909c"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorBoardLayoutEngine.loadColumns (cognitive 24): PhabricatorBoardLayoutEngine.loadColumns has cognitive complexity 24 (threshold 15). Drivers by points: if/else 7 (14 pts), loops 5 (8 pts), boolean chains 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/engine/PhabricatorBoardLayoutEngine.php"},"region":{"startLine":321}}}],"partialFingerprints":{"codehealthFindingId/v1":"397a7d0e9ef149133243f6d749954787477e618aa2dabfbad0d5c1edc503a046"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryRefEngine.loadNewCommitIdentifiers (cognitive 24): PhabricatorRepositoryRefEngine.loadNewCommitIdentifiers has cognitive complexity 24 (threshold 15). Drivers by points: loops 4 (13 pts), if/else 6 (10 pts), match/switch 1 (nesting depth added 13). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/engine/PhabricatorRepositoryRefEngine.php"},"region":{"startLine":414}}}],"partialFingerprints":{"codehealthFindingId/v1":"803fa8c624ef9a7e78338a83c8664b817b2b03a2b9676f9c3d40fa435367f67b"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMultiFactorSettingsPanel.processNew (cognitive 24): PhabricatorMultiFactorSettingsPanel.processNew has cognitive complexity 24 (threshold 15). Drivers by points: if/else 14 (21 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/settings/panel/PhabricatorMultiFactorSettingsPanel.php"},"region":{"startLine":175}}}],"partialFingerprints":{"codehealthFindingId/v1":"59e4a18ef24b368dc27267275c223234b2cfb6c905a81c677bf7d3974645a91c"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransactionEditor.applyCapabilityChecks (cognitive 24): PhabricatorApplicationTransactionEditor.applyCapabilityChecks has cognitive complexity 24 (threshold 15). Drivers by points: if/else 9 (16 pts), loops 2 (7 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":1841}}}],"partialFingerprints":{"codehealthFindingId/v1":"cf075a65961a63b1d9ea3ad898b5eb1f03374951cc104d5caefb26ad7364d85e"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransactionEditor.buildSubscribeTransaction (cognitive 24): PhabricatorApplicationTransactionEditor.buildSubscribeTransaction has cognitive complexity 24 (threshold 15). Drivers by points: if/else 11 (22 pts), loops 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":2039}}}],"partialFingerprints":{"codehealthFindingId/v1":"3f21f8acad96b4032de52044c78040cfb3b5dafd79b73bb3bdaad8e31046b840"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransactionEditor.getMailCC (cognitive 24): PhabricatorApplicationTransactionEditor.getMailCC has cognitive complexity 24 (threshold 15). Drivers by points: if/else 6 (13 pts), loops 3 (11 pts) (nesting depth added 15). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":3730}}}],"partialFingerprints":{"codehealthFindingId/v1":"f6644a81bf1f0987ab4c86a40cf3870510a4e70bc6edef7a9831b7b0c9f83b6d"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransactionEditor.newMFATransactions (cognitive 24): PhabricatorApplicationTransactionEditor.newMFATransactions has cognitive complexity 24 (threshold 15). Drivers by points: if/else 10 (20 pts), loops 2 (4 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":5514}}}],"partialFingerprints":{"codehealthFindingId/v1":"cbc4722ecfabff700802d42324c09112685bd3fcee2655f747444bd91507afbd"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransactionWarningResponse.reduceProxyResponse (cognitive 24): PhabricatorApplicationTransactionWarningResponse.reduceProxyResponse has cognitive complexity 24 (threshold 15). Drivers by points: if/else 13 (18 pts), loops 5 (6 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/response/PhabricatorApplicationTransactionWarningResponse.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"37fa67255fbf47c3d87d110e7b8bb4a8381403516b702072f4afb0ed133e3c76"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorEditEngineConfiguration.applyConfigurationToFields (cognitive 24): PhabricatorEditEngineConfiguration.applyConfigurationToFields has cognitive complexity 24 (threshold 15). Drivers by points: if/else 8 (19 pts), loops 2, match/switch 1 (2 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php"},"region":{"startLine":132}}}],"partialFingerprints":{"codehealthFindingId/v1":"7f7c5843e5204a09a0b080b4e7a593da42eb631ecfe41044264dd02a59d8362a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorWorkerLeaseQuery.execute (cognitive 24): PhabricatorWorkerLeaseQuery.execute has cognitive complexity 24 (threshold 15). Drivers by points: if/else 15 (22 pts), loops 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/workers/query/PhabricatorWorkerLeaseQuery.php"},"region":{"startLine":75}}}],"partialFingerprints":{"codehealthFindingId/v1":"f4ca7104e50dca03d6968e1aabae209378fce454bc3a351659d39d79e78899d6"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorStorageManagementWorkflow.printErrors (cognitive 24): PhabricatorStorageManagementWorkflow.printErrors has cognitive complexity 24 (threshold 15). Drivers by points: if/else 15 (23 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php"},"region":{"startLine":776}}}],"partialFingerprints":{"codehealthFindingId/v1":"f94751f8250a7babb946711d4eb4815845979a8cdf65ba0728693b244db3ab7c"}},{"ruleId":"D2","level":"warning","message":{"text":"AphrontDialogView.render (cognitive 24): AphrontDialogView.render has cognitive complexity 24 (threshold 15). Drivers by points: if/else 16 (18 pts), loops 2 (3 pts), boolean chains 2, match/switch 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/AphrontDialogView.php"},"region":{"startLine":255}}}],"partialFingerprints":{"codehealthFindingId/v1":"92c43952079d20f67d10090e5eb51cdda4376ba0800c41336f1f31d07bdcf98a"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-durable-column.JX.behavior(\u0022durable-column\u0022) (cognitive 24): behavior-durable-column.JX.behavior(\u0022durable-column\u0022) has cognitive complexity 24 (threshold 15). Drivers by points: if/else 16 (18 pts), ternaries 4, loops 1, match/switch 1 (nesting depth added 2). Most of this is not in the body itself: 3 of the 24 points are its own statements and the rest belongs to 11 function items inside it that branch (a function literal at line 334, _drawColumn, _minimizeColumn, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/conpherence/behavior-durable-column.js"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"818e2dfa49f49aeb91b6feac8fe8dd10b32e076ea78744816316c34dca54cb83"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-project-boards.JX.behavior(\u0022project-boards\u0022) (cognitive 24): behavior-project-boards.JX.behavior(\u0022project-boards\u0022) has cognitive complexity 24 (threshold 15). Drivers by points: loops 12 (16 pts), if/else 7 (8 pts) (nesting depth added 5). Of this number, 19 points are the body\u0027s own statements and 5 belong to 3 function literals inside it that branch. To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/projects/behavior-project-boards.js"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"683c5b8605a3db84ff7c9a0fe07f4eeac47c0a45435b8e931d5fe5a5c49233b0"}},{"ruleId":"D2","level":"warning","message":{"text":"_onresults (cognitive 24): _onresults has cognitive complexity 24 (threshold 15). Drivers by points: if/else 11 (19 pts), loops 2 (3 pts), boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/phuix/PHUIXAutocomplete.js"},"region":{"startLine":230}}}],"partialFingerprints":{"codehealthFindingId/v1":"d18716d0a89ec674fc5771d2b591370ccffdf7425ce9a59beea373b6ceae4a5f"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous) (cognitive 24): (anonymous) has cognitive complexity 24 (threshold 15). Drivers by points: if/else 16 (18 pts), ternaries 4, loops 1, match/switch 1 (nesting depth added 2). Most of this is not in the body itself: 3 of the 24 points are its own statements and the rest belongs to 29 function items inside it that branch (a function literal at line 334, _drawColumn, _minimizeColumn, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/conpherence/behavior-durable-column.js"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"2531fd722db1417dcd4af7773e5a73c5878351a5c68fb27b7b8adedbe634e95b"}},{"ruleId":"D2","level":"warning","message":{"text":"buildPaths (cognitive 24): buildPaths has cognitive complexity 24 (threshold 15). Drivers by points: if/else 6 (20 pts), loops 2 (4 pts) (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diffusion/DiffusionLocateFileSource.js"},"region":{"startLine":219}}}],"partialFingerprints":{"codehealthFindingId/v1":"e11a0874f46f819ffb33065dc5ac4d490866bd4e95415b55ce4afe9100528f9c"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous) (cognitive 24): (anonymous) has cognitive complexity 24 (threshold 15). Drivers by points: loops 12 (16 pts), if/else 7 (8 pts) (nesting depth added 5). Of this number, 19 points are the body\u0027s own statements and 5 belong to 5 function items inside it that branch. To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/projects/behavior-project-boards.js"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"b29906e3894eddbb3f8b7cec407cd58d97ef7b409a1c74409c1123583f0f9552"}},{"ruleId":"D2","level":"warning","message":{"text":"AphrontApplicationConfiguration.buildController (cognitive 23): AphrontApplicationConfiguration.buildController has cognitive complexity 23 (threshold 15). Drivers by points: if/else 13 (22 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/configuration/AphrontApplicationConfiguration.php"},"region":{"startLine":394}}}],"partialFingerprints":{"codehealthFindingId/v1":"f3c74bb4c6cf9c5b1d3758f688bbf13b4c8f1e0b25256564ddfc2619121d2131"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilCalendarRecurrenceRule.nextDay (cognitive 23): PhutilCalendarRecurrenceRule.nextDay has cognitive complexity 23 (threshold 15). Drivers by points: if/else 7 (11 pts), boolean chains 8, ternaries 1 (3 pts), loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php"},"region":{"startLine":900}}}],"partialFingerprints":{"codehealthFindingId/v1":"a4c6a10a1a36c11c69b8e494f0bfc5b878f37b3a13ed5de7064ec96983ec33e3"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorConfigDatabaseStatusController.renderTable (cognitive 23): PhabricatorConfigDatabaseStatusController.renderTable has cognitive complexity 23 (threshold 15). Drivers by points: if/else 13 (19 pts), loops 3 (4 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/services/PhabricatorConfigDatabaseStatusController.php"},"region":{"startLine":332}}}],"partialFingerprints":{"codehealthFindingId/v1":"989f9503f5d0ed79bee602a27b0d30cdcd01f4a6de6df255f7b07216acf68c66"}},{"ruleId":"D2","level":"warning","message":{"text":"ConpherenceThreadQuery.loadPage (cognitive 23): ConpherenceThreadQuery.loadPage has cognitive complexity 23 (threshold 15). Drivers by points: if/else 8 (20 pts), loops 1 (3 pts) (nesting depth added 14). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/query/ConpherenceThreadQuery.php"},"region":{"startLine":79}}}],"partialFingerprints":{"codehealthFindingId/v1":"9eb12c18b1a7c584bbc0b9715b08dabbfbd76badeb21818eba0fe1b4ed195aef"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorLockLogManagementWorkflow.execute (cognitive 23): PhabricatorLockLogManagementWorkflow.execute has cognitive complexity 23 (threshold 15). Drivers by points: if/else 13 (20 pts), boolean chains 2, loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/daemon/management/PhabricatorLockLogManagementWorkflow.php"},"region":{"startLine":28}}}],"partialFingerprints":{"codehealthFindingId/v1":"54ade51399f4247ea852e5ce4b6e0afeeca97edc7ad654ff1a707bddf2c9052f"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorDifferentialMigrateHunkWorkflow.execute (cognitive 23): PhabricatorDifferentialMigrateHunkWorkflow.execute has cognitive complexity 23 (threshold 15). Drivers by points: if/else 11 (16 pts), boolean chains 4, error handling 1 (2 pts), loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/management/PhabricatorDifferentialMigrateHunkWorkflow.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"ed981c9813774c1525ae8ec903bb19d7430c5d9aacd52d5324e17838049d876c"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialLineAdjustmentMap.newInverseMap (cognitive 23): DifferentialLineAdjustmentMap.newInverseMap has cognitive complexity 23 (threshold 15). Drivers by points: if/else 7 (15 pts), loops 3 (8 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialLineAdjustmentMap.php"},"region":{"startLine":213}}}],"partialFingerprints":{"codehealthFindingId/v1":"9b5db1be644ea4e7d7c036751534029804bc9dae1fbca6a8cb437e312cb7544d"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialRevisionAcceptTransaction.getActionOptions (cognitive 23): DifferentialRevisionAcceptTransaction.getActionOptions has cognitive complexity 23 (threshold 15). Drivers by points: if/else 11 (20 pts), loops 3 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/xaction/DifferentialRevisionAcceptTransaction.php"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"fc412536bd7080465181390406ae2c7eaf08ab4ccd34f88d61e2e1a18f9f7f2a"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionBrowseQueryConduitAPIMethod.getMercurialResult (cognitive 23): DiffusionBrowseQueryConduitAPIMethod.getMercurialResult has cognitive complexity 23 (threshold 15). Drivers by points: if/else 11 (18 pts), boolean chains 2, loops 2, ternaries 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php"},"region":{"startLine":267}}}],"partialFingerprints":{"codehealthFindingId/v1":"c06b31f81374127abd4c6d67ea1cf8dfb169c632053d9536a7a6cc615e32bcaf"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionLintController.loadLintCodes (cognitive 23): DiffusionLintController.loadLintCodes has cognitive complexity 23 (threshold 15). Drivers by points: if/else 9 (18 pts), ternaries 1 (3 pts), loops 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionLintController.php"},"region":{"startLine":219}}}],"partialFingerprints":{"codehealthFindingId/v1":"db16a0a092baf59a554961c141587923b070a7334e7e822c35c4f5c5fa2c028c"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionLowLevelCommitQuery.loadGitCommitRef (cognitive 23): DiffusionLowLevelCommitQuery.loadGitCommitRef has cognitive complexity 23 (threshold 15). Drivers by points: if/else 13 (21 pts), boolean chains 1, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/lowlevel/DiffusionLowLevelCommitQuery.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"c11dd101f26301ce34f05716a04d60f3e40a62bb26350836e0ffa7daef221c25"}},{"ruleId":"D2","level":"warning","message":{"text":"DivinerAtomController.buildParametersAndReturn (cognitive 23): DivinerAtomController.buildParametersAndReturn has cognitive complexity 23 (threshold 15). Drivers by points: if/else 9 (18 pts), loops 3 (5 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/controller/DivinerAtomController.php"},"region":{"startLine":575}}}],"partialFingerprints":{"codehealthFindingId/v1":"a4ca9a0a74b2e51d164c798108325fbde64f84ad85ba0aff21c97958655ba15a"}},{"ruleId":"D2","level":"warning","message":{"text":"DoorkeeperJIRAFeedWorker.publishFeedStory (cognitive 23): DoorkeeperJIRAFeedWorker.publishFeedStory has cognitive complexity 23 (threshold 15). Drivers by points: if/else 6 (12 pts), loops 3 (6 pts), error handling 1 (4 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/worker/DoorkeeperJIRAFeedWorker.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"de439549b3d3c71265632d25ae41e9253c6068ef1a28988db09c0e0703c1d747"}},{"ruleId":"D2","level":"warning","message":{"text":"DrydockManagementLeaseWorkflow.execute (cognitive 23): DrydockManagementLeaseWorkflow.execute has cognitive complexity 23 (threshold 15). Drivers by points: if/else 13 (18 pts), loops 5 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/management/DrydockManagementLeaseWorkflow.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"a339ddb83beee1c8ae285bb00adf66ff4148a8963cb1fea34d1d5bfd414aefc8"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorChartDataQuery.selectInputValues (cognitive 23): PhabricatorChartDataQuery.selectInputValues has cognitive complexity 23 (threshold 15). Drivers by points: if/else 7 (15 pts), loops 3 (7 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fact/chart/PhabricatorChartDataQuery.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"b9f743e2f2967147c07c0204ca246d823dfdc1b4ef8f7ef19ffb479083343dc6"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorChartStackedAreaDataset.getGeometry (cognitive 23): PhabricatorChartStackedAreaDataset.getGeometry has cognitive complexity 23 (threshold 15). Drivers by points: if/else 6 (14 pts), loops 4 (8 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fact/chart/PhabricatorChartStackedAreaDataset.php"},"region":{"startLine":234}}}],"partialFingerprints":{"codehealthFindingId/v1":"06a7006e7bcd882ba7ee63339911212e447df72a42a6c8bf596f18375405f8fb"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorKeyringConfigOptionType.validateOption (cognitive 23): PhabricatorKeyringConfigOptionType.validateOption has cognitive complexity 23 (threshold 15). Drivers by points: if/else 8 (17 pts), error handling 1 (2 pts), loops 2, match/switch 1 (2 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/keyring/PhabricatorKeyringConfigOptionType.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"2579ee0e8db71484447fdcb50f2287d11ca524a3881f6d6b4df90274f527a8da"}},{"ruleId":"D2","level":"warning","message":{"text":"HarbormasterBuildLogRenderController.mergeOverlappingViews (cognitive 23): HarbormasterBuildLogRenderController.mergeOverlappingViews has cognitive complexity 23 (threshold 15). Drivers by points: if/else 6 (18 pts), loops 2 (3 pts), boolean chains 2 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php"},"region":{"startLine":558}}}],"partialFingerprints":{"codehealthFindingId/v1":"196da706bf5368d75f2fc5764f6f4a757bf72c4341d70b8f7e44f0264c9fade0"}},{"ruleId":"D2","level":"warning","message":{"text":"HarbormasterStepEditController.handleRequest (cognitive 23): HarbormasterStepEditController.handleRequest has cognitive complexity 23 (threshold 15). Drivers by points: if/else 15 (20 pts), error handling 1 (2 pts), ternaries 1 (nesting depth added 6). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterStepEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"7fb6681658b85f0bd87d60fc0abecf6e761cb574c1bbc680d8f4f974dbb86770"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorAppSearchEngine.renderResultList (cognitive 23): PhabricatorAppSearchEngine.renderResultList has cognitive complexity 23 (threshold 15). Drivers by points: if/else 8 (19 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/meta/query/PhabricatorAppSearchEngine.php"},"region":{"startLine":181}}}],"partialFingerprints":{"codehealthFindingId/v1":"83b16ab711b2c32f0abdfd8d64329eb8e8b949a828c4bdbdb3da23b637a90934"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorOAuthServerTokenController.handleRequest (cognitive 23): PhabricatorOAuthServerTokenController.handleRequest has cognitive complexity 23 (threshold 15). Drivers by points: if/else 17 (20 pts), boolean chains 2, error handling 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/oauthserver/controller/PhabricatorOAuthServerTokenController.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"31a7ae6800a6e93ae4a6a9f7c4f52689edb386c6bd9f1193fe1f9c0d0f944331"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorPeopleUserPHIDType.loadHandles (cognitive 23): PhabricatorPeopleUserPHIDType.loadHandles has cognitive complexity 23 (threshold 15). Drivers by points: if/else 10 (22 pts), loops 1 (nesting depth added 12). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/phid/PhabricatorPeopleUserPHIDType.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"85f005417a7b8f2cccbffc607d33671304c3dcc5cb519cece2147f6b0f27a3c5"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectQuery.didFilterPage (cognitive 23): PhabricatorProjectQuery.didFilterPage has cognitive complexity 23 (threshold 15). Drivers by points: if/else 5 (12 pts), loops 4 (11 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/query/PhabricatorProjectQuery.php"},"region":{"startLine":385}}}],"partialFingerprints":{"codehealthFindingId/v1":"98f52ac1e0515ce98f134c50840746a7c4a9df4115484903bf67f0aa824cc14d"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectLogicalAncestorDatasource.didEvaluateTokens (cognitive 23): PhabricatorProjectLogicalAncestorDatasource.didEvaluateTokens has cognitive complexity 23 (threshold 15). Drivers by points: if/else 6 (13 pts), loops 5 (9 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/typeahead/PhabricatorProjectLogicalAncestorDatasource.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"6a6e252334d944727b7d26e71d6417d55b544da184bc2760ef3c5b77a92953dd"}},{"ruleId":"D2","level":"warning","message":{"text":"ProjectBoardTaskCard.getItem (cognitive 23): ProjectBoardTaskCard.getItem has cognitive complexity 23 (threshold 15). Drivers by points: if/else 13 (19 pts), loops 1 (3 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/view/ProjectBoardTaskCard.php"},"region":{"startLine":83}}}],"partialFingerprints":{"codehealthFindingId/v1":"1a320d925d2da5d847cc2f5c710bb5073850f035e0057d27e76c86dfbe2407b1"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryManagementRebuildIdentitiesWorkflow.rebuildIdentities (cognitive 23): PhabricatorRepositoryManagementRebuildIdentitiesWorkflow.rebuildIdentities has cognitive complexity 23 (threshold 15). Drivers by points: if/else 9 (21 pts), boolean chains 1, loops 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/management/PhabricatorRepositoryManagementRebuildIdentitiesWorkflow.php"},"region":{"startLine":330}}}],"partialFingerprints":{"codehealthFindingId/v1":"fc8de8c5e4dcb8f9546e9681e3a3d70e926b0568fd970c3b9327c7b56985907a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProfileMenuItemView.newListItemView (cognitive 23): PhabricatorProfileMenuItemView.newListItemView has cognitive complexity 23 (threshold 15). Drivers by points: if/else 11 (16 pts), loops 4 (5 pts), boolean chains 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorProfileMenuItemView.php"},"region":{"startLine":138}}}],"partialFingerprints":{"codehealthFindingId/v1":"9be059424a5b398b828bac658bdb4c504d26c72550f389a178e25555447fcc73"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorDestructionEngine.destroyObject (cognitive 23): PhabricatorDestructionEngine.destroyObject has cognitive complexity 23 (threshold 15). Drivers by points: if/else 10 (14 pts), loops 3 (7 pts), error handling 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/system/engine/PhabricatorDestructionEngine.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"9da111afd36132b6a3393132452698ba937223f22ff95c8653eb8306a6ea5477"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransactionEditor.getTransactionOldValue (cognitive 23): PhabricatorApplicationTransactionEditor.getTransactionOldValue has cognitive complexity 23 (threshold 15). Drivers by points: if/else 11 (22 pts), match/switch 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":490}}}],"partialFingerprints":{"codehealthFindingId/v1":"5a703e05256a6add35773542fc05fddcd846a48f932f69ffd1fffc5c5347aa50"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransactionEditor.applyBuiltinExternalTransaction (cognitive 23): PhabricatorApplicationTransactionEditor.applyBuiltinExternalTransaction has cognitive complexity 23 (threshold 15). Drivers by points: if/else 5 (16 pts), loops 3 (6 pts), match/switch 1 (nesting depth added 14). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":904}}}],"partialFingerprints":{"codehealthFindingId/v1":"a2c49c5336b7649b0da4742b93791eab1b20a2cc3ea53c62e627904e653ee2e3"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransactionEditor.expandRemarkupBlockTransactions (cognitive 23): PhabricatorApplicationTransactionEditor.expandRemarkupBlockTransactions has cognitive complexity 23 (threshold 15). Drivers by points: if/else 8 (18 pts), loops 2 (4 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":2348}}}],"partialFingerprints":{"codehealthFindingId/v1":"4bb0ea628d74988e881a65815d85b6b32b6f3fac8309ca2f078dca3a3afc040b"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransactionEditor.validateFileTransactions (cognitive 23): PhabricatorApplicationTransactionEditor.validateFileTransactions has cognitive complexity 23 (threshold 15). Drivers by points: if/else 8 (16 pts), loops 4 (6 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":2942}}}],"partialFingerprints":{"codehealthFindingId/v1":"d39ea41873a90abf55aa55af46ac401925e29f1c417c579e51d82cfdab6cbd38"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransactionEditor.applyProjectConflictRules (cognitive 23): PhabricatorApplicationTransactionEditor.applyProjectConflictRules has cognitive complexity 23 (threshold 15). Drivers by points: if/else 8 (17 pts), loops 4 (6 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":4755}}}],"partialFingerprints":{"codehealthFindingId/v1":"8f5c56a60be3b275ec1625d447c20a8a7af75a1839f3a6c625e72934acbe5ef2"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCustomField.buildFieldList (cognitive 23): PhabricatorCustomField.buildFieldList has cognitive complexity 23 (threshold 15). Drivers by points: if/else 7 (17 pts), loops 4 (6 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/customfield/field/PhabricatorCustomField.php"},"region":{"startLine":125}}}],"partialFingerprints":{"codehealthFindingId/v1":"9eef6d0c28cd3fe54d297dd90271eee9468cbfd4b7f9788c28289248c8445fdc"}},{"ruleId":"D2","level":"warning","message":{"text":"qsprintf.qsprintf_check_scalar_type (cognitive 23): qsprintf.qsprintf_check_scalar_type has cognitive complexity 23 (threshold 15). Drivers by points: if/else 10 (20 pts), boolean chains 2, match/switch 1 (nesting depth added 10). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/xsprintf/qsprintf.php"},"region":{"startLine":398}}}],"partialFingerprints":{"codehealthFindingId/v1":"963ca0557f014700868e8972df3397b548718b50bb0297f8bda0be507b6c3327"}},{"ruleId":"D2","level":"warning","message":{"text":"_onmove (cognitive 23): _onmove has cognitive complexity 23 (threshold 15). Drivers by points: if/else 13 (20 pts), boolean chains 2, loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/DraggableList.js"},"region":{"startLine":486}}}],"partialFingerprints":{"codehealthFindingId/v1":"c4d9d9d4e9a77bcff873a41f5e4d16c5eac121b443950623fa6de19b575f52ae"}},{"ruleId":"D2","level":"warning","message":{"text":"_redrawBanner (cognitive 23): _redrawBanner has cognitive complexity 23 (threshold 15). Drivers by points: if/else 16 (20 pts), boolean chains 2, loops 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":1817}}}],"partialFingerprints":{"codehealthFindingId/v1":"dca8a2265e133b20525260045f73c45e26a43f19677bcb58b10019bf60f1a266"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorAuthOneTimeLoginController.handleRequest (cognitive 22): PhabricatorAuthOneTimeLoginController.handleRequest has cognitive complexity 22 (threshold 15). Drivers by points: if/else 13 (18 pts), boolean chains 2, loops 1, match/switch 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthOneTimeLoginController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"777ca136122ebe27be314ca83abc04c3a7ec7b59079820460fcce23035b011f2"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorAuthSSHKeyEditor.validateTransaction (cognitive 22): PhabricatorAuthSSHKeyEditor.validateTransaction has cognitive complexity 22 (threshold 15). Drivers by points: if/else 5 (12 pts), loops 2 (5 pts), error handling 1 (4 pts), match/switch 1 (nesting depth added 13). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/editor/PhabricatorAuthSSHKeyEditor.php"},"region":{"startLine":101}}}],"partialFingerprints":{"codehealthFindingId/v1":"ac9b90c960104f724d9318e11254f6251baf8412a54074858d63fb2d3f2dbcba"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorAuthSSHPrivateKey.newBarePrivateKey (cognitive 22): PhabricatorAuthSSHPrivateKey.newBarePrivateKey has cognitive complexity 22 (threshold 15). Drivers by points: if/else 16 (21 pts), loops 1 (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/sshkey/PhabricatorAuthSSHPrivateKey.php"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"1a350364a8b067b478c775ad23410b482374d9ccf32a1f5f4528c10b2b31c0a3"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCalendarEventQuery.buildWhereClauseParts (cognitive 22): PhabricatorCalendarEventQuery.buildWhereClauseParts has cognitive complexity 22 (threshold 15). Drivers by points: if/else 19 (20 pts), loops 1 (2 pts) (nesting depth added 2). To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/query/PhabricatorCalendarEventQuery.php"},"region":{"startLine":357}}}],"partialFingerprints":{"codehealthFindingId/v1":"bf6f1bd22f67cc04947b1f5821387c3e761c8f453d5f362a881cbda149e3c8c7"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorDashboardQueryPanelInstallController.handleRequest (cognitive 22): PhabricatorDashboardQueryPanelInstallController.handleRequest has cognitive complexity 22 (threshold 15). Drivers by points: if/else 14 (22 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"6325cd80a403fd077f6058d608a694011fa55427ad564328ad97058eec0375d2"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialCreateInlineConduitAPIMethod.execute (cognitive 22): DifferentialCreateInlineConduitAPIMethod.execute has cognitive complexity 22 (threshold 15). Drivers by points: if/else 12 (20 pts), boolean chains 1, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/conduit/DifferentialCreateInlineConduitAPIMethod.php"},"region":{"startLine":45}}}],"partialFingerprints":{"codehealthFindingId/v1":"5c009a748068a72429ff1a5a8ee5a38b064f409c030a8b0dc16eb243965f9cea"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialTransactionEditor.expandCustomRemarkupBlockTransactions (cognitive 22): DifferentialTransactionEditor.expandCustomRemarkupBlockTransactions has cognitive complexity 22 (threshold 15). Drivers by points: if/else 8 (11 pts), loops 8 (11 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/editor/DifferentialTransactionEditor.php"},"region":{"startLine":807}}}],"partialFingerprints":{"codehealthFindingId/v1":"1c5b859781dce3c23578523612e6d33369ce75937cb8b989910a69d431c09c3b"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialInlineCommentMailView.buildMailSection (cognitive 22): DifferentialInlineCommentMailView.buildMailSection has cognitive complexity 22 (threshold 15). Drivers by points: if/else 7 (18 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/mail/DifferentialInlineCommentMailView.php"},"region":{"startLine":29}}}],"partialFingerprints":{"codehealthFindingId/v1":"dc2b91c11fbe294183cccc86f0ce8057244fb79f665eedc3e5a81fc214030909"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialChangesetDetailView.render (cognitive 22): DifferentialChangesetDetailView.render has cognitive complexity 22 (threshold 15). Drivers by points: if/else 16 (22 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/view/DifferentialChangesetDetailView.php"},"region":{"startLine":105}}}],"partialFingerprints":{"codehealthFindingId/v1":"6e72311b624d935ee6b8f29dcdf0df586552c7fa54ad96a5d8b8e803139d42ac"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialTransactionView.renderTransactionContent (cognitive 22): DifferentialTransactionView.renderTransactionContent has cognitive complexity 22 (threshold 15). Drivers by points: if/else 8 (14 pts), loops 3 (6 pts), match/switch 1 (2 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/view/DifferentialTransactionView.php"},"region":{"startLine":82}}}],"partialFingerprints":{"codehealthFindingId/v1":"bfeb82a3e02f3a579fd57e14e563e1ba6b51c36a5367ec5a5d76f837c1374ac0"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionLintSaveRunner.runArcLint (cognitive 22): DiffusionLintSaveRunner.runArcLint has cognitive complexity 22 (threshold 15). Drivers by points: if/else 4 (11 pts), loops 3 (6 pts), error handling 2 (3 pts), boolean chains 2 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/DiffusionLintSaveRunner.php"},"region":{"startLine":157}}}],"partialFingerprints":{"codehealthFindingId/v1":"cbd71dd2ae33702041b157741928bf88c5a690aa25a9addc89fb365041370dc2"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionSubversionServeSSHWorkflow.willWriteMessageCallback (cognitive 22): DiffusionSubversionServeSSHWorkflow.willWriteMessageCallback has cognitive complexity 22 (threshold 15). Drivers by points: if/else 6 (16 pts), match/switch 1 (4 pts), boolean chains 1, loops 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/ssh/DiffusionSubversionServeSSHWorkflow.php"},"region":{"startLine":197}}}],"partialFingerprints":{"codehealthFindingId/v1":"bc93b023984d9a678cc5a47f76c3d9b2729b3787141e610e9780b97d602923d1"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionPushLogListView.render (cognitive 22): DiffusionPushLogListView.render has cognitive complexity 22 (threshold 15). Drivers by points: if/else 10 (18 pts), loops 3 (4 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/view/DiffusionPushLogListView.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"d44b5213189a519c6dba9c8c01db327afd68605f6ab9051faa1fdd6b10537ba9"}},{"ruleId":"D2","level":"warning","message":{"text":"DoorkeeperBridgeGitHubUser.pullRefs (cognitive 22): DoorkeeperBridgeGitHubUser.pullRefs has cognitive complexity 22 (threshold 15). Drivers by points: if/else 8 (15 pts), loops 3, boolean chains 2, error handling 1 (2 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubUser.php"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"bdbf0ef8a0468e47a4b5c431acc7f7351462cece2cd0d6cd90b6c82544658649"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorFileDataController.handleRequest (cognitive 22): PhabricatorFileDataController.handleRequest has cognitive complexity 22 (threshold 15). Drivers by points: if/else 13 (15 pts), boolean chains 7 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/controller/PhabricatorFileDataController.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"100923cc9209aba5a39146c500222bf05f44e2b45c6582c0f8e5b452aaa5e5ca"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorEmbedFileRemarkupRule.renderImageFile (cognitive 22): PhabricatorEmbedFileRemarkupRule.renderImageFile has cognitive complexity 22 (threshold 15). Drivers by points: if/else 9 (14 pts), match/switch 3 (5 pts), boolean chains 2, ternaries 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php"},"region":{"startLine":129}}}],"partialFingerprints":{"codehealthFindingId/v1":"bb34a4ef64c3b7df9a2d867b8a85258b050636a3a66a34d2994edf3b8b7eccff"}},{"ruleId":"D2","level":"warning","message":{"text":"ManiphestEditEngine.getColumnMap (cognitive 22): ManiphestEditEngine.getColumnMap has cognitive complexity 22 (threshold 15). Drivers by points: if/else 8 (18 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/editor/ManiphestEditEngine.php"},"region":{"startLine":466}}}],"partialFingerprints":{"codehealthFindingId/v1":"56f610a13d8c8f22be38953a79fe0d1455f56d260782bd63f849e5a0fcd82213"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMetaMTAMail.sendWithMailers (cognitive 22): PhabricatorMetaMTAMail.sendWithMailers has cognitive complexity 22 (threshold 15). Drivers by points: if/else 8 (11 pts), error handling 3 (6 pts), loops 4 (5 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/storage/PhabricatorMetaMTAMail.php"},"region":{"startLine":674}}}],"partialFingerprints":{"codehealthFindingId/v1":"43e11d5b807cd5787396831c334c25c89cf694686c23b0ca02c25934564d3210"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorPasteRemarkupRule.renderObjectEmbed (cognitive 22): PhabricatorPasteRemarkupRule.renderObjectEmbed has cognitive complexity 22 (threshold 15). Drivers by points: if/else 5 (15 pts), loops 2 (7 pts) (nesting depth added 15). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/paste/remarkup/PhabricatorPasteRemarkupRule.php"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"9f72e596d9aae972deb20f5e4a88e863fe24875c359ecd7d80c931b324284038"}},{"ruleId":"D2","level":"warning","message":{"text":"PhameBlogQuery.didFilterPage (cognitive 22): PhameBlogQuery.didFilterPage has cognitive complexity 22 (threshold 15). Drivers by points: if/else 9 (18 pts), loops 2 (4 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/query/PhameBlogQuery.php"},"region":{"startLine":82}}}],"partialFingerprints":{"codehealthFindingId/v1":"97032ed07188528f41d48902761d029a6d0f1b441781b811607db393ce01e2a2"}},{"ruleId":"D2","level":"warning","message":{"text":"PhortuneMerchantInvoiceCreateController.handleMerchantRequest (cognitive 22): PhortuneMerchantInvoiceCreateController.handleMerchantRequest has cognitive complexity 22 (threshold 15). Drivers by points: if/else 13 (18 pts), error handling 1 (3 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/merchant/PhortuneMerchantInvoiceCreateController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"543e062e87b0903a210f035e63e9278fb21bb2c001fbd380e67679c461462014"}},{"ruleId":"D2","level":"warning","message":{"text":"PhortuneOrderSummaryView.newMessagesView (cognitive 22): PhortuneOrderSummaryView.newMessagesView has cognitive complexity 22 (threshold 15). Drivers by points: if/else 12 (21 pts), match/switch 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/view/PhortuneOrderSummaryView.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"59fe6d10402ee1f2336db0f922f1a45b2166a7bd695275e3cc448ddd33a0dedf"}},{"ruleId":"D2","level":"warning","message":{"text":"PhortuneOrderTableView.render (cognitive 22): PhortuneOrderTableView.render has cognitive complexity 22 (threshold 15). Drivers by points: if/else 8 (13 pts), loops 4 (6 pts), boolean chains 2, ternaries 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/view/PhortuneOrderTableView.php"},"region":{"startLine":56}}}],"partialFingerprints":{"codehealthFindingId/v1":"d054ddced14546937acc935b5bbf45ecb9cd636b12891843f416faa3308013bb"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectHeraldAction.applyProjects (cognitive 22): PhabricatorProjectHeraldAction.applyProjects has cognitive complexity 22 (threshold 15). Drivers by points: if/else 12 (18 pts), loops 2 (4 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/herald/PhabricatorProjectHeraldAction.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"31f76f3ad6803dcbe1add827cab5423296718b1e34b344b83807dd70600b7882"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryManagementClusterizeWorkflow.execute (cognitive 22): PhabricatorRepositoryManagementClusterizeWorkflow.execute has cognitive complexity 22 (threshold 15). Drivers by points: if/else 12 (17 pts), loops 2 (3 pts), boolean chains 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/management/PhabricatorRepositoryManagementClusterizeWorkflow.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"1d2ec2706dc120af49660697b93924a01fdb3327ef24d9f8c1fffd764071f9ca"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryCommitPublishWorker.shouldTriggerAudit (cognitive 22): PhabricatorRepositoryCommitPublishWorker.shouldTriggerAudit has cognitive complexity 22 (threshold 15). Drivers by points: if/else 9 (21 pts), match/switch 1 (nesting depth added 12). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/PhabricatorRepositoryCommitPublishWorker.php"},"region":{"startLine":229}}}],"partialFingerprints":{"codehealthFindingId/v1":"320daa3079d3a45586f7d37aee4046aefd2e1c4fe9559a10dafb81bff791cb2a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorSearchEditController.handleRequest (cognitive 22): PhabricatorSearchEditController.handleRequest has cognitive complexity 22 (threshold 15). Drivers by points: if/else 15 (21 pts), boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/controller/PhabricatorSearchEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"5b5c786a7629e6e15fdd5d427c5df7c05b8563a766b95af474124a9938107d1b"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorFerretFulltextEngineExtension.updateStoredNgrams (cognitive 22): PhabricatorFerretFulltextEngineExtension.updateStoredNgrams has cognitive complexity 22 (threshold 15). Drivers by points: if/else 8 (12 pts), loops 6 (10 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engineextension/PhabricatorFerretFulltextEngineExtension.php"},"region":{"startLine":341}}}],"partialFingerprints":{"codehealthFindingId/v1":"69a6cab188b49e94cc2ff418a3cc435e9bb14ec370fda2e68555016935a7f797"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorSearchManagementIndexWorkflow.getIndexableObjectsByTypes (cognitive 22): PhabricatorSearchManagementIndexWorkflow.getIndexableObjectsByTypes has cognitive complexity 22 (threshold 15). Drivers by points: if/else 7 (16 pts), loops 5 (6 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php"},"region":{"startLine":317}}}],"partialFingerprints":{"codehealthFindingId/v1":"5421c4eaf08a2fb89786f325fe7a3faffe85e2b809dec094458c755e5c40b5fe"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorSettingsMainController.buildPanels (cognitive 22): PhabricatorSettingsMainController.buildPanels has cognitive complexity 22 (threshold 15). Drivers by points: if/else 9 (19 pts), boolean chains 2, loops 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/settings/controller/PhabricatorSettingsMainController.php"},"region":{"startLine":139}}}],"partialFingerprints":{"codehealthFindingId/v1":"276eb669779cfd145fc5883b4d7b4a778abbf35be80454d7148101bf30c60a31"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorWorkerTriggerQuery.loadPage (cognitive 22): PhabricatorWorkerTriggerQuery.loadPage has cognitive complexity 22 (threshold 15). Drivers by points: if/else 4 (9 pts), loops 3 (7 pts), error handling 2 (6 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php"},"region":{"startLine":80}}}],"partialFingerprints":{"codehealthFindingId/v1":"9465ba7672851dad3519a7bee0d64affb30df87a2d989cf9bd62566c3f3b3e80"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilProseDiff.reorderParts (cognitive 22): PhutilProseDiff.reorderParts has cognitive complexity 22 (threshold 15). Drivers by points: if/else 5 (10 pts), loops 4 (8 pts), boolean chains 2, match/switch 1 (2 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/prose/PhutilProseDiff.php"},"region":{"startLine":79}}}],"partialFingerprints":{"codehealthFindingId/v1":"a44522e622f4b80060ce49839de4085a9feb97b0bb7cfe7af670b74f459daaf1"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorDiffInlineCommentQuery.loadInlineCommentContext (cognitive 22): PhabricatorDiffInlineCommentQuery.loadInlineCommentContext has cognitive complexity 22 (threshold 15). Drivers by points: if/else 8 (17 pts), loops 4 (5 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/query/PhabricatorDiffInlineCommentQuery.php"},"region":{"startLine":281}}}],"partialFingerprints":{"codehealthFindingId/v1":"3d269590e751f26168f31c40f81dbfabd87479b03b5c62110cb945fa8a836a1d"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorChangesetViewStateEngine.updateHiddenState (cognitive 22): PhabricatorChangesetViewStateEngine.updateHiddenState has cognitive complexity 22 (threshold 15). Drivers by points: if/else 9 (22 pts) (nesting depth added 13). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/viewstate/PhabricatorChangesetViewStateEngine.php"},"region":{"startLine":189}}}],"partialFingerprints":{"codehealthFindingId/v1":"f7803bb63408254a831eb4dbb6c069a1906018f1ee7daa635689ec74715c4d82"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilRemarkupQuotedBlockRule.normalizeQuotedBody (cognitive 22): PhutilRemarkupQuotedBlockRule.normalizeQuotedBody has cognitive complexity 22 (threshold 15). Drivers by points: if/else 8 (16 pts), loops 4 (5 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/blockrule/PhutilRemarkupQuotedBlockRule.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"1850b33501599292d6980e15b825520b9dc736e81aa1e93292afbb0c345065f0"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorNavigationRemarkupRule.markupNavigation (cognitive 22): PhabricatorNavigationRemarkupRule.markupNavigation has cognitive complexity 22 (threshold 15). Drivers by points: if/else 12 (20 pts), loops 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/rule/PhabricatorNavigationRemarkupRule.php"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"62228aab75f6817db2d9c9d363b06d433194d6532be617c265d0d334c252071b"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCursorPagedPolicyAwareQuery.formatOrderClause (cognitive 22): PhabricatorCursorPagedPolicyAwareQuery.formatOrderClause has cognitive complexity 22 (threshold 15). Drivers by points: if/else 10 (18 pts), match/switch 1 (3 pts), loops 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php"},"region":{"startLine":1270}}}],"partialFingerprints":{"codehealthFindingId/v1":"f3edef59d497aecd300f78b94fc5de01813e04cba8fe167982219fb40f43e051"}},{"ruleId":"D2","level":"warning","message":{"text":"LiskDAO.getSchemaColumns (cognitive 22): LiskDAO.getSchemaColumns has cognitive complexity 22 (threshold 15). Drivers by points: if/else 12 (21 pts), loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/lisk/LiskDAO.php"},"region":{"startLine":1741}}}],"partialFingerprints":{"codehealthFindingId/v1":"b79db1f17f4b7d365dffe44fba93f0ce274bc1b62fd0b69a9d6c6aa5d3efc6e9"}},{"ruleId":"D2","level":"warning","message":{"text":"PHUIObjectItemView.getTagAttributes (cognitive 22): PHUIObjectItemView.getTagAttributes has cognitive complexity 22 (threshold 15). Drivers by points: if/else 18 (20 pts), boolean chains 1, match/switch 1 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIObjectItemView.php"},"region":{"startLine":287}}}],"partialFingerprints":{"codehealthFindingId/v1":"f248e340ead37f5baf1e29f3a039434ad2f649f25277deed69e4da9773a94221"}},{"ruleId":"D2","level":"warning","message":{"text":"AphrontStackTraceView.render (cognitive 22): AphrontStackTraceView.render has cognitive complexity 22 (threshold 15). Drivers by points: if/else 8 (18 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/widget/AphrontStackTraceView.php"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"bede8db5ce966ddd94cb698cf2fed7c6192dff4faf234c8dfe338a4c88f291c4"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-phabricator-remarkup-assist.JX.behavior(\u0022phabricator-remarkup-assist\u0022)::assist (cognitive 22): behavior-phabricator-remarkup-assist.JX.behavior(\u0022phabricator-remarkup-assist\u0022)::assist has cognitive complexity 22 (threshold 15). Drivers by points: if/else 6 (9 pts), boolean chains 6, ternaries 3 (6 pts), match/switch 1 (nesting depth added 6). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js"},"region":{"startLine":188}}}],"partialFingerprints":{"codehealthFindingId/v1":"620f2525785048fb0d5350002af7a93fb80e626cf27d7c2e3116ca5176dca23a"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-time-typeahead.JX.behavior(\u0022time-typeahead\u0022)::getNewValue (cognitive 22): behavior-time-typeahead.JX.behavior(\u0022time-typeahead\u0022)::getNewValue has cognitive complexity 22 (threshold 15). Drivers by points: if/else 13 (18 pts), boolean chains 3, ternaries 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-time-typeahead.js"},"region":{"startLine":82}}}],"partialFingerprints":{"codehealthFindingId/v1":"02f7c8c4708d8a7582b2c53402a9b80b312466f02b7036bb3b8b3d8fe0fa8eae"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous)::getNewValue (cognitive 22): (anonymous)::getNewValue has cognitive complexity 22 (threshold 15). Drivers by points: if/else 13 (18 pts), boolean chains 3, ternaries 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-time-typeahead.js"},"region":{"startLine":82}}}],"partialFingerprints":{"codehealthFindingId/v1":"dcaf69bb023c5a461020ed1b94864da24439693a44f66ed69348cef0e002b417"}},{"ruleId":"D2","level":"warning","message":{"text":"redraw (cognitive 22): redraw has cognitive complexity 22 (threshold 15). Drivers by points: if/else 5 (13 pts), loops 5 (9 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/projects/WorkboardColumn.js"},"region":{"startLine":210}}}],"partialFingerprints":{"codehealthFindingId/v1":"bcb03fbca9d17f208b809a82f8b5e0c776bb089450c4b61c42c89b90b395bd43"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorExternalAccountQuery.willFilterPage (cognitive 21): PhabricatorExternalAccountQuery.willFilterPage has cognitive complexity 21 (threshold 15). Drivers by points: if/else 8 (15 pts), loops 3 (5 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/query/PhabricatorExternalAccountQuery.php"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"d13358c897e13f8ef5ecfe8dc5e83104f72d73ea816ae091d32bd55291732ec5"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCalendarEventEditController.handleRequest (cognitive 21): PhabricatorCalendarEventEditController.handleRequest has cognitive complexity 21 (threshold 15). Drivers by points: if/else 9 (21 pts) (nesting depth added 12). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/controller/PhabricatorCalendarEventEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"25866b00f9eb082c6c3067bcc972243c9fdbea211655243244a800d091f88657"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCalendarEventEditor.validateAllTransactions (cognitive 21): PhabricatorCalendarEventEditor.validateAllTransactions has cognitive complexity 21 (threshold 15). Drivers by points: if/else 9 (19 pts), boolean chains 1, loops 1 (nesting depth added 10). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/editor/PhabricatorCalendarEventEditor.php"},"region":{"startLine":188}}}],"partialFingerprints":{"codehealthFindingId/v1":"a3752dd3d3e21e19797f6985307940d95e02f5d63436cb540aa292a23a98b3ad"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorChatLogChannelLogController.handleRequest (cognitive 21): PhabricatorChatLogChannelLogController.handleRequest has cognitive complexity 21 (threshold 15). Drivers by points: if/else 10 (15 pts), loops 3, ternaries 1 (2 pts), boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"3c0179cc49033ae6fd466bc05b0cb59fab1ea73b3e95b16d1e6fe86c286b8687"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialRevisionQuery.loadReviewers (cognitive 21): DifferentialRevisionQuery.loadReviewers has cognitive complexity 21 (threshold 15). Drivers by points: if/else 6 (15 pts), loops 3 (4 pts), boolean chains 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/query/DifferentialRevisionQuery.php"},"region":{"startLine":956}}}],"partialFingerprints":{"codehealthFindingId/v1":"81e96e3c79db90379e8d27bd2921385ce2e9645f587e11b1a5a9946b595aded9"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionRepositoryBasicsManagementPanel.buildStateView (cognitive 21): DiffusionRepositoryBasicsManagementPanel.buildStateView has cognitive complexity 21 (threshold 15). Drivers by points: if/else 14 (21 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php"},"region":{"startLine":745}}}],"partialFingerprints":{"codehealthFindingId/v1":"037f1086ee188276e1a134a776a19788708e673e77afe372112bb099593be0c8"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionSubversionServeSSHWorkflow.identifyRepository (cognitive 21): DiffusionSubversionServeSSHWorkflow.identifyRepository has cognitive complexity 21 (threshold 15). Drivers by points: if/else 8 (19 pts), loops 2 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/ssh/DiffusionSubversionServeSSHWorkflow.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"4c4da7d34ac211194d8dcc40703882ca0af79741ca323be26ba5fae10f418de4"}},{"ruleId":"D2","level":"warning","message":{"text":"DivinerPHPAtomizer.parseReturnType (cognitive 21): DivinerPHPAtomizer.parseReturnType has cognitive complexity 21 (threshold 15). Drivers by points: if/else 11 (20 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/atomizer/DivinerPHPAtomizer.php"},"region":{"startLine":266}}}],"partialFingerprints":{"codehealthFindingId/v1":"00a52bd1db94b05d5e9abf76b0759d8e10368f57dd54b61d892fe21a409d27e2"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorFaviconRef.newTemplateFile (cognitive 21): PhabricatorFaviconRef.newTemplateFile has cognitive complexity 21 (threshold 15). Drivers by points: if/else 13 (20 pts), loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/favicon/PhabricatorFaviconRef.php"},"region":{"startLine":344}}}],"partialFingerprints":{"codehealthFindingId/v1":"4979f5f0f6fb94c0f0b0846611afa93a2e8728fac34c670fd2935623fa1dd728"}},{"ruleId":"D2","level":"warning","message":{"text":"ManiphestTaskListView.render (cognitive 21): ManiphestTaskListView.render has cognitive complexity 21 (threshold 15). Drivers by points: if/else 11 (19 pts), boolean chains 1, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/view/ManiphestTaskListView.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"2ee641deb9abad40b39548c50b0e35696111281d9a495e300f1d0cb37fd7cde6"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMailManagementVolumeWorkflow.execute (cognitive 21): PhabricatorMailManagementVolumeWorkflow.execute has cognitive complexity 21 (threshold 15). Drivers by points: if/else 5 (14 pts), loops 4 (7 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/management/PhabricatorMailManagementVolumeWorkflow.php"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"0348830068eca0a5e0ac1b5a0a7af76ac575fb05f1c97efd519ed022cecfa4cb"}},{"ruleId":"D2","level":"warning","message":{"text":"NuanceSourceQuery.buildWhereClauseParts (cognitive 21): NuanceSourceQuery.buildWhereClauseParts has cognitive complexity 21 (threshold 15). Drivers by points: if/else 12 (19 pts), loops 1 (2 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/query/NuanceSourceQuery.php"},"region":{"startLine":68}}}],"partialFingerprints":{"codehealthFindingId/v1":"fe4a7676faface0ea9fe3c2986576596c9ddc2d882fdd245278b156ceecebfe5"}},{"ruleId":"D2","level":"warning","message":{"text":"PhameLiveController.buildApplicationCrumbs (cognitive 21): PhameLiveController.buildApplicationCrumbs has cognitive complexity 21 (threshold 15). Drivers by points: if/else 12 (20 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/PhameLiveController.php"},"region":{"startLine":155}}}],"partialFingerprints":{"codehealthFindingId/v1":"23416c7a6729bedcf4358908002bc3d09218bdb6eea4394fe29bc5462f68498c"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorHandleQuery.loadPage (cognitive 21): PhabricatorHandleQuery.loadPage has cognitive complexity 21 (threshold 15). Drivers by points: if/else 7 (17 pts), loops 3 (4 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phid/query/PhabricatorHandleQuery.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"5b9e92df69b8d1e737cb7c792f171651eaa9fb2c55fb40280039ffca5912b26e"}},{"ruleId":"D2","level":"warning","message":{"text":"PhortuneCartCheckoutController.handleCartRequest (cognitive 21): PhortuneCartCheckoutController.handleCartRequest has cognitive complexity 21 (threshold 15). Drivers by points: if/else 9 (12 pts), loops 2 (4 pts), error handling 1 (3 pts), boolean chains 1, match/switch 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/cart/PhortuneCartCheckoutController.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"d9530e174fedb061fdd05496ca659e59f830ebe25c31acd3bc7213409fb4f48a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectTransactionEditor.validateAllTransactions (cognitive 21): PhabricatorProjectTransactionEditor.validateAllTransactions has cognitive complexity 21 (threshold 15). Drivers by points: if/else 5 (15 pts), match/switch 2 (4 pts), loops 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/editor/PhabricatorProjectTransactionEditor.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"3631df3ebcacaa1da0268c2371b10d568155631dfd17a72217729ffb9952fe74"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorBoardResponseEngine.buildResponse (cognitive 21): PhabricatorBoardResponseEngine.buildResponse has cognitive complexity 21 (threshold 15). Drivers by points: if/else 10 (17 pts), loops 4 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/engine/PhabricatorBoardResponseEngine.php"},"region":{"startLine":76}}}],"partialFingerprints":{"codehealthFindingId/v1":"3590e564daa0a85bedf98cfb4dc31db261225203c8966d6b98100d9658de7863"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectPointsProfileMenuItem.newMenuItemViewList (cognitive 21): PhabricatorProjectPointsProfileMenuItem.newMenuItemViewList has cognitive complexity 21 (threshold 15). Drivers by points: if/else 12 (19 pts), loops 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/menuitem/PhabricatorProjectPointsProfileMenuItem.php"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"8a76ea3e61b6ca8877bf5138305bac93ca13cc122eef37b254e01e48d0bbe9af"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorSearchManagementNgramsWorkflow.execute (cognitive 21): PhabricatorSearchManagementNgramsWorkflow.execute has cognitive complexity 21 (threshold 15). Drivers by points: if/else 8 (13 pts), loops 3 (5 pts), boolean chains 3 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/management/PhabricatorSearchManagementNgramsWorkflow.php"},"region":{"startLine":29}}}],"partialFingerprints":{"codehealthFindingId/v1":"2ea98cb938167a8abda83247bf6c6f5d0ce420eac0b033b19b6d1f375a8e6be8"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransactionEditor.validateEditParameters (cognitive 21): PhabricatorApplicationTransactionEditor.validateEditParameters has cognitive complexity 21 (threshold 15). Drivers by points: if/else 9 (17 pts), boolean chains 3, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":1756}}}],"partialFingerprints":{"codehealthFindingId/v1":"cced05504ea12e29a264cdc09bb94dcfae9070f28e2df272857866562e586be2"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationEditHTTPParameterHelpView.render (cognitive 21): PhabricatorApplicationEditHTTPParameterHelpView.render has cognitive complexity 21 (threshold 15). Drivers by points: if/else 6 (12 pts), loops 6 (7 pts), ternaries 1 (2 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/view/PhabricatorApplicationEditHTTPParameterHelpView.php"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"41d00cdecca1f898328c28ff3d3be7c6efc94536cd329964710472a2c49fca9a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCustomFieldList.appendFieldsToPropertyList (cognitive 21): PhabricatorCustomFieldList.appendFieldsToPropertyList has cognitive complexity 21 (threshold 15). Drivers by points: if/else 5 (12 pts), match/switch 2 (5 pts), loops 4 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/customfield/field/PhabricatorCustomFieldList.php"},"region":{"startLine":100}}}],"partialFingerprints":{"codehealthFindingId/v1":"774bad3d8e3872d7b83f322a4d63aacb0c42ad0de48551230c90963b868f17de"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilRemarkupCodeBlockRule.getMatchingLineCount (cognitive 21): PhutilRemarkupCodeBlockRule.getMatchingLineCount has cognitive complexity 21 (threshold 15). Drivers by points: if/else 10 (19 pts), boolean chains 1, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/blockrule/PhutilRemarkupCodeBlockRule.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"a830c783c8b7768fab9afe89c048cad6233bc40380717c7239477deb48c21a4c"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorStorageManagementDestroyWorkflow.didExecute (cognitive 21): PhabricatorStorageManagementDestroyWorkflow.didExecute has cognitive complexity 21 (threshold 15). Drivers by points: if/else 11 (19 pts), boolean chains 1, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDestroyWorkflow.php"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"14d1ad35fac5c4a0dd0566ceae790f2934c7bba36ce8cfea4cd9522f90adb943"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorGlobalLock.newHint (cognitive 21): PhabricatorGlobalLock.newHint has cognitive complexity 21 (threshold 15). Drivers by points: if/else 13 (21 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/util/PhabricatorGlobalLock.php"},"region":{"startLine":331}}}],"partialFingerprints":{"codehealthFindingId/v1":"4091ee9af064cdb67df498c0720cf0300f87977d6bd7dd05f1916d55d9aa219f"}},{"ruleId":"D2","level":"warning","message":{"text":"AphrontFormDateControl.getTimeTypeaheadValues (cognitive 21): AphrontFormDateControl.getTimeTypeaheadValues has cognitive complexity 21 (threshold 15). Drivers by points: loops 4 (9 pts), ternaries 2 (8 pts), if/else 3 (4 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/form/control/AphrontFormDateControl.php"},"region":{"startLine":346}}}],"partialFingerprints":{"codehealthFindingId/v1":"86be5a561a985a6c27ccbb7a4cf409c0a3b60a14b9e4f08dd0711ff8d8a08c73"}},{"ruleId":"D2","level":"warning","message":{"text":"AphrontFormPolicyControl.getOptions (cognitive 21): AphrontFormPolicyControl.getOptions has cognitive complexity 21 (threshold 15). Drivers by points: if/else 10 (17 pts), boolean chains 2, loops 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/form/control/AphrontFormPolicyControl.php"},"region":{"startLine":103}}}],"partialFingerprints":{"codehealthFindingId/v1":"20c83d1825c279480e947dffedaabcab5493c217338712ecd22f25098b97bb8c"}},{"ruleId":"D2","level":"warning","message":{"text":"redrawFileTree (cognitive 21): redrawFileTree has cognitive complexity 21 (threshold 15). Drivers by points: if/else 12 (20 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangeset.js"},"region":{"startLine":860}}}],"partialFingerprints":{"codehealthFindingId/v1":"862e9f9e5b2cc47bb9b977fe778e6380001e4bc4fea68ad77afc576525ace6b6"}},{"ruleId":"D2","level":"warning","message":{"text":"_findContentCells (cognitive 21): _findContentCells has cognitive complexity 21 (threshold 15). Drivers by points: if/else 6 (17 pts), loops 3 (4 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":1490}}}],"partialFingerprints":{"codehealthFindingId/v1":"69d75b75514d56859ba52baf1acb64eccaba91873f541f687cd8f3db4814638d"}},{"ruleId":"D2","level":"warning","message":{"text":"_redrawFrame (cognitive 21): _redrawFrame has cognitive complexity 21 (threshold 15). Drivers by points: if/else 8 (14 pts), boolean chains 4, loops 3 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/projects/WorkboardColumn.js"},"region":{"startLine":394}}}],"partialFingerprints":{"codehealthFindingId/v1":"815bb40fb7e60e2c5600c8627cb3716b99a5d295e958471b893c4c2d1b9ce42b"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorElasticsearchSetupCheck.executeChecks (cognitive 20): PhabricatorElasticsearchSetupCheck.executeChecks has cognitive complexity 20 (threshold 15). Drivers by points: if/else 6 (14 pts), error handling 2 (5 pts), loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/check/PhabricatorElasticsearchSetupCheck.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"4d2ebf2ee6f5618b67b3f691e23b6fde6c1eee08cfca6a8a51ddb708ef190e5f"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMySQLSetupCheck.executeRefChecks (cognitive 20): PhabricatorMySQLSetupCheck.executeRefChecks has cognitive complexity 20 (threshold 15). Drivers by points: if/else 15 (20 pts) (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/check/PhabricatorMySQLSetupCheck.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"dcb00a2d5c9db9cb1cc90c92f6923c23ee12f87e79581acaedcabeca678a2e5b"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorConfigClusterNotificationsController.buildClusterNotificationStatus (cognitive 20): PhabricatorConfigClusterNotificationsController.buildClusterNotificationStatus has cognitive complexity 20 (threshold 15). Drivers by points: if/else 8 (13 pts), error handling 2 (6 pts), loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/services/PhabricatorConfigClusterNotificationsController.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"64368a0b365173e2248fd0279ba8eb2bb8f3034d619f005b0eff175862bd408d"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorConfigDatabaseStatusController.handleRequest (cognitive 20): PhabricatorConfigDatabaseStatusController.handleRequest has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (20 pts) (nesting depth added 11). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/services/PhabricatorConfigDatabaseStatusController.php"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"86faea4a3a98fd1b0b7dacc36ecc6bacfa02571d8340fc6c2c466f8955bebc1b"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorConfigManagementMigrateWorkflow.execute (cognitive 20): PhabricatorConfigManagementMigrateWorkflow.execute has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (17 pts), loops 2 (3 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/management/PhabricatorConfigManagementMigrateWorkflow.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"cf1da326091dd3bc8beca8b778423b7c46dd8c4280ab3effbe8c31bccbe235ac"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorSetupIssueView.renderValueForDisplay (cognitive 20): PhabricatorSetupIssueView.renderValueForDisplay has cognitive complexity 20 (threshold 15). Drivers by points: if/else 10 (20 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/view/PhabricatorSetupIssueView.php"},"region":{"startLine":554}}}],"partialFingerprints":{"codehealthFindingId/v1":"2ea7f96499e1fb290ed0adcd4065dbbde151f8779f360dc22c4496672d2a6230"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorDashboardPanelTabsController.handleAddOperation (cognitive 20): PhabricatorDashboardPanelTabsController.handleAddOperation has cognitive complexity 20 (threshold 15). Drivers by points: if/else 8 (16 pts), loops 1 (4 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/panel/PhabricatorDashboardPanelTabsController.php"},"region":{"startLine":149}}}],"partialFingerprints":{"codehealthFindingId/v1":"7706a92f8fd92edf0c0191690839fee366aa5e661efa21a84b882341cc5e7cbb"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialHarbormasterField.renderDiffPropertyViewValue (cognitive 20): DifferentialHarbormasterField.renderDiffPropertyViewValue has cognitive complexity 20 (threshold 15). Drivers by points: if/else 8 (10 pts), loops 3 (6 pts), error handling 1 (4 pts) (nesting depth added 8). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/customfield/DifferentialHarbormasterField.php"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"9a6e30d0e8f8030801bd6669a4aca24210e7bbfa804981f7a6452ac759df20d4"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialReviewersHeraldAction.applyReviewers (cognitive 20): DifferentialReviewersHeraldAction.applyReviewers has cognitive complexity 20 (threshold 15). Drivers by points: if/else 12 (17 pts), loops 3 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/herald/DifferentialReviewersHeraldAction.php"},"region":{"startLine":18}}}],"partialFingerprints":{"codehealthFindingId/v1":"87e0a0cde8aac64af30b1b0e1a173ff7e14caf8f0fdc5ac79d8a6150d3ef3257"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialCreateMailReceiver.processReceivedMail (cognitive 20): DifferentialCreateMailReceiver.processReceivedMail has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (9 pts), loops 4 (7 pts), error handling 2 (4 pts) (nesting depth added 7). To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/mail/DifferentialCreateMailReceiver.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"c2b06238d1a9738c4745489299ca9107b0bf7a7ca2f4ad1d3ffc17c035c81acb"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialChangesetParser.calculateGapsAndMask (cognitive 20): DifferentialChangesetParser.calculateGapsAndMask has cognitive complexity 20 (threshold 15). Drivers by points: if/else 6 (14 pts), loops 2 (6 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialChangesetParser.php"},"region":{"startLine":1197}}}],"partialFingerprints":{"codehealthFindingId/v1":"dfec7b6a64a7bed49521a29bc99c2374a4fc863032715986c8812af7106e047a"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialHunkParser.reparseHunksForSpecialAttributes (cognitive 20): DifferentialHunkParser.reparseHunksForSpecialAttributes has cognitive complexity 20 (threshold 15). Drivers by points: if/else 8 (16 pts), boolean chains 3, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialHunkParser.php"},"region":{"startLine":215}}}],"partialFingerprints":{"codehealthFindingId/v1":"0d59d2849f3f69d4e49c2d75b508888261a6f51a8ae514e9e94bd2d1b85d2b5c"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialChangesetHTMLRenderer.renderChangeTypeHeader (cognitive 20): DifferentialChangesetHTMLRenderer.renderChangeTypeHeader has cognitive complexity 20 (threshold 15). Drivers by points: match/switch 9 (17 pts), if/else 1 (3 pts) (nesting depth added 10). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetHTMLRenderer.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"287d0df0380704b256ed25a7f0fe81e861b5b6c2f67eb4f22bbc098427a49837"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialRevisionReviewersTransaction.validateTransactions (cognitive 20): DifferentialRevisionReviewersTransaction.validateTransactions has cognitive complexity 20 (threshold 15). Drivers by points: if/else 5 (13 pts), loops 2 (3 pts), match/switch 1 (3 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php"},"region":{"startLine":316}}}],"partialFingerprints":{"codehealthFindingId/v1":"73e1341ee47acf5f1111a1256188b25d5730c408717e69984f43f0117bb128cd"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionURIEditEngine.buildCustomEditFields (cognitive 20): DiffusionURIEditEngine.buildCustomEditFields has cognitive complexity 20 (threshold 15). Drivers by points: if/else 8 (18 pts), match/switch 1 (2 pts) (nesting depth added 11). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/editor/DiffusionURIEditEngine.php"},"region":{"startLine":83}}}],"partialFingerprints":{"codehealthFindingId/v1":"9e298591654fabd3c54a3943e97671b8b96d98f31c72d09bf928b44ce0f6bc46"}},{"ruleId":"D2","level":"warning","message":{"text":"HeraldPreCommitContentAdapter.getDiffContent (cognitive 20): HeraldPreCommitContentAdapter.getDiffContent has cognitive complexity 20 (threshold 15). Drivers by points: if/else 6 (7 pts), loops 3 (7 pts), match/switch 1 (4 pts), error handling 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"813c7520d5501707ce3897ae51e9b023049d15b80623da8711cb9e5ac228d121"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionCommitQuery.loadPage (cognitive 20): DiffusionCommitQuery.loadPage has cognitive complexity 20 (threshold 15). Drivers by points: if/else 10 (14 pts), error handling 2 (4 pts), loops 1 (2 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/DiffusionCommitQuery.php"},"region":{"startLine":207}}}],"partialFingerprints":{"codehealthFindingId/v1":"b1708f02f33ea0faba5b43188540e3aa08ec12795bc779fc9f294905890ff54e"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionPathChangeQuery.executeQuery (cognitive 20): DiffusionPathChangeQuery.executeQuery has cognitive complexity 20 (threshold 15). Drivers by points: if/else 8 (14 pts), loops 3 (5 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/pathchange/DiffusionPathChangeQuery.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"d7ec50f412a29b3c6456640746d65f0bbe17b1dd56fb79ece822b19ea1dcbef1"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionTagListView.render (cognitive 20): DiffusionTagListView.render has cognitive complexity 20 (threshold 15). Drivers by points: if/else 10 (19 pts), loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/view/DiffusionTagListView.php"},"region":{"startLine":28}}}],"partialFingerprints":{"codehealthFindingId/v1":"af85b559ce790061b6fda73ee31343b58173c631753a6df086382ce692799505"}},{"ruleId":"D2","level":"warning","message":{"text":"DoorkeeperBridgeAsana.pullRefs (cognitive 20): DoorkeeperBridgeAsana.pullRefs has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (14 pts), loops 3, error handling 1 (2 pts), boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"d0c6baf66619660efa77cc23bbbb35b02e43060be117dc8c5de23487d5448cde"}},{"ruleId":"D2","level":"warning","message":{"text":"DoorkeeperBridgeJIRA.pullRefs (cognitive 20): DoorkeeperBridgeJIRA.pullRefs has cognitive complexity 20 (threshold 15). Drivers by points: if/else 8 (14 pts), loops 3, error handling 1 (2 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/bridge/DoorkeeperBridgeJIRA.php"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"271a06289cf381437abe0e60363315964c4f9f17e4b184424ed2f7a9b8dcc606"}},{"ruleId":"D2","level":"warning","message":{"text":"DrydockWorkingCopyBlueprintImplementation.activateLease (cognitive 20): DrydockWorkingCopyBlueprintImplementation.activateLease has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (13 pts), loops 2 (4 pts), error handling 1 (3 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/blueprint/DrydockWorkingCopyBlueprintImplementation.php"},"region":{"startLine":265}}}],"partialFingerprints":{"codehealthFindingId/v1":"cbf7e56968d9497bd9312592deb911e686302ca88b39eb03fa51a46c6fb524bf"}},{"ruleId":"D2","level":"warning","message":{"text":"DrydockLogQuery.didFilterPage (cognitive 20): DrydockLogQuery.didFilterPage has cognitive complexity 20 (threshold 15). Drivers by points: if/else 12 (16 pts), loops 4 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/query/DrydockLogQuery.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"8686f4ca838dd2f36942daffd13da29eb7eb5c002a751fb06313ab7433770718"}},{"ruleId":"D2","level":"warning","message":{"text":"DrydockLogListView.render (cognitive 20): DrydockLogListView.render has cognitive complexity 20 (threshold 15). Drivers by points: if/else 12 (19 pts), loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/view/DrydockLogListView.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"10a5c4849fe61b02be93e8ed250529adc5f5bb3a43f6ddf8c628fa8c6668768a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorChartFunctionArgument.newValue (cognitive 20): PhabricatorChartFunctionArgument.newValue has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (18 pts), boolean chains 1, match/switch 1 (nesting depth added 9). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fact/chart/PhabricatorChartFunctionArgument.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"abb1caf7d6f05e4e97fb1739302631444a9abacfd8e0c3201e2dca1dc2566f21"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorDocumentEngineBlocks.newTwoUpLayout (cognitive 20): PhabricatorDocumentEngineBlocks.newTwoUpLayout has cognitive complexity 20 (threshold 15). Drivers by points: if/else 10 (17 pts), loops 2, boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/diff/PhabricatorDocumentEngineBlocks.php"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"b0d7ef9f1e6dbdf383fda0de79e4b50796d8a82e86d80c7e27e87dc595e5cbe4"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorFilesManagementCompactWorkflow.execute (cognitive 20): PhabricatorFilesManagementCompactWorkflow.execute has cognitive complexity 20 (threshold 15). Drivers by points: if/else 5 (12 pts), error handling 2 (5 pts), loops 2 (3 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/management/PhabricatorFilesManagementCompactWorkflow.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"e6cd8b8adb665c1bdfb3e792e20d5ac04cab87cde8f3be33a3a07cb7a017f71e"}},{"ruleId":"D2","level":"warning","message":{"text":"ManiphestTransactionEditor.didApplyTransactions (cognitive 20): ManiphestTransactionEditor.didApplyTransactions has cognitive complexity 20 (threshold 15). Drivers by points: if/else 4 (10 pts), loops 3 (10 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/editor/ManiphestTransactionEditor.php"},"region":{"startLine":868}}}],"partialFingerprints":{"codehealthFindingId/v1":"b07c351c15d7b2ca7d6741e95bac4b44ee4d1fda0b8770b920dcada8a610f33c"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMailReplyHandler.getMailTargets (cognitive 20): PhabricatorMailReplyHandler.getMailTargets has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (17 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php"},"region":{"startLine":206}}}],"partialFingerprints":{"codehealthFindingId/v1":"57b8c14c3ebc094ff7819f9f3727aa8a10608630298a7cf779987f4e3abec514"}},{"ruleId":"D2","level":"warning","message":{"text":"NuanceGitHubRawEvent.getURI (cognitive 20): NuanceGitHubRawEvent.getURI has cognitive complexity 20 (threshold 15). Drivers by points: if/else 8 (17 pts), match/switch 1 (2 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/github/NuanceGitHubRawEvent.php"},"region":{"startLine":103}}}],"partialFingerprints":{"codehealthFindingId/v1":"225eb5c687df3edb6f1ff97b9dacc6d71b1ac073e7da8b9b5dea6990383ed525"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorOwnersPackagePathsTransaction.validateTransactions (cognitive 20): PhabricatorOwnersPackagePathsTransaction.validateTransactions has cognitive complexity 20 (threshold 15). Drivers by points: if/else 5 (11 pts), loops 3 (6 pts), error handling 1 (3 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/owners/xaction/PhabricatorOwnersPackagePathsTransaction.php"},"region":{"startLine":42}}}],"partialFingerprints":{"codehealthFindingId/v1":"259a7ae0d649bf500c097e4be74eff0b13df31a61d01d43fa51c7b8916886635"}},{"ruleId":"D2","level":"warning","message":{"text":"PassphraseCredentialQuery.willFilterPage (cognitive 20): PassphraseCredentialQuery.willFilterPage has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (14 pts), loops 3 (6 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/passphrase/query/PassphraseCredentialQuery.php"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"e9d2a9dbb373fce6ccab5494bcebaed514cadb507a12768284b81a0cf7cd2e50"}},{"ruleId":"D2","level":"warning","message":{"text":"PassphraseCredentialControl.renderInput (cognitive 20): PassphraseCredentialControl.renderInput has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (14 pts), boolean chains 2, error handling 1 (2 pts), loops 1, ternaries 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/passphrase/view/PassphraseCredentialControl.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"0faf033e11bdf7f44bdc5d792ac5cab1e4963abc404669036384fcbd476a149b"}},{"ruleId":"D2","level":"warning","message":{"text":"PhameBlogHeaderPictureController.handleRequest (cognitive 20): PhameBlogHeaderPictureController.handleRequest has cognitive complexity 20 (threshold 15). Drivers by points: if/else 10 (19 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"723f942bdeedeac24d688a640a308288ef20548dcd2a123c068a624a8b106cc3"}},{"ruleId":"D2","level":"warning","message":{"text":"PhamePostHeaderPictureController.handleRequest (cognitive 20): PhamePostHeaderPictureController.handleRequest has cognitive complexity 20 (threshold 15). Drivers by points: if/else 10 (19 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/post/PhamePostHeaderPictureController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"f83ae77fd12593c766239c5480a7e18be70adb6aa524fe7738d82eef8bd961ba"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorObjectQuery.loadPage (cognitive 20): PhabricatorObjectQuery.loadPage has cognitive complexity 20 (threshold 15). Drivers by points: if/else 10 (15 pts), loops 3 (5 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phid/query/PhabricatorObjectQuery.php"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"ed34df58e35e75df3e3944b4d10fe47817f675b965ae8f094bbd35002dd33b0e"}},{"ruleId":"D2","level":"warning","message":{"text":"PolicyLockOptionType.validateOption (cognitive 20): PolicyLockOptionType.validateOption has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (14 pts), error handling 1 (3 pts), loops 2 (3 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/config/PolicyLockOptionType.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"44f461186d2bebadf1e15f2ce47be6d6604db03232a1a3748130e69494f79a9c"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorPolicyQuery.loadObjectPolicyPHIDs (cognitive 20): PhabricatorPolicyQuery.loadObjectPolicyPHIDs has cognitive complexity 20 (threshold 15). Drivers by points: if/else 8 (15 pts), loops 4 (5 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/query/PhabricatorPolicyQuery.php"},"region":{"startLine":193}}}],"partialFingerprints":{"codehealthFindingId/v1":"55964c04985859f89c70b87c69a2b9e0b553f594e68f4acfa7b3e86bba1086d2"}},{"ruleId":"D2","level":"warning","message":{"text":"ProjectQueryConduitAPIMethod.execute (cognitive 20): ProjectQueryConduitAPIMethod.execute has cognitive complexity 20 (threshold 15). Drivers by points: if/else 12 (15 pts), loops 2 (5 pts) (nesting depth added 6). To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/conduit/ProjectQueryConduitAPIMethod.php"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"d020c04fe813d6cc8cd7d32965652071360ef309712852bebdff52eac3bac4c7"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectSubprojectsController.buildCurtainView (cognitive 20): PhabricatorProjectSubprojectsController.buildCurtainView has cognitive complexity 20 (threshold 15). Drivers by points: if/else 12 (14 pts), boolean chains 6 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectSubprojectsController.php"},"region":{"startLine":121}}}],"partialFingerprints":{"codehealthFindingId/v1":"a2df89402b21ae90125130135b3dda46ce2e81ad4ac59c4784f72a3d3a2e6c96"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryManagementImportingWorkflow.execute (cognitive 20): PhabricatorRepositoryManagementImportingWorkflow.execute has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (18 pts), loops 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/management/PhabricatorRepositoryManagementImportingWorkflow.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"f660ca14a7aa5e1b699127bb239fee4d2bf93f0dc0cc8c86af7858334aba3b7a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorElasticFulltextStorageEngine.buildSpec (cognitive 20): PhabricatorElasticFulltextStorageEngine.buildSpec has cognitive complexity 20 (threshold 15). Drivers by points: if/else 13 (16 pts), boolean chains 3, loops 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/fulltextstorage/PhabricatorElasticFulltextStorageEngine.php"},"region":{"startLine":108}}}],"partialFingerprints":{"codehealthFindingId/v1":"43273d58f2ce2d06118ee4a1442b5d24929815ef73740091501c1e4c41b5f3f7"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorBulkManagementExportWorkflow.execute (cognitive 20): PhabricatorBulkManagementExportWorkflow.execute has cognitive complexity 20 (threshold 15). Drivers by points: if/else 13 (14 pts), loops 2 (4 pts), boolean chains 2 (nesting depth added 3). To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/bulk/management/PhabricatorBulkManagementExportWorkflow.php"},"region":{"startLine":48}}}],"partialFingerprints":{"codehealthFindingId/v1":"639af7d10f309d5e30fff7096164876823aa0f68199d5c75fc1b421d282a759b"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorEditEngineConfigurationSearchEngine.renderResultList (cognitive 20): PhabricatorEditEngineConfigurationSearchEngine.renderResultList has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (19 pts), loops 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/query/PhabricatorEditEngineConfigurationSearchEngine.php"},"region":{"startLine":103}}}],"partialFingerprints":{"codehealthFindingId/v1":"ab44b0c1b19af40e0d695b26f2b9983db1cd107fd398e52c439fdd78f56306b5"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransactionReplyHandler.processMailCommands (cognitive 20): PhabricatorApplicationTransactionReplyHandler.processMailCommands has cognitive complexity 20 (threshold 15). Drivers by points: loops 4 (12 pts), if/else 4 (8 pts) (nesting depth added 12). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/replyhandler/PhabricatorApplicationTransactionReplyHandler.php"},"region":{"startLine":115}}}],"partialFingerprints":{"codehealthFindingId/v1":"ea231d207487ec362b6e79fae6b9d1b450a034fa2db799fb87c1189df9eb7261"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilProseDifferenceEngine.newEditDistanceMatrixDiff (cognitive 20): PhutilProseDifferenceEngine.newEditDistanceMatrixDiff has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (19 pts), loops 1 (nesting depth added 10). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/prose/PhutilProseDifferenceEngine.php"},"region":{"startLine":165}}}],"partialFingerprints":{"codehealthFindingId/v1":"337837667d2fa906486aec6316375e74e617f78dd4f94c4fd6b380ece846b26c"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilRemarkupBlockStorage.restore (cognitive 20): PhutilRemarkupBlockStorage.restore has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (15 pts), loops 3 (5 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/PhutilRemarkupBlockStorage.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"8ad3f8d9f236696d63144aac5d91ef0f9bf4f4017533a31d7bed2b693ba3007a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilRemarkupHyperlinkRule.didMarkupText (cognitive 20): PhutilRemarkupHyperlinkRule.didMarkupText has cognitive complexity 20 (threshold 15). Drivers by points: if/else 6 (12 pts), loops 5 (6 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/markuprule/PhutilRemarkupHyperlinkRule.php"},"region":{"startLine":180}}}],"partialFingerprints":{"codehealthFindingId/v1":"2c40788e403eb20bee29df578b09a736297e40332f735f0a4d7814602de82848"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorPolicyAwareQuery.applyWillFilterPageExtensions (cognitive 20): PhabricatorPolicyAwareQuery.applyWillFilterPageExtensions has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (15 pts), loops 3 (5 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php"},"region":{"startLine":739}}}],"partialFingerprints":{"codehealthFindingId/v1":"50259929444975624de6d45f2aabbd2f698dede955fde0a953bc8c34c3b8023b"}},{"ruleId":"D2","level":"warning","message":{"text":"AphrontBaseMySQLDatabaseConnection.executeQuery (cognitive 20): AphrontBaseMySQLDatabaseConnection.executeQuery has cognitive complexity 20 (threshold 15). Drivers by points: if/else 5 (13 pts), loops 2 (5 pts), error handling 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php"},"region":{"startLine":184}}}],"partialFingerprints":{"codehealthFindingId/v1":"20bd9cff27df3e92f166159180300f0c58f1f9becb862e0517c41ef7e8474c5f"}},{"ruleId":"D2","level":"warning","message":{"text":"LiskDAO.__call (cognitive 20): LiskDAO.__call has cognitive complexity 20 (threshold 15). Drivers by points: if/else 10 (20 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/lisk/LiskDAO.php"},"region":{"startLine":1585}}}],"partialFingerprints":{"codehealthFindingId/v1":"9c4e4986e1de9e29a5db1f6652955290953ee34a6b8e73c207d52466cd1003be"}},{"ruleId":"D2","level":"warning","message":{"text":"PHUITimelineEventView.getMenuItems (cognitive 20): PHUITimelineEventView.getMenuItems has cognitive complexity 20 (threshold 15). Drivers by points: if/else 11 (18 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUITimelineEventView.php"},"region":{"startLine":661}}}],"partialFingerprints":{"codehealthFindingId/v1":"281690698d3aa1406ec925d1eedad43ee0e24285717ebe35fea854b5855e4e17"}},{"ruleId":"D2","level":"warning","message":{"text":"_getTargetList (cognitive 20): _getTargetList has cognitive complexity 20 (threshold 15). Drivers by points: if/else 6 (16 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/DraggableList.js"},"region":{"startLine":304}}}],"partialFingerprints":{"codehealthFindingId/v1":"a816b96a07db98ab1b6fa3ee987919fb3923ec04354194f91f496f075dec613b"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilLDAPAuthAdapter.loadLDAPUserData (cognitive 19): PhutilLDAPAuthAdapter.loadLDAPUserData has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (17 pts), loops 1 (2 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/adapter/PhutilLDAPAuthAdapter.php"},"region":{"startLine":212}}}],"partialFingerprints":{"codehealthFindingId/v1":"0934e657b8e61e716632e608a44e62839b406bb63596aed2bb545a2cd0e9fab9"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorAuthInviteEngine.processInviteCode (cognitive 19): PhabricatorAuthInviteEngine.processInviteCode has cognitive complexity 19 (threshold 15). Drivers by points: if/else 12 (19 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/engine/PhabricatorAuthInviteEngine.php"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"9bdb68760ce446c64719cc9f47b22f9637c100fb699df3ae8acf8f0ae4238fbe"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorAuthInviteEngine.handleLoggedInInvite (cognitive 19): PhabricatorAuthInviteEngine.handleLoggedInInvite has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (18 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/engine/PhabricatorAuthInviteEngine.php"},"region":{"startLine":125}}}],"partialFingerprints":{"codehealthFindingId/v1":"b75e8e230639925f6875590a3ffa2d43f56d95cfaa14c53d8c90772bdce376b5"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorAuthAccountView.render (cognitive 19): PhabricatorAuthAccountView.render has cognitive complexity 19 (threshold 15). Drivers by points: if/else 11 (18 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/view/PhabricatorAuthAccountView.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"e7435b324f836f7592dbbf495aa252bed4f0bd610f60692aa059f2cb9bdb6982"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCalendarEventEditEngine.willApplyTransactions (cognitive 19): PhabricatorCalendarEventEditEngine.willApplyTransactions has cognitive complexity 19 (threshold 15). Drivers by points: if/else 8 (14 pts), boolean chains 4, loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/editor/PhabricatorCalendarEventEditEngine.php"},"region":{"startLine":314}}}],"partialFingerprints":{"codehealthFindingId/v1":"a44bf64d0f24be01680e343905d66de60d6e4bbdf28caaae00e4d545694d2e08"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilCalendarRecurrenceRule.generateNextEvent (cognitive 19): PhutilCalendarRecurrenceRule.generateNextEvent has cognitive complexity 19 (threshold 15). Drivers by points: if/else 8 (16 pts), loops 2 (3 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php"},"region":{"startLine":733}}}],"partialFingerprints":{"codehealthFindingId/v1":"f87a6ffc7bfc0a48f36c9c2d098657895e2fa0d5724bf0403a00009173bb3a99"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilCalendarRecurrenceRule.isCursorBehind (cognitive 19): PhutilCalendarRecurrenceRule.isCursorBehind has cognitive complexity 19 (threshold 15). Drivers by points: if/else 15 (19 pts) (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php"},"region":{"startLine":1779}}}],"partialFingerprints":{"codehealthFindingId/v1":"2325cf3bb3054275003cef42ec6a61eb112409b6aa0370ef86fe6085d580b0f0"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorConfigSchemaQuery.buildComparisonSchemaForServer (cognitive 19): PhabricatorConfigSchemaQuery.buildComparisonSchemaForServer has cognitive complexity 19 (threshold 15). Drivers by points: if/else 4 (10 pts), loops 4 (9 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/schema/PhabricatorConfigSchemaQuery.php"},"region":{"startLine":268}}}],"partialFingerprints":{"codehealthFindingId/v1":"3df37f9677d6cc2cc7c8131a078c30e32d51724265b0191769cf19ce8f82448f"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorDaemonBulkJobMonitorController.handleRequest (cognitive 19): PhabricatorDaemonBulkJobMonitorController.handleRequest has cognitive complexity 19 (threshold 15). Drivers by points: if/else 9 (13 pts), loops 1 (4 pts), match/switch 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/daemon/controller/PhabricatorDaemonBulkJobMonitorController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"5af801bd61512dba27204579ae90f1515a53c4452f2cdd2711cff4de3bebd1ca"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorWorkerTaskDetailController.buildPropertyListView (cognitive 19): PhabricatorWorkerTaskDetailController.buildPropertyListView has cognitive complexity 19 (threshold 15). Drivers by points: if/else 13 (15 pts), match/switch 1 (2 pts), boolean chains 1, ternaries 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/daemon/controller/PhabricatorWorkerTaskDetailController.php"},"region":{"startLine":82}}}],"partialFingerprints":{"codehealthFindingId/v1":"949c7416872a47e16658d5c9191cedeee4591a0e935434ae477f280802756592"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorDaemonLogQuery.willFilterPage (cognitive 19): PhabricatorDaemonLogQuery.willFilterPage has cognitive complexity 19 (threshold 15). Drivers by points: if/else 6 (14 pts), boolean chains 4, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/daemon/query/PhabricatorDaemonLogQuery.php"},"region":{"startLine":70}}}],"partialFingerprints":{"codehealthFindingId/v1":"fbaeb3727e2a20aa244fa1dc46ffa5b2c1d1e807e30f4b04393c075ed2546b67"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialBranchField.getBranchDescription (cognitive 19): DifferentialBranchField.getBranchDescription has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (16 pts), boolean chains 3 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/customfield/DifferentialBranchField.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"8a8fe7ec99ca80e6cca148e24ead670420574149ad2bd9ba0dc4582f6b759936"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialHunkParser.parseHunksForLineData (cognitive 19): DifferentialHunkParser.parseHunksForLineData has cognitive complexity 19 (threshold 15). Drivers by points: if/else 3 (7 pts), match/switch 2 (7 pts), loops 3 (5 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialHunkParser.php"},"region":{"startLine":477}}}],"partialFingerprints":{"codehealthFindingId/v1":"01f039e6fb93d49930ea023dceccaee729247a587a77615105ce0f3d9e8be628"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialHunk.makeContent (cognitive 19): DifferentialHunk.makeContent has cognitive complexity 19 (threshold 15). Drivers by points: if/else 9 (16 pts), loops 2, boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialHunk.php"},"region":{"startLine":206}}}],"partialFingerprints":{"codehealthFindingId/v1":"b9121de0e911a4f207b47dde74f7ba24cd6c830a90a13f3ec3df20054a7ca6e4"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialTransaction.getTitle (cognitive 19): DifferentialTransaction.getTitle has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (15 pts), match/switch 2 (3 pts), boolean chains 1 (nesting depth added 9). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialTransaction.php"},"region":{"startLine":208}}}],"partialFingerprints":{"codehealthFindingId/v1":"1f30b97f3f2a2c639c5472a2d601dede4e21c3c98861d6f4ba9647520030a840"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialRevisionUpdateTransaction.validateTransactions (cognitive 19): DifferentialRevisionUpdateTransaction.validateTransactions has cognitive complexity 19 (threshold 15). Drivers by points: if/else 9 (16 pts), boolean chains 2, loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/xaction/DifferentialRevisionUpdateTransaction.php"},"region":{"startLine":160}}}],"partialFingerprints":{"codehealthFindingId/v1":"b340a22696971e73287d40bbdb18a0658e51fcad8b8387db052e329c3055087a"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionController.buildCrumbList (cognitive 19): DiffusionController.buildCrumbList has cognitive complexity 19 (threshold 15). Drivers by points: if/else 11 (13 pts), boolean chains 5, match/switch 1 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionController.php"},"region":{"startLine":128}}}],"partialFingerprints":{"codehealthFindingId/v1":"7a1354c0d99f537a53aeb0212b3edb0d715cd1add1d535b7b34f7708d76804a4"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionLowLevelCommitFieldsQuery.executeQuery (cognitive 19): DiffusionLowLevelCommitFieldsQuery.executeQuery has cognitive complexity 19 (threshold 15). Drivers by points: if/else 6 (13 pts), loops 2 (5 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/lowlevel/DiffusionLowLevelCommitFieldsQuery.php"},"region":{"startLine":29}}}],"partialFingerprints":{"codehealthFindingId/v1":"a3355956ece5ec77c913e7cf3721cdc8c06c2de9fecbea431d877e30ae83d2a0"}},{"ruleId":"D2","level":"warning","message":{"text":"DivinerPHPAtomizer.parseParams (cognitive 19): DivinerPHPAtomizer.parseParams has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (16 pts), loops 2 (3 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/atomizer/DivinerPHPAtomizer.php"},"region":{"startLine":129}}}],"partialFingerprints":{"codehealthFindingId/v1":"4757c0f530c23c42fbb8121bd4806535d63d3ba9e5a8b71854c2854945121c1e"}},{"ruleId":"D2","level":"warning","message":{"text":"DivinerPHPAtomizer.findAtomDocblock (cognitive 19): DivinerPHPAtomizer.findAtomDocblock has cognitive complexity 19 (threshold 15). Drivers by points: if/else 6 (15 pts), loops 1 (3 pts), boolean chains 1 (nesting depth added 11). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/atomizer/DivinerPHPAtomizer.php"},"region":{"startLine":193}}}],"partialFingerprints":{"codehealthFindingId/v1":"cd6353889c840a115cac4405208aabdc750065a75815e8357a13149446681ab7"}},{"ruleId":"D2","level":"warning","message":{"text":"DoorkeeperHyperlinkEngineExtension.processHyperlinks (cognitive 19): DoorkeeperHyperlinkEngineExtension.processHyperlinks has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (14 pts), loops 3 (4 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/engineextension/DoorkeeperHyperlinkEngineExtension.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"bfa646a3adcb9e9c770bdaa630f2705204d6a954057ad64a2b4a70913fbdb6d2"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorEmbedFileRemarkupRule.renderObjectEmbed (cognitive 19): PhabricatorEmbedFileRemarkupRule.renderObjectEmbed has cognitive complexity 19 (threshold 15). Drivers by points: if/else 9 (13 pts), boolean chains 6 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php"},"region":{"startLine":68}}}],"partialFingerprints":{"codehealthFindingId/v1":"a7ac37809c340c750a6b8e287d5b1e744fb5066f8e0a8e14173f93361aa3cc45"}},{"ruleId":"D2","level":"warning","message":{"text":"HarbormasterBuildableActionController.handleRequest (cognitive 19): HarbormasterBuildableActionController.handleRequest has cognitive complexity 19 (threshold 15). Drivers by points: if/else 11 (13 pts), loops 2 (3 pts), error handling 1 (2 pts), boolean chains 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterBuildableActionController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"cbd27a95fdf064aa30d8d60c2bb638b1cd869914a7e2c3b6ece86d8f056b35e2"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMacroAudioController.handleRequest (cognitive 19): PhabricatorMacroAudioController.handleRequest has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (19 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/macro/controller/PhabricatorMacroAudioController.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"7a9710c913cbd0b0f4b98196a669eac2e88d5a94bcb9691d5ed5f5ae4c0a2774"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMacroQuery.buildWhereClauseParts (cognitive 19): PhabricatorMacroQuery.buildWhereClauseParts has cognitive complexity 19 (threshold 15). Drivers by points: if/else 13 (15 pts), boolean chains 3, match/switch 1 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/macro/query/PhabricatorMacroQuery.php"},"region":{"startLine":103}}}],"partialFingerprints":{"codehealthFindingId/v1":"6c1ab7931c7a70a1f700de8b025ee9f54b5a1bc026c63e09c0032edaf5ae829e"}},{"ruleId":"D2","level":"warning","message":{"text":"ManiphestTransactionEditor.expandTransactions (cognitive 19): ManiphestTransactionEditor.expandTransactions has cognitive complexity 19 (threshold 15). Drivers by points: if/else 8 (11 pts), boolean chains 4, loops 2, match/switch 1 (2 pts) (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/editor/ManiphestTransactionEditor.php"},"region":{"startLine":319}}}],"partialFingerprints":{"codehealthFindingId/v1":"76f2941f9cb0e47eff2fb522d2ac603f117a934a9cbfd97e2553462f6986daa9"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorUserProfileImageCacheType.newValueForUsers (cognitive 19): PhabricatorUserProfileImageCacheType.newValueForUsers has cognitive complexity 19 (threshold 15). Drivers by points: if/else 9 (16 pts), loops 3 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/cache/PhabricatorUserProfileImageCacheType.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"baf1bcced17efd063062b310990b3c4a9bf23154f21e1c2d27f37aa3b924c013"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorUserCardView.getTagContent (cognitive 19): PhabricatorUserCardView.getTagContent has cognitive complexity 19 (threshold 15). Drivers by points: if/else 12 (19 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/view/PhabricatorUserCardView.php"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"4f7f64ef5e20e1d1c97b2118389e2f76adfc433d82b17752ba5e3effa7fc8bfb"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorObjectQuery.loadObjectsByPHID (cognitive 19): PhabricatorObjectQuery.loadObjectsByPHID has cognitive complexity 19 (threshold 15). Drivers by points: if/else 5 (12 pts), loops 4 (6 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phid/query/PhabricatorObjectQuery.php"},"region":{"startLine":116}}}],"partialFingerprints":{"codehealthFindingId/v1":"443fd0ef360f1912af21845856a667c5de9cd907b19815f76f1a8e2edfac7f35"}},{"ruleId":"D2","level":"warning","message":{"text":"PhortuneSubscriptionQuery.willFilterPage (cognitive 19): PhortuneSubscriptionQuery.willFilterPage has cognitive complexity 19 (threshold 15). Drivers by points: if/else 8 (13 pts), loops 5 (6 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/query/PhortuneSubscriptionQuery.php"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"f2e9db5a2755081bf157240216d68e7d7c5a5716e9efc3bc854ca417fbf07ed4"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectColumnEditController.handleRequest (cognitive 19): PhabricatorProjectColumnEditController.handleRequest has cognitive complexity 19 (threshold 15). Drivers by points: if/else 11 (16 pts), error handling 1 (2 pts), ternaries 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectColumnEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"e676329ff98bb85a422aaca3e8fa65e2415ba993fd1b7fc233cd3437d64b9159"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectTransactionEditor.adjustObjectForPolicyChecks (cognitive 19): PhabricatorProjectTransactionEditor.adjustObjectForPolicyChecks has cognitive complexity 19 (threshold 15). Drivers by points: if/else 9 (16 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/editor/PhabricatorProjectTransactionEditor.php"},"region":{"startLine":330}}}],"partialFingerprints":{"codehealthFindingId/v1":"08aaf78b6ed1e64f6da772958566e32e55549835676a729f150c093286bd24be"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryPullLocalDaemon.loadPullableRepositories (cognitive 19): PhabricatorRepositoryPullLocalDaemon.loadPullableRepositories has cognitive complexity 19 (threshold 15). Drivers by points: if/else 6 (11 pts), loops 5 (8 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php"},"region":{"startLine":405}}}],"partialFingerprints":{"codehealthFindingId/v1":"34a16fb1cd55b5dfa419c40b5e2409eee787732229e387b32cc5e44519999bb9"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryDiscoveryEngine.discoverSubversionCommits (cognitive 19): PhabricatorRepositoryDiscoveryEngine.discoverSubversionCommits has cognitive complexity 19 (threshold 15). Drivers by points: if/else 6 (11 pts), loops 3 (4 pts), boolean chains 2, error handling 1 (2 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php"},"region":{"startLine":234}}}],"partialFingerprints":{"codehealthFindingId/v1":"fafe00d8612901ffa5cc697dbc67912a953b44eb11c67b58f92c00ff0c87b0ae"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryGraphCache.rebuildBucket (cognitive 19): PhabricatorRepositoryGraphCache.rebuildBucket has cognitive complexity 19 (threshold 15). Drivers by points: if/else 8 (10 pts), loops 4 (9 pts) (nesting depth added 7). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/graphcache/PhabricatorRepositoryGraphCache.php"},"region":{"startLine":295}}}],"partialFingerprints":{"codehealthFindingId/v1":"ebcb00421bdf0920466b8516980efc30bd6be23e0a44129a567fb4275ec4419b"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryQuery.didFilterPage (cognitive 19): PhabricatorRepositoryQuery.didFilterPage has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (13 pts), loops 3 (6 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/query/PhabricatorRepositoryQuery.php"},"region":{"startLine":347}}}],"partialFingerprints":{"codehealthFindingId/v1":"3a610ab00485a37f0a34ee8734edaebe071f6f40e8ca5527be12426c01e3b586"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryCommit.updateAuditStatus (cognitive 19): PhabricatorRepositoryCommit.updateAuditStatus has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (16 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepositoryCommit.php"},"region":{"startLine":306}}}],"partialFingerprints":{"codehealthFindingId/v1":"738b56973dbb82e80e254acd0d098babe74aac997c88285c88b719a83ddb15e0"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositorySvnCommitChangeParserWorker.lookupPathFileTypes (cognitive 19): PhabricatorRepositorySvnCommitChangeParserWorker.lookupPathFileTypes has cognitive complexity 19 (threshold 15). Drivers by points: loops 6 (12 pts), if/else 4 (7 pts) (nesting depth added 9). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/commitchangeparser/PhabricatorRepositorySvnCommitChangeParserWorker.php"},"region":{"startLine":558}}}],"partialFingerprints":{"codehealthFindingId/v1":"0c23df07397a8eb7a49a447c6c8b2a06baeea9ef5ad39bf2584ba8d2d1822cc3"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationSearchController.processCustomizeRequest (cognitive 19): PhabricatorApplicationSearchController.processCustomizeRequest has cognitive complexity 19 (threshold 15). Drivers by points: if/else 13 (18 pts), boolean chains 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/controller/PhabricatorApplicationSearchController.php"},"region":{"startLine":999}}}],"partialFingerprints":{"codehealthFindingId/v1":"1c52aa78b2042ac63b7f5f09b33859451a7067eb756d3e36076e8fece5e563bf"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorEmailAddressesSettingsPanel.processRequest (cognitive 19): PhabricatorEmailAddressesSettingsPanel.processRequest has cognitive complexity 19 (threshold 15). Drivers by points: if/else 12 (18 pts), loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"724ac8dec193eed20901373e6860232cd9c7dd995ceea8f59f0b1751e07bf498"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorPasswordSettingsPanel.processRequest (cognitive 19): PhabricatorPasswordSettingsPanel.processRequest has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (15 pts), error handling 2 (4 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/settings/panel/PhabricatorPasswordSettingsPanel.php"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"da1553981b6d01b8d4466a366add932d9fcf46ff964d42815b0e6259c50cd6ef"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransaction.getIcon (cognitive 19): PhabricatorApplicationTransaction.getIcon has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (14 pts), match/switch 2 (3 pts), boolean chains 2 (nesting depth added 8). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorApplicationTransaction.php"},"region":{"startLine":473}}}],"partialFingerprints":{"codehealthFindingId/v1":"60d3fa668851630b325ac6c8b0730358975adfe8be337c650136ff82671239ff"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorWorkerTriggerManagementFireWorkflow.execute (cognitive 19): PhabricatorWorkerTriggerManagementFireWorkflow.execute has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (18 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/workers/management/PhabricatorWorkerTriggerManagementFireWorkflow.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"4f15ce2a3fc0b8e9a4f51c305df81dd4ec25a2690e25f73502bd475dd754df43"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorDiffInlineCommentQuery.buildWhereClauseParts (cognitive 19): PhabricatorDiffInlineCommentQuery.buildWhereClauseParts has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (17 pts), boolean chains 1, loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/query/PhabricatorDiffInlineCommentQuery.php"},"region":{"startLine":61}}}],"partialFingerprints":{"codehealthFindingId/v1":"608521c83f1aa678156cdc76c2de5953f825d5ce7f8390629b2c08b170fedf26"}},{"ruleId":"D2","level":"warning","message":{"text":"PHUIDiffTableOfContentsItemView.renderChangesetMetadata (cognitive 19): PHUIDiffTableOfContentsItemView.renderChangesetMetadata has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (16 pts), loops 1 (3 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/view/PHUIDiffTableOfContentsItemView.php"},"region":{"startLine":179}}}],"partialFingerprints":{"codehealthFindingId/v1":"46c52699775d748a515c146cb7951795c968c1504d3c179efd67a3bda6dd2793"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorEnv.buildConfigurationSourceStack (cognitive 19): PhabricatorEnv.buildConfigurationSourceStack has cognitive complexity 19 (threshold 15). Drivers by points: if/else 8 (13 pts), loops 3 (4 pts), error handling 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/env/PhabricatorEnv.php"},"region":{"startLine":182}}}],"partialFingerprints":{"codehealthFindingId/v1":"5de59d60cefa48fcfaf3864d4643b41588d136cd046566441d9cfd61d75f99ad"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilContextFreeGrammar.applyRules (cognitive 19): PhutilContextFreeGrammar.applyRules has cognitive complexity 19 (threshold 15). Drivers by points: if/else 8 (15 pts), match/switch 1 (3 pts), loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/lipsum/PhutilContextFreeGrammar.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"61cc7a896dfac3a0ab9c25acc3d5429b59c00a6ec8182572587062ae5800835f"}},{"ruleId":"D2","level":"warning","message":{"text":"render.phutil_tag (cognitive 19): render.phutil_tag has cognitive complexity 19 (threshold 15). Drivers by points: if/else 9 (17 pts), boolean chains 1, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/render.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"29eed0e290dcf8cf4930f96d309c51736a3727cc55a45f23c00c032704c4b6c8"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilLexerSyntaxHighlighter.getHighlightFuture (cognitive 19): PhutilLexerSyntaxHighlighter.getHighlightFuture has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (14 pts), loops 2 (3 pts), match/switch 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/syntax/highlighter/PhutilLexerSyntaxHighlighter.php"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"95c483723032cea0b8c7be8fbed72ebe26bafa505e0a157b0171652d4338a529"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCursorPagedPolicyAwareQuery.buildEdgeLogicSelectClause (cognitive 19): PhabricatorCursorPagedPolicyAwareQuery.buildEdgeLogicSelectClause has cognitive complexity 19 (threshold 15). Drivers by points: if/else 2 (8 pts), loops 3 (8 pts), match/switch 1 (3 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php"},"region":{"startLine":2622}}}],"partialFingerprints":{"codehealthFindingId/v1":"c5fbbb4750feed046b80605394ef562195dc4ee187e6d613477a2c97dcf6e9cd"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorStorageManagementUpgradeWorkflow.didExecute (cognitive 19): PhabricatorStorageManagementUpgradeWorkflow.didExecute has cognitive complexity 19 (threshold 15). Drivers by points: if/else 9 (13 pts), boolean chains 4, loops 1 (2 pts) (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/management/workflow/PhabricatorStorageManagementUpgradeWorkflow.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"bb5062ada7d882356bd82edec166a826ae2de5422eac5909f2b92261007f4e6f"}},{"ruleId":"D2","level":"warning","message":{"text":"PHUIHeaderView.renderPolicyProperty (cognitive 19): PHUIHeaderView.renderPolicyProperty has cognitive complexity 19 (threshold 15). Drivers by points: if/else 9 (17 pts), loops 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIHeaderView.php"},"region":{"startLine":429}}}],"partialFingerprints":{"codehealthFindingId/v1":"5e69235c1f6661ae2a41034df020329b39bd873b02d5f4e1e4c4d217ff50c53b"}},{"ruleId":"D2","level":"warning","message":{"text":"PHUIHovercardView.getTagContent (cognitive 19): PHUIHovercardView.getTagContent has cognitive complexity 19 (threshold 15). Drivers by points: if/else 12 (14 pts), loops 3 (4 pts), ternaries 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIHovercardView.php"},"region":{"startLine":92}}}],"partialFingerprints":{"codehealthFindingId/v1":"fc4a1b7d76e11b200ea54812f1ae41c9de5e0029d4786bef84f7d61b53bcbe43"}},{"ruleId":"D2","level":"warning","message":{"text":"PHUICalendarDayView.render (cognitive 19): PHUICalendarDayView.render has cognitive complexity 19 (threshold 15). Drivers by points: if/else 5 (12 pts), boolean chains 4, loops 3 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/calendar/PHUICalendarDayView.php"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"dbcd357573127dee2aee16adfaa34c0cc5af705c3ac074601ce0d24708a6e42f"}},{"ruleId":"D2","level":"warning","message":{"text":"PHUICalendarListView.getTagContent (cognitive 19): PHUICalendarListView.getTagContent has cognitive complexity 19 (threshold 15). Drivers by points: if/else 11 (17 pts), boolean chains 1, loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/calendar/PHUICalendarListView.php"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"56c8accb38d848c564971bdeb1fddf06e9eaed2116e5b2b638c24845f6a5ad82"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-document-engine.JX.behavior(\u0022document-engine\u0022)::blame (cognitive 19): behavior-document-engine.JX.behavior(\u0022document-engine\u0022)::blame has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (14 pts), loops 4 (5 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/files/behavior-document-engine.js"},"region":{"startLine":262}}}],"partialFingerprints":{"codehealthFindingId/v1":"8c24f1661d0ab1835b21787feaae31e52ed285e21fb784d5d85a85daf3ac2dfb"}},{"ruleId":"D2","level":"warning","message":{"text":"_hasUnrefinableResults (cognitive 19): _hasUnrefinableResults has cognitive complexity 19 (threshold 15). Drivers by points: if/else 6 (18 pts), loops 1 (nesting depth added 12). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/phuix/PHUIXAutocomplete.js"},"region":{"startLine":381}}}],"partialFingerprints":{"codehealthFindingId/v1":"ac11037852df2141043852f584a1dcc5c714a087a97fc2810ecb3f0b0b899e18"}},{"ruleId":"D2","level":"warning","message":{"text":"_onresponse (cognitive 19): _onresponse has cognitive complexity 19 (threshold 15). Drivers by points: if/else 9 (15 pts), boolean chains 2, error handling 1 (2 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangeset.js"},"region":{"startLine":580}}}],"partialFingerprints":{"codehealthFindingId/v1":"7297cb14a63510bd495034859c8e0dd57ef5bd64f195496b7b335a046c8bb7c5"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous)::blame (cognitive 19): (anonymous)::blame has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (14 pts), loops 4 (5 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/files/behavior-document-engine.js"},"region":{"startLine":262}}}],"partialFingerprints":{"codehealthFindingId/v1":"1a065b608dd9a5a3c38ed24bff3765cf0544723c69049b05eafc7cd952ebad27"}},{"ruleId":"D2","level":"warning","message":{"text":"AphrontRequest.newClusterProxyFuture (cognitive 18): AphrontRequest.newClusterProxyFuture has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (12 pts), loops 4, match/switch 1 (2 pts) (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/AphrontRequest.php"},"region":{"startLine":851}}}],"partialFingerprints":{"codehealthFindingId/v1":"010268059094cdc026a8b865ac88b99d6458de0b3c95c291af260d47e6beecd8"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorAuthSSHKeyEditController.handleRequest (cognitive 18): PhabricatorAuthSSHKeyEditController.handleRequest has cognitive complexity 18 (threshold 15). Drivers by points: if/else 9 (12 pts), boolean chains 2, error handling 1 (2 pts), ternaries 2 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthSSHKeyEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"ef31fbf1585d1d2864d7c793f101b77a229afed89046a08257ed6d943422c837"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCalendarEventViewController.buildRecurringSection (cognitive 18): PhabricatorCalendarEventViewController.buildRecurringSection has cognitive complexity 18 (threshold 15). Drivers by points: if/else 13 (17 pts), match/switch 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/controller/PhabricatorCalendarEventViewController.php"},"region":{"startLine":439}}}],"partialFingerprints":{"codehealthFindingId/v1":"17313c7a8893afda572f20a6ad476aa7c39b36e7ca10c0bdeb194d99ab3748f2"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilCalendarRecurrenceRule.newFromRRULE (cognitive 18): PhutilCalendarRecurrenceRule.newFromRRULE has cognitive complexity 18 (threshold 15). Drivers by points: if/else 4 (11 pts), loops 3 (5 pts), match/switch 1 (2 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php"},"region":{"startLine":237}}}],"partialFingerprints":{"codehealthFindingId/v1":"d9fdb55824306381bb63dede81442308ac60acea2afbdb7d5f3c206d59198291"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilICSParser.unescapeFieldValue (cognitive 18): PhutilICSParser.unescapeFieldValue has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (12 pts), loops 3 (5 pts), match/switch 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/ics/PhutilICSParser.php"},"region":{"startLine":386}}}],"partialFingerprints":{"codehealthFindingId/v1":"45f676f2304e365611c0dbcd252090f8c8401f25c2acb499936f1ee3487673c8"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorConduitAPIController.decodeConduitParams (cognitive 18): PhabricatorConduitAPIController.decodeConduitParams has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (12 pts), loops 2 (3 pts), error handling 1 (2 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conduit/controller/PhabricatorConduitAPIController.php"},"region":{"startLine":627}}}],"partialFingerprints":{"codehealthFindingId/v1":"007c6f921dbd57b9717e9005e3e970a4c6986cf3d410712a528ee3008327c16c"}},{"ruleId":"D2","level":"warning","message":{"text":"ConpherenceViewController.handleRequest (cognitive 18): ConpherenceViewController.handleRequest has cognitive complexity 18 (threshold 15). Drivers by points: if/else 13 (14 pts), boolean chains 4 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceViewController.php"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"98dee54a3b920bdac370a09e3c06447efa49ed2bc68db9737574035b60c70e6f"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorDaemonManagementWorkflow.launchDaemons (cognitive 18): PhabricatorDaemonManagementWorkflow.launchDaemons has cognitive complexity 18 (threshold 15). Drivers by points: if/else 11 (14 pts), error handling 1 (2 pts), boolean chains 1, loops 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php"},"region":{"startLine":71}}}],"partialFingerprints":{"codehealthFindingId/v1":"c1881fbd4065e63abfa703e48ba754ff10baca0c31eaa92528cd5b5f597359a4"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorDaemonManagementWorkflow.sendSignal (cognitive 18): PhabricatorDaemonManagementWorkflow.sendSignal has cognitive complexity 18 (threshold 15). Drivers by points: if/else 4 (10 pts), loops 3 (6 pts), match/switch 1 (2 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php"},"region":{"startLine":467}}}],"partialFingerprints":{"codehealthFindingId/v1":"8856b1f9eae8862e6de575a96f14b92c636b8d18abb92166dee1631386b67b9e"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialRevisionViewController.loadChangesetsAndVsMap (cognitive 18): DifferentialRevisionViewController.loadChangesetsAndVsMap has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (9 pts), loops 5 (9 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/controller/DifferentialRevisionViewController.php"},"region":{"startLine":864}}}],"partialFingerprints":{"codehealthFindingId/v1":"6029d16d3567bfd599dbdd85697109ef665a885db20264bf64bb40073a7fe471"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialChangesetParser.buildLineBackmaps (cognitive 18): DifferentialChangesetParser.buildLineBackmaps has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (13 pts), loops 5 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialChangesetParser.php"},"region":{"startLine":1382}}}],"partialFingerprints":{"codehealthFindingId/v1":"e7167d4ce53011a2e996c886504f8c65b59edd541e9dde58d34e660165f18970"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialHunkParser.getHasChanges (cognitive 18): DifferentialHunkParser.getHasChanges has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (15 pts), boolean chains 2, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialHunkParser.php"},"region":{"startLine":163}}}],"partialFingerprints":{"codehealthFindingId/v1":"a4990d799498acd2c7cc3b73e162eace6174c65cb0586d09353ff5b71928f3e7"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialRevisionQuery.willFilterPage (cognitive 18): DifferentialRevisionQuery.willFilterPage has cognitive complexity 18 (threshold 15). Drivers by points: if/else 11 (15 pts), boolean chains 2, loops 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/query/DifferentialRevisionQuery.php"},"region":{"startLine":336}}}],"partialFingerprints":{"codehealthFindingId/v1":"e495a84c8ee56dccdaef9e2dc53196cea9d299e5856a2952e8f00db75bf5baba"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionCommitHookEngine.applyHeraldRules (cognitive 18): DiffusionCommitHookEngine.applyHeraldRules has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (12 pts), loops 3 (6 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/engine/DiffusionCommitHookEngine.php"},"region":{"startLine":330}}}],"partialFingerprints":{"codehealthFindingId/v1":"6b49f147afbc23bc66a6fdc443c7313e75b1208ef5085adcd97584c766911c71"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionCommitHookEngine.findMercurialPushKeyRefUpdates (cognitive 18): DiffusionCommitHookEngine.findMercurialPushKeyRefUpdates has cognitive complexity 18 (threshold 15). Drivers by points: if/else 12 (17 pts), boolean chains 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/engine/DiffusionCommitHookEngine.php"},"region":{"startLine":962}}}],"partialFingerprints":{"codehealthFindingId/v1":"dde865345ab4fae8cef80863c587d5c18f11c1f42e4dcb3ff1e518e20bebd51c"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionPhpExternalSymbolsSource.executeQuery (cognitive 18): DiffusionPhpExternalSymbolsSource.executeQuery has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (13 pts), loops 2 (4 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/symbol/DiffusionPhpExternalSymbolsSource.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"4155c5021a7e8121a0cea33a4455ca92d220a5f8a3b7059dddbf22d2b4a81ce9"}},{"ruleId":"D2","level":"warning","message":{"text":"DrydockLeaseViewController.buildPropertyListView (cognitive 18): DrydockLeaseViewController.buildPropertyListView has cognitive complexity 18 (threshold 15). Drivers by points: if/else 15 (16 pts), loops 1 (2 pts) (nesting depth added 2). To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/controller/DrydockLeaseViewController.php"},"region":{"startLine":127}}}],"partialFingerprints":{"codehealthFindingId/v1":"9dfce48401c3ee7a61da0a07e968d897396bd5256f99e38c69165302ac94674a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorFactDaemon.updateDatapoints (cognitive 18): PhabricatorFactDaemon.updateDatapoints has cognitive complexity 18 (threshold 15). Drivers by points: if/else 5 (9 pts), loops 6 (9 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fact/daemon/PhabricatorFactDaemon.php"},"region":{"startLine":122}}}],"partialFingerprints":{"codehealthFindingId/v1":"1c9a99216d188e2229368b775b2c7c2299842a87726fe787ebf199584f22ee01"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorFeedStoryPublisher.filterSubscribedPHIDs (cognitive 18): PhabricatorFeedStoryPublisher.filterSubscribedPHIDs has cognitive complexity 18 (threshold 15). Drivers by points: if/else 5 (12 pts), loops 2 (4 pts), boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/feed/PhabricatorFeedStoryPublisher.php"},"region":{"startLine":220}}}],"partialFingerprints":{"codehealthFindingId/v1":"0a9be71c9cb974746ff7442b95649a568f9a02c1cdfb9a86064b06da195b616c"}},{"ruleId":"D2","level":"warning","message":{"text":"FileAllocateConduitAPIMethod.execute (cognitive 18): FileAllocateConduitAPIMethod.execute has cognitive complexity 18 (threshold 15). Drivers by points: if/else 12 (14 pts), boolean chains 4 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/conduit/FileAllocateConduitAPIMethod.php"},"region":{"startLine":28}}}],"partialFingerprints":{"codehealthFindingId/v1":"c4caa6af7f2f2232b81cc82f6f1cb268be9861280ccb5364d67003456c3585e8"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorFileTransformController.handleRequest (cognitive 18): PhabricatorFileTransformController.handleRequest has cognitive complexity 18 (threshold 15). Drivers by points: if/else 11 (15 pts), error handling 2 (3 pts) (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/controller/PhabricatorFileTransformController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"2b15b1e1e62ccf313ab3ea2ae24a815a45105fdb08121a558fc8a7864668cc03"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorFileAttachmentQuery.willFilterPage (cognitive 18): PhabricatorFileAttachmentQuery.willFilterPage has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (11 pts), loops 4 (6 pts), boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/query/PhabricatorFileAttachmentQuery.php"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"08fa16f0ffe624ec0958586efce2794ec70949ad5f03f71db5928422a63afed5"}},{"ruleId":"D2","level":"warning","message":{"text":"HarbormasterBuildLogRenderController.getHighlightViews (cognitive 18): HarbormasterBuildLogRenderController.getHighlightViews has cognitive complexity 18 (threshold 15). Drivers by points: if/else 9 (17 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php"},"region":{"startLine":803}}}],"partialFingerprints":{"codehealthFindingId/v1":"369925a5d919eda97cd3b027ea6f14870465c5ee06609dd66f561ed11fc0afd2"}},{"ruleId":"D2","level":"warning","message":{"text":"LegalpadDocumentSignController.readSignerInformation (cognitive 18): LegalpadDocumentSignController.readSignerInformation has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (17 pts), match/switch 1 (nesting depth added 11). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/legalpad/controller/LegalpadDocumentSignController.php"},"region":{"startLine":359}}}],"partialFingerprints":{"codehealthFindingId/v1":"2180da6ece41387cd2f13b1a9baedc826901e66da2d03a887af1235f65a49aaf"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationUninstallController.handleRequest (cognitive 18): PhabricatorApplicationUninstallController.handleRequest has cognitive complexity 18 (threshold 15). Drivers by points: if/else 11 (15 pts), error handling 1 (2 pts), boolean chains 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/meta/controller/PhabricatorApplicationUninstallController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"af0ed5343397d1c95cfe37444de970be14ce6caa4e37fb8e9ecf2805712ff222"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMetaMTAMail.getRoutingRuleMap (cognitive 18): PhabricatorMetaMTAMail.getRoutingRuleMap has cognitive complexity 18 (threshold 15). Drivers by points: if/else 5 (13 pts), loops 2 (5 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/storage/PhabricatorMetaMTAMail.php"},"region":{"startLine":1160}}}],"partialFingerprints":{"codehealthFindingId/v1":"9fdd0730631243b9ebdf1b802c4600383ebc6e18e5d240d586bc0c11bdf438b8"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorNotificationBuilder.parseStories (cognitive 18): PhabricatorNotificationBuilder.parseStories has cognitive complexity 18 (threshold 15). Drivers by points: loops 6 (11 pts), if/else 4 (7 pts) (nesting depth added 8). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/notification/builder/PhabricatorNotificationBuilder.php"},"region":{"startLine":29}}}],"partialFingerprints":{"codehealthFindingId/v1":"57f394fd92c60360cfef5b856488e60b29a0620dbf4a6963d014c18ba4af4768"}},{"ruleId":"D2","level":"warning","message":{"text":"PhamePostViewController.handleRequest (cognitive 18): PhamePostViewController.handleRequest has cognitive complexity 18 (threshold 15). Drivers by points: if/else 15 (16 pts), boolean chains 2 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/post/PhamePostViewController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"0f9b56dd4056251734f9650b4c1a208c14c92eb9e0d3de304987f834e361e2ce"}},{"ruleId":"D2","level":"warning","message":{"text":"PhortuneMerchantQuery.canViewersEditMerchants (cognitive 18): PhortuneMerchantQuery.canViewersEditMerchants has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (10 pts), loops 6 (8 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/query/PhortuneMerchantQuery.php"},"region":{"startLine":128}}}],"partialFingerprints":{"codehealthFindingId/v1":"b999879d37ce8dd2cfb52546d0dcf94f55086195c4f67c291fa93e41cedbc8d3"}},{"ruleId":"D2","level":"warning","message":{"text":"PhrictionHistoryController.handleRequest (cognitive 18): PhrictionHistoryController.handleRequest has cognitive complexity 18 (threshold 15). Drivers by points: if/else 9 (14 pts), loops 2, match/switch 1 (2 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/controller/PhrictionHistoryController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"efe6794c34431b42343279337bdeb1aa37443df2682b1ff7cb2e225597ca28c6"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectMoveController.handleRequest (cognitive 18): PhabricatorProjectMoveController.handleRequest has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (9 pts), loops 3 (7 pts), boolean chains 2 (nesting depth added 5). To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectMoveController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"e2ef66b4ef191702037e5269be565f46352d87215a2a015ac23d2b7e6eaf2e18"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectTransactionEditor.applyFinalEffects (cognitive 18): PhabricatorProjectTransactionEditor.applyFinalEffects has cognitive complexity 18 (threshold 15). Drivers by points: if/else 5 (8 pts), loops 2 (5 pts), match/switch 2 (5 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/editor/PhabricatorProjectTransactionEditor.php"},"region":{"startLine":196}}}],"partialFingerprints":{"codehealthFindingId/v1":"3ce008d0e5b4bd670b3eed36b4f4c28b368239df4da4470a43130cf1d97929e0"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryPushLogSearchEngine.newExportData (cognitive 18): PhabricatorRepositoryPushLogSearchEngine.newExportData has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (14 pts), loops 3 (4 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php"},"region":{"startLine":188}}}],"partialFingerprints":{"codehealthFindingId/v1":"85ca551feea3739392603210e797728a2b805de5802638e0297ab68f04c9c141"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorSearchDeleteController.handleRequest (cognitive 18): PhabricatorSearchDeleteController.handleRequest has cognitive complexity 18 (threshold 15). Drivers by points: if/else 13 (18 pts) (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/controller/PhabricatorSearchDeleteController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"bd0d87e72c2dd1fdaedc11c0d37e507ab0f6319968e5d6736d7f5e9e5a0f2d0e"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorFerretFulltextEngineExtension.updateStoredFields (cognitive 18): PhabricatorFerretFulltextEngineExtension.updateStoredFields has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (12 pts), loops 5 (6 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engineextension/PhabricatorFerretFulltextEngineExtension.php"},"region":{"startLine":243}}}],"partialFingerprints":{"codehealthFindingId/v1":"7c6d2a2f68a004219014f838ebcbb8e48c6e0cbf8df6b888127ce26d26b1232c"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorSlowvoteVoteController.handleRequest (cognitive 18): PhabricatorSlowvoteVoteController.handleRequest has cognitive complexity 18 (threshold 15). Drivers by points: if/else 10 (14 pts), loops 3, boolean chains 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/slowvote/controller/PhabricatorSlowvoteVoteController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"cdc6411253ae8692a6f4b1712c4794d019a6cb403cf4684c37ef4c30c06291e0"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorTypeaheadDatasource.evaluateTokens (cognitive 18): PhabricatorTypeaheadDatasource.evaluateTokens has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (13 pts), loops 3 (5 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php"},"region":{"startLine":407}}}],"partialFingerprints":{"codehealthFindingId/v1":"7b484334aa438338d932ea8bf8f29082100563cfb9c3c51e43bf815f6e4be310"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCustomField.adjustCustomFieldsForObjectSubtype (cognitive 18): PhabricatorCustomField.adjustCustomFieldsForObjectSubtype has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (15 pts), loops 2, boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/customfield/field/PhabricatorCustomField.php"},"region":{"startLine":1638}}}],"partialFingerprints":{"codehealthFindingId/v1":"948415d2e4e08293b5aee435760382a58961f37366bea5937a006e7d12b45903"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilDaemonOverseer.__construct (cognitive 18): PhutilDaemonOverseer.__construct has cognitive complexity 18 (threshold 15). Drivers by points: if/else 13 (17 pts), boolean chains 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/PhutilDaemonOverseer.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"b766f18fcb1a1cfcfcec92c795dad37f8aff442598c1242516d75534114a97a9"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilRemarkupNoteBlockRule.markupText (cognitive 18): PhutilRemarkupNoteBlockRule.markupText has cognitive complexity 18 (threshold 15). Drivers by points: if/else 12 (18 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/blockrule/PhutilRemarkupNoteBlockRule.php"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"90737c33960139af426b4700b9c95b0d00dbc9404c0e97eefd11c47880414fde"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorKeyboardRemarkupRule.markupKeystrokes (cognitive 18): PhabricatorKeyboardRemarkupRule.markupKeystrokes has cognitive complexity 18 (threshold 15). Drivers by points: if/else 10 (13 pts), loops 4 (5 pts) (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/rule/PhabricatorKeyboardRemarkupRule.php"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"f219f5516b80c5bbd700846e8f592acd897efa76381850d1796704b3ee45d08f"}},{"ruleId":"D2","level":"warning","message":{"text":"QueryFuture.isReady (cognitive 18): QueryFuture.isReady has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (8 pts), loops 4 (8 pts), boolean chains 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/future/QueryFuture.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"bef769e04f2f90a745444d969423ad42e8d155b50f641d41d3898b5ce82ce66d"}},{"ruleId":"D2","level":"warning","message":{"text":"AphrontView.reduceChildren (cognitive 18): AphrontView.reduceChildren has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (17 pts), loops 1 (nesting depth added 10). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/AphrontView.php"},"region":{"startLine":159}}}],"partialFingerprints":{"codehealthFindingId/v1":"4d4e526a0a3c5a8aefef01cfa7d2e7ea0e461ca667052a832326331d5b4ddc3c"}},{"ruleId":"D2","level":"warning","message":{"text":"AphrontFormControl.render (cognitive 18): AphrontFormControl.render has cognitive complexity 18 (threshold 15). Drivers by points: if/else 12 (13 pts), boolean chains 3, loops 1 (2 pts) (nesting depth added 2). To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/form/control/AphrontFormControl.php"},"region":{"startLine":155}}}],"partialFingerprints":{"codehealthFindingId/v1":"fdd0c68b1ed45c3c2cf2923fce2ff0b4ded68a98738e107c4d818202a6a5d860"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-global-drag-and-drop.JX.behavior(\u0022global-drag-and-drop\u0022) (cognitive 18): behavior-global-drag-and-drop.JX.behavior(\u0022global-drag-and-drop\u0022) has cognitive complexity 18 (threshold 15). Drivers by points: if/else 12 (14 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 3). Most of this is not in the body itself: 2 of the 18 points are its own statements and the rest belongs to 6 function items inside it that branch (a function literal at line 62, init, a function literal at line 39, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-global-drag-and-drop.js"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"5a7971f33672b254a35c16830b8d56a22194e3ab7c145057636a2334ba8aa1df"}},{"ruleId":"D2","level":"warning","message":{"text":"_updateAutoscroll (cognitive 18): _updateAutoscroll has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (14 pts), error handling 1 (2 pts), boolean chains 1, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/DraggableList.js"},"region":{"startLine":586}}}],"partialFingerprints":{"codehealthFindingId/v1":"754fd51558e5b9a19d794c8e5178599836888eb5213d8356eb9d353755726f22"}},{"ruleId":"D2","level":"warning","message":{"text":"_tryScroll (cognitive 18): _tryScroll has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (17 pts), loops 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/DraggableList.js"},"region":{"startLine":767}}}],"partialFingerprints":{"codehealthFindingId/v1":"81c66fa126c97a2a1650361338afa91fdd61b144734e16772336bf79be63c693"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous) (cognitive 18): (anonymous) has cognitive complexity 18 (threshold 15). Drivers by points: if/else 12 (14 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 3). Most of this is not in the body itself: 2 of the 18 points are its own statements and the rest belongs to 8 function items inside it that branch (a function literal at line 62, init, a function literal at line 39, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-global-drag-and-drop.js"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"d58156e1abb46c57f28bd31970f3bef9f6292b2a712af132230622ab91b3e2af"}},{"ruleId":"D2","level":"warning","message":{"text":"_getDropContext (cognitive 18): _getDropContext has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (14 pts), loops 3 (4 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/projects/WorkboardBoard.js"},"region":{"startLine":447}}}],"partialFingerprints":{"codehealthFindingId/v1":"52cb3a99565ae5a4211e2bc3e9850ea916946e7cde1fd37581fea785399aa4ba"}},{"ruleId":"D2","level":"warning","message":{"text":"AphrontApplicationConfiguration.processRequest (cognitive 17): AphrontApplicationConfiguration.processRequest has cognitive complexity 17 (threshold 15). Drivers by points: error handling 6 (8 pts), if/else 6 (8 pts), boolean chains 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/configuration/AphrontApplicationConfiguration.php"},"region":{"startLine":244}}}],"partialFingerprints":{"codehealthFindingId/v1":"15e05f29dc32d03849069cd4f3110d389947fce37fd3ecf7da7cf2d2103f565b"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorHighSecurityRequestExceptionHandler.handleRequestThrowable (cognitive 17): PhabricatorHighSecurityRequestExceptionHandler.handleRequestThrowable has cognitive complexity 17 (threshold 15). Drivers by points: if/else 11 (14 pts), loops 2, boolean chains 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/handler/PhabricatorHighSecurityRequestExceptionHandler.php"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"71c00d37ec903ec094344ba766a40d4a30795fd85f3a42d703a33a769014878f"}},{"ruleId":"D2","level":"warning","message":{"text":"AlmanacController.buildAlmanacPropertiesTable (cognitive 17): AlmanacController.buildAlmanacPropertiesTable has cognitive complexity 17 (threshold 15). Drivers by points: if/else 4 (7 pts), ternaries 3 (6 pts), boolean chains 2, loops 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/controller/AlmanacController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"89b1a612bbfb4ae4003481989475e19a32df0d6115fabdf0c5f0a2d54fbe87ed"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorAuditManagementWorkflow.loadCommitsWithConstraints (cognitive 17): PhabricatorAuditManagementWorkflow.loadCommitsWithConstraints has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (12 pts), boolean chains 3, loops 1 (2 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/management/PhabricatorAuditManagementWorkflow.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"e5e355663df2888684e82611c4f610f3128b4ec22847d8c6362cf659d6af1008"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorAuthManagementRefreshWorkflow.execute (cognitive 17): PhabricatorAuthManagementRefreshWorkflow.execute has cognitive complexity 17 (threshold 15). Drivers by points: if/else 10 (16 pts), loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/management/PhabricatorAuthManagementRefreshWorkflow.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"be4d52fdb0fb69c64d9f7a5ac10f212cc317ba271cc2773ae56f9370e30bf691"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCacheManagementPurgeWorkflow.execute (cognitive 17): PhabricatorCacheManagementPurgeWorkflow.execute has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (12 pts), loops 2 (3 pts), boolean chains 2 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/cache/management/PhabricatorCacheManagementPurgeWorkflow.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"87eaff51fe83aa0802d77cb894e0fd972ced7c7cac0a697ece34149664832d33"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCalendarImportEditor.applyFinalEffects (cognitive 17): PhabricatorCalendarImportEditor.applyFinalEffects has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (12 pts), match/switch 2 (4 pts), loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/editor/PhabricatorCalendarImportEditor.php"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"b077b96b8b1d5af73acd0305ff0055faaa9028a2fdf94f43eb8fc841bb76703a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilICSParser.unescapeTextValue (cognitive 17): PhutilICSParser.unescapeTextValue has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (13 pts), match/switch 1 (3 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/ics/PhutilICSParser.php"},"region":{"startLine":551}}}],"partialFingerprints":{"codehealthFindingId/v1":"025f12eccfddf0ec172c0208d0974f0149bb087e8b580eacf0d39f7b47a9d416"}},{"ruleId":"D2","level":"warning","message":{"text":"CelerityResourceTransformer.translateResourceURI (cognitive 17): CelerityResourceTransformer.translateResourceURI has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (16 pts), loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/celerity/CelerityResourceTransformer.php"},"region":{"startLine":120}}}],"partialFingerprints":{"codehealthFindingId/v1":"8e091a592d9ab6e0c906473ce581591567bf812eca3303eb2be9f9deddbcb324"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorConfigEditController.readRequest (cognitive 17): PhabricatorConfigEditController.readRequest has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (8 pts), error handling 2 (6 pts), ternaries 1 (3 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/settings/PhabricatorConfigEditController.php"},"region":{"startLine":237}}}],"partialFingerprints":{"codehealthFindingId/v1":"e3dcfb2be790e2a00068129c9fe9c85d2b05c2976b59e01dc0f1818cf44cdc85"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorConfigColumnSchema.getKeyByteLength (cognitive 17): PhabricatorConfigColumnSchema.getKeyByteLength has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (12 pts), boolean chains 4, match/switch 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/schema/PhabricatorConfigColumnSchema.php"},"region":{"startLine":102}}}],"partialFingerprints":{"codehealthFindingId/v1":"70e3cbea0a281f81280748dc72410a5e01a8fb6b8569a18784bbd4d934a09cb5"}},{"ruleId":"D2","level":"warning","message":{"text":"ConpherenceThreadParticipantsTransaction.getTitle (cognitive 17): ConpherenceThreadParticipantsTransaction.getTitle has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (14 pts), boolean chains 3 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/xaction/ConpherenceThreadParticipantsTransaction.php"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"eaea53581e80924d7f5f06622c33a54790dc6bafc258f9c29185d413a13a7bce"}},{"ruleId":"D2","level":"warning","message":{"text":"DarkConsoleCore.sanitizeForJSON (cognitive 17): DarkConsoleCore.sanitizeForJSON has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (14 pts), loops 1 (3 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/console/core/DarkConsoleCore.php"},"region":{"startLine":116}}}],"partialFingerprints":{"codehealthFindingId/v1":"66a2d84fe16ccbb71f5a22dd6b5d8acbaf377ab5b02d0a61393e388d5645c46e"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialRevisionInlinesController.renderInlineTable (cognitive 17): DifferentialRevisionInlinesController.renderInlineTable has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (14 pts), loops 2, boolean chains 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/controller/DifferentialRevisionInlinesController.php"},"region":{"startLine":72}}}],"partialFingerprints":{"codehealthFindingId/v1":"04de45b4ccde898b8130a5a9091a4a14760e6b901737e0b27df044a0d658aeaf"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialDiffEditor.validateTransaction (cognitive 17): DifferentialDiffEditor.validateTransaction has cognitive complexity 17 (threshold 15). Drivers by points: if/else 3 (11 pts), loops 2 (4 pts), match/switch 1 (2 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/editor/DifferentialDiffEditor.php"},"region":{"startLine":111}}}],"partialFingerprints":{"codehealthFindingId/v1":"7cecbb7fa293e8a5f5bbdab68657c1540a9d7d6d7edd764196c3c5a3d4563d31"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialChangesetParser.process (cognitive 17): DifferentialChangesetParser.process has cognitive complexity 17 (threshold 15). Drivers by points: boolean chains 5, if/else 4 (5 pts), error handling 2 (4 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialChangesetParser.php"},"region":{"startLine":631}}}],"partialFingerprints":{"codehealthFindingId/v1":"4e19e003933836c697f20a3989253531a04f5e62ff139fa7f105fb9261e7525d"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialLineAdjustmentMap.buildMaps (cognitive 17): DifferentialLineAdjustmentMap.buildMaps has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (9 pts), boolean chains 6, loops 2 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialLineAdjustmentMap.php"},"region":{"startLine":304}}}],"partialFingerprints":{"codehealthFindingId/v1":"8370619f4db13efd5bdc439019cdbe4297127e1f658113aaf92330184a2e62b5"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionCommitController.loadCommitState (cognitive 17): DiffusionCommitController.loadCommitState has cognitive complexity 17 (threshold 15). Drivers by points: if/else 10 (11 pts), error handling 3, loops 1 (3 pts) (nesting depth added 3). To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionCommitController.php"},"region":{"startLine":1033}}}],"partialFingerprints":{"codehealthFindingId/v1":"95b4791cabb13fdb0d8ddf248eb7935e0ee7e9502a2c51a8fc4ea9b8b7d8e62d"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionRepositoryController.buildHeaderView (cognitive 17): DiffusionRepositoryController.buildHeaderView has cognitive complexity 17 (threshold 15). Drivers by points: if/else 10 (17 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRepositoryController.php"},"region":{"startLine":270}}}],"partialFingerprints":{"codehealthFindingId/v1":"d4a844bfda3599a459f6d6d0bc4862cd9d485d2c9c137f54e1e96bb79dc91582"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionDoorkeeperCommitFeedStoryPublisher.willPublishStory (cognitive 17): DiffusionDoorkeeperCommitFeedStoryPublisher.willPublishStory has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (14 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/doorkeeper/DiffusionDoorkeeperCommitFeedStoryPublisher.php"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"ad980abeffef9f653bc95f9357efc61deac57d065e7762a61cfb4b4a5cb0a219"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionRepositoryClusterEngine.synchronizeWorkingCopyAfterWrite (cognitive 17): DiffusionRepositoryClusterEngine.synchronizeWorkingCopyAfterWrite has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (11 pts), error handling 3 (5 pts), loops 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php"},"region":{"startLine":486}}}],"partialFingerprints":{"codehealthFindingId/v1":"b787984c78caa9e482a952c62df56542e573dc86bbe22c0adfabc142b577fea2"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionCachedResolveRefsQuery.resolveGitAndMercurialRefs (cognitive 17): DiffusionCachedResolveRefsQuery.resolveGitAndMercurialRefs has cognitive complexity 17 (threshold 15). Drivers by points: if/else 4 (9 pts), loops 5 (8 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/DiffusionCachedResolveRefsQuery.php"},"region":{"startLine":61}}}],"partialFingerprints":{"codehealthFindingId/v1":"036cc561a180281ee23d9abf264fb812ca7c05d0a00aa48bfb755c3ff8b24be9"}},{"ruleId":"D2","level":"warning","message":{"text":"DivinerStaticPublisher.findAtomByRef (cognitive 17): DivinerStaticPublisher.findAtomByRef has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (14 pts), loops 2 (3 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/publisher/DivinerStaticPublisher.php"},"region":{"startLine":117}}}],"partialFingerprints":{"codehealthFindingId/v1":"fbf9a9c027454e61fbcffa31a9a5fdf243f042abe66208eaa3abf7c7759eece8"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorFile.buildFromFileData (cognitive 17): PhabricatorFile.buildFromFileData has cognitive complexity 17 (threshold 15). Drivers by points: if/else 10 (11 pts), error handling 3 (5 pts), loops 1 (nesting depth added 3). To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/storage/PhabricatorFile.php"},"region":{"startLine":326}}}],"partialFingerprints":{"codehealthFindingId/v1":"3ab0e7c3b8901a26552e616a580a0a2b9929e3dae8f60c281f6e75018bb568ef"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorGuidanceEngine.newInfoView (cognitive 17): PhabricatorGuidanceEngine.newInfoView has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (11 pts), loops 5 (6 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/guides/guidance/PhabricatorGuidanceEngine.php"},"region":{"startLine":28}}}],"partialFingerprints":{"codehealthFindingId/v1":"a73d3bb2755a53ac417472afae67c098df0edfa1010f21d76211e061808f4b13"}},{"ruleId":"D2","level":"warning","message":{"text":"HeraldTranscriptController.buildWarningPanel (cognitive 17): HeraldTranscriptController.buildWarningPanel has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (17 pts) (nesting depth added 10). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/controller/HeraldTranscriptController.php"},"region":{"startLine":186}}}],"partialFingerprints":{"codehealthFindingId/v1":"cdacbe700dfbb78c3780affaa5cf3a1104ef2436850adac527fac46fd4216b21"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMemeRemarkupRule.markupMeme (cognitive 17): PhabricatorMemeRemarkupRule.markupMeme has cognitive complexity 17 (threshold 15). Drivers by points: if/else 10 (13 pts), error handling 1 (3 pts), boolean chains 1 (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/macro/markup/PhabricatorMemeRemarkupRule.php"},"region":{"startLine":18}}}],"partialFingerprints":{"codehealthFindingId/v1":"0a350456e4ca39248a48407e95bde5d250e486abc61d10778d016776f1613c1b"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMailMailgunAdapter.sendMessage (cognitive 17): PhabricatorMailMailgunAdapter.sendMessage has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9, loops 4 (7 pts), error handling 1 (nesting depth added 3). To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/adapter/PhabricatorMailMailgunAdapter.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"131e83e0a7c0c970cc92a7802a3c4345d3deaf7764dde15a2e6281b6f88c6caf"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMailPostmarkAdapter.sendMessage (cognitive 17): PhabricatorMailPostmarkAdapter.sendMessage has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9, loops 4 (8 pts) (nesting depth added 4). To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/adapter/PhabricatorMailPostmarkAdapter.php"},"region":{"startLine":45}}}],"partialFingerprints":{"codehealthFindingId/v1":"b0bc632ad85a932a0198d9caf711bd655cb850bce8e920b41b5a3bd83d0bb022"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMailSendGridAdapter.sendMessage (cognitive 17): PhabricatorMailSendGridAdapter.sendMessage has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9, loops 4 (8 pts) (nesting depth added 4). To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/adapter/PhabricatorMailSendGridAdapter.php"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"dfc41e3d886b7b364e2337ce1b6f860adf1de5ed074749d0cdd039d20fd0ed1c"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMetaMTAApplicationEmailEditor.validateTransaction (cognitive 17): PhabricatorMetaMTAApplicationEmailEditor.validateTransaction has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (14 pts), loops 1 (2 pts), match/switch 1 (nesting depth added 10). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/editor/PhabricatorMetaMTAApplicationEmailEditor.php"},"region":{"startLine":85}}}],"partialFingerprints":{"codehealthFindingId/v1":"0e7dbb91436c04032db6bc56fbfa9a6d0a5c5080d77067b3d31f686443649aa9"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorPeopleQuery.buildWhereClauseParts (cognitive 17): PhabricatorPeopleQuery.buildWhereClauseParts has cognitive complexity 17 (threshold 15). Drivers by points: if/else 15, loops 1 (2 pts) (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/query/PhabricatorPeopleQuery.php"},"region":{"startLine":242}}}],"partialFingerprints":{"codehealthFindingId/v1":"a893ab3918a57ad006c3709cd2d20423d173581138b878257c4908f36b162eb0"}},{"ruleId":"D2","level":"warning","message":{"text":"PhrictionTransactionEditor.applyFinalEffects (cognitive 17): PhrictionTransactionEditor.applyFinalEffects has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (9 pts), loops 2 (4 pts), boolean chains 2, match/switch 1 (2 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/editor/PhrictionTransactionEditor.php"},"region":{"startLine":155}}}],"partialFingerprints":{"codehealthFindingId/v1":"34339c1e39a920d7fd986354d94c188662e479d822d32ffe649ee4e513e0f9ec"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorPolicyEditEngineExtension.buildCustomEditFields (cognitive 17): PhabricatorPolicyEditEngineExtension.buildCustomEditFields has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (16 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/editor/PhabricatorPolicyEditEngineExtension.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"9716592a92ca7351e7f9c76497bcc7d24d263ed260797668fc28ef3bc90bf03b"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorPolicyFilterSet.loadHandleViewCapabilities (cognitive 17): PhabricatorPolicyFilterSet.loadHandleViewCapabilities has cognitive complexity 17 (threshold 15). Drivers by points: loops 7 (13 pts), if/else 3 (4 pts) (nesting depth added 7). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/filter/PhabricatorPolicyFilterSet.php"},"region":{"startLine":105}}}],"partialFingerprints":{"codehealthFindingId/v1":"fb2b75cf20793e5be1fb868ba0a1e758e795ff048bf8ec0b1349570be2025cce"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectController.newApplicationCrumbs (cognitive 17): PhabricatorProjectController.newApplicationCrumbs has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (11 pts), match/switch 1 (4 pts), loops 1 (2 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectController.php"},"region":{"startLine":111}}}],"partialFingerprints":{"codehealthFindingId/v1":"2b82cb52963aa3bba237fdb966e407b2eab736d9d537e34e507e92cc3314f892"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectUIEventListener.handlePropertyEvent (cognitive 17): PhabricatorProjectUIEventListener.handlePropertyEvent has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (10 pts), loops 2 (5 pts), boolean chains 2 (nesting depth added 5). To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/events/PhabricatorProjectUIEventListener.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"0d87b3ad2924170284769a2e8c598cfde44d543480bd1e7937146eb37198ada6"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectIconSet.validateColorConfiguration (cognitive 17): PhabricatorProjectIconSet.validateColorConfiguration has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (15 pts), loops 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/icon/PhabricatorProjectIconSet.php"},"region":{"startLine":434}}}],"partialFingerprints":{"codehealthFindingId/v1":"a5b4dabaae66a2de5be4f43c30aed9f70ee3519b746af85671bb2320b806b507"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectTrigger.newTriggerRulesFromRuleSpecifications (cognitive 17): PhabricatorProjectTrigger.newTriggerRulesFromRuleSpecifications has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (12 pts), error handling 2 (4 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/storage/PhabricatorProjectTrigger.php"},"region":{"startLine":102}}}],"partialFingerprints":{"codehealthFindingId/v1":"b7df67d3da966dd56cb97834cdf42169ccf16bf5b44a829f8bba05fe1c5147a4"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProjectListView.renderList (cognitive 17): PhabricatorProjectListView.renderList has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (15 pts), boolean chains 1, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/view/PhabricatorProjectListView.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"adc1cf49538f5d8248c553387998e1d26f7343b596c723cf01d6786b36a23ec9"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepository.sortWritableAlmanacServiceRefs (cognitive 17): PhabricatorRepository.sortWritableAlmanacServiceRefs has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (11 pts), loops 3 (6 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepository.php"},"region":{"startLine":2013}}}],"partialFingerprints":{"codehealthFindingId/v1":"2bb120434f1ab93cee1ea8c420d019ec3ca8e0ce7a342a988f1168a7d453c9cc"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepository.getPassthroughEnvironmentalVariables (cognitive 17): PhabricatorRepository.getPassthroughEnvironmentalVariables has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (11 pts), loops 3 (6 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepository.php"},"region":{"startLine":2287}}}],"partialFingerprints":{"codehealthFindingId/v1":"5c21fe9f61c859abc668c23fb964ff8ab846d342a37ec96be4a533af64932550"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryTransactionType.validateRefList (cognitive 17): PhabricatorRepositoryTransactionType.validateRefList has cognitive complexity 17 (threshold 15). Drivers by points: if/else 3 (10 pts), match/switch 1 (4 pts), loops 2 (3 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/xaction/PhabricatorRepositoryTransactionType.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"33678101624ca45c35fff512ef6c7f2916e2dda3d17d7a8708d4733c05122737"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorSearchEngineAPIMethod.buildConstraintsDocumentationPage (cognitive 17): PhabricatorSearchEngineAPIMethod.buildConstraintsDocumentationPage has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (13 pts), loops 2 (4 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorSearchEngineAPIMethod.php"},"region":{"startLine":154}}}],"partialFingerprints":{"codehealthFindingId/v1":"492cc6fd31433b32258362003b50500f402b670ad8a1dab2a0d3aab83d818f88"}},{"ruleId":"D2","level":"warning","message":{"text":"FerretSearchFunction.newFerretSearchFunctions (cognitive 17): FerretSearchFunction.newFerretSearchFunctions has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (14 pts), loops 2 (3 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/ferret/function/FerretSearchFunction.php"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"0097d0cb1130150a5ad2df45068598cc97b081f0e3223af59b9caf28752ccf13"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorLinkProfileMenuItem.validateTransactions (cognitive 17): PhabricatorLinkProfileMenuItem.validateTransactions has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (15 pts), loops 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/menuitem/PhabricatorLinkProfileMenuItem.php"},"region":{"startLine":97}}}],"partialFingerprints":{"codehealthFindingId/v1":"9761c5fa164dcc1e343d3fdbf5cb59d4eb3644fd90feb44ce76f07936c30e1b5"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorSlowvoteQuery.willFilterPage (cognitive 17): PhabricatorSlowvoteQuery.willFilterPage has cognitive complexity 17 (threshold 15). Drivers by points: loops 4 (10 pts), if/else 5 (7 pts) (nesting depth added 8). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/slowvote/query/PhabricatorSlowvoteQuery.php"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"3ad13d955d2ec99d9b391ad5cc3f90f252e571f335e680917a8286240afe0e7a"}},{"ruleId":"D2","level":"warning","message":{"text":"SlowvoteEmbedView.render (cognitive 17): SlowvoteEmbedView.render has cognitive complexity 17 (threshold 15). Drivers by points: if/else 11 (15 pts), loops 2 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/slowvote/view/SlowvoteEmbedView.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"863ef812fc475ccc6a11aa2302c85c29679d67ac67eced55bce2b0d366985e11"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorEditEngine.getBuiltinEngineConfigurations (cognitive 17): PhabricatorEditEngine.getBuiltinEngineConfigurations has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (14 pts), loops 2, boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editengine/PhabricatorEditEngine.php"},"region":{"startLine":449}}}],"partialFingerprints":{"codehealthFindingId/v1":"16be66fb442cdb091ecab9941e265e0fe2611680daf92e517e4ec05915fcd27d"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorEditEngineSubtype.newSubtypeMap (cognitive 17): PhabricatorEditEngineSubtype.newSubtypeMap has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (13 pts), loops 2 (4 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editengine/PhabricatorEditEngineSubtype.php"},"region":{"startLine":259}}}],"partialFingerprints":{"codehealthFindingId/v1":"1233f2671f36ce387f102d85f72c80a7ff83ded69e63e49299ca42d3b7d57a1e"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilInRequestKeyValueCache.setKeys (cognitive 17): PhutilInRequestKeyValueCache.setKeys has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (9 pts), loops 4 (8 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/cache/PhutilInRequestKeyValueCache.php"},"region":{"startLine":61}}}],"partialFingerprints":{"codehealthFindingId/v1":"f74582bf7abaf2400ff0dd51eb800b103b4fed4f1faee191ff7f76de19142ddd"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorClusterMailersConfigType.validateStoredValue (cognitive 17): PhabricatorClusterMailersConfigType.validateStoredValue has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (10 pts), error handling 2 (4 pts), loops 2, boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/cluster/config/PhabricatorClusterMailersConfigType.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"20b53778ea5fe35f4095a6f452c405e0a20797eb8003915a6bda977de37d2190"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilDaemon.sleep (cognitive 17): PhutilDaemon.sleep has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (13 pts), boolean chains 3, loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/PhutilDaemon.php"},"region":{"startLine":158}}}],"partialFingerprints":{"codehealthFindingId/v1":"544302706ad07f22d0bb55a56a666e40dd740246f8b354b925e5a23f6bcb29f5"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorDiffScopeEngine.newLineDepthMap (cognitive 17): PhabricatorDiffScopeEngine.newLineDepthMap has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (13 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/PhabricatorDiffScopeEngine.php"},"region":{"startLine":123}}}],"partialFingerprints":{"codehealthFindingId/v1":"a6a1da0e8aa7730bdf82f101e92b94f0b98edd3cf84af36c55d582b1fa86ab64"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilProseDiff.getSummaryParts (cognitive 17): PhutilProseDiff.getSummaryParts has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (13 pts), match/switch 1 (2 pts), boolean chains 1, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/prose/PhutilProseDiff.php"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"c13f71f17509d2f25339cf6b7d516405426b708b0b6dbe6b71f1703ee7273c61"}},{"ruleId":"D2","level":"warning","message":{"text":"PhutilDefaultSyntaxHighlighterEngine.getHighlightFuture (cognitive 17): PhutilDefaultSyntaxHighlighterEngine.getHighlightFuture has cognitive complexity 17 (threshold 15). Drivers by points: if/else 12 (13 pts), boolean chains 4 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/syntax/engine/PhutilDefaultSyntaxHighlighterEngine.php"},"region":{"startLine":42}}}],"partialFingerprints":{"codehealthFindingId/v1":"758c8a342c36f219ee508ec73d67524bf9eeb7cd8a71758fb152531dccc55902"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorCursorPagedPolicyAwareQuery.buildFerretSelectClause (cognitive 17): PhabricatorCursorPagedPolicyAwareQuery.buildFerretSelectClause has cognitive complexity 17 (threshold 15). Drivers by points: if/else 10 (15 pts), loops 2 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php"},"region":{"startLine":1875}}}],"partialFingerprints":{"codehealthFindingId/v1":"b8fb52e7353600d7a4bb14a1368325a37023addbb6829097629009b9ca1443cc"}},{"ruleId":"D2","level":"warning","message":{"text":"AphrontTagView.render (cognitive 17): AphrontTagView.render has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (12 pts), loops 2, match/switch 1 (2 pts), ternaries 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/AphrontTagView.php"},"region":{"startLine":92}}}],"partialFingerprints":{"codehealthFindingId/v1":"ed2edd817ccf4d873debc3c5ef04369e14152d04c44f71bf4642c0bf624d50d0"}},{"ruleId":"D2","level":"warning","message":{"text":"PHUICurtainExtension.buildExtensionPanels (cognitive 17): PHUICurtainExtension.buildExtensionPanels has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (11 pts), loops 5 (6 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/extension/PHUICurtainExtension.php"},"region":{"startLine":48}}}],"partialFingerprints":{"codehealthFindingId/v1":"e324e4829988f032a4b78a4bfe18f6d58ff88c56616b9e372c46fc33462de984"}},{"ruleId":"D2","level":"warning","message":{"text":"PHUIButtonBarView.getTagContent (cognitive 17): PHUIButtonBarView.getTagContent has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (16 pts), loops 1 (nesting depth added 10). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIButtonBarView.php"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"ce76e01270c1c946c1a2bb70704d830716eac89f9c17835f11c1f62c6152f06b"}},{"ruleId":"D2","level":"warning","message":{"text":"PHUIFeedStoryView.render (cognitive 17): PHUIFeedStoryView.render has cognitive complexity 17 (threshold 15). Drivers by points: if/else 14 (16 pts), loops 1 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIFeedStoryView.php"},"region":{"startLine":194}}}],"partialFingerprints":{"codehealthFindingId/v1":"39d939186df053d889f3ec202c8637e99bd24d444e52e246ef489ccfcdc24a94"}},{"ruleId":"D2","level":"warning","message":{"text":"PHUIIconView.getTagAttributes (cognitive 17): PHUIIconView.getTagAttributes has cognitive complexity 17 (threshold 15). Drivers by points: if/else 10 (17 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIIconView.php"},"region":{"startLine":96}}}],"partialFingerprints":{"codehealthFindingId/v1":"ab5e68dcf8e3292f42f4c0014d857e3a9dc0486df22ec79a9d3b8af76e92c9d8"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-day-view.JX.behavior(\u0022day-view\u0022)::findTodayClusters (cognitive 17): behavior-day-view.JX.behavior(\u0022day-view\u0022)::findTodayClusters has cognitive complexity 17 (threshold 15). Drivers by points: if/else 4 (10 pts), loops 3 (6 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/calendar/behavior-day-view.js"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"8b6d47a968acf6bac0522c8691110f154a9bdc0e3e4de4dfca38757b1ddd44e0"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-batch-selector.JX.behavior(\u0022maniphest-batch-selector\u0022) (cognitive 17): behavior-batch-selector.JX.behavior(\u0022maniphest-batch-selector\u0022) has cognitive complexity 17 (threshold 15). Drivers by points: if/else 13 (14 pts), loops 2, boolean chains 1 (nesting depth added 1). None of this is in the body itself: all 17 points belong to 6 function items inside it that branch (clear_selection, a function literal at line 96, change, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/maniphest/behavior-batch-selector.js"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"58159e1759721a8560fe77de8680b8b76d25be214f465e76ebe6ab8166c980d0"}},{"ruleId":"D2","level":"warning","message":{"text":"_getCurrentTarget (cognitive 17): _getCurrentTarget has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (14 pts), boolean chains 2, loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/DraggableList.js"},"region":{"startLine":433}}}],"partialFingerprints":{"codehealthFindingId/v1":"93323cea549a0685fe2a9dddaa667fc99b74a26230f9db604c722d07693ceabd"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous)::findTodayClusters (cognitive 17): (anonymous)::findTodayClusters has cognitive complexity 17 (threshold 15). Drivers by points: if/else 4 (10 pts), loops 3 (6 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/calendar/behavior-day-view.js"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"52af76139a81860b83b4ab595ed1afb54d7e3f3b3c4133184a9bf08287703bf5"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous) (cognitive 17): (anonymous) has cognitive complexity 17 (threshold 15). Drivers by points: if/else 13 (14 pts), loops 2, boolean chains 1 (nesting depth added 1). None of this is in the body itself: all 17 points belong to 10 function items inside it that branch (clear_selection, a function literal at line 96, change, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/maniphest/behavior-batch-selector.js"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"4cd44b83f13bc48bb31242516d283ab46fab0f6b8f505cb9911a36735f522f0b"}},{"ruleId":"D2","level":"warning","message":{"text":"AlmanacManagementRegisterWorkflow.execute (cognitive 16): AlmanacManagementRegisterWorkflow.execute has cognitive complexity 16 (threshold 15). Drivers by points: if/else 14 (16 pts) (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/management/AlmanacManagementRegisterWorkflow.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"13d0dcd45d013a3d7460deea2f3a9495a71d27b3fdbb14347245a02a5692625c"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorAuditTransactionView.renderTransactionContent (cognitive 16): PhabricatorAuditTransactionView.renderTransactionContent has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (9 pts), loops 4 (5 pts), match/switch 1 (2 pts) (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/view/PhabricatorAuditTransactionView.php"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"41747dd308cb4029fe4c1ef893c44a6add93e78e30be30e65bfe3e05bc0fe60f"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorAuthProvider.renderStandardLoginButton (cognitive 16): PhabricatorAuthProvider.renderStandardLoginButton has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (14 pts), loops 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorAuthProvider.php"},"region":{"startLine":468}}}],"partialFingerprints":{"codehealthFindingId/v1":"f4ff5f4eb95e05c3181d7f1e2b60d10fab54056068db32b4bfa940d82d8d4106"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorConfigSettingsListController.handleRequest (cognitive 16): PhabricatorConfigSettingsListController.handleRequest has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (10 pts), boolean chains 5, loops 1 (nesting depth added 3). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/settings/PhabricatorConfigSettingsListController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"ee4f9038d5531004e1c304fc4e3cfd054bdc3e0187ffc3da74833f7e3fe241c0"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorConfigTransaction.getTitle (cognitive 16): PhabricatorConfigTransaction.getTitle has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (12 pts), boolean chains 3, match/switch 1 (nesting depth added 6). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident. This shape REPEATS in the file: one other method here (PhabricatorConfigTransaction.getTitleForFeed) has the same decision points, in the same order, at the same nesting depths \u2014 so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/storage/PhabricatorConfigTransaction.php"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"159813dcaff553d005786a0575b5946ce7df7134f15d6dfc708019defc0f5ae6"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorConfigTransaction.getTitleForFeed (cognitive 16): PhabricatorConfigTransaction.getTitleForFeed has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (12 pts), boolean chains 3, match/switch 1 (nesting depth added 6). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident. This shape REPEATS in the file: one other method here (PhabricatorConfigTransaction.getTitle) has the same decision points, in the same order, at the same nesting depths \u2014 so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/storage/PhabricatorConfigTransaction.php"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"aeadd1a5e8cb3c53e6f12c9d4ed506617c4ec4a45bbdbd727d07adb8f88e9678"}},{"ruleId":"D2","level":"warning","message":{"text":"ConpherenceUpdateController.renderRemovePersonDialog (cognitive 16): ConpherenceUpdateController.renderRemovePersonDialog has cognitive complexity 16 (threshold 15). Drivers by points: if/else 11 (15 pts), loops 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceUpdateController.php"},"region":{"startLine":220}}}],"partialFingerprints":{"codehealthFindingId/v1":"aa21c84499fcfee51c269e890b1724c3a85f70386f7ee58848d002d86f108e2c"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialController.buildPackageMaps (cognitive 16): DifferentialController.buildPackageMaps has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (10 pts), loops 3 (6 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/controller/DifferentialController.php"},"region":{"startLine":28}}}],"partialFingerprints":{"codehealthFindingId/v1":"231993b493a965652cd3396cb695867260016f5a1d9f708584917852e828d9bb"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialChangesetParser.loadFileObjectsForChangeset (cognitive 16): DifferentialChangesetParser.loadFileObjectsForChangeset has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (15 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialChangesetParser.php"},"region":{"startLine":1849}}}],"partialFingerprints":{"codehealthFindingId/v1":"f6abbb658fa283f32cdf4e0ed6354f641d94355486f4395e14fb867b45d839c0"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialRevisionQuery.loadReviewerAuthority (cognitive 16): DifferentialRevisionQuery.loadReviewerAuthority has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (13 pts), loops 2 (3 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/query/DifferentialRevisionQuery.php"},"region":{"startLine":1016}}}],"partialFingerprints":{"codehealthFindingId/v1":"494f157e6cc0ba13f9d78e17628755053715559c8885c218491437b4525e7be4"}},{"ruleId":"D2","level":"warning","message":{"text":"DifferentialChangesetRenderer.getChangesetProperties (cognitive 16): DifferentialChangesetRenderer.getChangesetProperties has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (14 pts), boolean chains 1, loops 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetRenderer.php"},"region":{"startLine":650}}}],"partialFingerprints":{"codehealthFindingId/v1":"1154c3ba2ceec3ed3096038be5619b9980ed4182a10a0a4df24049bb5391df30"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionLastModifiedQueryConduitAPIMethod.loadCommitsFromCache (cognitive 16): DiffusionLastModifiedQueryConduitAPIMethod.loadCommitsFromCache has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (13 pts), loops 2 (3 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/conduit/DiffusionLastModifiedQueryConduitAPIMethod.php"},"region":{"startLine":100}}}],"partialFingerprints":{"codehealthFindingId/v1":"a0b7d69da373e3bf1eca605b7807cf130a447fdbe4e3884821fce0cb9309ccd3"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionLastModifiedController.handleRequest (cognitive 16): DiffusionLastModifiedController.handleRequest has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (12 pts), loops 2, boolean chains 1, error handling 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionLastModifiedController.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"3ad0270821bae28ca99ce8795be0ab62db5cdcb0c788eac828d35bae764bdf47"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionServeController.handleRequest (cognitive 16): DiffusionServeController.handleRequest has cognitive complexity 16 (threshold 15). Drivers by points: if/else 11 (14 pts), error handling 2 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionServeController.php"},"region":{"startLine":94}}}],"partialFingerprints":{"codehealthFindingId/v1":"7dc270c4900df65ea70a044b6578646b27fa8f6de87009ef278a344180280ab0"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionGitBranch.parseRemoteBranchOutput (cognitive 16): DiffusionGitBranch.parseRemoteBranchOutput has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (15 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/data/DiffusionGitBranch.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"accb2766cde4e22fc63a9f960b142aa4f8db8f91e6fa2073c5a4f5032df7a71e"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionBrowseTableView.render (cognitive 16): DiffusionBrowseTableView.render has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (12 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/view/DiffusionBrowseTableView.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"6db6d58f5957046bd8003b1fca1c2d8606d61dced8c5be1bab03a5d67761551a"}},{"ruleId":"D2","level":"warning","message":{"text":"DiffusionCommitAuditorsTransaction.validateTransactions (cognitive 16): DiffusionCommitAuditorsTransaction.validateTransactions has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (9 pts), loops 2 (3 pts), match/switch 1 (3 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/xaction/DiffusionCommitAuditorsTransaction.php"},"region":{"startLine":177}}}],"partialFingerprints":{"codehealthFindingId/v1":"3482a85b4f78464a48eb7fd879b6d26231df5879bf6e7c30e9785e99b1f1f4bb"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorChartRenderingEngine.getStoredChart (cognitive 16): PhabricatorChartRenderingEngine.getStoredChart has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (12 pts), error handling 1 (4 pts) (nesting depth added 10). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fact/engine/PhabricatorChartRenderingEngine.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"60fbe5d3c35bf0ed268917585f8fc91d0b317612837b957fa62cfa84f222296b"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorDocumentRef.loadData (cognitive 16): PhabricatorDocumentRef.loadData has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (13 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/document/PhabricatorDocumentRef.php"},"region":{"startLine":85}}}],"partialFingerprints":{"codehealthFindingId/v1":"cb4afe90a1390fef2aac01365b890b4a321599cacb0635ab9c9ac59f00ebf2b6"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorFilesCurtainExtension.buildCurtainPanel (cognitive 16): PhabricatorFilesCurtainExtension.buildCurtainPanel has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (15 pts), loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/engineextension/PhabricatorFilesCurtainExtension.php"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"b20141798a4f7b949ef923ca610c47c029d7b4b4d21770ebc25c83172e2958f8"}},{"ruleId":"D2","level":"warning","message":{"text":"HarbormasterBuildLogRenderController.mergeOverlappingReads (cognitive 16): HarbormasterBuildLogRenderController.mergeOverlappingReads has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (12 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php"},"region":{"startLine":507}}}],"partialFingerprints":{"codehealthFindingId/v1":"10b5fa74f46b6d0e95cfa37e00422c7ae8d39b05703207327efe8633a1afe798"}},{"ruleId":"D2","level":"warning","message":{"text":"HarbormasterPlanViewController.buildStepList (cognitive 16): HarbormasterPlanViewController.buildStepList has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (11 pts), boolean chains 2, error handling 1 (2 pts), loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterPlanViewController.php"},"region":{"startLine":92}}}],"partialFingerprints":{"codehealthFindingId/v1":"ea938946dcd9c11dd6711c14f76ea178c1d077dc608bfe1716aab6fb05135ac2"}},{"ruleId":"D2","level":"warning","message":{"text":"HarbormasterTargetEngine.generateBuildStepMap (cognitive 16): HarbormasterTargetEngine.generateBuildStepMap has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (10 pts), loops 3 (6 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/engine/HarbormasterTargetEngine.php"},"region":{"startLine":62}}}],"partialFingerprints":{"codehealthFindingId/v1":"0216c8bcaea9a03ff79643730efaec72367c346f084fd5f642fd353406ee67e6"}},{"ruleId":"D2","level":"warning","message":{"text":"HarbormasterBuild.getUnprocessedMessageState (cognitive 16): HarbormasterBuild.getUnprocessedMessageState has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (13 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/storage/build/HarbormasterBuild.php"},"region":{"startLine":253}}}],"partialFingerprints":{"codehealthFindingId/v1":"f2f7bca1aee8724a0fa2088a33aa5dc993577784e88ff816fd935e6c0191515d"}},{"ruleId":"D2","level":"warning","message":{"text":"HeraldObjectTranscript.truncateValue (cognitive 16): HeraldObjectTranscript.truncateValue has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (13 pts), loops 1 (3 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/storage/transcript/HeraldObjectTranscript.php"},"region":{"startLine":70}}}],"partialFingerprints":{"codehealthFindingId/v1":"9df8867a4a8c208e78adbeecbf6b99db68b1e29e9fad8ed2df884d121bfa6136"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMacroFileTransaction.validateTransactions (cognitive 16): PhabricatorMacroFileTransaction.validateTransactions has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (15 pts), loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/macro/xaction/PhabricatorMacroFileTransaction.php"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"27115ac4f8fa9f11d615babac000dd22f431ef6dadced1cfb09ca596ad82f625"}},{"ruleId":"D2","level":"warning","message":{"text":"ManiphestTaskDetailController.handleRequest (cognitive 16): ManiphestTaskDetailController.handleRequest has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (14 pts), loops 1 (2 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/controller/ManiphestTaskDetailController.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"e55c36a953851386321dd214a5b1266489410fee536f846266ca526dc3982765"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMailEmailEngine.newEmailSubject (cognitive 16): PhabricatorMailEmailEngine.newEmailSubject has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (14 pts), boolean chains 1, loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/engine/PhabricatorMailEmailEngine.php"},"region":{"startLine":293}}}],"partialFingerprints":{"codehealthFindingId/v1":"1333c1a4fe0437d154732e51386f36c14676f9d13e8d933f90b80b82d0315ad0"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorMailReplyHandler.filterRecipientUsers (cognitive 16): PhabricatorMailReplyHandler.filterRecipientUsers has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (10 pts), loops 3 (6 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php"},"region":{"startLine":377}}}],"partialFingerprints":{"codehealthFindingId/v1":"c288375bed9f7698ba627e74e291a629b2f8449561d35670c4315f0e16ecafb9"}},{"ruleId":"D2","level":"warning","message":{"text":"NuanceItemQuery.willFilterPage (cognitive 16): NuanceItemQuery.willFilterPage has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (12 pts), loops 4 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/query/NuanceItemQuery.php"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"ba1900e54989d061c9c70b705a51b3506b1a722d89114832d9414a275f9ca7a6"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorUserLog.getRemoteAddressForViewer (cognitive 16): PhabricatorUserLog.getRemoteAddressForViewer has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (15 pts), boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/storage/PhabricatorUserLog.php"},"region":{"startLine":111}}}],"partialFingerprints":{"codehealthFindingId/v1":"67c66e874fd5527fcf6ee3e274b098f92071c06d25a345ebd90bcdf9558cc6c3"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorUserUsernameTransaction.validateTransactions (cognitive 16): PhabricatorUserUsernameTransaction.validateTransactions has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (15 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/xaction/PhabricatorUserUsernameTransaction.php"},"region":{"startLine":56}}}],"partialFingerprints":{"codehealthFindingId/v1":"a3f0269f702e13358027dc413c05017b2e9b105a99b3608ae239ba4339cd7a57"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryDiscoveryEngine.discoverStreamAncestry (cognitive 16): PhabricatorRepositoryDiscoveryEngine.discoverStreamAncestry has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (12 pts), loops 3 (4 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php"},"region":{"startLine":396}}}],"partialFingerprints":{"codehealthFindingId/v1":"f9872f3fd1e943c4adc0799592d6c3306e36d5c9ed5633cd34f9db3a35451e6a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryDiscoveryEngine.markUnreachableFrom (cognitive 16): PhabricatorRepositoryDiscoveryEngine.markUnreachableFrom has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (10 pts), loops 3 (4 pts), error handling 1 (2 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php"},"region":{"startLine":816}}}],"partialFingerprints":{"codehealthFindingId/v1":"d52d4d45fc0761e16d0f3d6d9b797698fd05d6784b9d130fcb26aa3ff674d582"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryManagementMarkImportedWorkflow.execute (cognitive 16): PhabricatorRepositoryManagementMarkImportedWorkflow.execute has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (13 pts), boolean chains 2, loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/management/PhabricatorRepositoryManagementMarkImportedWorkflow.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"f86aa5b98cb3a23411974e99d5e6b39009e3a1ea4e73d5278c57bc144042df76"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryManagementUnpublishWorkflow.unpublishCommit (cognitive 16): PhabricatorRepositoryManagementUnpublishWorkflow.unpublishCommit has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (10 pts), loops 3 (6 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/management/PhabricatorRepositoryManagementUnpublishWorkflow.php"},"region":{"startLine":75}}}],"partialFingerprints":{"codehealthFindingId/v1":"aec4fa0ff034c1befc9faa61622cd0e329d7edc5cd48deb80d62e3d261893d23"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepository.canServeProtocol (cognitive 16): PhabricatorRepository.canServeProtocol has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (15 pts), loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepository.php"},"region":{"startLine":1384}}}],"partialFingerprints":{"codehealthFindingId/v1":"6f9e45e0c44e5db60ac6ab83ffa13f68f9a8906dd0255c0947bf5281711226b0"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorRepositoryURITransaction.getTitle (cognitive 16): PhabricatorRepositoryURITransaction.getTitle has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (14 pts), boolean chains 1, match/switch 1 (nesting depth added 7). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepositoryURITransaction.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"e9fda40d39f01d947fabe6fcae4c534c69650c6d57dbdca5b4e2eedeb5e2f0fd"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationSearchEngine.readUsersFromRequest (cognitive 16): PhabricatorApplicationSearchEngine.readUsersFromRequest has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (13 pts), loops 2 (3 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorApplicationSearchEngine.php"},"region":{"startLine":740}}}],"partialFingerprints":{"codehealthFindingId/v1":"349aeb0620c4b82f890b5a26a91592a7f680fd5fa3a41251990c6a84ff6ebedc"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorProfileMenuEngine.adjustDefault (cognitive 16): PhabricatorProfileMenuEngine.adjustDefault has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (9 pts), loops 3 (4 pts), boolean chains 3 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorProfileMenuEngine.php"},"region":{"startLine":1148}}}],"partialFingerprints":{"codehealthFindingId/v1":"ef784778a8996d7c9e03748ee294fe7dc4819c5f158edc9b12a400f9d6bc6c45"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorSearchTokenizerField.getUsersFromRequest (cognitive 16): PhabricatorSearchTokenizerField.getUsersFromRequest has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (13 pts), loops 2 (3 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/field/PhabricatorSearchTokenizerField.php"},"region":{"startLine":29}}}],"partialFingerprints":{"codehealthFindingId/v1":"cb1b8287abe0ed5800fbef68aa637bead28ee7f8af24a389a6fd0cb9e3ecfe8a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorElasticFulltextStorageEngine.check (cognitive 16): PhabricatorElasticFulltextStorageEngine.check has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (15 pts), loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/fulltextstorage/PhabricatorElasticFulltextStorageEngine.php"},"region":{"startLine":423}}}],"partialFingerprints":{"codehealthFindingId/v1":"f8dd917471b5ffac9ed089e4bcbe16b2da05239ce036ac1996a865ad0ef32722"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorEditEngineConfigurationLockController.handleRequest (cognitive 16): PhabricatorEditEngineConfigurationLockController.handleRequest has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (15 pts), loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/controller/PhabricatorEditEngineConfigurationLockController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"e9ac390402e2a9b7c14e10e84df3f7aadd6657002b7f6fd14c780781a79eaea3"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorEditEngineConfigurationSortController.handleRequest (cognitive 16): PhabricatorEditEngineConfigurationSortController.handleRequest has cognitive complexity 16 (threshold 15). Drivers by points: if/else 10 (12 pts), loops 3 (4 pts) (nesting depth added 3). To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/controller/PhabricatorEditEngineConfigurationSortController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"9465d4ea47413f19b573d55eba39083cb3982a00778e9f0d5f0d96b397e8391b"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorEditEngine.buildEditFields (cognitive 16): PhabricatorEditEngine.buildEditFields has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (10 pts), loops 4 (6 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editengine/PhabricatorEditEngine.php"},"region":{"startLine":149}}}],"partialFingerprints":{"codehealthFindingId/v1":"3b695fa0adf98aa5901bff04f8c88850cbc39c07f3d2ad1c4935fa05fc868e83"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorEditEngine.buildEditEngineCommentView (cognitive 16): PhabricatorEditEngine.buildEditEngineCommentView has cognitive complexity 16 (threshold 15). Drivers by points: if/else 10 (15 pts), loops 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editengine/PhabricatorEditEngine.php"},"region":{"startLine":1625}}}],"partialFingerprints":{"codehealthFindingId/v1":"35d0bdf111abb16301cedcf53cb937023772d9e3fb316861f1b68bea9624dd83"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransactionEditor.newFileTransactionInternalValues (cognitive 16): PhabricatorApplicationTransactionEditor.newFileTransactionInternalValues has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (13 pts), loops 2, boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":428}}}],"partialFingerprints":{"codehealthFindingId/v1":"4a63a758e2c01acc2e0d48647c6d660f3d44877631def73a98c0867e770422ff"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransactionEditor.getLegacyRequiredCapabilities (cognitive 16): PhabricatorApplicationTransactionEditor.getLegacyRequiredCapabilities has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (11 pts), loops 2 (4 pts), match/switch 1 (nesting depth added 9). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":1899}}}],"partialFingerprints":{"codehealthFindingId/v1":"74b24f613546d742d6af60155fd1e995febd6f2f2d37b269de1c28ee93ffe2cf"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransactionEditor.validateSpaceTransactions (cognitive 16): PhabricatorApplicationTransactionEditor.validateSpaceTransactions has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (15 pts), loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":3098}}}],"partialFingerprints":{"codehealthFindingId/v1":"36db199937eba4b85e3cee88f138ef59ba776621aa8c3aa90c5a3f6c6a5cd18f"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorApplicationTransactionQuery.loadPage (cognitive 16): PhabricatorApplicationTransactionQuery.loadPage has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (11 pts), loops 3 (5 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/query/PhabricatorApplicationTransactionQuery.php"},"region":{"startLine":104}}}],"partialFingerprints":{"codehealthFindingId/v1":"183131e60993a17ba337133036de716e6c912eed8ca5922b5b06e9a5a0663871"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorClusterSearchConfigType.validateValue (cognitive 16): PhabricatorClusterSearchConfigType.validateValue has cognitive complexity 16 (threshold 15). Drivers by points: error handling 2 (6 pts), if/else 3 (6 pts), loops 2 (4 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/cluster/config/PhabricatorClusterSearchConfigType.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"cee2b4a6a2d7513adc3dd193ff5e026a7593a87cf23de44320a2b18ca71fe8de"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorWorkerManagementExecuteWorkflow.execute (cognitive 16): PhabricatorWorkerManagementExecuteWorkflow.execute has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (15 pts), loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementExecuteWorkflow.php"},"region":{"startLine":29}}}],"partialFingerprints":{"codehealthFindingId/v1":"8360e8929f9780d463f5fbd38976e164a859e3f4b8e26c8f0628e7b454dc954d"}},{"ruleId":"D2","level":"warning","message":{"text":"PHUIDiffTableOfContentsListView.newTreeVector (cognitive 16): PHUIDiffTableOfContentsListView.newTreeVector has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (10 pts), loops 2 (3 pts), match/switch 1 (2 pts), boolean chains 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/view/PHUIDiffTableOfContentsListView.php"},"region":{"startLine":299}}}],"partialFingerprints":{"codehealthFindingId/v1":"6069a86266bc3849487e33ca8fedca7f3b6ab8b0b8074e7a2e64894bcc8f6fea"}},{"ruleId":"D2","level":"warning","message":{"text":"ManiphestTaskGraph.newTableRow (cognitive 16): ManiphestTaskGraph.newTableRow has cognitive complexity 16 (threshold 15). Drivers by points: if/else 11 (15 pts), boolean chains 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/graph/ManiphestTaskGraph.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"e40a517fa2507f2a4347ba3ac65feb20cab7dee615519217b6c9a9755ec19063"}},{"ruleId":"D2","level":"warning","message":{"text":"LiskDAO.applyLiskDataSerialization (cognitive 16): LiskDAO.applyLiskDataSerialization has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (11 pts), match/switch 1 (3 pts), loops 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/lisk/LiskDAO.php"},"region":{"startLine":1547}}}],"partialFingerprints":{"codehealthFindingId/v1":"fd0317ef117483dea3b62ae095682b6b5ca1e6dee198ccba795f37e7e2d17455"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorLiskDAO.newClusterConnection (cognitive 16): PhabricatorLiskDAO.newClusterConnection has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (14 pts), boolean chains 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/lisk/PhabricatorLiskDAO.php"},"region":{"startLine":85}}}],"partialFingerprints":{"codehealthFindingId/v1":"7f4d6a1c15e7145d46f8701ebad4405e0204ce2aa41a1b53ddb57e6a856719a1"}},{"ruleId":"D2","level":"warning","message":{"text":"AphrontMultiColumnView.render (cognitive 16): AphrontMultiColumnView.render has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (14 pts), boolean chains 1, loops 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/layout/AphrontMultiColumnView.php"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"b6dd2a3a1a35e657bb7bfe2cfadc980b021b5eabbd795d627c8ce5e2892e69f9"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorStandardPageView.getBodyClasses (cognitive 16): PhabricatorStandardPageView.getBodyClasses has cognitive complexity 16 (threshold 15). Drivers by points: if/else 11 (15 pts), loops 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/page/PhabricatorStandardPageView.php"},"region":{"startLine":603}}}],"partialFingerprints":{"codehealthFindingId/v1":"aaea46f4c2cc4ec4137bd3b334ea9ecbe895214d4f43f0b1d7316c500cae044b"}},{"ruleId":"D2","level":"warning","message":{"text":"PHUIObjectItemListView.getTagContent (cognitive 16): PHUIObjectItemListView.getTagContent has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (9 pts), loops 3 (6 pts), boolean chains 1 (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIObjectItemListView.php"},"region":{"startLine":117}}}],"partialFingerprints":{"codehealthFindingId/v1":"f1165f83c15e6ce8e21ee795d6493bda72a3f999118e39946432febbe7d78bb0"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorClientLimit.getScore (cognitive 16): PhabricatorClientLimit.getScore has cognitive complexity 16 (threshold 15). Drivers by points: if/else 10 (14 pts), loops 2 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"support/startup/PhabricatorClientLimit.php"},"region":{"startLine":234}}}],"partialFingerprints":{"codehealthFindingId/v1":"520cd471f7ca92eeef67fcac474e12bab1ebaf545d27eb63f59e1734116dc28a"}},{"ruleId":"D2","level":"warning","message":{"text":"PhabricatorStartup.onDebugTick (cognitive 16): PhabricatorStartup.onDebugTick has cognitive complexity 16 (threshold 15). Drivers by points: ternaries 4 (12 pts), if/else 2, loops 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"support/startup/PhabricatorStartup.php"},"region":{"startLine":279}}}],"partialFingerprints":{"codehealthFindingId/v1":"9dc94f82364bccc950425cb38c9794baef7890c1ff4ee071fc12a506032ac55d"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-dashboard-query-panel-select.JX.behavior(\u0022dashboard-query-panel-select\u0022) (cognitive 16): behavior-dashboard-query-panel-select.JX.behavior(\u0022dashboard-query-panel-select\u0022) has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (12 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 7). Of this number, 10 points are the body\u0027s own statements and 6 belong to one function item inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/dashboard/behavior-dashboard-query-panel-select.js"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"8d51a677c0a31ca466e75956fe6289f7a5c5b9722fa978c275cd8cf0832a7cbf"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-pholio-mock-edit.JX.behavior(\u0022pholio-mock-edit\u0022) (cognitive 16): behavior-pholio-mock-edit.JX.behavior(\u0022pholio-mock-edit\u0022) has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (9 pts), loops 5, boolean chains 2 (nesting depth added 1). Most of this is not in the body itself: 1 of the 16 points is its own statement and the rest belongs to 9 function items inside it that branch (a function literal at line 99, update_statics, a function literal at line 272, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/pholio/behavior-pholio-mock-edit.js"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"6e279894c14b0487c78c98d594be1d75908384abbd5088e2b7c603e736a30c84"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-gesture.JX.behavior(\u0022phabricator-gesture\u0022) (cognitive 16): behavior-gesture.JX.behavior(\u0022phabricator-gesture\u0022) has cognitive complexity 16 (threshold 15). Drivers by points: if/else 11 (15 pts), ternaries 1 (nesting depth added 4). None of this is in the body itself: all 16 points belong to 4 function items inside it that branch (a function literal at line 50, a function literal at line 25, a function literal at line 92, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-gesture.js"},"region":{"startLine":15}}}],"partialFingerprints":{"codehealthFindingId/v1":"fbec3030cb464f12c9bcc8f642a97fbf3a4d25981cf38eec3443af811cbf42b5"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-oncopy.JX.behavior(\u0022phabricator-oncopy\u0022)::onstartselect (cognitive 16): behavior-oncopy.JX.behavior(\u0022phabricator-oncopy\u0022)::onstartselect has cognitive complexity 16 (threshold 15). Drivers by points: if/else 11 (12 pts), error handling 3, boolean chains 1 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages. This shape REPEATS in the file: one other method here (behavior-oncopy.JX.behavior(\u0022phabricator-oncopy\u0022)::extract_text) has the same decision points, in the same order, at the same nesting depths \u2014 so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-oncopy.js"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"3a732de2ba984f81cf1359c80e36ac0f5e9189a66742b1db4d954b05f671afcb"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-oncopy.JX.behavior(\u0022phabricator-oncopy\u0022)::extract_text (cognitive 16): behavior-oncopy.JX.behavior(\u0022phabricator-oncopy\u0022)::extract_text has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (12 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (behavior-oncopy.JX.behavior(\u0022phabricator-oncopy\u0022)::onstartselect) has the same decision points, in the same order, at the same nesting depths \u2014 so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-oncopy.js"},"region":{"startLine":250}}}],"partialFingerprints":{"codehealthFindingId/v1":"e2c4eff08aebd2e6c79f42648107560c48070222c55079466c09f4105e04bf2c"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-refresh-csrf.JX.behavior(\u0022refresh-csrf\u0022) (cognitive 16): behavior-refresh-csrf.JX.behavior(\u0022refresh-csrf\u0022) has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (12 pts), loops 2, match/switch 2 (nesting depth added 3). None of this is in the body itself: all 16 points belong to 6 function items inside it that branch (redraw_bar, a function literal at line 36, a function literal at line 121, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-refresh-csrf.js"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"350028444a3ddd8e020ce6504d62a92c082583ce36d9494227b9e26b5b78198d"}},{"ruleId":"D2","level":"warning","message":{"text":"behavior-search-typeahead.JX.behavior(\u0022phabricator-search-typeahead\u0022)::sort_handler (cognitive 16): behavior-search-typeahead.JX.behavior(\u0022phabricator-search-typeahead\u0022)::sort_handler has cognitive complexity 16 (threshold 15). Drivers by points: if/else 3 (7 pts), loops 4 (5 pts), boolean chains 4 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-search-typeahead.js"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"beaef8a2ed38b52471af3b63b81a23202575f00ae6eede9b62e5bd4bf89f92f5"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous) (cognitive 16): (anonymous) has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (10 pts), boolean chains 3, loops 2, ternaries 1 (nesting depth added 1). None of this is in the body itself: all 16 points belong to 5 function items inside it that branch (a function literal at line 18, a function literal at line 57, will_submit, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-form.js"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"117ce260132ce3321d977eeb2bd9399613809b3dddf20319aab1252e6dea8404"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous) (cognitive 16): (anonymous) has cognitive complexity 16 (threshold 15). Drivers by points: if/else 11 (15 pts), ternaries 1 (nesting depth added 4). None of this is in the body itself: all 16 points belong to 5 function items inside it that branch (a function literal at line 50, a function literal at line 25, a function literal at line 92, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-gesture.js"},"region":{"startLine":15}}}],"partialFingerprints":{"codehealthFindingId/v1":"088c83de115f2c6927dbd156822986adca34dad5dc03e48ae0115c597c817430"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous)::onstartselect (cognitive 16): (anonymous)::onstartselect has cognitive complexity 16 (threshold 15). Drivers by points: if/else 11 (12 pts), error handling 3, boolean chains 1 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-oncopy.js"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"460f55c819c6bdc95a636e93a4736e7cf09215764aca6634e6bd86111749ed67"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous)::extract_text (cognitive 16): (anonymous)::extract_text has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (12 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-oncopy.js"},"region":{"startLine":250}}}],"partialFingerprints":{"codehealthFindingId/v1":"daf477a5dc006df3e0553a4d3913513db9667839a47e7c625c728b2870f36924"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous) (cognitive 16): (anonymous) has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (12 pts), loops 2, match/switch 2 (nesting depth added 3). None of this is in the body itself: all 16 points belong to 8 function items inside it that branch (redraw_bar, a function literal at line 36, a function literal at line 121, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-refresh-csrf.js"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"01f942e6953afdf40239c7e750f266bc221ee6b59a8dfed20b994d977133c8f4"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous)::sort_handler (cognitive 16): (anonymous)::sort_handler has cognitive complexity 16 (threshold 15). Drivers by points: if/else 3 (7 pts), loops 4 (5 pts), boolean chains 4 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-search-typeahead.js"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"c855c8f08c0810032ef6139c193acbe814e3edf4c47b9440079c7100d4e9ede6"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous) (cognitive 16): (anonymous) has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (12 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 7). Of this number, 10 points are the body\u0027s own statements and 6 belong to 2 function items inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/dashboard/behavior-dashboard-query-panel-select.js"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"86bb73debc91a20d511e72d085617167c65654d21fe86e590a4f1afeaadda7e2"}},{"ruleId":"D2","level":"warning","message":{"text":"matchTree (cognitive 16): matchTree has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (15 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diffusion/DiffusionLocateFileSource.js"},"region":{"startLine":165}}}],"partialFingerprints":{"codehealthFindingId/v1":"f930dd83a66adca0027db9f9a18a0760ac7d42fbc128029f2811c6b6d50ffde1"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous) (cognitive 16): (anonymous) has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (9 pts), loops 5, boolean chains 2 (nesting depth added 1). Most of this is not in the body itself: 1 of the 16 points is its own statement and the rest belongs to 29 function items inside it that branch (a function literal at line 99, update_statics, a function literal at line 272, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/pholio/behavior-pholio-mock-edit.js"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"6c0d13562646352635a2953928704dbdfb76260ddf0138c693d4f8b883f5bc1f"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous)::openSearch (cognitive 16): (anonymous)::openSearch has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (10 pts), boolean chains 6 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/repository/repository-crossreference.js"},"region":{"startLine":123}}}],"partialFingerprints":{"codehealthFindingId/v1":"e5cbb956f402a389bc29f3643dd308f22a3b9829de0136f9f7cee4d96fc3c54e"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorUSEnglishTranslation.getTranslations: MethodTooLong \u2014 getTranslations runs 1109 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 1009 over it, 11.09\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"72ae3b823e408bacfa109950d71833027f13df8d1c2e7cd9b8465243231a976f"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorApplicationTransactionEditor: ClassTooLong \u2014 3239 significant lines (blank, comment-only and punctuation-only lines excluded), 192 methods. The bar is 400 significant lines; this is 2839 over it, 8.10\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"54bc2dae6c159e5d3f10be574a0f73dec16fbb10835428a3b79549ead26cceb4"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: editor/PhabricatorApplicationTransactionEditor.php: FileTooLong \u2014 3240 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorApplicationTransactionEditor (40-5747). The bar is 500 significant lines; this is 2740 over it, 6.48\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"02e56b30530eca70a25b59a9c836381d1795ba7697fa0133da401249885c2a75"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorApplicationTransactionEditor: TooManyMethods \u2014 192 methods. The bar is 30 methods; this is 162 over it, 6.40\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"bbf740ecb4163e0671f6ede53ec849c51f69662314bed2ca7b9ee040c0ff658f"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorRepository: TooManyMethods \u2014 165 methods. The bar is 30 methods; this is 135 over it, 5.50\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepository.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"039f8799fb44c338c8155d42e851311e992583bbf4ddffc7779eb165ab52d5e7"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: behavior-pholio-mock-view.JX.behavior(\u0022pholio-mock-view\u0022): FunctionTooLong \u2014 JX.behavior(\u0022pholio-mock-view\u0022) runs 517 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 417 over it, 5.17\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"1adb15c06e274cceded0026bbebd95b5b622a1a209f84e5c6d2f3050d7108bf8"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorCursorPagedPolicyAwareQuery: ClassTooLong \u2014 1852 significant lines (blank, comment-only and punctuation-only lines excluded), 94 methods. The bar is 400 significant lines; this is 1452 over it, 4.63\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"11415b5747589a1abf788c5448f03fd06263b7d9bf667e0605002cfbfb95a508"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorAuthRegisterController.handleRequest: MethodTooLong \u2014 handleRequest runs 450 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 350 over it, 4.50\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthRegisterController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"d594fc9713322c632978cb2253253d4765ced820cf5dca76d11191e95a69c1a3"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DifferentialRevisionViewController.handleRequest: MethodTooLong \u2014 handleRequest runs 442 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 342 over it, 4.42\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/controller/DifferentialRevisionViewController.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"6d28e683bcbdd0bdf06553aa6785e37b59ca2f04e5d6ca2c50a34c0da1d9acb1"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorEditEngine: TooManyMethods \u2014 132 methods. The bar is 30 methods; this is 102 over it, 4.40\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editengine/PhabricatorEditEngine.php"},"region":{"startLine":15}}}],"partialFingerprints":{"codehealthFindingId/v1":"1e902c00fa73e5713274fcf73ba8fdf75d49acd915709c1b2fcbf6731d26dc8e"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorRepository: ClassTooLong \u2014 1657 significant lines (blank, comment-only and punctuation-only lines excluded), 165 methods. The bar is 400 significant lines; this is 1257 over it, 4.14\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepository.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"33b5e8004e8998b3aaf0902d94a5a1580806c8a73de7c47ff216c6d14c4c4c1d"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorEditField: TooManyMethods \u2014 118 methods. The bar is 30 methods; this is 88 over it, 3.93\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editfield/PhabricatorEditField.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"c4b4cdc670be58f26bdb90f33593b1167eaeabbabfb159b1fb999ef163bdf339"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorEditEngine: ClassTooLong \u2014 1565 significant lines (blank, comment-only and punctuation-only lines excluded), 132 methods. The bar is 400 significant lines; this is 1165 over it, 3.91\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editengine/PhabricatorEditEngine.php"},"region":{"startLine":15}}}],"partialFingerprints":{"codehealthFindingId/v1":"c120415d2c09b681c5d0a0dd34b574c84a225ff9315a9a35e51ac1a082ef8163"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorManiphestConfigOptions.getOptions: MethodTooLong \u2014 getOptions runs 391 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 291 over it, 3.91\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"5c2419719aecbf7baf253f59a99d6e1ad2c91e917c938a435a93ee03d502e63b"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorBuiltinPatchList.getOldPatches: MethodTooLong \u2014 getOldPatches runs 387 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 287 over it, 3.87\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/patch/PhabricatorBuiltinPatchList.php"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"8fd6a99e9c59efa323d3581fdf538c85744a19af4a7c9209c2e573f5c63a14a4"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: policy/PhabricatorCursorPagedPolicyAwareQuery.php: FileTooLong \u2014 1853 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorCursorPagedPolicyAwareQuery (16-3283). The bar is 500 significant lines; this is 1353 over it, 3.71\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"af5af31cd058579de9a7a01314da05b287c62ed7fd8b9cfd3aac54abeaaafe08"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DiffusionCommitController.handleRequest: MethodTooLong \u2014 handleRequest runs 367 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 267 over it, 3.67\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionCommitController.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"136ac1fea197437b1b23cdd218b4affa9ffe7fc56e6a01f25f0087db5814a5b8"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorCustomField: TooManyMethods \u2014 109 methods. The bar is 30 methods; this is 79 over it, 3.63\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/customfield/field/PhabricatorCustomField.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"8e0eaef42bd5235cd0b7ac6e0ec378a34766509c3eeedca6a324eb6a22b29bbc"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorMetaMTAMail: TooManyMethods \u2014 106 methods. The bar is 30 methods; this is 76 over it, 3.53\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/storage/PhabricatorMetaMTAMail.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"516b6de0fd7c42a5b7481c559524f9c0e541dab315add3d915df7b98bfc0112e"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorApplicationTransaction: ClassTooLong \u2014 1373 significant lines (blank, comment-only and punctuation-only lines excluded), 101 methods. The bar is 400 significant lines; this is 973 over it, 3.43\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorApplicationTransaction.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"6a53d72dcb5ef3c8a3dbc8668662048d15924a358df2e800ab7494117a9ac924"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PHUIObjectItemView.getTagContent: MethodTooLong \u2014 getTagContent runs 343 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 243 over it, 3.43\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIObjectItemView.php"},"region":{"startLine":383}}}],"partialFingerprints":{"codehealthFindingId/v1":"0e7f04fbb143148f66352904e85f347d0f0c39e11bab5474e739a8bc73f94232"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: diff/DiffChangesetList.js: FileTooLong \u2014 1689 significant lines (blank, comment-only and punctuation-only lines excluded; the length bar is tripled for a single-responsibility module of 4 or fewer top-level units). The bar is 1500 significant lines; this is 189 over it, 1.13\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"d22e5f91aa9771b56b11703a9b811bb7a73a1dc27c67709cd9ce7359253899da"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorFile: TooManyMethods \u2014 101 methods. The bar is 30 methods; this is 71 over it, 3.37\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/storage/PhabricatorFile.php"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"a77afe5ef50c9d641478b17a7710a1e66b892e335ec9c6a1bc9c47a6d1a8167b"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorApplicationTransaction: TooManyMethods \u2014 101 methods. The bar is 30 methods; this is 71 over it, 3.37\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorApplicationTransaction.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"f67fcea34deda0561a6c093c580aa23cb99cf192c3d91de9c12452bc988b2c23"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: storage/PhabricatorRepository.php: FileTooLong \u2014 1658 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorRepository (8-2886). The bar is 500 significant lines; this is 1158 over it, 3.32\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepository.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"dcbf36bdc2f721f05bbf62fc2345a5c42ce4b5ffadf559c12bc9384f11a8d8de"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorApplicationTransaction.getTitle: MethodTooLong \u2014 getTitle runs 330 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 230 over it, 3.30\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorApplicationTransaction.php"},"region":{"startLine":943}}}],"partialFingerprints":{"codehealthFindingId/v1":"48ea58c0d80a31e54ec5e64b466c09e3fc8083f8f21d44dbcf217ad37ca48aad"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorUser: TooManyMethods \u2014 98 methods. The bar is 30 methods; this is 68 over it, 3.27\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/storage/PhabricatorUser.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"34a8957f7ee87a48e3223f9cedea9071eeb19f67bcf0b7f4ee4192b7fd3e2840"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorCursorPagedPolicyAwareQuery: TooManyMethods \u2014 94 methods. The bar is 30 methods; this is 64 over it, 3.13\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"ae7da4ae5068bbacb3e4537a22323c44d1c191767519c1d7da14490ee1b4f68b"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: editengine/PhabricatorEditEngine.php: FileTooLong \u2014 1566 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorEditEngine (15-2753). The bar is 500 significant lines; this is 1066 over it, 3.13\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editengine/PhabricatorEditEngine.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"31b888fc389f3ad7cf49494912a4cd90f283859d2c954da1480cde9b986c4803"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorCalendarEvent: TooManyMethods \u2014 93 methods. The bar is 30 methods; this is 63 over it, 3.10\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/storage/PhabricatorCalendarEvent.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"fc76c4c4fedfd374414bbbbc928d43dc3c9c4ebbe3d3a439bfc3cb8cdd811e76"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: DifferentialRevision: TooManyMethods \u2014 93 methods. The bar is 30 methods; this is 63 over it, 3.10\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialRevision.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"f8e752e5c6b66eecf62359a3d6d0ae3a905fd90f1005b0756a7de7badaf7f234"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DiffusionRepositoryEditEngine.buildCustomEditFields: MethodTooLong \u2014 buildCustomEditFields runs 305 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 205 over it, 3.05\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php"},"region":{"startLine":207}}}],"partialFingerprints":{"codehealthFindingId/v1":"53dac81d19581330f4aae6252e22f5dcb080a7daff2b38137291229482068a5a"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: HeraldAdapter: TooManyMethods \u2014 91 methods. The bar is 30 methods; this is 61 over it, 3.03\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/adapter/HeraldAdapter.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"6a6780e224282f22023300e027efaf73fdaac1ba7d7b4cd79730737d93887a20"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorAuthEditController.handleRequest: MethodTooLong \u2014 handleRequest runs 302 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 202 over it, 3.02\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/config/PhabricatorAuthEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"f0d956a2d62107914547caa2a9641c06c327446665c087e2c6ba15002e57b607"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: DifferentialChangesetRenderer: TooManyMethods \u2014 90 methods. The bar is 30 methods; this is 60 over it, 3.00\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetRenderer.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"28e0cee1fb4b45ee0210bef0f65f12fdb921a72ea23a6307be41a789b8dd37fa"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorMySQLSetupCheck.executeRefChecks: MethodTooLong \u2014 executeRefChecks runs 300 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 200 over it, 3.00\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/check/PhabricatorMySQLSetupCheck.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"30f5e44fe4f63d3d6bb4ea85bb2533ce3cbd746e5c3682743815622951a567e7"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhutilCalendarRecurrenceRule: ClassTooLong \u2014 1188 significant lines (blank, comment-only and punctuation-only lines excluded), 68 methods. The bar is 400 significant lines; this is 788 over it, 2.97\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"ab82055b704e1405c9af747462bbedff8f63e6cf066ce7e6d65f41d29287f2dd"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorApplicationSearchEngine: TooManyMethods \u2014 89 methods. The bar is 30 methods; this is 59 over it, 2.97\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorApplicationSearchEngine.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"622a6f17c3d3b3281ab64fa7b1fad491035fd4c5bb96da698f7a3826ebcd4a21"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PholioMockEditController.handleRequest: MethodTooLong \u2014 handleRequest runs 292 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 192 over it, 2.92\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/pholio/controller/PholioMockEditController.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"7e00fd057ac268d23567b7f732e3bb11d9eef054611a261ddd734e62738b79f1"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: HarbormasterBuildLogRenderController.handleRequest: MethodTooLong \u2014 handleRequest runs 290 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 190 over it, 2.90\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"de34a00278cac33f0b3e4d13699f90b2559696f47e55692bee35e55da81c0f77"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: DifferentialChangesetParser: ClassTooLong \u2014 1153 significant lines (blank, comment-only and punctuation-only lines excluded), 75 methods. The bar is 400 significant lines; this is 753 over it, 2.88\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialChangesetParser.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"78cf88ca3155c942a8c9ef430fe552e5a1601e8ddb88dfa84f8901bfc9a28f02"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorExtraConfigSetupCheck.getAncientConfig: MethodTooLong \u2014 getAncientConfig runs 288 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 188 over it, 2.88\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/check/PhabricatorExtraConfigSetupCheck.php"},"region":{"startLine":207}}}],"partialFingerprints":{"codehealthFindingId/v1":"0a373db4dadaaf5dbdda4b767286f06e8c77c5411f8d1f6e0a702f09e2a66ae7"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorRepositoryCommit: TooManyMethods \u2014 86 methods. The bar is 30 methods; this is 56 over it, 2.87\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepositoryCommit.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"575c60993b580e04a9c999c66de47bae8cca23399a8ffdee0d7ade86e0e6bb4f"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhrictionDocumentController.handleRequest: MethodTooLong \u2014 handleRequest runs 286 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 186 over it, 2.86\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/controller/PhrictionDocumentController.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"c25aa1f995135b9cfac53a89eec996337aa4ef156f101e4293504f33c443728f"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PHUIDiffInlineCommentDetailView.render: MethodTooLong \u2014 render runs 286 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 186 over it, 2.86\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php"},"region":{"startLine":78}}}],"partialFingerprints":{"codehealthFindingId/v1":"46f41e1e8092e1589227deb989d9a1a266a5fb33025ddaa3a463222048697ee5"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: behavior-document-engine.JX.behavior(\u0022document-engine\u0022): FunctionTooLong \u2014 JX.behavior(\u0022document-engine\u0022) runs 284 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 184 over it, 2.84\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/files/behavior-document-engine.js"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"69a39474f3928143f3b66717ef873cd34702cba625e1786b93be3508d5e81c3b"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhrictionEditController.handleRequest: MethodTooLong \u2014 handleRequest runs 282 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 182 over it, 2.82\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/controller/PhrictionEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"0fa9d65dd351b5fc775bfbef1b4fcac562184b3b00d2143942a0beadbd91d3aa"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: behavior-fancy-datepicker.JX.behavior(\u0022fancy-datepicker\u0022): FunctionTooLong \u2014 JX.behavior(\u0022fancy-datepicker\u0022) runs 282 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 182 over it, 2.82\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-fancy-datepicker.js"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"1c938444369407ec4f4b4c78f54235cb46f5a1f2689999d7a7314420804998d9"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DiffusionRepositoryBasicsManagementPanel.buildRepositoryStatus: MethodTooLong \u2014 buildRepositoryStatus runs 279 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 179 over it, 2.79\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php"},"region":{"startLine":336}}}],"partialFingerprints":{"codehealthFindingId/v1":"c1165bb081ba8de2844faaddb26ce72ee73a9eb92d0a8171a6eef7641168ccac"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorUSEnglishTranslation: ClassTooLong \u2014 1113 significant lines (blank, comment-only and punctuation-only lines excluded), 2 methods. The bar is 400 significant lines; this is 713 over it, 2.78\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"ff875ede031b9749699282839ccecf72bb0fa6f1c6d2347a0f1f7a61706d8e71"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorStorageManagementWorkflow.doAdjustSchemata: MethodTooLong \u2014 doAdjustSchemata runs 275 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 175 over it, 2.75\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php"},"region":{"startLine":159}}}],"partialFingerprints":{"codehealthFindingId/v1":"ae7a17c86876e70bd11f8ee3532f325c1b0187d04cd5589ee0658246e8a2ad61"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: storage/PhabricatorApplicationTransaction.php: FileTooLong \u2014 1374 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorApplicationTransaction (3-2036). The bar is 500 significant lines; this is 874 over it, 2.75\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorApplicationTransaction.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"d4f4d35e21bf7e7c53c700015642f035069e3c6780939d75f0f257505849ff09"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorTypeaheadModularDatasourceController.handleRequest: MethodTooLong \u2014 handleRequest runs 273 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 173 over it, 2.73\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"e32b86c3811d037c9f22fabd2ea871615364e2c9c790c353f9179da6b358066b"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PassphraseCredentialEditController.handleRequest: MethodTooLong \u2014 handleRequest runs 269 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 169 over it, 2.69\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/passphrase/controller/PassphraseCredentialEditController.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"decd0af881a3cffd67be704b17a854fe40e9f17841ce51766fe696aee4eb834a"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: LiskDAO: TooManyMethods \u2014 80 methods. The bar is 30 methods; this is 50 over it, 2.67\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/lisk/LiskDAO.php"},"region":{"startLine":165}}}],"partialFingerprints":{"codehealthFindingId/v1":"e4b6f4b5f3630f24185dcd3f593ff3e25a32f7dde138c0a27363c48cec24029e"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorProjectBoardViewController.handleRequest: MethodTooLong \u2014 handleRequest runs 265 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 165 over it, 2.65\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectBoardViewController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"fa01d637a92bcb61cd65607f8c96636c24ca7a1c00f99780bf6ed18be4bea253"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorProject: TooManyMethods \u2014 79 methods. The bar is 30 methods; this is 49 over it, 2.63\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/storage/PhabricatorProject.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"ec66f940925919bf7cadedb993d4cc4172992dec08b376e143fc946a53b0e429"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorModularTransactionType: TooManyMethods \u2014 79 methods. The bar is 30 methods; this is 49 over it, 2.63\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorModularTransactionType.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"e79f34fe9298540b5833bb1b69f48cf2663e878dbcaf4154797652b87e501b41"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorInlineComment: TooManyMethods \u2014 79 methods. The bar is 30 methods; this is 49 over it, 2.63\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/interface/PhabricatorInlineComment.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"9528e8fc1300b3aa93c17e579fa38b0b68dbcde9fa5f84ab087006f48bd27f67"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: behavior-menu.JX.behavior(\u0022conpherence-menu\u0022): FunctionTooLong \u2014 JX.behavior(\u0022conpherence-menu\u0022) runs 262 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 162 over it, 2.62\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/conpherence/behavior-menu.js"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"7c791e82b8a1fc649ede185631828927798ac6c7229966601d5f1fa5d61b41a7"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorMainMenuView.renderNotificationMenu: MethodTooLong \u2014 renderNotificationMenu runs 257 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 157 over it, 2.57\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/page/menu/PhabricatorMainMenuView.php"},"region":{"startLine":365}}}],"partialFingerprints":{"codehealthFindingId/v1":"314a81b466c10dea8f7164d6e41bf2ea0caed054eb4620867543bdb9d45fbc1b"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorFile: ClassTooLong \u2014 1022 significant lines (blank, comment-only and punctuation-only lines excluded), 101 methods. The bar is 400 significant lines; this is 622 over it, 2.56\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/storage/PhabricatorFile.php"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"4d15f05217f417df5a53957e5d9f6a53ce44b3cfd62ee9070f687d171176278e"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: behavior-phabricator-remarkup-assist.JX.behavior(\u0022phabricator-remarkup-assist\u0022): FunctionTooLong \u2014 JX.behavior(\u0022phabricator-remarkup-assist\u0022) runs 255 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 155 over it, 2.55\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"6d25b8c52e83e86e716b71389ee654f24568d597821b131651cd2601298039a4"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: behavior-dark-console.JX.behavior(\u0022dark-console\u0022): FunctionTooLong \u2014 JX.behavior(\u0022dark-console\u0022) runs 254 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 154 over it, 2.54\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/darkconsole/behavior-dark-console.js"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"5f5b22cecb33dd49be0ab402ad237ac091b16c1a3416b40355816fb79c3d11ec"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: DifferentialTransactionEditor: ClassTooLong \u2014 1014 significant lines (blank, comment-only and punctuation-only lines excluded), 60 methods. The bar is 400 significant lines; this is 614 over it, 2.54\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/editor/DifferentialTransactionEditor.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"149cd02fa532af651618866431bd1e9287dd508343d8a6c6a59dd0d7a38b8fd6"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DifferentialChangesetParser.render: MethodTooLong \u2014 render runs 253 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 153 over it, 2.53\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialChangesetParser.php"},"region":{"startLine":749}}}],"partialFingerprints":{"codehealthFindingId/v1":"db2a5f72d9248726f583de888c6ca53791c2053877a030c8e848d49d67c02366"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: DifferentialChangesetParser: TooManyMethods \u2014 75 methods. The bar is 30 methods; this is 45 over it, 2.50\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialChangesetParser.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"a7a28732fdc70d467624772aace948a8cd032e03d3c21115dea524045083f8c9"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: DifferentialRevisionViewController: ClassTooLong \u2014 993 significant lines (blank, comment-only and punctuation-only lines excluded), 26 methods. The bar is 400 significant lines; this is 593 over it, 2.48\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/controller/DifferentialRevisionViewController.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"1566a6cb3062a1b4ed9af42da15a3353c9390817ca9643c20dada6033a95c4e5"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: behavior-lightbox-attachments.JX.behavior(\u0022lightbox-attachments\u0022): FunctionTooLong \u2014 JX.behavior(\u0022lightbox-attachments\u0022) runs 247 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 147 over it, 2.47\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-lightbox-attachments.js"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"539c84c71cfc5f7a2fc5703ab9b276dfb41f2a6f75a90199abef5e74120bf5b1"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: DifferentialChangeset: TooManyMethods \u2014 73 methods. The bar is 30 methods; this is 43 over it, 2.43\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialChangeset.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"3b0937b16abd4da8076d7ae5eb22b4f22328afbdbecdbdee1bf54de57f2419b0"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorMetaMTAConfigOptions.getOptions: MethodTooLong \u2014 getOptions runs 242 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 142 over it, 2.42\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/option/PhabricatorMetaMTAConfigOptions.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"5ccc9a2e3d555578061190b80b0468e17fda288c40825a10982e8766b7114bf4"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: behavior-day-view.JX.behavior(\u0022day-view\u0022): FunctionTooLong \u2014 JX.behavior(\u0022day-view\u0022) runs 240 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 140 over it, 2.40\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/calendar/behavior-day-view.js"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"a2a9da614d11dc5531a7233fc7d8a1dd6b1c562553bf4520708262bef04cfec4"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: HarbormasterBuildViewController.handleRequest: MethodTooLong \u2014 handleRequest runs 239 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 139 over it, 2.39\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterBuildViewController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"a0431b7c8b78e6b99197c697a1b022612cc624b4db681ed0bc32f0e38d01dcde"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorRemarkupControl.renderInput: MethodTooLong \u2014 renderInput runs 239 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 139 over it, 2.39\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/form/control/PhabricatorRemarkupControl.php"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"a39f9b59a6e4ef019b16eab0b8282b6ceb9f052b1110e3fe44ebba33f87d897a"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: behavior-durable-column.JX.behavior(\u0022durable-column\u0022): FunctionTooLong \u2014 JX.behavior(\u0022durable-column\u0022) runs 239 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 139 over it, 2.39\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/conpherence/behavior-durable-column.js"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"7b574dd573b503f5ee52f1da29b8be8d7d11e239671b3fefbf219b0ab7dba324"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DiffusionCommitQuery.buildWhereClauseParts: MethodTooLong \u2014 buildWhereClauseParts runs 238 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 138 over it, 2.38\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/DiffusionCommitQuery.php"},"region":{"startLine":536}}}],"partialFingerprints":{"codehealthFindingId/v1":"9c7123b2f2b3a4b85e93c8bf4f7d3df01cc759219431ee73b019c0684823d2fe"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: data/PhutilCalendarRecurrenceRule.php: FileTooLong \u2014 1189 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhutilCalendarRecurrenceRule (3-1820). The bar is 500 significant lines; this is 689 over it, 2.38\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"0ac1af3f0d828ce8969f7e74e93161efe619bda254126101b1dd0d4178fc1a77"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorCalendarImportEngine.importEventDocument: MethodTooLong \u2014 importEventDocument runs 236 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 136 over it, 2.36\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/import/PhabricatorCalendarImportEngine.php"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"1f36db54eadcd2d03892eae67d076244d2bde5e5f4857936ee3dbd22799fc1cc"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhortunePaymentMethodCreateController.handleRequest: MethodTooLong \u2014 handleRequest runs 236 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 136 over it, 2.36\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/paymentmethod/PhortunePaymentMethodCreateController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"50f23cab1ca8f50726e2582d7c7305be0d2273057891e210e5cfa18f18ca14a3"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: ManiphestReportController.renderBurn: MethodTooLong \u2014 renderBurn runs 235 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 135 over it, 2.35\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/controller/ManiphestReportController.php"},"region":{"startLine":74}}}],"partialFingerprints":{"codehealthFindingId/v1":"774d50c51238e7c90fd90decc5f89fe49996c51b320d6b8274b835f069ec207a"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorSecurityConfigOptions.getOptions: MethodTooLong \u2014 getOptions runs 231 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 131 over it, 2.31\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/option/PhabricatorSecurityConfigOptions.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"3dd9e495221270dc949afd894b098f07604fe8972d9c4634c72610767c02662e"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: parser/DifferentialChangesetParser.php: FileTooLong \u2014 1154 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: DifferentialChangesetParser (3-1975). The bar is 500 significant lines; this is 654 over it, 2.31\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialChangesetParser.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"d45758db54486c8ac1b469b6f1caaef25f7b2b7301c05250ca9db6ffb61b8254"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DifferentialChangesetTwoUpRenderer.renderTextChange: MethodTooLong \u2014 renderTextChange runs 230 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 130 over it, 2.30\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"db91f621fb83330eef87ffde85d2b218e45ea1ec9ce5ae5e40d6c79d9b791b9a"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DoorkeeperAsanaFeedWorker.publishFeedStory: MethodTooLong \u2014 publishFeedStory runs 230 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 130 over it, 2.30\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/worker/DoorkeeperAsanaFeedWorker.php"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"81a84005d3bdf8f5904b2cf511c31edd5699ed4ac883462fb31b6bfcff0864ad"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: HarbormasterBuildPlanBehavior.newPlanBehaviors: MethodTooLong \u2014 newPlanBehaviors runs 229 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 129 over it, 2.29\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/plan/HarbormasterBuildPlanBehavior.php"},"region":{"startLine":158}}}],"partialFingerprints":{"codehealthFindingId/v1":"07e77dbef1e66bd1b1e526a093630bb775eb9b67790a0ac9cae63404d6058be3"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorSlowvoteEditController.handleRequest: MethodTooLong \u2014 handleRequest runs 227 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 127 over it, 2.27\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"b7ed31f4c912b243c5eee1b63fbc098cda2a7b55701c2c2059230300bc8c5c1f"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhutilCalendarRecurrenceRule: TooManyMethods \u2014 68 methods. The bar is 30 methods; this is 38 over it, 2.27\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"24bf4a6937c978151d176002adb82acf3809c03e479a65d3afc993d167196170"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DifferentialChangesetViewController.handleRequest: MethodTooLong \u2014 handleRequest runs 225 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 125 over it, 2.25\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/controller/DifferentialChangesetViewController.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"e6334522247ba7e82dfb506a686fb4264648676366cb2f3411caa098c61ce5ff"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: LegalpadDocumentSignController.handleRequest: MethodTooLong \u2014 handleRequest runs 225 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 125 over it, 2.25\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/legalpad/controller/LegalpadDocumentSignController.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"56772e20bea9c4707e64ba85a467d4a78081668c15c6dab505ae0f87e54b0f5d"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorDatabaseRef: TooManyMethods \u2014 67 methods. The bar is 30 methods; this is 37 over it, 2.23\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/cluster/PhabricatorDatabaseRef.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"a618b7f21396365f00cdda77cf10e4abe33c0d609aaf6444af217a3f4ef7fbe4"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorStandardCustomField: TooManyMethods \u2014 67 methods. The bar is 30 methods; this is 37 over it, 2.23\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"4417b8a2f3f63580dac13a38afdda92cfaa0a595e7562ea54a12d37318d429c6"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorConduitAPIController.authenticateUser: MethodTooLong \u2014 authenticateUser runs 223 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 123 over it, 2.23\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conduit/controller/PhabricatorConduitAPIController.php"},"region":{"startLine":167}}}],"partialFingerprints":{"codehealthFindingId/v1":"41831e1f7f861ff6ac0959c72b6bd76b65cb8193cbc2e182ccbcdefb243ad164"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorFactObjectController.handleRequest: MethodTooLong \u2014 handleRequest runs 223 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 123 over it, 2.23\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fact/controller/PhabricatorFactObjectController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"2f32617ae55aff5a35d475c00644fa855b921768a37846de66e6bfea25615ddd"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: translation/PhabricatorUSEnglishTranslation.php: FileTooLong \u2014 1114 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorUSEnglishTranslation (3-1816). The bar is 500 significant lines; this is 614 over it, 2.23\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"c53b0e1d6ecd503df4c20e71a29ba61f48bb79fc3434503aec157c28379c27e2"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorProfileMenuEngine: ClassTooLong \u2014 888 significant lines (blank, comment-only and punctuation-only lines excluded), 46 methods. The bar is 400 significant lines; this is 488 over it, 2.22\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorProfileMenuEngine.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"5a5429e36d2df47ad9a0b7ec15fccf8c0dcf0fb614257464bab68152f1e3c152"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorRepositorySvnCommitChangeParserWorker.parseCommitChanges: MethodTooLong \u2014 parseCommitChanges runs 219 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 119 over it, 2.19\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/commitchangeparser/PhabricatorRepositorySvnCommitChangeParserWorker.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"97f4ecff7483ef61092b53fe9dfdeeeacaf309a1f55ade99d2d9e4cdb1e1526d"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: AphrontRequest: TooManyMethods \u2014 65 methods. The bar is 30 methods; this is 35 over it, 2.17\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/AphrontRequest.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"53fa399e4b25a3173ea4b731fad9be74e92bf701cc1e665e5466308d0bf9313f"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorApplicationSearchEngine: ClassTooLong \u2014 865 significant lines (blank, comment-only and punctuation-only lines excluded), 89 methods. The bar is 400 significant lines; this is 465 over it, 2.16\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorApplicationSearchEngine.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"d3fc00f7b41365a34293ae2fa919b8a8542f41f22d13815e4117f6450b839702"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorCoreConfigOptions.getOptions: MethodTooLong \u2014 getOptions runs 216 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 116 over it, 2.16\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/option/PhabricatorCoreConfigOptions.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"7fcd4c0334a7679518794359d397f44cd1c5e517614cab5be34a3f6c5ba198cc"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: ManiphestEditEngine.buildCustomEditFields: MethodTooLong \u2014 buildCustomEditFields runs 216 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 116 over it, 2.16\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/editor/ManiphestEditEngine.php"},"region":{"startLine":76}}}],"partialFingerprints":{"codehealthFindingId/v1":"7d02b9d9e20a866120dcda8fe1d2656eaae7dfa3178e76ac2129e796e8843f3d"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorStorageManagementDumpWorkflow.didExecute: MethodTooLong \u2014 didExecute runs 214 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 114 over it, 2.14\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php"},"region":{"startLine":64}}}],"partialFingerprints":{"codehealthFindingId/v1":"f30488f6bb3ddd19d171087eb458242e16acb55ab4d8f72fcacf0438c21b9997"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: DiffusionCommitHookEngine: ClassTooLong \u2014 853 significant lines (blank, comment-only and punctuation-only lines excluded), 54 methods. The bar is 400 significant lines; this is 453 over it, 2.13\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/engine/DiffusionCommitHookEngine.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"cdbd773bb1162e14631af24e20a19ea216ac07ee77cfeb8d1597ae4a157ef7c5"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorCalendarEvent: ClassTooLong \u2014 852 significant lines (blank, comment-only and punctuation-only lines excluded), 93 methods. The bar is 400 significant lines; this is 452 over it, 2.13\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/storage/PhabricatorCalendarEvent.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"dcb117b0416618f596dde22af83249570eaa41ef93ccd4cbdc8dbf5642a9e333"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorAphlictManagementWorkflow.parseLaunchArguments: MethodTooLong \u2014 parseLaunchArguments runs 213 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 113 over it, 2.13\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"fcb853a48e933c284d41966c14db83954d62db0989b99fede101d142cf916c55"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DiffusionURIEditor.validateTransaction: MethodTooLong \u2014 validateTransaction runs 213 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 113 over it, 2.13\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/editor/DiffusionURIEditor.php"},"region":{"startLine":156}}}],"partialFingerprints":{"codehealthFindingId/v1":"1c678f2713b67a11418686990779418a487aa0b922c0454aeb79725319bc2453"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: ManiphestTaskDetailController.newChangesView: MethodTooLong \u2014 newChangesView runs 213 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 113 over it, 2.13\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/controller/ManiphestTaskDetailController.php"},"region":{"startLine":545}}}],"partialFingerprints":{"codehealthFindingId/v1":"b31799332b2bd4dce363ab914e9799286b41b76c5b0669f2025a30b193f9ad47"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorProjectEditPictureController.handleRequest: MethodTooLong \u2014 handleRequest runs 212 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 112 over it, 2.12\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectEditPictureController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"8c8df79b3b1b1893ca1ee184ea48beeaf114bff72ad44376fb620f5feb619b0f"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorPeopleProfilePictureController.handleRequest: MethodTooLong \u2014 handleRequest runs 211 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 111 over it, 2.11\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/controller/PhabricatorPeopleProfilePictureController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"551ab5c22b1ef37af4c7d1265e14153aa5fe29ccc95a76ba69ea9172c9bb9c8a"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorManiphestTaskFactEngine.newDatapointsForObject: MethodTooLong \u2014 newDatapointsForObject runs 210 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 110 over it, 2.10\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fact/engine/PhabricatorManiphestTaskFactEngine.php"},"region":{"startLine":86}}}],"partialFingerprints":{"codehealthFindingId/v1":"90741c4478ee2811f9843781efae544f0635ce53411328da031b9f18a03fe596"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorStorageManagementWorkflow: ClassTooLong \u2014 837 significant lines (blank, comment-only and punctuation-only lines excluded), 25 methods. The bar is 400 significant lines; this is 437 over it, 2.09\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"7b27cf8779465fecd9f4a4df6ee4029beb01adccc7670b6b162af3b684639103"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorDashboardTabsPanelType.renderPanelContent: MethodTooLong \u2014 renderPanelContent runs 209 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 109 over it, 2.09\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"79634e9d6108c681d1e0bc819ee12292f2091275e3b5d5d998d9e6f0bb3deeeb"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: MultimeterSampleController.handleRequest: MethodTooLong \u2014 handleRequest runs 209 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 109 over it, 2.09\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/multimeter/controller/MultimeterSampleController.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"3b68e045e34d81b9bbb324a8d2b43155c37e954776bf6ba41fa7484e29637573"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhutilSearchQueryCompiler.tokenizeQuery: MethodTooLong \u2014 tokenizeQuery runs 208 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 108 over it, 2.08\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/compiler/PhutilSearchQueryCompiler.php"},"region":{"startLine":104}}}],"partialFingerprints":{"codehealthFindingId/v1":"898cac942e84bb230f5450f437a801308c2ba3e92ba83a23ff73336b9eb420e0"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: repository-crossreference.JX.behavior(\u0022repository-crossreference\u0022): FunctionTooLong \u2014 JX.behavior(\u0022repository-crossreference\u0022) runs 208 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 108 over it, 2.08\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/repository/repository-crossreference.js"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"c3da9f4da5cd36df56449e93d3efb526ce71fd2c9c8bf36261392c5da1e030c2"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorWebServerSetupCheck.executeChecks: MethodTooLong \u2014 executeChecks runs 207 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 107 over it, 2.07\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/check/PhabricatorWebServerSetupCheck.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"89ef2fb5cc2bc65e667fa54eff51eb22d0a4826762867ec9cc3bb8ecbc3c0dfc"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: qsprintf.xsprintf_query: MethodTooLong \u2014 xsprintf_query runs 207 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 107 over it, 2.07\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/xsprintf/qsprintf.php"},"region":{"startLine":90}}}],"partialFingerprints":{"codehealthFindingId/v1":"be58da94f43d00118dc4c0f267349cab2e19a6021e4f1c6bcae9f92668b7e0f9"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: ManiphestReportController.renderOpenTasks: MethodTooLong \u2014 renderOpenTasks runs 206 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 106 over it, 2.06\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/controller/ManiphestReportController.php"},"region":{"startLine":487}}}],"partialFingerprints":{"codehealthFindingId/v1":"999583e0bdfca083e1ca71b2738c5a4ea6dc229de13c1af425028b7c106d00ef"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: storage/PhabricatorFile.php: FileTooLong \u2014 1023 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorFile (23-1764). The bar is 500 significant lines; this is 523 over it, 2.05\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/storage/PhabricatorFile.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"41cddd8fbe0844352f303d27e3d652e844c036480291333de1170345aa27c8cd"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorDifferentialConfigOptions.getOptions: MethodTooLong \u2014 getOptions runs 204 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 104 over it, 2.04\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/config/PhabricatorDifferentialConfigOptions.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"0e39e0499298271c6fc117dc50b9f8e7d0a4b1c72902d0ac7a05abcd9de3a1e9"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorAuthProvider: TooManyMethods \u2014 61 methods. The bar is 30 methods; this is 31 over it, 2.03\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorAuthProvider.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"d0f03b0dfc78b22c5452ad69125e561e38b403564c762b58a1b333fd5899d7da"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorApplication: TooManyMethods \u2014 61 methods. The bar is 30 methods; this is 31 over it, 2.03\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/base/PhabricatorApplication.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"70882d12aa0ad9915a02872aacbacc6cc821d023323692cbf4112fa26ae79c99"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: editor/DifferentialTransactionEditor.php: FileTooLong \u2014 1015 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: DifferentialTransactionEditor (3-1690). The bar is 500 significant lines; this is 515 over it, 2.03\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/editor/DifferentialTransactionEditor.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"7ba83cd12a59eb7619b3e1cd7d9c5dd42df7be0f86c0d523e11ad0e2e11bedb8"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: DiffusionServeController: ClassTooLong \u2014 811 significant lines (blank, comment-only and punctuation-only lines excluded), 28 methods. The bar is 400 significant lines; this is 411 over it, 2.03\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionServeController.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"0ecffbe7add332ee2bc8358d9c47acc8f22369b2e41c101b2d592bcb160ac454"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DifferentialChangesetHTMLRenderer.renderChangeTypeHeader: MethodTooLong \u2014 renderChangeTypeHeader runs 202 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 102 over it, 2.02\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetHTMLRenderer.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"aee14274d48dec2e227ea8c57a4470c5af04c77f03ababe0754259fdd232dae0"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorApplicationTransactionEditor.applyTransactions: MethodTooLong \u2014 applyTransactions runs 202 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 102 over it, 2.02\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":1175}}}],"partialFingerprints":{"codehealthFindingId/v1":"66b1ff70aeced5d7fb556117416b18403cd41fd41dc0fb728f9c25f835cba7ab"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorApplicationEditHTTPParameterHelpView.render: MethodTooLong \u2014 render runs 202 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 102 over it, 2.02\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/view/PhabricatorApplicationEditHTTPParameterHelpView.php"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"870df349037b41e4a026789c3e2984ce39b0a1aff844a26414faf3384def56bb"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: DiffusionCommitController: ClassTooLong \u2014 806 significant lines (blank, comment-only and punctuation-only lines excluded), 18 methods. The bar is 400 significant lines; this is 406 over it, 2.02\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionCommitController.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"6de71ffb60ff359464e8b4e269eede0665bf6e5d94dca4fded89bab39b6d9a34"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: DifferentialTransactionEditor: TooManyMethods \u2014 60 methods. The bar is 30 methods; this is 30 over it, 2.00\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/editor/DifferentialTransactionEditor.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"3dffb13f1cae2cab6179a10319e9652dc6219618e4d6cf068ab373153b12b3ae"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: HeraldRuleController.handleRequest: MethodTooLong \u2014 handleRequest runs 200 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 100 over it, 2.00\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/controller/HeraldRuleController.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"2145799fa0732ce47b62cd986f7617a3fe519b6f64456265f3c78925fac1c99f"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: controller/DifferentialRevisionViewController.php: FileTooLong \u2014 994 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: DifferentialRevisionViewController (3-1454). The bar is 500 significant lines; this is 494 over it, 1.99\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/controller/DifferentialRevisionViewController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"a95d6baccb972d5718b7c0a0e41879f3344efe35f91175292f4de1f8339990c8"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorApplicationSearchController.processSearchRequest: MethodTooLong \u2014 processSearchRequest runs 198 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 98 over it, 1.98\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/controller/PhabricatorApplicationSearchController.php"},"region":{"startLine":95}}}],"partialFingerprints":{"codehealthFindingId/v1":"dd71fc993316bb40a61584776b2283afa275a8f14ecfb9c1f8ff78c42e42e222"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorKeyboardRemarkupRule.markupKeystrokes: MethodTooLong \u2014 markupKeystrokes runs 198 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 98 over it, 1.98\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/rule/PhabricatorKeyboardRemarkupRule.php"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"d2c545c8f24d4598fd77c06900fb70de842dde1dba83ec78fc174c9d09962940"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhortuneMerchantInvoiceCreateController.handleMerchantRequest: MethodTooLong \u2014 handleMerchantRequest runs 195 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 95 over it, 1.95\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/merchant/PhortuneMerchantInvoiceCreateController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"07a36038580ff7377d17f3cc0de3280c3a001304045277460a6ff412419580a7"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorRepositoryManagementThawWorkflow.execute: MethodTooLong \u2014 execute runs 195 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 95 over it, 1.95\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/management/PhabricatorRepositoryManagementThawWorkflow.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"839ee7f308972361059f8a2dd19db22ded85f76fb003d8b51cdc77877560db9c"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorFilesManagementIntegrityWorkflow.execute: MethodTooLong \u2014 execute runs 194 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 94 over it, 1.94\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/management/PhabricatorFilesManagementIntegrityWorkflow.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"73c1beee51f79fc3d09f55be5e092e069650fbeee9839223f06e09e4e77992bc"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorProjectTriggerEditController.handleRequest: MethodTooLong \u2014 handleRequest runs 194 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 94 over it, 1.94\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/trigger/PhabricatorProjectTriggerEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"717e250e7334aab6e60463f38b75bbbd652faf27a502f88cdf4ff0969988a12f"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorObjectHandle: TooManyMethods \u2014 58 methods. The bar is 30 methods; this is 28 over it, 1.93\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phid/PhabricatorObjectHandle.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"cdbd0f11a062593a094dbb02bbcad1c79233d8425e16c51cd8770114c4f3b42e"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorProjectColumnBulkMoveController.handleRequest: MethodTooLong \u2014 handleRequest runs 191 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 91 over it, 1.91\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectColumnBulkMoveController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"573c27777fa0cfe728efc15ab5932ef9b80687c8946e0f5141fd97e6177268ae"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DiffusionServeController.serveRequest: MethodTooLong \u2014 serveRequest runs 190 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 90 over it, 1.90\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionServeController.php"},"region":{"startLine":176}}}],"partialFingerprints":{"codehealthFindingId/v1":"35a13b31d6e946cd0c47c471f7ce5a095a1f13019da8030e789aadecd5a0069d"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: HeraldAdapter: ClassTooLong \u2014 754 significant lines (blank, comment-only and punctuation-only lines excluded), 91 methods. The bar is 400 significant lines; this is 354 over it, 1.89\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/adapter/HeraldAdapter.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"2545e18ed388d8f716d2925d089b978cd449374207514d5711168e911f0f488d"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DiffusionRepositoryProfilePictureController.handleRequest: MethodTooLong \u2014 handleRequest runs 187 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 87 over it, 1.87\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"854c6ac3b6fed371ae3f7a45f4235e8e81f68d130710f499c7c886fa52d5b3a7"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorProjectBoardViewController: ClassTooLong \u2014 747 significant lines (blank, comment-only and punctuation-only lines excluded), 12 methods. The bar is 400 significant lines; this is 347 over it, 1.87\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectBoardViewController.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"1181b9dbda3cf1da5de07dc8ca01aaac765fef46a5768401a34703cc2c49a48e"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: ManiphestTask: TooManyMethods \u2014 56 methods. The bar is 30 methods; this is 26 over it, 1.87\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/storage/ManiphestTask.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"f3bfa202e8434ebdb1ae8c9129f3fd8a7f324eece0fa629396812b08b80f305a"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DifferentialChangesetListView.render: MethodTooLong \u2014 render runs 185 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 85 over it, 1.85\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/view/DifferentialChangesetListView.php"},"region":{"startLine":159}}}],"partialFingerprints":{"codehealthFindingId/v1":"235a83e70a730fbfb024e07ca2e9d13ef7e3851ea1d81cd259cf3fb46197e8a2"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorOAuthServerAuthController.handleRequest: MethodTooLong \u2014 handleRequest runs 184 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 84 over it, 1.84\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/oauthserver/controller/PhabricatorOAuthServerAuthController.php"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"181953ab852246dd01b90d8164cf5ffb22ef60195ad1c4be282178c082123d3e"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorPeopleNewController.handleRequest: MethodTooLong \u2014 handleRequest runs 184 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 84 over it, 1.84\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/controller/PhabricatorPeopleNewController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"a1751af2e0e4ce324700a7e3b5c8008afe0359188b16bd5196f924b99e0d13e1"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorInlineCommentAdjustmentEngine.execute: MethodTooLong \u2014 execute runs 184 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 84 over it, 1.84\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"7c140644b63721ace851ab3907eed09df315d34c91ddc1e42b56d5aa23344cd3"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: DiffusionBrowseController: ClassTooLong \u2014 735 significant lines (blank, comment-only and punctuation-only lines excluded), 24 methods. The bar is 400 significant lines; this is 335 over it, 1.84\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionBrowseController.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"8299290f24fd641d9793127c97929a4766604d01e3a574887c9851cd38ffa854"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: DrydockLease: TooManyMethods \u2014 55 methods. The bar is 30 methods; this is 25 over it, 1.83\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/storage/DrydockLease.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"60c3dd7c909984d4fca836e580752bc4e753dfc0a465fa4cf4136a64b43d3bec"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorApplicationSearchController: ClassTooLong \u2014 732 significant lines (blank, comment-only and punctuation-only lines excluded), 27 methods. The bar is 400 significant lines; this is 332 over it, 1.83\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/controller/PhabricatorApplicationSearchController.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"8ee58556691b41030cdfb5df650254bb89dfeda3c020deec7d74ea86df7655f8"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorPolicyEditController.handleRequest: MethodTooLong \u2014 handleRequest runs 182 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 82 over it, 1.82\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/controller/PhabricatorPolicyEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"8afd25887cbeba6dffee968b485eff4e1f991f92653ff756bfa4e335336d6b05"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: DiffusionCommitHookEngine: TooManyMethods \u2014 54 methods. The bar is 30 methods; this is 24 over it, 1.80\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/engine/DiffusionCommitHookEngine.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"f7ec7aebc30732639029e0ef0197055ecfc98c4a0d28a0a47194ef27fd5edecc"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DiffusionSetPasswordSettingsPanel.processRequest: MethodTooLong \u2014 processRequest runs 180 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 80 over it, 1.80\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/panel/DiffusionSetPasswordSettingsPanel.php"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"c53b0e4b63d02e61af8eb6df7fd5b63735dcf3fc38d87f0aea3fc478e4efc464"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorUser: ClassTooLong \u2014 716 significant lines (blank, comment-only and punctuation-only lines excluded), 98 methods. The bar is 400 significant lines; this is 316 over it, 1.79\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/storage/PhabricatorUser.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"f071fb5f748739ab2b27270e04b31e3248f0286297f6ac7443ea5b179b7beef7"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhameBlogProfilePictureController.handleRequest: MethodTooLong \u2014 handleRequest runs 178 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 78 over it, 1.78\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/blog/PhameBlogProfilePictureController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"f6d77cc277bf28afc652aa41e4d45d136b889ddd50fe1f45bab6f29563b92ac5"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: engine/PhabricatorProfileMenuEngine.php: FileTooLong \u2014 889 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorProfileMenuEngine (3-1361). The bar is 500 significant lines; this is 389 over it, 1.78\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorProfileMenuEngine.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"7b5fbe230a249d7bf9ca96546aafb930da69ca3618c6f11394826379ff34a78d"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: DifferentialDiff: TooManyMethods \u2014 53 methods. The bar is 30 methods; this is 23 over it, 1.77\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialDiff.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"e68cbe439793038c75977d7cf1e40007571ebaae594a42ead95b20607e25b529"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: DivinerAtom: TooManyMethods \u2014 53 methods. The bar is 30 methods; this is 23 over it, 1.77\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/atom/DivinerAtom.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"d8f9d6f61f7ac18c20ed2cf4cf8d16ef744a1b332e385d7a8e789b45d8d535c2"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorTypeaheadDatasource: TooManyMethods \u2014 53 methods. The bar is 30 methods; this is 23 over it, 1.77\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"d18f1850663faaa7b4f74593824e3a180048589caa6489b432a5f6e090cb3979"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DifferentialRevisionUpdateHistoryView.render: MethodTooLong \u2014 render runs 174 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 74 over it, 1.74\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"01481521327dbc130e5a64cbbde465151870ce355a4197b35d340d4669d5e29e"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorEditEngine.buildEditResponse: MethodTooLong \u2014 buildEditResponse runs 174 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 74 over it, 1.74\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editengine/PhabricatorEditEngine.php"},"region":{"startLine":1033}}}],"partialFingerprints":{"codehealthFindingId/v1":"0ce3411cf677f1c6573f13059255cc8ba2ac25e7bb32983c4246fb07df14891e"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PHUITimelineEventView: TooManyMethods \u2014 52 methods. The bar is 30 methods; this is 22 over it, 1.73\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUITimelineEventView.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"abe135b21d4e614a4765d451581c0968fdbbbec3fa48511d16ba1e71feaa0873"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: ManiphestTaskQuery: ClassTooLong \u2014 693 significant lines (blank, comment-only and punctuation-only lines excluded), 46 methods. The bar is 400 significant lines; this is 293 over it, 1.73\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/query/ManiphestTaskQuery.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"429f026c8c3e69c3cb149a59c5eda01f771c82341e7133b122bd54e46efb5d85"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: engine/PhabricatorApplicationSearchEngine.php: FileTooLong \u2014 866 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorApplicationSearchEngine (17-1636). The bar is 500 significant lines; this is 366 over it, 1.73\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorApplicationSearchEngine.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"4b9b94342931b004226d7e05b840e84a5dafe121c24d2d6c186144a87c6b6ac9"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorCustomField: ClassTooLong \u2014 688 significant lines (blank, comment-only and punctuation-only lines excluded), 109 methods. The bar is 400 significant lines; this is 288 over it, 1.72\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/customfield/field/PhabricatorCustomField.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"cdaa9d3b1c7fcba4001e2295b338d67b4345bcf572c59f419e88033a6a492d9b"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: ConpherenceRoomPictureController.handleRequest: MethodTooLong \u2014 handleRequest runs 172 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 72 over it, 1.72\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceRoomPictureController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"4a62bf0d5913232feca4d5113f79f8e0ac80b4a0fcc5d98f976e31d6e5888684"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DivinerAtomController.handleRequest: MethodTooLong \u2014 handleRequest runs 172 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 72 over it, 1.72\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/controller/DivinerAtomController.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"e93ceab656aad6747fe4af7edcb226c60fabf8860dcf3a11c454242f866a3f1b"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: HarbormasterStepEditController.handleRequest: MethodTooLong \u2014 handleRequest runs 172 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 72 over it, 1.72\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterStepEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"d476a0e71e9b362963de923a6dd3d4a469e5f70261da4d83b1fdc6560ba33038"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: AphrontTableView.render: MethodTooLong \u2014 render runs 172 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 72 over it, 1.72\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/control/AphrontTableView.php"},"region":{"startLine":131}}}],"partialFingerprints":{"codehealthFindingId/v1":"013c05551f7ccc5e6209a44d297425b9ad91a4decf2bb7bd835517eeef5cc0f0"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorRepositoryMercurialCommitChangeParserWorker.parseCommitChanges: MethodTooLong \u2014 parseCommitChanges runs 171 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 71 over it, 1.71\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryMercurialCommitChangeParserWorker.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"00fef145d83fab10df07a3fcc42ce2fc42495590ee502ef342c567b381317dba"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: engine/DiffusionCommitHookEngine.php: FileTooLong \u2014 854 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: DiffusionCommitHookEngine (11-1473). The bar is 500 significant lines; this is 354 over it, 1.71\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/engine/DiffusionCommitHookEngine.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"c669320b5713ae8448680e9c7522025d9eb64dc50cf9e392f84f2c5112f3e1ca"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: storage/PhabricatorCalendarEvent.php: FileTooLong \u2014 853 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorCalendarEvent (3-1446). The bar is 500 significant lines; this is 353 over it, 1.71\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/storage/PhabricatorCalendarEvent.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"14ae86ec5335167cb07ce30ef35122f0695ed14dbbfcb3533b3975cb9393589b"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorAuthFactor: TooManyMethods \u2014 51 methods. The bar is 30 methods; this is 21 over it, 1.70\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/factor/PhabricatorAuthFactor.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"fe59f0e05a929b0d10ec63d9dd5643330c2a419ee925e4ff2bd8b68e00016890"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorChatLogChannelLogController.handleRequest: MethodTooLong \u2014 handleRequest runs 170 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 70 over it, 1.70\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"ec8c9e31846c57ecaa790a91cd6add551fcc623eec2f1dc57b0f307ee1290486"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorConfigEditController.handleRequest: MethodTooLong \u2014 handleRequest runs 170 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 70 over it, 1.70\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/settings/PhabricatorConfigEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"460881058c811f552745191df038f42f129fc1da7d72e495c5345d71785bf773"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DifferentialRevisionEditEngine.buildCustomEditFields: MethodTooLong \u2014 buildCustomEditFields runs 169 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 69 over it, 1.69\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/editor/DifferentialRevisionEditEngine.php"},"region":{"startLine":114}}}],"partialFingerprints":{"codehealthFindingId/v1":"878c41429d1f792105441ff0aaf9efda2fb5f4381f540bfff1d42ab37c262844"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorStorageManagementWorkflow.doUpgradeSchemata: MethodTooLong \u2014 doUpgradeSchemata runs 168 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 68 over it, 1.68\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php"},"region":{"startLine":918}}}],"partialFingerprints":{"codehealthFindingId/v1":"7241b51e1aac622416a302ad64a96bc3288171536b1a6051c5e399e50a159aa4"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: workflow/PhabricatorStorageManagementWorkflow.php: FileTooLong \u2014 838 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorStorageManagementWorkflow (3-1289). The bar is 500 significant lines; this is 338 over it, 1.68\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"49bff147f17236f2bad45e68baa7fc23ae7e6144c5c1a3fa6c7ae2c9513c6900"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: DifferentialRevision: ClassTooLong \u2014 670 significant lines (blank, comment-only and punctuation-only lines excluded), 93 methods. The bar is 400 significant lines; this is 270 over it, 1.68\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialRevision.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"a48857d8d82e073fd95133a34724539e83b7e656b6699f4c0d40af4751385b28"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorDaemonConsoleController.handleRequest: MethodTooLong \u2014 handleRequest runs 167 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 67 over it, 1.67\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/daemon/controller/PhabricatorDaemonConsoleController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"0f2a218110526a8cd65361a97e8dcfd2625d60e5260da9e1386fa11409a77cd5"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorOwnersPackage: TooManyMethods \u2014 50 methods. The bar is 30 methods; this is 20 over it, 1.67\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/owners/storage/PhabricatorOwnersPackage.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"7c51c5dceb4605cd9b6806d5e130d512bcf624c4f5e3125621089c0dfe1d7cff"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PHUITimelineEventView.render: MethodTooLong \u2014 render runs 166 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 66 over it, 1.66\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUITimelineEventView.php"},"region":{"startLine":318}}}],"partialFingerprints":{"codehealthFindingId/v1":"54dfa8c0d331a0cb4a146bbc0c06de9fd97f171d0c2f9161dcf25d46973e8f85"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PHUIDiffTableOfContentsListView.render: MethodTooLong \u2014 render runs 165 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 65 over it, 1.65\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/view/PHUIDiffTableOfContentsListView.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"18b088f32e5db3c5bb1f448f94af54dbea536c0a1f769fbefbd352e1745dab83"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: behavior-pholio-mock-edit.JX.behavior(\u0022pholio-mock-edit\u0022): FunctionTooLong \u2014 JX.behavior(\u0022pholio-mock-edit\u0022) runs 165 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 65 over it, 1.65\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/pholio/behavior-pholio-mock-edit.js"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"4174c5c58ac73c8cd6aca8e2fcf91ca3b74728b73abf134b922278d628e790c7"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorMetaMTAMail: ClassTooLong \u2014 657 significant lines (blank, comment-only and punctuation-only lines excluded), 106 methods. The bar is 400 significant lines; this is 257 over it, 1.64\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/storage/PhabricatorMetaMTAMail.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"cf8f1255046a8fcb44ecfde8cf0148853df092fb17e2b03d0b4b4d5ace6dfedb"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DifferentialDiffCreateController.handleRequest: MethodTooLong \u2014 handleRequest runs 164 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 64 over it, 1.64\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/controller/DifferentialDiffCreateController.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"b7b0ec2427f6740065d055e7c0aefd1d57b28b77df4234015c93aa233e54af9a"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorPeopleInviteSendController.handleRequest: MethodTooLong \u2014 handleRequest runs 164 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 64 over it, 1.64\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/controller/PhabricatorPeopleInviteSendController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"abe4105817564b5a26a4cc179103f4955d9dfb572a6bf60b23652d9026296495"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorRepositoryPullLocalDaemon.run: MethodTooLong \u2014 run runs 164 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 64 over it, 1.64\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"0ead73b22d6f437c7ebde6f3824b762428b96d0a99d66e19788424a6a5ce0e6f"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: behavior-object-selector.JX.behavior(\u0022phabricator-object-selector\u0022): FunctionTooLong \u2014 JX.behavior(\u0022phabricator-object-selector\u0022) runs 164 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 64 over it, 1.64\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-object-selector.js"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"8fb2242c1288c6e2e61172129942794c3121f48e11fc193686a65314d17c4ad0"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhortuneCart: TooManyMethods \u2014 49 methods. The bar is 30 methods; this is 19 over it, 1.63\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/storage/PhortuneCart.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"ce9aa19f1889ef68e7fa2b4a7804765c999fb5ae1ddaeb40226d48a2c45f30cd"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorInlineCommentController.processRequest: MethodTooLong \u2014 processRequest runs 163 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 63 over it, 1.63\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/PhabricatorInlineCommentController.php"},"region":{"startLine":93}}}],"partialFingerprints":{"codehealthFindingId/v1":"cbf016686bc2e18f0dc3f64ca55fb7fd16077468c03052ee4aa9ec6fe32824bd"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorCursorPagedPolicyAwareQuery.buildFerretWhereClause: MethodTooLong \u2014 buildFerretWhereClause runs 163 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 63 over it, 1.63\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php"},"region":{"startLine":2208}}}],"partialFingerprints":{"codehealthFindingId/v1":"65a7de2c79473e443714bffa11dbdaadba414a71fd33e1170c15889b6e75cd61"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PHUIHeaderView.getTagContent: MethodTooLong \u2014 getTagContent runs 163 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 63 over it, 1.63\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIHeaderView.php"},"region":{"startLine":190}}}],"partialFingerprints":{"codehealthFindingId/v1":"9988771d8be8fc42f91e7d0580e38d3b6cb29945aa7929e341a4f83db3ed9c86"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: controller/DiffusionServeController.php: FileTooLong \u2014 812 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: DiffusionServeController (3-1330). The bar is 500 significant lines; this is 312 over it, 1.62\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionServeController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"1d1105ff5ed5843dfa3f7b4ad5f59c9749ae989ff19470c277035ec23179dab8"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorFerretFulltextEngineExtension.indexFulltextObject: MethodTooLong \u2014 indexFulltextObject runs 162 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 62 over it, 1.62\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engineextension/PhabricatorFerretFulltextEngineExtension.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"875d1531127b777aca27a29b54256a70ecd26462865c3aa4668aafa031351612"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: controller/DiffusionCommitController.php: FileTooLong \u2014 807 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: DiffusionCommitController (3-1172). The bar is 500 significant lines; this is 307 over it, 1.61\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionCommitController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"d3309124cbb8159f13e1ea978d9bd7d784a7942e8d19fb845531afff986d39b5"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorConfigClusterRepositoriesController.buildClusterRepositoryStatus: MethodTooLong \u2014 buildClusterRepositoryStatus runs 161 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 61 over it, 1.61\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/services/PhabricatorConfigClusterRepositoriesController.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"eeee06f1f937ca579d35e0b7df37b88d76662b89dafb36b76522acc06266c818"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorConfigDatabaseStatusController.renderTable: MethodTooLong \u2014 renderTable runs 161 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 61 over it, 1.61\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/services/PhabricatorConfigDatabaseStatusController.php"},"region":{"startLine":332}}}],"partialFingerprints":{"codehealthFindingId/v1":"ef322a9e320bb7bd7f2bddd64554515e2e75a70f8d7606593bd8061b8679d679"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhortuneCartCheckoutController.handleCartRequest: MethodTooLong \u2014 handleCartRequest runs 161 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 61 over it, 1.61\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/cart/PhortuneCartCheckoutController.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"6decc7eb1c558d4a9a9711f34e27221218faf4cb1948cedb0b9301d9d020c0be"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: ConduitAPIMethod: TooManyMethods \u2014 48 methods. The bar is 30 methods; this is 18 over it, 1.60\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conduit/method/ConduitAPIMethod.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"f5a98e02b2f28105bf7986b15ad926fda7602e60405b7cba3daf8fcb3521782a"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorEnv: TooManyMethods \u2014 48 methods. The bar is 30 methods; this is 18 over it, 1.60\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/env/PhabricatorEnv.php"},"region":{"startLine":51}}}],"partialFingerprints":{"codehealthFindingId/v1":"dc773ed517b620ec8f999e4b447649a24e37a5083b56ed3dff431f9323195901"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorSetupIssueView.render: MethodTooLong \u2014 render runs 160 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 60 over it, 1.60\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/view/PhabricatorSetupIssueView.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"bbc917d75eac4ad87f733c7012c586458fbd9b5f4f4d57ed1adeacd3a8fa05e8"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DifferentialChangesetOneUpRenderer.renderPrimitives: MethodTooLong \u2014 renderPrimitives runs 160 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 60 over it, 1.60\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetOneUpRenderer.php"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"3f6bf1a8ead565b3527b7cd2f23de3875b2ce460e09284a74d835153ae0b0087"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhortuneMerchantPictureController.handleMerchantRequest: MethodTooLong \u2014 handleMerchantRequest runs 159 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 59 over it, 1.59\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/merchant/PhortuneMerchantPictureController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"b0362e023400efb0784a27a4641ed457b76db14a918a302483f260d38e1d962a"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhutilICSParser: ClassTooLong \u2014 632 significant lines (blank, comment-only and punctuation-only lines excluded), 21 methods. The bar is 400 significant lines; this is 232 over it, 1.58\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/ics/PhutilICSParser.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"ee3711150250a58461a877354b7c5d31d22a33a7e0f1bc3af747a90177cd615d"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorAuthSessionEngine.newHighSecurityToken: MethodTooLong \u2014 newHighSecurityToken runs 158 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 58 over it, 1.58\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/engine/PhabricatorAuthSessionEngine.php"},"region":{"startLine":446}}}],"partialFingerprints":{"codehealthFindingId/v1":"7f4254f105118af1e6199b87decba9486f36002410e0f8a5cfef99f39f959986"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DifferentialChangesetOneUpRenderer.renderDocumentEngineBlocks: MethodTooLong \u2014 renderDocumentEngineBlocks runs 158 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 58 over it, 1.58\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetOneUpRenderer.php"},"region":{"startLine":270}}}],"partialFingerprints":{"codehealthFindingId/v1":"a0a7685acab1e861025bb11f2b4bdc01a4c01e57d892b4fcc872bf1357e08780"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorFeedStory: TooManyMethods \u2014 47 methods. The bar is 30 methods; this is 17 over it, 1.57\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/feed/story/PhabricatorFeedStory.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"9d6cc781925f01ae5550509c562e3e4ba99dec552079bc3ee9cf00817b4254e1"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: HarbormasterBuild: TooManyMethods \u2014 47 methods. The bar is 30 methods; this is 17 over it, 1.57\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/storage/build/HarbormasterBuild.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"29e0f243c421dc7580c734b2d0c92cd8781f665c3ea8c720617a33df0a8cc886"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PHUIObjectItemView: TooManyMethods \u2014 47 methods. The bar is 30 methods; this is 17 over it, 1.57\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIObjectItemView.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"7c00737a6d1f9c4b2f95cb2802d79386533fe6a0cdfa3e557fead9871cf6024a"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorConfigDatabaseStatusController: ClassTooLong \u2014 626 significant lines (blank, comment-only and punctuation-only lines excluded), 9 methods. The bar is 400 significant lines; this is 226 over it, 1.57\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/services/PhabricatorConfigDatabaseStatusController.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"29f820b0eaa8a258bf4c1c10a82fddcbf9f06dbbe7314812155d69e45ea38c4e"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorCalendarEventEditEngine.buildCustomEditFields: MethodTooLong \u2014 buildCustomEditFields runs 156 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 56 over it, 1.56\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/editor/PhabricatorCalendarEventEditEngine.php"},"region":{"startLine":76}}}],"partialFingerprints":{"codehealthFindingId/v1":"49b800de72bbd0fe15becc961ea2eaee41de811c94007a8f214b9a409e240ff4"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DiffusionCommitController.buildPropertyListView: MethodTooLong \u2014 buildPropertyListView runs 156 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 56 over it, 1.56\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionCommitController.php"},"region":{"startLine":524}}}],"partialFingerprints":{"codehealthFindingId/v1":"1205f624c312d290d798554ff9ec9eb335ba9c98c8099ba0901c882257452de4"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: behavior-comment-actions.JX.behavior(\u0022comment-actions\u0022): FunctionTooLong \u2014 JX.behavior(\u0022comment-actions\u0022) runs 156 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 56 over it, 1.56\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/transactions/behavior-comment-actions.js"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"7362c2e06ceb9e73aba5582063e92df934ce84c7b6ff008025bfede2b728945c"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: DiffusionCommitQuery: ClassTooLong \u2014 623 significant lines (blank, comment-only and punctuation-only lines excluded), 41 methods. The bar is 400 significant lines; this is 223 over it, 1.56\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/DiffusionCommitQuery.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"1d97bd551af35a1cde829be7ba13baf2722334fcdeb1da0173f48056ff0fdbae"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: DiffusionRepositoryBasicsManagementPanel: ClassTooLong \u2014 623 significant lines (blank, comment-only and punctuation-only lines excluded), 15 methods. The bar is 400 significant lines; this is 223 over it, 1.56\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"98cded4f3f2e7fe9e935248fd92203241d050efe2dd6ffed7632e341228d370b"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DifferentialChangesetTwoUpRenderer.renderDocumentEngineBlocks: MethodTooLong \u2014 renderDocumentEngineBlocks runs 155 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 55 over it, 1.55\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php"},"region":{"startLine":368}}}],"partialFingerprints":{"codehealthFindingId/v1":"b147ad74a163d3b7019aa029e8b26a0c8c34268ea0f3b23e3c707a3c67c1a807"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: ManiphestTransactionEditor.buildMoveTransaction: MethodTooLong \u2014 buildMoveTransaction runs 155 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 55 over it, 1.55\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/editor/ManiphestTransactionEditor.php"},"region":{"startLine":438}}}],"partialFingerprints":{"codehealthFindingId/v1":"0c0d8cc761600c1302e2126f596b1c4936aa9145360f4b6695d6b92ddf2f4d31"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DiffusionLintController.handleRequest: MethodTooLong \u2014 handleRequest runs 154 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 54 over it, 1.54\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionLintController.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"c24d45194a01f1b75744a0d9fcf2307ddc78a62fe3de7593f7d460d7fd8f8070"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorSQLPatchList.buildAllPatches: MethodTooLong \u2014 buildAllPatches runs 154 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 54 over it, 1.54\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/patch/PhabricatorSQLPatchList.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"6477db675c7962400627d3b421b52670dd97df0917aeae39479558fee16f411a"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorDuoAuthFactor: ClassTooLong \u2014 614 significant lines (blank, comment-only and punctuation-only lines excluded), 24 methods. The bar is 400 significant lines; this is 214 over it, 1.54\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/factor/PhabricatorDuoAuthFactor.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"484151ec40ccffd5e5d621af5b6da213ba0d0686a60b443fe1673a617b9e1f57"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: ManiphestTaskQuery: TooManyMethods \u2014 46 methods. The bar is 30 methods; this is 16 over it, 1.53\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/query/ManiphestTaskQuery.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"37a143b7c474a2a00f39a13a8d6e8795ddc33d48aca35a03f0cdeff93994f428"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorProfileMenuEngine: TooManyMethods \u2014 46 methods. The bar is 30 methods; this is 16 over it, 1.53\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorProfileMenuEngine.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"f32a3969b874b1386691f0099ce0ee3f8e00ba138970a23ab6a6f4f39adc12fd"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: ManiphestReportController: ClassTooLong \u2014 613 significant lines (blank, comment-only and punctuation-only lines excluded), 9 methods. The bar is 400 significant lines; this is 213 over it, 1.53\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/controller/ManiphestReportController.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"e6be07ac01767bf8139c0c9d8dd2ab42f4b132ce79f5eaebc8cb4f8d62857287"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: ConpherenceUpdateController.handleRequest: MethodTooLong \u2014 handleRequest runs 153 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 53 over it, 1.53\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceUpdateController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"c88eb1c13eb11687edf2862ad6a51b6eed547c5a1aa9cdd16cf84d4ef4849a72"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorConfigClusterDatabasesController.buildClusterDatabaseStatus: MethodTooLong \u2014 buildClusterDatabaseStatus runs 152 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 52 over it, 1.52\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/services/PhabricatorConfigClusterDatabasesController.php"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"194ff39bb456bb1a564d7a4fedb7103953efebf9e5224c18b40817bf0383df34"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorRepositoryGitCommitChangeParserWorker.parseCommitChanges: MethodTooLong \u2014 parseCommitChanges runs 152 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 52 over it, 1.52\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryGitCommitChangeParserWorker.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"15c3e5cb7e5a1bb66322e7d26797b70a18aa04b979dc127a1a890a17f68e804e"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: adapter/HeraldAdapter.php: FileTooLong \u2014 755 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: HeraldAdapter (3-1224). The bar is 500 significant lines; this is 255 over it, 1.51\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/adapter/HeraldAdapter.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"13ff1513870ca64f337a4f08f72c350d52036716acd98945a974a478acf927c3"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PHUIObjectItemView: ClassTooLong \u2014 603 significant lines (blank, comment-only and punctuation-only lines excluded), 47 methods. The bar is 400 significant lines; this is 203 over it, 1.51\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIObjectItemView.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"7b7c28854ac90439f589cc5b40819470d91b7f0434602ca7eb19ed9467587902"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorRepositoryCommit: ClassTooLong \u2014 602 significant lines (blank, comment-only and punctuation-only lines excluded), 86 methods. The bar is 400 significant lines; this is 202 over it, 1.51\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepositoryCommit.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"7066b4a19af054d62e3d3093ec04d173fdfed6ad16519e0f0a88b1d7394c8c21"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorFilesConfigOptions.getOptions: MethodTooLong \u2014 getOptions runs 150 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 50 over it, 1.50\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/config/PhabricatorFilesConfigOptions.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"3dba0a9d7ffcf27be003da3cb302acdd28660b5620f139692a633b5bd9c5df91"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorProfileMenuEngine.buildItemConfigureContent: MethodTooLong \u2014 buildItemConfigureContent runs 150 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 50 over it, 1.50\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorProfileMenuEngine.php"},"region":{"startLine":683}}}],"partialFingerprints":{"codehealthFindingId/v1":"1ee70f8dee8c5b0896daf6f09091fb94997d5a0a3d53605e475c68ff46fa0903"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorSearchManagementIndexWorkflow.execute: MethodTooLong \u2014 execute runs 150 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 50 over it, 1.50\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php"},"region":{"startLine":74}}}],"partialFingerprints":{"codehealthFindingId/v1":"31167a22c3e10f9d097e01379e6f039969d02c5cf0f77e612538712f049c2624"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorApplicationTransactionCommentView.renderCommentPanel: MethodTooLong \u2014 renderCommentPanel runs 150 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 50 over it, 1.50\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php"},"region":{"startLine":296}}}],"partialFingerprints":{"codehealthFindingId/v1":"acd22fde4794266d5d9591e8b78ace4036074b4c1c4231e5e1aa3ec23074793f"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: controller/PhabricatorProjectBoardViewController.php: FileTooLong \u2014 748 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorProjectBoardViewController (3-1040). The bar is 500 significant lines; this is 248 over it, 1.50\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectBoardViewController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"01a25f9e428f0d872c1aeb457011a6301b509dfa154ba22395f23acc43e28779"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorPolicyFilter: ClassTooLong \u2014 595 significant lines (blank, comment-only and punctuation-only lines excluded), 26 methods. The bar is 400 significant lines; this is 195 over it, 1.49\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/filter/PhabricatorPolicyFilter.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"81d90eb74cd5b656fc81aa8d58286b192b41c9e92a225b68591b3c4e0ce36882"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: DifferentialRevisionQuery: ClassTooLong \u2014 589 significant lines (blank, comment-only and punctuation-only lines excluded), 43 methods. The bar is 400 significant lines; this is 189 over it, 1.47\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/query/DifferentialRevisionQuery.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"b94da847c4e163242011bc6cc9ddb66f54792e3da1d6721a1330fe6101b5fdfb"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: controller/DiffusionBrowseController.php: FileTooLong \u2014 736 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: DiffusionBrowseController (3-1054). The bar is 500 significant lines; this is 236 over it, 1.47\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionBrowseController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"7c81e7de50d0734d7db40d204059a95d9d5efb13a8d4d8d7ab0472a4cca22963"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorMetaMTAMailViewController.buildDeliveryProperties: MethodTooLong \u2014 buildDeliveryProperties runs 147 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 47 over it, 1.47\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/controller/PhabricatorMetaMTAMailViewController.php"},"region":{"startLine":216}}}],"partialFingerprints":{"codehealthFindingId/v1":"ebf6a00a1f6bc4280c9e88cbf9acc24a65037293eab0c7072ba907425f72ba13"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorStandardPageView: TooManyMethods \u2014 44 methods. The bar is 30 methods; this is 14 over it, 1.47\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/page/PhabricatorStandardPageView.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"18effe3883923411e8f04b078ac0774d115868d6cf77176d1c82866f34fb9175"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PHUIListItemView: TooManyMethods \u2014 44 methods. The bar is 30 methods; this is 14 over it, 1.47\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIListItemView.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"90bfc51fe313a3010747d311dfe92490bc2706ea727118105710813be961c68e"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: controller/PhabricatorApplicationSearchController.php: FileTooLong \u2014 733 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorApplicationSearchController (3-1101). The bar is 500 significant lines; this is 233 over it, 1.47\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/controller/PhabricatorApplicationSearchController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"82846e0f8bf04fdecc9fa079299ca3dccbee0eb76208c4f9591e09a958d5e06a"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: HeraldTranscriptController.buildActionTranscriptPanel: MethodTooLong \u2014 buildActionTranscriptPanel runs 146 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 46 over it, 1.46\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/controller/HeraldTranscriptController.php"},"region":{"startLine":226}}}],"partialFingerprints":{"codehealthFindingId/v1":"62bbd81773dde2519d5c8dc07d1ed127161924fd17325173c492f0d0eee6b722"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorSpacesEditController.handleRequest: MethodTooLong \u2014 handleRequest runs 146 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 46 over it, 1.46\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/spaces/controller/PhabricatorSpacesEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"b4c69f3bc52ea1222c4315f0b4b0133a57c05229fc0e75f8156fa00fc5fbd7b6"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: AphrontDialogView.render: MethodTooLong \u2014 render runs 146 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 46 over it, 1.46\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/AphrontDialogView.php"},"region":{"startLine":255}}}],"partialFingerprints":{"codehealthFindingId/v1":"4765991c9b429bc680be23363c2e003b3a42ba8d717d4af4941d1826db14d0d8"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorAuthSessionEngine: ClassTooLong \u2014 581 significant lines (blank, comment-only and punctuation-only lines excluded), 23 methods. The bar is 400 significant lines; this is 181 over it, 1.45\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/engine/PhabricatorAuthSessionEngine.php"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"a03af7f7c86ca26ae3fe962f85f23e73981f6489098d883f18c63db2d917f3f9"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhortunePayPalPaymentProvider.processControllerRequest: MethodTooLong \u2014 processControllerRequest runs 145 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 45 over it, 1.45\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/provider/PhortunePayPalPaymentProvider.php"},"region":{"startLine":287}}}],"partialFingerprints":{"codehealthFindingId/v1":"712f7aaced2423f4f16a71e462e184419c2b5161304a29905dc15c1113d28d5a"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorProfileMenuEngine.buildResponse: MethodTooLong \u2014 buildResponse runs 145 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 45 over it, 1.45\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorProfileMenuEngine.php"},"region":{"startLine":102}}}],"partialFingerprints":{"codehealthFindingId/v1":"3f5b6194eb309dc3054fd9dd38ca34a9e715ee9fd2e9ee70f57ef458a4ebe625"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: behavior-oncopy.JX.behavior(\u0022phabricator-oncopy\u0022): FunctionTooLong \u2014 JX.behavior(\u0022phabricator-oncopy\u0022) runs 145 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 45 over it, 1.45\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-oncopy.js"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"7666f2eab12d96737f65cc1853be59b7798c35f54bc95012725e573233287359"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorStandardPageView: ClassTooLong \u2014 579 significant lines (blank, comment-only and punctuation-only lines excluded), 44 methods. The bar is 400 significant lines; this is 179 over it, 1.45\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/page/PhabricatorStandardPageView.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"c174d0826d57388d25ad0e5d11e73fc48ccf11f82ed90864a97c1012347c8d12"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: ManiphestTaskDetailController: ClassTooLong \u2014 579 significant lines (blank, comment-only and punctuation-only lines excluded), 11 methods. The bar is 400 significant lines; this is 179 over it, 1.45\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/controller/ManiphestTaskDetailController.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"760916b7cdebaebf93d8a71fdd47f82aedc064a7bfb26151fe6fde924b735a77"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: HeraldEngine: ClassTooLong \u2014 578 significant lines (blank, comment-only and punctuation-only lines excluded), 36 methods. The bar is 400 significant lines; this is 178 over it, 1.45\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/engine/HeraldEngine.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"bb9ac2154348cf30a1a155194f201f95facc3fdb025d35b702bd1d229d26cb57"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: ManiphestTransactionEditor: ClassTooLong \u2014 578 significant lines (blank, comment-only and punctuation-only lines excluded), 35 methods. The bar is 400 significant lines; this is 178 over it, 1.45\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/editor/ManiphestTransactionEditor.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"e90fdd8c857164dd934f04699239a58cbf5910b3f8b57b298168749521e3da6f"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorProject: ClassTooLong \u2014 577 significant lines (blank, comment-only and punctuation-only lines excluded), 79 methods. The bar is 400 significant lines; this is 177 over it, 1.44\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/storage/PhabricatorProject.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"f7045e793f1836ba733cee090dae925d112dc290f9f0f993f345bc1ff22afd4c"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorExtraConfigSetupCheck.executeChecks: MethodTooLong \u2014 executeChecks runs 144 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 44 over it, 1.44\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/check/PhabricatorExtraConfigSetupCheck.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"5597a7923c9ae4170a5351799f9c28639550e310f3f849696f90028b909e4a0b"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DiffusionBrowseQueryConduitAPIMethod.getSVNResult: MethodTooLong \u2014 getSVNResult runs 144 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 44 over it, 1.44\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php"},"region":{"startLine":363}}}],"partialFingerprints":{"codehealthFindingId/v1":"89780b49d8507b36683eeae4755373a8deb4c740029d6cb52b76464012256619"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: ManiphestTaskDetailController.handleRequest: MethodTooLong \u2014 handleRequest runs 144 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 44 over it, 1.44\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/controller/ManiphestTaskDetailController.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"f3848b2cd8c1137e3d3b1e326873f9decaa4d90301d59ff344b71fc0145d940a"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: storage/PhabricatorUser.php: FileTooLong \u2014 717 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorUser (11-1463). The bar is 500 significant lines; this is 217 over it, 1.43\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/storage/PhabricatorUser.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"6ea7bee6629fc49a3d5cdee65fa15c0aab0c1576d9b5cb3d587e4ec283358c5c"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorAuditEditor: TooManyMethods \u2014 43 methods. The bar is 30 methods; this is 13 over it, 1.43\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/editor/PhabricatorAuditEditor.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"4b1031a11e3185d16a40e3ce129d50bd4ce52c5fdfe6c72a134103dd6bbf7ddf"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: DifferentialRevisionQuery: TooManyMethods \u2014 43 methods. The bar is 30 methods; this is 13 over it, 1.43\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/query/DifferentialRevisionQuery.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"8cdde706d469935ac22a207d80c698033eee2b3f87e873c3d166f46ba2887935"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: HeraldRule: TooManyMethods \u2014 43 methods. The bar is 30 methods; this is 13 over it, 1.43\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/storage/HeraldRule.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"5486e9885d93a94b0ebfca38f2a0ce27f24f4655c104f5d4d49741b8c0d96fbf"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorProjectQuery: TooManyMethods \u2014 43 methods. The bar is 30 methods; this is 13 over it, 1.43\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/query/PhabricatorProjectQuery.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"2fc9de4bc84eefbcfb7641921a8a6d0b8b491047e229417c97d64dd84c02d57c"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: DiffusionRepositoryClusterEngine: ClassTooLong \u2014 573 significant lines (blank, comment-only and punctuation-only lines excluded), 24 methods. The bar is 400 significant lines; this is 173 over it, 1.43\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"f76ca138cef351288786eab9f198126f766902b197d3e21377d0ed086e973f87"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DifferentialChangesetDetailView.render: MethodTooLong \u2014 render runs 143 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 43 over it, 1.43\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/view/DifferentialChangesetDetailView.php"},"region":{"startLine":105}}}],"partialFingerprints":{"codehealthFindingId/v1":"10228eddbabacce3a3ef8d559f1e0153a75d6d3e3fc46176fbaf0f1bd763e1ca"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorOwnersPathsController.handleRequest: MethodTooLong \u2014 handleRequest runs 143 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 43 over it, 1.43\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/owners/controller/PhabricatorOwnersPathsController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"ac60a7eb1e8d7ee05697a2e49fa1e218a466a7928f1c9bab46c31b4b9ebc0d03"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorFilesManagementMigrateWorkflow.execute: MethodTooLong \u2014 execute runs 142 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 42 over it, 1.42\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/management/PhabricatorFilesManagementMigrateWorkflow.php"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"7b4c3f22f33e4dbe357bfcfba73e1350ec841452e860f1d34b53347b1d15eff9"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorFileComposeController.handleRequest: MethodTooLong \u2014 handleRequest runs 141 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 41 over it, 1.41\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/controller/PhabricatorFileComposeController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"12a63689a521bbebadea7296b8e822337b1a3e3e17d936c8354f6919f9ac9280"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhortuneMerchantProviderEditController.handleMerchantRequest: MethodTooLong \u2014 handleMerchantRequest runs 141 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 41 over it, 1.41\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/merchant/PhortuneMerchantProviderEditController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"d5472a52e4092dfb908557e4e62271e3d288d942813a5510ac0d704827a0c471"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: behavior-aphlict-dropdown.JX.behavior(\u0022aphlict-dropdown\u0022): FunctionTooLong \u2014 JX.behavior(\u0022aphlict-dropdown\u0022) runs 141 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 41 over it, 1.41\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"c0bc515fd475c08aace97ab4864dc77bc6287339998f8c2861c8ca4bb3e39923"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorProjectQuery: ClassTooLong \u2014 562 significant lines (blank, comment-only and punctuation-only lines excluded), 43 methods. The bar is 400 significant lines; this is 162 over it, 1.41\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/query/PhabricatorProjectQuery.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"0ab72a148c698027d5b7db0b28a308831b2fa7407c773fe61ba226ecf893488d"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorApplicationTransactionCommentView: TooManyMethods \u2014 42 methods. The bar is 30 methods; this is 12 over it, 1.40\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"b87cb05caf7b0746368cd4f09ff52e20644e1b432efe49b504c9dd7e05c762c5"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorOAuthServerTokenController.handleRequest: MethodTooLong \u2014 handleRequest runs 140 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 40 over it, 1.40\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/oauthserver/controller/PhabricatorOAuthServerTokenController.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"a44b42fc5aad518732833ccc3806c780921f952a3873f798ab5a1e5ae575b1c2"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhamePostViewController.handleRequest: MethodTooLong \u2014 handleRequest runs 140 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 40 over it, 1.40\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/post/PhamePostViewController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"543470ac4327502fd590df25b0ec38efc7cf2fbe8e731a8753ed0af524a625e8"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorProjectQuery.buildWhereClauseParts: MethodTooLong \u2014 buildWhereClauseParts runs 140 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 40 over it, 1.40\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/query/PhabricatorProjectQuery.php"},"region":{"startLine":457}}}],"partialFingerprints":{"codehealthFindingId/v1":"116e5e3f9832fa0b17be88227b191c635666380bc4f481f1e7bc5f7cf54e1d4c"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorStorageManagementWorkflow.findAdjustments: MethodTooLong \u2014 findAdjustments runs 140 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 40 over it, 1.40\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php"},"region":{"startLine":534}}}],"partialFingerprints":{"codehealthFindingId/v1":"bce88ba1bd66c8f23401615470739ae595435557f990591d10bec500e6a6c272"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: behavior-search-typeahead.JX.behavior(\u0022phabricator-search-typeahead\u0022): FunctionTooLong \u2014 JX.behavior(\u0022phabricator-search-typeahead\u0022) runs 140 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 40 over it, 1.40\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-search-typeahead.js"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"cfa0e04c9aca15cdda8220f13e7008e63ebcd9e920b7c4cb8c6b7355a27309bd"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: HarbormasterBuildLogRenderController: ClassTooLong \u2014 557 significant lines (blank, comment-only and punctuation-only lines excluded), 10 methods. The bar is 400 significant lines; this is 157 over it, 1.39\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"9ce4e93715336f0250e2e2d94c79d7bee4b7a9fd32817a340a653e331e93a03b"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DiffusionPushLogListView.render: MethodTooLong \u2014 render runs 139 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 39 over it, 1.39\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/view/DiffusionPushLogListView.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"1d2bd990aea687f3993fcade2c1a3d187d31c94da643e8f171c03db770e746ef"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorGuideQuickStartModule.renderModuleStatus: MethodTooLong \u2014 renderModuleStatus runs 139 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 39 over it, 1.39\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/guides/module/PhabricatorGuideQuickStartModule.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"0845ef8e5ae5a117c2dfff42c33739d2b49e571350979f0e561c3728401efc64"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorPasswordSettingsPanel.processRequest: MethodTooLong \u2014 processRequest runs 139 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 39 over it, 1.39\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/settings/panel/PhabricatorPasswordSettingsPanel.php"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"0b32f55ed21e43b41a6e49cfe77a9d752f885f31d93cd399b4578883e12367e2"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: query/ManiphestTaskQuery.php: FileTooLong \u2014 694 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: ManiphestTaskQuery (7-1054). The bar is 500 significant lines; this is 194 over it, 1.39\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/query/ManiphestTaskQuery.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"6ea6bb9da73f6fb800abe38f9f1219a4fcac02d4898dc37e15919bad38dd1c67"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhluxEditController.handleRequest: MethodTooLong \u2014 handleRequest runs 138 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 38 over it, 1.38\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phlux/controller/PhluxEditController.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"ec3d9eacfe5633bbea0a6daa3831c9e5de1def06a3f53015f8f1a5fa28d0f94f"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: field/PhabricatorCustomField.php: FileTooLong \u2014 689 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorCustomField (19-1713). The bar is 500 significant lines; this is 189 over it, 1.38\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/customfield/field/PhabricatorCustomField.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"82f21c40338ce34bdbd765768978002583aa0a2c146074b0e40a992758dcbee8"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorDuoAuthFactor.processAddFactorForm: MethodTooLong \u2014 processAddFactorForm runs 137 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 37 over it, 1.37\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/factor/PhabricatorDuoAuthFactor.php"},"region":{"startLine":155}}}],"partialFingerprints":{"codehealthFindingId/v1":"60de54e9fddcef39b29b1c50853344e6166ceb7b7781a77d447683194c6424f4"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorRepositoryManagementReparseWorkflow.execute: MethodTooLong \u2014 execute runs 137 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 37 over it, 1.37\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/management/PhabricatorRepositoryManagementReparseWorkflow.php"},"region":{"startLine":81}}}],"partialFingerprints":{"codehealthFindingId/v1":"d058dd4d0135437466888a5acd782f9d3e104849779aa8a437d63f11a1d4a072"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorEditEngine.buildCommentResponse: MethodTooLong \u2014 buildCommentResponse runs 137 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 37 over it, 1.37\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editengine/PhabricatorEditEngine.php"},"region":{"startLine":1875}}}],"partialFingerprints":{"codehealthFindingId/v1":"6a72c31b4d7eb39eada783bc46e4edfa9e61a9275115a81f4a144eaa195b093d"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: DiffusionCommitQuery: TooManyMethods \u2014 41 methods. The bar is 30 methods; this is 11 over it, 1.37\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/DiffusionCommitQuery.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"1d84b3f02b91582d5bb1eade79b30266294eb84a1188ccf29db11cc929567a1f"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: DiffusionCommitGraphView: TooManyMethods \u2014 41 methods. The bar is 30 methods; this is 11 over it, 1.37\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/view/DiffusionCommitGraphView.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"241224007a22feb6f597b5e6e259d16418d663e57b6cd5ed1bf45983086caa28"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: DrydockLeaseUpdateWorker: ClassTooLong \u2014 545 significant lines (blank, comment-only and punctuation-only lines excluded), 30 methods. The bar is 400 significant lines; this is 145 over it, 1.36\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/worker/DrydockLeaseUpdateWorker.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"be7de17c5e95517357555dd5357fac9d94439c8ccf7755ecf9aaa969325f0484"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorEmailLoginController.handleRequest: MethodTooLong \u2014 handleRequest runs 136 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 36 over it, 1.36\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorEmailLoginController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"dd78ee72b78b38bfaf18b08bc374e764dafbe8a4b8083eb0e69a33b968d1e812"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorCalendarEventCancelController.handleRequest: MethodTooLong \u2014 handleRequest runs 136 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 36 over it, 1.36\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/controller/PhabricatorCalendarEventCancelController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"90d233e27feb90de1a29e94a66b586879d815666454cad8136aaf8a2223ece4f"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhrictionHistoryController.handleRequest: MethodTooLong \u2014 handleRequest runs 136 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 36 over it, 1.36\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/controller/PhrictionHistoryController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"6c399a820ddecfabfa2ca0eb385ec015b3bcf52307a5a1b2610dbfacecdb03a8"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorApplicationTransaction.getTitleForFeed: MethodTooLong \u2014 getTitleForFeed runs 136 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 36 over it, 1.36\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorApplicationTransaction.php"},"region":{"startLine":1335}}}],"partialFingerprints":{"codehealthFindingId/v1":"b71861e55041fe655213e491ea1e165df4aaa0bd831eeda814f97338716c1b76"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorAuditEditor: ClassTooLong \u2014 543 significant lines (blank, comment-only and punctuation-only lines excluded), 43 methods. The bar is 400 significant lines; this is 143 over it, 1.36\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/editor/PhabricatorAuditEditor.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"638cd1f03594b9dd482c789e9abd664b2b774c5db139eb70b1a9fe8746f65eec"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorDatabaseRefParser.newRefs: MethodTooLong \u2014 newRefs runs 135 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 35 over it, 1.35\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/cluster/PhabricatorDatabaseRefParser.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"0fd946aad4bea529f43074042bba9e6d3d82b7671b79097ed44157fd8fc66669"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: storage/DifferentialRevision.php: FileTooLong \u2014 671 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: DifferentialRevision (3-1169). The bar is 500 significant lines; this is 171 over it, 1.34\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialRevision.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"03a35b267738d6aac8ebfa119ef0c8d6d5791918e55dd72f145935d699037885"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DiffusionBrowseQueryConduitAPIMethod.getGitResult: MethodTooLong \u2014 getGitResult runs 134 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 34 over it, 1.34\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"89aa11ade4ff7ae9558039b13764116233bc9670c9894f078a75898b8264729f"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DiffusionBlameController.handleRequest: MethodTooLong \u2014 handleRequest runs 134 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 34 over it, 1.34\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionBlameController.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"54e0fc70af8a10b9583ffdce536c56e0a8e691a0fe3bf28373901234a27631fb"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorProjectEditEngine.buildCustomEditFields: MethodTooLong \u2014 buildCustomEditFields runs 134 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 34 over it, 1.34\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/engine/PhabricatorProjectEditEngine.php"},"region":{"startLine":162}}}],"partialFingerprints":{"codehealthFindingId/v1":"ad6142d677448ad76410e47e8efb62f09aed8cd71bf3f38fcb39c9beeaf5a72f"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: DiffusionCommandEngine: TooManyMethods \u2014 40 methods. The bar is 30 methods; this is 10 over it, 1.33\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/protocol/DiffusionCommandEngine.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"4c3a6a26896ff8e0916244ef2b916d4382a354b2ef99efa88afe903cb232367f"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorDocumentEngine: TooManyMethods \u2014 40 methods. The bar is 30 methods; this is 10 over it, 1.33\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/document/PhabricatorDocumentEngine.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"056ba552b41ed53c2e85d54627fefaf8947692369cb4b9d940c066fa4a45037a"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: HarbormasterBuildLog: TooManyMethods \u2014 40 methods. The bar is 30 methods; this is 10 over it, 1.33\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/storage/build/HarbormasterBuildLog.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"1c3dacf5223f8ff781a8f07ea52aaa3a95403940219745f68c308318ef9569a5"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhortunePaymentProvider: TooManyMethods \u2014 40 methods. The bar is 30 methods; this is 10 over it, 1.33\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/provider/PhortunePaymentProvider.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"ae22f1347d119bc8234505094b8fcc61bb60b32bc4c062bc9fdd5466fb397cf9"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhrictionTransactionEditor: TooManyMethods \u2014 40 methods. The bar is 30 methods; this is 10 over it, 1.33\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/editor/PhrictionTransactionEditor.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"d8bac53678727b2affdb6aea27dc2c82436a1055231e54a04a6c233aeddfadc5"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhutilDaemonHandle: TooManyMethods \u2014 40 methods. The bar is 30 methods; this is 10 over it, 1.33\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/PhutilDaemonHandle.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"863c373fdd8f8ae801840ba886b4c242ab6d228eaa95a52edc3cc211205ac612"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: HeraldTranscriptController: ClassTooLong \u2014 532 significant lines (blank, comment-only and punctuation-only lines excluded), 15 methods. The bar is 400 significant lines; this is 132 over it, 1.33\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/controller/HeraldTranscriptController.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"20c39d1dcac85f2b0babe7ac6f2e9b9eabb6cf4094612e24cd1ac6675619fabe"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: HeraldRuleResult.newResultSpecificationMap: MethodTooLong \u2014 newResultSpecificationMap runs 133 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 33 over it, 1.33\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/storage/transcript/HeraldRuleResult.php"},"region":{"startLine":86}}}],"partialFingerprints":{"codehealthFindingId/v1":"14c0728a25dcbc0959bdc4ac851976a3a329354963a500e74dfe60880c6d349e"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: lisk/LiskDAO.php: FileTooLong \u2014 663 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 163 over it, 1.33\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/lisk/LiskDAO.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"7efc33a193445f8d5da9260916ba5db69664919a4377bca24852bfc8f9616cf5"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhortuneCartCancelController.handleCartRequest: MethodTooLong \u2014 handleCartRequest runs 132 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 32 over it, 1.32\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/cart/PhortuneCartCancelController.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"fa2216f16ef305ecce8654b960240591f4a53570ad6c325a42e01c00842f2666"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: storage/PhabricatorMetaMTAMail.php: FileTooLong \u2014 658 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorMetaMTAMail (6-1265). The bar is 500 significant lines; this is 158 over it, 1.32\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/storage/PhabricatorMetaMTAMail.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"fbd1dcebdafe201525a0394237d5e6a88a613c0d44e1340232b169e39caabd30"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorAuthRegisterController: ClassTooLong \u2014 525 significant lines (blank, comment-only and punctuation-only lines excluded), 6 methods. The bar is 400 significant lines; this is 125 over it, 1.31\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthRegisterController.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"1722aeff781ae111045cf05bfb044bfdc9dc1f02ca8838ae1b218ec147ecb2c2"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorRepositoryDiscoveryEngine: ClassTooLong \u2014 524 significant lines (blank, comment-only and punctuation-only lines excluded), 23 methods. The bar is 400 significant lines; this is 124 over it, 1.31\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"ecb0ef1682e78cb8eb9179c5939706ed71f9c7e9efa380efaaf23ea25b86f721"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorMailManagementShowOutboundWorkflow.execute: MethodTooLong \u2014 execute runs 131 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 31 over it, 1.31\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/management/PhabricatorMailManagementShowOutboundWorkflow.php"},"region":{"startLine":29}}}],"partialFingerprints":{"codehealthFindingId/v1":"a60114b97b1398661d2f6408caa62fda1c60f8e2b03327548c98677c1c5ed585"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorSearchRelationshipController.handleRequest: MethodTooLong \u2014 handleRequest runs 131 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 31 over it, 1.31\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/controller/PhabricatorSearchRelationshipController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"dc71664cd85b68f1a77b17d1a0bdd42f96ce5cb9b75600fd3049405270f85829"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorEditField: ClassTooLong \u2014 521 significant lines (blank, comment-only and punctuation-only lines excluded), 118 methods. The bar is 400 significant lines; this is 121 over it, 1.30\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editfield/PhabricatorEditField.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"95a52cfb44eec94927571d66f41f94e364108760cd8ad4e25259c76840a23e35"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: DifferentialHunkParser: ClassTooLong \u2014 521 significant lines (blank, comment-only and punctuation-only lines excluded), 34 methods. The bar is 400 significant lines; this is 121 over it, 1.30\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialHunkParser.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"2278847a256caf863a2b5db060b26408bca078b2d99e9a5e89d617e37d818168"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhamePost: TooManyMethods \u2014 39 methods. The bar is 30 methods; this is 9 over it, 1.30\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/storage/PhamePost.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"9099a78d001ad12c08e9f186f8785a5aeaf5125f06d7df4be95e612e807d25b9"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorRepositoryURI: TooManyMethods \u2014 39 methods. The bar is 30 methods; this is 9 over it, 1.30\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepositoryURI.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"fbadc694ad4117d491866f89b45fa4798e058e0373394b8bc4804a7dbfd29806"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorSearchField: TooManyMethods \u2014 39 methods. The bar is 30 methods; this is 9 over it, 1.30\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/field/PhabricatorSearchField.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"7a8141e534a1725a1beb8d35455b23333a75350495817e24457ffc08a52da9b2"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorProfileMenuItemConfiguration: TooManyMethods \u2014 39 methods. The bar is 30 methods; this is 9 over it, 1.30\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/storage/PhabricatorProfileMenuItemConfiguration.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"71b1ed82cf7b2f9752f2beff29e658823cc7d12fe719f53994307da5ee4e6fba"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorDeveloperConfigOptions.getOptions: MethodTooLong \u2014 getOptions runs 130 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 30 over it, 1.30\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/option/PhabricatorDeveloperConfigOptions.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"d09228b0a1d94a6c650fc8bab59af6d3b0d59c4c8c81cf3badbf0c5edb5dbc46"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DiffusionSymbolController.handleRequest: MethodTooLong \u2014 handleRequest runs 130 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 30 over it, 1.30\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionSymbolController.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"1b11d9352d5e069501b29f17edb9a2b6c4ca919e5845face04ecae98a25f5de4"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorSourceCodeView.render: MethodTooLong \u2014 render runs 130 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 30 over it, 1.30\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/layout/PhabricatorSourceCodeView.php"},"region":{"startLine":72}}}],"partialFingerprints":{"codehealthFindingId/v1":"9a8d2c88ce6f4cd8960971549575f0fc477ff0d208f0efba3aff613779b0b1e2"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: DifferentialDiff: ClassTooLong \u2014 517 significant lines (blank, comment-only and punctuation-only lines excluded), 53 methods. The bar is 400 significant lines; this is 117 over it, 1.29\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialDiff.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"6f2a8ca5e12d8c40c441e97708fdb969d110f56b0552d9405be23d58739cbbec"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: LegalpadDocumentSignController: ClassTooLong \u2014 516 significant lines (blank, comment-only and punctuation-only lines excluded), 14 methods. The bar is 400 significant lines; this is 116 over it, 1.29\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/legalpad/controller/LegalpadDocumentSignController.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"4c4a7f79aa5d75c4b629eb45412f1adb143333beb305a92bab1487a97c6cf58c"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorMainMenuView: ClassTooLong \u2014 516 significant lines (blank, comment-only and punctuation-only lines excluded), 14 methods. The bar is 400 significant lines; this is 116 over it, 1.29\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/page/menu/PhabricatorMainMenuView.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"08af86e672efa180655d51d885df3a336ec56d1959985c788b170165989056a3"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: HarbormasterBuildViewController: ClassTooLong \u2014 516 significant lines (blank, comment-only and punctuation-only lines excluded), 10 methods. The bar is 400 significant lines; this is 116 over it, 1.29\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterBuildViewController.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"2d1182ef4859c32dbf4f26b73553455f3ba8392f4f1d1eb4efe862bedf5a1932"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorRepositorySvnCommitChangeParserWorker: ClassTooLong \u2014 514 significant lines (blank, comment-only and punctuation-only lines excluded), 12 methods. The bar is 400 significant lines; this is 114 over it, 1.29\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/commitchangeparser/PhabricatorRepositorySvnCommitChangeParserWorker.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"9ba5184973b094df653e5f530443a0a5888228dc7eae6ad5215a5d13eeb199e3"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: AlmanacManagementRegisterWorkflow.execute: MethodTooLong \u2014 execute runs 128 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 28 over it, 1.28\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/management/AlmanacManagementRegisterWorkflow.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"2b13f3f18038065082888b75004a431098bde9f54009b39e7b459f0d377359d2"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhutilICSParser.unescapeFieldValue: MethodTooLong \u2014 unescapeFieldValue runs 128 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 28 over it, 1.28\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/ics/PhutilICSParser.php"},"region":{"startLine":386}}}],"partialFingerprints":{"codehealthFindingId/v1":"fd9d0ba97deebc5dd1392e11db1bf5577a1744824b9e6d209f69613a652c5d5e"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorDiffusionConfigOptions.getOptions: MethodTooLong \u2014 getOptions runs 128 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 28 over it, 1.28\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/config/PhabricatorDiffusionConfigOptions.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"61c2c4067c6e0812bdc44af7d531be8d3dfb696f6e0b8f3db1b9ceeab3a59927"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DiffusionBrowseController.browseFile: MethodTooLong \u2014 browseFile runs 128 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 28 over it, 1.28\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionBrowseController.php"},"region":{"startLine":100}}}],"partialFingerprints":{"codehealthFindingId/v1":"53541fa15cb748f3cf79e07d056d911051d6112d6ddaeafb3fb5aabafe6f9a5d"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorOwnersDetailController.handleRequest: MethodTooLong \u2014 handleRequest runs 128 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 28 over it, 1.28\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/owners/controller/PhabricatorOwnersDetailController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"2ced25d7556d55abe7fb1a8de20d7d67b5d2c6fa70d79156fe24be1b773aec90"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhortuneAccountSubscriptionViewController.newAutopayView: MethodTooLong \u2014 newAutopayView runs 128 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 28 over it, 1.28\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountSubscriptionViewController.php"},"region":{"startLine":156}}}],"partialFingerprints":{"codehealthFindingId/v1":"024fbe001ad4b7f91100c3f292ec7577123ca224d9ce8490f1d6af6859a794f1"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: HeraldAdapter.doesConditionMatch: MethodTooLong \u2014 doesConditionMatch runs 127 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 27 over it, 1.27\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/adapter/HeraldAdapter.php"},"region":{"startLine":444}}}],"partialFingerprints":{"codehealthFindingId/v1":"9da35657574e4734aa48d64f01245445a1ef33a7d2a37147991b5a58f5d593aa"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorNotificationsSettingsPanel.processRequest: MethodTooLong \u2014 processRequest runs 127 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 27 over it, 1.27\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/settings/panel/PhabricatorNotificationsSettingsPanel.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"f7bcaa455b434a9f48133fe58f4b6fd6e29419d9ce86b899a2210a0a7736af13"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: DrydockBlueprint: TooManyMethods \u2014 38 methods. The bar is 30 methods; this is 8 over it, 1.27\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/storage/DrydockBlueprint.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"d224552be8072fad7faee634f00e1dd4cad111bd396bdabe3cab99e922e6c567"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: AphrontDatabaseConnection: TooManyMethods \u2014 38 methods. The bar is 30 methods; this is 8 over it, 1.27\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/connection/AphrontDatabaseConnection.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"fd339011d2ac29ab6718822dcd4bfbc06c9a43f74319665a98ddf6072a97aa72"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: ics/PhutilICSParser.php: FileTooLong \u2014 633 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhutilICSParser (3-919). The bar is 500 significant lines; this is 133 over it, 1.27\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/ics/PhutilICSParser.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"5b63e0a765ce30979d94eba80e9cd5e36b7cc725341cf9de20959679a7b58359"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorOwnersPackage: ClassTooLong \u2014 506 significant lines (blank, comment-only and punctuation-only lines excluded), 50 methods. The bar is 400 significant lines; this is 106 over it, 1.27\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/owners/storage/PhabricatorOwnersPackage.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"960f013071f43ca0ce44954e2d25f7ddcb2a7b7cc133cfae4b05762b90b5834d"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PHUITimelineEventView: ClassTooLong \u2014 505 significant lines (blank, comment-only and punctuation-only lines excluded), 52 methods. The bar is 400 significant lines; this is 105 over it, 1.26\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUITimelineEventView.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"4cba6c50cdfc5d12164159aec7598a3179fa4735a3bf37368150da71a84f1f92"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DifferentialDiffViewController.handleRequest: MethodTooLong \u2014 handleRequest runs 126 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 26 over it, 1.26\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/controller/DifferentialDiffViewController.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"d96af659be25ab7e5790ee39b9fba775e70e82e2f131f7568930e83c675cf516"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DifferentialRevisionReviewersTransaction.renderReviewerEditTitle: MethodTooLong \u2014 renderReviewerEditTitle runs 126 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 26 over it, 1.26\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php"},"region":{"startLine":165}}}],"partialFingerprints":{"codehealthFindingId/v1":"7a2297730e57e6588ff4c5584519946f7b7e958243cb67ec25fa2979bdece4b0"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: HarbormasterBuildableActionController.handleRequest: MethodTooLong \u2014 handleRequest runs 126 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 26 over it, 1.26\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterBuildableActionController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"701f02240046d4953196c0d49e87fadeac0063ec039970c6b4952acf075289fd"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: LegalpadDocumentSignatureAddController.handleRequest: MethodTooLong \u2014 handleRequest runs 126 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 26 over it, 1.26\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/legalpad/controller/LegalpadDocumentSignatureAddController.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"cf995a0c4ae9abd742b92843014faf0b8b03140e2618293909c0a4e75e469985"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: TransactionSearchConduitAPIMethod.execute: MethodTooLong \u2014 execute runs 126 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 26 over it, 1.26\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php"},"region":{"startLine":102}}}],"partialFingerprints":{"codehealthFindingId/v1":"499fea0b7c1c502304b55c680f903a5de0dd388566d4e09759b813d87cf4f80c"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: services/PhabricatorConfigDatabaseStatusController.php: FileTooLong \u2014 627 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorConfigDatabaseStatusController (3-862). The bar is 500 significant lines; this is 127 over it, 1.25\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/services/PhabricatorConfigDatabaseStatusController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"e70b9ae977cdd4a8200aa9d09db928715f399455cd314d1cd8dfcb50d1002917"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorSyntaxHighlightingConfigOptions.getOptions: MethodTooLong \u2014 getOptions runs 125 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 25 over it, 1.25\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/option/PhabricatorSyntaxHighlightingConfigOptions.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"0e269b4d763326af0dc2796d6e664babc79c4d2e9320fa026eaa3944e6a39fd8"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DiffusionURIEditEngine.buildCustomEditFields: MethodTooLong \u2014 buildCustomEditFields runs 125 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 25 over it, 1.25\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/editor/DiffusionURIEditEngine.php"},"region":{"startLine":83}}}],"partialFingerprints":{"codehealthFindingId/v1":"c2ca131d85a962c4ae0fffe5fd09b57aebce5856fdddb6c7c616afb037c3e3e5"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhrictionDiffController.handleRequest: MethodTooLong \u2014 handleRequest runs 125 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 25 over it, 1.25\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/controller/PhrictionDiffController.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"37e3c0fc4f91549b2eb78f09bfdf3f5163e17cb2af98436740506db1e4884db3"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: management/DiffusionRepositoryBasicsManagementPanel.php: FileTooLong \u2014 624 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: DiffusionRepositoryBasicsManagementPanel (3-822). The bar is 500 significant lines; this is 124 over it, 1.25\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"61e1a2e72cbee44220437549637683af2cbdda613a201166f868a12df042bb8e"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: query/DiffusionCommitQuery.php: FileTooLong \u2014 624 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: DiffusionCommitQuery (3-997). The bar is 500 significant lines; this is 124 over it, 1.25\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/DiffusionCommitQuery.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"51f30bc3733f1eedf036500b026acaa97fbc4dc4da1d907af59d84b3e1261897"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorConfigDatabaseIssueController.handleRequest: MethodTooLong \u2014 handleRequest runs 124 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 24 over it, 1.24\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/services/PhabricatorConfigDatabaseIssueController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"21049ab28a788ce38c5e182a1929efe440d51736f61228f1684d3e73b5905221"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorLockLogManagementWorkflow.execute: MethodTooLong \u2014 execute runs 124 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 24 over it, 1.24\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/daemon/management/PhabricatorLockLogManagementWorkflow.php"},"region":{"startLine":28}}}],"partialFingerprints":{"codehealthFindingId/v1":"dc7ef8f42a627aa58053ff0d09e78db34510da14ab3eb9f755bcd0114d19595b"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: DiffusionRequest: TooManyMethods \u2014 37 methods. The bar is 30 methods; this is 7 over it, 1.23\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/request/DiffusionRequest.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"88c4da67667bf62db16b02c44c425c37abb9be1e7c27e684c45be6188be89542"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: DrydockResource: TooManyMethods \u2014 37 methods. The bar is 30 methods; this is 7 over it, 1.23\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/storage/DrydockResource.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"ceb9130fe02a4d29f0e67c1aed6096783ccc52d8cd61e4c746977dcf8772f53e"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: HarbormasterBuildable: TooManyMethods \u2014 37 methods. The bar is 30 methods; this is 7 over it, 1.23\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/storage/HarbormasterBuildable.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"72a58f18ae819138b31920ead17bdb465aceae59c62f8384ecab90013167966b"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhameBlog: TooManyMethods \u2014 37 methods. The bar is 30 methods; this is 7 over it, 1.23\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/storage/PhameBlog.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"fb53751b2596f00ff1b6179e98d66f38b6440f545c4755fd1c51ab164ad3c3f4"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorApplicationTransactionView: TooManyMethods \u2014 37 methods. The bar is 30 methods; this is 7 over it, 1.23\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/view/PhabricatorApplicationTransactionView.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"0af102d146811ec6d6e949d1798150c483fa1a0e698739175da0e96b306ad554"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: HeraldRuleController: ClassTooLong \u2014 493 significant lines (blank, comment-only and punctuation-only lines excluded), 12 methods. The bar is 400 significant lines; this is 93 over it, 1.23\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/controller/HeraldRuleController.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"4c071a47d8e488807feeea5872ea199f5c20ecf9739ab6eb36b20d5d329ce1c5"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: factor/PhabricatorDuoAuthFactor.php: FileTooLong \u2014 615 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorDuoAuthFactor (3-869). The bar is 500 significant lines; this is 115 over it, 1.23\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/factor/PhabricatorDuoAuthFactor.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"129cda28f31c80c7b429f2a815cc23bfaec72d3e362ab5cd947e7a0365fe09df"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorGuideInstallModule.renderModuleStatus: MethodTooLong \u2014 renderModuleStatus runs 123 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 23 over it, 1.23\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/guides/module/PhabricatorGuideInstallModule.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"2fd99163c248f7791f6bedf7189435fad682c6c24cff2de30d6c32ae7f31eea2"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorMacroAudioController.handleRequest: MethodTooLong \u2014 handleRequest runs 123 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 23 over it, 1.23\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/macro/controller/PhabricatorMacroAudioController.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"b07059e3ed44a18f9fd46dd54e61c145b3ec1dffb865f74e2b2b2de7ef042fec"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: ManiphestTaskQuery.buildWhereClauseParts: MethodTooLong \u2014 buildWhereClauseParts runs 123 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 23 over it, 1.23\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/query/ManiphestTaskQuery.php"},"region":{"startLine":354}}}],"partialFingerprints":{"codehealthFindingId/v1":"a722988cfcc0fe0ba53b7127289b118fb4f0caf7ac59bec56dd0b59f446a4ae4"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorOwnersPackageEditEngine.buildCustomEditFields: MethodTooLong \u2014 buildCustomEditFields runs 123 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 23 over it, 1.23\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/owners/editor/PhabricatorOwnersPackageEditEngine.php"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"61100e27fcde3c6dc0322b9bf94f0ab1427ca290257336cdb949add564c75007"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorCursorPagedPolicyAwareQuery.buildFerretJoinClause: MethodTooLong \u2014 buildFerretJoinClause runs 123 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 23 over it, 1.23\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php"},"region":{"startLine":1995}}}],"partialFingerprints":{"codehealthFindingId/v1":"74df64268bdc39c75c19e561a74de59bf21d862e15bd40980143fee604a5a533"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: controller/ManiphestReportController.php: FileTooLong \u2014 614 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: ManiphestReportController (3-890). The bar is 500 significant lines; this is 114 over it, 1.23\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/controller/ManiphestReportController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"d675b7755eba10b2466cc35780399c4af1e9691692d96b3e3d1307a9efc6ec15"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: HarbormasterSendMessageConduitAPIMethod: ClassTooLong \u2014 491 significant lines (blank, comment-only and punctuation-only lines excluded), 16 methods. The bar is 400 significant lines; this is 91 over it, 1.23\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/conduit/HarbormasterSendMessageConduitAPIMethod.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"45d332997a13b435b307fa57201662d708d1c22718148e32e08e617f9951c36f"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorRepositoryURI: ClassTooLong \u2014 489 significant lines (blank, comment-only and punctuation-only lines excluded), 39 methods. The bar is 400 significant lines; this is 89 over it, 1.22\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepositoryURI.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"ad3ac23b70b39596a4867b8498c800c5e0b2accff6471cc7e4ec72973de292ad"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorJupyterDocumentEngine: ClassTooLong \u2014 488 significant lines (blank, comment-only and punctuation-only lines excluded), 29 methods. The bar is 400 significant lines; this is 88 over it, 1.22\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/document/PhabricatorJupyterDocumentEngine.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"a68c2d1470466c82cd5530c9efdce7492f6c2461808cfc6d03bd4ece8aa68d87"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorCalendarNotificationEngine.sendNotifications: MethodTooLong \u2014 sendNotifications runs 121 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 21 over it, 1.21\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/notifications/PhabricatorCalendarNotificationEngine.php"},"region":{"startLine":73}}}],"partialFingerprints":{"codehealthFindingId/v1":"379b69f84110871659318d3581a3edeb934f3e0689c1360704af91f8653987a3"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: phui/PHUIObjectItemView.php: FileTooLong \u2014 604 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PHUIObjectItemView (3-905). The bar is 500 significant lines; this is 104 over it, 1.21\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIObjectItemView.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"5562725d0b30de960bba971f9369f5489770e7b92120b66d4b7c2cd8cadbdd8e"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: storage/PhabricatorRepositoryCommit.php: FileTooLong \u2014 603 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorRepositoryCommit (3-978). The bar is 500 significant lines; this is 103 over it, 1.21\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepositoryCommit.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"b95c5a8569233baeb0f09f4714abf5408d6c6d4e825bda61357dbe850e6926f3"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhrictionDocumentController: ClassTooLong \u2014 481 significant lines (blank, comment-only and punctuation-only lines excluded), 8 methods. The bar is 400 significant lines; this is 81 over it, 1.20\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/controller/PhrictionDocumentController.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"5f550abe02e338bb65245d3faaa58f284297372376d1a245a9374adbf07bfd54"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: HeraldEngine: TooManyMethods \u2014 36 methods. The bar is 30 methods; this is 6 over it, 1.20\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/engine/HeraldEngine.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"945a9604b0e58326dbf9b125fff30540b3ae21d6f94c7d77ab4890f6dad9ce4a"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorPolicy: TooManyMethods \u2014 36 methods. The bar is 30 methods; this is 6 over it, 1.20\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/storage/PhabricatorPolicy.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"6a99657cfa4a999bb4edc11014e3694b6a9f1edffc353a1d55372cbdf193a696"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorProjectTriggerRule: TooManyMethods \u2014 36 methods. The bar is 30 methods; this is 6 over it, 1.20\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/trigger/PhabricatorProjectTriggerRule.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"0e89d3e099b5ef22424e169a8ebd3f3377b12d310943613cecab86b45d659a68"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: AphrontDialogView: TooManyMethods \u2014 36 methods. The bar is 30 methods; this is 6 over it, 1.20\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/AphrontDialogView.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"6b00bfa412516cde5472194d5cc8091047a0e88afaf8ef9755154522505b348b"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorFileViewController.buildPropertyViews: MethodTooLong \u2014 buildPropertyViews runs 120 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 20 over it, 1.20\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/controller/PhabricatorFileViewController.php"},"region":{"startLine":218}}}],"partialFingerprints":{"codehealthFindingId/v1":"d8fecce3499a45c0800267ea737583271991cc98d05946534db34c7278e24b7e"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: filter/PhabricatorPolicyFilter.php: FileTooLong \u2014 596 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorPolicyFilter (3-1065). The bar is 500 significant lines; this is 96 over it, 1.19\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/filter/PhabricatorPolicyFilter.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"6daaa8b1d6b201aed92733adc3f99c1d0a3fc4abd8acca761a3068e11222e2c3"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorConduitAPIController: ClassTooLong \u2014 476 significant lines (blank, comment-only and punctuation-only lines excluded), 9 methods. The bar is 400 significant lines; this is 76 over it, 1.19\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conduit/controller/PhabricatorConduitAPIController.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"dbace120042a6ce4b813c3e177c823e8343c0f286e2bedc4b94ba6d7594276a6"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorAuthManagementStripWorkflow.execute: MethodTooLong \u2014 execute runs 119 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 19 over it, 1.19\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/management/PhabricatorAuthManagementStripWorkflow.php"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"fa21a426b086dffd9e5f3a9cde210d2a201e46310c68071cf56ad1725914da8f"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DiffusionRepositoryStorageManagementPanel.buildClusterStatusPanel: MethodTooLong \u2014 buildClusterStatusPanel runs 119 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 19 over it, 1.19\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/management/DiffusionRepositoryStorageManagementPanel.php"},"region":{"startLine":79}}}],"partialFingerprints":{"codehealthFindingId/v1":"fc90bf8d3a469f18cc2c23a1d1d4599b5156860d8442bb6182b2564ad7a8b7be"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorProjectIconSet.validateConfiguration: MethodTooLong \u2014 validateConfiguration runs 119 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 19 over it, 1.19\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/icon/PhabricatorProjectIconSet.php"},"region":{"startLine":195}}}],"partialFingerprints":{"codehealthFindingId/v1":"9278111b6172cc9d0c1968a9454088e211b104189b4368d8e0049f9b2d41a071"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: behavior-policy-rule-editor.JX.behavior(\u0022policy-rule-editor\u0022): FunctionTooLong \u2014 JX.behavior(\u0022policy-rule-editor\u0022) runs 119 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 19 over it, 1.19\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/policy/behavior-policy-rule-editor.js"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"10df3de964577d7232aa201284162b1e78e4f7252717e8e57a645799dbaedb44"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: HarbormasterBuildLog: ClassTooLong \u2014 472 significant lines (blank, comment-only and punctuation-only lines excluded), 40 methods. The bar is 400 significant lines; this is 72 over it, 1.18\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/storage/build/HarbormasterBuildLog.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"fb5787a5aa981f95c31a169c528387b395b882a6b89eb34c48181733afa29f9f"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: query/DifferentialRevisionQuery.php: FileTooLong \u2014 590 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: DifferentialRevisionQuery (8-1091). The bar is 500 significant lines; this is 90 over it, 1.18\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/query/DifferentialRevisionQuery.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"d2c204b0dc09a4d8528c92ef2c79c0ac04375bf88a49ae4e0c6fffe653dfeb75"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DiffusionRepositoryController.handleRequest: MethodTooLong \u2014 handleRequest runs 118 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 18 over it, 1.18\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRepositoryController.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"44ba2382cfe732924584b004064f5d58513665b71d6f64d1d03d05f9f268d661"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DiffusionCommitHookEngine.findMercurialChangegroupRefUpdates: MethodTooLong \u2014 findMercurialChangegroupRefUpdates runs 118 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 18 over it, 1.18\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/engine/DiffusionCommitHookEngine.php"},"region":{"startLine":743}}}],"partialFingerprints":{"codehealthFindingId/v1":"ff1c5f550ce8f7cbea9f46ccf265f26127574705b0edfbef7fc7598df59f181e"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhutilSpriteSheet.generate: MethodTooLong \u2014 generate runs 117 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 17 over it, 1.17\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/sprite/PhutilSpriteSheet.php"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"319ccb462191bf3e90ec45307771c3f8ff50751e9b172b0d7b7b58a8c4fe5160"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhutilCalendarRecurrenceRule.newYearMap: MethodTooLong \u2014 newYearMap runs 117 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 17 over it, 1.17\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php"},"region":{"startLine":1349}}}],"partialFingerprints":{"codehealthFindingId/v1":"cc8a5d22d32ed7c2278d239cbb35921298aed172b92d21f039b75b635a717cb5"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorDashboardQueryPanelInstallController.handleRequest: MethodTooLong \u2014 handleRequest runs 117 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 17 over it, 1.17\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"601cbec57338358e1aad03298da4835c1aa8b9bb3743e24e6bc12ca9f5849f48"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DifferentialReviewersView.render: MethodTooLong \u2014 render runs 117 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 17 over it, 1.17\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/view/DifferentialReviewersView.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"93a7d63ea77dc8fb1c00a217487f2f62d2196aef86191ffba6cc4c264d100360"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: ManiphestConduitAPIMethod.applyRequest: MethodTooLong \u2014 applyRequest runs 117 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 17 over it, 1.17\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"d124e737050ac14702f627fbce1d2b4555193b63b4f693cde9e498297b18b45d"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PholioInlineController.handleRequest: MethodTooLong \u2014 handleRequest runs 117 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 17 over it, 1.17\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/pholio/controller/PholioInlineController.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"f6fbfc686f649a46e2cd07f1546dcc0ad34c150c722d77780504508d4121aa82"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhrequentTrackController.processRequest: MethodTooLong \u2014 processRequest runs 117 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 17 over it, 1.17\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phrequent/controller/PhrequentTrackController.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"2299bfa497d597b64659516c0c8bb6ed30b94d872c5e83934c3f599c55026eda"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorActionView.render: MethodTooLong \u2014 render runs 117 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 17 over it, 1.17\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/layout/PhabricatorActionView.php"},"region":{"startLine":198}}}],"partialFingerprints":{"codehealthFindingId/v1":"6a892cbb2236a6015e8c715bda8be44097c2a3d7c692d4dc5ef3defcf16357a6"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhutilLDAPAuthAdapter: TooManyMethods \u2014 35 methods. The bar is 30 methods; this is 5 over it, 1.17\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/adapter/PhutilLDAPAuthAdapter.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"3f6a41bce837df9159ff1803a8fc66a94939720538c171c03930eef0c9068299"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorSetupIssue: TooManyMethods \u2014 35 methods. The bar is 30 methods; this is 5 over it, 1.17\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/issue/PhabricatorSetupIssue.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"ff488360783482f7acaaed7f0f5ee0e53ef0119f6cca63c26f66dd0ae26b465c"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: DrydockRepositoryOperation: TooManyMethods \u2014 35 methods. The bar is 30 methods; this is 5 over it, 1.17\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/storage/DrydockRepositoryOperation.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"217157d305c7c427a5062d86b2bc9c1f34ef94b06412207b0c3c370d1e7e498f"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: HarbormasterBuildTarget: TooManyMethods \u2014 35 methods. The bar is 30 methods; this is 5 over it, 1.17\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/storage/build/HarbormasterBuildTarget.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"a48336bbb6514d7a3c5fe02883048af2c4ef3d8c998ae0fb478cdafb819d090c"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: ManiphestTransactionEditor: TooManyMethods \u2014 35 methods. The bar is 30 methods; this is 5 over it, 1.17\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/editor/ManiphestTransactionEditor.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"5df1898719f8b8a3afc5280e2d429794dd29b32ccc58619c30b61a085b8e8843"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorProjectColumn: TooManyMethods \u2014 35 methods. The bar is 30 methods; this is 5 over it, 1.17\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/storage/PhabricatorProjectColumn.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"04abeaad1f482ffd728573eceb5e14bd056b4993126a3279408ce6bdbc992198"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorRepositoryQuery: TooManyMethods \u2014 35 methods. The bar is 30 methods; this is 5 over it, 1.17\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/query/PhabricatorRepositoryQuery.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"9535879ff2f4c230a6e7b9e41fbf83ba3d734a58098f8f881aaf7fd4938dfb31"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhutilDaemon: TooManyMethods \u2014 35 methods. The bar is 30 methods; this is 5 over it, 1.17\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/PhutilDaemon.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"7fb633db2d8156aeb0b08e872d7739533df8e7c0a347d17447662539f78b2ec5"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorInlineCommentController: TooManyMethods \u2014 35 methods. The bar is 30 methods; this is 5 over it, 1.17\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/PhabricatorInlineCommentController.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"b98b1b1aa7539d18f757142f03e4ffe4988b21cfb3d763ac3638a6db8681f21f"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: engine/PhabricatorAuthSessionEngine.php: FileTooLong \u2014 582 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorAuthSessionEngine (12-1171). The bar is 500 significant lines; this is 82 over it, 1.16\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/engine/PhabricatorAuthSessionEngine.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"f2d2557d6fd4461ecbd0f3f989d85afb2365ca902c222930c79b852cc76bef8a"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: DifferentialChangesetRenderer: ClassTooLong \u2014 465 significant lines (blank, comment-only and punctuation-only lines excluded), 90 methods. The bar is 400 significant lines; this is 65 over it, 1.16\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetRenderer.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"8f10017d118dfb6b0c36de1a045aa61a3885f7810335cfbde7ae9ffd9ff4c597"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: DifferentialChangesetHTMLRenderer: ClassTooLong \u2014 464 significant lines (blank, comment-only and punctuation-only lines excluded), 15 methods. The bar is 400 significant lines; this is 64 over it, 1.16\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetHTMLRenderer.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"0988f81a7f58aaa9f2e8643de860fa89a367129cfa3eba54c9332451a3e7615a"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: controller/ManiphestTaskDetailController.php: FileTooLong \u2014 580 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: ManiphestTaskDetailController (3-836). The bar is 500 significant lines; this is 80 over it, 1.16\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/controller/ManiphestTaskDetailController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"4f4a201f114f106251004de4b187f647b1a7d95e29e2e0da864825ab03a38341"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: page/PhabricatorStandardPageView.php: FileTooLong \u2014 580 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorStandardPageView (7-914). The bar is 500 significant lines; this is 80 over it, 1.16\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/page/PhabricatorStandardPageView.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"b0daa51e98b9f97282fcbc6ed5fb06b7a8b06a3179b813f1c5a8d556b8dc0a5f"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: ConpherenceLayoutView.getTagContent: MethodTooLong \u2014 getTagContent runs 116 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 16 over it, 1.16\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/view/ConpherenceLayoutView.php"},"region":{"startLine":84}}}],"partialFingerprints":{"codehealthFindingId/v1":"17d316be2e5c4d08db3cc22bb1a0863ca386d43d9a7bce742af1de2d4812fd5b"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorApplicationEditController.handleRequest: MethodTooLong \u2014 handleRequest runs 116 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 16 over it, 1.16\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/meta/controller/PhabricatorApplicationEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"dedc854328f4a86c6e00e2d01501c1feb9fb8c2eed7d6c45570924cf8ea0ceee"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorStandardPageView.willRenderPage: MethodTooLong \u2014 willRenderPage runs 116 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 16 over it, 1.16\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/page/PhabricatorStandardPageView.php"},"region":{"startLine":199}}}],"partialFingerprints":{"codehealthFindingId/v1":"82ada89605c23b349d39da2748abd70af760650c731bb6c86eb7e6fcaf7e551b"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: engine/HeraldEngine.php: FileTooLong \u2014 579 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: HeraldEngine (3-978). The bar is 500 significant lines; this is 79 over it, 1.16\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/engine/HeraldEngine.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"2f22b253aaedfbf6e0c1732760077f12d8a92ac9e02b023cad52f9c7a0dc2ff9"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: editor/ManiphestTransactionEditor.php: FileTooLong \u2014 579 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: ManiphestTransactionEditor (3-935). The bar is 500 significant lines; this is 79 over it, 1.16\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/editor/ManiphestTransactionEditor.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"be786a14f1f68d4f9b61b38b5f95085740d237d83a50c7ca22b8bc42fddb33c1"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: DifferentialChangeset: ClassTooLong \u2014 463 significant lines (blank, comment-only and punctuation-only lines excluded), 73 methods. The bar is 400 significant lines; this is 63 over it, 1.16\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialChangeset.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"17be05bc70dcc3055c05f884e27903bdc6cd6fbda66ee2e351c8c44f245dad7e"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: storage/PhabricatorProject.php: FileTooLong \u2014 578 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorProject (3-935). The bar is 500 significant lines; this is 78 over it, 1.16\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/storage/PhabricatorProject.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"f43271d21f61ac7582f84cbab7762cf33214ff43cba59abce6a891af33cd6847"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: AlmanacController.buildAlmanacPropertiesTable: MethodTooLong \u2014 buildAlmanacPropertiesTable runs 115 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 15 over it, 1.15\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/controller/AlmanacController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"b820844c029a3ac4f947c1e0bb0911e1a6a5ed5909fc1403e85c3abccf76700c"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DifferentialRevision.newReviewerForceAcceptMap: MethodTooLong \u2014 newReviewerForceAcceptMap runs 115 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 15 over it, 1.15\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialRevision.php"},"region":{"startLine":253}}}],"partialFingerprints":{"codehealthFindingId/v1":"2878048ddb67642dd7e5c8906171654d639443412f431a7c90425bf932cad4d6"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorEditEngineConfigurationSortController.handleRequest: MethodTooLong \u2014 handleRequest runs 115 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 15 over it, 1.15\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/controller/PhabricatorEditEngineConfigurationSortController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"110476d06c338f2cd6c8a5b4d38689046711adae37767b246fe6d672131e7f7c"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PHUIObjectBoxView.getTagContent: MethodTooLong \u2014 getTagContent runs 115 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 15 over it, 1.15\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIObjectBoxView.php"},"region":{"startLine":181}}}],"partialFingerprints":{"codehealthFindingId/v1":"01c98465e6ee2d877e0e46bb23c6f9a7a38149b72e4fbc9d3a95f1f87e546d79"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: behavior-line-linker.JX.behavior(\u0022phabricator-line-linker\u0022): FunctionTooLong \u2014 JX.behavior(\u0022phabricator-line-linker\u0022) runs 115 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 15 over it, 1.15\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-line-linker.js"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"5cddbedc9df7f9457fef53ee6d3ee26be611308b3355a34b98ad726928ac5fb6"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: protocol/DiffusionRepositoryClusterEngine.php: FileTooLong \u2014 574 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: DiffusionRepositoryClusterEngine (10-942). The bar is 500 significant lines; this is 74 over it, 1.15\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"f5f51260e0113d9597d563f8f21b56d44bb9e730635842113a9061a4a6c393ca"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhortuneCart: ClassTooLong \u2014 459 significant lines (blank, comment-only and punctuation-only lines excluded), 49 methods. The bar is 400 significant lines; this is 59 over it, 1.15\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/storage/PhortuneCart.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"b56946db89ed6c2783df6b1dfef3c27e0c67de313c2b9fa0f98c290663a2b5b1"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorCalendarEventQuery: ClassTooLong \u2014 458 significant lines (blank, comment-only and punctuation-only lines excluded), 34 methods. The bar is 400 significant lines; this is 58 over it, 1.15\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/query/PhabricatorCalendarEventQuery.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"1bc323febd99c990313c7f0ab048d27053055d3585996153591f92c61afb2288"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorDatabaseRef: ClassTooLong \u2014 457 significant lines (blank, comment-only and punctuation-only lines excluded), 67 methods. The bar is 400 significant lines; this is 57 over it, 1.14\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/cluster/PhabricatorDatabaseRef.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"9bdd98c750f347fc3e7250bc58664b911abd452253145f7f17c01328b7cafc6b"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: HarbormasterPlanViewController: ClassTooLong \u2014 457 significant lines (blank, comment-only and punctuation-only lines excluded), 9 methods. The bar is 400 significant lines; this is 57 over it, 1.14\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterPlanViewController.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"b3c95bc982722c0381d859c859f051a2d17ce989d5e5d3a40b0b7724959a21ac"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: DivinerAtomController: ClassTooLong \u2014 456 significant lines (blank, comment-only and punctuation-only lines excluded), 15 methods. The bar is 400 significant lines; this is 56 over it, 1.14\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/controller/DivinerAtomController.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"d7713f062298ae18fb10f46901e6753b7a7ba8f23f9a46a31b55ba4525e340cb"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DiffusionRepositoryURICredentialController.handleRequest: MethodTooLong \u2014 handleRequest runs 114 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 14 over it, 1.14\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRepositoryURICredentialController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"eeeae01c3832e1ae0a0e19151e10276cda068d35e6f9b89c50fc079222022142"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorSystemRemoveDestroyWorkflow.execute: MethodTooLong \u2014 execute runs 114 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 14 over it, 1.14\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/system/management/PhabricatorSystemRemoveDestroyWorkflow.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"73bbbcaad9705178cd348f94bba4e04270b69d5c3619e6f73ff30e71c74e3a87"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorEditEngineConfigurationViewController.buildCurtainView: MethodTooLong \u2014 buildCurtainView runs 114 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 14 over it, 1.14\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/controller/PhabricatorEditEngineConfigurationViewController.php"},"region":{"startLine":76}}}],"partialFingerprints":{"codehealthFindingId/v1":"977437aea80ff29aaa18ec0b2b5cd832a50b1b033ec041bb91578c6ad167a071"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: AphrontRequest: ClassTooLong \u2014 454 significant lines (blank, comment-only and punctuation-only lines excluded), 65 methods. The bar is 400 significant lines; this is 54 over it, 1.14\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/AphrontRequest.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"8195ca0a49d639296bd7352694e92375f1b86ec363e1491b0ba310beb4028a05"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorRepositoryQuery: ClassTooLong \u2014 454 significant lines (blank, comment-only and punctuation-only lines excluded), 35 methods. The bar is 400 significant lines; this is 54 over it, 1.14\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/query/PhabricatorRepositoryQuery.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"618a43308f8cd8de21c1ae8ad36f7d9e02037a27757d9d385c7f1cb822af936f"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorSetupIssueView: ClassTooLong \u2014 454 significant lines (blank, comment-only and punctuation-only lines excluded), 11 methods. The bar is 400 significant lines; this is 54 over it, 1.14\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/view/PhabricatorSetupIssueView.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"589d0aa1ce1a7771c4deddfe20da736b86a1b858c6238c308aa467a5d85a91f3"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorCalendarEventQuery: TooManyMethods \u2014 34 methods. The bar is 30 methods; this is 4 over it, 1.13\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/query/PhabricatorCalendarEventQuery.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"f4782360866b5d4bd44e785b0c3fec3b4197e7e850741208fadf23499e300e29"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: DifferentialHunkParser: TooManyMethods \u2014 34 methods. The bar is 30 methods; this is 4 over it, 1.13\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialHunkParser.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"438c48f45b41e7ec3c92d118ed6a13db4a81adfc9b2840ee392b063a2258dbe4"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: HeraldCommitAdapter: TooManyMethods \u2014 34 methods. The bar is 30 methods; this is 4 over it, 1.13\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/herald/HeraldCommitAdapter.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"00397a890d115c2bd313a019a8fa3b454b58b97f763c51cb859fa0145fd8fe00"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: HeraldAction: TooManyMethods \u2014 34 methods. The bar is 30 methods; this is 4 over it, 1.13\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/action/HeraldAction.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"8d7f8270a9eb152752fab3db4f1a84cd7983b11c8645b0d9075ec4b46102a418"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorTypeaheadResult: TooManyMethods \u2014 34 methods. The bar is 30 methods; this is 4 over it, 1.13\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/typeahead/storage/PhabricatorTypeaheadResult.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"83f1e5b24cd901017e54df25875c5f7600eac6f7962e409688dc2b67dfdca53c"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorPolicyAwareQuery: TooManyMethods \u2014 34 methods. The bar is 30 methods; this is 4 over it, 1.13\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php"},"region":{"startLine":29}}}],"partialFingerprints":{"codehealthFindingId/v1":"39708593e1c95a57c74be85d940f28cec4f15f71d7b6639ace54d64cddee9c43"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorAuthOneTimeLoginController.handleRequest: MethodTooLong \u2014 handleRequest runs 113 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 13 over it, 1.13\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthOneTimeLoginController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"96441a2afc06982047f2d6da6530fec4195b0c50bb5a596b725f5e47f2c57b06"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorAuthStartController.handleRequest: MethodTooLong \u2014 handleRequest runs 113 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 13 over it, 1.13\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthStartController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"6239ae6f204c8b3b1cd1731f8d4e817e8f7734838a8ded56fef71626d42475dc"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorBinariesSetupCheck.executeChecks: MethodTooLong \u2014 executeChecks runs 113 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 13 over it, 1.13\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/check/PhabricatorBinariesSetupCheck.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"14b4f9b4f92751e2fe23b3a1565803feb36ed8f13e7e07e1d65026569faec62f"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorProjectMembersViewController.buildCurtainView: MethodTooLong \u2014 buildCurtainView runs 113 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 13 over it, 1.13\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectMembersViewController.php"},"region":{"startLine":70}}}],"partialFingerprints":{"codehealthFindingId/v1":"76713fae761f5aa7e82b3263a2da2d68bc3a1800685f3d782a13c4dde8848b8f"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorProjectProfileController.handleRequest: MethodTooLong \u2014 handleRequest runs 113 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 13 over it, 1.13\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectProfileController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"c6dabf5def5cf4910cd5156b6ddfccf6bf24c16c42d0bef2613a279037411e83"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: behavior-project-boards.JX.behavior(\u0022project-boards\u0022): FunctionTooLong \u2014 JX.behavior(\u0022project-boards\u0022) runs 113 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 13 over it, 1.13\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/projects/behavior-project-boards.js"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"c084e7333c1e1e8865b4908b833a2b582b2e06114917661b2cae9a241deda7f7"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: query/PhabricatorProjectQuery.php: FileTooLong \u2014 563 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorProjectQuery (3-897). The bar is 500 significant lines; this is 63 over it, 1.13\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/query/PhabricatorProjectQuery.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"61306482c2918c31f161e0b07b9878875be23a9782ca29e131627f2d17a79b32"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorSearchEngineAPIMethod: ClassTooLong \u2014 448 significant lines (blank, comment-only and punctuation-only lines excluded), 15 methods. The bar is 400 significant lines; this is 48 over it, 1.12\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorSearchEngineAPIMethod.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"770d5bebb66ca0e4a989d9779f20fe879f65cf46a50bee79b9caece52e73837f"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DiffusionSourceLinkRemarkupRule.didMarkupText: MethodTooLong \u2014 didMarkupText runs 112 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 12 over it, 1.12\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/remarkup/DiffusionSourceLinkRemarkupRule.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"23d36b5923db85b9d4442a150ccaeca7077931f3ae085dea1ee210ca16ceafd5"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorRepository.generateURI: MethodTooLong \u2014 generateURI runs 112 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 12 over it, 1.12\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepository.php"},"region":{"startLine":681}}}],"partialFingerprints":{"codehealthFindingId/v1":"b02540e2bc340083f75cf3fcd47318ab93f896763b381207d80de7f527a217a4"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorSystemReadOnlyController.handleRequest: MethodTooLong \u2014 handleRequest runs 112 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 12 over it, 1.12\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/system/controller/PhabricatorSystemReadOnlyController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"9d6c26ba5a1017219c87689abe71574cef41445c907cd690bd1da0e320e145de"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorWorkerManagementWorkflow.loadTasks: MethodTooLong \u2014 loadTasks runs 112 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 12 over it, 1.12\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementWorkflow.php"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"249590a5adb59f7143d032f8282657a7ce2c3bd0777d74c8c5913e21f0d87c0d"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: controller/HarbormasterBuildLogRenderController.php: FileTooLong \u2014 558 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: HarbormasterBuildLogRenderController (3-897). The bar is 500 significant lines; this is 58 over it, 1.12\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"6f664b951d9bd56cdc51a454e9d0332bb74f7e784d98028651cc9deaf769a66a"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorRepositoryPullEngine: ClassTooLong \u2014 445 significant lines (blank, comment-only and punctuation-only lines excluded), 25 methods. The bar is 400 significant lines; this is 45 over it, 1.11\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/engine/PhabricatorRepositoryPullEngine.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"2a8dc6964c81bdfa440260147d0587920d76e44f9c6014eef34e8a4e9357db22"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: AphrontApplicationConfiguration: ClassTooLong \u2014 445 significant lines (blank, comment-only and punctuation-only lines excluded), 24 methods. The bar is 400 significant lines; this is 45 over it, 1.11\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/configuration/AphrontApplicationConfiguration.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"5dfbb9d104b6131581796f110f8215784fc4ac217eab09466ebca40250ee18cb"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorEnv: ClassTooLong \u2014 444 significant lines (blank, comment-only and punctuation-only lines excluded), 48 methods. The bar is 400 significant lines; this is 44 over it, 1.11\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/env/PhabricatorEnv.php"},"region":{"startLine":51}}}],"partialFingerprints":{"codehealthFindingId/v1":"8c018f9df39b622a464ad32674787f5c28af0cd2e681a68ec4878e0c39185a20"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorAuthSetPasswordController.handleRequest: MethodTooLong \u2014 handleRequest runs 111 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 11 over it, 1.11\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthSetPasswordController.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"8874280608ae1ef80e81a7841417bac428d91ce7aa1efebbc2c63dd75ea97920"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DifferentialRevisionQuery.buildWhereClause: MethodTooLong \u2014 buildWhereClause runs 111 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 11 over it, 1.11\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/query/DifferentialRevisionQuery.php"},"region":{"startLine":630}}}],"partialFingerprints":{"codehealthFindingId/v1":"a2ad30826add455ed86a31e2783fa0938c2b8311d66e4009b960fc0c67a522c3"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: HarbormasterCircleCIBuildStepImplementation.execute: MethodTooLong \u2014 execute runs 111 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 11 over it, 1.11\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/step/HarbormasterCircleCIBuildStepImplementation.php"},"region":{"startLine":82}}}],"partialFingerprints":{"codehealthFindingId/v1":"268628f3b09bfb6498030c647187b14f2a6499b5582e0f041470beafc6c5b555"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhortuneOrderTableView.render: MethodTooLong \u2014 render runs 111 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 11 over it, 1.11\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/view/PhortuneOrderTableView.php"},"region":{"startLine":56}}}],"partialFingerprints":{"codehealthFindingId/v1":"ed60c5c092f8dd78f15fe75aadd792b57d028d2cf6de8d18dc7c0baa267422b2"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhrictionRemarkupRule.didMarkupText: MethodTooLong \u2014 didMarkupText runs 111 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 11 over it, 1.11\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/markup/PhrictionRemarkupRule.php"},"region":{"startLine":86}}}],"partialFingerprints":{"codehealthFindingId/v1":"db36462a93f469f8c861dfeeddb2e8f9129972fa8f3dcd21edb41db147ff7c2b"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: AlmanacDevice: TooManyMethods \u2014 33 methods. The bar is 30 methods; this is 3 over it, 1.10\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/storage/AlmanacDevice.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"cbab85ab88ee7daf73dac3a393e901304860bb9096cc3cca099bd47261bcf036"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: AlmanacService: TooManyMethods \u2014 33 methods. The bar is 30 methods; this is 3 over it, 1.10\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/storage/AlmanacService.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"1433cd621f44158678dd046dc8209aa43ad527e1aa74d96a7c4eae45a5a21c88"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: HeraldWebhookRequest: TooManyMethods \u2014 33 methods. The bar is 30 methods; this is 3 over it, 1.10\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/storage/HeraldWebhookRequest.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"c600cbce8c9b49617d30e6cb4f5798f6dfefc872ec8cad04f840c4555a1d5c73"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorPeopleQuery: TooManyMethods \u2014 33 methods. The bar is 30 methods; this is 3 over it, 1.10\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/query/PhabricatorPeopleQuery.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"503ce5e143a4cced61285642a4adefc55d0203e14bf3f7cb04e0559add3d77f1"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PonderQuestion: TooManyMethods \u2014 33 methods. The bar is 30 methods; this is 3 over it, 1.10\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/ponder/storage/PonderQuestion.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"e0493e7281f8eed73c5d4f348f9497b90a94f98242fcd579c4bef16c64b2bc8a"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorActionView: TooManyMethods \u2014 33 methods. The bar is 30 methods; this is 3 over it, 1.10\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/layout/PhabricatorActionView.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"f6ceda964ffc0004891e5c71bc3c59aa0a614ce64865c4edee5ceee677663b4d"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DiffusionCompareController.handleRequest: MethodTooLong \u2014 handleRequest runs 110 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 10 over it, 1.10\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionCompareController.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"6708bb32c944b1e4a270ce29f51484e881ffa735a90aad1ecc60bf7267719fa1"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DiffusionRepositoryBasicsManagementPanel.buildManagementPanelCurtain: MethodTooLong \u2014 buildManagementPanelCurtain runs 110 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 10 over it, 1.10\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"d62b732e7bed3e99644d65b367345cf3587fd77535667b6031bda82b99b185b3"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorMultiFactorSettingsPanel.processNew: MethodTooLong \u2014 processNew runs 110 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 10 over it, 1.10\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/settings/panel/PhabricatorMultiFactorSettingsPanel.php"},"region":{"startLine":175}}}],"partialFingerprints":{"codehealthFindingId/v1":"ec59e725e1af01749b303e78bd4475333f1bd87ac9e3f5530f00b8bb26ea15b2"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorCalendarEventViewController: ClassTooLong \u2014 438 significant lines (blank, comment-only and punctuation-only lines excluded), 11 methods. The bar is 400 significant lines; this is 38 over it, 1.10\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/controller/PhabricatorCalendarEventViewController.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"88cedac73dcaa7e5374de9bf6bddd8a5eb210a3a0958b848a858790d06dcbe1f"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: worker/DrydockLeaseUpdateWorker.php: FileTooLong \u2014 546 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: DrydockLeaseUpdateWorker (13-1129). The bar is 500 significant lines; this is 46 over it, 1.09\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/worker/DrydockLeaseUpdateWorker.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"46c66bd5ae4d29fa117fafaa69fb212b5b6807e6a09a3cf000459e626a789c4d"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: DifferentialTransaction: ClassTooLong \u2014 436 significant lines (blank, comment-only and punctuation-only lines excluded), 24 methods. The bar is 400 significant lines; this is 36 over it, 1.09\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialTransaction.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"96be764749d0ba28b9cd84409685e722c4b6b56ac2bbfe4b3bebac0350fd1633"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: DifferentialChangesetTwoUpRenderer: ClassTooLong \u2014 436 significant lines (blank, comment-only and punctuation-only lines excluded), 10 methods. The bar is 400 significant lines; this is 36 over it, 1.09\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"20a82e5015738007e6c6baa55d21711c3ab3c5e8d53429e0f39f126f08273f6d"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorJIRAAuthProvider.extendEditForm: MethodTooLong \u2014 extendEditForm runs 109 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 9 over it, 1.09\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorJIRAAuthProvider.php"},"region":{"startLine":161}}}],"partialFingerprints":{"codehealthFindingId/v1":"5dd25cec36152054e11800c8bad79ca93078afacede3561f7dd75daae139266a"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorCalendarEventQuery.willFilterPage: MethodTooLong \u2014 willFilterPage runs 109 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 9 over it, 1.09\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/query/PhabricatorCalendarEventQuery.php"},"region":{"startLine":515}}}],"partialFingerprints":{"codehealthFindingId/v1":"32062b9b3fdce40ad488aaa6a69f15a879fead6bd375205b61667ef8ee065c65"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorSetupIssueView.renderPHPConfig: MethodTooLong \u2014 renderPHPConfig runs 109 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 9 over it, 1.09\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/view/PhabricatorSetupIssueView.php"},"region":{"startLine":339}}}],"partialFingerprints":{"codehealthFindingId/v1":"f1805f3c15d8b6378be78e86319ec3933529887320a7098e83381b911d9f1704"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DarkConsoleServicesPlugin.renderPanel: MethodTooLong \u2014 renderPanel runs 109 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 9 over it, 1.09\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/console/plugin/DarkConsoleServicesPlugin.php"},"region":{"startLine":171}}}],"partialFingerprints":{"codehealthFindingId/v1":"7cc009ea1f2175d31ef08d70f84abd860ab5f92a2a46739d032194805053fc30"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: LegalpadDocumentSignatureSearchEngine.renderResultList: MethodTooLong \u2014 renderResultList runs 109 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 9 over it, 1.09\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/legalpad/query/LegalpadDocumentSignatureSearchEngine.php"},"region":{"startLine":150}}}],"partialFingerprints":{"codehealthFindingId/v1":"c6e806ec5d27aa3a303aa6ec19c177aaacbbbbc5e938ef793c8d00c9953ce68b"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorMailEmailEngine.newMessage: MethodTooLong \u2014 newMessage runs 109 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 9 over it, 1.09\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/engine/PhabricatorMailEmailEngine.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"12637fb7e5edee2b291a72cbe3580c0cfc5c4d7876f4cc2e274160946d85df6d"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PHUICalendarDayView.render: MethodTooLong \u2014 render runs 109 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 9 over it, 1.09\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/calendar/PHUICalendarDayView.php"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"a855f4f2896fc3ff7ee08362c5160801f3d9d720b7004431a1326f69a7217f88"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: editor/PhabricatorAuditEditor.php: FileTooLong \u2014 544 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorAuditEditor (3-870). The bar is 500 significant lines; this is 44 over it, 1.09\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/editor/PhabricatorAuditEditor.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"b38b19435c650eca5001ef7766cf9a9eea293ab3d6eb44cc3090cac7a9052691"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorCalendarEventSearchEngine: ClassTooLong \u2014 435 significant lines (blank, comment-only and punctuation-only lines excluded), 28 methods. The bar is 400 significant lines; this is 35 over it, 1.09\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"4f13121afa48ca100518046a9d2e6c1cc8760ccb0c66bc023861fbcdb602ff9e"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorExtraConfigSetupCheck: ClassTooLong \u2014 435 significant lines (blank, comment-only and punctuation-only lines excluded), 3 methods. The bar is 400 significant lines; this is 35 over it, 1.09\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/check/PhabricatorExtraConfigSetupCheck.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"14db4f4f104c5ccc183b1aa7dde86addf73cd7998cf0a13aed230ec27f31e725"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorAuditTransaction.getTitle: MethodTooLong \u2014 getTitle runs 108 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 8 over it, 1.08\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/storage/PhabricatorAuditTransaction.php"},"region":{"startLine":162}}}],"partialFingerprints":{"codehealthFindingId/v1":"bbad1cb9922c40c0b2aaa97f0689153f6f8c314dbe1450389853c9e739277e5b"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorAuthManagementRevokeWorkflow.execute: MethodTooLong \u2014 execute runs 108 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 8 over it, 1.08\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/management/PhabricatorAuthManagementRevokeWorkflow.php"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"c4e694b7d842561e6c93d08b3476890415333cadb8e7f1fc3fa35d60bdeb3353"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorProjectColumnHideController.handleRequest: MethodTooLong \u2014 handleRequest runs 108 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 8 over it, 1.08\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectColumnHideController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"5362864cbd19af031838088ee337cde14199b70c62157591195355ba0d387752"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorTypeaheadFunctionHelpController.handleRequest: MethodTooLong \u2014 handleRequest runs 108 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 8 over it, 1.08\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/typeahead/controller/PhabricatorTypeaheadFunctionHelpController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"97e2566a2d3e006eaac414f36d9c2701362ee1084476e4615bd72ca4f2072fb7"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorApplicationTransactionCommentView: ClassTooLong \u2014 431 significant lines (blank, comment-only and punctuation-only lines excluded), 42 methods. The bar is 400 significant lines; this is 31 over it, 1.08\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"51c14bce094d15fb07d7aa3cc2ed991722173a9ea10d37a133ed81d316b8e7bf"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorAuditManagementDeleteWorkflow.execute: MethodTooLong \u2014 execute runs 107 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 7 over it, 1.07\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/management/PhabricatorAuditManagementDeleteWorkflow.php"},"region":{"startLine":62}}}],"partialFingerprints":{"codehealthFindingId/v1":"478f120189c26d73b7501615bce97359784b490ad3664a805d3d9bad62ba1199"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorClusterConfigOptions.getOptions: MethodTooLong \u2014 getOptions runs 107 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 7 over it, 1.07\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/option/PhabricatorClusterConfigOptions.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"463771312f4a0914ec2d82a7d147b27e9ba236a82aec7c4eebc38ed8da53977e"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DifferentialQueryConduitAPIMethod.execute: MethodTooLong \u2014 execute runs 107 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 7 over it, 1.07\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php"},"region":{"startLine":65}}}],"partialFingerprints":{"codehealthFindingId/v1":"fe225db6244bb25d5f6518dcd81dc698dc31fbdaa750c582905d6c7b68381aca"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DiffusionLowLevelResolveRefsQuery.resolveGitRefs: MethodTooLong \u2014 resolveGitRefs runs 107 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 7 over it, 1.07\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/lowlevel/DiffusionLowLevelResolveRefsQuery.php"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"a81752ab255db95921a264efc090eb35e9ccbf52fff7cdfc72c24c44557dd336"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: ManiphestTaskQuery.buildJoinClauseParts: MethodTooLong \u2014 buildJoinClauseParts runs 107 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 7 over it, 1.07\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/query/ManiphestTaskQuery.php"},"region":{"startLine":616}}}],"partialFingerprints":{"codehealthFindingId/v1":"420aea08a17299479ee69d59871eb342b083f90e3566e8a780b4179fa935df90"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorApplicationSearchController.processExportRequest: MethodTooLong \u2014 processExportRequest runs 107 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 7 over it, 1.07\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/controller/PhabricatorApplicationSearchController.php"},"region":{"startLine":399}}}],"partialFingerprints":{"codehealthFindingId/v1":"45e834262950a54636b93396ecac13241b45e8b961125ebb7436cb989498a653"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: ManiphestTaskSearchEngine: ClassTooLong \u2014 427 significant lines (blank, comment-only and punctuation-only lines excluded), 22 methods. The bar is 400 significant lines; this is 27 over it, 1.07\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/query/ManiphestTaskSearchEngine.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"a579b15ede4ce98a19adffc55f7a448a05050b1d5978aebfab90370994facc3d"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: AlmanacBinding: TooManyMethods \u2014 32 methods. The bar is 30 methods; this is 2 over it, 1.07\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/storage/AlmanacBinding.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"a812059a5eb12301d12132fb251f47998ca4a1981be693ec591c9995111ffb81"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorConfigOption: TooManyMethods \u2014 32 methods. The bar is 30 methods; this is 2 over it, 1.07\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/option/PhabricatorConfigOption.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"fe08905a2b69ee2712d3e68baaeb2b7a9b734c0bd54d1dff15f77813b4cc0452"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: ConpherenceThread: TooManyMethods \u2014 32 methods. The bar is 30 methods; this is 2 over it, 1.07\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/storage/ConpherenceThread.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"536cf72a873be73ae29fd1c107cf87e85a6e9eadfe41592c83bc48f404fee02b"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: DrydockBlueprintImplementation: TooManyMethods \u2014 32 methods. The bar is 30 methods; this is 2 over it, 1.07\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/blueprint/DrydockBlueprintImplementation.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"3d867a4961fdca10f01db6956916fadac1cfe52a46835db206d615050b17334d"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: HarbormasterBuildStepImplementation: TooManyMethods \u2014 32 methods. The bar is 30 methods; this is 2 over it, 1.07\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/step/HarbormasterBuildStepImplementation.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"07c55cccbb08ccbff69bb84dd8617999fc87c1d9ac0e1e2f9baf902467923c16"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorEditType: TooManyMethods \u2014 32 methods. The bar is 30 methods; this is 2 over it, 1.07\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/edittype/PhabricatorEditType.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"496b183b23586a16c5e84cbc03b2d3f0ecd43d4ddad916ba029059af22ddc753"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorEditEngineConfiguration: TooManyMethods \u2014 32 methods. The bar is 30 methods; this is 2 over it, 1.07\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"03aaf4c894af003bb66b63d41e8da403a189bdfe444ac48687784ccd20f350f4"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhabricatorStorageManagementAPI: TooManyMethods \u2014 32 methods. The bar is 30 methods; this is 2 over it, 1.07\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/management/PhabricatorStorageManagementAPI.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"63525212085b8a0cb51a34eb20907fa3a01192d27ce0f9e636c8353077a3b1fc"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: controller/HeraldTranscriptController.php: FileTooLong \u2014 533 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: HeraldTranscriptController (3-804). The bar is 500 significant lines; this is 33 over it, 1.07\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/controller/HeraldTranscriptController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"fca774286124339f7e01dc7c55c5b0f1d61904250c2fef0963c5f8bdc6461cd8"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorPHPConfigSetupCheck.executeChecks: MethodTooLong \u2014 executeChecks runs 106 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 6 over it, 1.06\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/check/PhabricatorPHPConfigSetupCheck.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"e5da9ef2c4c9d70b5600b9ec3463e0c5f4d6097976a7efbc6b5453ce6aafdabc"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorConfigClusterNotificationsController.buildClusterNotificationStatus: MethodTooLong \u2014 buildClusterNotificationStatus runs 106 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 6 over it, 1.06\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/services/PhabricatorConfigClusterNotificationsController.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"b9ba38b62c5c231d604e046df19b4aea08587fae2daac11d4d04da9b2f77d8b7"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorCursorPagedPolicyAwareQuery.buildPagingClauseFromMultipleColumns: MethodTooLong \u2014 buildPagingClauseFromMultipleColumns runs 106 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 6 over it, 1.06\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php"},"region":{"startLine":727}}}],"partialFingerprints":{"codehealthFindingId/v1":"93da91344d862b96274c8e81f76de701c51741cc529781c6bf9b03726329e16f"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorStorageManagementQuickstartWorkflow.execute: MethodTooLong \u2014 execute runs 106 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 6 over it, 1.06\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/management/workflow/PhabricatorStorageManagementQuickstartWorkflow.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"6e91e9a04ec840a8bf9f03b68b03dbe4c4f4243d3a46c10797c007d3120ba8a2"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorStorageManagementRenamespaceWorkflow.didExecute: MethodTooLong \u2014 didExecute runs 106 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 6 over it, 1.06\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/management/workflow/PhabricatorStorageManagementRenamespaceWorkflow.php"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"3b8b4c2e1df44f07ba737a257162b16dfe42096cefb61e2a03eea5cb1be9425e"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorRepositoryRefEngine: ClassTooLong \u2014 421 significant lines (blank, comment-only and punctuation-only lines excluded), 18 methods. The bar is 400 significant lines; this is 21 over it, 1.05\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/engine/PhabricatorRepositoryRefEngine.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"27e19f3a5bb4f226523d57f6ef093447000ae8ded8ac4f9e94b3a854227a5700"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: controller/PhabricatorAuthRegisterController.php: FileTooLong \u2014 526 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorAuthRegisterController (3-758). The bar is 500 significant lines; this is 26 over it, 1.05\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthRegisterController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"11c6bf6317e31fac1e510859978d643c9394534aeb8304f6c413ba91fca5dc9a"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: engine/PhabricatorRepositoryDiscoveryEngine.php: FileTooLong \u2014 525 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorRepositoryDiscoveryEngine (10-931). The bar is 500 significant lines; this is 25 over it, 1.05\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"3b0271efa0ae0170ce0b7eb2ef902040860e0844f19e8359c6c51f945b1823df"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: ConpherenceThreadSearchEngine.loadContextMessages: MethodTooLong \u2014 loadContextMessages runs 105 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 5 over it, 1.05\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/query/ConpherenceThreadSearchEngine.php"},"region":{"startLine":233}}}],"partialFingerprints":{"codehealthFindingId/v1":"f773218992d541ed15d5fd6489bd5842f3f1886519242e5f1678a9fc7afa1c36"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DivinerBookEditController.handleRequest: MethodTooLong \u2014 handleRequest runs 105 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 5 over it, 1.05\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/controller/DivinerBookEditController.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"45fbb9a8670973363f12059987c543689257b44a7e017f2c9ca4cd5c9edfb486"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: HarbormasterPlanViewController.buildStepList: MethodTooLong \u2014 buildStepList runs 105 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 5 over it, 1.05\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterPlanViewController.php"},"region":{"startLine":92}}}],"partialFingerprints":{"codehealthFindingId/v1":"556db1da29de6d37ccb35deec1a3d1e1bdadac405b262d1fc327cf5325299230"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorApplicationEmailCommandsController.handleRequest: MethodTooLong \u2014 handleRequest runs 105 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 5 over it, 1.05\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/meta/controller/PhabricatorApplicationEmailCommandsController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"8bbadbda0427ba76c3d30d04740c2049077d4cd864076620faf54a622f6263eb"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: DiffusionRepositoryEditEngine: ClassTooLong \u2014 419 significant lines (blank, comment-only and punctuation-only lines excluded), 22 methods. The bar is 400 significant lines; this is 19 over it, 1.05\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"04774d3901dd3d4b31dd2c1ca5778d60b941ae3a7e3939c68bb83f71c840b44b"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: parser/DifferentialHunkParser.php: FileTooLong \u2014 522 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: DifferentialHunkParser (3-912). The bar is 500 significant lines; this is 22 over it, 1.04\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialHunkParser.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"b7d7e5c0dc21965b0dfcfc4de890f506eb7b0adcf179de73fc81b6455d13c656"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: editfield/PhabricatorEditField.php: FileTooLong \u2014 522 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorEditField (3-920). The bar is 500 significant lines; this is 22 over it, 1.04\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editfield/PhabricatorEditField.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"87aa1d43bff91f77b1798edf2dbc343796c81583ec203e61e8acb57bd17d5b04"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: ConpherenceThreadSearchEngine.renderResultList: MethodTooLong \u2014 renderResultList runs 104 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 4 over it, 1.04\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/query/ConpherenceThreadSearchEngine.php"},"region":{"startLine":94}}}],"partialFingerprints":{"codehealthFindingId/v1":"8b60027a3ed581e0d18f2cfbe3768e8b04df81aa36ec887e41e7b5a7a9465075"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorDocumentRenderingEngine.newDocumentView: MethodTooLong \u2014 newDocumentView runs 104 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 4 over it, 1.04\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php"},"region":{"startLine":45}}}],"partialFingerprints":{"codehealthFindingId/v1":"3c45a6683d04c2567ecf9ea02614e5025c8c0af984ea53b20e5c60fbe2ffd9f4"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorNotificationServersConfigType.validateStoredValue: MethodTooLong \u2014 validateStoredValue runs 104 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 4 over it, 1.04\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/notification/config/PhabricatorNotificationServersConfigType.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"e533d3cd041d020f2e9b4c736aa1a8faa68c6e8c2496b3778f305fbca68eea4b"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorPolicyEditEngineExtension.buildCustomEditFields: MethodTooLong \u2014 buildCustomEditFields runs 104 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 4 over it, 1.04\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/editor/PhabricatorPolicyEditEngineExtension.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"2a6e2633dfabe940ec89cd0b017e4633e3bf1091568969c5e110626797741983"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorBoardLayoutEngine.layoutBoard: MethodTooLong \u2014 layoutBoard runs 104 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 4 over it, 1.04\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/engine/PhabricatorBoardLayoutEngine.php"},"region":{"startLine":422}}}],"partialFingerprints":{"codehealthFindingId/v1":"44e92c887d0319920fbc306e4b896a9a8ecb67cca52bd3c7da58c9f1d7f416e1"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorProjectSearchEngine.buildCustomSearchFields: MethodTooLong \u2014 buildCustomSearchFields runs 104 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 4 over it, 1.04\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/query/PhabricatorProjectSearchEngine.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"cf93c9ea668d7de9ffdc3b92e984ef13bbf10f767056927c0cea712dcdb3a271"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: storage/DifferentialDiff.php: FileTooLong \u2014 518 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: DifferentialDiff (3-834). The bar is 500 significant lines; this is 18 over it, 1.04\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialDiff.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"a2d2533dfbb2b8d8150d233416284ff42cbf7119ada2a9d5db1ffe339c3f83d3"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: controller/HarbormasterBuildViewController.php: FileTooLong \u2014 517 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: HarbormasterBuildViewController (3-711). The bar is 500 significant lines; this is 17 over it, 1.03\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterBuildViewController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"f52d11c01017e5c2fff1ca12f7aec9b59dde773a1f9048c272d2d4fcbfccab2e"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: controller/LegalpadDocumentSignController.php: FileTooLong \u2014 517 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: LegalpadDocumentSignController (3-715). The bar is 500 significant lines; this is 17 over it, 1.03\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/legalpad/controller/LegalpadDocumentSignController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"dcbb267808f1f86c1a475b51fbfa6d7efc077b9dbe8bb5212cab1f22d926c5b1"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: menu/PhabricatorMainMenuView.php: FileTooLong \u2014 517 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorMainMenuView (3-736). The bar is 500 significant lines; this is 17 over it, 1.03\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/page/menu/PhabricatorMainMenuView.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"7d0bcc8b7cdffa0e54ed14162b22ad4335c9c7fcc5407c7d34a1ed05c4f2ce70"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: pholio/behavior-pholio-mock-view.js: FileTooLong \u2014 517 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 17 over it, 1.03\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"5a5bedfee8fae625d5b60fa3f170b46192da0c7cdb7811a9f97fd196d365685e"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhutilOAuthAuthAdapter: TooManyMethods \u2014 31 methods. The bar is 30 methods; this is 1 over it, 1.03\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/adapter/PhutilOAuthAuthAdapter.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"0920c0455007f48e7b8017fb1b54930274d78867e7424df75552a1b50201bd1e"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: DifferentialChangesetListView: TooManyMethods \u2014 31 methods. The bar is 30 methods; this is 1 over it, 1.03\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/view/DifferentialChangesetListView.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"d0b85ff846ef68a228e973cb6f58f891060440ba47353c53193dfe1c8f973dcd"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhortuneSubscription: TooManyMethods \u2014 31 methods. The bar is 30 methods; this is 1 over it, 1.03\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/storage/PhortuneSubscription.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"912ffc3f6729fa065506fd9190c095ba6072ddea03829c9cd6ea57d01fc723d0"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: PhrictionDocument: TooManyMethods \u2014 31 methods. The bar is 30 methods; this is 1 over it, 1.03\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/storage/PhrictionDocument.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"43d888bb28b5cb127f4c45c342121148466e02f7a9034b5a74b4f1e241dcb414"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: AphrontBaseMySQLDatabaseConnection: TooManyMethods \u2014 31 methods. The bar is 30 methods; this is 1 over it, 1.03\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"bf52463c96bf91128fa4c77ea76f9716fae81ae085dbc9fa778b084f1ea9d9f1"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: AphrontFormControl: TooManyMethods \u2014 31 methods. The bar is 30 methods; this is 1 over it, 1.03\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/form/control/AphrontFormControl.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"e4a3d15ccfe547bd486707085003c91e79e7f1c5a77afbcb7cce25a9d1f1b2e1"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorBuiltinPatchList: ClassTooLong \u2014 413 significant lines (blank, comment-only and punctuation-only lines excluded), 4 methods. The bar is 400 significant lines; this is 13 over it, 1.03\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/patch/PhabricatorBuiltinPatchList.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"8278b5af149c26fe58bb6d03d1d31086114a712098d3bea7eab0e4b108415d4f"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: commitchangeparser/PhabricatorRepositorySvnCommitChangeParserWorker.php: FileTooLong \u2014 515 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorRepositorySvnCommitChangeParserWorker (3-808). The bar is 500 significant lines; this is 15 over it, 1.03\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/commitchangeparser/PhabricatorRepositorySvnCommitChangeParserWorker.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"585f85c9a675e29ef81337e38b40d759a0de322383739437f97a9193fdfab7fa"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorConfigSchemaQuery.loadActualSchemaForServer: MethodTooLong \u2014 loadActualSchemaForServer runs 103 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 3 over it, 1.03\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/schema/PhabricatorConfigSchemaQuery.php"},"region":{"startLine":64}}}],"partialFingerprints":{"codehealthFindingId/v1":"10071bafcb9c9f7b030df2124e956ac3d698da8b72663653bfc97bc20e098c15"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DiffusionRepositoryURIViewController.buildPropertySection: MethodTooLong \u2014 buildPropertySection runs 103 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 3 over it, 1.03\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php"},"region":{"startLine":178}}}],"partialFingerprints":{"codehealthFindingId/v1":"f36be50ac0dd656948e5899d6cae30583bb038aa29da3101e70e94293ef58b61"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DiffusionRepositoryClusterEngine.synchronizeWorkingCopyBeforeRead: MethodTooLong \u2014 synchronizeWorkingCopyBeforeRead runs 103 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 3 over it, 1.03\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php"},"region":{"startLine":153}}}],"partialFingerprints":{"codehealthFindingId/v1":"951b554275b02aef0b9beeb064a8798b9114bf2d59edc30ece229b6f6c99533c"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorPeopleProfileManageController.buildCurtain: MethodTooLong \u2014 buildCurtain runs 103 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 3 over it, 1.03\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/controller/PhabricatorPeopleProfileManageController.php"},"region":{"startLine":79}}}],"partialFingerprints":{"codehealthFindingId/v1":"9c7ad50e59bdec946fc84f9a4b937ff32fc9b53bd775604f10d670dbd2307c75"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhameBlogHeaderPictureController.handleRequest: MethodTooLong \u2014 handleRequest runs 103 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 3 over it, 1.03\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"8a6492c6e1ba452badd6b4f0004651249b32e66a071ab81379016c4c9542facc"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorRepositoryPullEngine.executeGitUpdate: MethodTooLong \u2014 executeGitUpdate runs 103 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 3 over it, 1.03\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/engine/PhabricatorRepositoryPullEngine.php"},"region":{"startLine":275}}}],"partialFingerprints":{"codehealthFindingId/v1":"0722c6c988ace8f7faf7d7f0c2c58a6f0efc943ec0ea30e091f471ef0cfd2704"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorApplicationSearchEngine.buildConduitResponse: MethodTooLong \u2014 buildConduitResponse runs 103 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 3 over it, 1.03\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorApplicationSearchEngine.php"},"region":{"startLine":1144}}}],"partialFingerprints":{"codehealthFindingId/v1":"dcfeab55ae863a4f91d21c408367006885d9f2e0e502a8d8f192272c7aceaf3a"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorMultiFactorSettingsPanel.processRequest: MethodTooLong \u2014 processRequest runs 103 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 3 over it, 1.03\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/settings/panel/PhabricatorMultiFactorSettingsPanel.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"df2a656b4c82dbea32669fcd04c49c5e2538fc27d18b959945d80f6f8e4242a1"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PHUICalendarMonthView: ClassTooLong \u2014 408 significant lines (blank, comment-only and punctuation-only lines excluded), 23 methods. The bar is 400 significant lines; this is 8 over it, 1.02\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/calendar/PHUICalendarMonthView.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"f51aa342d22290b2e215407e499576fc9f0532f8f42698884796d5ed611c0e78"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorController.willBeginExecution: MethodTooLong \u2014 willBeginExecution runs 102 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 2 over it, 1.02\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/base/controller/PhabricatorController.php"},"region":{"startLine":64}}}],"partialFingerprints":{"codehealthFindingId/v1":"814fdfcab3d41b1e43d8f00e31ed20592b9d4cc72fcaa2643e4553b591e7c6ea"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorStorageSetupCheck.executeChecks: MethodTooLong \u2014 executeChecks runs 102 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 2 over it, 1.02\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/check/PhabricatorStorageSetupCheck.php"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"f9ace9c23ed504949fa675b347f12e2ecd26fc92fbe6042fc2bccad1edbfb75f"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorConfigDatabaseStatusController.renderColumn: MethodTooLong \u2014 renderColumn runs 102 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 2 over it, 1.02\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/services/PhabricatorConfigDatabaseStatusController.php"},"region":{"startLine":548}}}],"partialFingerprints":{"codehealthFindingId/v1":"626df29dc3b13cc445288c9542b102018f58e2e4f2e71af2bad105faa39a98bd"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DifferentialRevisionListView.render: MethodTooLong \u2014 render runs 102 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 2 over it, 1.02\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/view/DifferentialRevisionListView.php"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"3f35a0235a179de2fd53bd7cb31cded93634696499bf83ee3f0db6bba81074c7"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorFileTransformListController.handleRequest: MethodTooLong \u2014 handleRequest runs 102 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 2 over it, 1.02\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/controller/PhabricatorFileTransformListController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"d17bc49afa69b346036838387d03913486492ea5500cde363b354d247e25c02f"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorFileQuery.buildWhereClauseParts: MethodTooLong \u2014 buildWhereClauseParts runs 102 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 2 over it, 1.02\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/query/PhabricatorFileQuery.php"},"region":{"startLine":396}}}],"partialFingerprints":{"codehealthFindingId/v1":"0f898e870302135fcce4b71e489ed028706198442649b4afa1658ef14ae42bc2"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: ManiphestTaskStatus.validateConfiguration: MethodTooLong \u2014 validateConfiguration runs 102 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 2 over it, 1.02\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/constants/ManiphestTaskStatus.php"},"region":{"startLine":261}}}],"partialFingerprints":{"codehealthFindingId/v1":"743edb42d1565f40ef3bad8b621e61d6c67fba9d30f9690eb7d2c9ce83e05996"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorPhortuneManagementInvoiceWorkflow.execute: MethodTooLong \u2014 execute runs 102 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 2 over it, 1.02\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/management/PhabricatorPhortuneManagementInvoiceWorkflow.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"acd0bda700cad4d29d9d2c691fced92e84e3542c94141575dd501d5a19a18b13"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhrictionMoveController.handleRequest: MethodTooLong \u2014 handleRequest runs 102 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 2 over it, 1.02\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/controller/PhrictionMoveController.php"},"region":{"startLine":5}}}],"partialFingerprints":{"codehealthFindingId/v1":"4bd5ad610aba0ad5a86ea6d8c42008de4e28500df6234034a1e42f137b040ca5"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorProjectBoardViewController.buildColumnMenu: MethodTooLong \u2014 buildColumnMenu runs 102 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 2 over it, 1.02\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectBoardViewController.php"},"region":{"startLine":670}}}],"partialFingerprints":{"codehealthFindingId/v1":"ec4587cd048e9a2afc83d96f1743cd7e416efe1963ed5503bbf1f294b81334a6"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorProjectColumnEditController.handleRequest: MethodTooLong \u2014 handleRequest runs 102 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 2 over it, 1.02\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectColumnEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"be2c5940260436a43b0a7f713a385a79dd729a777d68756df63cab83a3198f16"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorRepositoryQuery.buildWhereClauseParts: MethodTooLong \u2014 buildWhereClauseParts runs 102 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 2 over it, 1.02\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/query/PhabricatorRepositoryQuery.php"},"region":{"startLine":533}}}],"partialFingerprints":{"codehealthFindingId/v1":"a9ab48e5c1cf51a4cb7e159f5e2d9eb1c4aca10703499de8f46912ff30a0969c"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: DoorkeeperAsanaFeedWorker: ClassTooLong \u2014 407 significant lines (blank, comment-only and punctuation-only lines excluded), 16 methods. The bar is 400 significant lines; this is 7 over it, 1.02\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/worker/DoorkeeperAsanaFeedWorker.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"2cebebf56b7f4e82bb2edcadad6ad234d9f3d20bcd9191dcb442fb61ba1d2b43"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorDaemonManagementWorkflow: ClassTooLong \u2014 406 significant lines (blank, comment-only and punctuation-only lines excluded), 20 methods. The bar is 400 significant lines; this is 6 over it, 1.02\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"ff477b6207a01396fa8978c419da3dcc4cbb432ee30f5d9c5de6d193a66ddfb6"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: storage/PhabricatorOwnersPackage.php: FileTooLong \u2014 507 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PhabricatorOwnersPackage (3-848). The bar is 500 significant lines; this is 7 over it, 1.01\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/owners/storage/PhabricatorOwnersPackage.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"28783ca3bbec076f6a4afe6ea3f748f0320bcfe4ffa9bd246d797abb8b39f07e"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: phui/PHUITimelineEventView.php: FileTooLong \u2014 506 significant lines (blank, comment-only and punctuation-only lines excluded), about 100% of them inside a single declaration: PHUITimelineEventView (3-768). The bar is 500 significant lines; this is 6 over it, 1.01\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUITimelineEventView.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"7913999554a67d0c267da1bd276567acb5997545425ec8ee8ff5fcb53e8ece63"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorAphlictManagementWorkflow: ClassTooLong \u2014 404 significant lines (blank, comment-only and punctuation-only lines excluded), 18 methods. The bar is 400 significant lines; this is 4 over it, 1.01\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"24d4341f2d3a8b70f219a6c82e9a6252217de173a40ed7c53b46f157b6fbfcef"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorDatabaseSetupCheck.executeRefChecks: MethodTooLong \u2014 executeRefChecks runs 101 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 1 over it, 1.01\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/check/PhabricatorDatabaseSetupCheck.php"},"region":{"startLine":96}}}],"partialFingerprints":{"codehealthFindingId/v1":"b4373f3de6dcd36bb34fbd77a9ae5ee5e529df7c7186cbffecd833e01bb59841"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DifferentialTransaction.getTitleForFeed: MethodTooLong \u2014 getTitleForFeed runs 101 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 1 over it, 1.01\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialTransaction.php"},"region":{"startLine":281}}}],"partialFingerprints":{"codehealthFindingId/v1":"b6e50a2faf1b5ce971e56e0e713b1f312b24c2824e69e9ecaa04da2595465ae4"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: DiffusionRefTableController.handleRequest: MethodTooLong \u2014 handleRequest runs 101 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 1 over it, 1.01\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRefTableController.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"4d3d3bc50de3284da099d30d0f6f882c215c64c30a7bfa6c513b6ee818f24a4b"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: HeraldRuleController.setupEditorBehavior: MethodTooLong \u2014 setupEditorBehavior runs 101 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 1 over it, 1.01\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/controller/HeraldRuleController.php"},"region":{"startLine":400}}}],"partialFingerprints":{"codehealthFindingId/v1":"22d0ac3e2c6e043aef48c14efeda49babda0994e3be94ec030b2bcc107215c0d"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: HeraldWebhookWorker.doWork: MethodTooLong \u2014 doWork runs 101 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 1 over it, 1.01\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/worker/HeraldWebhookWorker.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"93cd0575d7efa12c0c3b2263d60ab986818370951837df04eae2b2cd3c60f4b8"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorMetaMTAApplicationEmailPanel.returnSaveAddressResponse: MethodTooLong \u2014 returnSaveAddressResponse runs 101 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 1 over it, 1.01\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/applicationpanel/PhabricatorMetaMTAApplicationEmailPanel.php"},"region":{"startLine":161}}}],"partialFingerprints":{"codehealthFindingId/v1":"83ab1c4c5232e2ae2bc899513ee5940f7d9ccda60333ddb4f6fe7227ef12dbe6"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorMentionRemarkupRule.didMarkupText: MethodTooLong \u2014 didMarkupText runs 101 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 1 over it, 1.01\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/markup/PhabricatorMentionRemarkupRule.php"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"9fb2944c1fef67be27e087d7b94b91d6ac754afa81d306c3ab9e50cb0bdc8404"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorSearchEditController.handleRequest: MethodTooLong \u2014 handleRequest runs 101 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 1 over it, 1.01\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/controller/PhabricatorSearchEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"ec5538ce63fab15240f14dc60bfcd050e0ee87356da300c771eabf01b940a4c2"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PhabricatorSearchEngineAPIMethod.buildConstraintsDocumentationPage: MethodTooLong \u2014 buildConstraintsDocumentationPage runs 101 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 1 over it, 1.01\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorSearchEngineAPIMethod.php"},"region":{"startLine":154}}}],"partialFingerprints":{"codehealthFindingId/v1":"efa4c2f04a669f307eee8c81075d764a410d8fa29a546b12720205338f532bfe"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: DrydockLease: ClassTooLong \u2014 401 significant lines (blank, comment-only and punctuation-only lines excluded), 55 methods. The bar is 400 significant lines; this is 1 over it, 1.00\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/storage/DrydockLease.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"959fb3c7427308dba14faac5de9c9fe547c626d00bee207eef6cef32df6b1691"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: PhabricatorManiphestConfigOptions: ClassTooLong \u2014 401 significant lines (blank, comment-only and punctuation-only lines excluded), 5 methods. The bar is 400 significant lines; this is 1 over it, 1.00\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"47044fd8dd4e865596a0191d7835e1e56be942ad76c9dd4187df79013c806313"}},{"ruleId":"D4","level":"warning","message":{"text":"Near-duplicate member family (6 members, 102 shared lines): src/applications/conpherence/controller/ConpherenceRoomPictureController.php:7-232 | src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php:7-247 | src/applications/people/controller/PhabricatorPeopleProfilePictureController.php:7-288 | src/applications/phame/controller/blog/PhameBlogProfilePictureController.php:7-238 | src/applications/phortune/controller/merchant/PhortuneMerchantPictureController.php:11-220 | src/applications/project/controller/PhabricatorProjectEditPictureController.php:7-287 \u2014 These 6 members are variants of one another: a block of 102 lines reported below appears in every one of them, and the pairwise near-duplicate rows they would otherwise produce are collapsed into this row. Read them as one construct written 6 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 6 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceRoomPictureController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"3c850f2f97adc1ca6076f1cc854f7402da8d6b3987189bd1ca222aab5be56dfc"}},{"ruleId":"D4","level":"warning","message":{"text":"Near-duplicate member family (4 members, 49 shared lines): src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php:7-136 | src/applications/phame/controller/blog/PhameBlogProfilePictureController.php:7-238 | src/applications/phame/controller/post/PhamePostHeaderPictureController.php:7-133 | src/applications/phortune/controller/merchant/PhortuneMerchantPictureController.php:11-220 \u2014 These 4 members are variants of one another: a block of 49 lines reported below appears in every one of them, and the pairwise near-duplicate rows they would otherwise produce are collapsed into this row. Read them as one construct written 4 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"55b5c8d5fe943f7ef282d310fc395e2d52b398fa9acbc665a119d30506ecc24c"}},{"ruleId":"D4","level":"warning","message":{"text":"Near-duplicate member family (4 members, 26 shared lines): src/applications/people/controller/PhabricatorPeopleProfileBadgesController.php:7-59 | src/applications/people/controller/PhabricatorPeopleProfileCommitsController.php:7-51 | src/applications/people/controller/PhabricatorPeopleProfileRevisionsController.php:7-51 | src/applications/people/controller/PhabricatorPeopleProfileTasksController.php:7-51 \u2014 These 4 members are variants of one another: a block of 26 lines reported below appears in every one of them, and the pairwise near-duplicate rows they would otherwise produce are collapsed into this row. Read them as one construct written 4 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/controller/PhabricatorPeopleProfileBadgesController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"c1232f57525ab03132032cbbb0628975964ab5436bc7a4c644ffc1d354aed2a1"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (84 members, 50\u002B identical tokens): src/applications/almanac/query/AlmanacBindingQuery.php:95-146 | src/applications/almanac/query/AlmanacDeviceQuery.php:60-115 | src/applications/almanac/query/AlmanacInterfaceQuery.php:88-133 | src/applications/almanac/query/AlmanacNamespaceQuery.php:36-59 | src/applications/almanac/query/AlmanacNetworkQuery.php:36-59 | src/applications/almanac/query/AlmanacServiceQuery.php:86-142 | src/applications/auth/query/PhabricatorAuthChallengeQuery.php:44-88 | src/applications/auth/query/PhabricatorAuthContactNumberQuery.php:48-92 | src/applications/auth/query/PhabricatorAuthFactorConfigQuery.php:42-79 | src/applications/auth/query/PhabricatorAuthFactorProviderQuery.php:36-66 | src/applications/auth/query/PhabricatorAuthMessageQuery.php:30-53 | src/applications/auth/query/PhabricatorAuthPasswordQuery.php:42-79 | src/applications/auth/query/PhabricatorAuthProviderConfigQuery.php:36-66 | src/applications/auth/query/PhabricatorAuthSSHKeyQuery.php:78-126 | src/applications/auth/query/PhabricatorAuthSessionQuery.php:64-106 | src/applications/auth/query/PhabricatorExternalAccountIdentifierQuery.php:42-83 | src/applications/auth/query/PhabricatorExternalAccountQuery.php:146-211 | src/applications/badges/query/PhabricatorBadgesQuery.php:46-76 | src/applications/calendar/query/PhabricatorCalendarEventQuery.php:358-497 | src/applications/calendar/query/PhabricatorCalendarExportQuery.php:42-79 | src/applications/calendar/query/PhabricatorCalendarExternalInviteeQuery.php:30-57 | src/applications/calendar/query/PhabricatorCalendarImportLogQuery.php:30-54 | src/applications/calendar/query/PhabricatorCalendarImportQuery.php:36-66 | src/applications/countdown/query/PhabricatorCountdownQuery.php:36-66 | src/applications/dashboard/query/PhabricatorDashboardPanelQuery.php:50-87 | src/applications/dashboard/query/PhabricatorDashboardPortalQuery.php:30-53 | src/applications/dashboard/query/PhabricatorDashboardQuery.php:58-88 | src/applications/differential/query/DifferentialDiffQuery.php:123-184 | src/applications/drydock/query/DrydockAuthorizationQuery.php:124-168 | src/applications/drydock/query/DrydockBlueprintQuery.php:147-207 | src/applications/drydock/query/DrydockLeaseQuery.php:109-167 | src/applications/drydock/query/DrydockRepositoryOperationQuery.php:124-182 | src/applications/drydock/query/DrydockResourceQuery.php:94-138 | src/applications/files/query/PhabricatorFileQuery.php:397-535 | src/applications/fund/query/FundInitiativeQuery.php:36-66 | src/applications/harbormaster/query/HarbormasterBuildLogQuery.php:56-79 | src/applications/harbormaster/query/HarbormasterBuildPlanQuery.php:74-111 | src/applications/harbormaster/query/HarbormasterBuildQuery.php:141-197 | src/applications/harbormaster/query/HarbormasterBuildStepQuery.php:30-53 | src/applications/harbormaster/query/HarbormasterBuildTargetQuery.php:73-152 | src/applications/harbormaster/query/HarbormasterBuildUnitMessageQuery.php:30-53 | src/applications/harbormaster/query/HarbormasterBuildableQuery.php:129-173 | src/applications/herald/query/HeraldRuleQuery.php:201-273 | src/applications/herald/query/HeraldWebhookQuery.php:30-53 | src/applications/herald/query/HeraldWebhookRequestQuery.php:44-88 | src/applications/legalpad/query/LegalpadDocumentQuery.php:158-209 | src/applications/macro/query/PhabricatorMacroQuery.php:104-202 | src/applications/metamta/query/PhabricatorMetaMTAMailQuery.php:40-77 | src/applications/nuance/query/NuanceItemQuery.php:131-189 | src/applications/packages/query/PhabricatorPackagesPackageQuery.php:48-83 | src/applications/packages/query/PhabricatorPackagesPublisherQuery.php:36-59 | src/applications/packages/query/PhabricatorPackagesVersionQuery.php:48-83 | src/applications/passphrase/query/PassphraseCredentialQuery.php:103-154 | src/applications/paste/query/PhabricatorPasteQuery.php:104-162 | src/applications/phame/query/PhamePostQuery.php:103-147 | src/applications/pholio/query/PholioImageQuery.php:48-71 | src/applications/pholio/query/PholioMockQuery.php:72-102 | src/applications/phortune/query/PhortuneAccountEmailQuery.php:65-102 | src/applications/phortune/query/PhortuneAccountQuery.php:86-109 | src/applications/phortune/query/PhortuneMerchantQuery.php:80-103 | src/applications/phortune/query/PhortunePaymentMethodQuery.php:102-139 | src/applications/phortune/query/PhortuneSubscriptionQuery.php:145-189 | src/applications/phriction/query/PhrictionContentQuery.php:36-66 | src/applications/phriction/query/PhrictionDocumentQuery.php:200-336 | src/applications/phurl/query/PhabricatorPhurlURLQuery.php:54-98 | src/applications/ponder/query/PonderAnswerQuery.php:32-55 | src/applications/ponder/query/PonderQuestionQuery.php:52-82 | src/applications/project/query/PhabricatorProjectColumnQuery.php:172-224 | src/applications/project/query/PhabricatorProjectTriggerQuery.php:39-69 | src/applications/repository/query/PhabricatorRepositoryIdentityQuery.php:70-149 | src/applications/repository/query/PhabricatorRepositoryPullEventQuery.php:80-124 | src/applications/repository/query/PhabricatorRepositoryPushEventQuery.php:81-111 | src/applications/repository/query/PhabricatorRepositoryPushLogQuery.php:89-162 | src/applications/repository/query/PhabricatorRepositoryQuery.php:534-676 | src/applications/repository/query/PhabricatorRepositoryRefCursorQuery.php:93-142 | src/applications/repository/query/PhabricatorRepositorySyncEventQuery.php:67-104 | src/applications/repository/query/PhabricatorRepositoryURIQuery.php:38-61 | src/applications/search/query/PhabricatorProfileMenuItemConfigurationQuery.php:44-92 | src/applications/settings/query/PhabricatorUserPreferencesQuery.php:147-189 | src/applications/slowvote/query/PhabricatorSlowvoteQuery.php:117-147 | src/applications/spaces/query/PhabricatorSpacesNamespaceQuery.php:44-79 | src/applications/transactions/query/PhabricatorApplicationTransactionQuery.php:189-248 | src/applications/transactions/query/PhabricatorEditEngineConfigurationQuery.php:232-277 | src/infrastructure/daemon/workers/query/PhabricatorWorkerBulkJobQuery.php:58-95 \u2014 These 84 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 84 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 84 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/query/AlmanacBindingQuery.php"},"region":{"startLine":95}}}],"partialFingerprints":{"codehealthFindingId/v1":"2a61bfd9fe85a22cfd52b5ba1c75b27c7fa1b731d9e1b1fd0175531dec799e21"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (19 members, 50\u002B identical tokens): src/applications/badges/query/PhabricatorBadgesSearchEngine.php:138-154 | src/applications/countdown/query/PhabricatorCountdownSearchEngine.php:147-163 | src/applications/dashboard/controller/panel/PhabricatorDashboardPanelListController.php:52-67 | src/applications/differential/query/DifferentialRevisionSearchEngine.php:251-267 | src/applications/files/query/PhabricatorFileSearchEngine.php:196-211 | src/applications/herald/query/HeraldRuleSearchEngine.php:153-169 | src/applications/legalpad/query/LegalpadDocumentSearchEngine.php:176-191 | src/applications/macro/query/PhabricatorMacroSearchEngine.php:193-208 | src/applications/maniphest/query/ManiphestTaskSearchEngine.php:441-457 | src/applications/owners/query/PhabricatorOwnersPackageSearchEngine.php:159-176 | src/applications/passphrase/query/PassphraseCredentialSearchEngine.php:115-130 | src/applications/paste/query/PhabricatorPasteSearchEngine.php:207-222 | src/applications/pholio/query/PholioMockSearchEngine.php:134-150 | src/applications/phurl/query/PhabricatorPhurlURLSearchEngine.php:127-145 | src/applications/ponder/query/PonderQuestionSearchEngine.php:184-199 | src/applications/project/query/PhabricatorProjectSearchEngine.php:340-356 | src/applications/repository/query/PhabricatorRepositorySearchEngine.php:269-284 | src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php:167-182 | src/applications/spaces/query/PhabricatorSpacesNamespaceSearchEngine.php:102-118 \u2014 These 19 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 19 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 19 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/query/PhabricatorBadgesSearchEngine.php"},"region":{"startLine":138}}}],"partialFingerprints":{"codehealthFindingId/v1":"a6181453c7f849c90ed73e53227576a4c60b02699a9ac8a2259ca9ff936ba389"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (18 members, 50\u002B identical tokens): src/applications/calendar/phid/PhabricatorCalendarEventPHIDType.php:58-76 | src/applications/countdown/phid/PhabricatorCountdownCountdownPHIDType.php:52-70 | src/applications/dashboard/phid/PhabricatorDashboardPanelPHIDType.php:58-76 | src/applications/differential/phid/DifferentialRevisionPHIDType.php:58-76 | src/applications/files/phid/PhabricatorFileFilePHIDType.php:56-74 | src/applications/fund/phid/FundInitiativePHIDType.php:57-75 | src/applications/harbormaster/phid/HarbormasterBuildablePHIDType.php:67-85 | src/applications/herald/phid/HeraldRulePHIDType.php:56-74 | src/applications/legalpad/phid/PhabricatorLegalpadDocumentPHIDType.php:53-71 | src/applications/maniphest/phid/ManiphestTaskPHIDType.php:55-73 | src/applications/owners/phid/PhabricatorOwnersPackagePHIDType.php:65-83 | src/applications/passphrase/phid/PassphraseCredentialPHIDType.php:55-73 | src/applications/paste/phid/PhabricatorPastePastePHIDType.php:52-70 | src/applications/pholio/phid/PholioMockPHIDType.php:56-74 | src/applications/phurl/phid/PhabricatorPhurlURLPHIDType.php:54-72 | src/applications/ponder/phid/PonderQuestionPHIDType.php:51-69 | src/applications/slowvote/phid/PhabricatorSlowvotePollPHIDType.php:49-67 | src/applications/spaces/phid/PhabricatorSpacesNamespacePHIDType.php:59-77 \u2014 These 18 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 18 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 18 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/phid/PhabricatorCalendarEventPHIDType.php"},"region":{"startLine":58}}}],"partialFingerprints":{"codehealthFindingId/v1":"488ff3fe6d1fe29b45495aa2b7acf618f1f5af1128c47a1a414ecfb0c197d1fa"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (10 members, 50\u002B identical tokens): src/applications/phortune/controller/account/PhortuneAccountChargesController.php:11-36 | src/applications/phortune/controller/account/PhortuneAccountEmailAddressesController.php:11-36 | src/applications/phortune/controller/account/PhortuneAccountManagersController.php:11-36 | src/applications/phortune/controller/account/PhortuneAccountOrdersController.php:11-37 | src/applications/phortune/controller/account/PhortuneAccountOverviewController.php:11-49 | src/applications/phortune/controller/account/PhortuneAccountPaymentMethodController.php:11-36 | src/applications/phortune/controller/account/PhortuneAccountSubscriptionController.php:11-37 | src/applications/phortune/controller/merchant/PhortuneMerchantInvoiceCreateController.php:12-262 | src/applications/phortune/controller/merchant/PhortuneMerchantOrdersController.php:11-34 | src/applications/phortune/controller/merchant/PhortuneMerchantSubscriptionsController.php:11-35 \u2014 These 10 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 10 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 10 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountChargesController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"d6a122f05bd7621ca0511b262b707d82bc814f7b5d84f4648cdb6134e5257e95"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (9 members, 50\u002B identical tokens): src/applications/auth/controller/config/PhabricatorAuthProviderViewController.php:68-104 | src/applications/auth/controller/contact/PhabricatorAuthContactNumberViewController.php:83-136 | src/applications/auth/controller/mfa/PhabricatorAuthFactorProviderViewController.php:98-124 | src/applications/fund/controller/FundInitiativeViewController.php:116-165 | src/applications/herald/controller/HeraldRuleViewController.php:68-105 | src/applications/nuance/controller/NuanceItemViewController.php:54-81 | src/applications/nuance/controller/NuanceQueueViewController.php:55-81 | src/applications/phortune/controller/merchant/PhortuneMerchantDetailsController.php:99-148 | src/applications/project/controller/PhabricatorProjectManageController.php:76-128 \u2014 These 9 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 9 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 9 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/config/PhabricatorAuthProviderViewController.php"},"region":{"startLine":68}}}],"partialFingerprints":{"codehealthFindingId/v1":"10abdf1a21acfc3539c7e07179aac333edcc6d5125652b358012f3538c97d0d9"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (7 members, 50\u002B identical tokens): src/applications/auth/query/PhabricatorAuthPasswordQuery.php:83-103 | src/applications/auth/query/PhabricatorAuthSSHKeyQuery.php:51-74 | src/applications/auth/query/PhabricatorAuthSessionQuery.php:42-60 | src/applications/conduit/query/PhabricatorConduitTokenQuery.php:90-108 | src/applications/drydock/query/DrydockCommandQuery.php:29-48 | src/applications/people/query/PhabricatorPeopleUserEmailQuery.php:49-70 | src/applications/search/query/PhabricatorProfileMenuItemConfigurationQuery.php:111-148 \u2014 These 7 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 7 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 7 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/query/PhabricatorAuthPasswordQuery.php"},"region":{"startLine":83}}}],"partialFingerprints":{"codehealthFindingId/v1":"9ddc04d2dcc9f8bbd8fcc9c25279f67f0777d0effef08f1eaf6e72384b0072b5"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (7 members, 50\u002B identical tokens): src/applications/calendar/controller/PhabricatorCalendarExportDisableController.php:7-60 | src/applications/calendar/controller/PhabricatorCalendarImportDeleteController.php:7-61 | src/applications/calendar/controller/PhabricatorCalendarImportDisableController.php:7-68 | src/applications/calendar/controller/PhabricatorCalendarImportReloadController.php:7-49 | src/applications/harbormaster/controller/HarbormasterPlanBehaviorController.php:7-89 | src/applications/harbormaster/controller/HarbormasterPlanDisableController.php:7-65 | src/applications/harbormaster/controller/HarbormasterStepAddController.php:7-105 \u2014 These 7 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 7 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 7 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/controller/PhabricatorCalendarExportDisableController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"c602b7411d1bbf9fcddb9725aa1edc9eab1db85381ccc53c22fa851865814713"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (7 members, 50\u002B identical tokens): src/applications/harbormaster/query/HarbormasterBuildMessageQuery.php:30-54 | src/applications/harbormaster/query/HarbormasterBuildQuery.php:60-81 | src/applications/harbormaster/query/HarbormasterBuildQuery.php:85-137 | src/applications/harbormaster/query/HarbormasterBuildStepQuery.php:57-78 | src/applications/harbormaster/query/HarbormasterBuildTargetQuery.php:181-202 | src/applications/harbormaster/query/HarbormasterBuildableQuery.php:67-88 | src/applications/harbormaster/query/HarbormasterBuildableQuery.php:92-125 \u2014 These 7 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 7 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 7 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/query/HarbormasterBuildMessageQuery.php"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"1f3bd15f7f25b6820546d850724b44a68fca4e48862c85aaaa943ef394fdd506"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (6 members, 50\u002B identical tokens): src/applications/search/menuitem/PhabricatorApplicationProfileMenuItem.php:99-135 | src/applications/search/menuitem/PhabricatorConpherenceProfileMenuItem.php:130-166 | src/applications/search/menuitem/PhabricatorDashboardProfileMenuItem.php:186-222 | src/applications/search/menuitem/PhabricatorEditEngineProfileMenuItem.php:127-167 | src/applications/search/menuitem/PhabricatorLinkProfileMenuItem.php:103-144 | src/applications/search/menuitem/PhabricatorProjectProfileMenuItem.php:114-150 \u2014 These 6 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 6 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 6 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/menuitem/PhabricatorApplicationProfileMenuItem.php"},"region":{"startLine":99}}}],"partialFingerprints":{"codehealthFindingId/v1":"40ccff0d73a09227efbf7652c792c9d153ec44099877d751be9aa8bae1d50900"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (5 members, 50\u002B identical tokens): src/applications/almanac/controller/AlmanacDeviceViewController.php:85-105 | src/applications/almanac/controller/AlmanacNamespaceViewController.php:58-78 | src/applications/almanac/controller/AlmanacNetworkViewController.php:59-79 | src/applications/almanac/controller/AlmanacServiceViewController.php:90-110 | src/applications/diffusion/controller/DiffusionIdentityViewController.php:59-79 \u2014 These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/controller/AlmanacDeviceViewController.php"},"region":{"startLine":85}}}],"partialFingerprints":{"codehealthFindingId/v1":"e5991748213c29d9abd8ab6f8f0a7d863c6446e27eddf8181e10646d6262ea4f"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (5 members, 50\u002B identical tokens): src/applications/almanac/query/AlmanacDeviceSearchEngine.php:100-137 | src/applications/almanac/query/AlmanacServiceSearchEngine.php:93-116 | src/applications/auth/query/PhabricatorAuthSSHKeySearchEngine.php:80-103 | src/applications/nuance/query/NuanceQueueSearchEngine.php:56-74 | src/applications/nuance/query/NuanceSourceSearchEngine.php:65-86 \u2014 These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/query/AlmanacDeviceSearchEngine.php"},"region":{"startLine":100}}}],"partialFingerprints":{"codehealthFindingId/v1":"c55bef23ba890d2dac2c053576fe20abf94327d0eb78d15db2b6c9ba6ab0fbb0"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (5 members, 50\u002B identical tokens): src/applications/badges/controller/PhabricatorBadgesCommentController.php:7-61 | src/applications/pholio/controller/PholioMockCommentController.php:6-78 | src/applications/ponder/controller/PonderAnswerCommentController.php:6-60 | src/applications/ponder/controller/PonderQuestionCommentController.php:6-56 | src/applications/slowvote/controller/PhabricatorSlowvoteCommentController.php:7-61 \u2014 These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/controller/PhabricatorBadgesCommentController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"0cb91ca05b4761b37afa72c30addf9c2a7309ce5efa0f9ec3c6efdaabcd4191a"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (5 members, 50\u002B identical tokens): src/applications/conpherence/query/ConpherenceThreadQuery.php:80-134 | src/applications/phame/query/PhameBlogQuery.php:83-134 | src/applications/phame/query/PhamePostQuery.php:55-99 | src/applications/phortune/query/PhortuneMerchantQuery.php:36-76 | src/applications/repository/query/PhabricatorRepositoryQuery.php:348-409 \u2014 These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/query/ConpherenceThreadQuery.php"},"region":{"startLine":80}}}],"partialFingerprints":{"codehealthFindingId/v1":"7c9c0e3163ee21cb87c2f750a20e22e40585407d1ba0b7f8b788324a6f80baa5"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (5 members, 50\u002B identical tokens): src/applications/countdown/controller/PhabricatorCountdownViewController.php:110-130 | src/applications/passphrase/controller/PassphraseCredentialViewController.php:65-89 | src/applications/paste/controller/PhabricatorPasteViewController.php:153-173 | src/applications/ponder/controller/PonderQuestionViewController.php:182-202 | src/applications/slowvote/controller/PhabricatorSlowvotePollController.php:121-141 \u2014 These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/countdown/controller/PhabricatorCountdownViewController.php"},"region":{"startLine":110}}}],"partialFingerprints":{"codehealthFindingId/v1":"166841fad7f50d593012e72ee89914e2d9b3a0a22ad99a60550a0f4c4fd6e250"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (5 members, 50\u002B identical tokens): src/applications/dashboard/controller/dashboard/PhabricatorDashboardViewController.php:69-112 | src/applications/dashboard/controller/panel/PhabricatorDashboardPanelViewController.php:92-126 | src/applications/harbormaster/controller/HarbormasterPlanViewController.php:235-281 | src/applications/harbormaster/controller/HarbormasterStepViewController.php:118-144 | src/applications/phurl/controller/PhabricatorPhurlURLViewController.php:101-120 \u2014 These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/dashboard/PhabricatorDashboardViewController.php"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"5e823a26fbe98358d65e50f0ff54b86214a3695d202622d5a9689315aebfc219"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (5 members, 50\u002B identical tokens): src/applications/differential/constants/DifferentialConstantsModule.php:25-108 | src/applications/differential/constants/DifferentialConstantsModule.php:112-142 | src/applications/differential/constants/DifferentialConstantsModule.php:146-176 | src/applications/herald/controller/HeraldTranscriptController.php:517-582 | src/applications/herald/controller/HeraldTranscriptController.php:587-677 \u2014 These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/constants/DifferentialConstantsModule.php"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"48c6abcfa6f85ab0946bea86b12e4ec9685e871429eee1f3fb3511ae6c5ba651"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (5 members, 50\u002B identical tokens): src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php:47-84 | src/applications/diffusion/management/DiffusionRepositoryLimitsManagementPanel.php:46-66 | src/applications/diffusion/management/DiffusionRepositoryStagingManagementPanel.php:44-64 | src/applications/diffusion/management/DiffusionRepositorySubversionManagementPanel.php:40-60 | src/applications/diffusion/management/DiffusionRepositorySymbolsManagementPanel.php:42-62 \u2014 These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"d407c7df277539fbf9e9c04310dc021e42bae78f3032dd0dc5665e672f14647f"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (5 members, 50\u002B identical tokens): src/applications/files/controller/PhabricatorFileDetachController.php:7-117 | src/applications/files/controller/PhabricatorFileUICurtainAttachController.php:7-130 | src/applications/files/controller/PhabricatorFileUICurtainListController.php:11-58 | src/applications/policy/controller/PhabricatorPolicyExplainController.php:11-75 | src/applications/transactions/controller/PhabricatorApplicationTransactionValueController.php:11-71 \u2014 These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/controller/PhabricatorFileDetachController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"16c143374ef8ade779b34e94f98c96640902013a276c4c5d670dd0deee50913e"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (5 members, 50\u002B identical tokens): src/applications/paste/xaction/PhabricatorPasteTitleTransaction.php:17-36 | src/applications/phortune/xaction/PhortuneAccountBillingNameTransaction.php:17-36 | src/applications/phortune/xaction/PhortuneMerchantInvoiceEmailTransaction.php:17-35 | src/applications/phortune/xaction/paymentmethod/PhortunePaymentMethodNameTransaction.php:17-36 | src/applications/project/xaction/trigger/PhabricatorProjectTriggerNameTransaction.php:17-36 \u2014 These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/paste/xaction/PhabricatorPasteTitleTransaction.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"8c636c7bc37e4623a0b735711b8eab5716372f1c074fe366fe92f6dcd1eeb244"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (5 members, 50\u002B identical tokens): src/applications/phortune/controller/account/PhortuneAccountChargesController.php:40-67 | src/applications/phortune/controller/account/PhortuneAccountProfileController.php:103-138 | src/applications/phortune/controller/account/PhortuneAccountSubscriptionViewController.php:110-153 | src/applications/phortune/controller/merchant/PhortuneMerchantOrdersController.php:41-76 | src/applications/phortune/controller/merchant/PhortuneMerchantSubscriptionsController.php:39-65 \u2014 These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountChargesController.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"03db98cf6e613c534f990f55321c615de2c2d1fe736ce3f4275053fdac9055b1"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (5 members, 50\u002B identical tokens): src/applications/transactions/controller/PhabricatorApplicationTransactionCommentEditController.php:7-99 | src/applications/transactions/controller/PhabricatorApplicationTransactionCommentHistoryController.php:11-79 | src/applications/transactions/controller/PhabricatorApplicationTransactionCommentQuoteController.php:7-59 | src/applications/transactions/controller/PhabricatorApplicationTransactionCommentRawController.php:7-76 | src/applications/transactions/controller/PhabricatorApplicationTransactionCommentRemoveController.php:7-92 \u2014 These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/controller/PhabricatorApplicationTransactionCommentEditController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"0ed8207f42e87052f546f1cbaaa55854b6ec3b6e04ebc96c7089b2d01f8c73ed"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (5 members, 50\u002B identical tokens): src/applications/transactions/controller/PhabricatorEditEngineConfigurationDefaultsController.php:7-125 | src/applications/transactions/controller/PhabricatorEditEngineConfigurationLockController.php:7-54 | src/applications/transactions/controller/PhabricatorEditEngineConfigurationReorderController.php:7-123 | src/applications/transactions/controller/PhabricatorEditEngineConfigurationSaveController.php:7-52 | src/applications/transactions/controller/PhabricatorEditEngineConfigurationSubtypeController.php:7-58 \u2014 These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/controller/PhabricatorEditEngineConfigurationDefaultsController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"541d2c0906b0663ea78f30ca128545236d851f018871e9a1060086d072d3ecec"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (4 members, 50\u002B identical tokens): src/applications/almanac/controller/AlmanacDeviceViewController.php:11-81 | src/applications/almanac/controller/AlmanacNamespaceViewController.php:11-54 | src/applications/almanac/controller/AlmanacNetworkViewController.php:11-54 | src/applications/almanac/controller/AlmanacServiceViewController.php:11-69 \u2014 These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/controller/AlmanacDeviceViewController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"5c1a98eea41d97f816fadc6692a3eb17b294a2c0b8bf52010a5df24c1d677fa0"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (4 members, 50\u002B identical tokens): src/applications/almanac/phid/AlmanacDevicePHIDType.php:32-41 | src/applications/almanac/phid/AlmanacNamespacePHIDType.php:32-41 | src/applications/almanac/phid/AlmanacNetworkPHIDType.php:32-41 | src/applications/almanac/phid/AlmanacServicePHIDType.php:32-41 \u2014 These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/phid/AlmanacDevicePHIDType.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"f0a63e82a29d34537e0823e09580dafcf2111464ae600ad9bb854e58f7b19c6b"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (4 members, 50\u002B identical tokens): src/applications/almanac/xaction/AlmanacDeviceNameTransaction.php:25-76 | src/applications/almanac/xaction/AlmanacNamespaceNameTransaction.php:34-88 | src/applications/almanac/xaction/AlmanacNetworkNameTransaction.php:34-72 | src/applications/almanac/xaction/AlmanacServiceNameTransaction.php:34-85 \u2014 These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/xaction/AlmanacDeviceNameTransaction.php"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"f6fea82c157adc904e654bfb3a3947d5a3e91e1cf02196318748323790501479"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (4 members, 50\u002B identical tokens): src/applications/auth/query/PhabricatorAuthInviteQuery.php:63-107 | src/applications/phortune/query/PhortunePaymentProviderConfigQuery.php:63-88 | src/applications/phortune/query/PhortuneProductQuery.php:81-113 | src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php:172-216 \u2014 These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/query/PhabricatorAuthInviteQuery.php"},"region":{"startLine":63}}}],"partialFingerprints":{"codehealthFindingId/v1":"bf32137412adb810d6a717daf28da49f6c3300776ef4f485b6af7c8e34f1b9a8"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (4 members, 50\u002B identical tokens): src/applications/auth/xaction/PhabricatorAuthFactorProviderNameTransaction.php:17-36 | src/applications/calendar/xaction/PhabricatorCalendarImportNameTransaction.php:17-36 | src/applications/repository/xaction/PhabricatorRepositoryCallsignTransaction.php:25-44 | src/applications/repository/xaction/PhabricatorRepositoryStagingURITransaction.php:17-37 \u2014 These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/xaction/PhabricatorAuthFactorProviderNameTransaction.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"01f0a4dc24ac53413c058df517e9025336da5c2fdce8022fd1b1668dbcb83f9f"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (4 members, 50\u002B identical tokens): src/applications/config/controller/services/PhabricatorConfigClusterDatabasesController.php:7-33 | src/applications/config/controller/services/PhabricatorConfigClusterNotificationsController.php:7-35 | src/applications/config/controller/services/PhabricatorConfigClusterRepositoriesController.php:7-43 | src/applications/config/controller/services/PhabricatorConfigClusterSearchController.php:7-33 \u2014 These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/services/PhabricatorConfigClusterDatabasesController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"c164f38efcd84855be3d24914d6e491f6340074fef3492fa00e00377ab85a367"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (4 members, 50\u002B identical tokens): src/applications/console/controller/DarkConsoleController.php:48-72 | src/applications/policy/controller/PhabricatorPolicyEditController.php:266-344 | src/applications/search/controller/PhabricatorApplicationSearchController.php:978-996 | src/applications/settings/panel/PhabricatorSettingsPanel.php:291-302 \u2014 These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/console/controller/DarkConsoleController.php"},"region":{"startLine":48}}}],"partialFingerprints":{"codehealthFindingId/v1":"26e73277e1182fedbdf9a5d12586d8c075507f36efd4c9d808f5792f18378abf"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (4 members, 50\u002B identical tokens): src/applications/differential/typeahead/DifferentialBlockingReviewerDatasource.php:104-125 | src/applications/differential/typeahead/DifferentialExactUserFunctionDatasource.php:91-112 | src/applications/owners/typeahead/PhabricatorOwnersPackageOwnerDatasource.php:120-146 | src/applications/project/typeahead/PhabricatorProjectLogicalUserDatasource.php:114-135 \u2014 These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/typeahead/DifferentialBlockingReviewerDatasource.php"},"region":{"startLine":104}}}],"partialFingerprints":{"codehealthFindingId/v1":"c0b29bbf7e305cd0e92ca943f9c160362f0eec50c766dc49214971aeaca0012f"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (4 members, 50\u002B identical tokens): src/applications/diffusion/engineextension/DiffusionDatasourceEngineExtension.php:14-79 | src/applications/phriction/engineextension/PhrictionDatasourceEngineExtension.php:13-54 | src/applications/project/engineextension/ProjectDatasourceEngineExtension.php:13-55 | src/applications/search/engineextension/PhabricatorFerretSearchEngineExtension.php:30-51 \u2014 These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/engineextension/DiffusionDatasourceEngineExtension.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"2944c23f427e5de1dd870526d2f09af67741a71a94cd71572e03314ee8a0fa1e"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (4 members, 50\u002B identical tokens): src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php:27-124 | src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubIssue.php:21-82 | src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubUser.php:21-105 | src/applications/doorkeeper/bridge/DoorkeeperBridgeJIRA.php:22-120 \u2014 These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"08c81d0be02bc57c649030ee283341a5d0f9468f8e8974fcc683b59c55c351cc"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (4 members, 50\u002B identical tokens): src/applications/drydock/controller/DrydockBlueprintViewController.php:145-180 | src/applications/drydock/controller/DrydockBlueprintViewController.php:184-246 | src/applications/drydock/controller/DrydockController.php:98-110 | src/applications/drydock/controller/DrydockResourceViewController.php:173-209 \u2014 These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/controller/DrydockBlueprintViewController.php"},"region":{"startLine":145}}}],"partialFingerprints":{"codehealthFindingId/v1":"8d66194c7bc16208897dcaec0e8be670d6ccf42b781be2a72e81377e2ef01e54"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (4 members, 50\u002B identical tokens): src/applications/files/controller/PhabricatorFileTransformListController.php:11-144 | src/applications/macro/controller/PhabricatorMacroAudioController.php:6-162 | src/applications/phortune/controller/cart/PhortuneCartCheckoutController.php:15-231 | src/applications/phortune/controller/merchant/PhortuneMerchantProviderEditController.php:211-292 \u2014 These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/controller/PhabricatorFileTransformListController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"663b77c9f2624f7437e7918aadf6892a05097911b279d9ed1d1e8b25ba2c5dab"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (4 members, 50\u002B identical tokens): src/applications/files/controller/PhabricatorFileViewController.php:10-93 | src/applications/harbormaster/controller/HarbormasterPlanViewController.php:10-89 | src/applications/legalpad/controller/LegalpadDocumentManageController.php:6-78 | src/applications/phurl/controller/PhabricatorPhurlURLViewController.php:11-62 \u2014 These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/controller/PhabricatorFileViewController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"b2bb4ee04b9474ffe46352074eade1458264c9a07ad379f15f4a07ad3f828964"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (4 members, 50\u002B identical tokens): src/applications/fund/query/FundBackerQuery.php:72-111 | src/applications/phortune/query/PhortuneCartQuery.php:156-216 | src/applications/phortune/query/PhortuneChargeQuery.php:98-137 | src/applications/phortune/query/PhortunePurchaseQuery.php:78-103 \u2014 These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fund/query/FundBackerQuery.php"},"region":{"startLine":72}}}],"partialFingerprints":{"codehealthFindingId/v1":"b66997a7d1d6e1e0a5e136aecf5ac6b0ece1d52c55bd26db80b3938b1441fcd2"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (4 members, 50\u002B identical tokens): src/applications/harbormaster/controller/HarbormasterPlanViewController.php:456-497 | src/applications/harbormaster/controller/HarbormasterPlanViewController.php:501-544 | src/applications/herald/controller/HeraldWebhookViewController.php:201-235 | src/applications/owners/controller/PhabricatorOwnersDetailController.php:364-411 \u2014 These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterPlanViewController.php"},"region":{"startLine":456}}}],"partialFingerprints":{"codehealthFindingId/v1":"38c80b0d15e67d1b7ec258c7eb5f30b1d10f164645b0ae3e1fbb33f01e061426"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (4 members, 50\u002B identical tokens): src/applications/metamta/management/PhabricatorMailManagementListInboundWorkflow.php:25-68 | src/applications/metamta/management/PhabricatorMailManagementListOutboundWorkflow.php:24-57 | src/infrastructure/storage/management/workflow/PhabricatorStorageManagementStatusWorkflow.php:18-73 | src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php:163-531 \u2014 These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/management/PhabricatorMailManagementListInboundWorkflow.php"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"fd858c8ed19191e050592ebd0200a7f44750176dffe8a082027b6c3e95227f72"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (4 members, 50\u002B identical tokens): src/applications/passphrase/controller/PassphraseCredentialConduitController.php:7-87 | src/applications/passphrase/controller/PassphraseCredentialDestroyController.php:7-57 | src/applications/passphrase/controller/PassphraseCredentialLockController.php:7-71 | src/applications/passphrase/controller/PassphraseCredentialPublicController.php:7-47 \u2014 These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/passphrase/controller/PassphraseCredentialConduitController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"1ab8ad1513ba23bc2534504443b8904c0869380a2bac5d53d782edd6ad8c39c9"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (4 members, 50\u002B identical tokens): src/applications/people/editor/PhabricatorUserEditor.php:222-261 | src/applications/people/editor/PhabricatorUserEditor.php:271-334 | src/applications/people/editor/PhabricatorUserEditor.php:350-394 | src/applications/people/editor/PhabricatorUserEditor.php:404-447 \u2014 These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/editor/PhabricatorUserEditor.php"},"region":{"startLine":222}}}],"partialFingerprints":{"codehealthFindingId/v1":"8dd389e5da155d080e37c319996838084c120bde644dea7246ebdb5cb1e3954f"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (4 members, 50\u002B identical tokens): src/applications/phortune/controller/account/PhortuneAccountDetailsController.php:60-123 | src/applications/phortune/controller/account/PhortuneAccountManagersController.php:41-85 | src/applications/phortune/controller/merchant/PhortuneMerchantDetailsController.php:99-148 | src/applications/phortune/controller/merchant/PhortuneMerchantManagersController.php:38-87 \u2014 These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountDetailsController.php"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"96011029d9dfd4491dd968a0a89fa0dae928d10b7d9d7c8002a50aa2a6ba9e91"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (4 members, 50\u002B identical tokens): src/applications/phriction/conduit/PhrictionCreateConduitAPIMethod.php:27-70 | src/applications/phriction/conduit/PhrictionEditConduitAPIMethod.php:27-74 | src/applications/phriction/conduit/PhrictionHistoryConduitAPIMethod.php:40-64 | src/applications/phriction/conduit/PhrictionInfoConduitAPIMethod.php:40-54 \u2014 These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/conduit/PhrictionCreateConduitAPIMethod.php"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"d7fc7cf4fa958bb7d2c35c713d030df5334edb2b00d1761dfa1c2fea4ad902db"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (91 corresponding lines): src/applications/drydock/controller/DrydockLeaseViewController.php:6-96 | src/applications/drydock/controller/DrydockResourceViewController.php:6-105 \u2014 These two members are one piece of code written twice and then edited apart: 91 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/controller/DrydockLeaseViewController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"6537aa0fb429ae20b1c8dff73c843064663aad7b4f868e8d8f134cbc98acb795"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (117 corresponding lines): src/applications/audit/storage/PhabricatorAuditTransaction.php:163-294 | src/applications/audit/storage/PhabricatorAuditTransaction.php:298-414 \u2014 These two members are one piece of code written twice and then edited apart: 117 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/storage/PhabricatorAuditTransaction.php"},"region":{"startLine":163}}}],"partialFingerprints":{"codehealthFindingId/v1":"fd955c4618dc898d4967c812a76c277bbbae229b665248840b81abae136c445a"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (66 corresponding lines): src/applications/maniphest/xaction/ManiphestTaskStatusTransaction.php:50-115 | src/applications/maniphest/xaction/ManiphestTaskStatusTransaction.php:120-193 \u2014 These two members are one piece of code written twice and then edited apart: 66 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/xaction/ManiphestTaskStatusTransaction.php"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"2fb8b893c981f0c366c937be38cb5c7db6d7aeafee00204b588ce9b1bdf29db1"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (74 corresponding lines): src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php:78-151 | src/applications/dashboard/controller/panel/PhabricatorDashboardPanelTabsController.php:153-233 \u2014 These two members are one piece of code written twice and then edited apart: 74 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php"},"region":{"startLine":78}}}],"partialFingerprints":{"codehealthFindingId/v1":"f73dfcef86ea1d0d667541b881e048446e95f56a300fe06cd22dfde97ed38003"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (74 corresponding lines): src/applications/drydock/management/DrydockManagementReleaseLeaseWorkflow.php:26-99 | src/applications/drydock/management/DrydockManagementReleaseResourceWorkflow.php:26-100 \u2014 These two members are one piece of code written twice and then edited apart: 74 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/management/DrydockManagementReleaseLeaseWorkflow.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"d47ed758e6f68d296d1f3da15286762878416f905cb9e1506cd221307315c9dd"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (59 corresponding lines): src/applications/almanac/controller/AlmanacServiceEditController.php:32-108 | src/applications/calendar/controller/PhabricatorCalendarImportEditController.php:31-89 \u2014 These two members are one piece of code written twice and then edited apart: 59 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/controller/AlmanacServiceEditController.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"2951ac695fbbb625b11aad97cb3829462e084e357896df087a2d8e6c59a8e302"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (73 corresponding lines): src/applications/project/controller/PhabricatorProjectLockController.php:11-83 | src/applications/project/controller/PhabricatorProjectSilenceController.php:7-84 \u2014 These two members are one piece of code written twice and then edited apart: 73 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectLockController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"fc9d5581bed2ea676da7df0e31d8f34bb24eda28c16511d81681977c98da887b"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (66 corresponding lines): src/applications/drydock/controller/DrydockBlueprintViewController.php:6-85 | src/applications/drydock/controller/DrydockRepositoryOperationViewController.php:11-76 \u2014 These two members are one piece of code written twice and then edited apart: 66 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/controller/DrydockBlueprintViewController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"93700cd400943692263d9a526ed1afc2c1cabdefc8fc9e421e7585aff4f2bda4"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (85 corresponding lines): src/applications/config/controller/services/PhabricatorConfigDatabaseStatusController.php:556-683 | src/applications/config/controller/services/PhabricatorConfigDatabaseStatusController.php:694-778 \u2014 These two members are one piece of code written twice and then edited apart: 85 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/services/PhabricatorConfigDatabaseStatusController.php"},"region":{"startLine":556}}}],"partialFingerprints":{"codehealthFindingId/v1":"e159845eb6831bc01ae3847ad4aa09f3fed8bda1ccfe3a2c01ee2dafa72eebf1"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (72 corresponding lines): src/applications/project/engineextension/PhabricatorProjectsCurtainExtension.php:17-88 | src/applications/project/events/PhabricatorProjectUIEventListener.php:27-112 \u2014 These two members are one piece of code written twice and then edited apart: 72 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/engineextension/PhabricatorProjectsCurtainExtension.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"7a0817ee98650780ab1f8281fcb71c43383d0429c95e96e490a981d29de24f10"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (59 corresponding lines): src/applications/harbormaster/controller/HarbormasterLintMessagesController.php:11-71 | src/applications/harbormaster/controller/HarbormasterUnitMessageListController.php:11-69 \u2014 These two members are one piece of code written twice and then edited apart: 59 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterLintMessagesController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"aff76640b872c4869f423b137afe4e2311db843da09467d8c5db051478d6b305"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (57 corresponding lines): src/applications/phortune/query/PhortuneCartQuery.php:79-135 | src/applications/phortune/query/PhortunePaymentMethodQuery.php:42-98 \u2014 These two members are one piece of code written twice and then edited apart: 57 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/query/PhortuneCartQuery.php"},"region":{"startLine":79}}}],"partialFingerprints":{"codehealthFindingId/v1":"2eef7a73c11281b2f6fa0f3014672ff2ee47df5ad0f4e77f2e3f3433b557fc01"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (61 corresponding lines): src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php:317-385 | src/applications/diffusion/xaction/DiffusionCommitAuditorsTransaction.php:178-238 \u2014 These two members are one piece of code written twice and then edited apart: 61 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php"},"region":{"startLine":317}}}],"partialFingerprints":{"codehealthFindingId/v1":"32b86f9488e092492004aefb00d8ab20a7418956d9fc5856ddc262d3d8bc1227"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (53 corresponding lines): src/applications/paste/query/PhabricatorPasteQuery.php:222-274 | src/applications/paste/query/PhabricatorPasteQuery.php:278-341 \u2014 These two members are one piece of code written twice and then edited apart: 53 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/paste/query/PhabricatorPasteQuery.php"},"region":{"startLine":222}}}],"partialFingerprints":{"codehealthFindingId/v1":"e28874d25fefa29f1365e08696b96ed01aac4f7f967005619a0d50eeeda1c244"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (6 members, 56\u002B corresponding lines): src/applications/badges/controller/PhabricatorBadgesArchiveController.php:7-66 | src/applications/dashboard/controller/dashboard/PhabricatorDashboardArchiveController.php:7-63 | src/applications/owners/controller/PhabricatorOwnersArchiveController.php:7-63 | src/applications/paste/controller/PhabricatorPasteArchiveController.php:7-62 | src/applications/phame/controller/blog/PhameBlogArchiveController.php:7-65 | src/applications/project/controller/PhabricatorProjectArchiveController.php:7-66 \u2014 These 6 members are one piece of code written 6 times and then edited apart: every two of them correspond over at least 56 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 6 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/controller/PhabricatorBadgesArchiveController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"f5fa3102c7f1b43e6c75162be46e014eb64c08a48d6019e7561b02311439a8ff"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (56 corresponding lines): src/applications/pholio/controller/PholioMockArchiveController.php:7-62 | src/applications/slowvote/controller/PhabricatorSlowvoteCloseController.php:7-63 \u2014 These two members are one piece of code written twice and then edited apart: 56 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/pholio/controller/PholioMockArchiveController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"3b5e235952a1bca75c71363e5e6462ba4d4a1729f0d2dfbc3a61cef6e47e0939"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (53 corresponding lines): src/applications/phortune/controller/account/PhortuneAccountAddManagerController.php:11-77 | src/applications/phortune/controller/merchant/PhortuneMerchantAddManagerController.php:11-63 \u2014 These two members are one piece of code written twice and then edited apart: 53 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountAddManagerController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"8e4208217a20740fd5b1d0a3f42473c78afa29ec4d7ac292a2ed0da2ec20432d"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (68 corresponding lines): src/applications/auth/controller/mfa/PhabricatorAuthFactorProviderMessageController.php:7-81 | src/applications/phame/controller/post/PhamePostMoveController.php:6-73 \u2014 These two members are one piece of code written twice and then edited apart: 68 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/mfa/PhabricatorAuthFactorProviderMessageController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"0a28a89d7bc517d33e9e45825c721d13d372d5c6897a97527b7f577b2eef890f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (59 corresponding lines): src/applications/almanac/controller/AlmanacBindingViewController.php:11-79 | src/applications/auth/controller/PhabricatorAuthSSHKeyViewController.php:11-69 \u2014 These two members are one piece of code written twice and then edited apart: 59 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/controller/AlmanacBindingViewController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"bd982f501ea7a2f1e801b097f6fa6dbf82923e120255f76fe1b72d17a9faa4bd"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (62 corresponding lines): src/applications/countdown/controller/PhabricatorCountdownViewController.php:11-82 | src/applications/fund/controller/FundInitiativeViewController.php:11-72 \u2014 These two members are one piece of code written twice and then edited apart: 62 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/countdown/controller/PhabricatorCountdownViewController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"543debd7c7f8bab8f9b9a5e8eb6312b22fc6431cfbfea06ef388e53dc2e1bd8e"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (68 corresponding lines): src/applications/badges/controller/PhabricatorBadgesAwardController.php:7-74 | src/applications/project/controller/PhabricatorProjectMembersAddController.php:7-74 \u2014 These two members are one piece of code written twice and then edited apart: 68 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/controller/PhabricatorBadgesAwardController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"d7b6b7a494bbc9f1ee3fb6143c85ef5816fb0b1ff0ccf54ce4e6b654d9fd18eb"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (58 corresponding lines): src/applications/project/controller/PhabricatorProjectBoardManageController.php:7-64 | src/applications/project/controller/PhabricatorProjectColumnDetailController.php:7-72 \u2014 These two members are one piece of code written twice and then edited apart: 58 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectBoardManageController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"407a808bf7cc2d5b7b9c82f4700f8c89233d869d2836d29c2fa3fb65b0f0e321"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (52 corresponding lines): src/applications/drydock/query/DrydockBlueprintSearchEngine.php:77-138 | src/applications/harbormaster/query/HarbormasterBuildPlanSearchEngine.php:83-134 \u2014 These two members are one piece of code written twice and then edited apart: 52 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/query/DrydockBlueprintSearchEngine.php"},"region":{"startLine":77}}}],"partialFingerprints":{"codehealthFindingId/v1":"d5742496462e40d920858f2fec10d49e7758fb7495b14b3509f5b193d955e593"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 57\u002B corresponding lines): src/applications/diffusion/controller/DiffusionRepositoryURIDisableController.php:7-79 | src/applications/drydock/controller/DrydockBlueprintDisableController.php:7-63 | src/applications/fund/controller/FundInitiativeCloseController.php:7-66 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 57 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRepositoryURIDisableController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"f7d16c299f294c345148e7535cc70f8933be3c1def91e8c7661b561f891e8067"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 50\u002B corresponding lines): src/applications/transactions/controller/PhabricatorEditEngineConfigurationDefaultCreateController.php:7-58 | src/applications/transactions/controller/PhabricatorEditEngineConfigurationDisableController.php:7-56 | src/applications/transactions/controller/PhabricatorEditEngineConfigurationIsEditController.php:7-56 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 50 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/controller/PhabricatorEditEngineConfigurationDefaultCreateController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"a5a1c81d67ee59910c9f3a48802337017b28d91abda96e62a17bda9ad0c5cff5"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (42 corresponding lines): src/applications/calendar/controller/PhabricatorCalendarExportViewController.php:7-48 | src/applications/calendar/controller/PhabricatorCalendarImportViewController.php:7-56 \u2014 These two members are one piece of code written twice and then edited apart: 42 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/controller/PhabricatorCalendarExportViewController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"3e72254da3fdad2cf620d50e84a4d3e9fdf377c6c89987ab15b74a038163ed21"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (67 corresponding lines): src/applications/drydock/worker/DrydockRepositoryOperationUpdateWorker.php:87-153 | src/applications/harbormaster/step/HarbormasterLeaseWorkingCopyBuildStepImplementation.php:21-95 \u2014 These two members are one piece of code written twice and then edited apart: 67 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/worker/DrydockRepositoryOperationUpdateWorker.php"},"region":{"startLine":87}}}],"partialFingerprints":{"codehealthFindingId/v1":"929f665600c15b60843d8e0981b6a5ba1140b7302759262c155126b9393d1df4"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (54 corresponding lines): src/applications/almanac/controller/AlmanacInterfaceDeleteController.php:7-64 | src/applications/badges/controller/PhabricatorBadgesRemoveRecipientsController.php:7-60 \u2014 These two members are one piece of code written twice and then edited apart: 54 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/controller/AlmanacInterfaceDeleteController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"d47534148790549b725dd279f57c8cd719e1be56b398ddadfaafad5883fe7f93"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (54 corresponding lines): src/applications/dashboard/controller/dashboard/PhabricatorDashboardViewController.php:11-64 | src/applications/dashboard/controller/panel/PhabricatorDashboardPanelViewController.php:11-70 \u2014 These two members are one piece of code written twice and then edited apart: 54 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/dashboard/PhabricatorDashboardViewController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"aca17a15b28e95924ab4564ca676dc4be4318eed78f654111e696a58aed7fdc8"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (50 corresponding lines): src/applications/phortune/controller/account/PhortuneAccountEmailAddressesController.php:40-89 | src/applications/phortune/controller/account/PhortuneAccountPaymentMethodController.php:40-93 \u2014 These two members are one piece of code written twice and then edited apart: 50 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountEmailAddressesController.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"4e991b4c5da143f296c0ece4ee8ef938a977f6a7703d5f769962a97591ff3fca"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (45 corresponding lines): src/view/phui/calendar/PHUICalendarDayView.php:252-296 | src/view/phui/calendar/PHUICalendarMonthView.php:413-459 \u2014 These two members are one piece of code written twice and then edited apart: 45 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/calendar/PHUICalendarDayView.php"},"region":{"startLine":252}}}],"partialFingerprints":{"codehealthFindingId/v1":"45326363574a75b7eb75ba80adf8c42cc851c86239b06913283afd1d61c9fb03"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (45 corresponding lines): src/applications/drydock/query/DrydockAuthorizationQuery.php:76-120 | src/applications/files/query/PhabricatorFileAttachmentQuery.php:56-120 \u2014 These two members are one piece of code written twice and then edited apart: 45 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/query/DrydockAuthorizationQuery.php"},"region":{"startLine":76}}}],"partialFingerprints":{"codehealthFindingId/v1":"84eaac78f215e402553feb37aac80b99683f87e7b71fce909a9f728016f49c21"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (50 corresponding lines): src/applications/calendar/policyrule/PhabricatorCalendarEventInviteesPolicyRule.php:34-83 | src/applications/subscriptions/policyrule/PhabricatorSubscriptionsSubscribersPolicyRule.php:39-103 \u2014 These two members are one piece of code written twice and then edited apart: 50 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/policyrule/PhabricatorCalendarEventInviteesPolicyRule.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"2cc04108f708dae0aaf2192134b48a1a7284c3bf9ded70e13850335337b3791f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (45 corresponding lines): src/applications/packages/controller/PhabricatorPackagesPackageViewController.php:11-57 | src/applications/packages/controller/PhabricatorPackagesVersionViewController.php:11-55 \u2014 These two members are one piece of code written twice and then edited apart: 45 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/packages/controller/PhabricatorPackagesPackageViewController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"f8cf0027b9d02953c2151b984f536b973b5d81cfb0369d05f186516e7679c844"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (43 corresponding lines): src/applications/project/controller/PhabricatorProjectProfileController.php:241-283 | src/applications/project/controller/PhabricatorProjectProfileController.php:287-331 \u2014 These two members are one piece of code written twice and then edited apart: 43 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectProfileController.php"},"region":{"startLine":241}}}],"partialFingerprints":{"codehealthFindingId/v1":"56cb1ac6bf006a011d118bd1e1ffd6484f61baf3417b8458095eb539c0e635ac"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (4 members, 49\u002B corresponding lines): src/applications/dashboard/controller/panel/PhabricatorDashboardPanelArchiveController.php:7-58 | src/applications/phame/controller/post/PhamePostArchiveController.php:6-54 | src/applications/phame/controller/post/PhamePostPublishController.php:6-67 | src/applications/phortune/controller/merchant/PhortuneMerchantProviderDisableController.php:11-72 \u2014 These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 49 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/panel/PhabricatorDashboardPanelArchiveController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"708a5a35384b8a3df6accd5e21658f20344f07c5294928542e4e431b0185f18a"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (46 corresponding lines): src/applications/harbormaster/controller/HarbormasterStepViewController.php:11-61 | src/applications/phortune/controller/merchant/PhortuneMerchantProviderViewController.php:11-56 \u2014 These two members are one piece of code written twice and then edited apart: 46 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterStepViewController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"a1f6a43f74e05b8dbf44cd3f1752727a78b153be2f754f1d40de649439c28f27"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (44 corresponding lines): src/applications/nuance/controller/NuanceSourceViewController.php:7-50 | src/applications/people/controller/PhabricatorPeopleProfileManageController.php:11-61 \u2014 These two members are one piece of code written twice and then edited apart: 44 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/controller/NuanceSourceViewController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"516085becadb018eabbff3a2893c243a7efed12a46858011f5ffc4b51e1120a1"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (45 corresponding lines): src/applications/almanac/xaction/AlmanacBindingServiceTransaction.php:17-61 | src/applications/almanac/xaction/AlmanacInterfaceDeviceTransaction.php:25-71 \u2014 These two members are one piece of code written twice and then edited apart: 45 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/xaction/AlmanacBindingServiceTransaction.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"f7d30dd8e6a5c17cad63ab3ffcb2e7c369191f712df1c3a34bf8363f3c7d3186"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (47 corresponding lines): src/applications/harbormaster/conduit/HarbormasterSendMessageConduitAPIMethod.php:311-358 | src/applications/harbormaster/conduit/HarbormasterSendMessageConduitAPIMethod.php:393-445 \u2014 These two members are one piece of code written twice and then edited apart: 47 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/conduit/HarbormasterSendMessageConduitAPIMethod.php"},"region":{"startLine":311}}}],"partialFingerprints":{"codehealthFindingId/v1":"b6196806a1533d7de4312342f8c8a411e02875cc0f48e557a420c55dc37d5feb"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (49 corresponding lines): src/applications/diffusion/controller/DiffusionIdentityViewController.php:7-55 | src/applications/phortune/controller/product/PhortuneProductViewController.php:6-54 \u2014 These two members are one piece of code written twice and then edited apart: 49 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionIdentityViewController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"8ec7fa8c19f05c941f53cbe9aa082d78a69182ca41f8854e655def0aa6417302"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (45 corresponding lines): src/applications/daemon/controller/PhabricatorDaemonBulkJobViewController.php:7-51 | src/applications/phlux/controller/PhluxViewController.php:6-59 \u2014 These two members are one piece of code written twice and then edited apart: 45 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/daemon/controller/PhabricatorDaemonBulkJobViewController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"463ae80d890b7481faad8c3504311739b34dfc6460d9bb80df04dd63ad461d70"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (45 corresponding lines): src/applications/badges/controller/PhabricatorBadgesRecipientsController.php:11-58 | src/applications/badges/controller/PhabricatorBadgesViewController.php:11-55 \u2014 These two members are one piece of code written twice and then edited apart: 45 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/controller/PhabricatorBadgesRecipientsController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"faba6094f0c254a97192c8e15e5756d451b4bf2063b058b9abee02918000ffbb"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (36 corresponding lines): src/applications/ponder/controller/PonderAnswerHistoryController.php:10-47 | src/applications/ponder/controller/PonderQuestionHistoryController.php:10-45 \u2014 These two members are one piece of code written twice and then edited apart: 36 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/ponder/controller/PonderAnswerHistoryController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"148c61d89a7d9099af3d0429d55377fd70f7235cae2c30879da38b2729c5fe24"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (51 corresponding lines): src/applications/auth/controller/PhabricatorAuthSSHKeyRevokeController.php:7-57 | src/applications/auth/controller/contact/PhabricatorAuthContactNumberTestController.php:7-61 \u2014 These two members are one piece of code written twice and then edited apart: 51 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthSSHKeyRevokeController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"650ba2761477c320a93859994bb4d252644f3333d9704e8d3248bf29196ba296"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 48\u002B corresponding lines): src/applications/drydock/controller/DrydockLeaseReleaseController.php:6-53 | src/applications/drydock/controller/DrydockResourceReleaseController.php:6-53 | src/applications/project/controller/PhabricatorProjectColumnRemoveTriggerController.php:7-58 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 48 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/controller/DrydockLeaseReleaseController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"a34b5337965edc3a2ec71b7aaf6dbfc00dc856317ccd42bcd8fc609f29c3b9a9"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (57 corresponding lines): src/applications/metamta/controller/PhabricatorMetaMTAMailgunReceiveController.php:41-107 | src/applications/metamta/controller/PhabricatorMetaMTASendGridReceiveController.php:14-70 \u2014 These two members are one piece of code written twice and then edited apart: 57 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/controller/PhabricatorMetaMTAMailgunReceiveController.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"c0ef3b4a118b01cd1f9fb48f5dbe3c8c414ff0e5c384a250df8c1696fc672e49"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (36 corresponding lines): src/applications/maniphest/xaction/ManiphestTaskUnblockTransaction.php:32-69 | src/applications/maniphest/xaction/ManiphestTaskUnblockTransaction.php:73-108 \u2014 These two members are one piece of code written twice and then edited apart: 36 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/xaction/ManiphestTaskUnblockTransaction.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"7dfc2e5f274523985007f056139510a8750b74bf4e811aca4c4603f974d906da"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 44\u002B corresponding lines): src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php:282-326 | src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php:370-415 | src/applications/settings/panel/PhabricatorMultiFactorSettingsPanel.php:404-447 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 44 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php"},"region":{"startLine":282}}}],"partialFingerprints":{"codehealthFindingId/v1":"fbc4d258ec8d5e96c06a8b90ad7617b897a41c3221a5ec7276262b0b6bce5914"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (67 corresponding lines): src/applications/phame/view/PhameBlogListView.php:20-90 | src/applications/phame/view/PhameDraftListView.php:27-93 \u2014 These two members are one piece of code written twice and then edited apart: 67 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/view/PhameBlogListView.php"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"fabc25fb6043e6b616c874d5c4e3c012b09ee6df81fc77c0d9f9f2c3d158f7a8"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (33 corresponding lines): src/applications/almanac/controller/AlmanacDeviceViewController.php:109-141 | src/applications/almanac/controller/AlmanacServiceViewController.php:114-148 \u2014 These two members are one piece of code written twice and then edited apart: 33 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/controller/AlmanacDeviceViewController.php"},"region":{"startLine":109}}}],"partialFingerprints":{"codehealthFindingId/v1":"f99637d335c68994750cdb493d01ed0c069de34f846663947df241f5d8f61526"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (42 corresponding lines): src/applications/auth/controller/config/PhabricatorAuthProviderViewController.php:7-48 | src/applications/project/controller/trigger/PhabricatorProjectTriggerViewController.php:11-57 \u2014 These two members are one piece of code written twice and then edited apart: 42 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/config/PhabricatorAuthProviderViewController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"0fbd7ea07301e1aba66855ba543e10240804735397d0230202b3869e1c16c1c3"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 34\u002B corresponding lines): src/applications/nuance/controller/NuanceItemManageController.php:6-49 | src/applications/nuance/controller/NuanceItemViewController.php:6-50 | src/applications/nuance/controller/NuanceQueueViewController.php:7-40 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 34 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/controller/NuanceItemManageController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"db6a32b9be678902e5066241d106b3b201b699eff511315607cfc0a3a9b924aa"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (47 corresponding lines): src/applications/packages/xaction/package/PhabricatorPackagesPackagePublisherTransaction.php:17-64 | src/applications/packages/xaction/version/PhabricatorPackagesVersionPackageTransaction.php:17-63 \u2014 These two members are one piece of code written twice and then edited apart: 47 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/packages/xaction/package/PhabricatorPackagesPackagePublisherTransaction.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"4a15405e1a64359b94e6463f0f5a1efe4d5ddfd1cc1d6df3cf699e6c82bca040"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (4 members, 42\u002B corresponding lines): src/applications/auth/controller/mfa/PhabricatorAuthFactorProviderViewController.php:7-50 | src/applications/packages/controller/PhabricatorPackagesPublisherViewController.php:11-54 | src/applications/phortune/controller/account/PhortuneAccountEmailViewController.php:11-52 | src/applications/phortune/controller/account/PhortuneAccountPaymentMethodViewController.php:11-59 \u2014 These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 42 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/mfa/PhabricatorAuthFactorProviderViewController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"313e1ea0c75b09d819b2d25ee61a2134585a726ca2ca9d7a30f70f001e9b38f7"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (39 corresponding lines): src/applications/herald/adapter/HeraldAdapter.php:319-357 | src/applications/herald/adapter/HeraldAdapter.php:707-746 \u2014 These two members are one piece of code written twice and then edited apart: 39 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/adapter/HeraldAdapter.php"},"region":{"startLine":319}}}],"partialFingerprints":{"codehealthFindingId/v1":"ccf92b7b49528991daf6a2e91ffeee4fe9190f373b547f29872d03a66fb51f0a"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (39 corresponding lines): src/applications/repository/xaction/PhabricatorRepositoryCallsignTransaction.php:48-87 | src/applications/repository/xaction/PhabricatorRepositorySlugTransaction.php:47-85 \u2014 These two members are one piece of code written twice and then edited apart: 39 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/xaction/PhabricatorRepositoryCallsignTransaction.php"},"region":{"startLine":48}}}],"partialFingerprints":{"codehealthFindingId/v1":"f85d23f058e5689f529ca59fe8888e03130c88a45683c6098642513fe7839027"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (38 corresponding lines): src/applications/herald/typeahead/HeraldRuleDatasource.php:19-57 | src/applications/owners/typeahead/PhabricatorOwnersPackageDatasource.php:19-56 \u2014 These two members are one piece of code written twice and then edited apart: 38 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/typeahead/HeraldRuleDatasource.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"25f7418302f53503a5a694a3d60d59612c44b6c3922cc0efbc0ec3da6e3c8a8e"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (58 corresponding lines): src/applications/nuance/query/NuanceSourceQuery.php:69-130 | src/applications/transactions/query/PhabricatorApplicationTransactionCommentQuery.php:50-107 \u2014 These two members are one piece of code written twice and then edited apart: 58 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/query/NuanceSourceQuery.php"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"f2f8d2a634ea0d938041afa4f0f11c86c0d86bffa59a9c2fb135fb4167e879e8"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (35 corresponding lines): src/applications/project/controller/PhabricatorProjectBoardDisableController.php:7-59 | src/applications/project/controller/PhabricatorProjectBoardViewController.php:986-1020 \u2014 These two members are one piece of code written twice and then edited apart: 35 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectBoardDisableController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"3a0fc8ab85990b6e21f918a39a3dd5a04207bc7efe8459869f33ef9cae5bd18d"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (42 corresponding lines): src/applications/project/order/PhabricatorProjectColumnPriorityOrder.php:47-91 | src/applications/project/order/PhabricatorProjectColumnStatusOrder.php:57-98 \u2014 These two members are one piece of code written twice and then edited apart: 42 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/order/PhabricatorProjectColumnPriorityOrder.php"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"3111f342eb0e557e6704b6ab34f444bb732223e8fa7dccca743498b14bccf782"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (39 corresponding lines): src/applications/calendar/query/PhabricatorCalendarImportLogQuery.php:58-96 | src/applications/drydock/query/DrydockRepositoryOperationQuery.php:59-99 \u2014 These two members are one piece of code written twice and then edited apart: 39 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/query/PhabricatorCalendarImportLogQuery.php"},"region":{"startLine":58}}}],"partialFingerprints":{"codehealthFindingId/v1":"4a87af550ac72f1126889bc869610135a20c94aa7dd18088e7ecadaafcb52b12"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (45 corresponding lines): src/applications/calendar/xaction/PhabricatorCalendarImportICSFileTransaction.php:34-78 | src/applications/calendar/xaction/PhabricatorCalendarImportICSURITransaction.php:26-71 \u2014 These two members are one piece of code written twice and then edited apart: 45 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/xaction/PhabricatorCalendarImportICSFileTransaction.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"99cab75a9eb235b71003ee62ec9a5e97e265be2401509f6224cff446f955563b"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (48 corresponding lines): src/applications/diffusion/controller/DiffusionCommitBranchesController.php:10-58 | src/applications/diffusion/controller/DiffusionCommitTagsController.php:10-57 \u2014 These two members are one piece of code written twice and then edited apart: 48 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionCommitBranchesController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"a380002404a7dfcc0fe7cfcac941b16d4944010a019c26b880f786ba6040101f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (36 corresponding lines): src/applications/diviner/query/DivinerBookQuery.php:71-116 | src/applications/repository/query/PhabricatorRepositoryRefCursorQuery.php:54-89 \u2014 These two members are one piece of code written twice and then edited apart: 36 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/query/DivinerBookQuery.php"},"region":{"startLine":71}}}],"partialFingerprints":{"codehealthFindingId/v1":"b572a091253a514d88b999bf5c277a234040535d4fd5ff511e22cf15bdc7be53"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 30\u002B corresponding lines): src/applications/calendar/controller/PhabricatorCalendarImportViewController.php:223-252 | src/applications/packages/controller/PhabricatorPackagesPackageViewController.php:95-127 | src/applications/packages/controller/PhabricatorPackagesPublisherViewController.php:92-124 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 30 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/controller/PhabricatorCalendarImportViewController.php"},"region":{"startLine":223}}}],"partialFingerprints":{"codehealthFindingId/v1":"a62cda8e079da36ef278cbfe18c8964337bad4e2573802060c81a7213aadfdfa"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (35 corresponding lines): src/applications/config/storage/PhabricatorConfigTransaction.php:17-51 | src/applications/config/storage/PhabricatorConfigTransaction.php:55-89 \u2014 These two members are one piece of code written twice and then edited apart: 35 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/storage/PhabricatorConfigTransaction.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"cf05a530c86d849d2ace3dcde071a88621cda967a272c3f3bd8d23b340bee9ea"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (45 corresponding lines): src/applications/audit/management/PhabricatorAuditManagementWorkflow.php:22-72 | src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementWorkflow.php:263-307 \u2014 These two members are one piece of code written twice and then edited apart: 45 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/management/PhabricatorAuditManagementWorkflow.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"94cba72918597080e72f99cea86400d9070b74e0a5c1b28acb20c73c393648d7"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (31 corresponding lines): src/applications/flag/conduit/FlagQueryConduitAPIMethod.php:29-59 | src/applications/repository/conduit/RepositoryQueryConduitAPIMethod.php:44-84 \u2014 These two members are one piece of code written twice and then edited apart: 31 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/flag/conduit/FlagQueryConduitAPIMethod.php"},"region":{"startLine":29}}}],"partialFingerprints":{"codehealthFindingId/v1":"13300156152d6253e9d4ee0849c0170f00641c4525b9d0411ba2942a91ca0a2e"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (28 corresponding lines): src/applications/project/order/PhabricatorProjectColumnAuthorOrder.php:37-64 | src/applications/project/order/PhabricatorProjectColumnOwnerOrder.php:41-72 \u2014 These two members are one piece of code written twice and then edited apart: 28 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/order/PhabricatorProjectColumnAuthorOrder.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"f1eb3e9e7c760a53360ff571f2083324cb062e92e30856fbba9aa3eebde72541"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (38 corresponding lines): src/applications/phortune/controller/account/PhortuneAccountDetailsController.php:11-55 | src/applications/phortune/controller/merchant/PhortuneMerchantDetailsController.php:11-48 \u2014 These two members are one piece of code written twice and then edited apart: 38 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountDetailsController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"e81b52799b642c8001661a570d3f1d9bb3346ed557c6dd2ba38c19794fc0631a"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 47\u002B corresponding lines): src/applications/diffusion/query/DiffusionPullLogSearchEngine.php:102-148 | src/applications/feed/query/PhabricatorFeedTransactionSearchEngine.php:180-227 | src/applications/people/query/PhabricatorPeopleLogSearchEngine.php:190-242 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 47 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/DiffusionPullLogSearchEngine.php"},"region":{"startLine":102}}}],"partialFingerprints":{"codehealthFindingId/v1":"001b106893ede4a4dbaa3495d4eea1bfda9066ef17d0afedc0b000f92bee4996"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (28 corresponding lines): src/applications/drydock/typeahead/DrydockBlueprintDatasource.php:19-50 | src/applications/herald/typeahead/HeraldWebhookDatasource.php:19-46 \u2014 These two members are one piece of code written twice and then edited apart: 28 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/typeahead/DrydockBlueprintDatasource.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"179a7f14b1301ea5bc64ba5c04fc9f98aaf66994b2e750e5c78ce380d01a3aeb"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (26 corresponding lines): src/applications/fund/phortune/FundBackerProduct.php:87-118 | src/applications/fund/phortune/FundBackerProduct.php:125-150 \u2014 These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fund/phortune/FundBackerProduct.php"},"region":{"startLine":87}}}],"partialFingerprints":{"codehealthFindingId/v1":"a554f58a81945800961ec514f12a9dcccfd993cdb2d0a4c56123f200be9a9003"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 32\u002B corresponding lines): src/applications/project/searchfield/PhabricatorProjectSearchField.php:15-46 | src/applications/search/engine/PhabricatorApplicationSearchEngine.php:745-779 | src/applications/search/field/PhabricatorSearchTokenizerField.php:33-67 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 32 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/searchfield/PhabricatorProjectSearchField.php"},"region":{"startLine":15}}}],"partialFingerprints":{"codehealthFindingId/v1":"e0cc69eaa18f25475259dde949765d6896e7d1671747450328ca28a3e107e21d"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (33 corresponding lines): src/applications/calendar/storage/PhabricatorCalendarImport.php:164-196 | src/applications/repository/storage/PhabricatorRepository.php:2706-2738 \u2014 These two members are one piece of code written twice and then edited apart: 33 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/storage/PhabricatorCalendarImport.php"},"region":{"startLine":164}}}],"partialFingerprints":{"codehealthFindingId/v1":"6ad3aa9a37df376578dfb52bfde08ee1acd19d2c2d3a6eb5a5fed8d7d6b863a2"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (45 corresponding lines): src/applications/diffusion/query/DiffusionSymbolQuery.php:196-240 | src/applications/diviner/query/DivinerBookQuery.php:120-166 \u2014 These two members are one piece of code written twice and then edited apart: 45 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/DiffusionSymbolQuery.php"},"region":{"startLine":196}}}],"partialFingerprints":{"codehealthFindingId/v1":"c82f6b2f0571af54494c76d8fc0a2a275a1a3ab625640df1643c9512fa95263f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (39 corresponding lines): src/applications/config/option/PhabricatorCoreConfigOptions.php:275-331 | src/applications/config/option/PhabricatorSecurityConfigOptions.php:295-333 \u2014 These two members are one piece of code written twice and then edited apart: 39 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/option/PhabricatorCoreConfigOptions.php"},"region":{"startLine":275}}}],"partialFingerprints":{"codehealthFindingId/v1":"ce113cffc4afb68b207194bb3d9bb9e08c3ffa8b9897232d6b08960703ac3df7"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (34 corresponding lines): src/infrastructure/export/engine/PhabricatorProjectsExportEngineExtension.php:24-57 | src/infrastructure/export/engine/PhabricatorSubscriptionsExportEngineExtension.php:24-57 \u2014 These two members are one piece of code written twice and then edited apart: 34 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/export/engine/PhabricatorProjectsExportEngineExtension.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"7ae36d21e9aae70805fb4091e575b6a25902a38aee039c0ecb2a85a138af41ef"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (25 corresponding lines): src/applications/people/markup/PhabricatorMentionRemarkupRule.php:30-54 | src/applications/phid/remarkup/PhabricatorHandleRemarkupRule.php:16-47 \u2014 These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/markup/PhabricatorMentionRemarkupRule.php"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"5da2135a6ebadf08428a4c86048132867a17380a774afad9249b2091a68598e9"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (5 members, 30\u002B corresponding lines): src/applications/diffusion/xaction/DiffusionCommitAuditorsTransaction.php:107-137 | src/applications/diffusion/xaction/DiffusionCommitAuditorsTransaction.php:141-174 | src/applications/owners/xaction/PhabricatorOwnersPackageIgnoredTransaction.php:21-54 | src/applications/project/xaction/PhabricatorProjectSlugsTransaction.php:37-66 | src/applications/project/xaction/PhabricatorProjectSlugsTransaction.php:70-102 \u2014 These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 30 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/xaction/DiffusionCommitAuditorsTransaction.php"},"region":{"startLine":107}}}],"partialFingerprints":{"codehealthFindingId/v1":"5cd69845310375b410d8ab730fd6886039e78c5d2f000db6d19298def35e9b09"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (27 corresponding lines): src/applications/pholio/xaction/PholioImageFileTransaction.php:45-71 | src/applications/repository/xaction/PhabricatorRepositoryBlueprintsTransaction.php:25-53 \u2014 These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/pholio/xaction/PholioImageFileTransaction.php"},"region":{"startLine":45}}}],"partialFingerprints":{"codehealthFindingId/v1":"e6f3edd5485ce5e8d1039df9ebe4af4c4749390e8dc64bf857ad8fcff2505b3a"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 38\u002B corresponding lines): src/applications/herald/xaction/HeraldWebhookURITransaction.php:34-71 | src/applications/macro/xaction/PhabricatorMacroNameTransaction.php:34-82 | src/applications/phortune/xaction/PhortuneAccountEmailAddressTransaction.php:17-60 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 38 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/xaction/HeraldWebhookURITransaction.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"5bfec06b6c5edd58bfb3ca4c59f028bb7564dc1234fb6bbe2c608dd326a1ca85"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (33 corresponding lines): src/applications/repository/daemon/PhabricatorGitGraphStream.php:56-98 | src/applications/repository/daemon/PhabricatorMercurialGraphStream.php:84-116 \u2014 These two members are one piece of code written twice and then edited apart: 33 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/daemon/PhabricatorGitGraphStream.php"},"region":{"startLine":56}}}],"partialFingerprints":{"codehealthFindingId/v1":"2baa185c816d9a45130d29f12fa481ea82d285bd0f77095fdf4e6481884e027d"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (22 corresponding lines): src/applications/fund/xaction/FundInitiativeBackerTransaction.php:21-42 | src/applications/fund/xaction/FundInitiativeRefundTransaction.php:21-44 \u2014 These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fund/xaction/FundInitiativeBackerTransaction.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"933714c9c8ff71d7b088988ad76a05c9e43483d0d4ba0f3d893b7f253a94cad1"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (30 corresponding lines): src/applications/feed/controller/PhabricatorFeedDetailController.php:6-35 | src/applications/help/controller/PhabricatorHelpDocumentationController.php:11-43 \u2014 These two members are one piece of code written twice and then edited apart: 30 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/feed/controller/PhabricatorFeedDetailController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"ccd4c47dfb75f67998fc3010bba24571c918a4703844626de12d7a7063726d63"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (23 corresponding lines): src/applications/phortune/controller/external/PhortuneExternalOverviewController.php:49-72 | src/applications/phortune/controller/external/PhortuneExternalOverviewController.php:76-98 \u2014 These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/external/PhortuneExternalOverviewController.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"d1f72ad2bb70f086a2eec1b224706eeba5e9890e240ee4f166c8a804cb5597ce"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (31 corresponding lines): src/applications/auth/controller/PhabricatorAuthSSHKeyViewController.php:73-103 | src/applications/drydock/controller/DrydockAuthorizationViewController.php:68-104 \u2014 These two members are one piece of code written twice and then edited apart: 31 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthSSHKeyViewController.php"},"region":{"startLine":73}}}],"partialFingerprints":{"codehealthFindingId/v1":"c8cd113ce7b26d23eb31340d1f0165b0d7f973a89399529af59b3f20d49ec5aa"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (31 corresponding lines): src/applications/metamta/applicationpanel/PhabricatorMetaMTAApplicationEmailPanel.php:297-327 | src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php:333-363 \u2014 These two members are one piece of code written twice and then edited apart: 31 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/applicationpanel/PhabricatorMetaMTAApplicationEmailPanel.php"},"region":{"startLine":297}}}],"partialFingerprints":{"codehealthFindingId/v1":"6d1943f1b0d3fff093d98b4adf52c3df946693474d3a1b1b90738139bb6d2e5b"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (45 corresponding lines): src/applications/drydock/storage/DrydockLease.php:330-375 | src/applications/drydock/storage/DrydockResource.php:189-233 \u2014 These two members are one piece of code written twice and then edited apart: 45 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/storage/DrydockLease.php"},"region":{"startLine":330}}}],"partialFingerprints":{"codehealthFindingId/v1":"77802b24811364c37ada2333450e61797a5e1f70b293e653f82bcd6a24a9d439"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (26 corresponding lines): src/applications/repository/query/PhabricatorRepositoryPullEventQuery.php:47-76 | src/applications/repository/query/PhabricatorRepositorySyncEventQuery.php:38-63 \u2014 These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/query/PhabricatorRepositoryPullEventQuery.php"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"5e8e666055fe1e583949306cfdde312a36a6fd8457b7f0202443aa5ca64a4ac0"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (47 corresponding lines): src/applications/diviner/view/DivinerParameterTableView.php:29-81 | src/applications/diviner/view/DivinerReturnTableView.php:29-75 \u2014 These two members are one piece of code written twice and then edited apart: 47 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/view/DivinerParameterTableView.php"},"region":{"startLine":29}}}],"partialFingerprints":{"codehealthFindingId/v1":"f293080acc24ef2c4c28ee43f794b1a211c5ea0638cb59f33b5f386b261c626a"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (24 corresponding lines): src/applications/maniphest/xaction/ManiphestTaskPriorityTransaction.php:47-70 | src/applications/maniphest/xaction/ManiphestTaskPriorityTransaction.php:74-100 \u2014 These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/xaction/ManiphestTaskPriorityTransaction.php"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"243479b71f06f3b02ce5df699573ebebc9ac4011c39dd65e6aa1d63ec31867be"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 31\u002B corresponding lines): src/applications/almanac/management/AlmanacManagementUntrustKeyWorkflow.php:21-51 | src/applications/auth/management/PhabricatorAuthManagementTrustOAuthClientWorkflow.php:26-60 | src/applications/auth/management/PhabricatorAuthManagementUntrustOAuthClientWorkflow.php:25-60 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 31 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/management/AlmanacManagementUntrustKeyWorkflow.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"a242240e684ef3fbccdcbdef84a327fc5557aa89cacce3fd39434b1bed9a02f2"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (30 corresponding lines): src/applications/auth/revoker/PhabricatorAuthPasswordRevoker.php:49-78 | src/applications/auth/revoker/PhabricatorAuthSSHRevoker.php:33-62 \u2014 These two members are one piece of code written twice and then edited apart: 30 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/revoker/PhabricatorAuthPasswordRevoker.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"3a98a18385bade58b24a794a83a48f062ee587b730582162bbedecca979efa62"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (29 corresponding lines): src/applications/macro/xaction/PhabricatorMacroFileTransaction.php:34-73 | src/applications/project/xaction/PhabricatorProjectImageTransaction.php:77-105 \u2014 These two members are one piece of code written twice and then edited apart: 29 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/macro/xaction/PhabricatorMacroFileTransaction.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"342879b28f36c541cba91085d9a95a1a177167ce0336fdb575b55aa08d5d351f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (26 corresponding lines): src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php:157-191 | src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php:84-109 \u2014 These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php"},"region":{"startLine":157}}}],"partialFingerprints":{"codehealthFindingId/v1":"7fe77391f67763a84d2f2d40b46ea3f2ae3da02cb96704e98e4902e4544523bf"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (32 corresponding lines): src/applications/harbormaster/controller/HarbormasterBuildViewController.php:531-562 | src/applications/harbormaster/controller/HarbormasterBuildableViewController.php:80-124 \u2014 These two members are one piece of code written twice and then edited apart: 32 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterBuildViewController.php"},"region":{"startLine":531}}}],"partialFingerprints":{"codehealthFindingId/v1":"d13121ad4543ecbf6d3152dd56a5a3a1d65d23cc0f8a4ac59340aff888e9b3e3"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (33 corresponding lines): src/applications/drydock/management/DrydockManagementUpdateLeaseWorkflow.php:22-54 | src/applications/drydock/management/DrydockManagementUpdateResourceWorkflow.php:22-54 \u2014 These two members are one piece of code written twice and then edited apart: 33 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/management/DrydockManagementUpdateLeaseWorkflow.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"1590212489cccf735e9c9df17b60c83e03837385d6e8c466d123af4f19a1282b"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (34 corresponding lines): src/applications/auth/xaction/PhabricatorAuthFactorProviderDuoCredentialTransaction.php:27-66 | src/applications/auth/xaction/PhabricatorAuthFactorProviderDuoHostnameTransaction.php:27-60 \u2014 These two members are one piece of code written twice and then edited apart: 34 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/xaction/PhabricatorAuthFactorProviderDuoCredentialTransaction.php"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"47a12700ebed9206935d81ab14964f41ad93ff8cc82bb6cabf47df06d7d7c8ce"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (27 corresponding lines): src/applications/diffusion/management/DiffusionRepositoryAutomationManagementPanel.php:54-85 | src/applications/diffusion/management/DiffusionRepositoryURIsManagementPanel.php:21-47 \u2014 These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/management/DiffusionRepositoryAutomationManagementPanel.php"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"64b61c3cb3cfee1b43b0165f678d093a6af00cc092c2a4e1c6b815d6c465359d"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (25 corresponding lines): src/applications/calendar/query/PhabricatorCalendarExportSearchEngine.php:64-95 | src/applications/herald/query/HeraldWebhookSearchEngine.php:75-99 \u2014 These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/query/PhabricatorCalendarExportSearchEngine.php"},"region":{"startLine":64}}}],"partialFingerprints":{"codehealthFindingId/v1":"4e0af2f1c51b0f67d4beb596d04abb5bc45f16b2ea9c91c8a3f640dc2e27ce6e"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (35 corresponding lines): src/applications/calendar/xaction/PhabricatorCalendarEventInviteTransaction.php:75-111 | src/applications/repository/xaction/PhabricatorRepositorySymbolSourcesTransaction.php:40-74 \u2014 These two members are one piece of code written twice and then edited apart: 35 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/xaction/PhabricatorCalendarEventInviteTransaction.php"},"region":{"startLine":75}}}],"partialFingerprints":{"codehealthFindingId/v1":"8bb1bdb133b8104c1715bbc69d41eba3afb2a20c2d00e0394e088f5c84c87164"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (45 corresponding lines): src/applications/almanac/controller/AlmanacDeviceViewController.php:183-227 | src/applications/drydock/controller/DrydockController.php:34-79 \u2014 These two members are one piece of code written twice and then edited apart: 45 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/controller/AlmanacDeviceViewController.php"},"region":{"startLine":183}}}],"partialFingerprints":{"codehealthFindingId/v1":"013a46629d6c93b5e50d2fbac6d8d069e77ed8d6d3bd59b66c18d8c343cfb105"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (24 corresponding lines): src/applications/maniphest/xaction/ManiphestTaskOwnerTransaction.php:53-76 | src/applications/maniphest/xaction/ManiphestTaskOwnerTransaction.php:80-106 \u2014 These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/xaction/ManiphestTaskOwnerTransaction.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"fad48dc4e581f75f0382c5f9262c2f40f9f43a51836002dd4df2e1319f67fec4"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (24 corresponding lines): src/applications/people/controller/PhabricatorPeopleProfileViewController.php:91-114 | src/applications/project/controller/PhabricatorProjectProfileController.php:159-184 \u2014 These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/controller/PhabricatorPeopleProfileViewController.php"},"region":{"startLine":91}}}],"partialFingerprints":{"codehealthFindingId/v1":"6918b4e0a61ce07729c1c05648b7735b033eb90fbf1f611b06ed5a5caad98132"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (4 members, 25\u002B corresponding lines): src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php:425-452 | src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldCredential.php:111-135 | src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php:197-226 | src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php:114-145 \u2014 These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 25 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php"},"region":{"startLine":425}}}],"partialFingerprints":{"codehealthFindingId/v1":"01a08b90de47651ac2343dbb7bab0d36753719a1d997fb9d04590c71150a413f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (35 corresponding lines): src/applications/differential/xaction/DifferentialRevisionAuthorTransaction.php:22-56 | src/applications/project/xaction/column/PhabricatorProjectColumnTriggerTransaction.php:59-94 \u2014 These two members are one piece of code written twice and then edited apart: 35 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/xaction/DifferentialRevisionAuthorTransaction.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"75bb2c0b405f85e9ba45ffde22e6b8531ec49e9acc17ec75d8cc593b0baea338"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (27 corresponding lines): src/applications/auth/engine/PhabricatorAuthSessionEngine.php:852-878 | src/applications/auth/engine/PhabricatorAuthSessionEngine.php:895-924 \u2014 These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/engine/PhabricatorAuthSessionEngine.php"},"region":{"startLine":852}}}],"partialFingerprints":{"codehealthFindingId/v1":"7f68fc4f5b32eec05da7fdcdd7327872071caa8b522abbaaa7f3e5cddb13d49c"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (29 corresponding lines): src/applications/differential/xaction/DifferentialRevisionAuthorTransaction.php:83-118 | src/applications/differential/xaction/DifferentialRevisionAuthorTransaction.php:122-150 \u2014 These two members are one piece of code written twice and then edited apart: 29 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/xaction/DifferentialRevisionAuthorTransaction.php"},"region":{"startLine":83}}}],"partialFingerprints":{"codehealthFindingId/v1":"0f2c9c5b6225821b729fed836f4352107842d435c4282cfabcda095d6b6bd302"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (22 corresponding lines): src/applications/phortune/query/PhortuneMerchantSearchEngine.php:66-87 | src/applications/phurl/query/PhabricatorPhurlURLSearchEngine.php:99-123 \u2014 These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/query/PhortuneMerchantSearchEngine.php"},"region":{"startLine":66}}}],"partialFingerprints":{"codehealthFindingId/v1":"dc74f161922d78f76a09920389e1eed91cbe75020a7d38058ca09efaaafa9466"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (40 corresponding lines): src/applications/cache/PhabricatorKeyValueDatabaseCache.php:10-54 | src/applications/people/storage/PhabricatorUserCache.php:57-96 \u2014 These two members are one piece of code written twice and then edited apart: 40 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/cache/PhabricatorKeyValueDatabaseCache.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"d338a83f56bc3cd50d7eb20891a4b3f1d2ce75185e41c67a881ec61d1cfda0ac"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (4 members, 23\u002B corresponding lines): src/applications/calendar/query/PhabricatorCalendarImportSearchEngine.php:61-83 | src/applications/oauthserver/query/PhabricatorOAuthServerClientSearchEngine.php:80-104 | src/applications/owners/query/PhabricatorOwnersPackageSearchEngine.php:128-154 | src/applications/spaces/query/PhabricatorSpacesNamespaceSearchEngine.php:71-98 \u2014 These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 23 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/query/PhabricatorCalendarImportSearchEngine.php"},"region":{"startLine":61}}}],"partialFingerprints":{"codehealthFindingId/v1":"ff3dbfb57a931226adf687524f49db17dc634c493276e20cf256846a7decd47c"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (26 corresponding lines): src/applications/project/query/PhabricatorProjectColumnQuery.php:60-85 | src/applications/repository/query/PhabricatorRepositoryURIQuery.php:65-90 \u2014 These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/query/PhabricatorProjectColumnQuery.php"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"bd186128ebf19f3cb45a8e6eb9491b2c06799a6ecd50539162f179b1b229d0ab"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (30 corresponding lines): src/applications/search/editor/PhabricatorProfileMenuEditEngine.php:162-192 | src/applications/settings/editor/PhabricatorSettingsEditEngine.php:230-259 \u2014 These two members are one piece of code written twice and then edited apart: 30 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/editor/PhabricatorProfileMenuEditEngine.php"},"region":{"startLine":162}}}],"partialFingerprints":{"codehealthFindingId/v1":"b28ce81bc336f96acaa0ee7cee74c47ac0d6c26863c6290cede62a4f698a89c2"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 34\u002B corresponding lines): src/applications/auth/provider/PhabricatorOAuth1AuthProvider.php:155-189 | src/applications/auth/storage/PhabricatorAuthSSHKeyTransaction.php:19-52 | src/applications/oauthserver/storage/PhabricatorOAuthServerTransaction.php:23-56 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 34 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorOAuth1AuthProvider.php"},"region":{"startLine":155}}}],"partialFingerprints":{"codehealthFindingId/v1":"fa0b4a52906c3830dfe60dfd4041df5fcb965a64aa984ac09a6795a05e49866e"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (26 corresponding lines): src/applications/diffusion/herald/DiffusionCommitWrongBuildsHeraldField.php:17-42 | src/applications/diffusion/herald/DiffusionPreCommitContentWrongBuildsHeraldField.php:17-42 \u2014 These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/herald/DiffusionCommitWrongBuildsHeraldField.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"ad0d85099b0e1ca9fc5d58763859a15b138275cf7f7d0fc2d8303b024bd2aa57"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (27 corresponding lines): src/applications/fund/phortune/FundBackerCart.php:46-72 | src/applications/phortune/cart/PhortuneSubscriptionCart.php:47-73 \u2014 These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fund/phortune/FundBackerCart.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"c7832a658e3a966b4c76069c3ac6a1da6b016129580382ab6e852b0508d08a3f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (23 corresponding lines): src/applications/maniphest/command/ManiphestPriorityEmailCommand.php:19-41 | src/applications/maniphest/command/ManiphestStatusEmailCommand.php:19-43 \u2014 These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/command/ManiphestPriorityEmailCommand.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"a30df8003696f4c7cfdaaa42b4f68f9d92e104dce3193edc59d95d208d46e448"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (32 corresponding lines): src/applications/maniphest/xaction/ManiphestTaskParentTransaction.php:27-58 | src/applications/phriction/xaction/PhrictionDocumentPublishTransaction.php:34-68 \u2014 These two members are one piece of code written twice and then edited apart: 32 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/xaction/ManiphestTaskParentTransaction.php"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"c25266f5f4f94c81e1147a4f964bfc326580dfecaebd9b0e3e93f69ca0b6b448"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (24 corresponding lines): src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php:209-232 | src/applications/dashboard/editor/PhabricatorDashboardPanelEditEngine.php:145-179 \u2014 These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php"},"region":{"startLine":209}}}],"partialFingerprints":{"codehealthFindingId/v1":"0864bb572624abaeb5df8b444470988f3d56a7477a80f437e23d457f61054d79"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (29 corresponding lines): src/applications/diffusion/view/DiffusionCommitGraphView.php:483-511 | src/applications/diffusion/view/DiffusionCommitGraphView.php:515-548 \u2014 These two members are one piece of code written twice and then edited apart: 29 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/view/DiffusionCommitGraphView.php"},"region":{"startLine":483}}}],"partialFingerprints":{"codehealthFindingId/v1":"49a143a6f835267426991be2beb688172f15d4d6081f130f8767c84d6e4371e3"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (4 members, 24\u002B corresponding lines): src/applications/drydock/controller/DrydockAuthorizationListController.php:22-46 | src/applications/drydock/controller/DrydockLeaseListController.php:10-33 | src/applications/drydock/controller/DrydockResourceListController.php:10-34 | src/applications/legalpad/controller/LegalpadDocumentSignatureListController.php:8-40 \u2014 These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 24 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/controller/DrydockAuthorizationListController.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"ec3ab7708908f978b40c95f3239982ff9977ede95d97f5193f4a93094c2b95a8"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (23 corresponding lines): src/applications/herald/query/HeraldWebhookRequestQuery.php:92-114 | src/applications/phriction/query/PhrictionContentQuery.php:83-105 \u2014 These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/query/HeraldWebhookRequestQuery.php"},"region":{"startLine":92}}}],"partialFingerprints":{"codehealthFindingId/v1":"75084fdb6ee88a8afc2cde8ba423c11a2cc7efba62173282f1fc37ffb75db529"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (23 corresponding lines): src/applications/people/controller/PhabricatorPeopleProfileRevisionsController.php:55-77 | src/applications/people/controller/PhabricatorPeopleProfileTasksController.php:55-81 \u2014 These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/controller/PhabricatorPeopleProfileRevisionsController.php"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"cc4aa6c93d3616a62956a7c400d8a37ca90bae7b0b00aeb6c4db4c3577c618df"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (22 corresponding lines): src/applications/phortune/controller/merchant/PhortuneMerchantOrderListController.php:13-34 | src/applications/phortune/controller/merchant/PhortuneMerchantSubscriptionListController.php:11-32 \u2014 These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/merchant/PhortuneMerchantOrderListController.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"b90be6193c494828b8da31697a7115da96a939d2a6028728cc63dd3a46eb132d"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (21 corresponding lines): src/applications/auth/editor/PhabricatorAuthProviderConfigEditor.php:33-56 | src/applications/auth/editor/PhabricatorAuthProviderConfigEditor.php:79-99 \u2014 These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/editor/PhabricatorAuthProviderConfigEditor.php"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"532db1cde4c1afddf62735d801058a6ae43a6057efa35756538f1be8d71685f2"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 27\u002B corresponding lines): src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php:801-827 | src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php:831-862 | src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php:866-897 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 27 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php"},"region":{"startLine":801}}}],"partialFingerprints":{"codehealthFindingId/v1":"14a1a19e14b9311f3b076ea0dea73548cc5f72f33977ea8e09e83a499087921f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 23\u002B corresponding lines): src/applications/calendar/xaction/PhabricatorCalendarEventInviteTransaction.php:119-141 | src/applications/calendar/xaction/PhabricatorCalendarEventInviteTransaction.php:145-171 | src/applications/owners/xaction/PhabricatorOwnersPackageOwnersTransaction.php:47-73 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 23 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/xaction/PhabricatorCalendarEventInviteTransaction.php"},"region":{"startLine":119}}}],"partialFingerprints":{"codehealthFindingId/v1":"f3457549eb837fcb72e742d8ee41cd432de1d3c3a0a28c6c28a84be816608e5b"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (22 corresponding lines): src/applications/diffusion/typeahead/DiffusionTaggedRepositoriesFunctionDatasource.php:87-108 | src/applications/project/typeahead/PhabricatorProjectMembersDatasource.php:79-101 \u2014 These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/typeahead/DiffusionTaggedRepositoriesFunctionDatasource.php"},"region":{"startLine":87}}}],"partialFingerprints":{"codehealthFindingId/v1":"0a7faba08dcd17c2f450293a0a4a19782d2da7f89cd9b0c8eb30c497c59d3465"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (32 corresponding lines): src/applications/files/storage/PhabricatorFile.php:456-487 | src/applications/files/storage/PhabricatorFile.php:491-522 \u2014 These two members are one piece of code written twice and then edited apart: 32 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/storage/PhabricatorFile.php"},"region":{"startLine":456}}}],"partialFingerprints":{"codehealthFindingId/v1":"db0ef15a7b946c5630ed5241aeaab8e40cfbda717c8b088e29bfa3f533f49b3d"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (22 corresponding lines): src/applications/maniphest/herald/ManiphestTaskPriorityHeraldAction.php:26-50 | src/applications/maniphest/herald/ManiphestTaskStatusHeraldAction.php:26-47 \u2014 These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/herald/ManiphestTaskPriorityHeraldAction.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"b414f54dec0b36fb6424e4c3a0c0604e07f82ab2ae232d4683ad368c0ce65e51"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (25 corresponding lines): src/applications/auth/provider/PhabricatorAsanaAuthProvider.php:54-78 | src/applications/auth/provider/PhabricatorJIRAAuthProvider.php:337-368 \u2014 These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorAsanaAuthProvider.php"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"53ad4d3b8396a151d042082e6f9f907b3d94f51a306d8c67c9903a62fc3d26d5"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (29 corresponding lines): src/applications/maniphest/query/ManiphestTaskSearchEngine.php:308-340 | src/applications/ponder/query/PonderQuestionSearchEngine.php:75-103 \u2014 These two members are one piece of code written twice and then edited apart: 29 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/query/ManiphestTaskSearchEngine.php"},"region":{"startLine":308}}}],"partialFingerprints":{"codehealthFindingId/v1":"d19bc806304886222f958fbca4d001f62ea1c0302019d2b987c727fe89e0a57e"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (27 corresponding lines): src/applications/herald/storage/transcript/HeraldConditionTranscript.php:73-99 | src/applications/herald/storage/transcript/HeraldRuleTranscript.php:52-78 \u2014 These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/storage/transcript/HeraldConditionTranscript.php"},"region":{"startLine":73}}}],"partialFingerprints":{"codehealthFindingId/v1":"55933abaef734ec206351102d8a347f66ddf32ae75db82b588ea89c1cc872b93"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (28 corresponding lines): src/applications/nuance/item/NuanceGitHubEventItemType.php:295-327 | src/applications/phurl/controller/PhabricatorPhurlURLViewController.php:124-151 \u2014 These two members are one piece of code written twice and then edited apart: 28 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/item/NuanceGitHubEventItemType.php"},"region":{"startLine":295}}}],"partialFingerprints":{"codehealthFindingId/v1":"55ecc97d078ed230ae605c702c150732c97e1b6545d2cb9acde6f5876cfbdd87"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (22 corresponding lines): src/applications/passphrase/xaction/PassphraseCredentialUsernameTransaction.php:32-53 | src/applications/project/xaction/column/PhabricatorProjectColumnNameTransaction.php:39-66 \u2014 These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/passphrase/xaction/PassphraseCredentialUsernameTransaction.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"b682a15256b45e5745070485078117084ef3917869d5b7aa7743d2ca2c575dab"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 26\u002B corresponding lines): src/applications/almanac/xaction/AlmanacInterfaceNetworkTransaction.php:25-50 | src/applications/fund/xaction/FundInitiativeMerchantTransaction.php:56-85 | src/applications/phame/xaction/PhamePostBlogTransaction.php:30-61 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 26 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/xaction/AlmanacInterfaceNetworkTransaction.php"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"f311400b39a0640d62d201a436c314fb81280b6cbcc4975df19055a93408a96e"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (21 corresponding lines): src/applications/badges/controller/PhabricatorBadgesProfileController.php:22-42 | src/applications/dashboard/controller/PhabricatorDashboardProfileController.php:18-39 \u2014 These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/controller/PhabricatorBadgesProfileController.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"12b25462e62c7f3d9d1643af425bf3390dbdd16e67caeaffbbc3152cf5f9c636"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 18\u002B corresponding lines): src/applications/calendar/controller/PhabricatorCalendarEventViewController.php:594-614 | src/applications/differential/controller/DifferentialRevisionViewController.php:702-719 | src/applications/macro/controller/PhabricatorMacroViewController.php:127-149 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 18 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/controller/PhabricatorCalendarEventViewController.php"},"region":{"startLine":594}}}],"partialFingerprints":{"codehealthFindingId/v1":"23b937370c4aa90a845ef617c2b1ca150fc49ea62c2efc8109f32e3e5edd54d1"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (26 corresponding lines): src/applications/differential/customfield/DifferentialCoreCustomField.php:44-69 | src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php:355-385 \u2014 These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/customfield/DifferentialCoreCustomField.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"8f5226b1264355cfaf663147e5003b6ccb5d2b30c655767cc91e71a9e1ae5e38"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (25 corresponding lines): src/applications/differential/storage/DifferentialDiff.php:727-751 | src/applications/differential/storage/DifferentialRevision.php:1024-1048 \u2014 These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialDiff.php"},"region":{"startLine":727}}}],"partialFingerprints":{"codehealthFindingId/v1":"f4315c6a681ae3cb3c0d1d9ab3e32d90bc504cc9d942dbf12215742faf5580ed"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (25 corresponding lines): src/applications/phortune/controller/account/PhortuneAccountController.php:70-94 | src/applications/phortune/controller/merchant/PhortuneMerchantController.php:54-79 \u2014 These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountController.php"},"region":{"startLine":70}}}],"partialFingerprints":{"codehealthFindingId/v1":"aaba8938277478e28fc2b5a35e86964bd043f9582de0bb85f21ff90ed6618a62"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 18\u002B corresponding lines): src/applications/search/menuitem/PhabricatorConpherenceProfileMenuItem.php:45-62 | src/applications/search/menuitem/PhabricatorDashboardProfileMenuItem.php:77-100 | src/applications/search/menuitem/PhabricatorProjectProfileMenuItem.php:39-56 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 18 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/menuitem/PhabricatorConpherenceProfileMenuItem.php"},"region":{"startLine":45}}}],"partialFingerprints":{"codehealthFindingId/v1":"4c24636e621679a11c0f9b60962cfe051b791571e124d5d68575afff3fd98219"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (18 corresponding lines): src/applications/auth/factor/PhabricatorSMSAuthFactor.php:262-279 | src/applications/auth/factor/PhabricatorTOTPAuthFactor.php:188-206 \u2014 These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/factor/PhabricatorSMSAuthFactor.php"},"region":{"startLine":262}}}],"partialFingerprints":{"codehealthFindingId/v1":"06ea9d2af0be9411251a8a66fe9507f85cedc99d15ac93e6e1bd7565db28513f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 25\u002B corresponding lines): src/applications/repository/management/PhabricatorRepositoryManagementDiscoverWorkflow.php:31-55 | src/applications/repository/management/PhabricatorRepositoryManagementPullWorkflow.php:31-55 | src/applications/repository/management/PhabricatorRepositoryManagementRefsWorkflow.php:31-56 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 25 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/management/PhabricatorRepositoryManagementDiscoverWorkflow.php"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"2325cf8636277986bb6f869af74905bf3823b9269e8c471d618bff30366576d2"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (23 corresponding lines): src/applications/people/editor/PhabricatorUserEditor.php:105-127 | src/applications/people/editor/PhabricatorUserEditor.php:134-156 \u2014 These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/editor/PhabricatorUserEditor.php"},"region":{"startLine":105}}}],"partialFingerprints":{"codehealthFindingId/v1":"e200a135a196450da8c144803c2830b867cf8c0c2ad037263256df487cec8dcc"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (25 corresponding lines): src/applications/people/storage/PhabricatorUserEmail.php:240-265 | src/applications/people/storage/PhabricatorUserEmail.php:278-302 \u2014 These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/storage/PhabricatorUserEmail.php"},"region":{"startLine":240}}}],"partialFingerprints":{"codehealthFindingId/v1":"4d2e56cb2c96e36c85095c19913f526513649d71f9f463e28cbf0fa198f769b4"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (19 corresponding lines): src/applications/phortune/controller/account/PhortuneAccountSubscriptionController.php:42-60 | src/applications/phortune/controller/account/PhortuneAccountSubscriptionViewController.php:86-106 \u2014 These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountSubscriptionController.php"},"region":{"startLine":42}}}],"partialFingerprints":{"codehealthFindingId/v1":"c6a108a3f0ebf8e516f93d2d8ac6683d6ca5ca8ba58111f6a1eafcae23e95fd9"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (23 corresponding lines): src/applications/badges/xaction/PhabricatorBadgesBadgeRevokeTransaction.php:58-83 | src/applications/calendar/xaction/PhabricatorCalendarEventHostTransaction.php:34-56 \u2014 These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/xaction/PhabricatorBadgesBadgeRevokeTransaction.php"},"region":{"startLine":58}}}],"partialFingerprints":{"codehealthFindingId/v1":"0a552a0ee6f725bb96da5f4fcd983be0b6335b854abb23ca42d15c72ee050eea"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (21 corresponding lines): src/applications/diffusion/query/DiffusionCachedResolveRefsQuery.php:32-52 | src/applications/diffusion/query/lowlevel/DiffusionLowLevelResolveRefsQuery.php:30-57 \u2014 These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/DiffusionCachedResolveRefsQuery.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"9dec183f29622930156a2557294947c61c44487a0930b17dece65026c6451e1c"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (20 corresponding lines): src/applications/calendar/controller/PhabricatorCalendarExportViewController.php:53-72 | src/applications/calendar/controller/PhabricatorCalendarImportViewController.php:61-80 \u2014 These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/controller/PhabricatorCalendarExportViewController.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"fb91184ac26f4b125fd3b0282eb0a33125ddb03c9914c7d45d5298c970254b64"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (23 corresponding lines): src/applications/calendar/xaction/PhabricatorCalendarEventFrequencyTransaction.php:102-124 | src/applications/ponder/xaction/PonderQuestionStatusTransaction.php:39-61 \u2014 These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/xaction/PhabricatorCalendarEventFrequencyTransaction.php"},"region":{"startLine":102}}}],"partialFingerprints":{"codehealthFindingId/v1":"f6009e5257a961725e3f34ebcb638b042d32cc8bebd5181871ae615492312baf"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (31 corresponding lines): src/applications/conduit/query/PhabricatorConduitLogSearchEngine.php:144-174 | src/applications/differential/query/DifferentialRevisionSearchEngine.php:355-390 \u2014 These two members are one piece of code written twice and then edited apart: 31 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conduit/query/PhabricatorConduitLogSearchEngine.php"},"region":{"startLine":144}}}],"partialFingerprints":{"codehealthFindingId/v1":"3061d6dcade8b4e2632838e753a2c14e1cebe3429177222f10237901587f65bd"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (26 corresponding lines): src/applications/differential/editor/DifferentialRevisionEditEngine.php:344-376 | src/applications/diffusion/editor/DiffusionCommitEditEngine.php:142-167 \u2014 These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/editor/DifferentialRevisionEditEngine.php"},"region":{"startLine":344}}}],"partialFingerprints":{"codehealthFindingId/v1":"7fceb74d7aaaf3835a565d21d8e455bea3955e44b9c0631380b09fad2322555c"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (4 members, 22\u002B corresponding lines): src/applications/files/xaction/PhabricatorFileAltTextTransaction.php:50-72 | src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php:50-71 | src/applications/paste/xaction/PhabricatorPasteTitleTransaction.php:40-62 | src/applications/phortune/xaction/PhortuneMerchantInvoiceEmailTransaction.php:39-60 \u2014 These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 22 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/xaction/PhabricatorFileAltTextTransaction.php"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"11821ff9f6a9b1851869f6cc4d7070f1cf8441103f595b5dac65723c8e42c7cf"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (20 corresponding lines): src/applications/macro/query/PhabricatorMacroQuery.php:206-225 | src/applications/paste/query/PhabricatorPasteQuery.php:194-218 \u2014 These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/macro/query/PhabricatorMacroQuery.php"},"region":{"startLine":206}}}],"partialFingerprints":{"codehealthFindingId/v1":"b61cb56a676b21ed92f5b5e7a070deaf34e50bc2bce8a4c7630e1d567216bf07"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (5 members, 20\u002B corresponding lines): src/applications/almanac/typeahead/AlmanacServiceDatasource.php:19-54 | src/applications/diffusion/typeahead/DiffusionRefDatasource.php:22-47 | src/applications/drydock/typeahead/DrydockLeaseDatasource.php:15-34 | src/applications/drydock/typeahead/DrydockResourceDatasource.php:15-34 | src/applications/metamta/typeahead/PhabricatorMetaMTAApplicationEmailDatasource.php:24-49 \u2014 These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 20 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/typeahead/AlmanacServiceDatasource.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"a97ba57246ea418f1495d4ba55cd124fd5c89bc24115e905257a1c6e4ad77a9c"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 20\u002B corresponding lines): src/applications/auth/storage/PhabricatorAuthProviderConfig.php:151-170 | src/applications/harbormaster/storage/HarbormasterBuildable.php:398-418 | src/applications/harbormaster/storage/build/HarbormasterBuild.php:505-525 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 20 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/storage/PhabricatorAuthProviderConfig.php"},"region":{"startLine":151}}}],"partialFingerprints":{"codehealthFindingId/v1":"ead51fbda10450c4869820d9a5c050caacd5725d30d200a727eaf33e0c2f8141"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (21 corresponding lines): src/applications/dashboard/typeahead/PhabricatorDashboardDatasource.php:19-42 | src/applications/dashboard/typeahead/PhabricatorDashboardPortalDatasource.php:28-48 \u2014 These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/typeahead/PhabricatorDashboardDatasource.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"8371f95523dc3c3bc7872ba3e3e7e0decd71aaea9db67acd35f00288c4220088"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (24 corresponding lines): src/applications/drydock/controller/DrydockLeaseViewController.php:101-124 | src/applications/drydock/controller/DrydockResourceViewController.php:110-135 \u2014 These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/controller/DrydockLeaseViewController.php"},"region":{"startLine":101}}}],"partialFingerprints":{"codehealthFindingId/v1":"8830a2421c4fd3965e6fc62a8b3be3c08dd6b8a7d381c17ac8bf60d266b7ea9b"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (21 corresponding lines): src/applications/harbormaster/typeahead/HarbormasterBuildPlanDatasource.php:19-41 | src/applications/macro/typeahead/PhabricatorMacroDatasource.php:18-38 \u2014 These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/typeahead/HarbormasterBuildPlanDatasource.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"ba6157f6b2b50722aa8d08da802523e9eef53c3a4fd2033a2000c76c9133991d"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 25\u002B corresponding lines): src/applications/conpherence/xaction/ConpherenceThreadParticipantsTransaction.php:88-114 | src/applications/maniphest/xaction/ManiphestTaskOwnerTransaction.php:110-134 | src/applications/repository/xaction/PhabricatorRepositoryIdentityAssignTransaction.php:49-78 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 25 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/xaction/ConpherenceThreadParticipantsTransaction.php"},"region":{"startLine":88}}}],"partialFingerprints":{"codehealthFindingId/v1":"746f57a0c7fea6aa200dd03f46f508ceaf67384c093917ca8b1ab71ca9c157d1"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (20 corresponding lines): src/applications/diffusion/query/lowlevel/DiffusionLowLevelCommitQuery.php:19-38 | src/applications/diffusion/query/lowlevel/DiffusionLowLevelParentsQuery.php:14-33 \u2014 These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/lowlevel/DiffusionLowLevelCommitQuery.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"609cc073b8e3f73587fe6445fdd45e6aa5f7f407f8aba7faf15c6981c6119748"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (29 corresponding lines): src/applications/phriction/xaction/PhrictionDocumentDeleteTransaction.php:43-74 | src/applications/phriction/xaction/PhrictionDocumentMoveToTransaction.php:69-97 \u2014 These two members are one piece of code written twice and then edited apart: 29 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/xaction/PhrictionDocumentDeleteTransaction.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"97e289c4176894b1f953ae0079d7cd9da399801b63180eafd8e915fab5a5639f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (13 corresponding lines): src/applications/calendar/parser/data/PhutilCalendarAbsoluteDateTime.php:63-75 | src/view/form/control/AphrontFormDateControlValue.php:235-256 \u2014 These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/data/PhutilCalendarAbsoluteDateTime.php"},"region":{"startLine":63}}}],"partialFingerprints":{"codehealthFindingId/v1":"4f0f065beb8d70816fe84152becbe0612e29c114a05d351612d85424d15a50d0"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (19 corresponding lines): src/applications/calendar/xaction/PhabricatorCalendarEventInviteTransaction.php:53-71 | src/applications/calendar/xaction/PhabricatorCalendarEventReplyTransaction.php:16-34 \u2014 These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/xaction/PhabricatorCalendarEventInviteTransaction.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"c50296d62fd78859e7cdb21a7a6104a8d75c9093ddca17cadb019ce9fbcb6869"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (6 members, 19\u002B corresponding lines): src/applications/conpherence/xaction/ConpherenceThreadTitleTransaction.php:54-72 | src/applications/countdown/xaction/PhabricatorCountdownTitleTransaction.php:33-51 | src/applications/differential/xaction/DifferentialRevisionTitleTransaction.php:35-55 | src/applications/legalpad/xaction/LegalpadDocumentTitleTransaction.php:54-72 | src/applications/phame/xaction/PhamePostTitleTransaction.php:34-52 | src/applications/ponder/xaction/PonderQuestionTitleTransaction.php:34-52 \u2014 These 6 members are one piece of code written 6 times and then edited apart: every two of them correspond over at least 19 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 6 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/xaction/ConpherenceThreadTitleTransaction.php"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"e6d51e13cdb76367afd5d05404ab7666d40884a61d18a751b90eb54ceb9b7bea"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (22 corresponding lines): src/aphront/response/Aphront403Response.php:19-40 | src/aphront/response/Aphront404Response.php:10-38 \u2014 These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/response/Aphront403Response.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"7379c3e7cd4e200dd2de34cf2f87671fc938f7815f2f03bb2266f1e60cee3a91"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (22 corresponding lines): src/applications/auth/controller/message/PhabricatorAuthMessageEditController.php:7-28 | src/applications/auth/controller/mfa/PhabricatorAuthFactorProviderEditController.php:7-28 \u2014 These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/message/PhabricatorAuthMessageEditController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"485eb82e4833a31f8220269f489e6d2ec2a6519a91eb63add6f2a6001d4b0c43"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (21 corresponding lines): src/applications/differential/customfield/DifferentialCustomField.php:43-63 | src/applications/differential/field/DifferentialCommitMessageField.php:127-149 \u2014 These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/customfield/DifferentialCustomField.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"b7c151d9abd71165c62ae6d08c9b4d842fb6a73cd99d34ab263605cd99485c9d"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (26 corresponding lines): src/applications/herald/query/HeraldTranscriptQuery.php:104-129 | src/applications/oauthserver/query/PhabricatorOAuthServerClientQuery.php:41-66 \u2014 These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/query/HeraldTranscriptQuery.php"},"region":{"startLine":104}}}],"partialFingerprints":{"codehealthFindingId/v1":"13f0010ffa425f104eb62826f775f5dadcfb26ede7cb9961e4dd7c8b6d641e79"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 24\u002B corresponding lines): src/applications/audit/view/PhabricatorAuditTransactionView.php:24-47 | src/applications/differential/view/DifferentialTransactionView.php:56-79 | src/applications/pholio/view/PholioTransactionView.php:21-44 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 24 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/view/PhabricatorAuditTransactionView.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"bfb18159774d16e79029bc8d4d1ff02cb535793f3279ce544d5817c350a2e668"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (26 corresponding lines): src/applications/diviner/publisher/DivinerStaticPublisher.php:29-57 | src/infrastructure/cache/PhutilDirectoryKeyValueCache.php:120-145 \u2014 These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/publisher/DivinerStaticPublisher.php"},"region":{"startLine":29}}}],"partialFingerprints":{"codehealthFindingId/v1":"da125eef6c5f4e8df53b4c0805608be0b7f047099b397a20f404fd920ee1ad08"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (23 corresponding lines): src/applications/diffusion/query/DiffusionCommitRequiredActionResultBucket.php:89-114 | src/applications/diffusion/query/DiffusionCommitRequiredActionResultBucket.php:118-140 \u2014 These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/DiffusionCommitRequiredActionResultBucket.php"},"region":{"startLine":89}}}],"partialFingerprints":{"codehealthFindingId/v1":"f2450105f353d8723eb11707d25f0c678f59ca943455957c7b45de8fc5c884ab"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (25 corresponding lines): src/applications/diffusion/query/lowlevel/DiffusionLowLevelCommitQuery.php:154-178 | src/applications/diffusion/query/lowlevel/DiffusionLowLevelCommitQuery.php:182-206 \u2014 These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/lowlevel/DiffusionLowLevelCommitQuery.php"},"region":{"startLine":154}}}],"partialFingerprints":{"codehealthFindingId/v1":"869c22fb274d6c4056501b4fc24c689ab32c61ac710326f684c8c4e1d584a23f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (21 corresponding lines): src/applications/drydock/storage/DrydockLease.php:466-489 | src/applications/drydock/storage/DrydockResource.php:254-274 \u2014 These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/storage/DrydockLease.php"},"region":{"startLine":466}}}],"partialFingerprints":{"codehealthFindingId/v1":"80311a2b368aca21558ff453642d38c70cbbc6974104fe20679529f34a677bfd"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (16 corresponding lines): src/applications/drydock/storage/DrydockLease.php:493-508 | src/applications/drydock/storage/DrydockRepositoryOperation.php:221-241 \u2014 These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/storage/DrydockLease.php"},"region":{"startLine":493}}}],"partialFingerprints":{"codehealthFindingId/v1":"28ae1f6ea99fcf15318dfc4c51b52cb30085d623e27e257d12afcc87fa727bea"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (16 corresponding lines): src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php:72-87 | src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php:119-135 \u2014 These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php"},"region":{"startLine":72}}}],"partialFingerprints":{"codehealthFindingId/v1":"2b2f47617442b493e75ab66a2631de9383b611c2b2c7a5d41b2bb6109c903133"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (5 members, 19\u002B corresponding lines): src/applications/differential/xaction/DifferentialRevisionRepositoryTransaction.php:17-35 | src/applications/differential/xaction/DifferentialRevisionRepositoryTransaction.php:39-60 | src/applications/repository/xaction/PhabricatorRepositoryCopyTimeLimitTransaction.php:30-51 | src/applications/repository/xaction/PhabricatorRepositoryFilesizeLimitTransaction.php:30-50 | src/applications/repository/xaction/PhabricatorRepositoryTouchLimitTransaction.php:30-50 \u2014 These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 19 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/xaction/DifferentialRevisionRepositoryTransaction.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"41f54276747faf7549cb17f30b4d0cbab2725456c5fecbd97ef44a978ba6441b"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 18\u002B corresponding lines): src/applications/packages/xaction/package/PhabricatorPackagesPackageKeyTransaction.php:17-44 | src/applications/packages/xaction/package/PhabricatorPackagesPackageNameTransaction.php:34-51 | src/applications/packages/xaction/publisher/PhabricatorPackagesPublisherKeyTransaction.php:17-41 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 18 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/packages/xaction/package/PhabricatorPackagesPackageKeyTransaction.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"e6c591a1cf345533a1474531bbeda8dba66a02968cef782986dd28411a5f5dc4"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (17 corresponding lines): src/applications/pholio/controller/PholioMockViewController.php:215-234 | src/applications/slowvote/controller/PhabricatorSlowvotePollController.php:145-161 \u2014 These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/pholio/controller/PholioMockViewController.php"},"region":{"startLine":215}}}],"partialFingerprints":{"codehealthFindingId/v1":"0926a67ad90429e9b0e4f41f958ba653875a87a7f59f68fe7c9402e37ed5f6a6"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (20 corresponding lines): src/applications/maniphest/xaction/ManiphestTaskTitleTransaction.php:65-90 | src/applications/transactions/xaction/PhabricatorEditEngineNameTransaction.php:32-51 \u2014 These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/xaction/ManiphestTaskTitleTransaction.php"},"region":{"startLine":65}}}],"partialFingerprints":{"codehealthFindingId/v1":"9578f6974238fecfb3ae3825104125f096cbbb31e3fcc7ac6c275e6f69513453"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (21 corresponding lines): src/applications/passphrase/controller/PassphraseCredentialViewController.php:183-207 | src/applications/spaces/controller/PhabricatorSpacesViewController.php:72-92 \u2014 These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/passphrase/controller/PassphraseCredentialViewController.php"},"region":{"startLine":183}}}],"partialFingerprints":{"codehealthFindingId/v1":"6faa0d9cf4fa5c3e7dc86fecef7b2e51268a234a68773ed083f9396dbf5b532e"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (24 corresponding lines): src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php:38-61 | src/applications/repository/engine/PhabricatorRepositoryPullEngine.php:25-48 \u2014 These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"647b63716386201cbb7e1b55975104975127280f97bf54839d92546bb7c0b10c"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (20 corresponding lines): src/applications/repository/storage/PhabricatorRepository.php:1109-1128 | src/applications/repository/storage/PhabricatorRepositoryURI.php:226-245 \u2014 These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepository.php"},"region":{"startLine":1109}}}],"partialFingerprints":{"codehealthFindingId/v1":"c018a76d7e1fde3b7449563dc25bd12fe0b5a0e8adec56404fd2dcb00bbd60d4"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (27 corresponding lines): src/applications/drydock/worker/DrydockLeaseUpdateWorker.php:274-300 | src/applications/drydock/worker/DrydockLeaseUpdateWorker.php:304-331 \u2014 These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/worker/DrydockLeaseUpdateWorker.php"},"region":{"startLine":274}}}],"partialFingerprints":{"codehealthFindingId/v1":"5ab999a490e4c02de314b2d4c25aaa2f48171ef1e32ce9a254563ae74807438b"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (31 corresponding lines): src/applications/drydock/worker/DrydockLeaseUpdateWorker.php:1063-1100 | src/applications/drydock/worker/DrydockResourceUpdateWorker.php:263-293 \u2014 These two members are one piece of code written twice and then edited apart: 31 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/worker/DrydockLeaseUpdateWorker.php"},"region":{"startLine":1063}}}],"partialFingerprints":{"codehealthFindingId/v1":"442ddd3397a10df699896273d5e847e96c0cd2e7ca093afa051bf3553332386a"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (19 corresponding lines): src/applications/maniphest/controller/ManiphestTaskDetailController.php:433-451 | src/applications/maniphest/controller/ManiphestTaskDetailController.php:510-529 \u2014 These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/controller/ManiphestTaskDetailController.php"},"region":{"startLine":433}}}],"partialFingerprints":{"codehealthFindingId/v1":"7cff63464e26ea913c9b1f0ffdbd78e589003a9e47b69366837853b685fd49a2"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (23 corresponding lines): src/applications/phame/controller/blog/PhameBlogViewController.php:170-192 | src/applications/phame/controller/post/PhamePostViewController.php:334-356 \u2014 These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/blog/PhameBlogViewController.php"},"region":{"startLine":170}}}],"partialFingerprints":{"codehealthFindingId/v1":"7dd37d4a658975c22fe797e00732bff583c1280e80da87b8206c89ac8236b058"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (20 corresponding lines): src/applications/search/engine/PhabricatorApplicationSearchEngine.php:1307-1326 | src/applications/search/engine/PhabricatorApplicationSearchEngine.php:1438-1460 \u2014 These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorApplicationSearchEngine.php"},"region":{"startLine":1307}}}],"partialFingerprints":{"codehealthFindingId/v1":"d03576fd2166bed7f44dbc42aa9c4e07dd4040d0e1ba62c6351df23ee0fb081c"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (18 corresponding lines): src/applications/maniphest/typeahead/ManiphestTaskPriorityDatasource.php:28-45 | src/applications/maniphest/typeahead/ManiphestTaskStatusDatasource.php:29-51 \u2014 These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/typeahead/ManiphestTaskPriorityDatasource.php"},"region":{"startLine":28}}}],"partialFingerprints":{"codehealthFindingId/v1":"264ef1eda69b919a331680411631e51e115dc7ce94e3b9b49a5840bcfc1a9721"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (14 corresponding lines): src/applications/diffusion/management/DiffusionRepositoryAutomationManagementPanel.php:89-107 | src/applications/diffusion/management/DiffusionRepositoryStagingManagementPanel.php:68-81 \u2014 These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/management/DiffusionRepositoryAutomationManagementPanel.php"},"region":{"startLine":89}}}],"partialFingerprints":{"codehealthFindingId/v1":"0868c24fb41d37a2dadc0a1ff49bcf48ddb06eb7b5de6612cb3a877a4daef6e8"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (24 corresponding lines): src/applications/drydock/query/DrydockCommandQuery.php:52-75 | src/applications/harbormaster/query/HarbormasterBuildMessageQuery.php:58-81 \u2014 These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/query/DrydockCommandQuery.php"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"08fd87c3743419c343ba96aaea47f3ba8c355b44d0bb607b5537704a7b196ac2"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (24 corresponding lines): src/applications/diffusion/query/DiffusionCommitHintQuery.php:60-83 | src/applications/repository/query/PhabricatorRepositoryGitLFSRefQuery.php:30-53 \u2014 These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/DiffusionCommitHintQuery.php"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"7222df92135fc6cc7ac06fcd2fab237b11911d07b27c4746e5ea64a7f7352e03"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (15 corresponding lines): src/applications/maniphest/typeahead/ManiphestTaskSubtypeDatasource.php:28-42 | src/applications/project/typeahead/PhabricatorProjectSubtypeDatasource.php:28-42 \u2014 These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/typeahead/ManiphestTaskSubtypeDatasource.php"},"region":{"startLine":28}}}],"partialFingerprints":{"codehealthFindingId/v1":"2b70cfab97237b743e19038c03f87a2836ac1690c6179537298563e646f427cf"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (4 members, 16\u002B corresponding lines): src/applications/repository/xaction/PhabricatorRepositoryEncodingTransaction.php:17-36 | src/applications/repository/xaction/PhabricatorRepositoryMaintenanceTransaction.php:25-40 | src/applications/repository/xaction/PhabricatorRepositoryServiceTransaction.php:25-46 | src/applications/repository/xaction/PhabricatorRepositorySlugTransaction.php:25-43 \u2014 These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 16 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/xaction/PhabricatorRepositoryEncodingTransaction.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"ef21dc93a3030cf73654de5ebc586ce3e6063ca0a06869f8700a322e17ecc837"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (5 members, 20\u002B corresponding lines): src/applications/almanac/controller/AlmanacServiceEditController.php:7-28 | src/applications/calendar/controller/PhabricatorCalendarImportEditController.php:7-27 | src/applications/diffusion/controller/DiffusionRepositoryEditController.php:7-26 | src/applications/drydock/controller/DrydockBlueprintEditController.php:6-26 | src/applications/nuance/controller/NuanceSourceEditController.php:7-27 \u2014 These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 20 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/controller/AlmanacServiceEditController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"91e9a48291e71b697ce12fb8447a751c372dadf17fe35aec36226a9efb71118e"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (17 corresponding lines): src/applications/files/typeahead/PhabricatorIconDatasource.php:27-43 | src/applications/macro/typeahead/PhabricatorEmojiDatasource.php:27-44 \u2014 These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/typeahead/PhabricatorIconDatasource.php"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"e951cdec6e5382b558265b8da9a076799899dc8fe490ea3f9c02bfc26ec7db2e"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (16 corresponding lines): src/applications/harbormaster/query/HarbormasterBuildPlanQuery.php:54-70 | src/applications/repository/query/PhabricatorRepositoryPushEventQuery.php:62-77 \u2014 These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/query/HarbormasterBuildPlanQuery.php"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"84eec238c212a5a22f4c2bc79d08e0824565fd938e1b21c3f717dbbc6dc69dae"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (17 corresponding lines): src/applications/maniphest/constants/ManiphestTaskPriority.php:27-43 | src/applications/maniphest/constants/ManiphestTaskStatus.php:51-71 \u2014 These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/constants/ManiphestTaskPriority.php"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"1c01f2c851865298428ec03a9c70cf867d71e279f237d8075e44b5befc9b7754"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (16 corresponding lines): src/applications/maniphest/xaction/ManiphestTaskStatusTransaction.php:29-46 | src/applications/maniphest/xaction/ManiphestTaskUnblockTransaction.php:13-28 \u2014 These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/xaction/ManiphestTaskStatusTransaction.php"},"region":{"startLine":29}}}],"partialFingerprints":{"codehealthFindingId/v1":"48b544377b6173b9fdecabd4265acd76ebb55e97a96b4703ec42e351372f2ffe"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (4 members, 19\u002B corresponding lines): src/applications/almanac/query/AlmanacDeviceSearchEngine.php:47-65 | src/applications/files/query/PhabricatorFileSearchEngine.php:59-81 | src/applications/paste/query/PhabricatorPasteSearchEngine.php:20-42 | src/applications/phurl/query/PhabricatorPhurlURLSearchEngine.php:45-63 \u2014 These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 19 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/query/AlmanacDeviceSearchEngine.php"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"238f6710567e69e66f773f4307c16404d5958b9d740f4827617684ee8470a1d3"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (30 corresponding lines): src/applications/auth/xaction/PhabricatorAuthContactNumberPrimaryTransaction.php:23-52 | src/applications/auth/xaction/PhabricatorAuthContactNumberStatusTransaction.php:31-62 \u2014 These two members are one piece of code written twice and then edited apart: 30 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/xaction/PhabricatorAuthContactNumberPrimaryTransaction.php"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"1c565691d52fd4e5c8542a1e5ea96ddd6354dc92626f5cc35474064e59c63eb7"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (4 members, 15\u002B corresponding lines): src/applications/countdown/storage/PhabricatorCountdown.php:25-40 | src/applications/passphrase/storage/PassphraseCredential.php:32-48 | src/applications/paste/storage/PhabricatorPaste.php:37-52 | src/applications/pholio/storage/PholioMock.php:36-50 \u2014 These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 15 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/countdown/storage/PhabricatorCountdown.php"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"7f8fe70e041f6bc4c1636f3d33bb2c843518c698a616cf76bcf1173bdbcdb987"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 20\u002B corresponding lines): src/applications/drydock/controller/DrydockAuthorizationListController.php:65-84 | src/applications/drydock/controller/DrydockLeaseController.php:36-59 | src/applications/drydock/controller/DrydockResourceController.php:36-57 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 20 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/controller/DrydockAuthorizationListController.php"},"region":{"startLine":65}}}],"partialFingerprints":{"codehealthFindingId/v1":"753af45b42406d45b31fe75d1050a5cbe2e1be12732b2a9b6c5ed4cf79649c4f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (15 corresponding lines): src/applications/fund/query/FundBackerQuery.php:54-68 | src/applications/repository/query/PhabricatorRepositoryPushLogQuery.php:68-85 \u2014 These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fund/query/FundBackerQuery.php"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"6592ce9eadefea24e7c410dd11f93bb24bd419920eccf46eefdf16d8dd881923"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (4 members, 24\u002B corresponding lines): src/applications/almanac/xaction/AlmanacDeviceStatusTransaction.php:34-58 | src/applications/dashboard/xaction/dashboard/PhabricatorDashboardLayoutTransaction.php:27-51 | src/applications/dashboard/xaction/dashboard/PhabricatorDashboardStatusTransaction.php:32-55 | src/applications/dashboard/xaction/panel/PhabricatorDashboardQueryPanelApplicationTransaction.php:13-36 \u2014 These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 24 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/xaction/AlmanacDeviceStatusTransaction.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"e156db189f1d9ea36a6edfbcae599ddb2f1bc04eeadc33d3f38ff9536dd4ca3f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 15\u002B corresponding lines): src/applications/herald/controller/HeraldController.php:10-28 | src/applications/maniphest/controller/ManiphestController.php:10-27 | src/applications/phame/controller/post/PhamePostListController.php:20-34 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 15 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/controller/HeraldController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"cbc7b9bad5936a8474d7279fd606df895a5306c293f9059b3c43bbeb735cbcef"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 16\u002B corresponding lines): src/applications/maniphest/httpparametertype/ManiphestTaskPHIDResolver.php:7-27 | src/applications/phid/resolver/PhabricatorProjectPHIDResolver.php:10-25 | src/applications/phid/resolver/PhabricatorUserPHIDResolver.php:9-24 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 16 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/httpparametertype/ManiphestTaskPHIDResolver.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"571fc65f1eba5ab7119be09e80baadf6e0263f62c87c8821467677ebc7de5a28"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (5 members, 22\u002B corresponding lines): src/applications/phortune/storage/PhortuneCart.php:82-103 | src/applications/phortune/storage/PhortuneCart.php:157-180 | src/applications/phortune/storage/PhortuneCart.php:223-244 | src/applications/phortune/storage/PhortuneCart.php:248-274 | src/applications/phortune/storage/PhortuneCart.php:278-304 \u2014 These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 22 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/storage/PhortuneCart.php"},"region":{"startLine":82}}}],"partialFingerprints":{"codehealthFindingId/v1":"6a4c27085eae72249cc86398b94bab1a8bd2930f1a5b7dd43ed36d1563a7b8ba"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (17 corresponding lines): src/applications/audit/editor/PhabricatorAuditEditor.php:851-867 | src/applications/differential/editor/DifferentialTransactionEditor.php:1670-1686 \u2014 These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/editor/PhabricatorAuditEditor.php"},"region":{"startLine":851}}}],"partialFingerprints":{"codehealthFindingId/v1":"10db7c8094ae9d52789d96a4042bf64950b359eb2d6ec8458a12601fd2d13da8"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (4 members, 21\u002B corresponding lines): src/applications/calendar/search/PhabricatorCalendarEventFulltextEngine.php:10-36 | src/applications/fund/search/FundInitiativeFulltextEngine.php:10-32 | src/applications/phame/search/PhamePostFulltextEngine.php:10-30 | src/applications/pholio/search/PholioMockFulltextEngine.php:10-30 \u2014 These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 21 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/search/PhabricatorCalendarEventFulltextEngine.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"4c967b9656917be6c4032d7f23f2e44e0fecc09f0d5b3758f046543b807f3d63"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (5 members, 16\u002B corresponding lines): src/applications/conpherence/controller/ConpherenceRoomListController.php:26-41 | src/applications/legalpad/controller/LegalpadController.php:6-22 | src/applications/passphrase/controller/PassphraseController.php:6-21 | src/applications/phriction/controller/PhrictionController.php:14-30 | src/applications/ponder/controller/PonderController.php:6-21 \u2014 These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 16 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceRoomListController.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"e9d5ab4a9c061cd6531bcea943fff4eadf67d6104c84ca0cea71c5e182f610fd"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (18 corresponding lines): src/applications/countdown/controller/PhabricatorCountdownViewController.php:86-105 | src/applications/phlux/controller/PhluxViewController.php:63-80 \u2014 These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/countdown/controller/PhabricatorCountdownViewController.php"},"region":{"startLine":86}}}],"partialFingerprints":{"codehealthFindingId/v1":"48f703663469639a159bc002960339cc5bc16d31f51059dba013d4ed1d526ddb"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 24\u002B corresponding lines): src/applications/search/query/PhabricatorNamedQueryConfigQuery.php:30-53 | src/applications/search/query/PhabricatorNamedQueryQuery.php:36-66 | src/applications/search/query/PhabricatorSavedQueryQuery.php:41-66 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 24 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/query/PhabricatorNamedQueryConfigQuery.php"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"2e9292b1e2bbc9fa609726fa5c71b7a9d3bcbcc04f8b5a716aa1172750c99191"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 18\u002B corresponding lines): src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php:100-119 | src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php:123-149 | src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php:246-263 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 18 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php"},"region":{"startLine":100}}}],"partialFingerprints":{"codehealthFindingId/v1":"8b1931f5a0bfac2a8960a5d3f8da5c0cef558b0dbb0439974d293f343426ce49"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (19 corresponding lines): src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php:169-187 | src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php:207-226 \u2014 These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php"},"region":{"startLine":169}}}],"partialFingerprints":{"codehealthFindingId/v1":"a4c2dd7b0efee6941d14ff8c84487fe4c4287b724e9c2f34134e6769d0476c6c"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (15 corresponding lines): src/applications/favorites/controller/PhabricatorFavoritesMenuItemController.php:7-21 | src/applications/home/controller/PhabricatorHomeMenuItemController.php:15-39 \u2014 These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/favorites/controller/PhabricatorFavoritesMenuItemController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"84380728ef1e8af0c861ed55702ea4c3a8d8d1945c96b8d03daa0a98d46258a6"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (19 corresponding lines): src/applications/diffusion/typeahead/DiffusionTaggedRepositoriesFunctionDatasource.php:56-83 | src/applications/project/typeahead/PhabricatorProjectMembersDatasource.php:57-75 \u2014 These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/typeahead/DiffusionTaggedRepositoriesFunctionDatasource.php"},"region":{"startLine":56}}}],"partialFingerprints":{"codehealthFindingId/v1":"2b2682de8db5b9eadcd4335c54e02f5929442c83ed3d0af3e45126fbe1e3a0c7"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 17\u002B corresponding lines): src/applications/drydock/worker/DrydockLeaseUpdateWorker.php:16-33 | src/applications/drydock/worker/DrydockRepositoryOperationUpdateWorker.php:7-23 | src/applications/drydock/worker/DrydockResourceUpdateWorker.php:14-31 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 17 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/worker/DrydockLeaseUpdateWorker.php"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"870a428f454ec17ed23f94c8175483177a2872b761168f901144fd59f916e36a"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 14\u002B corresponding lines): src/applications/nuance/typeahead/NuanceQueueDatasource.php:19-35 | src/applications/packages/typeahead/PhabricatorPackagesPackageDatasource.php:19-32 | src/applications/packages/typeahead/PhabricatorPackagesPublisherDatasource.php:19-32 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 14 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/typeahead/NuanceQueueDatasource.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"952eba5976c540b4cb103662fa43e6e0de56c61704311445a9913f565a099f9c"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (17 corresponding lines): src/applications/settings/controller/PhabricatorSettingsAdjustController.php:7-25 | src/applications/settings/controller/PhabricatorSettingsTimezoneController.php:133-149 \u2014 These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/settings/controller/PhabricatorSettingsAdjustController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"104e5224cdd9a9bc1759b7df006bd2c24db6df6b5c087bebc80f856fda2b86da"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (4 members, 15\u002B corresponding lines): src/applications/calendar/storage/PhabricatorCalendarEvent.php:1336-1352 | src/applications/legalpad/storage/LegalpadDocument.php:223-240 | src/applications/project/storage/PhabricatorProject.php:751-766 | src/applications/slowvote/storage/PhabricatorSlowvotePoll.php:182-196 \u2014 These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 15 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/storage/PhabricatorCalendarEvent.php"},"region":{"startLine":1336}}}],"partialFingerprints":{"codehealthFindingId/v1":"05ce71d77f21ccee3b266cd92dd804355588da5f708b9116e9e5d6b81d84edee"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (19 corresponding lines): src/applications/config/query/PhabricatorConfigEntryQuery.php:35-53 | src/applications/phlux/query/PhluxVariableQuery.php:41-66 \u2014 These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/query/PhabricatorConfigEntryQuery.php"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"59c143f5506ea8afdfaf2d80589f54e374e622fc486ffbd5318826a1906b55a0"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 15\u002B corresponding lines): src/applications/phortune/query/PhortuneAccountEmailQuery.php:42-61 | src/applications/phortune/query/PhortuneChargeQuery.php:60-76 | src/applications/phortune/query/PhortuneChargeQuery.php:80-94 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 15 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/query/PhortuneAccountEmailQuery.php"},"region":{"startLine":42}}}],"partialFingerprints":{"codehealthFindingId/v1":"93e04fba57ed76f28b276bce52fd09f67f5700291c6694b789e84e9310996b2f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 17\u002B corresponding lines): src/applications/conduit/query/PhabricatorConduitLogSearchEngine.php:23-43 | src/applications/diffusion/query/DiffusionPullLogSearchEngine.php:19-35 | src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php:19-39 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 17 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conduit/query/PhabricatorConduitLogSearchEngine.php"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"7a21bc81a6eec8051c402b26b209d9d91daa5ddfb4035d0715b4eaa4396e5f56"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (17 corresponding lines): src/applications/dashboard/query/PhabricatorDashboardPortalSearchEngine.php:57-75 | src/applications/harbormaster/query/HarbormasterArtifactSearchEngine.php:74-90 \u2014 These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/query/PhabricatorDashboardPortalSearchEngine.php"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"a62d5d4a86973cd0bc0edf49267c95a0fd53b0f8ca1508078abe99f93e6f49d2"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 15\u002B corresponding lines): src/applications/packages/view/PhabricatorPackagesPackageListView.php:23-38 | src/applications/packages/view/PhabricatorPackagesPublisherListView.php:23-38 | src/applications/packages/view/PhabricatorPackagesVersionListView.php:23-37 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 15 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/packages/view/PhabricatorPackagesPackageListView.php"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"0319c21f3abc19e8db2187c048fbd7c7697fec1c8e2187cc5151fbc267fa09a7"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (24 corresponding lines): src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemonModule.php:9-35 | src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemonModule.php:7-30 \u2014 These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemonModule.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"233bb932fecf15540d3b81899e7d0a9dd28b109c039820e76c1c16579a1e15cc"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (20 corresponding lines): src/applications/repository/xaction/PhabricatorRepositorySymbolLanguagesTransaction.php:17-36 | src/applications/repository/xaction/PhabricatorRepositorySymbolSourcesTransaction.php:17-36 \u2014 These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/xaction/PhabricatorRepositorySymbolLanguagesTransaction.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"0f4f26dabdb8f91376c403b49ee9d6d14ef5a9db12afa28be3fdf1665e16833f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (14 corresponding lines): src/applications/differential/customfield/DifferentialLintField.php:86-99 | src/applications/differential/customfield/DifferentialUnitField.php:75-88 \u2014 These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/customfield/DifferentialLintField.php"},"region":{"startLine":86}}}],"partialFingerprints":{"codehealthFindingId/v1":"f5b9bcdf08451963a94ea9e46098dfdc0596e12415e0cd35fc3b058f91043d47"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (21 corresponding lines): src/infrastructure/markup/markuprule/PhutilRemarkupEvalRule.php:19-39 | src/infrastructure/markup/markuprule/PhutilRemarkupHyperlinkRule.php:84-107 \u2014 These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/markuprule/PhutilRemarkupEvalRule.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"bc8dd972d21d413ff495125d306f2120daf9983252b05c03b701f70cca82ef42"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 19\u002B corresponding lines): src/applications/files/xaction/PhabricatorFileAltTextTransaction.php:27-46 | src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php:28-46 | src/applications/project/xaction/column/PhabricatorProjectColumnNameTransaction.php:17-35 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 19 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/xaction/PhabricatorFileAltTextTransaction.php"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"5dce23fefcaafd31d0c636358fd981c5ebc62b5014de08915af72ddf23505a87"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (19 corresponding lines): src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:4676-4704 | src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:4722-4740 \u2014 These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":4676}}}],"partialFingerprints":{"codehealthFindingId/v1":"7b4237e569aa4abad05763b113a8dea4376cd790dd4433d4adbacb14067f2db8"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (16 corresponding lines): src/applications/audit/editor/PhabricatorAuditEditor.php:145-160 | src/applications/differential/editor/DifferentialTransactionEditor.php:304-319 \u2014 These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/editor/PhabricatorAuditEditor.php"},"region":{"startLine":145}}}],"partialFingerprints":{"codehealthFindingId/v1":"5a9d0609ae094aeced9da7f5fc54cfabd493d7c728f302d5d4344eda59f08c3f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 13\u002B corresponding lines): src/applications/auth/controller/config/PhabricatorAuthProviderViewController.php:52-64 | src/applications/dashboard/controller/panel/PhabricatorDashboardPanelViewController.php:74-88 | src/applications/oauthserver/controller/client/PhabricatorOAuthClientViewController.php:54-67 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/config/PhabricatorAuthProviderViewController.php"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"86f635bda2ed8ea50ee108f69356e0f49ed348a92cec2e998931adb56632583c"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (16 corresponding lines): src/applications/diffusion/herald/DiffusionCommitRevisionAcceptingReviewersHeraldField.php:17-32 | src/applications/diffusion/herald/DiffusionPreCommitContentRevisionAcceptingReviewersHeraldField.php:17-32 \u2014 These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/herald/DiffusionCommitRevisionAcceptingReviewersHeraldField.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"c6b86fcc6be3e376e30b2a0114520ced902ee09606c8c8c3fd0407d4b6b520f0"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (20 corresponding lines): src/applications/diffusion/query/rawdiff/DiffusionMercurialRawDiffQuery.php:6-29 | src/applications/diffusion/query/rawdiff/DiffusionSvnRawDiffQuery.php:6-25 \u2014 These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/rawdiff/DiffusionMercurialRawDiffQuery.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"1cce6020952251a62994e3da9629b3d5957ed1d11625839bbcc3fb7ef73e960f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (14 corresponding lines): src/applications/nuance/cursor/NuanceGitHubIssuesImportCursor.php:13-26 | src/applications/nuance/cursor/NuanceGitHubRepositoryImportCursor.php:21-45 \u2014 These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/cursor/NuanceGitHubIssuesImportCursor.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"57e34edd3819d10d44f46d78de507ad8ac55a926eab42adad7b7bb59644408d6"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (24 corresponding lines): src/applications/nuance/query/NuanceImportCursorDataQuery.php:30-53 | src/infrastructure/edges/query/PhabricatorEdgeQuery.php:304-328 \u2014 These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/query/NuanceImportCursorDataQuery.php"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"44578dbd4097118cb47ce3c5e023ff56cffe61a7993fa887132aa10c02b26cb8"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (14 corresponding lines): src/applications/phortune/controller/account/PhortuneAccountOrderListController.php:38-51 | src/applications/phortune/controller/merchant/PhortuneMerchantOrderListController.php:38-51 \u2014 These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountOrderListController.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"472ee10976dcd003fbb038c7b2f416574b3240f6e264ce58b2244729e6dacac8"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (21 corresponding lines): src/applications/project/command/ProjectAddProjectsEmailCommand.php:46-67 | src/applications/subscriptions/command/PhabricatorSubscriptionsSubscribeEmailCommand.php:51-71 \u2014 These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/command/ProjectAddProjectsEmailCommand.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"687c5daf9c7d0a5314789ced46874543c44961571132a93e9f4f45c8dc9c29be"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (22 corresponding lines): src/applications/repository/xaction/PhabricatorRepositoryEncodingTransaction.php:40-65 | src/applications/repository/xaction/PhabricatorRepositoryFilesizeLimitTransaction.php:54-75 \u2014 These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/xaction/PhabricatorRepositoryEncodingTransaction.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"6f187fb4e0cd1426e7b94df2827067c23af8b70f68ba40e9515e9c8b5c4cc101"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (18 corresponding lines): src/applications/transactions/editfield/PhabricatorTokenizerEditField.php:39-56 | src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldTokenizer.php:147-165 \u2014 These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editfield/PhabricatorTokenizerEditField.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"2d9710fa5fd81e00f8d65ca3541db1c46bc66aa440be4deddcd771aca03fc344"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (17 corresponding lines): src/applications/differential/query/DifferentialRevisionQuery.php:889-905 | src/applications/differential/query/DifferentialRevisionQuery.php:937-953 \u2014 These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/query/DifferentialRevisionQuery.php"},"region":{"startLine":889}}}],"partialFingerprints":{"codehealthFindingId/v1":"0b045a81fdde718743814c1ac9766e2c56c533de28d30e791d91ecd1cf5a0408"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (16 corresponding lines): src/applications/differential/storage/DifferentialHunk.php:308-323 | src/applications/differential/storage/DifferentialHunk.php:327-353 \u2014 These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialHunk.php"},"region":{"startLine":308}}}],"partialFingerprints":{"codehealthFindingId/v1":"b72432f48339b58629d3b1dea084997bb37008e96b2b8adc1eaa73ab00286288"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (22 corresponding lines): src/applications/diffusion/controller/DiffusionChangeController.php:159-180 | src/applications/diffusion/controller/DiffusionLintController.php:355-380 \u2014 These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionChangeController.php"},"region":{"startLine":159}}}],"partialFingerprints":{"codehealthFindingId/v1":"3d82b27205911df4258856aa6a35561b63350d08f57ced34b6ad5bf2b0fbd5ab"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (18 corresponding lines): src/applications/drydock/worker/DrydockLeaseUpdateWorker.php:129-146 | src/applications/drydock/worker/DrydockResourceUpdateWorker.php:116-133 \u2014 These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/worker/DrydockLeaseUpdateWorker.php"},"region":{"startLine":129}}}],"partialFingerprints":{"codehealthFindingId/v1":"66c54e64ceceaa36241ebce0f32258f98e3d9592a3ab60d88f6050a4872bce83"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (24 corresponding lines): src/applications/harbormaster/codex/HarbormasterBuildPlanPolicyCodex.php:7-34 | src/applications/maniphest/policy/ManiphestTaskPolicyCodex.php:38-61 \u2014 These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/codex/HarbormasterBuildPlanPolicyCodex.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"ef3451f84b7df4278b7349c6ab4a805412b60d0b6b34ea1fc6ecd940686997ac"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (14 corresponding lines): src/applications/harbormaster/worker/HarbormasterBuildWorker.php:38-51 | src/applications/harbormaster/worker/HarbormasterBuildWorker.php:55-68 \u2014 These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/worker/HarbormasterBuildWorker.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"212a95c482fdc36dbd8216e970c44b4ef1ad380ce6e1190940a1efd19f9f7375"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 17\u002B corresponding lines): src/applications/harbormaster/xaction/build/HarbormasterBuildMessagePauseTransaction.php:85-101 | src/applications/harbormaster/xaction/build/HarbormasterBuildMessagePauseTransaction.php:108-124 | src/applications/harbormaster/xaction/build/HarbormasterBuildMessageResumeTransaction.php:98-115 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 17 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/xaction/build/HarbormasterBuildMessagePauseTransaction.php"},"region":{"startLine":85}}}],"partialFingerprints":{"codehealthFindingId/v1":"b13e262b4d15e1764a6f5af8de3fe19bb776fa77257b1259bdbfd723d76e0c29"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (16 corresponding lines): src/applications/maniphest/storage/ManiphestTransaction.php:121-136 | src/applications/maniphest/storage/ManiphestTransaction.php:140-156 \u2014 These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/storage/ManiphestTransaction.php"},"region":{"startLine":121}}}],"partialFingerprints":{"codehealthFindingId/v1":"5d0a41cb7b47e1ada0696aa32d7b37e48fae840bed42097a3f6a81638527d8ca"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (19 corresponding lines): src/applications/auth/adapter/PhutilFacebookAuthAdapter.php:66-88 | src/applications/auth/adapter/PhutilGoogleAuthAdapter.php:99-117 \u2014 These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/adapter/PhutilFacebookAuthAdapter.php"},"region":{"startLine":66}}}],"partialFingerprints":{"codehealthFindingId/v1":"bbea2326fd4013f3797a1bc87040069a7cf16c632a4d1b1716e51d112627dac9"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (16 corresponding lines): src/applications/auth/xaction/PhabricatorAuthFactorProviderNameTransaction.php:40-55 | src/applications/project/xaction/trigger/PhabricatorProjectTriggerNameTransaction.php:40-55 \u2014 These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/xaction/PhabricatorAuthFactorProviderNameTransaction.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"7a78726a55ac434d337e501df44e4aa3223d5aa7ce2cbfc22a7ffe25030caff6"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (4 members, 19\u002B corresponding lines): src/applications/badges/storage/PhabricatorBadgesTransaction.php:27-47 | src/applications/phame/storage/PhameBlogTransaction.php:23-43 | src/applications/phame/storage/PhamePostTransaction.php:28-46 | src/applications/ponder/storage/PonderQuestionTransaction.php:32-51 \u2014 These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 19 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/storage/PhabricatorBadgesTransaction.php"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"7a6e601cb6a8d074f5b9da9379684bc064dff8e9dec7a8eaabb67d4ea781cbe1"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (14 corresponding lines): src/applications/files/favicon/PhabricatorFaviconRef.php:228-241 | src/applications/macro/engine/PhabricatorMemeEngine.php:120-140 \u2014 These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/favicon/PhabricatorFaviconRef.php"},"region":{"startLine":228}}}],"partialFingerprints":{"codehealthFindingId/v1":"7663c3dabb3ba8c96c15e29c0e1abd288a3fa2eda842ef1de1199ebf4fec4e9b"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (19 corresponding lines): src/applications/harbormaster/storage/build/HarbormasterBuildLog.php:361-382 | src/applications/harbormaster/storage/build/HarbormasterBuildLogChunk.php:43-61 \u2014 These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/storage/build/HarbormasterBuildLog.php"},"region":{"startLine":361}}}],"partialFingerprints":{"codehealthFindingId/v1":"95b7dc44728fa5108b62f6122d390323b17c9f630c855c4e533076be590b8732"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (12 corresponding lines): src/applications/differential/controller/DifferentialController.php:155-166 | src/applications/differential/query/DifferentialDiffQuery.php:94-107 \u2014 These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/controller/DifferentialController.php"},"region":{"startLine":155}}}],"partialFingerprints":{"codehealthFindingId/v1":"b352c19a93440c8f9408843c2a94decb5ca090ee7a36a28d0382672e90961e33"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (15 corresponding lines): src/applications/differential/controller/DifferentialRevisionViewController.php:725-742 | src/applications/phortune/controller/account/PhortuneAccountOverviewController.php:67-81 \u2014 These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/controller/DifferentialRevisionViewController.php"},"region":{"startLine":725}}}],"partialFingerprints":{"codehealthFindingId/v1":"6cfeb120f29500afde636f4a4710994f109598c44ba10a4f685c34a74b43e57d"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 18\u002B corresponding lines): src/applications/drydock/storage/DrydockLease.php:49-66 | src/applications/drydock/worker/DrydockWorker.php:83-100 | src/applications/harbormaster/artifact/HarbormasterDrydockLeaseArtifact.php:56-80 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 18 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/storage/DrydockLease.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"70445da6f633920bc06f8904804f702ad9804353e5e57ba8b0497f06172d242b"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (16 corresponding lines): src/applications/herald/xaction/HeraldWebhookStatusTransaction.php:46-64 | src/applications/repository/xaction/PhabricatorRepositoryActivateTransaction.php:43-58 \u2014 These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/xaction/HeraldWebhookStatusTransaction.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"122d945fa07a4a89f9f10fb132365adc4c4e47e49796c06227298b212092f5db"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (16 corresponding lines): src/applications/macro/xaction/PhabricatorMacroAudioBehaviorTransaction.php:17-32 | src/applications/macro/xaction/PhabricatorMacroAudioBehaviorTransaction.php:36-54 \u2014 These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/macro/xaction/PhabricatorMacroAudioBehaviorTransaction.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"07827619803415cacfdcfac276b33a43a122d408e004fe6a53f734a739bea5e3"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (14 corresponding lines): src/applications/auth/controller/PhabricatorAuthSSHKeyViewController.php:108-121 | src/applications/pholio/controller/PholioMockViewController.php:176-191 \u2014 These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthSSHKeyViewController.php"},"region":{"startLine":108}}}],"partialFingerprints":{"codehealthFindingId/v1":"9d00eb0abca62db22e919b64b45ac89206e3f3f36ce63c0794c277e50a8664de"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (14 corresponding lines): src/applications/badges/xaction/PhabricatorBadgesBadgeFlavorTransaction.php:34-47 | src/applications/phortune/xaction/PhortuneAccountBillingNameTransaction.php:40-53 \u2014 These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/xaction/PhabricatorBadgesBadgeFlavorTransaction.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"ca217e8ba2e32c15d132617cd60ec61ad93fd14b7a4874af7f6fb1778efc9f1a"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 21\u002B corresponding lines): src/applications/calendar/xaction/PhabricatorCalendarExportModeTransaction.php:31-51 | src/applications/owners/xaction/PhabricatorOwnersPackageAuditingTransaction.php:35-64 | src/applications/owners/xaction/PhabricatorOwnersPackageIgnoredTransaction.php:58-82 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 21 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/xaction/PhabricatorCalendarExportModeTransaction.php"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"59b4d14acc6246ff741fe88ace447f620eb58062e83a8882789a74966cae149c"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (19 corresponding lines): src/applications/chatlog/query/PhabricatorChatLogChannelQuery.php:37-56 | src/applications/chatlog/query/PhabricatorChatLogQuery.php:59-77 \u2014 These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/chatlog/query/PhabricatorChatLogChannelQuery.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"61246b555e1a84eb9530f00d30f1f94d08a0d66131d78837fe9affb6755199ac"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (16 corresponding lines): src/applications/differential/customfield/DifferentialProjectReviewersField.php:35-50 | src/applications/differential/customfield/DifferentialReviewersField.php:36-51 \u2014 These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/customfield/DifferentialProjectReviewersField.php"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"c0c4221d4a2c72e73944611293c67d3c380f44549f17962a78dc493807019486"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (4 members, 11\u002B corresponding lines): src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php:98-112 | src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php:116-133 | src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php:137-147 | src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php:151-167 \u2014 These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php"},"region":{"startLine":98}}}],"partialFingerprints":{"codehealthFindingId/v1":"cc597b87f98806029a598a298a6c3b132dcf7f6c3545b9ebf786bd3a9051180d"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 12\u002B corresponding lines): src/applications/drydock/controller/DrydockAuthorizationListController.php:50-61 | src/applications/drydock/controller/DrydockLeaseController.php:18-32 | src/applications/drydock/controller/DrydockResourceController.php:18-32 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 12 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/controller/DrydockAuthorizationListController.php"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"ac8f5f8b32cf4fd88d6afaf75ccf07c8c40fa69958f6513a54c5a0e304393d18"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (17 corresponding lines): src/applications/drydock/operation/DrydockLandRepositoryOperation.php:21-38 | src/applications/drydock/operation/DrydockTestRepositoryOperation.php:18-34 \u2014 These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/operation/DrydockLandRepositoryOperation.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"4942a09e47f81f0955f06e00ecd079b181c9e3fd05d64c9129eccd5e6f4df434"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (22 corresponding lines): src/applications/fact/chart/PhabricatorChartFunction.php:21-44 | src/applications/project/order/PhabricatorProjectColumnOrder.php:100-121 \u2014 These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fact/chart/PhabricatorChartFunction.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"4e70315308ee6a50bc984eeb31024603b4a53961b9aef5b4180d23a32dccec52"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (11 corresponding lines): src/applications/phame/phid/PhabricatorPhameBlogPHIDType.php:32-42 | src/applications/phame/phid/PhabricatorPhamePostPHIDType.php:32-42 \u2014 These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/phid/PhabricatorPhameBlogPHIDType.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"ac50548cd7ac9b9cbd571d222554cb2b0f38b69619337c1084363d4fe6d332c4"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (15 corresponding lines): src/applications/conpherence/xaction/ConpherenceThreadTitleTransaction.php:34-49 | src/applications/conpherence/xaction/ConpherenceThreadTopicTransaction.php:34-48 \u2014 These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/xaction/ConpherenceThreadTitleTransaction.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"6861ee810089c79af9224c0052cacf77d01576f08f764f84399127a97bdabc8e"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (14 corresponding lines): src/applications/diffusion/management/DiffusionRepositoryManagementPanel.php:78-91 | src/applications/settings/panel/PhabricatorEditEngineSettingsPanel.php:43-56 \u2014 These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/management/DiffusionRepositoryManagementPanel.php"},"region":{"startLine":78}}}],"partialFingerprints":{"codehealthFindingId/v1":"b6d441a18ed8c48635b36cef77e4fe23639e73e838cf1bd5f1c45bcb2da1530e"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (21 corresponding lines): src/applications/drydock/worker/DrydockLeaseUpdateWorker.php:869-892 | src/applications/phortune/editor/PhortuneCartEditor.php:250-270 \u2014 These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/worker/DrydockLeaseUpdateWorker.php"},"region":{"startLine":869}}}],"partialFingerprints":{"codehealthFindingId/v1":"280a113824802cfb0db56af5124063b630e72c632cd56feb92de7df96aef7b28"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (6 members, 16\u002B corresponding lines): src/applications/macro/xaction/PhabricatorMacroAudioTransaction.php:44-59 | src/applications/project/xaction/PhabricatorProjectImageTransaction.php:17-36 | src/applications/project/xaction/PhabricatorProjectImageTransaction.php:40-62 | src/applications/project/xaction/column/PhabricatorProjectColumnLimitTransaction.php:25-43 | src/applications/project/xaction/column/PhabricatorProjectColumnTriggerTransaction.php:36-55 | src/applications/repository/xaction/PhabricatorRepositoryIdentityAssignTransaction.php:17-36 \u2014 These 6 members are one piece of code written 6 times and then edited apart: every two of them correspond over at least 16 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 6 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/macro/xaction/PhabricatorMacroAudioTransaction.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"d95c6a20cc95fd9566bd966677b1323d235fd221183a9e5389d7eb39319e5416"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (20 corresponding lines): src/infrastructure/daemon/PhutilDaemonOverseer.php:360-381 | src/infrastructure/daemon/PhutilDaemonOverseer.php:385-404 \u2014 These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/PhutilDaemonOverseer.php"},"region":{"startLine":360}}}],"partialFingerprints":{"codehealthFindingId/v1":"624d45824e6e72fd773d92895d2c1257fbd85efee353b238436f5940014ba943"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (7 members, 13\u002B corresponding lines): src/applications/almanac/controller/AlmanacNetworkListController.php:20-33 | src/applications/fund/controller/FundInitiativeListController.php:40-53 | src/applications/legalpad/controller/LegalpadDocumentListController.php:21-35 | src/applications/macro/controller/PhabricatorMacroController.php:28-41 | src/applications/people/controller/PhabricatorPeopleInviteListController.php:29-41 | src/applications/phortune/controller/merchant/PhortuneMerchantListController.php:13-26 | src/applications/spaces/controller/PhabricatorSpacesListController.php:36-49 \u2014 These 7 members are one piece of code written 7 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 7 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/controller/AlmanacNetworkListController.php"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"d321bea8cf6e5fdea3f9a09118f8c2bd5d9fcc2f80f74f97f92c2342001d111c"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (16 corresponding lines): src/applications/conpherence/query/ConpherenceParticipantCountQuery.php:20-35 | src/applications/conpherence/query/ConpherenceParticipantQuery.php:13-28 \u2014 These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/query/ConpherenceParticipantCountQuery.php"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"d3a242c30dc0c8fa8fe3d2a839bb08df163b83b5ec57d104a9266ddcf59595a3"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (15 corresponding lines): src/applications/countdown/xaction/PhabricatorCountdownEpochTransaction.php:40-56 | src/applications/nuance/xaction/NuanceSourceDefaultQueueTransaction.php:25-39 \u2014 These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/countdown/xaction/PhabricatorCountdownEpochTransaction.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"39b6d39a5107430283f6090ce9a7e218ed32398235c3fbcc305dde5f8ecde79d"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 14\u002B corresponding lines): src/applications/files/document/PhabricatorAudioDocumentEngine.php:21-34 | src/applications/files/document/PhabricatorImageDocumentEngine.php:104-117 | src/applications/files/document/PhabricatorVideoDocumentEngine.php:27-40 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 14 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/document/PhabricatorAudioDocumentEngine.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"f9435c48f8fee04f389c5483f09892ff853b3ac633e8f4a52fc55bd1d6c8706e"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (20 corresponding lines): src/applications/people/xaction/PhabricatorUserApproveTransaction.php:70-89 | src/applications/people/xaction/PhabricatorUserDisableTransaction.php:40-59 \u2014 These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/xaction/PhabricatorUserApproveTransaction.php"},"region":{"startLine":70}}}],"partialFingerprints":{"codehealthFindingId/v1":"5d7bc65dd61315b3e21338a367cce48b5bd75df6f1aab066e7d518af944f3581"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 14\u002B corresponding lines): src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:5589-5602 | src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:5607-5620 | src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:5626-5639 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 14 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":5589}}}],"partialFingerprints":{"codehealthFindingId/v1":"0be609abe05630aeda173f8aae4bf7624077f6846a8bfa3e0ed21ed931740daf"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (6 members, 15\u002B corresponding lines): src/applications/almanac/management/AlmanacManagementWorkflow.php:7-26 | src/applications/audit/management/PhabricatorAuditManagementDeleteWorkflow.php:231-249 | src/applications/audit/management/PhabricatorAuditManagementDeleteWorkflow.php:269-288 | src/applications/audit/management/PhabricatorAuditManagementDeleteWorkflow.php:309-328 | src/applications/repository/management/PhabricatorRepositoryManagementWorkflow.php:82-96 | src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php:299-314 \u2014 These 6 members are one piece of code written 6 times and then edited apart: every two of them correspond over at least 15 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 6 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/management/AlmanacManagementWorkflow.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"9d50e2cd801f97b65fbf122b8546fbd1c612a03db3e2415b8fd2157e815de384"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (7 members, 14\u002B corresponding lines): src/applications/calendar/phid/PhabricatorCalendarEventPHIDType.php:32-47 | src/applications/calendar/phid/PhabricatorCalendarExportPHIDType.php:32-47 | src/applications/calendar/phid/PhabricatorCalendarImportPHIDType.php:32-47 | src/applications/herald/phid/HeraldRulePHIDType.php:32-45 | src/applications/owners/phid/PhabricatorOwnersPackagePHIDType.php:36-54 | src/applications/repository/phid/PhabricatorRepositoryRepositoryPHIDType.php:37-53 | src/applications/spaces/phid/PhabricatorSpacesNamespacePHIDType.php:33-48 \u2014 These 7 members are one piece of code written 7 times and then edited apart: every two of them correspond over at least 14 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 7 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/phid/PhabricatorCalendarEventPHIDType.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"8e5443ab18312fd34b78c64209f8083bbb258cfb54d1a83440bcac8ea96b910e"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (5 members, 20\u002B corresponding lines): src/applications/calendar/xaction/PhabricatorCalendarImportFrequencyTransaction.php:23-42 | src/applications/harbormaster/xaction/plan/HarbormasterBuildPlanStatusTransaction.php:30-53 | src/applications/owners/xaction/PhabricatorOwnersPackageAuthorityTransaction.php:13-32 | src/applications/owners/xaction/PhabricatorOwnersPackageAutoreviewTransaction.php:13-32 | src/applications/owners/xaction/PhabricatorOwnersPackageDominionTransaction.php:13-32 \u2014 These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 20 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/xaction/PhabricatorCalendarImportFrequencyTransaction.php"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"eb05b2e5822de4bc3db237828ba43e5e110b6d0cfc3d217fe612a58a82e511f0"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 18\u002B corresponding lines): src/applications/dashboard/menuitem/PhabricatorDashboardPortalMenuItem.php:54-71 | src/applications/search/menuitem/PhabricatorEditEngineProfileMenuItem.php:98-118 | src/applications/search/menuitem/PhabricatorManageProfileMenuItem.php:49-68 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 18 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/menuitem/PhabricatorDashboardPortalMenuItem.php"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"5a096bdac9ae4d1b3ae35c6223285559eece45bd7d36d396f9c1b6ecf25db9e0"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (15 corresponding lines): src/applications/dashboard/phid/PhabricatorDashboardPanelPHIDType.php:32-47 | src/applications/herald/phid/HeraldWebhookPHIDType.php:32-46 \u2014 These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/phid/PhabricatorDashboardPanelPHIDType.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"f922a50690095effb504e1e6a9509eb9277410e339f9e17cbad190d406316d6d"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (15 corresponding lines): src/applications/project/engine/PhabricatorBoardResponseEngine.php:216-230 | src/applications/project/state/PhabricatorWorkboardViewState.php:247-261 \u2014 These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/engine/PhabricatorBoardResponseEngine.php"},"region":{"startLine":216}}}],"partialFingerprints":{"codehealthFindingId/v1":"20914639fded919d81da9d428d2a608832d76e4a2fadcf900f914f55f0e45937"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (12 corresponding lines): src/applications/repository/storage/PhabricatorRepositoryCommit.php:474-485 | src/applications/repository/storage/PhabricatorRepositoryCommit.php:489-500 \u2014 These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepositoryCommit.php"},"region":{"startLine":474}}}],"partialFingerprints":{"codehealthFindingId/v1":"f819d5f30aaf9287a617c2c03a14c064d858dc88cc6bf6778eaee3da545cbdb1"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (13 corresponding lines): src/applications/badges/phid/PhabricatorBadgesPHIDType.php:32-44 | src/applications/fund/phid/FundInitiativePHIDType.php:32-46 \u2014 These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/phid/PhabricatorBadgesPHIDType.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"9b9b51e76675ac12364c158a940b1f2250a7964cb93c4d0abdb716c786536233"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (5 members, 15\u002B corresponding lines): src/applications/countdown/query/PhabricatorCountdownSearchEngine.php:65-79 | src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php:57-78 | src/applications/fund/query/FundInitiativeSearchEngine.php:62-82 | src/applications/phame/query/PhamePostSearchEngine.php:69-86 | src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php:186-200 \u2014 These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 15 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/countdown/query/PhabricatorCountdownSearchEngine.php"},"region":{"startLine":65}}}],"partialFingerprints":{"codehealthFindingId/v1":"0b67d0894a729658d258685840e1f03382156c791c21277104324a0ec211a47c"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (11 corresponding lines): src/applications/diffusion/engine/DiffusionCommitHookEngine.php:257-267 | src/applications/diffusion/engine/DiffusionCommitHookEngine.php:300-312 \u2014 These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/engine/DiffusionCommitHookEngine.php"},"region":{"startLine":257}}}],"partialFingerprints":{"codehealthFindingId/v1":"49f2fb117e528a4a87558917b58bc9a65c6b16de276ac6a7f783b3a0665aa967"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 23\u002B corresponding lines): src/applications/herald/adapter/HeraldAdapter.php:207-229 | src/applications/policy/codex/PhabricatorPolicyCodex.php:87-114 | src/applications/system/codex/PhabricatorDestructibleCodex.php:36-63 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 23 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/adapter/HeraldAdapter.php"},"region":{"startLine":207}}}],"partialFingerprints":{"codehealthFindingId/v1":"81677958f7ca4d337834ee1978c969ffb2898ca7b6e87da7bbc18a9ed7827655"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (13 corresponding lines): src/applications/oauthserver/editor/PhabricatorOAuthServerEditor.php:58-70 | src/applications/search/editor/PhabricatorProfileMenuEditor.php:59-73 \u2014 These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/oauthserver/editor/PhabricatorOAuthServerEditor.php"},"region":{"startLine":58}}}],"partialFingerprints":{"codehealthFindingId/v1":"4ca957071ab91e00f77f44fd289c90df4cf7cfe785123ffdb67a6c6d3c9c6ef1"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (20 corresponding lines): src/applications/almanac/xaction/AlmanacInterfacePortTransaction.php:31-50 | src/applications/dashboard/xaction/panel/PhabricatorDashboardQueryPanelLimitTransaction.php:21-40 \u2014 These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/xaction/AlmanacInterfacePortTransaction.php"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"3633ded1e613ee131325828189544d14b021e3c2ba068e66dad0669429140a45"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (12 corresponding lines): src/applications/differential/engine/DifferentialRevisionDraftEngine.php:7-18 | src/applications/diffusion/engine/DiffusionCommitDraftEngine.php:7-18 \u2014 These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/engine/DifferentialRevisionDraftEngine.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"d2094d6e4acbaaf7e8140f5ec02299d83a9f8f85d2eb6bf2b2466e911c94a0fd"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (14 corresponding lines): src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php:19-38 | src/view/page/menu/PhabricatorMainMenuView.php:223-236 \u2014 These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"bbbfdda92c6a79f250772e3c5693af54482d21e3c7fbfb39191535c1e55bd0cc"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (15 corresponding lines): src/infrastructure/daemon/PhutilDaemonHandle.php:475-495 | src/infrastructure/daemon/PhutilDaemonHandle.php:499-513 \u2014 These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/PhutilDaemonHandle.php"},"region":{"startLine":475}}}],"partialFingerprints":{"codehealthFindingId/v1":"5158ca3eba43e90a224f2344b6c4bf1242c2d926e8d2cbd7f389646be1c211ae"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 14\u002B corresponding lines): src/applications/calendar/editor/PhabricatorCalendarEventEditor.php:323-341 | src/applications/countdown/editor/PhabricatorCountdownEditor.php:55-68 | src/applications/slowvote/editor/PhabricatorSlowvoteEditor.php:58-71 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 14 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/editor/PhabricatorCalendarEventEditor.php"},"region":{"startLine":323}}}],"partialFingerprints":{"codehealthFindingId/v1":"f2bec81115054caf9d75f502fecaf1852a7d7ed380b52a37389f64f6cb5c9da8"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (15 corresponding lines): src/applications/passphrase/search/PassphraseCredentialFulltextEngine.php:10-24 | src/applications/phame/search/PhameBlogFulltextEngine.php:10-24 \u2014 These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/passphrase/search/PassphraseCredentialFulltextEngine.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"80ac608a85df5f6bfa1abb00a19310d2cdcfbf72b48f1ec1281af738405d98bd"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (19 corresponding lines): src/applications/people/management/PhabricatorPeopleManagementWorkflow.php:17-36 | src/applications/policy/management/PhabricatorPolicyManagementUnlockWorkflow.php:139-157 \u2014 These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/management/PhabricatorPeopleManagementWorkflow.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"f6573ffaef03d4779d6825299f51ed858364ed8156d2ed81335686217a3f5add"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 17\u002B corresponding lines): src/infrastructure/cache/PhutilKeyValueCacheProfiler.php:42-62 | src/infrastructure/cache/PhutilKeyValueCacheProfiler.php:67-84 | src/infrastructure/cache/PhutilKeyValueCacheProfiler.php:89-105 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 17 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/cache/PhutilKeyValueCacheProfiler.php"},"region":{"startLine":42}}}],"partialFingerprints":{"codehealthFindingId/v1":"70ad1f339555eaf21c325d1a622764367c471f2e4dbd8b3d9b4ca50369ef7938"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 26\u002B corresponding lines): src/applications/config/module/PhabricatorConfigEdgeModule.php:14-40 | src/applications/config/module/PhabricatorConfigRequestExceptionHandlerModule.php:15-40 | src/applications/config/module/PhabricatorConfigSiteModule.php:14-39 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 26 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/module/PhabricatorConfigEdgeModule.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"3c7d5e67ca0a3004888e9859b358ae538b5db5b4ec194448a715c3e81372ae4f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (13 corresponding lines): src/applications/daemon/controller/PhabricatorDaemonBulkJobViewController.php:55-67 | src/applications/phriction/controller/PhrictionDocumentController.php:393-406 \u2014 These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/daemon/controller/PhabricatorDaemonBulkJobViewController.php"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"56ec3be49b49732ac5df79de94830442c226bf8ee4b01dbb1460f07bf8b9514c"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (17 corresponding lines): src/applications/differential/query/DifferentialViewStateQuery.php:30-53 | src/applications/metamta/query/PhabricatorMetaMTAMailPropertiesQuery.php:24-40 \u2014 These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/query/DifferentialViewStateQuery.php"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"42b163d90ffd7ca666afb5ec351ec68d384a6094d0240745b463ff70dfb4a5b7"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (14 corresponding lines): src/applications/policy/query/PhabricatorPolicyQuery.php:149-166 | src/applications/policy/query/PhabricatorPolicyQuery.php:336-349 \u2014 These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/query/PhabricatorPolicyQuery.php"},"region":{"startLine":149}}}],"partialFingerprints":{"codehealthFindingId/v1":"2e86ff977e3179cc752fb536031fc6ecd1f414ae8b18e58e28d44a8beedced25"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (16 corresponding lines): src/applications/settings/setting/PhabricatorOptionGroupSetting.php:47-62 | src/applications/settings/setting/PhabricatorSelectSetting.php:50-66 \u2014 These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/settings/setting/PhabricatorOptionGroupSetting.php"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"5bdb1ea567a6d8d9a70b6995f2e400c031e5db15d04a17e4e8cc0c33fdf14f36"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (10 corresponding lines): src/applications/audit/editor/PhabricatorAuditEditor.php:127-138 | src/applications/differential/editor/DifferentialTransactionEditor.php:288-297 \u2014 These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/editor/PhabricatorAuditEditor.php"},"region":{"startLine":127}}}],"partialFingerprints":{"codehealthFindingId/v1":"fd796b25ed7c6d194b920365a7d39bc74624a37ce7079eb54d7fa5dddada19f5"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (8 members, 23\u002B corresponding lines): src/applications/auth/engine/PhabricatorAuthSessionEngineExtensionModule.php:15-42 | src/applications/search/engineextension/PhabricatorHovercardEngineExtensionModule.php:15-48 | src/applications/search/engineextension/PhabricatorSearchEngineExtensionModule.php:15-48 | src/applications/search/index/PhabricatorFulltextEngineExtensionModule.php:15-37 | src/applications/search/index/PhabricatorIndexEngineExtensionModule.php:15-37 | src/applications/system/engine/PhabricatorDestructionEngineExtensionModule.php:15-37 | src/applications/transactions/engineextension/PhabricatorEditEngineExtensionModule.php:15-45 | src/applications/transactions/engineextension/PhabricatorEditorExtensionModule.php:15-37 \u2014 These 8 members are one piece of code written 8 times and then edited apart: every two of them correspond over at least 23 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 8 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/engine/PhabricatorAuthSessionEngineExtensionModule.php"},"region":{"startLine":15}}}],"partialFingerprints":{"codehealthFindingId/v1":"e2554cf5cf0cdd0fe3fdcbf7c3dadf81cbf31bce30fb03fcd686c443c6c6f12c"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 17\u002B corresponding lines): src/applications/calendar/worker/PhabricatorCalendarImportReloadWorker.php:35-51 | src/applications/harbormaster/worker/HarbormasterTargetWorker.php:25-41 | src/applications/phortune/worker/PhortuneSubscriptionWorker.php:203-219 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 17 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/worker/PhabricatorCalendarImportReloadWorker.php"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"e2b56cc528e0d0eda901f1edb8838455da80e268bbaea9cba6f8a25b81965df0"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (14 corresponding lines): src/applications/config/editor/PhabricatorConfigEditor.php:124-141 | src/applications/config/editor/PhabricatorConfigEditor.php:149-162 \u2014 These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/editor/PhabricatorConfigEditor.php"},"region":{"startLine":124}}}],"partialFingerprints":{"codehealthFindingId/v1":"cab02452635b8eeaf4454cd7484da33e9fb83f4bba9aae438fbc22377f534d96"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (13 corresponding lines): src/applications/fund/xaction/FundInitiativeMerchantTransaction.php:17-36 | src/applications/fund/xaction/FundInitiativeMerchantTransaction.php:40-52 \u2014 These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fund/xaction/FundInitiativeMerchantTransaction.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"91b4b5b8358b592e5419f04eaec2d94c4ea03fe4c93dac004d4850cd321a156a"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (22 corresponding lines): src/applications/herald/engine/HeraldEngine.php:575-596 | src/applications/herald/engine/HeraldEngine.php:605-634 \u2014 These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/engine/HeraldEngine.php"},"region":{"startLine":575}}}],"partialFingerprints":{"codehealthFindingId/v1":"8de7bffd520eb7b7495d8b94cc1487996c34decb3da203e3f3e45d2455b9b329"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (16 corresponding lines): src/applications/people/storage/PhabricatorUserCache.php:124-144 | src/applications/people/storage/PhabricatorUserCache.php:148-163 \u2014 These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/storage/PhabricatorUserCache.php"},"region":{"startLine":124}}}],"partialFingerprints":{"codehealthFindingId/v1":"54f6ed788a3e6b928b9614ee650d2a9481e8c0d8429fcec17f535632f25a796a"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (12 corresponding lines): src/applications/phame/xaction/PhamePostVisibilityTransaction.php:41-57 | src/applications/ponder/xaction/PonderAnswerStatusTransaction.php:30-41 \u2014 These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/xaction/PhamePostVisibilityTransaction.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"e4fd0cdf69a22b7b05992c750bea140a37b22202d86874832aeaff238dc4ac3a"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (5 members, 12\u002B corresponding lines): src/applications/differential/controller/DifferentialInlineCommentEditController.php:19-30 | src/applications/diffusion/controller/DiffusionInlineCommentController.php:19-30 | src/applications/drydock/blueprint/DrydockWorkingCopyBlueprintImplementation.php:457-472 | src/applications/harbormaster/artifact/HarbormasterDrydockLeaseArtifact.php:38-52 | src/applications/harbormaster/artifact/HarbormasterFileArtifact.php:48-62 \u2014 These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 12 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/controller/DifferentialInlineCommentEditController.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"724ab2a00ea345e8124861edee902b009ba8d344ec82ac00fb9b83b1dad7c8f5"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (5 members, 13\u002B corresponding lines): src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php:153-165 | src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php:191-203 | src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php:230-242 | src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php:267-279 | src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php:283-295 \u2014 These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php"},"region":{"startLine":153}}}],"partialFingerprints":{"codehealthFindingId/v1":"250fe4c85a2f4f0abbfc9dc456f8652d5478211319518873ed2cd531643ade84"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (12 corresponding lines): src/applications/drydock/management/DrydockManagementReleaseLeaseWorkflow.php:104-115 | src/applications/drydock/management/DrydockManagementReleaseResourceWorkflow.php:104-115 \u2014 These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/management/DrydockManagementReleaseLeaseWorkflow.php"},"region":{"startLine":104}}}],"partialFingerprints":{"codehealthFindingId/v1":"0047751ebd1b2220e3a2b3889f804bb23c0dba7f56a53b806b8bdb0587c85e6e"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (12 corresponding lines): src/applications/maniphest/relationship/ManiphestTaskCloseAsDuplicateRelationship.php:66-77 | src/applications/maniphest/relationship/ManiphestTaskMergeInRelationship.php:61-73 \u2014 These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/relationship/ManiphestTaskCloseAsDuplicateRelationship.php"},"region":{"startLine":66}}}],"partialFingerprints":{"codehealthFindingId/v1":"4355f6193d13ff77d52a41270e13ff001440452ac21a40fc6c2938f7a6446fd5"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (12 corresponding lines): src/infrastructure/daemon/workers/PhabricatorTriggerDaemon.php:334-349 | src/infrastructure/daemon/workers/PhabricatorTriggerDaemon.php:401-412 \u2014 These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/workers/PhabricatorTriggerDaemon.php"},"region":{"startLine":334}}}],"partialFingerprints":{"codehealthFindingId/v1":"bbbeeeb94308c6dc49192783a1ccb0ff51e59e16859d25adb38d5198bc779da1"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (13 corresponding lines): src/applications/audit/editor/PhabricatorAuditEditor.php:106-120 | src/applications/differential/editor/DifferentialTransactionEditor.php:113-125 \u2014 These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/editor/PhabricatorAuditEditor.php"},"region":{"startLine":106}}}],"partialFingerprints":{"codehealthFindingId/v1":"bbbed19789ec47da79f6d8a74ed63b1b2a7223367bc76f54fb13914892a54641"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (7 members, 13\u002B corresponding lines): src/applications/conpherence/query/ConpherenceThreadSearchEngine.php:79-91 | src/applications/macro/query/PhabricatorMacroSearchEngine.php:109-127 | src/applications/oauthserver/query/PhabricatorOAuthServerClientSearchEngine.php:61-73 | src/applications/owners/query/PhabricatorOwnersPackageSearchEngine.php:103-121 | src/applications/paste/query/PhabricatorPasteSearchEngine.php:107-125 | src/applications/pholio/query/PholioMockSearchEngine.php:67-83 | src/infrastructure/daemon/workers/query/PhabricatorWorkerBulkJobSearchEngine.php:59-71 \u2014 These 7 members are one piece of code written 7 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 7 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/query/ConpherenceThreadSearchEngine.php"},"region":{"startLine":79}}}],"partialFingerprints":{"codehealthFindingId/v1":"11ee15c36c7891d38c4e1b9607290d0d04bdec30f7f5d52690928d9c987639b2"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (15 corresponding lines): src/applications/diffusion/query/blame/DiffusionGitBlameQuery.php:21-35 | src/applications/diffusion/query/blame/DiffusionSvnBlameQuery.php:15-33 \u2014 These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/blame/DiffusionGitBlameQuery.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"f9baae049bbe50c6214612a034c441ee0c8c8212ae6d04bcc60e0e1b71915ce7"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 17\u002B corresponding lines): src/applications/feed/storage/PhabricatorFeedStoryData.php:78-94 | src/applications/owners/storage/PhabricatorOwnersPackage.php:669-685 | src/applications/project/storage/PhabricatorProjectTrigger.php:330-349 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 17 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/feed/storage/PhabricatorFeedStoryData.php"},"region":{"startLine":78}}}],"partialFingerprints":{"codehealthFindingId/v1":"23d63a9d67dbedd10118831911ce392bc1f0cdd3e44500374622cb09831bbf91"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (13 corresponding lines): src/applications/files/format/PhabricatorFileAES256StorageFormat.php:139-151 | src/applications/files/format/PhabricatorFileAES256StorageFormat.php:159-171 \u2014 These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/format/PhabricatorFileAES256StorageFormat.php"},"region":{"startLine":139}}}],"partialFingerprints":{"codehealthFindingId/v1":"e788564f12c9ca289a230845fd1fa310020fdf900774d65742f6aac6786d14f6"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (13 corresponding lines): src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php:101-116 | src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php:131-143 \u2014 These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php"},"region":{"startLine":101}}}],"partialFingerprints":{"codehealthFindingId/v1":"059491707b68b9d82441cd6215d39d06ad7304353f9a497be6a4ba01f5a16c0b"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (10 corresponding lines): src/applications/phurl/storage/PhabricatorPhurlURL.php:32-41 | src/applications/ponder/storage/PonderAnswer.php:28-39 \u2014 These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phurl/storage/PhabricatorPhurlURL.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"f1530a5bc407cee7d726a160c078056e7d327a7aea846e315e94576b56236b47"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (13 corresponding lines): src/applications/transactions/exception/PhabricatorApplicationTransactionNoEffectException.php:11-23 | src/applications/transactions/exception/PhabricatorApplicationTransactionValidationException.php:9-21 \u2014 These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/exception/PhabricatorApplicationTransactionNoEffectException.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"707734e822415587fa7d10e2735c01e7ca0479f3533cae32abd75ba1b9e31980"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 14\u002B corresponding lines): src/applications/auth/query/PhabricatorAuthFactorProviderQuery.php:70-83 | src/applications/auth/query/PhabricatorAuthMessageQuery.php:57-72 | src/applications/calendar/query/PhabricatorCalendarImportQuery.php:70-84 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 14 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/query/PhabricatorAuthFactorProviderQuery.php"},"region":{"startLine":70}}}],"partialFingerprints":{"codehealthFindingId/v1":"c57614d1afdd8eb212207791734ef0a805376671ffdadb8c6fac2387da4adc0c"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (12 corresponding lines): src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php:146-164 | src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php:1742-1753 \u2014 These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php"},"region":{"startLine":146}}}],"partialFingerprints":{"codehealthFindingId/v1":"f52755f1fef79474fd73417e12033e83a6cd36ebed0d10cc48f4f87056d65942"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 13\u002B corresponding lines): src/applications/diffusion/controller/DiffusionController.php:330-348 | src/applications/diffusion/controller/DiffusionController.php:352-364 | src/applications/diffusion/controller/DiffusionController.php:368-380 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionController.php"},"region":{"startLine":330}}}],"partialFingerprints":{"codehealthFindingId/v1":"34370cdb158d88def093dc03374112a10fa8f5b550f2b2096ba5c47e21ba7b3f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 10\u002B corresponding lines): src/applications/files/conduit/FileDownloadConduitAPIMethod.php:30-40 | src/applications/maniphest/conduit/ManiphestInfoConduitAPIMethod.php:40-52 | src/applications/paste/conduit/PasteInfoConduitAPIMethod.php:38-47 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 10 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/conduit/FileDownloadConduitAPIMethod.php"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"4703c367308eb9bc2d13364c815c7266f7eeb99d845c951cf0e9bf0eaae34c4a"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (12 corresponding lines): src/applications/people/engineextension/PeopleHovercardEngineExtension.php:43-57 | src/applications/project/engineextension/PhabricatorProjectHovercardEngineExtension.php:41-52 \u2014 These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/engineextension/PeopleHovercardEngineExtension.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"0a6d9e0bd8c5d2cf4a49f8db0a3a20719f52495e61d7576d709f2e29f7dda82c"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (14 corresponding lines): src/applications/conpherence/view/ConpherenceTransactionView.php:177-190 | src/applications/conpherence/view/ConpherenceTransactionView.php:194-209 \u2014 These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/view/ConpherenceTransactionView.php"},"region":{"startLine":177}}}],"partialFingerprints":{"codehealthFindingId/v1":"6b6edfb24662c6dc1f8b1066378aa2b8a3473f5b86968298590b6dc0d2ce72aa"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (11 corresponding lines): src/applications/differential/storage/DifferentialRevision.php:772-782 | src/applications/differential/storage/DifferentialRevision.php:786-800 \u2014 These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialRevision.php"},"region":{"startLine":772}}}],"partialFingerprints":{"codehealthFindingId/v1":"1988b0e6d23b32d81f794a82c8f5df41c7b7a888e5150965e67d5bc49a182ec9"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 17\u002B corresponding lines): src/applications/diffusion/query/DiffusionCommitRequiredActionResultBucket.php:69-85 | src/applications/diffusion/query/DiffusionCommitRequiredActionResultBucket.php:144-160 | src/applications/diffusion/query/DiffusionCommitRequiredActionResultBucket.php:164-181 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 17 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/DiffusionCommitRequiredActionResultBucket.php"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"9d925975813315c4856bb50993b288ed6e49c9be3198b3f85a1400ff2a147064"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (12 corresponding lines): src/applications/files/phid/PhabricatorFileFilePHIDType.php:32-45 | src/applications/phurl/phid/PhabricatorPhurlURLPHIDType.php:32-43 \u2014 These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/phid/PhabricatorFileFilePHIDType.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"a80f34c18293ee6b2b660a4b264938cc520041c1d1339f87309212c770f8a45c"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (5 members, 11\u002B corresponding lines): src/applications/harbormaster/query/HarbormasterBuildSearchEngine.php:127-138 | src/applications/packages/query/PhabricatorPackagesPackageSearchEngine.php:80-90 | src/applications/packages/query/PhabricatorPackagesPublisherSearchEngine.php:70-81 | src/applications/packages/query/PhabricatorPackagesVersionSearchEngine.php:79-89 | src/applications/project/query/PhabricatorProjectSearchEngine.php:324-336 \u2014 These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/query/HarbormasterBuildSearchEngine.php"},"region":{"startLine":127}}}],"partialFingerprints":{"codehealthFindingId/v1":"cd3eada5ad56ab3c144e97dfa01ed318f9ce3cf0ee04d5738157dc2e2f4d0b02"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (16 corresponding lines): src/applications/metamta/adapter/PhabricatorMailAdapter.php:59-76 | src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php:889-904 \u2014 These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/adapter/PhabricatorMailAdapter.php"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"e3d5db9c88f697c5533d3e8f46f28801830c67abde86a79ac2d448ce0ce7e72a"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 14\u002B corresponding lines): src/applications/project/menuitem/PhabricatorProjectDetailsProfileMenuItem.php:50-65 | src/applications/project/menuitem/PhabricatorProjectReportsProfileMenuItem.php:64-77 | src/applications/project/menuitem/PhabricatorProjectWorkboardProfileMenuItem.php:56-69 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 14 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/menuitem/PhabricatorProjectDetailsProfileMenuItem.php"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"f9d54dc95c452660444be0d70345d001e126a5918faa4a332d5e2a47c64cca63"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (4 members, 11\u002B corresponding lines): src/applications/almanac/xaction/AlmanacDeviceStatusTransaction.php:17-30 | src/applications/auth/xaction/PhabricatorAuthFactorProviderStatusTransaction.php:17-29 | src/applications/calendar/xaction/PhabricatorCalendarExportModeTransaction.php:17-27 | src/applications/herald/xaction/HeraldWebhookStatusTransaction.php:17-27 \u2014 These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/xaction/AlmanacDeviceStatusTransaction.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"8c061875a225e25fc803699609e9424bcaff716b491e25e42088fb99daa0a6a0"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (12 corresponding lines): src/applications/auth/controller/config/PhabricatorAuthProviderViewController.php:108-120 | src/applications/auth/controller/contact/PhabricatorAuthContactNumberViewController.php:68-79 \u2014 These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/config/PhabricatorAuthProviderViewController.php"},"region":{"startLine":108}}}],"partialFingerprints":{"codehealthFindingId/v1":"f714d8af88fa9885bd78713060c3bf2754d452d47c931e7b2d8d6b81094ae8cc"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (4 members, 12\u002B corresponding lines): src/applications/differential/engineextension/DifferentialHovercardEngineExtension.php:22-34 | src/applications/owners/engineextension/PhabricatorOwnersHovercardEngineExtension.php:22-33 | src/applications/people/engineextension/PeopleHovercardEngineExtension.php:21-35 | src/applications/project/engineextension/PhabricatorProjectHovercardEngineExtension.php:21-33 \u2014 These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 12 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/engineextension/DifferentialHovercardEngineExtension.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"936e157dac02517a56ebacd2b67504627d56e7272bc87f7f52b94ee8553fd8e6"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (9 corresponding lines): src/applications/diffusion/query/pathid/DiffusionPathIDQuery.php:89-97 | src/applications/repository/worker/commitchangeparser/PhabricatorRepositorySvnCommitChangeParserWorker.php:780-789 \u2014 These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/pathid/DiffusionPathIDQuery.php"},"region":{"startLine":89}}}],"partialFingerprints":{"codehealthFindingId/v1":"b4a290671ac3152703e54aae0007125836ab6075587e82f89257f78171114b29"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (14 corresponding lines): src/applications/project/xaction/PhabricatorProjectMilestoneTransaction.php:13-28 | src/applications/project/xaction/PhabricatorProjectParentTransaction.php:13-26 \u2014 These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/xaction/PhabricatorProjectMilestoneTransaction.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"334871bd23467857fd4f983b58001964f12d6176aadcf0a14697181f453a4e35"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (19 corresponding lines): src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php:220-238 | src/infrastructure/daemon/workers/query/PhabricatorWorkerLeaseQuery.php:290-312 \u2014 These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php"},"region":{"startLine":220}}}],"partialFingerprints":{"codehealthFindingId/v1":"988ea3c8e162de1c4bf71dd8c1433c2fc1d20fe02915d5f14054d6aca4118675"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (24 corresponding lines): src/view/fuel/FuelHandleListItemView.php:14-42 | src/view/fuel/FuelMapItemView.php:28-51 \u2014 These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/fuel/FuelHandleListItemView.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"41196099563c1c48610f3a8a51264dff2466538d062e7418b57e8566059239ea"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (5 members, 11\u002B corresponding lines): src/applications/almanac/controller/AlmanacNetworkListController.php:37-48 | src/applications/fund/controller/FundInitiativeListController.php:22-36 | src/applications/legalpad/controller/LegalpadDocumentSignatureListController.php:44-58 | src/applications/notification/controller/PhabricatorNotificationListController.php:18-28 | src/applications/search/controller/PhabricatorSearchController.php:100-111 \u2014 These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/controller/AlmanacNetworkListController.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"42988e715fad3fc6ee54a71151520cfdc6ecadaa1e43270e11bc045b7272f350"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (18 corresponding lines): src/applications/auth/controller/PhabricatorAuthController.php:279-296 | src/applications/auth/controller/PhabricatorAuthNeedsApprovalController.php:48-65 \u2014 These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthController.php"},"region":{"startLine":279}}}],"partialFingerprints":{"codehealthFindingId/v1":"e7aef3048fec001a3218104ff34750b17a665a22920cb60b31fd9c9fd8dd18c3"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 16\u002B corresponding lines): src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php:1082-1097 | src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php:1102-1117 | src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php:1317-1332 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 16 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php"},"region":{"startLine":1082}}}],"partialFingerprints":{"codehealthFindingId/v1":"aa5ea52007bcfeea17d4116c3a827e45ac6f37274bbf4577446ab05579de8ecf"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (11 corresponding lines): src/applications/diffusion/controller/DiffusionBrowseController.php:1038-1051 | src/applications/files/controller/PhabricatorFileDropUploadController.php:107-117 \u2014 These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionBrowseController.php"},"region":{"startLine":1038}}}],"partialFingerprints":{"codehealthFindingId/v1":"9a56ce11958571c18b196fcd6167ffeab091f31dc78bab74b4dca7552f1ffee7"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (16 corresponding lines): src/applications/diffusion/data/DiffusionBrowseResultSet.php:130-147 | src/applications/diffusion/view/DiffusionReadmeView.php:33-48 \u2014 These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/data/DiffusionBrowseResultSet.php"},"region":{"startLine":130}}}],"partialFingerprints":{"codehealthFindingId/v1":"d0a421df583c73b72a96c208648292e5604e75107937d4c52caac6b5ad3c75d8"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (12 corresponding lines): src/applications/herald/field/HeraldField.php:258-269 | src/applications/project/engine/PhabricatorProjectEditEngine.php:113-134 \u2014 These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/field/HeraldField.php"},"region":{"startLine":258}}}],"partialFingerprints":{"codehealthFindingId/v1":"3bc209b0f6cd1565186b7e95dbb4499b69468dffb6a6a3b7b40d673157867e6c"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (17 corresponding lines): src/applications/project/menuitem/PhabricatorProjectPointsProfileMenuItem.php:22-40 | src/applications/project/menuitem/PhabricatorProjectReportsProfileMenuItem.php:32-48 \u2014 These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/menuitem/PhabricatorProjectPointsProfileMenuItem.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"43932bf5de570552284e6ab6c260557613cfd373b4aaaa15d231892f12af436b"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (19 corresponding lines): src/applications/auth/factor/PhabricatorAuthFactor.php:201-221 | src/applications/auth/factor/PhabricatorAuthFactor.php:229-247 \u2014 These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/factor/PhabricatorAuthFactor.php"},"region":{"startLine":201}}}],"partialFingerprints":{"codehealthFindingId/v1":"e2114a92d2a9d6c335081b65a5af9568ee32c873d9a52fe13f37fd5520e905f4"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (12 corresponding lines): src/aphront/site/PhabricatorShortSite.php:14-31 | src/aphront/site/PhabricatorResourceSite.php:14-25 \u2014 These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/site/PhabricatorShortSite.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"8d0cb5ad30727cf09128e8660f001ee5231308181dc2d28d7a1870d25a8139be"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (5 members, 11\u002B corresponding lines): src/applications/audit/editor/PhabricatorAuditEditor.php:314-328 | src/applications/differential/editor/DifferentialTransactionEditor.php:508-522 | src/applications/diffusion/query/DiffusionLintCountQuery.php:98-108 | src/applications/pholio/editor/PholioMockEditor.php:183-196 | src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:2755-2768 \u2014 These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/editor/PhabricatorAuditEditor.php"},"region":{"startLine":314}}}],"partialFingerprints":{"codehealthFindingId/v1":"f5a9f8a44e52cd483d1759de14380638edadadecaaa6abb7ee2c03a9afb86505"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (10 corresponding lines): src/applications/differential/storage/DifferentialChangeset.php:725-736 | src/applications/ponder/storage/PonderQuestion.php:260-269 \u2014 These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialChangeset.php"},"region":{"startLine":725}}}],"partialFingerprints":{"codehealthFindingId/v1":"edb632266ac784987a8fabf82704a83a19cb57541529b472854f4d917bb81483"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (12 corresponding lines): src/applications/differential/typeahead/DifferentialRevisionClosedStatusDatasource.php:39-50 | src/applications/differential/typeahead/DifferentialRevisionOpenStatusDatasource.php:39-50 \u2014 These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/typeahead/DifferentialRevisionClosedStatusDatasource.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"1a7078549ca5002d2df63d89bf5c13e0ee461e37c776b702108bdccc80d664d9"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (13 corresponding lines): src/applications/differential/xaction/DifferentialRevisionRequestReviewTransaction.php:138-153 | src/applications/phame/xaction/PhameBlogStatusTransaction.php:31-43 \u2014 These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/xaction/DifferentialRevisionRequestReviewTransaction.php"},"region":{"startLine":138}}}],"partialFingerprints":{"codehealthFindingId/v1":"d6075fbb274df6fc333c232f8b0b0bd07db2808d8c9304eacba50db91a1b0bf0"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (4 members, 11\u002B corresponding lines): src/applications/files/storage/PhabricatorFileChunk.php:86-97 | src/applications/files/storage/PhabricatorFileExternalRequest.php:50-60 | src/applications/paste/storage/PhabricatorPaste.php:203-213 | src/applications/repository/storage/PhabricatorRepositoryGitLFSRef.php:55-65 \u2014 These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/storage/PhabricatorFileChunk.php"},"region":{"startLine":86}}}],"partialFingerprints":{"codehealthFindingId/v1":"ed3dffdb4fc2803dba1ae1869dcf75c27fd7252a8c897ba2234fb78889cd8583"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (8 corresponding lines): src/applications/project/xaction/trigger/PhabricatorProjectTriggerRulesetTransaction.php:66-78 | src/applications/transactions/xaction/PhabricatorEditEngineDefaultTransaction.php:43-50 \u2014 These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/xaction/trigger/PhabricatorProjectTriggerRulesetTransaction.php"},"region":{"startLine":66}}}],"partialFingerprints":{"codehealthFindingId/v1":"a0fed1217c781712f548bdabe4bebc1cd8f575b75cddb245f00d03745090f438"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (14 corresponding lines): src/applications/search/engine/PhabricatorApplicationSearchEngine.php:1618-1633 | src/applications/search/engine/PhabricatorDatasourceEngine.php:39-52 \u2014 These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorApplicationSearchEngine.php"},"region":{"startLine":1618}}}],"partialFingerprints":{"codehealthFindingId/v1":"fdd2624793981faed291c64a20cf1009925c8c5d93e7f0d1e0f0ba7b7e9672be"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 11\u002B corresponding lines): src/applications/herald/typeahead/HeraldRuleTypeDatasource.php:28-39 | src/applications/paste/typeahead/PasteLanguageSelectDatasource.php:29-39 | src/applications/people/typeahead/PhabricatorUserLogTypeDatasource.php:28-40 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/typeahead/HeraldRuleTypeDatasource.php"},"region":{"startLine":28}}}],"partialFingerprints":{"codehealthFindingId/v1":"ede25591a55eb105b20a5bf7c28beb577ae616a77f26ee0b964ef775fbe2d23a"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (14 corresponding lines): src/applications/home/menuitem/PhabricatorHomeLauncherProfileMenuItem.php:49-62 | src/applications/home/menuitem/PhabricatorHomeProfileMenuItem.php:52-65 \u2014 These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/home/menuitem/PhabricatorHomeLauncherProfileMenuItem.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"1e42d2bb28ae8f3775898d6dcd58718af31719f4d5b246d3e04238f7d804728e"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (12 corresponding lines): src/applications/maniphest/typeahead/ManiphestTaskClosedStatusDatasource.php:39-50 | src/applications/maniphest/typeahead/ManiphestTaskOpenStatusDatasource.php:39-50 \u2014 These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/typeahead/ManiphestTaskClosedStatusDatasource.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"6a9b7030d478c61dd372a8761902378255d68e4b63f8a74968e3cfcec1ac0914"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (8 corresponding lines): src/applications/ponder/phid/PonderAnswerPHIDType.php:32-41 | src/applications/harbormaster/phid/HarbormasterBuildPHIDType.php:32-39 \u2014 These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/ponder/phid/PonderAnswerPHIDType.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"abb119be328f085eafb5abac1e88c2605e244e6c7cc042af27d6fca744b1262f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 10\u002B corresponding lines): src/applications/transactions/storage/PhabricatorApplicationTransaction.php:832-841 | src/applications/transactions/storage/PhabricatorModularTransactionType.php:458-470 | src/applications/transactions/storage/PhabricatorModularTransactionType.php:474-486 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 10 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorApplicationTransaction.php"},"region":{"startLine":832}}}],"partialFingerprints":{"codehealthFindingId/v1":"e139957be108bd542e1c43ac8718c34592e130f784460785a85ae15b4fa39b05"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (16 corresponding lines): src/infrastructure/markup/blockrule/PhutilRemarkupNoteBlockRule.php:6-22 | src/infrastructure/markup/blockrule/PhutilRemarkupTableBlockRule.php:6-21 \u2014 These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/blockrule/PhutilRemarkupNoteBlockRule.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"5ae90c64e6c2fece36318c46d845e7fa555b2fd6fb1ed2471a0ce1298b516c74"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (14 corresponding lines): src/applications/auth/adapter/PhutilBitbucketAuthAdapter.php:57-70 | src/applications/auth/adapter/PhutilTwitterAuthAdapter.php:57-72 \u2014 These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/adapter/PhutilBitbucketAuthAdapter.php"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"fa60b23a1b1c1c3d5e41a404512cc15bac06f64048e5bdbd6980342966e55cfa"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (15 corresponding lines): src/applications/differential/controller/DifferentialInlineCommentEditController.php:126-141 | src/applications/diffusion/controller/DiffusionInlineCommentController.php:93-107 \u2014 These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/controller/DifferentialInlineCommentEditController.php"},"region":{"startLine":126}}}],"partialFingerprints":{"codehealthFindingId/v1":"9c1b32d165c7fc06823be7ce449c9c1486bc8a0cbb29262c06f697e860c09859"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (9 corresponding lines): src/applications/diffusion/herald/DiffusionPreCommitContentCommitterPackagesHeraldField.php:13-26 | src/applications/differential/herald/DifferentialRevisionAuthorPackagesHeraldField.php:13-21 \u2014 These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/herald/DiffusionPreCommitContentCommitterPackagesHeraldField.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"947c2074ad5b0741cfb4ac72452c0d055a93d2c66a47217f273b113bbe91e737"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (6 members, 14\u002B corresponding lines): src/applications/maniphest/xaction/ManiphestTaskCoverImageTransaction.php:39-52 | src/applications/maniphest/xaction/ManiphestTaskTitleTransaction.php:48-61 | src/applications/pholio/xaction/PholioMockNameTransaction.php:21-35 | src/applications/pholio/xaction/PholioMockNameTransaction.php:39-54 | src/applications/phriction/xaction/PhrictionDocumentTitleTransaction.php:67-82 | src/applications/project/xaction/PhabricatorProjectNameTransaction.php:49-62 \u2014 These 6 members are one piece of code written 6 times and then edited apart: every two of them correspond over at least 14 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 6 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/xaction/ManiphestTaskCoverImageTransaction.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"4f65ca8a453b92f643deaf9e8525f13988c0aac4e81639839ccb6dc1016273cd"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (16 corresponding lines): src/applications/macro/controller/PhabricatorMacroViewController.php:184-200 | src/applications/phame/controller/blog/PhameBlogManageController.php:221-236 \u2014 These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/macro/controller/PhabricatorMacroViewController.php"},"region":{"startLine":184}}}],"partialFingerprints":{"codehealthFindingId/v1":"0a9f402dc6360a8460ffe8dea291f137469d37701bd1d94e31da34b6cd31226c"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (11 corresponding lines): src/applications/nuance/controller/NuanceItemManageController.php:94-105 | src/applications/harbormaster/controller/HarbormasterUnitMessageViewController.php:107-117 \u2014 These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/controller/NuanceItemManageController.php"},"region":{"startLine":94}}}],"partialFingerprints":{"codehealthFindingId/v1":"c6858bc719e9023f10b4016405e19a1b78fe694d83e8ae294a35e79ff4685fa4"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (24 corresponding lines): src/view/fuel/FuelMapView.php:15-42 | src/view/fuel/FuelGridView.php:15-38 \u2014 These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/fuel/FuelMapView.php"},"region":{"startLine":15}}}],"partialFingerprints":{"codehealthFindingId/v1":"d884d6cd2b479274c8d167931b26b4f3ff2ead33ce4b71496678fcccf7f473eb"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (17 corresponding lines): src/applications/auth/provider/PhabricatorPhabricatorAuthProvider.php:25-44 | src/applications/auth/provider/PhabricatorAsanaAuthProvider.php:12-28 \u2014 These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorPhabricatorAuthProvider.php"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"a8624aac645428b5cda4b231f9743a139d823e32ee3a7aea64b98442c1cfebf8"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (4 members, 11\u002B corresponding lines): src/applications/dashboard/query/PhabricatorDashboardPanelSearchEngine.php:88-105 | src/applications/differential/query/DifferentialChangesetSearchEngine.php:76-86 | src/applications/legalpad/query/LegalpadDocumentSearchEngine.php:91-103 | src/applications/phurl/query/PhabricatorPhurlURLSearchEngine.php:80-91 \u2014 These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/query/PhabricatorDashboardPanelSearchEngine.php"},"region":{"startLine":88}}}],"partialFingerprints":{"codehealthFindingId/v1":"e345e810a73d47941b50ddfed3659dd3ebbbcd00cdadf1031391238c1c865b60"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (10 corresponding lines): src/applications/audit/storage/PhabricatorAuditInlineComment.php:25-34 | src/applications/differential/storage/DifferentialInlineComment.php:17-27 \u2014 These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/storage/PhabricatorAuditInlineComment.php"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"5bcff0b91dff81d7eaad25235224eb4e3085155f4f14e738d1cf5750a5b6bb53"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (12 corresponding lines): src/applications/fact/chart/PhabricatorMaxChartFunction.php:17-28 | src/applications/fact/chart/PhabricatorMinChartFunction.php:17-28 \u2014 These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fact/chart/PhabricatorMaxChartFunction.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"2c26b6901f7f9d2599cdd606fcebe80c1cea45dfb7716e40b9040628a91977f4"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (4 members, 11\u002B corresponding lines): src/applications/fund/query/FundInitiativeSearchEngine.php:32-42 | src/applications/pholio/query/PholioMockSearchEngine.php:36-46 | src/applications/ponder/query/PonderQuestionSearchEngine.php:20-34 | src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php:19-33 \u2014 These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fund/query/FundInitiativeSearchEngine.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"35f79c79ce84ebe58c712ba3e1cbe299764fa92422c94c4f54a2e82878de71f5"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (9 corresponding lines): src/applications/pholio/storage/PholioMock.php:225-235 | src/applications/passphrase/storage/PassphraseCredential.php:166-174 \u2014 These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/pholio/storage/PholioMock.php"},"region":{"startLine":225}}}],"partialFingerprints":{"codehealthFindingId/v1":"55f1fa8a301fe2a6b928948314ebb813f1b980edf014f8e7414afb9c028f1557"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (13 corresponding lines): src/applications/phriction/xaction/PhrictionDocumentContentTransaction.php:17-29 | src/applications/phriction/xaction/PhrictionDocumentDraftTransaction.php:19-36 \u2014 These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/xaction/PhrictionDocumentContentTransaction.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"06622979ed72ac3f5e81caacdb3159032249fa6cf953264041589d95676e0b86"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (10 corresponding lines): src/applications/repository/storage/PhabricatorRepositoryURITransaction.php:22-38 | src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldCredential.php:96-105 \u2014 These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepositoryURITransaction.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"4fb216e8113500765fe8685f4ab5c172160e789842c2c6aa236191259ead4d40"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (12 corresponding lines): src/applications/diffusion/controller/DiffusionRepositoryDefaultController.php:15-32 | src/applications/diffusion/controller/DiffusionRepositoryURIEditController.php:7-18 \u2014 These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRepositoryDefaultController.php"},"region":{"startLine":15}}}],"partialFingerprints":{"codehealthFindingId/v1":"f06208c131d1481b5474f77db8ebd0ab3121926698e063b9eaf9306fb4a8eac7"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (9 corresponding lines): src/applications/audit/editor/PhabricatorAuditEditor.php:33-45 | src/applications/maniphest/editor/ManiphestTransactionEditor.php:18-26 \u2014 These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/editor/PhabricatorAuditEditor.php"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"9282f9d1bb46b839048fa6a0dd9169767d29da0bb791bc465e9c5cc94a4f71ab"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (8 corresponding lines): src/applications/drydock/storage/DrydockBlueprint.php:114-121 | src/applications/drydock/storage/DrydockResource.php:278-286 \u2014 These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/storage/DrydockBlueprint.php"},"region":{"startLine":114}}}],"partialFingerprints":{"codehealthFindingId/v1":"2913e42f9f9e9ea81dc95f3637856db43ec6549e32d0d418b6d914057c7cc1fe"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (4 members, 9\u002B corresponding lines): src/applications/fund/phid/FundBackerPHIDType.php:32-42 | src/applications/macro/phid/PhabricatorMacroMacroPHIDType.php:36-45 | src/applications/phortune/phid/PhortuneCartPHIDType.php:32-40 | src/applications/transactions/phid/PhabricatorEditEngineConfigurationPHIDType.php:32-40 \u2014 These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fund/phid/FundBackerPHIDType.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"7c28b7a9cd96f32be3b4ff7bdffddd3a6d01c4deee584e9735e4011af11f3ec3"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (11 corresponding lines): src/applications/audit/editor/PhabricatorAuditEditor.php:499-509 | src/applications/differential/editor/DifferentialTransactionEditor.php:578-588 \u2014 These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/editor/PhabricatorAuditEditor.php"},"region":{"startLine":499}}}],"partialFingerprints":{"codehealthFindingId/v1":"f6df0d2e62dace0cfc7ff556ba4746cbd8ddf47ade0eb67a30df01eee6ad378a"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (8 corresponding lines): src/applications/diviner/publisher/DivinerStaticPublisher.php:168-177 | src/infrastructure/internationalization/management/PhabricatorInternationalizationManagementExtractWorkflow.php:340-347 \u2014 These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/publisher/DivinerStaticPublisher.php"},"region":{"startLine":168}}}],"partialFingerprints":{"codehealthFindingId/v1":"78ed3937b5e3fe939bdd0aba31722f261999e721006228bb7e809899b70bc0fa"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (5 members, 11\u002B corresponding lines): src/applications/fund/xaction/FundInitiativeNameTransaction.php:17-28 | src/applications/legalpad/xaction/LegalpadDocumentTextTransaction.php:20-30 | src/applications/legalpad/xaction/LegalpadDocumentTitleTransaction.php:20-32 | src/applications/passphrase/xaction/PassphraseCredentialNameTransaction.php:17-28 | src/applications/spaces/xaction/PhabricatorSpacesNamespaceNameTransaction.php:17-28 \u2014 These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fund/xaction/FundInitiativeNameTransaction.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"c82ce05b699291c3d77d6040ec4e90412e987073d9f8c28568268e5fba1ff079"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (9 corresponding lines): src/view/phui/calendar/PHUICalendarDayView.php:361-370 | src/view/phui/calendar/PHUICalendarMonthView.php:615-623 \u2014 These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/calendar/PHUICalendarDayView.php"},"region":{"startLine":361}}}],"partialFingerprints":{"codehealthFindingId/v1":"727c6bbd7f748e9707e73d337640a00ac0aa62498436a24221728b12d9f49774"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (5 corresponding lines): src/applications/doorkeeper/engine/DoorkeeperObjectRef.php:16-21 | src/applications/doorkeeper/storage/DoorkeeperExternalObject.php:71-75 \u2014 These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/engine/DoorkeeperObjectRef.php"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"0945ecea137f29f517cf940423a92ebc48fe4c0eb180c647a4658108b4474537"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (11 corresponding lines): src/applications/people/menuitem/PhabricatorPeoplePictureProfileMenuItem.php:34-46 | src/applications/project/menuitem/PhabricatorProjectPictureProfileMenuItem.php:38-48 \u2014 These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/menuitem/PhabricatorPeoplePictureProfileMenuItem.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"b72fb076044ff4ceabf8d62576eae5f34e97adc06709fc93f9644f15082134b7"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 9\u002B corresponding lines): src/applications/diffusion/query/filecontent/DiffusionGitFileContentQuery.php:6-14 | src/applications/diffusion/query/filecontent/DiffusionMercurialFileContentQuery.php:7-16 | src/applications/diffusion/query/filecontent/DiffusionSvnFileContentQuery.php:6-14 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/filecontent/DiffusionGitFileContentQuery.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"11651a464cd7d0aebba5f55329a32eae231d30a33795ad9001a9a205262045e2"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (8 corresponding lines): src/applications/meta/phid/PhabricatorApplicationApplicationPHIDType.php:37-44 | src/applications/phortune/phid/PhortuneMerchantPHIDType.php:33-40 \u2014 These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/meta/phid/PhabricatorApplicationApplicationPHIDType.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"a293a8ea6323875b1d61944e72a2cea37ec6b3a154f958a3a07cae000945d8a4"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (7 corresponding lines): src/applications/metamta/PhabricatorMetaMTAWorker.php:30-42 | src/infrastructure/daemon/workers/bulk/PhabricatorWorkerBulkJobWorker.php:50-56 \u2014 These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/PhabricatorMetaMTAWorker.php"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"e40295b16b4859006772bba94c2126f531c83aa94451e1ff10e3fc9c26b078a4"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (10 corresponding lines): src/applications/phortune/controller/account/PhortuneAccountChargeListController.php:21-32 | src/applications/phortune/controller/account/PhortuneAccountController.php:42-51 \u2014 These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountChargeListController.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"2e9910c9b3c4a75bbde26a372491f7b1879e59e026596929efb1fc8df98c18ed"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 9\u002B corresponding lines): src/applications/search/storage/PhabricatorNamedQuery.php:49-58 | src/applications/search/storage/PhabricatorNamedQueryConfig.php:51-59 | src/applications/search/storage/PhabricatorProfileMenuItemConfiguration.php:291-299 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/storage/PhabricatorNamedQuery.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"d819af8453abaafd6d539218384b947b6926033325a7acedd3984cfc4773c945"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 7\u002B corresponding lines): src/aphront/response/AphrontResponse.php:25-44 | src/applications/config/schema/PhabricatorConfigServerSchema.php:19-25 | src/applications/config/schema/PhabricatorConfigTableSchema.php:17-23 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 7 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/response/AphrontResponse.php"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"2b90f807bb2ff7241f2efb4406a5b5d4027d18aab00d8485092947011c7b9671"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (10 corresponding lines): src/applications/audit/storage/PhabricatorAuditTransaction.php:36-45 | src/applications/phriction/editor/PhrictionTransactionEditor.php:334-345 \u2014 These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/storage/PhabricatorAuditTransaction.php"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"deada6f7d148beae3839ebd692cf4d4dca39298ecaae86e78a927858c46ccac0"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (8 corresponding lines): src/applications/config/check/PhabricatorSetupCheck.php:135-142 | src/applications/search/compiler/PhutilSearchQueryCompiler.php:57-67 \u2014 These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/check/PhabricatorSetupCheck.php"},"region":{"startLine":135}}}],"partialFingerprints":{"codehealthFindingId/v1":"cd4fa28a878fb4ea9ec059302c63269a27a7bed98517cdba757cee142a11c59a"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (8 corresponding lines): src/applications/countdown/editor/PhabricatorCountdownEditor.php:15-23 | src/applications/project/editor/PhabricatorProjectTransactionEditor.php:34-41 \u2014 These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/countdown/editor/PhabricatorCountdownEditor.php"},"region":{"startLine":15}}}],"partialFingerprints":{"codehealthFindingId/v1":"b40209f72eceb55a9f47eb3da9fe29f56c55c11624251f31c30da5f127832ae7"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (5 corresponding lines): src/applications/differential/customfield/DifferentialRevertPlanField.php:82-86 | src/applications/people/customfield/PhabricatorUserBlurbField.php:67-71 \u2014 These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/customfield/DifferentialRevertPlanField.php"},"region":{"startLine":82}}}],"partialFingerprints":{"codehealthFindingId/v1":"627ee85fdc13cbb200539b0f5d93878985079b2204fdd6a4dd9e3612561715d8"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (8 corresponding lines): src/applications/fund/xaction/FundInitiativeBackerTransaction.php:56-63 | src/applications/fund/xaction/FundInitiativeRefundTransaction.php:48-58 \u2014 These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fund/xaction/FundInitiativeBackerTransaction.php"},"region":{"startLine":56}}}],"partialFingerprints":{"codehealthFindingId/v1":"78084051ede1f841685cc0c4053dbd08cf6b9c45bcf29c5f72ac3f7916927e6b"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (11 corresponding lines): src/applications/packages/query/PhabricatorPackagesPackageQuery.php:87-99 | src/applications/phriction/query/PhrictionDocumentQuery.php:178-188 \u2014 These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/packages/query/PhabricatorPackagesPackageQuery.php"},"region":{"startLine":87}}}],"partialFingerprints":{"codehealthFindingId/v1":"98fdf383289af7bb272a3a4d082cc0cc939398fe5de91be06f0a4833b7f63e9f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (7 corresponding lines): src/applications/differential/customfield/DifferentialProjectReviewersField.php:54-60 | src/applications/differential/customfield/DifferentialReviewersField.php:55-61 \u2014 These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/customfield/DifferentialProjectReviewersField.php"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"feedcb9ba2acb54389b552bd1082f640a9e656af7bc8fa9a3988f4acbaf201d8"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (15 corresponding lines): src/applications/differential/storage/DifferentialReviewer.php:138-152 | src/applications/differential/view/DifferentialReviewersView.php:191-208 \u2014 These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialReviewer.php"},"region":{"startLine":138}}}],"partialFingerprints":{"codehealthFindingId/v1":"d9f9b981bf5ca1b0e5a8fed4aaa53ce1cb2e90aed92d4853311e284c2a66574d"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (8 corresponding lines): src/applications/drydock/worker/DrydockLeaseUpdateWorker.php:714-726 | src/applications/metamta/storage/PhabricatorMetaMTAMail.php:885-892 \u2014 These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/worker/DrydockLeaseUpdateWorker.php"},"region":{"startLine":714}}}],"partialFingerprints":{"codehealthFindingId/v1":"246cff7a30742fc9ef849149955b3ced4c2ca4ae7809913f22c0eb2407e4759f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (10 corresponding lines): src/applications/passphrase/xaction/PassphraseCredentialSecretIDTransaction.php:21-30 | src/applications/repository/xaction/PhabricatorRepositoryActivateTransaction.php:23-39 \u2014 These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/passphrase/xaction/PassphraseCredentialSecretIDTransaction.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"812de3b98242b93ea4a24a65f0c48396a08cfe96e37020ccfbf461032ec607e4"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (14 corresponding lines): src/applications/harbormaster/storage/HarbormasterBuildable.php:259-275 | src/applications/harbormaster/storage/build/HarbormasterBuild.php:354-367 \u2014 These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/storage/HarbormasterBuildable.php"},"region":{"startLine":259}}}],"partialFingerprints":{"codehealthFindingId/v1":"784c94770a699e2c5f7e7ab0550a83494330239318f3c4cd6f48d01ed281740e"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (10 corresponding lines): src/applications/calendar/import/PhabricatorCalendarImportEngine.php:557-570 | src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php:94-103 \u2014 These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/import/PhabricatorCalendarImportEngine.php"},"region":{"startLine":557}}}],"partialFingerprints":{"codehealthFindingId/v1":"03e881b4e619155b1c3a2074e81afed1581042d0e1d49c848e22f6445aada880"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 7\u002B corresponding lines): src/applications/calendar/policyrule/PhabricatorCalendarEventInviteesPolicyRule.php:91-97 | src/applications/project/policyrule/PhabricatorProjectMembersPolicyRule.php:64-70 | src/applications/repository/storage/PhabricatorRepositoryCommit.php:237-244 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 7 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/policyrule/PhabricatorCalendarEventInviteesPolicyRule.php"},"region":{"startLine":91}}}],"partialFingerprints":{"codehealthFindingId/v1":"df6918cb65eff187129ed1798a4dded7f3f2bd93e4d987a58a5ee95458f41015"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (14 corresponding lines): src/applications/doorkeeper/engine/DoorkeeperURIRef.php:71-84 | src/applications/fact/chart/PhabricatorChartFunctionArgument.php:29-46 \u2014 These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/engine/DoorkeeperURIRef.php"},"region":{"startLine":71}}}],"partialFingerprints":{"codehealthFindingId/v1":"7d954b78e3961103a04f66951709dda5611fbdc8d5112c58a6a11c6c999d46e6"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (5 corresponding lines): src/applications/fund/xaction/FundInitiativeBackerTransaction.php:13-17 | src/applications/fund/xaction/FundInitiativeRefundTransaction.php:13-17 \u2014 These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fund/xaction/FundInitiativeBackerTransaction.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"990654f2cbcfb4ee64dea0a23779e55fb368e832f6eeefc0f9515f5e211c8d89"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (6 corresponding lines): src/applications/nuance/phid/NuanceItemPHIDType.php:32-38 | src/applications/project/phid/PhabricatorProjectTriggerPHIDType.php:37-42 \u2014 These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/phid/NuanceItemPHIDType.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"cd6649984f53801b19fc6e200b5811f07a8f5d222c1e2ea803409fddad029183"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (11 corresponding lines): src/applications/search/field/PhabricatorSearchField.php:338-348 | src/applications/transactions/editfield/PhabricatorEditField.php:640-650 \u2014 These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/field/PhabricatorSearchField.php"},"region":{"startLine":338}}}],"partialFingerprints":{"codehealthFindingId/v1":"ebac58fac4ac1eee1b0dbfd0e59450705aa4cb4fc9b6b562bb1042bf84e136f4"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (6 corresponding lines): src/applications/config/custom/PhabricatorConfigOptionType.php:13-18 | src/infrastructure/customfield/config/PhabricatorCustomFieldConfigOptionType.php:10-22 \u2014 These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/custom/PhabricatorConfigOptionType.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"4f737711b9ea29257ba9c0a5b25fd97ac759c0e79a0e229897807cc13009cd91"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 8\u002B corresponding lines): src/applications/macro/storage/PhabricatorFileImageMacro.php:135-142 | src/applications/ponder/storage/PonderAnswer.php:163-170 | src/applications/ponder/storage/PonderQuestion.php:203-210 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 8 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/macro/storage/PhabricatorFileImageMacro.php"},"region":{"startLine":135}}}],"partialFingerprints":{"codehealthFindingId/v1":"3c163153a87c862397958ccd6a1a4b3b91622c8ce36914750d64dc52a2df5832"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (7 corresponding lines): src/applications/maniphest/xaction/ManiphestTaskParentTransaction.php:17-23 | src/applications/phortune/storage/PhortuneAccount.php:170-178 \u2014 These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/xaction/ManiphestTaskParentTransaction.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"a2d88ee99d213e0284edcffb02345e1d85467c8b366e5209b92feb5d74955388"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (7 corresponding lines): src/applications/search/menuitem/PhabricatorApplicationProfileMenuItem.php:24-30 | src/applications/search/menuitem/PhabricatorConpherenceProfileMenuItem.php:67-73 \u2014 These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/menuitem/PhabricatorApplicationProfileMenuItem.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"a033583f7304e8aaa80a80128247dc4167f415b0c58b41aabfccee937f136bb8"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (8 corresponding lines): src/applications/files/builtin/PhabricatorFilesOnDiskBuiltinFile.php:33-40 | src/applications/transactions/editfield/PhabricatorEditField.php:752-761 \u2014 These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/builtin/PhabricatorFilesOnDiskBuiltinFile.php"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"599d0f8cc4c59b66c6760795e7eb3e01d4beec651558d75484acd92e3e6c0611"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (8 corresponding lines): src/applications/herald/action/HeraldAction.php:196-203 | src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldTokenizer.php:129-136 \u2014 These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/action/HeraldAction.php"},"region":{"startLine":196}}}],"partialFingerprints":{"codehealthFindingId/v1":"14ddd3510a54cd7458276e877be854ee929a2fa02048ca843ee4762248f65aac"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (7 corresponding lines): src/view/form/control/AphrontFormDateControl.php:303-311 | src/view/form/control/AphrontFormDateControlValue.php:290-296 \u2014 These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/form/control/AphrontFormDateControl.php"},"region":{"startLine":303}}}],"partialFingerprints":{"codehealthFindingId/v1":"b0360e6dc4e73f9afac3dc3a5163a86e55d5b07985a448d541a43afbd11f727d"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (5 corresponding lines): src/applications/auth/editor/PhabricatorAuthSSHKeyEditor.php:256-267 | src/applications/phortune/editor/PhortuneCartEditor.php:122-126 \u2014 These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/editor/PhabricatorAuthSSHKeyEditor.php"},"region":{"startLine":256}}}],"partialFingerprints":{"codehealthFindingId/v1":"b833273ea53a33ad58b5abe81f1a3355aed8c131601d50628f24d800e21b580c"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (9 corresponding lines): src/applications/conduit/parametertype/ConduitIntListParameterType.php:7-17 | src/applications/conduit/parametertype/ConduitListParameterType.php:57-65 \u2014 These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conduit/parametertype/ConduitIntListParameterType.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"280defbbac77f7192041dda4fcb42e7b22bc8e2ee916ac4697d48be4df81e62f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (5 corresponding lines): src/applications/differential/customfield/DifferentialRepositoryField.php:56-63 | src/applications/repository/customfield/PhabricatorCommitRepositoryField.php:31-35 \u2014 These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/customfield/DifferentialRepositoryField.php"},"region":{"startLine":56}}}],"partialFingerprints":{"codehealthFindingId/v1":"5f90563e463425123515e9467b140aa8cc8619df3241b557952ac0253736223a"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (5 corresponding lines): src/applications/diffusion/query/DiffusionCommitQuery.php:883-889 | src/applications/phid/query/PhabricatorObjectQuery.php:169-173 \u2014 These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/DiffusionCommitQuery.php"},"region":{"startLine":883}}}],"partialFingerprints":{"codehealthFindingId/v1":"110a65940905c9a21692c1143bf076a47cae5fb4fbb3816ba69d3bcd84b1f9ab"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (8 corresponding lines): src/applications/project/policyrule/PhabricatorProjectsAllPolicyRule.php:15-22 | src/applications/project/policyrule/PhabricatorProjectsPolicyRule.php:15-22 \u2014 These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/policyrule/PhabricatorProjectsAllPolicyRule.php"},"region":{"startLine":15}}}],"partialFingerprints":{"codehealthFindingId/v1":"4451165f7d774acf7a42d2be58b21ffd645ee0c6967c036c48cd5be77c49d488"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (10 corresponding lines): src/applications/auth/message/PhabricatorAuthMessageType.php:18-27 | src/applications/transactions/editfield/PhabricatorEditField.php:785-794 \u2014 These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/message/PhabricatorAuthMessageType.php"},"region":{"startLine":18}}}],"partialFingerprints":{"codehealthFindingId/v1":"f5b18fa7176bf53295920f7fb991ef0690be2cbec33520bf96dead4d9f59c97c"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (4 members, 7\u002B corresponding lines): src/applications/dashboard/phid/PhabricatorDashboardDashboardPHIDType.php:32-39 | src/applications/phortune/phid/PhortuneAccountEmailPHIDType.php:32-38 | src/applications/phortune/phid/PhortunePaymentProviderPHIDType.php:32-38 | src/applications/phortune/phid/PhortunePurchasePHIDType.php:32-39 \u2014 These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 7 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/phid/PhabricatorDashboardDashboardPHIDType.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"6702bc5f7f900f316a68d4a038d274c2a77eac231b8aed981adba903095f4716"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (6 corresponding lines): src/applications/herald/storage/HeraldRule.php:89-94 | src/applications/owners/storage/PhabricatorOwnersPackage.php:187-192 \u2014 These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/storage/HeraldRule.php"},"region":{"startLine":89}}}],"partialFingerprints":{"codehealthFindingId/v1":"f8e5fa2116491a5b2bb9a246d89b82ad03ecbf320cc064a4f724f4fcabbceafd"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (6 corresponding lines): src/applications/herald/storage/HeraldRule.php:109-114 | src/applications/owners/storage/PhabricatorOwnersPackage.php:196-201 \u2014 These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/storage/HeraldRule.php"},"region":{"startLine":109}}}],"partialFingerprints":{"codehealthFindingId/v1":"c1a41e37730e6fbf397132f34b60d1bd9248b9a4e6b3778ccb3a0502e2259ded"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (22 corresponding lines): src/infrastructure/daemon/PhutilDaemonHandle.php:33-54 | src/infrastructure/daemon/PhutilDaemonPool.php:20-47 \u2014 These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/PhutilDaemonHandle.php"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"a0c2a2af688d1b81da73a02126afaf68bf5fee0d20ca74350d0e228a87578baa"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 3\u002B corresponding lines): src/applications/almanac/constants/AlmanacDeviceStatus.php:86-88 | src/applications/differential/constants/DifferentialLintStatus.php:53-55 | src/applications/differential/constants/DifferentialUnitStatus.php:53-55 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 3 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/constants/AlmanacDeviceStatus.php"},"region":{"startLine":86}}}],"partialFingerprints":{"codehealthFindingId/v1":"c722642dc29e67bb0050edcfcbb578db53900ba3a11273517fd16249e0e1bda0"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 8\u002B corresponding lines): src/applications/almanac/engineextension/AlmanacPropertiesDestructionEngineExtension.php:22-29 | src/applications/auth/revoker/PhabricatorAuthConduitTokenRevoker.php:34-43 | src/applications/notification/engineextension/PhabricatorNotificationDestructionEngineExtension.php:16-23 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 8 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/engineextension/AlmanacPropertiesDestructionEngineExtension.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"b2dd7a48b6707a55fe6c633ecc18412ec854dac1fad0007a5e5f44d9d1f67209"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (6 corresponding lines): src/applications/differential/mail/DifferentialInlineCommentMailView.php:286-291 | src/infrastructure/lipsum/PhutilContextFreeGrammar.php:85-90 \u2014 These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/mail/DifferentialInlineCommentMailView.php"},"region":{"startLine":286}}}],"partialFingerprints":{"codehealthFindingId/v1":"0b191db631e1df8ea94c936e6e52049b181cdc193a099064b92b24e4b975f4a9"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 7\u002B corresponding lines): src/applications/drydock/xaction/DrydockBlueprintNameTransaction.php:25-33 | src/applications/pholio/xaction/PholioImageFileTransaction.php:75-81 | src/applications/phriction/xaction/PhrictionDocumentMoveToTransaction.php:58-65 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 7 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/xaction/DrydockBlueprintNameTransaction.php"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"84c5b44d0249ed2b73b8adee1a4265cd19ba45d50932edc28aba963b48fa2d5d"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (6 corresponding lines): src/applications/metamta/adapter/PhabricatorMailAmazonSESAdapter.php:38-47 | src/applications/metamta/adapter/PhabricatorMailSendmailAdapter.php:38-43 \u2014 These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/adapter/PhabricatorMailAmazonSESAdapter.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"b1444bdee27f51d7eaf8bc5c771c92b0583295c92b6939572e358886ed921cc9"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (8 corresponding lines): src/applications/phortune/provider/PhortunePaymentProvider.php:77-84 | src/applications/policy/engineextension/PhabricatorPolicySearchEngineExtension.php:34-43 \u2014 These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/provider/PhortunePaymentProvider.php"},"region":{"startLine":77}}}],"partialFingerprints":{"codehealthFindingId/v1":"9df839218d763a3fdc54ce613cb2c83c3800af5e653a3f804d3a804a42882015"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (5 corresponding lines): src/applications/phortune/provider/PhortuneStripePaymentProvider.php:306-310 | src/infrastructure/storage/management/PhabricatorStorageManagementAPI.php:93-100 \u2014 These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/provider/PhortuneStripePaymentProvider.php"},"region":{"startLine":306}}}],"partialFingerprints":{"codehealthFindingId/v1":"d6d292014862cad0a9e66a535283891b2b9203e289e3490098358131c97e21c5"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (5 members, 8\u002B corresponding lines): src/infrastructure/markup/markuprule/PhutilRemarkupBoldRule.php:10-17 | src/infrastructure/markup/markuprule/PhutilRemarkupDelRule.php:10-17 | src/infrastructure/markup/markuprule/PhutilRemarkupHighlightRule.php:10-17 | src/infrastructure/markup/markuprule/PhutilRemarkupItalicRule.php:10-17 | src/infrastructure/markup/markuprule/PhutilRemarkupUnderlineRule.php:10-17 \u2014 These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 8 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/markuprule/PhutilRemarkupBoldRule.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"de36c5b3cc97032268fb8b28602d12d7b7cb22c31314aa244b391f0f13ece192"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (4 corresponding lines): src/applications/calendar/storage/PhabricatorCalendarEventInvitee.php:24-27 | src/applications/calendar/storage/PhabricatorCalendarExternalInvitee.php:15-18 \u2014 These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/storage/PhabricatorCalendarEventInvitee.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"25432ee893f8db94a8e654d6eaa2ed98fef7abb4ebdee3c02b784bbc7d3e0b37"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (9 corresponding lines): src/applications/files/document/PhabricatorJSONDocumentEngine.php:18-29 | src/applications/files/document/PhabricatorRemarkupDocumentEngine.php:17-25 \u2014 These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/document/PhabricatorJSONDocumentEngine.php"},"region":{"startLine":18}}}],"partialFingerprints":{"codehealthFindingId/v1":"b2f3c5908dad721134ffbdb7692d4bfcec4d1b37e74c7369be761b7db61577b3"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (7 members, 4\u002B corresponding lines): src/applications/herald/phid/HeraldWebhookRequestPHIDType.php:32-35 | src/applications/oauthserver/phid/PhabricatorOAuthServerClientAuthorizationPHIDType.php:33-36 | src/applications/repository/phid/PhabricatorRepositoryPullEventPHIDType.php:32-36 | src/applications/repository/phid/PhabricatorRepositoryPushEventPHIDType.php:32-36 | src/applications/repository/phid/PhabricatorRepositoryPushLogPHIDType.php:32-36 | src/applications/repository/phid/PhabricatorRepositorySyncEventPHIDType.php:32-36 | src/applications/settings/phid/PhabricatorUserPreferencesPHIDType.php:32-36 \u2014 These 7 members are one piece of code written 7 times and then edited apart: every two of them correspond over at least 4 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 7 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/phid/HeraldWebhookRequestPHIDType.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"6020f7a6958481c529dc84028bd6f86cc45064aeef710d24038fbab0ae66005a"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 4\u002B corresponding lines): src/applications/people/customfield/PhabricatorUserIconField.php:67-71 | src/applications/people/customfield/PhabricatorUserRealNameField.php:70-74 | src/applications/people/customfield/PhabricatorUserTitleField.php:67-70 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 4 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/customfield/PhabricatorUserIconField.php"},"region":{"startLine":67}}}],"partialFingerprints":{"codehealthFindingId/v1":"446aac43547fc4d5a3ba54a981a87969bc3b38605e964fa7d8951530c5c0466b"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (4 corresponding lines): src/applications/pholio/xaction/PholioImageDescriptionTransaction.php:20-23 | src/applications/pholio/xaction/PholioImageNameTransaction.php:20-23 \u2014 These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/pholio/xaction/PholioImageDescriptionTransaction.php"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"4b125969a98c59249a421a09a04cb16fabf68ff64eb63379d2fbfcf4baae7eb7"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (8 corresponding lines): src/applications/project/state/PhabricatorWorkboardViewState.php:203-211 | src/applications/repository/storage/PhabricatorRepositoryCommitData.php:131-138 \u2014 These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/state/PhabricatorWorkboardViewState.php"},"region":{"startLine":203}}}],"partialFingerprints":{"codehealthFindingId/v1":"1a321fe4558353fee4643295243e694f8d2016e7a51856680247d4adde40467e"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (8 corresponding lines): src/applications/search/field/PhabricatorSearchStringListField.php:26-33 | src/applications/transactions/editfield/PhabricatorTextEditField.php:18-25 \u2014 These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/field/PhabricatorSearchStringListField.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"9e077eaf722546e48724ea8db26b800efef45e82e5143213e18f6a6925595117"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (5 corresponding lines): src/aphront/sprite/PhutilSprite.php:69-73 | src/applications/diviner/publisher/DivinerPublisher.php:50-55 \u2014 These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/sprite/PhutilSprite.php"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"5540790d9c6fa63e81f9c6ea7b12a1f53af96dba06cd2cc0525543319fcf41c4"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (9 corresponding lines): src/applications/draft/storage/PhabricatorVersionedDraft.php:102-110 | src/applications/maniphest/storage/ManiphestNameIndex.php:31-39 \u2014 These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/draft/storage/PhabricatorVersionedDraft.php"},"region":{"startLine":102}}}],"partialFingerprints":{"codehealthFindingId/v1":"26edbcdb0559e54050e829d2e425cad072e996a6c9428e2c6b4599fc238663a7"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 9\u002B corresponding lines): src/applications/fact/chart/PhabricatorConstantChartFunction.php:17-25 | src/applications/fact/chart/PhabricatorScaleChartFunction.php:17-25 | src/applications/fact/chart/PhabricatorShiftChartFunction.php:17-25 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fact/chart/PhabricatorConstantChartFunction.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"c85caf0de8f994fe5d362f7030c0df919b34f3fa9cfb1416c390891867d44cf1"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 6\u002B corresponding lines): src/applications/maniphest/xaction/ManiphestTaskMergedIntoTransaction.php:30-36 | src/applications/project/xaction/PhabricatorProjectColorTransaction.php:25-30 | src/applications/project/xaction/PhabricatorProjectIconTransaction.php:27-34 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 6 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/xaction/ManiphestTaskMergedIntoTransaction.php"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"14c6295888f2fd529667c04b7647f34e9f3e24a03013d0ef90dfac34d636331d"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (6 corresponding lines): src/applications/phriction/xaction/PhrictionDocumentDeleteTransaction.php:13-18 | src/applications/phriction/xaction/PhrictionDocumentMoveAwayTransaction.php:24-30 \u2014 These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/xaction/PhrictionDocumentDeleteTransaction.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"0c857983c81db2c523c77f41e0099680aa1b2bc49e46d60259624b0eac774918"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (6 corresponding lines): src/view/phui/PHUIButtonView.php:137-143 | src/view/phui/PHUIObjectItemView.php:149-154 \u2014 These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIButtonView.php"},"region":{"startLine":137}}}],"partialFingerprints":{"codehealthFindingId/v1":"10a94034c4b1d30702e2bf963f479f3cdc43385fa034a9a9bb15ebedd41fab23"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (5 corresponding lines): src/aphront/httpparametertype/AphrontHTTPParameterType.php:84-88 | src/applications/conduit/parametertype/ConduitParameterType.php:34-38 \u2014 These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/httpparametertype/AphrontHTTPParameterType.php"},"region":{"startLine":84}}}],"partialFingerprints":{"codehealthFindingId/v1":"2fd78f5f7751ae118ae6fe1ca80a92edf6d66a50814e02f7397189de54ea4dfc"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 5\u002B corresponding lines): src/applications/calendar/typeahead/PhabricatorCalendarInviteeViewerFunctionDatasource.php:50-57 | src/applications/differential/typeahead/DifferentialResponsibleViewerFunctionDatasource.php:50-57 | src/applications/people/typeahead/PhabricatorViewerDatasource.php:56-60 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 5 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/typeahead/PhabricatorCalendarInviteeViewerFunctionDatasource.php"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"7cc7a448e4d2aabc3579c247572e8e7aabe92be8c243cfed1b7b48a11b383dcd"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (5 corresponding lines): src/applications/config/custom/PhabricatorConfigJSONOptionType.php:35-40 | src/applications/config/custom/PhabricatorConfigOptionType.php:49-53 \u2014 These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/custom/PhabricatorConfigJSONOptionType.php"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"2ad51d90d29aa3a96a7d7c30f5512a8a0df3f0fb5f57c5aafde46fcf25d9e9cc"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (4 corresponding lines): src/applications/diviner/cache/DivinerAtomCache.php:33-36 | src/applications/diviner/cache/DivinerPublishCache.php:17-20 \u2014 These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/cache/DivinerAtomCache.php"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"79b4765b8c3a8d807e9d9c0241a5043365ae6588328d16c1b2f677db6659985b"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (4 corresponding lines): src/applications/diviner/cache/DivinerAtomCache.php:67-70 | src/applications/diviner/cache/DivinerPublishCache.php:50-53 \u2014 These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/cache/DivinerAtomCache.php"},"region":{"startLine":67}}}],"partialFingerprints":{"codehealthFindingId/v1":"ca2ffc3f130936a42e5f1d3abc0c9e5002c8d039826b8e6a08aa8325c81ad91b"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copies of one member (3 members, 2\u002B corresponding lines): src/applications/slowvote/constants/SlowvotePollResponseVisibility.php:54-55 | src/applications/slowvote/constants/SlowvotePollStatus.php:55-56 | src/applications/slowvote/constants/SlowvotePollVotingMethod.php:53-54 \u2014 These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 2 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/slowvote/constants/SlowvotePollResponseVisibility.php"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"59680897b5daffc4b328fb267bdefb592af8f600819ec4b40d8479baffde1be7"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (4 corresponding lines): src/applications/calendar/storage/PhabricatorCalendarExport.php:53-57 | src/applications/legalpad/storage/LegalpadDocumentSignature.php:55-58 \u2014 These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/storage/PhabricatorCalendarExport.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"486e53528e8955bd3ac54a75e232dad11eee5081c4cbeeb9e951670babb5470b"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (5 corresponding lines): src/applications/feed/story/PhabricatorFeedStory.php:246-250 | src/applications/people/storage/PhabricatorUser.php:350-354 \u2014 These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/feed/story/PhabricatorFeedStory.php"},"region":{"startLine":246}}}],"partialFingerprints":{"codehealthFindingId/v1":"414183d3f5458a7315fc8c5fbbea29eb2d7333038a1b52fe56fc8fa7fb76c6ae"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (4 corresponding lines): src/applications/flag/herald/PhabricatorFlagAddFlagHeraldAction.php:39-42 | src/applications/flag/herald/PhabricatorFlagRemoveFlagHeraldAction.php:37-40 \u2014 These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/flag/herald/PhabricatorFlagAddFlagHeraldAction.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"523c2268b22299d18ef8af8cb269b1e1c1348bd0f0ea30973841010ca4827454"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (8 corresponding lines): src/applications/herald/engine/HeraldEngine.php:114-123 | src/applications/transactions/editengine/PhabricatorEditEngineSubtypeMap.php:33-40 \u2014 These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/engine/HeraldEngine.php"},"region":{"startLine":114}}}],"partialFingerprints":{"codehealthFindingId/v1":"0baea63751afe469df94dd3a56e7a3553ca235a6a8fd8ce2f16fc7b1b5da2a64"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (5 corresponding lines): src/applications/herald/query/HeraldWebhookSearchEngine.php:19-25 | src/applications/phame/query/PhameBlogSearchEngine.php:20-24 \u2014 These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/query/HeraldWebhookSearchEngine.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"ced43015665c665144246ce2a402b811cb7859070aa41a8b17dcaa108a251cb6"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (3 corresponding lines): src/applications/auth/revoker/PhabricatorAuthPasswordRevoker.php:43-45 | src/applications/auth/revoker/PhabricatorAuthSSHRevoker.php:26-29 \u2014 These two members are one piece of code written twice and then edited apart: 3 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/revoker/PhabricatorAuthPasswordRevoker.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"7756d4bf7fb6657f40c5db656d254fa467103c49b7df83556d65b7bfc907bfba"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (6 corresponding lines): src/applications/auth/storage/PhabricatorAuthFactorProvider.php:78-83 | src/applications/calendar/storage/PhabricatorCalendarImport.php:89-94 \u2014 These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/storage/PhabricatorAuthFactorProvider.php"},"region":{"startLine":78}}}],"partialFingerprints":{"codehealthFindingId/v1":"5ab4f24a2545895dd0d594d3114bb9367bb20fb405f74c509e24cc7bf3df3620"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (13 corresponding lines): src/applications/differential/storage/DifferentialViewState.php:118-130 | src/applications/harbormaster/storage/HarbormasterString.php:26-38 \u2014 These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialViewState.php"},"region":{"startLine":118}}}],"partialFingerprints":{"codehealthFindingId/v1":"bbb6e026561eaec175bd6e74df60fdc063e98a5e639ec2b99e20b34c1c3ebf19"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (5 corresponding lines): src/applications/project/xaction/PhabricatorProjectColorTransaction.php:17-21 | src/applications/project/xaction/PhabricatorProjectIconTransaction.php:17-23 \u2014 These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/xaction/PhabricatorProjectColorTransaction.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"baac02d18fd7f6c302d1b86af702d535e7a89475be556e9686038f50f21be73f"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (6 corresponding lines): src/applications/transactions/editengine/PhabricatorEditEngine.php:2741-2746 | src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php:199-204 \u2014 These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editengine/PhabricatorEditEngine.php"},"region":{"startLine":2741}}}],"partialFingerprints":{"codehealthFindingId/v1":"c330181ad8879f5fc1385e305380ef58972d7080457281125381e31c545232d0"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (3 corresponding lines): src/applications/diviner/storage/DivinerLiveBook.php:70-72 | src/applications/project/trigger/PhabricatorProjectTriggerPlaySoundRule.php:91-93 \u2014 These two members are one piece of code written twice and then edited apart: 3 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/storage/DivinerLiveBook.php"},"region":{"startLine":70}}}],"partialFingerprints":{"codehealthFindingId/v1":"a2464c06ed5aa2494bdf4d2d3e43d7a245ec34402e8aa68f5eea442a6a7638a7"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (6 corresponding lines): src/applications/files/storage/PhabricatorFile.php:1279-1285 | src/applications/project/state/PhabricatorWorkboardViewState.php:172-177 \u2014 These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/storage/PhabricatorFile.php"},"region":{"startLine":1279}}}],"partialFingerprints":{"codehealthFindingId/v1":"af19207797d8b0d5b42ce2fbbfabc64b10a11928249459e2f83d469f73860c4e"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (6 corresponding lines): src/applications/people/phid/PhabricatorPeopleUserEmailPHIDType.php:33-38 | src/applications/phid/PhabricatorMetaMTAApplicationEmailPHIDType.php:37-42 \u2014 These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/phid/PhabricatorPeopleUserEmailPHIDType.php"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"83e8c4fa6bcc23931f8eedd5874de3ac772f84ff41db59f218fb3ba210b1bed9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (59\u201360 lines \u00D7 2): src/applications/drydock/management/DrydockManagementReleaseLeaseWorkflow.php:41-99 | src/applications/drydock/management/DrydockManagementReleaseResourceWorkflow.php:39-98 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/management/DrydockManagementReleaseLeaseWorkflow.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"2cf5673246cca3d4571cbde74a115274c0c19d80dfa7a35a11fefaea0fa7a6b2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (56 lines \u00D7 2): src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php:136-191 | src/applications/people/controller/PhabricatorPeopleProfilePictureController.php:173-228 \u2014 before extracting anything, compare \u0060src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php\u0060 and \u0060src/applications/people/controller/PhabricatorPeopleProfilePictureController.php\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 179 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php:136\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php"},"region":{"startLine":136}}}],"partialFingerprints":{"codehealthFindingId/v1":"2e3f06bf39d354b52e9a033f32b119e8f7beb2ceee61c1f5c5aaaa09f671927c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (54 lines \u00D7 2): src/applications/project/engineextension/PhabricatorProjectsCurtainExtension.php:30-83 | src/applications/project/events/PhabricatorProjectUIEventListener.php:56-109 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/engineextension/PhabricatorProjectsCurtainExtension.php"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"6ebc67d986a07ce9acf560b3c4f3b3b293acf0c917b1db17ae06558453d1a412"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (52\u201353 lines \u00D7 2): src/view/page/menu/PhabricatorMainMenuView.php:378-430 | src/view/page/menu/PhabricatorMainMenuView.php:459-510 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/view/page/menu/PhabricatorMainMenuView.php:378\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/page/menu/PhabricatorMainMenuView.php"},"region":{"startLine":378}}}],"partialFingerprints":{"codehealthFindingId/v1":"60ada2ef0629c072f38932fd349b6c9628ad9b2a876f5269a424799c6f497e76"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (52 lines \u00D7 4): src/applications/conpherence/controller/ConpherenceRoomPictureController.php:122-173 | src/applications/phame/controller/blog/PhameBlogProfilePictureController.php:123-174 | src/applications/phortune/controller/merchant/PhortuneMerchantPictureController.php:112-163 | src/applications/project/controller/PhabricatorProjectEditPictureController.php:143-194 \u2014 before extracting anything, compare \u0060src/applications/conpherence/controller/ConpherenceRoomPictureController.php\u0060 and \u0060src/applications/phame/controller/blog/PhameBlogProfilePictureController.php\u0060 as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 217 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/conpherence/controller/ConpherenceRoomPictureController.php:122\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceRoomPictureController.php"},"region":{"startLine":122}}}],"partialFingerprints":{"codehealthFindingId/v1":"e9a0caa4738f9c5b25c8c02c4a63381e12a678c64deae17e125aafd53ac4482d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (52 lines \u00D7 2): src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php:11-62 | src/applications/phame/controller/post/PhamePostHeaderPictureController.php:11-62 \u2014 before extracting anything, compare \u0060src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php\u0060 and \u0060src/applications/phame/controller/post/PhamePostHeaderPictureController.php\u0060 as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 173 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php:11\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"247bba75c1f48b65d5d20c3ad0d6fa2d6ab7208b8642be76e86f1fcede51306f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (50\u201351 lines \u00D7 6): src/applications/conpherence/controller/ConpherenceRoomPictureController.php:132-181 | src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php:150-199 | src/applications/people/controller/PhabricatorPeopleProfilePictureController.php:187-236 | src/applications/phame/controller/blog/PhameBlogProfilePictureController.php:133-182 | src/applications/phortune/controller/merchant/PhortuneMerchantPictureController.php:122-171 | src/applications/project/controller/PhabricatorProjectEditPictureController.php:153-203 \u2014 before extracting anything, compare \u0060src/applications/conpherence/controller/ConpherenceRoomPictureController.php\u0060 and \u0060src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 119 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/conpherence/controller/ConpherenceRoomPictureController.php:132\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceRoomPictureController.php"},"region":{"startLine":132}}}],"partialFingerprints":{"codehealthFindingId/v1":"5fd3d72751ba97b07a7edd399467a6bf53c04b2ce8abf3682e369f7750d11368"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (48 lines \u00D7 2): src/view/page/menu/PhabricatorMainMenuView.php:410-457 | src/view/page/menu/PhabricatorMainMenuView.php:570-617 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/view/page/menu/PhabricatorMainMenuView.php:410\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/page/menu/PhabricatorMainMenuView.php"},"region":{"startLine":410}}}],"partialFingerprints":{"codehealthFindingId/v1":"f1caa6dc63d32cb41b3c5b7e6b9f2e0466ac4446b24bd74f9d4e8996629883df"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (44\u201347 lines \u00D7 2): src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php:328-374 | src/applications/diffusion/xaction/DiffusionCommitAuditorsTransaction.php:186-229 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php:328\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php:375\u0060 calls \u0060getIsCommandeerSideEffect\u0060 and \u0060src/applications/diffusion/xaction/DiffusionCommitAuditorsTransaction.php:230\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php"},"region":{"startLine":328}}}],"partialFingerprints":{"codehealthFindingId/v1":"4d953749bd80550a4e49f2e0cc16a8be5de75fa868c456d18b3b7c9b2d5aa036"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (41 lines \u00D7 6): src/applications/conpherence/controller/ConpherenceRoomPictureController.php:30-70 | src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php:31-71 | src/applications/people/controller/PhabricatorPeopleProfilePictureController.php:33-73 | src/applications/phame/controller/blog/PhameBlogProfilePictureController.php:30-70 | src/applications/phortune/controller/merchant/PhortuneMerchantPictureController.php:20-60 | src/applications/project/controller/PhabricatorProjectEditPictureController.php:32-72 \u2014 before extracting anything, compare \u0060src/applications/conpherence/controller/ConpherenceRoomPictureController.php\u0060 and \u0060src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 119 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/conpherence/controller/ConpherenceRoomPictureController.php:30\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php:29\u0060 calls \u0060getURI\u0060 and \u0060src/applications/conpherence/controller/ConpherenceRoomPictureController.php:28\u0060 does not \u2014 after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceRoomPictureController.php"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"184e1059afd48c1ab8f1c37c8a1740f44991ecf8f35953c5240b1f42a6c5897c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (40\u201341 lines \u00D7 2): src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubIssue.php:33-72 | src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubUser.php:36-76 \u2014 before extracting anything, compare \u0060src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubIssue.php\u0060 and \u0060src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubUser.php\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 92 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubIssue.php:33\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubIssue.php"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"64a76978abf21c7edbf01a229e41f283017c1ff33e68001efff2c34d61a631de"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (41 lines \u00D7 2): src/applications/files/controller/PhabricatorFileDetachController.php:77-117 | src/applications/files/controller/PhabricatorFileUICurtainAttachController.php:90-130 \u2014 before extracting anything, compare \u0060src/applications/files/controller/PhabricatorFileDetachController.php\u0060 and \u0060src/applications/files/controller/PhabricatorFileUICurtainAttachController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 75 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/files/controller/PhabricatorFileDetachController.php:77\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/controller/PhabricatorFileDetachController.php"},"region":{"startLine":77}}}],"partialFingerprints":{"codehealthFindingId/v1":"a1990f6d184a892dd062d4ee50e41c88ade69d650a6ea7fd69979bb65b0d99b4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (41 lines \u00D7 2): src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php:68-108 | src/applications/phame/controller/post/PhamePostHeaderPictureController.php:68-108 \u2014 before extracting anything, compare \u0060src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php\u0060 and \u0060src/applications/phame/controller/post/PhamePostHeaderPictureController.php\u0060 as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 173 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php:68\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php"},"region":{"startLine":68}}}],"partialFingerprints":{"codehealthFindingId/v1":"b118d3650593440eaa4eaa60775d476fe59e96c3e72b0d0947f9cdc930dfe1b7"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (40 lines \u00D7 2): src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php:180-219 | src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php:259-298 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php:180\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php"},"region":{"startLine":180}}}],"partialFingerprints":{"codehealthFindingId/v1":"21e1e488852d2403666ed97e698059be801a3e8fe6800f47a7e384e2371e9a7d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (37\u201338 lines \u00D7 2): src/applications/drydock/controller/DrydockLeaseReleaseController.php:10-46 | src/applications/drydock/controller/DrydockResourceReleaseController.php:10-47 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/controller/DrydockLeaseReleaseController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"0018c751f39aff327d0542e50a5b74c84ade2dd62328f712de9fcb3f45d08e4b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (38 lines \u00D7 2): src/applications/project/controller/PhabricatorProjectColumnBulkEditController.php:14-51 | src/applications/project/controller/PhabricatorProjectColumnBulkMoveController.php:19-56 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/project/controller/PhabricatorProjectColumnBulkMoveController.php:17\u0060 calls \u0060getURIData\u0060 and \u0060src/applications/project/controller/PhabricatorProjectColumnBulkEditController.php:12\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectColumnBulkEditController.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"e854a88ddab740cdda60ce35491be87c58725290f18f497be4aca437e637870a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (37 lines \u00D7 2): src/applications/project/herald/PhabricatorProjectHeraldAction.php:42-78 | src/applications/subscriptions/herald/PhabricatorSubscriptionsHeraldAction.php:83-119 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/project/herald/PhabricatorProjectHeraldAction.php:80\u0060 calls \u0060setMetadataValue\u0060 and \u0060src/applications/subscriptions/herald/PhabricatorSubscriptionsHeraldAction.php:121\u0060 does not \u2014 after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/herald/PhabricatorProjectHeraldAction.php"},"region":{"startLine":42}}}],"partialFingerprints":{"codehealthFindingId/v1":"556e4cef06541bac2829416443a369029b959e305970c52c6141b784acecaddd"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (36 lines \u00D7 2): src/applications/phortune/query/PhortunePaymentMethodQuery.php:45-80 | src/applications/phortune/query/PhortuneSubscriptionQuery.php:58-93 \u2014 before extracting anything, compare \u0060src/applications/phortune/query/PhortunePaymentMethodQuery.php\u0060 and \u0060src/applications/phortune/query/PhortuneSubscriptionQuery.php\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 78 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/query/PhortunePaymentMethodQuery.php"},"region":{"startLine":45}}}],"partialFingerprints":{"codehealthFindingId/v1":"88fafd3b2945202de4b9d83ca2d71ea89598454185ed9b529ea610b0b0ac2b2f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (34\u201335 lines \u00D7 2): src/view/phui/calendar/PHUICalendarDayView.php:215-248 | src/view/phui/calendar/PHUICalendarMonthView.php:463-497 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/calendar/PHUICalendarDayView.php"},"region":{"startLine":215}}}],"partialFingerprints":{"codehealthFindingId/v1":"f30ec1b48a8d4e6262144d67a2adedbd9ea47728cf673d144e03805524c70f69"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (30\u201334 lines \u00D7 2): src/applications/audit/storage/PhabricatorAuditTransactionComment.php:32-65 | src/applications/differential/storage/DifferentialTransactionComment.php:38-67 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/storage/PhabricatorAuditTransactionComment.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"5bd3a6dfe85c3bb36ccd7e74768c7a3af48995088ee2f650cacd657902c0fcd6"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (31\u201332 lines \u00D7 2): src/applications/almanac/controller/AlmanacServiceEditController.php:76-106 | src/applications/calendar/controller/PhabricatorCalendarImportEditController.php:56-87 \u2014 before extracting anything, compare \u0060src/applications/almanac/controller/AlmanacServiceEditController.php\u0060 and \u0060src/applications/calendar/controller/PhabricatorCalendarImportEditController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 58 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/controller/AlmanacServiceEditController.php"},"region":{"startLine":76}}}],"partialFingerprints":{"codehealthFindingId/v1":"63de76d39cf71240cd9caefdf7f5383f2fb61c1c47c8453e1c01754aa704f402"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (32 lines \u00D7 2): src/applications/people/conduit/UserDisableConduitAPIMethod.php:39-70 | src/applications/people/conduit/UserEnableConduitAPIMethod.php:39-70 \u2014 before extracting anything, compare \u0060src/applications/people/conduit/UserDisableConduitAPIMethod.php\u0060 and \u0060src/applications/people/conduit/UserEnableConduitAPIMethod.php\u0060 as WHOLE FILES: 82% of the shorter file\u0027s lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it \u2014 treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/conduit/UserDisableConduitAPIMethod.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"574721951e82f9b796d5e833fa7179391443a3a5019ed4770c827d8f9f5e2ab4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (32 lines \u00D7 2): src/applications/phortune/controller/cart/PhortuneCartViewController.php:77-108 | src/applications/phortune/controller/external/PhortuneExternalOrderController.php:45-76 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phortune/controller/cart/PhortuneCartViewController.php:77\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/cart/PhortuneCartViewController.php"},"region":{"startLine":77}}}],"partialFingerprints":{"codehealthFindingId/v1":"22f94db5eb218eae6636a82ddc2c7fa6446b69fd941b5e8149f55196408c7826"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (31 lines \u00D7 2): src/applications/audit/storage/PhabricatorAuditTransaction.php:168-198 | src/applications/audit/storage/PhabricatorAuditTransaction.php:304-334 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/audit/storage/PhabricatorAuditTransaction.php:168\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/storage/PhabricatorAuditTransaction.php"},"region":{"startLine":168}}}],"partialFingerprints":{"codehealthFindingId/v1":"941a33c392910b8661ed466eff3cb1247bb7f70c587ab54ae520661f91b39e07"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (31 lines \u00D7 2): src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryGitCommitChangeParserWorker.php:195-225 | src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryMercurialCommitChangeParserWorker.php:250-280 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryGitCommitChangeParserWorker.php:195\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryGitCommitChangeParserWorker.php"},"region":{"startLine":195}}}],"partialFingerprints":{"codehealthFindingId/v1":"9c1404277ce31c19fbe3f354c40a9a322b2b170cdeb850d59f947d93d10b8c44"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (29 lines \u00D7 3): src/applications/dashboard/xaction/dashboard/PhabricatorDashboardNameTransaction.php:28-56 | src/applications/dashboard/xaction/panel/PhabricatorDashboardPanelNameTransaction.php:28-56 | src/applications/dashboard/xaction/portal/PhabricatorDashboardPortalNameTransaction.php:28-56 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/xaction/dashboard/PhabricatorDashboardNameTransaction.php"},"region":{"startLine":28}}}],"partialFingerprints":{"codehealthFindingId/v1":"21bd6b4104e60c95ae260848ede6ffd38446cdc1409461634dc62eb5122b28f3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (29 lines \u00D7 2): src/applications/files/document/PhabricatorAudioDocumentEngine.php:38-66 | src/applications/files/document/PhabricatorVideoDocumentEngine.php:44-72 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/document/PhabricatorAudioDocumentEngine.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"23d98c3dbcbc46070621714f4d9e6355be4d27264cf943fc994560a53dc338f4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18\u201329 lines \u00D7 2): src/applications/metamta/controller/PhabricatorMetaMTAMailgunReceiveController.php:75-103 | src/applications/metamta/controller/PhabricatorMetaMTAPostmarkReceiveController.php:82-99 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/metamta/controller/PhabricatorMetaMTAMailgunReceiveController.php:75\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/controller/PhabricatorMetaMTAMailgunReceiveController.php"},"region":{"startLine":75}}}],"partialFingerprints":{"codehealthFindingId/v1":"407a1bd38a1c7300da39f8c8ba0d6e2c882be91f61292a79711e59c9d7c1f4c5"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (25\u201328 lines \u00D7 2): src/applications/config/controller/PhabricatorConfigConsoleController.php:109-136 | src/applications/config/controller/PhabricatorConfigConsoleController.php:308-332 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/config/controller/PhabricatorConfigConsoleController.php:109\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/PhabricatorConfigConsoleController.php"},"region":{"startLine":109}}}],"partialFingerprints":{"codehealthFindingId/v1":"1f74336f224efc10f73d5af7a5f08e935f606d7c3894b695ec6646afff731eb6"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (28 lines \u00D7 2): src/applications/phortune/controller/account/PhortuneAccountManagersController.php:58-85 | src/applications/phortune/controller/merchant/PhortuneMerchantManagersController.php:60-87 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountManagersController.php"},"region":{"startLine":58}}}],"partialFingerprints":{"codehealthFindingId/v1":"280cfca84a4a31c710d46cd66a9c67ee34abb184d3226d237d35d5f975c7a910"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (27 lines \u00D7 2): src/applications/differential/constants/DifferentialConstantsModule.php:114-140 | src/applications/differential/constants/DifferentialConstantsModule.php:148-174 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/constants/DifferentialConstantsModule.php"},"region":{"startLine":114}}}],"partialFingerprints":{"codehealthFindingId/v1":"17d1f6f3ad3ad64c7c0a1228fec1c42895cb29195e7a7c8a9985bbf910727b60"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (27 lines \u00D7 2): src/applications/differential/render/DifferentialChangesetOneUpRenderer.php:96-122 | src/applications/differential/render/DifferentialChangesetOneUpRenderer.php:164-190 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/differential/render/DifferentialChangesetOneUpRenderer.php:96\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetOneUpRenderer.php"},"region":{"startLine":96}}}],"partialFingerprints":{"codehealthFindingId/v1":"c0fc9e2e7c018a3fdca9a76cda17a81cac0e286fd0c6107ff5c6b349952250bd"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (26\u201327 lines \u00D7 2): src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php:31-57 | src/applications/doorkeeper/bridge/DoorkeeperBridgeJIRA.php:26-51 \u2014 before extracting anything, compare \u0060src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php\u0060 and \u0060src/applications/doorkeeper/bridge/DoorkeeperBridgeJIRA.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 62 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"3316d0e304675387b2e6e8954c1ad869e05f344f792b296e3ce82b2ff0f6fe7d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (27 lines \u00D7 2): src/applications/metamta/controller/PhabricatorMetaMTAMailgunReceiveController.php:58-84 | src/applications/metamta/controller/PhabricatorMetaMTASendGridReceiveController.php:37-63 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/controller/PhabricatorMetaMTAMailgunReceiveController.php"},"region":{"startLine":58}}}],"partialFingerprints":{"codehealthFindingId/v1":"5e9ea1e66cfccaa1c948c99b68931f2109e7b677bbbe0f2468bb7e59ca60710c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (27 lines \u00D7 2): src/applications/phortune/codex/PhortunePaymentMethodPolicyCodex.php:7-33 | src/applications/phortune/codex/PhortuneSubscriptionPolicyCodex.php:7-33 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/codex/PhortunePaymentMethodPolicyCodex.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"05a531060faadff9abb2580ebfc87980362c40d09dbc86989a900e41b078ce76"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (27 lines \u00D7 2): src/applications/project/order/PhabricatorProjectColumnPriorityOrder.php:65-91 | src/applications/project/order/PhabricatorProjectColumnStatusOrder.php:72-98 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/project/order/PhabricatorProjectColumnPriorityOrder.php:65\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/order/PhabricatorProjectColumnPriorityOrder.php"},"region":{"startLine":65}}}],"partialFingerprints":{"codehealthFindingId/v1":"f795ec03277cc7b35604c83e31a841b56d20168638046eedc99e261df4ac07c4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18\u201327 lines \u00D7 2): src/infrastructure/daemon/PhutilDaemonHandle.php:445-471 | src/infrastructure/daemon/PhutilDaemonHandle.php:478-495 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/PhutilDaemonHandle.php"},"region":{"startLine":445}}}],"partialFingerprints":{"codehealthFindingId/v1":"cf54bccb9dcca86b87089041fc11366a00b26dc878b2b1b47b2967c3b205d024"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (26 lines \u00D7 5): src/applications/differential/constants/DifferentialConstantsModule.php:68-108 | src/applications/differential/constants/DifferentialConstantsModule.php:116-142 | src/applications/differential/constants/DifferentialConstantsModule.php:150-176 | src/applications/herald/controller/HeraldTranscriptController.php:557-582 | src/applications/herald/controller/HeraldTranscriptController.php:649-677 \u2014 there are 5 copies across 2 file(s) \u2014 more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 5 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/differential/constants/DifferentialConstantsModule.php:68\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/constants/DifferentialConstantsModule.php"},"region":{"startLine":68}}}],"partialFingerprints":{"codehealthFindingId/v1":"ff55f60beacd028e73368efbb9f0edecb306210a6bda014ba68f059278aefecf"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (26 lines \u00D7 2): src/applications/drydock/controller/DrydockLeaseViewController.php:55-80 | src/applications/drydock/controller/DrydockResourceViewController.php:60-85 \u2014 before extracting anything, compare \u0060src/applications/drydock/controller/DrydockLeaseViewController.php\u0060 and \u0060src/applications/drydock/controller/DrydockResourceViewController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/drydock/controller/DrydockResourceViewController.php:87\u0060 calls \u0060buildLeaseBox\u0060 and \u0060src/applications/drydock/controller/DrydockLeaseViewController.php:82\u0060 does not \u2014 after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/controller/DrydockLeaseViewController.php"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"3e6a5788a222b4130557045dcd18bbe44fdfbaae1552b68fc306f0032ef9b37c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (26 lines \u00D7 2): src/applications/phortune/controller/account/PhortuneAccountProfileController.php:108-133 | src/applications/phortune/controller/merchant/PhortuneMerchantOrdersController.php:46-71 \u2014 before extracting anything, compare \u0060src/applications/phortune/controller/account/PhortuneAccountProfileController.php\u0060 and \u0060src/applications/phortune/controller/merchant/PhortuneMerchantOrdersController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 51 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountProfileController.php"},"region":{"startLine":108}}}],"partialFingerprints":{"codehealthFindingId/v1":"4037b9957917a077543a966c6255705339a5b41c7a9c8488cf94c932682169da"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (26 lines \u00D7 2): src/applications/project/controller/PhabricatorProjectProfileController.php:258-283 | src/applications/project/controller/PhabricatorProjectProfileController.php:306-331 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectProfileController.php"},"region":{"startLine":258}}}],"partialFingerprints":{"codehealthFindingId/v1":"aa18eb44229275e1bc898f7fdcf6abfcae243669e3ff16a525a2ca011b822b81"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (25 lines \u00D7 4): src/applications/almanac/xaction/AlmanacDeviceNameTransaction.php:25-49 | src/applications/almanac/xaction/AlmanacNamespaceNameTransaction.php:34-58 | src/applications/almanac/xaction/AlmanacNetworkNameTransaction.php:34-58 | src/applications/almanac/xaction/AlmanacServiceNameTransaction.php:34-58 \u2014 before extracting anything, compare \u0060src/applications/almanac/xaction/AlmanacDeviceNameTransaction.php\u0060 and \u0060src/applications/almanac/xaction/AlmanacNamespaceNameTransaction.php\u0060 as WHOLE FILES: 82% of the shorter file\u0027s lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it \u2014 treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/almanac/xaction/AlmanacDeviceNameTransaction.php:25\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/xaction/AlmanacDeviceNameTransaction.php"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"4681855bac4e89f2cc152f7e5d52e919a5772b2807d47bffebda87ed7071c0f3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (25 lines \u00D7 3): src/applications/packages/storage/PhabricatorPackagesPackage.php:102-126 | src/applications/packages/storage/PhabricatorPackagesPublisher.php:78-102 | src/applications/packages/storage/PhabricatorPackagesVersion.php:62-86 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/packages/storage/PhabricatorPackagesPackage.php"},"region":{"startLine":102}}}],"partialFingerprints":{"codehealthFindingId/v1":"4837cb88cb23f80aab6a592b233defa0ad336043cc23db697c905528422feb70"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (25 lines \u00D7 2): src/applications/auth/controller/contact/PhabricatorAuthContactNumberDisableController.php:41-65 | src/applications/auth/controller/contact/PhabricatorAuthContactNumberPrimaryController.php:52-76 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/auth/controller/contact/PhabricatorAuthContactNumberDisableController.php:41\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/contact/PhabricatorAuthContactNumberDisableController.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"287e0185adcb5231414f185c945b4d3232c6fb88777d3ce57a37d7dfb8211257"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (25 lines \u00D7 2): src/applications/differential/editor/DifferentialTransactionEditor.php:1172-1196 | src/applications/differential/herald/DifferentialReviewersHeraldAction.php:42-66 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/editor/DifferentialTransactionEditor.php"},"region":{"startLine":1172}}}],"partialFingerprints":{"codehealthFindingId/v1":"6f9810c4a05a9e7cce14ceecc6494d0be77d784b1d7c0fb381eed2ef1a19b19e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18\u201325 lines \u00D7 2): src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php:496-520 | src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php:523-540 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php"},"region":{"startLine":496}}}],"partialFingerprints":{"codehealthFindingId/v1":"2b3b31af5f5f5c8dc79ce3abf1134423e9b20d22b4d901528d83b1d644f2cbe8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (25 lines \u00D7 2): src/applications/phame/view/PhameBlogListView.php:41-65 | src/applications/phame/view/PhameDraftListView.php:49-73 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phame/view/PhameBlogListView.php:41\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/phame/view/PhameDraftListView.php:74\u0060 calls \u0060pht\u0060 and \u0060src/applications/phame/view/PhameBlogListView.php:66\u0060 does not \u2014 after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/view/PhameBlogListView.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"0049e263081fbc6216709220d482a88f9c5266ee5012833b92cd2a166a9400b5"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (25 lines \u00D7 2): src/applications/project/controller/PhabricatorProjectBoardViewController.php:423-447 | src/applications/project/controller/PhabricatorProjectBoardViewController.php:526-550 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectBoardViewController.php"},"region":{"startLine":423}}}],"partialFingerprints":{"codehealthFindingId/v1":"9da8335ebbfb6859a70b50820c447b3fcdb661fc80a3e4fab3b9b1ae8bdb494b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (23\u201325 lines \u00D7 2): src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php:389-413 | src/infrastructure/storage/management/workflow/PhabricatorStorageManagementRenamespaceWorkflow.php:182-204 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php:389\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php"},"region":{"startLine":389}}}],"partialFingerprints":{"codehealthFindingId/v1":"0b68c188cca5802f407c09f12036fcb5559aee97f6ac29cc70792d5cc3b16806"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (23\u201324 lines \u00D7 3): src/applications/almanac/query/AlmanacDeviceQuery.php:63-85 | src/applications/almanac/query/AlmanacServiceQuery.php:89-112 | src/applications/calendar/query/PhabricatorCalendarExternalInviteeQuery.php:33-55 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/almanac/query/AlmanacDeviceQuery.php:63\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/query/AlmanacDeviceQuery.php"},"region":{"startLine":63}}}],"partialFingerprints":{"codehealthFindingId/v1":"33e27a7661da066805bb95f5a3da26984fb519b08cde6302593fc3cb1a4c0e61"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (24 lines \u00D7 2): src/applications/almanac/xaction/AlmanacDeviceNameTransaction.php:53-76 | src/applications/almanac/xaction/AlmanacServiceNameTransaction.php:62-85 \u2014 before extracting anything, compare \u0060src/applications/almanac/xaction/AlmanacDeviceNameTransaction.php\u0060 and \u0060src/applications/almanac/xaction/AlmanacServiceNameTransaction.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 58 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/almanac/xaction/AlmanacDeviceNameTransaction.php:53\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/xaction/AlmanacDeviceNameTransaction.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"096532f5538082ec952d18bc646a0dacb678fee9b3f56718a8e7ce4944a75eea"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (24 lines \u00D7 2): src/applications/badges/controller/PhabricatorBadgesViewController.php:96-119 | src/applications/paste/controller/PhabricatorPasteViewController.php:116-139 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/badges/controller/PhabricatorBadgesViewController.php:94\u0060 calls \u0060newCurtainView\u0060 and \u0060src/applications/paste/controller/PhabricatorPasteViewController.php:114\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/controller/PhabricatorBadgesViewController.php"},"region":{"startLine":96}}}],"partialFingerprints":{"codehealthFindingId/v1":"687413388797a71bcf1d910c38447f5c8d9d1e5a83c051c6a26e0f94077dcf47"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (23\u201324 lines \u00D7 2): src/applications/calendar/controller/PhabricatorCalendarImportDropController.php:7-30 | src/applications/xhprof/controller/PhabricatorXHProfDropController.php:7-29 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/calendar/controller/PhabricatorCalendarImportDropController.php:7\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/controller/PhabricatorCalendarImportDropController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"234050da25d27f9649a0b8102bcec46df4c1f6bc77c01bc72df837e6860722fb"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (24 lines \u00D7 2): src/applications/diviner/query/DivinerAtomQuery.php:274-297 | src/applications/diviner/query/DivinerBookQuery.php:73-96 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/query/DivinerAtomQuery.php"},"region":{"startLine":274}}}],"partialFingerprints":{"codehealthFindingId/v1":"1908af8ec0466bb95f9c3da6d25340fe2af558c6faee9dcd88692d6be85b2345"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (24 lines \u00D7 2): src/applications/paste/query/PhabricatorPasteQuery.php:240-263 | src/applications/paste/query/PhabricatorPasteQuery.php:301-324 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/paste/query/PhabricatorPasteQuery.php:240\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/paste/query/PhabricatorPasteQuery.php"},"region":{"startLine":240}}}],"partialFingerprints":{"codehealthFindingId/v1":"150c209b8ba81a4e404417ddc97726511c3775162d1b848f556dd6a6238dd6b2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (24 lines \u00D7 2): src/view/phui/calendar/PHUICalendarDayView.php:261-284 | src/view/phui/calendar/PHUICalendarMonthView.php:424-447 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/view/phui/calendar/PHUICalendarDayView.php:261\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/calendar/PHUICalendarDayView.php"},"region":{"startLine":261}}}],"partialFingerprints":{"codehealthFindingId/v1":"df7575d84ec7976a7330a69df9d0cfeabd2d5d05d60ad8bc30b855445cdf64b3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (23 lines \u00D7 2): src/applications/almanac/query/AlmanacNamespaceSearchEngine.php:66-88 | src/applications/almanac/query/AlmanacNetworkSearchEngine.php:66-88 \u2014 before extracting anything, compare \u0060src/applications/almanac/query/AlmanacNamespaceSearchEngine.php\u0060 and \u0060src/applications/almanac/query/AlmanacNetworkSearchEngine.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 39 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/query/AlmanacNamespaceSearchEngine.php"},"region":{"startLine":66}}}],"partialFingerprints":{"codehealthFindingId/v1":"d352b8faec92598fa24b3236fd7d65d7ff9ac510664ef535dd4bea8d0ac4611f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19\u201323 lines \u00D7 2): src/applications/auth/view/PhabricatorAuthSSHKeyTableView.php:93-115 | src/applications/drydock/controller/DrydockController.php:41-59 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/view/PhabricatorAuthSSHKeyTableView.php"},"region":{"startLine":93}}}],"partialFingerprints":{"codehealthFindingId/v1":"97ea5fc6c91b75d824fec6fd5f68e3128f4cb42102dd5b24b16789a6f7161797"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (21\u201323 lines \u00D7 2): src/applications/dashboard/controller/PhabricatorDashboardConsoleController.php:49-71 | src/applications/drydock/controller/DrydockConsoleController.php:68-88 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/dashboard/controller/PhabricatorDashboardConsoleController.php:49\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/PhabricatorDashboardConsoleController.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"76696fe62e7be999c30981bf39bbc03cacdb2ab9ae4019ba41106c6a37a1fdd9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (23 lines \u00D7 2): src/applications/differential/parser/DifferentialChangesetParser.php:1680-1702 | src/applications/differential/parser/DifferentialChangesetParser.php:1716-1738 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/differential/parser/DifferentialChangesetParser.php:1680\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialChangesetParser.php"},"region":{"startLine":1680}}}],"partialFingerprints":{"codehealthFindingId/v1":"df10ecde74699dd77c5e583832f9575a27b3b4c56162afc5241703ca950a0c4f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (23 lines \u00D7 2): src/applications/diffusion/controller/DiffusionRepositoryURICredentialController.php:7-29 | src/applications/diffusion/controller/DiffusionRepositoryURIDisableController.php:7-29 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRepositoryURICredentialController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"ba1502f4bfb5daaee269e989b89cd83332a2fa18b1056890bc5490f7a289a065"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (23 lines \u00D7 2): src/applications/harbormaster/controller/HarbormasterLintMessagesController.php:11-33 | src/applications/harbormaster/controller/HarbormasterUnitMessageListController.php:11-33 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/harbormaster/controller/HarbormasterLintMessagesController.php:11\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterLintMessagesController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"def283797a3cf58ebbb8d70be20d4040c6d22040f95467bed71e2d51a7b52075"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (22\u201323 lines \u00D7 2): src/applications/macro/xaction/PhabricatorMacroFileTransaction.php:51-73 | src/applications/project/xaction/PhabricatorProjectImageTransaction.php:84-105 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/macro/xaction/PhabricatorMacroFileTransaction.php:51\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/macro/xaction/PhabricatorMacroFileTransaction.php"},"region":{"startLine":51}}}],"partialFingerprints":{"codehealthFindingId/v1":"d6bc4fdffab80aa403a2e8fb584622498b2cdc395c75663016f92274e837c4e4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (23 lines \u00D7 2): src/applications/owners/controller/PhabricatorOwnersDetailController.php:82-104 | src/applications/owners/controller/PhabricatorOwnersDetailController.php:109-131 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/owners/controller/PhabricatorOwnersDetailController.php:82\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/owners/controller/PhabricatorOwnersDetailController.php"},"region":{"startLine":82}}}],"partialFingerprints":{"codehealthFindingId/v1":"2a91fa95620e9d23b843ab0b5d281d409a7484a2e4c53f44eac73fa311f3fae7"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (23 lines \u00D7 2): src/applications/people/controller/PhabricatorPeopleProfileViewController.php:255-277 | src/applications/project/controller/PhabricatorProjectProfileController.php:81-103 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/controller/PhabricatorPeopleProfileViewController.php"},"region":{"startLine":255}}}],"partialFingerprints":{"codehealthFindingId/v1":"e60447b8b45ac3f1835bce2c101e35ce9e68d8edc7d6f4c81b369b4419e330ba"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (22\u201323 lines \u00D7 2): src/applications/phame/query/PhameBlogQuery.php:113-134 | src/applications/phame/query/PhamePostQuery.php:77-99 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/query/PhameBlogQuery.php"},"region":{"startLine":113}}}],"partialFingerprints":{"codehealthFindingId/v1":"5dab43c84a3147de61e00b1bea04e5e2768b8e40164e9c640a3d0f01fdf30e40"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (22\u201323 lines \u00D7 2): src/applications/pholio/controller/PholioInlineController.php:65-86 | src/applications/pholio/view/PholioTransactionView.php:108-130 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/pholio/controller/PholioInlineController.php:65\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/pholio/controller/PholioInlineController.php"},"region":{"startLine":65}}}],"partialFingerprints":{"codehealthFindingId/v1":"6e7295822a4e5a8be65bb93f0f321d8fc533a2259925d6398a265a23044f73cf"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (23 lines \u00D7 2): src/applications/project/controller/PhabricatorProjectBoardDisableController.php:30-52 | src/applications/project/controller/PhabricatorProjectBoardViewController.php:991-1013 \u2014 before extracting anything, compare \u0060src/applications/project/controller/PhabricatorProjectBoardDisableController.php\u0060 and \u0060src/applications/project/controller/PhabricatorProjectBoardViewController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 51 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/project/controller/PhabricatorProjectBoardViewController.php:1014\u0060 calls \u0060addHiddenInput\u0060 and \u0060src/applications/project/controller/PhabricatorProjectBoardDisableController.php:53\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectBoardDisableController.php"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"904fc63526c5ac3a872179a3c434c141583bd4f6553e793695fd4daa9d1a49fe"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (23 lines \u00D7 2): src/applications/search/engine/PhabricatorApplicationSearchEngine.php:747-769 | src/applications/search/field/PhabricatorSearchTokenizerField.php:35-57 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/search/engine/PhabricatorApplicationSearchEngine.php:747\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorApplicationSearchEngine.php"},"region":{"startLine":747}}}],"partialFingerprints":{"codehealthFindingId/v1":"527878c603c7a6c99aac6a366d8b25f49010cbe771f415d959034c7d849e6f20"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19\u201323 lines \u00D7 2): src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementCancelWorkflow.php:20-42 | src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementPriorityWorkflow.php:46-64 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementCancelWorkflow.php:20\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementCancelWorkflow.php"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"a0d6774577831657bf614bd23feebb88adf5231c8615b228748c9b7bd567b24d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14\u201323 lines \u00D7 2): src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php:644-657 | src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php:715-737 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php:644\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php"},"region":{"startLine":644}}}],"partialFingerprints":{"codehealthFindingId/v1":"b845a20bd48e51845ecc2cc15b91e6ea63edb2a9a081738adcf5fbe088901bb0"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (21\u201322 lines \u00D7 3): src/applications/badges/controller/PhabricatorBadgesCommentController.php:38-59 | src/applications/pholio/controller/PholioMockCommentController.php:56-76 | src/applications/slowvote/controller/PhabricatorSlowvoteCommentController.php:38-59 \u2014 before extracting anything, compare \u0060src/applications/badges/controller/PhabricatorBadgesCommentController.php\u0060 and \u0060src/applications/slowvote/controller/PhabricatorSlowvoteCommentController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 44 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/badges/controller/PhabricatorBadgesCommentController.php:38\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/controller/PhabricatorBadgesCommentController.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"9c7e17920a3f147b4ac310ac5e0d674456eaef7968ed2ec0774cdf44985b7b30"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (22 lines \u00D7 3): src/applications/files/management/PhabricatorFilesManagementCycleWorkflow.php:33-54 | src/applications/files/management/PhabricatorFilesManagementEncodeWorkflow.php:73-94 | src/applications/files/management/PhabricatorFilesManagementMigrateWorkflow.php:133-154 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/management/PhabricatorFilesManagementCycleWorkflow.php"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"5c6f2a3007472fc16820c0909ec5525cdce8d7ebb510c3cf728cd11eaa88bb25"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (22 lines \u00D7 2): src/applications/almanac/xaction/AlmanacServiceTypeTransaction.php:32-53 | src/applications/drydock/xaction/DrydockBlueprintTypeTransaction.php:33-54 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/xaction/AlmanacServiceTypeTransaction.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"fb33d6ac8cb8a0fbecf184677b1a22059b33e15c4f957d341697e444d225f168"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (22 lines \u00D7 2): src/applications/audit/storage/PhabricatorAuditTransaction.php:202-223 | src/applications/audit/storage/PhabricatorAuditTransaction.php:336-357 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/audit/storage/PhabricatorAuditTransaction.php:202\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/audit/storage/PhabricatorAuditTransaction.php:200\u0060 calls \u0060renderHandleLink\u0060, \u0060getObjectPHID\u0060 and \u0060src/applications/audit/storage/PhabricatorAuditTransaction.php:334\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/storage/PhabricatorAuditTransaction.php"},"region":{"startLine":202}}}],"partialFingerprints":{"codehealthFindingId/v1":"b3255dfcc3a071f17745fcf8134abf87a4f7cc41cd44e99ff4bf959cc152957a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (22 lines \u00D7 2): src/applications/auth/xaction/PhabricatorAuthFactorProviderDuoCredentialTransaction.php:28-49 | src/applications/auth/xaction/PhabricatorAuthFactorProviderDuoHostnameTransaction.php:27-48 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/auth/xaction/PhabricatorAuthFactorProviderDuoCredentialTransaction.php:28\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/auth/xaction/PhabricatorAuthFactorProviderDuoCredentialTransaction.php:27\u0060 calls \u0060getActor\u0060 and \u0060src/applications/auth/xaction/PhabricatorAuthFactorProviderDuoHostnameTransaction.php:26\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/xaction/PhabricatorAuthFactorProviderDuoCredentialTransaction.php"},"region":{"startLine":28}}}],"partialFingerprints":{"codehealthFindingId/v1":"41ffa892ac27676ac52ec57ce2b2ff7e66df1a2cf61fbcfcd446d1b7f8c457a4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (21\u201322 lines \u00D7 2): src/applications/conpherence/query/ConpherenceThreadSearchEngine.php:351-371 | src/applications/conpherence/query/ConpherenceThreadSearchEngine.php:380-401 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/conpherence/query/ConpherenceThreadSearchEngine.php:380\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/query/ConpherenceThreadSearchEngine.php"},"region":{"startLine":351}}}],"partialFingerprints":{"codehealthFindingId/v1":"4d6a67c8a084740342b7b3af44c75fa7d5633ea28fda03f4190327ca7db47bb0"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19\u201322 lines \u00D7 2): src/applications/differential/controller/DifferentialRevisionViewController.php:779-797 | src/applications/maniphest/controller/ManiphestTaskDetailController.php:316-337 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/controller/DifferentialRevisionViewController.php"},"region":{"startLine":779}}}],"partialFingerprints":{"codehealthFindingId/v1":"791de5107329a68b067a9f515caf5f1f3c511cc8e92259b98961c8d8b7811b66"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (22 lines \u00D7 2): src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php:83-104 | src/applications/doorkeeper/bridge/DoorkeeperBridgeJIRA.php:74-95 \u2014 before extracting anything, compare \u0060src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php\u0060 and \u0060src/applications/doorkeeper/bridge/DoorkeeperBridgeJIRA.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 62 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php:83\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php"},"region":{"startLine":83}}}],"partialFingerprints":{"codehealthFindingId/v1":"5a5b1d1be23e6e8024dae10cd4beb2f4316efa47e409c86b0e11c9e4097f6e33"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (21\u201322 lines \u00D7 2): src/applications/drydock/controller/DrydockBlueprintViewController.php:64-85 | src/applications/drydock/controller/DrydockRepositoryOperationViewController.php:56-76 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/controller/DrydockBlueprintViewController.php"},"region":{"startLine":64}}}],"partialFingerprints":{"codehealthFindingId/v1":"1dd01d575ab5ba8e80dfb1b0eb9034444a2629f722f9874ce6ea4fc48cbe10d6"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (22 lines \u00D7 2): src/applications/drydock/management/DrydockManagementUpdateLeaseWorkflow.php:33-54 | src/applications/drydock/management/DrydockManagementUpdateResourceWorkflow.php:33-54 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/management/DrydockManagementUpdateLeaseWorkflow.php"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"c8215073ac6f64f700cc83595c18d7ab746d3a79ecddd30945e6675f15cd3286"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (22 lines \u00D7 2): src/applications/files/controller/PhabricatorFileDetachController.php:15-36 | src/applications/files/controller/PhabricatorFileUICurtainAttachController.php:26-47 \u2014 before extracting anything, compare \u0060src/applications/files/controller/PhabricatorFileDetachController.php\u0060 and \u0060src/applications/files/controller/PhabricatorFileUICurtainAttachController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 75 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/controller/PhabricatorFileDetachController.php"},"region":{"startLine":15}}}],"partialFingerprints":{"codehealthFindingId/v1":"ae9460af594b7a23a833456ae51f629d8897092dde2f91fec69f7f073eab0eac"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (22 lines \u00D7 2): src/applications/files/management/PhabricatorFilesManagementCycleWorkflow.php:94-115 | src/applications/files/management/PhabricatorFilesManagementEncodeWorkflow.php:116-137 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/files/management/PhabricatorFilesManagementCycleWorkflow.php:94\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/management/PhabricatorFilesManagementCycleWorkflow.php"},"region":{"startLine":94}}}],"partialFingerprints":{"codehealthFindingId/v1":"7fc5d3841ce6c676d603e55b916c826d53e5b0c3a72a5303acd9b28ea8ed9849"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (22 lines \u00D7 2): src/applications/harbormaster/query/HarbormasterBuildArtifactQuery.php:44-65 | src/applications/harbormaster/query/HarbormasterBuildLogQuery.php:31-52 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/query/HarbormasterBuildArtifactQuery.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"97579d77ce2f3728e77ab32014c52353382f73c1bc4535ca995df018b39b6e2f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (22 lines \u00D7 2): src/applications/maniphest/controller/ManiphestTaskDetailController.php:89-110 | src/applications/maniphest/controller/ManiphestTaskGraphController.php:34-55 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/maniphest/controller/ManiphestTaskDetailController.php:89\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/maniphest/controller/ManiphestTaskGraphController.php:33\u0060 calls \u0060setIsStandalone\u0060 and \u0060src/applications/maniphest/controller/ManiphestTaskDetailController.php:88\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/controller/ManiphestTaskDetailController.php"},"region":{"startLine":89}}}],"partialFingerprints":{"codehealthFindingId/v1":"2377bf23eb86261b1a86afaef3c630002b34f648777a92519271ad955da5c18d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (22 lines \u00D7 2): src/applications/phortune/controller/account/PhortuneAccountDetailsController.php:78-99 | src/applications/phortune/controller/merchant/PhortuneMerchantDetailsController.php:125-146 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountDetailsController.php"},"region":{"startLine":78}}}],"partialFingerprints":{"codehealthFindingId/v1":"27eb58828973d7675ae10efd5664c58d86bc9d737747f92af63e6e213cd02efa"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (21\u201322 lines \u00D7 2): src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php:282-303 | src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php:370-390 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php:282\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php"},"region":{"startLine":282}}}],"partialFingerprints":{"codehealthFindingId/v1":"99ad9015159ae6a0dbf4b267ad6ec9fe525d55fe73599f482f840c066ee45455"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (21 lines \u00D7 5): src/applications/almanac/controller/AlmanacDeviceViewController.php:85-105 | src/applications/almanac/controller/AlmanacNamespaceViewController.php:58-78 | src/applications/almanac/controller/AlmanacNetworkViewController.php:59-79 | src/applications/almanac/controller/AlmanacServiceViewController.php:90-110 | src/applications/diffusion/controller/DiffusionIdentityViewController.php:59-79 \u2014 before extracting anything, compare \u0060src/applications/almanac/controller/AlmanacDeviceViewController.php\u0060 and \u0060src/applications/almanac/controller/AlmanacNamespaceViewController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 67 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/controller/AlmanacDeviceViewController.php"},"region":{"startLine":85}}}],"partialFingerprints":{"codehealthFindingId/v1":"1b41e140576e2ad230646ac12861ffd19873f0631fc43e85985524807ddaddb9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18\u201321 lines \u00D7 4): src/applications/transactions/controller/PhabricatorApplicationTransactionCommentHistoryController.php:11-31 | src/applications/transactions/controller/PhabricatorApplicationTransactionCommentQuoteController.php:7-24 | src/applications/transactions/controller/PhabricatorApplicationTransactionCommentRawController.php:7-27 | src/applications/transactions/controller/PhabricatorApplicationTransactionCommentRemoveController.php:7-25 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 4 call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/controller/PhabricatorApplicationTransactionCommentHistoryController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"5249833ca48daa93da20c0b35c1e892dd04155c26fa38d10740a42a52321f0df"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (21 lines \u00D7 3): src/applications/conpherence/query/ConpherenceThreadQuery.php:111-131 | src/applications/phame/query/PhameBlogQuery.php:91-111 | src/applications/phortune/query/PhortuneMerchantQuery.php:54-74 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/conpherence/query/ConpherenceThreadQuery.php:111\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/query/ConpherenceThreadQuery.php"},"region":{"startLine":111}}}],"partialFingerprints":{"codehealthFindingId/v1":"451500c6eaeeac90be605edff9b2fd4d0cd062553347cf02cc1705753b698279"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19\u201321 lines \u00D7 2): src/applications/audit/view/PhabricatorAuditTransactionView.php:57-75 | src/applications/differential/view/DifferentialTransactionView.php:89-109 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/audit/view/PhabricatorAuditTransactionView.php:57\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/view/PhabricatorAuditTransactionView.php"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"be2109ff203a53f8696bb8c1ae00317b6adeed0d1dc27d6c1a4d3d6580f204a2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (21 lines \u00D7 2): src/applications/config/check/PhabricatorMySQLSetupCheck.php:157-177 | src/applications/config/check/PhabricatorMySQLSetupCheck.php:205-225 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/config/check/PhabricatorMySQLSetupCheck.php:157\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/check/PhabricatorMySQLSetupCheck.php"},"region":{"startLine":157}}}],"partialFingerprints":{"codehealthFindingId/v1":"16d34b331024ca7370e8d471e0493d810b38d6b7c3eff23d61f135ea5f110f2f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (21 lines \u00D7 2): src/applications/differential/conduit/DifferentialConduitAPIMethod.php:130-150 | src/infrastructure/customfield/engineextension/PhabricatorCustomFieldSearchEngineExtension.php:86-106 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/conduit/DifferentialConduitAPIMethod.php"},"region":{"startLine":130}}}],"partialFingerprints":{"codehealthFindingId/v1":"1d4c78719c7188076cf08d46ff333a3c101904ee415b3c225108980e0693a974"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19\u201321 lines \u00D7 2): src/applications/differential/engine/DifferentialDiffExtractionEngine.php:55-73 | src/applications/diffusion/controller/DiffusionBrowseController.php:726-746 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/differential/engine/DifferentialDiffExtractionEngine.php:55\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/engine/DifferentialDiffExtractionEngine.php"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"4de40eb33780d184feaed69c340492e56cc57f282448395ef94b891bc59faebc"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (21 lines \u00D7 2): src/applications/diffusion/controller/DiffusionCommitBranchesController.php:20-41 | src/applications/diffusion/controller/DiffusionCommitTagsController.php:20-40 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/diffusion/controller/DiffusionCommitBranchesController.php:20\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionCommitBranchesController.php"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"29fd7e69297d84c4ee82a419f6f66c272b265117d948d49e2583f1b2b963f632"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18\u201321 lines \u00D7 2): src/applications/harbormaster/controller/HarbormasterPlanViewController.php:501-518 | src/applications/owners/controller/PhabricatorOwnersDetailController.php:364-384 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/owners/controller/PhabricatorOwnersDetailController.php:364\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterPlanViewController.php"},"region":{"startLine":501}}}],"partialFingerprints":{"codehealthFindingId/v1":"5a93b5577dbcb318563c5d4323f27d825fce22aa30ec9eafe5f191aa1cc736c5"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (21 lines \u00D7 2): src/applications/herald/controller/HeraldRuleController.php:186-206 | src/applications/herald/controller/HeraldRuleController.php:207-228 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/controller/HeraldRuleController.php"},"region":{"startLine":186}}}],"partialFingerprints":{"codehealthFindingId/v1":"16a3d5de5d01d67fe0bddaaf12459d5406cd4a3b6a984d459e5332c830de82a5"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (21 lines \u00D7 2): src/applications/packages/controller/PhabricatorPackagesPackageViewController.php:107-127 | src/applications/packages/controller/PhabricatorPackagesPublisherViewController.php:104-124 \u2014 before extracting anything, compare \u0060src/applications/packages/controller/PhabricatorPackagesPackageViewController.php\u0060 and \u0060src/applications/packages/controller/PhabricatorPackagesPublisherViewController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 66 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/packages/controller/PhabricatorPackagesPackageViewController.php"},"region":{"startLine":107}}}],"partialFingerprints":{"codehealthFindingId/v1":"7084b2fc42151183fa7803744cb8e5e1a429b4c44bec396e3bbcc993f2446291"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (21 lines \u00D7 2): src/applications/phriction/controller/PhrictionDocumentController.php:139-159 | src/applications/phriction/controller/PhrictionHistoryController.php:116-136 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phriction/controller/PhrictionDocumentController.php:139\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/controller/PhrictionDocumentController.php"},"region":{"startLine":139}}}],"partialFingerprints":{"codehealthFindingId/v1":"e00f6423296fc3aee14249f86d4a9de51c47e9d62afde3f8039851ed1ed2803e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16\u201321 lines \u00D7 2): src/applications/repository/engine/PhabricatorRepositoryEngine.php:92-112 | src/applications/repository/engine/PhabricatorRepositoryRefEngine.php:513-528 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/engine/PhabricatorRepositoryEngine.php"},"region":{"startLine":92}}}],"partialFingerprints":{"codehealthFindingId/v1":"ddaba475414e1d568ebbe4c169190ac6f8edc141592b74e2856b5777d6108f60"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (21 lines \u00D7 2): src/applications/repository/management/PhabricatorRepositoryManagementUnpublishWorkflow.php:211-231 | src/applications/repository/management/PhabricatorRepositoryManagementUnpublishWorkflow.php:234-254 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/repository/management/PhabricatorRepositoryManagementUnpublishWorkflow.php:211\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/management/PhabricatorRepositoryManagementUnpublishWorkflow.php"},"region":{"startLine":211}}}],"partialFingerprints":{"codehealthFindingId/v1":"8dfeaf625fa12c7163ca0e0446f829f927d91938783accb6dba891419500d12e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (20\u201321 lines \u00D7 2): src/applications/tokens/controller/PhabricatorTokenGivenController.php:57-76 | src/applications/tokens/controller/PhabricatorTokenLeaderController.php:40-60 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/tokens/controller/PhabricatorTokenGivenController.php:57\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/tokens/controller/PhabricatorTokenGivenController.php"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"e14f05835b737e52b62cf86ad89d5e3d630cc2f6dce17bca98da189b2ce598ac"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (20 lines \u00D7 13): src/applications/calendar/query/PhabricatorCalendarExportQuery.php:44-63 | src/applications/calendar/query/PhabricatorCalendarImportQuery.php:38-57 | src/applications/countdown/query/PhabricatorCountdownQuery.php:38-57 | src/applications/files/query/PhabricatorFileQuery.php:399-418 | src/applications/herald/query/HeraldRuleQuery.php:203-222 | src/applications/macro/query/PhabricatorMacroQuery.php:106-125 | src/applications/paste/query/PhabricatorPasteQuery.php:106-125 | src/applications/pholio/query/PholioMockQuery.php:74-93 | src/applications/phurl/query/PhabricatorPhurlURLQuery.php:56-75 | src/applications/ponder/query/PonderAnswerQuery.php:34-53 | src/applications/ponder/query/PonderQuestionQuery.php:54-73 | src/applications/slowvote/query/PhabricatorSlowvoteQuery.php:119-138 | src/infrastructure/daemon/workers/query/PhabricatorWorkerBulkJobQuery.php:60-79 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 13 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 13 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/query/PhabricatorCalendarExportQuery.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"a4ce19980ee10fae81855a8108845b3a39bb242ac73ec80a4ae4409ab0430a2d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (20 lines \u00D7 7): src/applications/auth/query/PhabricatorAuthFactorProviderQuery.php:38-57 | src/applications/dashboard/query/PhabricatorDashboardPortalQuery.php:32-51 | src/applications/dashboard/query/PhabricatorDashboardQuery.php:60-79 | src/applications/drydock/query/DrydockLeaseQuery.php:125-144 | src/applications/harbormaster/query/HarbormasterBuildPlanQuery.php:76-95 | src/applications/herald/query/HeraldWebhookQuery.php:32-51 | src/applications/nuance/query/NuanceItemQuery.php:147-166 \u2014 before extracting anything, compare \u0060src/applications/auth/query/PhabricatorAuthFactorProviderQuery.php\u0060 and \u0060src/applications/herald/query/HeraldWebhookQuery.php\u0060 as WHOLE FILES: 83% of the shorter file\u0027s lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it \u2014 treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/query/PhabricatorAuthFactorProviderQuery.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"63d84c0d8a47e1dc27e6fac4061de8808c08dc6d4a588ec637e6535558b19a10"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (20 lines \u00D7 6): src/applications/repository/query/PhabricatorRepositoryPullEventQuery.php:82-101 | src/applications/repository/query/PhabricatorRepositoryPushEventQuery.php:83-102 | src/applications/repository/query/PhabricatorRepositoryPushLogQuery.php:91-110 | src/applications/repository/query/PhabricatorRepositoryRefCursorQuery.php:95-114 | src/applications/repository/query/PhabricatorRepositorySyncEventQuery.php:69-88 | src/applications/repository/query/PhabricatorRepositoryURIQuery.php:40-59 \u2014 before extracting anything, compare \u0060src/applications/repository/query/PhabricatorRepositoryPullEventQuery.php\u0060 and \u0060src/applications/repository/query/PhabricatorRepositorySyncEventQuery.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 50 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/query/PhabricatorRepositoryPullEventQuery.php"},"region":{"startLine":82}}}],"partialFingerprints":{"codehealthFindingId/v1":"8fb48f4e1a793f5426c5acf64477f577cb565961ad65aa27d29c440fb9056514"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (20 lines \u00D7 5): src/applications/auth/query/PhabricatorAuthContactNumberQuery.php:50-69 | src/applications/auth/query/PhabricatorAuthPasswordQuery.php:44-63 | src/applications/auth/query/PhabricatorAuthSSHKeyQuery.php:80-99 | src/applications/drydock/query/DrydockRepositoryOperationQuery.php:126-145 | src/applications/transactions/query/PhabricatorApplicationTransactionQuery.php:191-210 \u2014 before extracting anything, compare \u0060src/applications/auth/query/PhabricatorAuthPasswordQuery.php\u0060 and \u0060src/applications/auth/query/PhabricatorAuthSSHKeyQuery.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 45 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/auth/query/PhabricatorAuthSSHKeyQuery.php:102\u0060 calls \u0060array\u0060, \u0060foreach\u0060 and \u0060src/applications/auth/query/PhabricatorAuthContactNumberQuery.php:72\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/query/PhabricatorAuthContactNumberQuery.php"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"6b75a75f1b44e7b4e29d15728b740a0eefd8958f3c56167702b1e498b1e0759a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19\u201320 lines \u00D7 5): src/applications/guides/module/PhabricatorGuideInstallModule.php:32-50 | src/applications/guides/module/PhabricatorGuideInstallModule.php:89-107 | src/applications/guides/module/PhabricatorGuideInstallModule.php:118-136 | src/applications/guides/module/PhabricatorGuideInstallModule.php:142-161 | src/applications/guides/module/PhabricatorGuideQuickStartModule.php:86-104 \u2014 there are 5 copies across 2 file(s) \u2014 more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 5 sites; resolving a subset leaves the remainder to drift apart. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/guides/module/PhabricatorGuideInstallModule.php:52\u0060 calls \u0060id\u0060, \u0060PhabricatorAuthProviderConfigQuery\u0060, \u0060setViewer\u0060 and \u0060src/applications/guides/module/PhabricatorGuideInstallModule.php:110\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/guides/module/PhabricatorGuideInstallModule.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"554c829e7a8a2d70614c7adc36b01fe6aa016d61eabef736cdc640cdfc3d48f8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (20 lines \u00D7 4): src/applications/auth/query/PhabricatorAuthChallengeQuery.php:46-65 | src/applications/auth/query/PhabricatorAuthFactorConfigQuery.php:44-63 | src/applications/auth/query/PhabricatorExternalAccountQuery.php:148-167 | src/applications/settings/query/PhabricatorUserPreferencesQuery.php:149-168 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/query/PhabricatorAuthChallengeQuery.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"120c3302494682c49f6ccb0d823161580c3c9f0eceb1952ab0c42b626c22b1f1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (20 lines \u00D7 4): src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php:90-109 | src/applications/people/controller/PhabricatorPeopleProfilePictureController.php:101-120 | src/applications/phame/controller/blog/PhameBlogProfilePictureController.php:102-121 | src/applications/project/controller/PhabricatorProjectEditPictureController.php:106-125 \u2014 before extracting anything, compare \u0060src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php\u0060 and \u0060src/applications/people/controller/PhabricatorPeopleProfilePictureController.php\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 179 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php"},"region":{"startLine":90}}}],"partialFingerprints":{"codehealthFindingId/v1":"bcbb2108cbc73dc8dd09af535a84e432d6df1ff547bd2f3ed494df77da502740"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19\u201320 lines \u00D7 3): src/applications/passphrase/controller/PassphraseCredentialDestroyController.php:8-27 | src/applications/passphrase/controller/PassphraseCredentialLockController.php:8-27 | src/applications/passphrase/controller/PassphraseCredentialPublicController.php:8-26 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/passphrase/controller/PassphraseCredentialDestroyController.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"3e2d7b3f569d16c4a90e95eb72af12b146626d69c6abd91b03ff6e533dff3ce1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18\u201320 lines \u00D7 3): src/applications/project/controller/PhabricatorProjectMembersAddController.php:41-60 | src/applications/project/controller/PhabricatorProjectMembersRemoveController.php:42-61 | src/applications/project/controller/PhabricatorProjectSilenceController.php:47-64 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/project/controller/PhabricatorProjectMembersAddController.php:41\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectMembersAddController.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"2fd15b0f552b6d9193045a06245c8aba82e92dd52e49feac50a2f6c78f2ac265"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19\u201320 lines \u00D7 2): src/applications/almanac/xaction/AlmanacBindingServiceTransaction.php:43-61 | src/applications/almanac/xaction/AlmanacInterfaceDeviceTransaction.php:52-71 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/almanac/xaction/AlmanacBindingServiceTransaction.php:43\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/xaction/AlmanacBindingServiceTransaction.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"d142472e6503955e46d2a860bc4c46ee36f31976700ca61fdee3183f05a1612f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18\u201320 lines \u00D7 2): src/applications/auth/controller/PhabricatorAuthOneTimeLoginController.php:240-257 | src/applications/auth/controller/PhabricatorAuthSetExternalController.php:9-28 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthOneTimeLoginController.php"},"region":{"startLine":240}}}],"partialFingerprints":{"codehealthFindingId/v1":"b75bb9bca5ff446298a14edf37ac35d33920cefbc7179f7894081a2b41c71a14"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (20 lines \u00D7 2): src/applications/dashboard/install/PhabricatorDashboardPortalInstallWorkflow.php:39-58 | src/applications/dashboard/install/PhabricatorDashboardProjectInstallWorkflow.php:40-59 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/dashboard/install/PhabricatorDashboardPortalInstallWorkflow.php:39\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/install/PhabricatorDashboardPortalInstallWorkflow.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"8f2ad86338716bf6670537b0ac8ded079e059cb15661fd0bcf29dcfa1d62eb9e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19\u201320 lines \u00D7 2): src/applications/drydock/controller/DrydockBlueprintViewController.php:162-180 | src/applications/drydock/controller/DrydockBlueprintViewController.php:227-246 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/controller/DrydockBlueprintViewController.php"},"region":{"startLine":162}}}],"partialFingerprints":{"codehealthFindingId/v1":"2d19f6cef0c46bc235ac98058fe8e4266da80082846e37231f3ef48a7689fea3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (20 lines \u00D7 2): src/applications/packages/xaction/package/PhabricatorPackagesPackagePublisherTransaction.php:40-59 | src/applications/packages/xaction/version/PhabricatorPackagesVersionPackageTransaction.php:39-58 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/packages/xaction/package/PhabricatorPackagesPackagePublisherTransaction.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"fc070cfbd7d6dc229053c7498278588855c12c0c47bddd36f89198056c08083d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (20 lines \u00D7 2): src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php:103-122 | src/applications/phame/controller/blog/PhameBlogProfilePictureController.php:204-223 \u2014 before extracting anything, compare \u0060src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php\u0060 and \u0060src/applications/phame/controller/blog/PhameBlogProfilePictureController.php\u0060 as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 135 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php:103\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php"},"region":{"startLine":103}}}],"partialFingerprints":{"codehealthFindingId/v1":"594ed1a5c5fc31f369964d0c6db17e72b77d795418741bad16feae69619c70b6"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19\u201320 lines \u00D7 2): src/applications/ponder/controller/PonderAnswerCommentController.php:39-58 | src/applications/ponder/controller/PonderQuestionCommentController.php:36-54 \u2014 before extracting anything, compare \u0060src/applications/ponder/controller/PonderAnswerCommentController.php\u0060 and \u0060src/applications/ponder/controller/PonderQuestionCommentController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 42 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/ponder/controller/PonderAnswerCommentController.php:39\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/ponder/controller/PonderAnswerCommentController.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"0220de231ebcf24ed1533bc6854f6f3f5eb4813c1209fec333fc0f2f7773e362"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19\u201320 lines \u00D7 2): src/applications/project/controller/PhabricatorProjectBoardImportController.php:7-25 | src/applications/project/controller/PhabricatorProjectBoardReorderController.php:7-26 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectBoardImportController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"fa36f2ff04a2b6df881579f7a319f9726df977c2b77d62ec7d78e7aeb7fe839f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (20 lines \u00D7 2): src/applications/project/order/PhabricatorProjectColumnAuthorOrder.php:112-131 | src/applications/project/order/PhabricatorProjectColumnOwnerOrder.php:148-167 \u2014 before extracting anything, compare \u0060src/applications/project/order/PhabricatorProjectColumnAuthorOrder.php\u0060 and \u0060src/applications/project/order/PhabricatorProjectColumnOwnerOrder.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 50 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/order/PhabricatorProjectColumnAuthorOrder.php"},"region":{"startLine":112}}}],"partialFingerprints":{"codehealthFindingId/v1":"735d35d7216f4b224316da94a1ee19d6f5259ff7cd79710040fcbda89ff453fb"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (20 lines \u00D7 2): src/applications/repository/xaction/PhabricatorRepositoryDefaultBranchTransaction.php:17-36 | src/applications/repository/xaction/PhabricatorRepositorySVNSubpathTransaction.php:17-36 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/xaction/PhabricatorRepositoryDefaultBranchTransaction.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"1562d5a9faf47fe645d8248dfedc3e5b691a76735999c0f95e5f01d33e051823"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (20 lines \u00D7 2): src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementDelayWorkflow.php:46-65 | src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementFreeWorkflow.php:19-38 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementDelayWorkflow.php:46\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementDelayWorkflow.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"0a5c27f8f7d007d0261852f65263110a2a16b42ace0a19598362f116018495ab"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (20 lines \u00D7 2): src/infrastructure/export/engine/PhabricatorProjectsExportEngineExtension.php:24-43 | src/infrastructure/export/engine/PhabricatorSubscriptionsExportEngineExtension.php:24-43 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/infrastructure/export/engine/PhabricatorProjectsExportEngineExtension.php:24\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/export/engine/PhabricatorProjectsExportEngineExtension.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"7d2dda9cb2b871500202f8fc8febe23c56c805cc3d474fa828274459f986fffb"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (20 lines \u00D7 2): src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php:569-588 | src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php:603-624 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php:569\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php"},"region":{"startLine":569}}}],"partialFingerprints":{"codehealthFindingId/v1":"c7a8a28eb1d73e5e9299000e2a69c3e1ecfaba699795c888efdabdca95acdadb"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18\u201319 lines \u00D7 3): src/applications/herald/xaction/HeraldWebhookNameTransaction.php:34-52 | src/applications/herald/xaction/HeraldWebhookURITransaction.php:34-52 | src/applications/macro/xaction/PhabricatorMacroNameTransaction.php:34-51 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/herald/xaction/HeraldWebhookNameTransaction.php:34\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/xaction/HeraldWebhookNameTransaction.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"92de327e33276c7127c49b27ba200c641312195bafc6b4966a051df9b88befb1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19 lines \u00D7 3): src/applications/packages/controller/PhabricatorPackagesPackageViewController.php:73-91 | src/applications/packages/controller/PhabricatorPackagesPublisherViewController.php:70-88 | src/applications/packages/controller/PhabricatorPackagesVersionViewController.php:71-89 \u2014 before extracting anything, compare \u0060src/applications/packages/controller/PhabricatorPackagesPackageViewController.php\u0060 and \u0060src/applications/packages/controller/PhabricatorPackagesPublisherViewController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 66 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/packages/controller/PhabricatorPackagesPackageViewController.php"},"region":{"startLine":73}}}],"partialFingerprints":{"codehealthFindingId/v1":"73f8e50c34b01b5b8b00e5be6a74bb11fc2314ac36d1e5edf3e5da032d221417"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19 lines \u00D7 3): src/applications/repository/xaction/PhabricatorRepositoryFetchRefsTransaction.php:17-35 | src/applications/repository/xaction/PhabricatorRepositoryPermanentRefsTransaction.php:17-35 | src/applications/repository/xaction/PhabricatorRepositoryTrackOnlyTransaction.php:17-35 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/xaction/PhabricatorRepositoryFetchRefsTransaction.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"0c16a2d8d03ae05ca753bf6d158ea41463b0c61059cc6fa0b05a7dfe208aba92"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19 lines \u00D7 3): src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php:401-419 | src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php:173-191 | src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php:91-109 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php:88\u0060 calls \u0060idx\u0060, \u0060getOptions\u0060 and \u0060src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php:399\u0060 does not \u2014 after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php"},"region":{"startLine":401}}}],"partialFingerprints":{"codehealthFindingId/v1":"183594cb7acb89c0f40d345955ba93141c9156e624cec65c764cde75a8e35435"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19 lines \u00D7 2): src/applications/auth/controller/contact/PhabricatorAuthContactNumberViewController.php:28-46 | src/applications/auth/controller/mfa/PhabricatorAuthFactorProviderViewController.php:32-50 \u2014 before extracting anything, compare \u0060src/applications/auth/controller/contact/PhabricatorAuthContactNumberViewController.php\u0060 and \u0060src/applications/auth/controller/mfa/PhabricatorAuthFactorProviderViewController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 64 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/contact/PhabricatorAuthContactNumberViewController.php"},"region":{"startLine":28}}}],"partialFingerprints":{"codehealthFindingId/v1":"f2fa93d986a09ff5a5c5d567e541f731b2afb6da45798ab087037a44c899e9fe"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19 lines \u00D7 2): src/applications/auth/provider/PhabricatorOAuth1AuthProvider.php:102-120 | src/applications/auth/provider/PhabricatorOAuth2AuthProvider.php:82-100 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorOAuth1AuthProvider.php"},"region":{"startLine":102}}}],"partialFingerprints":{"codehealthFindingId/v1":"f55cc6e063a13710a8defa06edb3596ecbe8c1a011ca3a1cfba787ff373b0b21"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19 lines \u00D7 2): src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php:155-173 | src/applications/harbormaster/query/HarbormasterBuildPlanSearchEngine.php:116-134 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php:155\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php"},"region":{"startLine":155}}}],"partialFingerprints":{"codehealthFindingId/v1":"937ca9c3b44d66d439eeee64dc1e5df382ab5f62f8b1ff8beae3b301bd25b861"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19 lines \u00D7 2): src/applications/differential/xaction/DifferentialRevisionBuildableTransaction.php:63-81 | src/applications/diffusion/xaction/DiffusionCommitBuildableTransaction.php:59-77 \u2014 before extracting anything, compare \u0060src/applications/differential/xaction/DifferentialRevisionBuildableTransaction.php\u0060 and \u0060src/applications/diffusion/xaction/DiffusionCommitBuildableTransaction.php\u0060 as WHOLE FILES: 85% of the shorter file\u0027s lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it \u2014 treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/xaction/DifferentialRevisionBuildableTransaction.php"},"region":{"startLine":63}}}],"partialFingerprints":{"codehealthFindingId/v1":"c7063e21bbbaf5e276d61dd9658c10d10c04c13ce4154cec1a526447c79dc600"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16\u201319 lines \u00D7 2): src/applications/diffusion/controller/DiffusionChangeController.php:18-36 | src/applications/diffusion/controller/DiffusionDiffController.php:46-61 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionChangeController.php"},"region":{"startLine":18}}}],"partialFingerprints":{"codehealthFindingId/v1":"4bb96ccddf9271de2f7a8f6d27f4d2845717ee66750413f0838c38bbf9b9d053"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17\u201319 lines \u00D7 2): src/applications/diffusion/controller/DiffusionHistoryController.php:10-28 | src/applications/diffusion/controller/DiffusionTagListController.php:10-26 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionHistoryController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"67e418e1dfa46d623bf07ab66183b5fd4e348a09cae69eab7edc710afc74b196"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19 lines \u00D7 2): src/applications/diffusion/herald/DiffusionCommitWrongBuildsHeraldField.php:21-39 | src/applications/diffusion/herald/DiffusionPreCommitContentWrongBuildsHeraldField.php:21-39 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/diffusion/herald/DiffusionCommitWrongBuildsHeraldField.php:21\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/herald/DiffusionCommitWrongBuildsHeraldField.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"e9f0518f6b7e5db52d674711d983714c2f54db40601ee8cac5200328e981f82f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18\u201319 lines \u00D7 2): src/applications/diffusion/panel/DiffusionSetPasswordSettingsPanel.php:86-104 | src/applications/settings/panel/PhabricatorPasswordSettingsPanel.php:104-121 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/diffusion/panel/DiffusionSetPasswordSettingsPanel.php:86\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/panel/DiffusionSetPasswordSettingsPanel.php"},"region":{"startLine":86}}}],"partialFingerprints":{"codehealthFindingId/v1":"038478bc5b2d692d32a27eb5d989463a4926a61e0c6d62b3fcbe5db690ff917f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18\u201319 lines \u00D7 2): src/applications/macro/controller/PhabricatorMacroAudioController.php:142-160 | src/applications/phortune/controller/merchant/PhortuneMerchantProviderEditController.php:273-290 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/macro/controller/PhabricatorMacroAudioController.php"},"region":{"startLine":142}}}],"partialFingerprints":{"codehealthFindingId/v1":"82277c6f9beba7f48c017af28115a71f54c26a26fb2d27dac419cbecff52d4fb"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18\u201319 lines \u00D7 2): src/applications/maniphest/xaction/ManiphestTaskOwnerTransaction.php:117-134 | src/applications/repository/xaction/PhabricatorRepositoryIdentityAssignTransaction.php:60-78 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/maniphest/xaction/ManiphestTaskOwnerTransaction.php:117\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/xaction/ManiphestTaskOwnerTransaction.php"},"region":{"startLine":117}}}],"partialFingerprints":{"codehealthFindingId/v1":"891332911bb7648a17fd51335fd1ed74f657f673eab0236105287018109759b7"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19 lines \u00D7 2): src/applications/phortune/controller/merchant/PhortuneMerchantDetailsController.php:63-81 | src/applications/phortune/controller/merchant/PhortuneMerchantOverviewController.php:110-128 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/merchant/PhortuneMerchantDetailsController.php"},"region":{"startLine":63}}}],"partialFingerprints":{"codehealthFindingId/v1":"231d565ef0cd939e4a7b36b9c880ac7e2fe033a06cdc916a87109f22b20b3693"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19 lines \u00D7 2): src/applications/project/controller/PhabricatorProjectArchiveController.php:26-44 | src/applications/project/controller/PhabricatorProjectColumnHideController.php:59-77 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectArchiveController.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"ec149ede66c6ffb0e471f6ac9f356d6d96f25662afe9bdb241268dc87a5961af"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17\u201319 lines \u00D7 2): src/applications/project/controller/PhabricatorProjectColumnDetailController.php:7-23 | src/applications/project/controller/PhabricatorProjectColumnEditController.php:7-25 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectColumnDetailController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"6f3c4a3b183a135ad77dca9e1ef4ebef50a8a18b2cd8c3823cd9fdbfbac548f9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19 lines \u00D7 2): src/applications/project/controller/PhabricatorProjectUpdateController.php:60-78 | src/applications/project/controller/PhabricatorProjectWatchController.php:57-75 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/project/controller/PhabricatorProjectUpdateController.php:60\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectUpdateController.php"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"c56c8347da26dc88d8bc8f9d1acac6224a53f691bd565d7b0652d9e7ccef818c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18 lines \u00D7 5): src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php:47-64 | src/applications/diffusion/management/DiffusionRepositoryLimitsManagementPanel.php:46-63 | src/applications/diffusion/management/DiffusionRepositoryStagingManagementPanel.php:44-61 | src/applications/diffusion/management/DiffusionRepositorySubversionManagementPanel.php:40-57 | src/applications/diffusion/management/DiffusionRepositorySymbolsManagementPanel.php:42-59 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 5 call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"9e0665f8c6edfd8704e2d5cb3d1771b0edb8aa1f3244fb43d5a174d45456bc9b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18 lines \u00D7 3): src/applications/dashboard/controller/dashboard/PhabricatorDashboardViewController.php:95-112 | src/applications/project/controller/PhabricatorProjectManageController.php:111-128 | src/applications/spaces/controller/PhabricatorSpacesViewController.php:116-133 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/dashboard/controller/dashboard/PhabricatorDashboardViewController.php:95\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/dashboard/PhabricatorDashboardViewController.php"},"region":{"startLine":95}}}],"partialFingerprints":{"codehealthFindingId/v1":"eb54aeaa591506f21844721f137e1d8b4bd6ffff61582263c4800d714a753684"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16\u201318 lines \u00D7 3): src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php:78-95 | src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubIssue.php:39-54 | src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubUser.php:43-58 \u2014 before extracting anything, compare \u0060src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubIssue.php\u0060 and \u0060src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubUser.php\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 92 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubIssue.php:56\u0060 calls \u0060getViewer\u0060 and \u0060src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php:97\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php"},"region":{"startLine":78}}}],"partialFingerprints":{"codehealthFindingId/v1":"246ae458e5c7ad196dba9d3727eddc3350344437ffc34ce572c1c82086db8218"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18 lines \u00D7 3): src/applications/drydock/storage/DrydockLease.php:280-297 | src/applications/drydock/storage/DrydockLease.php:348-365 | src/applications/drydock/storage/DrydockResource.php:206-223 \u2014 before extracting anything, compare \u0060src/applications/drydock/storage/DrydockLease.php\u0060 and \u0060src/applications/drydock/storage/DrydockResource.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 42 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/storage/DrydockLease.php"},"region":{"startLine":280}}}],"partialFingerprints":{"codehealthFindingId/v1":"9c10b0accdd7847883783d651f003030d9c77570dc8c69bda429a109ee1d8b9f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15\u201318 lines \u00D7 3): src/applications/files/controller/PhabricatorFileViewController.php:79-93 | src/applications/harbormaster/controller/HarbormasterPlanViewController.php:72-89 | src/applications/legalpad/controller/LegalpadDocumentManageController.php:64-78 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/controller/PhabricatorFileViewController.php"},"region":{"startLine":79}}}],"partialFingerprints":{"codehealthFindingId/v1":"7853b77a1bb3c05a6a16f041743315642d4b928790ce393d16f989ec5d87d40f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17\u201318 lines \u00D7 3): src/applications/phame/controller/post/PhamePostArchiveController.php:6-22 | src/applications/phame/controller/post/PhamePostMoveController.php:6-23 | src/applications/phame/controller/post/PhamePostPublishController.php:6-22 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/phame/controller/post/PhamePostPublishController.php:24\u0060 calls \u0060getURIData\u0060 and \u0060src/applications/phame/controller/post/PhamePostArchiveController.php:24\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/post/PhamePostArchiveController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"19415b42431e6c3d78020d34f343119a7f5c4b20b743f7cd27b73f2e972a2afa"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15\u201318 lines \u00D7 3): src/applications/phortune/controller/account/PhortuneAccountOrdersController.php:21-36 | src/applications/phortune/controller/account/PhortuneAccountOverviewController.php:31-48 | src/applications/phortune/controller/merchant/PhortuneMerchantOrdersController.php:19-33 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/phortune/controller/account/PhortuneAccountOverviewController.php:29\u0060 calls \u0060buildStatusView\u0060, \u0060buildInvoicesSection\u0060 and \u0060src/applications/phortune/controller/account/PhortuneAccountOrdersController.php:19\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountOrdersController.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"a5dd0853f0831305bd7dd27ece1cddff38704f8e6020066da4c3d05fe04c0374"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17\u201318 lines \u00D7 2): src/applications/auth/controller/contact/PhabricatorAuthContactNumberViewController.php:10-26 | src/applications/auth/controller/mfa/PhabricatorAuthFactorProviderViewController.php:13-30 \u2014 before extracting anything, compare \u0060src/applications/auth/controller/contact/PhabricatorAuthContactNumberViewController.php\u0060 and \u0060src/applications/auth/controller/mfa/PhabricatorAuthFactorProviderViewController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 64 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/auth/controller/contact/PhabricatorAuthContactNumberViewController.php:10\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/contact/PhabricatorAuthContactNumberViewController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"5745abc28fe7d7331d2ee3c40119b897f02a36fea22de1cb948c04b8b177e1e3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18 lines \u00D7 2): src/applications/auth/provider/PhabricatorAsanaAuthProvider.php:54-71 | src/applications/auth/provider/PhabricatorJIRAAuthProvider.php:337-354 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/auth/provider/PhabricatorAsanaAuthProvider.php:54\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorAsanaAuthProvider.php"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"236045c0aee4d188bfdf849fe9b9414df015b386c9ec540e2f5af7af610941eb"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16\u201318 lines \u00D7 2): src/applications/calendar/policyrule/PhabricatorCalendarEventInviteesPolicyRule.php:47-62 | src/applications/subscriptions/policyrule/PhabricatorSubscriptionsSubscribersPolicyRule.php:59-76 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/calendar/policyrule/PhabricatorCalendarEventInviteesPolicyRule.php:47\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/policyrule/PhabricatorCalendarEventInviteesPolicyRule.php"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"645711a001855e5de73a238029b45b824a05857c1be38f090155c75ce1d94d82"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17\u201318 lines \u00D7 2): src/applications/dashboard/controller/dashboard/PhabricatorDashboardViewController.php:47-64 | src/applications/dashboard/controller/panel/PhabricatorDashboardPanelViewController.php:54-70 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/dashboard/PhabricatorDashboardViewController.php"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"8c8f43a922f810c3949985fb57da19c03ec0aa111cf096b2ba829100710f8a4d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18 lines \u00D7 2): src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php:105-122 | src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php:125-142 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php:105\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php"},"region":{"startLine":105}}}],"partialFingerprints":{"codehealthFindingId/v1":"9ee388cb42dc20b2202af4377022d17bcc316c3cf00887dcf15b3e14b63708b8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18 lines \u00D7 2): src/applications/drydock/controller/DrydockLeaseViewController.php:24-41 | src/applications/drydock/controller/DrydockResourceViewController.php:26-43 \u2014 before extracting anything, compare \u0060src/applications/drydock/controller/DrydockLeaseViewController.php\u0060 and \u0060src/applications/drydock/controller/DrydockResourceViewController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/controller/DrydockLeaseViewController.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"6e808920fd9830636abfe04bfc87e772047aaf8bfea152af386370fe249c7e49"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17\u201318 lines \u00D7 2): src/applications/drydock/query/DrydockBlueprintSearchEngine.php:77-94 | src/applications/harbormaster/query/HarbormasterBuildPlanSearchEngine.php:83-99 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/drydock/query/DrydockBlueprintSearchEngine.php:77\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/query/DrydockBlueprintSearchEngine.php"},"region":{"startLine":77}}}],"partialFingerprints":{"codehealthFindingId/v1":"9f4a77dfb04eca50322e83cfe8e0b0b3ef6366062058ee975cfdf55c266422d2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18 lines \u00D7 2): src/applications/meta/controller/PhabricatorApplicationEditController.php:58-75 | src/applications/meta/controller/PhabricatorApplicationUninstallController.php:54-71 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/meta/controller/PhabricatorApplicationEditController.php:58\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/meta/controller/PhabricatorApplicationEditController.php"},"region":{"startLine":58}}}],"partialFingerprints":{"codehealthFindingId/v1":"39978c8853dc5e83cc964d41753e499cb97fd107bd4d9a59a481f245bd96c995"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18 lines \u00D7 2): src/applications/packages/controller/PhabricatorPackagesPackageViewController.php:40-57 | src/applications/packages/controller/PhabricatorPackagesPublisherViewController.php:37-54 \u2014 before extracting anything, compare \u0060src/applications/packages/controller/PhabricatorPackagesPackageViewController.php\u0060 and \u0060src/applications/packages/controller/PhabricatorPackagesPublisherViewController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 66 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/packages/controller/PhabricatorPackagesPackageViewController.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"acba30829623c3a8a9fec015dd56c27c247e49a45e58fe14bbd5f46b68d3e66c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18 lines \u00D7 2): src/applications/people/controller/PhabricatorPeopleProfileEditController.php:7-24 | src/applications/people/controller/PhabricatorPeopleProfilePictureController.php:7-24 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/controller/PhabricatorPeopleProfileEditController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"b4b853dd9e671e1039a3caccb28ee6c08b565251c2f4cd550c11725416956967"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18 lines \u00D7 2): src/applications/phortune/controller/account/PhortuneAccountDetailsController.php:11-28 | src/applications/phortune/controller/account/PhortuneAccountOverviewController.php:11-28 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountDetailsController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"92108f2ab0ecdc100d4a5ef269cf18dd808b38815c0f752080d9c6e35503a159"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18 lines \u00D7 2): src/applications/phortune/controller/account/PhortuneAccountEmailRotateController.php:11-28 | src/applications/phortune/controller/account/PhortuneAccountEmailStatusController.php:11-28 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountEmailRotateController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"6dee152baf6cd87de8cda47bb890b47c425dae89ca6e4e3e7d57de5566415edc"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 4): src/applications/countdown/controller/PhabricatorCountdownViewController.php:114-130 | src/applications/paste/controller/PhabricatorPasteViewController.php:157-173 | src/applications/ponder/controller/PonderQuestionViewController.php:186-202 | src/applications/slowvote/controller/PhabricatorSlowvotePollController.php:125-141 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 4 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/countdown/controller/PhabricatorCountdownViewController.php"},"region":{"startLine":114}}}],"partialFingerprints":{"codehealthFindingId/v1":"2920f9a277279f9dbbe03b28aaaf7d47349cf0e16eee82cd98230b4d6c5b9397"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 4): src/applications/differential/typeahead/DifferentialBlockingReviewerDatasource.php:77-93 | src/applications/differential/typeahead/DifferentialExactUserFunctionDatasource.php:65-81 | src/applications/owners/typeahead/PhabricatorOwnersPackageOwnerDatasource.php:89-105 | src/applications/project/typeahead/PhabricatorProjectLogicalUserDatasource.php:79-95 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 4 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/differential/typeahead/DifferentialBlockingReviewerDatasource.php:77\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/typeahead/DifferentialBlockingReviewerDatasource.php"},"region":{"startLine":77}}}],"partialFingerprints":{"codehealthFindingId/v1":"8d57bd97abf2319415e4851b7343ca0a3ade51722a0c6d6257dabd0d51babce2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14\u201317 lines \u00D7 4): src/applications/files/controller/PhabricatorFileTransformListController.php:130-144 | src/applications/macro/controller/PhabricatorMacroAudioController.php:148-162 | src/applications/phortune/controller/cart/PhortuneCartCheckoutController.php:215-231 | src/applications/phortune/controller/merchant/PhortuneMerchantProviderEditController.php:279-292 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 4 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/controller/PhabricatorFileTransformListController.php"},"region":{"startLine":130}}}],"partialFingerprints":{"codehealthFindingId/v1":"257f192d387054216c1178374910cf64240121bdf715e110b65f30506cbb6022"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 4): src/applications/fund/query/FundBackerQuery.php:72-88 | src/applications/phortune/query/PhortuneCartQuery.php:156-172 | src/applications/phortune/query/PhortuneChargeQuery.php:98-114 | src/applications/phortune/query/PhortunePurchaseQuery.php:78-94 \u2014 before extracting anything, compare \u0060src/applications/phortune/query/PhortuneCartQuery.php\u0060 and \u0060src/applications/phortune/query/PhortuneChargeQuery.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 36 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fund/query/FundBackerQuery.php"},"region":{"startLine":72}}}],"partialFingerprints":{"codehealthFindingId/v1":"9fa0c638e05606ce2b286808bbecc568ddbcb055cf3f81660e0ca3e5d283b5f5"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16\u201317 lines \u00D7 3): src/applications/auth/controller/config/PhabricatorAuthListController.php:102-118 | src/applications/auth/controller/message/PhabricatorAuthMessageListController.php:62-77 | src/applications/auth/controller/mfa/PhabricatorAuthFactorProviderListController.php:64-79 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/config/PhabricatorAuthListController.php"},"region":{"startLine":102}}}],"partialFingerprints":{"codehealthFindingId/v1":"061474514804777e8eb33464b217166da2cf6d6efa545c880b2f2c5dc6b5277e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15\u201317 lines \u00D7 3): src/applications/calendar/controller/PhabricatorCalendarEventAvailabilityController.php:7-21 | src/applications/calendar/controller/PhabricatorCalendarEventCancelController.php:7-23 | src/applications/calendar/controller/PhabricatorCalendarEventJoinController.php:7-21 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/controller/PhabricatorCalendarEventAvailabilityController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"2598ec68e2148d46117e06e9d0c17be098437101b78f01bdd07d38976e9cac90"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 3): src/applications/differential/conduit/DifferentialConduitAPIMethod.php:138-154 | src/infrastructure/customfield/engineextension/PhabricatorCustomFieldSearchEngineExtension.php:94-110 | src/infrastructure/export/engine/PhabricatorCustomFieldExportEngineExtension.php:42-58 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/differential/conduit/DifferentialConduitAPIMethod.php:138\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/conduit/DifferentialConduitAPIMethod.php"},"region":{"startLine":138}}}],"partialFingerprints":{"codehealthFindingId/v1":"a267064620730812948aaa82e3f086ddba1737ee5109a43a6efc1e50e7a6aedc"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 3): src/applications/nuance/query/NuanceQueueQuery.php:24-40 | src/applications/people/query/PhabricatorPeopleUserEmailQuery.php:28-44 | src/applications/xhprof/query/PhabricatorXHProfSampleQuery.php:24-40 \u2014 before extracting anything, compare \u0060src/applications/nuance/query/NuanceQueueQuery.php\u0060 and \u0060src/applications/xhprof/query/PhabricatorXHProfSampleQuery.php\u0060 as WHOLE FILES: 84% of the shorter file\u0027s lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it \u2014 treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/query/NuanceQueueQuery.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"25701f603792ef6c1bf7a1744de9e25518237932a2cdba6a39e1bb7775a43387"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 3): src/applications/owners/xaction/PhabricatorOwnersPackageAuthorityTransaction.php:16-32 | src/applications/owners/xaction/PhabricatorOwnersPackageAutoreviewTransaction.php:16-32 | src/applications/owners/xaction/PhabricatorOwnersPackageDominionTransaction.php:16-32 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/owners/xaction/PhabricatorOwnersPackageAuthorityTransaction.php"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"c8952c9dbc8883cab0edc7ef4f374ab71c90aee6168c49cbeedb55e8d388c54f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 3): src/applications/people/controller/PhabricatorPeopleProfileCommitsController.php:10-26 | src/applications/people/controller/PhabricatorPeopleProfileRevisionsController.php:10-26 | src/applications/people/controller/PhabricatorPeopleProfileTasksController.php:10-26 \u2014 before extracting anything, compare \u0060src/applications/people/controller/PhabricatorPeopleProfileCommitsController.php\u0060 and \u0060src/applications/people/controller/PhabricatorPeopleProfileRevisionsController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 57 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/controller/PhabricatorPeopleProfileCommitsController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"de87f2782ffd330ff7d50fe6c274dedcbee6a14a5b92deb5521f5ca371b20013"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15\u201317 lines \u00D7 3): src/applications/transactions/controller/PhabricatorApplicationTransactionCommentEditController.php:12-28 | src/applications/transactions/controller/PhabricatorApplicationTransactionCommentRawController.php:13-29 | src/applications/transactions/controller/PhabricatorApplicationTransactionCommentRemoveController.php:13-27 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/controller/PhabricatorApplicationTransactionCommentEditController.php"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"b3213088010b9850887c1f83e1183d806310d61ecca92b1f233952598d6745c0"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 3): src/applications/transactions/controller/PhabricatorEditEngineConfigurationDefaultsController.php:11-27 | src/applications/transactions/controller/PhabricatorEditEngineConfigurationLockController.php:11-27 | src/applications/transactions/controller/PhabricatorEditEngineConfigurationReorderController.php:11-27 \u2014 before extracting anything, compare \u0060src/applications/transactions/controller/PhabricatorEditEngineConfigurationDefaultsController.php\u0060 and \u0060src/applications/transactions/controller/PhabricatorEditEngineConfigurationLockController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 43 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/controller/PhabricatorEditEngineConfigurationDefaultsController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"49271f64bfd6b04d512aeb538523a0258fc98a236208433175e0598bd5428501"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12\u201317 lines \u00D7 2): src/aphront/configuration/AphrontApplicationConfiguration.php:299-310 | src/aphront/configuration/AphrontApplicationConfiguration.php:339-355 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/aphront/configuration/AphrontApplicationConfiguration.php:299\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/configuration/AphrontApplicationConfiguration.php"},"region":{"startLine":299}}}],"partialFingerprints":{"codehealthFindingId/v1":"d0f7b8aa7b48865db92ea0ae5f025e0c7cc6dde60e24a3853ecc59318142c6d1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 2): src/applications/almanac/controller/AlmanacBindingViewController.php:63-79 | src/applications/meta/controller/PhabricatorApplicationDetailViewController.php:63-79 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/controller/AlmanacBindingViewController.php"},"region":{"startLine":63}}}],"partialFingerprints":{"codehealthFindingId/v1":"074ee57046d1d072fa5f93b5b116608a0e95f9ea5f4afbe930ec2b0e898bec6d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 2): src/applications/auth/controller/contact/PhabricatorAuthContactNumberPrimaryController.php:8-24 | src/applications/auth/controller/contact/PhabricatorAuthContactNumberTestController.php:8-24 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/contact/PhabricatorAuthContactNumberPrimaryController.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"83cced8c24f9d4ca21b4787b3d4bfa748308ea3be3cb76b45930ca04bfc41984"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 2): src/applications/auth/provider/PhabricatorJIRAAuthProvider.php:123-139 | src/applications/auth/provider/PhabricatorPhabricatorAuthProvider.php:107-123 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/auth/provider/PhabricatorJIRAAuthProvider.php:123\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorJIRAAuthProvider.php"},"region":{"startLine":123}}}],"partialFingerprints":{"codehealthFindingId/v1":"cba4f6a258776a053fa06694ba8580fbb6bd258c40a59d4603d15cddb8c5f045"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 2): src/applications/calendar/typeahead/PhabricatorCalendarInviteeDatasource.php:31-47 | src/applications/differential/typeahead/DifferentialResponsibleDatasource.php:32-48 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/calendar/typeahead/PhabricatorCalendarInviteeDatasource.php:31\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/typeahead/PhabricatorCalendarInviteeDatasource.php"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"2fd8daeeb4e1142659145bd464fab6ac8401d83d4c86827bbb8c7ccb1c8b383f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16\u201317 lines \u00D7 2): src/applications/calendar/xaction/PhabricatorCalendarEventFrequencyTransaction.php:60-76 | src/applications/calendar/xaction/PhabricatorCalendarImportFrequencyTransaction.php:27-42 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/calendar/xaction/PhabricatorCalendarEventFrequencyTransaction.php:60\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/xaction/PhabricatorCalendarEventFrequencyTransaction.php"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"2f091ecf372d19e7dcb9f1ea44d09f99b85977700005ea276be37cb780640515"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 2): src/applications/differential/customfield/DifferentialCustomField.php:47-63 | src/applications/differential/field/DifferentialCommitMessageField.php:133-149 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/differential/field/DifferentialCommitMessageField.php:131\u0060 calls \u0060getViewer\u0060, \u0060loadHandles\u0060 and \u0060src/applications/differential/customfield/DifferentialCustomField.php:45\u0060 does not \u2014 after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/customfield/DifferentialCustomField.php"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"b015908a3b4ebee1e81224d4428f01df4c76a933ba1365ec614a42baa8c67b56"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 2): src/applications/differential/xaction/DifferentialRevisionBuildableTransaction.php:43-59 | src/applications/diffusion/xaction/DiffusionCommitBuildableTransaction.php:39-55 \u2014 before extracting anything, compare \u0060src/applications/differential/xaction/DifferentialRevisionBuildableTransaction.php\u0060 and \u0060src/applications/diffusion/xaction/DiffusionCommitBuildableTransaction.php\u0060 as WHOLE FILES: 85% of the shorter file\u0027s lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it \u2014 treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/xaction/DifferentialRevisionBuildableTransaction.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"2b4b149eca1f4ce37274b357e7db01b15286778d8b2f97e615f1eb185e67266b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 2): src/applications/diffusion/controller/DiffusionBranchTableController.php:87-103 | src/applications/diffusion/controller/DiffusionBrowseController.php:79-97 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionBranchTableController.php"},"region":{"startLine":87}}}],"partialFingerprints":{"codehealthFindingId/v1":"dd8559b407d6f6a4daccb6243483b0c809081e085704afb74280a96c6d59e903"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 2): src/applications/drydock/storage/DrydockLease.php:471-487 | src/applications/drydock/storage/DrydockResource.php:258-274 \u2014 before extracting anything, compare \u0060src/applications/drydock/storage/DrydockLease.php\u0060 and \u0060src/applications/drydock/storage/DrydockResource.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 42 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/storage/DrydockLease.php"},"region":{"startLine":471}}}],"partialFingerprints":{"codehealthFindingId/v1":"0aee8365821fd863f8a2fbc2bb3ecbbb0eae7d1f27d54c2ebd249175d9c9abbe"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15\u201317 lines \u00D7 2): src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php:514-530 | src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php:565-579 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php:514\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php"},"region":{"startLine":514}}}],"partialFingerprints":{"codehealthFindingId/v1":"4ceb234539c9ba44f833f2821f11bcec78d891274d6b87c8490b71d5427e709a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 2): src/applications/maniphest/xaction/ManiphestTaskStatusTransaction.php:50-66 | src/applications/maniphest/xaction/ManiphestTaskStatusTransaction.php:120-136 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/maniphest/xaction/ManiphestTaskStatusTransaction.php:50\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/maniphest/xaction/ManiphestTaskStatusTransaction.php:137\u0060 calls \u0060renderObject\u0060 and \u0060src/applications/maniphest/xaction/ManiphestTaskStatusTransaction.php:67\u0060 does not \u2014 after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/xaction/ManiphestTaskStatusTransaction.php"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"affcc52e368c8514d2e50091d9e2de10581b3d39be6ef80776e9e4fc431f26fd"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 2): src/applications/packages/xaction/package/PhabricatorPackagesPackagePublisherTransaction.php:21-37 | src/applications/packages/xaction/version/PhabricatorPackagesVersionPackageTransaction.php:20-36 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/packages/xaction/package/PhabricatorPackagesPackagePublisherTransaction.php:21\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/packages/xaction/package/PhabricatorPackagesPackagePublisherTransaction.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"94efa3aaaef9665abd1d1be51fe2295e071f3e3b7219176eb665182527c656fa"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13\u201317 lines \u00D7 2): src/applications/people/conduit/UserConduitAPIMethod.php:14-26 | src/applications/people/storage/PhabricatorUser.php:1201-1217 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/conduit/UserConduitAPIMethod.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"0ec41900d00080ce547811e4f334c248fb8d728104c43c45ad1e47edc9985609"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 2): src/applications/people/controller/PhabricatorPeopleProfileViewController.php:92-108 | src/applications/project/controller/PhabricatorProjectProfileController.php:162-178 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/controller/PhabricatorPeopleProfileViewController.php"},"region":{"startLine":92}}}],"partialFingerprints":{"codehealthFindingId/v1":"8bce9d90143010d5909d80f392be47998665c166084541ed1d905d255b58f152"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14\u201317 lines \u00D7 2): src/applications/phortune/controller/merchant/PhortuneMerchantOverviewController.php:30-43 | src/applications/phortune/controller/merchant/PhortuneMerchantProvidersController.php:31-47 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phortune/controller/merchant/PhortuneMerchantProvidersController.php:31\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/merchant/PhortuneMerchantOverviewController.php"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"19aadc096ff5216bf838ec96bf3de1aa7ba5e9d3b7a050d4ad4c73c0026e0602"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 2): src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementExecuteWorkflow.php:51-67 | src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementRetryWorkflow.php:44-60 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementExecuteWorkflow.php:51\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementRetryWorkflow.php:62\u0060 calls \u0060unarchiveTask\u0060 and \u0060src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementExecuteWorkflow.php:69\u0060 does not \u2014 after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementExecuteWorkflow.php"},"region":{"startLine":51}}}],"partialFingerprints":{"codehealthFindingId/v1":"3f9d48d1e045e2aa2a6faede41fb8ba6e4549b5d2683f60be3c73532f95b71bc"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 2): src/infrastructure/env/PhabricatorEnv.php:738-754 | src/infrastructure/env/PhabricatorEnv.php:805-821 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/env/PhabricatorEnv.php"},"region":{"startLine":738}}}],"partialFingerprints":{"codehealthFindingId/v1":"aeb9b3f74d89df1d24db578596a23a44b801ae389b4efd9daa73503bbb753cb1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 6): src/applications/search/menuitem/PhabricatorApplicationProfileMenuItem.php:103-118 | src/applications/search/menuitem/PhabricatorConpherenceProfileMenuItem.php:134-149 | src/applications/search/menuitem/PhabricatorDashboardProfileMenuItem.php:190-205 | src/applications/search/menuitem/PhabricatorEditEngineProfileMenuItem.php:131-146 | src/applications/search/menuitem/PhabricatorLinkProfileMenuItem.php:115-130 | src/applications/search/menuitem/PhabricatorProjectProfileMenuItem.php:118-133 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 6 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/search/menuitem/PhabricatorApplicationProfileMenuItem.php:103\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/menuitem/PhabricatorApplicationProfileMenuItem.php"},"region":{"startLine":103}}}],"partialFingerprints":{"codehealthFindingId/v1":"9aef2c654d91f2cae990dc67ae5d9be57edca757059467090e809a73941175cd"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 5): src/applications/conpherence/controller/ConpherenceRoomPictureController.php:216-232 | src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php:121-136 | src/applications/phame/controller/blog/PhameBlogProfilePictureController.php:222-238 | src/applications/phame/controller/post/PhamePostHeaderPictureController.php:118-133 | src/applications/phortune/controller/merchant/PhortuneMerchantPictureController.php:204-220 \u2014 before extracting anything, compare \u0060src/applications/conpherence/controller/ConpherenceRoomPictureController.php\u0060 and \u0060src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 57 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceRoomPictureController.php"},"region":{"startLine":216}}}],"partialFingerprints":{"codehealthFindingId/v1":"025baab5168544b5f320f7ca00ae75796c14a1977915fd11bad954bce95506a4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15\u201316 lines \u00D7 4): src/applications/almanac/controller/AlmanacBindingViewController.php:119-133 | src/applications/auth/controller/PhabricatorAuthSSHKeyViewController.php:73-88 | src/applications/badges/controller/PhabricatorBadgesViewController.php:83-97 | src/applications/owners/controller/PhabricatorOwnersDetailController.php:241-255 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 4 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/almanac/controller/AlmanacBindingViewController.php:119\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/controller/AlmanacBindingViewController.php"},"region":{"startLine":119}}}],"partialFingerprints":{"codehealthFindingId/v1":"a53beefeef99fa5fc9cde5053e20aa8a156ad80cfa63e934829f7237d508c7b2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 4): src/applications/calendar/controller/PhabricatorCalendarEventViewController.php:222-237 | src/applications/dashboard/controller/dashboard/PhabricatorDashboardViewController.php:95-110 | src/applications/project/controller/PhabricatorProjectManageController.php:111-126 | src/applications/spaces/controller/PhabricatorSpacesViewController.php:116-131 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 4 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/calendar/controller/PhabricatorCalendarEventViewController.php:222\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/controller/PhabricatorCalendarEventViewController.php"},"region":{"startLine":222}}}],"partialFingerprints":{"codehealthFindingId/v1":"056a10fce1e295fb9cebbe684f4b8d3b7a23849a105fd2edc464a038697119e3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15\u201316 lines \u00D7 4): src/applications/conpherence/controller/ConpherenceRoomPictureController.php:95-109 | src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php:82-97 | src/applications/phame/controller/blog/PhameBlogProfilePictureController.php:95-109 | src/applications/phortune/controller/merchant/PhortuneMerchantPictureController.php:85-99 \u2014 before extracting anything, compare \u0060src/applications/conpherence/controller/ConpherenceRoomPictureController.php\u0060 and \u0060src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 119 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/conpherence/controller/ConpherenceRoomPictureController.php:95\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceRoomPictureController.php"},"region":{"startLine":95}}}],"partialFingerprints":{"codehealthFindingId/v1":"8d063eee3050c7cff54495e8f2aa4bb780ba13ed725eff0f1d15b612776bfcc9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 4): src/applications/transactions/controller/PhabricatorEditEngineConfigurationDefaultsController.php:8-23 | src/applications/transactions/controller/PhabricatorEditEngineConfigurationLockController.php:8-23 | src/applications/transactions/controller/PhabricatorEditEngineConfigurationReorderController.php:8-23 | src/applications/transactions/controller/PhabricatorEditEngineConfigurationSubtypeController.php:8-23 \u2014 before extracting anything, compare \u0060src/applications/transactions/controller/PhabricatorEditEngineConfigurationDefaultsController.php\u0060 and \u0060src/applications/transactions/controller/PhabricatorEditEngineConfigurationLockController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 43 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/transactions/controller/PhabricatorEditEngineConfigurationDefaultsController.php:8\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/controller/PhabricatorEditEngineConfigurationDefaultsController.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"1f43c2c8b14179b14717ed17ec2ed8b3c3f4897de452db34112d57f28ed259b8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 3): src/applications/almanac/controller/AlmanacDeviceViewController.php:61-81 | src/applications/almanac/controller/AlmanacNamespaceViewController.php:39-54 | src/applications/almanac/controller/AlmanacNetworkViewController.php:39-54 \u2014 before extracting anything, compare \u0060src/applications/almanac/controller/AlmanacDeviceViewController.php\u0060 and \u0060src/applications/almanac/controller/AlmanacNamespaceViewController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 67 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/controller/AlmanacDeviceViewController.php"},"region":{"startLine":61}}}],"partialFingerprints":{"codehealthFindingId/v1":"1c947230e4c201b757c944d167d7d0841631352be3bf82e090d3559910673d16"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 3): src/applications/calendar/controller/PhabricatorCalendarImportDeleteController.php:7-22 | src/applications/calendar/controller/PhabricatorCalendarImportDisableController.php:7-22 | src/applications/calendar/controller/PhabricatorCalendarImportReloadController.php:7-22 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/controller/PhabricatorCalendarImportDeleteController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"2a49e824b20285af6e51f3db3868533d54f366b2d2f9b9d58954765f46ac6a9e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 3): src/applications/conduit/controller/PhabricatorConduitController.php:69-84 | src/applications/drydock/controller/DrydockLeaseViewController.php:60-75 | src/applications/drydock/controller/DrydockResourceViewController.php:65-80 \u2014 before extracting anything, compare \u0060src/applications/drydock/controller/DrydockLeaseViewController.php\u0060 and \u0060src/applications/drydock/controller/DrydockResourceViewController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conduit/controller/PhabricatorConduitController.php"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"08dfe27b741e615b5bfd666ff565e51c5600fbd54054acf495ca1e17bc2c82bf"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14\u201316 lines \u00D7 3): src/applications/config/controller/services/PhabricatorConfigCacheController.php:26-41 | src/applications/config/controller/services/PhabricatorConfigClusterNotificationsController.php:22-35 | src/applications/config/controller/services/PhabricatorConfigClusterSearchController.php:20-33 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/config/controller/services/PhabricatorConfigCacheController.php:26\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/services/PhabricatorConfigCacheController.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"15f2ae05c00f138e2502933fad763dc7966f884090d59effcad367b7b61b35a9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15\u201316 lines \u00D7 3): src/applications/phortune/controller/account/PhortuneAccountEmailViewController.php:38-52 | src/applications/phortune/controller/account/PhortuneAccountPaymentMethodViewController.php:44-59 | src/applications/phortune/controller/merchant/PhortuneMerchantProviderViewController.php:42-56 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountEmailViewController.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"7604b53391ab1f76775f9e6555401875e949b2fbb0dc84e9902419372b8f5fa2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15\u201316 lines \u00D7 3): src/applications/project/controller/PhabricatorProjectBoardImportController.php:8-22 | src/applications/project/controller/PhabricatorProjectBoardReorderController.php:8-23 | src/applications/project/controller/PhabricatorProjectColumnHideController.php:9-24 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/project/controller/PhabricatorProjectColumnHideController.php:8\u0060 calls \u0060getURIData\u0060 and \u0060src/applications/project/controller/PhabricatorProjectBoardReorderController.php:7\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectBoardImportController.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"16fb897a541381bc6377734b56ca205805911bc9566df8637033b37a03faec87"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15\u201316 lines \u00D7 3): src/applications/project/menuitem/PhabricatorProjectManageProfileMenuItem.php:50-65 | src/applications/project/menuitem/PhabricatorProjectMembersProfileMenuItem.php:40-55 | src/applications/project/menuitem/PhabricatorProjectSubprojectsProfileMenuItem.php:48-62 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/menuitem/PhabricatorProjectManageProfileMenuItem.php"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"b03c1e5e76cb1d463b5360dd2c91f12bfd160ef105ad215fdc7ca7d7cd511467"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): src/applications/almanac/management/AlmanacManagementTrustKeyWorkflow.php:21-36 | src/applications/almanac/management/AlmanacManagementUntrustKeyWorkflow.php:21-36 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/management/AlmanacManagementTrustKeyWorkflow.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"2a29f6c7b0d80adfab930da9a5b99a30d9cd524bf50065f808b53d1594f500a1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): src/applications/almanac/typeahead/AlmanacServiceDatasource.php:39-54 | src/applications/metamta/typeahead/PhabricatorMetaMTAApplicationEmailDatasource.php:34-49 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/almanac/typeahead/AlmanacServiceDatasource.php:39\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/typeahead/AlmanacServiceDatasource.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"464d154823973aaebcadabe386b2641b35e475542b0b46688f46e718022ce649"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15\u201316 lines \u00D7 2): src/applications/auth/editor/PhabricatorAuthSSHKeyEditor.php:130-145 | src/applications/oauthserver/editor/PhabricatorOAuthServerEditor.php:114-128 \u2014 before extracting anything, compare \u0060src/applications/auth/editor/PhabricatorAuthSSHKeyEditor.php\u0060 and \u0060src/applications/oauthserver/editor/PhabricatorOAuthServerEditor.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 45 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/auth/editor/PhabricatorAuthSSHKeyEditor.php:130\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/editor/PhabricatorAuthSSHKeyEditor.php"},"region":{"startLine":130}}}],"partialFingerprints":{"codehealthFindingId/v1":"3d3eaddaa376484663dccd9e7608355cd6bf17a2c1ebb93c020d8946ea218a1c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15\u201316 lines \u00D7 2): src/applications/auth/storage/PhabricatorAuthSSHKeyTransaction.php:19-34 | src/applications/oauthserver/storage/PhabricatorOAuthServerTransaction.php:23-37 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/auth/storage/PhabricatorAuthSSHKeyTransaction.php:19\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/storage/PhabricatorAuthSSHKeyTransaction.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"afd6673c853578748ca251242be89f56f1f7433a92855f2bd5fb4042248a4059"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): src/applications/conduit/controller/PhabricatorConduitTokenEditController.php:8-23 | src/applications/conduit/controller/PhabricatorConduitTokenTerminateController.php:9-24 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/conduit/controller/PhabricatorConduitTokenEditController.php:8\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/conduit/controller/PhabricatorConduitTokenTerminateController.php:8\u0060 calls \u0060getStr\u0060 and \u0060src/applications/conduit/controller/PhabricatorConduitTokenEditController.php:7\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conduit/controller/PhabricatorConduitTokenEditController.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"f45c06892bf8cb17cff5074f95afd27f83161022916f8ee60ff04dd2b599d116"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12\u201316 lines \u00D7 2): src/applications/config/storage/PhabricatorConfigTransaction.php:17-32 | src/applications/config/storage/PhabricatorConfigTransaction.php:55-66 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/config/storage/PhabricatorConfigTransaction.php:17\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/storage/PhabricatorConfigTransaction.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"d0d7b663c2d46fa6750fd639d7f80ff6e645e4627a90e512a2d25d242ef32396"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php:117-132 | src/applications/dashboard/controller/panel/PhabricatorDashboardPanelTabsController.php:202-217 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php:117\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php:134\u0060 calls \u0060appendRemarkupInstructions\u0060, \u0060pht\u0060 and \u0060src/applications/dashboard/controller/panel/PhabricatorDashboardPanelTabsController.php:219\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php"},"region":{"startLine":117}}}],"partialFingerprints":{"codehealthFindingId/v1":"195d4c2f1ef0b73bc62c40157ec5304dc08d062d25fbc3d8e0651ac90b41407f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): src/applications/dashboard/controller/dashboard/PhabricatorDashboardArchiveController.php:11-26 | src/applications/paste/controller/PhabricatorPasteArchiveController.php:11-26 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/dashboard/controller/dashboard/PhabricatorDashboardArchiveController.php:11\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/dashboard/PhabricatorDashboardArchiveController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"055ab44ccadb070c510e48418283904f96e6e2f8a464d22be31c4ddccc88fb84"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14\u201316 lines \u00D7 2): src/applications/differential/storage/DifferentialTransaction.php:228-241 | src/applications/differential/storage/DifferentialTransaction.php:326-341 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialTransaction.php"},"region":{"startLine":228}}}],"partialFingerprints":{"codehealthFindingId/v1":"479977d5e7d3220adeb15e09c41a3deb389731f325de7a9bd39fbae977f0fce3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php:130-145 | src/applications/project/controller/PhabricatorProjectEditPictureController.php:137-152 \u2014 before extracting anything, compare \u0060src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php\u0060 and \u0060src/applications/project/controller/PhabricatorProjectEditPictureController.php\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 139 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php:130\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php"},"region":{"startLine":130}}}],"partialFingerprints":{"codehealthFindingId/v1":"25a39319f224f3bbae7494964eb04a78d1f8a23314d43003fe37c2437fad5c6a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): src/applications/diffusion/herald/DiffusionCommitRevisionAcceptedHeraldField.php:18-33 | src/applications/diffusion/herald/DiffusionPreCommitContentRevisionAcceptedHeraldField.php:18-33 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/herald/DiffusionCommitRevisionAcceptedHeraldField.php"},"region":{"startLine":18}}}],"partialFingerprints":{"codehealthFindingId/v1":"b7a80cc9d848d962ffc9ba4ad9f922934e88051cd3f2e02719884fc9573f3fbf"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): src/applications/drydock/query/DrydockLeaseQuery.php:90-105 | src/applications/drydock/query/DrydockResourceQuery.php:75-90 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/query/DrydockLeaseQuery.php"},"region":{"startLine":90}}}],"partialFingerprints":{"codehealthFindingId/v1":"cb589748ff12c52a347cbaf5d04f25201d58199df70ae65c81cebda26fb292d1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): src/applications/drydock/typeahead/DrydockLeaseDatasource.php:19-34 | src/applications/drydock/typeahead/DrydockResourceDatasource.php:19-34 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/typeahead/DrydockLeaseDatasource.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"4eb89912951ec9383d0ae38651ba7128361c580e45bbc1c5e6690a79b17d4602"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14\u201316 lines \u00D7 2): src/applications/drydock/worker/DrydockRepositoryOperationUpdateWorker.php:113-128 | src/applications/harbormaster/step/HarbormasterLeaseWorkingCopyBuildStepImplementation.php:50-63 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/worker/DrydockRepositoryOperationUpdateWorker.php"},"region":{"startLine":113}}}],"partialFingerprints":{"codehealthFindingId/v1":"88bee524f083486003d95986411a1a1207a9e2f855ebb1a45a45d1f7eaedb865"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15\u201316 lines \u00D7 2): src/applications/files/controller/PhabricatorFileUploadController.php:92-107 | src/applications/phlux/controller/PhluxEditController.php:163-177 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/controller/PhabricatorFileUploadController.php"},"region":{"startLine":92}}}],"partialFingerprints":{"codehealthFindingId/v1":"9325c7ce17b7d3d7fffc378f7a5e5813e1cb9ad67a87b3c9554dc498eeeef258"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15\u201316 lines \u00D7 2): src/applications/legalpad/controller/LegalpadDocumentSignController.php:580-595 | src/applications/legalpad/controller/LegalpadDocumentSignController.php:646-660 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/legalpad/controller/LegalpadDocumentSignController.php"},"region":{"startLine":580}}}],"partialFingerprints":{"codehealthFindingId/v1":"256a544d4e1061b3053f57bf644476ed57c404fbff56dc5442819a7494088045"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15\u201316 lines \u00D7 2): src/applications/meta/controller/PhabricatorApplicationPanelController.php:11-25 | src/applications/meta/controller/PhabricatorApplicationUninstallController.php:9-24 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/meta/controller/PhabricatorApplicationUninstallController.php:8\u0060 calls \u0060getUser\u0060 and \u0060src/applications/meta/controller/PhabricatorApplicationPanelController.php:9\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/meta/controller/PhabricatorApplicationPanelController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"100b31d9a48c4f0c8c2e2a08f7d9013d7356abb934b3a24e756193813997e88e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): src/applications/metamta/management/PhabricatorMailManagementShowInboundWorkflow.php:35-50 | src/applications/metamta/management/PhabricatorMailManagementShowOutboundWorkflow.php:50-65 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/metamta/management/PhabricatorMailManagementShowInboundWorkflow.php:35\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/management/PhabricatorMailManagementShowInboundWorkflow.php"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"62c54a39b161e449da03d5c2af41d22712d30acae47e14a7d825ea36dd7f52c2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): src/applications/pholio/controller/PholioMockEditController.php:312-327 | src/applications/phriction/controller/PhrictionEditController.php:254-269 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/pholio/controller/PholioMockEditController.php:312\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/pholio/controller/PholioMockEditController.php"},"region":{"startLine":312}}}],"partialFingerprints":{"codehealthFindingId/v1":"0ce7e9d4a70805dab5cda7884c50d4813b1938e2bc263c1dee5006b52e4d97ac"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15\u201316 lines \u00D7 2): src/applications/phortune/controller/account/PhortuneAccountSubscriptionController.php:21-36 | src/applications/phortune/controller/merchant/PhortuneMerchantSubscriptionsController.php:20-34 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/phortune/controller/account/PhortuneAccountSubscriptionController.php:19\u0060 calls \u0060newAccountAuthorityView\u0060 and \u0060src/applications/phortune/controller/merchant/PhortuneMerchantSubscriptionsController.php:18\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountSubscriptionController.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"51f514714db4a3e5696fecc3f880979fe91415803bb3cb1268dc3cfb3d8c0852"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): src/applications/phortune/controller/cart/PhortuneCartViewController.php:50-65 | src/applications/phortune/controller/external/PhortuneExternalOrderController.php:25-40 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phortune/controller/cart/PhortuneCartViewController.php:50\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/phortune/controller/cart/PhortuneCartViewController.php:49\u0060 calls \u0060setResumeURI\u0060 and \u0060src/applications/phortune/controller/external/PhortuneExternalOrderController.php:24\u0060 does not \u2014 after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/cart/PhortuneCartViewController.php"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"b088053336d2e4ec506aa1b247c72ae02d09726a6620f9eca3707c9b6068a4fa"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): src/applications/phortune/controller/merchant/PhortuneMerchantOrderListController.php:13-28 | src/applications/phortune/controller/merchant/PhortuneMerchantSubscriptionListController.php:11-26 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phortune/controller/merchant/PhortuneMerchantOrderListController.php:13\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/merchant/PhortuneMerchantOrderListController.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"819d10f7936354a37fc60d57664cf8dd0beee6bd1bf6ee6f729bdccfeae04249"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): src/applications/phortune/storage/PhortuneCart.php:186-201 | src/applications/phortune/storage/PhortuneCart.php:280-295 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/storage/PhortuneCart.php"},"region":{"startLine":186}}}],"partialFingerprints":{"codehealthFindingId/v1":"a25a79ed79ea266516097c5c8a1743e95e83d7de0a7afe8b2b90c23b0b60ad8d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): src/applications/project/order/PhabricatorProjectColumnAuthorOrder.php:37-52 | src/applications/project/order/PhabricatorProjectColumnOwnerOrder.php:41-56 \u2014 before extracting anything, compare \u0060src/applications/project/order/PhabricatorProjectColumnAuthorOrder.php\u0060 and \u0060src/applications/project/order/PhabricatorProjectColumnOwnerOrder.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 50 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/project/order/PhabricatorProjectColumnAuthorOrder.php:37\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/order/PhabricatorProjectColumnAuthorOrder.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"69c93f5f05d741959127b2e1ae4b9f605c336aec9c33a2719f16a08d41474b91"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): src/applications/project/query/PhabricatorProjectQuery.php:816-831 | src/applications/project/query/PhabricatorProjectQuery.php:853-868 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/query/PhabricatorProjectQuery.php"},"region":{"startLine":816}}}],"partialFingerprints":{"codehealthFindingId/v1":"0824de419ee6be518add5923cb19a3401e189720bdc0e8016a6c1774df02c00c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): src/applications/search/controller/PhabricatorSearchDeleteController.php:7-22 | src/applications/search/controller/PhabricatorSearchEditController.php:7-22 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/search/controller/PhabricatorSearchDeleteController.php:7\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/search/controller/PhabricatorSearchDeleteController.php:24\u0060 calls \u0060newv\u0060, \u0060getEngineClassName\u0060, \u0060array\u0060 and \u0060src/applications/search/controller/PhabricatorSearchEditController.php:24\u0060 does not \u2014 after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/controller/PhabricatorSearchDeleteController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"306014e37229d5c6fc6ee8850b32d0c80f446bf48e5792576a0a515f0d6e6b6f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): src/applications/tokens/event/PhabricatorTokenUIEventListener.php:31-46 | src/applications/tokens/event/PhabricatorTokenUIEventListener.php:82-97 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/tokens/event/PhabricatorTokenUIEventListener.php"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"05c9f284ac8ad1131b83a7985686c6bdc2a0a819381ce242d921e7c0275381f1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 82): src/applications/almanac/query/AlmanacBindingQuery.php:95-109 | src/applications/almanac/query/AlmanacDeviceQuery.php:60-74 | src/applications/almanac/query/AlmanacInterfaceQuery.php:88-102 | src/applications/almanac/query/AlmanacNamespaceQuery.php:36-50 | src/applications/almanac/query/AlmanacNetworkQuery.php:36-50 | src/applications/almanac/query/AlmanacServiceQuery.php:86-100 | src/applications/auth/query/PhabricatorAuthChallengeQuery.php:44-58 | src/applications/auth/query/PhabricatorAuthContactNumberQuery.php:48-62 | src/applications/auth/query/PhabricatorAuthFactorConfigQuery.php:42-56 | src/applications/auth/query/PhabricatorAuthFactorProviderQuery.php:36-50 | src/applications/auth/query/PhabricatorAuthMessageQuery.php:30-44 | src/applications/auth/query/PhabricatorAuthPasswordQuery.php:42-56 | src/applications/auth/query/PhabricatorAuthProviderConfigQuery.php:36-50 | src/applications/auth/query/PhabricatorAuthSSHKeyQuery.php:78-92 | src/applications/auth/query/PhabricatorAuthSessionQuery.php:64-78 | src/applications/auth/query/PhabricatorExternalAccountIdentifierQuery.php:42-56 | src/applications/auth/query/PhabricatorExternalAccountQuery.php:146-160 | src/applications/badges/query/PhabricatorBadgesQuery.php:46-60 | src/applications/calendar/query/PhabricatorCalendarEventQuery.php:358-372 | src/applications/calendar/query/PhabricatorCalendarExportQuery.php:42-56 | src/applications/calendar/query/PhabricatorCalendarExternalInviteeQuery.php:30-44 | src/applications/calendar/query/PhabricatorCalendarImportLogQuery.php:30-44 | src/applications/calendar/query/PhabricatorCalendarImportQuery.php:36-50 | src/applications/countdown/query/PhabricatorCountdownQuery.php:36-50 | src/applications/dashboard/query/PhabricatorDashboardPanelQuery.php:50-64 | src/applications/dashboard/query/PhabricatorDashboardPortalQuery.php:30-44 | src/applications/dashboard/query/PhabricatorDashboardQuery.php:58-72 | src/applications/differential/query/DifferentialDiffQuery.php:123-137 | src/applications/drydock/query/DrydockAuthorizationQuery.php:124-138 | src/applications/drydock/query/DrydockBlueprintQuery.php:147-161 | src/applications/drydock/query/DrydockRepositoryOperationQuery.php:124-138 | src/applications/drydock/query/DrydockResourceQuery.php:94-108 | src/applications/files/query/PhabricatorFileQuery.php:397-411 | src/applications/fund/query/FundInitiativeQuery.php:36-50 | src/applications/harbormaster/query/HarbormasterBuildLogQuery.php:56-70 | src/applications/harbormaster/query/HarbormasterBuildPlanQuery.php:74-88 | src/applications/harbormaster/query/HarbormasterBuildQuery.php:141-155 | src/applications/harbormaster/query/HarbormasterBuildStepQuery.php:30-44 | src/applications/harbormaster/query/HarbormasterBuildTargetQuery.php:73-87 | src/applications/harbormaster/query/HarbormasterBuildUnitMessageQuery.php:30-44 | src/applications/harbormaster/query/HarbormasterBuildableQuery.php:129-143 | src/applications/herald/query/HeraldRuleQuery.php:201-215 | src/applications/herald/query/HeraldWebhookQuery.php:30-44 | src/applications/herald/query/HeraldWebhookRequestQuery.php:44-58 | src/applications/legalpad/query/LegalpadDocumentQuery.php:158-172 | src/applications/macro/query/PhabricatorMacroQuery.php:104-118 | src/applications/metamta/query/PhabricatorMetaMTAMailQuery.php:40-54 | src/applications/packages/query/PhabricatorPackagesPackageQuery.php:48-62 | src/applications/packages/query/PhabricatorPackagesPublisherQuery.php:36-50 | src/applications/packages/query/PhabricatorPackagesVersionQuery.php:48-62 | src/applications/passphrase/query/PassphraseCredentialQuery.php:103-117 | src/applications/paste/query/PhabricatorPasteQuery.php:104-118 | src/applications/phame/query/PhamePostQuery.php:103-117 | src/applications/pholio/query/PholioImageQuery.php:48-62 | src/applications/pholio/query/PholioMockQuery.php:72-86 | src/applications/phortune/query/PhortuneAccountEmailQuery.php:65-79 | src/applications/phortune/query/PhortuneAccountQuery.php:86-100 | src/applications/phortune/query/PhortuneMerchantQuery.php:80-94 | src/applications/phortune/query/PhortunePaymentMethodQuery.php:102-116 | src/applications/phortune/query/PhortuneSubscriptionQuery.php:145-159 | src/applications/phriction/query/PhrictionContentQuery.php:36-50 | src/applications/phriction/query/PhrictionDocumentQuery.php:200-214 | src/applications/phurl/query/PhabricatorPhurlURLQuery.php:54-68 | src/applications/ponder/query/PonderAnswerQuery.php:32-46 | src/applications/ponder/query/PonderQuestionQuery.php:52-66 | src/applications/project/query/PhabricatorProjectColumnQuery.php:172-186 | src/applications/project/query/PhabricatorProjectTriggerQuery.php:39-53 | src/applications/repository/query/PhabricatorRepositoryIdentityQuery.php:70-84 | src/applications/repository/query/PhabricatorRepositoryPullEventQuery.php:80-94 | src/applications/repository/query/PhabricatorRepositoryPushEventQuery.php:81-95 | src/applications/repository/query/PhabricatorRepositoryPushLogQuery.php:89-103 | src/applications/repository/query/PhabricatorRepositoryQuery.php:534-548 | src/applications/repository/query/PhabricatorRepositoryRefCursorQuery.php:93-107 | src/applications/repository/query/PhabricatorRepositorySyncEventQuery.php:67-81 | src/applications/repository/query/PhabricatorRepositoryURIQuery.php:38-52 | src/applications/search/query/PhabricatorProfileMenuItemConfigurationQuery.php:44-58 | src/applications/settings/query/PhabricatorUserPreferencesQuery.php:147-161 | src/applications/slowvote/query/PhabricatorSlowvoteQuery.php:117-131 | src/applications/spaces/query/PhabricatorSpacesNamespaceQuery.php:44-58 | src/applications/transactions/query/PhabricatorApplicationTransactionQuery.php:189-203 | src/applications/transactions/query/PhabricatorEditEngineConfigurationQuery.php:232-246 | src/infrastructure/daemon/workers/query/PhabricatorWorkerBulkJobQuery.php:58-72 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 82 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 82 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/query/AlmanacBindingQuery.php"},"region":{"startLine":95}}}],"partialFingerprints":{"codehealthFindingId/v1":"ff06d7edcef5ff5e8b023d57781f2ad641db4baf93afd8a5220bd0648c68055f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13\u201315 lines \u00D7 8): src/applications/conpherence/controller/ConpherenceRoomPictureController.php:215-229 | src/applications/harbormaster/controller/HarbormasterStepAddController.php:92-104 | src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php:120-133 | src/applications/phame/controller/blog/PhameBlogProfilePictureController.php:221-235 | src/applications/phame/controller/post/PhamePostHeaderPictureController.php:117-130 | src/applications/phortune/controller/merchant/PhortuneMerchantPictureController.php:203-217 | src/applications/phortune/controller/product/PhortuneProductListController.php:54-67 | src/applications/transactions/controller/PhabricatorEditEngineConfigurationDefaultsController.php:111-124 \u2014 before extracting anything, compare \u0060src/applications/conpherence/controller/ConpherenceRoomPictureController.php\u0060 and \u0060src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 57 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/conpherence/controller/ConpherenceRoomPictureController.php:215\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceRoomPictureController.php"},"region":{"startLine":215}}}],"partialFingerprints":{"codehealthFindingId/v1":"7665c492a9a87e4c35a5e903011792f213aedb88ecfd0150eabf383166b5aebd"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 5): src/applications/badges/controller/PhabricatorBadgesArchiveController.php:11-25 | src/applications/badges/controller/PhabricatorBadgesEditRecipientsController.php:12-26 | src/applications/owners/controller/PhabricatorOwnersArchiveController.php:11-25 | src/applications/phame/controller/blog/PhameBlogArchiveController.php:11-25 | src/applications/project/controller/PhabricatorProjectArchiveController.php:11-25 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 5 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 5 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/badges/controller/PhabricatorBadgesArchiveController.php:11\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/badges/controller/PhabricatorBadgesEditRecipientsController.php:9\u0060 calls \u0060array\u0060 and \u0060src/applications/badges/controller/PhabricatorBadgesArchiveController.php:8\u0060 does not \u2014 after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/controller/PhabricatorBadgesArchiveController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"0da00bc005f201549bf42d09f62975d58c647eab6a17103722b1896477396064"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14\u201315 lines \u00D7 4): src/applications/almanac/controller/AlmanacServiceEditController.php:95-108 | src/applications/calendar/controller/PhabricatorCalendarImportEditController.php:75-89 | src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php:233-247 | src/applications/meta/controller/PhabricatorApplicationEditController.php:152-165 \u2014 before extracting anything, compare \u0060src/applications/almanac/controller/AlmanacServiceEditController.php\u0060 and \u0060src/applications/calendar/controller/PhabricatorCalendarImportEditController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 58 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/controller/AlmanacServiceEditController.php"},"region":{"startLine":95}}}],"partialFingerprints":{"codehealthFindingId/v1":"1d040bcf423752df2ab8f0ea815fe164587d5491c22219b43a1127359dbd8b32"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 4): src/applications/auth/query/PhabricatorAuthInviteQuery.php:63-77 | src/applications/phortune/query/PhortunePaymentProviderConfigQuery.php:63-77 | src/applications/phortune/query/PhortuneProductQuery.php:81-95 | src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php:172-186 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/query/PhabricatorAuthInviteQuery.php"},"region":{"startLine":63}}}],"partialFingerprints":{"codehealthFindingId/v1":"34870a97ade1aafd9accb9219bd45d0c83d571c011172f67080fbcc7bcb60e23"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 4): src/applications/auth/xaction/PhabricatorAuthFactorProviderNameTransaction.php:17-31 | src/applications/calendar/xaction/PhabricatorCalendarImportNameTransaction.php:17-31 | src/applications/repository/xaction/PhabricatorRepositoryCallsignTransaction.php:25-39 | src/applications/repository/xaction/PhabricatorRepositoryStagingURITransaction.php:17-31 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 4 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/auth/xaction/PhabricatorAuthFactorProviderNameTransaction.php:17\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/xaction/PhabricatorAuthFactorProviderNameTransaction.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"3a96926e8807c23dcf1a85bb722e585e40e4b1dc1ff8887cc91c14f79d9c7818"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 4): src/applications/differential/typeahead/DifferentialBlockingReviewerDatasource.php:111-125 | src/applications/differential/typeahead/DifferentialExactUserFunctionDatasource.php:98-112 | src/applications/owners/typeahead/PhabricatorOwnersPackageOwnerDatasource.php:132-146 | src/applications/project/typeahead/PhabricatorProjectLogicalUserDatasource.php:121-135 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/typeahead/DifferentialBlockingReviewerDatasource.php"},"region":{"startLine":111}}}],"partialFingerprints":{"codehealthFindingId/v1":"0e8179a5786728876da7e1ce98d441b53c76266e58cd7de9e6bcc8786cb1742e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14\u201315 lines \u00D7 4): src/applications/passphrase/controller/PassphraseCredentialConduitController.php:7-21 | src/applications/passphrase/controller/PassphraseCredentialDestroyController.php:7-21 | src/applications/passphrase/controller/PassphraseCredentialLockController.php:7-21 | src/applications/passphrase/controller/PassphraseCredentialPublicController.php:7-20 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 4 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/passphrase/controller/PassphraseCredentialConduitController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"243a2d30676ea2d3b50bfd725a4e48658eec749b6003992176cf09c052ec05d5"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14\u201315 lines \u00D7 4): src/applications/people/editor/PhabricatorUserEditor.php:222-235 | src/applications/people/editor/PhabricatorUserEditor.php:271-284 | src/applications/people/editor/PhabricatorUserEditor.php:350-363 | src/applications/people/editor/PhabricatorUserEditor.php:404-418 \u2014 all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/people/editor/PhabricatorUserEditor.php:237\u0060 calls \u0060getIsPrimary\u0060, \u0060Exception\u0060, \u0060pht\u0060 and \u0060src/applications/people/editor/PhabricatorUserEditor.php:286\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/editor/PhabricatorUserEditor.php"},"region":{"startLine":222}}}],"partialFingerprints":{"codehealthFindingId/v1":"0c44ea781ef04dcc65347e1f91cbce01933603d26b7762ea0e9e77f7b58904f3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 3): src/applications/auth/controller/contact/PhabricatorAuthContactNumberDisableController.php:7-21 | src/applications/auth/controller/contact/PhabricatorAuthContactNumberPrimaryController.php:7-21 | src/applications/auth/controller/contact/PhabricatorAuthContactNumberTestController.php:7-21 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/auth/controller/contact/PhabricatorAuthContactNumberDisableController.php:23\u0060 calls \u0060getURIData\u0060 and \u0060src/applications/auth/controller/contact/PhabricatorAuthContactNumberPrimaryController.php:23\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/contact/PhabricatorAuthContactNumberDisableController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"76308e620429d477e2db8525db966cce618e2a7f2f743a1cbce986410cbd089e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 3): src/applications/dashboard/controller/dashboard/PhabricatorDashboardArchiveController.php:11-25 | src/applications/paste/controller/PhabricatorPasteArchiveController.php:11-25 | src/applications/slowvote/controller/PhabricatorSlowvoteCloseController.php:11-25 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/dashboard/controller/dashboard/PhabricatorDashboardArchiveController.php:11\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/dashboard/PhabricatorDashboardArchiveController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"6a6486153784e13076d553a86c5e3673b7cbc282a9875846e4b95dc9214d73bf"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13\u201315 lines \u00D7 3): src/applications/drydock/controller/DrydockAuthorizationListController.php:68-82 | src/applications/drydock/controller/DrydockLogController.php:90-103 | src/applications/drydock/controller/DrydockResourceController.php:39-51 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/drydock/controller/DrydockLogController.php:90\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/controller/DrydockAuthorizationListController.php"},"region":{"startLine":68}}}],"partialFingerprints":{"codehealthFindingId/v1":"80c82ea2c0360e1b7c134ecd0857963dc0d8813e79f7f6097d5dad0ff29dd313"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 3): src/applications/drydock/query/DrydockBlueprintSearchEngine.php:124-138 | src/applications/fund/query/FundInitiativeSearchEngine.php:137-151 | src/applications/ponder/query/PonderQuestionSearchEngine.php:166-180 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/drydock/query/DrydockBlueprintSearchEngine.php:124\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/query/DrydockBlueprintSearchEngine.php"},"region":{"startLine":124}}}],"partialFingerprints":{"codehealthFindingId/v1":"e06dd46566992cfc8075a20c188597d3e852723e5619c9fa7dca596db3192b09"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14\u201315 lines \u00D7 3): src/applications/fund/xaction/FundInitiativeNameTransaction.php:32-45 | src/applications/legalpad/xaction/LegalpadDocumentTitleTransaction.php:36-50 | src/applications/passphrase/xaction/PassphraseCredentialNameTransaction.php:32-45 \u2014 before extracting anything, compare \u0060src/applications/fund/xaction/FundInitiativeNameTransaction.php\u0060 and \u0060src/applications/legalpad/xaction/LegalpadDocumentTitleTransaction.php\u0060 as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 76 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fund/xaction/FundInitiativeNameTransaction.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"24db219f4df9c49ba770feb429894733f6a4c7e1bdbf01be6b6510b9579d1eea"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 3): src/applications/harbormaster/controller/HarbormasterPlanViewController.php:477-491 | src/applications/harbormaster/controller/HarbormasterPlanViewController.php:524-538 | src/applications/owners/controller/PhabricatorOwnersDetailController.php:390-404 \u2014 there are 3 copies across 2 file(s) \u2014 more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/harbormaster/controller/HarbormasterPlanViewController.php:477\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/owners/controller/PhabricatorOwnersDetailController.php:405\u0060 calls \u0060setHeaderIcon\u0060, \u0060id\u0060, \u0060PhabricatorHeraldApplication\u0060 and \u0060src/applications/harbormaster/controller/HarbormasterPlanViewController.php:539\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterPlanViewController.php"},"region":{"startLine":477}}}],"partialFingerprints":{"codehealthFindingId/v1":"161ea6518e06179cca7a9fe863854ad5ee17797f38b58981ae16755c10123978"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 3): src/applications/harbormaster/storage/HarbormasterBuildable.php:404-418 | src/applications/harbormaster/storage/build/HarbormasterBuild.php:511-525 | src/applications/harbormaster/storage/build/HarbormasterBuildTarget.php:407-421 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/storage/HarbormasterBuildable.php"},"region":{"startLine":404}}}],"partialFingerprints":{"codehealthFindingId/v1":"3e18881193dbe285e0a7eff6d73a5cd772af35a937045039c842af1e845296a2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 3): src/applications/phame/controller/blog/PhameBlogProfilePictureController.php:84-98 | src/applications/phortune/controller/merchant/PhortuneMerchantPictureController.php:74-88 | src/applications/project/controller/PhabricatorProjectEditPictureController.php:85-99 \u2014 before extracting anything, compare \u0060src/applications/phame/controller/blog/PhameBlogProfilePictureController.php\u0060 and \u0060src/applications/phortune/controller/merchant/PhortuneMerchantPictureController.php\u0060 as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 253 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phame/controller/blog/PhameBlogProfilePictureController.php:84\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/blog/PhameBlogProfilePictureController.php"},"region":{"startLine":84}}}],"partialFingerprints":{"codehealthFindingId/v1":"0b2807459c54c994820b4047bc89833f732847e2699e06373d82e017dcc131e0"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 3): src/applications/phame/xaction/PhameBlogFullDomainTransaction.php:40-54 | src/applications/phame/xaction/PhameBlogParentDomainTransaction.php:33-47 | src/applications/phame/xaction/PhameBlogParentSiteTransaction.php:33-47 \u2014 before extracting anything, compare \u0060src/applications/phame/xaction/PhameBlogParentDomainTransaction.php\u0060 and \u0060src/applications/phame/xaction/PhameBlogParentSiteTransaction.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 53 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/xaction/PhameBlogFullDomainTransaction.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"a40f973db91ea696a0f1fde6c80be674d8686187eabb5e4727118f4f74cfdbb8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 3): src/applications/phortune/controller/account/PhortuneAccountOrderListController.php:20-34 | src/applications/phortune/controller/merchant/PhortuneMerchantOrderListController.php:20-34 | src/applications/phortune/controller/merchant/PhortuneMerchantSubscriptionListController.php:18-32 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountOrderListController.php"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"94a1484e82588ffbf116298e53b4fb78f940522ac926a73277eab1debf126321"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14\u201315 lines \u00D7 3): src/applications/project/controller/PhabricatorProjectBoardDisableController.php:35-49 | src/applications/project/controller/PhabricatorProjectBoardViewController.php:903-916 | src/applications/project/controller/PhabricatorProjectBoardViewController.php:996-1010 \u2014 before extracting anything, compare \u0060src/applications/project/controller/PhabricatorProjectBoardDisableController.php\u0060 and \u0060src/applications/project/controller/PhabricatorProjectBoardViewController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 51 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/project/controller/PhabricatorProjectBoardDisableController.php:35\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/project/controller/PhabricatorProjectBoardViewController.php:1014\u0060 calls \u0060addHiddenInput\u0060 and \u0060src/applications/project/controller/PhabricatorProjectBoardDisableController.php:53\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectBoardDisableController.php"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"c314610916e8add29a4cb66f00f0b8722d325f4aa2d56498e88332fec7376f80"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 3): src/applications/transactions/controller/PhabricatorEditEngineConfigurationLockController.php:34-48 | src/applications/transactions/controller/PhabricatorEditEngineConfigurationReorderController.php:35-49 | src/applications/transactions/controller/PhabricatorEditEngineConfigurationSubtypeController.php:39-53 \u2014 before extracting anything, compare \u0060src/applications/transactions/controller/PhabricatorEditEngineConfigurationLockController.php\u0060 and \u0060src/applications/transactions/controller/PhabricatorEditEngineConfigurationReorderController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 58 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/transactions/controller/PhabricatorEditEngineConfigurationLockController.php:34\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/transactions/controller/PhabricatorEditEngineConfigurationLockController.php:50\u0060 calls \u0060getEngine\u0060 and \u0060src/applications/transactions/controller/PhabricatorEditEngineConfigurationSubtypeController.php:55\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/controller/PhabricatorEditEngineConfigurationLockController.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"30fe87a11f1d9f3c4a88db77c5bab9c4b5895747be35a9207b971bb700dcb121"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): src/applications/almanac/controller/AlmanacServiceViewController.php:53-69 | src/applications/auth/controller/PhabricatorAuthSSHKeyViewController.php:55-69 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/controller/AlmanacServiceViewController.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"359137d017d50a53d4ce97ea5ee42d7fc83e4832c6c8897bb324b02ddfac3bd0"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): src/applications/almanac/query/AlmanacPropertyQuery.php:71-85 | src/applications/conduit/query/PhabricatorConduitTokenQuery.php:42-56 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/query/AlmanacPropertyQuery.php"},"region":{"startLine":71}}}],"partialFingerprints":{"codehealthFindingId/v1":"2cfb6108c5fcc87430e61a013246b2d30233e274d04df5e6027f139f7ee4ce5b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): src/applications/auth/controller/PhabricatorAuthSetPasswordController.php:121-135 | src/applications/settings/panel/PhabricatorPasswordSettingsPanel.php:172-186 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/auth/controller/PhabricatorAuthSetPasswordController.php:121\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthSetPasswordController.php"},"region":{"startLine":121}}}],"partialFingerprints":{"codehealthFindingId/v1":"ef1996dcf7a2a8584a92d42fc1322aa02c2c268d56b815764c81c161fed10c1a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): src/applications/auth/editor/PhabricatorAuthSSHKeyEditor.php:111-125 | src/applications/oauthserver/editor/PhabricatorOAuthServerEditor.php:96-110 \u2014 before extracting anything, compare \u0060src/applications/auth/editor/PhabricatorAuthSSHKeyEditor.php\u0060 and \u0060src/applications/oauthserver/editor/PhabricatorOAuthServerEditor.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 45 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/auth/editor/PhabricatorAuthSSHKeyEditor.php:107\u0060 calls \u0060requireActor\u0060 and \u0060src/applications/oauthserver/editor/PhabricatorOAuthServerEditor.php:92\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/editor/PhabricatorAuthSSHKeyEditor.php"},"region":{"startLine":111}}}],"partialFingerprints":{"codehealthFindingId/v1":"88b4003402c8ef30ee37c3a45605d41065c7eb0692f7479661a9edb110d41ce8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): src/applications/auth/management/PhabricatorAuthManagementTrustOAuthClientWorkflow.php:46-60 | src/applications/auth/management/PhabricatorAuthManagementUntrustOAuthClientWorkflow.php:46-60 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/auth/management/PhabricatorAuthManagementTrustOAuthClientWorkflow.php:46\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/management/PhabricatorAuthManagementTrustOAuthClientWorkflow.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"d542cc4459adc95b4853c085fcba5866d165d28f521f9c98b8e3a4e8abf1104f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): src/applications/badges/controller/PhabricatorBadgesArchiveController.php:7-21 | src/applications/badges/controller/PhabricatorBadgesRemoveRecipientsController.php:7-21 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/badges/controller/PhabricatorBadgesRemoveRecipientsController.php:23\u0060 calls \u0060getStr\u0060 and \u0060src/applications/badges/controller/PhabricatorBadgesArchiveController.php:23\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/controller/PhabricatorBadgesArchiveController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"f95969a4293827e63f64dec45a9dfddcf8581ca797be9b5749f0bf3770ab467f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): src/applications/calendar/controller/PhabricatorCalendarImportReloadController.php:10-24 | src/applications/harbormaster/controller/HarbormasterPlanDisableController.php:10-24 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/calendar/controller/PhabricatorCalendarImportReloadController.php:10\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/controller/PhabricatorCalendarImportReloadController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"68cbbd63daa26e49f2d7669143e8dd87d180214f13f07c35925333541de408c7"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): src/applications/calendar/xaction/PhabricatorCalendarEventFrequencyTransaction.php:53-70 | src/applications/project/xaction/column/PhabricatorProjectColumnStatusTransaction.php:41-55 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/calendar/xaction/PhabricatorCalendarEventFrequencyTransaction.php:53\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/xaction/PhabricatorCalendarEventFrequencyTransaction.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"2b2d8662e6c1c7ef7d3a8900f2e15a61f0b0bf63042998b7930c01ae9326067d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12\u201315 lines \u00D7 2): src/applications/conpherence/conduit/ConpherenceQueryTransactionConduitAPIMethod.php:43-57 | src/applications/conpherence/conduit/ConpherenceUpdateThreadConduitAPIMethod.php:54-65 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/conduit/ConpherenceQueryTransactionConduitAPIMethod.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"2d5947ddd2838ff9d7f4e70861b8cad31cea92f1170064c5ae825ca135570a4a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10\u201315 lines \u00D7 2): src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php:156-165 | src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php:207-221 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php:156\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php"},"region":{"startLine":156}}}],"partialFingerprints":{"codehealthFindingId/v1":"07da23e33fe455aa62daeb2d05c7a30d3b04adf652d346023bd8f13360e0ddb2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): src/applications/diffusion/controller/DiffusionDocumentController.php:28-42 | src/applications/files/controller/PhabricatorFileDocumentController.php:19-33 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionDocumentController.php"},"region":{"startLine":28}}}],"partialFingerprints":{"codehealthFindingId/v1":"870ee7170a6c15f87872eeb9ca9db66c12be0e95d87e7bed1d758cb79c3ddce3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): src/applications/diffusion/query/DiffusionCommitHintQuery.php:60-74 | src/applications/repository/query/PhabricatorRepositoryGitLFSRefQuery.php:30-44 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/DiffusionCommitHintQuery.php"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"178387a89934525a115d794ed0fd1a21aca7217286fddee226cb307ca52e0036"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): src/applications/diffusion/typeahead/DiffusionTaggedRepositoriesFunctionDatasource.php:87-101 | src/applications/project/typeahead/PhabricatorProjectMembersDatasource.php:79-93 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/diffusion/typeahead/DiffusionTaggedRepositoriesFunctionDatasource.php:87\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/typeahead/DiffusionTaggedRepositoriesFunctionDatasource.php"},"region":{"startLine":87}}}],"partialFingerprints":{"codehealthFindingId/v1":"39093b55c09536f8de0ce7a7d51cf94779758a178c02b699d77b4fac6c83fed3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): src/applications/maniphest/query/ManiphestTaskQuery.php:325-339 | src/applications/ponder/query/PonderQuestionQuery.php:108-122 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/query/ManiphestTaskQuery.php"},"region":{"startLine":325}}}],"partialFingerprints":{"codehealthFindingId/v1":"10f3c8d7dbaf345a9906ee091f6a7534644ff5e611203573e7bb4bcfce3d5834"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): src/applications/maniphest/search/ManiphestTaskFulltextEngine.php:14-28 | src/applications/pholio/search/PholioMockFulltextEngine.php:14-28 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/maniphest/search/ManiphestTaskFulltextEngine.php:14\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/search/ManiphestTaskFulltextEngine.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"4383a161d4d267e586d787b8f31552d6fccc9dcdb46d78ee93db3e3741b9e3de"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12\u201315 lines \u00D7 2): src/applications/metamta/management/PhabricatorMailManagementReceiveTestWorkflow.php:74-85 | src/applications/people/management/PhabricatorPeopleManagementWorkflow.php:20-34 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/metamta/management/PhabricatorMailManagementReceiveTestWorkflow.php:74\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/management/PhabricatorMailManagementReceiveTestWorkflow.php"},"region":{"startLine":74}}}],"partialFingerprints":{"codehealthFindingId/v1":"1d23fee2bc2a1c0eb51ea8d049800cf5391d13d331186dab69c148a97ea5b68b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14\u201315 lines \u00D7 2): src/applications/passphrase/controller/PassphraseCredentialCreateController.php:52-65 | src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php:281-295 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php:281\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/passphrase/controller/PassphraseCredentialCreateController.php"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"000beb9143451b733bc74732bc4d65f5540e73d38bcab42ec7590429a2394045"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php:65-79 | src/applications/phame/controller/blog/PhameBlogProfilePictureController.php:81-95 \u2014 before extracting anything, compare \u0060src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php\u0060 and \u0060src/applications/phame/controller/blog/PhameBlogProfilePictureController.php\u0060 as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 135 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php:65\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php"},"region":{"startLine":65}}}],"partialFingerprints":{"codehealthFindingId/v1":"daa22d48ed1628e2a5306b25d61a0ee976dbc47e01050733363696e033adcb38"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14\u201315 lines \u00D7 2): src/applications/phame/controller/post/PhamePostViewController.php:236-249 | src/applications/phame/controller/post/PhamePostViewController.php:259-273 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phame/controller/post/PhamePostViewController.php:259\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/post/PhamePostViewController.php"},"region":{"startLine":236}}}],"partialFingerprints":{"codehealthFindingId/v1":"818cf599298e5e7f60e9c6fa179caad8b37e132add2e90e86d4e7c77864d137a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): src/applications/phortune/controller/paymentmethod/PhortunePaymentMethodDisableController.php:7-21 | src/applications/phortune/controller/paymentmethod/PhortunePaymentMethodEditController.php:7-21 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/paymentmethod/PhortunePaymentMethodDisableController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"839e6e748b8d68d2fa7f3b5f9dc1942c8ca05f5550eeec41fe5e50a682be7ec8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): src/applications/phriction/controller/PhrictionDeleteController.php:7-21 | src/applications/phriction/controller/PhrictionPublishController.php:9-23 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/controller/PhrictionDeleteController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"d66f0062e771cb2864b71e68aac4ed1e37800249b39c65a6759240a646c5b6c2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): src/applications/project/chart/PhabricatorProjectActivityChartEngine.php:15-29 | src/applications/project/chart/PhabricatorProjectBurndownChartEngine.php:15-29 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/chart/PhabricatorProjectActivityChartEngine.php"},"region":{"startLine":15}}}],"partialFingerprints":{"codehealthFindingId/v1":"ad8227c6573c05612d8d48e076ec1d2ee49a38acf72001075106ecd0dd1ea0f1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): src/applications/project/controller/PhabricatorProjectArchiveController.php:7-21 | src/applications/project/controller/PhabricatorProjectMembersAddController.php:7-21 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectArchiveController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"6212349dd1c45f39586282650584c699b531caf9bf61efae6e78f8cbc2aa4b03"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): src/applications/project/controller/PhabricatorProjectBoardBackgroundController.php:8-22 | src/applications/project/controller/PhabricatorProjectEditPictureController.php:8-22 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectBoardBackgroundController.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"2f936cd6180da22b8e40efe8694c45b12183d0747dfadc87577eb2c99e40d49f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14\u201315 lines \u00D7 2): src/applications/repository/management/PhabricatorRepositoryManagementDiscoverWorkflow.php:31-44 | src/applications/repository/management/PhabricatorRepositoryManagementRefsWorkflow.php:31-45 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/repository/management/PhabricatorRepositoryManagementDiscoverWorkflow.php:31\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/management/PhabricatorRepositoryManagementDiscoverWorkflow.php"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"79ab1404db98f5a402d7786946a97b6dc475c2105b59bc1cd5329af48aaf35a8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): src/applications/repository/query/PhabricatorRepositoryPullEventQuery.php:47-61 | src/applications/repository/query/PhabricatorRepositorySyncEventQuery.php:38-52 \u2014 before extracting anything, compare \u0060src/applications/repository/query/PhabricatorRepositoryPullEventQuery.php\u0060 and \u0060src/applications/repository/query/PhabricatorRepositorySyncEventQuery.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 50 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/repository/query/PhabricatorRepositoryPullEventQuery.php:47\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/query/PhabricatorRepositoryPullEventQuery.php"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"88ba50eb4ae5058fda697a41c177b2ee5eca943e784c21dbce3d8441b6b8450a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): src/applications/search/engine/PhabricatorApplicationSearchEngine.php:1571-1585 | src/applications/search/engine/PhabricatorApplicationSearchEngine.php:1589-1603 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorApplicationSearchEngine.php"},"region":{"startLine":1571}}}],"partialFingerprints":{"codehealthFindingId/v1":"da7a73aa07dd9a673120305ec46b976746934cb9329763d2ddf9a03fc4ad3526"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): src/applications/search/query/PhabricatorNamedQueryConfigQuery.php:30-44 | src/applications/search/query/PhabricatorNamedQueryQuery.php:36-50 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/query/PhabricatorNamedQueryConfigQuery.php"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"e4b803c56b6a65b7f3322d8855a3f195304a3f9cb6b6b7646dcbe4e09a9f7415"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 6): src/applications/conpherence/query/ConpherenceThreadQuery.php:106-119 | src/applications/phame/query/PhameBlogQuery.php:86-99 | src/applications/phame/query/PhameBlogQuery.php:114-127 | src/applications/phame/query/PhamePostQuery.php:78-91 | src/applications/phortune/query/PhortuneMerchantQuery.php:49-62 | src/applications/repository/query/PhabricatorRepositoryQuery.php:382-395 \u2014 there are 6 copies across 5 file(s) \u2014 more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 6 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/conpherence/query/ConpherenceThreadQuery.php:106\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/query/ConpherenceThreadQuery.php"},"region":{"startLine":106}}}],"partialFingerprints":{"codehealthFindingId/v1":"ed83973d0594b95373ec63fed69016424398f361840e1e93cb1700c471de8d0f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 4): src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php:107-120 | src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php:170-183 | src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php:217-230 | src/applications/dashboard/editor/PhabricatorDashboardPanelEditEngine.php:165-178 \u2014 there are 4 copies across 2 file(s) \u2014 more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php:122\u0060 calls \u0060id\u0060, \u0060AphrontRedirectResponse\u0060, \u0060setURI\u0060 and \u0060src/applications/dashboard/editor/PhabricatorDashboardPanelEditEngine.php:179\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php"},"region":{"startLine":107}}}],"partialFingerprints":{"codehealthFindingId/v1":"6528b117beb7db59b2ca9cab7fd13235fdb2301a94f25bcea60ce02af2015763"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 4): src/applications/files/controller/PhabricatorFileViewController.php:79-92 | src/applications/harbormaster/controller/HarbormasterPlanViewController.php:72-88 | src/applications/legalpad/controller/LegalpadDocumentManageController.php:64-77 | src/applications/phurl/controller/PhabricatorPhurlURLViewController.php:45-59 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 4 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phurl/controller/PhabricatorPhurlURLViewController.php:45\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/controller/PhabricatorFileViewController.php"},"region":{"startLine":79}}}],"partialFingerprints":{"codehealthFindingId/v1":"8e412a9817f07986a6a9ac45a480489bbe05aa758687117761d0461c7832ab11"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13\u201314 lines \u00D7 3): src/applications/auth/editor/PhabricatorAuthSSHKeyEditor.php:111-124 | src/applications/auth/editor/PhabricatorAuthSSHKeyEditor.php:128-140 | src/applications/oauthserver/editor/PhabricatorOAuthServerEditor.php:96-109 \u2014 before extracting anything, compare \u0060src/applications/auth/editor/PhabricatorAuthSSHKeyEditor.php\u0060 and \u0060src/applications/oauthserver/editor/PhabricatorOAuthServerEditor.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 45 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/auth/editor/PhabricatorAuthSSHKeyEditor.php:128\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/auth/editor/PhabricatorAuthSSHKeyEditor.php:107\u0060 calls \u0060requireActor\u0060 and \u0060src/applications/oauthserver/editor/PhabricatorOAuthServerEditor.php:92\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/editor/PhabricatorAuthSSHKeyEditor.php"},"region":{"startLine":111}}}],"partialFingerprints":{"codehealthFindingId/v1":"9e990020cdaa6b12ce24e3e8f4041bd3c00d9a6f3310dddd8000bcfe06ad3579"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 3): src/applications/diffusion/herald/DiffusionCommitAuthorPackagesHeraldField.php:13-26 | src/applications/diffusion/herald/DiffusionCommitCommitterPackagesHeraldField.php:13-26 | src/applications/diffusion/herald/DiffusionPreCommitContentAuthorPackagesHeraldField.php:13-26 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/herald/DiffusionCommitAuthorPackagesHeraldField.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"23afb01d0ebfd5bd863c7ebe7a82ca9ac754167f4563e88685db309d7d14d4c6"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12\u201314 lines \u00D7 3): src/applications/drydock/typeahead/DrydockBlueprintDatasource.php:25-38 | src/applications/herald/typeahead/HeraldRuleDatasource.php:37-48 | src/applications/herald/typeahead/HeraldWebhookDatasource.php:24-37 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/drydock/typeahead/DrydockBlueprintDatasource.php:25\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/typeahead/DrydockBlueprintDatasource.php"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"8080459c13f38e70487a19f284660a5d6815eaf27f93b19d32f593df2b7afbd8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 3): src/applications/harbormaster/controller/HarbormasterPlanBehaviorController.php:7-20 | src/applications/harbormaster/controller/HarbormasterPlanDisableController.php:7-20 | src/applications/harbormaster/controller/HarbormasterStepAddController.php:7-20 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterPlanBehaviorController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"bfa87abc8d1770e0bf6ca90fac05ff9fbc6921c020fd5649595f96318fda0f34"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 3): src/applications/harbormaster/controller/HarbormasterPlanViewController.php:484-497 | src/applications/harbormaster/controller/HarbormasterPlanViewController.php:531-544 | src/applications/herald/controller/HeraldWebhookViewController.php:222-235 \u2014 there are 3 copies across 2 file(s) \u2014 more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterPlanViewController.php"},"region":{"startLine":484}}}],"partialFingerprints":{"codehealthFindingId/v1":"f22076f096454e63c4889632bea59d5ba05be19c6d09e9d1985d92f0e907a724"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 3): src/applications/meta/controller/PhabricatorApplicationEditController.php:8-21 | src/applications/meta/controller/PhabricatorApplicationPanelController.php:12-27 | src/applications/meta/controller/PhabricatorApplicationUninstallController.php:10-24 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/meta/controller/PhabricatorApplicationUninstallController.php:8\u0060 calls \u0060getUser\u0060 and \u0060src/applications/meta/controller/PhabricatorApplicationPanelController.php:9\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/meta/controller/PhabricatorApplicationEditController.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"c72859461afcf357d060a390c61150fbe018634b478c31281460b5ef712a32ec"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10\u201314 lines \u00D7 2): src/applications/almanac/management/AlmanacManagementUntrustKeyWorkflow.php:30-39 | src/applications/auth/management/PhabricatorAuthManagementUntrustOAuthClientWorkflow.php:35-48 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/almanac/management/AlmanacManagementUntrustKeyWorkflow.php:30\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/management/AlmanacManagementUntrustKeyWorkflow.php"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"0f5aba874365d3e2d4683d559f0ed3ac807e45f52424c8f230bb6c838dec3e8d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/almanac/query/AlmanacBindingQuery.php:53-66 | src/applications/almanac/query/AlmanacInterfaceQuery.php:46-59 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/query/AlmanacBindingQuery.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"fbde5c4a14e10111a1ab993e704a3d0ff904e920dbdbcb67b6e70a86dfbb58a1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12\u201314 lines \u00D7 2): src/applications/audit/management/PhabricatorAuditManagementDeleteWorkflow.php:236-247 | src/applications/auth/management/PhabricatorAuthManagementStripWorkflow.php:73-86 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/management/PhabricatorAuditManagementDeleteWorkflow.php"},"region":{"startLine":236}}}],"partialFingerprints":{"codehealthFindingId/v1":"9b8ccec4e23b1fdf35a505cc942c9085d201a741ace4650d522c752767181c0d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/audit/management/PhabricatorAuditManagementDeleteWorkflow.php:275-288 | src/applications/audit/management/PhabricatorAuditManagementDeleteWorkflow.php:315-328 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/management/PhabricatorAuditManagementDeleteWorkflow.php"},"region":{"startLine":275}}}],"partialFingerprints":{"codehealthFindingId/v1":"c4b120d632e452ad4a2d4994b1fb6850229ab0b5d9d3adec9e60b3084f0bfc29"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/auth/controller/config/PhabricatorAuthDisableController.php:12-25 | src/applications/auth/controller/config/PhabricatorAuthProviderViewController.php:11-24 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/auth/controller/config/PhabricatorAuthDisableController.php:12\u0060 calls \u0060getURIData\u0060 and \u0060src/applications/auth/controller/config/PhabricatorAuthProviderViewController.php:11\u0060 does not \u2014 after which the two agree again for 5 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/config/PhabricatorAuthDisableController.php"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"d6adb53767a0e589df5ff73f8efec878073bd4cb238cb24200780cc1a5d30751"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/auth/controller/contact/PhabricatorAuthContactNumberDisableController.php:11-24 | src/applications/drydock/controller/DrydockBlueprintDisableController.php:11-24 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/contact/PhabricatorAuthContactNumberDisableController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"8c8bc97a96a0614f43602bb0092d5baf456602844bc3410e15bc1b246b3cc5ce"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/badges/controller/PhabricatorBadgesRemoveRecipientsController.php:34-47 | src/applications/project/controller/PhabricatorProjectMembersRemoveController.php:53-66 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/badges/controller/PhabricatorBadgesRemoveRecipientsController.php:34\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/controller/PhabricatorBadgesRemoveRecipientsController.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"c314df9230275e3935bfa8c852753806042abb27d6ddd7be2fdbe7774e3fada6"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13\u201314 lines \u00D7 2): src/applications/calendar/controller/PhabricatorCalendarEventViewController.php:105-118 | src/applications/calendar/controller/PhabricatorCalendarExportViewController.php:57-69 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/calendar/controller/PhabricatorCalendarEventViewController.php:105\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/controller/PhabricatorCalendarEventViewController.php"},"region":{"startLine":105}}}],"partialFingerprints":{"codehealthFindingId/v1":"694990621b606d515d362779717860b862bcf109686f0c5aab50ff6f0daac69c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/calendar/controller/PhabricatorCalendarExportDisableController.php:10-23 | src/applications/calendar/controller/PhabricatorCalendarImportDisableController.php:10-23 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/controller/PhabricatorCalendarExportDisableController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"5ffe789836e175a05f3a5605edea43efaa5e145b0fa0d662d768658c56062227"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/calendar/controller/PhabricatorCalendarExportViewController.php:53-66 | src/applications/calendar/controller/PhabricatorCalendarImportViewController.php:61-74 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/controller/PhabricatorCalendarExportViewController.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"c37743d99395b49af952710e7f0ffce8424239a8722036c1f2067d1a0d721951"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/calendar/xaction/PhabricatorCalendarEventInviteTransaction.php:128-141 | src/applications/maniphest/xaction/ManiphestTaskAttachTransaction.php:33-46 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/calendar/xaction/PhabricatorCalendarEventInviteTransaction.php:128\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/xaction/PhabricatorCalendarEventInviteTransaction.php"},"region":{"startLine":128}}}],"partialFingerprints":{"codehealthFindingId/v1":"71a92577780799095a1b0ddfa0138a19b5a30f824b1aba2c5f22a46ac8690274"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/config/management/PhabricatorConfigManagementDeleteWorkflow.php:27-40 | src/applications/config/management/PhabricatorConfigManagementGetWorkflow.php:21-34 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/management/PhabricatorConfigManagementDeleteWorkflow.php"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"6bdb9db2cb895336d5b574211a671277916d5403abb6917eab25f827945b9c19"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/conpherence/xaction/ConpherenceThreadTitleTransaction.php:17-30 | src/applications/phortune/xaction/PhortuneAccountNameTransaction.php:17-30 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/xaction/ConpherenceThreadTitleTransaction.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"3f48fdd28214ab47455d703ead638e205854bcfb68ae5d2fbcdc2e7cec5cac86"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13\u201314 lines \u00D7 2): src/applications/differential/controller/DifferentialChangesetViewController.php:123-135 | src/applications/differential/controller/DifferentialController.php:173-186 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/controller/DifferentialChangesetViewController.php"},"region":{"startLine":123}}}],"partialFingerprints":{"codehealthFindingId/v1":"a23b985e6f39625786b6685f5f742371c3897461dc9e77196bc838046c094d54"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/diffusion/conduit/DiffusionGetLintMessagesConduitAPIMethod.php:32-45 | src/applications/diffusion/conduit/DiffusionUpdateCoverageConduitAPIMethod.php:38-51 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/conduit/DiffusionGetLintMessagesConduitAPIMethod.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"20349f0b837bcfca5270bbb465458c36c7059e964200c582d6f8f215dc89c9db"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php:267-280 | src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php:287-300 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php"},"region":{"startLine":267}}}],"partialFingerprints":{"codehealthFindingId/v1":"3d89bf8467a5c37b567dbe3c99605d117648114d760d8da71febb7626cd4319d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/diffusion/herald/DiffusionCommitAuthorProjectsHeraldField.php:13-26 | src/applications/diffusion/herald/DiffusionPreCommitContentAuthorProjectsHeraldField.php:13-26 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/herald/DiffusionCommitAuthorProjectsHeraldField.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"093e28d003254c04b7675b3c63a1ee134974a78cb79d20238ab2aef80ffee3d9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/diffusion/herald/DiffusionCommitCommitterProjectsHeraldField.php:13-26 | src/applications/diffusion/herald/DiffusionPreCommitContentCommitterProjectsHeraldField.php:13-26 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/herald/DiffusionCommitCommitterProjectsHeraldField.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"778fce65c611fc74cc8ed3c0490688498a24ea1bdd692c3af85079cff6f046bb"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/diffusion/herald/DiffusionCommitRevisionAcceptingReviewersHeraldField.php:19-32 | src/applications/diffusion/herald/DiffusionPreCommitContentRevisionAcceptingReviewersHeraldField.php:19-32 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/herald/DiffusionCommitRevisionAcceptingReviewersHeraldField.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"fc9c8437f48db76a7829ee85858c50dcde5f90a9935fb0c113475f237f39d19f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php:549-562 | src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php:580-593 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php:549\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php"},"region":{"startLine":549}}}],"partialFingerprints":{"codehealthFindingId/v1":"a335be622fce7bcb7d97d28034dd93077e96d78c7587e595c00d6a753ced58ba"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13\u201314 lines \u00D7 2): src/applications/drydock/controller/DrydockLeaseController.php:39-52 | src/applications/drydock/controller/DrydockLogController.php:105-117 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/drydock/controller/DrydockLeaseController.php:39\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/controller/DrydockLeaseController.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"f98cf868d55237695f98c0ecb0d8bdaef44f05af32e435264a31325c5a816435"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/drydock/query/DrydockAuthorizationQuery.php:98-111 | src/applications/drydock/query/DrydockRepositoryOperationQuery.php:103-116 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/drydock/query/DrydockAuthorizationQuery.php:98\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/query/DrydockAuthorizationQuery.php"},"region":{"startLine":98}}}],"partialFingerprints":{"codehealthFindingId/v1":"41214166ac62db7ee77b55ba16a4bf201f279ba4bfdb31ea9290e2f30aa14f61"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13\u201314 lines \u00D7 2): src/applications/files/diff/PhabricatorDocumentEngineBlocks.php:101-114 | src/applications/files/diff/PhabricatorDocumentEngineBlocks.php:116-128 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/diff/PhabricatorDocumentEngineBlocks.php"},"region":{"startLine":101}}}],"partialFingerprints":{"codehealthFindingId/v1":"b9036cf3b877d7621049cb85ef98e0466a5e90fb64c6ea85ebbffd6a15db54ba"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/harbormaster/query/HarbormasterBuildQuery.php:64-77 | src/applications/harbormaster/query/HarbormasterBuildableQuery.php:71-84 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/harbormaster/query/HarbormasterBuildQuery.php:64\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/query/HarbormasterBuildQuery.php"},"region":{"startLine":64}}}],"partialFingerprints":{"codehealthFindingId/v1":"e72cf7a9a90fade123aedaa38c5887e140dca6421562bececf41f0805a0275b2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/herald/controller/HeraldWebhookKeyController.php:7-20 | src/applications/herald/controller/HeraldWebhookTestController.php:7-20 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/controller/HeraldWebhookKeyController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"892c10f0a0231a1c3c838457849268aa6bac2dad39b923bf8beebe9e38af7fc4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13\u201314 lines \u00D7 2): src/applications/legalpad/controller/LegalpadDocumentSignController.php:561-574 | src/applications/legalpad/controller/LegalpadDocumentSignController.php:614-626 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/legalpad/controller/LegalpadDocumentSignController.php"},"region":{"startLine":561}}}],"partialFingerprints":{"codehealthFindingId/v1":"78bce3afb0661758ab4694fb188dceedc54dde9b413665b2de227e3267b6a931"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13\u201314 lines \u00D7 2): src/applications/macro/xaction/PhabricatorMacroAudioTransaction.php:46-59 | src/applications/maniphest/xaction/ManiphestTaskOwnerTransaction.php:94-106 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/maniphest/xaction/ManiphestTaskOwnerTransaction.php:94\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/macro/xaction/PhabricatorMacroAudioTransaction.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"c39279938f030d68272304f4230da7d3183c5cbd0656efd4d42c09494cace62b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/maniphest/xaction/ManiphestTaskAttachTransaction.php:16-29 | src/applications/maniphest/xaction/ManiphestTaskAttachTransaction.php:51-64 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/maniphest/xaction/ManiphestTaskAttachTransaction.php:16\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/xaction/ManiphestTaskAttachTransaction.php"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"ade549a7590bda8cb94581f5261d92b7f4fa9039d806e1a8c3369f5b5c88d3ab"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/metamta/management/PhabricatorMailManagementResendWorkflow.php:34-47 | src/applications/metamta/management/PhabricatorMailManagementShowOutboundWorkflow.php:49-62 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/management/PhabricatorMailManagementResendWorkflow.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"a9c44755d5d547a9101f3339e366f4c010e9a2cf00f8467d1fc0f1d5f2963de3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/nuance/controller/NuanceQueueViewController.php:7-20 | src/applications/nuance/controller/NuanceQueueWorkController.php:7-20 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/controller/NuanceQueueViewController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"a0dd2db3970f85c7ecf2ebaf20eda057bb89db1e798fb9726901b56ac46f90c2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/oauthserver/controller/client/PhabricatorOAuthClientDisableController.php:9-22 | src/applications/oauthserver/controller/client/PhabricatorOAuthClientSecretController.php:9-22 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/oauthserver/controller/client/PhabricatorOAuthClientDisableController.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"dddd08f499b4591f27da456ae90256d0418d2fc25ad04e5062ff7dfe3d1b7a84"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/phame/controller/post/PhamePostArchiveController.php:28-41 | src/applications/phame/controller/post/PhamePostPublishController.php:36-49 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phame/controller/post/PhamePostArchiveController.php:28\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/post/PhamePostArchiveController.php"},"region":{"startLine":28}}}],"partialFingerprints":{"codehealthFindingId/v1":"2e636ead1d2dca7fcc8ec0716930ca0bb8ec4ab6b01ab680ed063c40cba65e29"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12\u201314 lines \u00D7 2): src/applications/pholio/query/PholioMockSearchEngine.php:67-80 | src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php:84-95 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/pholio/query/PholioMockSearchEngine.php:67\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php:97\u0060 calls \u0060setParameter\u0060, \u0060array\u0060 and \u0060src/applications/pholio/query/PholioMockSearchEngine.php:81\u0060 does not \u2014 after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/pholio/query/PholioMockSearchEngine.php"},"region":{"startLine":67}}}],"partialFingerprints":{"codehealthFindingId/v1":"937108a53037aebfd595b0b12a5d3937cb26856819066cc169bb5c4370983821"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/phortune/controller/account/PhortuneAccountAddManagerController.php:64-77 | src/applications/phortune/controller/merchant/PhortuneMerchantAddManagerController.php:50-63 \u2014 before extracting anything, compare \u0060src/applications/phortune/controller/account/PhortuneAccountAddManagerController.php\u0060 and \u0060src/applications/phortune/controller/merchant/PhortuneMerchantAddManagerController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 37 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountAddManagerController.php"},"region":{"startLine":64}}}],"partialFingerprints":{"codehealthFindingId/v1":"17bc80bdab3af4b7fbc7177c08bcc84b0bc222b2e9780ae4b30e2fb421fb1550"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/phriction/conduit/PhrictionCreateConduitAPIMethod.php:57-70 | src/applications/phriction/conduit/PhrictionEditConduitAPIMethod.php:61-74 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/conduit/PhrictionCreateConduitAPIMethod.php"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"8f6cb0f2f757226124f11e3ba396ea9a5cc899b6eba4cb168dd6078bf2007c1b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13\u201314 lines \u00D7 2): src/applications/project/controller/PhabricatorProjectBoardBackgroundController.php:18-31 | src/applications/project/controller/PhabricatorProjectBoardDisableController.php:18-30 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/project/controller/PhabricatorProjectBoardBackgroundController.php:18\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/project/controller/PhabricatorProjectBoardDisableController.php:17\u0060 calls \u0060withIDs\u0060, \u0060array\u0060, \u0060executeOne\u0060 and \u0060src/applications/project/controller/PhabricatorProjectBoardBackgroundController.php:18\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectBoardBackgroundController.php"},"region":{"startLine":18}}}],"partialFingerprints":{"codehealthFindingId/v1":"e6a4f152beb4132b91597f270fcccfb0c58c7784593e5586ff93f9486b10b806"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/project/controller/PhabricatorProjectReportsController.php:11-24 | src/applications/project/controller/PhabricatorProjectSubprojectsController.php:11-24 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectReportsController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"6ada0ba5d3dabe723a0615bfc3a470f8f94d39ac268236dc0151d3cde7c707e9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/project/controller/PhabricatorProjectSubprojectsController.php:38-51 | src/applications/project/controller/PhabricatorProjectSubprojectsController.php:60-73 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/project/controller/PhabricatorProjectSubprojectsController.php:38\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/project/controller/PhabricatorProjectSubprojectsController.php:59\u0060 calls \u0060setOrderVector\u0060, \u0060array\u0060 and \u0060src/applications/project/controller/PhabricatorProjectSubprojectsController.php:37\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectSubprojectsController.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"390b270fd11dc153820d841783ee6972e86835006062b2e59be441fe29bb24e3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/project/order/PhabricatorProjectColumnAuthorOrder.php:82-95 | src/applications/project/order/PhabricatorProjectColumnOwnerOrder.php:103-116 \u2014 before extracting anything, compare \u0060src/applications/project/order/PhabricatorProjectColumnAuthorOrder.php\u0060 and \u0060src/applications/project/order/PhabricatorProjectColumnOwnerOrder.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 50 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/project/order/PhabricatorProjectColumnOwnerOrder.php:118\u0060 calls \u0060array_unshift\u0060 and \u0060src/applications/project/order/PhabricatorProjectColumnAuthorOrder.php:97\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/order/PhabricatorProjectColumnAuthorOrder.php"},"region":{"startLine":82}}}],"partialFingerprints":{"codehealthFindingId/v1":"db23543b8ab12fe700aca504a4f8b95d694598eeb12e0fb780ad2ae2a27b1b4f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13\u201314 lines \u00D7 2): src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php:299-312 | src/applications/system/management/PhabricatorSystemRemoveDestroyWorkflow.php:33-45 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php"},"region":{"startLine":299}}}],"partialFingerprints":{"codehealthFindingId/v1":"2e5783a8e7503abe3a0c2a15e19c36e8a5c11fa3fb72a6874ed5ab80a9a15c6b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDestroyWorkflow.php:33-46 | src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDestroyWorkflow.php:54-67 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDestroyWorkflow.php:33\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDestroyWorkflow.php"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"a584d54bee1d317bae42c61a59e4b4c3b4b407504555d97651c97be2af1673ad"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9\u201313 lines \u00D7 19): src/applications/badges/xaction/PhabricatorBadgesBadgeNameTransaction.php:38-48 | src/applications/conpherence/xaction/ConpherenceThreadTitleTransaction.php:58-68 | src/applications/countdown/xaction/PhabricatorCountdownTitleTransaction.php:39-47 | src/applications/drydock/xaction/DrydockBlueprintNameTransaction.php:42-53 | src/applications/files/xaction/PhabricatorFileNameTransaction.php:40-48 | src/applications/fund/xaction/FundInitiativeNameTransaction.php:53-63 | src/applications/herald/xaction/HeraldRuleNameTransaction.php:29-41 | src/applications/legalpad/xaction/LegalpadDocumentTitleTransaction.php:58-68 | src/applications/nuance/xaction/NuanceQueueNameTransaction.php:29-40 | src/applications/nuance/xaction/NuanceSourceNameTransaction.php:29-40 | src/applications/passphrase/xaction/PassphraseCredentialNameTransaction.php:53-64 | src/applications/phame/xaction/PhameBlogNameTransaction.php:38-48 | src/applications/phame/xaction/PhameBlogParentDomainTransaction.php:66-76 | src/applications/phame/xaction/PhamePostTitleTransaction.php:38-48 | src/applications/pholio/xaction/PholioMockNameTransaction.php:74-82 | src/applications/phortune/xaction/PhortuneMerchantNameTransaction.php:38-48 | src/applications/ponder/xaction/PonderQuestionTitleTransaction.php:38-48 | src/applications/project/xaction/PhabricatorProjectNameTransaction.php:72-80 | src/applications/spaces/xaction/PhabricatorSpacesNamespaceNameTransaction.php:45-55 \u2014 before extracting anything, compare \u0060src/applications/badges/xaction/PhabricatorBadgesBadgeNameTransaction.php\u0060 and \u0060src/applications/conpherence/xaction/ConpherenceThreadTitleTransaction.php\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 61 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/badges/xaction/PhabricatorBadgesBadgeNameTransaction.php:38\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/project/xaction/PhabricatorProjectNameTransaction.php:84\u0060 calls \u0060getEditor\u0060, \u0060getIsMilestone\u0060 and \u0060src/applications/badges/xaction/PhabricatorBadgesBadgeNameTransaction.php:52\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/xaction/PhabricatorBadgesBadgeNameTransaction.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"486e495d14d9737eef3fb187ca9f29018b33ae71a3b3c78d1d7269e1634598f0"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 10): src/applications/phortune/controller/account/PhortuneAccountChargesController.php:22-36 | src/applications/phortune/controller/account/PhortuneAccountEmailAddressesController.php:22-36 | src/applications/phortune/controller/account/PhortuneAccountManagersController.php:22-36 | src/applications/phortune/controller/account/PhortuneAccountOrdersController.php:23-37 | src/applications/phortune/controller/account/PhortuneAccountOverviewController.php:33-49 | src/applications/phortune/controller/account/PhortuneAccountPaymentMethodController.php:22-36 | src/applications/phortune/controller/account/PhortuneAccountSubscriptionController.php:23-37 | src/applications/phortune/controller/merchant/PhortuneMerchantInvoiceCreateController.php:250-262 | src/applications/phortune/controller/merchant/PhortuneMerchantOrdersController.php:21-34 | src/applications/phortune/controller/merchant/PhortuneMerchantSubscriptionsController.php:22-35 \u2014 before extracting anything, compare \u0060src/applications/phortune/controller/account/PhortuneAccountChargesController.php\u0060 and \u0060src/applications/phortune/controller/merchant/PhortuneMerchantOrdersController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 42 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/phortune/controller/account/PhortuneAccountOverviewController.php:29\u0060 calls \u0060buildStatusView\u0060, \u0060buildInvoicesSection\u0060 and \u0060src/applications/phortune/controller/account/PhortuneAccountOrdersController.php:19\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountChargesController.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"8f2de59858b1ef90343ea0e9d8920a6a3f526c083a2145e2222bc01a6144a297"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 8): src/applications/auth/controller/config/PhabricatorAuthProviderViewController.php:68-80 | src/applications/auth/controller/contact/PhabricatorAuthContactNumberViewController.php:83-95 | src/applications/auth/controller/mfa/PhabricatorAuthFactorProviderViewController.php:98-110 | src/applications/fund/controller/FundInitiativeViewController.php:116-129 | src/applications/herald/controller/HeraldRuleViewController.php:68-81 | src/applications/nuance/controller/NuanceItemViewController.php:54-66 | src/applications/nuance/controller/NuanceQueueViewController.php:55-67 | src/applications/project/controller/PhabricatorProjectManageController.php:76-88 \u2014 before extracting anything, compare \u0060src/applications/auth/controller/contact/PhabricatorAuthContactNumberViewController.php\u0060 and \u0060src/applications/auth/controller/mfa/PhabricatorAuthFactorProviderViewController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 64 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/auth/controller/config/PhabricatorAuthProviderViewController.php:68\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/herald/controller/HeraldRuleViewController.php:82\u0060 calls \u0060setHref\u0060, \u0060getApplicationURI\u0060 and \u0060src/applications/fund/controller/FundInitiativeViewController.php:130\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/config/PhabricatorAuthProviderViewController.php"},"region":{"startLine":68}}}],"partialFingerprints":{"codehealthFindingId/v1":"8bfba0b639a3d2d35f7a9433f6b690eeb103342338dc34cd3586acc2c70ffa8a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 5): src/applications/dashboard/controller/dashboard/PhabricatorDashboardViewController.php:69-81 | src/applications/dashboard/controller/panel/PhabricatorDashboardPanelViewController.php:92-104 | src/applications/harbormaster/controller/HarbormasterPlanViewController.php:235-247 | src/applications/harbormaster/controller/HarbormasterStepViewController.php:118-130 | src/applications/phurl/controller/PhabricatorPhurlURLViewController.php:101-114 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 5 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 5 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/dashboard/controller/dashboard/PhabricatorDashboardViewController.php:69\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/harbormaster/controller/HarbormasterPlanViewController.php:231\u0060 calls \u0060array\u0060 and \u0060src/applications/harbormaster/controller/HarbormasterStepViewController.php:113\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/dashboard/PhabricatorDashboardViewController.php"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"95a0393920ee305dda6cd6610fc779366499f2c3b5daa0cb796002677d8cc921"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 5): src/applications/harbormaster/query/HarbormasterBuildQuery.php:60-72 | src/applications/harbormaster/query/HarbormasterBuildQuery.php:85-97 | src/applications/harbormaster/query/HarbormasterBuildStepQuery.php:57-69 | src/applications/harbormaster/query/HarbormasterBuildTargetQuery.php:181-193 | src/applications/harbormaster/query/HarbormasterBuildableQuery.php:67-79 \u2014 before extracting anything, compare \u0060src/applications/harbormaster/query/HarbormasterBuildQuery.php\u0060 and \u0060src/applications/harbormaster/query/HarbormasterBuildStepQuery.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 37 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/harbormaster/query/HarbormasterBuildQuery.php:60\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/query/HarbormasterBuildQuery.php"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"f99dc4be15ea5fb8fd8615772540942a9b107bcfd2378570b27fe3e2d772bfe1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 5): src/applications/people/controller/PhabricatorPeopleProfileBadgesController.php:46-59 | src/applications/people/controller/PhabricatorPeopleProfileCommitsController.php:39-51 | src/applications/people/controller/PhabricatorPeopleProfilePictureController.php:275-288 | src/applications/people/controller/PhabricatorPeopleProfileRevisionsController.php:39-51 | src/applications/people/controller/PhabricatorPeopleProfileTasksController.php:39-51 \u2014 before extracting anything, compare \u0060src/applications/people/controller/PhabricatorPeopleProfileCommitsController.php\u0060 and \u0060src/applications/people/controller/PhabricatorPeopleProfileRevisionsController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 57 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/people/controller/PhabricatorPeopleProfilePictureController.php:273\u0060 calls \u0060buildProfileHeader\u0060 and \u0060src/applications/people/controller/PhabricatorPeopleProfileCommitsController.php:37\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/controller/PhabricatorPeopleProfileBadgesController.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"47c02da6519a21ca6ef953f152ebea014dd97e0b0ca3c19b9b345639867a26fc"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 4): src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php:97-109 | src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubIssue.php:58-70 | src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubUser.php:62-74 | src/applications/doorkeeper/bridge/DoorkeeperBridgeJIRA.php:88-100 \u2014 before extracting anything, compare \u0060src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php\u0060 and \u0060src/applications/doorkeeper/bridge/DoorkeeperBridgeJIRA.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 62 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php:97\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubUser.php:60\u0060 calls \u0060getViewer\u0060 and \u0060src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php:95\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php"},"region":{"startLine":97}}}],"partialFingerprints":{"codehealthFindingId/v1":"fe30e01e787913cbcd1beb3ae38359d4792ceb85bb37ff2245f53300daee3d08"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 4): src/applications/people/controller/PhabricatorPeopleProfileBadgesController.php:14-26 | src/applications/people/controller/PhabricatorPeopleProfileCommitsController.php:16-28 | src/applications/people/controller/PhabricatorPeopleProfileRevisionsController.php:16-28 | src/applications/people/controller/PhabricatorPeopleProfileTasksController.php:16-28 \u2014 before extracting anything, compare \u0060src/applications/people/controller/PhabricatorPeopleProfileCommitsController.php\u0060 and \u0060src/applications/people/controller/PhabricatorPeopleProfileRevisionsController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 57 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/controller/PhabricatorPeopleProfileBadgesController.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"d2268e2f3a5847013df54cce6f55eba3d873e3b85f1a10202f3841f3e21c91f1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 4): src/applications/people/controller/PhabricatorPeopleProfileCommitsController.php:7-19 | src/applications/people/controller/PhabricatorPeopleProfileManageController.php:11-23 | src/applications/people/controller/PhabricatorPeopleProfileRevisionsController.php:7-19 | src/applications/people/controller/PhabricatorPeopleProfileTasksController.php:7-19 \u2014 before extracting anything, compare \u0060src/applications/people/controller/PhabricatorPeopleProfileCommitsController.php\u0060 and \u0060src/applications/people/controller/PhabricatorPeopleProfileRevisionsController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 57 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/controller/PhabricatorPeopleProfileCommitsController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"3ca150400ffbbf0475cda3e260ff5c9e62317f9d32c1c694e9971e8a9ae98229"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 4): src/applications/phortune/controller/account/PhortuneAccountChargesController.php:55-67 | src/applications/phortune/controller/account/PhortuneAccountProfileController.php:126-138 | src/applications/phortune/controller/merchant/PhortuneMerchantOrdersController.php:64-76 | src/applications/phortune/controller/merchant/PhortuneMerchantSubscriptionsController.php:53-65 \u2014 before extracting anything, compare \u0060src/applications/phortune/controller/account/PhortuneAccountChargesController.php\u0060 and \u0060src/applications/phortune/controller/merchant/PhortuneMerchantOrdersController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 42 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountChargesController.php"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"18f711cbe7968d9235f4a5d132c34f9d483bc23678c55bf59387e6239057f99f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12\u201313 lines \u00D7 4): src/applications/project/controller/PhabricatorProjectBoardDisableController.php:33-45 | src/applications/project/controller/PhabricatorProjectBoardImportController.php:79-90 | src/applications/project/controller/PhabricatorProjectBoardViewController.php:902-913 | src/applications/project/controller/PhabricatorProjectBoardViewController.php:994-1006 \u2014 before extracting anything, compare \u0060src/applications/project/controller/PhabricatorProjectBoardDisableController.php\u0060 and \u0060src/applications/project/controller/PhabricatorProjectBoardViewController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 51 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectBoardDisableController.php"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"bfa263bbf81cee75f570bdc9df9275a4c72da2055a820a1e691485d3782cb512"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 3): src/applications/auth/xaction/PhabricatorAuthFactorProviderNameTransaction.php:43-55 | src/applications/project/xaction/column/PhabricatorProjectColumnNameTransaction.php:54-66 | src/applications/project/xaction/trigger/PhabricatorProjectTriggerNameTransaction.php:43-55 \u2014 before extracting anything, compare \u0060src/applications/auth/xaction/PhabricatorAuthFactorProviderNameTransaction.php\u0060 and \u0060src/applications/project/xaction/trigger/PhabricatorProjectTriggerNameTransaction.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 33 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/auth/xaction/PhabricatorAuthFactorProviderNameTransaction.php:39\u0060 calls \u0060validateTransactions\u0060, \u0060array\u0060 and \u0060src/applications/project/xaction/column/PhabricatorProjectColumnNameTransaction.php:51\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/xaction/PhabricatorAuthFactorProviderNameTransaction.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"f7ea7418191986abc9c75baca79ef17a4535df36c35a0cdbf9253a3855e1448c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 3): src/applications/calendar/controller/PhabricatorCalendarExportViewController.php:108-120 | src/applications/calendar/controller/PhabricatorCalendarImportViewController.php:122-134 | src/applications/fund/controller/FundInitiativeViewController.php:136-148 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/calendar/controller/PhabricatorCalendarExportViewController.php:108\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/controller/PhabricatorCalendarExportViewController.php"},"region":{"startLine":108}}}],"partialFingerprints":{"codehealthFindingId/v1":"c3e5ba2e6017cb111f3680181ffef0a729a574dc62dd6464a04da684bb7d53f3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 3): src/applications/chatlog/query/PhabricatorChatLogChannelQuery.php:21-33 | src/applications/chatlog/query/PhabricatorChatLogQuery.php:21-33 | src/applications/legalpad/query/LegalpadDocumentSignatureQuery.php:51-63 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/chatlog/query/PhabricatorChatLogChannelQuery.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"298cfe8b65ba60fcedee58cc464b7aeb83da86f4e3d0bd54f77ab94902a639ed"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 3): src/applications/diffusion/controller/DiffusionRepositoryEditActivateController.php:8-20 | src/applications/diffusion/controller/DiffusionRepositoryEditPublishingController.php:8-20 | src/applications/diffusion/controller/DiffusionRepositoryEditUpdateController.php:8-20 \u2014 before extracting anything, compare \u0060src/applications/diffusion/controller/DiffusionRepositoryEditActivateController.php\u0060 and \u0060src/applications/diffusion/controller/DiffusionRepositoryEditPublishingController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 36 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/diffusion/controller/DiffusionRepositoryEditActivateController.php:8\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRepositoryEditActivateController.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"79f928d762777ec590bc5fb255b3bcfcddd5552b6c5d0309f42922da1f467793"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 3): src/applications/diffusion/controller/DiffusionRepositoryURICredentialController.php:8-20 | src/applications/diffusion/controller/DiffusionRepositoryURIDisableController.php:8-20 | src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php:8-20 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRepositoryURICredentialController.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"bfcd7577c770f0b63df71365c0fae3d1dec7d4f93cdbb2a3c1230931541a31b3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 3): src/applications/diffusion/engineextension/DiffusionDatasourceEngineExtension.php:32-44 | src/applications/phriction/engineextension/PhrictionDatasourceEngineExtension.php:26-38 | src/applications/project/engineextension/ProjectDatasourceEngineExtension.php:26-38 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/engineextension/DiffusionDatasourceEngineExtension.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"be33ac5feb891eb1cdd190918223d30a6c429493128e9319678af6f94cb77314"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 3): src/applications/owners/xaction/PhabricatorOwnersPackageAuthorityTransaction.php:41-53 | src/applications/owners/xaction/PhabricatorOwnersPackageAutoreviewTransaction.php:41-53 | src/applications/owners/xaction/PhabricatorOwnersPackageDominionTransaction.php:41-53 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/owners/xaction/PhabricatorOwnersPackageAuthorityTransaction.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"7e9309b7b943fff681b2566f8bc8c7d62f2d78c36555549d9092cc3568886b41"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 3): src/applications/phame/xaction/PhameBlogFullDomainTransaction.php:24-36 | src/applications/phame/xaction/PhameBlogParentDomainTransaction.php:17-29 | src/applications/phame/xaction/PhameBlogParentSiteTransaction.php:17-29 \u2014 before extracting anything, compare \u0060src/applications/phame/xaction/PhameBlogParentDomainTransaction.php\u0060 and \u0060src/applications/phame/xaction/PhameBlogParentSiteTransaction.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 53 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/xaction/PhameBlogFullDomainTransaction.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"91360e238536136591fa6dbc50ac420ede849523d0b5d2641f31c13131a148fd"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12\u201313 lines \u00D7 3): src/applications/search/engine/PhabricatorProfileMenuEngine.php:567-578 | src/applications/search/engine/PhabricatorProfileMenuEngine.php:1037-1049 | src/applications/search/engine/PhabricatorProfileMenuEngine.php:1195-1207 \u2014 all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorProfileMenuEngine.php"},"region":{"startLine":567}}}],"partialFingerprints":{"codehealthFindingId/v1":"13695332b90d2bd7419c287d7ceb280debe74edc16d515e11228b74beada2faa"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 3): src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementCancelWorkflow.php:18-31 | src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementExecuteWorkflow.php:33-45 | src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementPriorityWorkflow.php:44-57 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementCancelWorkflow.php:18\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementCancelWorkflow.php"},"region":{"startLine":18}}}],"partialFingerprints":{"codehealthFindingId/v1":"52a113f8651874615ee53e252c48299ab05b14c6da26de20c14d9ba12e77ce8b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/almanac/controller/AlmanacDeviceViewController.php:20-32 | src/applications/almanac/controller/AlmanacNamespaceViewController.php:18-30 \u2014 before extracting anything, compare \u0060src/applications/almanac/controller/AlmanacDeviceViewController.php\u0060 and \u0060src/applications/almanac/controller/AlmanacNamespaceViewController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 67 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/controller/AlmanacDeviceViewController.php"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"7bc3cc31d69beaecdf78f56e9df1e5d052fdfd87fc22260992e15d1906a1da40"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/almanac/controller/AlmanacNamespaceViewController.php:15-27 | src/applications/almanac/controller/AlmanacNetworkViewController.php:15-27 \u2014 before extracting anything, compare \u0060src/applications/almanac/controller/AlmanacNamespaceViewController.php\u0060 and \u0060src/applications/almanac/controller/AlmanacNetworkViewController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 67 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/controller/AlmanacNamespaceViewController.php"},"region":{"startLine":15}}}],"partialFingerprints":{"codehealthFindingId/v1":"334a335060d6a7fe15deaa842cd0eda0d5b50d527fdd086e9aa8582ffc43c28c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12\u201313 lines \u00D7 2): src/applications/auth/management/PhabricatorAuthManagementUnlimitWorkflow.php:36-48 | src/applications/metamta/management/PhabricatorMailManagementReceiveTestWorkflow.php:78-89 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/auth/management/PhabricatorAuthManagementUnlimitWorkflow.php:36\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/management/PhabricatorAuthManagementUnlimitWorkflow.php"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"d3d4bbc6fde27641bc1eacc3f7a3f7f90bb820411fa3ccc22c9a14c9207c5d3d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12\u201313 lines \u00D7 2): src/applications/badges/xaction/PhabricatorBadgesBadgeAwardTransaction.php:65-77 | src/applications/conpherence/xaction/ConpherenceThreadParticipantsTransaction.php:99-110 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/badges/xaction/PhabricatorBadgesBadgeAwardTransaction.php:65\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/xaction/PhabricatorBadgesBadgeAwardTransaction.php"},"region":{"startLine":65}}}],"partialFingerprints":{"codehealthFindingId/v1":"e98b845b35a76d27f7bc2a2855bef8367c4431f2524d7001eca4505508e99754"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/calendar/controller/PhabricatorCalendarExportDisableController.php:33-45 | src/applications/calendar/controller/PhabricatorCalendarImportDisableController.php:41-53 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/calendar/controller/PhabricatorCalendarExportDisableController.php:33\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/controller/PhabricatorCalendarExportDisableController.php"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"8bd7127c239b0fad0c286bad7bfd1b4f8b4b9e72ba44511504d08ec0c43b2892"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/calendar/controller/PhabricatorCalendarImportViewController.php:239-251 | src/applications/calendar/controller/PhabricatorCalendarImportViewController.php:279-291 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/controller/PhabricatorCalendarImportViewController.php"},"region":{"startLine":239}}}],"partialFingerprints":{"codehealthFindingId/v1":"79cf2638c85cd785dcd215acfae50edd78a657ca78148bc45aeebe6a682256da"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/config/schema/PhabricatorConfigSchemaQuery.php:279-292 | src/applications/config/schema/PhabricatorConfigSchemaQuery.php:299-311 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/schema/PhabricatorConfigSchemaQuery.php"},"region":{"startLine":279}}}],"partialFingerprints":{"codehealthFindingId/v1":"e1201f643723f721df6987f2ffc08ef76224c5ab678ac442d0d94ad6db766dda"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/conpherence/xaction/ConpherenceThreadParticipantsTransaction.php:72-84 | src/applications/pholio/xaction/PholioImageFileTransaction.php:59-71 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/conpherence/xaction/ConpherenceThreadParticipantsTransaction.php:72\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/xaction/ConpherenceThreadParticipantsTransaction.php"},"region":{"startLine":72}}}],"partialFingerprints":{"codehealthFindingId/v1":"ef8cc8ab383c71bca60fb436163264d4cdb979dfc77affb38fbaabab01184679"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php:130-142 | src/applications/dashboard/controller/panel/PhabricatorDashboardPanelTabsController.php:207-219 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php:130\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php"},"region":{"startLine":130}}}],"partialFingerprints":{"codehealthFindingId/v1":"69be7c57f724a4c769e98601653387cb9477fee31b995c9e5d23c439f70154d3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php:112-124 | src/applications/search/controller/PhabricatorApplicationSearchController.php:1079-1091 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php:112\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php"},"region":{"startLine":112}}}],"partialFingerprints":{"codehealthFindingId/v1":"eb89712c764d06f03a1f61d9eca9a75c19517765a3baf9d74ecf51fe57b9c4bd"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11\u201313 lines \u00D7 2): src/applications/differential/controller/DifferentialRevisionViewController.php:1322-1334 | src/applications/differential/controller/DifferentialRevisionViewController.php:1433-1443 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/controller/DifferentialRevisionViewController.php"},"region":{"startLine":1322}}}],"partialFingerprints":{"codehealthFindingId/v1":"8376c8e36afa5c419ffee04b459beaee29235dbe3d06b4e42de95729b8e1c651"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/differential/render/DifferentialChangesetRenderer.php:680-692 | src/applications/differential/render/DifferentialChangesetRenderer.php:696-708 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/differential/render/DifferentialChangesetRenderer.php:680\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetRenderer.php"},"region":{"startLine":680}}}],"partialFingerprints":{"codehealthFindingId/v1":"bcf8e93cb03d64ac1f6a9ff7356d60c478b06c8174ade0da3940929f42b91983"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php:769-781 | src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php:802-814 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php:769\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php"},"region":{"startLine":769}}}],"partialFingerprints":{"codehealthFindingId/v1":"d7fc69823230aefa300cc7cd594c227978333dedc03bb2f6b33173d8b6cb3fb5"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/diffusion/xaction/DiffusionCommitAuditorsTransaction.php:108-120 | src/applications/diffusion/xaction/DiffusionCommitAuditorsTransaction.php:142-154 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/diffusion/xaction/DiffusionCommitAuditorsTransaction.php:108\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/diffusion/xaction/DiffusionCommitAuditorsTransaction.php:155\u0060 calls \u0060renderObject\u0060 and \u0060src/applications/diffusion/xaction/DiffusionCommitAuditorsTransaction.php:121\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/xaction/DiffusionCommitAuditorsTransaction.php"},"region":{"startLine":108}}}],"partialFingerprints":{"codehealthFindingId/v1":"14b5de069fdc3f1528042a1a4bcfe7c1a017866432ea14b24f5d6463af63cad0"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/files/builtin/PhabricatorFilesOnDiskBuiltinFile.php:44-56 | src/applications/files/builtin/PhabricatorFilesOnDiskBuiltinFile.php:60-72 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/builtin/PhabricatorFilesOnDiskBuiltinFile.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"e22690d6f079ec2b73e4aada0c2cae2a45afe20730a8f357747415bd7884601c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/files/controller/PhabricatorFileUICurtainAttachController.php:10-22 | src/applications/files/controller/PhabricatorFileUICurtainListController.php:13-25 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/files/controller/PhabricatorFileUICurtainAttachController.php:9\u0060 calls \u0060getURIData\u0060 and \u0060src/applications/files/controller/PhabricatorFileUICurtainListController.php:11\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/controller/PhabricatorFileUICurtainAttachController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"10d525545c6ab8b25f5d692f80a8fbee408633933af65aad13713d0052bf1c66"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/herald/xaction/HeraldWebhookStatusTransaction.php:51-64 | src/applications/project/xaction/column/PhabricatorProjectColumnStatusTransaction.php:49-61 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/xaction/HeraldWebhookStatusTransaction.php"},"region":{"startLine":51}}}],"partialFingerprints":{"codehealthFindingId/v1":"c174ff7346668a6d43de784447eb7c0405f47c333fcaa0c0794df9189073e85a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/nuance/controller/NuanceConsoleController.php:41-53 | src/applications/phortune/controller/product/PhortuneProductListController.php:52-65 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/controller/NuanceConsoleController.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"cd76b347cddb243285a9327a1ee9d70f0671c899a94f6447a7bef071210fe8df"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/owners/storage/PhabricatorOwnersPackage.php:763-775 | src/applications/owners/storage/PhabricatorOwnersPackage.php:780-792 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/owners/storage/PhabricatorOwnersPackage.php"},"region":{"startLine":763}}}],"partialFingerprints":{"codehealthFindingId/v1":"dcdeae0c7b92c52cf9e8dcda4b8e3fc0af6b5933571ea50d9dce9a2da37ef514"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/paste/xaction/PhabricatorPasteTitleTransaction.php:41-53 | src/applications/phortune/xaction/PhortuneMerchantInvoiceEmailTransaction.php:40-52 \u2014 before extracting anything, compare \u0060src/applications/paste/xaction/PhabricatorPasteTitleTransaction.php\u0060 and \u0060src/applications/phortune/xaction/PhortuneMerchantInvoiceEmailTransaction.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/paste/xaction/PhabricatorPasteTitleTransaction.php:41\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/paste/xaction/PhabricatorPasteTitleTransaction.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"0b07eb980768c9f7bc1ee817475dfb77988208eb9cd45543342f1d6afee7e043"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/people/storage/PhabricatorUserEmail.php:253-265 | src/applications/people/storage/PhabricatorUserEmail.php:288-300 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/people/storage/PhabricatorUserEmail.php:253\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/storage/PhabricatorUserEmail.php"},"region":{"startLine":253}}}],"partialFingerprints":{"codehealthFindingId/v1":"ebab30861b4724094bdb0a45fa72a2bf5a258bd003096441827eef83273c9b44"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/phlux/controller/PhluxViewController.php:63-75 | src/applications/pholio/controller/PholioMockViewController.php:117-129 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phlux/controller/PhluxViewController.php:63\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phlux/controller/PhluxViewController.php"},"region":{"startLine":63}}}],"partialFingerprints":{"codehealthFindingId/v1":"2eca7e950e2f3feeb2af0bc43fafa6f942b292ee4798f28b347ffa3d4b1aec11"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/phortune/controller/account/PhortuneAccountEmailAddressesController.php:40-52 | src/applications/phortune/controller/account/PhortuneAccountManagersController.php:41-53 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountEmailAddressesController.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"45e07f14c6069b24015655992e6f681ceee991d498fc88cfa1cda04ff63a431f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/phortune/controller/merchant/PhortuneMerchantOverviewController.php:15-27 | src/applications/phortune/controller/merchant/PhortuneMerchantProvidersController.php:16-28 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/phortune/controller/merchant/PhortuneMerchantProvidersController.php:15\u0060 calls \u0060addTextCrumb\u0060, \u0060pht\u0060 and \u0060src/applications/phortune/controller/merchant/PhortuneMerchantOverviewController.php:14\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/merchant/PhortuneMerchantOverviewController.php"},"region":{"startLine":15}}}],"partialFingerprints":{"codehealthFindingId/v1":"fe518cf19f52d25db7737b4e833fce45bb06353ae21f0db82a420bf9bb085f3c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/phortune/management/PhabricatorPhortuneManagementInvoiceWorkflow.php:73-85 | src/infrastructure/daemon/workers/management/PhabricatorWorkerTriggerManagementFireWorkflow.php:49-61 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/management/PhabricatorPhortuneManagementInvoiceWorkflow.php"},"region":{"startLine":73}}}],"partialFingerprints":{"codehealthFindingId/v1":"f07294de1a2b1ee140c30c133954d3c92f1cf8b4cee1cb863322a106b9b1d7c8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/phpast/controller/PhabricatorXHPASTViewStreamController.php:7-19 | src/applications/phpast/controller/PhabricatorXHPASTViewTreeController.php:11-23 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phpast/controller/PhabricatorXHPASTViewStreamController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"d72414b683f6ecd556cac04273821e412ebe9e04663d633489231b5e26339d4d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/project/controller/PhabricatorProjectArchiveController.php:8-21 | src/applications/project/controller/PhabricatorProjectLockController.php:16-28 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/project/controller/PhabricatorProjectLockController.php:13\u0060 calls \u0060requireApplicationCapability\u0060 and \u0060src/applications/project/controller/PhabricatorProjectArchiveController.php:7\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectArchiveController.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"17b97e889fe1a30af144cc580a0968b2660ac1e55bca0c1bd5d86fe2bfa0ccc5"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/project/controller/PhabricatorProjectMembersAddController.php:24-36 | src/applications/project/controller/PhabricatorProjectUpdateController.php:35-47 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/project/controller/PhabricatorProjectMembersAddController.php:24\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/project/controller/PhabricatorProjectMembersAddController.php:23\u0060 calls \u0060setProject\u0060 and \u0060src/applications/project/controller/PhabricatorProjectUpdateController.php:33\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectMembersAddController.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"9e4dc892ce4c0033b9ad0e9025639a9b58426cb38636b39af21cbd373ff737c9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/project/controller/PhabricatorProjectMembersViewController.php:53-65 | src/applications/project/controller/PhabricatorProjectSubprojectsController.php:103-116 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectMembersViewController.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"c144d6e13413d66210ce88906f7ba7480260d6b7489c6ecb92e742324eac1877"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/project/icon/PhabricatorProjectIconSet.php:250-262 | src/applications/project/icon/PhabricatorProjectIconSet.php:470-482 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/project/icon/PhabricatorProjectIconSet.php:250\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/icon/PhabricatorProjectIconSet.php"},"region":{"startLine":250}}}],"partialFingerprints":{"codehealthFindingId/v1":"b2214335423cc0148f31febd9e136304acf013b2cf48c354e3f2416a48f30b59"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12\u201313 lines \u00D7 2): src/applications/project/storage/PhabricatorProjectTransaction.php:101-112 | src/applications/project/storage/PhabricatorProjectTransaction.php:113-125 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/project/storage/PhabricatorProjectTransaction.php:101\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/storage/PhabricatorProjectTransaction.php"},"region":{"startLine":101}}}],"partialFingerprints":{"codehealthFindingId/v1":"cde46b0e802f0e08482ff4e56de1d1d6a55736eb3de2f4cd23f01bc3ffd64c72"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/project/xaction/PhabricatorProjectSlugsTransaction.php:37-49 | src/applications/project/xaction/PhabricatorProjectSlugsTransaction.php:70-82 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/project/xaction/PhabricatorProjectSlugsTransaction.php:37\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/project/xaction/PhabricatorProjectSlugsTransaction.php:83\u0060 calls \u0060renderObject\u0060 and \u0060src/applications/project/xaction/PhabricatorProjectSlugsTransaction.php:50\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/xaction/PhabricatorProjectSlugsTransaction.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"aaa7bcc181f87abb6434876c393dd535531cf183aebe01c08878a504a3ad85fb"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11\u201313 lines \u00D7 2): src/applications/repository/customfield/PhabricatorCommitBranchesField.php:38-50 | src/applications/repository/customfield/PhabricatorCommitTagsField.php:38-48 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/repository/customfield/PhabricatorCommitBranchesField.php:38\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/customfield/PhabricatorCommitBranchesField.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"cce754aec2f5fabedbe6eb406cbc9317d9d9de7680c7c4e4fdcdb6fe963e9a80"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/repository/daemon/PhabricatorGitGraphStream.php:57-69 | src/applications/repository/daemon/PhabricatorMercurialGraphStream.php:85-97 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/repository/daemon/PhabricatorGitGraphStream.php:57\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/daemon/PhabricatorGitGraphStream.php"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"15bb571b49c5783ba6b33d7d15756459a724a86fba769c9b6314454ca5b2251b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/repository/storage/PhabricatorRepositoryCommit.php:883-895 | src/applications/repository/storage/PhabricatorRepositoryCommit.php:898-910 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepositoryCommit.php"},"region":{"startLine":883}}}],"partialFingerprints":{"codehealthFindingId/v1":"461f4544d58a85b0d1edd24fb59129e0ea806e2b0ecc78b149b3c8810e2e9e49"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10\u201312 lines \u00D7 19): src/applications/badges/xaction/PhabricatorBadgesBadgeNameTransaction.php:37-46 | src/applications/conpherence/xaction/ConpherenceThreadTitleTransaction.php:57-66 | src/applications/countdown/xaction/PhabricatorCountdownTitleTransaction.php:36-45 | src/applications/differential/xaction/DifferentialRevisionTitleTransaction.php:38-48 | src/applications/drydock/xaction/DrydockBlueprintNameTransaction.php:41-51 | src/applications/files/xaction/PhabricatorFileNameTransaction.php:37-46 | src/applications/fund/xaction/FundInitiativeNameTransaction.php:52-61 | src/applications/herald/xaction/HeraldRuleNameTransaction.php:28-39 | src/applications/legalpad/xaction/LegalpadDocumentTitleTransaction.php:57-66 | src/applications/nuance/xaction/NuanceQueueNameTransaction.php:28-38 | src/applications/nuance/xaction/NuanceSourceNameTransaction.php:28-38 | src/applications/passphrase/xaction/PassphraseCredentialNameTransaction.php:52-62 | src/applications/phame/xaction/PhameBlogNameTransaction.php:37-46 | src/applications/phame/xaction/PhamePostTitleTransaction.php:37-46 | src/applications/pholio/xaction/PholioMockNameTransaction.php:71-80 | src/applications/phortune/xaction/PhortuneMerchantNameTransaction.php:37-46 | src/applications/ponder/xaction/PonderQuestionTitleTransaction.php:37-46 | src/applications/project/xaction/PhabricatorProjectNameTransaction.php:69-78 | src/applications/spaces/xaction/PhabricatorSpacesNamespaceNameTransaction.php:44-53 \u2014 before extracting anything, compare \u0060src/applications/badges/xaction/PhabricatorBadgesBadgeNameTransaction.php\u0060 and \u0060src/applications/conpherence/xaction/ConpherenceThreadTitleTransaction.php\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 61 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/badges/xaction/PhabricatorBadgesBadgeNameTransaction.php:37\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/xaction/PhabricatorBadgesBadgeNameTransaction.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"50152ed22665d1e5227e895fc713c034c2e202920ca7ca0d15b31d33a71c3263"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 18): src/applications/calendar/phid/PhabricatorCalendarEventPHIDType.php:65-76 | src/applications/countdown/phid/PhabricatorCountdownCountdownPHIDType.php:59-70 | src/applications/dashboard/phid/PhabricatorDashboardPanelPHIDType.php:65-76 | src/applications/differential/phid/DifferentialRevisionPHIDType.php:65-76 | src/applications/files/phid/PhabricatorFileFilePHIDType.php:63-74 | src/applications/fund/phid/FundInitiativePHIDType.php:64-75 | src/applications/harbormaster/phid/HarbormasterBuildablePHIDType.php:74-85 | src/applications/herald/phid/HeraldRulePHIDType.php:63-74 | src/applications/legalpad/phid/PhabricatorLegalpadDocumentPHIDType.php:60-71 | src/applications/maniphest/phid/ManiphestTaskPHIDType.php:62-73 | src/applications/owners/phid/PhabricatorOwnersPackagePHIDType.php:72-83 | src/applications/passphrase/phid/PassphraseCredentialPHIDType.php:62-73 | src/applications/paste/phid/PhabricatorPastePastePHIDType.php:59-70 | src/applications/pholio/phid/PholioMockPHIDType.php:63-74 | src/applications/phurl/phid/PhabricatorPhurlURLPHIDType.php:61-72 | src/applications/ponder/phid/PonderQuestionPHIDType.php:58-69 | src/applications/slowvote/phid/PhabricatorSlowvotePollPHIDType.php:56-67 | src/applications/spaces/phid/PhabricatorSpacesNamespacePHIDType.php:66-77 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 18 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 18 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/phid/PhabricatorCalendarEventPHIDType.php"},"region":{"startLine":65}}}],"partialFingerprints":{"codehealthFindingId/v1":"759653659b1602a8b1f2c356380bd6ada361a205ca026a2fcc692e7b7c83b70d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10\u201312 lines \u00D7 12): src/applications/badges/xaction/PhabricatorBadgesBadgeNameTransaction.php:34-44 | src/applications/files/xaction/PhabricatorFileNameTransaction.php:34-43 | src/applications/fund/xaction/FundInitiativeNameTransaction.php:49-59 | src/applications/herald/xaction/HeraldRuleNameTransaction.php:25-36 | src/applications/nuance/xaction/NuanceQueueNameTransaction.php:25-35 | src/applications/nuance/xaction/NuanceSourceNameTransaction.php:25-35 | src/applications/passphrase/xaction/PassphraseCredentialNameTransaction.php:49-60 | src/applications/phame/xaction/PhameBlogNameTransaction.php:34-44 | src/applications/pholio/xaction/PholioMockNameTransaction.php:68-77 | src/applications/phortune/xaction/PhortuneAccountNameTransaction.php:34-44 | src/applications/phortune/xaction/PhortuneMerchantNameTransaction.php:34-44 | src/applications/project/xaction/PhabricatorProjectNameTransaction.php:66-75 \u2014 before extracting anything, compare \u0060src/applications/badges/xaction/PhabricatorBadgesBadgeNameTransaction.php\u0060 and \u0060src/applications/files/xaction/PhabricatorFileNameTransaction.php\u0060 as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 73 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/badges/xaction/PhabricatorBadgesBadgeNameTransaction.php:34\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/xaction/PhabricatorBadgesBadgeNameTransaction.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"5e10307f42cc8370c1560ba76e156503ce72231c71a171d978c29346e0650f79"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 8): src/applications/auth/controller/config/PhabricatorAuthProviderViewController.php:69-81 | src/applications/auth/controller/contact/PhabricatorAuthContactNumberViewController.php:84-96 | src/applications/auth/controller/mfa/PhabricatorAuthFactorProviderViewController.php:99-111 | src/applications/fund/controller/FundInitiativeViewController.php:118-130 | src/applications/nuance/controller/NuanceItemViewController.php:55-67 | src/applications/nuance/controller/NuanceQueueViewController.php:56-68 | src/applications/phortune/controller/merchant/PhortuneMerchantDetailsController.php:100-112 | src/applications/project/controller/PhabricatorProjectManageController.php:78-89 \u2014 before extracting anything, compare \u0060src/applications/auth/controller/contact/PhabricatorAuthContactNumberViewController.php\u0060 and \u0060src/applications/auth/controller/mfa/PhabricatorAuthFactorProviderViewController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 64 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/auth/controller/config/PhabricatorAuthProviderViewController.php:69\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/config/PhabricatorAuthProviderViewController.php"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"bfb5947f373db03f86ed8bf09afbca90c0bf1e628770dbd03c13288c84d66fbb"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 6): src/applications/diffusion/controller/DiffusionRepositoryEditActivateController.php:7-18 | src/applications/diffusion/controller/DiffusionRepositoryEditDangerousController.php:7-18 | src/applications/diffusion/controller/DiffusionRepositoryEditDeleteController.php:7-18 | src/applications/diffusion/controller/DiffusionRepositoryEditEnormousController.php:7-18 | src/applications/diffusion/controller/DiffusionRepositoryEditPublishingController.php:7-18 | src/applications/diffusion/controller/DiffusionRepositoryEditUpdateController.php:7-18 \u2014 before extracting anything, compare \u0060src/applications/diffusion/controller/DiffusionRepositoryEditActivateController.php\u0060 and \u0060src/applications/diffusion/controller/DiffusionRepositoryEditPublishingController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 36 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRepositoryEditActivateController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"ba742b7cf6bce78be6ad072e3a87b95608fa2123064a0c90bd64e53e7ce32987"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 5): src/applications/paste/xaction/PhabricatorPasteTitleTransaction.php:17-28 | src/applications/phortune/xaction/PhortuneAccountBillingNameTransaction.php:17-28 | src/applications/phortune/xaction/PhortuneMerchantInvoiceEmailTransaction.php:17-28 | src/applications/phortune/xaction/paymentmethod/PhortunePaymentMethodNameTransaction.php:17-28 | src/applications/project/xaction/trigger/PhabricatorProjectTriggerNameTransaction.php:17-28 \u2014 before extracting anything, compare \u0060src/applications/paste/xaction/PhabricatorPasteTitleTransaction.php\u0060 and \u0060src/applications/phortune/xaction/PhortuneMerchantInvoiceEmailTransaction.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/paste/xaction/PhabricatorPasteTitleTransaction.php:17\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/paste/xaction/PhabricatorPasteTitleTransaction.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"7d8c5afe35139bdcea8db598c416a2e105f22cb5dfeafcf678d45edd06887f53"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 5): src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php:68-79 | src/applications/phame/controller/blog/PhameBlogProfilePictureController.php:84-95 | src/applications/phame/controller/post/PhamePostHeaderPictureController.php:68-79 | src/applications/phortune/controller/merchant/PhortuneMerchantPictureController.php:74-85 | src/applications/project/controller/PhabricatorProjectEditPictureController.php:85-96 \u2014 before extracting anything, compare \u0060src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php\u0060 and \u0060src/applications/phame/controller/blog/PhameBlogProfilePictureController.php\u0060 as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 135 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php:68\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php"},"region":{"startLine":68}}}],"partialFingerprints":{"codehealthFindingId/v1":"5a90afa049de4406a6af35d2dfd5a53d6fb1baf0cdb9e0331f1d1035e1b01bb9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 5): src/applications/phortune/controller/account/PhortuneAccountChargesController.php:55-66 | src/applications/phortune/controller/account/PhortuneAccountProfileController.php:126-137 | src/applications/phortune/controller/account/PhortuneAccountSubscriptionViewController.php:141-152 | src/applications/phortune/controller/merchant/PhortuneMerchantOrdersController.php:64-75 | src/applications/phortune/controller/merchant/PhortuneMerchantSubscriptionsController.php:53-64 \u2014 before extracting anything, compare \u0060src/applications/phortune/controller/account/PhortuneAccountChargesController.php\u0060 and \u0060src/applications/phortune/controller/merchant/PhortuneMerchantOrdersController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 42 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountChargesController.php"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"245e8cfaa7ca382ac7af73fd5b332270874d0ac80114e86450c8473f44e02eb5"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 4): src/applications/badges/controller/PhabricatorBadgesCommentController.php:35-46 | src/applications/ponder/controller/PonderAnswerCommentController.php:37-48 | src/applications/ponder/controller/PonderQuestionCommentController.php:34-45 | src/applications/slowvote/controller/PhabricatorSlowvoteCommentController.php:35-46 \u2014 before extracting anything, compare \u0060src/applications/badges/controller/PhabricatorBadgesCommentController.php\u0060 and \u0060src/applications/slowvote/controller/PhabricatorSlowvoteCommentController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 44 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/badges/controller/PhabricatorBadgesCommentController.php:49\u0060 calls \u0060replaceOrDelete\u0060 and \u0060src/applications/ponder/controller/PonderAnswerCommentController.php:51\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/controller/PhabricatorBadgesCommentController.php"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"3a33c56bc37a54c8583836c87399a2fbba421dc4bcb1b59423a064ec3a8bbced"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 4): src/applications/drydock/controller/DrydockBlueprintDisableController.php:36-47 | src/applications/oauthserver/controller/client/PhabricatorOAuthClientDisableController.php:33-44 | src/applications/phame/controller/post/PhamePostPublishController.php:41-52 | src/applications/project/controller/PhabricatorProjectSilenceController.php:57-68 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 4 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/drydock/controller/DrydockBlueprintDisableController.php:36\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/controller/DrydockBlueprintDisableController.php"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"34d848d42161ec9dc4bdb77a2ad9b5949eef748166623dc6dafb40998a653ff4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11\u201312 lines \u00D7 4): src/applications/files/controller/PhabricatorFileDetachController.php:7-18 | src/applications/files/controller/PhabricatorFileUICurtainAttachController.php:7-18 | src/applications/policy/controller/PhabricatorPolicyExplainController.php:11-22 | src/applications/transactions/controller/PhabricatorApplicationTransactionValueController.php:11-21 \u2014 before extracting anything, compare \u0060src/applications/files/controller/PhabricatorFileDetachController.php\u0060 and \u0060src/applications/files/controller/PhabricatorFileUICurtainAttachController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 75 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/controller/PhabricatorFileDetachController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"eaf447194f49a997abe2addda6990815001f44049e692946e96769727be50e8c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 4): src/applications/transactions/storage/PhabricatorApplicationTransaction.php:959-970 | src/applications/transactions/storage/PhabricatorApplicationTransaction.php:972-983 | src/applications/transactions/storage/PhabricatorApplicationTransaction.php:985-996 | src/applications/transactions/storage/PhabricatorApplicationTransaction.php:998-1009 \u2014 all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorApplicationTransaction.php"},"region":{"startLine":959}}}],"partialFingerprints":{"codehealthFindingId/v1":"82eb059d5e9ad50eb8b91e2f6be829fb3e12414be516f05793dfee87716a22f3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 3): src/applications/almanac/controller/AlmanacDeviceViewController.php:19-30 | src/applications/almanac/controller/AlmanacNamespaceViewController.php:17-28 | src/applications/almanac/controller/AlmanacNetworkViewController.php:17-28 \u2014 before extracting anything, compare \u0060src/applications/almanac/controller/AlmanacDeviceViewController.php\u0060 and \u0060src/applications/almanac/controller/AlmanacNamespaceViewController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 67 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/controller/AlmanacDeviceViewController.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"b9f2f9684e39245ecb60aafef83d87976c4cb3e420a6632a74f5adf5d2df280d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 3): src/applications/auth/controller/PhabricatorAuthSetPasswordController.php:80-91 | src/applications/diffusion/panel/DiffusionSetPasswordSettingsPanel.php:94-105 | src/applications/settings/panel/PhabricatorPasswordSettingsPanel.php:111-122 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/auth/controller/PhabricatorAuthSetPasswordController.php:80\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthSetPasswordController.php"},"region":{"startLine":80}}}],"partialFingerprints":{"codehealthFindingId/v1":"b544ae0eca11e96b6d807030aaeb651ff230df4659b3d1afb68d47254c7baaef"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 3): src/applications/badges/xaction/PhabricatorBadgesBadgeFlavorTransaction.php:36-47 | src/applications/phortune/xaction/PhortuneAccountBillingNameTransaction.php:42-53 | src/applications/phortune/xaction/PhortuneAccountNameTransaction.php:41-52 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/xaction/PhabricatorBadgesBadgeFlavorTransaction.php"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"813f0d60a7d63322651bae3eee664d4096260f6729ca3ff61018384d8d0c1234"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 3): src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php:128-141 | src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php:122-133 | src/applications/dashboard/controller/panel/PhabricatorDashboardPanelTabsController.php:207-218 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php:128\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php:134\u0060 calls \u0060appendRemarkupInstructions\u0060, \u0060pht\u0060 and \u0060src/applications/dashboard/controller/panel/PhabricatorDashboardPanelTabsController.php:219\u0060 does not \u2014 after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php"},"region":{"startLine":128}}}],"partialFingerprints":{"codehealthFindingId/v1":"4da328ada7c6be1f64be6350b7b7f1b96ae7d8569dc29c813e3cbd1c22395ac9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 3): src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php:112-123 | src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php:175-186 | src/applications/search/controller/PhabricatorApplicationSearchController.php:1079-1090 \u2014 there are 3 copies across 2 file(s) \u2014 more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php:112\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php"},"region":{"startLine":112}}}],"partialFingerprints":{"codehealthFindingId/v1":"60832b48a811f1642414da15559b7b978a604e9c1eb247c9d2f3a5d097da4642"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 3): src/applications/drydock/controller/DrydockBlueprintViewController.php:164-175 | src/applications/drydock/controller/DrydockBlueprintViewController.php:230-241 | src/applications/drydock/controller/DrydockResourceViewController.php:187-198 \u2014 there are 3 copies across 2 file(s) \u2014 more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/controller/DrydockBlueprintViewController.php"},"region":{"startLine":164}}}],"partialFingerprints":{"codehealthFindingId/v1":"e42f2f4b62ed81c870b81753b7a62441c2bf205e846d4dfc580647e4151000ca"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 3): src/applications/people/controller/PhabricatorPeopleProfilePictureController.php:252-263 | src/applications/phame/controller/blog/PhameBlogProfilePictureController.php:198-209 | src/applications/phortune/controller/merchant/PhortuneMerchantPictureController.php:187-198 \u2014 before extracting anything, compare \u0060src/applications/people/controller/PhabricatorPeopleProfilePictureController.php\u0060 and \u0060src/applications/phame/controller/blog/PhameBlogProfilePictureController.php\u0060 as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 146 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/people/controller/PhabricatorPeopleProfilePictureController.php:252\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/controller/PhabricatorPeopleProfilePictureController.php"},"region":{"startLine":252}}}],"partialFingerprints":{"codehealthFindingId/v1":"854240c61d6cb5f403415aebe4af3ef3fa38d924e8377d08c81c8d1ce56692d3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 3): src/applications/phame/controller/post/PhamePostViewController.php:221-232 | src/applications/phame/controller/post/PhamePostViewController.php:236-247 | src/applications/phame/controller/post/PhamePostViewController.php:259-270 \u2014 all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phame/controller/post/PhamePostViewController.php:221\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/post/PhamePostViewController.php"},"region":{"startLine":221}}}],"partialFingerprints":{"codehealthFindingId/v1":"6246d96c456155297b28e8ca5c76a3c7dffec46868a02fde99446f268641d2d2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/applications/almanac/controller/AlmanacPropertyDeleteController.php:49-60 | src/applications/calendar/controller/PhabricatorCalendarEventJoinController.php:53-64 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/almanac/controller/AlmanacPropertyDeleteController.php:49\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/controller/AlmanacPropertyDeleteController.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"b2b6ab083c1b3446e2ef7f8d0723c5f8ed81ea33f91b10ad131a820dc78b5b3b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/applications/auth/conduit/PhabricatorAuthQueryPublicKeysConduitAPIMethod.php:34-45 | src/applications/harbormaster/conduit/HarbormasterQueryBuildablesConduitAPIMethod.php:34-45 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/auth/conduit/PhabricatorAuthQueryPublicKeysConduitAPIMethod.php:34\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/conduit/PhabricatorAuthQueryPublicKeysConduitAPIMethod.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"a9a210ee00a1da0a789617790afc4089fc9e9a053d9aaca405974d582fc9c80f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11\u201312 lines \u00D7 2): src/applications/badges/controller/PhabricatorBadgesRecipientsController.php:11-21 | src/applications/badges/controller/PhabricatorBadgesViewController.php:11-22 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/controller/PhabricatorBadgesRecipientsController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"08feb3e1bd03011a6d11c7674431d24cb8f348c1a3092914890f4f8e0f00fe41"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/applications/config/controller/services/PhabricatorConfigClusterDatabasesController.php:22-33 | src/applications/config/controller/settings/PhabricatorConfigSettingsHistoryController.php:32-43 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/services/PhabricatorConfigClusterDatabasesController.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"81014ba923d7806690a65d14e42aede182daaae99bf689ebc4f07e4717728ea8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/applications/daemon/controller/PhabricatorDaemonLogViewController.php:68-79 | src/applications/phortune/controller/product/PhortuneProductViewController.php:40-51 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/daemon/controller/PhabricatorDaemonLogViewController.php"},"region":{"startLine":68}}}],"partialFingerprints":{"codehealthFindingId/v1":"2df0f94f3da673ea9be20f52344802960be5f094f9df03dadda8c6dfb96430ff"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11\u201312 lines \u00D7 2): src/applications/dashboard/controller/dashboard/PhabricatorDashboardInstallController.php:18-29 | src/applications/dashboard/controller/dashboard/PhabricatorDashboardViewController.php:11-21 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/dashboard/PhabricatorDashboardInstallController.php"},"region":{"startLine":18}}}],"partialFingerprints":{"codehealthFindingId/v1":"c0a82eeb1c5fca18e37072945c0d34a94ed0793a4e06251936e1085e4ec5d520"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/applications/drydock/controller/DrydockRepositoryOperationStatusController.php:11-22 | src/applications/drydock/controller/DrydockRepositoryOperationViewController.php:11-22 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/controller/DrydockRepositoryOperationStatusController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"9fb43403cde84b7bd0501b8c8a479a58d0faafc5ae4de6f5d59021c2a8e164b6"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/applications/drydock/worker/DrydockRepositoryOperationUpdateWorker.php:96-107 | src/applications/harbormaster/step/HarbormasterLeaseWorkingCopyBuildStepImplementation.php:29-40 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/drydock/worker/DrydockRepositoryOperationUpdateWorker.php:96\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/worker/DrydockRepositoryOperationUpdateWorker.php"},"region":{"startLine":96}}}],"partialFingerprints":{"codehealthFindingId/v1":"8c14aae0608ca0a5a4cc655cd6b58590b8c925def19c0f1c11ed16a22e873590"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php:62-73 | src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php:210-221 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php"},"region":{"startLine":62}}}],"partialFingerprints":{"codehealthFindingId/v1":"d312f14a3a271d975bbfff2b6dec1507b9acfc516c7568b153a671d16cefb75b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/applications/harbormaster/controller/HarbormasterPlanBehaviorController.php:43-54 | src/applications/harbormaster/controller/HarbormasterPlanDisableController.php:36-47 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/harbormaster/controller/HarbormasterPlanBehaviorController.php:43\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterPlanBehaviorController.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"ed3b26b9e0d4e7694cfe2e4b604822427323f702472a7b9ea05a0721e0a58dae"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/applications/harbormaster/query/HarbormasterBuildMessageQuery.php:31-42 | src/applications/harbormaster/query/HarbormasterBuildableQuery.php:95-106 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/harbormaster/query/HarbormasterBuildMessageQuery.php:31\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/query/HarbormasterBuildMessageQuery.php"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"9dc8823eb856a815d87bc58f3d53ba11e904a032925579cd46525ec9f0204ac5"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/applications/harbormaster/step/HarbormasterBuildkiteBuildStepImplementation.php:136-147 | src/applications/harbormaster/step/HarbormasterCircleCIBuildStepImplementation.php:135-146 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/step/HarbormasterBuildkiteBuildStepImplementation.php"},"region":{"startLine":136}}}],"partialFingerprints":{"codehealthFindingId/v1":"660028057bd9da2bc9b0f9839c898d1b68d7658d9251a87e03b82a003bde79df"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/applications/herald/query/HeraldRuleQuery.php:175-186 | src/applications/project/query/PhabricatorProjectColumnQuery.php:97-108 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/herald/query/HeraldRuleQuery.php:175\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/query/HeraldRuleQuery.php"},"region":{"startLine":175}}}],"partialFingerprints":{"codehealthFindingId/v1":"0c59c62f52fa129fad4ccc39d2e59c1c6bb8fa1b6e2f588798bbe77127c4cea9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/applications/maniphest/controller/ManiphestReportController.php:537-548 | src/applications/maniphest/controller/ManiphestReportController.php:550-561 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/controller/ManiphestReportController.php"},"region":{"startLine":537}}}],"partialFingerprints":{"codehealthFindingId/v1":"ef3fcb6a978a239bfa3c2e1305c5c6e915ed6fa0914d595242720af8ce251925"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/applications/maniphest/typeahead/ManiphestTaskSubtypeDatasource.php:31-42 | src/applications/project/typeahead/PhabricatorProjectSubtypeDatasource.php:31-42 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/typeahead/ManiphestTaskSubtypeDatasource.php"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"9853eb3a489ce6590039d6672f32861a1563c004d0d37b7b37e9d527368dc943"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11\u201312 lines \u00D7 2): src/applications/maniphest/xaction/ManiphestTaskUnblockTransaction.php:32-43 | src/applications/maniphest/xaction/ManiphestTaskUnblockTransaction.php:73-83 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/xaction/ManiphestTaskUnblockTransaction.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"4aa90498a94361174dcae26095a1a5f3367b6865b167f52f5857d333ca0c7b64"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/applications/nuance/controller/NuanceItemManageController.php:6-17 | src/applications/nuance/controller/NuanceItemViewController.php:6-17 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/nuance/controller/NuanceItemViewController.php:18\u0060 calls \u0060getDisplayName\u0060 and \u0060src/applications/nuance/controller/NuanceItemManageController.php:19\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/controller/NuanceItemManageController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"30fd5e21aa576d146d8426bae936006c546cbcdd92736d4821342893656cd051"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/applications/nuance/management/NuanceManagementWorkflow.php:16-27 | src/applications/nuance/management/NuanceManagementWorkflow.php:77-88 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/nuance/management/NuanceManagementWorkflow.php:16\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/management/NuanceManagementWorkflow.php"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"ed6fb4c2d2e48e8c0b2dcd466e819333c34c007c9c368e7a443ead2445f52f2a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/applications/phame/controller/blog/PhameBlogManageController.php:163-174 | src/applications/phame/controller/blog/PhameBlogViewController.php:126-137 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phame/controller/blog/PhameBlogManageController.php:163\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/blog/PhameBlogManageController.php"},"region":{"startLine":163}}}],"partialFingerprints":{"codehealthFindingId/v1":"4be0d6b6ad64eb96e928a65db94cda5a3db2e804fb06103287cbd704149387b9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/applications/phortune/controller/account/PhortuneAccountAddManagerController.php:37-48 | src/applications/phortune/controller/merchant/PhortuneMerchantAddManagerController.php:35-46 \u2014 before extracting anything, compare \u0060src/applications/phortune/controller/account/PhortuneAccountAddManagerController.php\u0060 and \u0060src/applications/phortune/controller/merchant/PhortuneMerchantAddManagerController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 37 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phortune/controller/account/PhortuneAccountAddManagerController.php:37\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountAddManagerController.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"92609559d40c64584b8f80b26200de7a9f241a73c3da1e96f7653631afd5d0a5"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/applications/phortune/controller/merchant/PhortuneMerchantDetailsController.php:84-95 | src/applications/phortune/controller/merchant/PhortuneMerchantOverviewController.php:122-133 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/merchant/PhortuneMerchantDetailsController.php"},"region":{"startLine":84}}}],"partialFingerprints":{"codehealthFindingId/v1":"a4ddfa52b99e38700ee8b9f31cd79e8b5873fef2d78087a0ef78a819592eef5e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11\u201312 lines \u00D7 2): src/applications/phortune/xaction/PhortuneAccountNameTransaction.php:37-47 | src/applications/phurl/xaction/PhabricatorPhurlURLAliasTransaction.php:37-48 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phortune/xaction/PhortuneAccountNameTransaction.php:37\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/xaction/PhortuneAccountNameTransaction.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"b9d49df833929cada2c7e6dfb6ba5dcd4f07368c6f5f5b666e3aeb434dfca7b4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/applications/project/controller/PhabricatorProjectProfileController.php:20-31 | src/applications/project/view/PhabricatorProjectCardView.php:49-60 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectProfileController.php"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"dfdb69aa9ca1c16c022a61276ba52332f332fb4c3644476da591e98fb7df54d1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/applications/repository/xaction/PhabricatorRepositoryEncodingTransaction.php:25-36 | src/applications/repository/xaction/PhabricatorRepositorySlugTransaction.php:32-43 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/repository/xaction/PhabricatorRepositoryEncodingTransaction.php:25\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/xaction/PhabricatorRepositoryEncodingTransaction.php"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"4d25092dbd6a1e520de42ae7202f0807305f4d2f698d0d5a80d335581e20fd22"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/applications/transactions/storage/PhabricatorApplicationTransaction.php:736-747 | src/applications/transactions/storage/PhabricatorApplicationTransaction.php:804-815 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/transactions/storage/PhabricatorApplicationTransaction.php:736\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorApplicationTransaction.php"},"region":{"startLine":736}}}],"partialFingerprints":{"codehealthFindingId/v1":"38a78cb6d72b0547afb9f6acd8d1a665c38c1b7c9d40493904a22a869f0d91b7"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php:437-448 | src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php:211-222 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php:437\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php"},"region":{"startLine":437}}}],"partialFingerprints":{"codehealthFindingId/v1":"5c7b62b1af16e9c0c0a461a7fa5e13db64f0c1367b2abafaa0427d3563e8a527"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 23): src/applications/badges/xaction/PhabricatorBadgesBadgeNameTransaction.php:42-52 | src/applications/conpherence/xaction/ConpherenceThreadTitleTransaction.php:62-72 | src/applications/conpherence/xaction/ConpherenceThreadTopicTransaction.php:56-66 | src/applications/countdown/xaction/PhabricatorCountdownTitleTransaction.php:40-51 | src/applications/drydock/xaction/DrydockBlueprintNameTransaction.php:46-57 | src/applications/files/xaction/PhabricatorFileNameTransaction.php:41-52 | src/applications/fund/xaction/FundInitiativeNameTransaction.php:57-67 | src/applications/herald/xaction/HeraldRuleNameTransaction.php:33-45 | src/applications/legalpad/xaction/LegalpadDocumentTitleTransaction.php:62-72 | src/applications/nuance/xaction/NuanceQueueNameTransaction.php:33-44 | src/applications/nuance/xaction/NuanceSourceNameTransaction.php:33-44 | src/applications/passphrase/xaction/PassphraseCredentialNameTransaction.php:57-68 | src/applications/passphrase/xaction/PassphraseCredentialUsernameTransaction.php:43-53 | src/applications/phame/xaction/PhameBlogNameTransaction.php:42-52 | src/applications/phame/xaction/PhameBlogParentDomainTransaction.php:70-80 | src/applications/phame/xaction/PhameBlogParentSiteTransaction.php:54-64 | src/applications/phame/xaction/PhameBlogSubtitleTransaction.php:50-60 | src/applications/phame/xaction/PhamePostSubtitleTransaction.php:50-60 | src/applications/phame/xaction/PhamePostTitleTransaction.php:42-52 | src/applications/pholio/xaction/PholioMockNameTransaction.php:75-86 | src/applications/phortune/xaction/PhortuneMerchantNameTransaction.php:42-52 | src/applications/ponder/xaction/PonderQuestionTitleTransaction.php:42-52 | src/applications/spaces/xaction/PhabricatorSpacesNamespaceNameTransaction.php:49-59 \u2014 before extracting anything, compare \u0060src/applications/badges/xaction/PhabricatorBadgesBadgeNameTransaction.php\u0060 and \u0060src/applications/conpherence/xaction/ConpherenceThreadTitleTransaction.php\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 61 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/conpherence/xaction/ConpherenceThreadTopicTransaction.php:52\u0060 calls \u0060validateTransactions\u0060, \u0060array\u0060 and \u0060src/applications/passphrase/xaction/PassphraseCredentialUsernameTransaction.php:40\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/xaction/PhabricatorBadgesBadgeNameTransaction.php"},"region":{"startLine":42}}}],"partialFingerprints":{"codehealthFindingId/v1":"3c662ca713fe0355c15347ab26d7bc99b3d69191bb653561c7d69262b42edda4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 16): src/applications/badges/query/PhabricatorBadgesSearchEngine.php:138-148 | src/applications/countdown/query/PhabricatorCountdownSearchEngine.php:147-157 | src/applications/dashboard/controller/panel/PhabricatorDashboardPanelListController.php:52-62 | src/applications/differential/query/DifferentialRevisionSearchEngine.php:251-261 | src/applications/files/query/PhabricatorFileSearchEngine.php:196-206 | src/applications/herald/query/HeraldRuleSearchEngine.php:153-163 | src/applications/legalpad/query/LegalpadDocumentSearchEngine.php:176-186 | src/applications/macro/query/PhabricatorMacroSearchEngine.php:193-203 | src/applications/owners/query/PhabricatorOwnersPackageSearchEngine.php:159-169 | src/applications/passphrase/query/PassphraseCredentialSearchEngine.php:115-125 | src/applications/pholio/query/PholioMockSearchEngine.php:134-144 | src/applications/ponder/query/PonderQuestionSearchEngine.php:184-194 | src/applications/project/query/PhabricatorProjectSearchEngine.php:340-350 | src/applications/repository/query/PhabricatorRepositorySearchEngine.php:269-279 | src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php:167-177 | src/applications/spaces/query/PhabricatorSpacesNamespaceSearchEngine.php:102-112 \u2014 before extracting anything, compare \u0060src/applications/dashboard/controller/panel/PhabricatorDashboardPanelListController.php\u0060 and \u0060src/applications/files/query/PhabricatorFileSearchEngine.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 30 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/query/PhabricatorBadgesSearchEngine.php"},"region":{"startLine":138}}}],"partialFingerprints":{"codehealthFindingId/v1":"715300545448948e50a51237eb6b2adbb2db05c840b617c474a82548c1c310b4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 8): src/applications/conpherence/controller/ConpherenceRoomPictureController.php:190-200 | src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php:208-218 | src/applications/people/controller/PhabricatorPeopleProfilePictureController.php:245-255 | src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php:81-91 | src/applications/phame/controller/blog/PhameBlogProfilePictureController.php:191-201 | src/applications/phame/controller/post/PhamePostHeaderPictureController.php:81-91 | src/applications/phortune/controller/merchant/PhortuneMerchantPictureController.php:180-190 | src/applications/project/controller/PhabricatorProjectEditPictureController.php:252-262 \u2014 before extracting anything, compare \u0060src/applications/conpherence/controller/ConpherenceRoomPictureController.php\u0060 and \u0060src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 119 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/conpherence/controller/ConpherenceRoomPictureController.php:190\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceRoomPictureController.php"},"region":{"startLine":190}}}],"partialFingerprints":{"codehealthFindingId/v1":"05fa358249e48fba43aa3d93d42557b68a46810cb2f46f66d9ec0e5f46215c56"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 7): src/applications/conpherence/controller/ConpherenceRoomPictureController.php:215-226 | src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php:120-130 | src/applications/phame/controller/blog/PhameBlogProfilePictureController.php:221-232 | src/applications/phame/controller/post/PhamePostHeaderPictureController.php:117-127 | src/applications/phortune/controller/paymentmethod/PhortunePaymentMethodCreateController.php:316-329 | src/applications/phortune/controller/paymentmethod/PhortunePaymentMethodEditController.php:81-94 | src/applications/transactions/controller/PhabricatorEditEngineConfigurationDefaultsController.php:111-122 \u2014 before extracting anything, compare \u0060src/applications/conpherence/controller/ConpherenceRoomPictureController.php\u0060 and \u0060src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 57 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceRoomPictureController.php"},"region":{"startLine":215}}}],"partialFingerprints":{"codehealthFindingId/v1":"dada55b2b35007399c64d4bcb69f988e713a83eb43a4a7cf0a637a1049b29cf7"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9\u201311 lines \u00D7 7): src/applications/owners/controller/PhabricatorOwnersPathsController.php:162-170 | src/applications/people/controller/PhabricatorPeopleProfilePictureController.php:255-263 | src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php:100-108 | src/applications/phame/controller/blog/PhameBlogProfilePictureController.php:201-209 | src/applications/phame/controller/post/PhamePostHeaderPictureController.php:100-108 | src/applications/phortune/controller/merchant/PhortuneMerchantPictureController.php:190-198 | src/applications/phortune/controller/paymentmethod/PhortunePaymentMethodEditController.php:66-76 \u2014 before extracting anything, compare \u0060src/applications/people/controller/PhabricatorPeopleProfilePictureController.php\u0060 and \u0060src/applications/phame/controller/blog/PhameBlogProfilePictureController.php\u0060 as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 146 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/owners/controller/PhabricatorOwnersPathsController.php"},"region":{"startLine":162}}}],"partialFingerprints":{"codehealthFindingId/v1":"6ddde02f02243cbd5ca5d74cddfa96ed133e02cc9f0aa5426e2c3c9dfaaa09a7"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10\u201311 lines \u00D7 5): src/applications/almanac/query/AlmanacDeviceSearchEngine.php:100-110 | src/applications/almanac/query/AlmanacServiceSearchEngine.php:93-103 | src/applications/auth/query/PhabricatorAuthSSHKeySearchEngine.php:80-89 | src/applications/nuance/query/NuanceQueueSearchEngine.php:56-65 | src/applications/nuance/query/NuanceSourceSearchEngine.php:65-74 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 5 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 5 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/almanac/query/AlmanacDeviceSearchEngine.php:100\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/nuance/query/NuanceSourceSearchEngine.php:77\u0060 calls \u0060addIcon\u0060, \u0060getType\u0060 and \u0060src/applications/nuance/query/NuanceQueueSearchEngine.php:67\u0060 does not \u2014 after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/query/AlmanacDeviceSearchEngine.php"},"region":{"startLine":100}}}],"partialFingerprints":{"codehealthFindingId/v1":"3eca0a316069efe68ce7d4933c2367e731e5ea04c6fb42898e454312497c5f50"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 5): src/applications/countdown/controller/PhabricatorCountdownViewController.php:110-120 | src/applications/passphrase/controller/PassphraseCredentialViewController.php:65-75 | src/applications/paste/controller/PhabricatorPasteViewController.php:153-163 | src/applications/ponder/controller/PonderQuestionViewController.php:182-192 | src/applications/slowvote/controller/PhabricatorSlowvotePollController.php:121-131 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 5 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 5 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/countdown/controller/PhabricatorCountdownViewController.php"},"region":{"startLine":110}}}],"partialFingerprints":{"codehealthFindingId/v1":"c29a7e2f4a33e3f5f35a57e6e85e1b326214e0df9b8d8860567d51da1a55b1ee"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 4): src/applications/diffusion/engineextension/DiffusionDatasourceEngineExtension.php:34-44 | src/applications/phriction/engineextension/PhrictionDatasourceEngineExtension.php:28-38 | src/applications/project/engineextension/ProjectDatasourceEngineExtension.php:28-38 | src/applications/search/engineextension/PhabricatorFerretSearchEngineExtension.php:38-49 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/engineextension/DiffusionDatasourceEngineExtension.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"bbce6e34f5a5bcae4cf66c02a0f6be1aa86ead48b8267574861c9ddbeb67b41e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 4): src/applications/drydock/query/DrydockLogQuery.php:44-54 | src/applications/drydock/query/DrydockLogQuery.php:65-75 | src/applications/drydock/query/DrydockLogQuery.php:86-96 | src/applications/drydock/query/DrydockLogQuery.php:107-117 \u2014 all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/drydock/query/DrydockLogQuery.php:44\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/query/DrydockLogQuery.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"3de99096465ae702105e84f4c3bf89fb69c885b2d7676947b8d00af790fdf926"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 3): src/applications/almanac/controller/AlmanacServiceEditController.php:85-95 | src/applications/calendar/controller/PhabricatorCalendarImportEditController.php:65-75 | src/applications/nuance/controller/NuanceSourceEditController.php:53-63 \u2014 before extracting anything, compare \u0060src/applications/almanac/controller/AlmanacServiceEditController.php\u0060 and \u0060src/applications/calendar/controller/PhabricatorCalendarImportEditController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 58 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/controller/AlmanacServiceEditController.php"},"region":{"startLine":85}}}],"partialFingerprints":{"codehealthFindingId/v1":"dc139e1b292116e72b884b8fbe4e4c08c2c9e51c69810952a2e7970ce6d6c481"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 3): src/applications/almanac/typeahead/AlmanacServiceDatasource.php:38-48 | src/applications/harbormaster/controller/HarbormasterBuildViewController.php:643-653 | src/applications/metamta/typeahead/PhabricatorMetaMTAApplicationEmailDatasource.php:33-43 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/almanac/typeahead/AlmanacServiceDatasource.php:38\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/typeahead/AlmanacServiceDatasource.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"e455b0b689c67cb97957117464b998ab659e456d7e663df2672cf35d60ec19b1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10\u201311 lines \u00D7 3): src/applications/auth/controller/PhabricatorAuthSSHKeyEditController.php:90-99 | src/applications/phortune/controller/account/PhortuneAccountAddManagerController.php:36-46 | src/applications/phortune/controller/merchant/PhortuneMerchantAddManagerController.php:34-44 \u2014 before extracting anything, compare \u0060src/applications/phortune/controller/account/PhortuneAccountAddManagerController.php\u0060 and \u0060src/applications/phortune/controller/merchant/PhortuneMerchantAddManagerController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 37 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/auth/controller/PhabricatorAuthSSHKeyEditController.php:90\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/auth/controller/PhabricatorAuthSSHKeyEditController.php:100\u0060 calls \u0060getShortMessage\u0060 and \u0060src/applications/phortune/controller/account/PhortuneAccountAddManagerController.php:47\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthSSHKeyEditController.php"},"region":{"startLine":90}}}],"partialFingerprints":{"codehealthFindingId/v1":"3459dd3f7015083595b9d2d657ac042a1f2cf31ba71ceab4d4143ef05b8c5461"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 3): src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php:116-127 | src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php:170-180 | src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php:217-227 \u2014 there are 3 copies across 2 file(s) \u2014 more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php"},"region":{"startLine":116}}}],"partialFingerprints":{"codehealthFindingId/v1":"28757d57ee32a3109f7fd606df1c2659dc88de502ed8a66c6b3fb3d90d367dd9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 3): src/applications/drydock/typeahead/DrydockBlueprintDatasource.php:23-33 | src/applications/drydock/typeahead/DrydockLeaseDatasource.php:19-29 | src/applications/drydock/typeahead/DrydockResourceDatasource.php:19-29 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/drydock/typeahead/DrydockBlueprintDatasource.php:23\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/typeahead/DrydockBlueprintDatasource.php"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"67504da82e716fb005cfa14d9225d7b2e6609c2a1d17b9564986e3802bd21782"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 3): src/applications/people/controller/PhabricatorPeopleDeleteController.php:8-18 | src/applications/people/controller/PhabricatorPeopleEmpowerController.php:8-18 | src/applications/people/controller/PhabricatorPeopleRenameController.php:13-23 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/controller/PhabricatorPeopleDeleteController.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"cf590dd419e804318991419aa008d4b028dc902558767a775bc232cc00aeb412"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 3): src/applications/phortune/query/PhortuneCartSearchEngine.php:67-77 | src/applications/phortune/query/PhortuneChargeSearchEngine.php:43-53 | src/applications/phortune/query/PhortuneSubscriptionSearchEngine.php:76-86 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phortune/query/PhortuneCartSearchEngine.php:67\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/phortune/query/PhortuneCartSearchEngine.php:65\u0060 calls \u0060withMerchantPHIDs\u0060, \u0060array\u0060, \u0060getPHID\u0060 and \u0060src/applications/phortune/query/PhortuneChargeSearchEngine.php:42\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/query/PhortuneCartSearchEngine.php"},"region":{"startLine":67}}}],"partialFingerprints":{"codehealthFindingId/v1":"24aa106b23e18955918683b1bb3085b8e04082c176c653f8e1a6fd4215523b8c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 3): src/applications/transactions/controller/PhabricatorEditEngineConfigurationDefaultCreateController.php:27-37 | src/applications/transactions/controller/PhabricatorEditEngineConfigurationDisableController.php:27-37 | src/applications/transactions/controller/PhabricatorEditEngineConfigurationIsEditController.php:26-36 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/transactions/controller/PhabricatorEditEngineConfigurationDefaultCreateController.php:27\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/controller/PhabricatorEditEngineConfigurationDefaultCreateController.php"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"b8b1615423cfcafc65fbc6223d877404ed4d6720fbee40018acec485e78e1c53"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/almanac/controller/AlmanacBindingEditController.php:78-88 | src/applications/phortune/controller/merchant/PhortuneMerchantAddManagerController.php:41-51 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/almanac/controller/AlmanacBindingEditController.php:78\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/almanac/controller/AlmanacBindingEditController.php:77\u0060 calls \u0060getURI\u0060 and \u0060src/applications/phortune/controller/merchant/PhortuneMerchantAddManagerController.php:39\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/controller/AlmanacBindingEditController.php"},"region":{"startLine":78}}}],"partialFingerprints":{"codehealthFindingId/v1":"66642c158d65d5ad9eecea2627ad3311333891946238a0c97ff4e322de1857bd"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/almanac/controller/AlmanacDeviceViewController.php:16-26 | src/applications/almanac/controller/AlmanacServiceViewController.php:16-26 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/almanac/controller/AlmanacServiceViewController.php:27\u0060 calls \u0060buildPropertySection\u0060 and \u0060src/applications/almanac/controller/AlmanacDeviceViewController.php:28\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/controller/AlmanacDeviceViewController.php"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"9aab8d175da330b7b0dff438bd10222dbff8c05facfa967306cb21939a830860"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/aphlict/management/PhabricatorAphlictManagementNotifyWorkflow.php:59-69 | src/applications/notification/controller/PhabricatorNotificationTestController.php:20-30 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/aphlict/management/PhabricatorAphlictManagementNotifyWorkflow.php:57\u0060 calls \u0060newContentSource\u0060 and \u0060src/applications/notification/controller/PhabricatorNotificationTestController.php:18\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/aphlict/management/PhabricatorAphlictManagementNotifyWorkflow.php"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"fcd8f001d6f3695be3e24d933036c8393bb2e559426c68d2e440b1df66afc89f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/auth/controller/PhabricatorAuthSSHKeyEditController.php:81-91 | src/applications/auth/controller/PhabricatorAuthSSHKeyGenerateController.php:54-64 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthSSHKeyEditController.php"},"region":{"startLine":81}}}],"partialFingerprints":{"codehealthFindingId/v1":"cef5b73e00baa161936a96d619b2c8e93988b74bec26b5eb5191749f64935f84"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/auth/controller/PhabricatorAuthSSHKeyViewController.php:91-101 | src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php:143-153 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/auth/controller/PhabricatorAuthSSHKeyViewController.php:91\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthSSHKeyViewController.php"},"region":{"startLine":91}}}],"partialFingerprints":{"codehealthFindingId/v1":"e75864060c648566ba48d20f92b081adc795a391d2186151bc300de3bae15e52"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/auth/engine/PhabricatorAuthInviteEngine.php:133-143 | src/applications/auth/engine/PhabricatorAuthInviteEngine.php:149-159 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/engine/PhabricatorAuthInviteEngine.php"},"region":{"startLine":133}}}],"partialFingerprints":{"codehealthFindingId/v1":"70d9042fc27937bad22e1c64f9d5fefb443efa6e13e498b03b9771445cbce7db"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/auth/query/PhabricatorAuthInviteQuery.php:39-49 | src/applications/diffusion/query/DiffusionSymbolQuery.php:152-162 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/query/PhabricatorAuthInviteQuery.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"0dc0763ddef3da4a61e8d29755942feb41d63152bc9d1ba6e90d37cf1b58a9a6"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10\u201311 lines \u00D7 2): src/applications/auth/query/PhabricatorAuthSessionQuery.php:45-54 | src/applications/people/query/PhabricatorPeopleUserEmailQuery.php:52-62 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/auth/query/PhabricatorAuthSessionQuery.php:45\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/query/PhabricatorAuthSessionQuery.php"},"region":{"startLine":45}}}],"partialFingerprints":{"codehealthFindingId/v1":"d03058f364e98952d7082062ca0a18e061d6681ae8a236cc94ad386f269bd6e3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/badges/controller/PhabricatorBadgesAwardController.php:38-48 | src/applications/badges/controller/PhabricatorBadgesEditRecipientsController.php:36-46 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/controller/PhabricatorBadgesAwardController.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"aeaa5cf927558c3961b95f5c08c852f4ba6f55962e4d5d6fa9ce48c1e8ef7f40"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/badges/controller/PhabricatorBadgesProfileController.php:59-69 | src/applications/phortune/controller/merchant/PhortuneMerchantProfileController.php:34-44 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/controller/PhabricatorBadgesProfileController.php"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"51fd4a7bdfc37036303f1ede94b351a51b9ce45f4cb8c422e7ad70468878ad2e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/badges/xaction/PhabricatorBadgesBadgeAwardTransaction.php:37-47 | src/applications/badges/xaction/PhabricatorBadgesBadgeRevokeTransaction.php:40-50 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/xaction/PhabricatorBadgesBadgeAwardTransaction.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"ba174c5508873958e6dd9505b8a70157b500f335341d5564c7601d219fc2ee82"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/config/controller/services/PhabricatorConfigDatabaseStatusController.php:592-602 | src/applications/config/controller/services/PhabricatorConfigDatabaseStatusController.php:607-617 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/config/controller/services/PhabricatorConfigDatabaseStatusController.php:592\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/config/controller/services/PhabricatorConfigDatabaseStatusController.php:606\u0060 calls \u0060getDataType\u0060 and \u0060src/applications/config/controller/services/PhabricatorConfigDatabaseStatusController.php:591\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/services/PhabricatorConfigDatabaseStatusController.php"},"region":{"startLine":592}}}],"partialFingerprints":{"codehealthFindingId/v1":"d1cd500045069b14eca704e7861f2fc54cc4abfbac1035c5cfc6c7816d212316"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/differential/controller/DifferentialRevisionViewController.php:702-712 | src/applications/macro/controller/PhabricatorMacroViewController.php:127-137 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/controller/DifferentialRevisionViewController.php"},"region":{"startLine":702}}}],"partialFingerprints":{"codehealthFindingId/v1":"9b5be165be07f659c40834becd11727e168486293a4655fe8440079130990fd8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/differential/customfield/DifferentialLintField.php:89-99 | src/applications/differential/customfield/DifferentialUnitField.php:78-88 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/customfield/DifferentialLintField.php"},"region":{"startLine":89}}}],"partialFingerprints":{"codehealthFindingId/v1":"e193cac0f21305cc8d79d68f8d44d4dff26954a12a3b33bbe90ce9378c1da474"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php:109-119 | src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php:253-263 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php"},"region":{"startLine":109}}}],"partialFingerprints":{"codehealthFindingId/v1":"689cfb29f3330970af12ae6ea773484dd4c2684e05563f5e5a8963629c9e2928"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php:177-187 | src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php:216-226 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php"},"region":{"startLine":177}}}],"partialFingerprints":{"codehealthFindingId/v1":"bbf01925fd61cfb9f4d36a7020a421557c47f510d1026af774855c5b9882ebc9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/differential/query/DifferentialRevisionSearchEngine.php:361-371 | src/applications/maniphest/query/ManiphestTaskSearchEngine.php:531-541 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/differential/query/DifferentialRevisionSearchEngine.php:361\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/maniphest/query/ManiphestTaskSearchEngine.php:528\u0060 calls \u0060getOwnerPHID\u0060, \u0060getCloserPHID\u0060 and \u0060src/applications/differential/query/DifferentialRevisionSearchEngine.php:359\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/query/DifferentialRevisionSearchEngine.php"},"region":{"startLine":361}}}],"partialFingerprints":{"codehealthFindingId/v1":"7263fb78fe3aafb40b43e1213d6b6d49e01820f50335a7307312a71379d62cf3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/diffusion/controller/DiffusionRepositoryEditActivateController.php:30-40 | src/applications/diffusion/controller/DiffusionRepositoryEditPublishingController.php:30-40 \u2014 before extracting anything, compare \u0060src/applications/diffusion/controller/DiffusionRepositoryEditActivateController.php\u0060 and \u0060src/applications/diffusion/controller/DiffusionRepositoryEditPublishingController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 36 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/diffusion/controller/DiffusionRepositoryEditActivateController.php:30\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRepositoryEditActivateController.php"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"4a44fc92595bcb3ea9f839a79b7fc8f0c9a417f689f39e44d35a21586275d8f1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/diffusion/editor/DiffusionURIEditor.php:299-309 | src/applications/diffusion/editor/DiffusionURIEditor.php:412-422 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/diffusion/editor/DiffusionURIEditor.php:299\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/editor/DiffusionURIEditor.php"},"region":{"startLine":299}}}],"partialFingerprints":{"codehealthFindingId/v1":"a3be520f982f6285c9c873aa82df13dc4a6ef747c97e7ec2d897d436cb0cf208"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubIssue.php:21-31 | src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubUser.php:21-31 \u2014 before extracting anything, compare \u0060src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubIssue.php\u0060 and \u0060src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubUser.php\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 92 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubIssue.php:21\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubIssue.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"42d148a31761e91f34db343934fcf0dd2ca98275b329ab861515754d5eddf581"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/files/controller/PhabricatorFileUICurtainListController.php:41-51 | src/applications/subscriptions/view/SubscriptionListDialogBuilder.php:66-76 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/files/controller/PhabricatorFileUICurtainListController.php:41\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/files/controller/PhabricatorFileUICurtainListController.php:38\u0060 calls \u0060getFilePHID\u0060 and \u0060src/applications/subscriptions/view/SubscriptionListDialogBuilder.php:65\u0060 does not \u2014 after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/controller/PhabricatorFileUICurtainListController.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"c4f215ccaa31d252417f5c3cf6e7ca5fc33ea1c527f62cef27ba9fa5f78823e2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/files/controller/PhabricatorFileViewController.php:185-195 | src/applications/maniphest/controller/ManiphestTaskDetailController.php:358-368 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/controller/PhabricatorFileViewController.php"},"region":{"startLine":185}}}],"partialFingerprints":{"codehealthFindingId/v1":"dfdf1d37df73153057e99e56bea2df0a37e65652f235d06b1d2e27786bd0981f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10\u201311 lines \u00D7 2): src/applications/flag/controller/PhabricatorFlagEditController.php:6-16 | src/applications/tokens/controller/PhabricatorTokenGiveController.php:6-15 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/flag/controller/PhabricatorFlagEditController.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"a8297798fc50ff97da1985253a2f98dfed0b4b3b452519909a5eede191f30dff"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/harbormaster/conduit/HarbormasterSendMessageConduitAPIMethod.php:320-330 | src/applications/harbormaster/conduit/HarbormasterSendMessageConduitAPIMethod.php:402-412 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/conduit/HarbormasterSendMessageConduitAPIMethod.php"},"region":{"startLine":320}}}],"partialFingerprints":{"codehealthFindingId/v1":"72db3f31c4592bbcb5aefabdf2ed519e6193d4665e30f2983a376271f99d78fe"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php:11-21 | src/applications/harbormaster/controller/HarbormasterBuildLogViewController.php:11-21 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"94285a1377d791b8bcfcc8354a3491e70d9523dafb8c41aed455f1ab2454342a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/people/controller/PhabricatorPeopleProfileViewController.php:32-42 | src/applications/project/controller/PhabricatorProjectProfileController.php:105-115 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/project/controller/PhabricatorProjectProfileController.php:117\u0060 calls \u0060renderStories\u0060 and \u0060src/applications/people/controller/PhabricatorPeopleProfileViewController.php:44\u0060 does not \u2014 after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/controller/PhabricatorPeopleProfileViewController.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"9c85a7bf7f20835c11ae7da56b3bc7bfd9cca75b4494505f3ba555debe552bad"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10\u201311 lines \u00D7 2): src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php:54-63 | src/applications/phame/controller/blog/PhameBlogProfilePictureController.php:69-79 \u2014 before extracting anything, compare \u0060src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php\u0060 and \u0060src/applications/phame/controller/blog/PhameBlogProfilePictureController.php\u0060 as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 135 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php:54\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"b4249cd5522ff078bd4405225f6a712c41dde251d5bf667a321f99fd4da56bca"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/phortune/controller/account/PhortuneAccountPaymentMethodViewController.php:78-88 | src/applications/phortune/controller/merchant/PhortuneMerchantProviderViewController.php:78-88 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phortune/controller/account/PhortuneAccountPaymentMethodViewController.php:78\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountPaymentMethodViewController.php"},"region":{"startLine":78}}}],"partialFingerprints":{"codehealthFindingId/v1":"a6f45ba2db6dd59576555442d155b3215bc8c8ffe3bc62546648f91f203bbf67"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/phortune/controller/cart/PhortuneCartCancelController.php:96-106 | src/applications/phortune/controller/cart/PhortuneCartUpdateController.php:32-42 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phortune/controller/cart/PhortuneCartCancelController.php:96\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/cart/PhortuneCartCancelController.php"},"region":{"startLine":96}}}],"partialFingerprints":{"codehealthFindingId/v1":"6dcd51a7f4a2cc4ef36017f5413ccecd4b937e0d1774bde5c4b65c80aa11adda"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/phortune/controller/merchant/PhortuneMerchantDetailsController.php:14-24 | src/applications/phortune/controller/merchant/PhortuneMerchantProvidersController.php:12-23 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/phortune/controller/merchant/PhortuneMerchantDetailsController.php:12\u0060 calls \u0060getURIData\u0060 and \u0060src/applications/phortune/controller/merchant/PhortuneMerchantProvidersController.php:11\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/merchant/PhortuneMerchantDetailsController.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"2d64cdcc88bfd67098c03154124ef3ead4505f2aa0a2871bc3d5d85d278c91f7"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10\u201311 lines \u00D7 2): src/applications/phortune/query/PhortuneAccountEmailQuery.php:42-52 | src/applications/phortune/query/PhortuneChargeQuery.php:60-69 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phortune/query/PhortuneAccountEmailQuery.php:42\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/phortune/query/PhortuneAccountEmailQuery.php:53\u0060 calls \u0060didRejectResult\u0060 and \u0060src/applications/phortune/query/PhortuneChargeQuery.php:70\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/query/PhortuneAccountEmailQuery.php"},"region":{"startLine":42}}}],"partialFingerprints":{"codehealthFindingId/v1":"7bd9c720f1c92f0a3a78319580ed670d38749a2a44e61b0cd723b75a634b3a5b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/phortune/query/PhortuneCartQuery.php:82-92 | src/applications/phortune/query/PhortuneChargeQuery.php:64-74 \u2014 before extracting anything, compare \u0060src/applications/phortune/query/PhortuneCartQuery.php\u0060 and \u0060src/applications/phortune/query/PhortuneChargeQuery.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 36 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/phortune/query/PhortuneChargeQuery.php:62\u0060 calls \u0060setParentQuery\u0060 and \u0060src/applications/phortune/query/PhortuneCartQuery.php:80\u0060 does not \u2014 after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/query/PhortuneCartQuery.php"},"region":{"startLine":82}}}],"partialFingerprints":{"codehealthFindingId/v1":"cc735ff1de8b028bca36d4b9fdaa7ae65f84c5f36c859625d462cbc1250024e7"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/project/controller/PhabricatorProjectReportsController.php:35-45 | src/applications/project/controller/PhabricatorProjectReportsController.php:48-58 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectReportsController.php"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"6ceb8a2317bb2f59ace364bb7d80286743f23c8ffc8c2bd282039713049002fd"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/repository/storage/PhabricatorRepositoryURI.php:458-468 | src/applications/repository/storage/PhabricatorRepositoryURI.php:480-490 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepositoryURI.php"},"region":{"startLine":458}}}],"partialFingerprints":{"codehealthFindingId/v1":"a450527bd715d1afebbc77af7697eda1950e5203cd185ce630ab373bf49d2dc3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/search/controller/PhabricatorApplicationSearchController.php:410-420 | src/infrastructure/export/engine/PhabricatorExportEngineBulkJobType.php:67-77 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/search/controller/PhabricatorApplicationSearchController.php:410\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/controller/PhabricatorApplicationSearchController.php"},"region":{"startLine":410}}}],"partialFingerprints":{"codehealthFindingId/v1":"d4ecb39f4612ed28da558bb765169f346ed26445a75b25f0443ce2e9f0321939"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/subscriptions/controller/PhabricatorSubscriptionsEditController.php:26-36 | src/applications/subscriptions/controller/PhabricatorSubscriptionsMuteController.php:10-20 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/subscriptions/controller/PhabricatorSubscriptionsEditController.php:26\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/subscriptions/controller/PhabricatorSubscriptionsEditController.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"30dd714af29da9de6f1c962044fe4dd109bf13b2c73ff8412fefd572a7b68bbf"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19\u201320 lines \u00D7 2): src/applications/transactions/storage/PhabricatorApplicationTransaction.php:1270-1288 | src/applications/transactions/storage/PhabricatorApplicationTransaction.php:1442-1461 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/transactions/storage/PhabricatorApplicationTransaction.php:1270\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/transactions/storage/PhabricatorApplicationTransaction.php:1462\u0060 calls \u0060renderHandleLink\u0060 and \u0060src/applications/transactions/storage/PhabricatorApplicationTransaction.php:1289\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorApplicationTransaction.php"},"region":{"startLine":1270}}}],"partialFingerprints":{"codehealthFindingId/v1":"6076e47724287284ea9139c296252b7971f88c19dbcaeaed3b8f2f10f6616110"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php:116-126 | src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php:153-163 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php:116\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php"},"region":{"startLine":116}}}],"partialFingerprints":{"codehealthFindingId/v1":"6f25e2123a2e58a6f74cadd639952e910e741b4292ed0cf2f86d696ebd9ff53f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php:2115-2125 | src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php:2496-2506 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php:2489\u0060 calls \u0060array\u0060 and \u0060src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php:2108\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php"},"region":{"startLine":2115}}}],"partialFingerprints":{"codehealthFindingId/v1":"290b3d025ccba6ac60410007ffe80145503a73b3e8dd49d5e6cc929d45209a7e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6\u201311 lines \u00D7 3): src/infrastructure/storage/xsprintf/qsprintf.php:221-231 | src/infrastructure/storage/xsprintf/qsprintf.php:234-244 | src/infrastructure/storage/xsprintf/qsprintf.php:245-250 \u2014 all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/infrastructure/storage/xsprintf/qsprintf.php:221\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/infrastructure/storage/xsprintf/qsprintf.php:220\u0060 calls \u0060is_string\u0060 and \u0060src/infrastructure/storage/xsprintf/qsprintf.php:245\u0060 does not \u2014 after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/xsprintf/qsprintf.php"},"region":{"startLine":221}}}],"partialFingerprints":{"codehealthFindingId/v1":"19fe8b743110564ddc6a35a7bf636a6328a21a1105247550f476601db4e640fa"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8\u201311 lines \u00D7 3): src/view/control/AphrontCursorPagerView.php:143-153 | src/view/control/AphrontCursorPagerView.php:156-166 | src/view/control/AphrontCursorPagerView.php:168-175 \u2014 all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/view/control/AphrontCursorPagerView.php:168\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/control/AphrontCursorPagerView.php"},"region":{"startLine":143}}}],"partialFingerprints":{"codehealthFindingId/v1":"b6c3c944f6f30b662054a44e02e1d1d6e01652f74c89a21f8fc074fb5b73e4d4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 24): src/applications/badges/xaction/PhabricatorBadgesBadgeNameTransaction.php:41-50 | src/applications/conpherence/xaction/ConpherenceThreadTitleTransaction.php:61-70 | src/applications/conpherence/xaction/ConpherenceThreadTopicTransaction.php:55-64 | src/applications/countdown/xaction/PhabricatorCountdownTitleTransaction.php:39-49 | src/applications/drydock/xaction/DrydockBlueprintNameTransaction.php:45-55 | src/applications/files/xaction/PhabricatorFileNameTransaction.php:40-50 | src/applications/fund/xaction/FundInitiativeNameTransaction.php:56-65 | src/applications/herald/xaction/HeraldRuleNameTransaction.php:32-43 | src/applications/legalpad/xaction/LegalpadDocumentTitleTransaction.php:61-70 | src/applications/nuance/xaction/NuanceQueueNameTransaction.php:32-42 | src/applications/nuance/xaction/NuanceSourceNameTransaction.php:32-42 | src/applications/passphrase/xaction/PassphraseCredentialNameTransaction.php:56-66 | src/applications/passphrase/xaction/PassphraseCredentialUsernameTransaction.php:42-51 | src/applications/phame/xaction/PhameBlogNameTransaction.php:41-50 | src/applications/phame/xaction/PhameBlogParentDomainTransaction.php:69-78 | src/applications/phame/xaction/PhameBlogParentSiteTransaction.php:53-62 | src/applications/phame/xaction/PhameBlogSubtitleTransaction.php:49-58 | src/applications/phame/xaction/PhamePostSubtitleTransaction.php:49-58 | src/applications/phame/xaction/PhamePostTitleTransaction.php:41-50 | src/applications/pholio/xaction/PholioMockNameTransaction.php:74-84 | src/applications/phortune/xaction/PhortuneMerchantNameTransaction.php:41-50 | src/applications/ponder/xaction/PonderQuestionTitleTransaction.php:41-50 | src/applications/project/xaction/PhabricatorProjectNameTransaction.php:72-82 | src/applications/spaces/xaction/PhabricatorSpacesNamespaceNameTransaction.php:48-57 \u2014 before extracting anything, compare \u0060src/applications/badges/xaction/PhabricatorBadgesBadgeNameTransaction.php\u0060 and \u0060src/applications/conpherence/xaction/ConpherenceThreadTitleTransaction.php\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 61 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/project/xaction/PhabricatorProjectNameTransaction.php:84\u0060 calls \u0060getEditor\u0060, \u0060getIsMilestone\u0060 and \u0060src/applications/badges/xaction/PhabricatorBadgesBadgeNameTransaction.php:52\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/xaction/PhabricatorBadgesBadgeNameTransaction.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"1ce97ce02490937d590234e166a02ef523556d4369e201415d9e9615670bc5c7"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 10): src/applications/dashboard/controller/panel/PhabricatorDashboardPanelListController.php:58-67 | src/applications/files/query/PhabricatorFileSearchEngine.php:202-211 | src/applications/legalpad/query/LegalpadDocumentSearchEngine.php:182-191 | src/applications/macro/query/PhabricatorMacroSearchEngine.php:199-208 | src/applications/passphrase/query/PassphraseCredentialSearchEngine.php:121-130 | src/applications/paste/query/PhabricatorPasteSearchEngine.php:213-222 | src/applications/phurl/query/PhabricatorPhurlURLSearchEngine.php:136-145 | src/applications/ponder/query/PonderQuestionSearchEngine.php:190-199 | src/applications/repository/query/PhabricatorRepositorySearchEngine.php:275-284 | src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php:173-182 \u2014 before extracting anything, compare \u0060src/applications/dashboard/controller/panel/PhabricatorDashboardPanelListController.php\u0060 and \u0060src/applications/files/query/PhabricatorFileSearchEngine.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 30 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/panel/PhabricatorDashboardPanelListController.php"},"region":{"startLine":58}}}],"partialFingerprints":{"codehealthFindingId/v1":"62b2090a34677c63d68397f9ba5a4dd09eebc9fbdd85be515bddc51b6cfb368f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9\u201310 lines \u00D7 6): src/applications/auth/query/PhabricatorAuthPasswordQuery.php:83-92 | src/applications/auth/query/PhabricatorAuthSSHKeyQuery.php:51-60 | src/applications/auth/query/PhabricatorAuthSessionQuery.php:42-51 | src/applications/conduit/query/PhabricatorConduitTokenQuery.php:90-98 | src/applications/drydock/query/DrydockCommandQuery.php:29-38 | src/applications/search/query/PhabricatorProfileMenuItemConfigurationQuery.php:128-137 \u2014 before extracting anything, compare \u0060src/applications/auth/query/PhabricatorAuthPasswordQuery.php\u0060 and \u0060src/applications/auth/query/PhabricatorAuthSSHKeyQuery.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 45 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/auth/query/PhabricatorAuthPasswordQuery.php:83\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/query/PhabricatorAuthPasswordQuery.php"},"region":{"startLine":83}}}],"partialFingerprints":{"codehealthFindingId/v1":"05821c03878053e8e07f59da660688ae4c3c7393fdf842c16ef984668961409c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 5): src/applications/transactions/controller/PhabricatorEditEngineConfigurationDefaultsController.php:7-16 | src/applications/transactions/controller/PhabricatorEditEngineConfigurationLockController.php:7-16 | src/applications/transactions/controller/PhabricatorEditEngineConfigurationReorderController.php:7-16 | src/applications/transactions/controller/PhabricatorEditEngineConfigurationSaveController.php:7-16 | src/applications/transactions/controller/PhabricatorEditEngineConfigurationSubtypeController.php:7-16 \u2014 before extracting anything, compare \u0060src/applications/transactions/controller/PhabricatorEditEngineConfigurationDefaultsController.php\u0060 and \u0060src/applications/transactions/controller/PhabricatorEditEngineConfigurationLockController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 43 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/controller/PhabricatorEditEngineConfigurationDefaultsController.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"5c5f16c898c347ef9b8a9529b455d8f7b07f48ea0e51eedbe8f4c82a3fe679be"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 4): src/applications/almanac/phid/AlmanacDevicePHIDType.php:32-41 | src/applications/almanac/phid/AlmanacNamespacePHIDType.php:32-41 | src/applications/almanac/phid/AlmanacNetworkPHIDType.php:32-41 | src/applications/almanac/phid/AlmanacServicePHIDType.php:32-41 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 4 call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/phid/AlmanacDevicePHIDType.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"30c716fae8c77393cf9066261a03d3d0215a5867320aa911e620240e310643b2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 4): src/applications/auth/xaction/PhabricatorAuthContactNumberNumberTransaction.php:42-51 | src/applications/auth/xaction/PhabricatorAuthFactorProviderNameTransaction.php:42-51 | src/applications/project/xaction/column/PhabricatorProjectColumnNameTransaction.php:53-62 | src/applications/project/xaction/trigger/PhabricatorProjectTriggerNameTransaction.php:42-51 \u2014 before extracting anything, compare \u0060src/applications/auth/xaction/PhabricatorAuthFactorProviderNameTransaction.php\u0060 and \u0060src/applications/project/xaction/trigger/PhabricatorProjectTriggerNameTransaction.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 33 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/auth/xaction/PhabricatorAuthContactNumberNumberTransaction.php:42\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/auth/xaction/PhabricatorAuthFactorProviderNameTransaction.php:39\u0060 calls \u0060validateTransactions\u0060, \u0060array\u0060 and \u0060src/applications/project/xaction/column/PhabricatorProjectColumnNameTransaction.php:51\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/xaction/PhabricatorAuthContactNumberNumberTransaction.php"},"region":{"startLine":42}}}],"partialFingerprints":{"codehealthFindingId/v1":"d211f91be95fc590e0b971cbee5e7d0146e5152a6f33b5404a58aaa3bdf68d34"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 4): src/applications/drydock/query/DrydockAuthorizationQuery.php:79-88 | src/applications/drydock/query/DrydockAuthorizationQuery.php:101-110 | src/applications/drydock/query/DrydockRepositoryOperationQuery.php:80-89 | src/applications/drydock/query/DrydockRepositoryOperationQuery.php:106-115 \u2014 there are 4 copies across 2 file(s) \u2014 more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/drydock/query/DrydockAuthorizationQuery.php:79\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/query/DrydockAuthorizationQuery.php"},"region":{"startLine":79}}}],"partialFingerprints":{"codehealthFindingId/v1":"87e7f6478f9dae822cded2a2a96887f8a1f5150fff85391ccf576ea1dcb8e4a3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9\u201310 lines \u00D7 3): src/applications/auth/controller/config/PhabricatorAuthListController.php:90-99 | src/applications/auth/controller/message/PhabricatorAuthMessageListController.php:51-59 | src/applications/auth/controller/mfa/PhabricatorAuthFactorProviderListController.php:52-61 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/config/PhabricatorAuthListController.php"},"region":{"startLine":90}}}],"partialFingerprints":{"codehealthFindingId/v1":"e2555e33bfe511e2ed1436be3159d4790740a19dc6d0aeec495680420f388949"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 3): src/applications/badges/controller/PhabricatorBadgesViewController.php:91-100 | src/applications/meta/controller/PhabricatorApplicationDetailViewController.php:163-172 | src/applications/owners/controller/PhabricatorOwnersDetailController.php:249-258 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/badges/controller/PhabricatorBadgesViewController.php:91\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/owners/controller/PhabricatorOwnersDetailController.php:259\u0060 calls \u0060setWorkflow\u0060 and \u0060src/applications/badges/controller/PhabricatorBadgesViewController.php:101\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/controller/PhabricatorBadgesViewController.php"},"region":{"startLine":91}}}],"partialFingerprints":{"codehealthFindingId/v1":"437c8ae9e956fbbaf4703eeb14691e845ae2a9e1d6515c8e1e4a4f7a495819df"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 3): src/applications/conpherence/xaction/ConpherenceThreadTitleTransaction.php:34-43 | src/applications/paste/xaction/PhabricatorPasteTitleTransaction.php:40-49 | src/applications/phortune/xaction/PhortuneMerchantInvoiceEmailTransaction.php:39-48 \u2014 before extracting anything, compare \u0060src/applications/paste/xaction/PhabricatorPasteTitleTransaction.php\u0060 and \u0060src/applications/phortune/xaction/PhortuneMerchantInvoiceEmailTransaction.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/conpherence/xaction/ConpherenceThreadTitleTransaction.php:34\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/xaction/ConpherenceThreadTitleTransaction.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"7647af60c085197930a5e311173a9fc84c131b3fd9fc45a01719038b30fe7d4d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 3): src/applications/console/controller/DarkConsoleController.php:51-60 | src/applications/policy/controller/PhabricatorPolicyEditController.php:294-303 | src/applications/search/controller/PhabricatorApplicationSearchController.php:986-995 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/console/controller/DarkConsoleController.php"},"region":{"startLine":51}}}],"partialFingerprints":{"codehealthFindingId/v1":"f626c42fe18195d4e3a59e4780ccee79f7fd462f3fad90864e972dc2774a240b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9\u201310 lines \u00D7 3): src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php:346-355 | src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php:510-518 | src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php:530-538 \u2014 all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php:346\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php"},"region":{"startLine":346}}}],"partialFingerprints":{"codehealthFindingId/v1":"558746cc4ccd644eebc31f0f966553e6ac18ae3948d19fe7f629cd4ca10c87be"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 3): src/applications/drydock/controller/DrydockBlueprintViewController.php:168-177 | src/applications/drydock/controller/DrydockBlueprintViewController.php:234-243 | src/applications/drydock/controller/DrydockController.php:98-107 \u2014 there are 3 copies across 2 file(s) \u2014 more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/controller/DrydockBlueprintViewController.php"},"region":{"startLine":168}}}],"partialFingerprints":{"codehealthFindingId/v1":"ef7ff45d14dda6379a9a097d67af6dda208df1dd1938034529848a47973da45a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 3): src/applications/help/controller/PhabricatorHelpDocumentationController.php:11-20 | src/applications/meta/controller/PhabricatorApplicationDetailViewController.php:12-21 | src/applications/meta/controller/PhabricatorApplicationEmailCommandsController.php:11-20 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/help/controller/PhabricatorHelpDocumentationController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"f034100062bd1b783ce7ada93b1a8f7ee2184ae0d274ef09d24c68953996e28f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 3): src/applications/phortune/query/PhortuneCartQuery.php:98-107 | src/applications/phortune/query/PhortunePaymentMethodQuery.php:62-71 | src/applications/phortune/query/PhortuneSubscriptionQuery.php:75-84 \u2014 before extracting anything, compare \u0060src/applications/phortune/query/PhortunePaymentMethodQuery.php\u0060 and \u0060src/applications/phortune/query/PhortuneSubscriptionQuery.php\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 78 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phortune/query/PhortuneCartQuery.php:98\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/phortune/query/PhortunePaymentMethodQuery.php:72\u0060 calls \u0060didRejectResult\u0060 and \u0060src/applications/phortune/query/PhortuneCartQuery.php:108\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/query/PhortuneCartQuery.php"},"region":{"startLine":98}}}],"partialFingerprints":{"codehealthFindingId/v1":"48d8b4caafde62bdcf26c47506c4a2f04330a97083759b9787e72e9a26f9a8dc"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 3): src/applications/search/controller/PhabricatorApplicationSearchController.php:409-418 | src/applications/search/controller/PhabricatorApplicationSearchController.php:1045-1054 | src/infrastructure/export/engine/PhabricatorExportEngineBulkJobType.php:66-75 \u2014 there are 3 copies across 2 file(s) \u2014 more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/controller/PhabricatorApplicationSearchController.php"},"region":{"startLine":409}}}],"partialFingerprints":{"codehealthFindingId/v1":"95dc8232b912faae0aaa301a13091e776ff8f92681811f3ec2474ad0082db010"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): src/applications/conduit/query/PhabricatorConduitMethodQuery.php:129-139 | src/applications/project/query/PhabricatorProjectColumnQuery.php:99-108 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/conduit/query/PhabricatorConduitMethodQuery.php:129\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conduit/query/PhabricatorConduitMethodQuery.php"},"region":{"startLine":129}}}],"partialFingerprints":{"codehealthFindingId/v1":"08f3cd3cfd1438ca2773492f11122b1a63a7548c93aac01fbe5f08400f41438c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): src/applications/diffusion/herald/HeraldCommitAdapter.php:48-57 | src/applications/repository/worker/PhabricatorRepositoryCommitPublishWorker.php:33-44 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/diffusion/herald/HeraldCommitAdapter.php:48\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/herald/HeraldCommitAdapter.php"},"region":{"startLine":48}}}],"partialFingerprints":{"codehealthFindingId/v1":"a88658375b870d22d6c59d9dbfad0474ee32791d8eb96197a36338142773a6e9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): src/applications/diffusion/symbol/DiffusionPythonExternalSymbolsSource.php:19-28 | src/applications/diffusion/symbol/DiffusionPythonExternalSymbolsSource.php:29-38 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/diffusion/symbol/DiffusionPythonExternalSymbolsSource.php:19\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/symbol/DiffusionPythonExternalSymbolsSource.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"0e542276e4a2b5e9a5dc61e538f6f9b7b8d262945e9b82766911d50ae0858d9e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9\u201310 lines \u00D7 2): src/applications/drydock/controller/DrydockAuthorizationViewController.php:33-42 | src/applications/drydock/controller/DrydockRepositoryOperationViewController.php:34-42 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/drydock/controller/DrydockAuthorizationViewController.php:33\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/controller/DrydockAuthorizationViewController.php"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"5358d314b806a79ebc6f40a39682c4489ab7bbfd95653866b0a72b02da9185df"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): src/applications/files/query/PhabricatorFileChunkQuery.php:55-64 | src/infrastructure/diff/query/PhabricatorDiffInlineCommentQuery.php:158-167 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/files/query/PhabricatorFileChunkQuery.php:55\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/query/PhabricatorFileChunkQuery.php"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"7c23f4b1bf0e7c8db3877eee6136560792d3f498976538e5e538d6f5dfea8fd8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): src/applications/macro/query/PhabricatorMacroQuery.php:211-220 | src/applications/paste/query/PhabricatorPasteQuery.php:198-207 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/macro/query/PhabricatorMacroQuery.php:211\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/macro/query/PhabricatorMacroQuery.php"},"region":{"startLine":211}}}],"partialFingerprints":{"codehealthFindingId/v1":"4f0e6086d4b6807415eb45dbd5c14008ca75dd412d6a98de9de4e342490a30ca"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): src/applications/maniphest/controller/ManiphestTaskGraphController.php:11-20 | src/applications/maniphest/controller/ManiphestTaskSubtaskController.php:7-16 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/controller/ManiphestTaskGraphController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"87c04debb97d2c0710fcee1d896b4c5ad01f6a1704b7acd0b5c6c1d771f4c8ac"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): src/applications/packages/typeahead/PhabricatorPackagesPackageDatasource.php:23-32 | src/applications/packages/typeahead/PhabricatorPackagesPublisherDatasource.php:23-32 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/packages/typeahead/PhabricatorPackagesPackageDatasource.php"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"86856a9bf735cb23ab0f81d7e8f17b4fd965f95807f0416a177b886b5024db1f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): src/applications/phriction/controller/PhrictionDocumentController.php:72-81 | src/applications/phriction/controller/PhrictionEditController.php:29-38 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phriction/controller/PhrictionDocumentController.php:72\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/controller/PhrictionDocumentController.php"},"region":{"startLine":72}}}],"partialFingerprints":{"codehealthFindingId/v1":"9a4788c91a52874f24da51ed6e7f9e1986f7bad3bac9e1f4f0086a54f622308d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): src/infrastructure/edges/editor/PhabricatorEdgeEditor.php:255-264 | src/infrastructure/edges/editor/PhabricatorEdgeEditor.php:299-308 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/infrastructure/edges/editor/PhabricatorEdgeEditor.php:255\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/edges/editor/PhabricatorEdgeEditor.php"},"region":{"startLine":255}}}],"partialFingerprints":{"codehealthFindingId/v1":"d32785b74c953e781b1242b63b55275364c1e2ebe4c909b4f2a300f49b752499"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8\u20139 lines \u00D7 17): src/applications/badges/query/PhabricatorBadgesSearchEngine.php:142-149 | src/applications/countdown/query/PhabricatorCountdownSearchEngine.php:151-158 | src/applications/dashboard/controller/panel/PhabricatorDashboardPanelListController.php:56-63 | src/applications/differential/query/DifferentialRevisionSearchEngine.php:255-262 | src/applications/files/query/PhabricatorFileSearchEngine.php:200-207 | src/applications/herald/query/HeraldRuleSearchEngine.php:157-164 | src/applications/legalpad/query/LegalpadDocumentSearchEngine.php:180-187 | src/applications/macro/query/PhabricatorMacroSearchEngine.php:197-204 | src/applications/owners/query/PhabricatorOwnersPackageSearchEngine.php:163-171 | src/applications/passphrase/query/PassphraseCredentialSearchEngine.php:119-126 | src/applications/pholio/query/PholioMockSearchEngine.php:138-145 | src/applications/phurl/query/PhabricatorPhurlURLSearchEngine.php:134-141 | src/applications/ponder/query/PonderQuestionSearchEngine.php:188-195 | src/applications/project/query/PhabricatorProjectSearchEngine.php:344-351 | src/applications/repository/query/PhabricatorRepositorySearchEngine.php:273-280 | src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php:171-178 | src/applications/spaces/query/PhabricatorSpacesNamespaceSearchEngine.php:106-113 \u2014 before extracting anything, compare \u0060src/applications/dashboard/controller/panel/PhabricatorDashboardPanelListController.php\u0060 and \u0060src/applications/files/query/PhabricatorFileSearchEngine.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 30 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/badges/query/PhabricatorBadgesSearchEngine.php:142\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/query/PhabricatorBadgesSearchEngine.php"},"region":{"startLine":142}}}],"partialFingerprints":{"codehealthFindingId/v1":"d33bfbbdac611d41ab7d228dfdad805bd15ff1cb04d079c9621815bb2d81f7b6"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8\u20139 lines \u00D7 7): src/applications/harbormaster/query/HarbormasterBuildMessageQuery.php:30-37 | src/applications/harbormaster/query/HarbormasterBuildQuery.php:62-70 | src/applications/harbormaster/query/HarbormasterBuildQuery.php:87-95 | src/applications/harbormaster/query/HarbormasterBuildStepQuery.php:59-67 | src/applications/harbormaster/query/HarbormasterBuildTargetQuery.php:183-191 | src/applications/harbormaster/query/HarbormasterBuildableQuery.php:69-77 | src/applications/harbormaster/query/HarbormasterBuildableQuery.php:93-101 \u2014 before extracting anything, compare \u0060src/applications/harbormaster/query/HarbormasterBuildQuery.php\u0060 and \u0060src/applications/harbormaster/query/HarbormasterBuildStepQuery.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 37 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/harbormaster/query/HarbormasterBuildMessageQuery.php:30\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/harbormaster/query/HarbormasterBuildMessageQuery.php:37\u0060 calls \u0060mpull\u0060, \u0060array\u0060 and \u0060src/applications/harbormaster/query/HarbormasterBuildQuery.php:95\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/query/HarbormasterBuildMessageQuery.php"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"31194b06a27151b81472823d8bce459ca33f16b023a35489da308e2af43a467d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 6): src/applications/auth/xaction/PhabricatorAuthFactorProviderNameTransaction.php:40-49 | src/applications/conpherence/xaction/ConpherenceThreadTopicTransaction.php:53-61 | src/applications/phame/xaction/PhameBlogParentSiteTransaction.php:51-59 | src/applications/phame/xaction/PhameBlogSubtitleTransaction.php:47-55 | src/applications/phame/xaction/PhamePostSubtitleTransaction.php:47-55 | src/applications/project/xaction/trigger/PhabricatorProjectTriggerNameTransaction.php:40-49 \u2014 before extracting anything, compare \u0060src/applications/auth/xaction/PhabricatorAuthFactorProviderNameTransaction.php\u0060 and \u0060src/applications/project/xaction/trigger/PhabricatorProjectTriggerNameTransaction.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 33 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/auth/xaction/PhabricatorAuthFactorProviderNameTransaction.php:40\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/xaction/PhabricatorAuthFactorProviderNameTransaction.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"d156d729a95a558b318e39834dee095d2b41183f31e6c51b120b18a95bd32b30"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 5): src/applications/badges/controller/PhabricatorBadgesCommentController.php:52-61 | src/applications/pholio/controller/PholioMockCommentController.php:70-78 | src/applications/ponder/controller/PonderAnswerCommentController.php:51-60 | src/applications/ponder/controller/PonderQuestionCommentController.php:47-56 | src/applications/slowvote/controller/PhabricatorSlowvoteCommentController.php:52-61 \u2014 before extracting anything, compare \u0060src/applications/badges/controller/PhabricatorBadgesCommentController.php\u0060 and \u0060src/applications/slowvote/controller/PhabricatorSlowvoteCommentController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 44 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/controller/PhabricatorBadgesCommentController.php"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"29c58e4bbf8ef6d050c838b68c1f4deb90a77a1e955a2920effe4c6186abd45d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 4): src/applications/config/controller/services/PhabricatorConfigClusterDatabasesController.php:9-17 | src/applications/config/controller/services/PhabricatorConfigClusterNotificationsController.php:7-15 | src/applications/config/controller/services/PhabricatorConfigClusterRepositoriesController.php:7-16 | src/applications/config/controller/services/PhabricatorConfigClusterSearchController.php:7-16 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 4 call sites, so a change lands once. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/config/controller/services/PhabricatorConfigClusterDatabasesController.php:7\u0060 calls \u0060newNavigation\u0060 and \u0060src/applications/config/controller/services/PhabricatorConfigClusterNotificationsController.php:6\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/services/PhabricatorConfigClusterDatabasesController.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"81cebfb7a551fbdf2ee1e0ddbcd7035b9fbbfb1d7a7e52a005adade77a316c4c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 4): src/applications/console/controller/DarkConsoleController.php:53-61 | src/applications/policy/controller/PhabricatorPolicyEditController.php:296-304 | src/applications/search/controller/PhabricatorApplicationSearchController.php:988-996 | src/applications/settings/panel/PhabricatorSettingsPanel.php:294-302 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/console/controller/DarkConsoleController.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"6bf310364ec41102465fb9c4c18994eb81852c12d17d1ffcaaabbb0bd8ef0011"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8\u20139 lines \u00D7 4): src/applications/phortune/controller/account/PhortuneAccountDetailsController.php:84-91 | src/applications/phortune/controller/account/PhortuneAccountManagersController.php:68-76 | src/applications/phortune/controller/merchant/PhortuneMerchantDetailsController.php:131-138 | src/applications/phortune/controller/merchant/PhortuneMerchantManagersController.php:70-78 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 4 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phortune/controller/account/PhortuneAccountDetailsController.php:84\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/phortune/controller/account/PhortuneAccountDetailsController.php:81\u0060 calls \u0060id\u0060, \u0060PHUIObjectItemListView\u0060, \u0060setSimple\u0060 and \u0060src/applications/phortune/controller/account/PhortuneAccountManagersController.php:66\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountDetailsController.php"},"region":{"startLine":84}}}],"partialFingerprints":{"codehealthFindingId/v1":"c309159cd5cfb59e63219ef016c6a34d2c8622f9b59b835128210abbb74b7d63"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 3): src/applications/almanac/xaction/AlmanacDeviceNameTransaction.php:52-60 | src/applications/almanac/xaction/AlmanacNetworkNameTransaction.php:61-69 | src/applications/almanac/xaction/AlmanacServiceNameTransaction.php:61-69 \u2014 before extracting anything, compare \u0060src/applications/almanac/xaction/AlmanacDeviceNameTransaction.php\u0060 and \u0060src/applications/almanac/xaction/AlmanacServiceNameTransaction.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 58 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/xaction/AlmanacDeviceNameTransaction.php"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"af3c7f28fcd3be16cbeb1542fcdef7267969bc36b02e6117b7afde1d2a4d86f2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 3): src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php:254-262 | src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php:274-282 | src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php:294-302 \u2014 all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php"},"region":{"startLine":254}}}],"partialFingerprints":{"codehealthFindingId/v1":"53cac1a44c5e586eaba79ec7f3ce45f0ec5d07fc5e325fd6947baf57b293eecb"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 3): src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php:110-118 | src/applications/phame/controller/blog/PhameBlogManageController.php:64-72 | src/applications/phame/controller/blog/PhameBlogProfilePictureController.php:211-219 \u2014 before extracting anything, compare \u0060src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php\u0060 and \u0060src/applications/phame/controller/blog/PhameBlogProfilePictureController.php\u0060 as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 135 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php"},"region":{"startLine":110}}}],"partialFingerprints":{"codehealthFindingId/v1":"6443a6bad36a01650658e5cac67cac6403307f292a49a623032614c76a530cb5"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 3): src/applications/phortune/query/PhortuneCartQuery.php:79-87 | src/applications/phortune/query/PhortunePaymentMethodQuery.php:42-50 | src/applications/phortune/query/PhortuneSubscriptionQuery.php:55-63 \u2014 before extracting anything, compare \u0060src/applications/phortune/query/PhortunePaymentMethodQuery.php\u0060 and \u0060src/applications/phortune/query/PhortuneSubscriptionQuery.php\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 78 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phortune/query/PhortuneCartQuery.php:79\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/phortune/query/PhortunePaymentMethodQuery.php:52\u0060 calls \u0060didRejectResult\u0060 and \u0060src/applications/phortune/query/PhortuneCartQuery.php:89\u0060 does not \u2014 after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/query/PhortuneCartQuery.php"},"region":{"startLine":79}}}],"partialFingerprints":{"codehealthFindingId/v1":"7dc1bc53d073fa27bab71170fa3d5eeff5fa12f73b07b616764da3a58b1286e8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5\u20139 lines \u00D7 4): src/applications/transactions/storage/PhabricatorApplicationTransaction.php:1117-1125 | src/applications/transactions/storage/PhabricatorApplicationTransaction.php:1126-1134 | src/applications/transactions/storage/PhabricatorApplicationTransaction.php:1135-1143 | src/applications/transactions/storage/PhabricatorApplicationTransaction.php:1144-1148 \u2014 all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/transactions/storage/PhabricatorApplicationTransaction.php:1117\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/transactions/storage/PhabricatorApplicationTransaction.php:1115\u0060 calls \u0060phutil_count\u0060, \u0060renderHandleList\u0060 and \u0060src/applications/transactions/storage/PhabricatorApplicationTransaction.php:1125\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorApplicationTransaction.php"},"region":{"startLine":1117}}}],"partialFingerprints":{"codehealthFindingId/v1":"89cc58a2d457fa47df7c0e9ccce8c6a0bc16a0669825f377b767023a38769c06"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/applications/audit/management/PhabricatorAuditManagementDeleteWorkflow.php:274-282 | src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php:433-441 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/audit/management/PhabricatorAuditManagementDeleteWorkflow.php:274\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/management/PhabricatorAuditManagementDeleteWorkflow.php"},"region":{"startLine":274}}}],"partialFingerprints":{"codehealthFindingId/v1":"178daa0f79d26cf5107ff30bcb31a7d8358a959929f927eca4801042e4cfcc4f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8\u20139 lines \u00D7 2): src/applications/auth/controller/PhabricatorAuthRegisterController.php:327-334 | src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php:191-199 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/auth/controller/PhabricatorAuthRegisterController.php:327\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthRegisterController.php"},"region":{"startLine":327}}}],"partialFingerprints":{"codehealthFindingId/v1":"7f6af36ed9faf1bd874d4f266e94903f89bf6ac2b39011a07dcc45a9e0607bb2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/applications/auth/engine/PhabricatorAuthInviteEngine.php:84-92 | src/applications/auth/engine/PhabricatorAuthInviteEngine.php:94-102 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/engine/PhabricatorAuthInviteEngine.php"},"region":{"startLine":84}}}],"partialFingerprints":{"codehealthFindingId/v1":"5b2afb24e95ad352cad599fd54573b04a7dbe531e4e71ca9593cce42493d45d0"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/applications/auth/factor/PhabricatorSMSAuthFactor.php:262-270 | src/applications/auth/factor/PhabricatorTOTPAuthFactor.php:188-196 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/auth/factor/PhabricatorSMSAuthFactor.php:262\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/auth/factor/PhabricatorTOTPAuthFactor.php:197\u0060 calls \u0060setAutofocus\u0060 and \u0060src/applications/auth/factor/PhabricatorSMSAuthFactor.php:271\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/factor/PhabricatorSMSAuthFactor.php"},"region":{"startLine":262}}}],"partialFingerprints":{"codehealthFindingId/v1":"0e9cd487af8d43309c0b8e682036d925f767b54b6e1259b6f2b911fcedd9487e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/applications/conduit/controller/PhabricatorConduitAPIController.php:566-574 | src/applications/files/controller/PhabricatorFileTransformListController.php:118-126 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conduit/controller/PhabricatorConduitAPIController.php"},"region":{"startLine":566}}}],"partialFingerprints":{"codehealthFindingId/v1":"9d734f6a1c5287171745409c9bebb8b7c9145796aaebe141ce8424d00330c1ff"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7\u20139 lines \u00D7 2): src/applications/diffusion/controller/DiffusionLintController.php:231-237 | src/applications/diffusion/controller/DiffusionLintController.php:508-516 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/diffusion/controller/DiffusionLintController.php:508\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionLintController.php"},"region":{"startLine":231}}}],"partialFingerprints":{"codehealthFindingId/v1":"17e601dc2be5261dff03d8d3f7742d78e3510fc387a4dfd3dc99444a791bb951"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/applications/drydock/management/DrydockManagementLeaseWorkflow.php:219-227 | src/applications/drydock/view/DrydockLogListView.php:92-100 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/drydock/management/DrydockManagementLeaseWorkflow.php:219\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/management/DrydockManagementLeaseWorkflow.php"},"region":{"startLine":219}}}],"partialFingerprints":{"codehealthFindingId/v1":"b350416f43761924f3916515711ef4e9d8914f6c73c27e93459d5e32775b3a02"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/applications/fund/phortune/FundBackerProduct.php:87-95 | src/applications/fund/phortune/FundBackerProduct.php:125-133 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fund/phortune/FundBackerProduct.php"},"region":{"startLine":87}}}],"partialFingerprints":{"codehealthFindingId/v1":"aed79307002bd2b001ec5c692a416e73697ffcca8f6ac93372ca53d1819065d8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/applications/maniphest/query/ManiphestTaskSearchEngine.php:405-413 | src/applications/repository/query/PhabricatorRepositorySearchEngine.php:252-260 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/maniphest/query/ManiphestTaskSearchEngine.php:405\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/query/ManiphestTaskSearchEngine.php"},"region":{"startLine":405}}}],"partialFingerprints":{"codehealthFindingId/v1":"90c3583963cf00c964e6214624af589f788c37e33d9681d7fbee58ec975a8696"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/applications/passphrase/conduit/PassphraseQueryConduitAPIMethod.php:34-42 | src/applications/paste/conduit/PasteQueryConduitAPIMethod.php:42-50 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/passphrase/conduit/PassphraseQueryConduitAPIMethod.php:34\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/passphrase/conduit/PassphraseQueryConduitAPIMethod.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"8e9f7e302356b1ea7f82f122544215b8a9d6636925058c332052355e424171c8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/applications/slowvote/view/SlowvoteEmbedView.php:197-205 | src/applications/slowvote/view/SlowvoteEmbedView.php:292-300 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/slowvote/view/SlowvoteEmbedView.php"},"region":{"startLine":197}}}],"partialFingerprints":{"codehealthFindingId/v1":"4ac85feb869773b874e824c08728e2d3949faa21e2274d417286ee87caee468b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php:2627-2635 | src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php:2876-2884 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php:2627\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php"},"region":{"startLine":2627}}}],"partialFingerprints":{"codehealthFindingId/v1":"c54b48325051859bce3d8bccb93c09b20d852d086c638e10de787415227e31df"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 21): src/applications/badges/xaction/PhabricatorBadgesBadgeNameTransaction.php:37-45 | src/applications/conpherence/xaction/ConpherenceThreadTitleTransaction.php:57-65 | src/applications/countdown/xaction/PhabricatorCountdownTitleTransaction.php:36-43 | src/applications/differential/xaction/DifferentialRevisionTitleTransaction.php:38-46 | src/applications/drydock/xaction/DrydockBlueprintNameTransaction.php:41-50 | src/applications/files/xaction/PhabricatorFileNameTransaction.php:37-44 | src/applications/fund/xaction/FundInitiativeNameTransaction.php:52-60 | src/applications/herald/xaction/HeraldRuleNameTransaction.php:28-37 | src/applications/legalpad/xaction/LegalpadDocumentTitleTransaction.php:57-65 | src/applications/nuance/xaction/NuanceQueueNameTransaction.php:28-36 | src/applications/nuance/xaction/NuanceSourceNameTransaction.php:28-36 | src/applications/passphrase/xaction/PassphraseCredentialNameTransaction.php:52-61 | src/applications/phame/xaction/PhameBlogNameTransaction.php:37-45 | src/applications/phame/xaction/PhamePostTitleTransaction.php:37-45 | src/applications/pholio/xaction/PholioMockNameTransaction.php:71-78 | src/applications/phortune/xaction/PhortuneAccountNameTransaction.php:37-45 | src/applications/phortune/xaction/PhortuneMerchantNameTransaction.php:37-45 | src/applications/phurl/xaction/PhabricatorPhurlURLAliasTransaction.php:37-47 | src/applications/ponder/xaction/PonderQuestionTitleTransaction.php:37-45 | src/applications/project/xaction/PhabricatorProjectNameTransaction.php:69-76 | src/applications/spaces/xaction/PhabricatorSpacesNamespaceNameTransaction.php:44-52 \u2014 before extracting anything, compare \u0060src/applications/badges/xaction/PhabricatorBadgesBadgeNameTransaction.php\u0060 and \u0060src/applications/conpherence/xaction/ConpherenceThreadTitleTransaction.php\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 61 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/badges/xaction/PhabricatorBadgesBadgeNameTransaction.php:37\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/xaction/PhabricatorBadgesBadgeNameTransaction.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"341a3693354e2d386f4ac22f5646c37d3a5fd22506f32fb19aa04dd6501e388a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 4): src/applications/phortune/query/PhortuneCartQuery.php:81-88 | src/applications/phortune/query/PhortuneChargeQuery.php:63-70 | src/applications/phortune/query/PhortunePaymentMethodQuery.php:44-51 | src/applications/phortune/query/PhortuneSubscriptionQuery.php:57-64 \u2014 before extracting anything, compare \u0060src/applications/phortune/query/PhortuneCartQuery.php\u0060 and \u0060src/applications/phortune/query/PhortuneChargeQuery.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 36 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phortune/query/PhortuneCartQuery.php:81\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/phortune/query/PhortuneChargeQuery.php:62\u0060 calls \u0060setParentQuery\u0060 and \u0060src/applications/phortune/query/PhortuneCartQuery.php:80\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/query/PhortuneCartQuery.php"},"region":{"startLine":81}}}],"partialFingerprints":{"codehealthFindingId/v1":"fcc176b8799db5ebbb433dd24f40ed3604b9b95cd96a657e8b3fefb92852dbca"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 4): src/applications/phriction/conduit/PhrictionCreateConduitAPIMethod.php:27-34 | src/applications/phriction/conduit/PhrictionEditConduitAPIMethod.php:27-34 | src/applications/phriction/conduit/PhrictionHistoryConduitAPIMethod.php:40-47 | src/applications/phriction/conduit/PhrictionInfoConduitAPIMethod.php:40-47 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 4 call sites, so a change lands once. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/phriction/conduit/PhrictionEditConduitAPIMethod.php:35\u0060 calls \u0060needContent\u0060 and \u0060src/applications/phriction/conduit/PhrictionCreateConduitAPIMethod.php:35\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/conduit/PhrictionCreateConduitAPIMethod.php"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"796b13732ad657126892d4acb569bb40138e8b6912d3638013c61b6a6974385a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 3): src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php:166-173 | src/applications/diffusion/xaction/DiffusionCommitAuditorsTransaction.php:107-114 | src/applications/diffusion/xaction/DiffusionCommitAuditorsTransaction.php:141-148 \u2014 there are 3 copies across 2 file(s) \u2014 more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php:162\u0060 calls \u0060renderReviewerEditTitle\u0060 and \u0060src/applications/diffusion/xaction/DiffusionCommitAuditorsTransaction.php:140\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php"},"region":{"startLine":166}}}],"partialFingerprints":{"codehealthFindingId/v1":"6f01cc3a937dfcd131d1a8b24949e35e13e8d6bafc7bd40b24a79f0620d4a2e2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/applications/almanac/query/AlmanacBindingQuery.php:69-76 | src/applications/almanac/query/AlmanacInterfaceQuery.php:54-61 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/almanac/query/AlmanacBindingQuery.php:69\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/query/AlmanacBindingQuery.php"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"82390accf101a8fb2903848cde4620e195f58ed433b8731e3cfd75862891c3cf"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/applications/calendar/query/PhabricatorCalendarExportSearchEngine.php:64-71 | src/applications/calendar/query/PhabricatorCalendarImportSearchEngine.php:61-68 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/calendar/query/PhabricatorCalendarExportSearchEngine.php:64\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/query/PhabricatorCalendarExportSearchEngine.php"},"region":{"startLine":64}}}],"partialFingerprints":{"codehealthFindingId/v1":"b9c0fecbbac76cc864d4a8134e9ca241b222893632acc937a1a944a5424a6804"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/applications/conpherence/controller/ConpherenceRoomPreferencesController.php:67-74 | src/applications/conpherence/controller/ConpherenceUpdateController.php:414-422 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/conpherence/controller/ConpherenceRoomPreferencesController.php:64\u0060 calls \u0060idx\u0060 and \u0060src/applications/conpherence/controller/ConpherenceUpdateController.php:413\u0060 does not \u2014 after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceRoomPreferencesController.php"},"region":{"startLine":67}}}],"partialFingerprints":{"codehealthFindingId/v1":"75b6951bb9614dd637119746a3dab28dbe3d5a42b12c331f7359a601653262fa"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): src/applications/differential/render/DifferentialChangesetRenderer.php:502-511 | src/applications/differential/render/DifferentialChangesetRenderer.php:513-522 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetRenderer.php"},"region":{"startLine":502}}}],"partialFingerprints":{"codehealthFindingId/v1":"e38193939261bca72f8bd2029fedbaf6ad4a931e516d039010bf1ce6c079a54c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7\u20138 lines \u00D7 2): src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php:44-51 | src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php:204-210 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"86b89f83950575cb8e1cd792735e2531764eafbabe3083483e724c61e9ebb836"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php:66-73 | src/applications/drydock/controller/DrydockBlueprintViewController.php:23-31 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php"},"region":{"startLine":66}}}],"partialFingerprints":{"codehealthFindingId/v1":"32957f98a8ad8d997e4b88ca0a1c6c05e664bbae7ad15033fd18071851451e1a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/applications/repository/storage/PhabricatorRepositoryURITransaction.php:56-63 | src/applications/repository/storage/PhabricatorRepositoryURITransaction.php:66-73 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepositoryURITransaction.php"},"region":{"startLine":56}}}],"partialFingerprints":{"codehealthFindingId/v1":"7eb28252a0e94a010e7c90effcfe510d4419106bae6499e07fc41d25de85a6a0"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 4): src/applications/phortune/query/PhortuneAccountEmailQuery.php:43-49 | src/applications/phortune/query/PhortuneChargeQuery.php:61-67 | src/applications/phortune/query/PhortunePurchaseQuery.php:42-48 | src/applications/phortune/query/PhortunePurchaseQuery.php:58-64 \u2014 there are 4 copies across 3 file(s) \u2014 more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phortune/query/PhortuneAccountEmailQuery.php:43\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/phortune/query/PhortuneAccountEmailQuery.php:53\u0060 calls \u0060didRejectResult\u0060 and \u0060src/applications/phortune/query/PhortuneChargeQuery.php:70\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/query/PhortuneAccountEmailQuery.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"1e80c4cdacd5f282096da666b3cd4ebceacf9807c1c51fadff7c7187feb740e1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/applications/config/controller/services/PhabricatorConfigDatabaseStatusController.php:218-225 | src/applications/config/controller/services/PhabricatorConfigDatabaseStatusController.php:323-329 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/config/controller/services/PhabricatorConfigDatabaseStatusController.php:323\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/services/PhabricatorConfigDatabaseStatusController.php"},"region":{"startLine":218}}}],"partialFingerprints":{"codehealthFindingId/v1":"c0e6597f149863f40b4ba911e8234d26bf140e406984ef9c812d9a477b506c2e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/applications/differential/parser/DifferentialHunkParser.php:642-650 | src/applications/differential/parser/DifferentialHunkParser.php:651-659 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialHunkParser.php"},"region":{"startLine":642}}}],"partialFingerprints":{"codehealthFindingId/v1":"c73c02fad3cbb080829a85a489749ea4b301a31fc4f26ac68e72c845a3d30455"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php:268-274 | src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php:364-370 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php"},"region":{"startLine":268}}}],"partialFingerprints":{"codehealthFindingId/v1":"ddbf032e970e1fd94060dde567e87e1b37eb81f46556eaae7a71e951dd7b46c4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php:265-271 | src/applications/diffusion/management/DiffusionRepositoryURIsManagementPanel.php:75-81 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php"},"region":{"startLine":265}}}],"partialFingerprints":{"codehealthFindingId/v1":"8285a34439fde95655ddf74c5dd2f789a8d87a722e421be94c66b12d8fe6cabf"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php:285-291 | src/applications/diffusion/management/DiffusionRepositoryURIsManagementPanel.php:87-95 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/diffusion/management/DiffusionRepositoryURIsManagementPanel.php:87\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php"},"region":{"startLine":285}}}],"partialFingerprints":{"codehealthFindingId/v1":"e2b1516aa5907b8e16b484d4c1364d763407b5bd48181542fa7daa443bfa4b6e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php:615-621 | src/view/phui/PHUITimelineView.php:284-290 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php:615\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php"},"region":{"startLine":615}}}],"partialFingerprints":{"codehealthFindingId/v1":"1ff4dbc2e60567dd906e2b0c210985ebb3515ccc83f29161fd9eac24fa211770"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/infrastructure/env/PhabricatorEnv.php:286-292 | src/infrastructure/env/PhabricatorEnv.php:296-302 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/env/PhabricatorEnv.php"},"region":{"startLine":286}}}],"partialFingerprints":{"codehealthFindingId/v1":"ba0f69e2ea13635c51d14495acd257b28f0e3059d0c658d0405c35868f288871"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 3): src/applications/calendar/parser/data/PhutilCalendarAbsoluteDateTime.php:69-74 | src/applications/calendar/parser/data/PhutilCalendarRelativeDateTime.php:63-68 | src/view/form/control/AphrontFormDateControlValue.php:244-249 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/data/PhutilCalendarAbsoluteDateTime.php"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"93bd6fccefdd1658d6ca48dcc98e3216db6c9e84a1075c07a84158fcec0a4515"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): src/applications/config/controller/services/PhabricatorConfigDatabaseStatusController.php:678-683 | src/applications/config/controller/services/PhabricatorConfigDatabaseStatusController.php:773-778 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/config/controller/services/PhabricatorConfigDatabaseStatusController.php:678\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/services/PhabricatorConfigDatabaseStatusController.php"},"region":{"startLine":678}}}],"partialFingerprints":{"codehealthFindingId/v1":"32601b4f2ad27975b9ee58f0194c263a256646e85e283da9ebcc95b0d988b5f0"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): src/applications/maniphest/query/ManiphestTaskSearchEngine.php:447-452 | src/applications/paste/query/PhabricatorPasteSearchEngine.php:213-218 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/maniphest/query/ManiphestTaskSearchEngine.php:447\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/query/ManiphestTaskSearchEngine.php"},"region":{"startLine":447}}}],"partialFingerprints":{"codehealthFindingId/v1":"fe367e61e961eb1d3d91f5483d823320998c95916afd575f3b0e77a8d40a127d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (3\u20135 lines \u00D7 5): src/applications/metamta/management/PhabricatorMailManagementListInboundWorkflow.php:45-49 | src/applications/metamta/management/PhabricatorMailManagementListOutboundWorkflow.php:36-40 | src/infrastructure/storage/management/workflow/PhabricatorStorageManagementStatusWorkflow.php:33-37 | src/infrastructure/storage/management/workflow/PhabricatorStorageManagementStatusWorkflow.php:39-41 | src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php:215-217 \u2014 there are 5 copies across 4 file(s) \u2014 more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 5 sites; resolving a subset leaves the remainder to drift apart. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/infrastructure/storage/management/workflow/PhabricatorStorageManagementStatusWorkflow.php:31\u0060 calls \u0060getRef\u0060 and \u0060src/applications/metamta/management/PhabricatorMailManagementListOutboundWorkflow.php:34\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/management/PhabricatorMailManagementListInboundWorkflow.php"},"region":{"startLine":45}}}],"partialFingerprints":{"codehealthFindingId/v1":"22614cffd95353a759b2351ee5fb0b05ce15ca3cb3d52be14f6534bff830d7ba"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php:80-85 | src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php:122-127 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php"},"region":{"startLine":80}}}],"partialFingerprints":{"codehealthFindingId/v1":"69a22ca6d693dc2552f85f4cab333fac7d5cee4d8be6d9d08ab0acc2c64d7f9c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/aphront/response/AphrontPlainTextResponse.php:8-21 | src/applications/diffusion/response/DiffusionMercurialResponse.php:8-28 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/aphront/response/AphrontPlainTextResponse.php:8\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/response/AphrontPlainTextResponse.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"d6d8b5dbccb78d682beefdeb145814cc3babfd8d6af0f752736e29126fb2edec"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (22 lines \u00D7 6): src/applications/almanac/editor/AlmanacDeviceEditor.php:7-28 | src/applications/almanac/editor/AlmanacNetworkEditor.php:7-28 | src/applications/dashboard/editor/PhabricatorDashboardPortalEditor.php:7-32 | src/applications/drydock/editor/DrydockBlueprintEditor.php:7-32 | src/applications/harbormaster/editor/HarbormasterBuildPlanEditor.php:7-30 | src/applications/passphrase/editor/PassphraseCredentialTransactionEditor.php:7-32 \u2014 before extracting anything, compare \u0060src/applications/dashboard/editor/PhabricatorDashboardPortalEditor.php\u0060 and \u0060src/applications/drydock/editor/DrydockBlueprintEditor.php\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 152 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/almanac/editor/AlmanacDeviceEditor.php:7\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/editor/AlmanacDeviceEditor.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"ce2e962207b6d2b8934496b1012af6e21578f27085abc6dd5684120c9dd7cc16"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 2): src/applications/almanac/xaction/AlmanacBindingDisableTransaction.php:9-25 | src/applications/herald/xaction/HeraldRuleDisableTransaction.php:9-29 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/almanac/xaction/AlmanacBindingDisableTransaction.php:9\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/xaction/AlmanacBindingDisableTransaction.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"a50d3ea6f475232594a6e889e4148f22a62af2a401f60531da1f6266724fed70"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 3): src/applications/almanac/xaction/AlmanacBindingSetPropertyTransaction.php:9-21 | src/applications/almanac/xaction/AlmanacDeviceSetPropertyTransaction.php:9-21 | src/applications/almanac/xaction/AlmanacServiceSetPropertyTransaction.php:9-21 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/almanac/xaction/AlmanacBindingSetPropertyTransaction.php:9\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/xaction/AlmanacBindingSetPropertyTransaction.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"776bb6fde32ff05e793a6dde9f976fa563cf1583d46d0a302dff9b77c8e4c8bf"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (45 lines \u00D7 9): src/applications/badges/xaction/PhabricatorBadgesBadgeDescriptionTransaction.php:9-53 | src/applications/calendar/xaction/PhabricatorCalendarEventDescriptionTransaction.php:9-53 | src/applications/countdown/xaction/PhabricatorCountdownDescriptionTransaction.php:9-53 | src/applications/maniphest/xaction/ManiphestTaskDescriptionTransaction.php:9-68 | src/applications/passphrase/xaction/PassphraseCredentialDescriptionTransaction.php:9-61 | src/applications/phame/xaction/PhameBlogDescriptionTransaction.php:9-57 | src/applications/phortune/xaction/PhortuneMerchantDescriptionTransaction.php:9-53 | src/applications/phurl/xaction/PhabricatorPhurlURLDescriptionTransaction.php:9-57 | src/applications/spaces/xaction/PhabricatorSpacesNamespaceDescriptionTransaction.php:9-53 \u2014 before extracting anything, compare \u0060src/applications/phame/xaction/PhameBlogDescriptionTransaction.php\u0060 and \u0060src/applications/phurl/xaction/PhabricatorPhurlURLDescriptionTransaction.php\u0060 as WHOLE FILES: 85% of the shorter file\u0027s lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it \u2014 treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/badges/xaction/PhabricatorBadgesBadgeDescriptionTransaction.php:9\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/xaction/PhabricatorBadgesBadgeDescriptionTransaction.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"2b6d7181f9182c8472e34a9808912afa63c9a48bbf47d021c5eeb0d70382af94"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 7): src/applications/auth/revoker/PhabricatorAuthRevoker.php:15-35 | src/applications/cache/purger/PhabricatorCachePurger.php:11-27 | src/applications/metamta/engine/PhabricatorMailEngineExtension.php:10-44 | src/applications/metamta/stamp/PhabricatorMailStamp.php:12-85 | src/applications/transactions/engineextension/PhabricatorEditorExtension.php:11-79 | src/infrastructure/export/engine/PhabricatorExportEngineExtension.php:8-28 | src/infrastructure/export/format/PhabricatorExportFormat.php:10-50 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 7 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 7 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/auth/revoker/PhabricatorAuthRevoker.php:15\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/revoker/PhabricatorAuthRevoker.php"},"region":{"startLine":15}}}],"partialFingerprints":{"codehealthFindingId/v1":"8409ffc210e46d972b03a2769eb7264110c9d4b09f0c10ec8d9002780e08f54a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (33 lines \u00D7 2): src/applications/calendar/xaction/PhabricatorCalendarEventNameTransaction.php:9-41 | src/applications/phurl/xaction/PhabricatorPhurlURLNameTransaction.php:9-41 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/calendar/xaction/PhabricatorCalendarEventNameTransaction.php:9\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/xaction/PhabricatorCalendarEventNameTransaction.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"5eb043d6656a420bae42cec7fb0efd6cc0da0b3ba642297dee5b30d8023be041"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 2): src/applications/calendar/xaction/PhabricatorCalendarExportDisableTransaction.php:9-25 | src/applications/calendar/xaction/PhabricatorCalendarImportDisableTransaction.php:9-25 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/calendar/xaction/PhabricatorCalendarExportDisableTransaction.php:9\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/xaction/PhabricatorCalendarExportDisableTransaction.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"b64b23aa462b09813e147393bc4cf3675e3fc3bd70cd851b2428c96b2828ee33"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (24 lines \u00D7 5): src/applications/calendar/xaction/PhabricatorCalendarEventNameTransaction.php:9-41 | src/applications/calendar/xaction/PhabricatorCalendarExportNameTransaction.php:9-32 | src/applications/harbormaster/xaction/plan/HarbormasterBuildPlanNameTransaction.php:9-43 | src/applications/phurl/xaction/PhabricatorPhurlURLNameTransaction.php:9-41 | src/applications/repository/xaction/PhabricatorRepositoryNameTransaction.php:9-32 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 5 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 5 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/calendar/xaction/PhabricatorCalendarEventNameTransaction.php:9\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/xaction/PhabricatorCalendarEventNameTransaction.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"eb87425fb5f3ea9d08d5eafa53d0f224892022e23c2d9422938c9a20dc2975c4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18 lines \u00D7 3): src/applications/conpherence/xaction/ConpherenceThreadPictureTransaction.php:9-26 | src/applications/phame/xaction/PhameBlogProfileImageTransaction.php:10-31 | src/applications/phortune/xaction/PhortuneMerchantPictureTransaction.php:9-30 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/conpherence/xaction/ConpherenceThreadPictureTransaction.php:9\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/xaction/ConpherenceThreadPictureTransaction.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"8def6bf6f4916ef02ad8addac775483bc15f8fe855ac999a8358c031b2863212"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19 lines \u00D7 2): src/applications/dashboard/editor/PhabricatorDashboardPanelTransactionEditor.php:7-25 | src/applications/dashboard/editor/PhabricatorDashboardTransactionEditor.php:7-25 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/dashboard/editor/PhabricatorDashboardPanelTransactionEditor.php:7\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/editor/PhabricatorDashboardPanelTransactionEditor.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"260c0cdc6a856aff36714139c6b0218594fe335556391b83ccafb5e0702590a3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (24 lines \u00D7 4): src/applications/dashboard/editor/PhabricatorDashboardPortalEditor.php:7-32 | src/applications/drydock/editor/DrydockBlueprintEditor.php:7-32 | src/applications/harbormaster/editor/HarbormasterBuildPlanEditor.php:7-30 | src/applications/passphrase/editor/PassphraseCredentialTransactionEditor.php:7-32 \u2014 before extracting anything, compare \u0060src/applications/dashboard/editor/PhabricatorDashboardPortalEditor.php\u0060 and \u0060src/applications/drydock/editor/DrydockBlueprintEditor.php\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 152 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/dashboard/editor/PhabricatorDashboardPortalEditor.php:7\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/editor/PhabricatorDashboardPortalEditor.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"185472a27123f137d1719796e363b9d25c03dc046057614b6b09743d16b9b026"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (20 lines \u00D7 2): src/applications/differential/herald/DifferentialDiffAuthorProjectsHeraldField.php:9-28 | src/applications/differential/herald/DifferentialRevisionAuthorProjectsHeraldField.php:9-28 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/differential/herald/DifferentialDiffAuthorProjectsHeraldField.php:9\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/herald/DifferentialDiffAuthorProjectsHeraldField.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"7ebc7c62631ea883617352dc63e4afc40dc5256e7b466fe9f73081481bf3290c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19 lines \u00D7 2): src/applications/differential/herald/DifferentialDiffRepositoryHeraldField.php:9-27 | src/applications/differential/herald/DifferentialRevisionRepositoryHeraldField.php:9-27 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/differential/herald/DifferentialDiffRepositoryHeraldField.php:9\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/herald/DifferentialDiffRepositoryHeraldField.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"367c02061d6e9b31c090dcc2f65864fffc1143c3e61ae971586b0838b5f923a3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (20 lines \u00D7 2): src/applications/differential/herald/DifferentialDiffRepositoryProjectsHeraldField.php:9-28 | src/applications/differential/herald/DifferentialRevisionRepositoryProjectsHeraldField.php:9-28 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/differential/herald/DifferentialDiffRepositoryProjectsHeraldField.php:9\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/herald/DifferentialDiffRepositoryProjectsHeraldField.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"7b64b52cf7adce962f8452721188e2d092943e546134f5d88d28a2832ea89898"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18 lines \u00D7 3): src/applications/differential/herald/DifferentialRevisionPackageHeraldField.php:9-26 | src/applications/diffusion/herald/DiffusionCommitPackageHeraldField.php:9-26 | src/applications/diffusion/herald/DiffusionPreCommitContentPackageHeraldField.php:9-26 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/differential/herald/DifferentialRevisionPackageHeraldField.php:9\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/herald/DifferentialRevisionPackageHeraldField.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"4d22a94efbcccdc656a3af08b651cb6b8d6a878a8b7c038f27e8988beaee3d7b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (23 lines \u00D7 3): src/applications/differential/herald/DifferentialRevisionPackageOwnerHeraldField.php:9-31 | src/applications/diffusion/herald/DiffusionCommitPackageOwnerHeraldField.php:9-32 | src/applications/diffusion/herald/DiffusionPreCommitContentPackageOwnerHeraldField.php:9-31 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/differential/herald/DifferentialRevisionPackageOwnerHeraldField.php:9\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/herald/DifferentialRevisionPackageOwnerHeraldField.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"de7bfe8be97751a4888a546f10b6cc342f790a165b2474217dbc9a2ddfa0fd68"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/diffusion/herald/DiffusionPreCommitContentPusherHeraldField.php:9-21 | src/applications/diffusion/herald/DiffusionPreCommitRefPusherHeraldField.php:9-21 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/diffusion/herald/DiffusionPreCommitContentPusherHeraldField.php:9\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/herald/DiffusionPreCommitContentPusherHeraldField.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"ba97040a9edefe23439eddd043f8e378de4c210cd4136784a9961d2aa27b0680"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): src/applications/diffusion/herald/DiffusionPreCommitContentPusherProjectsHeraldField.php:9-23 | src/applications/diffusion/herald/DiffusionPreCommitRefPusherProjectsHeraldField.php:9-23 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/diffusion/herald/DiffusionPreCommitContentPusherProjectsHeraldField.php:9\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/herald/DiffusionPreCommitContentPusherProjectsHeraldField.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"3b1988cd50566fe1cb41fc5bd3b014341216913504302f31f1deda9df328e93b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/diffusion/herald/DiffusionPreCommitContentRepositoryHeraldField.php:9-21 | src/applications/diffusion/herald/DiffusionPreCommitRefRepositoryHeraldField.php:9-21 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/diffusion/herald/DiffusionPreCommitContentRepositoryHeraldField.php:9\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/herald/DiffusionPreCommitContentRepositoryHeraldField.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"e04da4c7b37eaa8c4cac5447aa30b47d92e26eca70cca4a19ebc2f7a71d6c387"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 3): src/applications/diffusion/management/DiffusionRepositoryManagementPanelGroup.php:7-18 | src/applications/herald/action/HeraldActionGroup.php:6-14 | src/applications/herald/field/HeraldFieldGroup.php:6-14 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/diffusion/management/DiffusionRepositoryManagementPanelGroup.php:7\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/management/DiffusionRepositoryManagementPanelGroup.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"c46a07d122839a5cb07b3ead3c1dd4addc5ad8057d91c84e2fe36442f3714665"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (20 lines \u00D7 2): src/applications/diffusion/remarkup/DiffusionRepositoryByIDRemarkupRule.php:7-26 | src/applications/diffusion/remarkup/DiffusionRepositoryRemarkupRule.php:7-26 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/diffusion/remarkup/DiffusionRepositoryByIDRemarkupRule.php:7\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/remarkup/DiffusionRepositoryByIDRemarkupRule.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"3540c26803751a43eb1c1b84fa92a49506cd819d402dd4f3fbc53b634698d107"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/diffusion/request/DiffusionGitRequest.php:6-16 | src/applications/diffusion/request/DiffusionMercurialRequest.php:6-18 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/diffusion/request/DiffusionGitRequest.php:6\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/request/DiffusionGitRequest.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"4f305c152518155a723f061cdfbe05b0cbb4824f0a5f68aaea40a20e027737e9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 10): src/applications/dashboard/editor/PhabricatorDashboardPortalEditor.php:7-32 | src/applications/diviner/editor/DivinerLiveBookEditor.php:7-20 | src/applications/drydock/editor/DrydockBlueprintEditor.php:7-32 | src/applications/harbormaster/editor/HarbormasterBuildPlanEditor.php:7-30 | src/applications/herald/editor/HeraldWebhookEditor.php:7-28 | src/applications/meta/editor/PhabricatorApplicationEditor.php:7-43 | src/applications/nuance/editor/NuanceItemEditor.php:7-20 | src/applications/nuance/editor/NuanceQueueEditor.php:7-20 | src/applications/nuance/editor/NuanceSourceEditor.php:7-24 | src/applications/passphrase/editor/PassphraseCredentialTransactionEditor.php:7-32 \u2014 before extracting anything, compare \u0060src/applications/dashboard/editor/PhabricatorDashboardPortalEditor.php\u0060 and \u0060src/applications/drydock/editor/DrydockBlueprintEditor.php\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 152 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/dashboard/editor/PhabricatorDashboardPortalEditor.php:7\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/editor/PhabricatorDashboardPortalEditor.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"5778ca262c6f8ab2906074ad826e19d87e3e87ca607eb18e26bd1c194d82f709"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (79 lines \u00D7 2): src/applications/drydock/constants/DrydockLeaseStatus.php:14-111 | src/applications/drydock/constants/DrydockResourceStatus.php:13-91 \u2014 before extracting anything, compare \u0060src/applications/drydock/constants/DrydockLeaseStatus.php\u0060 and \u0060src/applications/drydock/constants/DrydockResourceStatus.php\u0060 as WHOLE FILES: 92% of the shorter file\u0027s lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it \u2014 treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/drydock/constants/DrydockLeaseStatus.php:14\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/constants/DrydockLeaseStatus.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"7fc1d7affbc24bfdaf9694bfbddefed62b69568e17a0cee7987378f915b22cd4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/applications/drydock/logtype/DrydockLeaseActivationFailureLogType.php:8-19 | src/applications/drydock/logtype/DrydockResourceActivationFailureLogType.php:8-19 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/drydock/logtype/DrydockLeaseActivationFailureLogType.php:8\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/logtype/DrydockLeaseActivationFailureLogType.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"b68d3fe318c39d7a85c4af76c58d7df48285655cb1f5217ec4e80963809ba3aa"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/drydock/logtype/DrydockLeaseActivationYieldLogType.php:8-20 | src/applications/drydock/logtype/DrydockResourceActivationYieldLogType.php:8-20 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/drydock/logtype/DrydockLeaseActivationYieldLogType.php:8\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/logtype/DrydockLeaseActivationYieldLogType.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"48b0736855853f2c9a82ba087c5bfc878ef9b3f2ca1bc061be0b93a17da36635"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 3): src/applications/drydock/logtype/DrydockLeaseAllocationFailureLogType.php:8-23 | src/applications/drydock/logtype/DrydockLeaseReacquireLogType.php:8-23 | src/applications/drydock/logtype/DrydockResourceAllocationFailureLogType.php:8-23 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/drydock/logtype/DrydockLeaseAllocationFailureLogType.php:8\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/logtype/DrydockLeaseAllocationFailureLogType.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"141995d180864447f87dbb6f4d1450518495574804ac67977125677399e40936"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 4): src/applications/drydock/logtype/DrydockLeaseReclaimLogType.php:8-20 | src/applications/drydock/logtype/DrydockLeaseWaitingForActivationLogType.php:8-20 | src/applications/drydock/logtype/DrydockLeaseWaitingForReclamationLogType.php:8-20 | src/applications/drydock/logtype/DrydockLeaseWaitingForResourcesLogType.php:8-20 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 4 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/drydock/logtype/DrydockLeaseReclaimLogType.php:8\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/logtype/DrydockLeaseReclaimLogType.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"14bf8da83672848e4f805a88a72a4660d137c7dc03470c7059c6d76f766090e9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (31 lines \u00D7 2): src/applications/harbormaster/step/HarbormasterArcLintBuildStepImplementation.php:9-39 | src/applications/harbormaster/step/HarbormasterArcUnitBuildStepImplementation.php:9-39 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/harbormaster/step/HarbormasterArcLintBuildStepImplementation.php:9\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/step/HarbormasterArcLintBuildStepImplementation.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"3792b1495c6a74aae1161b9b81e0ea4eaa43a8702a6514d8a815412a192ff8d4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (22 lines \u00D7 5): src/applications/dashboard/editor/PhabricatorDashboardPortalEditor.php:7-32 | src/applications/drydock/editor/DrydockBlueprintEditor.php:7-32 | src/applications/harbormaster/editor/HarbormasterBuildPlanEditor.php:7-30 | src/applications/herald/editor/HeraldWebhookEditor.php:7-28 | src/applications/passphrase/editor/PassphraseCredentialTransactionEditor.php:7-32 \u2014 before extracting anything, compare \u0060src/applications/dashboard/editor/PhabricatorDashboardPortalEditor.php\u0060 and \u0060src/applications/drydock/editor/DrydockBlueprintEditor.php\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 152 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/dashboard/editor/PhabricatorDashboardPortalEditor.php:7\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/editor/PhabricatorDashboardPortalEditor.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"226638f45ce051286e6cada245267a0260b65d01d3293c00babde83a0f7e5d86"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 13): src/applications/auth/engine/PhabricatorAuthSessionEngineExtension.php:7-28 | src/applications/auth/revoker/PhabricatorAuthRevoker.php:15-35 | src/applications/cache/purger/PhabricatorCachePurger.php:11-27 | src/applications/metamta/engine/PhabricatorMailEngineExtension.php:10-44 | src/applications/metamta/message/PhabricatorMailExternalMessage.php:7-14 | src/applications/metamta/stamp/PhabricatorMailStamp.php:12-85 | src/applications/policy/capability/PhabricatorPolicyCapability.php:19-64 | src/applications/search/index/PhabricatorFulltextEngineExtension.php:6-43 | src/applications/search/index/PhabricatorIndexEngineExtension.php:9-45 | src/applications/system/engine/PhabricatorDestructionEngineExtension.php:6-33 | src/applications/transactions/engineextension/PhabricatorEditorExtension.php:11-79 | src/infrastructure/export/engine/PhabricatorExportEngineExtension.php:8-28 | src/infrastructure/export/format/PhabricatorExportFormat.php:10-50 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 13 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 13 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/auth/engine/PhabricatorAuthSessionEngineExtension.php:7\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/engine/PhabricatorAuthSessionEngineExtension.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"03e76e5365177a4f55af2b3d41f4508cb487ca53db240254c6db059fbc2e01a0"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18 lines \u00D7 6): src/applications/dashboard/editor/PhabricatorDashboardPortalEditor.php:7-32 | src/applications/drydock/editor/DrydockBlueprintEditor.php:7-32 | src/applications/harbormaster/editor/HarbormasterBuildPlanEditor.php:7-30 | src/applications/meta/editor/PhabricatorApplicationEditor.php:7-43 | src/applications/nuance/editor/NuanceSourceEditor.php:7-24 | src/applications/passphrase/editor/PassphraseCredentialTransactionEditor.php:7-32 \u2014 before extracting anything, compare \u0060src/applications/dashboard/editor/PhabricatorDashboardPortalEditor.php\u0060 and \u0060src/applications/drydock/editor/DrydockBlueprintEditor.php\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 152 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/dashboard/editor/PhabricatorDashboardPortalEditor.php:7\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/editor/PhabricatorDashboardPortalEditor.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"7d6a981eb0d492098fff64f559fca788e79042ded278fe17eba464745ab6a597"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/applications/auth/exception/PhabricatorAuthInviteDialogException.php:14-60 | src/applications/people/mail/PhabricatorPeopleMailEngineException.php:10-21 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/auth/exception/PhabricatorAuthInviteDialogException.php:14\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/exception/PhabricatorAuthInviteDialogException.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"1f9fa9abe4adbf2e6e794b9d8ccfcedd4031ac4948adac56bb01a803a45fd2f2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 7): src/applications/auth/tokentype/PhabricatorAuthTemporaryTokenType.php:11-22 | src/applications/calendar/importlog/PhabricatorCalendarImportLogType.php:7-36 | src/applications/drydock/operation/DrydockRepositoryOperationType.php:22-63 | src/applications/guides/guidance/PhabricatorGuidanceEngineExtension.php:7-36 | src/applications/harbormaster/artifact/HarbormasterArtifact.php:11-61 | src/applications/people/userlog/PhabricatorUserLogType.php:7-16 | src/infrastructure/markup/markuprule/PhutilRemarkupHyperlinkEngineExtension.php:9-25 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 7 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 7 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/auth/tokentype/PhabricatorAuthTemporaryTokenType.php:11\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/tokentype/PhabricatorAuthTemporaryTokenType.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"f1fdb21c267db3d206d495cb0428ece75e5f9c9057de452f0ac98e8d1bbf97c9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (49 lines \u00D7 3): src/applications/maniphest/xaction/ManiphestTaskDescriptionTransaction.php:9-68 | src/applications/phame/xaction/PhameBlogDescriptionTransaction.php:9-57 | src/applications/phurl/xaction/PhabricatorPhurlURLDescriptionTransaction.php:9-57 \u2014 before extracting anything, compare \u0060src/applications/phame/xaction/PhameBlogDescriptionTransaction.php\u0060 and \u0060src/applications/phurl/xaction/PhabricatorPhurlURLDescriptionTransaction.php\u0060 as WHOLE FILES: 85% of the shorter file\u0027s lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it \u2014 treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/maniphest/xaction/ManiphestTaskDescriptionTransaction.php:9\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/xaction/ManiphestTaskDescriptionTransaction.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"55a124dafea1da59143eeba8f108afccb3b5303b509a778b9b95b884d457ae8c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (22 lines \u00D7 2): src/applications/phame/xaction/PhameBlogHeaderImageTransaction.php:10-31 | src/applications/phame/xaction/PhamePostHeaderImageTransaction.php:9-30 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phame/xaction/PhameBlogHeaderImageTransaction.php:10\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/xaction/PhameBlogHeaderImageTransaction.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"fd9a26e788cac6ce5775997d633ba1348b7f420cdc42da9fcddfcffd5c806489"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (22 lines \u00D7 2): src/applications/phame/xaction/PhameBlogProfileImageTransaction.php:10-31 | src/applications/phortune/xaction/PhortuneMerchantPictureTransaction.php:9-30 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/phame/xaction/PhameBlogProfileImageTransaction.php:10\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/xaction/PhameBlogProfileImageTransaction.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"d1d30c2329ec3225c79ec38265e36274240e8df31d1a84f1dcd42c67613dc904"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (98 lines \u00D7 2): src/applications/project/trigger/PhabricatorProjectTriggerAddProjectsRule.php:9-106 | src/applications/project/trigger/PhabricatorProjectTriggerRemoveProjectsRule.php:9-106 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/project/trigger/PhabricatorProjectTriggerAddProjectsRule.php:9\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/trigger/PhabricatorProjectTriggerAddProjectsRule.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"1c4c6d1301626f0eed321d9dde993677c471415ea6d8bb41981aff37e69281e8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (50 lines \u00D7 2): src/applications/search/engineextension/PhabricatorHovercardEngineExtension.php:8-57 | src/applications/search/engineextension/PhabricatorSearchEngineExtension.php:9-84 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/search/engineextension/PhabricatorHovercardEngineExtension.php:8\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engineextension/PhabricatorHovercardEngineExtension.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"df33ce5fd739791aeaa24115a9d7f3e2f5c225c7164af2068448d4e22a873271"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 2): src/applications/search/relationship/DiffusionCommitRelationshipSource.php:7-23 | src/applications/search/relationship/PholioMockRelationshipSource.php:7-23 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/search/relationship/DiffusionCommitRelationshipSource.php:7\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/relationship/DiffusionCommitRelationshipSource.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"9532fea708d5c7f1587129fc812496373ae04946d17d6d19d1a37fa02a67d7d3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (49 lines \u00D7 2): src/applications/search/engineextension/PhabricatorSearchEngineExtension.php:9-84 | src/applications/transactions/engineextension/PhabricatorEditEngineExtension.php:8-56 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/search/engineextension/PhabricatorSearchEngineExtension.php:9\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engineextension/PhabricatorSearchEngineExtension.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"7b405c973c5b5a1a33ae7669cca6845719b06780a11018df6214b992f0de66bf"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (34 lines \u00D7 2): src/applications/legalpad/xaction/LegalpadDocumentPreambleTransaction.php:10-54 | src/applications/transactions/xaction/PhabricatorEditEnginePreambleTransaction.php:9-42 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/applications/legalpad/xaction/LegalpadDocumentPreambleTransaction.php:10\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/legalpad/xaction/LegalpadDocumentPreambleTransaction.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"3d1e8732a6f46d44a34154ebbda39e31833b9e87e25ef75da42ff954025fb0ef"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (27 lines \u00D7 2): src/infrastructure/customfield/storage/PhabricatorCustomFieldNumericIndexStorage.php:7-33 | src/infrastructure/customfield/storage/PhabricatorCustomFieldStringIndexStorage.php:7-33 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/infrastructure/customfield/storage/PhabricatorCustomFieldNumericIndexStorage.php:7\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/customfield/storage/PhabricatorCustomFieldNumericIndexStorage.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"fdef45e906f6a044f49ea7b22ddbb123b60ab0cd4b8a05f248a141d7abf78133"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): src/infrastructure/daemon/workers/action/PhabricatorTriggerAction.php:15-24 | src/infrastructure/daemon/workers/clock/PhabricatorTriggerClock.php:19-28 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/infrastructure/daemon/workers/action/PhabricatorTriggerAction.php:15\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/workers/action/PhabricatorTriggerAction.php"},"region":{"startLine":15}}}],"partialFingerprints":{"codehealthFindingId/v1":"54952fbaa09f6aca38a6e5855c31df17330a2cfc05d16eb4929e167c061f15b0"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 41): src/applications/almanac/query/AlmanacBindingSearchEngine.php:60-68 | src/applications/almanac/query/AlmanacInterfaceSearchEngine.php:51-59 | src/applications/almanac/query/AlmanacNamespaceSearchEngine.php:51-59 | src/applications/almanac/query/AlmanacNetworkSearchEngine.php:51-59 | src/applications/almanac/query/AlmanacServiceSearchEngine.php:78-86 | src/applications/auth/query/PhabricatorAuthInviteSearchEngine.php:47-55 | src/applications/auth/query/PhabricatorAuthSSHKeySearchEngine.php:65-73 | src/applications/calendar/query/PhabricatorCalendarExportSearchEngine.php:48-56 | src/applications/calendar/query/PhabricatorCalendarImportLogSearchEngine.php:54-62 | src/applications/calendar/query/PhabricatorCalendarImportSearchEngine.php:45-53 | src/applications/diffusion/query/DiffusionPullLogSearchEngine.php:162-170 | src/applications/diffusion/query/DiffusionRepositoryIdentitySearchEngine.php:88-96 | src/applications/diffusion/query/DiffusionSyncLogSearchEngine.php:130-138 | src/applications/diviner/query/DivinerAtomSearchEngine.php:115-123 | src/applications/drydock/query/DrydockAuthorizationSearchEngine.php:94-102 | src/applications/drydock/query/DrydockLogSearchEngine.php:133-141 | src/applications/drydock/query/DrydockRepositoryOperationSearchEngine.php:70-78 | src/applications/flag/query/PhabricatorFlagSearchEngine.php:84-92 | src/applications/fund/query/FundBackerSearchEngine.php:86-94 | src/applications/harbormaster/query/HarbormasterArtifactSearchEngine.php:59-67 | src/applications/harbormaster/query/HarbormasterBuildLogSearchEngine.php:59-67 | src/applications/harbormaster/query/HarbormasterBuildStepSearchEngine.php:39-47 | src/applications/harbormaster/query/HarbormasterBuildTargetSearchEngine.php:109-117 | src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php:108-116 | src/applications/legalpad/query/LegalpadDocumentSignatureSearchEngine.php:130-138 | src/applications/nuance/query/NuanceItemSearchEngine.php:42-50 | src/applications/nuance/query/NuanceQueueSearchEngine.php:41-49 | src/applications/nuance/query/NuanceSourceSearchEngine.php:50-58 | src/applications/packages/query/PhabricatorPackagesPackageSearchEngine.php:64-72 | src/applications/packages/query/PhabricatorPackagesPublisherSearchEngine.php:54-62 | src/applications/packages/query/PhabricatorPackagesVersionSearchEngine.php:63-71 | src/applications/people/query/PhabricatorPeopleLogSearchEngine.php:116-124 | src/applications/phortune/query/PhortuneChargeSearchEngine.php:81-89 | src/applications/phortune/query/PhortuneMerchantSearchEngine.php:45-53 | src/applications/phortune/query/PhortuneSubscriptionSearchEngine.php:117-125 | src/applications/phriction/query/PhrictionContentSearchEngine.php:57-65 | src/applications/project/query/PhabricatorProjectColumnSearchEngine.php:57-65 | src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php:83-91 | src/applications/settings/query/PhabricatorUserPreferencesSearchEngine.php:42-50 | src/applications/transactions/query/PhabricatorEditEngineSearchEngine.php:48-56 | src/applications/xhprof/query/PhabricatorXHProfSampleSearchEngine.php:41-49 \u2014 before extracting anything, compare \u0060src/applications/almanac/query/AlmanacNamespaceSearchEngine.php\u0060 and \u0060src/applications/almanac/query/AlmanacNetworkSearchEngine.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 39 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/query/AlmanacBindingSearchEngine.php"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"44403e52f214ec23a2cf87c1aaa3f2503e9b9361e25a6e6a37515104e5698d8f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 4): src/applications/almanac/query/AlmanacNamespaceSearchEngine.php:28-34 | src/applications/almanac/query/AlmanacNetworkSearchEngine.php:28-34 | src/applications/nuance/query/NuanceSourceSearchEngine.php:19-25 | src/applications/packages/query/PhabricatorPackagesPublisherSearchEngine.php:23-29 \u2014 before extracting anything, compare \u0060src/applications/almanac/query/AlmanacNamespaceSearchEngine.php\u0060 and \u0060src/applications/almanac/query/AlmanacNetworkSearchEngine.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 39 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/query/AlmanacNamespaceSearchEngine.php"},"region":{"startLine":28}}}],"partialFingerprints":{"codehealthFindingId/v1":"f1d5163ac84e4b52dab1edf6f6b7b108d16908533c14a012ff144bcc269ed1d4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 3): src/applications/almanac/storage/AlmanacDevice.php:60-64 | src/applications/almanac/storage/AlmanacNamespace.php:48-52 | src/applications/almanac/storage/AlmanacService.php:73-77 \u2014 before extracting anything, compare \u0060src/applications/almanac/storage/AlmanacDevice.php\u0060 and \u0060src/applications/almanac/storage/AlmanacService.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/storage/AlmanacDevice.php"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"2872306ae3b15f06ed926f93b466ffa80291c7971fcc48eb14b60dba95f56f96"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 26): src/applications/almanac/storage/AlmanacDevice.php:177-182 | src/applications/almanac/storage/AlmanacNamespace.php:118-123 | src/applications/almanac/storage/AlmanacNetwork.php:71-76 | src/applications/almanac/storage/AlmanacService.php:196-201 | src/applications/calendar/storage/PhabricatorCalendarImport.php:123-128 | src/applications/countdown/storage/PhabricatorCountdown.php:122-127 | src/applications/dashboard/storage/PhabricatorDashboard.php:158-163 | src/applications/dashboard/storage/PhabricatorDashboardPanel.php:142-147 | src/applications/dashboard/storage/PhabricatorDashboardPortal.php:90-95 | src/applications/differential/storage/DifferentialRevision.php:479-484 | src/applications/diviner/storage/DivinerLiveBook.php:105-110 | src/applications/drydock/storage/DrydockBlueprint.php:314-319 | src/applications/fund/storage/FundInitiative.php:116-121 | src/applications/herald/storage/HeraldWebhook.php:183-188 | src/applications/nuance/storage/NuanceQueue.php:62-67 | src/applications/nuance/storage/NuanceSource.php:118-123 | src/applications/oauthserver/storage/PhabricatorOAuthServerClient.php:80-85 | src/applications/owners/storage/PhabricatorOwnersPackage.php:605-610 | src/applications/packages/storage/PhabricatorPackagesPackage.php:149-154 | src/applications/passphrase/storage/PassphraseCredential.php:140-145 | src/applications/pholio/storage/PholioMock.php:180-185 | src/applications/phriction/storage/PhrictionDocument.php:192-197 | src/applications/phurl/storage/PhabricatorPhurlURL.php:129-134 | src/applications/spaces/storage/PhabricatorSpacesNamespace.php:75-80 | src/applications/transactions/storage/PhabricatorApplicationTransaction.php:1981-1986 | src/applications/transactions/storage/PhabricatorApplicationTransactionComment.php:166-171 \u2014 before extracting anything, compare \u0060src/applications/almanac/storage/AlmanacDevice.php\u0060 and \u0060src/applications/almanac/storage/AlmanacService.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/applications/fund/storage/FundInitiative.php:125\u0060 calls \u0060getPHID\u0060, \u0060getOwnerPHID\u0060 and \u0060src/applications/almanac/storage/AlmanacDevice.php:186\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/storage/AlmanacDevice.php"},"region":{"startLine":177}}}],"partialFingerprints":{"codehealthFindingId/v1":"1a716660794dad6260b15a15d7964f7286fae0f61767495c681b73789da7d6a2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): src/applications/auth/future/PhabricatorDuoFuture.php:137-151 | src/applications/metamta/future/PhabricatorTwilioFuture.php:83-97 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/future/PhabricatorDuoFuture.php"},"region":{"startLine":137}}}],"partialFingerprints":{"codehealthFindingId/v1":"471f72a44e430732b1a9ed4d3f63f6d6a5893574b6593660cd9dd343cb629cab"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 3): src/applications/auth/provider/PhabricatorDisqusAuthProvider.php:11-25 | src/applications/auth/provider/PhabricatorSlackAuthProvider.php:11-25 | src/applications/auth/provider/PhabricatorTwitchAuthProvider.php:11-25 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorDisqusAuthProvider.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"2304edab4dd2786494e0c7be2d9917b05a1ee36b940a0395ee112f58736ff5a1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18 lines \u00D7 2): src/applications/auth/provider/PhabricatorGitHubAuthProvider.php:11-28 | src/applications/auth/provider/PhabricatorWordPressAuthProvider.php:11-28 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorGitHubAuthProvider.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"e46312a5e25bbfea8168f8e8a30b5598c4f07334f8b6fee388f710d910075c79"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 6): src/applications/auth/xaction/PhabricatorAuthContactNumberNumberTransaction.php:22-29 | src/applications/dashboard/xaction/dashboard/PhabricatorDashboardIconTransaction.php:17-24 | src/applications/dashboard/xaction/dashboard/PhabricatorDashboardNameTransaction.php:17-24 | src/applications/dashboard/xaction/panel/PhabricatorDashboardPanelNameTransaction.php:17-24 | src/applications/dashboard/xaction/portal/PhabricatorDashboardPortalNameTransaction.php:17-24 | src/applications/transactions/xaction/PhabricatorEditEngineSubtypeTransaction.php:17-24 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 6 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 6 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/xaction/PhabricatorAuthContactNumberNumberTransaction.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"fc4422f08157dfb796fbf75f9a117bb023e49d8f94031df530adaeb6bca9ad37"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 3): src/applications/badges/query/PhabricatorBadgesSearchEngine.php:70-84 | src/applications/herald/query/HeraldWebhookSearchEngine.php:53-68 | src/applications/phriction/query/PhrictionDocumentSearchEngine.php:77-91 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/query/PhabricatorBadgesSearchEngine.php"},"region":{"startLine":70}}}],"partialFingerprints":{"codehealthFindingId/v1":"90007fc964314f002347e9dd36711f4506f70ab2c4a9405f026061ae8342c206"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 3): src/applications/badges/storage/PhabricatorBadgesBadge.php:108-113 | src/applications/packages/storage/PhabricatorPackagesPublisher.php:125-130 | src/applications/project/storage/PhabricatorProjectTrigger.php:311-316 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/storage/PhabricatorBadgesBadge.php"},"region":{"startLine":108}}}],"partialFingerprints":{"codehealthFindingId/v1":"57befe1c6117131fb172e7c9041bad5a0c04eaad22f426d737961923abae2141"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): src/applications/badges/xaction/PhabricatorBadgesBadgeAwardTransaction.php:24-33 | src/applications/badges/xaction/PhabricatorBadgesBadgeRevokeTransaction.php:27-36 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/xaction/PhabricatorBadgesBadgeAwardTransaction.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"679ababafff6d8723f204f063668840eeae2de2644eb1b1a234463441dbdbf76"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/applications/badges/xaction/PhabricatorBadgesBadgeIconTransaction.php:25-32 | src/applications/calendar/xaction/PhabricatorCalendarEventIconTransaction.php:25-32 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/xaction/PhabricatorBadgesBadgeIconTransaction.php"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"9c0cd5de795518f1e9086a1e990b0c9e457e55d6e84ec371585bb0507ae286eb"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/applications/badges/xaction/PhabricatorBadgesBadgeIconTransaction.php:36-44 | src/applications/calendar/xaction/PhabricatorCalendarEventIconTransaction.php:36-44 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/xaction/PhabricatorBadgesBadgeIconTransaction.php"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"c3079eb16351de18ca65a96abcbcd135c09aaff6abd7fa0135ced1963f15eee8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 6): src/applications/calendar/controller/PhabricatorCalendarImportListController.php:13-21 | src/applications/herald/controller/HeraldRuleListController.php:21-29 | src/applications/passphrase/controller/PassphraseController.php:29-37 | src/applications/phlux/controller/PhluxController.php:6-13 | src/applications/pholio/controller/PholioController.php:11-19 | src/applications/slowvote/controller/PhabricatorSlowvoteListController.php:17-25 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 6 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 6 times. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/controller/PhabricatorCalendarImportListController.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"9f22bf2bb23937c0feb10a8fdb32336c2b3023e10819a58f42af794de47ca86e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 4): src/applications/calendar/editor/PhabricatorCalendarEventEditor.php:91-97 | src/applications/conpherence/editor/ConpherenceEditor.php:89-95 | src/applications/legalpad/editor/LegalpadDocumentEditor.php:15-21 | src/applications/phurl/editor/PhabricatorPhurlURLEditor.php:27-32 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 4 times. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/editor/PhabricatorCalendarEventEditor.php"},"region":{"startLine":91}}}],"partialFingerprints":{"codehealthFindingId/v1":"6256fb1623294e7d0e2081eb603339cf5740e621ff59ba0f09b219f7a6d644e1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 3): src/applications/calendar/typeahead/PhabricatorCalendarInviteeViewerFunctionDatasource.php:32-38 | src/applications/differential/typeahead/DifferentialResponsibleViewerFunctionDatasource.php:32-38 | src/applications/people/typeahead/PhabricatorViewerDatasource.php:38-44 \u2014 before extracting anything, compare \u0060src/applications/calendar/typeahead/PhabricatorCalendarInviteeViewerFunctionDatasource.php\u0060 and \u0060src/applications/differential/typeahead/DifferentialResponsibleViewerFunctionDatasource.php\u0060 as WHOLE FILES: 87% of the shorter file\u0027s lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 3 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it \u2014 treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/typeahead/PhabricatorCalendarInviteeViewerFunctionDatasource.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"acf60b74da9e74e7883270556d9a428e179db5202fc2446e89926adc555a4f9d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 3): src/applications/calendar/typeahead/PhabricatorCalendarInviteeViewerFunctionDatasource.php:61-66 | src/applications/differential/typeahead/DifferentialResponsibleViewerFunctionDatasource.php:61-66 | src/applications/people/typeahead/PhabricatorViewerDatasource.php:64-69 \u2014 before extracting anything, compare \u0060src/applications/calendar/typeahead/PhabricatorCalendarInviteeViewerFunctionDatasource.php\u0060 and \u0060src/applications/differential/typeahead/DifferentialResponsibleViewerFunctionDatasource.php\u0060 as WHOLE FILES: 87% of the shorter file\u0027s lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 3 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it \u2014 treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/typeahead/PhabricatorCalendarInviteeViewerFunctionDatasource.php"},"region":{"startLine":61}}}],"partialFingerprints":{"codehealthFindingId/v1":"fb1f6b44aab4c36661f5ce9f57e907ce70c91d6fab5fc3733be2d73a6c1a702c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/applications/calendar/typeahead/PhabricatorCalendarInviteeViewerFunctionDatasource.php:70-74 | src/applications/differential/typeahead/DifferentialResponsibleViewerFunctionDatasource.php:70-74 \u2014 before extracting anything, compare \u0060src/applications/calendar/typeahead/PhabricatorCalendarInviteeViewerFunctionDatasource.php\u0060 and \u0060src/applications/differential/typeahead/DifferentialResponsibleViewerFunctionDatasource.php\u0060 as WHOLE FILES: 87% of the shorter file\u0027s lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 3 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it \u2014 treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/typeahead/PhabricatorCalendarInviteeViewerFunctionDatasource.php"},"region":{"startLine":70}}}],"partialFingerprints":{"codehealthFindingId/v1":"51a95c3f8c41a78d7c173afd9fd774e525761102237481b78aa047b8af644ee8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 3): src/applications/calendar/xaction/PhabricatorCalendarEventEndDateTransaction.php:44-49 | src/applications/calendar/xaction/PhabricatorCalendarEventStartDateTransaction.php:44-49 | src/applications/countdown/xaction/PhabricatorCountdownEpochTransaction.php:31-36 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/xaction/PhabricatorCalendarEventEndDateTransaction.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"b95e4119edb73cd926b6bb212ce0b3575ae281f645ba5d1664af487734203723"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/applications/conduit/method/ConduitAPIMethod.php:450-461 | src/applications/transactions/editengine/PhabricatorEditEngineAPIMethod.php:148-159 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conduit/method/ConduitAPIMethod.php"},"region":{"startLine":450}}}],"partialFingerprints":{"codehealthFindingId/v1":"17770e238585905c7c44e4916b5dfaa1c78d47330f72c985a96fb53b1e35119b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/config/controller/PhabricatorConfigController.php:27-39 | src/applications/diffusion/controller/DiffusionRepositoryManageController.php:26-38 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/PhabricatorConfigController.php"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"05f5fc1fda9cd6cc428c2813e075444dd1296c033ad151e55ab7d8d17bec1ba3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): src/applications/conpherence/editor/ConpherenceEditor.php:222-227 | src/applications/fund/editor/FundInitiativeEditor.php:60-66 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/editor/ConpherenceEditor.php"},"region":{"startLine":222}}}],"partialFingerprints":{"codehealthFindingId/v1":"206d83828aa1ec3b45854131a50693246fa7479c9832c7e73a8abc3eaced64e8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 3): src/applications/conpherence/storage/ConpherenceTransactionComment.php:13-26 | src/applications/legalpad/storage/LegalpadTransactionComment.php:23-38 | src/applications/pholio/storage/PholioTransactionComment.php:18-35 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/storage/ConpherenceTransactionComment.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"5ef4d669d601dd9cbd47c391fa2e877814ea93c500541259e36c62a93cf0c1c2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 5): src/applications/dashboard/install/PhabricatorDashboardFavoritesInstallWorkflow.php:13-19 | src/applications/dashboard/install/PhabricatorDashboardFavoritesInstallWorkflow.php:36-42 | src/applications/dashboard/install/PhabricatorDashboardFavoritesInstallWorkflow.php:46-52 | src/applications/dashboard/install/PhabricatorDashboardHomeInstallWorkflow.php:35-41 | src/applications/dashboard/install/PhabricatorDashboardHomeInstallWorkflow.php:45-51 \u2014 there are 5 copies across 2 file(s) \u2014 more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 5 sites; resolving a subset leaves the remainder to drift apart. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/install/PhabricatorDashboardFavoritesInstallWorkflow.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"ae2440187b041cae9c72b011e504040cca8d7ec88ede8cfec8f9c47d9f222ee5"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 3): src/applications/dashboard/query/PhabricatorDashboardPanelSearchEngine.php:75-84 | src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php:44-53 | src/applications/herald/query/HeraldRuleSearchEngine.php:100-109 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/query/PhabricatorDashboardPanelSearchEngine.php"},"region":{"startLine":75}}}],"partialFingerprints":{"codehealthFindingId/v1":"2fd23c475cb58455e7f4a330a37e353b2b6160efecdb7dbfe2646ff497874bc2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): src/applications/dashboard/query/PhabricatorDashboardPortalSearchEngine.php:40-49 | src/applications/differential/query/DifferentialDiffSearchEngine.php:52-62 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/query/PhabricatorDashboardPortalSearchEngine.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"e0d818a574e68eea64d1b02120c482fb95bd378c1b7551c1a358b5d1271224be"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): src/applications/differential/customfield/DifferentialAuditorsField.php:23-28 | src/applications/differential/customfield/DifferentialJIRAIssuesField.php:29-34 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/customfield/DifferentialAuditorsField.php"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"3d541040f718c213739a65fe16edcd801474ef676ac32651f8f2bb9bdee7df24"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/applications/differential/customfield/DifferentialBlameRevisionField.php:71-77 | src/applications/differential/customfield/DifferentialRevertPlanField.php:91-97 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/customfield/DifferentialBlameRevisionField.php"},"region":{"startLine":71}}}],"partialFingerprints":{"codehealthFindingId/v1":"ac7725a61540d8c5165ee90544297d1f6adb0d5f32c9a82d1ae48a262f2c8c95"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/applications/differential/customfield/DifferentialBlameRevisionField.php:83-91 | src/applications/differential/customfield/DifferentialRevertPlanField.php:103-111 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/customfield/DifferentialBlameRevisionField.php"},"region":{"startLine":83}}}],"partialFingerprints":{"codehealthFindingId/v1":"574af0e9050fd1fea2e3eba292cf1e8424432b1f7ef30ed9de9400195f6017f1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/applications/differential/customfield/DifferentialCustomField.php:30-36 | src/applications/differential/field/DifferentialCommitMessageField.php:117-123 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/customfield/DifferentialCustomField.php"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"2bff0282b407787418409c8185a96c6540d34c3a0bdd8b6275ac47039f4799d2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 3): src/applications/differential/customfield/DifferentialRevertPlanField.php:43-47 | src/applications/differential/customfield/DifferentialSummaryField.php:54-58 | src/applications/differential/customfield/DifferentialTestPlanField.php:58-62 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/customfield/DifferentialRevertPlanField.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"d8c5095084f041fcf95be23b9e95f62b0996dbffa531ce01d096dd4a950db91a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): src/applications/differential/customfield/DifferentialSummaryField.php:70-79 | src/applications/differential/customfield/DifferentialTestPlanField.php:74-83 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/customfield/DifferentialSummaryField.php"},"region":{"startLine":70}}}],"partialFingerprints":{"codehealthFindingId/v1":"ade7298e156da7f9a36613756f73537ed42abe1fd25e16a2cf710de22438cb69"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 4): src/applications/differential/phid/DifferentialChangesetPHIDType.php:32-38 | src/applications/harbormaster/phid/HarbormasterBuildArtifactPHIDType.php:32-36 | src/infrastructure/daemon/workers/phid/PhabricatorWorkerBulkJobPHIDType.php:32-38 | src/infrastructure/daemon/workers/phid/PhabricatorWorkerTriggerPHIDType.php:32-38 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/phid/DifferentialChangesetPHIDType.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"5be5d3a0ae3b7009737aa8d0c24e0c6e0688c5f125d56bebbc17b2831deffca3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 5): src/applications/differential/typeahead/DifferentialNoReviewersDatasource.php:67-75 | src/applications/diffusion/typeahead/DiffusionIdentityUnassignedDatasource.php:67-74 | src/applications/people/typeahead/PhabricatorPeopleNoOwnerDatasource.php:66-73 | src/infrastructure/customfield/datasource/PhabricatorCustomFieldApplicationSearchAnyFunctionDatasource.php:60-67 | src/infrastructure/customfield/datasource/PhabricatorCustomFieldApplicationSearchNoneFunctionDatasource.php:62-69 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 5 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 5 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/typeahead/DifferentialNoReviewersDatasource.php"},"region":{"startLine":67}}}],"partialFingerprints":{"codehealthFindingId/v1":"1604ca55b35ecb72b89ad475b28f8980d9a396e9c043c64840d8a46de728162d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/applications/differential/typeahead/DifferentialRevisionClosedStatusDatasource.php:54-61 | src/applications/maniphest/typeahead/ManiphestTaskClosedStatusDatasource.php:54-61 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/typeahead/DifferentialRevisionClosedStatusDatasource.php"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"ad60ffd947e59c9dc3e0225195b2ca95a0a6e31d583624af0e34c549a56bb25c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 4): src/applications/differential/typeahead/DifferentialRevisionClosedStatusDatasource.php:65-71 | src/applications/differential/typeahead/DifferentialRevisionOpenStatusDatasource.php:65-71 | src/applications/maniphest/typeahead/ManiphestTaskClosedStatusDatasource.php:65-71 | src/applications/maniphest/typeahead/ManiphestTaskOpenStatusDatasource.php:65-71 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 4 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/typeahead/DifferentialRevisionClosedStatusDatasource.php"},"region":{"startLine":65}}}],"partialFingerprints":{"codehealthFindingId/v1":"6ad828d2ea84f73e30ff775d5d7c18a3c56b7b971c7279f3a3c8a2749fc241a0"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/applications/differential/typeahead/DifferentialRevisionOpenStatusDatasource.php:54-61 | src/applications/maniphest/typeahead/ManiphestTaskOpenStatusDatasource.php:54-61 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/typeahead/DifferentialRevisionOpenStatusDatasource.php"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"a63c080af9934330c3fbe4c86cc348a542750ea8d8e20e7f17c1e566a682a04f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/applications/diffusion/worker/DiffusionUpdateObjectAfterCommitWorker.php:66-74 | src/applications/repository/worker/PhabricatorRepositoryCommitPublishWorker.php:128-136 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/worker/DiffusionUpdateObjectAfterCommitWorker.php"},"region":{"startLine":66}}}],"partialFingerprints":{"codehealthFindingId/v1":"35defdb4ded89cf44ae5719bf4db9c240f1e0f66e9cac31fc4793849474e7ece"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/applications/drydock/customfield/DrydockBlueprintCoreCustomField.php:36-42 | src/applications/harbormaster/customfield/HarbormasterBuildStepCoreCustomField.php:66-72 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/customfield/DrydockBlueprintCoreCustomField.php"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"0cd63092554660a3240f49be76be11638aec442b045a161405e46d166e8a7968"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 3): src/applications/drydock/query/DrydockLeaseSearchEngine.php:91-107 | src/applications/drydock/query/DrydockResourceSearchEngine.php:83-98 | src/applications/harbormaster/query/HarbormasterBuildPlanSearchEngine.php:62-76 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/query/DrydockLeaseSearchEngine.php"},"region":{"startLine":91}}}],"partialFingerprints":{"codehealthFindingId/v1":"19f6a93f2314e594b282dc64bc6e56972434a462a4bc26ed29c92e351687fc9f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/applications/drydock/storage/DrydockLease.php:161-167 | src/applications/drydock/storage/DrydockResource.php:98-104 \u2014 before extracting anything, compare \u0060src/applications/drydock/storage/DrydockLease.php\u0060 and \u0060src/applications/drydock/storage/DrydockResource.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 42 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/storage/DrydockLease.php"},"region":{"startLine":161}}}],"partialFingerprints":{"codehealthFindingId/v1":"34242d47bb95447713617a5de1c4fe81d39a1d3261d5c799c568796df7596205"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 4): src/applications/feed/query/PhabricatorFeedSearchEngine.php:112-120 | src/applications/macro/query/PhabricatorMacroSearchEngine.php:96-105 | src/applications/paste/query/PhabricatorPasteSearchEngine.php:93-102 | src/applications/pholio/query/PholioMockSearchEngine.php:54-63 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/feed/query/PhabricatorFeedSearchEngine.php"},"region":{"startLine":112}}}],"partialFingerprints":{"codehealthFindingId/v1":"1b37fc4073c5422faec0c3026718cb464a731f05761f2b015459975f3e965988"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/applications/files/editor/PhabricatorFileEditor.php:46-50 | src/applications/phurl/editor/PhabricatorPhurlURLEditor.php:67-71 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/editor/PhabricatorFileEditor.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"f98fb871660773273d4777032379a63adcaac35a0dbf38dc849e5f8941320d05"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): src/applications/fund/editor/FundInitiativeEditor.php:23-28 | src/applications/paste/editor/PhabricatorPasteEditor.php:29-35 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fund/editor/FundInitiativeEditor.php"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"9ccbe29358dc50b7eec652b1f2f5d3bb2021fe0217e09cdaff9a013c93f61bda"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/applications/fund/editor/FundInitiativeEditor.php:49-53 | src/applications/pholio/editor/PholioMockEditor.php:46-50 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fund/editor/FundInitiativeEditor.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"00bede1a84613e3be0349202fab0da23d8483dbaa9116de17454651d82338702"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): src/applications/fund/xaction/FundInitiativeDescriptionTransaction.php:17-22 | src/applications/fund/xaction/FundInitiativeRisksTransaction.php:17-22 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fund/xaction/FundInitiativeDescriptionTransaction.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"4cb9eabcbeab4803c0c585f5a82d9023002d8770a10c1bcca06d12af9a615aa8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 3): src/applications/harbormaster/constants/HarbormasterBuildStatus.php:34-41 | src/applications/harbormaster/constants/HarbormasterBuildableStatus.php:24-31 | src/infrastructure/status/PhabricatorObjectStatus.php:15-22 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/constants/HarbormasterBuildStatus.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"cc2e12cda188c570fd05d6f431d99c0827836618fbd871d41e4f5da9eef1f4f4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/applications/harbormaster/query/HarbormasterArtifactSearchEngine.php:39-45 | src/applications/harbormaster/query/HarbormasterBuildLogSearchEngine.php:39-45 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/query/HarbormasterArtifactSearchEngine.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"222d70691fa089c969a599549fae5853d7a0d53dc993b3d2e4258ac6ba022e05"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/applications/harbormaster/storage/build/HarbormasterBuildTarget.php:181-188 | src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php:90-97 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/storage/build/HarbormasterBuildTarget.php"},"region":{"startLine":181}}}],"partialFingerprints":{"codehealthFindingId/v1":"78d107807ca6da6205d45f6c73c05f27d7863e6dcd333d7de96ff7f9617ea4ec"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 3): src/applications/herald/xaction/HeraldRuleEditTransaction.php:41-46 | src/applications/transactions/xaction/PhabricatorEditEngineLocksTransaction.php:27-32 | src/applications/transactions/xaction/PhabricatorEditEngineOrderTransaction.php:27-32 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/xaction/HeraldRuleEditTransaction.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"daad7f1fef6230ace961d0ce95a2d8431b04675bfec4af0d2b35a978c8e29eeb"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/applications/legalpad/policyrule/PhabricatorLegalpadSignaturePolicyRule.php:65-69 | src/applications/project/policyrule/PhabricatorProjectsBasePolicyRule.php:58-63 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/legalpad/policyrule/PhabricatorLegalpadSignaturePolicyRule.php"},"region":{"startLine":65}}}],"partialFingerprints":{"codehealthFindingId/v1":"a840724f02fd9cd85de56b69fa2adbd7adfbc7f5244b336bb35718ec5e604ae2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/applications/maniphest/constants/ManiphestTaskPriority.php:190-198 | src/applications/maniphest/constants/ManiphestTaskStatus.php:247-255 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/constants/ManiphestTaskPriority.php"},"region":{"startLine":190}}}],"partialFingerprints":{"codehealthFindingId/v1":"27f3e56115575cee48c4a4d298730e82be31da621643191cd0dad355e7e0f617"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 3): src/applications/maniphest/editor/ManiphestTransactionEditor.php:203-207 | src/applications/paste/editor/PhabricatorPasteEditor.php:93-97 | src/applications/ponder/editor/PonderQuestionEditor.php:147-151 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/editor/ManiphestTransactionEditor.php"},"region":{"startLine":203}}}],"partialFingerprints":{"codehealthFindingId/v1":"d45a0f3521bf661d6520bdadce9de48a5d8b628c270befc310c7974cdbfc0221"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 3): src/applications/metamta/storage/PhabricatorMetaMTAMail.php:1093-1103 | src/applications/tokens/conduit/TokenConduitAPIMethod.php:14-25 | src/applications/tokens/conduit/TokenConduitAPIMethod.php:29-41 \u2014 there are 3 copies across 2 file(s) \u2014 more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/storage/PhabricatorMetaMTAMail.php"},"region":{"startLine":1093}}}],"partialFingerprints":{"codehealthFindingId/v1":"933ba4d24d397787fb91e959180422fee5c5d573c503569cbc9d3d6b2e8afcba"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 3): src/applications/notification/client/PhabricatorNotificationServerRef.php:70-78 | src/infrastructure/cluster/PhabricatorDatabaseRef.php:295-303 | src/infrastructure/cluster/search/PhabricatorSearchService.php:158-166 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/notification/client/PhabricatorNotificationServerRef.php"},"region":{"startLine":70}}}],"partialFingerprints":{"codehealthFindingId/v1":"ad68a76000d594092b96afd8a4daef0bce4b4b9e3f4701d9178e3ee49376d9ce"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/applications/nuance/controller/NuanceQueueViewController.php:44-51 | src/applications/nuance/controller/NuanceSourceViewController.php:54-61 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/controller/NuanceQueueViewController.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"c86e664e5138ac9b5668954125360d43e0c43c6723ba0ab31caff08f774c1a36"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/applications/nuance/phid/NuanceQueuePHIDType.php:32-38 | src/applications/nuance/phid/NuanceSourcePHIDType.php:32-38 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/phid/NuanceQueuePHIDType.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"76ed7f8d2a255b8a8a1e2ed718c43bb0dffbc27bff90dfa31337f5953f5dd8bd"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/applications/nuance/xaction/NuanceItemOwnerTransaction.php:20-24 | src/applications/nuance/xaction/NuanceItemQueueTransaction.php:17-21 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/xaction/NuanceItemOwnerTransaction.php"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"0e2f52a8e56f19b5e2a677217bbec05744804978cca1dd51466e79a9d2f0d978"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 3): src/applications/oauthserver/phid/PhabricatorOAuthServerClientPHIDType.php:32-38 | src/applications/pholio/phid/PholioImagePHIDType.php:32-38 | src/applications/phortune/phid/PhortuneAccountPHIDType.php:32-38 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/oauthserver/phid/PhabricatorOAuthServerClientPHIDType.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"43f90ca0e9bdd5217c32c6cafba0c2243c7a202943d6c54a6c259fe1c2d97307"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 3): src/applications/packages/controller/PhabricatorPackagesPackageViewController.php:62-69 | src/applications/packages/controller/PhabricatorPackagesPublisherViewController.php:59-66 | src/applications/packages/controller/PhabricatorPackagesVersionViewController.php:60-67 \u2014 before extracting anything, compare \u0060src/applications/packages/controller/PhabricatorPackagesPackageViewController.php\u0060 and \u0060src/applications/packages/controller/PhabricatorPackagesPublisherViewController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 66 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/packages/controller/PhabricatorPackagesPackageViewController.php"},"region":{"startLine":62}}}],"partialFingerprints":{"codehealthFindingId/v1":"1128dfe8914b8b8f2bab901f9d3d22be79769c550c32c84abb6859206533c455"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 3): src/applications/packages/phid/PhabricatorPackagesPackagePHIDType.php:33-42 | src/applications/packages/phid/PhabricatorPackagesPublisherPHIDType.php:33-42 | src/applications/packages/phid/PhabricatorPackagesVersionPHIDType.php:33-42 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/packages/phid/PhabricatorPackagesPackagePHIDType.php"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"ae3fe7ba294551638293d0eef373d60b96d4a0d688bfb1aac7aaa4d1d495e148"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 5): src/applications/passphrase/xaction/PassphraseCredentialSecretIDTransaction.php:34-45 | src/applications/phame/xaction/PhameBlogSubtitleTransaction.php:32-43 | src/applications/phame/xaction/PhamePostSubtitleTransaction.php:32-43 | src/applications/slowvote/xaction/PhabricatorSlowvoteDescriptionTransaction.php:23-36 | src/applications/slowvote/xaction/PhabricatorSlowvoteQuestionTransaction.php:34-47 \u2014 before extracting anything, compare \u0060src/applications/phame/xaction/PhameBlogSubtitleTransaction.php\u0060 and \u0060src/applications/phame/xaction/PhamePostSubtitleTransaction.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 49 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/passphrase/xaction/PassphraseCredentialSecretIDTransaction.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"fb8f82b7553ea674a7827e416e0ba9a7fa7120b834745665d36050c3053e7355"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/applications/people/icon/PhabricatorPeopleIconSet.php:27-35 | src/applications/project/icon/PhabricatorProjectIconSet.php:150-156 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/icon/PhabricatorPeopleIconSet.php"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"427739fff2abfd13882741356f01d8d245e2593815b3d1123e1fa20af7219b3e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/applications/phame/controller/PhameHomeController.php:10-16 | src/applications/phame/controller/blog/PhameBlogListController.php:17-23 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/PhameHomeController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"6f2482bb1571eceb4c0f0c08b299d0130dbff348304bb85cd957c41d1fa7b7aa"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/applications/pholio/editor/PholioMockEditor.php:24-31 | src/applications/phriction/editor/PhrictionTransactionEditor.php:101-108 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/pholio/editor/PholioMockEditor.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"cac3b4d3d6dfa5c85b4127cfbd51a1e45a0168979fc416a210e690f77d639d7d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/applications/pholio/xaction/PholioImageDescriptionTransaction.php:47-55 | src/applications/pholio/xaction/PholioImageNameTransaction.php:50-58 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/pholio/xaction/PholioImageDescriptionTransaction.php"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"6b10da353b0fb0df666bec8d5afdd17c5cf815f610d239e3ff0167e40f74063f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 4): src/applications/phortune/storage/PhortuneCart.php:691-700 | src/applications/phortune/storage/PhortuneCharge.php:176-185 | src/applications/phortune/storage/PhortunePaymentMethod.php:185-194 | src/applications/phortune/storage/PhortuneSubscription.php:280-289 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 4 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/storage/PhortuneCart.php"},"region":{"startLine":691}}}],"partialFingerprints":{"codehealthFindingId/v1":"aad51d13cbdb0185445411b1179d68f7392f6cb91976c8a5c57c0524acea3652"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/project/query/PhabricatorProjectTriggerSearchEngine.php:59-69 | src/applications/spaces/query/PhabricatorSpacesNamespaceSearchEngine.php:54-64 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/query/PhabricatorProjectTriggerSearchEngine.php"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"f88e7a7a94ae615b1ccdf103c9ebc8387ca366fb704cb104a106e4661cac662c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/applications/repository/storage/PhabricatorRepositoryPushLog.php:170-174 | src/applications/repository/storage/PhabricatorRepositoryRefCursor.php:61-65 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepositoryPushLog.php"},"region":{"startLine":170}}}],"partialFingerprints":{"codehealthFindingId/v1":"17eb47350c3d46af199abf2456277353ec0e38a5ca25d47f04b957df0f951d0d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): src/applications/repository/xaction/PhabricatorRepositoryCopyTimeLimitTransaction.php:13-22 | src/applications/repository/xaction/PhabricatorRepositoryTouchLimitTransaction.php:13-22 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/xaction/PhabricatorRepositoryCopyTimeLimitTransaction.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"225fb4678d05c05c9a5412d09d25bb1d1c54f083c2c7c0bd4adaad53fd3a207b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): src/applications/search/engine/PhabricatorApplicationSearchEngine.php:864-873 | src/applications/search/field/PhabricatorSearchField.php:412-421 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorApplicationSearchEngine.php"},"region":{"startLine":864}}}],"partialFingerprints":{"codehealthFindingId/v1":"8a9b0ff1d9396fde61c04bca095400aaf02633d944ea02d19e436ce12880be4a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/applications/search/engineextension/PhabricatorLiskSearchEngineExtension.php:21-29 | src/infrastructure/export/engine/PhabricatorLiskExportEngineExtension.php:9-17 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engineextension/PhabricatorLiskSearchEngineExtension.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"f41a2d30606cc4a03f6ac494d26476d9fbff876a9e23d9028494f9b726aae001"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/applications/settings/setting/PhabricatorSetting.php:122-128 | src/applications/settings/storage/PhabricatorUserPreferences.php:157-163 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/settings/setting/PhabricatorSetting.php"},"region":{"startLine":122}}}],"partialFingerprints":{"codehealthFindingId/v1":"379624caee2f6d330d0febc2b99e78df879ea23db44fa961bc9525b9d4036d3c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 5): src/applications/slowvote/constants/SlowvotePollResponseVisibility.php:34-40 | src/applications/slowvote/constants/SlowvotePollResponseVisibility.php:44-50 | src/applications/slowvote/constants/SlowvotePollStatus.php:33-39 | src/applications/slowvote/constants/SlowvotePollVotingMethod.php:33-39 | src/applications/slowvote/constants/SlowvotePollVotingMethod.php:43-49 \u2014 there are 5 copies across 3 file(s) \u2014 more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 5 sites; resolving a subset leaves the remainder to drift apart. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/slowvote/constants/SlowvotePollResponseVisibility.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"3cce702777d41cf419402a1d2590dcb3fbcee989ba173f5ba88f3344c589f6d2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php:12-27 | src/applications/tokens/event/PhabricatorTokenUIEventListener.php:12-27 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"456acdd2355388c943bf38457f663d5dca62bbecbf9bd89735c74fe240c1a5fa"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 3): src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldBool.php:11-18 | src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php:11-18 | src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldInt.php:11-18 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldBool.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"6b266cca6c6b98ee9fea6061425a4757a20dfe0f5387ce370afe6fc1aa9f38d4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 4): src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldCredential.php:11-18 | src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldLink.php:11-18 | src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php:11-18 | src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldText.php:11-18 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 4 call sites, so a change lands once. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldCredential.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"4bb36b270dd041b2e87168eb535692a6b960f2b508137c9eb7c14c90f9f4a6db"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 3): src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldInt.php:67-71 | src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldLink.php:71-75 | src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldText.php:45-49 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldInt.php"},"region":{"startLine":67}}}],"partialFingerprints":{"codehealthFindingId/v1":"f0a19e9138ed92808117f8ce8d4c5a55795f4fb305ad8abae8ed132addf29b7c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/infrastructure/export/format/PhabricatorCSVExportFormat.php:32-39 | src/infrastructure/export/format/PhabricatorTextExportFormat.php:32-39 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/export/format/PhabricatorCSVExportFormat.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"fc0a8d5e566db4483152ec09f0862fc8ecc04b200d0f10e87ec7306d4417a7fb"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/infrastructure/markup/blockrule/PhutilRemarkupQuotesBlockRule.php:7-15 | src/infrastructure/markup/blockrule/PhutilRemarkupReplyBlockRule.php:11-19 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/blockrule/PhutilRemarkupQuotesBlockRule.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"2af16c049a2d91ee9b33a0a430bc614cbd002d40f7098fb2d4a402808069695d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/view/AphrontDialogView.php:120-127 | src/view/form/PHUIFormInsetView.php:34-41 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/AphrontDialogView.php"},"region":{"startLine":120}}}],"partialFingerprints":{"codehealthFindingId/v1":"2bff721f746eca684247f6617531ecedbe31110b8b6e1f04c88ec725a8efd506"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): src/view/phui/calendar/PHUICalendarDayView.php:44-49 | src/view/phui/calendar/PHUICalendarMonthView.php:45-50 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/calendar/PHUICalendarDayView.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"a5b5f46fa42f84ea1729c6d908b6eda44647d7d772fdbc046368418f9846c0f8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 3): src/aphront/httpparametertype/AphrontProjectListHTTPParameterType.php:7-12 | src/aphront/httpparametertype/AphrontUserListHTTPParameterType.php:7-12 | src/applications/maniphest/httpparametertype/ManiphestTaskListHTTPParameterType.php:7-12 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/httpparametertype/AphrontProjectListHTTPParameterType.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"55a37fc343d7c8c35a1e977675bb2dce1a8a13d354338f35b6a43395d2405583"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): src/aphront/site/PhabricatorPlatformSite.php:41-50 | src/aphront/site/PhabricatorResourceSite.php:29-38 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/site/PhabricatorPlatformSite.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"74259e98eee223f19923e5be67e995e4b166edad7b8478f9262e5ee2f4762ea4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/aphront/site/PhabricatorShortSite.php:35-41 | src/applications/phame/site/PhameBlogSite.php:68-74 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/site/PhabricatorShortSite.php"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"4a5ad44b967c432de69839813c163d51da77787b7477dffc156c445c8fae769b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 3): src/applications/almanac/constants/AlmanacDeviceStatus.php:22-28 | src/applications/differential/constants/DifferentialLintStatus.php:25-31 | src/applications/differential/constants/DifferentialUnitStatus.php:25-31 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/constants/AlmanacDeviceStatus.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"03ccb53f5291364f9279b63387c818938933132297893d0f43d9012fde36b67e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 3): src/applications/almanac/constants/AlmanacDeviceStatus.php:56-62 | src/applications/differential/constants/DifferentialLintStatus.php:43-49 | src/applications/differential/constants/DifferentialUnitStatus.php:43-49 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/constants/AlmanacDeviceStatus.php"},"region":{"startLine":56}}}],"partialFingerprints":{"codehealthFindingId/v1":"09c61cc34916569400754b65a09e9f945d4fa5d57b898545f4cb683c88ed4685"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/applications/almanac/constants/AlmanacDeviceStatus.php:66-72 | src/applications/maniphest/constants/ManiphestTaskStatus.php:130-136 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/constants/AlmanacDeviceStatus.php"},"region":{"startLine":66}}}],"partialFingerprints":{"codehealthFindingId/v1":"fd2d1371e1e7a929355e919d7197f5c918a4d7099e2f10e0a9389315a4d19bdb"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 7): src/applications/almanac/controller/AlmanacNetworkListController.php:11-16 | src/applications/conduit/controller/PhabricatorConduitListController.php:11-15 | src/applications/differential/controller/DifferentialRevisionListController.php:10-15 | src/applications/meta/controller/PhabricatorApplicationsListController.php:11-16 | src/applications/metamta/controller/PhabricatorMetaMTAMailListController.php:7-12 | src/applications/people/controller/PhabricatorPeopleInviteListController.php:7-12 | src/applications/people/controller/PhabricatorPeopleLogsController.php:7-12 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 7 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 7 times. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/controller/AlmanacNetworkListController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"29982ef77a0491ba97532597b4163c2b965162639f45d4f2cfae3f26659c2360"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 3): src/applications/almanac/query/AlmanacInterfaceQuery.php:78-84 | src/applications/phriction/query/PhrictionDocumentQuery.php:168-174 | src/applications/repository/query/PhabricatorRepositoryQuery.php:471-477 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/query/AlmanacInterfaceQuery.php"},"region":{"startLine":78}}}],"partialFingerprints":{"codehealthFindingId/v1":"f3459cc38633803b206bf053829495d20d5f611652f69f1ebf4d76d88cce3a01"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 5): src/applications/almanac/query/AlmanacInterfaceQuery.php:137-146 | src/applications/almanac/query/AlmanacServiceQuery.php:73-82 | src/applications/harbormaster/query/HarbormasterBuildQuery.php:201-210 | src/applications/phriction/query/PhrictionContentQuery.php:70-79 | src/applications/repository/query/PhabricatorRepositoryPushLogQuery.php:166-175 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 5 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 5 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/query/AlmanacInterfaceQuery.php"},"region":{"startLine":137}}}],"partialFingerprints":{"codehealthFindingId/v1":"ad78221a025c69c44f8d0110ed607354ddbb1caebf8fd0c0fa5642940d3be628"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/almanac/storage/AlmanacBinding.php:179-192 | src/applications/almanac/storage/AlmanacInterface.php:129-142 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/storage/AlmanacBinding.php"},"region":{"startLine":179}}}],"partialFingerprints":{"codehealthFindingId/v1":"0b9096c739cf39ca4c6555aca7e90724b4d94ca667d00c09426223bfb9f1604f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/almanac/storage/AlmanacDevice.php:194-207 | src/applications/almanac/storage/AlmanacService.php:213-226 \u2014 before extracting anything, compare \u0060src/applications/almanac/storage/AlmanacDevice.php\u0060 and \u0060src/applications/almanac/storage/AlmanacService.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/storage/AlmanacDevice.php"},"region":{"startLine":194}}}],"partialFingerprints":{"codehealthFindingId/v1":"1e819a420aad47e7c60c3b8475b5aa01c32610180b7a315978c5976fb9d147fe"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 4): src/applications/almanac/storage/AlmanacDevice.php:249-257 | src/applications/almanac/storage/AlmanacInterface.php:152-160 | src/applications/almanac/storage/AlmanacNetwork.php:90-99 | src/applications/almanac/storage/AlmanacService.php:248-256 \u2014 before extracting anything, compare \u0060src/applications/almanac/storage/AlmanacDevice.php\u0060 and \u0060src/applications/almanac/storage/AlmanacService.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/storage/AlmanacDevice.php"},"region":{"startLine":249}}}],"partialFingerprints":{"codehealthFindingId/v1":"b731a9eece0d30afc6aed24913706b5e5b4a47a252dd3dd9f2420f7d7691330b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/applications/auth/adapter/PhutilTwitchAuthAdapter.php:69-73 | src/applications/auth/adapter/PhutilWordPressAuthAdapter.php:66-70 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/adapter/PhutilTwitchAuthAdapter.php"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"c05143dd11dc48dd47b9927bed94856f9fb4c5a31a16aecedb26f252d3d8e7bf"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/applications/auth/controller/message/PhabricatorAuthMessageViewController.php:88-94 | src/applications/people/controller/PhabricatorPeopleLogViewController.php:43-49 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/message/PhabricatorAuthMessageViewController.php"},"region":{"startLine":88}}}],"partialFingerprints":{"codehealthFindingId/v1":"77b1d0652b829557d0f09cb9a10a2fa8c41de2cc6e7459e8e6911255a21f2436"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 3): src/applications/auth/editor/PhabricatorAuthContactNumberEditor.php:27-34 | src/applications/metamta/editor/PhabricatorMetaMTAApplicationEmailEditor.php:158-165 | src/applications/phurl/editor/PhabricatorPhurlURLEditor.php:100-107 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/editor/PhabricatorAuthContactNumberEditor.php"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"acf6048b4fcfe8c27f42482725872cd2ceede86bc006c5c6534fddcd4aed1a61"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/applications/auth/garbagecollector/PhabricatorAuthSessionGarbageCollector.php:17-25 | src/applications/auth/garbagecollector/PhabricatorAuthTemporaryTokenGarbageCollector.php:17-25 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/garbagecollector/PhabricatorAuthSessionGarbageCollector.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"0f51834f2431936b3107f299a0240245c5ef0df2f5e5813421a150b390425d51"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/applications/auth/management/PhabricatorAuthManagementLockWorkflow.php:17-30 | src/applications/auth/management/PhabricatorAuthManagementUnlockWorkflow.php:18-31 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/management/PhabricatorAuthManagementLockWorkflow.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"8da6d45fa40067765a6e99bd7a47a4e975435d43bde87da952bfa504bd3444b9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 4): src/applications/auth/provider/PhabricatorAsanaAuthProvider.php:40-48 | src/applications/auth/provider/PhabricatorJIRAAuthProvider.php:300-308 | src/applications/auth/provider/PhabricatorLDAPAuthProvider.php:485-493 | src/applications/auth/provider/PhabricatorPasswordAuthProvider.php:343-351 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 4 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorAsanaAuthProvider.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"b6d0ba85e4f7269ca8b5356f99107b8d67bb123cc559d973a02383031331dae9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 3): src/applications/auth/provider/PhabricatorAuthProvider.php:103-109 | src/applications/harbormaster/stepgroup/HarbormasterBuildStepGroup.php:29-37 | src/applications/project/order/PhabricatorProjectColumnOrder.php:30-38 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorAuthProvider.php"},"region":{"startLine":103}}}],"partialFingerprints":{"codehealthFindingId/v1":"159a535ccc508afbb3b3ba6778e292ae8ce60959de24c33e80ad0c23b2e15c89"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): src/applications/auth/query/PhabricatorExternalAccountQuery.php:215-224 | src/applications/project/query/PhabricatorProjectTriggerQuery.php:73-82 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/query/PhabricatorExternalAccountQuery.php"},"region":{"startLine":215}}}],"partialFingerprints":{"codehealthFindingId/v1":"61062342a765ebec1c84ea9fa44d1d89838f9ca1543d33bda3d1161693c1990d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/applications/auth/revoker/PhabricatorAuthConduitTokenRevoker.php:22-30 | src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php:516-523 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/revoker/PhabricatorAuthConduitTokenRevoker.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"91adad291413d841c2495b00324a675790d275b0a36e564c80b898c4e6bef06a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/applications/auth/revoker/PhabricatorAuthSessionRevoker.php:19-27 | src/applications/auth/revoker/PhabricatorAuthTemporaryTokenRevoker.php:22-30 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/revoker/PhabricatorAuthSessionRevoker.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"d016c5938f44a3c5313961a12d63f1bf4671cdc6574ccc0b5be24f6fe79b751f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): src/applications/auth/revoker/PhabricatorAuthSessionRevoker.php:31-40 | src/applications/auth/revoker/PhabricatorAuthTemporaryTokenRevoker.php:34-43 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/revoker/PhabricatorAuthSessionRevoker.php"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"41158d02c20f297cbb485f119ccaa97ef2cd8f7ffb3c4c85b0c171b5ab792786"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): src/applications/badges/editor/PhabricatorBadgesEditor.php:88-93 | src/applications/herald/editor/HeraldRuleEditor.php:57-63 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/editor/PhabricatorBadgesEditor.php"},"region":{"startLine":88}}}],"partialFingerprints":{"codehealthFindingId/v1":"c19e865f32ad346df888199621b0dbd4c8469ce70031de5155bec2f8b478b992"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 13): src/applications/badges/mail/PhabricatorBadgesMailReceiver.php:16-21 | src/applications/calendar/mail/PhabricatorCalendarEventMailReceiver.php:16-21 | src/applications/conpherence/mail/ConpherenceThreadMailReceiver.php:16-21 | src/applications/countdown/mail/PhabricatorCountdownMailReceiver.php:16-21 | src/applications/files/mail/FileMailReceiver.php:15-20 | src/applications/macro/mail/PhabricatorMacroMailReceiver.php:15-20 | src/applications/paste/mail/PasteMailReceiver.php:15-20 | src/applications/phame/mail/PhamePostMailReceiver.php:16-21 | src/applications/pholio/mail/PholioMockMailReceiver.php:15-20 | src/applications/phurl/mail/PhabricatorPhurlURLMailReceiver.php:16-21 | src/applications/ponder/mail/PonderAnswerMailReceiver.php:15-20 | src/applications/ponder/mail/PonderQuestionMailReceiver.php:15-20 | src/applications/slowvote/mail/PhabricatorSlowvoteMailReceiver.php:16-21 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 13 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 13 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/mail/PhabricatorBadgesMailReceiver.php"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"483b79cf1c9ad29e9bbccd153cc0c4b1d7013b0a7809e228625a555eae33da54"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 14): src/applications/cache/garbagecollector/PhabricatorCacheGeneralGarbageCollector.php:17-27 | src/applications/cache/garbagecollector/PhabricatorCacheMarkupGarbageCollector.php:17-26 | src/applications/conduit/garbagecollector/ConduitLogGarbageCollector.php:17-27 | src/applications/daemon/garbagecollector/PhabricatorDaemonLockLogGarbageCollector.php:17-26 | src/applications/daemon/garbagecollector/PhabricatorDaemonLogEventGarbageCollector.php:17-26 | src/applications/daemon/garbagecollector/PhabricatorDaemonLogGarbageCollector.php:17-26 | src/applications/diffusion/garbagecollector/DiffusionPullEventGarbageCollector.php:17-26 | src/applications/herald/garbagecollector/HeraldTranscriptGarbageCollector.php:17-33 | src/applications/herald/garbagecollector/HeraldWebhookRequestGarbageCollector.php:17-26 | src/applications/metamta/garbagecollector/MetaMTAMailReceivedGarbageCollector.php:17-26 | src/applications/notification/garbagecollector/FeedStoryNotificationGarbageCollector.php:17-27 | src/applications/people/garbagecollector/PeopleUserLogGarbageCollector.php:17-26 | src/applications/system/garbagecollector/PhabricatorSystemActionGarbageCollector.php:17-26 | src/applications/system/garbagecollector/PhabricatorSystemDestructionGarbageCollector.php:17-26 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 14 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 14 times. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/cache/garbagecollector/PhabricatorCacheGeneralGarbageCollector.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"602fd67fcdc490112d742e8c101f2fa522039d17513c937fadc56f42a7e4dc49"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/cache/garbagecollector/PhabricatorCacheTTLGarbageCollector.php:17-27 | src/applications/conduit/garbagecollector/ConduitTokenGarbageCollector.php:17-27 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/cache/garbagecollector/PhabricatorCacheTTLGarbageCollector.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"310eb76e177e07f4274ddcad1e73e9a7d4c506cb7e1d364d23fa1efff515204b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 3): src/applications/calendar/phid/PhabricatorCalendarExternalInviteePHIDType.php:33-38 | src/applications/people/phid/PhabricatorPeopleExternalPHIDType.php:32-37 | src/applications/repository/phid/PhabricatorRepositoryRefCursorPHIDType.php:37-43 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/phid/PhabricatorCalendarExternalInviteePHIDType.php"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"a5daed48afdb8a879a9421c59c30eafe566ed7f57f754c0e211c4e57d7ce8c30"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 15): src/applications/calendar/remarkup/PhabricatorCalendarRemarkupRule.php:11-16 | src/applications/countdown/remarkup/PhabricatorCountdownRemarkupRule.php:11-15 | src/applications/dashboard/remarkup/PhabricatorDashboardRemarkupRule.php:13-18 | src/applications/differential/remarkup/DifferentialRemarkupRule.php:10-14 | src/applications/fund/remarkup/FundInitiativeRemarkupRule.php:10-15 | src/applications/harbormaster/remarkup/HarbormasterRemarkupRule.php:10-14 | src/applications/herald/remarkup/HeraldRemarkupRule.php:10-14 | src/applications/legalpad/remarkup/LegalpadDocumentRemarkupRule.php:10-15 | src/applications/maniphest/remarkup/ManiphestRemarkupRule.php:10-15 | src/applications/owners/remarkup/PhabricatorOwnersPackageRemarkupRule.php:11-16 | src/applications/passphrase/remarkup/PassphraseRemarkupRule.php:10-15 | src/applications/phame/remarkup/PhamePostRemarkupRule.php:11-16 | src/applications/phurl/remarkup/PhabricatorPhurlRemarkupRule.php:11-16 | src/applications/ponder/remarkup/PonderRemarkupRule.php:10-14 | src/applications/spaces/remarkup/PhabricatorSpacesRemarkupRule.php:11-15 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 15 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 15 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/remarkup/PhabricatorCalendarRemarkupRule.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"e48eac1cf0cd55bbcc6d9fea3e8e670f3217d8cff6d7727ee85a583780d096a6"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): src/applications/calendar/storage/PhabricatorCalendarEvent.php:1280-1294 | src/applications/project/storage/PhabricatorProject.php:189-203 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/storage/PhabricatorCalendarEvent.php"},"region":{"startLine":1280}}}],"partialFingerprints":{"codehealthFindingId/v1":"9ed8ef7a6cc6e4bbca8a835190aa3204915effc36d6963353ccab58522dc5fa6"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): src/applications/calendar/xaction/PhabricatorCalendarEventEndDateTransaction.php:9-14 | src/applications/calendar/xaction/PhabricatorCalendarEventStartDateTransaction.php:9-14 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/xaction/PhabricatorCalendarEventEndDateTransaction.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"264121f8ed699357307f16e61f4e0df320d35817101ac33367addb87019e8c08"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/applications/calendar/xaction/PhabricatorCalendarEventEndDateTransaction.php:18-24 | src/applications/calendar/xaction/PhabricatorCalendarEventStartDateTransaction.php:18-24 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/xaction/PhabricatorCalendarEventEndDateTransaction.php"},"region":{"startLine":18}}}],"partialFingerprints":{"codehealthFindingId/v1":"122eef9b3a6b734760ce13f4814d7bef9f9760924d06418c6fdc617d979b6525"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/applications/conduit/parametertype/ConduitProjectListParameterType.php:7-11 | src/applications/conduit/parametertype/ConduitUserListParameterType.php:7-11 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conduit/parametertype/ConduitProjectListParameterType.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"37f7f8ee3ce6e66beacdbda2fd8a29f45b78c444adb05414e4b0e50e32fd777c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 3): src/applications/config/type/PhabricatorBoolConfigType.php:39-46 | src/applications/config/type/PhabricatorIntConfigType.php:26-33 | src/applications/config/type/PhabricatorStringConfigType.php:12-19 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/type/PhabricatorBoolConfigType.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"677978dabf5ac470c2543b9c09243bc17aaa7beb3bdc8d4d4055989c1891a7b9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/applications/conpherence/controller/ConpherenceRoomListController.php:10-18 | src/applications/spaces/controller/PhabricatorSpacesListController.php:11-17 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceRoomListController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"473c90feb7e34674f99e36c685a479afbd400f47546f8d8c3bbd1ffec389a83b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/applications/dashboard/controller/PhabricatorDashboardListController.php:11-18 | src/applications/flag/controller/PhabricatorFlagListController.php:10-18 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/PhabricatorDashboardListController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"68f1888a0e20bdbc02876421442c9b660f53a0fb5746528658418b4a806ee34f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 10): src/applications/dashboard/controller/panel/PhabricatorDashboardPanelListController.php:13-19 | src/applications/fund/controller/FundInitiativeListController.php:11-18 | src/applications/herald/controller/HeraldRuleListController.php:10-17 | src/applications/legalpad/controller/LegalpadDocumentListController.php:10-17 | src/applications/macro/controller/PhabricatorMacroListController.php:10-17 | src/applications/notification/controller/PhabricatorNotificationListController.php:7-14 | src/applications/passphrase/controller/PassphraseCredentialListController.php:10-17 | src/applications/phame/controller/post/PhamePostListController.php:10-16 | src/applications/phriction/controller/PhrictionListController.php:11-18 | src/applications/ponder/controller/PonderQuestionListController.php:10-17 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 10 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 10 times. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/panel/PhabricatorDashboardPanelListController.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"0a76a7a35269bb89eb849743c125300a1347ada89eecc262fc80b4227c987a40"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/applications/dashboard/controller/portal/PhabricatorDashboardPortalViewController.php:43-50 | src/applications/phame/controller/post/PhamePostEditController.php:64-73 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/controller/portal/PhabricatorDashboardPortalViewController.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"738f1051c87e74162172bf4cfd9303502e5a291425581a840eda0fc72442a3fc"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 4): src/applications/dashboard/engine/PhabricatorDashboardFulltextEngine.php:10-20 | src/applications/dashboard/engine/PhabricatorDashboardPanelFulltextEngine.php:10-20 | src/applications/dashboard/engine/PhabricatorDashboardPortalFulltextEngine.php:10-20 | src/applications/people/search/PhabricatorUserFulltextEngine.php:10-20 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/engine/PhabricatorDashboardFulltextEngine.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"d3b9aeb77334729fb5cd863aa457c991d12ce4d5841aa78541057178589a1621"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/applications/differential/doorkeeper/DifferentialDoorkeeperRevisionFeedStoryPublisher.php:26-30 | src/applications/phortune/editor/PhortuneCartEditor.php:220-224 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/doorkeeper/DifferentialDoorkeeperRevisionFeedStoryPublisher.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"1f96df356e1997e4fc9036558a6fb1c17ed2cf3e88d4b37191cf2f5a9c01671c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/differential/editor/DifferentialRevisionEditEngine.php:330-340 | src/applications/diffusion/editor/DiffusionCommitEditEngine.php:128-138 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/editor/DifferentialRevisionEditEngine.php"},"region":{"startLine":330}}}],"partialFingerprints":{"codehealthFindingId/v1":"3bcf4758bc9c689334dadca2e2b3203874f9503927a3c1b9df8f828641757eb5"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): src/applications/differential/field/DifferentialTagsCommitMessageField.php:37-46 | src/applications/differential/field/DifferentialTasksCommitMessageField.php:37-46 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/field/DifferentialTagsCommitMessageField.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"4b4a8e7689eed8bfe4885751bf006de62ae7cc73dd7b9d778b7afb2164abed30"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 4): src/applications/differential/relationships/DifferentialRevisionRelationship.php:7-16 | src/applications/diffusion/relationships/DiffusionCommitRelationship.php:7-16 | src/applications/maniphest/relationship/ManiphestTaskRelationship.php:7-16 | src/applications/pholio/relationships/PholioMockRelationship.php:7-16 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 4 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/relationships/DifferentialRevisionRelationship.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"d3f1bbc6de1bfc95cdcca738ea332b82adc00434e7f5df893f54a515da972fcd"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/applications/differential/storage/DifferentialChangeset.php:179-186 | src/applications/differential/storage/DifferentialDiff.php:127-134 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialChangeset.php"},"region":{"startLine":179}}}],"partialFingerprints":{"codehealthFindingId/v1":"a5fda2fbf333393673bdcf77cd8827d4500bbf9bf76f93de0c291968180c1405"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/applications/differential/storage/DifferentialChangeset.php:439-445 | src/applications/differential/storage/DifferentialDiff.php:341-345 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialChangeset.php"},"region":{"startLine":439}}}],"partialFingerprints":{"codehealthFindingId/v1":"d1e2f92eda9e0a716f55f94ed5923299350947f19909e3fbf58e3156d2a67383"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 3): src/applications/diffusion/engineextension/DiffusionRepositoryURIsSearchEngineAttachment.php:19-31 | src/applications/project/engineextension/PhabricatorProjectsMembersSearchEngineAttachment.php:19-28 | src/applications/project/engineextension/PhabricatorProjectsWatchersSearchEngineAttachment.php:19-28 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/engineextension/DiffusionRepositoryURIsSearchEngineAttachment.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"d161dc962790b2101a2bedb3ad3419c252206adcc2156530f6346862680e6b08"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/applications/diffusion/herald/DiffusionCommitRevisionReviewersHeraldField.php:17-23 | src/applications/diffusion/herald/DiffusionPreCommitContentRevisionReviewersHeraldField.php:17-23 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/herald/DiffusionCommitRevisionReviewersHeraldField.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"554c4003a6396ccdceb67ddfa733f0dcc056375413b17126a93d792d0209444f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/applications/diffusion/herald/DiffusionCommitRevisionSubscribersHeraldField.php:17-24 | src/applications/diffusion/herald/DiffusionPreCommitContentRevisionSubscribersHeraldField.php:17-24 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/herald/DiffusionCommitRevisionSubscribersHeraldField.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"572427aced53192920884adb1aa82d877b1c4d26e493b5b01e2df8f0d921fcdb"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/applications/diffusion/query/DiffusionCommitQuery.php:924-932 | src/applications/owners/query/PhabricatorOwnersPackageQuery.php:247-255 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/DiffusionCommitQuery.php"},"region":{"startLine":924}}}],"partialFingerprints":{"codehealthFindingId/v1":"ee84af447cedf45c2b42e759dfc890e0f68e87549b788ed59df3364b477ffd08"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 3): src/applications/diffusion/query/DiffusionPullLogSearchEngine.php:178-183 | src/applications/diffusion/query/DiffusionSyncLogSearchEngine.php:146-151 | src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php:99-104 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/DiffusionPullLogSearchEngine.php"},"region":{"startLine":178}}}],"partialFingerprints":{"codehealthFindingId/v1":"73c7d84c3df83460c37456ea34c72ffef50e2c9b0c64dd30afd19645eab4880d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/applications/diviner/search/DivinerLiveBookFulltextEngine.php:10-22 | src/applications/ponder/search/PonderQuestionFulltextEngine.php:10-22 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/search/DivinerLiveBookFulltextEngine.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"dce302fa3af66eccd38a90d822f31dae91b76c4815b962c047245770a6822645"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubIssue.php:9-17 | src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubUser.php:9-17 \u2014 before extracting anything, compare \u0060src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubIssue.php\u0060 and \u0060src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubUser.php\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 92 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubIssue.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"52fcf4b9f6723a9252fbd6743ac5dcd2f3e5222655e6a61f61508a78ba64a4ca"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/applications/doorkeeper/worker/DoorkeeperAsanaFeedWorker.php:457-465 | src/applications/doorkeeper/worker/DoorkeeperJIRAFeedWorker.php:133-141 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/worker/DoorkeeperAsanaFeedWorker.php"},"region":{"startLine":457}}}],"partialFingerprints":{"codehealthFindingId/v1":"3a6113c65e8a368c4f57e71f74ddcabe8c2fe9047c48e0974361ad1d53ae8765"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): src/applications/drydock/phid/DrydockBlueprintPHIDType.php:36-45 | src/applications/harbormaster/phid/HarbormasterBuildStepPHIDType.php:32-42 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/phid/DrydockBlueprintPHIDType.php"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"3e4f29d2cbaeaad1b8e1ffec39e7bd914e41753795ecdeb01246e605fecb31f5"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/applications/drydock/query/DrydockAuthorizationSearchEngine.php:30-37 | src/applications/drydock/query/DrydockResourceSearchEngine.php:26-33 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/query/DrydockAuthorizationSearchEngine.php"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"07781615e1ad76a36bdd36fb7d2e7d2856682d0082b375244d95c27b5223f304"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 3): src/applications/drydock/query/DrydockAuthorizationSearchEngine.php:110-117 | src/applications/drydock/query/DrydockLogSearchEngine.php:149-156 | src/applications/drydock/query/DrydockResourceSearchEngine.php:106-113 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/query/DrydockAuthorizationSearchEngine.php"},"region":{"startLine":110}}}],"partialFingerprints":{"codehealthFindingId/v1":"6c6d2289897ca959769b143d0675d32c0c601984148f524590c7b317c54822cf"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 3): src/applications/files/editor/PhabricatorFileEditor.php:57-63 | src/applications/herald/editor/HeraldRuleEditor.php:74-80 | src/applications/phame/editor/PhameBlogEditor.php:68-74 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/editor/PhabricatorFileEditor.php"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"91b698eea7f608721f6fbe6ecddba97a30015492467de66949c9b7c39c1d1fdf"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/applications/files/garbagecollector/PhabricatorFileExternalRequestGarbageCollector.php:17-25 | src/applications/files/garbagecollector/PhabricatorFileTemporaryGarbageCollector.php:17-27 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/garbagecollector/PhabricatorFileExternalRequestGarbageCollector.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"28ee4fa59bc5f335aa424f6a0a775451f71fb6ea18f94c2507010651fc5056ce"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 3): src/applications/fund/controller/FundInitiativeViewController.php:169-175 | src/applications/legalpad/controller/LegalpadDocumentManageController.php:184-190 | src/applications/phurl/controller/PhabricatorPhurlURLViewController.php:66-72 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fund/controller/FundInitiativeViewController.php"},"region":{"startLine":169}}}],"partialFingerprints":{"codehealthFindingId/v1":"bdf9a8a29aa073eaad153e985357867c86682f9eeb8faaf3f5c783c1f5afd4bd"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 3): src/applications/harbormaster/constants/HarbormasterBuildStatus.php:274-286 | src/applications/harbormaster/constants/HarbormasterBuildableStatus.php:96-106 | src/applications/herald/storage/HeraldWebhook.php:91-102 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/constants/HarbormasterBuildStatus.php"},"region":{"startLine":274}}}],"partialFingerprints":{"codehealthFindingId/v1":"2660c2c6e088fed5cb7e0b1e4ac0e993540dd573d9f38cab1544aebad8c56118"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 3): src/applications/harbormaster/query/HarbormasterBuildPlanSearchEngine.php:37-47 | src/applications/packages/query/PhabricatorPackagesPackageSearchEngine.php:23-33 | src/applications/packages/query/PhabricatorPackagesVersionSearchEngine.php:23-33 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/query/HarbormasterBuildPlanSearchEngine.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"c2111c1637581bf6b9822e2c2fe6a602cfb30b49b54aef482fe073efb87ce9ef"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/applications/harbormaster/worker/HarbormasterBuildWorker.php:9-15 | src/applications/harbormaster/worker/HarbormasterTargetWorker.php:15-21 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/worker/HarbormasterBuildWorker.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"b79ddd32db5cd1480a12e9a91ac041b98e5b623ac77ff57a837d6eb7f9f8d43f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 4): src/applications/herald/query/HeraldRuleQuery.php:277-288 | src/applications/phortune/query/PhortuneAccountQuery.php:113-123 | src/applications/phortune/query/PhortuneMerchantQuery.php:107-117 | src/applications/search/query/PhabricatorProfileMenuItemConfigurationQuery.php:96-107 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 4 times. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/query/HeraldRuleQuery.php"},"region":{"startLine":277}}}],"partialFingerprints":{"codehealthFindingId/v1":"cb1bf19150af26fdbc21452e46fb31cb5075ccd5ff8527a9e754bb52caebf7f9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/applications/legalpad/herald/LegalpadRequireSignatureHeraldAction.php:94-105 | src/applications/project/herald/PhabricatorProjectHeraldAction.php:111-122 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/legalpad/herald/LegalpadRequireSignatureHeraldAction.php"},"region":{"startLine":94}}}],"partialFingerprints":{"codehealthFindingId/v1":"9ac10baace5bc8feeb24a2a2070287e0311d3484640bd60fcaefa96b61d2b121"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/applications/maniphest/storage/ManiphestTask.php:348-356 | src/applications/phurl/storage/PhabricatorPhurlURL.php:138-146 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/storage/ManiphestTask.php"},"region":{"startLine":348}}}],"partialFingerprints":{"codehealthFindingId/v1":"846c7eeba12f18d3ac66c21897046c7c3dd8cb291b76fa2ed51bfbaebca323ae"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): src/applications/metamta/editor/PhabricatorMetaMTAApplicationEmailEditor.php:43-49 | src/applications/phlux/editor/PhluxVariableEditor.php:39-44 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/editor/PhabricatorMetaMTAApplicationEmailEditor.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"c7c5810413c23975771d01fb111262fb5a457f06264a9693e5575c4e6fe08a1b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/applications/metamta/herald/PhabricatorMailOutboundRoutingSelfEmailHeraldAction.php:17-23 | src/applications/metamta/herald/PhabricatorMailOutboundRoutingSelfNotificationHeraldAction.php:17-23 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/herald/PhabricatorMailOutboundRoutingSelfEmailHeraldAction.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"e18b20bff6bc0448192b3fe1e2f9e083acc0916288df87f36d0d18ca711f1cb1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/applications/metamta/query/PhabricatorMetaMTAMailSearchEngine.php:90-94 | src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:3678-3684 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/query/PhabricatorMetaMTAMailSearchEngine.php"},"region":{"startLine":90}}}],"partialFingerprints":{"codehealthFindingId/v1":"9b584cdafd2c87f6123faa1356d88da854cc9943b6a3b4291000b9d65e3466f2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 3): src/applications/nuance/worker/NuanceWorker.php:10-22 | src/applications/tokens/editor/PhabricatorTokenGivenEditor.php:147-156 | src/applications/tokens/editor/PhabricatorTokenGivenEditor.php:160-169 \u2014 there are 3 copies across 2 file(s) \u2014 more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/worker/NuanceWorker.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"597f3a395ee81c56ec7b4063c4440ef833c7bfabfdaa9d878d9e8d5cc54ebcb3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): src/applications/packages/editor/PhabricatorPackagesPublisherEditor.php:33-42 | src/applications/phortune/editor/PhortuneAccountEmailEditor.php:23-33 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/packages/editor/PhabricatorPackagesPublisherEditor.php"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"9f901e69a8d8dff44e9a575770ae9b6426358c38a46a48214a99404e1bbf24fd"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): src/applications/people/controller/PhabricatorPeopleInviteListController.php:16-25 | src/applications/people/controller/PhabricatorPeopleLogsController.php:16-25 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/controller/PhabricatorPeopleInviteListController.php"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"c25733025b3345e2661f3d96319011f45c918b7672021867f2b389541386c2d0"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 3): src/applications/pholio/xaction/PholioImageDescriptionTransaction.php:9-16 | src/applications/pholio/xaction/PholioImageNameTransaction.php:9-16 | src/applications/pholio/xaction/PholioImageSequenceTransaction.php:9-16 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/pholio/xaction/PholioImageDescriptionTransaction.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"893a30c10c4aa0686998cc0499042b69ae9f74b5194b8ca7e81380e713a880d4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): src/applications/pholio/xaction/PholioImageDescriptionTransaction.php:27-32 | src/applications/pholio/xaction/PholioImageSequenceTransaction.php:27-32 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/pholio/xaction/PholioImageDescriptionTransaction.php"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"b361fe7bd42160f6e6f62ef4e50dc80b6573a4971c97e5877bb8650d0c853a3f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/applications/phortune/controller/account/PhortuneAccountController.php:10-20 | src/applications/phortune/controller/merchant/PhortuneMerchantController.php:22-32 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountController.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"d49160325b1c1ba083f84c8977e75be487bef424064aba7c90e4fe97a456586a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/applications/phortune/query/PhortuneCartSearchEngine.php:105-113 | src/applications/phortune/query/PhortuneSubscriptionSearchEngine.php:96-104 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/query/PhortuneCartSearchEngine.php"},"region":{"startLine":105}}}],"partialFingerprints":{"codehealthFindingId/v1":"1851350c4aefb19659cf02946db34612ef5f1257d20c5f86a558fefbeda2e861"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/applications/project/engineextension/PhabricatorProjectsMailEngineExtension.php:21-29 | src/applications/subscriptions/engineextension/PhabricatorSubscriptionsMailEngineExtension.php:21-29 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/engineextension/PhabricatorProjectsMailEngineExtension.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"c705ad00ab6017a32dbbf14e56630e9c40e6624ff2942fc392a850ad65d9a749"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/applications/project/herald/PhabricatorProjectTagsAddedField.php:13-20 | src/applications/project/herald/PhabricatorProjectTagsRemovedField.php:13-20 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/herald/PhabricatorProjectTagsAddedField.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"71c157ea89a38e5acf6940d6c0bb08912e4bc0506e62c0c57c1fa7aceb709a45"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/applications/project/order/PhabricatorProjectColumnOwnerOrder.php:185-196 | src/applications/project/order/PhabricatorProjectColumnStatusOrder.php:102-113 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/order/PhabricatorProjectColumnOwnerOrder.php"},"region":{"startLine":185}}}],"partialFingerprints":{"codehealthFindingId/v1":"8ec6eac64ada8061549c0ec4a185b63ccbc36ff587ec239786f626a599503d1e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/applications/search/menuitem/PhabricatorEditEngineProfileMenuItem.php:70-76 | src/applications/search/menuitem/PhabricatorProjectProfileMenuItem.php:61-67 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/menuitem/PhabricatorEditEngineProfileMenuItem.php"},"region":{"startLine":70}}}],"partialFingerprints":{"codehealthFindingId/v1":"2d62412fbdad86bba5a42cf8fc89c069db9cd6c1a1575d1878abf606c41fecb8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 3): src/applications/slowvote/constants/SlowvotePollResponseVisibility.php:23-30 | src/applications/slowvote/constants/SlowvotePollStatus.php:22-29 | src/applications/slowvote/constants/SlowvotePollVotingMethod.php:22-29 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/slowvote/constants/SlowvotePollResponseVisibility.php"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"b9443528105c8c8be28218808ad7493e2783aa9cd02a25d9e4a1fe21776ef9f9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 3): src/applications/slowvote/xaction/PhabricatorSlowvoteResponsesTransaction.php:21-28 | src/applications/slowvote/xaction/PhabricatorSlowvoteStatusTransaction.php:21-28 | src/applications/slowvote/xaction/PhabricatorSlowvoteVotingMethodTransaction.php:21-28 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/slowvote/xaction/PhabricatorSlowvoteResponsesTransaction.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"7cc512ac7483f170186aed0e835ce41152aa5a2e953693846cf946921e955398"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 3): src/applications/slowvote/xaction/PhabricatorSlowvoteResponsesTransaction.php:32-40 | src/applications/slowvote/xaction/PhabricatorSlowvoteStatusTransaction.php:32-41 | src/applications/slowvote/xaction/PhabricatorSlowvoteVotingMethodTransaction.php:32-40 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/slowvote/xaction/PhabricatorSlowvoteResponsesTransaction.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"e376686d755ee723df0f5df5838ca90d1619fff6fa705d8edd03638d0f2fffaa"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/applications/transactions/editfield/PhabricatorEditField.php:510-517 | src/infrastructure/customfield/editor/PhabricatorCustomFieldEditField.php:168-182 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editfield/PhabricatorEditField.php"},"region":{"startLine":510}}}],"partialFingerprints":{"codehealthFindingId/v1":"b9b842eb3e52f7d2f0c1712c530b95c5aed76d41bdc81b050813851dd10e52e4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/applications/transactions/view/PhabricatorApplicationEditHTTPParameterHelpView.php:315-323 | src/view/form/AphrontFormView.php:92-100 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/view/PhabricatorApplicationEditHTTPParameterHelpView.php"},"region":{"startLine":315}}}],"partialFingerprints":{"codehealthFindingId/v1":"afaa922d6640901de8474d7983ea78fff25267f29b427ffe2b11e66911bf976a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): src/applications/transactions/view/PhabricatorApplicationTransactionView.php:354-359 | src/infrastructure/cluster/PhabricatorDatabaseRef.php:651-656 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/view/PhabricatorApplicationTransactionView.php"},"region":{"startLine":354}}}],"partialFingerprints":{"codehealthFindingId/v1":"978b0daf975e9e02ddfa151505a4c4333ce23cc58e8617c4733269e3b0a77356"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/infrastructure/customfield/datasource/PhabricatorCustomFieldApplicationSearchAnyFunctionDatasource.php:39-47 | src/infrastructure/customfield/datasource/PhabricatorCustomFieldApplicationSearchNoneFunctionDatasource.php:41-49 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/customfield/datasource/PhabricatorCustomFieldApplicationSearchAnyFunctionDatasource.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"34b81fe92270c55fca8008a877ebac8adb7d97af3ab8c5bb154817e8f5b9c520"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): src/infrastructure/customfield/engineextension/PhabricatorCustomFieldSearchEngineExtension.php:56-61 | src/infrastructure/export/engine/PhabricatorCustomFieldExportEngineExtension.php:78-83 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/customfield/engineextension/PhabricatorCustomFieldSearchEngineExtension.php"},"region":{"startLine":56}}}],"partialFingerprints":{"codehealthFindingId/v1":"e3427078558df7aeb07075c1d067ea3655c9cd2cfa160ab23835894685025e12"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (4 members, 50\u002B identical tokens): src/applications/uiexample/examples/PHUIBoxExample.php:15-120 | src/applications/uiexample/examples/PHUIButtonExample.php:16-225 | src/applications/uiexample/examples/PHUILeftRightExample.php:14-70 | src/applications/uiexample/examples/PHUIListExample.php:16-298 \u2014 These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/uiexample/examples/PHUIBoxExample.php"},"region":{"startLine":15}}}],"partialFingerprints":{"codehealthFindingId/v1":"ddff1b96c000e5b9f9142b98c6054b8faf1cf13581c5c6affadd33cf036eb87c"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (21 corresponding lines): src/applications/badges/lipsum/PhabricatorBadgesAwardTestDataGenerator.php:13-33 | src/applications/badges/lipsum/PhabricatorBadgesBadgeTestDataGenerator.php:13-47 \u2014 These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/lipsum/PhabricatorBadgesAwardTestDataGenerator.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"d3559ee342a6d6e5eeeb289d97f5de33a739cbdc4e16c66485dbcc02b8fafb67"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (31 lines \u00D7 2): src/applications/badges/lipsum/PhabricatorBadgesBadgeTestDataGenerator.php:17-47 | src/applications/conpherence/lipsum/PhabricatorConpherenceRoomTestDataGenerator.php:35-65 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/lipsum/PhabricatorBadgesBadgeTestDataGenerator.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"fb8913b6493ab0333aaccfe71ad0b7afed8baa1bb89b7c4e07cc3da4283137af"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (26\u201328 lines \u00D7 2): src/applications/uiexample/examples/PHUIBoxExample.php:95-120 | src/applications/uiexample/examples/PHUIListExample.php:271-298 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/uiexample/examples/PHUIBoxExample.php"},"region":{"startLine":95}}}],"partialFingerprints":{"codehealthFindingId/v1":"2e45adbe9f94739b52384a1fe2b67edfbb1e792a9552432277382806b7e60825"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11\u201319 lines \u00D7 4): src/applications/uiexample/examples/PHUIBoxExample.php:94-104 | src/applications/uiexample/examples/PHUIButtonExample.php:200-214 | src/applications/uiexample/examples/PHUILeftRightExample.php:51-61 | src/applications/uiexample/examples/PHUIListExample.php:262-280 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 4 call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/uiexample/examples/PHUIBoxExample.php"},"region":{"startLine":94}}}],"partialFingerprints":{"codehealthFindingId/v1":"12b467dbf48831d064f2f9f1a516b6bd199de19d30fefc0786309d1813a7413c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19 lines \u00D7 2): src/applications/herald/controller/HeraldTestConsoleController.php:133-151 | src/applications/herald/management/HeraldTestManagementWorkflow.php:50-68 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/controller/HeraldTestConsoleController.php"},"region":{"startLine":133}}}],"partialFingerprints":{"codehealthFindingId/v1":"edb721c2a760046694b9abf5b697866b6d1f8d1b72a537278e7552597753a5ed"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): src/applications/herald/controller/HeraldTestConsoleController.php:54-69 | src/applications/herald/management/HeraldTestManagementWorkflow.php:111-126 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/controller/HeraldTestConsoleController.php"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"b27e1b7000aa04775110eb0212cb567add54f549858a312bebad0cfb94812362"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12\u201313 lines \u00D7 3): src/applications/uiexample/examples/PHUIListExample.php:65-77 | src/applications/uiexample/examples/PHUIListExample.php:136-147 | src/applications/uiexample/examples/PHUIListExample.php:168-179 \u2014 all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/uiexample/examples/PHUIListExample.php:164\u0060 calls \u0060setHref\u0060, \u0060setSelected\u0060 and \u0060src/applications/uiexample/examples/PHUIListExample.php:62\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/uiexample/examples/PHUIListExample.php"},"region":{"startLine":65}}}],"partialFingerprints":{"codehealthFindingId/v1":"5a859259b28e4d0b187e42d2d847a08627441af4634ebe7668f42fae2582cd4f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7\u201310 lines \u00D7 5): src/applications/uiexample/examples/PHUIListExample.php:68-77 | src/applications/uiexample/examples/PHUIListExample.php:134-143 | src/applications/uiexample/examples/PHUIListExample.php:148-154 | src/applications/uiexample/examples/PHUIListExample.php:155-164 | src/applications/uiexample/examples/PHUIListExample.php:166-175 \u2014 all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/applications/uiexample/examples/PHUIListExample.php:133\u0060 calls \u0060setSelected\u0060 and \u0060src/applications/uiexample/examples/PHUIListExample.php:67\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/uiexample/examples/PHUIListExample.php"},"region":{"startLine":68}}}],"partialFingerprints":{"codehealthFindingId/v1":"dab026bfdbce5114171c473cd915d64dfe6f89a57eb55b195a167b8e18887b24"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 3): src/applications/differential/lipsum/PhabricatorDifferentialRevisionTestDataGenerator.php:42-46 | src/applications/maniphest/lipsum/PhabricatorManiphestTaskTestDataGenerator.php:65-69 | src/applications/pholio/lipsum/PhabricatorPholioMockTestDataGenerator.php:87-91 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/lipsum/PhabricatorDifferentialRevisionTestDataGenerator.php"},"region":{"startLine":42}}}],"partialFingerprints":{"codehealthFindingId/v1":"fe07fa23ee2828f2c2adf34b831f443684028ff1ba077d22cd80ab5cd0708424"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: DifferentialChangesetRenderer (LCOM4 25): DifferentialChangesetRenderer\u0027s methods fall into 25 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 25 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetRenderer.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"24cf7a7f2bf32bb3cff80c07e9575f901e0107314890262607f4cc24ff416ba1"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorUser (LCOM4 23): PhabricatorUser\u0027s methods fall into 23 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 23 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/storage/PhabricatorUser.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"2fceddd748a715a34b3ee2848d8b03e4d7dec4532367569632649ac6b034e1c2"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: HeraldAdapter (LCOM4 17): HeraldAdapter\u0027s methods fall into 17 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 17 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/adapter/HeraldAdapter.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"bf4dd308ab9ce51c1cea94bc38ea8a40f9c3750f1ffa1f3e9217aee5a3c0f87a"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: DifferentialTransactionEditor (LCOM4 16): DifferentialTransactionEditor\u0027s methods fall into 16 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 16 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/editor/DifferentialTransactionEditor.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"cfbe393b7f86f5c0af0f3c33b1322cc9aa9c7dba109b7dd05e8711c69fa54a9d"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorSetupIssue (LCOM4 15): PhabricatorSetupIssue\u0027s methods fall into 15 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 15 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/issue/PhabricatorSetupIssue.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"4b2081108d64fae4fe0008705d41dd240273917018d5297cba9f55b1c11217af"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: DifferentialChangeset (LCOM4 15): DifferentialChangeset\u0027s methods fall into 15 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 15 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialChangeset.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"f8cd5981d2cd73ca0aec2d4f67f6380d87c00a22d5eb2606df051d354d84c87c"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorRepository (LCOM4 15): PhabricatorRepository\u0027s methods fall into 15 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 15 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepository.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"4060876246a2034d03863173330c89c0084dc8b8f480a0d689a9ac81017c845e"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorDatabaseRef (LCOM4 14): PhabricatorDatabaseRef\u0027s methods fall into 14 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 14 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/cluster/PhabricatorDatabaseRef.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"e73fc9583e4d872b5ed8a285adf54d8e15db7884135432fb9ca7774747767710"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: AphrontCalendarEventView (LCOM4 13): AphrontCalendarEventView\u0027s methods fall into 13 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 13 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/view/AphrontCalendarEventView.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"4a881c5a2453fe4690dc39f4cad0e6aba4fc4dd7067a4c6ecf64b0449de10d26"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: HeraldRule (LCOM4 13): HeraldRule\u0027s methods fall into 13 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 13 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/storage/HeraldRule.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"c71f11b3320608f49dd70cad45b902adf28e716ba7ddab3a81303e07c95ab90b"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: ManiphestTransactionEditor (LCOM4 13): ManiphestTransactionEditor\u0027s methods fall into 13 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 13 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/editor/ManiphestTransactionEditor.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"a539390d20ddb6e4904ef0c1c50e7fb8106894953761e2e9d9b8a190d96930ae"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorAuthSessionEngine (LCOM4 12): PhabricatorAuthSessionEngine\u0027s methods fall into 12 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 12 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/engine/PhabricatorAuthSessionEngine.php"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"379d9c7c35f35f358ffcd6973ad27d7a1afc0b3b4ec1ae3ed32b5d181f730d00"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhutilCalendarEventNode (LCOM4 12): PhutilCalendarEventNode\u0027s methods fall into 12 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 12 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/data/PhutilCalendarEventNode.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"89a6995124bfb19fe70086aefb8f9041ed6bb99cda448a63cb326dfbf3961b78"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: HarbormasterBuildTarget (LCOM4 12): HarbormasterBuildTarget\u0027s methods fall into 12 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 12 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/storage/build/HarbormasterBuildTarget.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"22cd20cf72f0eea93eec4f3fd1fe82ee55131aea01128cbd8ac8265c9c18ee1a"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorEditField (LCOM4 12): PhabricatorEditField\u0027s methods fall into 12 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 12 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editfield/PhabricatorEditField.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"d1f770f6ac35fe901327fde505fecea427d5cccae9380c95d51af4a4bf787b3f"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorConfigOption (LCOM4 11): PhabricatorConfigOption\u0027s methods fall into 11 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 11 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/option/PhabricatorConfigOption.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"e13f855d81824ba4edfc1b310ad413ab4cb7fe7b95127c747680bbcbf73fe9ee"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: ManiphestTaskSearchEngine (LCOM4 11): ManiphestTaskSearchEngine\u0027s methods fall into 11 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 11 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/query/ManiphestTaskSearchEngine.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"e71e6738174113243045224374c00f36e5309900dae497bd6cbcab82b2f03faf"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhameBlog (LCOM4 11): PhameBlog\u0027s methods fall into 11 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 11 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/storage/PhameBlog.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"77823e0d1580657148c3d88291ab342c851235985b96eb87eb2d73901a71a701"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: DivinerLiveSymbol (LCOM4 10): DivinerLiveSymbol\u0027s methods fall into 10 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 10 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/storage/DivinerLiveSymbol.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"247ef0a741371893de9f03910906c183632862817ee7599c0d24f4df8af5a50b"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorApplicationTransaction (LCOM4 10): PhabricatorApplicationTransaction\u0027s methods fall into 10 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 10 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorApplicationTransaction.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"f7f5f68baa4d30ac7e7c8fb9758401a6553e32e20f04a83e89016237f6fafabb"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: DifferentialDiff (LCOM4 9): DifferentialDiff\u0027s methods fall into 9 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 9 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialDiff.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"1f92c094dbf2119645491fb5edc888bb17daf0de70a90209e777bb628c68b92f"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: LegalpadDocument (LCOM4 9): LegalpadDocument\u0027s methods fall into 9 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 9 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/legalpad/storage/LegalpadDocument.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"5ee5a54822d8ccafeee9b0b52bf1ef7ee294989256672c951ae9f3b5e6c6f843"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorTypeaheadDatasource (LCOM4 9): PhabricatorTypeaheadDatasource\u0027s methods fall into 9 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 9 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"5e3ec199c22133dde48b5ccae3b841ac6d88aeaf902751c143fc0bb6ebeae9cf"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorCacheSpec (LCOM4 8): PhabricatorCacheSpec\u0027s methods fall into 8 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 8 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/cache/spec/PhabricatorCacheSpec.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"813c7592843e6fd8e93483976b2f4d7e5a838bfbb3614cf94ade0bde94bb4d76"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: DifferentialReviewer (LCOM4 8): DifferentialReviewer\u0027s methods fall into 8 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 8 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialReviewer.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"9cf6ba609cd7712d4be517cfe040ec9c3c1f08b77be8fcf7d5fb5014ceca7a87"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorDocumentEngine (LCOM4 8): PhabricatorDocumentEngine\u0027s methods fall into 8 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 8 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/document/PhabricatorDocumentEngine.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"50a9507dde5635793b5ad021d3f3eae1e3050639593dc233cff072aad138e054"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: HarbormasterBuildLog (LCOM4 8): HarbormasterBuildLog\u0027s methods fall into 8 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 8 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/storage/build/HarbormasterBuildLog.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"fcb6e273e7e0aa13f4fd666e83b265ed91d2fae4cf70d935765a7ab496afee44"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorProfileMenuEditEngine (LCOM4 8): PhabricatorProfileMenuEditEngine\u0027s methods fall into 8 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 8 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/editor/PhabricatorProfileMenuEditEngine.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"bc10c8e74bab64857759bc2ea2bb94d2e98990493e0ef65d19309c5c86262e5f"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorApplicationSearchEngine (LCOM4 8): PhabricatorApplicationSearchEngine\u0027s methods fall into 8 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 8 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorApplicationSearchEngine.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"c180f1c3f01fc25a061ededab5a21278b92fe1ffc59eda8cc4d3428ca511b19b"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorProfileMenuItemConfiguration (LCOM4 8): PhabricatorProfileMenuItemConfiguration\u0027s methods fall into 8 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 8 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/storage/PhabricatorProfileMenuItemConfiguration.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"5b8bb49b82232a585908982c44dd26f8eee4933384fb9dfff039b01414527afc"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorSettingsEditEngine (LCOM4 8): PhabricatorSettingsEditEngine\u0027s methods fall into 8 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 8 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/settings/editor/PhabricatorSettingsEditEngine.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"f9ff524af582b4635527e202fa69632057a10933e299c8e9907d16cbab59f80f"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorApplicationTransactionComment (LCOM4 8): PhabricatorApplicationTransactionComment\u0027s methods fall into 8 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 8 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorApplicationTransactionComment.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"f39fd9ea59b5226932ff0ce146d042e1b131bef82c222e20d9ba01db67317ca0"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: AphrontRequest (LCOM4 7): AphrontRequest\u0027s methods fall into 7 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 7 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/AphrontRequest.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"d1fccfb188a9c45041c45fc1750bb030723a3646faab393171ec684c3351b4a3"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: DrydockBlueprint (LCOM4 7): DrydockBlueprint\u0027s methods fall into 7 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 7 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/storage/DrydockBlueprint.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"7734e0d25866d8303d567af27b1cd149fb3ac3467a76c5b42c25bef2723107c2"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: HarbormasterBuild (LCOM4 7): HarbormasterBuild\u0027s methods fall into 7 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 7 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/storage/build/HarbormasterBuild.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"4cb6d135cec9e88ebe63d407be5e9020d4e70169bd0db3c97ab0e10a4282418f"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: ManiphestTaskQuery (LCOM4 7): ManiphestTaskQuery\u0027s methods fall into 7 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 7 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/query/ManiphestTaskQuery.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"79130eae1fb6c667354701ed9738d7f722da0415a43a410f4d4b015d9ed2a540"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorMailAdapter (LCOM4 7): PhabricatorMailAdapter\u0027s methods fall into 7 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 7 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/adapter/PhabricatorMailAdapter.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"d5423faa4592c0d30899af5989253f8fda07cabf486a56e800de3636f4f1f5c7"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorExternalAccount (LCOM4 7): PhabricatorExternalAccount\u0027s methods fall into 7 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 7 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/storage/PhabricatorExternalAccount.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"47a6511c10eacb5c7529da8beaff4bee591e7ccc1245d7e418a7f597d69e5a71"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhortuneCart (LCOM4 7): PhortuneCart\u0027s methods fall into 7 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 7 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/storage/PhortuneCart.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"97f800a54144f52bbed50dcc500d603f4d2f73e5d3e2ab7201c6a0396659f6ae"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorPolicy (LCOM4 7): PhabricatorPolicy\u0027s methods fall into 7 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 7 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/storage/PhabricatorPolicy.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"fdeb76c11f9506fab07a0e71040aa01737c1192ddce8eb2c4e97f7bb8cdbad3a"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorApplicationSearchResultView (LCOM4 7): PhabricatorApplicationSearchResultView\u0027s methods fall into 7 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 7 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/view/PhabricatorApplicationSearchResultView.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"d41b2005bc1f407ecb41246f76e656e4db9da0cfe2d0bf4199ccfb7f4389db1b"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorEditEngineSubtype (LCOM4 7): PhabricatorEditEngineSubtype\u0027s methods fall into 7 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 7 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editengine/PhabricatorEditEngineSubtype.php"},"region":{"startLine":4}}}],"partialFingerprints":{"codehealthFindingId/v1":"8d14ca6d8f26493f26c2d72494d1e196e332f9ba3d8f17fc9f3b453b4d95ca8f"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorSSHWorkflow (LCOM4 7): PhabricatorSSHWorkflow\u0027s methods fall into 7 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 7 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/ssh/PhabricatorSSHWorkflow.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"7b8f513abf589bd807203b4f3c9b3f8997747d304cf655a8fde7230a1be4db4a"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorCalendarImport (LCOM4 6): PhabricatorCalendarImport\u0027s methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/storage/PhabricatorCalendarImport.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"8c1a7a275673b16737f0b66fcadc5775a796f777b347880c7a57d2d2fb073e7d"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: DifferentialActionEmailCommand (LCOM4 6): DifferentialActionEmailCommand\u0027s methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/command/DifferentialActionEmailCommand.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"00a24ce9c68f004e349a7ba6ae1bada18036f481eb71904252a24aab3c491845"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: DifferentialCommitMessageField (LCOM4 6): DifferentialCommitMessageField\u0027s methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/field/DifferentialCommitMessageField.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"bdc31e2b3d14da7abb3076db9f36436ba95910ce45cb4cf6b64b99a808f88b86"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: DifferentialTransactionComment (LCOM4 6): DifferentialTransactionComment\u0027s methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialTransactionComment.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"ca62b39bd21937f051729955c071a344f0c240091a324fb2fbeb0fe80ac289ab"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: DivinerPublisher (LCOM4 6): DivinerPublisher\u0027s methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/publisher/DivinerPublisher.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"43a603b3b50428960ee140fc8cb32c1bce77e66805fcb7058919ac013c41270b"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: DrydockRepositoryOperation (LCOM4 6): DrydockRepositoryOperation\u0027s methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/storage/DrydockRepositoryOperation.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"230d98a9ae817fc58dee11e0ec5beb0b2ff31084c61e868d65fe495ea04bd297"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: HarbormasterBuildUnitMessage (LCOM4 6): HarbormasterBuildUnitMessage\u0027s methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/storage/build/HarbormasterBuildUnitMessage.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"d9c57d1e41ffc792a338dc84eb6f7da914f757f6b899eb3f774150a4f6782527"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: HeraldConditionTranscript (LCOM4 6): HeraldConditionTranscript\u0027s methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/storage/transcript/HeraldConditionTranscript.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"60b995050935915726083f9f9b2f876915fb9963b9b7f41f57d1e6f9d589cf90"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhrictionTransactionEditor (LCOM4 6): PhrictionTransactionEditor\u0027s methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/editor/PhrictionTransactionEditor.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"962eb1e52b142c60001e015cb88359044305ad48b9f5bcb147527357fbfb4df6"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorCustomFieldEditField (LCOM4 6): PhabricatorCustomFieldEditField\u0027s methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/customfield/editor/PhabricatorCustomFieldEditField.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"8d318efc86cebe501c3cdf377a8aea0aff57e45a4ccf1fd75d30b5df6817b8cd"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: AphrontDatabaseConnection (LCOM4 6): AphrontDatabaseConnection\u0027s methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/connection/AphrontDatabaseConnection.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"8495686442b58481c5d73810d0388d9eeaa6e2ef0302f0d80b65d396e6754434"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: AphrontResponse (LCOM4 5): AphrontResponse\u0027s methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/response/AphrontResponse.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"25e80d7d6db384cf06b8b7a5792357f85f3cf0abc823bbb1dff5e848ee6cde24"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhutilSprite (LCOM4 5): PhutilSprite\u0027s methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/sprite/PhutilSprite.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"f5468e6db6eb9aca18977e40e298e257304ec2d19d9fe2612075f3b36591660b"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorAuthFactorConfig (LCOM4 5): PhabricatorAuthFactorConfig\u0027s methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/storage/PhabricatorAuthFactorConfig.php"},"region":{"startLine":4}}}],"partialFingerprints":{"codehealthFindingId/v1":"b59f04318af222132269863460a82b89b2e22ee1ec32029ddc8e99b840ed2f73"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: DifferentialDiffEditor (LCOM4 5): DifferentialDiffEditor\u0027s methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/editor/DifferentialDiffEditor.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"a957f27940c060df89927c5809c615bab53d9eb7ed3f251f3652d1ba7a18b92f"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: DiffusionSSHWorkflow (LCOM4 5): DiffusionSSHWorkflow\u0027s methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/ssh/DiffusionSSHWorkflow.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"bfffdd5ea4173bc87bcedd9336eff7ab80e0f25d5d71280de232e092602f7629"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: DoorkeeperObjectRef (LCOM4 5): DoorkeeperObjectRef\u0027s methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/engine/DoorkeeperObjectRef.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"9c4bdc9a0448e4deeea49c8b5d7cf363468c07076d33466bf9e2bac246470fb3"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorFileAttachment (LCOM4 5): PhabricatorFileAttachment\u0027s methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/storage/PhabricatorFileAttachment.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"75b412fa1761a6cee12308caf87dd56b0a2b346b5a542bae86fe8b517aec16f2"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: HeraldTranscript (LCOM4 5): HeraldTranscript\u0027s methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/storage/transcript/HeraldTranscript.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"791cc05f15d53ed6ebeb6b2b1eecd976820f7b3dc2d94afef883203ce3943132"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorUserEmail (LCOM4 5): PhabricatorUserEmail\u0027s methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/storage/PhabricatorUserEmail.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"c257670910f9ae02670f6106696888e79fee70264824df3b1339cac9299f71de"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorObjectHandle (LCOM4 5): PhabricatorObjectHandle\u0027s methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phid/PhabricatorObjectHandle.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"f9426722319c6e9358a8150337a38d441307cbd783b2982df27458cff0c37c7a"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhortuneCharge (LCOM4 5): PhortuneCharge\u0027s methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/storage/PhortuneCharge.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"5bf7d8a12e787fb965b7f880226d68f4bfbd075020d1d76fce5c1521683e053e"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhortunePaymentMethod (LCOM4 5): PhortunePaymentMethod\u0027s methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/storage/PhortunePaymentMethod.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"2782be368da007c877cb1856c2efbffebd24b69f2f0ee8fff4e15b9545601bd1"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorPolicyTestObject (LCOM4 5): PhabricatorPolicyTestObject\u0027s methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/__tests__/PhabricatorPolicyTestObject.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"1c4dbed0403b48ce72460a33c1f5c37353f3d7f2c7a78d1fc5f37c86d46892c5"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorProjectTrigger (LCOM4 5): PhabricatorProjectTrigger\u0027s methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/storage/PhabricatorProjectTrigger.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"99eb874fd988f376c27e20500f633938829a6e6f82e42ea653fb3d33441143c8"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorSettingsPanel (LCOM4 5): PhabricatorSettingsPanel\u0027s methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/settings/panel/PhabricatorSettingsPanel.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"b41879b77441a9abb52007d28c1517b930e89c3864dc22999533918ce8338946"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorEditType (LCOM4 5): PhabricatorEditType\u0027s methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/edittype/PhabricatorEditType.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"aba4b170a9cbccf984187c395da9fe3ab092f2c74808438c83ac1d66574de66f"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorEditEngineConfiguration (LCOM4 5): PhabricatorEditEngineConfiguration\u0027s methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"2aa2eb9d51c0eefd98d66d3b887c53c8dbe44ffbe86ca35e1879704bf523b5e0"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: AphrontDialogView (LCOM4 5): AphrontDialogView\u0027s methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/AphrontDialogView.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"23161f7a2156c90bac31c79ac452f7870415e850cdf6e5cca5db9f5a138179ab"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorMainMenuBarExtension (LCOM4 5): PhabricatorMainMenuBarExtension\u0027s methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/page/menu/PhabricatorMainMenuBarExtension.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"b892eeb3cafb8c3ebb9719034af3f3186396be1d2d7a50d7ab191e9e54b7dc36"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PHUITimelineEventView (LCOM4 5): PHUITimelineEventView\u0027s methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUITimelineEventView.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"5e20eabf3293c436d75c900f5599ebda991ce43cfcb447375c0e7ec8a1ef2f94"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorAuditTransactionComment (LCOM4 4): PhabricatorAuditTransactionComment\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/storage/PhabricatorAuditTransactionComment.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"e88f7183862ed53e40dd13ae84b955369af23bcca4b9044345e3dbfe0290ea82"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorConfigTableSchema (LCOM4 4): PhabricatorConfigTableSchema\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/schema/PhabricatorConfigTableSchema.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"8b4b120d1fef0981c327966f319fbeb40642b12d48b9ddeb3aad43bdd07eab83"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorDashboardPanelEditEngine (LCOM4 4): PhabricatorDashboardPanelEditEngine\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/editor/PhabricatorDashboardPanelEditEngine.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"57dedd82a826c5feaea805b351630f8c045aa29a31f06aa20dc52d492cb6cc62"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: DifferentialRevisionQuery (LCOM4 4): DifferentialRevisionQuery\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/query/DifferentialRevisionQuery.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"b60bb76d167623782bf1118a70d15b6e5b88837d100ca51d40d2948ea397ab6b"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: DivinerAtomCache (LCOM4 4): DivinerAtomCache\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/cache/DivinerAtomCache.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"e382eeb3efaba04b091a993ee36a4f522442c2a4febf0fff0c0be45bbfefc213"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: DoorkeeperBridge (LCOM4 4): DoorkeeperBridge\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/bridge/DoorkeeperBridge.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"754deef3d91099fc320896557edbbb3e523d8db79d34f97eaa2a226f20bae70b"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: DrydockLease (LCOM4 4): DrydockLease\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/storage/DrydockLease.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"84a83bebabd26a7d1f02943f4fc34e9880575771d36343090b453ec20c73674a"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorFeedStory (LCOM4 4): PhabricatorFeedStory\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/feed/story/PhabricatorFeedStory.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"04d0baec46068c7dfe16e5d655451395259ecd204c2865ae3e5e7e7669d5ab60"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorDocumentRef (LCOM4 4): PhabricatorDocumentRef\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/document/PhabricatorDocumentRef.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"541a9fe0eb6ec33be461cfd0d5c40c8222fd3a6fea6d8939cd199ed01af6af2e"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorGuidanceMessage (LCOM4 4): PhabricatorGuidanceMessage\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/guides/guidance/PhabricatorGuidanceMessage.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"d22023ae66f0f6f7e56b3c808f1b61a1540f9ff700fb54dd64f06cfce45f0636"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: HeraldAction (LCOM4 4): HeraldAction\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/action/HeraldAction.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"68f430f6a8a64d6ba5abb640f9198bbc0d32ccad20ad88aacb7e3d2608768d13"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: HeraldRuleTranscript (LCOM4 4): HeraldRuleTranscript\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/storage/transcript/HeraldRuleTranscript.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"fc908cd275b2468cd42c701dce3d848616639db94d9af04b8a2552350127512b"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorMailReplyHandler (LCOM4 4): PhabricatorMailReplyHandler\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"23a779c9cb9dc0d42494d3f31d1a9ba0888f496cea64c74bcebdb93383516ff6"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhrictionDocumentQuery (LCOM4 4): PhrictionDocumentQuery\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/query/PhrictionDocumentQuery.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"c7e2e99bf1454cdd7501dc67923b820f368c7835efa09aacdcf975d8235cb691"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorRepositoryEngine (LCOM4 4): PhabricatorRepositoryEngine\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/engine/PhabricatorRepositoryEngine.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"fdc46b6b71bf7d74518a4b089970ee48527fa978019c57694c0eb491b618bbbf"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorRepositoryPushLog (LCOM4 4): PhabricatorRepositoryPushLog\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepositoryPushLog.php"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"94a4d8dcded01b5de7221de06e5185c4020971dc2fe7b9cde9460356698ef264"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorSearchField (LCOM4 4): PhabricatorSearchField\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/field/PhabricatorSearchField.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"adee62866378707ccf9009c7f6fe465e9b13563688bcb28d910f61b4eb6db5bb"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorWorker (LCOM4 4): PhabricatorWorker\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/workers/PhabricatorWorker.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"9c28a5b17c3a6f8f4de9104ae2e63a4547d9b5b9c0f0649df6f9199f776f8fdf"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorWorkerTrigger (LCOM4 4): PhabricatorWorkerTrigger\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/workers/storage/PhabricatorWorkerTrigger.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"937da1dca82560b4ea7b268a4f8e27bba77648d64e981e3682c9e087ba0ab02c"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorMarkupOneOff (LCOM4 4): PhabricatorMarkupOneOff\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/PhabricatorMarkupOneOff.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"3d532460dbe058f04f91f93b6949e0281c34765829df7f2e914de1b8dd7b76a6"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhutilRemarkupRule (LCOM4 4): PhutilRemarkupRule\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/markuprule/PhutilRemarkupRule.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"626751de198d358a2ad313d7a444b195267676068dcf5dad0027067c75740573"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorBarePageView (LCOM4 4): PhabricatorBarePageView\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/page/PhabricatorBarePageView.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"1ca544dd7500860c223d65546dba2716ce4e893992146a02a782e3237b17606a"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PhabricatorStandardPageView (LCOM4 4): PhabricatorStandardPageView\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/page/PhabricatorStandardPageView.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"7cd0c1f20eb6ad57cd9cb25bb47f023f15290d2d9133559f1f8c24124d6617c0"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PHUIDocumentSummaryView (LCOM4 4): PHUIDocumentSummaryView\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIDocumentSummaryView.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"04473c69307450f63f97cd13ad45b2f31d8b37a31a1d38f3eab973dbadf6710d"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PHUIListItemView (LCOM4 4): PHUIListItemView\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIListItemView.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"7a89206b430b073edebe8465b2828800552709dbbe6f0cf797205a5d26b214cd"}},{"ruleId":"D13","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"1aeecd54b1a40345c297cc9d628f1efc4f0046b414f1b2432cf1c6e821d7cbce"},"taxa":[{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-798","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: src/applications/policy/filter/PhabricatorPolicyFilter.php: src/applications/policy/filter/PhabricatorPolicyFilter.php changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 25 in PhabricatorPolicyFilter.apply at line 156. 3 of those changes were fix/bug commits, so the churn is repair rather than feature work. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one \u2014 a file this often edited pays the complexity back every time. Counted over 2026-08-03..2026-11-01, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-08-03 05:01:58 -08:00\u0027 --until=\u00272026-11-01 05:01:58 -08:00\u0027 --full-history --no-merges -- src/applications/policy/filter/PhabricatorPolicyFilter.php\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/filter/PhabricatorPolicyFilter.php"},"region":{"startLine":156}}}],"partialFingerprints":{"codehealthFindingId/v1":"73d5e6cdb3c2ae7579455e6738f134c8dd4dee6c14e43690e4d6575e0ee9b14b"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: src/applications/calendar/query/PhabricatorCalendarEventQuery.php: src/applications/calendar/query/PhabricatorCalendarEventQuery.php changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 29 in PhabricatorCalendarEventQuery.willFilterPage at line 515. 2 of those changes were fix/bug commits, so the churn is repair rather than feature work. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one \u2014 a file this often edited pays the complexity back every time. Counted over 2026-08-03..2026-11-01, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-08-03 05:01:58 -08:00\u0027 --until=\u00272026-11-01 05:01:58 -08:00\u0027 --full-history --no-merges -- src/applications/calendar/query/PhabricatorCalendarEventQuery.php\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/query/PhabricatorCalendarEventQuery.php"},"region":{"startLine":515}}}],"partialFingerprints":{"codehealthFindingId/v1":"4c18faad2753ce068634585e0b06d0d3710c1c1bafdaa51551900433a6a38fbf"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: src/applications/diffusion/query/DiffusionCommitQuery.php: src/applications/diffusion/query/DiffusionCommitQuery.php changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 24 in DiffusionCommitQuery.didFilterPage at line 361. 2 of those changes were fix/bug commits, so the churn is repair rather than feature work. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one \u2014 a file this often edited pays the complexity back every time. Counted over 2026-08-03..2026-11-01, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-08-03 05:01:58 -08:00\u0027 --until=\u00272026-11-01 05:01:58 -08:00\u0027 --full-history --no-merges -- src/applications/diffusion/query/DiffusionCommitQuery.php\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/DiffusionCommitQuery.php"},"region":{"startLine":361}}}],"partialFingerprints":{"codehealthFindingId/v1":"4543460e4174af7fc8d0e61e57213dadddb5604eec7ac3293222eb3154b02db2"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: src/applications/oauthserver/controller/PhabricatorOAuthServerTokenController.php: src/applications/oauthserver/controller/PhabricatorOAuthServerTokenController.php changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 19 in PhabricatorOAuthServerTokenController.handleRequest at line 17. 2 of those changes were fix/bug commits, so the churn is repair rather than feature work. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one \u2014 a file this often edited pays the complexity back every time. Counted over 2026-08-03..2026-11-01, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-08-03 05:01:58 -08:00\u0027 --until=\u00272026-11-01 05:01:58 -08:00\u0027 --full-history --no-merges -- src/applications/oauthserver/controller/PhabricatorOAuthServerTokenController.php\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/oauthserver/controller/PhabricatorOAuthServerTokenController.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"ddead27bb37eb63742da83093a6444fdcb98f298b67e18d9c28ac6d6daf0f197"}},{"ruleId":"D16","level":"note","message":{"text":"Off-boarding risk: anonymized user #1: If anonymized user #1 becomes unavailable, 51 significant file(s) lose their only recent owner: src/applications/repository/storage/PhabricatorRepository.php, src/applications/transactions/storage/PhabricatorApplicationTransaction.php, src/applications/files/storage/PhabricatorFile.php, src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php, src/applications/search/engine/PhabricatorApplicationSearchEngine.php, src/applications/calendar/storage/PhabricatorCalendarEvent.php, src/applications/differential/storage/DifferentialRevision.php, src/applications/policy/filter/PhabricatorPolicyFilter.php (\u002B43 more). Pair on, review, or document these before any departure."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"80bad129afe4dfc3e5b66d12c63dbb77f40437a2c0be2baec2b000f1843f3917"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This API is awkward. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/AphrontDialogView.php"},"region":{"startLine":141}}}],"partialFingerprints":{"codehealthFindingId/v1":"dcfa268713d28e0af6aaf7b0f78c983a6ae955d13d32faa61c24590b7344a3c4"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Make this configurable? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/widget/AphrontStackTraceView.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"8edb851311a2a56f2575519476e5d4095c859680fce3abc9fc59e4a4f7bceb9a"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This block of code takes \u0022PHUIListItemView\u0022 objects and turns \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUICrumbsView.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"55143deda00cc9977d2fd15e6c2e8c1dd68e262fa692a7234773d1902be9e9f1"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is really bad; when rendering through Conduit and via \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIFeedStoryView.php"},"region":{"startLine":220}}}],"partialFingerprints":{"codehealthFindingId/v1":"5820b95ed5efca0c77f257483818b4218ba8d6753e5c5ad8440ebf52c7d7a7f6"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Normalize \u0022closed/archived\u0022 to constants. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIHeaderView.php"},"region":{"startLine":120}}}],"partialFingerprints":{"codehealthFindingId/v1":"a5db34285a11c073827b4090490ece29e33492e66999327ea2b368f99dd2da29"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: \u0022PHUICrumbsView\u0022 currently creates a bad copy of list items \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIListItemView.php"},"region":{"startLine":72}}}],"partialFingerprints":{"codehealthFindingId/v1":"9074f263499cfe35ab34285457060423e865d5d7a0fb0a48151b671a5dfcfcfe"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We could tell the browser about all the servers and let it \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/page/PhabricatorStandardPageView.php"},"region":{"startLine":580}}}],"partialFingerprints":{"codehealthFindingId/v1":"31e781e3e35ec1ea04afc40cf618570df40b0c342aca1bedc66b946af1cb6a3d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: It would be nice to convert this to an AphrontTagView and \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/layout/AphrontMultiColumnView.php"},"region":{"startLine":150}}}],"partialFingerprints":{"codehealthFindingId/v1":"491a9fee75d68197be00f4dd699257d92fda971de4df70e9c354e3546fcc3342"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Modularize this properly, see T13125. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/layout/PhabricatorSourceCodeView.php"},"region":{"startLine":115}}}],"partialFingerprints":{"codehealthFindingId/v1":"cb55f8aac87d8f7b6af2e92fc3157ef504da588a8db53457161361596d95f42a"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Modularize this properly, see T13125. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php"},"region":{"startLine":159}}}],"partialFingerprints":{"codehealthFindingId/v1":"7171f1bedc466b976a50e6276934caedb711763a0f3d83d6461a3b35a9df7b8b"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We could eventually allow these to be customized per install or \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/form/control/AphrontFormDateControl.php"},"region":{"startLine":317}}}],"partialFingerprints":{"codehealthFindingId/v1":"554830cfa9a75a3893ac887512e06fe2e846dcdca77b80c41030330575926852"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is a bit funky and still rendering a few pixels of padding \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/form/control/AphrontFormHandlesControl.php"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"ccffe49e4d61b2d9cdcb5b1a0c79b124420eff6f89b374ee2d909c3b816644f7"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is a little hacky but will only get us into trouble if we \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/form/control/AphrontFormPolicyControl.php"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"9ff297e5d27d345c877a33508064fba81fd9a682d7598adb4394a7b18e8ccba8"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Make this configurable. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/form/control/AphrontFormPolicyControl.php"},"region":{"startLine":239}}}],"partialFingerprints":{"codehealthFindingId/v1":"3abca73860d1363ac6be4fa8f3dcebed6d26922be2bce1272106e7e9a7094c6f"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Make this configurable. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/blueprint/DrydockWorkingCopyBlueprintImplementation.php"},"region":{"startLine":196}}}],"partialFingerprints":{"codehealthFindingId/v1":"689b85470f54dd6ac37f71ac394edd8cbf299acb834a99cf7a7b70e5e4e7840f"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This works alright, but is a bit of a hack, and the UI should \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/form/control/PHUIFormFileControl.php"},"region":{"startLine":45}}}],"partialFingerprints":{"codehealthFindingId/v1":"377f6e82cbc8879ec1d98a8711ea493f2075813db6e575058a054436b1054f92"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Is there a cleaner way to do this? We use a relative div with \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/control/AphrontTableView.php"},"region":{"startLine":390}}}],"partialFingerprints":{"codehealthFindingId/v1":"8bd2a28f4b833817c2692b654f3f2bc65084533da71e654de8c39914e449e987"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We could throw here, but then this lock doesn\u0027t get marked \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/util/PhabricatorGlobalLock.php"},"region":{"startLine":248}}}],"partialFingerprints":{"codehealthFindingId/v1":"b3116a760734d164bd87bb10ad8f9d78ea16884522efdaac137f01c8ef7ea015"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: There\u0027s currently no cohesive way to get the parameterized access \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/util/PhabricatorGlobalLock.php"},"region":{"startLine":302}}}],"partialFingerprints":{"codehealthFindingId/v1":"72b3ebde2423a32d2c0602f492693ebfa431c4b22fe5bebb03fd6eb3de7180f5"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Here, and in \u0022%LO\u0022, \u0022%LA\u0022, and \u0022%LJ\u0022, we should eventually \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/xsprintf/qsprintf.php"},"region":{"startLine":208}}}],"partialFingerprints":{"codehealthFindingId/v1":"98bad63c9cd1c0341c4637435c9f3fbed810611913633a7fe5c37a67d18060cb"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: See T13217. Remove this eventually. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/xsprintf/qsprintf.php"},"region":{"startLine":404}}}],"partialFingerprints":{"codehealthFindingId/v1":"fd060e5f844dd9ab8737ffcf916d4e2b69ec7333358c811e07d862421507be6d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: See T13217. Remove this eventually. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/xsprintf/qsprintf.php"},"region":{"startLine":428}}}],"partialFingerprints":{"codehealthFindingId/v1":"ce92d3848d812d69623609598ca144e81935f7c2b67c9924d0f4ecfcff67552f"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Detect cycles? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/patch/PhabricatorSQLPatchList.php"},"region":{"startLine":253}}}],"partialFingerprints":{"codehealthFindingId/v1":"af07f626adeb45f150a6c0ffbc907100a453052c46663e8ed58789a9be8b0640"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We\u0027re using \u0022%Z\u0022 here for the column type, which is \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php"},"region":{"startLine":416}}}],"partialFingerprints":{"codehealthFindingId/v1":"dc4d5a2e9758073ee1faec80e41e04dbd984b5c00f38d2561a7d166ebec03aa6"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: There is currently no protection on \u0027r\u0027 queries against writing. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/lisk/LiskDAO.php"},"region":{"startLine":839}}}],"partialFingerprints":{"codehealthFindingId/v1":"1fa8a7a31b2400f8d3464c5da0e3966fd4d231586386c37071da6daf3a221427"}},{"ruleId":"D17","level":"warning","message":{"text":"HackComment: // Hack for policy system hints, see PhabricatorPolicyRule for notes. \u2014 a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/lisk/LiskDAO.php"},"region":{"startLine":1641}}}],"partialFingerprints":{"codehealthFindingId/v1":"867250f5b0f56a48e6a8b267842208690ceff6ec351c964c24fc917a0c3048f7"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This should be testing if the mode is \u0022r\u0022, but that would probably \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/lisk/PhabricatorLiskDAO.php"},"region":{"startLine":74}}}],"partialFingerprints":{"codehealthFindingId/v1":"dfe8578234140325be35059bb4b01793bf0e40dce9da2048de8cce058b87aaad"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is pretty much a guess, and probably needs to be \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/lisk/PhabricatorLiskDAO.php"},"region":{"startLine":303}}}],"partialFingerprints":{"codehealthFindingId/v1":"be6adedaf9fdfd771a2fe11666efaf5b03a4ed1cbbbaba34b61bb7cdc9e262d2"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: When we have semi-durable fixtures, use those instead. This is \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/lisk/__tests__/LiskFixtureTestCase.php"},"region":{"startLine":48}}}],"partialFingerprints":{"codehealthFindingId/v1":"b21156fa1b7fe258f6c6a5fda56b0920ce74b08c486f07aa047dbf74c8f7c3d4"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: 1064 is syntax error, and quite terrible in production. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php"},"region":{"startLine":369}}}],"partialFingerprints":{"codehealthFindingId/v1":"eb7f386c4003c043c85b2299aa09cfecb0034b5c04023c2d1ae71be52cc108a4"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This just makes us throw away stderr after the first 1MB, but we \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/ssh/PhabricatorSSHPassthruCommand.php"},"region":{"startLine":122}}}],"partialFingerprints":{"codehealthFindingId/v1":"3487f59d04cc99bc09b9dd167644fa837bdd12de0c35abc83af6029d449ad673"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: When commands are proxied, the original remote address should \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/ssh/PhabricatorSSHWorkflow.php"},"region":{"startLine":108}}}],"partialFingerprints":{"codehealthFindingId/v1":"0de8f37d12f560310a69612115d782f43d33d774a29de69f99131ff5ed901116"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is gross and should be removed. Avoid use. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/PhabricatorMarkupEngine.php"},"region":{"startLine":341}}}],"partialFingerprints":{"codehealthFindingId/v1":"004ae694da590498c1cfe1c9bdd7460b5b785b1b6b1fb3ec8a8b698bf6b96bd6"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: In the long run, rules themselves should define available options. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/view/PHUIRemarkupView.php"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"c39c81ce47493fc32620bb38820d99794c615770895c88fd39101688c03c1a27"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Pygments converts \u0022\\r\u0022 newlines into \u0022\\n\u0022 newlines, so we can\u0027t \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/syntax/highlighter/PhutilPygmentsSyntaxHighlighter.php"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"1ee30b31481291f68d44b456dbfc3ad7be0cfcd2d9bd74b7b1da12637ca6125b"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We should probably distinguish between these cases and render a \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php"},"region":{"startLine":387}}}],"partialFingerprints":{"codehealthFindingId/v1":"52a5c8b2bc501c39ea2b5a46765992d0dd9c81b53f98808b448442479881e14f"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Write build documentation for the Javelin binaries and point \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/lint/linter/PhabricatorJavelinLinter.php"},"region":{"startLine":112}}}],"partialFingerprints":{"codehealthFindingId/v1":"801b85d76898fa23cdc284a5ea5494ee086be6f722d3bd3273f751527461ccbf"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Add a \u0022locale.default\u0022 config option once we have some reasonable \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/env/PhabricatorEnv.php"},"region":{"startLine":135}}}],"partialFingerprints":{"codehealthFindingId/v1":"1ea21abb2bf8858b896706c4412963431654983bb8b20c7630c8a9b326734c45"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is not actually unique, but we\u0027re just doing our best \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/edges/query/PhabricatorEdgeObjectQuery.php"},"region":{"startLine":130}}}],"partialFingerprints":{"codehealthFindingId/v1":"c8ed18e8ccae0c18af32259661273c66605569f9559bc7e673d41b842d0a327e"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This should be configurable once we handle tab widths better. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/PhabricatorDiffScopeEngine.php"},"region":{"startLine":119}}}],"partialFingerprints":{"codehealthFindingId/v1":"941b89b785c106506be67a64326043a41725d958650e032a5c90df631d8be749"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: If both files were identical but missing newlines, we probably \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/PhabricatorDifferenceEngine.php"},"region":{"startLine":116}}}],"partialFingerprints":{"codehealthFindingId/v1":"81ec7cc1b824723bb1ee497b7a0247d61f08ab01c3338460a82afa49572845a2"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: When properties are set on a directory in SVN directly, this \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/diff/view/PHUIDiffTableOfContentsListView.php"},"region":{"startLine":134}}}],"partialFingerprints":{"codehealthFindingId/v1":"2da8180dc1db3f763142cb543a67853675403b5e8a9b7fac552614e95cb0014e"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // waiting for something to read the buffers. TODO: Learn how unix works. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/PhutilDaemonOverseer.php"},"region":{"startLine":128}}}],"partialFingerprints":{"codehealthFindingId/v1":"b5e636eda7e4a5d60758a990f4c96f484e1a92a07f39f8b7f3ef1a595ea73613"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This only wakes if any daemons actually exit, or 1 second \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/PhutilDaemonOverseer.php"},"region":{"startLine":218}}}],"partialFingerprints":{"codehealthFindingId/v1":"9279d34409c0487f8562167537b962ced4224a03b916d2ebac8b8268dcf0d789"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: For now, never scale pools down to 0. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/PhutilDaemonPool.php"},"region":{"startLine":78}}}],"partialFingerprints":{"codehealthFindingId/v1":"54442c6b2267ca803d5cd88f88b1172184e7124d397c1ef379bb9f9606b58503"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Pools currently can\u0027t scale down to 0 daemons, but we should \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/PhutilDaemonPool.php"},"region":{"startLine":236}}}],"partialFingerprints":{"codehealthFindingId/v1":"796bc193f7862611bd03fd47c953f6eb3f8b445279a8fb8eb1555acad8e5d242"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: If the host name is very long, this can overflow the 64-character \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/workers/query/PhabricatorWorkerLeaseQuery.php"},"region":{"startLine":322}}}],"partialFingerprints":{"codehealthFindingId/v1":"1a5c0c28d9185f9cbe133536bd09a81565a38ef20e5e7f3cf9e98180aa66cea6"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: See T13321. After the removal of daemon PID files this class \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/control/PhabricatorDaemonReference.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"b4d6d06f5fa0a8baa05cf5a5ba27af7a422a9b0e53f8b978a67d88d6a085b17a"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We should have better typechecking somewhere, and then make \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"dd08cd3c207f4b3b645d981ebed780dd34d8e0718a72fa2eb8aaa0e7d5ef6568"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Build a new \u0022pair\u003Cepoch|null, epoch|null\u003E\u0022 type or similar. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php"},"region":{"startLine":230}}}],"partialFingerprints":{"codehealthFindingId/v1":"ce045580809f4ca56c5bc15dba448e65f4c389f3c1cbae367753ef14fe2ba1bf"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Clean this up. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"3a770eb7089157a6cb033826403d41849832f4f88ef022b3d1f9770eb11845bb"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Once this stabilizes, it would be nice to let fields batch this. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"d39d6ba8262341a2fc177fb2a3d8dd42187c1e4468c0ddf64e43f1c20ff5b312"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: These should have proper types. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/customfield/engineextension/PhabricatorCustomFieldSearchEngineExtension.php"},"region":{"startLine":73}}}],"partialFingerprints":{"codehealthFindingId/v1":"16efa1e5c0b3f02042d4acc29d8d198523506c80831a1a7e2c7e348edaad0aed"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is somewhat bogus because only StandardCustomFields \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/customfield/editor/PhabricatorCustomFieldEditField.php"},"region":{"startLine":96}}}],"partialFingerprints":{"codehealthFindingId/v1":"0d5a8178eca0b244173905b710b543250dd6067e37da7f33ab424b991c26ef05"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We might need to build a real object here eventually. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/customfield/config/PhabricatorCustomFieldConfigOptionType.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"54594090b63e3d56ec894bfc0bc2f83f63443977d4b98c92faf8ae517e51d8be"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We may have multiple replicas to choose from, and could make \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/cluster/PhabricatorDatabaseRef.php"},"region":{"startLine":684}}}],"partialFingerprints":{"codehealthFindingId/v1":"9813f39f6d1130fc4631b9fa8f6fe24f89e0931c03975cedea5d2b72841ce00c"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We should check that the application is valid, to \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/cluster/PhabricatorDatabaseRefParser.php"},"region":{"startLine":124}}}],"partialFingerprints":{"codehealthFindingId/v1":"9880379f675762fb272587f498b6251ba587180cb4b79559dae932b7df15852e"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This sets too many results in the closer caches, although \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/cache/PhutilKeyValueCacheStack.php"},"region":{"startLine":92}}}],"partialFingerprints":{"codehealthFindingId/v1":"bc4ddbbb0251ff3f9ffcb0c553acd0dcd0ffd2536da933c3f3808e3ada8848f0"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: There is currently no way to quote characters in arguments, so \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php"},"region":{"startLine":510}}}],"partialFingerprints":{"codehealthFindingId/v1":"834f59b940aca8b43a55cfee63e4c4ab8d2fc8a80208fb88eba9f209e5bc0ffc"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is a bit hacky for now: we\u0027re sort of generating wire \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php"},"region":{"startLine":590}}}],"partialFingerprints":{"codehealthFindingId/v1":"19e86120f070a317c1a08ea4e8537427b61784f903aa2e71148dfe85f1a954d4"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Remove this eventually, this is handling old changes during \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorApplicationTransaction.php"},"region":{"startLine":668}}}],"partialFingerprints":{"codehealthFindingId/v1":"116629a7b0a0ef8fd046c2d32ba189faf5d032eed95d351f84d5dc2d8b6fca7b"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: For now, rendering this with TARGET_HTML generates links with \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorApplicationTransaction.php"},"region":{"startLine":853}}}],"partialFingerprints":{"codehealthFindingId/v1":"c720e542209d5ea5b0ab920ed28624014c6ec245520348ddc42042e7ec708046"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Some \u0022final\u0022 modifiers have been VERY TEMPORARILY moved aside to \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/storage/PhabricatorModularTransaction.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"837307fb5a34d408c9acce47aeac8619a5ee8875dce17c4bf2ddbfe415979483"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Figure out the app via the template? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/query/PhabricatorApplicationTransactionCommentQuery.php"},"region":{"startLine":115}}}],"partialFingerprints":{"codehealthFindingId/v1":"a3f81c8b0671ac2ba7f65ecdffa4189ed45e6229df4890a73c51e31a88ef73dc"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Sort this out? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/query/PhabricatorApplicationTransactionQuery.php"},"region":{"startLine":296}}}],"partialFingerprints":{"codehealthFindingId/v1":"e7e67b7939a991448c69f65f0f5d61ba9a702dc18a9a8d80763a9c355f168ef2"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: The logic here is a little flimsy and won\u0027t survive pagination. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/query/PhabricatorEditEngineConfigurationQuery.php"},"region":{"startLine":72}}}],"partialFingerprints":{"codehealthFindingId/v1":"66726655dcff53a52daec6341ac02adc8c92215aed17cd7fc55415c645911959"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This needs to be more sophisticated once we have meta-policies. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php"},"region":{"startLine":77}}}],"partialFingerprints":{"codehealthFindingId/v1":"2642342ff0e7790df758ad5fd758e77c4e2d501ad0c6894d0645b1edfd73c0b7"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This needs to be more sophisticated once we have meta-policies. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":1049}}}],"partialFingerprints":{"codehealthFindingId/v1":"f11add0ba3cc211c6e819088481a226110cea8e5093b8e0d746a2de294b6c787"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Provide a modular hook for modern transactions to do a \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":407}}}],"partialFingerprints":{"codehealthFindingId/v1":"efcdce34e9dc377dfe3d3f74414465676affde48909301939a8c4fa4d2a4c147"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Once everything is on EditEngine, just use getIsNewObject() to \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":1303}}}],"partialFingerprints":{"codehealthFindingId/v1":"d2f3d0d9c4966b8b74c41cd72a2074c48ebad0508963acc212b1f560d7b50577"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is a transitional hack to let us migrate edge \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":1381}}}],"partialFingerprints":{"codehealthFindingId/v1":"761b940664fb19ae9222e22354111532f8e049698fee2a71ae7da125ab7c3bd4"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: It would be nice to give transactions a more specific source \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":1490}}}],"partialFingerprints":{"codehealthFindingId/v1":"f11b04e5c9ae0f145831f4dd77bb3188b8607436667f60feb07249d9bc9738a8"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Comments technically require CAN_INTERACT, but this is \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":1905}}}],"partialFingerprints":{"codehealthFindingId/v1":"4ee54048e87253cf0ab7ced79da92dbcdc66bffa1243792f32fa12fd2cbb7f62"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is a little bit hacky. We really want to be able to say \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":1932}}}],"partialFingerprints":{"codehealthFindingId/v1":"099a9c478f3a98fd3beeaee7f5b3a0948d262ba870cc6a40ba226a610432baa2"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This technically requires CAN_INTERACT, like comments. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":1954}}}],"partialFingerprints":{"codehealthFindingId/v1":"9c7b5c51023975e42e85721c6b45e74564cca649135dcb436c62ee1c1b99165d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: For now, this is just a placeholder. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":2229}}}],"partialFingerprints":{"codehealthFindingId/v1":"a3af4079fe6f69d7fb363840fd6a6cf6ba10347e30d76147bcb9f675c390a2c3"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This viewer isn\u0027t quite right. It would be slightly better to use \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":3616}}}],"partialFingerprints":{"codehealthFindingId/v1":"60c89a7b7bf1492f01f48e0bee45a1a19c65f472d553f79f1a2f743b76803d23"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We should move shared mail tags, like \u0022comment\u0022, here. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":3691}}}],"partialFingerprints":{"codehealthFindingId/v1":"8a2deb343c2a734170961d90e0b9d8a2be5dd24f627d21f2d2cb4df6e7505b68"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: At least for now, don\u0027t record inverse edge transactions \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":4467}}}],"partialFingerprints":{"codehealthFindingId/v1":"3276f09591963f0badcd08f698ff9ce0defc43a5eb90a5c3952f75759f6a58c6"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This should likely be some future WorkboardInterface. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":4927}}}],"partialFingerprints":{"codehealthFindingId/v1":"ec9c9b521b7912ec746980a685b7b9d17e1287c77e4a8ca235dd74d921307fd1"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: For the moment, this is a very un-modular hack to support \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":5296}}}],"partialFingerprints":{"codehealthFindingId/v1":"3afca482cba9ebdd3d53f1df59bd4726fb4b89654fb54e5c3a1379229dd6df0b"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This doesn\u0027t warn for inlines in Audit, even though they have \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":5305}}}],"partialFingerprints":{"codehealthFindingId/v1":"01fe58f248864b78666de65b1ce845206c88dbc25e23d1a230bd0dd39de68ec7"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Implement a more expansive \u0022Mailable\u0022 parameter type which \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editfield/PhabricatorSubscribersEditField.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"2e2cc16908d7a2ded6f25d0f8f2b09fc6be06b12677df20a33d006c38ee98543"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Validate this in more detail with a more tailored error. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editengine/PhabricatorEditEngine.php"},"region":{"startLine":192}}}],"partialFingerprints":{"codehealthFindingId/v1":"4f2e21f6b35dcf09ea7048a1675b30676f22b9f9cfde039c76d103ea23489fab"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This should also set workflow on the form, so the user doesn\u0027t \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editengine/PhabricatorEditEngine.php"},"region":{"startLine":1374}}}],"partialFingerprints":{"codehealthFindingId/v1":"5681f50706d9aabe31b441185f46f9014bd0e87a34b3a402381e7a8bb22cda6c"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This just nukes the entire comment form if you don\u0027t have access \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editengine/PhabricatorEditEngine.php"},"region":{"startLine":1629}}}],"partialFingerprints":{"codehealthFindingId/v1":"cf5652549aa989ca5ddbb57d8f74e0d7f90d03fdffab8fde52fe7ba18663bde9"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Validate these better. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editengine/PhabricatorEditEngine.php"},"region":{"startLine":1708}}}],"partialFingerprints":{"codehealthFindingId/v1":"8dd339e40fbfc47c8baac6cb44b87777d241234b9ffaa1e1b7e744fe01fe6611"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Maybe let the field pick a page to associate itself with so \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editengine/PhabricatorEditEngine.php"},"region":{"startLine":2498}}}],"partialFingerprints":{"codehealthFindingId/v1":"002754b5d849bb2a63f861f108f934be477bdd74aeed24956b201a04cbd90a06"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This should be some kind of \u0022hey do you support this?\u0022 thing on \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/controller/PhabricatorApplicationTransactionValueController.php"},"region":{"startLine":28}}}],"partialFingerprints":{"codehealthFindingId/v1":"42aaa51dfacbd09445c741d067bb985e2ca57df4307d759731ae95f6e4a52f48"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Explain what this means in more detail once the implications are \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/controller/PhabricatorEditEngineConfigurationSaveController.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"ccae30e46301f3734614c7384de5ca2568cc47881782e550fc1604fde851898c"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Hack things so certain transactions which don\u0027t have a modular \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php"},"region":{"startLine":152}}}],"partialFingerprints":{"codehealthFindingId/v1":"0846aa27c5361b25efdd1558c5f3e6b68cf7c06a77b508e7b6631d78ea4b3e2a"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is a bit hacky and inflexible. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/bulk/PhabricatorBulkEngine.php"},"region":{"startLine":136}}}],"partialFingerprints":{"codehealthFindingId/v1":"367148f855af56a8ea55d2395a962063faae63526f5f7a4f485ac19e72bc1a2d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: For now, since we don\u0027t deal gracefully with queries which \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/bulk/PhabricatorBulkEngine.php"},"region":{"startLine":169}}}],"partialFingerprints":{"codehealthFindingId/v1":"6013b79c1c922c2336538db7453af6b8c1a6c8033b089735e5bb590676f86cd1"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Maybe move to a View class? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/tokens/storage/PhabricatorToken.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"f1e80838943cd9babae579942aefa603a55c254ba4ac3bc5752c2515bc9ab95c"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is slightly wrong, as it does not respect implied context \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/tokens/feed/PhabricatorTokenGivenFeedStory.php"},"region":{"startLine":58}}}],"partialFingerprints":{"codehealthFindingId/v1":"094cafb690310c35a6f685e3553d5cd7e5dcf74aa031453cdf12b24770161ad5"}},{"ruleId":"D17","level":"warning","message":{"text":"HackComment: // Hacky solution so that property list view on Diffusion \u2014 a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/tokens/event/PhabricatorTokenUIEventListener.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"c0f01f0a9d603d0de06a0c6705d0aec837cdbf6263266e1ad1f05185a9e940d0"}},{"ruleId":"D17","level":"warning","message":{"text":"HackComment: // Hacky solution so that property list view on Diffusion \u2014 a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"5acff74822e807a9dbc7fe6ec11b18ec8e64732bf38ee0b21a00ac1ab42c844e"}},{"ruleId":"D17","level":"warning","message":{"text":"HackComment: // Hacky solution so that property list view on Diffusion \u2014 a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/events/PhabricatorProjectUIEventListener.php"},"region":{"startLine":15}}}],"partialFingerprints":{"codehealthFindingId/v1":"6613bf97ebaad793a805413f72f3b96d26ef4fe0a28bdaac52177ebe68373980"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This controller is a bit rough because it isn\u0027t really using the \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/system/controller/PhabricatorSystemSelectViewAsController.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"2c4cce5d2472fbc32b9b0436aab0c03ee0f1cc6f3c81106ad07403c1855f436b"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We should limit the number of subscriber PHIDs we\u0027ll load, so \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/subscriptions/engineextension/PhabricatorSubscriptionsCurtainExtension.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"8ccf6e395a6eda73322bb6245a7dec37e12b3d7419e7a044a4584ce39d667bc1"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Eventually, get rid of this once everything implements \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/subscriptions/controller/PhabricatorSubscriptionsEditController.php"},"region":{"startLine":75}}}],"partialFingerprints":{"codehealthFindingId/v1":"7e8818f5b96cca0371ed4463e5b5f37b62e64ce5372e6236d89d5577842281d4"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We should just render the \u0022Unsubscribe\u0022 action and swap it out \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/subscriptions/controller/PhabricatorSubscriptionsEditController.php"},"region":{"startLine":91}}}],"partialFingerprints":{"codehealthFindingId/v1":"6b0189304c6835161791b6f8b7a4d5e9e340b0458a4d645f500f494f4df12a68"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This should probably become a list of \u0022voterPHIDs\u0022, so hide \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"1264b849bea657c0e44ce81b2db423430b5c400a4462a42f3d80704cb54cd2cc"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: When editing another user\u0027s settings as an administrator, this \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/settings/setting/PhabricatorPronounSetting.php"},"region":{"startLine":29}}}],"partialFingerprints":{"codehealthFindingId/v1":"e80799b6a18b87f385ec59c791d86574f0ecc45d6f3895bb14ecde030d7fc8fa"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: These are hard-coded for now, and all of this will probably be \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/relationship/PhabricatorObjectRelationshipSource.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"2a9a546d6fe163130ffe6776c7b1ec7b8b82da76957d72df87011bd53fc26d8d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is inelegant and not very efficient, but gets us reasonable \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php"},"region":{"startLine":206}}}],"partialFingerprints":{"codehealthFindingId/v1":"48e9a6d18f7d8329d8af1c063b73081ef044bad4a0a9b8ee496f9e8ac79330d3"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Remove this after object selection moves to ApplicationSearch. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/query/PhabricatorSearchDocumentQuery.php"},"region":{"startLine":75}}}],"partialFingerprints":{"codehealthFindingId/v1":"8ba590b33d304bb598a49388e40f3fb054cac50edf449f7215b0c5e22645fab8"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: For historical reasons, the keys we look for don\u0027t line up with \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/field/PhabricatorSearchCustomFieldProxyField.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"4241ab5fe1a49f9064d62ccc8f3314924e82614e53466ce4f20899924c3daf02"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We should \u0060setError($this-\u003EgetShortError())\u0060 here, but it looks \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/field/PhabricatorSearchField.php"},"region":{"startLine":313}}}],"partialFingerprints":{"codehealthFindingId/v1":"05646cb0e50c655775dc14b1bd99e73f0a67cf6d925e67ab8213b77d77b3c65e"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Ideally, this should eventually be a \u0022Subscribers\u0022 type which \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/field/PhabricatorSearchSubscribersField.php"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"f6222451502cdee9abc2ead6703b3270d93efb68ce901095ef35300e2c412604"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is reachable with a null key, but probably should not be. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorApplicationSearchEngine.php"},"region":{"startLine":702}}}],"partialFingerprints":{"codehealthFindingId/v1":"4d29a995b423fde6e5f468ce3cbe1a2d0926e0191520494e8345e265ae85b9dc"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is reachable, but probably not correct. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorApplicationSearchEngine.php"},"region":{"startLine":978}}}],"partialFingerprints":{"codehealthFindingId/v1":"3f93afd9d627f2a51670c82dc246217abf393cfb07b28d3c1c7973e5484c1d39"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is reachable, but probably not correct. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/storage/PhabricatorProject.php"},"region":{"startLine":207}}}],"partialFingerprints":{"codehealthFindingId/v1":"be8a89c5f858bb34602545044890ac80ec1dadbce8123659310e87490acc7b42"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is reachable, but probably not correct. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/storage/PhabricatorProject.php"},"region":{"startLine":353}}}],"partialFingerprints":{"codehealthFindingId/v1":"53ad0e8ed9c13a2b37acfc0e5d499f8bf247d4d0c600fc582411311dc616c0a0"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is reachable, but probably not correct. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/filter/PhabricatorPolicyFilter.php"},"region":{"startLine":182}}}],"partialFingerprints":{"codehealthFindingId/v1":"ef3f0b02888f0854871cab4f06c9fccde3a680f792a98594282cd2f9c044a4d4"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: It would be nice to handle this more gracefully, but math \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorApplicationSearchEngine.php"},"region":{"startLine":1030}}}],"partialFingerprints":{"codehealthFindingId/v1":"6997e905684f8f5da61958435c1ca73ece3da87536bb9fe0db761e12912b4efd"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Validate this better. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/engine/PhabricatorApplicationSearchEngine.php"},"region":{"startLine":1221}}}],"partialFingerprints":{"codehealthFindingId/v1":"b8159a445db8edea3ee5d7b80fa16283fcb07a7dcc02e0df2e6b2bad6f62aa25"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Eventually, modularize all this stuff. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/controller/PhabricatorApplicationSearchController.php"},"region":{"startLine":324}}}],"partialFingerprints":{"codehealthFindingId/v1":"7705dc68a68a5361c5f7d08a93defaa51fd16163e51526c070cb2e9bfbac9d5d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is reachable with a null function, but perhaps it \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/compiler/PhutilSearchQueryCompiler.php"},"region":{"startLine":410}}}],"partialFingerprints":{"codehealthFindingId/v1":"effc22619618a0e905145a427d39b4102275d1bac33d75ec1139a2c39b82325d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Old versions of this transaction use a boolean value, but \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/xaction/PhabricatorRepositoryActivateTransaction.php"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"8131690a5db4bd7efff1cac812764a8575bfe326a7c554dc5d17f314d8d49d40"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Possibly, we should distinguish between automatic assignment \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/xaction/PhabricatorRepositoryServiceTransaction.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"0afd8a961d32b91a2a2eaa425c2e6bf4e571245cef12d6e1b31ecf8df0fe9c21"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This could use some validation, values should be valid Almanac \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/xaction/PhabricatorRepositoryServiceTransaction.php"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"71898e095fb8d249f09ce4728485b1a72f731a2eb8bfc64ab97ac0e0b1555800"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: See T13591. This supports execution of legacy tasks and can \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/PhabricatorRepositoryCommitParserWorker.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"b12399f7abff8116efc538a81418a580b1aeddd636657f7e0f04e1065ebd14c5"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We can detect binary changes as git does, through a combination \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryGitCommitChangeParserWorker.php"},"region":{"startLine":65}}}],"partialFingerprints":{"codehealthFindingId/v1":"59bde68d842e942162e6f4a50869fe947056247668ee9fedb838db3520449415"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We should expand this to a full 40-character hash using \u0022hg id\u0022. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryMercurialCommitChangeParserWorker.php"},"region":{"startLine":164}}}],"partialFingerprints":{"codehealthFindingId/v1":"c59e92aee08fad25424a7aeae782a46765081d19ec47d5a9c36630e03836ccc8"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: The UI probably doesn\u0027t handle any of these cases with \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryMercurialCommitChangeParserWorker.php"},"region":{"startLine":200}}}],"partialFingerprints":{"codehealthFindingId/v1":"f828eeceb061b64ab0b64dee538877c058a456291331cc2f2a4915fdf12bd4bb"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: use \u0022hg diff --git\u0022 to figure out which files are symlinks. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryMercurialCommitChangeParserWorker.php"},"region":{"startLine":240}}}],"partialFingerprints":{"codehealthFindingId/v1":"ff6a81b68e17cc7c9b457e6facdbcb4e8abeccd5fa84fed06329e147b11240f0"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Explicitly mark this commit as broken elsewhere? This isn\u0027t \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/commitchangeparser/PhabricatorRepositorySvnCommitChangeParserWorker.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"655e219081447449f31746c5dfb1b0ce7483fa1a7903ff24e1866d55ccf737ce"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Unclear how this is possible. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/commitchangeparser/PhabricatorRepositorySvnCommitChangeParserWorker.php"},"region":{"startLine":136}}}],"partialFingerprints":{"codehealthFindingId/v1":"e38f6021cee0949794488dca2037f752295c3d594e7e15c94161ac3480a8e2b5"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Replace with DiffusionPathIDQuery::getParentPath(). \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/commitchangeparser/PhabricatorRepositorySvnCommitChangeParserWorker.php"},"region":{"startLine":768}}}],"partialFingerprints":{"codehealthFindingId/v1":"ccf8a61790a03f08ebb69468760aa8b154fe1c8902d63425a824d0164882a732"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Replace with DiffusionPathIDQuery::expandPathToRoot(). \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/commitchangeparser/PhabricatorRepositorySvnCommitChangeParserWorker.php"},"region":{"startLine":778}}}],"partialFingerprints":{"codehealthFindingId/v1":"9cc2fb2ab456904ec3557837d8cd0f8d094ec00e9c202d93f1aa3ed89b353941"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is not correct, and should be FILE_SYMLINK. See \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/__tests__/PhabricatorChangeParserTestCase.php"},"region":{"startLine":256}}}],"partialFingerprints":{"codehealthFindingId/v1":"6a1c1dfd0d787da6884c7d6a8d393722bd5eed42933b5f1b4ffb2e1aefbedb38"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This might reasonbly be considered a bug in the parser; it \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/__tests__/PhabricatorChangeParserTestCase.php"},"region":{"startLine":520}}}],"partialFingerprints":{"codehealthFindingId/v1":"f2486b956743886e8f6b3e044316a1a097c8c0467d5b07dd53953cc4e3c4e1e1"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is not correct, and should be FILE_SYMLINK. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/worker/__tests__/PhabricatorChangeParserTestCase.php"},"region":{"startLine":815}}}],"partialFingerprints":{"codehealthFindingId/v1":"b3f9540d5ae0bbbf869e0f93672fb689a6118842f4de343e40cf17d79cfaa59e"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This should be cleaned up to deal with all the new URI handling. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepository.php"},"region":{"startLine":1205}}}],"partialFingerprints":{"codehealthFindingId/v1":"aa95a7162aa7b6316b75c102d58413a49804155997e20ef67f669edd3af0641d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: For now, this is only supported for Git. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepository.php"},"region":{"startLine":2072}}}],"partialFingerprints":{"codehealthFindingId/v1":"778c0d92ea829dc0ae662a29171699651748fd9eaeb5f7b49fbcfc81729c5929"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This should also list auditors, but handling that is a bit messy \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepositoryCommit.php"},"region":{"startLine":802}}}],"partialFingerprints":{"codehealthFindingId/v1":"e69172a984a61878c1342a103b59406c43328f42ee5e15ca1fd203fc5aab726f"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepositoryIdentity.php"},"region":{"startLine":73}}}],"partialFingerprints":{"codehealthFindingId/v1":"40832e979dc6751c09a8859dbf0a527ebb85bdebf211d289e15f6ba567e4d557"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php"},"region":{"startLine":601}}}],"partialFingerprints":{"codehealthFindingId/v1":"8c2eb13549902d390bfc3f64f9e1d5c881ef2e4b1b7987e44797a529e8b29ac6"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Denormalize repository status into the PhabricatorRepository \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/query/PhabricatorRepositoryQuery.php"},"region":{"startLine":239}}}],"partialFingerprints":{"codehealthFindingId/v1":"8c5049eb381f1a9d43353e57687b293e5457d574fcff4033fe95590cc7d86299"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This should also be denormalized. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/query/PhabricatorRepositoryQuery.php"},"region":{"startLine":260}}}],"partialFingerprints":{"codehealthFindingId/v1":"dbbb02fd48adaf69e0c2e2fc60f722b8457d9b18a633f03160f876879dbb74c6"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: It would be nice to discover only if we pulled something, but \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/management/PhabricatorRepositoryManagementUpdateWorkflow.php"},"region":{"startLine":66}}}],"partialFingerprints":{"codehealthFindingId/v1":"58d77fc53caff0842d20ae3afdb423411bab5103487740f3cbc1a28a6d1739e4"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We should report these into the UI properly, but for now just \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/management/PhabricatorRepositoryManagementUpdateWorkflow.php"},"region":{"startLine":127}}}],"partialFingerprints":{"codehealthFindingId/v1":"2c993397b38c7e85a9add5e72ac0d8fca6cad84be198ff33ee936473ab4f4cfb"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This cache stuff could be handled more gracefully, but the \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/graphcache/PhabricatorRepositoryGraphCache.php"},"region":{"startLine":246}}}],"partialFingerprints":{"codehealthFindingId/v1":"571bb1ee3d1ba6489f2d1f9041bd024a603fcd8cf5ea9b558101b87e95199a06"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Remove this once we\u0027re far enough in the future that deployment \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/engine/PhabricatorRepositoryPullEngine.php"},"region":{"startLine":733}}}],"partialFingerprints":{"codehealthFindingId/v1":"817a42d62a23637cb1dc69f82cc51a02240821ae8cdff884c54ab57f2c4401a6"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Implement support for Mercurial bookmarks. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/engine/PhabricatorRepositoryRefEngine.php"},"region":{"startLine":726}}}],"partialFingerprints":{"codehealthFindingId/v1":"7b622732ebcaa6de6ae8e40aa70759ddd8d522e996a930162be5c0687eb9be9d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Make this limit configurable after T6030 \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/customfield/PhabricatorCommitMergedCommitsField.php"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"c34ef03828ba53aef40b26a3b357b40208a9c53628aee38b8914cc868b858eea"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Some day, it would be nice to show the images. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/xaction/PhabricatorProjectImageTransaction.php"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"53bc65510b0ee83a4955bf916cc9338531b1d79af333e4e86b8ae4fb31e8d718"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Some day, it would be nice to show the images. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/xaction/PhabricatorProjectImageTransaction.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"0379e3fd45aed5de4344f4e866f41768e792ae9f2942c5275e65dcefbd8a3d28"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is a little ad-hoc, but we don\u0027t currently have \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/typeahead/PhabricatorProjectDatasource.php"},"region":{"startLine":66}}}],"partialFingerprints":{"codehealthFindingId/v1":"fd7f5020b069d72d36d4f93c477a63f0b50f8b0bffbd26f1b4d389869a3e0582"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Clarify the additional rules that parent and subprojects imply. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/storage/PhabricatorProject.php"},"region":{"startLine":177}}}],"partialFingerprints":{"codehealthFindingId/v1":"926e92e014ef001f87d7fafd40cfb67f0e42b7db9dd47883df7a939d1c2040ee"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is reachable, but probably not desirable. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/storage/PhabricatorProject.php"},"region":{"startLine":224}}}],"partialFingerprints":{"codehealthFindingId/v1":"8409aa19440bc4049d2b9bac6be94463e1d81f1bde06b2e357fc9a6277546768"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This URI is not fully state-preserving, because \u0022SearchEngine\u0022 \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/state/PhabricatorWorkboardViewState.php"},"region":{"startLine":94}}}],"partialFingerprints":{"codehealthFindingId/v1":"5c0ae5122d13961a4736e722691360021e96f498a5dcb6cacf2295b5ef25b0c5"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is possible, but probably not correct. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/policyrule/PhabricatorProjectsBasePolicyRule.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"2208849e4904401c8213514cc708c0539ee05d52af055b8087f7e37592cb539b"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: For now, only one column hit is permissible. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/engine/PhabricatorBoardLayoutEngine.php"},"region":{"startLine":524}}}],"partialFingerprints":{"codehealthFindingId/v1":"e8a8b0a53900ad90069568e03a94aff5a8583d800849cf2bd1fa045221d29ba5"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This whole method is clumsy, and the ordering for the custom \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/engine/PhabricatorProjectEditEngine.php"},"region":{"startLine":140}}}],"partialFingerprints":{"codehealthFindingId/v1":"5003b10b5c05a4719ad1baffbeb5837d7e15bb7b9422fbcdfe8a0da2dfa41f91"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We should dump an informational transaction onto the parent \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/editor/PhabricatorProjectTransactionEditor.php"},"region":{"startLine":239}}}],"partialFingerprints":{"codehealthFindingId/v1":"391544eb9632ed9961cf3f895bc420c8545c4b71bd82e883a9e1b0f3202c726f"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: For now, this is always hard-coded. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectBoardReloadController.php"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"6fa4555e57e217524d8f826ea027d899cc6e2bf137a249555d3b7490d21f5e2b"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: For now, we\u0027re not recording any transactions here. We probably \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectBoardReorderController.php"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"858c04e9a65f8fedee1b07f0562df7a788c792781591943f362ecaa7bd9149e3"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: For now, don\u0027t show subproject columns because we can\u0027t \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectBoardViewController.php"},"region":{"startLine":120}}}],"partialFingerprints":{"codehealthFindingId/v1":"d8371ac1de7b4eb7f5255a37616630ba35547ff19e4b9995921d81cc02a50b4d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: It would be desirable to build a real \u0022PHUIIconView\u0022 here, but \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectBoardViewController.php"},"region":{"startLine":397}}}],"partialFingerprints":{"codehealthFindingId/v1":"746c2e2a5e05583c8cfb326cccdb232ef6c02d5e70beff95c5c9fdc30bb83e19"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Tailor this UI if the project is already a parent project. We \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectBoardViewController.php"},"region":{"startLine":923}}}],"partialFingerprints":{"codehealthFindingId/v1":"47b81d13c3a8da8e346b52fdf0d1382a34d75ab93cf791c6c747e6495b01ff8e"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is pretty hideous. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/conduit/ProjectQueryConduitAPIMethod.php"},"region":{"startLine":116}}}],"partialFingerprints":{"codehealthFindingId/v1":"2e85e276dcbb77bca5453fb0e2d157ec575866a0a7e23b4fc40f47762d05fbd0"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO, this behaves badly when redirecting to the answer \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/ponder/controller/PonderAnswerCommentController.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"ebaa342bf014b94a90a70632484fb008ed202d98c034a8286571f3b102d57b70"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This creates a weird handle-based version of a rule policy. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/storage/PhabricatorPolicy.php"},"region":{"startLine":98}}}],"partialFingerprints":{"codehealthFindingId/v1":"754b7de84cbff030c7cc4f496688bffb47d7e2e6f40f885fe2ccac71e00534cd"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This could be friendlier. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/filter/PhabricatorPolicyFilter.php"},"region":{"startLine":398}}}],"partialFingerprints":{"codehealthFindingId/v1":"e85f7f033421147ea4282a94b49f945956d3c87088c01203725cb8dbfd27840a"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Formalize this somehow? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/filter/PhabricatorPolicyFilter.php"},"region":{"startLine":509}}}],"partialFingerprints":{"codehealthFindingId/v1":"8321104cfc73213ffdb30bc923160e33e7a25e00b29869c80ec5fcaab8373e49"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is reachable, but probably not ideal. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/filter/PhabricatorPolicyFilter.php"},"region":{"startLine":579}}}],"partialFingerprints":{"codehealthFindingId/v1":"e354464fe9bcb991db7fc209275b2bac97b088e6ab105ea2e5d3b5986ca3209b"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is a bit clumsy. We\u0027re producing HTML and text versions of \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/filter/PhabricatorPolicyFilter.php"},"region":{"startLine":663}}}],"partialFingerprints":{"codehealthFindingId/v1":"a568271c595f0aba5c753ad7b4ba95e418757e02972d701cf7d606b84ecb482f"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is reachable with a public viewer, but probably not ideal. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/filter/PhabricatorPolicyFilter.php"},"region":{"startLine":760}}}],"partialFingerprints":{"codehealthFindingId/v1":"2ea9f6cdf7fa1fb043a81c8e782288fb7a0643bda02d9cc1898e70979b5c3b30"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is reachable with a public viewer, but probably not \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/filter/PhabricatorPolicyFilter.php"},"region":{"startLine":770}}}],"partialFingerprints":{"codehealthFindingId/v1":"009c2ee7cc2249a46ea559ccda8228fe116f7a3a3858471bcbf156dc02e2ce68"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is reachable with a null viewer, but probably should not be. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/filter/PhabricatorPolicyFilter.php"},"region":{"startLine":829}}}],"partialFingerprints":{"codehealthFindingId/v1":"eaed3705891209009974c74e91b778741ae4993f9285d29b10917ef77312a1c8"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is reachable without a PHID, but probably not ideal. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/filter/PhabricatorPolicyFilter.php"},"region":{"startLine":850}}}],"partialFingerprints":{"codehealthFindingId/v1":"a71e435d31e2881f8bf19f516001e8dbb6f49266103a8e0ee1660a13ad99485f"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Move Ancestry validation here once all types are converted. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/xaction/PhrictionDocumentMoveToTransaction.php"},"region":{"startLine":95}}}],"partialFingerprints":{"codehealthFindingId/v1":"9ae730af9dbb647e1344d4c286a6c3ace6bdd15158cb351e6aed57aa04440da8"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: These are not quite correct, but we don\u0027t currently store the \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/search/PhrictionDocumentFulltextEngine.php"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"2a803e53e95014096c185df687344187f2150309f5ccbd1af266714fe70ddfb6"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO - some magical hotness via T5873 \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/conduit/PhrictionCreateConduitAPIMethod.php"},"region":{"startLine":66}}}],"partialFingerprints":{"codehealthFindingId/v1":"f0fba4a6250f2f481045ecb2f0a9bcc6b9c42e5dd6b96b400bac15f9aa4e6591"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO - some magical hotness via T5873 \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/conduit/PhrictionEditConduitAPIMethod.php"},"region":{"startLine":70}}}],"partialFingerprints":{"codehealthFindingId/v1":"b8f3ac3eddde614e5bdae7f6f56163d8401939d2901cf0636a800a90147964c4"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This isn\u0027t really ideal. It would be better to use an application \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/worker/PhortuneSubscriptionWorker.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"a2bdb21029e9f4ed58d8b54e749edcc918ed728dd3181f6aae92bb10e92b7df8"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Perform purchase review. Here, we would apply rules to determine \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/storage/PhortuneCart.php"},"region":{"startLine":207}}}],"partialFingerprints":{"codehealthFindingId/v1":"a3307706ec1b8b344220a8dd8a7fcd481c7bd42e4c2e1142f6b08c780c65943a"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Allow providers to improve this. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/storage/PhortunePaymentProviderConfigTransaction.php"},"region":{"startLine":42}}}],"partialFingerprints":{"codehealthFindingId/v1":"b94743b35276089976759ddb7615f277240102796ba7146a097b5636340f861f"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Handle these. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/provider/PhortunePayPalPaymentProvider.php"},"region":{"startLine":221}}}],"partialFingerprints":{"codehealthFindingId/v1":"177ef4a7ec465c3e39498c458f2ecf9a2f280077c90e40eb8e29800b050c7f07"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Also handle these better? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/provider/PhortunePayPalPaymentProvider.php"},"region":{"startLine":225}}}],"partialFingerprints":{"codehealthFindingId/v1":"d0286d6903f0c24fac64013d13b19216d0ae202f1cb555797024e08e60be9469"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This should be cart-dependent if we eventually support \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/provider/PhortunePayPalPaymentProvider.php"},"region":{"startLine":341}}}],"partialFingerprints":{"codehealthFindingId/v1":"ba8040d085eabc77fc1e22591e058fc1cf4961b6e2510fbceb598259a66f47ac"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We can capture more information about this stuff. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/provider/PhortunePayPalPaymentProvider.php"},"region":{"startLine":429}}}],"partialFingerprints":{"codehealthFindingId/v1":"d083d3895856937b96b900f40ed000c8744d791d7af72b0e2eb17a70bc8f5a1f"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Since the user cancelled this, we could conceivably just \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/provider/PhortunePayPalPaymentProvider.php"},"region":{"startLine":478}}}],"partialFingerprints":{"codehealthFindingId/v1":"64f4875de7fdd7c9c8879c4e1747d51fd257cce9e536d2b3a998ff06d6dce09e"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Deal with disputes / chargebacks / surprising refunds. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/provider/PhortuneStripePaymentProvider.php"},"region":{"startLine":201}}}],"partialFingerprints":{"codehealthFindingId/v1":"0c33ce0fc8e96ae53d0df58285e12380c661c7fe4161769355e51ca09a3f1714"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: At least some of these should have a better message, or be \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/provider/PhortuneStripePaymentProvider.php"},"region":{"startLine":377}}}],"partialFingerprints":{"codehealthFindingId/v1":"2905ae5643dca0e2df125e5d8b4abe73406b915f12f4fd670c01d3920b747d14"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Callback the subscription. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/product/PhortuneSubscriptionProduct.php"},"region":{"startLine":62}}}],"partialFingerprints":{"codehealthFindingId/v1":"cf23e0511d4a7c59444dcc89abcc5e79eefca12222731ed2e443726220e37f5c"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This should check for integer overflows, etc. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/currency/PhortuneCurrency.php"},"region":{"startLine":142}}}],"partialFingerprints":{"codehealthFindingId/v1":"97dd73839a83877ef80185a3043d4f61a17838cd399801aacda9dabdc5af1289"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This should check for integer overflows, etc. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/currency/PhortuneCurrency.php"},"region":{"startLine":156}}}],"partialFingerprints":{"codehealthFindingId/v1":"42a173d72feb99f9df45817aabca0c27bc76d3fa1048fe1e046aba1e43c2c479"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Make this work again, or destroy it. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/merchant/PhortuneMerchantInvoiceCreateController.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"60389cc5618ec56e5f27da3ae95079aaa7910130c6cabd39fb2960649e212bb1"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: If every HOLD and CHARGING transaction has been fully refunded \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/cart/PhortuneCartCancelController.php"},"region":{"startLine":155}}}],"partialFingerprints":{"codehealthFindingId/v1":"ff454f75d1ec58f24c2bd7b6631547d87ba3d3a6a75447596d7e9d5b1ab51302"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: If a payment method has expired or is expiring soon, we should \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/account/PhortuneAccountOverviewController.php"},"region":{"startLine":120}}}],"partialFingerprints":{"codehealthFindingId/v1":"a6c6164df180d0e0c34fa82881eeb73337c4b0a5496d0258721ff3329866a362"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: You shouldn\u0027t be able to replace an image if it has already \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/pholio/xaction/PholioImageReplaceTransaction.php"},"region":{"startLine":132}}}],"partialFingerprints":{"codehealthFindingId/v1":"52118a09ab7b544bf53d6a31841018affbe12887e629dadc79e7896cfd438076"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We could maybe do a better job with tailoring this, which is the \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/pholio/view/PholioMockImagesView.php"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"9508368f7696bc7ce34f8e532c6e1fe6ca992eac4b4745872f8becb1f1cc4993"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Not correct, but we don\u0027t always have a mock right now. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/pholio/controller/PholioInlineController.php"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"72d4de617b11ad4c92c517268c179aff8c062e12ada27aebab7396194184b5a7"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: It would be nice to render this with a proper \u003Cul /\u003E, at least \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phid/view/PHUIHandleListView.php"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"3ccae952371fdd4948de6ed75b146c2058256855e416b8cd7ed5752220dfd95f"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is reachable with \u0022null\u0022 in the list, but probably should \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phid/handle/pool/PhabricatorHandlePool.php"},"region":{"startLine":29}}}],"partialFingerprints":{"codehealthFindingId/v1":"d603dec2ca7c75e74af6f3a9155a8ed680852e9d57167f2c663959016bb24713"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Migrate these transactions ha ha .... ha \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/xaction/PhameBlogHeaderImageTransaction.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"ee5049d621f454b5836052c355e76af9f1df3017cf6a750c1d4d9cbd42c6c5fc"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Migrate these transactions ha ha .... ha \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/xaction/PhameBlogProfileImageTransaction.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"603617c31dfa6bddb4da6a267e564aeec356f1877173404b17e329c43b8d9242"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Can we set this without breaking public blogs? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/query/PhameBlogQuery.php"},"region":{"startLine":138}}}],"partialFingerprints":{"codehealthFindingId/v1":"6e7445546bbd19024eb09d6df85c160a0b946bec1f84c6058811a2893c0c3101"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Does setting this break public blogs? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/query/PhamePostQuery.php"},"region":{"startLine":178}}}],"partialFingerprints":{"codehealthFindingId/v1":"3f3400302ce4e5635dc451500242ea691864c1eda6cb038a8d5d261a8eadad3c"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is incorrect in the general case, but: \u0022PolicyRule\u0022 currently \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/policyrule/PhameInheritBlogPolicyRule.php"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"d6143901755eb961a88babe37c24d024a2454d76a7782513d02a26131a5c8876"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Remove these (see T13493). These columns are obsolete and have \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/storage/PhabricatorExternalAccount.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"9eaea0968ec1e5bf64a869a36be1fb3b2702e7e591c4bdb1b5b46b85704ddec2"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This unlinks (but does not destroy) any profile image. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/storage/PhabricatorExternalAccount.php"},"region":{"startLine":109}}}],"partialFingerprints":{"codehealthFindingId/v1":"ca025f62738f5b099d653e96f684fa334deee2ce6c62e2c2752d190976bfaea5"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This may leave a profile image behind. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/storage/PhabricatorExternalAccount.php"},"region":{"startLine":245}}}],"partialFingerprints":{"codehealthFindingId/v1":"6a9275c62c70a788c1d41497bddfc38ad5aa2046377528258dd8b2bb11b82aed"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: These permissions aren\u0027t very good. They should just be the same \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/storage/PhabricatorExternalAccountIdentifier.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"749cb5f2b557e687704775e119c1311828c057bc197c29859de69dc24254f1e9"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We might let the user switch which space they\u0027re \u0022in\u0022 later on; \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/storage/PhabricatorUser.php"},"region":{"startLine":637}}}],"partialFingerprints":{"codehealthFindingId/v1":"e3ac7b51f17b552f418a4a20fec0423cc7016ca0ba37ab9c38426c94ee44bdc7"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We could test that this is a valid username and jump to \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/engineextension/PhabricatorPeopleDatasourceEngineExtension.php"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"51f40d4b3af3caef06c13be65647aa17b0a3a739617ddd839479fab09b00335a"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: The copywriting on this mail could probably be more \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/controller/PhabricatorPeopleInviteSendController.php"},"region":{"startLine":75}}}],"partialFingerprints":{"codehealthFindingId/v1":"7ceb8ccb9f0766d1b58c3fc4d03849843f1222e264e19519ef21a836cf04de04"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is a bit anticlimactic. We don\u0027t really have anything \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/controller/PhabricatorPeopleInviteSendController.php"},"region":{"startLine":107}}}],"partialFingerprints":{"codehealthFindingId/v1":"93026571b557e840721928a752da20b667be8bfa7bfbf7db713b8740927b9e77"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Modernize this once we have a more long-term view of what the \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/conduit/UserConduitAPIMethod.php"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"42f9bd6f33e20502149d0bc0e208399982eb7b33d4975dbaafcba8c218aa73d1"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Attach owners here \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/owners/xaction/PhabricatorOwnersPackageOwnersTransaction.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"bb8de0c72dea0f53f36066b43b6b1b70c03a7a05c09a764ed9cb65fd296e880d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Flesh this out. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/owners/xaction/PhabricatorOwnersPackagePathsTransaction.php"},"region":{"startLine":182}}}],"partialFingerprints":{"codehealthFindingId/v1":"377a9ca1c500a6a28a7cd98ae58aae23f811591b0e9b3275b59389bfb9467f21"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: It would be nice for this to handle \u0060packages(#project)\u0060 from a \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/owners/typeahead/PhabricatorOwnersPackageOwnerDatasource.php"},"region":{"startLine":116}}}],"partialFingerprints":{"codehealthFindingId/v1":"5bd0a4aca68e48c8aeccd25d82225043a55f99de92cc4de027facb1c4e61e72d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Move these to \u0022/O123\u0022 for consistency. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/owners/storage/PhabricatorOwnersPackage.php"},"region":{"startLine":582}}}],"partialFingerprints":{"codehealthFindingId/v1":"f2de4010b722d615c41008c4fefecc5a076129490b76ee5416e7ebaae283a1f7"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: These are bogus, but not currently stored on packages. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/owners/search/PhabricatorOwnersPackageFulltextEngine.php"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"45424c42b9edb4d519a65085e3e13b6d07106ee46c8a1b04b9eba02f2a59cb13"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO -- T844 set headers with X-Auth-Scopes, etc \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/oauthserver/PhabricatorOAuthResponse.php"},"region":{"startLine":78}}}],"partialFingerprints":{"codehealthFindingId/v1":"0cb87add6d9f54eb7b544cf3700fdfd9536992fbf587fd95d6b899f5a9021da1"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: It would be nice to simply disable this panel, but we can\u0027t do \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/oauthserver/panel/PhabricatorOAuthServerAuthorizationsSettingsPanel.php"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"ddb33abb6f448ff1560ba07e17f527b80f01d05aea8cd9d3bc507f5f0be2a05d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: It would be nice to give the user more options here, like \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/oauthserver/controller/PhabricatorOAuthServerAuthController.php"},"region":{"startLine":203}}}],"partialFingerprints":{"codehealthFindingId/v1":"ca38db8cacc6e1d1e0066f5d740dd6ff510fcf9d6a2088d2d191959395ba18be"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Once we introduce more scopes, explain them here. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/oauthserver/controller/PhabricatorOAuthServerAuthController.php"},"region":{"startLine":266}}}],"partialFingerprints":{"codehealthFindingId/v1":"e6ffa295ac25718bdabc6d46afbcde974ce026c541d0c4845c3bc101a824cdfe"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: It would be nice to put scope options in this dialog, maybe? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/oauthserver/controller/client/PhabricatorOAuthClientTestController.php"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"046b323f5c5945add203c65ca5e3680a01eb1a84af3754e0e23d3cade51c7811"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Assign, unassign strings probably need variants. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/xaction/NuanceItemOwnerTransaction.php"},"region":{"startLine":18}}}],"partialFingerprints":{"codehealthFindingId/v1":"3e4c6383ad881d3625f409da728b7b1f4b5eac04b82fc25976020e769e50d040"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Make this use real typeahead logic. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/typeahead/NuanceQueueDatasource.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"c21c91e76c6943b10c3e8fb5ed1f245bc33d001868f9a36ec8b1daa03627b788"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Validate that the type is valid, and construct and attach it. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/storage/NuanceItem.php"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"473d6ce205563468a1177c2a014a39e298eab2cbb38410989eae663c878f6038"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO - this should be based on the queues the item currently resides in \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/storage/NuanceItem.php"},"region":{"startLine":119}}}],"partialFingerprints":{"codehealthFindingId/v1":"fdd06e32ec1168bb8fea162f1f1cc6c8c3522a5753a534126d38561143d3abb9"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO - requestors should get auto access too! \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/storage/NuanceItem.php"},"region":{"startLine":124}}}],"partialFingerprints":{"codehealthFindingId/v1":"cb133f64d6cf53dfdfbffe29e9fef1b7b0c1e443dc344a1b0bb9ae085883aed0"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: As above, this would eventually be driven by custom logic. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/source/NuancePhabricatorFormSourceDefinition.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"351771671709e050b4350f5bb43d578cf3cf6789f6c12a3c2980929c6d7485eb"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Should we have a tighter actor/viewer model? Requestors will \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/source/NuanceSourceDefinition.php"},"region":{"startLine":157}}}],"partialFingerprints":{"codehealthFindingId/v1":"461441106636a70e04754d474ef67507877c56706500d1690befb7b0de8b3b3f"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Eventually, apply real routing rules. For now, just put everything \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/source/NuanceSourceDefinition.php"},"region":{"startLine":170}}}],"partialFingerprints":{"codehealthFindingId/v1":"444283ac4fcdb3c2784371e5dcab83337423bf6ac66afa35e36e519a76cfdcab"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Maybe this should all be modular transactions now? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/source/NuanceSourceDefinition.php"},"region":{"startLine":176}}}],"partialFingerprints":{"codehealthFindingId/v1":"75bec2e07b80fee470e40c6c5dcda031bdc3714ee1cf131d85d9cdc3b8b8fa16"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This code is no longer reachable, and has moved to \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/item/NuanceGitHubEventItemType.php"},"region":{"startLine":334}}}],"partialFingerprints":{"codehealthFindingId/v1":"3ad980744e7f4e85a2255b4790839d098836ae214a90c6ebb344064527ea11de"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Write some kind of marker to prevent double-synchronization. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/item/NuanceGitHubEventItemType.php"},"region":{"startLine":360}}}],"partialFingerprints":{"codehealthFindingId/v1":"e2cfb6d87149dc55bb467f5bb61c8290f50c63ffde143e25b632935d7bffb453"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Synchronize state. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/item/NuanceGitHubEventItemType.php"},"region":{"startLine":411}}}],"partialFingerprints":{"codehealthFindingId/v1":"244b9acf14aa79f677632eaf1f2d183882d2eac468214b359be2d083969e85a7"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is wrong, some of these are pull events. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/github/NuanceGitHubRawEvent.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"a478d70084b72183105c707fcbe9d5cf3891b92376b8f948a66bf744f61bf1be"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: When we go through the whole queue without hitting anything we \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/cursor/NuanceGitHubImportCursor.php"},"region":{"startLine":164}}}],"partialFingerprints":{"codehealthFindingId/v1":"52c4c1f5f5b704967aba32b9c93a49a8e0ff8d67fdf165a4d06ff171cd3971a8"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is bad: we missed some items, maybe because too much \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/cursor/NuanceGitHubImportCursor.php"},"region":{"startLine":170}}}],"partialFingerprints":{"codehealthFindingId/v1":"c94a20c1ce6dc0dcfd1ba23bbc76b23a3a3081ec9d7a3054a2d5e700fc11d949"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is OK, we\u0027re doing the initial import. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/cursor/NuanceGitHubImportCursor.php"},"region":{"startLine":174}}}],"partialFingerprints":{"codehealthFindingId/v1":"58218f806d464f787c177f1dd009f3d8ec58859b480d0a1b96a28984bf1dfc8e"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Move this stuff to a new Engine, and have the controller and \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/controller/NuanceItemActionController.php"},"region":{"startLine":99}}}],"partialFingerprints":{"codehealthFindingId/v1":"7e865c49704f5a943184882370821cd4d0ddb7668137858f8b7d50d8a54c3fda"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Maybe preserve the actor\u0027s original content source? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/nuance/command/NuanceCommandImplementation.php"},"region":{"startLine":73}}}],"partialFingerprints":{"codehealthFindingId/v1":"1a413309a9617124d7a101672d9a27aa7713fc503e78f1fde1b5383aa11c93f5"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: It would be nice to retain the \u0022page updated\u0022 bubble on copies \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/notification/controller/PhabricatorNotificationIndividualController.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"8dd576aaef0e76be795aeb111c919fd463fea73b3a835b59fb98cf51b50e489d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Render a nice debuggable notice instead? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/notification/builder/PhabricatorNotificationBuilder.php"},"region":{"startLine":131}}}],"partialFingerprints":{"codehealthFindingId/v1":"a6f0956d7482ad6d6a52b5d6b5461a8f69b66eb92c2b4a7fde52db977d8cf96f"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Make this browsable. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/typeahead/PhabricatorMetaMTAApplicationEmailDatasource.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"21a7017106e6caae23fc1938a7725254ceef52803ee4bd992ff12fdc80d87862"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We should eventually get rid of these and get rid of this \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/storage/PhabricatorMetaMTAMailProperties.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"d65859382a30f000dceebed13df8e54d8cbc1a8b0089318c1b9814875387410f"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Since headers don\u0027t necessarily have unique names, this may not \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php"},"region":{"startLine":468}}}],"partialFingerprints":{"codehealthFindingId/v1":"5609745738b93e754cc888699fda5655e0efec675da77c2122980a1baba0124d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This recovers from a bug where blocking reviewers were serialized \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/stamp/PhabricatorPHIDMailStamp.php"},"region":{"startLine":18}}}],"partialFingerprints":{"codehealthFindingId/v1":"f64c5992656a86fdae85b258085c7c67b41df6f8c33a97e3e52e88cebe84d246"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Move this to PhabricatorPHIDType, or the objects, or some \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/query/PhabricatorMetaMTAActorQuery.php"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"91535f390d0c4bc936094ca6caaec8015c3813c96b33d174210b5e7d9af38293"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Generalize this somewhere else. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/query/PhabricatorMetaMTAMemberQuery.php"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"a1499d4c54f181b7ec1b1dced344881000049602a579dcdcc4a8eed8fdfd8222"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This logic needs to be revised when we legitimately support \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/editor/ManiphestTransactionEditor.php"},"region":{"startLine":739}}}],"partialFingerprints":{"codehealthFindingId/v1":"3012c2c535088ccba832352ea0a064c0bf26daf83a925c77fb5f6d9f72aeaab4"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is silly, but this is Maniphest reports. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/controller/ManiphestReportController.php"},"region":{"startLine":424}}}],"partialFingerprints":{"codehealthFindingId/v1":"65d5838800b93ada13bd874664a33ba71220370ee8251dea2cd39deac156fc4b"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is sort of a hard-code for the default \u0022normal\u0022 status. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/controller/ManiphestReportController.php"},"region":{"startLine":626}}}],"partialFingerprints":{"codehealthFindingId/v1":"7b390b3c410acff9490116e8d5994279e385239e8e2af79ceb001946ec9fde8c"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Gross. This table is not meant to be queried like this. Build \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/controller/ManiphestReportController.php"},"region":{"startLine":773}}}],"partialFingerprints":{"codehealthFindingId/v1":"c81e603466d242a10c21a640b5ad61280b78a59f5e2afdd04ea8b6b91bc45d14"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: It would be nice to render this as pinboard-style thumbnails, \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/controller/ManiphestTaskDetailController.php"},"region":{"startLine":442}}}],"partialFingerprints":{"codehealthFindingId/v1":"58ec0aac217b1e38a2343e5ed80181c0f7ad98c22464ef13b431c545e64f1c11"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Batch this get as CustomField gets cleaned up. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php"},"region":{"startLine":234}}}],"partialFingerprints":{"codehealthFindingId/v1":"bdce2590b2739de2ef972ee6994af71b7c5a56d37ab37acfea32ea37598f8aae"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is misspelled! See T13005. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/legalpad/xaction/LegalpadDocumentPreambleTransaction.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"de251edd197d3fde79e44f613cc6c1b615fa93e1e7b29750ebcfe7b37c0518d7"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is misspelled! See T13005. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/capability/HarbormasterBuildPlanDefaultViewCapability.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"c43794401d601d9a18a34266fde05273b8662779e20bd7bbe9f2cae2a2d0363f"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is misspelled! See T13005. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorLDAPAuthProvider.php"},"region":{"startLine":198}}}],"partialFingerprints":{"codehealthFindingId/v1":"3b72d501a5b43943cb32be76cbd4cebffee073b29ac0b81732e4325015df53a7"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This should be made browsable. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/legalpad/typeahead/LegalpadDocumentDatasource.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"4767292ded1f6ef14384e58b9128164144ff478e70c03f59af27af5ab6dad17e"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This accepts signature of any version of the document, even an \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/legalpad/policyrule/PhabricatorLegalpadSignaturePolicyRule.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"aab34d0d6f9fe0d04f29b560e2c01d58e97ff1a28de92d8b08a2640d5c501ba4"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This could probably be more general. Note that we call \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/legalpad/herald/LegalpadRequireSignatureHeraldAction.php"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"c93d7e61427c3a353a7237eea581521ca85978ba913e7e83dedddaf27b670d62"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is odd and should probably be adjusted after \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/legalpad/controller/LegalpadDocumentSignController.php"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"5f3a287a972ac87644776635f2253bd1def4162c61fd955adfc46af28085bcfa"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This class was renamed, but we have a migration which affects the \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/storage/HeraldActionRecord.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"519397efa8ca53e0fe5aa68de1ebb91ee5aa667c57e1b9df4cdcc6ab228b4134"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: It is possible, but probably not correct, to arrive here with an \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/storage/HeraldRule.php"},"region":{"startLine":81}}}],"partialFingerprints":{"codehealthFindingId/v1":"524a26b6534ad580685b2d40dfd81b685036074a30d76627f699a2b2b0526d53"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: validate conditions have been attached. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/storage/HeraldRule.php"},"region":{"startLine":104}}}],"partialFingerprints":{"codehealthFindingId/v1":"6de8a6aef828d7f74eb2b3c009b22e42c2b3da5cc60ab640d600bc7f75f07e1a"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: validate actions have been attached. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/storage/HeraldRule.php"},"region":{"startLine":118}}}],"partialFingerprints":{"codehealthFindingId/v1":"6fd990c9d05aa95999ee63cec1491427dd2906cefd28f2413c966f01dd0c0f0a"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We should filter these out in the Query, but we have to load \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/controller/HeraldTranscriptController.php"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"efdaa34cbd15d276ac1b533691191407e2a702082014ac8e5ace61291bfdbc67"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is all a hacky mess and should be driven through FieldValue \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/controller/HeraldTranscriptController.php"},"region":{"startLine":101}}}],"partialFingerprints":{"codehealthFindingId/v1":"f273d667d2c9d27f818563689f3d0cc8a8346687164130425123ed92b2d4be64"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is total hacks. Add another amazing layer of abstraction. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/controller/HeraldTranscriptController.php"},"region":{"startLine":142}}}],"partialFingerprints":{"codehealthFindingId/v1":"cb4d0d84dea4b2635ea22cbcb3153f061e79170bff50f3f0aa09ce060ff100b9"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Also total hacks. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/controller/HeraldTranscriptController.php"},"region":{"startLine":168}}}],"partialFingerprints":{"codehealthFindingId/v1":"73e83cbcc34692ebb218f7b97b796d491368f24c6b8b81d1451f0b0f004ac8d6"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Probably need to make sure this \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/controller/HeraldTranscriptController.php"},"region":{"startLine":172}}}],"partialFingerprints":{"codehealthFindingId/v1":"40b8aca1f12819fad90a15b820f6bf41e7be2b5e341ed725eef994462945f2f6"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is not really translatable and should be driven through \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/controller/HeraldTranscriptController.php"},"region":{"startLine":291}}}],"partialFingerprints":{"codehealthFindingId/v1":"69600b0d543fab98be714a3c49145d43b44d77da0a3cbaf335008a58edb69f98"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Add some color here? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/view/HarbormasterLintPropertyView.php"},"region":{"startLine":86}}}],"partialFingerprints":{"codehealthFindingId/v1":"cb585af6ea5be9b8d100f49facd9440aa9ce78fa09a099e1e5081ccf4c89c5be"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Provide nice links. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/view/ShellLogView.php"},"region":{"startLine":62}}}],"partialFingerprints":{"codehealthFindingId/v1":"5951a620d235a22f939becc546580dc5e06a6f41e31bbf5a50c41ad0c7e7fd18"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This should be browsable, but fixing it is involved. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/typeahead/HarbormasterBuildDependencyDatasource.php"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"6d3b6f89b60eae39f4077378d716405c8d9b6caa7558d7db7bbe4dc552f78036"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This should be communicated more clearly -- maybe we should \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/storage/HarbormasterBuildable.php"},"region":{"startLine":113}}}],"partialFingerprints":{"codehealthFindingId/v1":"02da87cb07367a4c48da881a265fe10da112924412234d8308cd146e3cac0f41"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This should become transactional. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/storage/build/HarbormasterBuild.php"},"region":{"startLine":394}}}],"partialFingerprints":{"codehealthFindingId/v1":"dc182f688da54adb294e468a5bf89607f5b0c9dabe7771c1fcb625ff6aa77e48"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Maybe use more numeric values after T6861. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/storage/build/HarbormasterBuildLintMessage.php"},"region":{"startLine":138}}}],"partialFingerprints":{"codehealthFindingId/v1":"ddba6e5da96430c26fcab8491d6910cc76fa6b2f6e649be328ab530305eeb1fc"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Remove this method since it won\u0027t scale for big logs. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/storage/build/HarbormasterBuildLog.php"},"region":{"startLine":268}}}],"partialFingerprints":{"codehealthFindingId/v1":"0ac4c6e9f6182e20d67aad7822fa93137900717489f37afa7417afd17d55001f"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Maybe don\u0027t flush more than a couple of times per second. If a \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/storage/build/HarbormasterBuildLog.php"},"region":{"startLine":485}}}],"partialFingerprints":{"codehealthFindingId/v1":"2a421d930c57bb935563f94994bf951f5b06bc07a7b242718aab65b5383dff4a"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We don\u0027t currently preserve the entire \u0022HTTP\u0022 response header, but \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/step/HarbormasterBuildStepImplementation.php"},"region":{"startLine":298}}}],"partialFingerprints":{"codehealthFindingId/v1":"e216e6e9449602fff9a74abeb6c448bcc9d04f9cbf10594e2c4167a25c9734d0"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Require active lease. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/step/HarbormasterDrydockCommandBuildStepImplementation.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"25a1ff055d3644403d834263d8778c36c908a40c1d94b6c9f88aeb011c7fd33b"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We should probably have a separate temporary storage area for \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/step/HarbormasterLeaseWorkingCopyBuildStepImplementation.php"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"842a6aef0a59ff60d5c00391d5ace30007837c26f09d922a42221da248dab023"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Maybe add a method to mark artifacts like this as pending? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/step/HarbormasterLeaseWorkingCopyBuildStepImplementation.php"},"region":{"startLine":65}}}],"partialFingerprints":{"codehealthFindingId/v1":"9ba3d62100da860c1dfcf191647975e592330b73d5ca4c9a2d8961138b207d2d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Smart backoff? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/step/HarbormasterLeaseWorkingCopyBuildStepImplementation.php"},"region":{"startLine":85}}}],"partialFingerprints":{"codehealthFindingId/v1":"405b55a1056bfe16525b894ecbe28ab14abd6c97fc3ea7b6c81a4d4bc919229a"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We could just forget about this lease and retry? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/step/HarbormasterLeaseWorkingCopyBuildStepImplementation.php"},"region":{"startLine":90}}}],"partialFingerprints":{"codehealthFindingId/v1":"72e1428a0e57c7fb5bc688ce69841aa3fffadb135a9b11181b0bfc2392962374"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Handle exceptions. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/step/HarbormasterUploadArtifactBuildStepImplementation.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"a4490cffa2e5e2aaafd9c1c500fd588a65dfd9c0cb2024b283cbd65527469973"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Some day, when targets have dependencies, we should toposort \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/query/HarbormasterBuildQuery.php"},"region":{"startLine":119}}}],"partialFingerprints":{"codehealthFindingId/v1":"b026cd4c956ec8f402f8e5c346a9d98169fc270f612cff02dc380d95faadcaad"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Instead of using string lists, we should ideally be using some \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php"},"region":{"startLine":58}}}],"partialFingerprints":{"codehealthFindingId/v1":"b738d4b644cf49efabf1e527f191242046ed2b1f4f60d47f2abf044360cbb42b"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This should probably be implemented as a FutureProxy; it will \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/future/HarbormasterExecFuture.php"},"region":{"startLine":51}}}],"partialFingerprints":{"codehealthFindingId/v1":"1c6a3091d0422cf044d37094db53a5de6a272107bf9981d0ea37817349ff3124"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is a bit hacky and we could probably find a cleaner fix \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/event/HarbormasterUIEventListener.php"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"297b943c713934954513f4afa994292d1cac2890b9071221fc980eedc836cc6e"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: See PHI430. When this query raises a policy exception, it \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/event/HarbormasterUIEventListener.php"},"region":{"startLine":63}}}],"partialFingerprints":{"codehealthFindingId/v1":"de69ab7da6a5e199ed584ebe2a9020fe9e735e931906c2e58076f63de2d4351b"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This should be a transaction. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/engine/HarbormasterBuildEngine.php"},"region":{"startLine":147}}}],"partialFingerprints":{"codehealthFindingId/v1":"c11a1d4804b4b03fa4eda886c04a12b2bdb3ddca5604fa9925984888a98100d6"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Remove this after enough time has passed for installs to run \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php"},"region":{"startLine":466}}}],"partialFingerprints":{"codehealthFindingId/v1":"4e46201d7d4c5d55dfb0ec8d52da37b15d67ffeb09aa845fe0e21e1550355f9a"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is hacky and artifact parameters should be replaced more \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/artifact/HarbormasterURIArtifact.php"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"4593f51fc1c446c006267cafb041d60668d71967505463a5b39d51931748ef2d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This should probably be a sprite sheet. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/flag/view/PhabricatorFlagSelectControl.php"},"region":{"startLine":29}}}],"partialFingerprints":{"codehealthFindingId/v1":"c3bb7bb37679feab3392a1884c0f721dee7b4a18795f54547c0f62b7315bc947"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is a bit iffy. Sometimes, getBestURI() returns a CDN URI \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/storage/PhabricatorFile.php"},"region":{"startLine":1558}}}],"partialFingerprints":{"codehealthFindingId/v1":"14f753c15be02531c6d88812a5286ee0c0f5774c99fe82726860c3f0b392df0d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: It might be nice to put this directly on PhabricatorFile and \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/query/PhabricatorFileQuery.php"},"region":{"startLine":239}}}],"partialFingerprints":{"codehealthFindingId/v1":"dda4183d5fbb9cde8cbfee376a81242aa4753846325a2839f845de8f9380c1cb"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Validate icons. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/iconset/PhabricatorIconSet.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"c31c0b1b7d20477b689de540195c014c409cc2eb2d2fe5bed695d74a90d4e695"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: For now, this EditEngine can only edit objects, since there is \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/editor/PhabricatorFileEditEngine.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"75d688661bb6f33d281b7c52cc0a645d9f76b8c359647a3979ff0993f051e3d2"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This should ideally highlight as Markdown, but the \u0022md\u0022 \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/document/PhabricatorJupyterDocumentEngine.php"},"region":{"startLine":511}}}],"partialFingerprints":{"codehealthFindingId/v1":"e400514c98691ede80e4f706319f06a0bae5480271e02c2b70b95726622ef97a"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We could just delegate to the file view controller instead, \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/controller/PhabricatorFileTransformController.php"},"region":{"startLine":108}}}],"partialFingerprints":{"codehealthFindingId/v1":"6a124763ee57c671841053fa7f02e13cd588aa5c845b348ce9a6778f9e534324"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // Do the math in MySQL. TODO: If we formalize a bc dependency, get \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/feed/PhabricatorFeedStoryPublisher.php"},"region":{"startLine":326}}}],"partialFingerprints":{"codehealthFindingId/v1":"70a1358e884563c2b47a5267ea3ca8f6c3b4207d95cf985e4899c7d4e4e842ec"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // Do the math in MySQL. TODO: If we formalize a bc dependency, get \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/feed/storage/PhabricatorFeedStoryData.php"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"a423dde10029c4a6850ce43f914cc06a5deac1cc8c04eeebaa29503059ca2e7a"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Use PhutilClassMapQuery? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/feed/worker/FeedPublisherWorker.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"6b729b15e7dd9eae7dae8f0c44a9a52668503207be5610fa3c5fac599fb3e912"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This (and text rendering) should be properly abstract and \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/feed/story/PhabricatorFeedStory.php"},"region":{"startLine":265}}}],"partialFingerprints":{"codehealthFindingId/v1":"7745c3ec21510371ac97d8164cce932761f9f7b2265a0f25a5c901cc878f7a3c"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This might be a questionable assumption? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fact/engine/PhabricatorManiphestTaskFactEngine.php"},"region":{"startLine":108}}}],"partialFingerprints":{"codehealthFindingId/v1":"5136c50a06713ca8e276094bff142f8c64a23ea4fa0c2b6d6d8d68bccf3cdb37"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This doesn\u0027t work especially well right now. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fact/chart/PhabricatorChartDataQuery.php"},"region":{"startLine":62}}}],"partialFingerprints":{"codehealthFindingId/v1":"401208d90511adda3bba940798fde3a56882ac4dd5b51e33e70361b5fada9f3b"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This could be validated better, but probably should not be \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fact/chart/PhabricatorChartFunctionArgument.php"},"region":{"startLine":56}}}],"partialFingerprints":{"codehealthFindingId/v1":"79c8925356588c0ee41e8c4c5b356a054627f84f4055604592bb9d012f0c740f"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is not entirely correct. The correct implementation would \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fact/chart/PhabricatorComposeChartFunction.php"},"region":{"startLine":74}}}],"partialFingerprints":{"codehealthFindingId/v1":"e95a1e6779fb2462d72f4ef7a061b3db17e48bf66c56fcacce5d10be486d9bae"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Implement improvements to this ranking algorithm if they become \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/worker/DrydockLeaseUpdateWorker.php"},"region":{"startLine":742}}}],"partialFingerprints":{"codehealthFindingId/v1":"85b687f4f8eb2207251e9eaca85d969e2f73ad468383aec5368b0b7d72cc001d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Implement improvements to this ranking algorithm if they become \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/worker/DrydockLeaseUpdateWorker.php"},"region":{"startLine":761}}}],"partialFingerprints":{"codehealthFindingId/v1":"90f6a8323823fadb690537c79da0a0ad02952ecec86ec5d2a704871296a02853"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We could be much smarter about this and try to release long-unused \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/worker/DrydockLeaseUpdateWorker.php"},"region":{"startLine":880}}}],"partialFingerprints":{"codehealthFindingId/v1":"1de66d4c712516e8d5ecd31747dc69012364980ebd8d0f2feba4a714d65bf2fc"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We should probably check for other running operations with lower \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/worker/DrydockRepositoryOperationUpdateWorker.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"92ff85d7121aed5b287048450bc30336c3628d94fdb2395bd614502ad30e70fa"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Once we have sequencing, we could awaken the next operation \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/worker/DrydockRepositoryOperationUpdateWorker.php"},"region":{"startLine":81}}}],"partialFingerprints":{"codehealthFindingId/v1":"27487606725544629b85592b6bc992959396237f6eb9161e0c396293d29719fb"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is very similar to leasing in Harbormaster, maybe we can \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/worker/DrydockRepositoryOperationUpdateWorker.php"},"region":{"startLine":89}}}],"partialFingerprints":{"codehealthFindingId/v1":"ba01d6a2b8fea0f0c5fa35159eb1db8029b8accf8a6513192d50685b329449a9"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: It would be nice to use a more narrow time here, like \u0022last \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/worker/DrydockWorker.php"},"region":{"startLine":209}}}],"partialFingerprints":{"codehealthFindingId/v1":"8c7fdeb567aa4c05cf9f0ea92919b031059d7adade29fed1fd5b1fce21ada368"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Be stricter about this? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/storage/DrydockLease.php"},"region":{"startLine":342}}}],"partialFingerprints":{"codehealthFindingId/v1":"4d0b6b14f745ba83fc91495fe6e06ee87c2e86c0281e577ab335726468b88d3c"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Implement reasonable policies. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/storage/DrydockLease.php"},"region":{"startLine":590}}}],"partialFingerprints":{"codehealthFindingId/v1":"ec827880a0c813b47e097ddad957888af59e71350903461455b35800d92910e9"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: One reason this can fail is if the changes have already been \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/operation/DrydockLandRepositoryOperation.php"},"region":{"startLine":131}}}],"partialFingerprints":{"codehealthFindingId/v1":"b64dcc4fa80664be7057999d14e4dd67f25bffba051f388a961f5dbd0ca417cd"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Probably let users choose a VCS email address in settings. For \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/operation/DrydockLandRepositoryOperation.php"},"region":{"startLine":185}}}],"partialFingerprints":{"codehealthFindingId/v1":"eb947fb4da97d3aca2bfdf672c007fca3bda54d2b7623058998d9b304551e5e4"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: At some point we should allow installs to give \u0022land reviewed \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/operation/DrydockLandRepositoryOperation.php"},"region":{"startLine":274}}}],"partialFingerprints":{"codehealthFindingId/v1":"264a2781398d1af0e0b5e69ed06737c938248a03a03a162a6fab214700d9da65"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Check lease state, etc. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/management/DrydockManagementCommandWorkflow.php"},"region":{"startLine":51}}}],"partialFingerprints":{"codehealthFindingId/v1":"caf8727e659205be93347ebd3d070991312ec2acdde2f80ae90d1363cb26fb1c"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This would probably be better handled with PhutilSignalRouter, \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/management/DrydockManagementLeaseWorkflow.php"},"region":{"startLine":129}}}],"partialFingerprints":{"codehealthFindingId/v1":"c08b972513ca40fa3a9ab307a05676dc18c9f8ff9e1580b2824a3f996ff1e5b3"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This logic shouldn\u0027t do anything awful, but is a little silly. It \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/blueprint/DrydockBlueprintImplementation.php"},"region":{"startLine":460}}}],"partialFingerprints":{"codehealthFindingId/v1":"067e8ddb72e317634dca46240a22d8436ae3e09929dc07e1232502208e77029b"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Leases should validate their attributes more formally. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/blueprint/DrydockWorkingCopyBlueprintImplementation.php"},"region":{"startLine":152}}}],"partialFingerprints":{"codehealthFindingId/v1":"606778bd67f109d897b09a3f0bb7c2b93eabc8bce090e3f17a084e8f5023a31d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Validate directory isn\u0027t goofy like \u0022/etc\u0022 or \u0022../../lol\u0022 \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/blueprint/DrydockWorkingCopyBlueprintImplementation.php"},"region":{"startLine":205}}}],"partialFingerprints":{"codehealthFindingId/v1":"341aa5acd7f28252101cea414f2c150be32abe778a8040ca16045bbc47a5f718"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Use working storage? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/drydock/blueprint/DrydockWorkingCopyBlueprintImplementation.php"},"region":{"startLine":373}}}],"partialFingerprints":{"codehealthFindingId/v1":"1bc55cfc372a6dcc62e2b5f63fdb7b20b1e5a11d2f48c4081084e49338710caf"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This probably breaks, very rarely, on 32-bit systems. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/worker/DoorkeeperAsanaFeedWorker.php"},"region":{"startLine":142}}}],"partialFingerprints":{"codehealthFindingId/v1":"4799693bc230f3dced4b740b602a86cf90e0c068005920eaf9fe8c7d219e5b9e"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This needs to be adjusted if/when we allow you to link multiple \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/worker/DoorkeeperAsanaFeedWorker.php"},"region":{"startLine":578}}}],"partialFingerprints":{"codehealthFindingId/v1":"7d0db475c878ee980cdfa395512907e51fcce3a41e5a2709b9dc721fa4dc2c36"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This needs to be adjusted if/when we allow you to link multiple \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/worker/DoorkeeperJIRAFeedWorker.php"},"region":{"startLine":89}}}],"partialFingerprints":{"codehealthFindingId/v1":"fd6f8aef2d2a12cffde49aef7a4cbd8e7dccdb88d579ee7be72f0000111fe597"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: If the user has several linked Asana accounts, we just pick the \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"5c0a377b036532a0acb9daf7e4b1e1c73e860170e9dbcc44bb030c5d48b0601d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Do a bunch of work to fetch the viewer\u0027s linked account if \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHub.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"9264f4b478757ffdfc83a00e8214cdb93648c2eb65ed633cc86e2e62992673fa"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Do we end up here for deleted objects and invisible \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubIssue.php"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"beab6db8b79876b450eeb5df0452ef970b899233d163767d9bec7d982f36d71e"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Do we end up here for deleted objects and invisible \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubUser.php"},"region":{"startLine":51}}}],"partialFingerprints":{"codehealthFindingId/v1":"9a18a870505aadf007b019ed05809f228494fa5d0cf648b74f83b3f62841a7c3"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: When we support multiple JIRA instances, we need to disambiguate \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/bridge/DoorkeeperBridgeJIRA.php"},"region":{"startLine":48}}}],"partialFingerprints":{"codehealthFindingId/v1":"4beb7d74ed80cad60a2271dc6a057f119c8b28fea03371fe144022d8c0459ba0"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is gross. Without this, the repository won\u0027t be updated for \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/publisher/DivinerLivePublisher.php"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"53e9c32ac245cb1bc61aabc511bd74a0b7d68de8b2477d226d6de9a3037e1b47"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We probably need a finer-grained sense of what \u0022documentable\u0022 \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/publisher/DivinerLivePublisher.php"},"region":{"startLine":151}}}],"partialFingerprints":{"codehealthFindingId/v1":"e1a1687432c09140d6f7f59aa67195b2e71c0fb2050e1a00329bcf91f7122cbc"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Yeah do that soon ^^^ \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/publisher/DivinerLivePublisher.php"},"region":{"startLine":159}}}],"partialFingerprints":{"codehealthFindingId/v1":"5dd5df5771afb3f9382daf47639695a8cc555b5dde14b9eba2242b2770d7e66f"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Actually implement this. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/publisher/DivinerLivePublisher.php"},"region":{"startLine":171}}}],"partialFingerprints":{"codehealthFindingId/v1":"93ff57045e4c7d99beeda10ad38504a20b0108fe36b6bc94d10028d5f164f8be"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Publish disambiguation pages. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/publisher/DivinerStaticPublisher.php"},"region":{"startLine":87}}}],"partialFingerprints":{"codehealthFindingId/v1":"b9fa892e6dd3b02e8a2ed76e120dccd4422a673cec67da024467deaedbc523f7"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This probably is not the best place to do this. Move it somewhere \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/markup/DivinerSymbolRemarkupRule.php"},"region":{"startLine":125}}}],"partialFingerprints":{"codehealthFindingId/v1":"a0af7ad045b7418b052113579664754179acfdc656981c06dcdb2008a55f79ef"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This could probably look better. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/controller/DivinerBookController.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"47cf0d3bd3c70a58b88da3664522f2e5bc3faa6fecaa8f65df54b76f5213083b"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This could probably be more smartly normalized in the DB, \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/controller/DivinerFindController.php"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"684fe2223e00500acee7afd857870ab1be4ccd5fcd4adef5837f781130181d73"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Find \u0060assert_instances_of()\u0060 calls in the function body and \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/atomizer/DivinerPHPAtomizer.php"},"region":{"startLine":187}}}],"partialFingerprints":{"codehealthFindingId/v1":"e31570311167f67d5c47b4c51d3ccc9c339ef7a4ac91956663136ea9701e9a35"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Restore blame information / generally fix this workflow. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/DiffusionLintSaveRunner.php"},"region":{"startLine":261}}}],"partialFingerprints":{"codehealthFindingId/v1":"e5fb3967d49e0253fe8f17e240e68371d9fc799d4443bbd862827b9fa54c23e6"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Under git, this error message should be more specific. It \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/view/DiffusionEmptyResultView.php"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"c9beaf5916def8eb2b4c3345c94c2b11a30087c5364cd385455b28e7ff2f2a6e"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We could improve this, but it is normally difficult to \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/view/DiffusionEmptyResultView.php"},"region":{"startLine":45}}}],"partialFingerprints":{"codehealthFindingId/v1":"b66cf7a107361a18b82f4b911fcc54a761c7b724431d2f65a051522dc06f9742"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is sketchy, but make sure we hit the markup cache. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/view/DiffusionReadmeView.php"},"region":{"startLine":63}}}],"partialFingerprints":{"codehealthFindingId/v1":"5ce5d7018add7dd5267a38fe10eb85b39b1fdef0256c166716eb69f39a9c05e7"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is really \u0022branch, tag, bookmark or ref\u0022 but we are only \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/typeahead/DiffusionRefDatasource.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"12e003f04d3db1f55669e20f4270d4078fb4b2def9d4a787417d6174e9d99627"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is a little hacky, but if you query for \u0022tagged(x)\u0022 and \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/typeahead/DiffusionTaggedRepositoriesFunctionDatasource.php"},"region":{"startLine":75}}}],"partialFingerprints":{"codehealthFindingId/v1":"4ba605c5b64c32d6962048296605c99dc45619b3b98f222b40d5b58effe3f5ea"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Currently, when proxying, we do not write an event log on the \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/ssh/DiffusionGitSSHWorkflow.php"},"region":{"startLine":183}}}],"partialFingerprints":{"codehealthFindingId/v1":"0e9b577a1cfee129dd2e5b8d0528e21c178c6142f360d20f8a6db26c267aab06"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is pretty inelegant and the protocol frame will change very \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/ssh/DiffusionSubversionServeSSHWorkflow.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"a1d05ae78aedd3b69f36ec43fd772e239526b1e6f191102a2eb61a8a23d45ca4"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Probably remove all of this. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/request/DiffusionRequest.php"},"region":{"startLine":266}}}],"partialFingerprints":{"codehealthFindingId/v1":"5eaf30e4c27b1f442f7767068e1aec5f6821fa69909743f02202a5e548b0a9af"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Get rid of this and do real Queries on real objects. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/request/DiffusionRequest.php"},"region":{"startLine":366}}}],"partialFingerprints":{"codehealthFindingId/v1":"76092f89f143a4b6c12d9e93f93825c5d5b1c3321ee0c4c68b37d44c9f883ce1"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This should also die. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/request/DiffusionRequest.php"},"region":{"startLine":378}}}],"partialFingerprints":{"codehealthFindingId/v1":"5b0c8755aefdf37eea64c088f32dbb7281cf5fd0005d0da50488d18af8e4db1b"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Do a better job of selecting the best match? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/request/DiffusionRequest.php"},"region":{"startLine":641}}}],"partialFingerprints":{"codehealthFindingId/v1":"4a5b43995abdaf72e0bd87c884024537f672edbc068d85e2a03ef151e029b646"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: In Git, we don\u0027t store (and thus don\u0027t return) the hash \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/DiffusionCachedResolveRefsQuery.php"},"region":{"startLine":125}}}],"partialFingerprints":{"codehealthFindingId/v1":"f7f5d4a20270aa0ee5d1fc09ae095341af714ba4caa45aeab066f1a7bbf8a5cb"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: When we import only part of a repository, we won\u0027t necessarily \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/DiffusionCachedResolveRefsQuery.php"},"region":{"startLine":172}}}],"partialFingerprints":{"codehealthFindingId/v1":"e2b8b325269e0bcd19c38961808b6ce3a31280e3d285f055a3c97b009c73d24a"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Here, we have a structured list of refs. In a future change, \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/protocol/DiffusionGitUploadPackWireProtocol.php"},"region":{"startLine":282}}}],"partialFingerprints":{"codehealthFindingId/v1":"b8ab933ad8699f066fb49ebd6315e8f0e05731d57728d5c4d4aa5e01fd9e4f17"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: For now, only fetch over SSH. We could support fetching over \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php"},"region":{"startLine":705}}}],"partialFingerprints":{"codehealthFindingId/v1":"a7cc0807e8ffa4bcbddaa90aaae5d216ecf490a84b8c80b7c1750ddb3db0d8b0"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: In a cluster environment, we need a daemon on this repository\u0027s \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php"},"region":{"startLine":505}}}],"partialFingerprints":{"codehealthFindingId/v1":"de597f836102417ee601ac48db9188f494bb06f6bfb46de0fe9c10165bf48186"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Viewer may not have permission to see the service, or it may \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/management/DiffusionRepositoryStorageManagementPanel.php"},"region":{"startLine":95}}}],"partialFingerprints":{"codehealthFindingId/v1":"50aa63d5fe3bd4aab28903dd5b1ada7126abf86c00c5a5ae554005661ec8dfcf"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Somewhere in here we should be setting CHANGEFLAG_REWRITE \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/engine/DiffusionCommitHookEngine.php"},"region":{"startLine":931}}}],"partialFingerprints":{"codehealthFindingId/v1":"df2f378fed338cc670a94242c78975afd2b8907f97cc5ee56de26caa9361dbae"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This diff has 3 lines of context, which produces slightly \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/engine/DiffusionCommitHookEngine.php"},"region":{"startLine":1207}}}],"partialFingerprints":{"codehealthFindingId/v1":"5833899f6e483d5a95cf6c4b54dbee87d90bb56837f2afd3d7e3ed4839a0ede1"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Although creation stories exist, they currently don\u0027t have a \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/doorkeeper/DiffusionDoorkeeperCommitFeedStoryPublisher.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"22e712cb589a2ed339b3f093b855d7eee5f097b2548bb752498e6791c785f7d5"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This isn\u0027t quite accurate, but pretty close: check if this story \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/doorkeeper/DiffusionDoorkeeperCommitFeedStoryPublisher.php"},"region":{"startLine":28}}}],"partialFingerprints":{"codehealthFindingId/v1":"6a085a441b91a7e6dd35dbae992ece4de658559575f7f6d7f20d44f41d6c8c77"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is messy and should be generalized, but we don\u0027t have a good \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/doorkeeper/DiffusionDoorkeeperCommitFeedStoryPublisher.php"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"9bf08ee39232abd6af7ec7809d87d49d0f4ae457fbfe9a23db79d0892de0663c"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We should probably test if we can load the file PHID here and \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionBrowseController.php"},"region":{"startLine":993}}}],"partialFingerprints":{"codehealthFindingId/v1":"638ed89448853ee440158122d5a69fbdeb5b11654c90de3db30423cda8f5539b"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Refine this. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionChangeController.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"28d73a15b6a76553ad3ee1f7efb600548112418a5d8b797814c40821539f97b9"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is pretty awkward, unify the CSS between Diffusion and \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionChangeController.php"},"region":{"startLine":70}}}],"partialFingerprints":{"codehealthFindingId/v1":"d32e8b95bef532aa1d5672eae21ac8d97aa53c8cb898a92a2edcd8e1c9588d9c"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is pretty awkward, unify the CSS between Diffusion and \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionCommitController.php"},"region":{"startLine":776}}}],"partialFingerprints":{"codehealthFindingId/v1":"56a6773bdb1b93eb31b50e39b710feeb00665596dffe79b38541461a910aedc0"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This table and panel shouldn\u0027t really be separate, but we need \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionCommitController.php"},"region":{"startLine":367}}}],"partialFingerprints":{"codehealthFindingId/v1":"e7b55cc09df2b0adda73b47f46a5d562794d1a98c594f32181c973b6f5f302c0"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Some parts of the views still rely on properties of the \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionCommitController.php"},"region":{"startLine":404}}}],"partialFingerprints":{"codehealthFindingId/v1":"d34b283af9c8aeb04606b36c32c8ba7e2fabf981682fb1d144789863414c7b4d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Try to setBranch() to something reasonable here? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionCommitController.php"},"region":{"startLine":447}}}],"partialFingerprints":{"codehealthFindingId/v1":"db679d3b307fc1e09b4480d89d09249f192fa842ffed8f4860cdec93915225f0"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Implement this, somewhat tricky if there\u0027s an octopus merge \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionCommitController.php"},"region":{"startLine":453}}}],"partialFingerprints":{"codehealthFindingId/v1":"6b707e34e69b827f644ad3f450287575d05f082003057adb72f83eafd28b2feb"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is hacky, we just want access to the linkX() methods on \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionCommitController.php"},"region":{"startLine":966}}}],"partialFingerprints":{"codehealthFindingId/v1":"c0533189a7013affaa8c859549ff5c87461282e686ce1f0058a8b2c3e6bceb24"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We could use futures here and resolve these calls in parallel. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionCommitController.php"},"region":{"startLine":1039}}}],"partialFingerprints":{"codehealthFindingId/v1":"c534712f80ea591c044a5ede8cebacfd4e414313bd96dc6f4f9c9a2803185685"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Provide a \u0022Show Diff\u0022 action. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionCompareController.php"},"region":{"startLine":273}}}],"partialFingerprints":{"codehealthFindingId/v1":"02fbe8d813cbc25e0bed66b480f19c921f147b8f0fb01ff2d322086ee2437d22"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is a rare query but does a table scan, add a key? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionExternalController.php"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"481ebed0c0d42a2f9f9de9207d293d1af1b46431a252dbeeac70cd4736f29ecc"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Write a real PathQuery object? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionInlineCommentController.php"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"872d4b5a12d58bd16c388ef03bd273cf00a2e3a138a4ecbfcbc230bb351e0cef"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Evan will replace \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRepositoryController.php"},"region":{"startLine":104}}}],"partialFingerprints":{"codehealthFindingId/v1":"8c7316f61ffee4f998ff43ae241fa462d317ed9503a4a3835a0ee6d908b654b7"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is messy for now; the mobile menu should be set automatically \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRepositoryManagePanelsController.php"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"74b21ce0fcecec6dee688afe31ed06e4f687ff056efdcfa2bc1bce894293dfeb"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This implementation is safe by default, but very incomplete. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionServeController.php"},"region":{"startLine":502}}}],"partialFingerprints":{"codehealthFindingId/v1":"748c287cb204fa115c9b5d84533efaf06f17b334eee12348de44ed065d0b0c03"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Set these correctly. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionServeController.php"},"region":{"startLine":599}}}],"partialFingerprints":{"codehealthFindingId/v1":"4016f9af9750d589f25620aabb56e841a324f5e36d9fc5e921529f90a74c8738"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Arguments can also come in via request body for POST requests. The \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionServeController.php"},"region":{"startLine":909}}}],"partialFingerprints":{"codehealthFindingId/v1":"7054fbb15dcaa440fba813521315cbd00fb919b8d1233d7a2b93238ef2690cbc"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Detect \u0022deleted\u0022 by issuing \u0022hg log\u0022? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php"},"region":{"startLine":352}}}],"partialFingerprints":{"codehealthFindingId/v1":"e2cd7daf973cbd9a76d770a660966b40469db6de25da56e6bedf89f4a363f9ea"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Compare commit identifiers of individual files like in \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/conduit/DiffusionGetLintMessagesConduitAPIMethod.php"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"fc215cffd91e110ec3a6f1d3d8a4b6ee291b0f8922bf714e5eeb8d7ffafff5c8"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Paginate this sensibly at some point. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/conduit/DiffusionMergedCommitsQueryConduitAPIMethod.php"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"03d4733d0ae8f9fe6e440cfa95cbb24b75279071a464f1550bf100613f885222"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Allow web UI queries opt out of this if they don\u0027t care about \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/conduit/DiffusionQueryConduitAPIMethod.php"},"region":{"startLine":101}}}],"partialFingerprints":{"codehealthFindingId/v1":"b36344533129eebb19ad04222e1e7f931e5ce3f1e0d2517ac1537600ef4e7e96"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This can probably be removed once Draft is the universal default. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/xaction/DifferentialRevisionHoldDraftTransaction.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"51b331210029b12ff24734e7c825925a9b927566f2b2ad85847145de0a093885"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Remove this once drafts leave prototype. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php"},"region":{"startLine":68}}}],"partialFingerprints":{"codehealthFindingId/v1":"14ee0d683feaae6da25d90decb320eb064f69dc10d1025e088e1c1f37f05784c"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This can race with diff updates, particularly those from \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/xaction/DifferentialRevisionUpdateTransaction.php"},"region":{"startLine":76}}}],"partialFingerprints":{"codehealthFindingId/v1":"9117ec470ee60d3a3647e8633d3673b8c4c828137bf4763cdab2b14a34cf78e2"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Render some kind of notice about rebases. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php"},"region":{"startLine":152}}}],"partialFingerprints":{"codehealthFindingId/v1":"c217cf531b67d42b32dba559e16151cc193c73b030b97aa6c544fbca49b55135"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: There\u0027s a whole lot of code duplication between this and \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/view/DifferentialTransactionView.php"},"region":{"startLine":48}}}],"partialFingerprints":{"codehealthFindingId/v1":"b6d43582fa9e2b20d5f532d16f4fb96e490dbee9ca151bc8048c1ede4c400a9c"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We still get one edge case wrong here, when we have a \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/view/DifferentialTransactionView.php"},"region":{"startLine":145}}}],"partialFingerprints":{"codehealthFindingId/v1":"b4587ae607503a78e8ffa177f4f854a29435c20a217546a5418bbed7171b86f8"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: For Subversion, we should adjust these paths to be relative to \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialChangeset.php"},"region":{"startLine":107}}}],"partialFingerprints":{"codehealthFindingId/v1":"28e704ff92080fdc7ea5a57070793b7127aeeb77d8683962395fa96793bb3af3"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Change type? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialChangeset.php"},"region":{"startLine":593}}}],"partialFingerprints":{"codehealthFindingId/v1":"c928f3392abf8e2f120f18a09a7ffa6f61e3df875887eaad02d0d69fbd78ab52"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Away paths? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialChangeset.php"},"region":{"startLine":594}}}],"partialFingerprints":{"codehealthFindingId/v1":"a955404fcc4d28417e65def82ad6b556886e9e8baa15a527a2653bf4b37bb0ab"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: View state key? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialChangeset.php"},"region":{"startLine":595}}}],"partialFingerprints":{"codehealthFindingId/v1":"27e046ec0f95fa967cff6eca57409d28a8411d1e993d8a16ab486b141c5f164e"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is \u0022safe\u0022, but it would be better to propagate a real user \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialDiff.php"},"region":{"startLine":235}}}],"partialFingerprints":{"codehealthFindingId/v1":"ea5f9dbdfb0db2a9447fa2d0b1a14caeacdaebdc758c5ca9601d9b6d6177164e"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We\u0027re just hoping to get lucky. Instead, \u0060arc\u0060 should store \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialDiff.php"},"region":{"startLine":659}}}],"partialFingerprints":{"codehealthFindingId/v1":"34a42414cdbadb30c579bea1e46a87ca1e8b01c4d98788494382ab88aa0dd720"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is sketchy, but just eat the query cost until this can get \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialDiff.php"},"region":{"startLine":666}}}],"partialFingerprints":{"codehealthFindingId/v1":"4b0908f4d3a27f415ada3b9bd87a0976899adc3b28ef4fd230896df303a420f9"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Can we just get rid of this? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialHunk.php"},"region":{"startLine":169}}}],"partialFingerprints":{"codehealthFindingId/v1":"73ffad1ea9b10ec152a07696cf8663e171f6046fc8aabcb378f183c2196b2061"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Because it\u0027s currently technically possible to create a revision \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialRevision.php"},"region":{"startLine":158}}}],"partialFingerprints":{"codehealthFindingId/v1":"49c34d2318ee44bbe2cb58b9636c103e82c504ed4fe8b0cfba3a7a69c63dd6bd"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This only happens when adding or removing CCs, and is safe from a \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialRevision.php"},"region":{"startLine":954}}}],"partialFingerprints":{"codehealthFindingId/v1":"22bec936d58e11416c8ac253790147e0e820cad74a6c5d2edf606c256c7da366"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This allows us to render modern strings for older transactions \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialTransaction.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"60a3fb0c887a7d5f316ca15017eca7ecc318e8da17ce07bd5d58352f6e393983"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is a bit gross, but far less bad than it used to be. It \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/storage/DifferentialTransaction.php"},"region":{"startLine":541}}}],"partialFingerprints":{"codehealthFindingId/v1":"087c98ce420306eafff418d94ad9ed1c254532eed0ae17cb6b53d28c20dc987e"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This isn\u0027t very clean, but custom fields currently rely on it. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/search/DifferentialRevisionFulltextEngine.php"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"e16449a5e20f4d5384cb25864d3386cb2940b3846dc9057b5946f2d93aadfddd"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We\u0027re currently double-rendering this: once when building \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetOneUpRenderer.php"},"region":{"startLine":400}}}],"partialFingerprints":{"codehealthFindingId/v1":"f76752bebd7b2285bceaeed3242ec73782751d8c2afd2945f7d43631fc290fc7"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This should probably happen earlier, whenever we deal with \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetTestRenderer.php"},"region":{"startLine":82}}}],"partialFingerprints":{"codehealthFindingId/v1":"0b01504e061d27c80272f1d94a3399b173489dc09666a9bf5ad3456d79013243"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: [HTML] Escaping model here isn\u0027t ideal. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php"},"region":{"startLine":140}}}],"partialFingerprints":{"codehealthFindingId/v1":"fbd364ff519971b6d028126110d998c176b65c319302ed33266e3ecffc1c0553"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Do we need this? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/query/DifferentialHunkQuery.php"},"region":{"startLine":85}}}],"partialFingerprints":{"codehealthFindingId/v1":"bb00e7e7ed022cae01652fb5185c47f7962b05c69d31fc19b6f2f44f68077e60"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Compare SVN remote URIs? Compare Git/Hg remote URIs? Add \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/query/DifferentialRepositoryLookup.php"},"region":{"startLine":61}}}],"partialFingerprints":{"codehealthFindingId/v1":"c0157191e501ac58da09d92655d276dcbf98e921ede74f3beccd88df15c2117b"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: It would be nice to tailor this more narrowly. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialChangesetParser.php"},"region":{"startLine":492}}}],"partialFingerprints":{"codehealthFindingId/v1":"48481538ff9f96d76130702be4cfc47f020f50f1cbaa95a8c76a9dec29321124"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This isn\u0027t really correct (the change is not \u0022generated\u0022), the \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialChangesetParser.php"},"region":{"startLine":597}}}],"partialFingerprints":{"codehealthFindingId/v1":"a89e57d337c248d3c9ca4f9c4f274ae11b98713d9648d58def211e906c0dff69"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This should probably be cleaner, but just be simple and \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialChangesetParser.php"},"region":{"startLine":1011}}}],"partialFingerprints":{"codehealthFindingId/v1":"ff270efe8dc6eaeeaf3f3cbef6a37272989e5da294b795f15dbb860fc15e5f68"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This should be flexible, eventually. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialChangesetParser.php"},"region":{"startLine":1527}}}],"partialFingerprints":{"codehealthFindingId/v1":"3a2422d5ba42088998bc7871e4fef30f323c00d4a27845ce3cfdae0df9aa498e"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Always include \u0022source\u0022 as a usable engine to default to \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/parser/DifferentialChangesetParser.php"},"region":{"startLine":1929}}}],"partialFingerprints":{"codehealthFindingId/v1":"c625fac6cdfbeffe1da9def0e52fc4d3c3014aee1fa57053bdc8ee664c822222"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Currently, we don\u0027t upload the raw author string from \u0022arc\u0022. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/engineextension/DifferentialCommitsSearchEngineAttachment.php"},"region":{"startLine":42}}}],"partialFingerprints":{"codehealthFindingId/v1":"f59bc80e63639ad39162ae42269002613694eee065f0d8f905361b18b20af30a"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Support adds, deletes and moves under SVN. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/engine/DifferentialDiffExtractionEngine.php"},"region":{"startLine":75}}}],"partialFingerprints":{"codehealthFindingId/v1":"9ab32286254a511863d39335776eb4c889276c405fd08870db7e1fea5cc3167b"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Attach binary files. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/engine/DifferentialDiffExtractionEngine.php"},"region":{"startLine":114}}}],"partialFingerprints":{"codehealthFindingId/v1":"4774ffa776bdfdb925493309c57b61d350b74c648ee9e8dce4dbadefec875441"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: See PHI1044. This call may fail if the diff deleted the \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/engine/DifferentialDiffExtractionEngine.php"},"region":{"startLine":190}}}],"partialFingerprints":{"codehealthFindingId/v1":"d13b65f187427285e04220e3715b85c9c3ed232472bb93f0c86f8dbfb4435025"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: If you \u0022arc land\u0022 and a build with \u0022Warn: If Complete\u0022 \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/engine/DifferentialDiffExtractionEngine.php"},"region":{"startLine":383}}}],"partialFingerprints":{"codehealthFindingId/v1":"3aed4dd391902502e40aff177f332aa981fda407dbbb17c3e01b5e405cad9296"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Provide a helpful message about the patch being too \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/editor/DifferentialTransactionEditor.php"},"region":{"startLine":763}}}],"partialFingerprints":{"codehealthFindingId/v1":"2c8b9bfbba2f5940165506031ab457823eb67c08430a97b928aa506e58c5bc88"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is substantially similar to DifferentialReviewersHeraldAction \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/editor/DifferentialTransactionEditor.php"},"region":{"startLine":1165}}}],"partialFingerprints":{"codehealthFindingId/v1":"3fc0e3c7e777cf164e2a82df9ab3325e28893677d87a53efdf081c1e85cfc704"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: As above. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/customfield/DifferentialCustomField.php"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"c9c3d4c10c68e916ccec8b3a00be3a3b8fe21d86e5510c79a3b9e6b96e81debc"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This load is slightly inefficient, but most of this is moving \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/customfield/DifferentialHarbormasterField.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"33770c19a9271684faeee4e7814d4f5073017138ac2e97376e634cde312ac8bd"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: When the diff is not the right-hand-size diff, we should \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/customfield/DifferentialHarbormasterField.php"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"461548cdda1b2ef4b6aa354175c27ee4dcdff70ebbf86cdaa376969e203cdeda"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We might need to remap some stuff here? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/customfield/DifferentialLintField.php"},"region":{"startLine":110}}}],"partialFingerprints":{"codehealthFindingId/v1":"367057176d278658ec1f2761a98542ffa2a97838615d193e35b034aea2286701"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: implement optgroup support in AphrontFormSelectControl? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/controller/DifferentialDiffViewController.php"},"region":{"startLine":51}}}],"partialFingerprints":{"codehealthFindingId/v1":"bc36c2146e3e9463ba9c2cf172ff76f1dac40a7ea9494c8b3fbe44da0dce0845"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Unify with similar Repository constants \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/constants/DifferentialRevisionControlSystem.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"61e2815ad97f45d2ad0ebed122f5a1ba31d3ffc23de765e30f56a9e0c73140d7"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Remove repository UUID eventually; for now continue writing \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"e4f25854dfb2625ec3f018ca988b5deb8196627c865745e00d8af9fbb7bad3ce"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Arcanist passes this; prevent fatals after D4191 until Conduit \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/conduit/DifferentialCreateRevisionConduitAPIMethod.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"5ea3cc01b133193d917a7c2538abc0528ecdd1cd4a67c09c7500a0b36ed97a19"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is a hacky way to put permissions on this field until we \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php"},"region":{"startLine":205}}}],"partialFingerprints":{"codehealthFindingId/v1":"1c1f43208351a7736222f70c495dbef02a8f1f9639141e72297faae7f9fe5365"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: If we don\u0027t do this, SearchEngine explodes when trying to \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/query/PhabricatorDashboardPanelQuery.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"74a4d01c27f1695a6df845c40126c9493395595acdf82a258cd356ae35ab50f5"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: A small number of queries, including \u0022Notifications\u0022 and \u0022Search\u0022, \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php"},"region":{"startLine":127}}}],"partialFingerprints":{"codehealthFindingId/v1":"c95ad632139d3f5d1f0409c9d61ebc3bbae1f7d08cb91eb8690bc998f9710803"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Currently, we\u0027ll load all the panels on page load. It would be \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php"},"region":{"startLine":256}}}],"partialFingerprints":{"codehealthFindingId/v1":"d85ad55dae937f25328153de73f4c88a423e827ab82b656f7c1bc4d953fcffaa"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Maybe we should persist which panel the user selected, so it \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php"},"region":{"startLine":259}}}],"partialFingerprints":{"codehealthFindingId/v1":"f4f5542b858fa703c9dfc49d88eabdfafa2173a960d20db76410030c9db861e2"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is a bit awkward for historical reasons, clean it up after \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/daemon/event/PhabricatorDaemonEventListener.php"},"region":{"startLine":63}}}],"partialFingerprints":{"codehealthFindingId/v1":"0590f0379f1e7732f652460cd273d3818a8d9765d9a03ca8301e9f9497d9190e"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: this is incredibly stupid, but we may not have Phutil metamodule \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/console/plugin/xhprof/DarkConsoleXHProfPluginAPI.php"},"region":{"startLine":64}}}],"partialFingerprints":{"codehealthFindingId/v1":"ab525c10aa454bd99d619cb17df8914c4619353851d078ce2a52237ff3b18ac1"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Sort the groups chronologically? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/query/ConpherenceThreadSearchEngine.php"},"region":{"startLine":440}}}],"partialFingerprints":{"codehealthFindingId/v1":"5e2eee00544f46b8ca58bb3ad51886b6e8bde35affe26e8e13ca02f170c16e05"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Conpherence threads don\u0027t currently support any commands directly, \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/application/PhabricatorConpherenceApplication.php"},"region":{"startLine":77}}}],"partialFingerprints":{"codehealthFindingId/v1":"bdf12e3c5713a737618704d464c6a3ef4507477951fba09334c03bb5c5996d8b"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We should do a better job of detecting how to install extensions \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/view/PhabricatorSetupIssueView.php"},"region":{"startLine":83}}}],"partialFingerprints":{"codehealthFindingId/v1":"d190c0e99048f78f27bfb333bce96469cd335774498caa80e236afe536d3dde0"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: After T2213 show the actual values too; for now, we don\u0027t \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/storage/PhabricatorConfigTransaction.php"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"5184b6dc795f8ed4c3fa8d8fe5b21854d43c50ccbf81ae56958fafc8e0326375"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Build this out to catch overlong indexes. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/schema/PhabricatorConfigColumnSchema.php"},"region":{"startLine":150}}}],"partialFingerprints":{"codehealthFindingId/v1":"471f48a42c10fc90b8f4622df23afda8c08256da2b377c334fccf65e4c07acbb"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is a reasonable thing to support in the HTTP access \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/option/PhabricatorAccessLogConfigOptions.php"},"region":{"startLine":51}}}],"partialFingerprints":{"codehealthFindingId/v1":"e298696273001632cc495a4e189a450722200c0b7c497fa975b8f30bf991689b"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This should be a PHUIFormFileControl, but that currently only \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/custom/PhabricatorCustomLogoConfigType.php"},"region":{"startLine":92}}}],"partialFingerprints":{"codehealthFindingId/v1":"882f35bb9a5c14eef53ace433b0262f48520529ba2b4152b9fd91f9b63bcf0a1"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: If we missed on the new \u0060PhabricatorConfigType\u0060 map, fall back \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/settings/PhabricatorConfigEditController.php"},"region":{"startLine":288}}}],"partialFingerprints":{"codehealthFindingId/v1":"a93fcb5e79825b9b4096c5df114af023dbc38382071be221bef8343ea4501d6d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Avoid fataling if we don\u0027t have a master database configured \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/check/PhabricatorElasticsearchSetupCheck.php"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"fc8cee6293f5447b32bfeae6913f0d1495aa23b3b4c3626e38fcd418d4a1f730"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Make \u0027mbstring\u0027 a soft requirement. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/check/PhabricatorExtensionsSetupCheck.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"6424d14a0f33c4c1979edfc5002763baf53ba9591c5a0ed5cd14d9bd2a9bd393"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This can be removed entirely because the minimum PHP version is \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"5ea26d18bdb8edec4241c61f68326a9201b559c48ffb478ff477f120ddb74bab"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Specialize this so we can give users more tailored messages from \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conduit/parametertype/ConduitParameterType.php"},"region":{"startLine":65}}}],"partialFingerprints":{"codehealthFindingId/v1":"763a8b01a0de90d1ab8ba63555fef50afe2e2075bf3bd7fa8fc98b2f7e117d8d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: The relationship between ConduitAPIRequest and ConduitCall is a \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conduit/controller/PhabricatorConduitAPIController.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"69b737010652b4e223665eee19d20807775e604d4da0011e714d3ecb9a43fecd"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Validate that we are the host! \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conduit/controller/PhabricatorConduitAPIController.php"},"region":{"startLine":193}}}],"partialFingerprints":{"codehealthFindingId/v1":"5be158969b255e4881e1c93ae59fe834f15f2473572d2097ba02679ee25376c8"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is super messy. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conduit/controller/PhabricatorConduitAPIController.php"},"region":{"startLine":454}}}],"partialFingerprints":{"codehealthFindingId/v1":"721cc3b27c1448cdaa7cca4d4bd1f1bc27f775de6208188cc1f9aec32bf7713e"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Remove this in favor of token-based auth. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conduit/controller/PhabricatorConduitAPIController.php"},"region":{"startLine":455}}}],"partialFingerprints":{"codehealthFindingId/v1":"34072fd02635ecb95a6eec9a122d26f0464d47aa1ca371a109341dbe8264aabc"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Remove this in favor of token-based auth. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conduit/controller/PhabricatorConduitAPIController.php"},"region":{"startLine":483}}}],"partialFingerprints":{"codehealthFindingId/v1":"665bb67d1b07e6d249664d86e74a6009e0daa9ba2ba8ce1d51fa2bfd77211611"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: As per below, this should get centralized and cleaned up. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conduit/call/ConduitCall.php"},"region":{"startLine":107}}}],"partialFingerprints":{"codehealthFindingId/v1":"65799bab75dcd8122aa8a133da439d64e812580f6e524776a7eea8f1122152f5"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This would be slightly cleaner by just using a Query, but the \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conduit/call/ConduitCall.php"},"region":{"startLine":112}}}],"partialFingerprints":{"codehealthFindingId/v1":"6c763ac98e6fa942e31b56c4e7fde8c23f6b1127dcc99a6b7ae4adcc1c3415f7"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This should be unconditional, but the execution order of \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/storage/PhabricatorCalendarEvent.php"},"region":{"startLine":177}}}],"partialFingerprints":{"codehealthFindingId/v1":"a85f6d2edcec4450f5e5fd01e9218befc8a595ef912dd5d15235d9b09b1ebd1a"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Use $children to generate EXDATE/RDATE information. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/storage/PhabricatorCalendarEvent.php"},"region":{"startLine":817}}}],"partialFingerprints":{"codehealthFindingId/v1":"5f1872488a5ff27d3ce14f577a01f7d80b323414ba22dcc668b075fbba647d49"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Possibly pass the actual viewer in from the Conduit stuff, or \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/storage/PhabricatorCalendarEvent.php"},"region":{"startLine":1431}}}],"partialFingerprints":{"codehealthFindingId/v1":"eebdb309c229ac1b70d299fabbd364df9af137c11de165d0f533d2c93fc6c084"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: The spec appears to contradict itself: it says that the value \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/ics/PhutilICSParser.php"},"region":{"startLine":403}}}],"partialFingerprints":{"codehealthFindingId/v1":"816519f33df540707c3fb4831d890742046f7ad1299102a2e2fe30cc9852f07f"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We could reasonably fill in \u0022ROLE\u0022 and \u0022RSVP\u0022 here too, but it \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/ics/PhutilICSWriter.php"},"region":{"startLine":335}}}],"partialFingerprints":{"codehealthFindingId/v1":"4304af324b5a95958433b5291f112455fd770108f0b91d8447d4cf7e7644787a"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This doesn\u0027t account for leap seconds. In theory, it probably \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php"},"region":{"startLine":1080}}}],"partialFingerprints":{"codehealthFindingId/v1":"e64a511d229ca99df388196b09e6f1a89259418d9652809178b4af2d794d5fbe"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This doesn\u0027t account for hours caused by daylight savings time. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php"},"region":{"startLine":1121}}}],"partialFingerprints":{"codehealthFindingId/v1":"ea05f4ebe15518c553c6e494477e25e17958eb77a7a56c1534ddb1cd9a6d612f"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: In theory, it would be nice to store these in a fully abstract \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/import/PhabricatorCalendarICSImportEngine.php"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"be5ddf7d2909300736e498beb8c0c587088132d82338ef534695f1336fab2e74"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Define per-engine content sources so this can say \u0022via Upload\u0022 or \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/import/PhabricatorCalendarImportEngine.php"},"region":{"startLine":323}}}],"partialFingerprints":{"codehealthFindingId/v1":"7a89c3f0cbd85fd41ef076d530cf4ebaf860cf72b3016f19ae92d6a9b23a44cd"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: These should be transactional, but the transaction only accepts \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/import/PhabricatorCalendarImportEngine.php"},"region":{"startLine":521}}}],"partialFingerprints":{"codehealthFindingId/v1":"d46394e73aea06a93266b6e3f8323ada63b0554dd23eac25e90e2ab6ff879663"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This should be transactional, but the transaction only accepts \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/import/PhabricatorCalendarImportEngine.php"},"region":{"startLine":534}}}],"partialFingerprints":{"codehealthFindingId/v1":"53544ccc5938926083a7ce6940add6fee7b2d270f8f9e651559f14646e69721c"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This isn\u0027t the most accurate source we could use, but this mode \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/editor/PhabricatorCalendarEventEditEngine.php"},"region":{"startLine":393}}}],"partialFingerprints":{"codehealthFindingId/v1":"3d27173e54d40e29dc632aee5c99a3644147631a51933e37a9bbb3f3faa61a3d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This endpoint currently only works via AJAX. It would be vaguely \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/controller/PhabricatorCalendarEventAvailabilityController.php"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"7a3ba65320476703ecaa836c800c63819857c55c665c1470a711b6804c3b826f"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is the only concrete table we have on the database right \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/cache/PhabricatorKeyValueDatabaseCache.php"},"region":{"startLine":120}}}],"partialFingerprints":{"codehealthFindingId/v1":"33d954efa6bed1ba799a44112bab8ce14a8605b786bdf1dd9372104caf342480"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We should probably standardize how digests get embedded into cache \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/cache/spec/PhabricatorDataCacheSpec.php"},"region":{"startLine":151}}}],"partialFingerprints":{"codehealthFindingId/v1":"7cfb3707513666b776512709da7e749aef4b976c51dbebe7882060962fd166f9"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is kind of gross, I\u0027m basically just making this public so \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/base/controller/PhabricatorController.php"},"region":{"startLine":548}}}],"partialFingerprints":{"codehealthFindingId/v1":"3b35c41be3569f7fa5686c9ed1f33e6ec78da50a646ab560cca9261392e467dd"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: If the image has not changed, we do not need to make a new \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorAuthProvider.php"},"region":{"startLine":285}}}],"partialFingerprints":{"codehealthFindingId/v1":"89226daa5dbdea4f9a0cef3b72a7c92a63020fa39a94e1f3c0c3bd67ac86282a"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Remove this when these columns are removed. They no longer have \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorAuthProvider.php"},"region":{"startLine":359}}}],"partialFingerprints":{"codehealthFindingId/v1":"a2914ee94d7b4e7e09cd168274f1f3f095d1a8a0b2749fe42d6d75fb7768444a"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Remove this when \u0022accountID\u0022 is removed; the column is not \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorAuthProvider.php"},"region":{"startLine":366}}}],"partialFingerprints":{"codehealthFindingId/v1":"7e5e895889dc73d2d26b21c172d9025148299c3ac8a4c611d89f9fbff449ce12"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Clean this up. See PhabricatorAuthOldOAuthRedirectController. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorGitHubAuthProvider.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"351a374758fcb164df66010f885c554ff3255497f1c203c4fea307efdb761fee"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Clean this up. See PhabricatorAuthOldOAuthRedirectController. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorGoogleAuthProvider.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"e5cc28513e1af6ad5565742db09af711c418d93d2aa5cfae0ce07b649d5fccda"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This could be a bit prettier. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorJIRAAuthProvider.php"},"region":{"startLine":168}}}],"partialFingerprints":{"codehealthFindingId/v1":"37cff6025af6b3b51966d3864c98be737ef760619811f56d9834ba212fcfe947"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This calls ldap_bind() eventually, which dumps cleartext \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorLDAPAuthProvider.php"},"region":{"startLine":162}}}],"partialFingerprints":{"codehealthFindingId/v1":"386350e420fb74249fe600730c4bea4cbbd0765d1ab0f879a596db35c2d8723f"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Make this cleaner. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorLDAPAuthProvider.php"},"region":{"startLine":178}}}],"partialFingerprints":{"codehealthFindingId/v1":"a0efb90e8b537c47b51b5ad164166fbe0b3772a7ca2f6072b666b6875040c815"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Handle this in a more user-friendly way. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorOAuth1AuthProvider.php"},"region":{"startLine":105}}}],"partialFingerprints":{"codehealthFindingId/v1":"f3edf921828fa1721fd2d22d2196aaae1064381be79022ea8925c9ee5745b384"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Handle this in a more user-friendly way. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorOAuth2AuthProvider.php"},"region":{"startLine":85}}}],"partialFingerprints":{"codehealthFindingId/v1":"956b34cdfc8e16d37c5c62e388e1ea4354bc2edf5eb046857d68d19f3dcebf17"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This isn\u0027t really a proper use of the table and should get \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorOAuth1AuthProvider.php"},"region":{"startLine":271}}}],"partialFingerprints":{"codehealthFindingId/v1":"78d73d26d2723355bb4eb4e0bc1c2574b6c997c84c5b827073c35085c046459c"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Maybe we need this eventually? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/phid/PhabricatorAuthAuthFactorPHIDType.php"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"e8abe38e327cff6cae26f5db265d6cf42bd2c75ec0e8572bcff13453bf74ab73"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Eventually, let users reset specific actions. For now, we \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/management/PhabricatorAuthManagementUnlimitWorkflow.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"9859726f246219979bcc4480079fed0d402dab8adfdccffd20ddd2a19649dbbc"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: A workflow key should become required in order to issue an MFA \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/engine/PhabricatorAuthSessionEngine.php"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"6b60f2bd625e320aeae4363ee2f19a9099f4de9caffdff2a7852a3e9e819a0d9"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Implement these (T4310). \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/engine/PhabricatorAuthSessionEngine.php"},"region":{"startLine":131}}}],"partialFingerprints":{"codehealthFindingId/v1":"c1da3e146900f35f401ba79d4ac67ee842b9d43b49cd0f77bba437c0686439cc"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: See T13225. We\u0027re moving sessions to a more modern digest \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/engine/PhabricatorAuthSessionEngine.php"},"region":{"startLine":139}}}],"partialFingerprints":{"codehealthFindingId/v1":"d7abca59ac1b26609ebb5fac2284e2f699fdadd5be2061925da41449a8817f6c"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Remove this, see T13225. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/engine/PhabricatorAuthSessionEngine.php"},"region":{"startLine":176}}}],"partialFingerprints":{"codehealthFindingId/v1":"4f2f7085751a1c385ec65e80d42f4697dddcd48e4a26888793ab523f08bcecb9"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Remove this, see T13225. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/engine/PhabricatorAuthSessionEngine.php"},"region":{"startLine":223}}}],"partialFingerprints":{"codehealthFindingId/v1":"17817fb8447d8ba70f724b96364811eab1e8fafeed925498f6639172013d5d6a"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: If a user answers a \u0022requireHighSecurityToken()\u0022 prompt and hits \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/engine/PhabricatorAuthSessionEngine.php"},"region":{"startLine":458}}}],"partialFingerprints":{"codehealthFindingId/v1":"2e6eaa18c28a8c74e550b8081e12b9a9c08bda0870762c48a1591068cb19d619"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Send the user email about the new account link. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthConfirmLinkController.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"6b1323b0324ba33116950114938616b62e6800d84c51e7a1587cd5e1babe1058"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: It might be nice to add options like \u0022bind this session to my IP\u0022 \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthFinishController.php"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"ccf6ed9ef7edc7049e66e52f5e8fed94a22a7740bbe86351682a5f5253f177f2"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Most OAuth providers are OK with changing the redirect URI, but \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthOldOAuthRedirectController.php"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"cbec3b7fc7bea639b4dcb15b5e9a7336530e31dfb22a22f339fdbba5ff330d97"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is a routine error if you click \u0022Login\u0022 on an external \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthRegisterController.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"96ba82d01d32982a24c52f646b1e347b8fa136edcd0e514007ce554a006da7e4"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: See T3340. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthRegisterController.php"},"region":{"startLine":494}}}],"partialFingerprints":{"codehealthFindingId/v1":"2faaa0d8ab6eed19ca0fefdef513b214edb5889b6b40dddb162ac5e49b3832df"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We could tailor this a bit more. In particular, we could \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/config/PhabricatorAuthDisableController.php"},"region":{"startLine":61}}}],"partialFingerprints":{"codehealthFindingId/v1":"47ead41285941d7b8cd93a531843b8fbb1265d0810b10bf03442097cfad48eec"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: When we have multi-auth providers, support them here. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/config/PhabricatorAuthEditController.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"3693aa9556fbb21585aac1944743a8f3983a2af137bf7ddd1bfc22dc99fc06a4"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Special case this, or split the auth and auth administration \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/application/PhabricatorAuthApplication.php"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"4d17a47f9c4eaf4102dcdaff86d5a61532da96d47c2483841f38283c59c7cf94"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: JIRA tokens expire (after 5 years) and we could surface and store \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/adapter/PhutilJIRAAuthAdapter.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"a5540568b817af76422feb31bfd5d7b82916ae9b40b6fae947eb23c2f96cb270"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This shares a lot of code with Differential and Pholio and should \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/view/PhabricatorAuditTransactionView.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"633d39ab00f79f6a3830520d199e28cd05b411f549a5c187609f39b9e809c4e6"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Migrate these away? They probably do not exist on normal \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/view/PhabricatorAuditTransactionView.php"},"region":{"startLine":88}}}],"partialFingerprints":{"codehealthFindingId/v1":"22f55f4e270184f10bcd2974edabe988f3fdab61dd7af9bd2e9e5b07b9c59537"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: These will get modernized eventually, but that can happen one \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/editor/PhabricatorAuditEditor.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"ff15488b6f356bd02eca8c7ec1ccbc65fc1aa8667685f8246b38b47e1c0bbda0"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: It would be nice to show pusher here too, but that information \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/editor/PhabricatorAuditEditor.php"},"region":{"startLine":569}}}],"partialFingerprints":{"codehealthFindingId/v1":"b4a733c3a6c0bdda108643b61fe6df0a48eb175ad7c441a9892621243244b1ef"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: They should, and then we should simplify this. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/audit/editor/PhabricatorAuditEditor.php"},"region":{"startLine":790}}}],"partialFingerprints":{"codehealthFindingId/v1":"ea40888b38a94db3d3bfd345fa0ea57fa3612497f075662696abed5f49efc949"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: When service classes are restricted, it might be nice to customize \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/typeahead/AlmanacServiceDatasource.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"7a4232a36e229731bcfb886c017fbb09c5e2898c4537faf56688c1d8e46abb10"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Some day, this should be a datasource. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/editor/AlmanacInterfaceEditEngine.php"},"region":{"startLine":143}}}],"partialFingerprints":{"codehealthFindingId/v1":"e5132014c5c8f066834b0ddcca75a22e8047f2de3c8430e2b4e7a9247e1482a4"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Clean this up, see T1921. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/AphrontRequest.php"},"region":{"startLine":376}}}],"partialFingerprints":{"codehealthFindingId/v1":"3145b159f9eed933b58f672dd885294edcb25a55573471c3aa94239a1250e6a3"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is effectively a test for whether we\u0027re running in a unit \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/AphrontRequest.php"},"region":{"startLine":608}}}],"partialFingerprints":{"codehealthFindingId/v1":"ba5c46bfac9b2620b7752f531d0ba69d0cdd52d77f8f86872567ec24569f116d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: AphrontResponse needs to support streaming responses. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/response/AphrontHTTPProxyResponse.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"199d9c54d7ae483cdb0cafcdb98fe1b26c505ac5555e2bd5390143c7de6d63a1"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This should read only the headers. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/response/AphrontHTTPProxyResponse.php"},"region":{"startLine":51}}}],"partialFingerprints":{"codehealthFindingId/v1":"5e436a31c2ad709cc14692cfadc225034df93a89f383cc8541a4cd6b19a5e634"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is grossly inefficient for large requests. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/response/AphrontHTTPProxyResponse.php"},"region":{"startLine":56}}}],"partialFingerprints":{"codehealthFindingId/v1":"78c5a75fca224cd4c5e551d5ebc1cdc5fc6a0bf82dd37b525628369e996e012e"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Javelin supports implicity conversion of \u0027__html\u0027 objects to \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/response/AphrontResponse.php"},"region":{"startLine":330}}}],"partialFingerprints":{"codehealthFindingId/v1":"c7a3c39e9edaa36820fffeb55380320bb3784d400095c47eb5ef44eac3ff4562"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: For now, this is using \u0022parseParital()\u0022, not \u0022parse()\u0022. This allows \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"scripts/ssh/ssh-auth.php"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"d8c984e58d265259e097fb42b759c0f14686453fcf73bd7fe1f280dc818be376"}},{"ruleId":"D28","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"452a95cd6d1084f73e0ec479f8c67a029a86e18be211fa1c7ef8e530a83ce175"},"properties":{"commitSha":"26b7d57d7f4a0c4aa2cad563e4e5aa0765b086f5"},"taxa":[{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-540","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A01:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D28","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"023b80563e793544cdf4f3515cb58880ec69d3a90450a0e451199c14430b1dc0"},"properties":{"commitSha":"1329b7b51ef88825b36cf47b3c680542c2895579"},"taxa":[{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-540","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A01:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D28","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"1d1a010465acac027aae7b2815758f15c2709377d63da1c6454b9d559a392353"},"properties":{"commitSha":"91d084624b9c2c88f093ba4b244f6e3fdab8bcc6"},"taxa":[{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-540","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A01:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D28","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"797946c7728486ef534ec3e071d390ab6dd527320b3c33bbe590f1868bd8522d"},"properties":{"commitSha":"20ac900e8b6a4ec685a8cc1269547f57391ab237"},"taxa":[{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-540","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A01:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D28","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"b8cbcf5017735e6b45e862100b3232b83a8a7742776e58a6e649b3edbfed52f9"},"properties":{"commitSha":"0278b15ceb5dc811b1d07fc283efc9eb9e53bfb5"},"taxa":[{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-540","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A01:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D28","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"d0ec37dca17e5bda0e720952f0945d59d5d2ad8132c142831f06d946935160ad"},"properties":{"commitSha":"91d084624b9c2c88f093ba4b244f6e3fdab8bcc6"},"taxa":[{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-540","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A01:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D28","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"cbcc5a9cf991946d45f8376d4ec3a8c4e0d89a6b2de690b71bdf5c8a2cbef7cf"},"properties":{"commitSha":"a9612fac24a9eb97ad3f611d84dfedbce98d17ad"},"taxa":[{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-540","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A01:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D28","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"57df3ec540c461645d4382707cb8faac1a9a34fc2e78cf4186b68e3d32d6f394"},"properties":{"commitSha":"a8657e6ab6fd3feb3b880329f46df2a45b67dc82"},"taxa":[{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-540","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A01:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D28","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"c29fe5f9fe87ed341d15c18d687533fed395a6ed160e88d4efec0cfc4ca78ed9"},"properties":{"commitSha":"29f7219a494e4927130cf1e7462465c9662a7703"}},{"ruleId":"D28","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"97a8b59c580905e75f12e023837e21b7fec8267683b9db82ad5061af94b8e698"},"properties":{"commitSha":"b57b72368c3c99fb5836309ba06da9f37a9a4f60"},"taxa":[{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-540","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A01:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D28","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"66e3e43cc52781da3e3c2740af301889d8214a59f49d0996f3d4080e990d82b0"},"properties":{"commitSha":"e74f027f0ac233fdd08e94b2296b526b9ebcf233"}},{"ruleId":"D28","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"3d4dbe699a5c3df2bb07dae76dbd070d8f0230cc3f43fe7bdf012f6a825fb4ea"},"properties":{"commitSha":"cd30946d6085f7a397ac909955f20bed923a4d69"}},{"ruleId":"D28","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"3cdfd7beb31b791ae18dcb425e21eb157c842e7bbcd522cc330573c1a6538db1"}},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"af0c94c48aeec4d9715841435ba3d98daefe927693dad633dae7eb19faf9378d"},"taxa":[{"id":"CWE-200","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A01:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"4ad1309c3d960ed7209678fa3bb4986e4f72bd61f2729a729f580c92186054ee"},"taxa":[{"id":"CWE-457","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"f0aad9de000702a9b8e3001bdd50ae944de4433b6a9c9b52cc53c3a06fcf9d44"},"taxa":[{"id":"CWE-457","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"87fb7b3aa7a82dea43e86deb1a13bee507ebe390773f1346cd4ee329c754fd83"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"06e4d20f81cea806bad5def77e6f03a1051cb50f79ca3642feb670322ba6f8d0"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"c6938537596d90374ab73b9bbf46df4f530c9e3bd7daa2c8eb6c7ac22f5afb28"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"48bc03fbd8c300b4334ca4ef5746ed2ff7b3b281b67ed86037f5fadfd533de03"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"a9ca86b8f71dde66936efc37b88140ca8c0ed37661ce046dcce15c0526be49be"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"697c72cd11bb8c4feff461415827bc767948863e7986bbc51d2950baabae0aec"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"0db14f78f084bb3b0e87aea56b96c32b0835bd5e3bb6126147ed0f8b22dcc5fd"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"3c31f36f4bdfe39db4ac8484c74ee66f9bb5a265754b36bb89808a3a74cdb404"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"6c9d5b9c8b9d77e5b12e9d8868fdde6d9d40dca804025f01a09cabf9ca343e37"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"a55792e7fe0a5c1da6e0eda2c1853fb44f71b3fe55ed33b95bdfadae4b34a482"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"3830c0d49698ec169c2b4c70640a61d466d67a6d537b41d8f184a392c936621a"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"850b80fd02cfdb5749dd9dd32e68c1f544664f62d244313031b1124a75d9ffc3"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"276767077ccd182c963b087f31a8336c959b4ed42ea1618ed2256e47b16cb402"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"b3cae82714ba5b3349839a48005d7e805fa0dae86a734d573b0eab27c8273b48"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"07beca3267fb535856a28dd89afd5fccc99287d8b8042e8230db0d748ec429df"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"996edbd107a05ef462ad3641d55ab5c0d7a8594ce0441349809bf9c4ba90114e"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"31da5bbed14c18740746e3b693f6cf4bea9ab04dbb53ff1734b2b6f3c4bc3326"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"9cd9054a82dbf6e9698aa863603c0c4040b4face713c818739f4c427a7a3f324"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"56b30e4594f38bf678cebb3a17b92f4ac917bb85a162df99a9e040b24c3f3d9f"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"7e44eb310ba62122a847e6537fca57d0091f4d71e4634b2c404a483107f1a1b1"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"0bb18e05de7a1f1c2a503093c7e29e4b2e61a60498b2f95d3854e51ba42020d1"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"65ee68afaa45984c835aa178e7726a5f5c7070caaf1050479d2d36a11c2dafb7"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"4a8a5442dfb1cc63e00163224ef388c7833cffa7e5d0426b7be2f3514cf42d79"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"4ce594933dccbfcecf54457d9b79e2493c8a23f3b4a6f7fd777025f9ad2f25fe"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"27d6052cf60e97bc9a7eec6b911f044d5da27abf91adf4b86d5a82d2acd73038"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"62526fa764e4f3e621625ef393bc8819a1d1229068818395614c50db5151def3"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"2e418ee85d7bec2f58346132b0d147b177b4847b48df1bf5434f0007ba338f3a"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"2c5121fe0a756522e7a3a8a123cbcea64750b023398c1f377f61ecefef612801"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"95ee0bbd3153b91bb4b78f813c8d49fd4beba82dfd35968240985788a3d10efb"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"2eeafa6ee0900a747da67178dc8269315e30fb4a3b0ae822c905c27fa4b34a1a"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"f9ca76696bc4dfd213a9312f505c8c6db5975d4bd0aad30c49d1cb0ad7e25899"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"d68ed695753dde9fa99ba43de2c9b0b193dead59899848802f09a9d5f86f8a65"},"taxa":[{"id":"CWE-290","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D34","level":"note","message":{"text":"Orphaned files with no living knowledge: 143 of 1776 analysed file(s) have no living knowledge left \u2014 their last meaningful change has decayed away, so if one breaks, no one currently understands it (counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated, example/demo and scaffolding-template trees and test files identified by path convention, largest first; 1776 of the 5927 production source files in this repository met that bar). None is large enough to earn a read-through of its own, so this row stands in for the per-file rows rather than raising one each \u2014 most significant first: src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php, src/applications/phriction/editor/PhrictionTransactionEditor.php, src/applications/conpherence/controller/ConpherenceUpdateController.php, src/applications/conpherence/view/ConpherenceDurableColumnView.php, src/applications/celerity/CelerityResourceMapGenerator.php, src/view/phui/calendar/PHUICalendarDayView.php, src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php, src/applications/conpherence/storage/ConpherenceThread.php (and 135 more). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"ce861fd78f6935114d3a342cb90ad25870f984e1042954fcbbe27c0e23be3658"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"89445836e97150e2d7b55bc5eaf934940bbfff2d56e342f392850c95b2b9a02a"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/editor/PhrictionTransactionEditor.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"f0bbe12ce260c8810832f2e6749c7c8ad253c801ed9721647ecfaedc28792a20"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceUpdateController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"fb40262c3571512466ce50d9c8e620358cd28d8ceacdfa09f062fca27257a7bf"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/view/ConpherenceDurableColumnView.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"f651ceaf58549cb27db151cc0d2e4ab0b88e4521aaf287dcc3fffd7fa4a2aaef"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/celerity/CelerityResourceMapGenerator.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"dd8901d33c7df96c9f6f07666a4f6b8871ff4f8e061aef835fddd1f31e959f82"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/calendar/PHUICalendarDayView.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"6e50e199e03945b54459a479c9bd02b6c65c21d8e2cae9729634bd17847f97e9"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"686b8c8c762109a0fcab9958fa727814b3f28342f8e53e3da75748fd1e1d8d82"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/storage/ConpherenceThread.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"c33b2e4fea1ade39059c226929c2c4be6bcdea49f383e27b6ef437b952f947dd"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"1edba34615618f3f81f2629e28f4cb42041e92151c3c629820f931944fb28c90"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/DiffusionLintSaveRunner.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"10ad9c214eb1136dc28de9349fa0e2429c517c350429b7bb85d65195c0da75f9"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorOAuth2AuthProvider.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"7a65c371c6ee0db2e6de2aa48c132d3f9bff901dc15576edcf20072913bc5e1b"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/celerity/postprocessor/CelerityDarkModePostprocessor.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"b33567008df5873f3be3da7d573c24d6a3560ee93f1bbc9141df49aa8b15b330"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/cluster/search/PhabricatorSearchService.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"dc8bdee7faf77958aeef9b87d61e230b9dd7bf279bb9a3cbe5d49fd31b534340"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/editor/ConpherenceEditor.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"d122a10146f1e9060a43da0fbb9723e2408713f8890b1ed2ee5bcf4df8f06a15"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"25e034d44c9025aa28a4944e0ddc73a2975836ee9486d8964d16c8d089414a0a"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/ConpherenceTransactionRenderer.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"7b15e96fc6a9eac5c2d0edd219bdd54a8c9cf7ae4dd25a50b7fb872c621e6ac3"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceViewController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"a945eff329e3e1bc8f1f44e5c532211b55de82143618885fc2c4bc6db61cf8e5"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/editor/DifferentialDiffEditor.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"da67d346350f22b81ac40a7e2c3969f0fbc31e3fed5022848b60fd28ceec5a0c"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/blog/PhameBlogManageController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"28247bc1f11dc18209716561b9a51e21f3356f151e709f130232f94416cbc958"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/view/ConpherenceTransactionView.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"4ece3567cd2d1b663b708d7049624e78c6b5f61193d8435a96c24b6cb6f75b5d"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/blog/PhameBlogProfilePictureController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"e408e82046dc4f4984fbe81a2df137da138e69af93476e99a9a38748f4722dfc"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/owners/xaction/PhabricatorOwnersPackagePathsTransaction.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"c2aa1c1f8e99ba38a0f0a225371d67ced484b63a45ee9b0dce27582dd7ba2e53"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/xaction/ManiphestTaskStatusTransaction.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"95cf29b4c8852e66bae7ffa8f18839361320547dff5257446c1cba96ad069c72"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceRoomPictureController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"af158883f1d86c4ded6f729a586e4503298889b5bde1adae4879a748a0c49ca1"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phurl/storage/PhabricatorPhurlURL.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"6213f3ce8f0c43b4fb25e561fa49233a63e92f950d13d82959943cd08b52ca57"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"scripts/symbols/import_repository_symbols.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"6b3d0d3434c7aa3af2c73672e2ce46e79334a7d7e4c83609230b7ab874059d62"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorPhabricatorAuthProvider.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"f3ada90edc45fd03d6d78271482aec6427359868b62216aab5d448775b2412dc"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/controller/merchant/PhortuneMerchantPictureController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"89ea5ceb638c91bf3ad9a29371a009e664df9883df36c878f1b741efb21a2eed"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"035b21434c895d3ff647bd99344beb1e4572968749eb72f15f4f66bc952d2146"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/settings/panel/PhabricatorNotificationsSettingsPanel.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"877c5c468e6fd645a6cc252f656d6e178668ff6be2a18259975b8704e6791b7d"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceListController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"36100f05c5584bd7f683cd586ab0b7012719ac8aeb9a2f7f21887d6e1234339b"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/legalpad/controller/LegalpadDocumentManageController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"3aedbfc9972106a31ba538e240f3fc8ccb855e89ca47a133c952a3859f212510"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/guides/module/PhabricatorGuideQuickStartModule.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"a565acf5d1ff1a303a2e4ca733d5f5e69a773ca299233f9ee5fa15ae881e8628"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/storage/PhabricatorBadgesBadge.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"3a6df2607e030131918bd66f2769ab7c2f83bffc6e15d95795e6a2cc9aa5dc1b"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/guides/module/PhabricatorGuideInstallModule.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"2e7f4a23ee704f32256fa34f1d1907f08893fc4e672b848d578672c73e06bf33"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/meta/xactions/PhabricatorApplicationPolicyChangeTransaction.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"8e37245450f46452a582eebf5f0ed07b1e5ee05e89c884a8eb57165d811666ec"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/legalpad/editor/LegalpadDocumentEditor.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"f5735df39ca09d0cea6b3a475ca57dfd5e40f8b1c0271a8c88a9c0b245fee09a"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUITwoColumnView.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"f868d2c539f4dd7e2bb5a7b3f0de14a2f187e6177b6b48d56bccf39efffc6f2a"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/controller/DifferentialRevisionInlinesController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"9ccc45d79dc107d3fd4314cc04ffde40526799d7f062ef1aa0ac0ee722fbfd52"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/editor/PhameBlogEditEngine.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"3252f538971aea5cd3d847750ce938dd84f4d7f70364ef551adbe621d41fa3a2"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIHovercardView.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"a97a984cacc5f66fe7dcf5de30802fce3da052e4f4dbd71ad8c7b1fbcf6d7447"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/editor/PhabricatorBadgesEditEngine.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"c3f2f94eb7b7c43662801261f6cbd0505afa243c5c720af17bad49bebfe63148"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectColumnHideController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"9e7fc37e5866e730ee430709ae293deaed95d13bec66a839427ac1546939515c"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fund/editor/FundInitiativeEditEngine.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"74787f36dd179301b6f63e29958074b500f815120e68d8cdce4be355d8adef07"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/editor/PhortuneMerchantEditEngine.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"a3c141e38c7beaa57b6a9294bb4f80f58fe475c215351e8b8034cd9b966ec7f8"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/view/DiffusionBranchListView.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"159f9fcca4406be058b2645f70ce6abe1d3f60a4fdd8fcc464b7a8183a1de2a9"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/ponder/view/PonderAnswerView.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"bd561e197e3e142b42c45ff1e8b8b68a3b42c4d5054cd3534375efddc8264f46"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/xaction/PhabricatorProjectSlugsTransaction.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"30fd70521e4483452b0510b4dea812eef799754c7e4bae7d672dac89272a452b"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/view/ConpherenceThreadListView.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"d5b0b3f0ce5817ab0599b2dceb639eae41bc77a9e80636fe3ffa1f66b3db53ee"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/editor/PhamePostEditEngine.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"9f61bbfb07749a80548b90a2137762c4d1ebc73791d206f84205fda12a8c36f3"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/editor/PhabricatorBadgesEditor.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"633a77a260de53f8cdfb044cdbc739447169f5dee60ab5c4df97ec9a43b37585"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diviner/controller/DivinerBookEditController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"336765d55a387486528343c70b7cfb6b462d389c5aefb46377d4dadd0272279a"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/menuitem/PhabricatorConpherenceProfileMenuItem.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"cecd08deb128406107feb65f7f0014e2c8c1009a0e3e19c0730a465a22a37a5d"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/view/PhabricatorApplicationTransactionDetailView.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"49f7d885b3a13d1be8a758e99a199de49feb0246715b733e5c714123095542bb"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/tokens/storage/PhabricatorTokensToken.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"58daf20c701f26a7c27142a3cdd5ef30bdda23fa205b3262031e584e7c74064c"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIBadgeView.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"23c96f37a2540bae9554ac751d7336d24ddb356646077474c37aae4c06bca76a"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phurl/controller/PhabricatorPhurlURLViewController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"ff36e2ccc62d4c09b50db3fb670d44629d9bff362b88c4b75f7a2d879f125637"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/xaction/ManiphestTaskUnblockTransaction.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"ca1f3cb056319cf98d8bfbc3b44b6cc9c663464417c68d49d2970c03a2474292"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/query/PhabricatorBadgesSearchEngine.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"f865695b5dfa8630f52b66918365b8e00168bd5908f6620a4d3c8fde017ae0d9"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"1141c43303384f12e9f27b7d087c193728203abe39613c0e2d18c86d4613aa4f"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/xaction/ConpherenceThreadParticipantsTransaction.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"566561043b034698d519459193cd29db296eca8c8a2de4b80a2439d72759cd26"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionIdentityViewController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"6eca5ef669f5b81ee23f543c106da981d8d17cf16dc9742851d31d1cad8060d6"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/xaction/ManiphestTaskOwnerTransaction.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"17620a9db0ec348977eb970ece6e171f41f59fbdf141978e8230d90a496a0c27"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceNotificationPanelController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"816768ebfc3c3e4d4bda57a89b10e48014429c61aa30a7f8ed340e9c64918067"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/query/PhamePostSearchEngine.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"549a87eac6c9f0c0e7c1fe7e1e9e18b8b45063f2d4513e4b500bf3da8338e10b"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/query/HarbormasterBuildSearchEngine.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"77219a7fd501069e2e1a7833e589dd204a4aee201b3fc1af8253310edfed1579"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/passphrase/conduit/PassphraseQueryConduitAPIMethod.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"e0cb816b7ffb258db4a92e55d10676c47fc89a592be932397960a976d52c77e1"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phurl/query/PhabricatorPhurlURLSearchEngine.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"f6630e76fa8e80478ca85ff46889bdde858c96827dd7f774754a69031a512fc8"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceRoomPreferencesController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"0b53eed15108ec383f6fe31f3dd29fccd6248d94feffff8544101e4d37d8128e"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/layout/AphrontMultiColumnView.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"4b4ac04961b9996c102a8242e9159b1ee38dc62f6a8faeb8faf58014903c5974"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/post/PhamePostHeaderPictureController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"25e0b731e979df7746df32a5799c5576521291ce9da4ec1dd0bc5db07b3d9f64"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/controller/PhabricatorProjectBoardImportController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"3b60ce506090800b5811437af3bc1ccc11b15e79f2d8e21edbc567ddf10a3c49"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/trigger/PhabricatorProjectTriggerManiphestOwnerRule.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"e302159eb28bbaba5f671f8eab7d6e5ef01ab5cccc4f601d266ff2f323d93e4d"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/editor/PhortuneAccountEditEngine.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"be9e50f4fd86577f77f8c6afb180c67b33257622f7974ae72411f942cf81a49f"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/editor/PhamePostEditor.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"4a353ce813079db86f68b9a39d528c4512b2cf144ced4f9246c00213351c5725"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/conduit/ConpherenceUpdateThreadConduitAPIMethod.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"df72a816eb587599f2ecb2d16451abe30be7a2cdc238b3ebd1b0400a0cedc1ae"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"scripts/symbols/generate_ctags_symbols.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"7bc6ea09963aa7b7257df7eefb2357ec032c86c1af21d4cc617bc83bf647af97"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/controller/ConpherenceColumnViewController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"ba2797cc291b2e000992e22171d1dac1b179e258129122e97609e752e2b19a17"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/PhameHomeController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"7fc4f6492d2472f32c1c2601f149e604f5f5926dcc87c57873a9e8e5c925a6ea"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/mail/DifferentialCreateMailReceiver.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"2a1c4d9f2d672797a10accfc64b33b07ae4a0d5021a91ea6fd9f876eeae238e5"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/conduit/DifferentialCreateInlineConduitAPIMethod.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"619a208a573f850fc6cf06fd24fd579519c8c12621ed47fc9899409dc3dfe679"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/query/PhabricatorMetaMTAMailSearchEngine.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"660959952481aa2671d99ab69bd55f3f16fe43e55e89bd87eeaedfcda44a7ea9"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/services/PhabricatorConfigClusterSearchController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"04a8681ed3e221e774592bb869062fc6ce8edb76102761b9112457a44d6e33ae"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/symbol/DiffusionPythonExternalSymbolsSource.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"db75f66844a0529853e2a199b1fbc564638acedb02ad9fd56a6cf3e35a71d6b4"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/controller/DifferentialRevisionCloseDetailsController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"78db87c7826cf9053c4e1a65b985d9f849f8d4312d5f72d129a36958e8d92c97"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/editor/ConpherenceEditEngine.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"6b290c1d880e7b13aba661f9773b102fbf242297df9177e1f6e2d0fa18758200"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/controller/PhabricatorBadgesViewController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"d2462b103af9a53329047aff3637f734b6c6b65826d8d0bffc24dd497f481f5b"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phurl/editor/PhabricatorPhurlURLEditEngine.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"6f102de0fa304f39930767e3c92a22f07d32e709560b7e472a471f81d4484d4f"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/typeahead/DiffusionTaggedRepositoriesFunctionDatasource.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"9248e5a371778ac1f7eedb24f2733ed2dfd5d905f4c6b350a5683f3bc033b2ce"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIActionPanelView.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"4018d63d7a1702de60e78472db6d10721a9fb1a95a325d4fbd893de06bfa8e8e"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/ponder/editor/PonderQuestionEditEngine.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"882309a74e453af3a0a1a43791bb39d666418f858ddcb4d459860f9e55028224"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/calendar/PHUICalendarWeekView.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"6505972ec3e3b7be036c9733d558d711fbd0a9c112a26562a63e62c15b75b736"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/xaction/PhrictionDocumentTitleTransaction.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"4a743102df7999092c47a77f3c664b65969fb21dbfcd92969aeab8f68eef0bf1"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/conduit/DiffusionMergedCommitsQueryConduitAPIMethod.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"a6619806a106ee168c44e5382f754cbbdd99480acd75e415601a9bacce9fde2b"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/xaction/PhabricatorProjectNameTransaction.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"15cd83f30fe3105a44870ac0bd59676a030f2a2e8423bc674d3437c297b52df6"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/xaction/ManiphestTaskCoverImageTransaction.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"ef9aa7b0155b8266b1a00dea1a99b583cca438a7a1f3ea9fb2c6f20de8439b0a"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionCloneController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"6234ba26cf13bbfeae4428dff18c2ffb241d2fbfead56e1c080752ae035ab673"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phid/remarkup/PhabricatorHandleRemarkupRule.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"33b1f3c17520c374221ed5bb09f34a11fa2e196b06f43d76c6ea4706198de2df"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/query/PhameBlogSearchEngine.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"63f46d48d97839b8937b79a14f3f2e05e4bb7ba49d452ebfc42208ca3eed9019"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/controller/PhabricatorFileLightboxController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"1b093df7833511aea07cbb137261773e9b05beb330e0c13ad0be8e123525defb"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/view/DiffusionPatternSearchView.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"2d01fc0c5c6005345a90507550bb82baa395c23c11388275a524fd277ab69974"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/conduit/ProjectCreateConduitAPIMethod.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"c215379e496342f5389092e99641182807b3c776ebadd19d5202c6b0b3ad1250"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/macro/editor/PhabricatorMacroEditEngine.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"8415678b8c2c87cabaca4ab1c2ebc194a5551097bf3004cd43f9c1ea85180d4c"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/query/DiffusionRenameHistoryQuery.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"9145d4e3511ae011717947be27e3de100d9263cdd13cfcf2b69f349549ebbf9a"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/view/ConpherenceParticipantView.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"982cb382366a0e1f7449ec978c23a8cdfe2d1e98fd430b46435e87c9a77d7dc9"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/controller/blog/PhameBlogFeedController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"745a0dd058d9cc6b5242b5fdca5f5e128ae61b4b360992903ccb0dc72c5165cf"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/conduit/ConpherenceQueryTransactionConduitAPIMethod.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"74444a9c7cf7936f2f8621d63660ec3db7cc86133c50be08dfc137952144d213"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIImageMaskView.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"f3b95bc80ddf1942c0e584a2889b1d45cfc77677198dd3758cda824a9db377e0"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/passphrase/controller/PassphraseCredentialConduitController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"62a2d177e91aefbba6bb07d69fbe7fc253f48b63056b8be48fa040af99e94240"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/query/PhabricatorBadgesAwardQuery.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"b64ce188eb900db065b1a0aa450a340bcde4f1d5fe5cdf6d1b82be5678415687"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/trigger/PhabricatorProjectTriggerRemoveProjectsRule.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"b06345f700b3e6d5aa1b58b7fc17a42060cbf06a8dc1752a6930e75c25a491f7"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/trigger/PhabricatorProjectTriggerAddProjectsRule.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"b5a452192b234903b85116a2a42ceb0b72dd14c7a02fa88cea3248fc2f9c06aa"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/ponder/constants/PonderQuestionStatus.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"9c60d2a8b998c1c4b7385e23d0c158059f6f0f432cf394109fc0a118e0a542c0"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phurl/editor/PhabricatorPhurlURLEditor.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"51a67960c5522b5e4e8ead6068febf50cbbf3a7017280abfa3b96c8e1dd47096"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/lipsum/PhabricatorPeopleTestDataGenerator.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"272e7833ba1e290f25043e6d9ea23cae00878b468f45e1a07b478d68178bd48a"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/command/PhabricatorCalendarEventRSVPEmailCommand.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"ef82c5c569e46dfb0f49fff226f3392208cddf6d634bd544d2bfb3c4e68a7b18"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/xaction/PhabricatorProjectImageTransaction.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"964100b67b09344e546f6fa66238f6ecce7220b04c2a593735c82873ba2075e0"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/aphlict/query/AphlictDropdownDataQuery.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"63095e5275a4bb8ec89b61ab5960748789773cb837870a25d5c8eff18fbbb243"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/management/PhabricatorConfigManagementMigrateWorkflow.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"86261d1c26661263e745d9a4855958c321d6143fe0b49f02597174ac04e91b0c"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/trigger/PhabricatorProjectTriggerManiphestPriorityRule.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"90320a269e76e303e0775fcc729fae6c65c470ec843f3abbf82dd043a0f32436"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/util/CalendarTimeUtil.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"475ba823a4c9a079402c3dddb8b99b0fb175a8e766bd10dcee3dd7954f4e9283"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/editor/PhameBlogEditor.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"12ec31ebb2b7b8c5b76ebb40a8d687339d3f6160971c7e25b50708850eb65976"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/metamta/query/PhabricatorMetaMTAApplicationEmailQuery.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"7f7e45389f3be1a2a23bb3e5c62024eeea1439da9e51a31cf3f412e2005853b3"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/xaction/PhrictionDocumentMoveToTransaction.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"d2a7c50506c9e81bc85186296ce64ba3cf5e35327d2bf7997e1488c840eea2ea"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"resources/sql/autopatches/20140722.appname.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"40da251cc4f3dbfa7a4aff7073fad0c4bfc09b0003cb618a96517e36a1c9a251"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phame/xaction/PhameBlogFullDomainTransaction.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"6b8f96aad8b132219c8face21f8e2cc6ce2677b044e414371b321934c965231b"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/xaction/PhortuneMerchantInvoiceEmailTransaction.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"895e22162b591f63c3800f7f2cd41b6eae11741c1d30026aef17f49a49f7c828"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/phui/PHUIIconCircleView.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"1d9ff6871a2815bcac84b5a2b106f44a13d46efe0e3014ff94d758d8ecc9e5f0"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/fund/xaction/FundInitiativeMerchantTransaction.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"a3452110dc03e204cac7bc0c9a373a832fd1702b3ed432e6f3b5d2601eafbe54"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/maniphest/xaction/ManiphestTaskAttachTransaction.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"2214e7b95b1918cadc92d8e0e652f2d3b9735cb03241c06639882e689edffa06"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/oauthserver/PhabricatorOAuthResponse.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"7485049a0b07b5f88e56b2f73fd4e777b9ce328712a56be0158b3cbd29360f21"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/countdown/editor/PhabricatorCountdownEditor.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"f668dc55e5505107187bbc70e2a6a4c746af29972e8fd740d7c2d73b82e188ba"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/cluster/config/PhabricatorClusterSearchConfigType.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"4c2fefea5a094e70fe8f2613da4b8265746e7c8e2a34efdbbd257f0016686340"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/cluster/search/PhabricatorSearchHost.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"34cc6d26a177e9599cfd153f4e55aa6cd248e7c9adcd8f0a572dd42128cc0ca2"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/query/PhabricatorBadgesQuery.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"27507424a43b89172d869e1ff84f828341f5c2544fc01be75590e1fd7bb62337"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/controller/PhabricatorApplicationTransactionCommentRawController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"48371e50ca05dcef6da8b7d6490aad772ae41ae10ea49f5451e9af4dca052738"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldLink.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"c1d9810d00eb329baa04ec9e091ad385d337d97b1316c47aa0a47321c4aeafb4"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/conpherence/view/ConpherenceMenuItemView.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"6232206e8cf6f82b545fef6d0a63853def1fe613c4e81e8d92e77791e7a87644"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/xaction/PhabricatorUserApproveTransaction.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"908e26b48aeeb4c366348e3dc55f6c2423622b83ec528152614f7496fca3df59"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/badges/xaction/PhabricatorBadgesBadgeAwardTransaction.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"d15bbfda0d360c185373d0c9ef5726b0d6629104626bef693d5e4d3341dc96ca"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/conduit/UserQueryConduitAPIMethod.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"ad2547db2e7fa73e9381e410e4564f7a33a8d737684aa252f7eb513258b7267b"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/owners/engineextension/PhabricatorOwnersHovercardEngineExtension.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"6d31e4976cb04626abd98be365559773defc4fc0d7fc4b77dd13e391d1d8202a"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/storage/PhrictionTransaction.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"40e35fb49ea352d4dcef97403a3f97ccdbdd90c50998c254f97bd46a35492218"}},{"ruleId":"M1","level":"note","message":{"text":"Thin README: The root README is 33 words, against a bar of 120. Of the three newcomer-critical sections this check looks for by heading, in the README and in the repository documents it links, it found no a build/run or getting-started section, no a testing section, no an architecture or project-map section. Sections are matched on HEADING text only, so material written under a heading this check does not recognise \u2014 or with no heading at all \u2014 is not seen and this row may understate what the document covers."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"README.md"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"c88b11295dc6ac6146c259ace6043143959f96dc98628f8c8578b6c5f95b8149"}},{"ruleId":"M2","level":"note","message":{"text":"No ADRs: No Architecture Decision Records found \u2014 no conventional ADR directory, no numbered \u0060NNNN-title\u0060 documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"670b3d6e36a756d63097d0dfbf90afd5fc761308800b9354894a07c3f4e4aa14"}},{"ruleId":"M2","level":"note","message":{"text":"No architecture diagram/doc: No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named \u0060architecture\u0060 or \u0060design\u0060 in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape \u2014 no \u0060## Architecture\u0060 heading, no \u0022architecture overview\u0022/\u0022high-level design\u0022 phrasing, no \u0022the architecture is \u2026\u0022 introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document \u2014 not evidence that nobody wrote the shape down."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"0c190e7c159d1850ee706c3ac4486e151e8a4fe169de4bf61436b9f399654f06"}},{"ruleId":"M4","level":"note","message":{"text":"README/code drift: externals/octicons/README.md links to \u0060./CHANGELOG.md\u0060, but \u0060externals/octicons/CHANGELOG.md\u0060 does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents\u0027 own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"externals/octicons/README.md"},"region":{"startLine":172}}}],"partialFingerprints":{"codehealthFindingId/v1":"f092491b6ac59a6e2f0c0fbac8fa29ca53b4574459a258bd4b59a52e5d66ea4c"}},{"ruleId":"P1","level":"warning","message":{"text":"No CI pipeline: No CI workflow found (.github/workflows, azure-pipelines.yml, .gitlab-ci.yml, \u2026) \u2014 changes aren\u0027t gated by an automated build/test."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"44f01af96e50474fba2df84d95ddf4f7e1d34c29c307830b9efc9057daa6b670"}},{"ruleId":"P2","level":"note","message":{"text":"Logging is not universal: Only 1/2 runnable modules use logging (modules with no entry point or server are excluded \u2014 they are libraries a runnable module hosts). Silent: \u0060.\u0060."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"91a94e21d6d4d0e6a2003f94505b0b02b157176f0b24c4820f3f82b4447a97fe"}},{"ruleId":"P3","level":"note","message":{"text":"No SAST: No static application security testing detected. For this repository\u0027s stack, add phpstan or psalm (or \u0060semgrep --config=auto\u0060, which runs on any language) \u2014 this repository has no CI pipeline yet, so run it locally to clear the existing findings, then make it a step of the first workflow you add so a regression fails the build. What was searched, so you can tell an absence from a miss: the 0 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge\u0027s web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen \u2014 if that is your case the row is wrong, and saying so is more useful than adding a second scanner."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"6e54424179c892f03ef2fd003130ac4bd43f39bbf3b1ca0a0143e25acb80ec87"}},{"ruleId":"P6","level":"note","message":{"text":"No changelog: No CHANGELOG/HISTORY/RELEASES file \u2014 what shipped when isn\u0027t easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)"},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"dda5aa5aed8cbb292c3ef2b733bc138f614293ae6426c85e98bf31ef330d9415"}},{"ruleId":"P7","level":"warning","message":{"text":"Outbound HTTP without resilience: \u0060https.request(\u0060 makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service\u0027s request, thread or connection until the call gives up on its own \u2014 or never, for a client with no default timeout."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"support/aphlict/server/lib/AphlictPeer.js"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"60ae18d447eb9b1ea3c9dc438fcb14c1cacf913ac20ccc46ac43c295f4a7970e"}},{"ruleId":"P7","level":"warning","message":{"text":"Outbound HTTP without resilience: \u0060http.request(\u0060 makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service\u0027s request, thread or connection until the call gives up on its own \u2014 or never, for a client with no default timeout."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"support/aphlict/server/lib/AphlictPeer.js"},"region":{"startLine":48}}}],"partialFingerprints":{"codehealthFindingId/v1":"ad29e04ade43922085bfc85561ae5ce51b20e2896945a1418abdcc4e6dd6225d"}},{"ruleId":"R1","level":"warning","message":{"text":"Type Safety: 0 typed \u00B7 183 plain JS \u2014 the untyped files are support/aphlict/server/aphlict_server.js, support/aphlict/server/lib/AphlictAdminServer.js, support/aphlict/server/lib/AphlictClientServer.js, support/aphlict/server/lib/AphlictListener.js, support/aphlict/server/lib/AphlictListenerList.js, support/aphlict/server/lib/AphlictLog.js (\u002B177 more)."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"d00ee7953f55325a823d27e5db9657c80ca9b9861c0c0abf8fe487cd3fa586d3"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplication concentrated across 4 sibling directories (23 clone groups): 23 duplicated blocks under webroot/rsrc/js/ have copies in at least two of the sibling directories application, core, phui, phuix \u2014 14 of them are reported below, and 9 are counted here but not reported individually: those copies match on shape but no longer clear R10\u0027s bar for an individually reported row \u2014 either they kept neither their own names nor their values, or what was copied is too small to stand on its own (it reports near-exact duplication only, and only of substantial extent). What this row states is the concentration, which the detector measured over all 23 and which does not depend on how exactly each block\u0027s copies still match. That concentration is one structural fact, not 23 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module \u2014 a common library every sibling imports \u2014 rather than 23 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffPathView.js"},"region":{"startLine":189}}}],"partialFingerprints":{"codehealthFindingId/v1":"7a91aea7d1f2f1de9c282e13c716881a5f9a04aaf49dd62badaa325a3429b751"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplication concentrated across 6 sibling directories (5 clone groups): 5 duplicated blocks under webroot/rsrc/js/application/ have copies in at least two of the sibling directories conpherence, diff, files, owners, pholio, projects \u2014 2 of them are reported below, and 3 are counted here but not reported individually: those copies match on shape but no longer clear R10\u0027s bar for an individually reported row \u2014 either they kept neither their own names nor their values, or what was copied is too small to stand on its own (it reports near-exact duplication only, and only of substantial extent). What this row states is the concentration, which the detector measured over all 5 and which does not depend on how exactly each block\u0027s copies still match. That concentration is one structural fact, not 5 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module \u2014 a common library every sibling imports \u2014 rather than 5 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js"},"region":{"startLine":810}}}],"partialFingerprints":{"codehealthFindingId/v1":"a400d3517ef99d47478517d29bdb3b7299cb72dfa7661d288548051f1c501a9e"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (26 lines \u00D7 2 locations): webroot/rsrc/js/application/search/behavior-reorder-profile-menu-items.js:10 \u00B7 webroot/rsrc/js/application/search/behavior-reorder-queries.js:10 \u2014 the 2 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/search/behavior-reorder-profile-menu-items.js"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"38441dfddd777baf09ed863715978441e71f5e6b9f879ddc65681b01d0b699af"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (23 lines \u00D7 2 locations): webroot/rsrc/js/application/herald/HeraldRuleEditor.js:179 \u00B7 webroot/rsrc/js/application/herald/HeraldRuleEditor.js:258 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/herald/HeraldRuleEditor.js"},"region":{"startLine":179}}}],"partialFingerprints":{"codehealthFindingId/v1":"933b24de75bbf05cd21656a0c49a2f6b102c892be0844f86480033145f93eb0e"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (20 lines \u00D7 2 locations): support/aphlict/server/lib/AphlictAdminServer.js:41 \u00B7 support/aphlict/server/lib/AphlictClientServer.js:46 \u2014 the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"support/aphlict/server/lib/AphlictAdminServer.js"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"ba0cd97e6e2772414563af892eb047811d42595476d438477409d2f99ab2f174"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (18 lines \u00D7 2 locations): webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js:252 \u00B7 webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js:274 \u2014 all 2 copies are in the same file, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js"},"region":{"startLine":252}}}],"partialFingerprints":{"codehealthFindingId/v1":"3b69a84cd2974b3b81029cce9821ec6efc5564bc01d98220b1f9a79b44966c16"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (18 lines \u00D7 2 locations): webroot/rsrc/js/application/diff/DiffChangesetList.js:418 \u00B7 webroot/rsrc/js/application/diff/DiffChangesetList.js:470 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":418}}}],"partialFingerprints":{"codehealthFindingId/v1":"b05b1680a944bff4ba5558a61338267a0a17f2afabd73eb09007ffd0e543f378"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 2 locations): webroot/rsrc/js/application/transactions/behavior-reorder-configs.js:10 \u00B7 webroot/rsrc/js/application/transactions/behavior-reorder-fields.js:10 \u2014 the 2 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/transactions/behavior-reorder-configs.js"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"bca397e39ed6a6681335c8a2cc74bf86dac16cddf150c95ad8925466bdc5b805"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2 locations): webroot/rsrc/js/core/behavior-lightbox-attachments.js:212 \u00B7 webroot/rsrc/js/core/behavior-lightbox-attachments.js:234 \u2014 all 2 copies are in the same file, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-lightbox-attachments.js"},"region":{"startLine":212}}}],"partialFingerprints":{"codehealthFindingId/v1":"ba4ed66812d8802a33871d53fc61427886a2d39333c26e74f202c20a298bb6c3"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2 locations): webroot/rsrc/js/application/diff/DiffChangesetList.js:2819 \u00B7 webroot/rsrc/js/core/behavior-oncopy.js:158 \u2014 the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":2819}}}],"partialFingerprints":{"codehealthFindingId/v1":"d9b768e38b81afc0ff68ea385c586f9c941a17defc077a0892f180ce92d5bf0d"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2 locations): webroot/rsrc/js/application/repository/repository-crossreference.js:59 \u00B7 webroot/rsrc/js/application/repository/repository-crossreference.js:328 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/repository/repository-crossreference.js"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"3c7307da07c11b28ce02f74e6fc10e66b970e550cde55390ea779e7dc0181e0c"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block with local edits (14 matched lines \u00D7 2 locations): webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js:810 \u00B7 webroot/rsrc/js/application/projects/behavior-project-boards.js:37 \u2014 the two spans are one implementation copied and then locally edited \u2014 67 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row\u0027s finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters \u2014 or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js"},"region":{"startLine":810}}}],"partialFingerprints":{"codehealthFindingId/v1":"25fa7a840c89797d5a3795323f21cab3c4620e085ed21261308f53fdc30a60bb"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block with local edits (14 matched lines \u00D7 2 locations): webroot/rsrc/js/application/projects/WorkboardController.js:153 \u00B7 webroot/rsrc/js/application/projects/WorkboardController.js:178 \u2014 the two spans are one implementation copied and then locally edited \u2014 81 tokens are still identical, in the same order in both spans, with only local edits between them. The copies have already begun to drift, which is this row\u0027s finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters \u2014 or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/projects/WorkboardController.js"},"region":{"startLine":153}}}],"partialFingerprints":{"codehealthFindingId/v1":"09bd274c2fe117ea98bcaf908ad3d94ebc389c512ca77d42de0273acb89bcdde"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 6 locations): webroot/rsrc/js/application/diff/DiffPathView.js:191 \u00B7 webroot/rsrc/js/application/fact/Chart.js:228 \u00B7 webroot/rsrc/js/phuix/PHUIXActionView.js:180 \u00B7 webroot/rsrc/js/phuix/PHUIXButtonView.js:87 \u00B7 \u002B2 more site(s) not listed \u2014 the 6 copies are spread across 5 files, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffPathView.js"},"region":{"startLine":191}}}],"partialFingerprints":{"codehealthFindingId/v1":"3a08d5b87071951322a1a70ec0e0615272ec81bb3a7d9b8f8530eb32f48decbb"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2 locations): webroot/rsrc/js/application/policy/behavior-policy-control.js:45 \u00B7 webroot/rsrc/js/application/policy/behavior-policy-control.js:61 \u2014 all 2 copies are in the same file, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/policy/behavior-policy-control.js"},"region":{"startLine":45}}}],"partialFingerprints":{"codehealthFindingId/v1":"151a14505da2d4ad4e296bd926e58c07f28bb264d335443ae491ff48b6567a7a"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block with local edits (13 matched lines \u00D7 2 locations): webroot/rsrc/js/application/projects/behavior-project-boards.js:22 \u00B7 webroot/rsrc/js/phui/behavior-phui-dropdown-menu.js:9 \u2014 the two spans are one implementation copied and then locally edited \u2014 91 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row\u0027s finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters \u2014 or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/projects/behavior-project-boards.js"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"52e1be2d1e4f2c58830b5587deabe3c0d5183a09ea62f8cf3612cd780ba5d44c"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 3 locations): webroot/rsrc/js/application/diff/DiffChangesetList.js:2066 \u00B7 webroot/rsrc/js/application/diff/DiffChangesetList.js:2083 \u00B7 webroot/rsrc/js/application/diff/DiffChangesetList.js:2100 \u2014 all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited. Check what actually differs between the copies before collapsing them: every one of them is an argument to a \u0060install(\u2026)\u0060 call, so where these calls are a MATRIX of cases \u2014 one per input, differing precisely in the case each one pins \u2014 the repetition is the enumeration and extracting the shared part would delete cases rather than de-duplicate anything."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":2066}}}],"partialFingerprints":{"codehealthFindingId/v1":"cf21d964f8872b9bf05bfb174b6c80982fe6e455e9c1aaf7d804689fee1648f3"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 7 locations): webroot/rsrc/js/application/diff/DiffPathView.js:194 \u00B7 webroot/rsrc/js/application/trigger/TriggerRule.js:119 \u00B7 webroot/rsrc/js/core/HovercardList.js:92 \u00B7 webroot/rsrc/js/phuix/PHUIXActionView.js:183 \u00B7 \u002B3 more site(s) not listed \u2014 the 7 copies are spread across 6 files, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffPathView.js"},"region":{"startLine":194}}}],"partialFingerprints":{"codehealthFindingId/v1":"89aff56129b9e96bf25ee205513722b11d54d47d9f533d3c5d4ac84010a9a283"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2 locations): webroot/rsrc/js/core/DragAndDropFileUpload.js:237 \u00B7 webroot/rsrc/js/core/DragAndDropFileUpload.js:368 \u2014 all 2 copies are in the same file, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/DragAndDropFileUpload.js"},"region":{"startLine":237}}}],"partialFingerprints":{"codehealthFindingId/v1":"c55e01b817d0335606103b2dbcd928b6ed9fc0ebf2c4bd8f02ad3dbca3995370"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block with local edits (11 matched lines \u00D7 2 locations): webroot/rsrc/js/application/projects/WorkboardController.js:103 \u00B7 webroot/rsrc/js/phuix/PHUIXFormationColumnView.js:46 \u2014 the two spans are one implementation copied and then locally edited \u2014 72 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row\u0027s finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters \u2014 or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/projects/WorkboardController.js"},"region":{"startLine":103}}}],"partialFingerprints":{"codehealthFindingId/v1":"c223c16592d900617e17a906de91021fca4e3f041e1cd096edfd2e0986934c45"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block with local edits (11 matched lines \u00D7 2 locations): webroot/rsrc/js/phuix/PHUIXButtonView.js:33 \u00B7 webroot/rsrc/js/phuix/PHUIXIconView.js:21 \u2014 the two spans are one implementation copied and then locally edited \u2014 68 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row\u0027s finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters \u2014 or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/phuix/PHUIXButtonView.js"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"baf377467f258b725c5d86cff72beee13cf817cd13fe025d055afe4d56873263"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2 locations): webroot/rsrc/js/application/diff/DiffChangeset.js:1035 \u00B7 webroot/rsrc/js/application/diff/DiffInline.js:745 \u2014 the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangeset.js"},"region":{"startLine":1035}}}],"partialFingerprints":{"codehealthFindingId/v1":"70942a8c7afeb79e144ecc73418c502736176087260df2794f545383d2331829"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block with local edits (10 matched lines \u00D7 2 locations): webroot/rsrc/js/application/diff/DiffInline.js:1115 \u00B7 webroot/rsrc/js/application/files/behavior-document-engine.js:12 \u2014 the two spans are one implementation copied and then locally edited \u2014 58 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row\u0027s finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters \u2014 or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffInline.js"},"region":{"startLine":1115}}}],"partialFingerprints":{"codehealthFindingId/v1":"f5b35587f0778ec9fefc1dc1215b1e636d6d5593277e4dcc2c56bc626de18777"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block with local edits (10 matched lines \u00D7 2 locations): webroot/rsrc/js/application/drydock/drydock-live-operation-status.js:9 \u00B7 webroot/rsrc/js/phui/behavior-phui-timer-control.js:8 \u2014 the two spans are one implementation copied and then locally edited \u2014 52 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row\u0027s finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters \u2014 or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/drydock/drydock-live-operation-status.js"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"ece1b0a43922cdcb89504a4c9f4a3d6790c796b7ff112cd2713a8a7476199ca0"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2 locations): webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js:172 \u00B7 webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js:185 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js"},"region":{"startLine":172}}}],"partialFingerprints":{"codehealthFindingId/v1":"eebf83d8c71952974d2793b0881a6620d4f1fe3b0bed756f340959376de85a58"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2 locations): webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js:359 \u00B7 webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js:392 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js"},"region":{"startLine":359}}}],"partialFingerprints":{"codehealthFindingId/v1":"ac5df16014a60254d63d9d2b09b0d7c72fb33ee03c078030fca697ec00c29db6"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 3 locations): webroot/rsrc/js/application/diff/DiffChangeset.js:866 \u00B7 webroot/rsrc/js/application/diff/DiffChangesetList.js:1986 \u00B7 webroot/rsrc/js/application/diff/DiffChangesetList.js:2020 \u2014 the 3 copies are spread across 2 files, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangeset.js"},"region":{"startLine":866}}}],"partialFingerprints":{"codehealthFindingId/v1":"a9d9262fa3fdd8d9db84aab0836a48c3c4b2c07eac1b88601ef2e20a3436e2bf"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2 locations): webroot/rsrc/js/application/diff/DiffChangesetList.js:467 \u00B7 webroot/rsrc/js/application/diff/DiffChangesetList.js:611 \u2014 all 2 copies are in the same file, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":467}}}],"partialFingerprints":{"codehealthFindingId/v1":"fca0402d327c965e0bc71b24fef86605cafa9778aa87b6548472de6230da3373"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block with local edits (9 matched lines \u00D7 2 locations): webroot/rsrc/js/application/herald/HeraldRuleEditor.js:373 \u00B7 webroot/rsrc/js/phuix/PHUIXFormControl.js:350 \u2014 the two spans are one implementation copied and then locally edited \u2014 85 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row\u0027s finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters \u2014 or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/herald/HeraldRuleEditor.js"},"region":{"startLine":373}}}],"partialFingerprints":{"codehealthFindingId/v1":"909cb19d93b0adcf1d5f20f69ca72ac3e5bc86b5387dedcc4d9b1a09327c0939"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 3 locations): webroot/rsrc/js/application/pholio/behavior-pholio-mock-edit.js:117 \u00B7 webroot/rsrc/js/application/pholio/behavior-pholio-mock-edit.js:197 \u00B7 webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js:246 \u2014 the 3 copies are spread across 2 files, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/pholio/behavior-pholio-mock-edit.js"},"region":{"startLine":117}}}],"partialFingerprints":{"codehealthFindingId/v1":"7171a779fe0dd41012442de8ab30d2189765508172a57391974469cedb91d1ce"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 4 locations): webroot/rsrc/js/application/projects/behavior-reorder-columns.js:10 \u00B7 webroot/rsrc/js/application/search/behavior-reorder-profile-menu-items.js:10 \u00B7 webroot/rsrc/js/application/search/behavior-reorder-queries.js:10 \u00B7 webroot/rsrc/js/core/behavior-reorder-applications.js:10 \u2014 the 4 copies are spread across 4 files, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/projects/behavior-reorder-columns.js"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"e439efa8b2bdd2f9ec520d33d9efb7f713c2c023920c9be723f00913d9df327d"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block with local edits (9 matched lines \u00D7 2 locations): webroot/rsrc/js/core/behavior-refresh-csrf.js:121 \u00B7 webroot/rsrc/js/core/behavior-refresh-csrf.js:137 \u2014 the two spans are one implementation copied and then locally edited \u2014 54 tokens are still identical, in the same order in both spans, with only local edits between them. The copies have already begun to drift, which is this row\u0027s finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters \u2014 or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-refresh-csrf.js"},"region":{"startLine":121}}}],"partialFingerprints":{"codehealthFindingId/v1":"4305bb4af3847e84845464991560a858c9f35c589828009170c36e4520e163bb"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 4 locations): webroot/rsrc/js/application/config/behavior-reorder-fields.js:40 \u00B7 webroot/rsrc/js/application/search/behavior-reorder-profile-menu-items.js:19 \u00B7 webroot/rsrc/js/application/search/behavior-reorder-queries.js:19 \u00B7 webroot/rsrc/js/core/behavior-reorder-applications.js:19 \u2014 the 4 copies are spread across 4 files, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/config/behavior-reorder-fields.js"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"6099d73cd2a46bd1487159b6b7c8da6d788cd1cf12026073f6d0ad1fbd3daa03"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 4 locations): webroot/rsrc/js/application/diff/DiffChangesetList.js:337 \u00B7 webroot/rsrc/js/application/diff/DiffChangesetList.js:418 \u00B7 webroot/rsrc/js/application/diff/DiffChangesetList.js:470 \u00B7 webroot/rsrc/js/application/diff/DiffChangesetList.js:614 \u2014 all 4 copies are in the same file, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":337}}}],"partialFingerprints":{"codehealthFindingId/v1":"4dac7f30c3b48aa3e67bd35c1b147f8e0bd610484224e007a14680d3c03c7632"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2 locations): webroot/rsrc/js/application/transactions/behavior-comment-actions.js:243 \u00B7 webroot/rsrc/js/application/transactions/behavior-transaction-comment-form.js:33 \u2014 the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/transactions/behavior-comment-actions.js"},"region":{"startLine":243}}}],"partialFingerprints":{"codehealthFindingId/v1":"860c554d60995b4f6228dc6afda7ef69b3c1135942c201f73e55e23251decc6c"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2 locations): webroot/rsrc/js/application/uiexample/gesture-example.js:67 \u00B7 webroot/rsrc/js/application/uiexample/gesture-example.js:76 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/uiexample/gesture-example.js"},"region":{"startLine":67}}}],"partialFingerprints":{"codehealthFindingId/v1":"2685f8ecbbcaa3a79e62592b32417f64448fdab87cfa70b18aa117817ef28d4f"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 3 locations): support/aphlict/server/aphlict_server.js:184 \u00B7 webroot/rsrc/js/application/pholio/behavior-pholio-mock-edit.js:200 \u00B7 webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js:249 \u2014 the 3 copies are spread across 3 files, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"support/aphlict/server/aphlict_server.js"},"region":{"startLine":184}}}],"partialFingerprints":{"codehealthFindingId/v1":"4920cca69dfd73c168f13ab57d3377de07bc3a1876497bb756e5d9da6f8c73c3"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2 locations): webroot/rsrc/js/application/diff/DiffChangesetList.js:1887 \u00B7 webroot/rsrc/js/application/diff/DiffChangesetList.js:1896 \u2014 all 2 copies are in the same file, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":1887}}}],"partialFingerprints":{"codehealthFindingId/v1":"e254a3754d7f0792bba471bae48b496838461f69b3e45937e54207a67a8fec46"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2 locations): webroot/rsrc/js/application/diffusion/behavior-audit-preview.js:21 \u00B7 webroot/rsrc/js/core/behavior-remarkup-preview.js:30 \u2014 the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diffusion/behavior-audit-preview.js"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"18bfbe7af6f055b90bacf39bd1bd3c13577bc0da0132c5ee9b9ab0f617d9c084"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2 locations): webroot/rsrc/js/application/files/behavior-icon-composer.js:25 \u00B7 webroot/rsrc/js/application/files/behavior-icon-composer.js:33 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/files/behavior-icon-composer.js"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"8b8576208722e44298e5f1c13cfdf9cf3fa1e3c106dc1e6d9fb13379fcb36cbc"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 3 locations): webroot/rsrc/js/application/herald/HeraldRuleEditor.js:132 \u00B7 webroot/rsrc/js/application/herald/HeraldRuleEditor.js:144 \u00B7 webroot/rsrc/js/application/herald/HeraldRuleEditor.js:167 \u2014 all 3 copies are in the same file, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/herald/HeraldRuleEditor.js"},"region":{"startLine":132}}}],"partialFingerprints":{"codehealthFindingId/v1":"fe855b396c7c45f6681df9e5bc89eb25aa273924a11534daa7134ed8def2cf60"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2 locations): webroot/rsrc/js/application/trigger/TriggerRuleEditor.js:52 \u00B7 webroot/rsrc/js/core/KeyboardShortcutManager.js:66 \u2014 the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/trigger/TriggerRuleEditor.js"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"c5c282e1531b0a27571482103f36b9ba8cca5f3a83a536dd047fe61cf4dcb310"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block with local edits (7 matched lines \u00D7 2 locations): webroot/rsrc/js/core/ToolTip.js:153 \u00B7 webroot/rsrc/js/core/ToolTip.js:161 \u2014 the two spans are one implementation copied and then locally edited \u2014 72 tokens are still identical, in the same order in both spans, with only local edits between them. The copies have already begun to drift, which is this row\u0027s finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters \u2014 or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/ToolTip.js"},"region":{"startLine":153}}}],"partialFingerprints":{"codehealthFindingId/v1":"7fba65e52d2223ffc8c743d7b81f5f6a3ea9c9b62af90f5cb9382008fd7ccc44"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 3 locations): webroot/rsrc/js/application/aphlict/behavior-desktop-notifications-control.js:50 \u00B7 webroot/rsrc/js/application/aphlict/behavior-desktop-notifications-control.js:56 \u00B7 webroot/rsrc/js/application/aphlict/behavior-desktop-notifications-control.js:62 \u2014 all 3 copies are in the same file, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/aphlict/behavior-desktop-notifications-control.js"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"8f5f24caff123868527337930ec9d72a5de0a6995f4db7f72d5d64f327e7ebbb"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 7 locations): webroot/rsrc/js/application/config/behavior-reorder-fields.js:13 \u00B7 webroot/rsrc/js/application/projects/behavior-reorder-columns.js:12 \u00B7 webroot/rsrc/js/application/search/behavior-reorder-profile-menu-items.js:12 \u00B7 webroot/rsrc/js/application/search/behavior-reorder-queries.js:12 \u00B7 \u002B3 more site(s) not listed \u2014 the 7 copies are spread across 5 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. There is one copy in each of 7 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape \u2014 one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values \u2014 and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/config/behavior-reorder-fields.js"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"11dae0246bc9e576a8d14fc02d865bbe3282f4113be1e0caf0bf5f475ee8efac"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block with local edits (5 matched lines \u00D7 2 locations): webroot/rsrc/js/application/conpherence/behavior-menu.js:68 \u00B7 webroot/rsrc/js/application/conpherence/behavior-menu.js:310 \u2014 the two spans are one implementation copied and then locally edited \u2014 57 tokens are still identical, in the same order in both spans, with only local edits between them. The copies have already begun to drift, which is this row\u0027s finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters \u2014 or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/conpherence/behavior-menu.js"},"region":{"startLine":68}}}],"partialFingerprints":{"codehealthFindingId/v1":"50671bf7188910680c84363e1c4e9044074d624f70024365229ea9be6f0d6beb"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2 locations): webroot/rsrc/js/application/policy/behavior-policy-control.js:28 \u00B7 webroot/rsrc/js/core/behavior-search-typeahead.js:215 \u2014 the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/policy/behavior-policy-control.js"},"region":{"startLine":28}}}],"partialFingerprints":{"codehealthFindingId/v1":"4579f70351aad4cd9b0d35aee00127e2d5f5a5b4e658010b98e6583749cce672"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2 locations): webroot/rsrc/js/core/behavior-badge-view.js:29 \u00B7 webroot/rsrc/js/core/behavior-toggle-class.js:25 \u2014 the 2 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-badge-view.js"},"region":{"startLine":29}}}],"partialFingerprints":{"codehealthFindingId/v1":"afc4fc6be0e79c4709863a4c7d35232aca2446615d2b933828356284c51dd689"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function _update (cyclomatic 30, cognitive 46): _update has cyclomatic complexity 30 and cognitive complexity 46; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/phuix/PHUIXAutocomplete.js"},"region":{"startLine":428}}}],"partialFingerprints":{"codehealthFindingId/v1":"4898e2a35a6327e4ccb1999b1c443b428f9603c38d87ed71048cab0d50c87116"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function assist (cyclomatic 29, cognitive 26): assist has cyclomatic complexity 29 and cognitive complexity 26; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth \u2014 arms side by side rather than stacked \u2014 and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js"},"region":{"startLine":188}}}],"partialFingerprints":{"codehealthFindingId/v1":"f8a9a9a16513663e8c32fd5605cf2c615c82dbfdc27432289125fc3a45f4f988"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function updateCard (cyclomatic 26, cognitive 52): updateCard has cyclomatic complexity 26 and cognitive complexity 52; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/projects/WorkboardBoard.js"},"region":{"startLine":601}}}],"partialFingerprints":{"codehealthFindingId/v1":"ae701098384fd6e7c511d37bab716a6682060daa2fdc184e56faa1c01d0155e2"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function _onjumpkey (cyclomatic 24, cognitive 44): _onjumpkey has cyclomatic complexity 24 and cognitive complexity 44; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":650}}}],"partialFingerprints":{"codehealthFindingId/v1":"8075e8dfabf69eb1c3b02ea5d5137f9183ead2d93b5d715169826f890d740ccc"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function (anonymous) (cyclomatic 23, cognitive 39): (anonymous) has cyclomatic complexity 23 and cognitive complexity 39; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diffusion/behavior-commit-graph.js"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"eaa8070083152f0e1be55b2106890e26ff4528284ed51ca49b16558e3cb79d2a"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function redraw (cyclomatic 21, cognitive 36): redraw has cyclomatic complexity 21 and cognitive complexity 36; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffTreeView.js"},"region":{"startLine":87}}}],"partialFingerprints":{"codehealthFindingId/v1":"3413daa5d32a638f1c98afd3a3b4aed4612a3921646bdd1cb83492a014cf3b18"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function _getFragmentLocation (cyclomatic 19, cognitive 35): _getFragmentLocation has cyclomatic complexity 19 and cognitive complexity 35; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":2643}}}],"partialFingerprints":{"codehealthFindingId/v1":"42eb8e7a721a769a989c3e80cee7d2b4cfc4210985cb560ee2e78a2de7cf1e0c"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function getSelectableItems (cyclomatic 18, cognitive 30): getSelectableItems has cyclomatic complexity 18 and cognitive complexity 30; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangeset.js"},"region":{"startLine":435}}}],"partialFingerprints":{"codehealthFindingId/v1":"3d36939c300c63ba43c114553d1afb917adfed2924844fa1060760a0b24869e7"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function _getInlinesByType (cyclomatic 17, cognitive 44): _getInlinesByType has cyclomatic complexity 17 and cognitive complexity 44; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":1968}}}],"partialFingerprints":{"codehealthFindingId/v1":"968860e663ed3955e9a4630a9b2435c8f0166c7ff7f7fa5172e32f8424976320"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function _newHoverMap (cyclomatic 16, cognitive 28): _newHoverMap has cyclomatic complexity 16 and cognitive complexity 28; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":1539}}}],"partialFingerprints":{"codehealthFindingId/v1":"b79813232df2da6f2e70c428cf87af9d6827803dc59d4d54536b6a7932198a07"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function seek_anchor (cyclomatic 16, cognitive 25): seek_anchor has cyclomatic complexity 16 and cognitive complexity 25; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-watch-anchor.js"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"2dea8e10b77a417006ebc0a7d1e7c81f2ccdb5b9baa1f75caf4a7816012c5273"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function _onresults (cyclomatic 16, cognitive 24): _onresults has cyclomatic complexity 16 and cognitive complexity 24; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/phuix/PHUIXAutocomplete.js"},"region":{"startLine":230}}}],"partialFingerprints":{"codehealthFindingId/v1":"c5b73a9d1deac9d8b427b9e3b588d60520e3345cc43eb3455b75bb9dc2f1636d"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function getNewValue (cyclomatic 16, cognitive 22): getNewValue has cyclomatic complexity 16 and cognitive complexity 22; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-time-typeahead.js"},"region":{"startLine":82}}}],"partialFingerprints":{"codehealthFindingId/v1":"cee400636ea1d7aba34fd89ca817bd77857d53b0ced9d2bff320fa3c007b18e5"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function _redrawBanner (cyclomatic 15, cognitive 23): _redrawBanner has cyclomatic complexity 15 and cognitive complexity 23; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":1817}}}],"partialFingerprints":{"codehealthFindingId/v1":"7f6419c4d58253ded8f2e5d9315e65f7bbdf1ab2da9dd234b1aa69f782bf6754"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function _onmove (cyclomatic 15, cognitive 23): _onmove has cyclomatic complexity 15 and cognitive complexity 23; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/DraggableList.js"},"region":{"startLine":486}}}],"partialFingerprints":{"codehealthFindingId/v1":"55cea6c5b65b06a9b8e06390064cebb3189d422c370186b73bc8011c669e9c0c"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function (anonymous) (cyclomatic 15, cognitive 19): (anonymous) has cyclomatic complexity 15 and cognitive complexity 19; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/projects/behavior-project-boards.js"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"d6b00ca9b4d31e36c817ee09672fac72d98f90c4554c3a5a217d043a3bbe58b8"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function openSearch (cyclomatic 15, cognitive 16): openSearch has cyclomatic complexity 15 and cognitive complexity 16; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/repository/repository-crossreference.js"},"region":{"startLine":123}}}],"partialFingerprints":{"codehealthFindingId/v1":"d2a146a5149b858045d0bb2034faf6acc6ecb146b1fb8877009d22e91e9624ec"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function _redrawFrame (cyclomatic 14, cognitive 21): _redrawFrame has cyclomatic complexity 14 and cognitive complexity 21; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/projects/WorkboardColumn.js"},"region":{"startLine":394}}}],"partialFingerprints":{"codehealthFindingId/v1":"fb4aa7955b7105dd19f9cac4ea3005c71704dc411cb5db1508567d8f619c43f7"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function onstartselect (cyclomatic 14, cognitive 16): onstartselect has cyclomatic complexity 14 and cognitive complexity 16; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-oncopy.js"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"6492db7792c84598bd3ebcd7c67fac5612d3d70bb09908f831e0bb9ab05f1aa8"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function _onInlineEvent (cyclomatic 14, cognitive 11): _onInlineEvent has cyclomatic complexity 14 and cognitive complexity 11; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth \u2014 arms side by side rather than stacked \u2014 and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":2438}}}],"partialFingerprints":{"codehealthFindingId/v1":"21be51040386e6d5bf9c471f415a0bc13ed57d416cb50a6f5c67fee30e35f405"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function _onresponse (cyclomatic 13, cognitive 19): _onresponse has cyclomatic complexity 13 and cognitive complexity 19; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangeset.js"},"region":{"startLine":580}}}],"partialFingerprints":{"codehealthFindingId/v1":"44e35792cc1573f0c7cf3d7a4ad6c3f062cc1fa26d7760c6252e0e7dc85d8bce"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function (anonymous) (cyclomatic 13, cognitive 14): (anonymous) has cyclomatic complexity 13 and cognitive complexity 14; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/Prefab.js"},"region":{"startLine":113}}}],"partialFingerprints":{"codehealthFindingId/v1":"b216b88c4a511a44b6b6b08ad305585482205f96f875a55a7576dc2698d21089"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function blame (cyclomatic 12, cognitive 19): blame has cyclomatic complexity 12 and cognitive complexity 19; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/files/behavior-document-engine.js"},"region":{"startLine":262}}}],"partialFingerprints":{"codehealthFindingId/v1":"9e3c79f36db3af4a280ae33f11ca76f43dfb520732062a8d8514de8ac39dee52"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function (anonymous) (cyclomatic 12, cognitive 18): (anonymous) has cyclomatic complexity 12 and cognitive complexity 18; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/Prefab.js"},"region":{"startLine":221}}}],"partialFingerprints":{"codehealthFindingId/v1":"f9b207fcb6145b37f825d8188caf4297421eb3e47fddc1576f34ee6bf3634f5a"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function (anonymous) (cyclomatic 12, cognitive 16): (anonymous) has cyclomatic complexity 12 and cognitive complexity 16; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/repository/repository-crossreference.js"},"region":{"startLine":325}}}],"partialFingerprints":{"codehealthFindingId/v1":"c11f7635c1c22a5b8780bfcf8e337fc364af6892460935965d9038ac22fdf928"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function extract_text (cyclomatic 12, cognitive 16): extract_text has cyclomatic complexity 12 and cognitive complexity 16; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-oncopy.js"},"region":{"startLine":250}}}],"partialFingerprints":{"codehealthFindingId/v1":"3501c5ad98ca90275328fe47cad18808ba74fdea538dbee069cffdd4e2bd4216"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function sort_handler (cyclomatic 12, cognitive 16): sort_handler has cyclomatic complexity 12 and cognitive complexity 16; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-search-typeahead.js"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"fe8eb2219fcd9a675a8018ac8d645eb7823379d3360b99f72a929f198677ac7c"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function (anonymous) (cyclomatic 12, cognitive 14): (anonymous) has cyclomatic complexity 12 and cognitive complexity 14; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"support/aphlict/server/lib/AphlictClientServer.js"},"region":{"startLine":133}}}],"partialFingerprints":{"codehealthFindingId/v1":"b2265c8a494c77b6ce0ef3ac0094882ee38ab46e4d1782e5fb8666d47b5e4216"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function (anonymous) (cyclomatic 12, cognitive 14): (anonymous) has cyclomatic complexity 12 and cognitive complexity 14; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/repository/repository-crossreference.js"},"region":{"startLine":58}}}],"partialFingerprints":{"codehealthFindingId/v1":"82411ef1010cdcf4442e8607eb3cbb4500469611428f1309a37728b5c4326829"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function show (cyclomatic 12, cognitive 11): show has cyclomatic complexity 12 and cognitive complexity 11; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth \u2014 arms side by side rather than stacked \u2014 and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/ToolTip.js"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"6c63f46bcdc3ecfd8aae3f9afc127eff3f3212a1a034136f92aa891802c05886"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function write_date (cyclomatic 12, cognitive 11): write_date has cyclomatic complexity 12 and cognitive complexity 11; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth \u2014 arms side by side rather than stacked \u2014 and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-fancy-datepicker.js"},"region":{"startLine":159}}}],"partialFingerprints":{"codehealthFindingId/v1":"dfa797158581e80e547622c93ca697045fbd26f9c1414173f653ab0bad0daab4"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function redraw (cyclomatic 11, cognitive 22): redraw has cyclomatic complexity 11 and cognitive complexity 22; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/projects/WorkboardColumn.js"},"region":{"startLine":210}}}],"partialFingerprints":{"codehealthFindingId/v1":"aca2af92c121ebf92f799d7700d8d4cda5de3d060c67896f3a9c3c442fa9f987"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function redrawFileTree (cyclomatic 11, cognitive 21): redrawFileTree has cyclomatic complexity 11 and cognitive complexity 21; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangeset.js"},"region":{"startLine":860}}}],"partialFingerprints":{"codehealthFindingId/v1":"f33a83fc61f457b2e3143da0bf62e38dba0d355254e88c81b693cc5e3e94568b"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function _getDropContext (cyclomatic 11, cognitive 18): _getDropContext has cyclomatic complexity 11 and cognitive complexity 18; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/projects/WorkboardBoard.js"},"region":{"startLine":447}}}],"partialFingerprints":{"codehealthFindingId/v1":"24f2e30fc1d9755ab74317ca08c2755bb002a3ba973f065d52d42db332948fbb"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function _updateAutoscroll (cyclomatic 11, cognitive 18): _updateAutoscroll has cyclomatic complexity 11 and cognitive complexity 18; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/DraggableList.js"},"region":{"startLine":586}}}],"partialFingerprints":{"codehealthFindingId/v1":"bac098be5ac732397ccf9595ceee0c865712dd4764b33dcf16e2ffda591cd9a9"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function activateLightbox (cyclomatic 11, cognitive 13): activateLightbox has cyclomatic complexity 11 and cognitive complexity 13; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-lightbox-attachments.js"},"region":{"startLine":62}}}],"partialFingerprints":{"codehealthFindingId/v1":"7cde393082658bb1617adeb622e9ad891ea4f5a73d3b770366a862fa1e62d187"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function render_day (cyclomatic 11, cognitive 12): render_day has cyclomatic complexity 11 and cognitive complexity 12; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-fancy-datepicker.js"},"region":{"startLine":326}}}],"partialFingerprints":{"codehealthFindingId/v1":"801f7ad9d75b403df0c674f5b228662d7ffd7a29ad7c6081a2aeba50850a25b1"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function _ondrag (cyclomatic 11, cognitive 11): _ondrag has cyclomatic complexity 11 and cognitive complexity 11; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/DraggableList.js"},"region":{"startLine":158}}}],"partialFingerprints":{"codehealthFindingId/v1":"b695f7056929d9c2391213e7c69e0e4d3ccddcbd584d09e906effbed7967a7c2"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function buildTokenizer (cyclomatic 11, cognitive 11): buildTokenizer has cyclomatic complexity 11 and cognitive complexity 11; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/Prefab.js"},"region":{"startLine":73}}}],"partialFingerprints":{"codehealthFindingId/v1":"bef35faf6e2f885b17587c10d1e3a52775b8b01cc0c130495f9c5b5c4d7f0739"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function _redrawHover (cyclomatic 11, cognitive 10): _redrawHover has cyclomatic complexity 11 and cognitive complexity 10; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth \u2014 arms side by side rather than stacked \u2014 and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":1412}}}],"partialFingerprints":{"codehealthFindingId/v1":"11c568f6e1561af498867b47943e67a982cc400968e07edf8dad970487de38bd"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function lightBoxHandleKeyDown (cyclomatic 11, cognitive 9): lightBoxHandleKeyDown has cyclomatic complexity 11 and cognitive complexity 9; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth \u2014 arms side by side rather than stacked \u2014 and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-lightbox-attachments.js"},"region":{"startLine":276}}}],"partialFingerprints":{"codehealthFindingId/v1":"a7c1b96a5bc0a2ef807b81761d67ade7b1d31d69bc6c3e17103a2ff3d231954b"}},{"ruleId":"R3","level":"warning","message":{"text":"webroot/rsrc/js/application/diff/DiffChangesetList.js: 2282 lines of code: webroot/rsrc/js/application/diff/DiffChangesetList.js has 2282 significant lines (blank lines excluded), over the 400-line bar, and contains logic \u2014 a file this long is usually several responsibilities in one module."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"5de6a998f09adbadd3c8e2d8c51bbfd78e9fc717c0e585daa516f9f6afa605f6"}},{"ruleId":"R3","level":"warning","message":{"text":"webroot/rsrc/js/application/diff/DiffInline.js: 943 lines of code: webroot/rsrc/js/application/diff/DiffInline.js has 943 significant lines (blank lines excluded), over the 400-line bar, and contains logic \u2014 a file this long is usually several responsibilities in one module."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffInline.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"ef4b650ad6aab930cfd900722efdd4057226103bd4c07dce4a43328591f2fc2a"}},{"ruleId":"R3","level":"warning","message":{"text":"webroot/rsrc/js/application/diff/DiffChangeset.js: 883 lines of code: webroot/rsrc/js/application/diff/DiffChangeset.js has 883 significant lines (blank lines excluded), over the 400-line bar, and contains logic \u2014 a file this long is usually several responsibilities in one module."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangeset.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"bfe65c4a1d6d499babcb4b0051ae3c84907afa9e8b17ab9f251fdb40d5531f88"}},{"ruleId":"R3","level":"warning","message":{"text":"webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js: 684 lines of code: webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js has 684 significant lines (blank lines excluded), over the 400-line bar, and contains logic \u2014 a file this long is usually several responsibilities in one module."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"de09f83eb0c73462ac29ad2bab8351664037b12481ac9fcf8686457c4660ed19"}},{"ruleId":"R3","level":"warning","message":{"text":"webroot/rsrc/js/core/DraggableList.js: 681 lines of code: webroot/rsrc/js/core/DraggableList.js has 681 significant lines (blank lines excluded), over the 400-line bar, and contains logic \u2014 a file this long is usually several responsibilities in one module."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/DraggableList.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"633c69f4d8de80235ec2975cc5a3fa2ebeba5846b092fd76ae4284f571b4b58f"}},{"ruleId":"R3","level":"warning","message":{"text":"webroot/rsrc/js/phuix/PHUIXAutocomplete.js: 645 lines of code: webroot/rsrc/js/phuix/PHUIXAutocomplete.js has 645 significant lines (blank lines excluded), over the 400-line bar, and contains logic \u2014 a file this long is usually several responsibilities in one module."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/phuix/PHUIXAutocomplete.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"abb9f905a9eeb75f4cbae15cfb2fdc559ca5bbfee2f7fef02b4e696f7e05de5c"}},{"ruleId":"R3","level":"warning","message":{"text":"webroot/rsrc/js/application/projects/WorkboardBoard.js: 621 lines of code: webroot/rsrc/js/application/projects/WorkboardBoard.js has 621 significant lines (blank lines excluded), over the 400-line bar, and contains logic \u2014 a file this long is usually several responsibilities in one module."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/projects/WorkboardBoard.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"99fcc27c087c2e465c3fe7b700d4d4838142b2041a23617dad530dd0474cb9d3"}},{"ruleId":"R3","level":"warning","message":{"text":"webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js: 458 lines of code: webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js has 458 significant lines (blank lines excluded), over the 400-line bar, and contains logic \u2014 a file this long is usually several responsibilities in one module."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"d73277a027c50891938cfbff17dc647551aa66cb0b521c1a3ffe2edea1c41fb8"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060!node.childNodes || !node.childNodes.length\u0060 appears character-identically in 2 files \u2014 webroot/rsrc/js/application/diff/DiffChangesetList.js, webroot/rsrc/js/core/behavior-oncopy.js. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":2784}}}],"partialFingerprints":{"codehealthFindingId/v1":"697a9a7e7555104e4faa75090a4ba36aac2b360d47ecc99116cb50c35020be2f"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060!$is_force \u0026\u0026 !phutil_console_confirm($prompt)\u0060 appears character-identically in 2 files \u2014 src/applications/repository/management/PhabricatorRepositoryManagementMovePathsWorkflow.php, src/applications/repository/management/PhabricatorRepositoryManagementThawWorkflow.php. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/management/PhabricatorRepositoryManagementMovePathsWorkflow.php"},"region":{"startLine":127}}}],"partialFingerprints":{"codehealthFindingId/v1":"50126cd7df87ada3283e7205d70673ca1d1f95f03634820c19e914872863599d"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060$base_uri === null || !strlen($base_uri)\u0060 appears character-identically in 2 files \u2014 src/aphront/AphrontRequest.php, src/applications/config/check/PhabricatorWebServerSetupCheck.php. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/AphrontRequest.php"},"region":{"startLine":501}}}],"partialFingerprints":{"codehealthFindingId/v1":"37aa2b33013398c5494691891a919683b50e8bbba3b91d7a3541c6911d46aa85"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060$committer !== null \u0026\u0026 strlen($committer)\u0060 appears character-identically in 2 files \u2014 src/applications/repository/storage/PhabricatorRepositoryCommit.php, src/applications/repository/storage/PhabricatorRepositoryCommitData.php. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepositoryCommit.php"},"region":{"startLine":496}}}],"partialFingerprints":{"codehealthFindingId/v1":"ec61d58dd00a0a1d0f6a74f656137d0c4c2c4256fb1984bb1ed6085952b29d62"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060$description !== null \u0026\u0026 strlen($description)\u0060 appears character-identically in 2 files \u2014 src/applications/phriction/editor/PhrictionTransactionEditor.php, src/applications/project/typeahead/PhabricatorProjectDatasource.php. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phriction/editor/PhrictionTransactionEditor.php"},"region":{"startLine":310}}}],"partialFingerprints":{"codehealthFindingId/v1":"1550716b2087f1cc0f1cecc84fb176505adf28e8f2f0ffbdb2a9974618b73e28"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060$identifier !== null \u0026\u0026 strlen($identifier)\u0060 appears character-identically in 3 files \u2014 src/applications/diffusion/controller/DiffusionController.php, src/applications/diffusion/engine/DiffusionCommitHookEngine.php, src/applications/diviner/workflow/DivinerGenerateWorkflow.php. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionController.php"},"region":{"startLine":107}}}],"partialFingerprints":{"codehealthFindingId/v1":"2553b5f6fc14b5eebaed5218e57259b6774ffcbecfa84e7aeaaf1e7523d056ff"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060$instructions !== null \u0026\u0026 strlen($instructions)\u0060 appears character-identically in 2 files \u2014 src/applications/transactions/editfield/PhabricatorEditField.php, src/infrastructure/customfield/field/PhabricatorCustomFieldList.php. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editfield/PhabricatorEditField.php"},"region":{"startLine":421}}}],"partialFingerprints":{"codehealthFindingId/v1":"b2fd39fbafea14daf3076d4834a9041e56cad0aff81370a174e0e06cd989b7a8"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060$limit \u0026\u0026 ($count \u003E= ($offset \u002B $limit))\u0060 appears character-identically in 2 files \u2014 src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php, src/applications/diffusion/conduit/DiffusionQueryPathsConduitAPIMethod.php. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php"},"region":{"startLine":336}}}],"partialFingerprints":{"codehealthFindingId/v1":"23ac916f0a44745f7d3bbc6664c2a7444717750f8403d996f4909ec66d9c2808"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060$map[\u0027createdStart\u0027] || $map[\u0027createdEnd\u0027]\u0060 appears character-identically in 5 files \u2014 src/applications/differential/query/DifferentialRevisionSearchEngine.php, src/applications/diffusion/query/DiffusionPullLogSearchEngine.php, src/applications/diffusion/query/DiffusionSyncLogSearchEngine.php, src/applications/people/query/PhabricatorPeopleLogSearchEngine.php. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/query/DifferentialRevisionSearchEngine.php"},"region":{"startLine":48}}}],"partialFingerprints":{"codehealthFindingId/v1":"24206c701fc6076cc0fa5375b48310e604e0b50e1aa1f2bf8b8c03ed574be00c"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060$map[\u0027upcoming\u0027] \u0026\u0026 $map[\u0027upcoming\u0027][0] == \u0027upcoming\u0027\u0060 appears character-identically in 2 files \u2014 src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php, src/applications/countdown/query/PhabricatorCountdownSearchEngine.php. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php"},"region":{"startLine":113}}}],"partialFingerprints":{"codehealthFindingId/v1":"d546ab8a923a6574e39bd78c4063e03a614f4724c04351a830e8b05a67ac05aa"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060$other \u0026\u0026 ($other-\u003EgetID() != $object-\u003EgetID())\u0060 appears character-identically in 4 files \u2014 src/applications/almanac/xaction/AlmanacDeviceNameTransaction.php, src/applications/almanac/xaction/AlmanacNamespaceNameTransaction.php, src/applications/almanac/xaction/AlmanacNetworkNameTransaction.php, src/applications/almanac/xaction/AlmanacServiceNameTransaction.php. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/almanac/xaction/AlmanacDeviceNameTransaction.php"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"a7ba289f5b9bf3bb9d04de2c7a173eacedaf2efbddb1279f4ec64f6727b31928"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060$other \u0026\u0026 ($other-\u003EgetID() !== $object-\u003EgetID())\u0060 appears character-identically in 2 files \u2014 src/applications/repository/xaction/PhabricatorRepositoryCallsignTransaction.php, src/applications/repository/xaction/PhabricatorRepositorySlugTransaction.php. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/xaction/PhabricatorRepositoryCallsignTransaction.php"},"region":{"startLine":75}}}],"partialFingerprints":{"codehealthFindingId/v1":"678ddf6a0f3dfdc3af1aa03bba0f09e20d3bab7ea489e2d68ef04efa0d95abd4"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060$protocol !== \u0027http\u0027 \u0026\u0026 $protocol !== \u0027https\u0027\u0060 appears character-identically in 2 files \u2014 src/applications/config/option/PhabricatorCoreConfigOptions.php, src/applications/config/option/PhabricatorSecurityConfigOptions.php. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/option/PhabricatorCoreConfigOptions.php"},"region":{"startLine":281}}}],"partialFingerprints":{"codehealthFindingId/v1":"bba45caa912f2bf03a04b27e28cca2fdc2ac7ff9cd55aa8754026fd3c8ccce23"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060$query_key !== null \u0026\u0026 strlen($query_key)\u0060 appears character-identically in 2 files \u2014 src/applications/project/state/PhabricatorWorkboardViewState.php, src/applications/transactions/bulk/PhabricatorBulkEngine.php. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/project/state/PhabricatorWorkboardViewState.php"},"region":{"startLine":45}}}],"partialFingerprints":{"codehealthFindingId/v1":"8febb69c34787c9b541108b2a1c107c149d73348c89c064f0b940266c622794a"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060$query_key === null || !strlen($query_key)\u0060 appears character-identically in 2 files \u2014 src/applications/search/controller/PhabricatorApplicationSearchController.php, src/applications/search/engine/PhabricatorApplicationSearchEngine.php. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/search/controller/PhabricatorApplicationSearchController.php"},"region":{"startLine":118}}}],"partialFingerprints":{"codehealthFindingId/v1":"0d27bdc7bd3f3b38b1412ff6e8229065eccc891bf4f1e04ae7efeae324f3173f"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060$raw_query !== null \u0026\u0026 strlen($raw_query)\u0060 appears character-identically in 4 files \u2014 src/applications/herald/typeahead/HeraldRuleDatasource.php, src/applications/owners/typeahead/PhabricatorOwnersPackageDatasource.php, src/applications/project/typeahead/PhabricatorProjectDatasource.php, src/applications/typeahead/datasource/PhabricatorTypeaheadCompositeDatasource.php. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/typeahead/HeraldRuleDatasource.php"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"3066f5f80947189345d2194769825bd63c5dbca6629c287b8076b79829bb3a55"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060$symbol !== null \u0026\u0026 preg_match(\u0027/^[a-f0-9]{40}\\z/\u0027, $symbol)\u0060 appears character-identically in 2 files \u2014 src/applications/diffusion/request/DiffusionGitRequest.php, src/applications/diffusion/request/DiffusionMercurialRequest.php. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/request/DiffusionGitRequest.php"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"8e4d852051fc6b45a0e5623745a59b82b57c78e360856c2d60bb610e84d3fe7f"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060($ex instanceof HTTPFutureResponseStatus) \u0026\u0026 ($ex-\u003EgetStatusCode() == 404)\u0060 appears character-identically in 4 files \u2014 src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php, src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubIssue.php, src/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubUser.php, src/applications/doorkeeper/bridge/DoorkeeperBridgeJIRA.php. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php"},"region":{"startLine":84}}}],"partialFingerprints":{"codehealthFindingId/v1":"986006d878cfca6cc9885d258011dab1b557646f83e8c0ab64bcbcaf6dc3b294"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060($is_child \u0026\u0026 $is_future) || ($is_parent \u0026\u0026 !$is_future)\u0060 appears character-identically in 2 files \u2014 src/applications/calendar/controller/PhabricatorCalendarEventCancelController.php, src/applications/calendar/editor/PhabricatorCalendarEventEditEngine.php. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/calendar/controller/PhabricatorCalendarEventCancelController.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"c3b021676e9826369843851d6f22e5322de255b1d86447108597515c8c2887aa"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060($response instanceof AphrontResponse) || ($response instanceof AphrontResponseProducerInterface)\u0060 appears character-identically in 2 files \u2014 src/applications/auth/controller/PhabricatorAuthNeedsMultiFactorController.php, src/applications/settings/controller/PhabricatorSettingsMainController.php. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/controller/PhabricatorAuthNeedsMultiFactorController.php"},"region":{"startLine":68}}}],"partialFingerprints":{"codehealthFindingId/v1":"2967afb91afabbeb3aa065dfa5ec3b45bbd37644367841b998237363e461abf0"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060function_exists(\u0027posix_isatty\u0027) \u0026\u0026 posix_isatty(STDIN)\u0060 appears character-identically in 2 files \u2014 scripts/daemon/exec/exec_daemon.php, src/infrastructure/daemon/PhutilDaemonOverseer.php. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"scripts/daemon/exec/exec_daemon.php"},"region":{"startLine":58}}}],"partialFingerprints":{"codehealthFindingId/v1":"59c02530567e5aa6b08419fcb22a435f60d20773cd5d953d922055c1aceb4d9c"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060isFlatText($matches[0]) || $text_mode || $mail_mode\u0060 appears character-identically in 2 files \u2014 src/applications/diffusion/remarkup/DiffusionSourceLinkRemarkupRule.php, src/applications/macro/markup/PhabricatorIconRemarkupRule.php. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/remarkup/DiffusionSourceLinkRemarkupRule.php"},"region":{"startLine":24}}}],"partialFingerprints":{"codehealthFindingId/v1":"e0e077f6274b7884b047e508c8eb0c8f50898ad7f83c6950b7181dbcbf96477f"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060isset($lines[$cursor]) \u0026\u0026 !strlen(trim($lines[$cursor]))\u0060 appears character-identically in 2 files \u2014 src/infrastructure/markup/blockrule/PhutilRemarkupHeaderBlockRule.php, src/infrastructure/markup/blockrule/PhutilRemarkupHorizontalRuleBlockRule.php. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/blockrule/PhutilRemarkupHeaderBlockRule.php"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"b006d95dcb9da3f48593629736e3345f0a343e85a448d91d7d213156d6ffeb90"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060isset($lines[$pos]) \u0026\u0026 preg_match(\u0027/^\u003E/\u0027, $lines[$pos])\u0060 appears character-identically in 2 files \u2014 src/infrastructure/markup/blockrule/PhutilRemarkupQuotesBlockRule.php, src/infrastructure/markup/blockrule/PhutilRemarkupReplyBlockRule.php. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/blockrule/PhutilRemarkupQuotesBlockRule.php"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"d9a9dde19f8962e47376ae706c7e4d9f821bb840dc4d5d52077b04f1bc643767"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060shouldAllowPublic() \u0026\u0026 PhabricatorEnv::getEnvConfig(\u0027policy.allow-public\u0027)\u0060 appears character-identically in 2 files \u2014 src/applications/base/controller/PhabricatorController.php, src/applications/conduit/call/ConduitCall.php. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/base/controller/PhabricatorController.php"},"region":{"startLine":189}}}],"partialFingerprints":{"codehealthFindingId/v1":"c6753d69be31e67fb62de9ac03afcc82f6f224faa30f5329129e69ee79ecdbcf"}},{"ruleId":"X19","level":"warning","message":{"text":"Process-global state is restored only on the happy path: \u0060parseLocalTime\u0060 changes state that belongs to the whole PROCESS and changes it back at the end of the same body \u2014 the default timezone (changed at line 54, put back at line 59) \u2014 which says the change was meant to last no longer than this call. But the restore is an ordinary statement on the straight-line path, not a \u0060finally\u0060, so it is skipped by any exception thrown in between: PHP then keeps the overwritten value for the rest of the request \u2014 and in a CLI command, a queue worker or a long-running server (Octane, Swoole, RoadRunner, FrankenPHP) for the rest of the process\u0027s life \u2014 and every later relative path, child-process launch, date, number format, XML parse or error report in ANY class reads it. That failure is silent and remote from its cause: the function that breaks is not the function that moved the value. The durable fix is not to widen the restore but to stop mutating the global: pass the value to the operation that needs it \u2014 \u0060cwd\u0060 and \u0060env\u0060 to Symfony \u0060Process\u0060 (\u0060new Process($command, $cwd, $env)\u0060) or \u0060proc_open($command, $spec, $pipes, $cwd, $env)\u0060, absolute paths instead of \u0060chdir\u0060, an explicit \u0060DateTimeZone\u0060 or locale to \u0060DateTimeImmutable\u0060/\u0060IntlDateFormatter\u0060/\u0060NumberFormatter\u0060, an explicit encoding to the \u0060mb_*\u0060 call, \u0060LIBXML_NOERROR\u0060/\u0060libxml_get_errors\u0060 handling in one place. Where the global genuinely must move, wrap it \u0060try\u0060/\u0060finally\u0060 so the restore runs on every path."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/time/PhabricatorTime.php"},"region":{"startLine":51}}}],"partialFingerprints":{"codehealthFindingId/v1":"6c9e536052bad140df1f58f7beb5e4a73130cab4d474d94bc17baaa7e36f0478"}},{"ruleId":"X19","level":"warning","message":{"text":"Process-global state is restored only on the happy path: \u0060phabricator_read_config_file\u0060 changes state that belongs to the whole PROCESS and changes it back at the end of the same body \u2014 the error-reporting level (changed at line 49, put back at line 61) and the \u0060display_errors\u0060 ini setting (changed at line 55, put back at line 62) \u2014 which says the change was meant to last no longer than this call. But the restore is an ordinary statement on the straight-line path, not a \u0060finally\u0060, so it is skipped by any exception thrown in between: PHP then keeps the overwritten value for the rest of the request \u2014 and in a CLI command, a queue worker or a long-running server (Octane, Swoole, RoadRunner, FrankenPHP) for the rest of the process\u0027s life \u2014 and every later relative path, child-process launch, date, number format, XML parse or error report in ANY class reads it. That failure is silent and remote from its cause: the function that breaks is not the function that moved the value. The durable fix is not to widen the restore but to stop mutating the global: pass the value to the operation that needs it \u2014 \u0060cwd\u0060 and \u0060env\u0060 to Symfony \u0060Process\u0060 (\u0060new Process($command, $cwd, $env)\u0060) or \u0060proc_open($command, $spec, $pipes, $cwd, $env)\u0060, absolute paths instead of \u0060chdir\u0060, an explicit \u0060DateTimeZone\u0060 or locale to \u0060DateTimeImmutable\u0060/\u0060IntlDateFormatter\u0060/\u0060NumberFormatter\u0060, an explicit encoding to the \u0060mb_*\u0060 call, \u0060LIBXML_NOERROR\u0060/\u0060libxml_get_errors\u0060 handling in one place. Where the global genuinely must move, wrap it \u0060try\u0060/\u0060finally\u0060 so the restore runs on every path."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"conf/__init_conf__.php"},"region":{"startLine":3}}}],"partialFingerprints":{"codehealthFindingId/v1":"bd170d9c847afb57c007644b614c9ffe8ffba66271cc6d8b4e3c62ac4945333f"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/phuix/PHUIXFormationView.js"},"region":{"startLine":102}}}],"partialFingerprints":{"codehealthFindingId/v1":"cec9b1a6ee796c6bdbf7b1aeb6e2a4ac7ddbdab3b3dd88e5e5c320df48781311"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (ex)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, or keep only the failure you expect and rethrow the rest (\u0060catch (e) { if (!(e instanceof SyntaxError)) throw e; \u2026 }\u0060, or test \u0060e.name\u0060), because a JavaScript catch takes every exception, programming errors included."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/phui/behavior-phui-file-upload.js"},"region":{"startLine":64}}}],"partialFingerprints":{"codehealthFindingId/v1":"3db60520136111ae4f0b1dd07dfd8fbb7455474f3d1e9604770a8a52f688cf6b"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (ignored)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, or keep only the failure you expect and rethrow the rest (\u0060catch (e) { if (!(e instanceof SyntaxError)) throw e; \u2026 }\u0060, or test \u0060e.name\u0060), because a JavaScript catch takes every exception, programming errors included."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/DraggableList.js"},"region":{"startLine":608}}}],"partialFingerprints":{"codehealthFindingId/v1":"342a374ee07948ad0ba7622f01736d9d041bd9123e6cdfd90b25e5bc8890bfc3"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (ex)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, or keep only the failure you expect and rethrow the rest (\u0060catch (e) { if (!(e instanceof SyntaxError)) throw e; \u2026 }\u0060, or test \u0060e.name\u0060), because a JavaScript catch takes every exception, programming errors included."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/Prefab.js"},"region":{"startLine":80}}}],"partialFingerprints":{"codehealthFindingId/v1":"70fefd59db432e78ee975a02c080db1b358b81f5248d41b55dc44f1dc693ac86"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (ignored)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, or keep only the failure you expect and rethrow the rest (\u0060catch (e) { if (!(e instanceof SyntaxError)) throw e; \u2026 }\u0060, or test \u0060e.name\u0060), because a JavaScript catch takes every exception, programming errors included."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-audio-source.js"},"region":{"startLine":51}}}],"partialFingerprints":{"codehealthFindingId/v1":"8d929b49cd6c52b54888a4da7fdc4b578c175a1145a616a133d651920685e2c7"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-autofocus.js"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"888306712a9f17870951617fd2f544bc0226fc6edfc115c5a3e5e738a6a856b4"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-copy.js"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"1ea2864944742c78a3b84c21afc8f1834bb79238a1577e56ff1533519aa1bcdb"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-detect-timezone.js"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"d6fff482ce07e24c5581e011e7c1322e57a2334d06467b0e10c54e713ecb3aa9"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-line-linker.js"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"702e6a769d20031a9552836779cb7f292314f2975714e794e210bcefc146de51"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-line-linker.js"},"region":{"startLine":197}}}],"partialFingerprints":{"codehealthFindingId/v1":"01928e3831c3d02741e4f8c5033d9317e0f4b125aae2ce4c2f32c5a7920c7486"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-oncopy.js"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"7a39a8544b47b53da0d1180c224c3f2a666bd7486155dba37ed6ce8d737db37f"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (ex)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, or keep only the failure you expect and rethrow the rest (\u0060catch (e) { if (!(e instanceof SyntaxError)) throw e; \u2026 }\u0060, or test \u0060e.name\u0060), because a JavaScript catch takes every exception, programming errors included."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-oncopy.js"},"region":{"startLine":64}}}],"partialFingerprints":{"codehealthFindingId/v1":"dd55912e73e43fec634367b9284e005db1e57f6348b5405f47e522cb33b30af6"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-watch-anchor.js"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"49ceb49b1e65e6d34c0efc85141456617dd3c69d4cb5f05be59ac3838cae7365"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-watch-anchor.js"},"region":{"startLine":106}}}],"partialFingerprints":{"codehealthFindingId/v1":"eadeeb43e34c2c51da730f0598774748be5fb0b00ec611055f9ca319e470b900"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/behavior-watch-anchor.js"},"region":{"startLine":123}}}],"partialFingerprints":{"codehealthFindingId/v1":"72c5eac4274400939a679fb8af54dfed4aaa12918458c5943584d56de0368fa6"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/core/darkconsole/behavior-dark-console.js"},"region":{"startLine":323}}}],"partialFingerprints":{"codehealthFindingId/v1":"069074b782c0fff122cd46810dc01c5f0e695981b23ea9f323874099bb1854d1"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (not_found_exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, or keep only the failure you expect and rethrow the rest (\u0060catch (e) { if (!(e instanceof SyntaxError)) throw e; \u2026 }\u0060, or test \u0060e.name\u0060), because a JavaScript catch takes every exception, programming errors included."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/transactions/behavior-show-older-transactions.js"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"acd79e09a68bcc36aa8107194ccda9cac3f7fc176971cdff8fe38ecac671a75d"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/repository/repository-crossreference.js"},"region":{"startLine":102}}}],"partialFingerprints":{"codehealthFindingId/v1":"e007c075c7c3f48c0dd118ba0fbc7e0731e60ca8abe66b513cfbd115ea27181d"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/repository/repository-crossreference.js"},"region":{"startLine":111}}}],"partialFingerprints":{"codehealthFindingId/v1":"5fff1bb746ec5d02434f08f4e971052053688ea8331f6e3466d3528b51da7e78"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/repository/repository-crossreference.js"},"region":{"startLine":248}}}],"partialFingerprints":{"codehealthFindingId/v1":"8fef4625e66a49a84d51d6f4e38fe8feba026ca7b25679bf1e98219472960f3f"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (e)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, or keep only the failure you expect and rethrow the rest (\u0060catch (e) { if (!(e instanceof SyntaxError)) throw e; \u2026 }\u0060, or test \u0060e.name\u0060), because a JavaScript catch takes every exception, programming errors included."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/harbormaster/behavior-harbormaster-log.js"},"region":{"startLine":96}}}],"partialFingerprints":{"codehealthFindingId/v1":"72e041fd5dab890b39216ddb199a3010491be7ffcb860efe5cb01ec1e5c836e2"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/doorkeeper/behavior-doorkeeper-tag.js"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"e75974afa17cf67b862cfa64939a44649eb14f44ab3ddea390f48c8adbd7231c"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diffusion/behavior-pull-lastmodified.js"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"65e020dabd8beb3201fde5525f467c3cb58f8d08b39800abd2cbda8ca187bb03"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangeset.js"},"region":{"startLine":646}}}],"partialFingerprints":{"codehealthFindingId/v1":"50df0552a370357416aafe1cc0f1ed77fb99e841dd8ad0055771067474d0185f"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangeset.js"},"region":{"startLine":684}}}],"partialFingerprints":{"codehealthFindingId/v1":"4e02636ecb1f6ebda3981e52ae8068ada3d96a87e6f1b2c7930e29ff3f36b5d7"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/diff/DiffChangesetList.js"},"region":{"startLine":1681}}}],"partialFingerprints":{"codehealthFindingId/v1":"592c4a00fe979ad176cf40c80a566d489d1b115f7693372692822241f5b5f648"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (ignored)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, or keep only the failure you expect and rethrow the rest (\u0060catch (e) { if (!(e instanceof SyntaxError)) throw e; \u2026 }\u0060, or test \u0060e.name\u0060), because a JavaScript catch takes every exception, programming errors included."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/countdown/timer.js"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"7f02d807eaa7ec356e626b072d277b56cbec0de895f67bfe1e317eff10645a70"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/conpherence/behavior-menu.js"},"region":{"startLine":218}}}],"partialFingerprints":{"codehealthFindingId/v1":"274ee4e5075a370936a2f270faeb15dd06e8cef05518970c1ae4acc895708e44"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/conpherence/behavior-menu.js"},"region":{"startLine":321}}}],"partialFingerprints":{"codehealthFindingId/v1":"051f84f8fb1a393d0d178a0f74aca947c01f19bc4055715c7be3c21cfa144dc3"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/conpherence/behavior-participant-pane.js"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"e78d200fcdf80b1b9154ec73a5900a69b04baa15ca5d8c60fbee968d49de4a79"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/conpherence/behavior-participant-pane.js"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"b263384d9ba30bd605edc54e2498305cb93db71f102077cf57c7371d221448db"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (ignored)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, or keep only the failure you expect and rethrow the rest (\u0060catch (e) { if (!(e instanceof SyntaxError)) throw e; \u2026 }\u0060, or test \u0060e.name\u0060), because a JavaScript catch takes every exception, programming errors included."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/aphlict/behavior-aphlict-status.js"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"eac4e0254d4f33c0e42fedde45b1c57d357e4b0ff89cae65c693db20846ca6f4"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"webroot/rsrc/js/application/aphlict/behavior-desktop-notifications-control.js"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"0a55cdd9a4723bee857ea1a2722b7390c8d99f61a4b54af39f76357f732322d4"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (error)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, or keep only the failure you expect and rethrow the rest (\u0060catch (e) { if (!(e instanceof SyntaxError)) throw e; \u2026 }\u0060, or test \u0060e.name\u0060), because a JavaScript catch takes every exception, programming errors included."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"support/aphlict/server/lib/AphlictClientServer.js"},"region":{"startLine":173}}}],"partialFingerprints":{"codehealthFindingId/v1":"58ae861e5dc6e43774bcb802db515b727f36058b89339815c462b45883e25cb2"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"support/aphlict/server/lib/AphlictClientServer.js"},"region":{"startLine":186}}}],"partialFingerprints":{"codehealthFindingId/v1":"c5da4134474896d5ac8bda8b1e692678a14fc9ecaf23338d94c40c95fb3dc0ad"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (error)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, or keep only the failure you expect and rethrow the rest (\u0060catch (e) { if (!(e instanceof SyntaxError)) throw e; \u2026 }\u0060, or test \u0060e.name\u0060), because a JavaScript catch takes every exception, programming errors included."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"support/aphlict/server/lib/AphlictPeer.js"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"e53f77dcfcf39e10669297872d6da8215ade0a27e29a7c582feed43eeb1b6e0f"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (error)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, or keep only the failure you expect and rethrow the rest (\u0060catch (e) { if (!(e instanceof SyntaxError)) throw e; \u2026 }\u0060, or test \u0060e.name\u0060), because a JavaScript catch takes every exception, programming errors included."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"support/aphlict/server/lib/AphlictPeer.js"},"region":{"startLine":67}}}],"partialFingerprints":{"codehealthFindingId/v1":"f2f3f6ddf628753c56abbba8c0d2532421998b10cf2b8baed785f71e65e5a80a"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/form/control/AphrontFormDateControl.php"},"region":{"startLine":71}}}],"partialFingerprints":{"codehealthFindingId/v1":"471e5caf732aa6f465849c082caad71880cd2235e835056d496bba49497d57ae"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/form/control/AphrontFormDateControl.php"},"region":{"startLine":135}}}],"partialFingerprints":{"codehealthFindingId/v1":"4912bed82b4f7b346d73ce79a995a25ee00e48858241bd9e502c285804ab8e92"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/form/control/AphrontFormDateControl.php"},"region":{"startLine":339}}}],"partialFingerprints":{"codehealthFindingId/v1":"5139a7432197561731d237be0b2a2ba59b626bb1970e80f81b9042d62eb84b55"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/view/form/control/AphrontFormDateControlValue.php"},"region":{"startLine":226}}}],"partialFingerprints":{"codehealthFindingId/v1":"84fb6271efff1b15e4cb3326f1ad7e055b521e49c9f1d76df2ae0e6149a69092"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/util/PhabricatorGlobalLock.php"},"region":{"startLine":242}}}],"partialFingerprints":{"codehealthFindingId/v1":"b867154e4baf2a4e4e876cf2b6e203b3974a8de99eb045da09752b1d6e4c9853"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/ssh/PhabricatorSSHWorkflow.php"},"region":{"startLine":116}}}],"partialFingerprints":{"codehealthFindingId/v1":"d1a0cdcd14cbb19b49bfef63e53951d9da705e99716b39c066760d13899aa8a1"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php"},"region":{"startLine":398}}}],"partialFingerprints":{"codehealthFindingId/v1":"37f5b9930080da686824c5fb71a7d2f43eb6ebedd8d237043f185a09cb1265f0"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/rule/PhabricatorConfigRemarkupRule.php"},"region":{"startLine":28}}}],"partialFingerprints":{"codehealthFindingId/v1":"182c5196e09ee65345b8af0282a06b109d4366b7b9cb96b71284300e084f9555"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/rule/PhabricatorYoutubeRemarkupRule.php"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"58c245993dd86d60de85a7e18fe0420b27a042a381ad79de9c1e486ef49c9919"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/markuprule/PhutilRemarkupHyperlinkRule.php"},"region":{"startLine":88}}}],"partialFingerprints":{"codehealthFindingId/v1":"f3b07f6d1c04887ca31365ef81b009b88e2b57216da1a704cd015dda0f43aecc"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/markuprule/PhutilRemarkupHyperlinkRule.php"},"region":{"startLine":171}}}],"partialFingerprints":{"codehealthFindingId/v1":"4b965c2aeee57641fe93d895341d8f8090717039d255041980efec71da4287c6"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/internationalization/management/PhabricatorInternationalizationManagementExtractWorkflow.php"},"region":{"startLine":321}}}],"partialFingerprints":{"codehealthFindingId/v1":"976192359b4cdbf7357943caea564ddbcf3e7554dd519ed106ba3966b08c1bcd"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/export/field/PhabricatorEpochExportField.php"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"658456aefc998f7b116b1555705c917e8508a29aae8dfd7daff541f7bbb9fc6b"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/env/PhabricatorEnv.php"},"region":{"startLine":393}}}],"partialFingerprints":{"codehealthFindingId/v1":"057d8bbc1a6dcda5fa0e27575530aee5eeabd00abadf8a9e171f501a70872dd2"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/env/PhabricatorEnv.php"},"region":{"startLine":708}}}],"partialFingerprints":{"codehealthFindingId/v1":"480dba11ada4517ed4bc3c17c05d47d68b2f1bb34cff127c7ed50ef6d195e584"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/env/PhabricatorEnv.php"},"region":{"startLine":770}}}],"partialFingerprints":{"codehealthFindingId/v1":"cff9d909e550cca832c2791d58b56d97040300aa991e45d3cec0265e4b001b63"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/env/PhabricatorEnv.php"},"region":{"startLine":905}}}],"partialFingerprints":{"codehealthFindingId/v1":"400a8620413f626cbf596f320daf99f48cd985d8477dbbce33c474a8e59c9a06"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php"},"region":{"startLine":121}}}],"partialFingerprints":{"codehealthFindingId/v1":"1007ba1b6d95a88d37c02c91b3dd39e68daf4364de5fc0ecc1099f41e7fd29b1"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php"},"region":{"startLine":140}}}],"partialFingerprints":{"codehealthFindingId/v1":"108e06c65fc34863553b35157eeb01c82aeefea8ff54e7bac43f9a21623ad8cf"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php"},"region":{"startLine":3837}}}],"partialFingerprints":{"codehealthFindingId/v1":"301bea107849a84293b34279e6fc95480c16cef2c7c99acc4cf215fa86998781"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editfield/PhabricatorRemarkupEditField.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"826d1cceec1c4a4df1651972c86d8bfd1f9f62281b0dd9ec3b26f9177829740c"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Throwable)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editfield/PhabricatorRemarkupEditField.php"},"region":{"startLine":51}}}],"partialFingerprints":{"codehealthFindingId/v1":"0f24f6bc8c5c2a672b0e001ae926e73d141ef2a10d44b18bd150c3d33ca36529"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editengine/PhabricatorEditEngine.php"},"region":{"startLine":229}}}],"partialFingerprints":{"codehealthFindingId/v1":"de224e290afbd0d2cbfaea5897bdf9c9030fdee287070228fd083a7be8fe5f14"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editengine/PhabricatorEditEngine.php"},"region":{"startLine":577}}}],"partialFingerprints":{"codehealthFindingId/v1":"17841348a1fd181878ed61b8f60188ccf0deabb5545c7d7067cdf20644a5280b"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/editengine/PhabricatorEditEngine.php"},"region":{"startLine":2066}}}],"partialFingerprints":{"codehealthFindingId/v1":"919448eed1d5edaa869db6abc1003131dba2f84fe9bf13976d9f4aee4681e4ea"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/controller/PhabricatorApplicationTransactionShowOlderController.php"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"2aefa14f7267c97f9d4b77f4fe34f18001f8a40a393fdd36f8e8984c5d5eeef5"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php"},"region":{"startLine":169}}}],"partialFingerprints":{"codehealthFindingId/v1":"bd9e3c377116e7781ffb943a784877104fb524f52ea04037fe588167dffff3d3"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/system/engine/PhabricatorDestructionEngine.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"4e8a09c4e27dbee00ffcd9d2145c733ff570e9fbff4bd2d495d23ecdecd222f4"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/system/engine/PhabricatorDestructionEngine.php"},"region":{"startLine":139}}}],"partialFingerprints":{"codehealthFindingId/v1":"7fc1ccc3f4c1834381def2756f84cc16c1d259073c1459b66c5416b58514be01"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepository.php"},"region":{"startLine":365}}}],"partialFingerprints":{"codehealthFindingId/v1":"223f95ea0a899dd128caf80455d51bab06951df3b3eb4c35f07a43711d7cb64e"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepository.php"},"region":{"startLine":1429}}}],"partialFingerprints":{"codehealthFindingId/v1":"f233b61271ced94cc8469f536216f748ab04d0a129dde78c905ec6eee9603601"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/storage/PhabricatorRepositoryWorkingCopyVersion.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"5a0d221c4ffff11e6d30ffce71862c58603e973ec383b87d0696a6499c72f214"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/management/PhabricatorRepositoryManagementMarkReachableWorkflow.php"},"region":{"startLine":80}}}],"partialFingerprints":{"codehealthFindingId/v1":"d6d3e21524f361ad48a5529cdefec9d4b15a9a1860c9ebccb9cbd40c1be4730e"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php"},"region":{"startLine":855}}}],"partialFingerprints":{"codehealthFindingId/v1":"d881c1e57bfe303f0d0f391ee96d894d7c3e68e22c6faf09064f03db172044eb"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/policy/storage/PhabricatorPolicy.php"},"region":{"startLine":338}}}],"partialFingerprints":{"codehealthFindingId/v1":"294ba9a8cc4d1a75d217157c33bd9cbfc7c009fc96fe070886faf4cd617daad1"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phpast/controller/PhabricatorXHPASTViewTreeController.php"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"eb58edc0b3b6bf69e172c1f11d697140ae5bb76b6676cd69fcdc3d19dd015259"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/storage/PhortuneCart.php"},"region":{"startLine":488}}}],"partialFingerprints":{"codehealthFindingId/v1":"3db8fc08162472521a231a7550f35eb9bd7087e44970df21dede741be9f0c68f"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/storage/PhortuneCart.php"},"region":{"startLine":497}}}],"partialFingerprints":{"codehealthFindingId/v1":"0087c17e8ec57d5ab563859fc45cc35e2fed2a810848ef8baee097de50c6a536"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/phortune/storage/PhortuneCart.php"},"region":{"startLine":506}}}],"partialFingerprints":{"codehealthFindingId/v1":"92c5c1e1ce621abad2ff83acae8dd480ec854fa58bfd244dec160f100facf814"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/storage/PhabricatorUser.php"},"region":{"startLine":596}}}],"partialFingerprints":{"codehealthFindingId/v1":"f260c131a17728c87ef11cd0e1eb913a3a1e473065e741787d3af1c6264f1886"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/people/storage/PhabricatorUser.php"},"region":{"startLine":744}}}],"partialFingerprints":{"codehealthFindingId/v1":"7a35ab535f8391f775d65cfecdab9affcab12d569772b648774f707f0a1f83b8"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/passphrase/controller/PassphraseCredentialEditController.php"},"region":{"startLine":75}}}],"partialFingerprints":{"codehealthFindingId/v1":"cb04af18a72781ef7b28f55f36027d0926b02c7cd9ed6fa54bc727463b36ca05"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/oauthserver/PhabricatorOAuthServer.php"},"region":{"startLine":187}}}],"partialFingerprints":{"codehealthFindingId/v1":"fa0cd7879ab330586287308f9db74ccf751c22b47481b9ea061728ec710b9816"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/notification/builder/PhabricatorNotificationBuilder.php"},"region":{"startLine":130}}}],"partialFingerprints":{"codehealthFindingId/v1":"17ec694fba1557f3629a2cbf7d060f7f35f3bbb5f8d8bfe570a24a998ec058db"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/macro/markup/PhabricatorMemeRemarkupRule.php"},"region":{"startLine":48}}}],"partialFingerprints":{"codehealthFindingId/v1":"a05adbfd77730d3ca2d7402b51fd88bc763f29a6b832bdffec680056369fe904"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/engine/HeraldEngine.php"},"region":{"startLine":811}}}],"partialFingerprints":{"codehealthFindingId/v1":"3ff113d7c8988d3b92c00f090ea057399debcdcb782e962c6674f1f65b8399b2"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/engine/HeraldEngine.php"},"region":{"startLine":851}}}],"partialFingerprints":{"codehealthFindingId/v1":"e952c006bbbabc56c433166ff38398d75445232910f917e2ee5730269329594c"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/herald/controller/HeraldRuleController.php"},"region":{"startLine":450}}}],"partialFingerprints":{"codehealthFindingId/v1":"96e075b7db79289ea8dd32362168a9adfc45f81f3384e11fa942ed2013c67646"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/worker/HarbormasterBuildWorker.php"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"4e8d3bf8ce579e496e919c7687a8ab01dc4f81679e6371351cd1dabf3dac7b85"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/worker/HarbormasterTargetWorker.php"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"c815e8125059ef7566319ce29fa2d01e4e8e2c1ab0d7f1ea2cee71c685e74270"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/storage/build/HarbormasterBuildTarget.php"},"region":{"startLine":194}}}],"partialFingerprints":{"codehealthFindingId/v1":"4f7820c1005fc5eb90ec0bfb1e93a8cda550eaced9182eb7a1d7117fe6ca2bac"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/engine/HarbormasterBuildGraph.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"d0d55bfdbaf0d4cc05a1ecc54eff118401ea9733c37fbd18db4a6285fcd980c0"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/customfield/HarbormasterBuildStepCoreCustomField.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"fe0511d984a0da28c9d11797a108cdbd4b119ef7d861408f01f51d318b1b89df"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/controller/HarbormasterStepViewController.php"},"region":{"startLine":75}}}],"partialFingerprints":{"codehealthFindingId/v1":"03e715a8e7ef8d871b8a7fe3a9075221294c30d5f9ae37d03c6b9372c53bd7f0"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/transform/PhabricatorFileTransform.php"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"877e01661a30d4147ccfeba478f8eaa9d226dea5c6e9626b29d50ed08feb2699"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/storage/PhabricatorFile.php"},"region":{"startLine":430}}}],"partialFingerprints":{"codehealthFindingId/v1":"d790dfbe5293443bd19abe1d0141a54b563887cbcc7639db618419a3898ca0ef"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/markup/PhabricatorImageRemarkupRule.php"},"region":{"startLine":68}}}],"partialFingerprints":{"codehealthFindingId/v1":"67dda6cf47bf2bee8b5859229ab3d418624ec819085abbdca19057ff01752c73"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/management/PhabricatorFilesManagementCompactWorkflow.php"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"aeec1b63f0e94b6f6321f84a1484f850611a96d19dc12d14674ff6c8828e4af0"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/files/document/PhabricatorDocumentRef.php"},"region":{"startLine":165}}}],"partialFingerprints":{"codehealthFindingId/v1":"698ded3ed229f798f08b7118b8e79a4edf79a1a1eac74cb209fa09639d22c709"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/feed/query/PhabricatorFeedTransactionSearchEngine.php"},"region":{"startLine":122}}}],"partialFingerprints":{"codehealthFindingId/v1":"76243a8799e0e24081945cb4560441187192627d25c6f444f5dd3a6589cbfc1f"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/feed/query/PhabricatorFeedTransactionSearchEngine.php"},"region":{"startLine":212}}}],"partialFingerprints":{"codehealthFindingId/v1":"99dc23e4e964b8ba123c478749228200947adbbb3cdf12968e354479fe6ce013"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/doorkeeper/option/PhabricatorAsanaConfigOptions.php"},"region":{"startLine":94}}}],"partialFingerprints":{"codehealthFindingId/v1":"f7c8f2811537ff8febab37e7b7c870622325f076afcaf806321e8c982855504a"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/xaction/DiffusionCommitActionTransaction.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"9c196adf63ae734bc65c5108d0f155c46bdc9a2442b7d79aa562fc68e0b32b0e"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php"},"region":{"startLine":597}}}],"partialFingerprints":{"codehealthFindingId/v1":"da2b301ad6848ca09f72e7a393059c26931bf0f26672cf40de912c2a3499db0e"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/management/DiffusionRepositoryStorageManagementPanel.php"},"region":{"startLine":187}}}],"partialFingerprints":{"codehealthFindingId/v1":"e53bfc9b6b7c89211f6453fd33c2edc8ec218715b1e1ac49f5b835eaf372d508"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/diffusion/controller/DiffusionController.php"},"region":{"startLine":413}}}],"partialFingerprints":{"codehealthFindingId/v1":"e705f036b81e3d79c01110ca72b3c019848a13a503ab4b125e0df11cb0b8ba29"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/xaction/DifferentialRevisionActionTransaction.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"f70df22561c9865e5f46c413aecd066151fc230382f7b321b325d2d4f5eed62c"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/xaction/DifferentialRevisionTransactionType.php"},"region":{"startLine":67}}}],"partialFingerprints":{"codehealthFindingId/v1":"df6f57d421cc948f6fe94d82a579643bf5a6769a73e61b6a9a9bd3bd2cac19b6"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/mail/DifferentialInlineCommentMailView.php"},"region":{"startLine":269}}}],"partialFingerprints":{"codehealthFindingId/v1":"4c77ebcd4a71f7bea50664f63c249a023e1b1f1de495a77b8f5e029d97db0e2e"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/differential/customfield/DifferentialCustomField.php"},"region":{"startLine":77}}}],"partialFingerprints":{"codehealthFindingId/v1":"186ca7a6c1dc958aefc8674504ee68c794c200829dace2f7d34facc19becf618"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/console/controller/DarkConsoleDataController.php"},"region":{"startLine":70}}}],"partialFingerprints":{"codehealthFindingId/v1":"e62c474164eb87015066a25bbb60eab95c8affb54bd1bdecceff577387bd6b95"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/type/PhabricatorClassConfigType.php"},"region":{"startLine":26}}}],"partialFingerprints":{"codehealthFindingId/v1":"362d35700da3dcfce200ea9dd26c52c0a71395ec1a6855ac11db9f4988b69960"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/custom/PhabricatorCustomLogoConfigType.php"},"region":{"startLine":83}}}],"partialFingerprints":{"codehealthFindingId/v1":"26db0b61a4d601ec4271691ea4f3489eb98ed2c4fc445afd78c05ece2a2148b4"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/controller/services/PhabricatorConfigClusterSearchController.php"},"region":{"startLine":76}}}],"partialFingerprints":{"codehealthFindingId/v1":"fbaa3ff6a7d5d426c2d6d1ce2a661d7b701bca22579f1509cbbe1a3a4c9fe518"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/check/PhabricatorSetupCheck.php"},"region":{"startLine":129}}}],"partialFingerprints":{"codehealthFindingId/v1":"9afc67525595a2026b6f27f07b55a158217dbe755a875a948384a8ecadcc0059"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/check/PhabricatorWebServerSetupCheck.php"},"region":{"startLine":296}}}],"partialFingerprints":{"codehealthFindingId/v1":"1397e0b0768c922394a41e68a31567fb28c18a5ce2e66a53d9645c74a0cfb4be"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/config/check/PhabricatorWebServerSetupCheck.php"},"region":{"startLine":302}}}],"partialFingerprints":{"codehealthFindingId/v1":"9f6a10179048202e5dd945121720dcfbd96f7a8a50f2c876b9043d25dbe00dea"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/view/PhabricatorAuthSSHKeyTableView.php"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"38b0ab00b2c6a0b963e56f75d465431540c4b2bf02adcc2d2f5110dc2f91812a"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/auth/provider/PhabricatorOAuth2AuthProvider.php"},"region":{"startLine":251}}}],"partialFingerprints":{"codehealthFindingId/v1":"3f470775a248f1e83c5742532f34cfd1d69dada6af5e6827ff8304fd57a47048"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/response/AphrontResponse.php"},"region":{"startLine":135}}}],"partialFingerprints":{"codehealthFindingId/v1":"199cb3058cd91db327e1bce055703083c81f50af83bf692f6d231252f29b8c12"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/response/AphrontUnhandledExceptionResponse.php"},"region":{"startLine":125}}}],"partialFingerprints":{"codehealthFindingId/v1":"3f374a5cfa2af8c466a7d8f94c08b6d69cc24718916159680e3afa75dd5b1417"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Throwable)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/aphront/response/AphrontUnhandledExceptionResponse.php"},"region":{"startLine":127}}}],"partialFingerprints":{"codehealthFindingId/v1":"4d1157e9934b981e135a83a4f94ca8b8256aa83db5e30686579368b42b6f8f21"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"resources/sql/autopatches/20160225.almanac.3.stype.php"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"bb318e22139d4efee7cc31b7c37b61fbc9c3e968f201e8b81a80b9c644c4b215"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"resources/sql/autopatches/20160601.user.02.copyprefs.php"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"4a14e5aca803eaee6fb360398344e03466236e13429251aa494a52fd0869429d"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"resources/sql/autopatches/20161004.cal.01.noepoch.php"},"region":{"startLine":110}}}],"partialFingerprints":{"codehealthFindingId/v1":"0ab4fd32ebe3f498606ff89d8b7391f83f74b3dbcc52b53d77669e82918595e5"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"resources/sql/autopatches/20161005.cal.01.rrules.php"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"c4d95bba2ddd7438037ed75662b194dffdd06cf0858d2582748706b140575f99"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"resources/sql/autopatches/20190412.dashboard.01.panels.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"e1b17d66997e4b1fe26138c1ee17160005e1e905f69680d3c5faac17b2c456ba"}},{"ruleId":"X5","level":"note","message":{"text":"PHP static analysis does not check null everywhere: This repository commits no PHPStan or Psalm configuration (\u0060phpstan.neon[.dist]\u0060, \u0060phpstan.dist.neon\u0060, \u0060psalm.xml[.dist]\u0060, or one a composer.json script names with \u0060--configuration\u0060), so nothing checks null: a \u0060?Customer\u0060 reaches \u0060-\u003Ename()\u0060 silently and throws \u0060Error: Call to a member function name() on null\u0060 the first time it is null. If the build passes a level on a command line instead, put it in a committed configuration \u2014 this check reads configuration, and configuration is all it can read."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"4ee877508ebc333ebff2765634874753d7fd67f71ea749a6c333792a59b461d7"}},{"ruleId":"X6","level":"note","message":{"text":"Hand-rolled JSON/XML parsing via regex: A regex whose pattern encodes JSON/XML syntax is parsing a structured format by hand \u2014 malformed or differently-typed content (e.g. \u0060\u0022amount\u0022: \u00225\u0022\u0060 as a string) silently mis-parses instead of failing validation. This PHP code already uses a real parser in the same package; use it here too."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/blockrule/PhutilRemarkupTableBlockRule.php"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"a5ca5bfd735ceef304536cee5533cad3195b3e80130e23532407d31ceafd8e42"}},{"ruleId":"X6","level":"note","message":{"text":"Hand-rolled JSON/XML parsing via regex: A regex whose pattern encodes JSON/XML syntax is parsing a structured format by hand \u2014 malformed or differently-typed content (e.g. \u0060\u0022amount\u0022: \u00225\u0022\u0060 as a string) silently mis-parses instead of failing validation. This PHP code already uses a real parser in the same package; use it here too."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/infrastructure/markup/blockrule/PhutilRemarkupTableBlockRule.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"6b96c66d4ee3337440943f780ff18e2cdd67eef3cdc4fbea21d3c5471beae6b3"}},{"ruleId":"X7","level":"note","message":{"text":"Silent fallback default in catch: \u0060encodeBitStream\u0060 swallows every exception into \u0060return -1\u0060 \u2014 a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the docblock, and the row stops firing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"externals/phpqrcode/phpqrcode.php"},"region":{"startLine":1279}}}],"partialFingerprints":{"codehealthFindingId/v1":"e6254116db0b2140c034f571bee259f409c0c3b260dff0cd7df840eca2ec7ede"}},{"ruleId":"X7","level":"note","message":{"text":"Silent fallback default in catch: \u0060createFields\u0060 swallows every exception into \u0060return array()\u0060 \u2014 a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the docblock, and the row stops firing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/applications/harbormaster/customfield/HarbormasterBuildStepCoreCustomField.php"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"53f341b2e0b85d53c5a002b571f54b95bc9d45e9c4cd8ed1530b07543f882bc5"}}],"taxonomies":[{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d","organization":"MITRE","informationUri":"https://cwe.mitre.org/","isComprehensive":false,"shortDescription":{"text":"The MITRE Common Weakness Enumeration (CWE)."},"taxa":[{"id":"CWE-200","guid":"b0ce3b1d-7a29-fe50-8aab-9aba899d2988","name":"Exposure of Sensitive Information to an Unauthorized Actor","shortDescription":{"text":"Exposure of Sensitive Information to an Unauthorized Actor"},"helpUri":"https://cwe.mitre.org/data/definitions/200.html"},{"id":"CWE-259","guid":"ae9ad959-fbb6-9d5e-892d-3dca66da0b69","name":"Use of Hard-coded Password","shortDescription":{"text":"Use of Hard-coded Password"},"helpUri":"https://cwe.mitre.org/data/definitions/259.html"},{"id":"CWE-290","guid":"379b1e66-a292-7b59-aa1e-a5bb4a6a99e9","name":"Authentication Bypass by Spoofing","shortDescription":{"text":"Authentication Bypass by Spoofing"},"helpUri":"https://cwe.mitre.org/data/definitions/290.html"},{"id":"CWE-457","guid":"b62874fe-6222-8b5b-8ade-9527ad1cbb4a","name":"CWE-457","shortDescription":{"text":"CWE-457"},"helpUri":"https://cwe.mitre.org/data/definitions/457.html"},{"id":"CWE-540","guid":"1a9db5db-e5bb-ae5d-935a-d1b4e9ee080b","name":"Inclusion of Sensitive Information in Source Code","shortDescription":{"text":"Inclusion of Sensitive Information in Source Code"},"helpUri":"https://cwe.mitre.org/data/definitions/540.html"},{"id":"CWE-77","guid":"332c8ade-6612-9f56-a06b-d8d90b1a8750","name":"Improper Neutralization of Special Elements used in a Command (\u0027Command Injection\u0027)","shortDescription":{"text":"Improper Neutralization of Special Elements used in a Command (\u0027Command Injection\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/77.html"},{"id":"CWE-78","guid":"2e31ceaf-c7ae-2e5e-9661-cfb1362789cf","name":"Improper Neutralization of Special Elements used in an OS Command (\u0027OS Command Injection\u0027)","shortDescription":{"text":"Improper Neutralization of Special Elements used in an OS Command (\u0027OS Command Injection\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/78.html"},{"id":"CWE-79","guid":"fd45580b-e8c4-fc5e-8c2f-aa8fab0b4dbf","name":"Improper Neutralization of Input During Web Page Generation (\u0027Cross-site Scripting\u0027)","shortDescription":{"text":"Improper Neutralization of Input During Web Page Generation (\u0027Cross-site Scripting\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/79.html"},{"id":"CWE-798","guid":"5e8f057d-fee3-995a-a0cb-9fc5b0d174d1","name":"Use of Hard-coded Credentials","shortDescription":{"text":"Use of Hard-coded Credentials"},"helpUri":"https://cwe.mitre.org/data/definitions/798.html"},{"id":"CWE-89","guid":"6d08fdad-37eb-c150-bbf0-d7d946863407","name":"Improper Neutralization of Special Elements used in an SQL Command (\u0027SQL Injection\u0027)","shortDescription":{"text":"Improper Neutralization of Special Elements used in an SQL Command (\u0027SQL Injection\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/89.html"},{"id":"CWE-94","guid":"75e7f50c-6c2f-dd52-bf40-bf6c52b861fd","name":"Improper Control of Generation of Code (\u0027Code Injection\u0027)","shortDescription":{"text":"Improper Control of Generation of Code (\u0027Code Injection\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/94.html"}]},{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61","version":"2025","organization":"OWASP Foundation","informationUri":"https://top10.owasp.org/2025/","isComprehensive":false,"shortDescription":{"text":"The OWASP Top 10:2025 web application security risks."},"taxa":[{"id":"A01:2025","guid":"df693558-c822-0452-8f7b-4d53cb6bcc59","name":"Broken Access Control","shortDescription":{"text":"Broken Access Control"},"helpUri":"https://top10.owasp.org/2025/A01_2025-Broken_Access_Control/"},{"id":"A05:2025","guid":"87e86033-3231-8458-8e4a-5cb82743553a","name":"Injection","shortDescription":{"text":"Injection"},"helpUri":"https://top10.owasp.org/2025/A05_2025-Injection/"},{"id":"A07:2025","guid":"334ddd78-539d-d35c-83dd-253647eb7eaf","name":"Authentication Failures","shortDescription":{"text":"Authentication Failures"},"helpUri":"https://top10.owasp.org/2025/A07_2025-Authentication_Failures/"}]}],"properties":{"codehealthPublication":{"public":true,"notice":"This is the PUBLIC form of this artifact. Findings are listed in full, but the details of SECURITY findings \u2014 which rule fired, in which file, on which line, and how to fix it \u2014 are deliberately withheld, and any secret-scanner results are excluded entirely. Where detail is absent here it was REMOVED FOR PUBLICATION; it is not missing from the analysis. The complete artifact is available from the repository owner.","securityFindingsRedacted":49,"secretScannerRunsExcluded":0}},"redactionTokens":["A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."]}]}