Public report of nilaoda/N_m3u8DL-RE, published 12 November 2026. It has the same score, grades and number of findings as the full report. The details of security findings (where they are in the code, which known vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive report Measured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.11.3). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey → Signed and filed in the standard's public register, 12 November 2026, 01:08 UTC · Survey ID cd_e8f876ea1e1741f8b9946fb836bc10a4

nilaoda/N_m3u8DL-RE

Measured 12 November 2026, 01:07 UTC, at code version 7849be8

Boundary Type-Coupling is not measured: Bounded contexts not declared.

CAI score 37out of 100 Weak
CriticalWeakAdequateStrongExemplary
Down 1 since the last survey

The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.

A medium codebase: 23,053 lines of product code in 4 projects, tests not counted · Estimated rebuild effort: about 1.6 person-years · Weakest lens: Security and Compliance, 18

Findings by how serious they are

61 critical 357 serious 79 minor

7 dimensions are left out of the score. For each one, we either couldn't measure it in this code, or found no evidence of the safeguard we look for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.

This survey was produced by

Assert small markCanine Code Analyzer
Producer
Canine Development
Analyzer
Canine Code Analyzer engine 1.0.0
Measured
12 November 2026, 01:07 UTC

A measurement, not a certificate. The Code Assurance Index records a number together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee the code. The standard was written by Canine Development, which also builds the Canine Code Analyzer. It is open to any tool that implements it, and today the Canine Code Analyzer is the only one that does.

The score is deterministic, which means the same code always gets the same score. We work it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸

68of 68 dimensions measured by tools.
475of 497 findings point to an exact file and line, so you can open each one in the code. The other 22 concern the repository as a whole, such as missing documentation.
68dimensions across 6 lenses, read from 23,053 lines of product code in 4 projects.
Chapters

Executive summary

nilaoda/N_m3u8DL-RE falls short of our standard for a preview release, in part because we found no access checks on the code's endpoints or handlers. It scores 37 out of 100 and is rated Weak, and 43 of its 61 critical findings are security problems.

Security and Compliance, at 18, is the weakest lens and counts most in the score. The best first step is adding access checks, worth about 14 points. Restoring certificate checks comes next, worth about 10 points. Raising Security and Compliance to 68 would lift the score to about 55.

Twenty-one pipeline tools are referenced by a changeable name, so the build pipeline can be tampered with. Sixteen weaknesses in the code could be used by an attacker, and ten errors are caught and ignored, so failures can go unnoticed. Pinning each tool to an exact version, fixing the weaknesses the scanner points to and handling or logging the ignored errors would close these risks. Updating the vulnerable packages would fix the package with a known security hole, and the two passwords or keys in the code's history need replacing, with the old ones switched off. The four data fields that are written but never read need removing.

The product code is 23,053 lines, about €230,000 to rebuild.

A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.

How the score is built: what each lens counts for The lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
Security and Compliance 18 · counts for 46%Production Readiness 50 · counts for 25%Maturity 56 · counts for 14%Architecture 58 · counts for 8%Performance 60 · counts for 4%Code Health 62 · counts for 2%

If Security and Compliance rose from 18 to 68, the lowest score rated Strong, the score would rise from 37 to about 55.

Code composition: what the lines of code are
Business logic 39%Supporting code 22%Tests 39%
New since the last survey: 33 findings

These 33 critical or serious findings weren't in the previous survey, on 23 October 2026.

  • Cyclomatic Complexity · HLSVariableSubstitution.Process (cyclomatic 32) src/N_m3u8DL-RE.Parser/Util/HLSVariableSubstitution.cs
  • Cyclomatic Complexity · LiveSegmentDownloadQueue.AttemptAsync (cyclomatic 22) src/N_m3u8DL-RE/DownloadManager/LiveSegmentDownloadQueue.cs
  • Cyclomatic Complexity · MediainfoUtil.ReadInfoAsync (cyclomatic 18) src/N_m3u8DL-RE/Util/MediainfoUtil.cs
  • Cyclomatic Complexity · MergeUtil.ConcatMediaParts (cyclomatic 18) REDACTED
  • Cognitive Complexity · HLSVariableSubstitution.Process (cognitive 66) src/N_m3u8DL-RE.Parser/Util/HLSVariableSubstitution.cs
  • Cognitive Complexity · LiveSegmentDownloadQueue.AttemptAsync (cognitive 29) src/N_m3u8DL-RE/DownloadManager/LiveSegmentDownloadQueue.cs
  • Cognitive Complexity · ToolInputResolver.Expand (cognitive 22) src/N_m3u8DL-RE/Util/ToolInputResolver.cs
  • Cognitive Complexity · MediainfoUtil.ReadInfoAsync (cognitive 21) src/N_m3u8DL-RE/Util/MediainfoUtil.cs
  • Cognitive Complexity · MergeUtil.ConcatMediaParts (cognitive 18) REDACTED
  • Cognitive Complexity · MP4MediaInfoUtil.ReadTrackInfo (cognitive 17) src/N_m3u8DL-RE.Parser/Mp4/MP4MediaInfoUtil.cs
  • Code Duplication · Edited copy of a member (33 corresponding lines) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs
  • Code Duplication · Edited copy of a member (18 corresponding lines) src/N_m3u8DL-RE/CommandLine/ConfigFile.cs
  • Code Duplication · Edited copy of a member (22 corresponding lines) src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs
  • Code Duplication · Edited copy of a member (15 corresponding lines) src/N_m3u8DL-RE/Util/ConcatInputStream.cs
  • Code Duplication · Edited copy of a member (18 corresponding lines) REDACTED
  • Code Duplication · Edited copy of a member (12 corresponding lines) src/N_m3u8DL-RE.Parser/Mp4/MSSMoovProcessor.cs
  • Code Duplication · Edited copy of a member (12 corresponding lines) src/N_m3u8DL-RE/Util/LargeSingleFileSplitUtil.cs
  • Code Duplication · Edited copy of a member (15 corresponding lines) src/N_m3u8DL-RE/Crypto/CSChaCha20.cs
  • Code Duplication · Edited copy of a member (11 corresponding lines) src/N_m3u8DL-RE.Parser/Mp4/BinaryWriter2.cs
  • Code Duplication · Edited copy of a member (2 corresponding lines) src/N_m3u8DL-RE.Common/Entity/WebVttSub.cs
  • Code Duplication · Edited copy of a member (2 corresponding lines) src/N_m3u8DL-RE/Util/HlsSubtitleTimeline.cs
  • Code Duplication · Edited copy of a member (4 corresponding lines) src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs
  • Code Duplication · Duplicated block (18 lines × 2) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs
  • Churn × Complexity Hotspots · Hotspot: src/N_m3u8DL-RE/Util/MediainfoUtil.cs src/N_m3u8DL-RE/Util/MediainfoUtil.cs
  • Static Analysis (SAST) · REDACTED
  • Dependency Vulnerabilities · High CVE: REDACTED
  • Change Coupling · Boundary-crossing change coupling: HTTPUtil.cs ↔ CommandInvoker.cs src/N_m3u8DL-RE.Common/Util/HTTPUtil.cs
  • Async correctness · Sync-over-async (deadlock risk) REDACTED
  • Cancellation propagation · Async method without CancellationToken: ReadInitInfoAsync src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs
  • Stateful singletons · Process-global static state: CommandInvoker src/N_m3u8DL-RE/CommandLine/CommandInvoker.cs
  • Stateful singletons · Process-global static state: CustomAnsiConsole src/N_m3u8DL-RE.Common/Log/CustomAnsiConsole.cs
  • Stateful singletons · Process-global static state: Logger src/N_m3u8DL-RE.Common/Log/Logger.cs
  • Async & latency hygiene · Sync-over-async blocking REDACTED

We compare every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.

Fixed since the last survey: 37 findings

These 37 critical or serious findings were in the previous survey, on 23 October 2026, and are gone from this one.

  • Cognitive Complexity · SimpleLiveRecordManager2.DownloadLiveSegmentAsync (cognitive 24) src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs
  • Code Duplication · Near-duplicate member pair (49 shared lines) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs
  • Code Duplication · Duplicated block (9 lines × 2) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs
  • Code Duplication · Duplicated block (5 lines × 2) src/N_m3u8DL-RE/Crypto/CSChaCha20.cs
  • Static Analysis (SAST) · High: watchdog-quoted-interpolation-into-process-arguments-csharp REDACTED
  • Async correctness · Blocking `MemoryStream.Write` inside an `async` method src/N_m3u8DL-RE.Common/Util/HTTPUtil.cs
  • Cancellation propagation · Async method without CancellationToken: ChangeSpecInfoAsync src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs
  • Cancellation propagation · Async method without CancellationToken: ChangeSpecInfoAsync src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs
  • Cancellation propagation · Async method without CancellationToken: FFmpegSupportsDolbyVisionAsync src/N_m3u8DL-RE/Util/BinaryToolUtil.cs
  • Cancellation propagation · Async method without CancellationToken: RespondAsync src/N_m3u8DL-RE/Util/ConcatInputServer.cs
  • Cancellation propagation · Async method without CancellationToken: CopyFileAsync src/N_m3u8DL-RE/Util/DownloadUtil.cs
  • Cancellation propagation · Async method without CancellationToken: ProcessAsync src/N_m3u8DL-RE/Util/ImageHeaderUtil.cs
  • Cancellation propagation · Async method without CancellationToken: SplitUrlAsync src/N_m3u8DL-RE/Util/LargeSingleFileSplitUtil.cs
  • Cancellation propagation · Async method without CancellationToken: CanSplitAsync src/N_m3u8DL-RE/Util/LargeSingleFileSplitUtil.cs
  • Cancellation propagation · Async method without CancellationToken: GetFileSizeAsync src/N_m3u8DL-RE/Util/LargeSingleFileSplitUtil.cs
  • Cancellation propagation · Async method without CancellationToken: RunAsync src/N_m3u8DL-RE/Util/MediaProcessingProgress.cs
  • Cancellation propagation · Async method without CancellationToken: DecryptAsync REDACTED
  • Cancellation propagation · Async method without CancellationToken: RunCommandAsync REDACTED
  • Cancellation propagation · Async method without CancellationToken: SearchKeyFromFileAsync REDACTED
  • Cancellation propagation · Async method without CancellationToken: DeGzipFileAsync src/N_m3u8DL-RE/Util/OtherUtil.cs
  • Cancellation propagation · Async method without CancellationToken: StartPipeMuxAsync REDACTED
  • Cancellation propagation · Async method without CancellationToken: RunCommandAsync src/N_m3u8DL-RE/Util/ProcessUtil.cs
  • Cancellation propagation · Async method without CancellationToken: ReadLinesAsync src/N_m3u8DL-RE/Util/ProcessUtil.cs
  • Cancellation propagation · Async method without CancellationToken: ReadAsync src/N_m3u8DL-RE/Util/ProcessUtil.cs
  • Cancellation propagation · Async method without CancellationToken: TryWriteImagePngsAsync REDACTED
  • Cancellation propagation · Async method without CancellationToken: InspectGroupsAsync src/N_m3u8DL-RE/Util/VodPartSelector.cs
  • Cancellation propagation · Async method without CancellationToken: ListAsync src/N_m3u8DL-RE/Util/VodPartSelector.cs
  • Cancellation propagation · Async method without CancellationToken: SelectAsync src/N_m3u8DL-RE/Util/VodPartSelector.cs
  • Cancellation propagation · Async method without CancellationToken: GetWebSourceAsync src/N_m3u8DL-RE.Common/Util/HTTPUtil.cs
  • Cancellation propagation · Async method without CancellationToken: GetPostResponseAsync src/N_m3u8DL-RE.Common/Util/HTTPUtil.cs
  • Cancellation propagation · Async method without CancellationToken: WebRequestRetryAsync src/N_m3u8DL-RE.Common/Util/RetryUtil.cs
  • Cancellation propagation · Async method without CancellationToken: FetchPlayListAsync src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs
  • Cancellation propagation · Async method without CancellationToken: ExtractStreamsAsync src/N_m3u8DL-RE.Parser/Extractor/HLSExtractor.cs
  • Cancellation propagation · Async method without CancellationToken: FetchPlayListAsync src/N_m3u8DL-RE.Parser/Extractor/MSSExtractor.cs
  • Cancellation propagation · Async method without CancellationToken: LoadSourceFromUrlAsync src/N_m3u8DL-RE.Parser/StreamExtractor.cs
  • Cancellation propagation · Async method without CancellationToken: ExtractStreamsAsync src/N_m3u8DL-RE.Parser/StreamExtractor.cs
  • Cancellation propagation · Async method without CancellationToken: FetchPlayListAsync src/N_m3u8DL-RE.Parser/StreamExtractor.cs
Rebuild cost: about €230,000 · Estimate
Cost to rebuild€75,000 to €390,000, for 1,255 to 4,129 hours of work, about 1.6 person-years for 1 to 4 engineers
Difficulty of the problemStandard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor×0.7 at a score of 37. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
SizeMedium: 23,053 lines of product code, of which 28% is declarations and boilerplate, 8% straight logic and 64% logic with branches
Comment linesThe estimate prices 21,079 lines. Comment lines count towards the size of 23,053 lines but aren't priced as work.
What it is notNot a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.

How the estimate is made: We price the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty.

Top priorities

The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.

1
Protect endpoints by default-deny: [Authorize] + role/policy authorization, or imperative guard methods (throw-on-violation) called from every handler.
Raises the score by about 14 points · Medium effort · Access Controls
2
Stop accepting every TLS certificate: remove the always-true validation callback so the platform verifies the chain, hostname and expiry.
If one self-signed certificate must be trusted, pin it by public key or thumbprint on the single handler that needs it and reject all others — never process-wide.
Raises the score by about 10 points · Medium effort · Web-Security Posture
3
Resolve the 2 REDACTED finding(s) in Secrets (history) — start with REDACTED, REDACTED.
Raises the score by about 2 points · Low effort · Secrets (history)

Diagnosis: what the measurements show together

Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.

Where the investment is most exposed · Value at risk
This code would cost about €230,000 to build again, about 1.6 person-years of work. Its weakest lens is Security and Compliance, at 18 (Critical). Security and Compliance is about how well the product is protected, and how it handles personal data. Because the weakest lens counts most in the score, work on Security and Compliance also moves the score most.
Based on: the rebuild estimate · the Security and Compliance grade · how much each lens counts
What to do: Start with the Security and Compliance actions in Top priorities.
If you do one thing first · First action
Protect endpoints by default-deny: [Authorize] + role/policy authorization, or imperative guard methods (throw-on-violation) called from every handler. Of all the actions in this report, it raises the score most for the work it takes: about 14 points for medium effort. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
What hard-to-read code costs each year · Cost
Four dimensions measure how easy the code is to work in: two measure how tangled its logic is, one how much of it is copied, and one how well each part sticks to a single job. In this codebase they average 5.8 out of 10. Code at that level is slower to change than clean code, and we estimate the extra work at 5% to 12% on every change. The history of the code shows how much it changes: about 32,211 lines over the last 90 days, which is about 130,634 lines a year. At that pace, the extra work comes to an estimated 17.9 to 107.3 engineer-days a year, and it grows as more code changes.
How this is estimated: The number of changed lines is measured from the history of the code. The rest rests on two assumptions of our own: code scoring 8 out of 10 or more adds no extra work, and each point below 8 adds 2.5% to 5.6% to every change, never less than 2% to 5% and never more than 40% to 60% in all; and an engineer changes 150 to 400 lines in a day. The result is a range for planning, not a measurement.
Based on: Cyclomatic Complexity · Cognitive Complexity · Code Duplication · Cohesion (LCOM4) · the code's change history
What to do: Start with the files listed under Churn × Complexity Hotspots, which change often and are hard to read, because that is where the extra work is paid most often.

Architecture — module dependency graph

Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways, which only happens where the projects form a dependency cycle. A graph without cycles has none.

arch N_m3u8DL-RE N_m3u8DL-RE N_m3u8DL-RE.Parser Parser N_m3u8DL-RE->N_m3u8DL-RE.Parser N_m3u8DL-RE.Common Common N_m3u8DL-RE.Parser->N_m3u8DL-RE.Common

Architecture: which parts of the code depend on which

The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.

29 modules, with 58 dependencies between them. One loop runs through 2 of the modules, marked above the diagonal.

Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
uses →1 CSChaCha202 N_m3u8DL_RE.Common.Enum3 N_m3u8DL_RE.Common.JsonConverter4 N_m3u8DL_RE.Common.Log5 N_m3u8DL_RE.Common.Resource6 N_m3u8DL_RE.Crypto7 N_m3u8DL_RE.Enum8 N_m3u8DL_RE.Parser.Constants9 N_m3u8DL_RE.Parser.Util10 N_m3u8DL_RE.Common.Entity11 N_m3u8DL_RE.Entity12 Mp4SubtitleParser13 N_m3u8DL_RE.Column14 N_m3u8DL_RE.CommandLine15 N_m3u8DL_RE.Common16 N_m3u8DL_RE.Parser.Mp417 N_m3u8DL_RE.Parser.Processor18 N_m3u8DL_RE.Common.Util19 N_m3u8DL_RE.Config20 N_m3u8DL_RE.Parser.Config21 N_m3u8DL_RE.Util22 N_m3u8DL_RE.Downloader23 N_m3u8DL_RE.Parser.Processor.DASH24 N_m3u8DL_RE.Parser.Processor.HLS25 N_m3u8DL_RE.Processor26 N_m3u8DL_RE.Parser.Extractor27 N_m3u8DL_RE.Parser28 N_m3u8DL_RE29 N_m3u8DL_RE.DownloadManager
1 CSChaCha20
2 N_m3u8DL_RE.Common.Enum
3 N_m3u8DL_RE.Common.JsonConverter
4 N_m3u8DL_RE.Common.Log
5 N_m3u8DL_RE.Common.Resource
6 N_m3u8DL_RE.Crypto
7 N_m3u8DL_RE.Enum
8 N_m3u8DL_RE.Parser.Constants
9 N_m3u8DL_RE.Parser.Util
10 N_m3u8DL_RE.Common.Entity4
11 N_m3u8DL_RE.Entity21
12 Mp4SubtitleParser3
13 N_m3u8DL_RE.Column2
14 N_m3u8DL_RE.CommandLine42610
15 N_m3u8DL_RE.Common56
16 N_m3u8DL_RE.Parser.Mp41
17 N_m3u8DL_RE.Parser.Processor414
18 N_m3u8DL_RE.Common.Util11
19 N_m3u8DL_RE.Config1
20 N_m3u8DL_RE.Parser.Config23
21 N_m3u8DL_RE.Util7121611
22 N_m3u8DL_RE.Downloader361
23 N_m3u8DL_RE.Parser.Processor.DASH111
24 N_m3u8DL_RE.Parser.Processor.HLS4133
25 N_m3u8DL_RE.Processor2122
26 N_m3u8DL_RE.Parser.Extractor91071
27 N_m3u8DL_RE.Parser1211
28 N_m3u8DL_RE111
29 N_m3u8DL_RE.DownloadManager1181123243
Uses a module listed above itPart of a loopThe module itself
1 CSChaCha202 N_m3u8DL_RE.Common.Enum3 N_m3u8DL_RE.Common.JsonConverter4 N_m3u8DL_RE.Common.Log5 N_m3u8DL_RE.Common.Resource6 N_m3u8DL_RE.Crypto7 N_m3u8DL_RE.Enum8 N_m3u8DL_RE.Parser.Constants9 N_m3u8DL_RE.Parser.Util10 N_m3u8DL_RE.Common.Entity11 N_m3u8DL_RE.Entity12 Mp4SubtitleParser13 N_m3u8DL_RE.Column14 N_m3u8DL_RE.CommandLine15 N_m3u8DL_RE.Common16 N_m3u8DL_RE.Parser.Mp417 N_m3u8DL_RE.Parser.Processor18 N_m3u8DL_RE.Common.Util19 N_m3u8DL_RE.Config20 N_m3u8DL_RE.Parser.Config21 N_m3u8DL_RE.Util22 N_m3u8DL_RE.Downloader23 N_m3u8DL_RE.Parser.Processor.DASH24 N_m3u8DL_RE.Parser.Processor.HLS25 N_m3u8DL_RE.Processor26 N_m3u8DL_RE.Parser.Extractor27 N_m3u8DL_RE.Parser28 N_m3u8DL_RE29 N_m3u8DL_RE.DownloadManagerCSChaCha201N_m3u8DL_RE.Common.Enum2N_m3u8DL_RE.Common.JsonConverter3N_m3u8DL_RE.Common.Log4N_m3u8DL_RE.Common.Resource5N_m3u8DL_RE.Crypto6N_m3u8DL_RE.Enum7N_m3u8DL_RE.Parser.Constants8N_m3u8DL_RE.Parser.Util9N_m3u8DL_RE.Common.Entity10N_m3u8DL_RE.Entity11Mp4SubtitleParser12N_m3u8DL_RE.Column13N_m3u8DL_RE.CommandLine14N_m3u8DL_RE.Common15N_m3u8DL_RE.Parser.Mp416N_m3u8DL_RE.Parser.Processor17N_m3u8DL_RE.Common.Util18N_m3u8DL_RE.Config19N_m3u8DL_RE.Parser.Config20N_m3u8DL_RE.Util21N_m3u8DL_RE.Downloader22N_m3u8DL_RE.Parser.Processor.DASH23N_m3u8DL_RE.Parser.Processor.HLS24N_m3u8DL_RE.Processor25N_m3u8DL_RE.Parser.Extractor26N_m3u8DL_RE.Parser27N_m3u8DL_RE28N_m3u8DL_RE.DownloadManager294213242610561414111237121611361111413321229107112111111181123243

At a glance — Code Health · 62% · Adequate · gated by D1, D2 ·

At a glance — Architecture · 58% · Adequate · gated by AX2, AX5 ·

At a glance — Maturity · 56% · Adequate · gated by M2 ·

At a glance — Readiness · 50% · Adequate · gated by P3 ·

At a glance — Security · 18% · Critical · gated by D29, D36, C2, S1 ·

At a glance — Performance · 60% · Adequate ·

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP categoryFindingsSeverity
A05:2025 — Injection45High / Critical
A03:2025 — Software Supply Chain Failures9High / Critical
A07:2025 — Authentication Failures3High / Critical

Roadmap

Top priorities: Protect endpoints by default-deny: [Authorize] + role/policy authorization, or imperative guard methods (throw-on-violation) called from every handler; Stop accepting every TLS certificate: remove the always-true validation callback so the platform verifies the chain, hostname and expiry. If one self-signed certificate must be trusted, pin it by public key or thumbprint on the single handler that needs it and reject all others — never process-wide; Resolve the 10 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (4), REDACTED (4), REDACTED (2).

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do thisHelpsEffortDimension
Protect endpoints by default-deny: [Authorize] + role/policy authorization, or imperative guard methods (throw-on-violation) called from every handler.+14.0 ptsMediumAccess Controls
Stop accepting every TLS certificate: remove the always-true validation callback so the platform verifies the chain, hostname and expiry. If one self-signed certificate must be trusted, pin it by public key or thumbprint on the single handler that needs it and reject all others — never process-wide.+10.0 ptsMediumWeb-Security Posture
Resolve the 2 REDACTED finding(s) in Secrets (history) — start with REDACTED, REDACTED.+1.5 ptsLowSecrets (history)
Resolve the 10 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (4), REDACTED (4), REDACTED (2).+3.1 ptsMediumStatic Analysis (SAST)
Resolve the 6 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (6).+1.9 ptsLowStatic Analysis (SAST)
Resolve the 1 High CVE finding(s) in Dependency Vulnerabilities.+1.5 ptsLowDependency Vulnerabilities
Add a SAST step to CI running what this repository's stack ships: CodeQL's csharp pack, or a .NET security analyzer package — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.+2.2 ptsMediumSecurity & performance tooling
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED.+1.0 ptsLowSupply-chain Provenance & Signing

File quality

Per-file score 0–10 — a quality signature. Of 66 files carrying findings, judged against the Preview bar: 8% slop · 19% mixed · 73% near-clean.

FileScoreBandWorst signal
REDACTED0.4SlopStatic Analysis (SAST): High: REDACTED
REDACTED0.5SlopStatic Analysis (SAST): High: REDACTED
REDACTED0.7SlopSecrets (history): REDACTED: REDACTED
REDACTED0.7SlopStatic Analysis (SAST): High: REDACTED
src/N_m3u8DL-RE/DownloadManager/HTTPLiveRecordManager.cs1.7SlopExplicit Debt: WriteOnlyPrivateField
src/N_m3u8DL-RE.Common/Util/HTTPUtil.cs3.4MixedChange Coupling: Boundary-crossing change coupling: HTTPUtil.cs ↔ CommandInvoker.cs
REDACTED4.0MixedStatic Analysis (SAST): Medium: REDACTED
src/N_m3u8DL-RE/CommandLine/CommandInvoker.cs4.3MixedExplicit Debt: EmptyCatchBlock
src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs4.6MixedExplicit Debt: EmptyCatchBlock
REDACTED4.8MixedStatic Analysis (SAST): High: REDACTED
src/N_m3u8DL-RE/Util/TSInfoUtil.cs4.8MixedExplicit Debt: EmptyCatchBlock
src/N_m3u8DL-RE/Util/ConcatInputServer.cs5.0MixedExplicit Debt: EmptyCatchBlock
src/N_m3u8DL-RE/DownloadManager/BinaryDownloadManager.cs5.4MixedExplicit Debt: EmptyCatchBlock
src/N_m3u8DL-RE.Common/Resource/StaticText.cs5.8MixedChange Coupling: Boundary-crossing change coupling: StaticText.cs ↔ MyOption.cs
src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs6.0MixedExplicit Debt: CommentedOutCode
src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs6.0MixedExplicit Debt: CommentedOutCode
src/N_m3u8DL-RE.Parser/Mp4/MSSMoovProcessor.cs6.0MixedExplicit Debt: CommentedOutCode
src/N_m3u8DL-RE.Parser/Extractor/HLSExtractor.cs6.5MixedCyclomatic Complexity: HLSExtractor.ParseListAsync (cyclomatic 72)
src/N_m3u8DL-RE/Util/FilterUtil.cs7.0Near-cleanCyclomatic Complexity: FilterUtil.DoFilterKeep (cyclomatic 37)
src/N_m3u8DL-RE.Parser/Mp4/MP4MediaInfoUtil.cs7.0Near-cleanCyclomatic Complexity: MP4MediaInfoUtil.ReadTiming (cyclomatic 22)

How the grades work

Every finding carries one of four grades. Three say how serious it is. The fourth says this survey could not settle it — and it is a grade, not a gap.

Critical — 61

A definite problem that already costs you something and drags the score down: a missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here tends to cause failures elsewhere.

Serious — 357

Likely wrong, but not failing yet. It degrades the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to carry for two years either.

Minor — 79

Recorded, with no effect on how the codebase functions. Present so the survey is complete, not because it needs doing.

Could not be resolved — 7

Something this survey could not settle from the outside, and which could be critical or serious. Either a control was required and no positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean result. These are excluded from the score rather than awarded a pass, so the number on the cover neither rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each one is named under Limitations.

Methodology & how to trust this report

This survey is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. All 68 evaluated dimensions are computed by tools and static analysis; no language model sets or judges any of them. Overall confidence is 0.9, the weighted average across measured dimensions.

Every figure here is one of two kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10.

What we checked — 68 dimensions across the health lenses
D1D2D3D4D5D6D10D11D13D14D15D17D18D19D20D21D24D26D27D28D29D30D34D35D36D43D44AX10AX2AX3AX4AX5AX6AX8C2GD1IC1M1M2M3M4P1P2P3P4P6PF3S1X1X12X13X14X16X18X19X2X20X21X22X23X24X25X27X28X29X3X30X5

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions
  1. Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 475 of 497 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
  2. Is there a tool behind the number? Every score below names the method that produced it: Roslyn, git or a scanner, not a narrative.
  3. Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

MethodBacksVersionEvaluator
Roslyn static analysisComplexity, cohesion, coupling, dead code, API surface, layering5.3.0✓ deterministic
Native secret scannerHardcoded secrets / credentials1.0.0✓ deterministic
Canine Code Analyzer duplication detector (in-process)Code duplication1.0.0✓ deterministic
Coverage (coverlet / dotnet-coverage)Line & branch coverage10.0.400✓ deterministic
NuGet / dotnetOutdated, vulnerable & deprecated dependencies10.0.400✓ deterministic
git / LibGit2SharpChurn hotspots, knowledge concentration, history2.43.0 · 0.31.0✓ deterministic
gitleaks · semgrep · trivySecrets in history, SAST, CVEs, IaC & container, PII / GDPR1.86.0 · 0.69.3✓ deterministic

Every finding is locatable in findings.md. Run 01a1cd4b-a228-76ef-a384-966560f1a3cb.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

  • D8 Code Coverage — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT MEASURED: the analyzer environment could not build/run the test suite (a target framework / SDK band or targeting pack the analyzer image doesn't carry). This is OUR limitation, not a defect in the repo — coverage is excluded from the score rather than counted as a near-zero. We track the analyzer-image gap so it can be closed; in the meantime, your test projects already reference a coverage collector, but no CI step we found runs the tests with it, so there is no report to hand us — run them with `--collect:"XPlat Code Coverage"` and commit (or publish into the working tree) the coverage.cobertura.xml it writes, and real coverage will be read. You can widen what we reach: optional: your test projects already reference a coverage collector, but no CI step we found runs the tests with it, so there is no report to hand us — run them with `--collect:"XPlat Code Coverage"` and commit (or publish into the working tree) the coverage.cobertura.xml it writes, and the real number is read on the next scan.
  • D12 Dependency Hygiene — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `dotnet list package` did not return usable output (restore or query failed); no outdated/vulnerable/deprecated data to assess. The tool said: `dotnet list package` exited 1 with no output.
  • D16 Bus Factor — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. Single-maintainer repository — bus factor is not applicable (26 contributor(s) across 625 commit(s) sampled, automation and bot accounts excluded). One of them holds 93% of the history; the other 25 hold 0.3% each on average, below the 5% at which there is somebody to hand the work to. That is a single maintainer with drive-by contributors, not a team whose knowledge has concentrated — so the bus factor is not applicable and there is nothing here for the owner to act on.
  • D19 Documentation Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This kind did not reach the 95 % precision gate in three adjudicated runs (docs/plans/deterministic-engine/adjudication/D19-sample3-v3.md), so by the pre-registered fallback it publishes no row until a re-measurement shows it does. The candidates are counted here, not reported as findings, and the score does not include them.
  • D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
  • D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
  • D22 Internal API Consistency — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. The loaded project set declares no packable project and no `.Contracts` project, so there is no intentionally-exposed surface for API consistency to be judged over.
  • D23 Boundary Type-Coupling — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Large codebase (23,053 production LoC in the .NET projects) with no declared bounded contexts — cross-boundary type coupling is unassessed Bounded contexts cannot be inferred from a codebase that is not physically organised by them (D-321), so with none declared there are no boundaries for the coupling pass to measure across. You can widen what we reach: name this codebase's bounded contexts (≥2 module groups, e.g. per subsystem) so cross-boundary type coupling can be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
  • D24 Comment Value — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. D24 compares a comment's words with the identifiers, literals and constructs of the code it annotates, using English function-word and rationale lexicons. Comments in another script or language were left unread rather than counted as clean.
  • D32 Data Compliance (PII/GDPR) — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `src/N_m3u8DL-RE.Common/Entity/WebSourceResult.cs`, `src/N_m3u8DL-RE.Common/Log/CustomAnsiConsole.cs`, `src/N_m3u8DL-RE.Common/Log/Logger.cs`, `src/N_m3u8DL-RE.Common/Util/CookieFileHandler.cs`, `src/N_m3u8DL-RE.Common/Util/CookieFileJar.cs`, … (+19 more) produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
  • M4 Documentation accuracy — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. M4 checks only the claim kinds adjudicated at or above 95 % precision: links and versions (PREREGISTRATION version 9), and artefact counts an order of magnitude off. Paths, command arguments, installs, environment variables, settings, projects, packages, routes, cd targets, infrastructure products and removed modules are read but not checked, and none of them is reported or counted.
  • P1 CI/CD gates — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. A CI pipeline exists and the word "test" appears, but no explicit test-runner invocation (your stack's test command, or a test job) was matched — so either the gate runs tests through a step this pass could not recognise, or "test" is incidental here (a path, "latest", a reporter). Which of the two it is cannot be settled from this dimension's evidence; the coverage dimensions report whether a suite exists at all. You can widen what we reach: name the test runner explicitly in the pipeline step (your stack's test command, or a job named for the suite) so the gate is unambiguous to a reader and to this pass.
  • P10 Library API & versioning — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Library API & versioning could not be assessed in this run — the check did not complete, so it is not scored. This is a gap in the analyzer, not a finding about this repository. Engine failure: ArgumentException: SyntaxTree is not part of the compilation (Parameter 'syntaxTree').
  • P11 BDD / executable specs — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. BDD / executable specs could not be assessed in this run — the check did not complete, so it is not scored. This is a gap in the analyzer, not a finding about this repository. Engine failure: ArgumentException: SyntaxTree is not part of the compilation (Parameter 'syntaxTree').
  • P5 DR & Backup — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. No backup/snapshot/replication config, RTO/RPO or restore-procedure documentation was found — and no production persistence was detected either (no data-access packages, no data-store services, no database resources), so there is nothing in this repository whose loss a DR control would recover. If this system's data lives in a platform or ops repo we can't see, that's where the DR evidence belongs.
  • P7 Outbound HTTP resilience — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Outbound HTTP resilience could not be assessed in this run — the check did not complete, so it is not scored. This is a gap in the analyzer, not a finding about this repository. Engine failure: ArgumentException: SyntaxTree is not part of the compilation (Parameter 'syntaxTree').
  • P8 Schema migrations — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Schema migrations could not be assessed in this run — the check did not complete, so it is not scored. This is a gap in the analyzer, not a finding about this repository. Engine failure: ArgumentException: SyntaxTree is not part of the compilation (Parameter 'syntaxTree').
  • X2 Cancellation propagation — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 28 further occurrence(s) are not listed individually; the score already reflects all 68.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

We assess the repository exactly as committed, and only the repository. By design we do not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

  • D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
  • D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
  • D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
  • D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
  • D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
  • D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
  • D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
  • D11 Test Reliability: Flakiness is inferred from history/markers — we run the suite once (for coverage), not the repeated runs under varied conditions that reveal nondeterminism, so a flaky test never recorded as failing is invisible here.
  • D13 REDACTED Scanning: REDACTED detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
  • D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
  • D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
  • D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
  • D18 Solution Shape: Build integrity reflects whether the solution compiled in this environment — a build that needs a private feed, a specific SDK, or a generated file absent from the repo can read as broken when it is merely unreproducible here.
  • D19 Documentation Quality: Documentation quality publishes two things only: a runnable or packaged unit with no example, and a multi-project root README that maps none of its parts. It does not judge clarity, and its other checks (overview, licence, boilerplate, structure, empty sections, XML-doc coverage) are withheld after adjudication: their candidates are counted in the card's gaps, not shown as rows. A false statement in a document is M4's; units are .NET projects only.
  • D20 ADR Quality: ADR quality checks the structure of the decision records present: it cannot know about decisions made and never recorded, and it does not judge how well a record argues its case. Records in a language the section lexicon does not cover are not evaluated.
  • D21 Naming Consistency: Naming consistency compares each name with the convention its structural peers follow in this repository: it cannot tell whether a consistently used name is a good one, and languages other than C# and TypeScript are not measured.
  • D24 Comment Value: Comment value is measured as redundancy only: a comment that repeats its code's words is found, but a paraphrase in other words, a vague comment, or one the code contradicts is not, and whether a comment is valuable is not claimed. Comments in other scripts or languages, and outside C#, are not judged.
  • D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
  • D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
  • D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
  • D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
  • D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
  • D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
  • D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
  • D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
  • D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
  • AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
  • M4 Documentation accuracy: Documentation accuracy checks links, versions and artefact counts against the tree: other claims (paths, commands, settings, routes) are read but not checked, and it cannot run the onboarding or measure how long a real new joiner takes.
  • P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
  • P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.

Dimensions

D1 · Cyclomatic Complexity2.0 / 10Critical✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: Documented → Verified → Prevented · effective 2.0 / 10 · rule-coverage 100% · ceiling Prevented

60 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was SimpleDownloadManager.DownloadStreamAsync at 209. A further 2 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being ImageHeaderUtil.IsImageHeader at 22 — they are counted neither in the figure above nor in this dimension's score.

SimpleDownloadManager.DownloadStreamAsync (cyclomatic 209)src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:142
SimpleLiveRecordManager2.RecordStreamAsync (cyclomatic 150)src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:250
DASHExtractor2.ExtractStreamsAsync (cyclomatic 114)src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:63
Program.DoWorkAsync (cyclomatic 111)REDACTED:81
HLSExtractor.ParseListAsync (cyclomatic 72)src/N_m3u8DL-RE.Parser/Extractor/HLSExtractor.cs:227

+ 55 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 2 bodies over 120 down to 120 or less in Cyclomatic Complexity — start with SimpleDownloadManager.DownloadStreamAsync (cyclomatic 209), SimpleLiveRecordManager2.RecordStreamAsync (cyclomatic 150). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 2 together lifts Cyclomatic Complexity from 2.0 to about 3.2/10, projected with the scoring formula itself and assuming each lands exactly at 120; a cleaner split scores higher.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

D2 · Cognitive Complexity2.0 / 10Critical✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: Documented → Verified → Prevented · effective 2.0 / 10 · rule-coverage 100% · ceiling Prevented

82 method(s) exceeded the cognitive complexity threshold of 15; the worst was SimpleLiveRecordManager2.RecordStreamAsync at 357.

SimpleLiveRecordManager2.RecordStreamAsync (cognitive 357)src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:250
DASHExtractor2.ExtractStreamsAsync (cognitive 344)src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:63
SimpleDownloadManager.DownloadStreamAsync (cognitive 301)src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:142
MergeUtil.MuxInputsAsync (cognitive 131)REDACTED:416
Program.DoWorkAsync (cognitive 129)REDACTED:81

+ 77 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 14 bodies over 60 down to 60 or less in Cognitive Complexity — start with SimpleLiveRecordManager2.RecordStreamAsync (cognitive 357), DASHExtractor2.ExtractStreamsAsync (cognitive 344), SimpleDownloadManager.DownloadStreamAsync (cognitive 301). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 14 together lifts Cognitive Complexity from 2.0 to about 3.6/10, projected with the scoring formula itself and assuming each lands exactly at 60; a cleaner split scores higher.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

D3 · God Classes7.4 / 10Strong✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: Documented → Verified → Prevented · effective 7.4 / 10 · rule-coverage 100% · ceiling Prevented

24 god class(es) detected.

MethodTooLong: SimpleDownloadManager.DownloadStreamAsync · ×12src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:142
FileTooLong: Resource/StaticText.cs · ×6src/N_m3u8DL-RE.Common/Resource/StaticText.cs
ClassTooLong: StaticText · ×5src/N_m3u8DL-RE.Common/Resource/StaticText.cs
TooManyMethods: CommandInvokersrc/N_m3u8DL-RE/CommandLine/CommandInvoker.cs

What to do

  1. Resolve the 12 MethodTooLong finding(s) in God Classes — start with SimpleDownloadManager.cs (2), SimpleLiveRecordManager2.cs (2), DASHExtractor2.cs. — One of this dimension's main actionable groups (12 warning-level).
  2. Resolve the 6 FileTooLong finding(s) in God Classes — start with StaticText.cs, SimpleLiveRecordManager2.cs, SimpleDownloadManager.cs. — One of this dimension's main actionable groups (6 warning-level).
  3. Resolve the 5 ClassTooLong finding(s) in God Classes — start with StaticText.cs, SimpleDownloadManager.cs, SimpleLiveRecordManager2.cs. — One of this dimension's main actionable groups (5 warning-level).

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

D4 · Code Duplication9.2 / 10Stronggated by 50 serious findings✓ Tool-verified

What it measures: Copy-pasted code that should be shared instead.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.2 / 10 · rule-coverage 100% · ceiling Verified

38 duplicated block group(s) detected. A further 12 rows report members as variants of one another; they aggregate block groups already counted above and are not themselves counted.

Duplicated block (6 lines × 2) · ×6src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:766
Duplicated block (5 lines × 2) · ×4src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:447
Duplicated block (12 lines × 2) · ×3src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:828
Duplicated block (11 lines × 2) · ×3src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:1098
Duplicated block (9 lines × 2) · ×3src/N_m3u8DL-RE.Common/Util/HTTPUtil.cs:89

+ 25 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 6 Duplicated block (6 lines × 2) finding(s) in Code Duplication — start with SimpleDownloadManager.cs (2), SimpleLiveRecordManager2.cs (2), LargeSingleFileSplitUtil.cs. — One of this dimension's main actionable groups (6 warning-level).
  2. Resolve the 4 Duplicated block (5 lines × 2) finding(s) in Code Duplication — start with SimpleDownloadManager.cs, REDACTED, MSSMoovProcessor.cs. — One of this dimension's main actionable groups (4 warning-level).
  3. Resolve the 3 Duplicated block (12 lines × 2) finding(s) in Code Duplication — start with DASHExtractor2.cs (2), ImageHeaderUtil.cs. — One of this dimension's main actionable groups (3 warning-level).

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

D5 · Coupling10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.

Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.

Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

4 projects, 0 dependency cycle(s), 0 unstable depended-on project(s).

Off the main sequence: N_m3u8DL-RE.Commonsrc/N_m3u8DL-RE.Common/N_m3u8DL-RE.Common.csproj:1

✓ On the Gold path — maintain.

Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.

D6 · Cohesion (LCOM4)10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 25 classes have LCOM4 above 3.

✓ On the Gold path — maintain.

Detailed fixes: d6_recommendation.md.

D10 · Test Quality10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the tests truly assert behaviour rather than just running the code.

Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

0 skipped, 0 zero-assertion, no mocking-framework packages referenced (hand-written doubles or no mocking) across 464 tests.

✓ On the Gold path — maintain.

Detailed fixes: d10_recommendation.md.

D11 · Test Reliability10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the tests pass reliably, with no flakiness.

Method: Suite re-run N times within tiered wall-clock budgets (unit to e2e); tests failing non-deterministically across runs flagged; guarded tests retried when #if guards detected.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 flaky across 1 measured tier(s). unit: measured (0 flaky).

✓ On the Gold path — maintain.

Detailed fixes: d11_recommendation.md.

D13 · REDACTED Scanning10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

REDACTED scan ran and found no leaked secrets.

✓ On the Gold path — maintain.

Detailed fixes: d13_recommendation.md.

D14 · License Compliance10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the licenses of third-party packages are compatible with your policy.

Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 121 packages use a banned license. ★ DEPTH: this repository's MSBuild projects declare 7 direct `PackageReference`(s), and 114 further package(s) were reached beyond them by closing the graph over nuget.org's own nuspec dependency graph — so a banned licence pulled in only by a dependency's OWN dependencies is inside this verdict. A package whose licence nuget.org could not be asked for is not graded, and version ranges are taken at their lower bound, so this is the closure as that graph states it rather than a restored consumer's exact resolution.

✓ On the Gold path — maintain.

Detailed fixes: d14_recommendation.md.

D15 · Churn × Complexity Hotspots6.7 / 10Adequate✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: Documented → Verified → Prevented · effective 6.7 / 10 · rule-coverage 100% · ceiling Documented

Top hotspots: src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs (14×209=2926); src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs (18×150=2700); REDACTED (17×111=1887)

Hotspot: src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs · ×25src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:142

What to do

  1. Resolve the 25 Hotspot finding(s) in Churn × Complexity Hotspots — start with SimpleDownloadManager.cs, SimpleLiveRecordManager2.cs, REDACTED. — One of this dimension's main actionable groups (25 warning-level).

Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.

D17 · Explicit Debt8.7 / 10Adequategated by 14 critical findings✓ Tool-verified

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: Documented → Verified → Prevented · effective 8.7 / 10 · rule-coverage 100% · ceiling Prevented

21 deducted debt markers + 2 dead symbols across 23053 LoC in the .NET projects (0.7/KLoC) → score 8.7.

EmptyCatchBlock · ×10src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:114
WriteOnlyPrivateField · ×4src/N_m3u8DL-RE.Parser/Mp4/MP4InitUtil.cs:16
CommentedOutCode · ×5src/N_m3u8DL-RE.Parser/Mp4/MSSMoovProcessor.cs:637
Dead code: GetWebSourceAsync · ×2src/N_m3u8DL-RE.Common/Util/HTTPUtil.cs:152
ObsoleteWithCallerssrc/N_m3u8DL-RE/CommandLine/MyOption.cs:163

+ 1 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 10 EmptyCatchBlock finding(s) in Explicit Debt — start with REDACTED (2), DASHExtractor2.cs, CommandInvoker.cs. — One of this dimension's main actionable groups (10 issue-level).
  2. Resolve the 4 WriteOnlyPrivateField finding(s) in Explicit Debt — start with HTTPLiveRecordManager.cs (3), MP4InitUtil.cs. — One of this dimension's main actionable groups (4 issue-level).
  3. Resolve the 5 CommentedOutCode finding(s) in Explicit Debt — start with SimpleLiveRecordManager2.cs (3), MSSMoovProcessor.cs, SimpleDownloadManager.cs. — One of this dimension's main actionable groups (5 warning-level).

Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.

D18 · Solution Shape10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the solution is laid out in a sensible, conventional structure.

Method: Solution structure: project count, decomposition, shell-project detection, build success (confirmed failures cap the score); traced to actual .sln files and binaries. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

4 projects, 238 source files, 36798 hand-written lines of code (23053 production / 13745 test — the split is derived per file: test is what its project, its own path, or a compile-guarded region marks as test, and a file carrying no test signal counts as production), 4 inter-project edges.

✓ On the Gold path — maintain.

Detailed fixes: d18_recommendation.md.

D19 · Documentation Quality10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the project's documentation is clear, complete, and useful.

Method: Every README, docs/ document and root guide parsed by its markup and measured in Unicode letters. Published: a runnable or packaged .NET project whose README (or a document it links, or a root guide) shows no example, and a root README naming none of three or more projects. Overview, licence, boilerplate, wall-of-text, empty-section and XML-doc rows are measured and withheld (counted in gaps) after adjudication. Deterministic, exhaustive, advisory.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

2 of 2 documentation facets pass in full. 2 document(s) read across 4 unit(s).

✓ On the Gold path — maintain.

Detailed fixes: d19_recommendation.md.

D20 · ADR Quality0.0 / 10Critical✓ Tool-verified

What it measures: Whether architecture decisions are recorded well (context, decision, consequences).

Method: Every ADR read by its section structure: nine located rules (a missing Decision, Context or Consequences section, a stale status, two records deciding the same question, a dangling supersede link, a number-only title, a single option, no named cost, no status where the log uses one, no enforcement field where the log adopted one), each a fixed deduction from 10; the score is the mean over evaluated records. Deterministic, no model. Advisory.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

No architecture decision records were found.

No ADRs found

What to do

  1. Resolve the 1 No ADRs found finding(s) in ADR Quality. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d20_recommendation.md · top locations in Appendix A, every location in findings.md.

D21 · Naming Consistency7.8 / 10Strong✓ Tool-verified

What it measures: Whether names — types, methods, variables — are clear and consistent.

Method: Seven vocabulary-free rules (N1-N7) mine each naming convention from the repository and flag a name that breaks a convention its structural peers in the same unit follow; production C# and TypeScript, each its own population. Deterministic, no model, no sample. Advisory.

Maturity: Documented → Verified → Prevented · effective 7.8 / 10 · rule-coverage 100% · ceiling Verified

3 naming inconsistencies among 136 declarations measured against a convention their peers follow.

`RefreshUrlFromMaster` returns an awaitable but lacks the `Async` suffix its 13 peers carrysrc/N_m3u8DL-RE.Parser/Extractor/HLSExtractor.cs:617
`CombineURL` spells `URL` where 39 names in the project spell it `Url`src/N_m3u8DL-RE.Parser/Util/ParserUtil.cs:107
`InvokeArgs` returns an awaitable but lacks the `Async` suffix its 93 peers carrysrc/N_m3u8DL-RE/CommandLine/CommandInvoker.cs:891

What to do

  1. Resolve the 1 `RefreshUrlFromMaster` returns an awaitable but lacks the `Async` suffix… finding(s) in Naming Consistency — start with HLSExtractor.cs. — One of this dimension's main actionable groups (1 recommendation-level).
  2. Resolve the 1 `CombineURL` spells `URL` where 39 names in the project spell it `Url` finding(s) in Naming Consistency — start with ParserUtil.cs. — One of this dimension's main actionable groups (1 recommendation-level).
  3. Resolve the 1 `InvokeArgs` returns an awaitable but lacks the `Async` suffix its 93… finding(s) in Naming Consistency — start with CommandInvoker.cs. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d21_recommendation.md · top locations in Appendix A, every location in findings.md.

D24 · Comment Value7.6 1.4 / 10Critical✓ Tool-verified

What it measures: Whether comments are worth it — explaining WHY (valuable) rather than WHAT (redundant).

Method: Every inline C# comment compared word by word with the identifiers, literals and constructs of the code it annotates (taken from the syntax); a comment whose words that code already contains is redundant, as are closing-brace labels and generator template text. Comments giving a reason or a reference are kept; other scripts and languages are not judged. Deterministic, exhaustive, advisory.

Maturity: Documented → Verified → Prevented · effective 1.4 / 10 · rule-coverage 18% · ceiling Documented

3 of 123 judged comments only repeat the code they sit on (2.4 %). 1137 comment(s) in another language or script were not judged.

redundant comment · ×3src/N_m3u8DL-RE.Parser/Mp4/MP4VttUtil.cs:128
doc comments repeat the namessrc/N_m3u8DL-RE/Crypto/CSChaCha20.cs:572

What to do

  1. Resolve the 3 redundant comment finding(s) in Comment Value — start with MSSMoovProcessor.cs (2), MP4VttUtil.cs. — One of this dimension's main actionable groups (3 recommendation-level).

Detailed fixes: d24_recommendation.md · top locations in Appendix A, every location in findings.md.

D26 · Project Cohesion10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether each project is a focused, coherent unit rather than an oversized grab-bag.

Method: Project size overshoot penalties (LoC / public-type count / namespace count, 2-of-3 flag) weighted by log magnitude. Exhaustive across projects, deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 of 4 projects flagged as possibly oversized/incoherent.

✓ On the Gold path — maintain.

Detailed fixes: d26_recommendation.md.

D27 · Navigability7.8 / 10Strong✓ Tool-verified

What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.

Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps. C# also names each pass-through layer (a class whose every public method only forwards its own parameters to one collaborator) as a located finding; the score is not affected.

Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.

Maturity: Documented → Verified → Prevented · effective 7.8 / 10 · rule-coverage 100% · ceiling Documented

86 % of calls cross a namespace and 1 % go through an interface, but 76 % of collaborators are co-located — so following a call takes several hops. Baseline: medium — clean/modular boundaries expected.

Detailed fixes: d27_recommendation.md.

D28 · Secrets (history)8.0 / 10Adequategated by 2 critical findings✓ Tool-verified

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: REDACTED scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.

Maturity: Documented → Verified → Prevented · effective 8.0 / 10 · rule-coverage 100% · ceiling Documented

2 finding(s): 0 critical, 2 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.

REDACTED
REDACTED

What to do

  1. Resolve the 2 REDACTED finding(s) in Secrets (history) — start with REDACTED, REDACTED. — One of this dimension's main actionable groups (2 issue-level).
  2. Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.

D29 · Static Analysis (SAST)0.3 / 10Critical✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: Documented → Verified → Prevented · effective 0.3 / 10 · rule-coverage 100% · ceiling Documented

45 finding(s): 0 critical, 39 high, 6 medium, 0 low. 21 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. semgrep hit a parse error in 33 file(s) — `src/N_m3u8DL-RE.Common/Entity/WebSourceResult.cs` (line 6), `src/N_m3u8DL-RE.Common/Log/CustomAnsiConsole.cs` (line 7), `src/N_m3u8DL-RE.Common/Log/Logger.cs` (line 95, line 97, line 99, …), `src/N_m3u8DL-RE.Common/Util/CookieFileHandler.cs` (line 5), `src/N_m3u8DL-RE.Common/Util/CookieFileJar.cs` (line 17), … (+28 more) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. In 26 of those file(s) — `src/N_m3u8DL-RE.Common/Entity/WebSourceResult.cs`, `src/N_m3u8DL-RE.Common/Log/CustomAnsiConsole.cs`, `src/N_m3u8DL-RE.Common/Log/Logger.cs`, `src/N_m3u8DL-RE.Common/Util/CookieFileHandler.cs`, `src/N_m3u8DL-RE.Common/Util/CookieFileJar.cs`, … (+21 more) — the break is a C# primary constructor, which semgrep's grammar cannot parse and which hides the type from every rule scoped to it; those files were re-scanned from a shadow copy with the constructor's parameter list blanked (line and column preserving), which restores the type to the rules, and 0 additional row(s) came from that pass. Only the header's own parameter list is unread in them. In 2 of those file(s) — `src/N_m3u8DL-RE.Tests/DownloadManager/LiveSingleInitTests.cs`, `src/N_m3u8DL-RE/Util/VodPartSelector.cs` — the break is at a TYPE DECLARATION (a C# primary constructor semgrep's grammar cannot parse), so the loss is wider than the named lines: rules scoped to that type see no type to scope to and are blind over its whole body, while rules matching statements keep working there. Absence of a type-scoped finding in those types is not evidence of anything. Separately, one or more rules could not re-parse an embedded snippet in 1 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

+ 3 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 10 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (4), REDACTED (4), REDACTED (2). — One of this dimension's main actionable groups (10 issue-level).
  2. Resolve the 6 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (6). — One of this dimension's main actionable groups (6 issue-level).
  3. No action in Static Analysis (SAST) — all 21 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (21 issue-level, 0 of them charged here).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

D30 · Dependency Vulnerabilities9.4 / 10Adequategated by 1 critical finding✓ Tool-verified

What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.

Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05. Advisory since rubric-2026.11.2 (CAI decision 0006): every row is a match against a vulnerability database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.

Maturity: Documented → Verified → Prevented · effective 9.4 / 10 · rule-coverage 100% · ceiling Documented

1 finding(s): 0 critical, 1 high, 0 medium, 0 low.

REDACTED

What to do

  1. Resolve the 1 High CVE finding(s) in Dependency Vulnerabilities. — One of this dimension's main actionable groups (1 issue-level).

Detailed fixes: d30_recommendation.md · top locations in Appendix A, every location in findings.md.

D34 · Knowledge Freshness10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.

Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

Every significant source file has living knowledge — recently and meaningfully worked. Counted over 67 of the 136 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.

✓ On the Gold path — maintain.

Detailed fixes: d34_recommendation.md.

D35 · Change Coupling9.5 / 10Adequategated by 3 critical findings✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.

Maturity: Documented → Verified → Prevented · effective 9.5 / 10 · rule-coverage 100% · ceiling Documented

Strongest change-coupling: ResString.cs↔MyOption.cs 81%; StaticText.cs↔MyOption.cs 81%; HTTPLiveRecordManager.cs↔SimpleLiveRecordManager2.cs 64%

Boundary-crossing change coupling: ResString.cs ↔ MyOption.cs · ×3src/N_m3u8DL-RE.Common/Resource/ResString.cs:1
Change coupling: HTTPLiveRecordManager.cs ↔ SimpleLiveRecordManager2.cssrc/N_m3u8DL-RE/DownloadManager/HTTPLiveRecordManager.cs:1

What to do

  1. Resolve the 3 Boundary-crossing change coupling finding(s) in Change Coupling — start with ResString.cs, StaticText.cs, HTTPUtil.cs. — One of this dimension's main actionable groups (3 issue-level).
  2. Resolve the 1 Change coupling finding(s) in Change Coupling — start with HTTPLiveRecordManager.cs. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.

D36 · Supply-chain Provenance & Signing0.0 / 10Critical✓ Tool-verified

What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.

Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

0/4 supply-chain integrity signals present (provenance, signing, SBOM, pinned actions).

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

+ 3 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
  2. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).
  3. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.

D43 · Malicious Dependencies10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Reported apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.

Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. Advisory since rubric-2026.11.2 (CAI decision 0006): the malicious-package feed is a database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No dependency in any ecosystem this repository declares is published as malicious.

✓ On the Gold path — maintain.

Detailed fixes: d43_recommendation.md.

D44 · Platform End-of-Life10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.

Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 4 platform declaration(s) and 0 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.

✓ On the Gold path — maintain.

Detailed fixes: d44_recommendation.md.

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AX10 · Code composition9.9 / 10Exemplary✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

What to do

  • The domain core is a small share of production code, but most of the rest matched no layer vocabulary at all — so this is not yet an anemic-domain finding. The namespace/path convention could not place that code, which makes the composition above a statement about the naming, not about the design. Name the layers (or check that the repository's conventions differ from the ones this check knows) before reading a thin domain into it.
AX2 · Stateful singletons1.0 / 10Critical✓ Tool-verified

Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.

Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.

  • `CommandInvoker` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (Descriptions; e.g. `Descriptions` at line 780). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — src/N_m3u8DL-RE/CommandLine/CommandInvoker.cs:19
  • `CustomAnsiConsole` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (Console; e.g. `Console` at line 92). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — src/N_m3u8DL-RE.Common/Log/CustomAnsiConsole.cs:76
  • `Logger` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (LogFilePath; e.g. `LogFilePath` at line 47). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — src/N_m3u8DL-RE.Common/Log/Logger.cs:8

What to do

  • A `static` field is one slot for the whole process, however its type is created: back it with a thread-safe type (ConcurrentDictionary, Interlocked), take a lock around every write, or move it into a registered singleton that does.
AX3 · Project dependency cycles10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).

Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.

  • The namespaces N_m3u8DL_RE.Parser.Config ↔ N_m3u8DL_RE.Parser.Processor depend on each other. The lightest dependency in the cycle is N_m3u8DL_RE.Parser.Config → N_m3u8DL_RE.Parser.Processor (N_m3u8DL_RE.Parser.Config.ParserConfig → N_m3u8DL_RE.Parser.Processor.ContentProcessor, 3 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/N_m3u8DL-RE.Parser/Config/ParserConfig.cs:2

What to do

  • Break namespace cycles inside a project by moving the shared type to a namespace both sides can use, or by inverting the back edge behind an interface.
AX4 · Dependency direction10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.

Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.

AX5 · Architecture & structure3.0 / 10Weak✓ Tool-verified

Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.

Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.

  • ~23.1k production LoC (363 types) across 3 project(s) / 30 namespace(s) with no recognised architectural style or layering — at this size, deliberate module boundaries would help. No DDD/clean/vertical-slice/CQRS/transaction-script organisation was detected — code is likely organised ad hoc, which makes change and onboarding harder as it grows.

What to do

  • Introduce deliberate module boundaries — by feature (vertical slices) if your team prefers, or by layer (domain/application/infrastructure). Even splitting into a few cohesive projects with a clear dependency direction would help.
AX6 · Interface segregation10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').

Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.

AX8 · Test isolation10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether production projects stay free of references to test projects — tests may depend on production, never the reverse.

Method: Csproj graph: each production project checked for references to test projects (identified by test-framework presence, not name). Zero violations is clean. Deterministic.

C2 · Access Controls0.0 / 10Critical✓ Tool-verified

Other · Security — Whether access is authorized by default — a framework authorization attribute/decorator or policy, or imperative guard methods (throw-on-violation) called from handlers.

Method: Roslyn scan: [Authorize] usage and authorization policies, plus imperative throw-on-violation guard methods detected via syntax. Deterministic.

  • No [Authorize]/policies and no imperative guard methods (throw-on-violation) were found — endpoints may be unprotected.

What to do

  • Protect endpoints by default-deny: [Authorize] + role/policy authorization, or imperative guard methods (throw-on-violation) called from every handler.
GD1 · Unfinished & placeholder code10.0 / 10Exemplary✓ Tool-verified

Other · Code Health — Unreviewed-generation residue: shipped members still throwing NotImplementedException, and placeholder string literals left in non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.

Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.

  • A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface. (×4) — src/N_m3u8DL-RE.Parser/Extractor/LiveTSExtractor.cs:33, src/N_m3u8DL-RE.Parser/Extractor/LiveTSExtractor.cs:38, src/N_m3u8DL-RE.Parser/Extractor/LiveTSExtractor.cs:43, …

What to do

  • Finish or delete NotImplementedException stubs and replace placeholder literals before shipping.
IC1 · Incompleteness & stubs7.4 / 10Strong✓ Tool-verified

Other · Code Health — Unfinished work detected by code SHAPE, not keywords: members that only throw a "not implemented" exception, methods that take inputs and return a constant, async methods that never await, dead `if (false)` / `#if false` branches, and skeleton types most of whose members are holes. A real, objective slice of technical debt.

Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.

  • The first 2 statements of the `if` and of the `else` are identical, so they run on both paths regardless of the condition. Lift them above the `if` — leaving them duplicated inside makes the branches read as though they handled this differently. — src/N_m3u8DL-RE.Common/Log/CustomAnsiConsole.cs:82
  • `LiveTSExtractor` has 4 unfinished members out of 7 declared members (methods, properties, indexers and events, whether or not each carries a body) — a scaffolded type that was never implemented. — src/N_m3u8DL-RE.Parser/Extractor/LiveTSExtractor.cs:8
  • `FetchPlayListAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/N_m3u8DL-RE.Parser/Extractor/LiveTSExtractor.cs:33
  • `PreProcessContent` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/N_m3u8DL-RE.Parser/Extractor/LiveTSExtractor.cs:38
  • `PreProcessUrl` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/N_m3u8DL-RE.Parser/Extractor/LiveTSExtractor.cs:43
  • `RefreshPlayListAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/N_m3u8DL-RE.Parser/Extractor/LiveTSExtractor.cs:48
  • A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers). (×24) — src/N_m3u8DL-RE.Parser/Extractor/HLSExtractor.cs:588, src/N_m3u8DL-RE.Parser/Mp4/MP4InitUtil.cs:72, src/N_m3u8DL-RE.Parser/Mp4/MP4Parser.cs:114, …
  • 16 consecutive lines of code sit inside a `/* … */` block — a block of code switched off rather than removed, which rots and confuses. Delete it (version control remembers). — src/N_m3u8DL-RE.Parser/Mp4/MSSMoovProcessor.cs:637
  • 6 consecutive lines of code sit inside a `/* … */` block — a block of code switched off rather than removed, which rots and confuses. Delete it (version control remembers). (×2) — src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:740, src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:1184

What to do

  • Finish or delete the unfinished stubs (NotImplementedException / empty / constant-returning bodies) — they are dead surface that looks live.
  • Clear the softer debt: remove commented-out code and dead branches, re-enable or delete skipped tests, and replace blanket warning suppressions with targeted ones.
M1 · Documentation (README)6.7 / 10Strong✓ Tool-verified

Maturity · Maturity — Whether the repository and its projects have a README, and whether it is substantive.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

What to do

  • Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
  • Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
  • Describe the projects a newcomer cannot place from the root README: 3 of 3 have no README of their own, in their folder or in their family's project (`src/N_m3u8DL-RE`, `src/N_m3u8DL-RE.Common`, `src/N_m3u8DL-RE.Parser`).
M2 · Architecture documentation0.0 / 10Critical✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

  • No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
  • No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.

What to do

  • Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
  • Add a C4 context/container diagram (Structurizr, PlantUML or Mermaid) or an architecture.md overview.
M3 · Folder & project structure10.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether the repository is organised deliberately: production code and tests are set apart in a way its ecosystem or the repository itself declares.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

M4 · Documentation accuracy10.0 / 10Exemplary○ Nothing flagged

Maturity · Maturity — Whether the project's current-state documentation describes the code that exists.

Method: Every current-state document's checkable claims looked up in the tree (links, versions, and artefact counts an order of magnitude off), plus two README checks: an advertised infrastructure product with no footprint, and a module the CHANGELOG records as removed. Deterministic, no model. Advisory.

P1 · CI/CD gates8.5 / 10Exemplary✓ Tool-verified

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

What to do

  • Run the test suite in CI via an explicit runner step (`dotnet test` for the toolchain this pipeline already uses) and gate merges on it.
P2 · Observability7.0 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.

Method: Filesystem/Roslyn scan: structured-logging frameworks (Serilog, NLog), OpenTelemetry, and health-check endpoint patterns. Exhaustive, deterministic.

What to do

  • Consider OpenTelemetry tracing/metrics and a health-check endpoint for operability.
P3 · Security & performance tooling0.0 / 10Critical✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

  • No static application security testing detected. For this repository's stack, add CodeQL's csharp pack, or a .NET security analyzer package (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 1 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
  • `src/N_m3u8DL-RE.Common/N_m3u8DL-RE.Common.csproj` declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices — including after an advisory is published against it. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per ecosystem the tree uses (or an enabled `renovate.json`), and gate pull requests with `actions/dependency-review-action`. — src/N_m3u8DL-RE.Common/N_m3u8DL-RE.Common.csproj:13

What to do

  • Add a SAST step to CI running what this repository's stack ships: CodeQL's csharp pack, or a .NET security analyzer package — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
  • Enable Dependabot/Renovate or a dependency-review gate.
  • Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
P4 · Deployment & Rollback7.0 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.

Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.

P6 · Release Hygiene5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.

Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.

  • No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)

What to do

  • Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.
PF3 · Async & latency hygiene6.0 / 10Adequate✓ Tool-verified

Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.

Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from each language's code model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.

  • 12 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). (×12) — src/N_m3u8DL-RE/Util/ConcatInputServer.cs:240, src/N_m3u8DL-RE/Util/MediaProcessingProgress.cs:116, REDACTED:24, …

What to do

  • Make the call chain async end-to-end and await it — never block on a Task with .Wait()/.GetAwaiter().GetResult().
S1 · Web-Security Posture2.0 / 10Critical✓ Tool-verified

Other · Security — Transport security, security headers, secure cookies, input validation, middleware order and crypto hygiene (presence, not runtime).

Method: Roslyn plus filesystem scan: HSTS/security headers, secure cookies, input validation, middleware order, weak crypto (MD5/SHA1/DES); HTTPS-metadata context-aware. On a repository with no .NET source it reads JavaScript/TypeScript, Dart, Ruby, Scala, Rust or Elixir source itself (test, vendored, generated and minified paths not) for the arms that hold whether or not the code serves HTTP: a weak hash or cipher, key material fixed in the source, a TLS client that accepts any certificate, and (JavaScript/TypeScript, Ruby, Scala, Rust and Elixir) an obsolete TLS version; the server controls are not assessed there, and a Dart, Ruby, Scala, Rust or Elixir repository that serves no HTTP of its own is N/A on them. Deterministic.

  • `RemoteCertificateValidationCallback` is assigned a callback that returns `true` unconditionally, so every TLS peer certificate is accepted — including one an attacker presents. Chain, expiry, revocation and hostname are all skipped, so an attacker on the network path can present any certificate and read or rewrite the traffic — the connection is encrypted to the attacker, not to the intended host. Delete the override and let the platform validate. If a specific self-signed or internally-issued certificate genuinely has to be trusted, pin THAT one — compare the presented certificate's public key or thumbprint against the expected value and return `false` for everything else — and scope it to the single handler that talks to that host rather than to the whole process. If the override exists only to get past a development certificate, gate it on a build configuration or an explicit opt-in setting so it cannot ship. — src/N_m3u8DL-RE.Common/Util/HTTPUtil.cs:19
  • None of the 11 security response headers the OWASP Secure Headers Project recommends (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options, …) is configured — defense in depth, even when a reverse proxy could set them. (−2.0 on this card.)
  • No UseHttpsRedirection/UseHsts and no reverse-proxy signal — transport security is unverified at the app layer. (−2.0 on this card.)

What to do

  • Stop accepting every TLS certificate: remove the always-true validation callback so the platform verifies the chain, hostname and expiry. If one self-signed certificate must be trusted, pin it by public key or thumbprint on the single handler that needs it and reject all others — never process-wide.
  • Add security response headers (Content-Security-Policy first, then Strict-Transport-Security, X-Content-Type-Options and a frame policy) — defense in depth, even when a reverse proxy could set them.
  • Enforce HTTPS at the app layer (UseHttpsRedirection / UseHsts) — only skip this if a reverse proxy demonstrably terminates TLS.
X1 · Async correctness5.2 / 10Adequate✓ Tool-verified

Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.

Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.

  • `Thread.Sleep` parks the thread for the whole delay: no other work runs on it, and under load the pool must grow to make up for it. `await Task.Delay(…)` suspends only this method. — src/N_m3u8DL-RE/CommandLine/CommandInvoker.cs:954
  • `File.ReadAllBytes` blocks the thread on I/O while `File.ReadAllBytesAsync` exists to wait without one — inside a method that is already `async`, await the twin. (×6) — src/N_m3u8DL-RE/Downloader/SimpleDownloader.cs:55, src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:369, src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:617, …
  • `File.ReadAllText` blocks the thread on I/O while `File.ReadAllTextAsync` exists to wait without one — inside a method that is already `async`, await the twin. — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:564
  • `PipeUtil.CreatePipe` is a synchronous helper that blocks (`Thread.Sleep`): called from an `async` method it parks the thread exactly as the inline call would. Make the helper `async` and `await` it (`await Task.Delay`, `SemaphoreSlim.WaitAsync`, a `TaskCompletionSource` instead of the poll). — src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:788
  • Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback. (×2) — src/N_m3u8DL-RE/Util/ConcatInputServer.cs:240, src/N_m3u8DL-RE/Util/MediaProcessingProgress.cs:116
  • Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process. (×9) — REDACTED:24, REDACTED:64, REDACTED:190, …

What to do

  • Blocking `Thread.Sleep` inside an `async` method
X12 · Unreachable branch10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.

Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.

X13 · Undrained process stream5.4 / 10Adequate✓ Tool-verified

Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.

Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.

  • `RedirectStandardOutput` is set here, but `StandardOutput` is not being read when the code waits for the child to exit — it is never read, read only later, or read only in part. The child blocks as soon as it fills the StandardOutput pipe (~4 KB, never more than 64 KB), so it never finishes and never exits, and the read or wait above never returns: a `WaitForExit` timeout after a read does not help: the timeout bounds the WAIT, not the read that precedes it. Drain every redirected stream before blocking on the child — read one on a background thread (`BeginOutputReadLine()` with its `DataReceived` handler, or a `Task` running `ReadToEndAsync()` started before the other read and awaited after it) — or stop redirecting the stream you do not consume. — REDACTED:20

What to do

  • Each finding names the span that makes the branch dead and the span it is dead because of. Confirm from the two, then delete the dead arm or fix the predicate that was meant to be reachable.
X14 · Bypassable address classification10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a hand-rolled public/private IP check can be walked past — a method that unwraps IPv4-mapped IPv6 but returns the opposite verdict for the same host written as IPv4-compatible, 6to4 or NAT64.

Method: Roslyn syntax + semantics: methods that unwrap IPv4-mapped IPv6 and hand-roll IPv4 range carve-outs, checked for whether the IPv6 branch also accounts for the IPv4-compatible, 6to4 and NAT64 embeddings. Deterministic, provable per finding. Advisory.

X16 · Unfloored truncation loop10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.

Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.

X18 · Disposal-pattern correctness4.5 / 10Weak✓ Tool-verified

Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.

Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.

  • `dcpt` is a `Aes`, which implements `IDisposable`, and it is created here (line 26). Every use of it in `AES128Decrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var dcpt = …;`), which releases it at the end of the scope on every path including a throw. — src/N_m3u8DL-RE/Crypto/AESUtil.cs:26
  • `cTransform` is a `ICryptoTransform`, which implements `IDisposable`, and it is created here (line 34). Every use of it in `AES128Decrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var cTransform = …;`), which releases it at the end of the scope on every path including a throw. — src/N_m3u8DL-RE/Crypto/AESUtil.cs:34
  • `forDecrypting` is a `ChaCha20`, which implements `IDisposable`, and it is created here (line 25). Every use of it in `DecryptPer1024Bytes` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var forDecrypting = …;`), which releases it at the end of the scope on every path including a throw. — src/N_m3u8DL-RE/Crypto/ChaCha20Util.cs:25
  • `ChaCha20` declares a finalizer (line 522), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization. — src/N_m3u8DL-RE/Crypto/CSChaCha20.cs:522
  • `CancellationTokenSource` (line 59) holds a `CancellationTokenSource` that `SimpleLiveRecordManager2` creates itself with `new`, and nothing in `SimpleLiveRecordManager2` ever releases it: the type is not `IDisposable`, declares no `Dispose`, and every other mention of `CancellationTokenSource` only reads through it. And `SimpleLiveRecordManager2` is not a process-lifetime owner: `new SimpleLiveRecordManager2(downloadConfig, selectedStreams, extractor)` (REDACTED line 545) creates one per call and drops it when the call returns, so each call strands one unreleased `CancellationTokenSource` (a timer that keeps firing, a handle, a socket) until finalization. Implement `IDisposable`, release `CancellationTokenSource` there and dispose the owner at that call site — or keep one owner for the process instead of one per call. — src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:59
  • `DownloadCancellationTokenSource` (line 60) holds a `CancellationTokenSource` that `SimpleLiveRecordManager2` creates itself with `new`, and nothing in `SimpleLiveRecordManager2` ever releases it: the type is not `IDisposable`, declares no `Dispose`, and every other mention of `DownloadCancellationTokenSource` only reads through it. And `SimpleLiveRecordManager2` is not a process-lifetime owner: `new SimpleLiveRecordManager2(downloadConfig, selectedStreams, extractor)` (REDACTED line 545) creates one per call and drops it when the call returns, so each call strands one unreleased `CancellationTokenSource` (a timer that keeps firing, a handle, a socket) until finalization. Implement `IDisposable`, release `DownloadCancellationTokenSource` there and dispose the owner at that call site — or keep one owner for the process instead of one per call. — src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:60
  • `stream` is a `FileStream`, which implements `IDisposable`, and it is created here (line 91). Every use of it in `Read` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var stream = …;`), which releases it at the end of the scope on every path including a throw. — src/N_m3u8DL-RE/Util/ConcatInputStream.cs:91
  • `stream` is a `FileStream`, which implements `IDisposable`, and it is created here (line 109). Every use of it in `ReadAsync` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var stream = …;`), which releases it at the end of the scope on every path including a throw. — src/N_m3u8DL-RE/Util/ConcatInputStream.cs:109
  • `reader` is a `BinaryReader2`, which implements `IDisposable`, and it is created here (line 116). Every use of it in `ExtractSub` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var reader = …;`), which releases it at the end of the scope on every path including a throw. — src/N_m3u8DL-RE.Parser/Mp4/MP4VttUtil.cs:116

What to do

  • Each finding names the value and the span that decides who owns it — the `new` that created it, or the constructor parameter that handed it over. Confirm ownership from that span, then make the disposal match it: release what this type created, leave what it was injected with to whoever created THAT, and drop a finalizer whose type holds nothing unmanaged to release.
X19 · Unrestored process-global state10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.

Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.

X2 · Cancellation propagation6.5 / 10Adequate✓ Tool-verified

Other · Code Health — Whether async methods accept a CancellationToken so work can be cancelled (adoption curve).

Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.

  • Only 47/114 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
  • No CancellationToken parameter — this work can't be stopped early once started. (×24) — src/N_m3u8DL-RE/CommandLine/CommandInvoker.cs:891, src/N_m3u8DL-RE/Crypto/CSChaCha20.cs:215, src/N_m3u8DL-RE/Crypto/CSChaCha20.cs:307, …
  • No CancellationToken parameter — the body observes an ambient token instead (a field or a context object), so the work does stop on cancellation, but a caller cannot cancel this call independently of the owner that created that token. (×12) — src/N_m3u8DL-RE/DownloadManager/HTTPLiveRecordManager.cs:60, src/N_m3u8DL-RE/DownloadManager/LiveSegmentDownloadQueue.cs:62, src/N_m3u8DL-RE/DownloadManager/LiveSegmentDownloadQueue.cs:76, …
  • Neither takes a CancellationToken nor reads the one of the function it sits in, while it calls something that takes one — this work can't be stopped early once started. Take the token, or pass on the enclosing one. (×3) — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:962, src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:984, src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:1006

What to do

  • Thread a CancellationToken through async methods so work stops promptly on cancellation.
X20 · Mistyped argument guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `ArgumentNullException` tells the caller a parameter was null when it provably was not.

Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements controlled by an `if`, whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`). Deterministic, provable per finding. Advisory.

X21 · Side-effecting pattern guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.

Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.

X22 · Contradicted release guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back. Also whether a `finally` that gives the primitive back unconditionally can run in a state where the method does not hold it: after a timed wait whose result was discarded, after an acquire inside the `try` that can fail, after the body already released it, or never, because a `return` left between the acquire and the `try`.

Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.

X23 · Unguarded diagnostic materialisation6.4 / 10Adequate✓ Tool-verified

Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.

Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.

  • `Debug` at line 614 is called with an argument built by `string.Join(" ", arguments.Select(argument => $"\"{argument}\""))` (line 614), whose cost grows with the collection it walks. C# evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because Debug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: no `IsEnabled` test, no debug flag, no conditional-compilation region. — REDACTED:614

What to do

  • Each finding names the diagnostic call and the expression inside its argument whose cost scales with a collection. Confirm from the two that the argument is built before the call — that is C#'s evaluation order, not a guess — then put the construction behind the same level check the sink applies: `if (logger.IsEnabled(LogLevel.Trace))` for Microsoft.Extensions.Logging, the repository's own debug flag where it has one, or a message template whose ARGUMENTS the logging framework only formats when the level is on. Moving the call is not the fix: it is the join/projection in the argument that is paid, wherever the call sits.
X24 · Document value interpolated into markup unescaped10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether text read out of the document being converted is escaped before it is written into generated markup — a value the document's author chose, interpolated into an attribute the surrounding literal delimits, can close that attribute and open another.

Method: Roslyn semantic model over the whole compilation: a string-typed `Value`/`InnerText`/`InnerXml`/`Text` member declared inside `DocumentFormat.OpenXml` or `System.Xml` is a taint SOURCE, propagated through assignments, returns, arguments, tuple elements and string composition to its transitive closure, then read at interpolated-string holes that sit in a markup position the surrounding literal itself delimits. Escaper/encoder calls and enclosing validator conditions cut the flow. Flow- and container-insensitive by construction. A second arm needs no provenance at all and reports a type that CONTRADICTS ITSELF — the same expression escaped at one delimited markup hole and interpolated raw at another hole in the same markup position of the same type, which the type's own escaping proves is a defect without knowing where the value came from. On a repository with no .NET source it reads JavaScript/TypeScript off the token stream with the same rule: a DOM read of raw document text (`getAttribute`, `textContent`, `innerText`, `nodeValue`) is the source, propagated through local bindings and string composition, and judged at template-literal and concatenation holes in the same two delimited markup positions; escapers and validating conditions cut it, and documentation-site, test, vendored and minified scripts are not read. Deterministic, provable per finding. Advisory.

X25 · Inert configuration knob10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.

Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.

X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `foreach` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is enumerating invalidates the enumerator it is holding, so the next `MoveNext` throws `InvalidOperationException` and the remaining items are never seen.

Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.

X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.

Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.

X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.

Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.

X3 · Exception handling5.5 / 10Adequate✓ Tool-verified

Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.

Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.

  • An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. (×10) — src/N_m3u8DL-RE/CommandLine/CommandInvoker.cs:959, src/N_m3u8DL-RE/DownloadManager/BinaryDownloadManager.cs:191, REDACTED:70, …
  • `catch (Exception)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch. — REDACTED:662

What to do

  • Swallowed exception (empty catch)
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.

Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.

X5 · Nullable reference types8.7 / 10Strong✓ Tool-verified

Other · Code Health — Whether nullable reference types are enabled and not undermined by heavy `!` suppression.

Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.

  • ~1.7 `!` suppressions per 1k syntax nodes — 251 suppression(s) across the 149017 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide. Many are correct: each is a claim the checker could not verify, and it is wrong only where the value can in fact be missing, so review the densest places first.

What to do

  • Enable <Nullable>enable</Nullable> across all projects and resolve warnings rather than suppressing with `!`.

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

LensScoreRatingImpact
Code Health62%Adequate — gated by D1, D2Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Architecture58%Adequate — gated by AX2, AX5Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Maturity56%Adequate — gated by M2Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Readiness50%Adequate — gated by P3Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Security18%Critical — gated by D29, D36, C2, S1Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Performance60%AdequateStrongest area.
Unscored — 4 check(s) recorded observations but carry no score

These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.

  • P12 CI test-gate honesty — 1 observation(s) recorded · Reported, not scored — this card publishes what the CI gate does with the test inventory rather than grading it. The findings above are its output.
  • SC1 Supply-chain hygiene — 1 observation(s) recorded · Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X10 Duplicated predicate — 19 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
  • X7 Silent fallback defaults — 7 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 1 control(s) we could not find positive evidence for

These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.

  • P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 46 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

  • AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
  • AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
  • AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
  • AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
  • AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
  • AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
  • AX1 Captive dependencies — no DI registrations detected
  • AX7 Slice cohesion — not applicable — not a vertical-slice architecture
  • AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
  • AXB1 Runtime evidence locked — no reproducible boot — This repository has nothing the runtime tiers could boot or serve — no markup, no UI framework or web-server dependency, no UI component source, no native UI project and no API definition — nothing here is a surface to boot — so runtime a11y/egress/header evidence has no subject here. Not applicable: this is neither a gap in the scan nor a finding about your code.
  • AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • C1 Data Protection — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
  • C3 Audit Trail — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
  • C4 Data Retention — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
  • C5 Data-Subject Rights — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
  • D12 Dependency Hygiene — Dependency hygiene not measured
  • D16 Bus Factor — single-maintainer repository — bus factor is not applicable
  • D22 Internal API Consistency — No intentionally-exposed public API to evaluate for consistency.
  • D23 Boundary Type-Coupling — Cross-context type coupling could not be assessed — this codebase's bounded contexts are neither declared nor inferable.
  • D25 ADR Conformance — no ADRs to check
  • D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
  • D32 Data Compliance (PII/GDPR) — 24 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
  • D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
  • D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
  • D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
  • D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
  • D7 Architectural Integrity — no checkable ADRs and no dependency cycles — architectural integrity not assessed
  • D8 Code Coverage — Coverage not measured — analyzer environment
  • DM1 Domain Modelling — not scored — this repository shows only 1 of the 3 signals this lens looks for (1 value object(s))
  • ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
  • ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
  • ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
  • P10 Library API & versioning — Library API & versioning could not be assessed in this run — the check did not complete, so it is not scored. This is a gap in the analyzer, not a finding about this repository.
  • P11 BDD / executable specs — BDD / executable specs could not be assessed in this run — the check did not complete, so it is not scored. This is a gap in the analyzer, not a finding about this repository.
  • P7 Outbound HTTP resilience — Outbound HTTP resilience could not be assessed in this run — the check did not complete, so it is not scored. This is a gap in the analyzer, not a finding about this repository.
  • P8 Schema migrations — Schema migrations could not be assessed in this run — the check did not complete, so it is not scored. This is a gap in the analyzer, not a finding about this repository.
  • P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (Cobertura — `dotnet test --collect:"XPlat Code Coverage"` with a `coverlet.collector` PackageReference) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures, or wire coverage collection into CI, to enable this cross-layer check
  • PF1 Benchmark discipline — Not applicable: no benchmark suite was found by the two searches this check runs — a BenchmarkDotNet package reference in any project file (loaded, or on disk), and a script whose name contains `benchmark` that this repository's CI runs. Neither can see a suite in another ecosystem's idiom, so this is not a verdict that the repository has none. Benchmarks are credited as a bonus, so their absence is neither scored nor deducted, and nothing is asked of a repository that has none.
  • PF2 Allocation hygiene — Not scored: this check counted allocation-aware idioms (Span, pools, stackalloc) per line, which describes what kind of code a repository is rather than whether it has an allocation problem, so it was withdrawn. Nothing here is a finding about your code.
  • X15 Unvalidated length from an untrusted reader — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X17 Uncapped recursion over a caller-supplied document — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X26 Unsynchronised callback handoff — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X32 Type resolved by simple name across every loaded assembly — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X4 Structured logging — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Critical — 61 finding(s)
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D17 · Explicit Debt · EmptyCatchBlock · ×10
  • EmptyCatchBlock src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:114 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/N_m3u8DL-RE/CommandLine/CommandInvoker.cs:959 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/N_m3u8DL-RE/DownloadManager/BinaryDownloadManager.cs:191 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock REDACTED:70 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock REDACTED:88 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/N_m3u8DL-RE/Util/ConcatInputServer.cs:69 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/N_m3u8DL-RE/Util/CultureUtil.cs:31 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock REDACTED:595 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/N_m3u8DL-RE/Util/ProcessUtil.cs:56 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/N_m3u8DL-RE/Util/TSInfoUtil.cs:241 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D17 · Explicit Debt · WriteOnlyPrivateField · ×4
  • WriteOnlyPrivateField src/N_m3u8DL-RE.Parser/Mp4/MP4InitUtil.cs:16 — private byte[] SYSTEM_ID_PLAYREADY — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField src/N_m3u8DL-RE/DownloadManager/HTTPLiveRecordManager.cs:22 — private IDownloader Downloader — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField src/N_m3u8DL-RE/DownloadManager/HTTPLiveRecordManager.cs:26 — private List<OutputFile> OutputFiles — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField src/N_m3u8DL-RE/DownloadManager/HTTPLiveRecordManager.cs:28 — private DateTime? PublishDateTime — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
D35 · Change Coupling · Boundary-crossing change coupling · ×3
  • Boundary-crossing change coupling: ResString.cs ↔ MyOption.cs src/N_m3u8DL-RE.Common/Resource/ResString.cs:1 — `src/N_m3u8DL-RE.Common/Resource/ResString.cs` (context N_m3u8DL-RE.Common) and `src/N_m3u8DL-RE/CommandLine/MyOption.cs` (context N_m3u8DL-RE) sit in DIFFERENT parts of the tree yet change together 81% of the time (34 of the 42 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 34 shared commits counted here, the most recent 3 are `ecf23f42` 默认使用 HTTP/1.1 并支持选择 HTTP 协议版本 (#1011); `2f64dcbb` 使用本机虚拟输入解决 FFmpeg 合并分片时的句柄耗尽 (#983); `141321e8` 支持 Netscape Cookie 文件及响应 Cookie 更新 (#972) — run `git show` on any of them.
  • Boundary-crossing change coupling: StaticText.cs ↔ MyOption.cs src/N_m3u8DL-RE.Common/Resource/StaticText.cs:1 — `src/N_m3u8DL-RE.Common/Resource/StaticText.cs` (context N_m3u8DL-RE.Common) and `src/N_m3u8DL-RE/CommandLine/MyOption.cs` (context N_m3u8DL-RE) sit in DIFFERENT parts of the tree yet change together 81% of the time (34 of the 42 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 34 shared commits counted here, the most recent 3 are `ecf23f42` 默认使用 HTTP/1.1 并支持选择 HTTP 协议版本 (#1011); `2f64dcbb` 使用本机虚拟输入解决 FFmpeg 合并分片时的句柄耗尽 (#983); `141321e8` 支持 Netscape Cookie 文件及响应 Cookie 更新 (#972) — run `git show` on any of them.
  • Boundary-crossing change coupling: HTTPUtil.cs ↔ CommandInvoker.cs src/N_m3u8DL-RE.Common/Util/HTTPUtil.cs:1 — `src/N_m3u8DL-RE.Common/Util/HTTPUtil.cs` (context N_m3u8DL-RE.Common) and `src/N_m3u8DL-RE/CommandLine/CommandInvoker.cs` (context N_m3u8DL-RE) sit in DIFFERENT parts of the tree yet change together 50% of the time (10 of the 20 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 10 shared commits counted here, the most recent 3 are `ecf23f42` 默认使用 HTTP/1.1 并支持选择 HTTP 协议版本 (#1011); `141321e8` 支持 Netscape Cookie 文件及响应 Cookie 更新 (#972); `4b0276d4` 支持通过 --interface 指定网络接口或本机 IP (#970) — run `git show` on any of them.
D28 · Secrets (history) · REDACTED · ×2
  • REDACTED
  • REDACTED
AX3 · Project dependency cycles · Namespace dependency cycle · ×1
  • Namespace dependency cycle src/N_m3u8DL-RE.Parser/Config/ParserConfig.cs:2 — The namespaces N_m3u8DL_RE.Parser.Config ↔ N_m3u8DL_RE.Parser.Processor depend on each other. The lightest dependency in the cycle is N_m3u8DL_RE.Parser.Config → N_m3u8DL_RE.Parser.Processor (N_m3u8DL_RE.Parser.Config.ParserConfig → N_m3u8DL_RE.Parser.Processor.ContentProcessor, 3 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D30 · Dependency Vulnerabilities · High CVE · ×1
  • REDACTED
S1 · Web-Security Posture · TLS certificate validation disabled · ×1
  • TLS certificate validation disabled src/N_m3u8DL-RE.Common/Util/HTTPUtil.cs:19 — `RemoteCertificateValidationCallback` is assigned a callback that returns `true` unconditionally, so every TLS peer certificate is accepted — including one an attacker presents. Chain, expiry, revocation and hostname are all skipped, so an attacker on the network path can present any certificate and read or rewrite the traffic — the connection is encrypted to the attacker, not to the intended host. Delete the override and let the platform validate. If a specific self-signed or internally-issued certificate genuinely has to be trusted, pin THAT one — compare the presented certificate's public key or thumbprint against the expected value and return `false` for everything else — and scope it to the single handler that talks to that host rather than to the whole process. If the override exists only to get past a development certificate, gate it on a build configuration or an explicit opt-in setting so it cannot ship.
Serious — 357 finding(s)
D15 · Churn × Complexity Hotspots · Hotspot · ×25
  • Hotspot: src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:142 — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs changed 14 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 209 in SimpleDownloadManager.DownloadStreamAsync at line 142. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-06..2026-11-04, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-06 18:55:05 +08:00' --until='2026-11-04 18:55:05 +08:00' --full-history --no-merges -- src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:250 — src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs changed 18 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 150 in SimpleLiveRecordManager2.RecordStreamAsync at line 250. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-06..2026-11-04, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-06 18:55:05 +08:00' --until='2026-11-04 18:55:05 +08:00' --full-history --no-merges -- src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: REDACTED REDACTED:81 — REDACTED changed 17 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 111 in Program.DoWorkAsync at line 81. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-06..2026-11-04, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-06 18:55:05 +08:00' --until='2026-11-04 18:55:05 +08:00' --full-history --no-merges -- REDACTED`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:63 — src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs changed 8 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 114 in DASHExtractor2.ExtractStreamsAsync at line 63. 2 of those changes were fix/bug commits, and the other 6 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-06..2026-11-04, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-06 18:55:05 +08:00' --until='2026-11-04 18:55:05 +08:00' --full-history --no-merges -- src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: REDACTED REDACTED:416 — REDACTED changed 11 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 60 in MergeUtil.MuxInputsAsync at line 416. 1 of those changes was a fix/bug commit, and the other 10 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-06..2026-11-04, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-06 18:55:05 +08:00' --until='2026-11-04 18:55:05 +08:00' --full-history --no-merges -- REDACTED`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/N_m3u8DL-RE.Parser/Extractor/HLSExtractor.cs src/N_m3u8DL-RE.Parser/Extractor/HLSExtractor.cs:227 — src/N_m3u8DL-RE.Parser/Extractor/HLSExtractor.cs changed 6 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 72 in HLSExtractor.ParseListAsync at line 227. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-06..2026-11-04, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-06 18:55:05 +08:00' --until='2026-11-04 18:55:05 +08:00' --full-history --no-merges -- src/N_m3u8DL-RE.Parser/Extractor/HLSExtractor.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/N_m3u8DL-RE/Util/FileToolUtil.cs src/N_m3u8DL-RE/Util/FileToolUtil.cs:16 — src/N_m3u8DL-RE/Util/FileToolUtil.cs changed 6 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 65 in FileToolUtil.ExecuteAsync at line 16. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-06..2026-11-04, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-06 18:55:05 +08:00' --until='2026-11-04 18:55:05 +08:00' --full-history --no-merges -- src/N_m3u8DL-RE/Util/FileToolUtil.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/N_m3u8DL-RE/Util/FilterUtil.cs src/N_m3u8DL-RE/Util/FilterUtil.cs:13 — src/N_m3u8DL-RE/Util/FilterUtil.cs changed 7 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 37 in FilterUtil.DoFilterKeep at line 13. 1 of those changes was a fix/bug commit, and the other 6 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-06..2026-11-04, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-06 18:55:05 +08:00' --until='2026-11-04 18:55:05 +08:00' --full-history --no-merges -- src/N_m3u8DL-RE/Util/FilterUtil.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.Parts.cs src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.Parts.cs:17 — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.Parts.cs changed 6 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 43 in SimpleDownloadManager.DownloadPartsAsync at line 17. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-06..2026-11-04, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-06 18:55:05 +08:00' --until='2026-11-04 18:55:05 +08:00' --full-history --no-merges -- src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.Parts.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/N_m3u8DL-RE/CommandLine/CommandInvoker.cs src/N_m3u8DL-RE/CommandLine/CommandInvoker.cs:891 — src/N_m3u8DL-RE/CommandLine/CommandInvoker.cs changed 15 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 16 in CommandInvoker.InvokeArgs at line 891. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-06..2026-11-04, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-06 18:55:05 +08:00' --until='2026-11-04 18:55:05 +08:00' --full-history --no-merges -- src/N_m3u8DL-RE/CommandLine/CommandInvoker.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/N_m3u8DL-RE/Util/RecordingTrack.cs src/N_m3u8DL-RE/Util/RecordingTrack.cs:80 — src/N_m3u8DL-RE/Util/RecordingTrack.cs changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 44 in RecordingTrack.Read at line 80. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-06..2026-11-04, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-06 18:55:05 +08:00' --until='2026-11-04 18:55:05 +08:00' --full-history --no-merges -- src/N_m3u8DL-RE/Util/RecordingTrack.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: REDACTED REDACTED:13 — REDACTED changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 38 in MP4DecryptUtil.DecryptAsync at line 13. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-06..2026-11-04, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-06 18:55:05 +08:00' --until='2026-11-04 18:55:05 +08:00' --full-history --no-merges -- REDACTED`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/N_m3u8DL-RE/Util/OtherUtil.cs src/N_m3u8DL-RE/Util/OtherUtil.cs:293 — src/N_m3u8DL-RE/Util/OtherUtil.cs changed 7 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 19 in OtherUtil.FindAvailableOutputPath at line 293. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-06..2026-11-04, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-06 18:55:05 +08:00' --until='2026-11-04 18:55:05 +08:00' --full-history --no-merges -- src/N_m3u8DL-RE/Util/OtherUtil.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/N_m3u8DL-RE/DownloadManager/HTTPLiveRecordManager.cs src/N_m3u8DL-RE/DownloadManager/HTTPLiveRecordManager.cs:60 — src/N_m3u8DL-RE/DownloadManager/HTTPLiveRecordManager.cs changed 7 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 16 in HTTPLiveRecordManager.RecordStreamAsync at line 60. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-06..2026-11-04, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-06 18:55:05 +08:00' --until='2026-11-04 18:55:05 +08:00' --full-history --no-merges -- src/N_m3u8DL-RE/DownloadManager/HTTPLiveRecordManager.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/N_m3u8DL-RE.Parser/Mp4/MP4MediaInfoUtil.cs src/N_m3u8DL-RE.Parser/Mp4/MP4MediaInfoUtil.cs:28 — src/N_m3u8DL-RE.Parser/Mp4/MP4MediaInfoUtil.cs changed 5 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 22 in MP4MediaInfoUtil.ReadTiming at line 28. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-06..2026-11-04, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-06 18:55:05 +08:00' --until='2026-11-04 18:55:05 +08:00' --full-history --no-merges -- src/N_m3u8DL-RE.Parser/Mp4/MP4MediaInfoUtil.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/N_m3u8DL-RE/CommandLine/ToolCommands.cs src/N_m3u8DL-RE/CommandLine/ToolCommands.cs:93 — src/N_m3u8DL-RE/CommandLine/ToolCommands.cs changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 27 in ToolCommands.CreateFileCommand at line 93. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-06..2026-11-04, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-06 18:55:05 +08:00' --until='2026-11-04 18:55:05 +08:00' --full-history --no-merges -- src/N_m3u8DL-RE/CommandLine/ToolCommands.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/N_m3u8DL-RE.Common/Util/HTTPUtil.cs src/N_m3u8DL-RE.Common/Util/HTTPUtil.cs:175 — src/N_m3u8DL-RE.Common/Util/HTTPUtil.cs changed 6 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 16 in HTTPUtil.GetWebSourceResultAsync at line 175. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-06..2026-11-04, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-06 18:55:05 +08:00' --until='2026-11-04 18:55:05 +08:00' --full-history --no-merges -- src/N_m3u8DL-RE.Common/Util/HTTPUtil.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/N_m3u8DL-RE/Downloader/SimpleDownloader.cs src/N_m3u8DL-RE/Downloader/SimpleDownloader.cs:83 — src/N_m3u8DL-RE/Downloader/SimpleDownloader.cs changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 24 in SimpleDownloader.DownClipAsync at line 83. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-06..2026-11-04, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-06 18:55:05 +08:00' --until='2026-11-04 18:55:05 +08:00' --full-history --no-merges -- src/N_m3u8DL-RE/Downloader/SimpleDownloader.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/N_m3u8DL-RE/Util/MediainfoUtil.cs src/N_m3u8DL-RE/Util/MediainfoUtil.cs:94 — src/N_m3u8DL-RE/Util/MediainfoUtil.cs changed 5 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 18 in MediainfoUtil.ReadInfoAsync at line 94. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-06..2026-11-04, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-06 18:55:05 +08:00' --until='2026-11-04 18:55:05 +08:00' --full-history --no-merges -- src/N_m3u8DL-RE/Util/MediainfoUtil.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/N_m3u8DL-RE.Parser/Processor/HLS/DefaultHLSKeyProcessor.cs src/N_m3u8DL-RE.Parser/Processor/HLS/DefaultHLSKeyProcessor.cs:27 — src/N_m3u8DL-RE.Parser/Processor/HLS/DefaultHLSKeyProcessor.cs changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 20 in DefaultHLSKeyProcessor.Process at line 27. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-06..2026-11-04, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-06 18:55:05 +08:00' --until='2026-11-04 18:55:05 +08:00' --full-history --no-merges -- src/N_m3u8DL-RE.Parser/Processor/HLS/DefaultHLSKeyProcessor.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/N_m3u8DL-RE/Util/VodStreamPlanner.cs src/N_m3u8DL-RE/Util/VodStreamPlanner.cs:12 — src/N_m3u8DL-RE/Util/VodStreamPlanner.cs changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 35 in VodStreamPlanner.Build at line 12. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-06..2026-11-04, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-06 18:55:05 +08:00' --until='2026-11-04 18:55:05 +08:00' --full-history --no-merges -- src/N_m3u8DL-RE/Util/VodStreamPlanner.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/N_m3u8DL-RE/DownloadManager/LiveSegmentTracker.cs src/N_m3u8DL-RE/DownloadManager/LiveSegmentTracker.cs:52 — src/N_m3u8DL-RE/DownloadManager/LiveSegmentTracker.cs changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 22 in LiveSegmentTracker.FindMatchingIndex at line 52. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-06..2026-11-04, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-06 18:55:05 +08:00' --until='2026-11-04 18:55:05 +08:00' --full-history --no-merges -- src/N_m3u8DL-RE/DownloadManager/LiveSegmentTracker.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/N_m3u8DL-RE/CommandLine/ConfigFile.cs src/N_m3u8DL-RE/CommandLine/ConfigFile.cs:140 — src/N_m3u8DL-RE/CommandLine/ConfigFile.cs changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 19 in ConfigFile.Merge at line 140. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-06..2026-11-04, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-06 18:55:05 +08:00' --until='2026-11-04 18:55:05 +08:00' --full-history --no-merges -- src/N_m3u8DL-RE/CommandLine/ConfigFile.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/N_m3u8DL-RE/Util/DownloadUtil.cs src/N_m3u8DL-RE/Util/DownloadUtil.cs:71 — src/N_m3u8DL-RE/Util/DownloadUtil.cs changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 18 in DownloadUtil.DownloadToFileCoreAsync at line 71. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-06..2026-11-04, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-06 18:55:05 +08:00' --until='2026-11-04 18:55:05 +08:00' --full-history --no-merges -- src/N_m3u8DL-RE/Util/DownloadUtil.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/N_m3u8DL-RE/Util/MuxSubtitleTimeline.cs src/N_m3u8DL-RE/Util/MuxSubtitleTimeline.cs:38 — src/N_m3u8DL-RE/Util/MuxSubtitleTimeline.cs changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 15 in MuxSubtitleTimeline.CreateAsync at line 38. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-06..2026-11-04, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-06 18:55:05 +08:00' --until='2026-11-04 18:55:05 +08:00' --full-history --no-merges -- src/N_m3u8DL-RE/Util/MuxSubtitleTimeline.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
X2 · Cancellation propagation · Async method without CancellationToken · ×24
  • Async method without CancellationToken: InvokeArgs src/N_m3u8DL-RE/CommandLine/CommandInvoker.cs:891 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: EncryptStreamAsync src/N_m3u8DL-RE/Crypto/CSChaCha20.cs:215 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: DecryptStreamAsync src/N_m3u8DL-RE/Crypto/CSChaCha20.cs:307 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: WorkStreamsAsync src/N_m3u8DL-RE/Crypto/CSChaCha20.cs:383 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: RunAsync src/N_m3u8DL-RE/DownloadManager/BinaryDownloadRunner.cs:20 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: DownloadWithLogAsync src/N_m3u8DL-RE/DownloadManager/BinaryDownloadRunner.cs:92 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: DownloadWithProgressAsync src/N_m3u8DL-RE/DownloadManager/BinaryDownloadRunner.cs:125 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: ReadInfoAsync src/N_m3u8DL-RE/DownloadManager/HTTPLiveRecordManager.cs:166 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: TimeCounterAsync src/N_m3u8DL-RE/DownloadManager/HTTPLiveRecordManager.cs:207 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: TryRecordStreamAsync src/N_m3u8DL-RE/DownloadManager/HTTPLiveRecordManager.cs:241 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: StartRecordAsync src/N_m3u8DL-RE/DownloadManager/HTTPLiveRecordManager.cs:259 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: SearchKeyAsync src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:62 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: ReadInitInfoAsync src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:109 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: DownloadStreamAsync src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:142 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: StartDownloadAsync src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:899 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: DownloadPartsAsync src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.Parts.cs:17 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: MergeSubtitlesAsync src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.Parts.cs:197 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: SearchKeyAsync src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:154 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: PlayListProduceAsync src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:950 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: StartRecordCoreAsync src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:1148 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: DoWorkAsync REDACTED:81 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: WriteRawFilesAsync REDACTED:625 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: CheckUpdateAsync REDACTED:648 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: Get302Async REDACTED:669 — No CancellationToken parameter — this work can't be stopped early once started.
PF3 · Async & latency hygiene · Sync-over-async blocking · ×13
  • Sync-over-async blocking — 12 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/N_m3u8DL-RE/Util/ConcatInputServer.cs:240 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/N_m3u8DL-RE/Util/MediaProcessingProgress.cs:116 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking REDACTED:24 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking REDACTED:65 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking REDACTED:191 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking REDACTED:215 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking REDACTED:319 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking REDACTED:406 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking REDACTED:413 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking REDACTED:325 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/N_m3u8DL-RE.Parser/Processor/HLS/DefaultHLSKeyProcessor.cs:90 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/N_m3u8DL-RE.Parser/Processor/HLS/DefaultHLSKeyProcessor.cs:102 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
D3 · God Classes · MethodTooLong · ×12
  • MethodTooLong: SimpleDownloadManager.DownloadStreamAsync src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:142 — MethodTooLong — DownloadStreamAsync runs 439 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 339 over it, 4.39× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SimpleLiveRecordManager2.RecordStreamAsync src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:250 — MethodTooLong — RecordStreamAsync runs 368 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 268 over it, 3.68× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: DASHExtractor2.ExtractStreamsAsync src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:63 — MethodTooLong — ExtractStreamsAsync runs 352 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 252 over it, 3.52× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: Program.DoWorkAsync REDACTED:81 — MethodTooLong — DoWorkAsync runs 276 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 176 over it, 2.76× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: HLSExtractor.ParseListAsync src/N_m3u8DL-RE.Parser/Extractor/HLSExtractor.cs:227 — MethodTooLong — ParseListAsync runs 179 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 79 over it, 1.79× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SimpleLiveRecordManager2.StartRecordCoreAsync src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:1148 — MethodTooLong — StartRecordCoreAsync runs 145 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 45 over it, 1.45× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: MSSExtractor.ExtractStreamsAsync src/N_m3u8DL-RE.Parser/Extractor/MSSExtractor.cs:45 — MethodTooLong — ExtractStreamsAsync runs 141 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 41 over it, 1.41× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: FileToolUtil.ExecuteAsync src/N_m3u8DL-RE/Util/FileToolUtil.cs:16 — MethodTooLong — ExecuteAsync runs 136 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 36 over it, 1.36× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SimpleDownloadManager.StartDownloadAsync src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:899 — MethodTooLong — StartDownloadAsync runs 130 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 30 over it, 1.30× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SimpleDownloadManager.DownloadPartsAsync src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.Parts.cs:17 — MethodTooLong — DownloadPartsAsync runs 124 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 24 over it, 1.24× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: MP4TtmlUtil.ExtractSub REDACTED:193 — MethodTooLong — ExtractSub runs 105 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 5 over it, 1.05× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: MergeUtil.MuxInputsAsync REDACTED:416 — MethodTooLong — MuxInputsAsync runs 103 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 3 over it, 1.03× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
X1 · Async correctness · Sync-over-async (deadlock risk) · ×11
  • Sync-over-async (deadlock risk) src/N_m3u8DL-RE/Util/ConcatInputServer.cs:240 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback.
  • Sync-over-async (deadlock risk) src/N_m3u8DL-RE/Util/MediaProcessingProgress.cs:116 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback.
  • Sync-over-async (deadlock risk) REDACTED:24 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
  • Sync-over-async (deadlock risk) REDACTED:64 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
  • Sync-over-async (deadlock risk) REDACTED:190 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
  • Sync-over-async (deadlock risk) REDACTED:214 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
  • Sync-over-async (deadlock risk) REDACTED:318 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
  • Sync-over-async (deadlock risk) REDACTED:405 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
  • Sync-over-async (deadlock risk) REDACTED:412 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
  • Sync-over-async (deadlock risk) REDACTED:325 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
  • Sync-over-async (deadlock risk) src/N_m3u8DL-RE.Parser/Processor/HLS/DefaultHLSKeyProcessor.cs:90 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
X3 · Exception handling · Swallowed exception (empty catch) · ×10
  • Swallowed exception (empty catch) src/N_m3u8DL-RE/CommandLine/CommandInvoker.cs:959 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/N_m3u8DL-RE/DownloadManager/BinaryDownloadManager.cs:191 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) REDACTED:70 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) REDACTED:88 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/N_m3u8DL-RE/Util/ConcatInputServer.cs:69 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/N_m3u8DL-RE/Util/CultureUtil.cs:31 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) REDACTED:595 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/N_m3u8DL-RE/Util/ProcessUtil.cs:56 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/N_m3u8DL-RE/Util/TSInfoUtil.cs:241 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:114 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
D3 · God Classes · FileTooLong · ×6
  • FileTooLong: Resource/StaticText.cs src/N_m3u8DL-RE.Common/Resource/StaticText.cs — FileTooLong — 1571 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 1071 over it, 3.14× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: DownloadManager/SimpleLiveRecordManager2.cs src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs — FileTooLong — 814 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 314 over it, 1.63× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: DownloadManager/SimpleDownloadManager.cs src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs — FileTooLong — 657 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 157 over it, 1.31× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: CommandLine/CommandInvoker.cs src/N_m3u8DL-RE/CommandLine/CommandInvoker.cs — FileTooLong — 602 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 102 over it, 1.20× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Mp4/MSSMoovProcessor.cs src/N_m3u8DL-RE.Parser/Mp4/MSSMoovProcessor.cs — FileTooLong — 541 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 41 over it, 1.08× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Extractor/DASHExtractor2.cs src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs — FileTooLong — 527 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 27 over it, 1.05× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
D4 · Code Duplication · Duplicated block (6 lines × 2) · ×6
  • Duplicated block (6 lines × 2) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:766 — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:766-771 | src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:775-780 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (6 lines × 2) src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:408 — src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:408-413 | src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:472-477 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:408` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) src/N_m3u8DL-RE/Util/LargeSingleFileSplitUtil.cs:54 — src/N_m3u8DL-RE/Util/LargeSingleFileSplitUtil.cs:54-59 | src/N_m3u8DL-RE/Util/LargeSingleFileSplitUtil.cs:74-79 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (6 lines × 2) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:376 — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:376-381 | src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:475-480 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:473` calls `Add`, `TrackFile` and `src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:375` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (6 lines × 2) src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:434 — src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:434-439 | src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:1005-1010 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (6 lines × 2) src/N_m3u8DL-RE.Parser/Extractor/HLSExtractor.cs:391 — src/N_m3u8DL-RE.Parser/Extractor/HLSExtractor.cs:391-396 | src/N_m3u8DL-RE.Parser/Extractor/HLSExtractor.cs:431-436 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
X1 · Async correctness · Blocking `File.ReadAllBytes` inside an `async` method · ×6
  • Blocking `File.ReadAllBytes` inside an `async` method src/N_m3u8DL-RE/Downloader/SimpleDownloader.cs:55 — `File.ReadAllBytes` blocks the thread on I/O while `File.ReadAllBytesAsync` exists to wait without one — inside a method that is already `async`, await the twin.
  • Blocking `File.ReadAllBytes` inside an `async` method src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:369 — `File.ReadAllBytes` blocks the thread on I/O while `File.ReadAllBytesAsync` exists to wait without one — inside a method that is already `async`, await the twin.
  • Blocking `File.ReadAllBytes` inside an `async` method src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:617 — `File.ReadAllBytes` blocks the thread on I/O while `File.ReadAllBytesAsync` exists to wait without one — inside a method that is already `async`, await the twin.
  • Blocking `File.ReadAllBytes` inside an `async` method src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:628 — `File.ReadAllBytes` blocks the thread on I/O while `File.ReadAllBytesAsync` exists to wait without one — inside a method that is already `async`, await the twin.
  • Blocking `File.ReadAllBytes` inside an `async` method src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:466 — `File.ReadAllBytes` blocks the thread on I/O while `File.ReadAllBytesAsync` exists to wait without one — inside a method that is already `async`, await the twin.
  • Blocking `File.ReadAllBytes` inside an `async` method src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:636 — `File.ReadAllBytes` blocks the thread on I/O while `File.ReadAllBytesAsync` exists to wait without one — inside a method that is already `async`, await the twin.
X18 · Disposal-pattern correctness · Disposable created and abandoned in the method that made it · ×6
  • Disposable created and abandoned in the method that made it src/N_m3u8DL-RE/Crypto/AESUtil.cs:26 — `dcpt` is a `Aes`, which implements `IDisposable`, and it is created here (line 26). Every use of it in `AES128Decrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var dcpt = …;`), which releases it at the end of the scope on every path including a throw.
  • Disposable created and abandoned in the method that made it src/N_m3u8DL-RE/Crypto/AESUtil.cs:34 — `cTransform` is a `ICryptoTransform`, which implements `IDisposable`, and it is created here (line 34). Every use of it in `AES128Decrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var cTransform = …;`), which releases it at the end of the scope on every path including a throw.
  • Disposable created and abandoned in the method that made it src/N_m3u8DL-RE/Crypto/ChaCha20Util.cs:25 — `forDecrypting` is a `ChaCha20`, which implements `IDisposable`, and it is created here (line 25). Every use of it in `DecryptPer1024Bytes` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var forDecrypting = …;`), which releases it at the end of the scope on every path including a throw.
  • Disposable created and abandoned in the method that made it src/N_m3u8DL-RE/Util/ConcatInputStream.cs:91 — `stream` is a `FileStream`, which implements `IDisposable`, and it is created here (line 91). Every use of it in `Read` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var stream = …;`), which releases it at the end of the scope on every path including a throw.
  • Disposable created and abandoned in the method that made it src/N_m3u8DL-RE/Util/ConcatInputStream.cs:109 — `stream` is a `FileStream`, which implements `IDisposable`, and it is created here (line 109). Every use of it in `ReadAsync` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var stream = …;`), which releases it at the end of the scope on every path including a throw.
  • Disposable created and abandoned in the method that made it src/N_m3u8DL-RE.Parser/Mp4/MP4VttUtil.cs:116 — `reader` is a `BinaryReader2`, which implements `IDisposable`, and it is created here (line 116). Every use of it in `ExtractSub` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var reader = …;`), which releases it at the end of the scope on every path including a throw.
D17 · Explicit Debt · CommentedOutCode · ×5
  • CommentedOutCode src/N_m3u8DL-RE.Parser/Mp4/MSSMoovProcessor.cs:637 — 16 consecutive commented-code lines
  • CommentedOutCode src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:710 — 3 consecutive commented-code lines
  • CommentedOutCode src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:698 — 3 consecutive commented-code lines
  • CommentedOutCode src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:740 — 6 consecutive commented-code lines
  • CommentedOutCode src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:1184 — 6 consecutive commented-code lines
D3 · God Classes · ClassTooLong · ×5
  • ClassTooLong: StaticText src/N_m3u8DL-RE.Common/Resource/StaticText.cs — ClassTooLong — 1570 significant lines (blank, comment-only and punctuation-only lines excluded), 0 methods. The bar is 400 significant lines; this is 1170 over it, 3.93× the bar. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
  • ClassTooLong: SimpleDownloadManager src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs — ClassTooLong — 805 significant lines (blank, comment-only and punctuation-only lines excluded), 13 methods, declared across 2 files: DownloadManager/SimpleDownloadManager.cs (9), DownloadManager/SimpleDownloadManager.Parts.cs (4). The bar is 400 significant lines; this is 405 over it, 2.01× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: SimpleLiveRecordManager2 src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs — ClassTooLong — 790 significant lines (blank, comment-only and punctuation-only lines excluded), 20 methods. The bar is 400 significant lines; this is 390 over it, 1.98× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: MSSMoovProcessor src/N_m3u8DL-RE.Parser/Mp4/MSSMoovProcessor.cs — ClassTooLong — 535 significant lines (blank, comment-only and punctuation-only lines excluded), 27 methods. The bar is 400 significant lines; this is 135 over it, 1.34× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: DASHExtractor2 src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs — ClassTooLong — 515 significant lines (blank, comment-only and punctuation-only lines excluded), 15 methods. The bar is 400 significant lines; this is 115 over it, 1.29× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D4 · Code Duplication · Duplicated block (5 lines × 2) · ×4
  • Duplicated block (5 lines × 2) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:447 — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:447-451 | src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:563-567 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:447` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) REDACTED:326 — REDACTED:326-330 | REDACTED:345-349 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:326` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) src/N_m3u8DL-RE.Parser/Mp4/MSSMoovProcessor.cs:521 — src/N_m3u8DL-RE.Parser/Mp4/MSSMoovProcessor.cs:521-525 | src/N_m3u8DL-RE.Parser/Mp4/MSSMoovProcessor.cs:539-543 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (5 lines × 2) src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:449 — src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:449-453 | src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:555-559 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
GD1 · Unfinished & placeholder code · Unfinished stub · ×4
  • Unfinished stub — throws NotImplementedException src/N_m3u8DL-RE.Parser/Extractor/LiveTSExtractor.cs:33 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException src/N_m3u8DL-RE.Parser/Extractor/LiveTSExtractor.cs:38 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException src/N_m3u8DL-RE.Parser/Extractor/LiveTSExtractor.cs:43 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException src/N_m3u8DL-RE.Parser/Extractor/LiveTSExtractor.cs:48 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
IC1 · Incompleteness & stubs · Unfinished stub · ×4
  • Unfinished stub — throws NotImplementedException src/N_m3u8DL-RE.Parser/Extractor/LiveTSExtractor.cs:33 — `FetchPlayListAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException src/N_m3u8DL-RE.Parser/Extractor/LiveTSExtractor.cs:38 — `PreProcessContent` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException src/N_m3u8DL-RE.Parser/Extractor/LiveTSExtractor.cs:43 — `PreProcessUrl` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException src/N_m3u8DL-RE.Parser/Extractor/LiveTSExtractor.cs:48 — `RefreshPlayListAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
AX2 · Stateful singletons · Process-global static state · ×3
  • Process-global static state: CommandInvoker src/N_m3u8DL-RE/CommandLine/CommandInvoker.cs:19 — `CommandInvoker` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (Descriptions; e.g. `Descriptions` at line 780). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
  • Process-global static state: CustomAnsiConsole src/N_m3u8DL-RE.Common/Log/CustomAnsiConsole.cs:76 — `CustomAnsiConsole` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (Console; e.g. `Console` at line 92). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
  • Process-global static state: Logger src/N_m3u8DL-RE.Common/Log/Logger.cs:8 — `Logger` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (LogFilePath; e.g. `LogFilePath` at line 47). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
D29 · Static Analysis (SAST) · REDACTED · ×3
  • REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Duplicated block (12 lines × 2) · ×3
  • Duplicated block (12 lines × 2) src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:828 — src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:828-839 | src/N_m3u8DL-RE.Parser/Extractor/MSSExtractor.cs:321-332 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:828` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (12 lines × 2) src/N_m3u8DL-RE/Util/ImageHeaderUtil.cs:40 — src/N_m3u8DL-RE/Util/ImageHeaderUtil.cs:40-51 | src/N_m3u8DL-RE/Util/ImageHeaderUtil.cs:66-77 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (12 lines × 2) src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:279 — src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:279-290 | src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:306-317 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (11 lines × 2) · ×3
  • Duplicated block (11 lines × 2) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:1098 — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:1098-1108 | src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:1368-1378 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:1098` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:1095` calls `SafeDeleteDir` and `src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:1365` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (11 lines × 2) src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:519 — src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:519-529 | src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:566-576 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (11 lines × 2) src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:668 — src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:668-678 | src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:712-722 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:668` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (9 lines × 2) · ×3
  • Duplicated block (9 lines × 2) src/N_m3u8DL-RE.Common/Util/HTTPUtil.cs:89 — src/N_m3u8DL-RE.Common/Util/HTTPUtil.cs:89-97 | src/N_m3u8DL-RE/Util/DownloadUtil.cs:123-131 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/N_m3u8DL-RE.Common/Util/HTTPUtil.cs:89` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:612 — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:612-620 | src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:631-639 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:612` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:64 — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:64-72 | src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:156-164 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
X2 · Cancellation propagation · Async local function without CancellationToken · ×3
  • Async local function without CancellationToken: DownloadTrackAsync src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:962 — Neither takes a CancellationToken nor reads the one of the function it sits in, while it calls something that takes one — this work can't be stopped early once started. Take the token, or pass on the enclosing one.
  • Async local function without CancellationToken: DownloadBatchAsync src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:984 — Neither takes a CancellationToken nor reads the one of the function it sits in, while it calls something that takes one — this work can't be stopped early once started. Take the token, or pass on the enclosing one.
  • Async local function without CancellationToken: DownloadMediaAsync src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:1006 — Neither takes a CancellationToken nor reads the one of the function it sits in, while it calls something that takes one — this work can't be stopped early once started. Take the token, or pass on the enclosing one.
D17 · Explicit Debt · Dead code · ×2
  • Dead code: GetWebSourceAsync src/N_m3u8DL-RE.Common/Util/HTTPUtil.cs:152 — Method GetWebSourceAsync — Roslyn's SymbolFinder walked every project the solution loads, including N_m3u8DL-RE.Common, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • Dead code: GenMoof src/N_m3u8DL-RE.Parser/Mp4/MSSMoovProcessor.cs:766 — Method GenMoof — Roslyn's SymbolFinder walked every project the solution loads, including N_m3u8DL-RE.Parser, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
D29 · Static Analysis (SAST) · REDACTED · ×2
  • REDACTED
  • REDACTED
D4 · Code Duplication · Edited copy of a member (18 corresponding lines) · ×2
  • Edited copy of a member (18 corresponding lines) src/N_m3u8DL-RE/CommandLine/ConfigFile.cs:223 — src/N_m3u8DL-RE/CommandLine/ConfigFile.cs:223-245 | src/N_m3u8DL-RE/CommandLine/ConfigFile.cs:248-265 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (18 corresponding lines) REDACTED:43 — REDACTED:43-60 | src/N_m3u8DL-RE.Parser/Mp4/MP4VttUtil.cs:28-53 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (15 corresponding lines) · ×2
  • Edited copy of a member (15 corresponding lines) src/N_m3u8DL-RE/Util/ConcatInputStream.cs:86 — src/N_m3u8DL-RE/Util/ConcatInputStream.cs:86-100 | src/N_m3u8DL-RE/Util/ConcatInputStream.cs:103-118 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (15 corresponding lines) src/N_m3u8DL-RE/Crypto/CSChaCha20.cs:367 — src/N_m3u8DL-RE/Crypto/CSChaCha20.cs:367-381 | src/N_m3u8DL-RE/Crypto/CSChaCha20.cs:384-400 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (12 corresponding lines) · ×2
  • Edited copy of a member (12 corresponding lines) src/N_m3u8DL-RE.Parser/Mp4/MSSMoovProcessor.cs:738 — src/N_m3u8DL-RE.Parser/Mp4/MSSMoovProcessor.cs:738-749 | src/N_m3u8DL-RE.Parser/Mp4/MSSMoovProcessor.cs:752-764 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (12 corresponding lines) src/N_m3u8DL-RE/Util/LargeSingleFileSplitUtil.cs:50 — src/N_m3u8DL-RE/Util/LargeSingleFileSplitUtil.cs:50-69 | src/N_m3u8DL-RE/Util/LargeSingleFileSplitUtil.cs:72-83 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (2 corresponding lines) · ×2
  • Edited copy of a member (2 corresponding lines) src/N_m3u8DL-RE.Common/Entity/WebVttSub.cs:203 — src/N_m3u8DL-RE.Common/Entity/WebVttSub.cs:203-208 | src/N_m3u8DL-RE/Util/MuxSubtitleTimeline.cs:193-194 — These two members are one piece of code written twice and then edited apart: 2 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (2 corresponding lines) src/N_m3u8DL-RE/Util/HlsSubtitleTimeline.cs:53 — src/N_m3u8DL-RE/Util/HlsSubtitleTimeline.cs:53-55 | src/N_m3u8DL-RE/Util/MuxSubtitleTimeline.cs:190-191 — These two members are one piece of code written twice and then edited apart: 2 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (10 lines × 2) · ×2
  • Duplicated block (10 lines × 2) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:408 — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:408-417 | src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:450-459 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (10 lines × 2) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:1063 — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:1063-1072 | src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:1331-1340 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:1063` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (7 lines × 2) · ×2
  • Duplicated block (7 lines × 2) src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:627 — src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:627-633 | src/N_m3u8DL-RE.Parser/Extractor/MSSExtractor.cs:244-250 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:627` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:316 — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:316-322 | src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:402-408 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:316` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
X18 · Disposal-pattern correctness · Disposable created into a field and never released · ×2
  • Disposable created into a field and never released src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:59 — `CancellationTokenSource` (line 59) holds a `CancellationTokenSource` that `SimpleLiveRecordManager2` creates itself with `new`, and nothing in `SimpleLiveRecordManager2` ever releases it: the type is not `IDisposable`, declares no `Dispose`, and every other mention of `CancellationTokenSource` only reads through it. And `SimpleLiveRecordManager2` is not a process-lifetime owner: `new SimpleLiveRecordManager2(downloadConfig, selectedStreams, extractor)` (REDACTED line 545) creates one per call and drops it when the call returns, so each call strands one unreleased `CancellationTokenSource` (a timer that keeps firing, a handle, a socket) until finalization. Implement `IDisposable`, release `CancellationTokenSource` there and dispose the owner at that call site — or keep one owner for the process instead of one per call.
  • Disposable created into a field and never released src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:60 — `DownloadCancellationTokenSource` (line 60) holds a `CancellationTokenSource` that `SimpleLiveRecordManager2` creates itself with `new`, and nothing in `SimpleLiveRecordManager2` ever releases it: the type is not `IDisposable`, declares no `Dispose`, and every other mention of `DownloadCancellationTokenSource` only reads through it. And `SimpleLiveRecordManager2` is not a process-lifetime owner: `new SimpleLiveRecordManager2(downloadConfig, selectedStreams, extractor)` (REDACTED line 545) creates one per call and drops it when the call returns, so each call strands one unreleased `CancellationTokenSource` (a timer that keeps firing, a handle, a socket) until finalization. Implement `IDisposable`, release `DownloadCancellationTokenSource` there and dispose the owner at that call site — or keep one owner for the process instead of one per call.
AX5 · Architecture & structure · Appears unstructured (no recognised architecture) · ×1
  • Appears unstructured (no recognised architecture) — ~23.1k production LoC (363 types) across 3 project(s) / 30 namespace(s) with no recognised architectural style or layering — at this size, deliberate module boundaries would help. No DDD/clean/vertical-slice/CQRS/transaction-script organisation was detected — code is likely organised ad hoc, which makes change and onboarding harder as it grows.
C2 · Access Controls · No authorization · ×1
  • No authorization — No [Authorize]/policies and no imperative guard methods (throw-on-violation) were found — endpoints may be unprotected.
D1 · Cyclomatic Complexity · SimpleDownloadManager.DownloadStreamAsync (cyclomatic 209) · ×1
  • SimpleDownloadManager.DownloadStreamAsync (cyclomatic 209) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:142 — SimpleDownloadManager.DownloadStreamAsync has cyclomatic complexity 209 (threshold 15). Of this number, 202 points are the body's own statements and 7 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SimpleLiveRecordManager2.RecordStreamAsync (cyclomatic 150) · ×1
  • SimpleLiveRecordManager2.RecordStreamAsync (cyclomatic 150) src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:250 — SimpleLiveRecordManager2.RecordStreamAsync has cyclomatic complexity 150 (threshold 15). Of this number, 141 points are the body's own statements and 9 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DASHExtractor2.ExtractStreamsAsync (cyclomatic 114) · ×1
  • DASHExtractor2.ExtractStreamsAsync (cyclomatic 114) src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:63 — DASHExtractor2.ExtractStreamsAsync has cyclomatic complexity 114 (threshold 15). Of this number, 102 points are the body's own statements and 12 belong to 3 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Program.DoWorkAsync (cyclomatic 111) · ×1
  • Program.DoWorkAsync (cyclomatic 111) REDACTED:81 — Program.DoWorkAsync has cyclomatic complexity 111 (threshold 15). Of this number, 110 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · HLSExtractor.ParseListAsync (cyclomatic 72) · ×1
  • HLSExtractor.ParseListAsync (cyclomatic 72) src/N_m3u8DL-RE.Parser/Extractor/HLSExtractor.cs:227 — HLSExtractor.ParseListAsync has cyclomatic complexity 72 (threshold 15). Of this number, 69 points are the body's own statements and 3 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · FileToolUtil.ExecuteAsync (cyclomatic 65) · ×1
  • FileToolUtil.ExecuteAsync (cyclomatic 65) src/N_m3u8DL-RE/Util/FileToolUtil.cs:16 — FileToolUtil.ExecuteAsync has cyclomatic complexity 65 (threshold 15). Of this number, 35 points are the body's own statements and 30 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MergeUtil.MuxInputsAsync (cyclomatic 60) · ×1
  • MergeUtil.MuxInputsAsync (cyclomatic 60) REDACTED:416 — MergeUtil.MuxInputsAsync has cyclomatic complexity 60 (threshold 15). Of this number, 59 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ImageHeaderUtil.ProcessAsync (cyclomatic 54) · ×1
  • ImageHeaderUtil.ProcessAsync (cyclomatic 54) src/N_m3u8DL-RE/Util/ImageHeaderUtil.cs:23 — ImageHeaderUtil.ProcessAsync has cyclomatic complexity 54 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · SimpleDownloadManager.StartDownloadAsync (cyclomatic 49) · ×1
  • SimpleDownloadManager.StartDownloadAsync (cyclomatic 49) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:899 — SimpleDownloadManager.StartDownloadAsync has cyclomatic complexity 49 (threshold 15). Of this number, 21 points are the body's own statements and 28 belong to 8 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SimpleLiveRecordManager2.PlayListProduceCoreAsync (cyclomatic 44) · ×1
  • SimpleLiveRecordManager2.PlayListProduceCoreAsync (cyclomatic 44) src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:970 — SimpleLiveRecordManager2.PlayListProduceCoreAsync has cyclomatic complexity 44 (threshold 15). Of this number, 20 points are the body's own statements and 24 belong to 5 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · RecordingTrack.Read (cyclomatic 44) · ×1
  • RecordingTrack.Read (cyclomatic 44) src/N_m3u8DL-RE/Util/RecordingTrack.cs:80 — RecordingTrack.Read has cyclomatic complexity 44 (threshold 15). Of this number, 43 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SimpleDownloadManager.DownloadPartsAsync (cyclomatic 43) · ×1
  • SimpleDownloadManager.DownloadPartsAsync (cyclomatic 43) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.Parts.cs:17 — SimpleDownloadManager.DownloadPartsAsync has cyclomatic complexity 43 (threshold 15). Of this number, 41 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MP4TtmlUtil.ExtractSub (cyclomatic 40) · ×1
  • MP4TtmlUtil.ExtractSub (cyclomatic 40) REDACTED:193 — MP4TtmlUtil.ExtractSub has cyclomatic complexity 40 (threshold 15). Of this number, 38 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · TSInfoUtil.ReadServices (cyclomatic 39) · ×1
  • TSInfoUtil.ReadServices (cyclomatic 39) src/N_m3u8DL-RE/Util/TSInfoUtil.cs:12 — TSInfoUtil.ReadServices has cyclomatic complexity 39 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SimpleLiveRecordManager2.StartRecordCoreAsync (cyclomatic 38) · ×1
  • SimpleLiveRecordManager2.StartRecordCoreAsync (cyclomatic 38) src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:1148 — SimpleLiveRecordManager2.StartRecordCoreAsync has cyclomatic complexity 38 (threshold 15). Of this number, 20 points are the body's own statements and 18 belong to 6 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MP4DecryptUtil.DecryptAsync (cyclomatic 38) · ×1
  • MP4DecryptUtil.DecryptAsync (cyclomatic 38) REDACTED:13 — MP4DecryptUtil.DecryptAsync has cyclomatic complexity 38 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · FilterUtil.DoFilterKeep (cyclomatic 37) · ×1
  • FilterUtil.DoFilterKeep (cyclomatic 37) src/N_m3u8DL-RE/Util/FilterUtil.cs:13 — FilterUtil.DoFilterKeep has cyclomatic complexity 37 (threshold 15). Of this number, 27 points are the body's own statements and 10 belong to 10 function literals inside it that branch. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · VodStreamPlanner.Build (cyclomatic 35) · ×1
  • VodStreamPlanner.Build (cyclomatic 35) src/N_m3u8DL-RE/Util/VodStreamPlanner.cs:12 — VodStreamPlanner.Build has cyclomatic complexity 35 (threshold 15). Of this number, 28 points are the body's own statements and 7 belong to 5 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · HLSVariableSubstitution.Process (cyclomatic 32) · ×1
  • HLSVariableSubstitution.Process (cyclomatic 32) src/N_m3u8DL-RE.Parser/Util/HLSVariableSubstitution.cs:17 — HLSVariableSubstitution.Process has cyclomatic complexity 32 (threshold 15). Of this number, 28 points are the body's own statements and 4 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DASHExtractor2.RefreshPlayListAsync (cyclomatic 30) · ×1
  • DASHExtractor2.RefreshPlayListAsync (cyclomatic 30) src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:730 — DASHExtractor2.RefreshPlayListAsync has cyclomatic complexity 30 (threshold 15). Of this number, 19 points are the body's own statements and 11 belong to 3 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MP4VttUtil.ExtractSub (cyclomatic 29) · ×1
  • MP4VttUtil.ExtractSub (cyclomatic 29) src/N_m3u8DL-RE.Parser/Mp4/MP4VttUtil.cs:55 — MP4VttUtil.ExtractSub has cyclomatic complexity 29 (threshold 15). Of this number, 22 points are the body's own statements and 7 belong to 5 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ToolCommands.CreateFileCommand (cyclomatic 27) · ×1
  • ToolCommands.CreateFileCommand (cyclomatic 27) src/N_m3u8DL-RE/CommandLine/ToolCommands.cs:93 — ToolCommands.CreateFileCommand has cyclomatic complexity 27 (threshold 15). Most of this is not in the body itself: 6 of the 27 points are its own statements and the rest belongs to one function literal inside it that branches (line 141). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
D1 · Cyclomatic Complexity · MSSExtractor.ExtractStreamsAsync (cyclomatic 26) · ×1
  • MSSExtractor.ExtractStreamsAsync (cyclomatic 26) src/N_m3u8DL-RE.Parser/Extractor/MSSExtractor.cs:45 — MSSExtractor.ExtractStreamsAsync has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DefaultHLSContentProcessor.Process (cyclomatic 25) · ×1
  • DefaultHLSContentProcessor.Process (cyclomatic 25) src/N_m3u8DL-RE.Parser/Processor/HLS/DefaultHLSContentProcessor.cs:25 — DefaultHLSContentProcessor.Process has cyclomatic complexity 25 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · SimpleDownloader.DownClipAsync (cyclomatic 24) · ×1
  • SimpleDownloader.DownClipAsync (cyclomatic 24) src/N_m3u8DL-RE/Downloader/SimpleDownloader.cs:83 — SimpleDownloader.DownClipAsync has cyclomatic complexity 24 (threshold 15). Of this number, 20 points are the body's own statements and 4 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · HLSExtractor.ParseMasterListAsync (cyclomatic 23) · ×1
  • HLSExtractor.ParseMasterListAsync (cyclomatic 23) src/N_m3u8DL-RE.Parser/Extractor/HLSExtractor.cs:83 — HLSExtractor.ParseMasterListAsync has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MediaProcessingColumn.Render (cyclomatic 22) · ×1
  • MediaProcessingColumn.Render (cyclomatic 22) src/N_m3u8DL-RE/Column/MediaProcessingColumn.cs:16 — MediaProcessingColumn.Render has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LiveSegmentDownloadQueue.AttemptAsync (cyclomatic 22) · ×1
  • LiveSegmentDownloadQueue.AttemptAsync (cyclomatic 22) src/N_m3u8DL-RE/DownloadManager/LiveSegmentDownloadQueue.cs:103 — LiveSegmentDownloadQueue.AttemptAsync has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LiveSegmentTracker.FindMatchingIndex (cyclomatic 22) · ×1
  • LiveSegmentTracker.FindMatchingIndex (cyclomatic 22) src/N_m3u8DL-RE/DownloadManager/LiveSegmentTracker.cs:52 — LiveSegmentTracker.FindMatchingIndex has cyclomatic complexity 22 (threshold 15). Of this number, 14 points are the body's own statements and 8 belong to 6 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MergeUtil.MergeByFFmpeg (cyclomatic 22) · ×1
  • MergeUtil.MergeByFFmpeg (cyclomatic 22) REDACTED:264 — MergeUtil.MergeByFFmpeg has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MP4MediaInfoUtil.ReadTiming (cyclomatic 22) · ×1
  • MP4MediaInfoUtil.ReadTiming (cyclomatic 22) src/N_m3u8DL-RE.Parser/Mp4/MP4MediaInfoUtil.cs:28 — MP4MediaInfoUtil.ReadTiming has cyclomatic complexity 22 (threshold 15). Of this number, 21 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MP4MediaInfoUtil.ReadTrackInfo (cyclomatic 22) · ×1
  • MP4MediaInfoUtil.ReadTrackInfo (cyclomatic 22) src/N_m3u8DL-RE.Parser/Mp4/MP4MediaInfoUtil.cs:120 — MP4MediaInfoUtil.ReadTrackInfo has cyclomatic complexity 22 (threshold 15). Most of this is not in the body itself: 2 of the 22 points are its own statements and the rest belongs to 4 function literals inside it that branch (lines 165, 138, 149, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D1 · Cyclomatic Complexity · HTTPUtil.GetEncodingFromBom (cyclomatic 21) · ×1
  • HTTPUtil.GetEncodingFromBom (cyclomatic 21) src/N_m3u8DL-RE.Common/Util/HTTPUtil.cs:235 — HTTPUtil.GetEncodingFromBom has cyclomatic complexity 21 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · NetscapeCookieFile.Parse (cyclomatic 21) · ×1
  • NetscapeCookieFile.Parse (cyclomatic 21) src/N_m3u8DL-RE.Common/Util/NetscapeCookieFile.cs:28 — NetscapeCookieFile.Parse has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · CommandInvoker.ParseStreamFilter (cyclomatic 20) · ×1
  • CommandInvoker.ParseStreamFilter (cyclomatic 20) src/N_m3u8DL-RE/CommandLine/CommandInvoker.cs:449 — CommandInvoker.ParseStreamFilter has cyclomatic complexity 20 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · FilterUtil.SyncStreams (cyclomatic 20) · ×1
  • FilterUtil.SyncStreams (cyclomatic 20) src/N_m3u8DL-RE/Util/FilterUtil.cs:190 — FilterUtil.SyncStreams has cyclomatic complexity 20 (threshold 15). Of this number, 15 points are the body's own statements and 5 belong to 3 function literals inside it that branch. To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D1 · Cyclomatic Complexity · MergeUtil.MergeByFFmpegAsync (cyclomatic 20) · ×1
  • MergeUtil.MergeByFFmpegAsync (cyclomatic 20) REDACTED:328 — MergeUtil.MergeByFFmpegAsync has cyclomatic complexity 20 (threshold 15). Of this number, 19 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · RecordingTrack.PrepareAsync (cyclomatic 20) · ×1
  • RecordingTrack.PrepareAsync (cyclomatic 20) src/N_m3u8DL-RE/Util/RecordingTrack.cs:214 — RecordingTrack.PrepareAsync has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DASHExtractor2.ReadTrackMetadata (cyclomatic 20) · ×1
  • DASHExtractor2.ReadTrackMetadata (cyclomatic 20) src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:645 — DASHExtractor2.ReadTrackMetadata has cyclomatic complexity 20 (threshold 15). Of this number, 15 points are the body's own statements and 5 belong to 2 function literals inside it that branch. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · DefaultHLSKeyProcessor.Process (cyclomatic 20) · ×1
  • DefaultHLSKeyProcessor.Process (cyclomatic 20) src/N_m3u8DL-RE.Parser/Processor/HLS/DefaultHLSKeyProcessor.cs:27 — DefaultHLSKeyProcessor.Process has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ConfigFile.Merge (cyclomatic 19) · ×1
  • ConfigFile.Merge (cyclomatic 19) src/N_m3u8DL-RE/CommandLine/ConfigFile.cs:140 — ConfigFile.Merge has cyclomatic complexity 19 (threshold 15). Of this number, 17 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DoctorUtil.ProbeAsync (cyclomatic 19) · ×1
  • DoctorUtil.ProbeAsync (cyclomatic 19) src/N_m3u8DL-RE/Util/DoctorUtil.cs:72 — DoctorUtil.ProbeAsync has cyclomatic complexity 19 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
D1 · Cyclomatic Complexity · MediaToolProgress.ReadFFmpeg (cyclomatic 19) · ×1
  • MediaToolProgress.ReadFFmpeg (cyclomatic 19) src/N_m3u8DL-RE/Util/MediaProcessingProgress.cs:174 — MediaToolProgress.ReadFFmpeg has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · OtherUtil.FindAvailableOutputPath (cyclomatic 19) · ×1
  • OtherUtil.FindAvailableOutputPath (cyclomatic 19) src/N_m3u8DL-RE/Util/OtherUtil.cs:293 — OtherUtil.FindAvailableOutputPath has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LiveCatchupWindow.Validate (cyclomatic 18) · ×1
  • LiveCatchupWindow.Validate (cyclomatic 18) src/N_m3u8DL-RE/DownloadManager/LiveCatchupWindow.cs:15 — LiveCatchupWindow.Validate has cyclomatic complexity 18 (threshold 15). Of this number, 17 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · StreamFilter.ToString (cyclomatic 18) · ×1
  • StreamFilter.ToString (cyclomatic 18) src/N_m3u8DL-RE/Entity/StreamFilter.cs:29 — StreamFilter.ToString has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · Program.CheckMediaTools (cyclomatic 18) · ×1
  • Program.CheckMediaTools (cyclomatic 18) REDACTED:560 — Program.CheckMediaTools has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DownloadUtil.DownloadToFileCoreAsync (cyclomatic 18) · ×1
  • DownloadUtil.DownloadToFileCoreAsync (cyclomatic 18) src/N_m3u8DL-RE/Util/DownloadUtil.cs:71 — DownloadUtil.DownloadToFileCoreAsync has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · FilterUtil.CleanAd (cyclomatic 18) · ×1
  • FilterUtil.CleanAd (cyclomatic 18) src/N_m3u8DL-RE/Util/FilterUtil.cs:328 — FilterUtil.CleanAd has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MediainfoUtil.ReadInfoAsync (cyclomatic 18) · ×1
  • MediainfoUtil.ReadInfoAsync (cyclomatic 18) src/N_m3u8DL-RE/Util/MediainfoUtil.cs:94 — MediainfoUtil.ReadInfoAsync has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MergeUtil.ConcatMediaParts (cyclomatic 18) · ×1
  • MergeUtil.ConcatMediaParts (cyclomatic 18) REDACTED:169 — MergeUtil.ConcatMediaParts has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · TSInfoUtil.DecodeText (cyclomatic 18) · ×1
  • TSInfoUtil.DecodeText (cyclomatic 18) src/N_m3u8DL-RE/Util/TSInfoUtil.cs:198 — TSInfoUtil.DecodeText has cyclomatic complexity 18 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
D1 · Cyclomatic Complexity · NetworkInterfaceBinding.Create (cyclomatic 17) · ×1
  • NetworkInterfaceBinding.Create (cyclomatic 17) src/N_m3u8DL-RE.Common/Util/NetworkInterfaceBinding.cs:30 — NetworkInterfaceBinding.Create has cyclomatic complexity 17 (threshold 15). Of this number, 12 points are the body's own statements and 5 belong to 2 function literals inside it that branch. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · IPTVExtractor.ExtractStreamsAsync (cyclomatic 17) · ×1
  • IPTVExtractor.ExtractStreamsAsync (cyclomatic 17) src/N_m3u8DL-RE.Parser/Extractor/IPTVExtractor.cs:31 — IPTVExtractor.ExtractStreamsAsync has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MP4Parser.ParseNext (cyclomatic 17) · ×1
  • MP4Parser.ParseNext (cyclomatic 17) src/N_m3u8DL-RE.Parser/Mp4/MP4Parser.cs:98 — MP4Parser.ParseNext has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ConfigFile.MergeUtility (cyclomatic 16) · ×1
  • ConfigFile.MergeUtility (cyclomatic 16) src/N_m3u8DL-RE/CommandLine/ConfigFile.cs:267 — ConfigFile.MergeUtility has cyclomatic complexity 16 (threshold 15). Of this number, 15 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · HTTPLiveRecordManager.RecordStreamAsync (cyclomatic 16) · ×1
  • HTTPLiveRecordManager.RecordStreamAsync (cyclomatic 16) src/N_m3u8DL-RE/DownloadManager/HTTPLiveRecordManager.cs:60 — HTTPLiveRecordManager.RecordStreamAsync has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ConcatInputServer.RespondAsync (cyclomatic 16) · ×1
  • ConcatInputServer.RespondAsync (cyclomatic 16) src/N_m3u8DL-RE/Util/ConcatInputServer.cs:101 — ConcatInputServer.RespondAsync has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · HTTPUtil.GetWebSourceResultAsync (cyclomatic 16) · ×1
  • HTTPUtil.GetWebSourceResultAsync (cyclomatic 16) src/N_m3u8DL-RE.Common/Util/HTTPUtil.cs:175 — HTTPUtil.GetWebSourceResultAsync has cyclomatic complexity 16 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · MSSMoovProcessor.GetSampleEntryBox (cyclomatic 16) · ×1
  • MSSMoovProcessor.GetSampleEntryBox (cyclomatic 16) src/N_m3u8DL-RE.Parser/Mp4/MSSMoovProcessor.cs:433 — MSSMoovProcessor.GetSampleEntryBox has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D17 · Explicit Debt · ObsoleteWithCallers · ×1
  • ObsoleteWithCallers src/N_m3u8DL-RE/CommandLine/MyOption.cs:163 — [Obsolete] UseShakaPackager
D17 · Explicit Debt · TodoComment · ×1
  • TodoComment REDACTED:299 — // TODO: handle the case that shaka packager actually decrypted (key ID == ZeroKid) — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
D2 · Cognitive Complexity · SimpleLiveRecordManager2.RecordStreamAsync (cognitive 357) · ×1
  • SimpleLiveRecordManager2.RecordStreamAsync (cognitive 357) src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:250 — SimpleLiveRecordManager2.RecordStreamAsync has cognitive complexity 357 (threshold 15). Of this number, 344 points are the body's own statements and 13 belong to 2 function literals inside it that branch. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · DASHExtractor2.ExtractStreamsAsync (cognitive 344) · ×1
  • DASHExtractor2.ExtractStreamsAsync (cognitive 344) src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:63 — DASHExtractor2.ExtractStreamsAsync has cognitive complexity 344 (threshold 15). Of this number, 340 points are the body's own statements and 4 belong to 3 function literals inside it that branch. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · SimpleDownloadManager.DownloadStreamAsync (cognitive 301) · ×1
  • SimpleDownloadManager.DownloadStreamAsync (cognitive 301) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:142 — SimpleDownloadManager.DownloadStreamAsync has cognitive complexity 301 (threshold 15). Of this number, 295 points are the body's own statements and 6 belong to one function literal inside it that branches. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · MergeUtil.MuxInputsAsync (cognitive 131) · ×1
  • MergeUtil.MuxInputsAsync (cognitive 131) REDACTED:416 — MergeUtil.MuxInputsAsync has cognitive complexity 131 (threshold 15). Of this number, 130 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · Program.DoWorkAsync (cognitive 129) · ×1
  • Program.DoWorkAsync (cognitive 129) REDACTED:81 — Program.DoWorkAsync has cognitive complexity 129 (threshold 15). Of this number, 128 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · HLSExtractor.ParseListAsync (cognitive 103) · ×1
  • HLSExtractor.ParseListAsync (cognitive 103) src/N_m3u8DL-RE.Parser/Extractor/HLSExtractor.cs:227 — HLSExtractor.ParseListAsync has cognitive complexity 103 (threshold 15). Of this number, 100 points are the body's own statements and 3 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FileToolUtil.ExecuteAsync (cognitive 98) · ×1
  • FileToolUtil.ExecuteAsync (cognitive 98) src/N_m3u8DL-RE/Util/FileToolUtil.cs:16 — FileToolUtil.ExecuteAsync has cognitive complexity 98 (threshold 15). Of this number, 46 points are the body's own statements and 52 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MP4TtmlUtil.ExtractSub (cognitive 98) · ×1
  • MP4TtmlUtil.ExtractSub (cognitive 98) REDACTED:193 — MP4TtmlUtil.ExtractSub has cognitive complexity 98 (threshold 15). Of this number, 97 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SimpleLiveRecordManager2.PlayListProduceCoreAsync (cognitive 78) · ×1
  • SimpleLiveRecordManager2.PlayListProduceCoreAsync (cognitive 78) src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:970 — SimpleLiveRecordManager2.PlayListProduceCoreAsync has cognitive complexity 78 (threshold 15). Of this number, 38 points are the body's own statements and 40 belong to 5 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MP4VttUtil.ExtractSub (cognitive 72) · ×1
  • MP4VttUtil.ExtractSub (cognitive 72) src/N_m3u8DL-RE.Parser/Mp4/MP4VttUtil.cs:55 — MP4VttUtil.ExtractSub has cognitive complexity 72 (threshold 15). Of this number, 61 points are the body's own statements and 11 belong to 5 function literals inside it that branch. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · TSInfoUtil.ReadServices (cognitive 70) · ×1
  • TSInfoUtil.ReadServices (cognitive 70) src/N_m3u8DL-RE/Util/TSInfoUtil.cs:12 — TSInfoUtil.ReadServices has cognitive complexity 70 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · MSSExtractor.ExtractStreamsAsync (cognitive 66) · ×1
  • MSSExtractor.ExtractStreamsAsync (cognitive 66) src/N_m3u8DL-RE.Parser/Extractor/MSSExtractor.cs:45 — MSSExtractor.ExtractStreamsAsync has cognitive complexity 66 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · HLSVariableSubstitution.Process (cognitive 66) · ×1
  • HLSVariableSubstitution.Process (cognitive 66) src/N_m3u8DL-RE.Parser/Util/HLSVariableSubstitution.cs:17 — HLSVariableSubstitution.Process has cognitive complexity 66 (threshold 15). Of this number, 61 points are the body's own statements and 5 belong to 2 function literals inside it that branch. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · SimpleDownloadManager.StartDownloadAsync (cognitive 63) · ×1
  • SimpleDownloadManager.StartDownloadAsync (cognitive 63) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:899 — SimpleDownloadManager.StartDownloadAsync has cognitive complexity 63 (threshold 15). Of this number, 21 points are the body's own statements and 42 belong to 8 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SimpleDownloadManager.DownloadPartsAsync (cognitive 54) · ×1
  • SimpleDownloadManager.DownloadPartsAsync (cognitive 54) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.Parts.cs:17 — SimpleDownloadManager.DownloadPartsAsync has cognitive complexity 54 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · HLSExtractor.ParseMasterListAsync (cognitive 54) · ×1
  • HLSExtractor.ParseMasterListAsync (cognitive 54) src/N_m3u8DL-RE.Parser/Extractor/HLSExtractor.cs:83 — HLSExtractor.ParseMasterListAsync has cognitive complexity 54 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · VodStreamPlanner.Build (cognitive 53) · ×1
  • VodStreamPlanner.Build (cognitive 53) src/N_m3u8DL-RE/Util/VodStreamPlanner.cs:12 — VodStreamPlanner.Build has cognitive complexity 53 (threshold 15). Of this number, 47 points are the body's own statements and 6 belong to 5 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SimpleLiveRecordManager2.StartRecordCoreAsync (cognitive 52) · ×1
  • SimpleLiveRecordManager2.StartRecordCoreAsync (cognitive 52) src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:1148 — SimpleLiveRecordManager2.StartRecordCoreAsync has cognitive complexity 52 (threshold 15). Of this number, 25 points are the body's own statements and 27 belong to 6 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · RecordingTrack.Read (cognitive 52) · ×1
  • RecordingTrack.Read (cognitive 52) src/N_m3u8DL-RE/Util/RecordingTrack.cs:80 — RecordingTrack.Read has cognitive complexity 52 (threshold 15). Of this number, 51 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MP4DecryptUtil.DecryptAsync (cognitive 49) · ×1
  • MP4DecryptUtil.DecryptAsync (cognitive 49) REDACTED:13 — MP4DecryptUtil.DecryptAsync has cognitive complexity 49 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · RecordingTrack.PrepareAsync (cognitive 42) · ×1
  • RecordingTrack.PrepareAsync (cognitive 42) src/N_m3u8DL-RE/Util/RecordingTrack.cs:214 — RecordingTrack.PrepareAsync has cognitive complexity 42 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · IPTVExtractor.ExtractStreamsAsync (cognitive 37) · ×1
  • IPTVExtractor.ExtractStreamsAsync (cognitive 37) src/N_m3u8DL-RE.Parser/Extractor/IPTVExtractor.cs:31 — IPTVExtractor.ExtractStreamsAsync has cognitive complexity 37 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FilterUtil.DoFilterKeep (cognitive 36) · ×1
  • FilterUtil.DoFilterKeep (cognitive 36) src/N_m3u8DL-RE/Util/FilterUtil.cs:13 — FilterUtil.DoFilterKeep has cognitive complexity 36 (threshold 15). Of this number, 26 points are the body's own statements and 10 belong to 10 function literals inside it that branch. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · FilterUtil.CleanAd (cognitive 35) · ×1
  • FilterUtil.CleanAd (cognitive 35) src/N_m3u8DL-RE/Util/FilterUtil.cs:328 — FilterUtil.CleanAd has cognitive complexity 35 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FilterUtil.SyncStreams (cognitive 34) · ×1
  • FilterUtil.SyncStreams (cognitive 34) src/N_m3u8DL-RE/Util/FilterUtil.cs:190 — FilterUtil.SyncStreams has cognitive complexity 34 (threshold 15). Of this number, 29 points are the body's own statements and 5 belong to 3 function literals inside it that branch. To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · MP4MediaInfoUtil.ReadTiming (cognitive 33) · ×1
  • MP4MediaInfoUtil.ReadTiming (cognitive 33) src/N_m3u8DL-RE.Parser/Mp4/MP4MediaInfoUtil.cs:28 — MP4MediaInfoUtil.ReadTiming has cognitive complexity 33 (threshold 15). Of this number, 32 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MSSMoovProcessor.GetSampleEntryBox (cognitive 33) · ×1
  • MSSMoovProcessor.GetSampleEntryBox (cognitive 33) src/N_m3u8DL-RE.Parser/Mp4/MSSMoovProcessor.cs:433 — MSSMoovProcessor.GetSampleEntryBox has cognitive complexity 33 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MediaProcessingColumn.Render (cognitive 32) · ×1
  • MediaProcessingColumn.Render (cognitive 32) src/N_m3u8DL-RE/Column/MediaProcessingColumn.cs:16 — MediaProcessingColumn.Render has cognitive complexity 32 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · SimpleDownloader.DownClipAsync (cognitive 32) · ×1
  • SimpleDownloader.DownClipAsync (cognitive 32) src/N_m3u8DL-RE/Downloader/SimpleDownloader.cs:83 — SimpleDownloader.DownClipAsync has cognitive complexity 32 (threshold 15). Of this number, 23 points are the body's own statements and 9 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ImageHeaderUtil.ProcessAsync (cognitive 32) · ×1
  • ImageHeaderUtil.ProcessAsync (cognitive 32) src/N_m3u8DL-RE/Util/ImageHeaderUtil.cs:23 — ImageHeaderUtil.ProcessAsync has cognitive complexity 32 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MergeUtil.MergeByFFmpeg (cognitive 32) · ×1
  • MergeUtil.MergeByFFmpeg (cognitive 32) REDACTED:264 — MergeUtil.MergeByFFmpeg has cognitive complexity 32 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · VodStreamPlanner.AlignPeriods (cognitive 32) · ×1
  • VodStreamPlanner.AlignPeriods (cognitive 32) src/N_m3u8DL-RE/Util/VodStreamPlanner.cs:171 — VodStreamPlanner.AlignPeriods has cognitive complexity 32 (threshold 15). Of this number, 28 points are the body's own statements and 4 belong to 4 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NetscapeCookieFile.Parse (cognitive 32) · ×1
  • NetscapeCookieFile.Parse (cognitive 32) src/N_m3u8DL-RE.Common/Util/NetscapeCookieFile.cs:28 — NetscapeCookieFile.Parse has cognitive complexity 32 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DASHExtractor2.RefreshPlayListAsync (cognitive 32) · ×1
  • DASHExtractor2.RefreshPlayListAsync (cognitive 32) src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:730 — DASHExtractor2.RefreshPlayListAsync has cognitive complexity 32 (threshold 15). Of this number, 28 points are the body's own statements and 4 belong to 3 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Program.CheckMediaTools (cognitive 30) · ×1
  • Program.CheckMediaTools (cognitive 30) REDACTED:560 — Program.CheckMediaTools has cognitive complexity 30 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LiveSegmentDownloadQueue.AttemptAsync (cognitive 29) · ×1
  • LiveSegmentDownloadQueue.AttemptAsync (cognitive 29) src/N_m3u8DL-RE/DownloadManager/LiveSegmentDownloadQueue.cs:103 — LiveSegmentDownloadQueue.AttemptAsync has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ConfigFile.Merge (cognitive 28) · ×1
  • ConfigFile.Merge (cognitive 28) src/N_m3u8DL-RE/CommandLine/ConfigFile.cs:140 — ConfigFile.Merge has cognitive complexity 28 (threshold 15). Of this number, 26 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ToolCommands.CreateFileCommand (cognitive 27) · ×1
  • ToolCommands.CreateFileCommand (cognitive 27) src/N_m3u8DL-RE/CommandLine/ToolCommands.cs:93 — ToolCommands.CreateFileCommand has cognitive complexity 27 (threshold 15). Most of this is not in the body itself: 5 of the 27 points are its own statements and the rest belongs to one function literal inside it that branches (line 141). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
D2 · Cognitive Complexity · LiveSegmentTracker.FindMatchingIndex (cognitive 27) · ×1
  • LiveSegmentTracker.FindMatchingIndex (cognitive 27) src/N_m3u8DL-RE/DownloadManager/LiveSegmentTracker.cs:52 — LiveSegmentTracker.FindMatchingIndex has cognitive complexity 27 (threshold 15). Of this number, 21 points are the body's own statements and 6 belong to 6 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · OtherUtil.FindAvailableOutputPath (cognitive 27) · ×1
  • OtherUtil.FindAvailableOutputPath (cognitive 27) src/N_m3u8DL-RE/Util/OtherUtil.cs:293 — OtherUtil.FindAvailableOutputPath has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ConfigFile.MergeUtility (cognitive 26) · ×1
  • ConfigFile.MergeUtility (cognitive 26) src/N_m3u8DL-RE/CommandLine/ConfigFile.cs:267 — ConfigFile.MergeUtility has cognitive complexity 26 (threshold 15). Of this number, 25 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · HLSExtractor.FetchPlayListAsync (cognitive 26) · ×1
  • HLSExtractor.FetchPlayListAsync (cognitive 26) src/N_m3u8DL-RE.Parser/Extractor/HLSExtractor.cs:635 — HLSExtractor.FetchPlayListAsync has cognitive complexity 26 (threshold 15). Of this number, 25 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DefaultHLSKeyProcessor.Process (cognitive 26) · ×1
  • DefaultHLSKeyProcessor.Process (cognitive 26) src/N_m3u8DL-RE.Parser/Processor/HLS/DefaultHLSKeyProcessor.cs:27 — DefaultHLSKeyProcessor.Process has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BinaryDownloadManager.DownloadSequentialAsync (cognitive 25) · ×1
  • BinaryDownloadManager.DownloadSequentialAsync (cognitive 25) src/N_m3u8DL-RE/DownloadManager/BinaryDownloadManager.cs:277 — BinaryDownloadManager.DownloadSequentialAsync has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NetworkInterfaceBinding.Bind (cognitive 25) · ×1
  • NetworkInterfaceBinding.Bind (cognitive 25) src/N_m3u8DL-RE.Common/Util/NetworkInterfaceBinding.cs:94 — NetworkInterfaceBinding.Bind has cognitive complexity 25 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · FileToolUtil.CompareNatural (cognitive 24) · ×1
  • FileToolUtil.CompareNatural (cognitive 24) src/N_m3u8DL-RE/Util/FileToolUtil.cs:257 — FileToolUtil.CompareNatural has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · VodStreamPlanner.AlignHlsTimeline (cognitive 24) · ×1
  • VodStreamPlanner.AlignHlsTimeline (cognitive 24) src/N_m3u8DL-RE/Util/VodStreamPlanner.Hls.cs:8 — VodStreamPlanner.AlignHlsTimeline has cognitive complexity 24 (threshold 15). Of this number, 20 points are the body's own statements and 4 belong to 3 function literals inside it that branch. To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · MP4MediaInfoUtil.ReadFragment (cognitive 24) · ×1
  • MP4MediaInfoUtil.ReadFragment (cognitive 24) src/N_m3u8DL-RE.Parser/Mp4/MP4MediaInfoUtil.cs:400 — MP4MediaInfoUtil.ReadFragment has cognitive complexity 24 (threshold 15). None of this is in the body itself: all 24 points belong to 3 function literals inside it that branch (lines 404, 412, 419). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D2 · Cognitive Complexity · MergeUtil.MergeByFFmpegAsync (cognitive 23) · ×1
  • MergeUtil.MergeByFFmpegAsync (cognitive 23) REDACTED:328 — MergeUtil.MergeByFFmpegAsync has cognitive complexity 23 (threshold 15). Of this number, 22 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MP4MediaInfoUtil.ReadSamples (cognitive 23) · ×1
  • MP4MediaInfoUtil.ReadSamples (cognitive 23) src/N_m3u8DL-RE.Parser/Mp4/MP4MediaInfoUtil.cs:359 — MP4MediaInfoUtil.ReadSamples has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MP4Parser.ParseNext (cognitive 23) · ×1
  • MP4Parser.ParseNext (cognitive 23) src/N_m3u8DL-RE.Parser/Mp4/MP4Parser.cs:98 — MP4Parser.ParseNext has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DefaultHLSContentProcessor.Process (cognitive 23) · ×1
  • DefaultHLSContentProcessor.Process (cognitive 23) src/N_m3u8DL-RE.Parser/Processor/HLS/DefaultHLSContentProcessor.cs:25 — DefaultHLSContentProcessor.Process has cognitive complexity 23 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
D2 · Cognitive Complexity · DownloadUtil.DownloadToFileCoreAsync (cognitive 22) · ×1
  • DownloadUtil.DownloadToFileCoreAsync (cognitive 22) src/N_m3u8DL-RE/Util/DownloadUtil.cs:71 — DownloadUtil.DownloadToFileCoreAsync has cognitive complexity 22 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · FilterUtil.SelectStreams (cognitive 22) · ×1
  • FilterUtil.SelectStreams (cognitive 22) src/N_m3u8DL-RE/Util/FilterUtil.cs:109 — FilterUtil.SelectStreams has cognitive complexity 22 (threshold 15). Of this number, 20 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MuxSubtitleTimeline.CreateAsync (cognitive 22) · ×1
  • MuxSubtitleTimeline.CreateAsync (cognitive 22) src/N_m3u8DL-RE/Util/MuxSubtitleTimeline.cs:38 — MuxSubtitleTimeline.CreateAsync has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ToolInputResolver.Expand (cognitive 22) · ×1
  • ToolInputResolver.Expand (cognitive 22) src/N_m3u8DL-RE/Util/ToolInputResolver.cs:21 — ToolInputResolver.Expand has cognitive complexity 22 (threshold 15). Of this number, 21 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CommandInvoker.ParseStreamFilter (cognitive 21) · ×1
  • CommandInvoker.ParseStreamFilter (cognitive 21) src/N_m3u8DL-RE/CommandLine/CommandInvoker.cs:449 — CommandInvoker.ParseStreamFilter has cognitive complexity 21 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · BinaryDownloadManager.FetchBlockAsync (cognitive 21) · ×1
  • BinaryDownloadManager.FetchBlockAsync (cognitive 21) src/N_m3u8DL-RE/DownloadManager/BinaryDownloadManager.cs:209 — BinaryDownloadManager.FetchBlockAsync has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · HTTPLiveRecordManager.RecordStreamAsync (cognitive 21) · ×1
  • HTTPLiveRecordManager.RecordStreamAsync (cognitive 21) src/N_m3u8DL-RE/DownloadManager/HTTPLiveRecordManager.cs:60 — HTTPLiveRecordManager.RecordStreamAsync has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LiveCatchupWindow.Validate (cognitive 21) · ×1
  • LiveCatchupWindow.Validate (cognitive 21) src/N_m3u8DL-RE/DownloadManager/LiveCatchupWindow.cs:15 — LiveCatchupWindow.Validate has cognitive complexity 21 (threshold 15). Of this number, 20 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MediainfoUtil.ReadInfoAsync (cognitive 21) · ×1
  • MediainfoUtil.ReadInfoAsync (cognitive 21) src/N_m3u8DL-RE/Util/MediainfoUtil.cs:94 — MediainfoUtil.ReadInfoAsync has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · WebVttSub.Parse (cognitive 21) · ×1
  • WebVttSub.Parse (cognitive 21) src/N_m3u8DL-RE.Common/Entity/WebVttSub.cs:47 — WebVttSub.Parse has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ChaCha20.WorkBytes (cognitive 20) · ×1
  • ChaCha20.WorkBytes (cognitive 20) src/N_m3u8DL-RE/Crypto/CSChaCha20.cs:408 — ChaCha20.WorkBytes has cognitive complexity 20 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · MediaToolProgress.ReadFFmpeg (cognitive 20) · ×1
  • MediaToolProgress.ReadFFmpeg (cognitive 20) src/N_m3u8DL-RE/Util/MediaProcessingProgress.cs:174 — MediaToolProgress.ReadFFmpeg has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ComplexParamParser.GetValue (cognitive 18) · ×1
  • ComplexParamParser.GetValue (cognitive 18) src/N_m3u8DL-RE/CommandLine/ComplexParamParser.cs:13 — ComplexParamParser.GetValue has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FilterUtil.ApplyCustomRange (cognitive 18) · ×1
  • FilterUtil.ApplyCustomRange (cognitive 18) src/N_m3u8DL-RE/Util/FilterUtil.cs:275 — FilterUtil.ApplyCustomRange has cognitive complexity 18 (threshold 15). Of this number, 16 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MergeUtil.ConcatMediaParts (cognitive 18) · ×1
  • MergeUtil.ConcatMediaParts (cognitive 18) REDACTED:169 — MergeUtil.ConcatMediaParts has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SectionBuffer.Append (cognitive 18) · ×1
  • SectionBuffer.Append (cognitive 18) src/N_m3u8DL-RE/Util/TSInfoUtil.cs:151 — SectionBuffer.Append has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DASHExtractor2.ReadTrackMetadata (cognitive 18) · ×1
  • DASHExtractor2.ReadTrackMetadata (cognitive 18) src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:645 — DASHExtractor2.ReadTrackMetadata has cognitive complexity 18 (threshold 15). Of this number, 13 points are the body's own statements and 5 belong to 2 function literals inside it that branch. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · ToolCommands.AddTo (cognitive 17) · ×1
  • ToolCommands.AddTo (cognitive 17) src/N_m3u8DL-RE/CommandLine/ToolCommands.cs:16 — ToolCommands.AddTo has cognitive complexity 17 (threshold 15). Most of this is not in the body itself: 1 of the 17 points is its own statement and the rest belongs to 4 function literals inside it that branch (lines 38, 53, 66, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D2 · Cognitive Complexity · LiveCatchupWindow.TimedSegments (cognitive 17) · ×1
  • LiveCatchupWindow.TimedSegments (cognitive 17) src/N_m3u8DL-RE/DownloadManager/LiveCatchupWindow.cs:77 — LiveCatchupWindow.TimedSegments has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · StreamFilter.ToString (cognitive 17) · ×1
  • StreamFilter.ToString (cognitive 17) src/N_m3u8DL-RE/Entity/StreamFilter.cs:29 — StreamFilter.ToString has cognitive complexity 17 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · MuxSubtitleTimeline.Repair (cognitive 17) · ×1
  • MuxSubtitleTimeline.Repair (cognitive 17) src/N_m3u8DL-RE/Util/MuxSubtitleTimeline.cs:135 — MuxSubtitleTimeline.Repair has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NetworkInterfaceBinding.Create (cognitive 17) · ×1
  • NetworkInterfaceBinding.Create (cognitive 17) src/N_m3u8DL-RE.Common/Util/NetworkInterfaceBinding.cs:30 — NetworkInterfaceBinding.Create has cognitive complexity 17 (threshold 15). Of this number, 14 points are the body's own statements and 3 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MP4MediaInfoUtil.ReadTrackInfo (cognitive 17) · ×1
  • MP4MediaInfoUtil.ReadTrackInfo (cognitive 17) src/N_m3u8DL-RE.Parser/Mp4/MP4MediaInfoUtil.cs:120 — MP4MediaInfoUtil.ReadTrackInfo has cognitive complexity 17 (threshold 15). Most of this is not in the body itself: 1 of the 17 points is its own statement and the rest belongs to 4 function literals inside it that branch (lines 165, 129, 138, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D2 · Cognitive Complexity · MP4MediaInfoUtil.ReadTrack (cognitive 17) · ×1
  • MP4MediaInfoUtil.ReadTrack (cognitive 17) src/N_m3u8DL-RE.Parser/Mp4/MP4MediaInfoUtil.cs:281 — MP4MediaInfoUtil.ReadTrack has cognitive complexity 17 (threshold 15). None of this is in the body itself: all 17 points belong to 5 function literals inside it that branch (lines 335, 318, 286, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D2 · Cognitive Complexity · ConcatInputServer.RespondAsync (cognitive 16) · ×1
  • ConcatInputServer.RespondAsync (cognitive 16) src/N_m3u8DL-RE/Util/ConcatInputServer.cs:101 — ConcatInputServer.RespondAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · ConcatInputServer.TryGetRange (cognitive 16) · ×1
  • ConcatInputServer.TryGetRange (cognitive 16) src/N_m3u8DL-RE/Util/ConcatInputServer.cs:159 — ConcatInputServer.TryGetRange has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MergeUtil.RunMediaToolAsync (cognitive 16) · ×1
  • MergeUtil.RunMediaToolAsync (cognitive 16) REDACTED:604 — MergeUtil.RunMediaToolAsync has cognitive complexity 16 (threshold 15). Of this number, 8 points are the body's own statements and 8 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · StreamSpec.ToString (cognitive 16) · ×1
  • StreamSpec.ToString (cognitive 16) src/N_m3u8DL-RE.Common/Entity/StreamSpec.cs:164 — StreamSpec.ToString has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · HTTPUtil.DoGetAsync (cognitive 16) · ×1
  • HTTPUtil.DoGetAsync (cognitive 16) src/N_m3u8DL-RE.Common/Util/HTTPUtil.cs:63 — HTTPUtil.DoGetAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DASHExtractor2.ResolvePeriodTimings (cognitive 16) · ×1
  • DASHExtractor2.ResolvePeriodTimings (cognitive 16) src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:706 — DASHExtractor2.ResolvePeriodTimings has cognitive complexity 16 (threshold 15). Of this number, 15 points are the body's own statements and 1 belongs to one function item inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D3 · God Classes · TooManyMethods · ×1
  • TooManyMethods: CommandInvoker src/N_m3u8DL-RE/CommandLine/CommandInvoker.cs — TooManyMethods — 586 significant lines (blank, comment-only and punctuation-only lines excluded), 34 methods. The bar is 30 methods; this is 4 over it, 1.13× the bar. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
D35 · Change Coupling · Change coupling · ×1
  • Change coupling: HTTPLiveRecordManager.cs ↔ SimpleLiveRecordManager2.cs src/N_m3u8DL-RE/DownloadManager/HTTPLiveRecordManager.cs:1 — `src/N_m3u8DL-RE/DownloadManager/HTTPLiveRecordManager.cs` and `src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs` change together 64% of the time (7 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `d07cf222` 优化终端配色以兼顾深浅背景 (#998); `e9254c6e` 修复直播录制时长统计和字幕偏移精度 (#975); `3518c87c` 直播录制时显示已录制文件大小 (#960) — run `git show` on any of them.
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D4 · Code Duplication · Edited copy of a member (33 corresponding lines) · ×1
  • Edited copy of a member (33 corresponding lines) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:75 — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:75-107 | src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:211-244 — These two members are one piece of code written twice and then edited apart: 33 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (22 corresponding lines) · ×1
  • Edited copy of a member (22 corresponding lines) src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:816 — src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:816-839 | src/N_m3u8DL-RE.Parser/Extractor/MSSExtractor.cs:311-332 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (11 corresponding lines) · ×1
  • Edited copy of a member (11 corresponding lines) src/N_m3u8DL-RE.Parser/Mp4/BinaryWriter2.cs:48 — src/N_m3u8DL-RE.Parser/Mp4/BinaryWriter2.cs:48-58 | src/N_m3u8DL-RE.Parser/Mp4/BinaryWriter2.cs:61-71 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (4 corresponding lines) · ×1
  • Edited copy of a member (4 corresponding lines) src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:37 — src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:37-40 | src/N_m3u8DL-RE.Parser/Extractor/MSSExtractor.cs:40-43 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (25–26 lines × 2) · ×1
  • Duplicated block (25–26 lines × 2) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:665 — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:665-689 | src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:718-743 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:665` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (21 lines × 2) · ×1
  • Duplicated block (21 lines × 2) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:1073 — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:1073-1093 | src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:1345-1365 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:1073` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (18 lines × 2) · ×1
  • Duplicated block (18 lines × 2) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:1045 — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:1045-1062 | src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:1312-1329 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:1045` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:1330` calls `CleanupRecording` and `src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:1063` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (19 lines × 2) · ×1
  • Duplicated block (19 lines × 2) src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:732 — src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:732-750 | src/N_m3u8DL-RE.Parser/Extractor/MSSExtractor.cs:360-378 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:732` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (14 lines × 2) · ×1
  • Duplicated block (14 lines × 2) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:385 — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:385-398 | src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:484-497 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (16 lines × 2) · ×1
  • Duplicated block (16 lines × 2) src/N_m3u8DL-RE/DownloadManager/HTTPLiveRecordManager.cs:273 — src/N_m3u8DL-RE/DownloadManager/HTTPLiveRecordManager.cs:273-288 | src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:915-936 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (14 lines × 4) · ×1
  • Duplicated block (14 lines × 4) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:591 — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:591-604 | src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:634-647 | src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:683-696 | src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:737-750 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:679` calls `TryWriteImagePngsAsync`, `GetEnvironmentVariable` and `src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:633` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (3–15 lines × 3) · ×1
  • Duplicated block (3–15 lines × 3) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.Parts.cs:25 — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.Parts.cs:25-27 | src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:205-219 | src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:293-307 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (15 lines × 2) · ×1
  • Duplicated block (15 lines × 2) src/N_m3u8DL-RE/Util/VodStreamPlanner.Hls.cs:25 — src/N_m3u8DL-RE/Util/VodStreamPlanner.Hls.cs:25-39 | src/N_m3u8DL-RE/Util/VodStreamPlanner.cs:196-210 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/N_m3u8DL-RE/Util/VodStreamPlanner.Hls.cs:25` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (13 lines × 2) · ×1
  • Duplicated block (13 lines × 2) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:363 — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:363-375 | src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:460-472 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:363` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:473` calls `Add`, `TrackFile` and `src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:376` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (10–11 lines × 2) · ×1
  • Duplicated block (10–11 lines × 2) src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:387 — src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:387-396 | src/N_m3u8DL-RE.Parser/Extractor/MSSExtractor.cs:149-159 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:387` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (4–10 lines × 3) · ×1
  • Duplicated block (4–10 lines × 3) src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:622 — src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:622-625 | src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:682-691 | src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:726-735 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:682` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (7 lines × 3) · ×1
  • Duplicated block (7 lines × 3) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:580 — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:580-586 | src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:667-673 | src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:720-726 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:580` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (5 lines × 3) · ×1
  • Duplicated block (5 lines × 3) src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:319 — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:319-323 | src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:517-521 | src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:564-568 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:319` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (10 lines × 3) · ×1
  • Duplicated block (10 lines × 3) src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:849 — src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:849-858 | src/N_m3u8DL-RE.Parser/Extractor/HLSExtractor.cs:72-81 | src/N_m3u8DL-RE.Parser/Extractor/MSSExtractor.cs:336-345 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
IC1 · Incompleteness & stubs · Both branches open with the same statements · ×1
  • Both branches open with the same statements — the condition does not decide them src/N_m3u8DL-RE.Common/Log/CustomAnsiConsole.cs:82 — The first 2 statements of the `if` and of the `else` are identical, so they run on both paths regardless of the condition. Lift them above the `if` — leaving them duplicated inside makes the branches read as though they handled this differently.
IC1 · Incompleteness & stubs · Skeleton type · ×1
  • Skeleton type — most members are unfinished src/N_m3u8DL-RE.Parser/Extractor/LiveTSExtractor.cs:8 — `LiveTSExtractor` has 4 unfinished members out of 7 declared members (methods, properties, indexers and events, whether or not each carries a body) — a scaffolded type that was never implemented.
SC1 · Supply-chain hygiene · NuGet dependencies are not locked · ×1
  • NuGet dependencies are not locked — No packages.lock.json and no central package management — restores aren't reproducible or pinned (SSDF PW.4.4). Enable <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile> (commit the lockfile) or adopt Directory.Packages.props. Advisory — never scored.
X1 · Async correctness · Blocking `Thread.Sleep` inside an `async` method · ×1
  • Blocking `Thread.Sleep` inside an `async` method src/N_m3u8DL-RE/CommandLine/CommandInvoker.cs:954 — `Thread.Sleep` parks the thread for the whole delay: no other work runs on it, and under load the pool must grow to make up for it. `await Task.Delay(…)` suspends only this method.
X1 · Async correctness · Blocking `File.ReadAllText` inside an `async` method · ×1
  • Blocking `File.ReadAllText` inside an `async` method src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:564 — `File.ReadAllText` blocks the thread on I/O while `File.ReadAllTextAsync` exists to wait without one — inside a method that is already `async`, await the twin.
X1 · Async correctness · Blocking `PipeUtil.CreatePipe` inside an `async` method · ×1
  • Blocking `PipeUtil.CreatePipe` inside an `async` method src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:788 — `PipeUtil.CreatePipe` is a synchronous helper that blocks (`Thread.Sleep`): called from an `async` method it parks the thread exactly as the inline call would. Make the helper `async` and `await` it (`await Task.Delay`, `SemaphoreSlim.WaitAsync`, a `TaskCompletionSource` instead of the poll).
X13 · Undrained process stream · Redirected process stream is never drained (deadlock) · ×1
  • Redirected process stream is never drained (deadlock) REDACTED:20 — `RedirectStandardOutput` is set here, but `StandardOutput` is not being read when the code waits for the child to exit — it is never read, read only later, or read only in part. The child blocks as soon as it fills the StandardOutput pipe (~4 KB, never more than 64 KB), so it never finishes and never exits, and the read or wait above never returns: a `WaitForExit` timeout after a read does not help: the timeout bounds the WAIT, not the read that precedes it. Drain every redirected stream before blocking on the child — read one on a background thread (`BeginOutputReadLine()` with its `DataReceived` handler, or a `Task` running `ReadToEndAsync()` started before the other read and awaited after it) — or stop redirecting the stream you do not consume.
X18 · Disposal-pattern correctness · Finalizer on a type that owns no unmanaged resource · ×1
  • Finalizer on a type that owns no unmanaged resource src/N_m3u8DL-RE/Crypto/CSChaCha20.cs:522 — `ChaCha20` declares a finalizer (line 522), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization.
X3 · Exception handling · Swallowed exception (caught, then discarded) · ×1
  • Swallowed exception (caught, then discarded) REDACTED:662 — `catch (Exception)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Minor — 77 finding(s)
IC1 · Incompleteness & stubs · Commented-out code · ×27
  • Commented-out code src/N_m3u8DL-RE.Parser/Extractor/HLSExtractor.cs:588 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code src/N_m3u8DL-RE.Parser/Mp4/MP4InitUtil.cs:72 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code src/N_m3u8DL-RE.Parser/Mp4/MP4Parser.cs:114 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code REDACTED:101 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code REDACTED:102 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code src/N_m3u8DL-RE.Parser/Mp4/MP4VttUtil.cs:194 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code src/N_m3u8DL-RE.Parser/Mp4/MSSMoovProcessor.cs:229 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code src/N_m3u8DL-RE.Parser/Mp4/MSSMoovProcessor.cs:230 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code src/N_m3u8DL-RE.Parser/Mp4/MSSMoovProcessor.cs:637 — 16 consecutive lines of code sit inside a `/* … */` block — a block of code switched off rather than removed, which rots and confuses. Delete it (version control remembers).
  • Commented-out code src/N_m3u8DL-RE.Parser/Mp4/MSSMoovProcessor.cs:669 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code src/N_m3u8DL-RE.Parser/Mp4/MSSMoovProcessor.cs:756 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code src/N_m3u8DL-RE.Parser/Mp4/MSSMoovProcessor.cs:864 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code src/N_m3u8DL-RE.Parser/Mp4/MSSMoovProcessor.cs:865 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code src/N_m3u8DL-RE.Parser/Processor/HLS/DefaultHLSContentProcessor.cs:43 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code src/N_m3u8DL-RE.Parser/StreamExtractor.cs:98 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code src/N_m3u8DL-RE.Parser/StreamExtractor.cs:105 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:710 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:711 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:712 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:698 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:699 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:700 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:740 — 6 consecutive lines of code sit inside a `/* … */` block — a block of code switched off rather than removed, which rots and confuses. Delete it (version control remembers).
  • Commented-out code src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs:1184 — 6 consecutive lines of code sit inside a `/* … */` block — a block of code switched off rather than removed, which rots and confuses. Delete it (version control remembers).
  • Commented-out code src/N_m3u8DL-RE/Downloader/SimpleDownloader.cs:61 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • + 2 more in this group — see findings.md.
X10 · Duplicated predicate · Duplicated predicate · ×19
  • Duplicated predicate src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:78 — `!DownloaderConfig.MyOptions.BinaryMerge && legacyDolbyVision` appears character-identically in 2 files — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs, src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:279 — `!DownloaderConfig.MyOptions.BinaryMerge && streamSpec.MediaType != MediaType.SUBTITLES` appears character-identically in 2 files — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs, src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:319 — `(mediaInit.IsEncrypted || !string.IsNullOrEmpty(currentKID)) && DownloaderConfig.MyOptions.MP4RealTimeDecryption && !string.IsNullOrEmpty(cu…` appears character-identically in 2 files — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs, src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:705 — `DownloaderConfig.MyOptions.AutoSubtitleFix && streamSpec is { MediaType: Common.Enum.MediaType.SUBTITLES, Extension: not null } && streamSpe…` appears character-identically in 2 files — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs, src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:657 — `DownloaderConfig.MyOptions.AutoSubtitleFix && streamSpec is { MediaType: Common.Enum.MediaType.SUBTITLES, Extension: not null } && streamSpe…` appears character-identically in 2 files — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs, src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:555 — `DownloaderConfig.MyOptions.AutoSubtitleFix && streamSpec is { MediaType: Common.Enum.MediaType.SUBTITLES, Extension: not null } && streamSpe…` appears character-identically in 2 files — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs, src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:613 — `DownloaderConfig.MyOptions.AutoSubtitleFix && streamSpec.MediaType == Common.Enum.MediaType.SUBTITLES && streamSpec.Codecs != "stpp" && stre…` appears character-identically in 2 files — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs, src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:84 — `DownloaderConfig.MyOptions.MuxAfterDone && legacyDolbyVision && DownloaderConfig.MyOptions.MuxOptions?.UseMkvmerge != true` appears character-identically in 2 files — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs, src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/N_m3u8DL-RE/DownloadManager/HTTPLiveRecordManager.cs:45 — `OperatingSystem.IsWindows() || OperatingSystem.IsMacOS()` appears character-identically in 5 files — src/N_m3u8DL-RE/DownloadManager/HTTPLiveRecordManager.cs, src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs, src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs, src/N_m3u8DL-RE/Util/FileToolUtil.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:328 — `decryptEngine == DecryptEngine.MP4DECRYPT && DownloaderConfig.MyOptions.Keys is { Length: > 0 }` appears character-identically in 2 files — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs, src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/N_m3u8DL-RE/DownloadManager/LiveSegmentNotFoundPolicy.cs:31 — `double.IsFinite(segment.Duration) && segment.Duration > 0` appears character-identically in 2 files — src/N_m3u8DL-RE/DownloadManager/LiveSegmentNotFoundPolicy.cs, src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:1080 — `exitCode == 0 || DownloaderConfig.MyOptions.MuxOptions.UseMkvmerge && exitCode == 1` appears character-identically in 2 files — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs, src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/N_m3u8DL-RE/Util/VodStreamPlanner.cs:196 — `intervals.Count > 0 && span.Start <= intervals[^1].End + 0.001` appears character-identically in 2 files — src/N_m3u8DL-RE/Util/VodStreamPlanner.Hls.cs, src/N_m3u8DL-RE/Util/VodStreamPlanner.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:76 — `mediainfos.Any(m => m.DolbyVison) && !await BinaryToolUtil.FFmpegSupportsDolbyVisionAsync(DownloaderConfig.MyOptions.FFmpegBinaryPath)` appears character-identically in 2 files — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs, src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:371 — `seg.IsEncrypted && DownloaderConfig.MyOptions.MP4RealTimeDecryption && !string.IsNullOrEmpty(currentKID)` appears character-identically in 2 files — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs, src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:448 — `seg.IsEncrypted && DownloaderConfig.MyOptions.MP4RealTimeDecryption && result is { Success: true } && !string.IsNullOrEmpty(currentKID)` appears character-identically in 2 files — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs, src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/N_m3u8DL-RE/Util/VodStreamPlanner.cs:239 — `span.Start >= i.Start && span.End <= i.End` appears character-identically in 2 files — src/N_m3u8DL-RE/Util/VodStreamPlanner.Hls.cs, src/N_m3u8DL-RE/Util/VodStreamPlanner.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs:1046 — `success && DownloaderConfig.MyOptions.MuxAfterDone && OutputFiles.Count > 0` appears character-identically in 2 files — src/N_m3u8DL-RE/DownloadManager/SimpleDownloadManager.cs, src/N_m3u8DL-RE/DownloadManager/SimpleLiveRecordManager2.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/N_m3u8DL-RE/Column/BinaryDownloadSpeedColumn.cs:16 — `task.IsFinished || task.StopTime != null || !task.IsStarted` appears character-identically in 2 files — src/N_m3u8DL-RE/Column/BinaryDownloadSpeedColumn.cs, src/N_m3u8DL-RE/Column/DownloadSpeedColumn.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
X7 · Silent fallback defaults · Silent fallback default in catch · ×4
  • Silent fallback default in catch src/N_m3u8DL-RE/DownloadManager/BinaryDownloadManager.cs:114 — `SupportsRangesAsync` swallows `Exception` into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
  • Silent fallback default in catch src/N_m3u8DL-RE/Util/BinaryToolUtil.cs:41 — `ProbeDolbyVisionAsync` swallows `Exception` into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
  • Silent fallback default in catch REDACTED:160 — `CanSkipPartsNormalization` swallows `Exception` into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
  • Silent fallback default in catch src/N_m3u8DL-RE/Util/TSInfoUtil.cs:246 — `DecodeText` swallows `ArgumentException` into `return "";` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
D24 · Comment Value · redundant comment · ×3
  • redundant comment src/N_m3u8DL-RE.Parser/Mp4/MP4VttUtil.cs:128 — "Read the payload size." repeats the code it sits on: 3 of its 3 words (read, payload, size) are already in `var payloadSize = (int)reader.ReadUInt32();`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment src/N_m3u8DL-RE.Parser/Mp4/MSSMoovProcessor.cs:672 — "general_profile_space + general_tier_flag + general_profile_idc" repeats the code it sits on: 6 of its 6 words (general, profile, space, tier, flag, idc) are already in `writer.WriteByte((byte)((generalProfileSpace << 6) + (generalTierFlag == 1 ? 0x20 : 0) | generalProfileIdc)); // general …`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment src/N_m3u8DL-RE.Parser/Mp4/MSSMoovProcessor.cs:673 — "general_profile_compatibility_flags" repeats the code it sits on: 4 of its 4 words (general, profile, compatibility, flags) are already in `writer.WriteUInt(generalProfileCompatibilityFlags); // general_profile_compatibility_flags`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
X7 · Silent fallback defaults · Silent fallback default on parse failure · ×3
  • Silent fallback default on parse failure REDACTED:78 — `GetOrder` falls back to `0` when `int.TryParse(str, out var order)` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
  • Silent fallback default on parse failure src/N_m3u8DL-RE/Util/VodPartSelector.cs:162 — `ResolutionArea` falls back to `0` when `values.Length == 2 && int.TryParse(values[0], out var width) && int.TryParse(val…` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
  • Silent fallback default on parse failure src/N_m3u8DL-RE/Util/VodStreamPlanner.cs:315 — `Pixels` falls back to `0` when `values is { Length: 2 } && long.TryParse(values[0], out var width) && long.TryPa…` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
D20 · ADR Quality · No ADRs found · ×1
  • No ADRs found — No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`.
D21 · Naming Consistency · `RefreshUrlFromMaster` returns an awaitable but lacks the `Async` suffix its 13 peers carry · ×1
  • `RefreshUrlFromMaster` returns an awaitable but lacks the `Async` suffix its 13 peers carry src/N_m3u8DL-RE.Parser/Extractor/HLSExtractor.cs:617 — 13 of the 14 awaitable methods of project N_m3u8DL-RE.Parser are named with an affix the repository binds to awaitables (13 of 14; unit: awaitable methods of project N_m3u8DL-RE.Parser). Peers: DASHExtractor2.ProcessUrlAsync (src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:815); HLSExtractor.ParseMasterListAsync (src/N_m3u8DL-RE.Parser/Extractor/HLSExtractor.cs:83); HLSExtractor.ParseListAsync (src/N_m3u8DL-RE.Parser/Extractor/HLSExtractor.cs:227); HLSExtractor.LoadM3u8FromUrlAsync (src/N_m3u8DL-RE.Parser/Extractor/HLSExtractor.cs:586); IExtractor.ExtractStreamsAsync (src/N_m3u8DL-RE.Parser/Extractor/IExtractor.cs:13). Rename to `RefreshUrlFromMasterAsync`. [rule N4b]
D21 · Naming Consistency · `CombineURL` spells `URL` where 39 names in the project spell it `Url` · ×1
  • `CombineURL` spells `URL` where 39 names in the project spell it `Url` src/N_m3u8DL-RE.Parser/Util/ParserUtil.cs:107 — 39 of 40 names in project N_m3u8DL-RE.Parser spell the token `Url` (39 of 40; unit: names in project N_m3u8DL-RE.Parser containing `Url`). Peers: ParserConfig.OriginalUrl (src/N_m3u8DL-RE.Parser/Config/ParserConfig.cs:12); ParserConfig.BaseUrl (src/N_m3u8DL-RE.Parser/Config/ParserConfig.cs:14); ParserConfig.AppendUrlParams (src/N_m3u8DL-RE.Parser/Config/ParserConfig.cs:70); BinaryExtractor.PreProcessUrl (src/N_m3u8DL-RE.Parser/Extractor/BinaryExtractor.cs:16); DASHExtractor2.MpdUrl (src/N_m3u8DL-RE.Parser/Extractor/DASHExtractor2.cs:22). Rename to `CombineUrl`. [rule N6]
D21 · Naming Consistency · `InvokeArgs` returns an awaitable but lacks the `Async` suffix its 93 peers carry · ×1
  • `InvokeArgs` returns an awaitable but lacks the `Async` suffix its 93 peers carry src/N_m3u8DL-RE/CommandLine/CommandInvoker.cs:891 — 93 of the 94 awaitable methods of project N_m3u8DL-RE are named with an affix the repository binds to awaitables (93 of 94; unit: awaitable methods of project N_m3u8DL-RE). Peers: ChaCha20.EncryptStreamAsync (src/N_m3u8DL-RE/Crypto/CSChaCha20.cs:215); ChaCha20.DecryptStreamAsync (src/N_m3u8DL-RE/Crypto/CSChaCha20.cs:307); ChaCha20.WorkStreamsAsync (src/N_m3u8DL-RE/Crypto/CSChaCha20.cs:383); BinaryDownloadManager.DownloadAsync (src/N_m3u8DL-RE/DownloadManager/BinaryDownloadManager.cs:36); BinaryDownloadManager.DownloadAsync (src/N_m3u8DL-RE/DownloadManager/BinaryDownloadManager.cs:50). Rename to `InvokeArgsAsync`. [rule N4b]
D28 · Secrets (history) · Rotate the exposed credentials · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
M2 · Architecture documentation · No ADRs · ×1
  • No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
M2 · Architecture documentation · No architecture diagram/doc · ×1
  • No architecture diagram/doc — No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.
P12 · CI test-gate honesty · Sleep-based test synchronization · ×1
  • Sleep-based test synchronization — 11 Task.Delay/Thread.Sleep call(s) in test code synchronize with background work by sleeping — a known flakiness precursor on slow runners. Prefer polling with a deadline or completion signals.
P3 · Security & performance tooling · No SAST · ×1
  • No SAST — No static application security testing detected. For this repository's stack, add CodeQL's csharp pack, or a .NET security analyzer package (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 1 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
P3 · Security & performance tooling · No dependency-update automation · ×1
  • No dependency-update automation src/N_m3u8DL-RE.Common/N_m3u8DL-RE.Common.csproj:13 — `src/N_m3u8DL-RE.Common/N_m3u8DL-RE.Common.csproj` declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices — including after an advisory is published against it. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per ecosystem the tree uses (or an enabled `renovate.json`), and gate pull requests with `actions/dependency-review-action`.
P6 · Release Hygiene · No changelog · ×1
  • No changelog — No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
S1 · Web-Security Posture · No security response headers detected · ×1
  • No security response headers detected — None of the 11 security response headers the OWASP Secure Headers Project recommends (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options, …) is configured — defense in depth, even when a reverse proxy could set them. (−2.0 on this card.)
S1 · Web-Security Posture · No app-layer HTTPS enforcement detected · ×1
  • No app-layer HTTPS enforcement detected — No UseHttpsRedirection/UseHsts and no reverse-proxy signal — transport security is unverified at the app layer. (−2.0 on this card.)
X2 · Cancellation propagation · Not all async methods take a CancellationToken · ×1
  • Not all async methods take a CancellationToken — Only 47/114 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
X23 · Unguarded diagnostic materialisation · Diagnostic log message is built whether or not it is wanted · ×1
  • Diagnostic log message is built whether or not it is wanted REDACTED:614 — `Debug` at line 614 is called with an argument built by `string.Join(" ", arguments.Select(argument => $"\"{argument}\""))` (line 614), whose cost grows with the collection it walks. C# evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because Debug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: no `IsEnabled` test, no debug flag, no conditional-compilation region.
X5 · Nullable reference types · Null-forgiving operator (`!`) suppressions override nullable warnings · ×1
  • Null-forgiving operator (`!`) suppressions override nullable warnings — ~1.7 `!` suppressions per 1k syntax nodes — 251 suppression(s) across the 149017 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide. Many are correct: each is a claim the checker could not verify, and it is wrong only where the value can in fact be missing, so review the densest places first.
Minor — 2 finding(s)
D24 · Comment Value · doc comments repeat the names · ×1
  • doc comments repeat the names src/N_m3u8DL-RE/Crypto/CSChaCha20.cs:572 — 0 of 60 documented parameters and 0 of 36 summaries in `N_m3u8DL-RE` only repeat the member or parameter name (e.g. "" for `v`). 12 documentation tag(s) are empty. Delete the restating tags, or add what the name does not say.
D5 · Coupling · Off the main sequence · ×1
  • Off the main sequence: N_m3u8DL-RE.Common src/N_m3u8DL-RE.Common/N_m3u8DL-RE.Common.csproj:1 — N_m3u8DL-RE.Common: abstractness 0.00, instability 0.00, distance 1.00 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

DimensionToolVersionCommandFindingsRaw output
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-bef0fd0e1eda4bdeac9434163981aaa2/history.json --exit-code 0 --source .3artifacts/raw/gitleaks-history.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-git --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-bef0fd0e1eda4bdeac9434163981aaa2/tree.json --exit-code 0 --source .0artifacts/raw/gitleaks-tree.json
D29 · Static Analysis (SAST)semgrep—semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --config /opt/semgrep-rules/canine-sast.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off --exclude *.arrow --exclude *.avro --exclude *.csv --exclude *.dat --exclude *.db --exclude *.feather --exclude *.geojson --exclude *.h5 --exclude *.hdf5 --exclude *.jsonl --exclude *.log --exclude *.ndjson --exclude *.npy --exclude *.npz --exclude *.orc --exclude *.parquet --exclude *.pickle --exclude *.pkl --exclude *.psv --exclude *.sqlite --exclude *.sqlite3 --exclude *.tfrecord --exclude *.tsv --exclude *.txt .45artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilitiesdotnet—dotnet list src/N_m3u8DL-RE.sln package --vulnerable --include-transitive --format json1artifacts/raw/dotnet-vulnerable.json
D31 · IaC & Container Securitytrivy—trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.0—
D32 · Data Compliance (PII/GDPR)semgrep—semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 24 file(s) — `src/N_m3u8DL-RE.Common/Entity/WebSourceResult.cs`, `src/N_m3u8DL-RE.Common/Log/CustomAnsiConsole.cs`, `src/N_m3u8DL-RE.Common/Log/Logger.cs`, `src/N_m3u8DL-RE.Common/Util/CookieFileHandler.cs`, `src/N_m3u8DL-RE.Common/Util/CookieFileJar.cs`, … (+19 more) — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.0—
D37 · Vulnerability-disclosure Policydisclosure—disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.0—
D40 · Network Egress Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.0—
D41 · Kernel & Syscall Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.0—
D42 · Runtime Threat Enforcementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.0—
D43 · Malicious Dependenciesosv-scanner—osv-scanner --format json --recursive --experimental-disable-plugins transitivedependency/requirements --experimental-disable-plugins dotnet/csproj --experimental-disable-plugins dotnet/nugetcpm . /tmp/codehealth-osv-sbom-ae9304cbae6d43008059b401c55d75120artifacts/raw/osv-scanner.json

Run 01a1cd4b-a228-76ef-a384-966560f1a3cb · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Downloadable artifacts

Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.

⬇ Findings, MITRE CWE-tagged .sarif⬇ Health changelog .md