Public report of mtransitapps/mtransit-for-android, published 17 November 2026. It has the same score, grades and number of
findings as the full report. The details of security findings (where they are in the code, which known
vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive reportMeasured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.11.4). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey →
Signed and filed in the standard's public register, 17 November 2026, 04:53 UTC · Survey ID cd_3319daf036524042a9910679e72b1c4c
mtransitapps/mtransit-for-android
Measured 17 November 2026, 04:52 UTC, at code version 9a31898
First survey, so nothing to compare with yet
CAI scoreWeak
CriticalWeakAdequateStrongExemplary
The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.
A medium codebase: 56,047 lines of product code in 1 project, tests not counted · Estimated rebuild effort: about 0.4 person-years · Weakest lens: Security and Compliance, 33.3
Findings by how serious they are
147 critical443 serious29 minor
16 dimensions are left out of the score. For each one, we either couldn't measure it in this code, or found no evidence of the safeguard we look for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.
This survey was produced by
Canine Code Analyzer
Producer
Canine Development
Analyzer
Canine Code Analyzer engine 1.0.0
Measured
17 November 2026, 04:52 UTC
A measurement, not a certificate. The Code Assurance Index records a number
together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee
the code. The standard was written by Canine Development, which also builds the Canine Code Analyzer. It is open to any tool that
implements it, and today the Canine Code Analyzer is the only one that does.
The score is deterministic, which means the same code always gets the same score. We work it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸
38of 38 dimensions measured by tools.
611of 619 findings point to an exact file and line, so you can open each one in the code. The other 8 concern the repository as a whole, such as missing documentation.
38dimensions across 6 lenses, read from 56,047 lines of product code in 1 project.
mtransitapps/mtransit-for-android falls short of our standard for production, in part because it has weaknesses in the build pipeline's configuration. It scores 49.7 out of 100 and is rated Weak, and all 147 of its critical findings are security problems in the build pipeline and in its automatic dependency updates.
Security and Compliance, at 33.3, is the weakest lens and counts most in the score. The best first step is fixing the 96 weaknesses in the build pipeline's configuration, worth about 12.0 points. Fixing the 13 pipeline jobs with more access than they need comes next, worth about 9.9 points. Raising Security and Compliance to 70 would lift the score to about 62.5.
Forty-eight pipeline tools are referenced by a changeable name, so the build pipeline can be tampered with. One automatic update takes new releases before a bad one can be spotted. Pinning each tool to an exact version and setting a waiting period for automatic updates would close both risks. Correcting the flagged pipeline settings would fix the 96 weaknesses in the build pipeline's configuration, and passing outside input through environment variables would deal with the pipeline step that puts outside input straight into a shell command.
The product code is 56,047 lines, about €56,000 to rebuild.
A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.
How the score is built: what each lens counts forThe lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
If Security and Compliance rose from 33.3 to 70, the lowest score rated Strong, the score would rise from 49.7 to about 62.5.
Code composition: what the lines of code are
Product code 94%Tests 6%
Rebuild cost: about €56,000 · Estimate
Cost to rebuild
€19,000 to €93,000, for 309 to 981 hours of work, about 0.4 person-years for one engineer
Difficulty of the problem
Standard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor
×0.7 at a score of 50. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
Size
Medium: 56,047 lines of product code
What it is not
Not a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.
How the estimate is made: We price the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.
Top priorities
The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.
1
Resolve the 96 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (24), REDACTED (24), REDACTED (20).
Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.
Where the investment is most exposed · Value at risk
This code would cost about €56,000 to build again, about 0.4 person-years of work. Its weakest lens is Security and Compliance, at 33.3 (Weak). Security and Compliance is about how well the product is protected, and how it handles personal data. Because the weakest lens counts most in the score, work on Security and Compliance also moves the score most.
Based on: the rebuild estimate · the Security and Compliance grade · how much each lens counts
What to do: Start with the Security and Compliance actions in Top priorities.
If you do one thing first · First action
Resolve the 96 REDACTED finding(s) in Static Analysis (SAST). Of all the actions in this report, it raises the score most for the work it takes: about 12.0 points for medium effort, because it clears the 96 Static Analysis (SAST) findings. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
Architecture: which parts of the code depend on which
The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.
239 modules, with 468 dependencies between them. 2 loops run through 33 of the modules, marked above the diagonal.
The table shows the 40 modules with the most connections; 199 more are left out to keep it readable.
Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
ui.inappnotification.moduledisabled uses data, so a change to data can break ui.inappnotification.moduledisabled, while a change to ui.inappnotification.moduledisabled can't break data.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
datasource uses provider.remoteconfig, so a change to provider.remoteconfig can break datasource, while a change to datasource can't break provider.remoteconfig.
Position
Below the diagonal: datasource uses a module listed above it, which is the healthy direction.
provider.location uses ui.view.common, so a change to ui.view.common can break provider.location, while a change to provider.location can't break ui.view.common.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
provider.direction uses provider.remoteconfig, so a change to provider.remoteconfig can break provider.direction, while a change to provider.direction can't break provider.remoteconfig.
Position
Below the diagonal: provider.direction uses a module listed above it, which is the healthy direction.
provider.direction uses provider.location, so a change to provider.location can break provider.direction, while a change to provider.direction can't break provider.location.
Position
Below the diagonal: provider.direction uses a module listed above it, which is the healthy direction.
ui.view.common uses provider.location, so a change to provider.location can break ui.view.common, while a change to ui.view.common can't break provider.location.
Position
Below the diagonal: ui.view.common uses a module listed above it, which is the healthy direction.
provider.sensor uses ui.view.common, so a change to ui.view.common can break provider.sensor, while a change to provider.sensor can't break ui.view.common.
Position
Below the diagonal: provider.sensor uses a module listed above it, which is the healthy direction.
ui.news uses ui.inappnotification.moduledisabled, so a change to ui.inappnotification.moduledisabled can break ui.news, while a change to ui.news can't break ui.inappnotification.moduledisabled.
Position
Below the diagonal: ui.news uses a module listed above it, which is the healthy direction.
ui.splash uses provider.remoteconfig, so a change to provider.remoteconfig can break ui.splash, while a change to ui.splash can't break provider.remoteconfig.
Position
Below the diagonal: ui.splash uses a module listed above it, which is the healthy direction.
ui.fragment uses provider.remoteconfig, so a change to provider.remoteconfig can break ui.fragment, while a change to ui.fragment can't break provider.remoteconfig.
Position
Below the diagonal: ui.fragment uses a module listed above it, which is the healthy direction.
ui.fragment uses provider.direction, so a change to provider.direction can break ui.fragment, while a change to ui.fragment can't break provider.direction.
Position
Below the diagonal: ui.fragment uses a module listed above it, which is the healthy direction.
billing uses provider.remoteconfig, so a change to provider.remoteconfig can break billing, while a change to billing can't break provider.remoteconfig.
Position
Below the diagonal: billing uses a module listed above it, which is the healthy direction.
ui.news.details uses ui.view.common, so a change to ui.view.common can break ui.news.details, while a change to ui.news.details can't break ui.view.common.
Position
Below the diagonal: ui.news.details uses a module listed above it, which is the healthy direction.
ui.serviceupdates uses ui.view.common, so a change to ui.view.common can break ui.serviceupdates, while a change to ui.serviceupdates can't break ui.view.common.
Position
Below the diagonal: ui.serviceupdates uses a module listed above it, which is the healthy direction.
ui.serviceupdates uses ui.fragment, so a change to ui.fragment can break ui.serviceupdates, while a change to ui.serviceupdates can't break ui.fragment.
Position
Below the diagonal: ui.serviceupdates uses a module listed above it, which is the healthy direction.
ad.rewarded uses provider.remoteconfig, so a change to provider.remoteconfig can break ad.rewarded, while a change to ad.rewarded can't break provider.remoteconfig.
Position
Below the diagonal: ad.rewarded uses a module listed above it, which is the healthy direction.
ui.map uses ui.inappnotification.moduledisabled, so a change to ui.inappnotification.moduledisabled can break ui.map, while a change to ui.map can't break ui.inappnotification.moduledisabled.
Position
Below the diagonal: ui.map uses a module listed above it, which is the healthy direction.
ui.nearby uses ui.inappnotification.moduledisabled, so a change to ui.inappnotification.moduledisabled can break ui.nearby, while a change to ui.nearby can't break ui.inappnotification.moduledisabled.
Position
Below the diagonal: ui.nearby uses a module listed above it, which is the healthy direction.
ui.nearby.type uses provider.sensor, so a change to provider.sensor can break ui.nearby.type, while a change to ui.nearby.type can't break provider.sensor.
Position
Below the diagonal: ui.nearby.type uses a module listed above it, which is the healthy direction.
ui.pref.main uses provider.remoteconfig, so a change to provider.remoteconfig can break ui.pref.main, while a change to ui.pref.main can't break provider.remoteconfig.
Position
Below the diagonal: ui.pref.main uses a module listed above it, which is the healthy direction.
ui.type uses ui.inappnotification.moduledisabled, so a change to ui.inappnotification.moduledisabled can break ui.type, while a change to ui.type can't break ui.inappnotification.moduledisabled.
Position
Below the diagonal: ui.type uses a module listed above it, which is the healthy direction.
ui.view.listfooter uses datasource, so a change to datasource can break ui.view.listfooter, while a change to ui.view.listfooter can't break datasource.
Position
Below the diagonal: ui.view.listfooter uses a module listed above it, which is the healthy direction.
ui.favorites uses ui.inappnotification.moduledisabled, so a change to ui.inappnotification.moduledisabled can break ui.favorites, while a change to ui.favorites can't break ui.inappnotification.moduledisabled.
Position
Below the diagonal: ui.favorites uses a module listed above it, which is the healthy direction.
ui.favorites uses ui.view.listfooter, so a change to ui.view.listfooter can break ui.favorites, while a change to ui.favorites can't break ui.view.listfooter.
Position
Below the diagonal: ui.favorites uses a module listed above it, which is the healthy direction.
ui.home uses ui.inappnotification.moduledisabled, so a change to ui.inappnotification.moduledisabled can break ui.home, while a change to ui.home can't break ui.inappnotification.moduledisabled.
Position
Below the diagonal: ui.home uses a module listed above it, which is the healthy direction.
ui.rds.route.direction uses analytics, so a change to analytics can break ui.rds.route.direction, while a change to ui.rds.route.direction can't break analytics.
Position
Below the diagonal: ui.rds.route.direction uses a module listed above it, which is the healthy direction.
ui.rds.route.direction uses provider.remoteconfig, so a change to provider.remoteconfig can break ui.rds.route.direction, while a change to ui.rds.route.direction can't break provider.remoteconfig.
Position
Below the diagonal: ui.rds.route.direction uses a module listed above it, which is the healthy direction.
ui.rds.route.direction uses device, so a change to device can break ui.rds.route.direction, while a change to ui.rds.route.direction can't break device.
Position
Below the diagonal: ui.rds.route.direction uses a module listed above it, which is the healthy direction.
ui.rds.route.direction uses datasource, so a change to datasource can break ui.rds.route.direction, while a change to ui.rds.route.direction can't break datasource.
Position
Below the diagonal: ui.rds.route.direction uses a module listed above it, which is the healthy direction.
ui.rds.route.direction uses provider, so a change to provider can break ui.rds.route.direction, while a change to ui.rds.route.direction can't break provider.
Position
Below the diagonal: ui.rds.route.direction uses a module listed above it, which is the healthy direction.
ui.rds.route.direction uses ui.view.common, so a change to ui.view.common can break ui.rds.route.direction, while a change to ui.rds.route.direction can't break ui.view.common.
Position
Below the diagonal: ui.rds.route.direction uses a module listed above it, which is the healthy direction.
ui.rds.route.direction uses provider.sensor, so a change to provider.sensor can break ui.rds.route.direction, while a change to ui.rds.route.direction can't break provider.sensor.
Position
Below the diagonal: ui.rds.route.direction uses a module listed above it, which is the healthy direction.
ui.rds.route.direction uses ui.fragment, so a change to ui.fragment can break ui.rds.route.direction, while a change to ui.rds.route.direction can't break ui.fragment.
Position
Below the diagonal: ui.rds.route.direction uses a module listed above it, which is the healthy direction.
ui.rds.route.direction uses billing, so a change to billing can break ui.rds.route.direction, while a change to ui.rds.route.direction can't break billing.
Position
Below the diagonal: ui.rds.route.direction uses a module listed above it, which is the healthy direction.
ui.rds.route.direction uses ui.view.listfooter, so a change to ui.view.listfooter can break ui.rds.route.direction, while a change to ui.rds.route.direction can't break ui.view.listfooter.
Position
Below the diagonal: ui.rds.route.direction uses a module listed above it, which is the healthy direction.
ui.type.poi uses ui.view.listfooter, so a change to ui.view.listfooter can break ui.type.poi, while a change to ui.type.poi can't break ui.view.listfooter.
Position
Below the diagonal: ui.type.poi uses a module listed above it, which is the healthy direction.
ui.type.rds uses ui.view.listfooter, so a change to ui.view.listfooter can break ui.type.rds, while a change to ui.type.rds can't break ui.view.listfooter.
Position
Below the diagonal: ui.type.rds uses a module listed above it, which is the healthy direction.
Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).
OWASP category
Findings
Severity
A05:2025 — Injection
147
High / Critical
A03:2025 — Software Supply Chain Failures
18
Medium
Roadmap
Top priorities: Resolve the 96 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (24), REDACTED (24), REDACTED (20); Resolve the 13 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED, REDACTED, REDACTED; Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.
Do this
Helps
Effort
Dimension
Resolve the 96 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (24), REDACTED (24), REDACTED (20).
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
Every finding carries one of four grades. Three say how serious it is. The fourth says this
survey could not settle it — and it is a grade, not a gap.
Critical — 147
A definite problem that already costs you something and drags the score down: a
missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here
tends to cause failures elsewhere.
Serious — 443
Likely wrong, but not failing yet. It degrades
the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to
carry for two years either.
Minor — 29
Recorded, with no effect on how the codebase functions.
Present so the survey is complete, not because it needs doing.
Could not be resolved — 16
Something this survey could not settle
from the outside, and which could be critical or serious. Either a control was required and no
positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves
nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean
result. These are excluded from the score rather than awarded a pass, so the number on the cover neither
rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each
one is named under Limitations.
Methodology & how to trust this report
This survey is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. All 38 evaluated dimensions are computed by tools and static analysis; no language model sets or judges any of them. Overall confidence is 0.8, the weighted average across measured dimensions.
Every figure here is one of two kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10.
What we checked — 38 dimensions across the health lenses
Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.
How to trust any code-health report — three questions
Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 611 of 619 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it: Roslyn, git or a scanner, not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.
This report answers yes to all three. That's the bar to hold any assessment to.
Tools & methods
The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.
Method
Backs
Version
Evaluator
Roslyn static analysis
Complexity, cohesion, coupling, dead code, API surface, layering
What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.
D8 Code Coverage — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT MEASURED: test source is present (.kt) but the built-in coverage collector has no runner for this repository's ecosystem — so this suite was never executed by it. Not scored — this is a gap in the analyzer's language coverage, not a defect in the repo.
D11 Test Reliability — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test source is present (.kt) but the built-in reliability runner does not support this repository's ecosystem, so flakiness couldn't be assessed. Not scored — this is a gap in the analyzer's language coverage, not a finding about this repository.
D12 Dependency Hygiene — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. No dependency manifest this pass reads for hygiene (a Python pyproject.toml/requirements.txt (pip/uv/Poetry), a Swift Package.swift/Package.resolved, a Cargo manifest, a Go module (go.mod/go.sum), a Gradle version catalogue, a Maven POM, an sbt build (build.sbt), composer.json, package.json, a Dart pubspec.yaml, an Elixir mix.exs/mix.lock (Hex), a rebar.config / erlang.mk DEPS (Hex), a Ruby Gemfile/Gemfile.lock or .gemspec (Bundler/RubyGems)) was found in this repository, so no package was assessed. Zero packages read is NOT a clean dependency tree, so this is NOT SCORED — a gap in the analyzer, not a verdict about this repository. This row is about dependency HYGIENE — outdated, deprecated or unmaintained direct dependencies; known CVEs in the same dependency graph are a separate question, reported under D30 wherever the manifest is OSV-readable.
D14 License Compliance — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Not scored — no dependency manifest this pass reads for licence data (a Python pyproject.toml/requirements.txt (pip/uv/Poetry), a Swift Package.swift/Package.resolved, a Cargo manifest, a Go module (go.mod/go.sum), a Gradle version catalogue, a Maven POM, an sbt build (build.sbt), composer.json, package.json, a Dart pubspec.yaml, an Elixir mix.exs/mix.lock (Hex), a rebar.config / erlang.mk DEPS (Hex), a Ruby Gemfile/Gemfile.lock or .gemspec (Bundler/RubyGems)) was found in this repository, so it declares no third-party dependency closure to grade. A gap in the analyzer, NOT a finding that this repository's licences are compliant: a manifest in an ecosystem outside that list, or third-party code copied into the tree, is not read — so this dimension asserts nothing about this repository's licensing in either direction.
D20 ADR Quality — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. The ADR expectation is gated on whether a repository ships a deployable product. Our repo-kind classifier reads .NET project files and the host and package markers of the other ecosystems it knows (a Go `package main`, a Cargo binary, a package.json `bin`, `start` script or application dev server such as Vite or Next, Python console scripts or a Django/WSGI entry point, a Spring Boot / WAR / Gradle application build, a Rack or Rails app, a Composer project, an OTP release or escript, a Dockerfile, a Procfile, a Platform.sh `.platform/routes.yaml`, and the corresponding published-package manifests, including an OTP `*.app.src`, a Drupal module's `*.info` and a Claude Code `.claude-plugin/plugin.json`), and found none here, so we could not tell what kind of repository this is and did not assess its ADR log. This is a gap in our analyzer, not a finding about this repository. No manifest, project file or entry point of any ecosystem it reads exists in this tree.
D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
D22 Internal API Consistency — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. This repository's source is written only in languages whose packages are published through a manifest, and no manifest in the tree makes a publication act: either there is no package manifest of any ecosystem (no package.json, pyproject.toml, setup.py, gemspec, Cargo.toml, pom.xml, build.gradle, composer.json, pubspec.yaml or mix.exs), or every one present declares in its package manager's own terms that it is not published (an npm package marked "private": true, a Cargo package with publish = false, a pubspec with publish_to: none, a Composer "project", a Poetry project with package-mode = false, or the "Private :: Do Not Upload" classifier). With no publication act there is no intentionally-exposed surface for API consistency to be judged over.
D24 Comment Value — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover the language this repository's product is written in, so it had nothing of the product to read. That is a gap in this analyzer's language reach — not a finding about this repository.
D26 Project Cohesion — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `(repository root)` (56047 LoC, 629 module-visible types across 77 directories) is over its size bounds, and whether one unit is a coherent whole or a grab-bag is read from its type references: the parts of it that reach the rest only through its shared core. Those are read over the C#/VB code model, which this unit's source did not supply. Its size alone is no verdict on its cohesion, so none is published.
D28 Secrets (history) — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. D28's config-credential rule (WD-SECRET-0002) parses each committed `.json` config as a document and reads credential-named values; `app-android/enc/google-services.json`, `app-android/enc/src/debug/google-services.json` did not parse (JSON5, a template, several concatenated documents), so a credential bound there is UNMEASURED by that rule. gitleaks still scanned the same files as text.
D32 Data Compliance (PII/GDPR) — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `app-android/src/main/java/org/mtransit/android/data/NewsImage.kt`, `app-android/src/main/java/org/mtransit/android/data/POIConnectionComparator.kt`, `app-android/src/main/java/org/mtransit/android/datasource/DataSourcesDatabase.kt`, `app-android/src/main/java/org/mtransit/android/ui/fragment/POIFragmentExt.kt`, `app-android/src/main/java/org/mtransit/android/ui/view/MTDotsView.kt` produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
D44 Platform End-of-Life — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This dimension reads a project's own statement about the platform it runs on: a TargetFramework in a .NET project file, a .nvmrc or .python-version, a capped requires-python, a Rust toolchain file or Cargo.toml rust-version, a .go-version, .java-version, .ruby-version, .tool-versions or .sdkmanrc, a go.mod go directive, a Maven or Gradle Java level or toolchain, a Gemfile's ruby directive, a mix.exs elixir requirement, a rebar.config minimum_otp_vsn, a pubspec.yaml SDK constraint, a build.sbt scalaVersion, or a framework major pinned by a dependency constraint. This repository carries none of them, so nothing about its platform was established. That is a gap in this analyzer's coverage, NOT a finding that the platform is supported — a language whose runtime is declared elsewhere (Package.swift, a Dockerfile) is simply not read here yet.
AXB1 Runtime evidence locked — no reproducible boot — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Subject: a native UI project (app-android/src/main/AndroidManifest.xml). The Runtime Evidence tier boots an app only via docker-compose, an Aspire AppHost, a Dockerfile, an npm dev script, a web service's own toolchain entry point (cargo, go, dotnet, Python, Spring Boot), or an Android app's own Gradle wrapper (run on an emulator); an Apple or Flutter app needs a host it lacks. None applied, so no live runtime a11y/egress/header evidence was collected. You can widen what we reach: add a docker-compose.yml (or an Aspire AppHost) that brings the app up with its dependencies. We then boot it in an isolated sandbox and gathers real runtime evidence — you change nothing in your pipeline (no CI step, no SDK).
C2 Access Controls — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These authorization controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks authorization controls.
GD1 Unfinished & placeholder code — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, F#, JavaScript/TypeScript, Dart, Ruby, Scala, Rust and Java source only, and this repository's Kotlin is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
IC1 Incompleteness & stubs — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, JavaScript/TypeScript, Java, Dart, Ruby, Scala and Rust source only, and this repository's Kotlin is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
P5 DR & Backup — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. No backup/snapshot/replication config, RTO/RPO or restore-procedure documentation was found. Whether there is anything here to recover could NOT be determined: persistence is detected from deployment/container manifests and from dependency manifests, and neither was readable by this pass, so a data store this code opens directly — a file, an embedded database — would not be visible to it. The blindness is this analyzer's, not a finding that the repository holds no data. You can widen what we reach: keep the deployment/container manifest or a dependency manifest in this repository — or a link to the ops repo that holds the DR evidence — so the persistence probe has something to read.
S1 Web-Security Posture — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These web-security controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks web-security controls.
X1 Async correctness — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This check's reader does not cover every language in this repository. The score describes the part it read, which is most of the product; the rest is a gap in this analyzer's language reach.
X12 Unreachable branch — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This check's reader does not cover every language in this repository. The score describes the part it read, which is most of the product; the rest is a gap in this analyzer's language reach.
X2 Cancellation propagation — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, and JavaScript/TypeScript, Go, PHP, Dart, Kotlin, Ruby, Scala, Java, Python and Rust source only, and no C# was loaded, and no named async function in this repository's JavaScript/TypeScript, nor any Go, PHP or Dart function or Kotlin suspend function, makes a request that can be cancelled (fetch, axios, ky, ofetch, got, undici, node:http; net/http, net.Dial; amphp; Dio; Ktor, OkHttp), so there is nothing to judge, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.
Limitations & what we did not check
We assess the repository exactly as committed, and only the repository. By design we do not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.
Per-dimension blind spots
For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.
D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
D21 Naming Consistency: Naming consistency compares each name with the convention its structural peers follow in this repository: it cannot tell whether a consistently used name is a good one, and languages other than C# and TypeScript are not measured.
D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
What it measures: How tangled the control flow is — methods with many branches are hard to test and change.
Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.
24 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was UISchedule.generateScheduleListTimes at 42. A further 5 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being NavigationDrawerControllerExtKt.trackNavigationItemSelected at 21 — they are counted neither in the figure above nor in this dimension's score. 3 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: app-android/src/main/java/org/mtransit/android/ui/NavigationDrawerControllerExt.kt (NavigationDrawerControllerExtKt.trackNavigationItemSelected at 21), app-android/src/main/java/org/mtransit/android/billing/MTBillingManager.kt (MTBillingManager.queryAvailableProductDetails at 16), app-android/src/main/java/org/mtransit/android/ui/main/NextMainViewModel.kt (NextMainViewModel.idPrefToIdRes at 16). They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.
+ 19 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 24 bodies over 15 down to 15 or less in Cyclomatic Complexity — start with UISchedule.generateScheduleListTimes (cyclomatic 42), UISchedule.findTimesSectionsStartEnd (cyclomatic 34), KeysManager.getKeysMap (cyclomatic 32). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 24 together lifts Cyclomatic Complexity from 7.0 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.
Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How hard the code is for a person to follow, beyond raw branching.
Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.
+ 50 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 3 bodies over 60 down to 60 or less in Cognitive Complexity — start with UISchedule.generateScheduleListTimes (cognitive 82), UISchedule.findTimesSectionsStartEnd (cognitive 80), POIStatusDetailViewController.updateScheduleView (cognitive 69). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 3 together lifts Cognitive Complexity from 6.2 to about 6.5/10, projected with the scoring formula itself and assuming each lands exactly at 60; a cleaner split scores higher.
Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D3 · God Classes7.6 / 10Strong✓ Tool-verified
What it measures: Over-large classes that try to do too much ("god classes").
Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.
Resolve the 23 TooManyMethods finding(s) in God Classes — start with POIFragment.java, POIArrayAdapter.java, MapViewController.java. — One of this dimension's main actionable groups (23 warning-level).
Resolve the 12 ClassTooLong finding(s) in God Classes — start with POIArrayAdapter.java, POIFragment.java, MapViewController.java. — One of this dimension's main actionable groups (12 warning-level).
Resolve the 12 FileTooLong finding(s) in God Classes — start with POIArrayAdapter.java, POIFragment.java, MapViewController.java. — One of this dimension's main actionable groups (12 warning-level).
Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How much of the production code is copy-pasted: the share of production lines inside a reported copy (every copy of a duplicated block or of an edited member, each line once), 10 at none and 0 at a quarter of the lines.
Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), scored on the share of production lines inside a reported copy (each line once; 10 at none, 0 at a quarter). Deterministic.
58 duplicated block group(s) detected. 7.2 % of the production lines (4,061 of 56,047) are in a reported copy. A further 75 rows report members as variants of one another; the share counts each copied line once, however many rows cite it.
Edited copy of a member (13 corresponding lines) · ×5app-android/src/main/java/org/mtransit/android/ui/view/MTCompassView.java:90
Edited copy of a member (16 corresponding lines) · ×5app-android/src/main/java/org/mtransit/android/data/PlaceExt.kt:22
Edited copy of a member (10 corresponding lines) · ×5app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:801
Edited copy of a member (6 corresponding lines) · ×5app-android/src/main/java/org/mtransit/android/ui/fragment/MTFragmentX.java:99
+ 68 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 6 Duplicated block (6 lines × 2) finding(s) in Code Duplication — start with MTFragmentX.java (2), NearbyFragment.kt, LazyMarker.java. — One of this dimension's main actionable groups (6 warning-level).
Resolve the 5 Edited copy of a member (13 corresponding lines) finding(s) in Code Duplication — start with MTCompassView.java, VehicleLocationExt.kt, DataSourceManager.java. — One of this dimension's main actionable groups (5 warning-level).
Resolve the 5 Edited copy of a member (16 corresponding lines) finding(s) in Code Duplication — start with PlaceExt.kt, ScreenWithLocationCommon.java, FavoriteRepository.kt. — One of this dimension's main actionable groups (5 warning-level).
Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether a class's methods are focused on a single responsibility.
Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.
Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.
Resolve the 2 Low cohesion finding(s) in Cohesion (LCOM4) — start with PlaceProvider.kt, RDSDirectionStopsViewModel.kt. — One of this dimension's main actionable groups (2 warning-level).
Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.
Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.
What it measures: Files that change often and are also complex — the riskiest hotspots.
Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.
Top hotspots: app-android/src/main/java/org/mtransit/android/ui/view/MapViewController.java (9×17=153); app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt (4×21=84); app-android/src/main/java/org/mtransit/android/usecase/GetNearbyPOIListUseCase.kt (2×23=46) Repeated repair below the complexity floor: app-android/src/main/java/org/mtransit/android/ui/schedule/ScheduleAdapter.kt (5 of 6 changes were fixes); app-android/src/main/java/org/mtransit/android/ui/MTApplication.kt (3 of 5 changes were fixes)
Resolve the 4 Hotspot finding(s) in Churn × Complexity Hotspots — start with MapViewController.java, RDSDirectionStopsFragment.kt, GetNearbyPOIListUseCase.kt. — One of this dimension's main actionable groups (4 warning-level).
Resolve the 2 Repeated repair finding(s) in Churn × Complexity Hotspots — start with ScheduleAdapter.kt, MTApplication.kt. — One of this dimension's main actionable groups (2 warning-level).
Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D16 · Bus Factor8.9 / 10Strong✓ Tool-verified
What it measures: Whether knowledge is concentrated in too few people (the "bus factor").
Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.
91 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is app-android/src/main/java/org/mtransit/android/ui/fragment/POIFragment.java. Counted over 210 of the 398 production source files in this repository: 183 are under the ~2,400-byte size floor this dimension measures over, and the remaining 5 have no attributable history left to measure.
Small-team knowledge concentration
What to do
Resolve the 1 Small-team knowledge concentration finding(s) in Bus Factor. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.
Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.
137 deducted task-comment markers across 56047 LoC (0.2/KLoC) → score 9.5. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.
Resolve the 87 TodoComment finding(s) in Explicit Debt — start with POIFragment.kt (9), POIFragment.java (8), NextMainActivity.kt (8). — One of this dimension's main actionable groups (87 warning-level).
Resolve the 50 FixmeComment finding(s) in Explicit Debt — start with DataSourcesReader.kt (25), FragmentUtils.java (14), MapViewController.java (2). — One of this dimension's main actionable groups (50 warning-level).
Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether names — types, methods, variables — are clear and consistent.
Method: Seven vocabulary-free rules (N1-N7) mine each naming convention from the repository and flag a name that breaks a convention its structural peers in the same unit follow; production C# and TypeScript, each its own population. Deterministic, no model, no sample. Advisory.
2 naming inconsistencies among 77 declarations measured against a convention their peers follow.
`endAtInMS` spells `MS` where 45 names in the project spell it `Ms`app-android/src/main/java/org/mtransit/android/ui/schedule/ScheduleViewModel.kt:196
`getAbController` spells `Ab` where 40 names in the project spell it `AB`app-android/src/main/java/org/mtransit/android/ui/fragment/ABFragment.java:315
What to do
Resolve the 1 `endAtInMS` spells `MS` where 45 names in the project spell it `Ms` finding(s) in Naming Consistency — start with ScheduleViewModel.kt. — One of this dimension's main actionable groups (1 recommendation-level).
Resolve the 1 `getAbController` spells `Ab` where 40 names in the project spell it… finding(s) in Naming Consistency — start with ABFragment.java. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d21_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.
Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.
What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.
Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.
Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).
147 finding(s): 0 critical, 147 high, 0 medium, 0 low. 48 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. semgrep hit a parse error in 3 file(s) — `app-android/enc/google-services.json`, `app-android/enc/src/debug/google-services.json`, `app-android/src/main/java/org/mtransit/android/datasource/DataSourcesDatabase.kt` (line 36) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. Separately, one or more rules could not re-parse an embedded snippet in 7 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
What to do
Resolve the 96 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (24), REDACTED (24), REDACTED (20). — One of this dimension's main actionable groups (96 issue-level).
Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
No action in Static Analysis (SAST) — all 48 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (48 issue-level, 0 of them charged here).
Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.
Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.
Every significant source file has living knowledge — recently and meaningfully worked. Counted over 215 of the 398 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.
Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.
Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.
Resolve the 9 Change coupling finding(s) in Change Coupling — start with POIFragment.java (2), NewsExt.kt, Module.java. — One of this dimension's main actionable groups (9 warning-level).
Resolve the 3 Change-coupling hub finding(s) in Change Coupling — start with POIArrayAdapter.java, PickPOIDialogFragment.kt, UIScheduleExt.kt. — One of this dimension's main actionable groups (3 warning-level).
Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.
Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.
+ 1 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 13 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (13 warning-level).
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.
Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.
Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.
Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.
Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.
Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.
`BannerAdManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (adBannerLoadedLastInMs, adBannerLoaded, adRequestLoading, setupTask; e.g. `adBannerLoadedLastInMs` in `setAdBannerLoaded` at line 79). — app-android/src/main/java/org/mtransit/android/ad/banner/BannerAdManager.kt:35
`RewardedAdManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (rewardedAdLoadingActivityHashCode, rewardedAdLoadedActivityHashCode, rewardedAd; e.g. `rewardedAdLoadingActivityHashCode` in `loadRewardedAdForActivity` at line 73). — app-android/src/main/java/org/mtransit/android/ad/rewarded/RewardedAdManager.kt:27
`MTBillingManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (billingClientResponseCode; e.g. `billingClientResponseCode` in `startConnection` at line 153). — app-android/src/main/java/org/mtransit/android/billing/MTBillingManager.kt:42
`DataSourcesInMemoryCache` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (_agencyProperties, _agencyBaseProperties, _supportedDataSourceTypes, _statusProviderProperties, _scheduleProviderProperties, _serviceUpdateProviderProperties; e.g. `_agencyProperties` in `startListeningForChangesIntoMemory` at line 64). — app-android/src/main/java/org/mtransit/android/datasource/DataSourcesInMemoryCache.kt:31
`DemoModeManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (filterAgencyAuthority, filterScreen, forceLang, forceTimestampSec, forceTimeZoneId, forceTimeFormat; e.g. `filterAgencyAuthority` in `read` at line 189). — app-android/src/main/java/org/mtransit/android/dev/DemoModeManager.kt:44
`LocalPreferenceRepository` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (_prefs; e.g. `_prefs` in `getPref` at line 109). — app-android/src/main/java/org/mtransit/android/common/repository/LocalPreferenceRepository.java:26
`StatusLoader` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (fetchStatusExecutors; e.g. `fetchStatusExecutors` in `getFetchStatusExecutor` at line 67). — app-android/src/main/java/org/mtransit/android/task/StatusLoader.java:34
What to do
Java/Kotlin: keep container singletons stateless — move per-request data into locals or a request-scoped bean — or back the state with java.util.concurrent types (ConcurrentHashMap, AtomicInteger/AtomicReference), guard it with synchronized / a Lock (Kotlin: withLock), or mark a flag that is only ever overwritten volatile (@Volatile).
Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).
Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.
Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.
Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.
Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').
Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.
`Circle` declares 19 abstract methods: `contains`, `getCenter`, `getData`, `getFillColor`, `getId`, `getRadius`, `getStrokeColor`, `getStrokeWidth`, `getZIndex`, `isVisible`, `remove`, `setCenter`, `setData`, `setFillColor`, `setRadius`, `setStrokeColor`, `setStrokeWidth`, `setVisible`, `setZIndex`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — app-android/src/main/java/org/mtransit/android/ui/view/map/Circle.java:6
`ExtendedGoogleMap` declares 55 abstract methods: `addCircle`, `addGroundOverlay`, `addMarker`, `addPolygon`, `addPolyline`, `addTileOverlay`, `animateCamera`, `animateCamera`, `animateCamera`, `clear`, `getCameraPosition`, `getCircles`, `getDisplayedMarkers`, `getGroundOverlays`, `getMapType`, `getMarkerShowingInfoWindow`, `getMarkers`, `getMaxZoomLevel`, `getMinZoomLevel`, `getMinZoomLevelNotClustered`, `getPolygons`, `getPolylines`, `getProjection`, `getTileOverlays`, `getUiSettings`, `isBuildingsEnabled`, `isIndoorEnabled`, `isMyLocationEnabled`, `isTrafficEnabled`, `moveCamera`, `setBuildingsEnabled`, `setClustering`, `setIndoorEnabled`, `setInfoWindowAdapter`, `setLocationSource`, `setMapStyle`, `setMapType`, `setMyLocationEnabled`, `setOnCameraIdleListener`, `setOnCameraMoveListener`, and 15 more. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 55 declarations carry 52 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 52 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — app-android/src/main/java/org/mtransit/android/ui/view/map/ExtendedGoogleMap.java:23
`GroundOverlay` declares 21 abstract methods: `getBearing`, `getBounds`, `getData`, `getHeight`, `getId`, `getPosition`, `getTransparency`, `getWidth`, `getZIndex`, `isVisible`, `remove`, `setBearing`, `setData`, `setDimensions`, `setDimensions`, `setImage`, `setPosition`, `setPositionFromBounds`, `setTransparency`, `setVisible`, `setZIndex`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 21 declarations carry 20 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 20 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — app-android/src/main/java/org/mtransit/android/ui/view/map/GroundOverlay.java:8
`IMarker` declares 40 abstract methods: `animatePosition`, `animatePosition`, `animatePosition`, `animatePosition`, `getAlpha`, `getClusterGroup`, `getColor`, `getData`, `getDefaultColor`, `getId`, `getMarkers`, `getPosition`, `getRotation`, `getSecondaryColor`, `getSnippet`, `getTitle`, `getZIndex`, `hideInfoWindow`, `isCluster`, `isDraggable`, `isFlat`, `isInfoWindowShown`, `isVisible`, `remove`, `setAlpha`, `setAnchor`, `setClusterGroup`, `setData`, `setDraggable`, `setFlat`, `setIcon`, `setIcon`, `setInfoWindowAnchor`, `setPosition`, `setRotation`, `setSnippet`, `setTitle`, `setVisible`, `setZIndex`, `showInfoWindow`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 40 declarations carry 36 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 36 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — app-android/src/main/java/org/mtransit/android/ui/view/map/IMarker.java:17
`Polygon` declares 20 abstract methods: `getData`, `getFillColor`, `getHoles`, `getId`, `getPoints`, `getStrokeColor`, `getStrokeWidth`, `getZIndex`, `isGeodesic`, `isVisible`, `remove`, `setData`, `setFillColor`, `setGeodesic`, `setHoles`, `setPoints`, `setStrokeColor`, `setStrokeWidth`, `setVisible`, `setZIndex`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — app-android/src/main/java/org/mtransit/android/ui/view/map/Polygon.java:8
`Polyline` declares 16 abstract methods: `getColor`, `getData`, `getId`, `getPoints`, `getWidth`, `getZIndex`, `isGeodesic`, `isVisible`, `remove`, `setColor`, `setData`, `setGeodesic`, `setPoints`, `setVisible`, `setWidth`, `setZIndex`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — app-android/src/main/java/org/mtransit/android/ui/view/map/Polyline.java:8
`IAdManager` declares 28 abstract methods: `init`, `initForScreens`, `onHasAgenciesEnabledUpdated`, `initHasSubscriptionFromCache`, `canShowAds`, `setHasSubscriptionOrNoError`, `isAppOpenAdAvailable`, `isShowingAppOpenAd`, `loadAppOpenAd`, `showAppOpenAdIfAvailable`, `linkRewardedAd`, `unlinkRewardedAd`, `refreshRewardedAdStatus`, `isRewardedAdAvailableToShow`, `showRewardedAd`, `getBannerHeightInPx`, `adaptToScreenSize`, `onResumeScreen`, `onTimeChanged`, `resumeAd`, `pauseAd`, `destroyAd`, `getRewardedUntil`, `resetRewarded`, `isRewardedNow`, `setRewardedAdListener`, `openAdInspector`, `shouldSkipLoadingRewardedAd`. Counted over its public functions with no body, once per name; default-bodied functions and properties are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — app-android/src/main/java/org/mtransit/android/ad/IAdManager.kt:10
`AgencyPropertiesDao` declares 19 abstract methods: `getAllAgenciesInclNotInstalled`, `getAllAgencies`, `readingAllAgencies`, `readingAllAgenciesBase`, `getAllEnabledAgencies`, `getAllNotInstalledOrNotEnabledAgencies`, `getAllAgenciesCount`, `readingAllAgenciesCount`, `getAllEnabledAgenciesCount`, `getAllNotExtendedDataSourceTypes`, `readingAllNotExtendedDataSourceTypes`, `getAllExtendedDataSourceTypes`, `readingAllExtendedDataSourceTypes`, `getAgency`, `readingAgency`, `readingAgencyBase`, `getAgencyPkg`, `getAgencyColorInt`, `updateAgencySetupRequired`. Counted over its public functions with no body, once per name; default-bodied functions and properties are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — app-android/src/main/java/org/mtransit/android/datasource/AgencyPropertiesDao.kt:15
What to do
Split fat interfaces into focused role-interfaces so clients depend only on what they use.
Maturity · Maturity — Whether the repository and its projects have a README, and whether it is substantive.
Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.
What to do
Add a build/run (quick start) section to the root README — the first thing a newcomer needs.
Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.
Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.
No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.
What to do
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Add a C4 context/container diagram (Structurizr, PlantUML or Mermaid) or an architecture.md overview.
Maturity · Maturity — Whether the repository is organised deliberately: production code and tests are set apart in a way its ecosystem or the repository itself declares.
Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.
Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).
Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.
No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 17 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner. — REDACTED:5
`REDACTED` schedules updates, but no `package-ecosystem` entry covers `gitsubmodule`, which this tree depends on — so those dependencies get no update pull requests and no advisory pressure, however complete the dep-scan credit looks. Add the missing entry to the `updates:` list. — REDACTED:2
What to do
Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
Dependabot is configured but does not watch `gitsubmodule` — add that `package-ecosystem` entry to REDACTED so those dependencies get the same automatic update and advisory pressure as the ones it already covers.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.
Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.
Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.
Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from each language's code model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.
Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.
Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.
Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.
Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.
Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.
Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.
Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.
Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether an enhanced `for` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is iterating invalidates the fail-fast iterator it is holding, so the next `next()` throws `ConcurrentModificationException` and the remaining elements are never seen. Whether a `for (x in c)` or `c.forEach { … }` leaves the collection it is walking alone — a `mutableListOf`/`ArrayList`, `mutableMapOf`/`HashMap` or `mutableSetOf`/`HashSet` is a `java.util` collection on the JVM and is walked by its own fail-fast iterator, so a body that adds to or removes from the very collection the loop is walking makes the next step throw `ConcurrentModificationException` and the remaining elements are never seen.
Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.
Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.
Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.
`catch (_: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. — app-android/src/main/java/org/mtransit/android/provider/location/CountryProvider.kt:50
What to do
Swallowed exception (caught, then discarded)
Do you agree with this assessment?
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.
Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether Kotlin's null safety is not undermined by not-null assertions — `String` cannot hold null and `String?` must be checked before use in every Kotlin module, and each `!!` is a run-time `NullPointerException` the author has told the compiler cannot happen.
Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.
Do you agree with this assessment?
Reference — by lens
The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.
Unscored — 1 check(s) recorded observations but carry no score
These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.
X10 Duplicated predicate — 11 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 2 control(s) we could not find positive evidence for
These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.
P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
P6 Release Hygiene — not evidenced — no changelog, version stamp or semver release tag in the repo
Not included — 74 check(s) not relevant to this codebase
These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.
AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
AX1 Captive dependencies — Not applicable: Dagger rejects, at compile time, a component that holds a binding with a narrower scope than its own.
AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
AX7 Slice cohesion — not applicable — not a vertical-slice architecture
AX8 Test isolation — no test/production split to check
AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
AXB1 Runtime evidence locked — no reproducible boot — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
C1 Data Protection — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no data at rest for these controls to protect.
C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
C3 Audit Trail — No personal data detected in a persisted data model — no PII-named column (email, first_name, date_of_birth, phone_number, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no sensitive data whose changes an audit trail would record. If it does (through a store configured outside this repository, for instance), the trail belongs to wherever that data is stored.
C4 Data Retention — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no personal data whose lifetime a retention limit would bound.
C5 Data-Subject Rights — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no personal data for a data subject to erase, export or consent over.
D10 Test Quality — ~3844 lines of test source are present (.kt) but no test cases reached the test census for this repository — no test root we could resolve declared them, or the files we read declare no cases in a test framework we recognise — so skipped/assertion-free tests couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
D11 Test Reliability — Test reliability not included — no .kt test runner
D12 Dependency Hygiene — Dependency hygiene not measured — no supported dependency manifest was read
D14 License Compliance — No dependency manifest found — no declared dependency closure to grade for licences
D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
D19 Documentation Quality — No runnable or published unit to look for an example in, and no multi-project root README to look for a map in; the other documentation kinds are withheld (see the gaps), so documentation quality is not applicable here.
D20 ADR Quality — Repository kind not determined
D22 Internal API Consistency — No intentionally-exposed public API to evaluate for consistency.
D23 Boundary Type-Coupling — No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ sibling projects each declaring an entity of their own or taking another project's integration events. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
D24 Comment Value — D24 reads C#, Visual Basic, TypeScript and JavaScript comments only — this repository's production source is .java, .kt, which was left unread. Not scored: this is a gap in the analyzer, not a verdict about this repository.
D25 ADR Conformance — no ADRs to check
D26 Project Cohesion — D26 could not read how the parts of this repository's one build unit reference each other, so its cohesion was not measured. Not scored: this is a gap in the analyzer, not a verdict about this repository.
D27 Navigability — symbol resolution incomplete — navigability not assessed
D30 Dependency Vulnerabilities — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Python pyproject.toml/requirements.txt (pip/uv/Poetry), a Swift Package.swift/Package.resolved, a Cargo manifest, a Go module (go.mod/go.sum), a Gradle version catalogue, a Maven POM, an sbt build (build.sbt), composer.json, package.json, a Dart pubspec.yaml, an Elixir mix.exs/mix.lock (Hex), a rebar.config / erlang.mk DEPS (Hex), a Ruby Gemfile/Gemfile.lock or .gemspec (Bundler/RubyGems) — not scanned yet).
D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
D32 Data Compliance (PII/GDPR) — 5 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D43 Malicious Dependencies — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Python pyproject.toml/requirements.txt (pip/uv/Poetry), a Swift Package.swift/Package.resolved, a Cargo manifest, a Go module (go.mod/go.sum), a Gradle version catalogue, a Maven POM, an sbt build (build.sbt), composer.json, package.json, a Dart pubspec.yaml, an Elixir mix.exs/mix.lock (Hex), a rebar.config / erlang.mk DEPS (Hex), a Ruby Gemfile/Gemfile.lock or .gemspec (Bundler/RubyGems) — not scanned yet).
D44 Platform End-of-Life — Platform end-of-life not assessed — this repository declares no platform this pass reads
D5 Coupling — Not applicable — no manifest declares this repository's modules, and its source holds 1 production component(s), so there is no coupling BETWEEN modules to measure. (Its test and non-production components are not part of the shipped graph.)
D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
D8 Code Coverage — Coverage not included — suite not readable by the collector
DM1 Domain Modelling — applicable but not scored (2 of 3 signals for this style — below the bar we score at): 16 value object(s); 2 repository port(s) loading or saving an aggregate/entity
ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
ES1 Event Sourcing — not scored — this repository shows only 1 of the 3 signals this lens looks for (1 projection(s))
GD1 Unfinished & placeholder code — no source files were read — this check reads C#, F#, JavaScript/TypeScript, Dart, Ruby, Scala, Rust and Java, and none was read for this repository's product. That is a limit of the analyzer, not a finding about your code.
IC1 Incompleteness & stubs — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
M4 Documentation accuracy — Not applicable: the 1 current-state document(s) make no claim of a kind M4 checks.
P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, and the automatic-re-run check to any GitHub-Actions workflow, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
P2 Observability — This repository's JVM source (1 module(s), 398 file(s) read) declares no entry point and bootstraps no server, and nothing here deploys a service — it is a library, run inside whatever hosts it, so production observability (structured logging, tracing/metrics, health checks) is N/A. If it grows a binary or a service, the dimension reactivates.
P7 Outbound HTTP resilience — not applicable — no HTTP server, API framework or worker entry point was found in the JVM source, so there is no service whose uptime a failing dependency could take down
P8 Schema migrations — no ORM, schema-migration tool or schema auto-create was found in this repository's dependency manifests or source, so there is no database schema for this check to judge
P9 Domain vs controller coverage — coverage not measured: this check compares the coverage of the analyzer's own test run across the domain and web layers, and that run measured none here — Test coverage (D8) says why
PF1 Benchmark discipline — Not applicable: no benchmark suite was found. This check searched for `@Benchmark` in a Java, Kotlin or Scala file importing JMH or kotlinx-benchmark, Jetpack Benchmark's `measureRepeated` in a file importing androidx.benchmark, or JMH/kotlinx-benchmark/androidx.benchmark in a pom.xml, Gradle or sbt build, and for a `*benchmark*` script that this repository's CI runs. Benchmarks are credited as a bonus, so their absence is neither scored nor deducted.
PF2 Allocation hygiene — Not scored: this check counted allocation-aware idioms (Span, pools, stackalloc) per line, which describes what kind of code a repository is rather than whether it has an allocation problem, so it was withdrawn. Nothing here is a finding about your code.
S1 Web-Security Posture — Not assessed: these web-security controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks web-security controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
X13 Undrained process stream — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X14 Bypassable address classification — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X15 Unvalidated length from an untrusted reader — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X17 Uncapped recursion over a caller-supplied document — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X18 Disposal-pattern correctness — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X2 Cancellation propagation — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
X20 Mistyped argument guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X22 Contradicted release guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X23 Unguarded diagnostic materialisation — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X24 Document value interpolated into markup unescaped — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X26 Unsynchronised callback handoff — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X28 Index access outside its own emptiness guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
X4 Structured logging — This check asks whether log calls keep a message's values apart from its text, which needs a logger that can carry them as fields. This repository's Kotlin was read, and it logs through none that an assembled message defeats: Android's `Log` and Timber, java.util.logging and log4j-api-kotlin take one finished message (as log4net does in C#), or it makes no call through a named logger at all. Calls made through SLF4J, log4j 2 or kotlin-logging (`LoggerFactory.getLogger`, `KotlinLogging.logger {}`) would be judged.
X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X7 Silent fallback defaults — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
Appendix A — Findings (grouped)
The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.
TodoComment app-android/src/test/java/org/mtransit/android/data/UIScheduleTest.java:342— // TODO FIX TEST: code NOT yet compatible with time NOT the minute — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app-android/src/main/java/org/mtransit/android/util/LinkUtils.java:116— // TODO ? .addSharedElement(view, view.getTransitionName()) — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app-android/src/main/java/org/mtransit/android/provider/direction/MapDirectionsProvider.kt:241— // TODO ? .addSharedElement(view, view.getTransitionName()) — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app-android/src/main/java/org/mtransit/android/util/UITimeUtils.java:478— // TODO i18n — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app-android/src/main/java/org/mtransit/android/ui/NavigationDrawerController.java:408— // TODO favorites? (favorite manager requires IO — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app-android/src/main/java/org/mtransit/android/ui/NavigationDrawerController.java:676— // TODO navigate to dialog — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app-android/src/main/java/org/mtransit/android/ui/NavigationDrawerController.java:689— // TODO navigate to dialog — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app-android/src/main/java/org/mtransit/android/ui/view/MapViewController.java:653— // TODO navigate to dialog — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app-android/src/main/java/org/mtransit/android/ui/view/MapViewController.java:676— // TODO navigate to dialog — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app-android/src/main/java/org/mtransit/android/ui/rds/route/RDSRouteFragment.kt:334— // TODO navigate to dialog — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt:330— // TODO navigate to dialog — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app-android/src/main/java/org/mtransit/android/ui/fragment/POIFragment.java:775— // TODO navigate to dialog — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app-android/src/main/java/org/mtransit/android/ui/EdgeToEdge.kt:204— // TODO? official doc recommends to use systemBars() and consumed true — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app-android/src/main/java/org/mtransit/android/ui/widget/ListViewSwipeRefreshLayout.java:16— // TODO stop using ListView — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app-android/src/main/java/org/mtransit/android/ui/view/map/impl/MarkerManager.java:83— // TODO CRASH SimpleArrayMap ClassCastException: String cannot be cast to Object[] — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app-android/src/main/java/org/mtransit/android/ui/view/common/MTTransitions.kt:101— // TODO ? drawingViewId = R.id.scrollview — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app-android/src/main/java/org/mtransit/android/ui/view/common/MTTransitions.kt:102— // TODO ? pathMotion = ArcMotion() — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app-android/src/main/java/org/mtransit/android/ui/type/AgencyTypeFragment.kt:248— // TODO really? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app-android/src/main/java/org/mtransit/android/ui/rds/route/RDSRouteFragment.kt:201— // TODO really? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app-android/src/main/java/org/mtransit/android/ui/type/AgencyTypeFragment.kt:446— // TODO if (FeatureFlags.F_NAVIGATION) nextMainViewModel.setABBgColor(it) — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app-android/src/main/java/org/mtransit/android/ui/type/AgencyTypePagerAdapter.kt:27— // TODO DiffUtil — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app-android/src/main/java/org/mtransit/android/ui/rds/route/RDSRouteDirectionPagerAdapter.kt:27— // TODO DiffUtil — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app-android/src/main/java/org/mtransit/android/ui/nearby/NearbyPagerAdapter.kt:21— // TODO DiffUtil — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app-android/src/main/java/org/mtransit/android/ui/type/rds/RDSAgencyRoutesAdapter.kt:177— // TODO agency-level UI? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app-android/src/main/java/org/mtransit/android/ui/splash/SplashScreenViewModel.kt:195— // TODO later prefetch free/useful real-time data / news? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment app-android/src/main/java/org/mtransit/android/util/FragmentUtils.java:120— //noinspection deprecation // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment app-android/src/main/java/org/mtransit/android/util/FragmentUtils.java:123— //noinspection deprecation // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment app-android/src/main/java/org/mtransit/android/util/FragmentUtils.java:158— //noinspection deprecation // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment app-android/src/main/java/org/mtransit/android/util/FragmentUtils.java:161— //noinspection deprecation // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment app-android/src/main/java/org/mtransit/android/util/FragmentUtils.java:199— //noinspection deprecation // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment app-android/src/main/java/org/mtransit/android/util/FragmentUtils.java:202— //noinspection deprecation // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment app-android/src/main/java/org/mtransit/android/util/FragmentUtils.java:225— //noinspection deprecation // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment app-android/src/main/java/org/mtransit/android/util/FragmentUtils.java:228— //noinspection deprecation // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment app-android/src/main/java/org/mtransit/android/util/FragmentUtils.java:251— //noinspection deprecation // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment app-android/src/main/java/org/mtransit/android/util/FragmentUtils.java:254— //noinspection deprecation // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment app-android/src/main/java/org/mtransit/android/util/FragmentUtils.java:285— //noinspection deprecation // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment app-android/src/main/java/org/mtransit/android/util/FragmentUtils.java:288— //noinspection deprecation // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment app-android/src/main/java/org/mtransit/android/util/FragmentUtils.java:315— //noinspection deprecation // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment app-android/src/main/java/org/mtransit/android/util/FragmentUtils.java:319— //noinspection deprecation // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment app-android/src/main/java/org/mtransit/android/ui/NavigationDrawerController.java:381— //noinspection deprecation // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment app-android/src/main/java/org/mtransit/android/ui/view/MapViewController.java:396— //noinspection deprecation // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment app-android/src/main/java/org/mtransit/android/ui/view/MapViewController.java:888— //noinspection deprecation // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment app-android/src/main/java/org/mtransit/android/ui/view/map/MTPOIMarkerIds.kt:35— // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment app-android/src/main/java/org/mtransit/android/task/ServiceUpdateLoader.java:194— // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment app-android/src/main/java/org/mtransit/android/task/ServiceUpdateLoader.java:275— // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment app-android/src/main/java/org/mtransit/android/ui/type/AgencyTypeFragment.kt:269— // exitTransition = MTTransitions.newHoldTransition() // not working with AdapterView // FIXME #RecyclerView — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment app-android/src/main/java/org/mtransit/android/ui/home/HomeFragment.kt:216— // exitTransition = MTTransitions.newHoldTransition() // not working with AdapterView // FIXME #RecyclerView — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment app-android/src/main/java/org/mtransit/android/ui/poi/POIFragment.kt:443— // @Suppress("DEPRECATION") // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment app-android/src/main/java/org/mtransit/android/ui/poi/POIViewModel.kt:111— // val poim: LiveData<POIManager?> = _poim // FIXME remove — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment app-android/src/main/java/org/mtransit/android/ui/main/NextMainActivity.kt:202— // FIXME only when new value? ... — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TooManyMethods: POIFragment app-android/src/main/java/org/mtransit/android/ui/fragment/POIFragment.java:154— TooManyMethods — 125 methods. The bar is 30 methods; this is 95 over it, 4.17× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: POIArrayAdapter app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:125— TooManyMethods — 120 methods. The bar is 30 methods; this is 90 over it, 4.00× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: MapViewController app-android/src/main/java/org/mtransit/android/ui/view/MapViewController.java:96— TooManyMethods — 91 methods. The bar is 30 methods; this is 61 over it, 3.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ModuleProvider app-android/src/main/java/org/mtransit/android/provider/ModuleProvider.java:63— TooManyMethods — 69 methods. The bar is 30 methods; this is 39 over it, 2.30× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: DelegatingGoogleMap app-android/src/main/java/org/mtransit/android/ui/view/map/impl/DelegatingGoogleMap.java:40— TooManyMethods — 63 methods. The bar is 30 methods; this is 33 over it, 2.10× the bar. Most of these members implement map.ExtendedGoogleMap (52 of 60 members), so moving them onto a smaller type would remove them from that contract rather than reduce it. To reduce it, split the contract instead: give each cohesive group of operations its own smaller interface and its own implementing type. Where the contract has to stay whole, move the work behind these members into collaborator types, so what is left here is a forward per member rather than a responsibility per member.
TooManyMethods: UISchedule app-android/src/main/java/org/mtransit/android/data/UISchedule.java:57— TooManyMethods — 61 methods. The bar is 30 methods; this is 31 over it, 2.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: UITimeUtils app-android/src/main/java/org/mtransit/android/util/UITimeUtils.java:49— TooManyMethods — 61 methods. The bar is 30 methods; this is 31 over it, 2.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: POIManager app-android/src/main/java/org/mtransit/android/data/POIManager.java:67— TooManyMethods — 58 methods. The bar is 30 methods; this is 28 over it, 1.93× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: DataSourcesRepository app-android/src/main/java/org/mtransit/android/datasource/DataSourcesRepository.kt:41— TooManyMethods — 56 methods. The bar is 30 methods; this is 26 over it, 1.87× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ClusterMarker app-android/src/main/java/org/mtransit/android/ui/view/map/impl/ClusterMarker.java:22— TooManyMethods — 51 methods. The bar is 30 methods; this is 21 over it, 1.70× the bar. Most of these members implement map.IMarker (36 of 46 members), so moving them onto a smaller type would remove them from that contract rather than reduce it. To reduce it, split the contract instead: give each cohesive group of operations its own smaller interface and its own implementing type. Where the contract has to stay whole, move the work behind these members into collaborator types, so what is left here is a forward per member rather than a responsibility per member.
TooManyMethods: DelegatingMarker app-android/src/main/java/org/mtransit/android/ui/view/map/impl/DelegatingMarker.java:21— TooManyMethods — 51 methods. The bar is 30 methods; this is 21 over it, 1.70× the bar. Most of these members implement map.IMarker (36 of 47 members), so moving them onto a smaller type would remove them from that contract rather than reduce it. To reduce it, split the contract instead: give each cohesive group of operations its own smaller interface and its own implementing type. Where the contract has to stay whole, move the work behind these members into collaborator types, so what is left here is a forward per member rather than a responsibility per member.
TooManyMethods: GoogleMapWrapper app-android/src/main/java/org/mtransit/android/ui/view/map/impl/GoogleMapWrapper.java:32— TooManyMethods — 48 methods. The bar is 30 methods; this is 18 over it, 1.60× the bar. Most of these members implement impl.IGoogleMap (43 of 45 members), so moving them onto a smaller type would remove them from that contract rather than reduce it. To reduce it, split the contract instead: give each cohesive group of operations its own smaller interface and its own implementing type. Where the contract has to stay whole, move the work behind these members into collaborator types, so what is left here is a forward per member rather than a responsibility per member.
TooManyMethods: ABFragment app-android/src/main/java/org/mtransit/android/ui/fragment/ABFragment.java:61— TooManyMethods — 45 methods. The bar is 30 methods; this is 15 over it, 1.50× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: DataSourcesStorage app-android/src/main/java/org/mtransit/android/datasource/DataSourcesStorage.kt:8— TooManyMethods — 44 methods. The bar is 30 methods; this is 14 over it, 1.47× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: NavigationDrawerController app-android/src/main/java/org/mtransit/android/ui/NavigationDrawerController.java:79— TooManyMethods — 42 methods. The bar is 30 methods; this is 12 over it, 1.40× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: MainActivity app-android/src/main/java/org/mtransit/android/ui/MainActivity.kt:71— TooManyMethods — 41 methods. The bar is 30 methods; this is 11 over it, 1.37× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ActionBarController app-android/src/main/java/org/mtransit/android/ui/ActionBarController.java:28— TooManyMethods — 39 methods. The bar is 30 methods; this is 9 over it, 1.30× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ExtendedMarkerOptions app-android/src/main/java/org/mtransit/android/ui/view/map/ExtendedMarkerOptions.java:17— TooManyMethods — 38 methods. The bar is 30 methods; this is 8 over it, 1.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: LazyMarker app-android/src/main/java/org/mtransit/android/ui/view/map/lazy/LazyMarker.java:23— TooManyMethods — 38 methods. The bar is 30 methods; this is 8 over it, 1.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: DataSourceManager app-android/src/main/java/org/mtransit/android/data/DataSourceManager.java:60— TooManyMethods — 36 methods. The bar is 30 methods; this is 6 over it, 1.20× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: PlaceProvider app-android/src/main/java/org/mtransit/android/provider/PlaceProvider.kt:49— TooManyMethods — 34 methods. The bar is 30 methods; this is 4 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: GridClusteringStrategy app-android/src/main/java/org/mtransit/android/ui/view/map/impl/GridClusteringStrategy.java:24— TooManyMethods — 34 methods. The bar is 30 methods; this is 4 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: AdManager app-android/src/main/java/org/mtransit/android/ad/AdManager.kt:44— TooManyMethods — 31 methods. The bar is 30 methods; this is 1 over it, 1.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: POIArrayAdapter app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:125— ClassTooLong — 1402 significant lines (blank, comment-only and punctuation-only lines excluded), 120 methods. The bar is 400 significant lines; this is 1002 over it, 3.51× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: POIFragment app-android/src/main/java/org/mtransit/android/ui/fragment/POIFragment.java:154— ClassTooLong — 1050 significant lines (blank, comment-only and punctuation-only lines excluded), 125 methods. The bar is 400 significant lines; this is 650 over it, 2.63× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: MapViewController app-android/src/main/java/org/mtransit/android/ui/view/MapViewController.java:96— ClassTooLong — 953 significant lines (blank, comment-only and punctuation-only lines excluded), 91 methods. The bar is 400 significant lines; this is 553 over it, 2.38× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: UISchedule app-android/src/main/java/org/mtransit/android/data/UISchedule.java:57— ClassTooLong — 791 significant lines (blank, comment-only and punctuation-only lines excluded), 61 methods. The bar is 400 significant lines; this is 391 over it, 1.98× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: POIManager app-android/src/main/java/org/mtransit/android/data/POIManager.java:67— ClassTooLong — 741 significant lines (blank, comment-only and punctuation-only lines excluded), 58 methods. The bar is 400 significant lines; this is 341 over it, 1.85× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: NavigationDrawerController app-android/src/main/java/org/mtransit/android/ui/NavigationDrawerController.java:79— ClassTooLong — 647 significant lines (blank, comment-only and punctuation-only lines excluded), 42 methods. The bar is 400 significant lines; this is 247 over it, 1.62× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: UITimeUtils app-android/src/main/java/org/mtransit/android/util/UITimeUtils.java:49— ClassTooLong — 605 significant lines (blank, comment-only and punctuation-only lines excluded), 61 methods. The bar is 400 significant lines; this is 205 over it, 1.51× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: DataSourcesReader app-android/src/main/java/org/mtransit/android/datasource/DataSourcesReader.kt:46— ClassTooLong — 580 significant lines (blank, comment-only and punctuation-only lines excluded), 17 methods. The bar is 400 significant lines; this is 180 over it, 1.45× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: ModuleProvider app-android/src/main/java/org/mtransit/android/provider/ModuleProvider.java:63— ClassTooLong — 501 significant lines (blank, comment-only and punctuation-only lines excluded), 69 methods. The bar is 400 significant lines; this is 101 over it, 1.25× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: ScheduleAdapter app-android/src/main/java/org/mtransit/android/ui/schedule/ScheduleAdapter.kt:56— ClassTooLong — 500 significant lines (blank, comment-only and punctuation-only lines excluded), 24 methods. The bar is 400 significant lines; this is 100 over it, 1.25× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: DataSourceManager app-android/src/main/java/org/mtransit/android/data/DataSourceManager.java:60— ClassTooLong — 488 significant lines (blank, comment-only and punctuation-only lines excluded), 36 methods. The bar is 400 significant lines; this is 88 over it, 1.22× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: RDSDirectionStopsFragment app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt:77— ClassTooLong — 434 significant lines (blank, comment-only and punctuation-only lines excluded), 25 methods. The bar is 400 significant lines; this is 34 over it, 1.09× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
FileTooLong: data/POIArrayAdapter.java app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java— FileTooLong — 1519 significant lines (blank, comment-only and punctuation-only lines excluded), about 92% of them inside a single declaration: POIArrayAdapter (125-2086). The bar is 500 significant lines; this is 1019 over it, 3.04× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: fragment/POIFragment.java app-android/src/main/java/org/mtransit/android/ui/fragment/POIFragment.java— FileTooLong — 1194 significant lines (blank, comment-only and punctuation-only lines excluded), about 88% of them inside a single declaration: POIFragment (154-1628). The bar is 500 significant lines; this is 694 over it, 2.39× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: view/MapViewController.java app-android/src/main/java/org/mtransit/android/ui/view/MapViewController.java— FileTooLong — 1040 significant lines (blank, comment-only and punctuation-only lines excluded), about 92% of them inside a single declaration: MapViewController (96-1456). The bar is 500 significant lines; this is 540 over it, 2.08× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: data/UISchedule.java app-android/src/main/java/org/mtransit/android/data/UISchedule.java— FileTooLong — 841 significant lines (blank, comment-only and punctuation-only lines excluded), about 94% of them inside a single declaration: UISchedule (57-1162). The bar is 500 significant lines; this is 341 over it, 1.68× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: data/POIManager.java app-android/src/main/java/org/mtransit/android/data/POIManager.java— FileTooLong — 801 significant lines (blank, comment-only and punctuation-only lines excluded), about 93% of them inside a single declaration: POIManager (67-1058). The bar is 500 significant lines; this is 301 over it, 1.60× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: ui/NavigationDrawerController.java app-android/src/main/java/org/mtransit/android/ui/NavigationDrawerController.java— FileTooLong — 718 significant lines (blank, comment-only and punctuation-only lines excluded), about 90% of them inside a single declaration: NavigationDrawerController (79-964). The bar is 500 significant lines; this is 218 over it, 1.44× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: util/UITimeUtils.java app-android/src/main/java/org/mtransit/android/util/UITimeUtils.java— FileTooLong — 648 significant lines (blank, comment-only and punctuation-only lines excluded), about 93% of them inside a single declaration: UITimeUtils (49-886). The bar is 500 significant lines; this is 148 over it, 1.30× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: datasource/DataSourcesReader.kt app-android/src/main/java/org/mtransit/android/datasource/DataSourcesReader.kt— FileTooLong — 623 significant lines (blank, comment-only and punctuation-only lines excluded), about 93% of them inside a single declaration: DataSourcesReader (46-842). The bar is 500 significant lines; this is 123 over it, 1.25× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: provider/ModuleProvider.java app-android/src/main/java/org/mtransit/android/provider/ModuleProvider.java— FileTooLong — 557 significant lines (blank, comment-only and punctuation-only lines excluded), about 90% of them inside a single declaration: ModuleProvider (63-808). The bar is 500 significant lines; this is 57 over it, 1.11× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: schedule/ScheduleAdapter.kt app-android/src/main/java/org/mtransit/android/ui/schedule/ScheduleAdapter.kt— FileTooLong — 553 significant lines (blank, comment-only and punctuation-only lines excluded), about 90% of them inside a single declaration: ScheduleAdapter (56-776). The bar is 500 significant lines; this is 53 over it, 1.11× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: data/DataSourceManager.java app-android/src/main/java/org/mtransit/android/data/DataSourceManager.java— FileTooLong — 542 significant lines (blank, comment-only and punctuation-only lines excluded), about 90% of them inside a single declaration: DataSourceManager (60-695). The bar is 500 significant lines; this is 42 over it, 1.08× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: direction/RDSDirectionStopsFragment.kt app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt— FileTooLong — 508 significant lines (blank, comment-only and punctuation-only lines excluded), about 85% of them inside a single declaration: RDSDirectionStopsFragment (77-691). The bar is 500 significant lines; this is 8 over it, 1.02× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
Change coupling: NewsExt.kt ↔ NewsDetailsFragment.kt app-android/src/main/java/org/mtransit/android/data/NewsExt.kt:1— `app-android/src/main/java/org/mtransit/android/data/NewsExt.kt` and `app-android/src/main/java/org/mtransit/android/ui/news/details/NewsDetailsFragment.kt` change together 70% of the time (7 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `63b34521` News detail screen > fix `"Error 153: Video player configuration erro…; `6e516592` News List item > add video & image gallery icons (& WIP: play button …; `5fab8013` News > group "@username - source" in details — run `git show` on any of them.
Change coupling: Module.java ↔ TextMessage.java app-android/src/main/java/org/mtransit/android/data/Module.java:1— `app-android/src/main/java/org/mtransit/android/data/Module.java` and `app-android/src/main/java/org/mtransit/android/data/TextMessage.java` change together 62% of the time (8 of the 13 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `16df101f` Remove accessibility feature flags (#64); `a5dbdf7c` fix issue with Modules (need ID for DB storage); `cd0ef626` fix crash with Place not having unique item view type id in POI array… — run `git show` on any of them.
Change coupling: HomeFragment.kt ↔ InAppNotificationUI.kt app-android/src/main/java/org/mtransit/android/ui/home/HomeFragment.kt:1— `app-android/src/main/java/org/mtransit/android/ui/home/HomeFragment.kt` and `app-android/src/main/java/org/mtransit/android/ui/inappnotification/InAppNotificationUI.kt` change together 60% of the time (6 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `6afeef00` On-boarding > location permission in-app notif in Home/Nearby screen (at that commit the files were still `src/main/java/org/mtransit/android/ui/home/HomeFragment.kt` and `src/main/java/org/mtransit/android/ui/inappnotification/InAppNotificationUI.kt`); `7e348596` In-App Notification UI > Snackbar > ON (fixed context view + optional… (at that commit the files were still `src/main/java/org/mtransit/android/ui/home/HomeFragment.kt` and `src/main/java/org/mtransit/android/ui/inappnotification/InAppNotificationUI.kt`); `83026648` In-App Notification > fix hide when nothing to hide (at that commit the files were still `src/main/java/org/mtransit/android/ui/home/HomeFragment.kt` and `src/main/java/org/mtransit/android/ui/inappnotification/InAppNotificationUI.kt`) — run `git show` on any of them.
Change coupling: NewsListAdapter.kt ↔ NewsDetailsFragment.kt app-android/src/main/java/org/mtransit/android/ui/news/NewsListAdapter.kt:1— `app-android/src/main/java/org/mtransit/android/ui/news/NewsListAdapter.kt` and `app-android/src/main/java/org/mtransit/android/ui/news/details/NewsDetailsFragment.kt` change together 59% of the time (13 of the 22 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 13 shared commits counted here, the most recent 3 are `bd5b2253` Enable predictive back (`android:enableOnBackInvokedCallback`=true) (…; `48c7b605` RT schedule UI improvements... (#154); `9670fceb` Banner Ad > different unit id for manual refresh and auto-refresh (#151) — run `git show` on any of them.
Change coupling: POIFragment.java ↔ ViewKtx.kt app-android/src/main/java/org/mtransit/android/ui/fragment/POIFragment.java:1— `app-android/src/main/java/org/mtransit/android/ui/fragment/POIFragment.java` and `app-android/src/main/java/org/mtransit/android/ui/view/common/ViewKtx.kt` change together 55% of the time (6 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `411c1a89` Billing > connected/reponse code & hide support w/ 0 (enabled) agenci…; `6b5d9838` Support rendering route logo + route short name together in RDS/POI r…; `a9d57436` R8 full mode (#198) — run `git show` on any of them.
Change coupling: ScheduleAdapter.kt ↔ ScheduleViewModel.kt app-android/src/main/java/org/mtransit/android/ui/schedule/ScheduleAdapter.kt:1— `app-android/src/main/java/org/mtransit/android/ui/schedule/ScheduleAdapter.kt` and `app-android/src/main/java/org/mtransit/android/ui/schedule/ScheduleViewModel.kt` change together 54% of the time (13 of the 24 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 13 shared commits counted here, the most recent 3 are `ee9d1262` GTFS Static > agency timezone > fix infrequent issue (#406); `9e061915` Schedule screen > add buttton to hide real-time" info (#399); `4d725152` Schedule screen > make sure service udpates are loaded (#390) — run `git show` on any of them.
Change coupling: ModuleProvider.java ↔ PlaceProvider.kt app-android/src/main/java/org/mtransit/android/provider/ModuleProvider.java:1— `app-android/src/main/java/org/mtransit/android/provider/ModuleProvider.java` and `app-android/src/main/java/org/mtransit/android/provider/PlaceProvider.kt` change together 50% of the time (5 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 5 shared commits counted here, the most recent 3 are `ee9d1262` GTFS Static > agency timezone > fix infrequent issue (#406); `9631728d` `ProviderContract.Filter` > shared filter params (#337); `16df101f` Remove accessibility feature flags (#64) — run `git show` on any of them.
Change coupling: HomeViewModel.kt ↔ InAppNotificationUI.kt app-android/src/main/java/org/mtransit/android/ui/home/HomeViewModel.kt:1— `app-android/src/main/java/org/mtransit/android/ui/home/HomeViewModel.kt` and `app-android/src/main/java/org/mtransit/android/ui/inappnotification/InAppNotificationUI.kt` change together 50% of the time (5 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 5 shared commits counted here, the most recent 3 are `a8d7cb6f` Fix IP location still used after 1st agency module installed... (#348); `6afeef00` On-boarding > location permission in-app notif in Home/Nearby screen (at that commit the files were still `src/main/java/org/mtransit/android/ui/home/HomeViewModel.kt` and `src/main/java/org/mtransit/android/ui/inappnotification/InAppNotificationUI.kt`); `7e348596` In-App Notification UI > Snackbar > ON (fixed context view + optional… (at that commit the files were still `src/main/java/org/mtransit/android/ui/home/HomeViewModel.kt` and `src/main/java/org/mtransit/android/ui/inappnotification/InAppNotificationUI.kt`) — run `git show` on any of them.
Change coupling: POIFragment.java ↔ ModulesAdapter.kt app-android/src/main/java/org/mtransit/android/ui/fragment/POIFragment.java:1— `app-android/src/main/java/org/mtransit/android/ui/fragment/POIFragment.java` and `app-android/src/main/java/org/mtransit/android/ui/modules/ModulesAdapter.kt` change together 50% of the time (5 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 5 shared commits counted here, the most recent 3 are `4895993a` Fix Weird Capitalization (#394); `74fc22e5` POI Screen > App Update available > only if less than 7 days of schedule; `bac0f388` Favorites screen > show disabled agency name + generic fragment in-ap… (at that commit the files were still `src/main/java/org/mtransit/android/ui/fragment/POIFragment.java` and `src/main/java/org/mtransit/android/ui/modules/ModulesAdapter.kt`) — run `git show` on any of them.
Stateful singleton: BannerAdManager app-android/src/main/java/org/mtransit/android/ad/banner/BannerAdManager.kt:35— `BannerAdManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (adBannerLoadedLastInMs, adBannerLoaded, adRequestLoading, setupTask; e.g. `adBannerLoadedLastInMs` in `setAdBannerLoaded` at line 79).
Stateful singleton: RewardedAdManager app-android/src/main/java/org/mtransit/android/ad/rewarded/RewardedAdManager.kt:27— `RewardedAdManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (rewardedAdLoadingActivityHashCode, rewardedAdLoadedActivityHashCode, rewardedAd; e.g. `rewardedAdLoadingActivityHashCode` in `loadRewardedAdForActivity` at line 73).
Stateful singleton: MTBillingManager app-android/src/main/java/org/mtransit/android/billing/MTBillingManager.kt:42— `MTBillingManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (billingClientResponseCode; e.g. `billingClientResponseCode` in `startConnection` at line 153).
Stateful singleton: DataSourcesInMemoryCache app-android/src/main/java/org/mtransit/android/datasource/DataSourcesInMemoryCache.kt:31— `DataSourcesInMemoryCache` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (_agencyProperties, _agencyBaseProperties, _supportedDataSourceTypes, _statusProviderProperties, _scheduleProviderProperties, _serviceUpdateProviderProperties; e.g. `_agencyProperties` in `startListeningForChangesIntoMemory` at line 64).
Stateful singleton: DemoModeManager app-android/src/main/java/org/mtransit/android/dev/DemoModeManager.kt:44— `DemoModeManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (filterAgencyAuthority, filterScreen, forceLang, forceTimestampSec, forceTimeZoneId, forceTimeFormat; e.g. `filterAgencyAuthority` in `read` at line 189).
Stateful singleton: LocalPreferenceRepository app-android/src/main/java/org/mtransit/android/common/repository/LocalPreferenceRepository.java:26— `LocalPreferenceRepository` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (_prefs; e.g. `_prefs` in `getPref` at line 109).
Stateful singleton: StatusLoader app-android/src/main/java/org/mtransit/android/task/StatusLoader.java:34— `StatusLoader` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (fetchStatusExecutors; e.g. `fetchStatusExecutors` in `getFetchStatusExecutor` at line 67).
Duplicated block (6 lines × 2) app-android/src/main/java/org/mtransit/android/ui/nearby/NearbyFragment.kt:364— app-android/src/main/java/org/mtransit/android/ui/nearby/NearbyFragment.kt:364-369 | app-android/src/main/java/org/mtransit/android/ui/news/NewsListDetailFragment.kt:414-419 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (6 lines × 2) app-android/src/main/java/org/mtransit/android/ui/view/map/lazy/LazyMarker.java:292— app-android/src/main/java/org/mtransit/android/ui/view/map/lazy/LazyMarker.java:292-297 | app-android/src/main/java/org/mtransit/android/ui/view/map/lazy/LazyMarker.java:427-432 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app-android/src/main/java/org/mtransit/android/ui/view/map/lazy/LazyMarker.java:292` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) app-android/src/main/java/org/mtransit/android/ui/MTAppCompatActivity.java:215— app-android/src/main/java/org/mtransit/android/ui/MTAppCompatActivity.java:215-220 | app-android/src/main/java/org/mtransit/android/ui/MTFragmentActivity.java:183-188 — before extracting anything, compare `app-android/src/main/java/org/mtransit/android/ui/MTAppCompatActivity.java` and `app-android/src/main/java/org/mtransit/android/ui/MTFragmentActivity.java` as WHOLE FILES: 84% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (6 lines × 2) app-android/src/main/java/org/mtransit/android/ui/fragment/MTFragmentX.java:212— app-android/src/main/java/org/mtransit/android/ui/fragment/MTFragmentX.java:212-217 | app-android/src/main/java/org/mtransit/android/ui/fragment/MTPreferenceFragment.java:230-235 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (6 lines × 2) app-android/src/main/java/org/mtransit/android/ui/fragment/MTFragmentX.java:229— app-android/src/main/java/org/mtransit/android/ui/fragment/MTFragmentX.java:229-234 | app-android/src/main/java/org/mtransit/android/ui/fragment/MTPreferenceFragment.java:246-251 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (6 lines × 2) app-android/src/main/java/org/mtransit/android/provider/FavoriteProvider.java:143— app-android/src/main/java/org/mtransit/android/provider/FavoriteProvider.java:143-148 | app-android/src/main/java/org/mtransit/android/provider/ModuleProvider.java:117-122 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication· Edited copy of a member (13 corresponding lines) · ×5
Edited copy of a member (13 corresponding lines) app-android/src/main/java/org/mtransit/android/ui/view/MTCompassView.java:90— app-android/src/main/java/org/mtransit/android/ui/view/MTCompassView.java:90-105 | app-android/src/main/java/org/mtransit/android/ui/view/MTJPathsView.java:114-132 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (13 corresponding lines) app-android/src/main/java/org/mtransit/android/ui/view/map/VehicleLocationExt.kt:48— app-android/src/main/java/org/mtransit/android/ui/view/map/VehicleLocationExt.kt:48-60 | app-android/src/main/java/org/mtransit/android/ui/view/map/VehicleLocationExt.kt:69-83 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (13 corresponding lines) app-android/src/main/java/org/mtransit/android/data/DataSourceManager.java:451— app-android/src/main/java/org/mtransit/android/data/DataSourceManager.java:451-464 | app-android/src/main/java/org/mtransit/android/data/DataSourceManager.java:575-587 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (13 corresponding lines) app-android/src/main/java/org/mtransit/android/ui/view/MapViewController.java:1269— app-android/src/main/java/org/mtransit/android/ui/view/MapViewController.java:1269-1281 | app-android/src/main/java/org/mtransit/android/ui/view/MapViewController.java:1298-1314 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (13 corresponding lines) app-android/src/main/java/org/mtransit/android/ui/news/NewsListAdapter.kt:216— app-android/src/main/java/org/mtransit/android/ui/news/NewsListAdapter.kt:216-228 | app-android/src/main/java/org/mtransit/android/ui/schedule/ScheduleAdapter.kt:410-424 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (16 corresponding lines) · ×5
Edited copy of a member (16 corresponding lines) app-android/src/main/java/org/mtransit/android/data/PlaceExt.kt:22— app-android/src/main/java/org/mtransit/android/data/PlaceExt.kt:22-37 | app-android/src/main/java/org/mtransit/android/data/PlaceExt.kt:39-54 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (16 corresponding lines) app-android/src/main/java/org/mtransit/android/ui/view/common/ScreenWithLocationCommon.java:27— app-android/src/main/java/org/mtransit/android/ui/view/common/ScreenWithLocationCommon.java:27-42 | app-android/src/main/java/org/mtransit/android/ui/view/common/ScreenWithLocationCommon.java:45-60 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (16 corresponding lines) app-android/src/main/java/org/mtransit/android/provider/FavoriteRepository.kt:94— app-android/src/main/java/org/mtransit/android/provider/FavoriteRepository.kt:94-109 | app-android/src/main/java/org/mtransit/android/provider/FavoriteRepository.kt:176-191 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (16 corresponding lines) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:463— app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:463-478 | app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:504-519 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (16 corresponding lines) app-android/src/main/java/org/mtransit/android/ad/banner/SetupBannerAdTask.kt:86— app-android/src/main/java/org/mtransit/android/ad/banner/SetupBannerAdTask.kt:86-101 | app-android/src/main/java/org/mtransit/android/ad/inlinebanner/SetupInlineBannerAdTask.kt:78-93 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (10 corresponding lines) · ×5
Edited copy of a member (10 corresponding lines) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:801— app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:801-810 | app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:812-821 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (10 corresponding lines) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1698— app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1698-1708 | app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1730-1739 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (10 corresponding lines) app-android/src/main/java/org/mtransit/android/ui/favorites/FavoritesFragment.kt:259— app-android/src/main/java/org/mtransit/android/ui/favorites/FavoritesFragment.kt:259-268 | app-android/src/main/java/org/mtransit/android/ui/nearby/NearbyFragment.kt:432-445 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (10 corresponding lines) app-android/src/main/java/org/mtransit/android/ui/MTActivityWithLocation.java:91— app-android/src/main/java/org/mtransit/android/ui/MTActivityWithLocation.java:91-105 | app-android/src/main/java/org/mtransit/android/ui/MTActivityWithLocation.java:111-120 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (10 corresponding lines) app-android/src/main/java/org/mtransit/android/ad/banner/BannerAdListener.kt:109— app-android/src/main/java/org/mtransit/android/ad/banner/BannerAdListener.kt:109-118 | app-android/src/main/java/org/mtransit/android/ad/banner/BannerAdListener.kt:121-140 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (6 corresponding lines) · ×5
Edited copy of a member (6 corresponding lines) app-android/src/main/java/org/mtransit/android/ui/fragment/MTFragmentX.java:99— app-android/src/main/java/org/mtransit/android/ui/fragment/MTFragmentX.java:99-104 | app-android/src/main/java/org/mtransit/android/ui/fragment/MTPreferenceFragment.java:118-123 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (6 corresponding lines) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1910— app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1910-1915 | app-android/src/main/java/org/mtransit/android/ui/fragment/POIFragment.java:1336-1343 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (6 corresponding lines) app-android/src/main/java/org/mtransit/android/ui/fragment/MTFragmentX.java:132— app-android/src/main/java/org/mtransit/android/ui/fragment/MTFragmentX.java:132-137 | app-android/src/main/java/org/mtransit/android/ui/fragment/MTPreferenceFragment.java:150-155 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (6 corresponding lines) app-android/src/main/java/org/mtransit/android/ui/fragment/MTFragmentX.java:140— app-android/src/main/java/org/mtransit/android/ui/fragment/MTFragmentX.java:140-145 | app-android/src/main/java/org/mtransit/android/ui/fragment/MTPreferenceFragment.java:158-163 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (6 corresponding lines) app-android/src/main/java/org/mtransit/android/ui/fragment/MTFragmentX.java:196— app-android/src/main/java/org/mtransit/android/ui/fragment/MTFragmentX.java:196-201 | app-android/src/main/java/org/mtransit/android/ui/fragment/MTPreferenceFragment.java:214-219 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (9 lines × 2) app-android/src/main/java/org/mtransit/android/data/RouteDirectionManager.kt:50— app-android/src/main/java/org/mtransit/android/data/RouteDirectionManager.kt:50-58 | app-android/src/main/java/org/mtransit/android/data/RouteManager.kt:50-58 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) app-android/src/main/java/org/mtransit/android/ui/home/HomeFragment.kt:419— app-android/src/main/java/org/mtransit/android/ui/home/HomeFragment.kt:419-427 | app-android/src/main/java/org/mtransit/android/ui/nearby/type/NearbyAgencyTypeFragment.kt:265-273 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (9 lines × 2) app-android/src/main/java/org/mtransit/android/ui/nearby/NearbyFragment.kt:447— app-android/src/main/java/org/mtransit/android/ui/nearby/NearbyFragment.kt:447-455 | app-android/src/main/java/org/mtransit/android/ui/rds/route/RDSRouteFragment.kt:458-466 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (9 lines × 2) app-android/src/main/java/org/mtransit/android/data/RouteDirectionManager.kt:67— app-android/src/main/java/org/mtransit/android/data/RouteDirectionManager.kt:67-75 | app-android/src/main/java/org/mtransit/android/data/RouteManager.kt:67-75 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app-android/src/main/java/org/mtransit/android/data/RouteDirectionManager.kt:67` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (9 lines × 2) app-android/src/main/java/org/mtransit/android/data/UISchedule.java:1020— app-android/src/main/java/org/mtransit/android/data/UISchedule.java:1020-1028 | app-android/src/main/java/org/mtransit/android/data/UISchedule.java:1036-1044 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `app-android/src/main/java/org/mtransit/android/data/UISchedule.java:1019` calls `size` and `app-android/src/main/java/org/mtransit/android/data/UISchedule.java:1035` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Hotspot: app-android/src/main/java/org/mtransit/android/ui/view/MapViewController.java app-android/src/main/java/org/mtransit/android/ui/view/MapViewController.java:906— app-android/src/main/java/org/mtransit/android/ui/view/MapViewController.java changed 9 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 17 in MapViewController.includeMarkersInLatLngBounds at line 906. 6 of those changes were fix/bug commits, so the churn is repair rather than feature work. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-18..2026-11-16, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-18 15:47:15 -05:00' --until='2026-11-16 15:47:15 -05:00' --full-history --no-merges -- app-android/src/main/java/org/mtransit/android/ui/view/MapViewController.java`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt:304— app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 21 in RDSDirectionStopsFragment.onViewCreated at line 304. 1 of those changes was a fix/bug commit, and the other 3 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-18..2026-11-16, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-18 15:47:15 -05:00' --until='2026-11-16 15:47:15 -05:00' --full-history --no-merges -- app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: app-android/src/main/java/org/mtransit/android/usecase/GetNearbyPOIListUseCase.kt app-android/src/main/java/org/mtransit/android/usecase/GetNearbyPOIListUseCase.kt:67— app-android/src/main/java/org/mtransit/android/usecase/GetNearbyPOIListUseCase.kt changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 23 in GetNearbyPOIListUseCase.invoke at line 67. 2 of those changes were fix/bug commits, so the churn is repair rather than feature work. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-18..2026-11-16, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-18 15:47:15 -05:00' --until='2026-11-16 15:47:15 -05:00' --full-history --no-merges -- app-android/src/main/java/org/mtransit/android/usecase/GetNearbyPOIListUseCase.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: app-android/src/main/java/org/mtransit/android/ui/pref/main/MainPreferencesFragment.kt app-android/src/main/java/org/mtransit/android/ui/pref/main/MainPreferencesFragment.kt:336— app-android/src/main/java/org/mtransit/android/ui/pref/main/MainPreferencesFragment.kt changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 16 in MainPreferencesFragment.onViewCreated at line 336. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-18..2026-11-16, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-18 15:47:15 -05:00' --until='2026-11-16 15:47:15 -05:00' --full-history --no-merges -- app-android/src/main/java/org/mtransit/android/ui/pref/main/MainPreferencesFragment.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
MethodTooLong: MainPreferencesFragment.onCreate app-android/src/main/java/org/mtransit/android/ui/pref/main/MainPreferencesFragment.kt:90— MethodTooLong — onCreate runs 144 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 44 over it, 1.44× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: RDSDirectionStopsFragment.onViewCreated app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt:304— MethodTooLong — onViewCreated runs 121 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 21 over it, 1.21× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: POIStatusDetailViewController.updateScheduleView app-android/src/main/java/org/mtransit/android/ui/view/POIStatusDetailViewController.java:356— MethodTooLong — updateScheduleView runs 109 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 9 over it, 1.09× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: UISchedule.generateScheduleListTimes app-android/src/main/java/org/mtransit/android/data/UISchedule.java:543— MethodTooLong — generateScheduleListTimes runs 108 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 8 over it, 1.08× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
D4 · Code Duplication· Edited copy of a member (17 corresponding lines) · ×4
Edited copy of a member (17 corresponding lines) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:834— app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:834-850 | app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:852-868 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (17 corresponding lines) app-android/src/main/java/org/mtransit/android/ui/view/MTPieChartPercentView.java:71— app-android/src/main/java/org/mtransit/android/ui/view/MTPieChartPercentView.java:71-87 | app-android/src/main/java/org/mtransit/android/ui/view/MTPieChartPercentView.java:89-109 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (17 corresponding lines) app-android/src/main/java/org/mtransit/android/ui/view/map/lazy/LazyMarker.java:183— app-android/src/main/java/org/mtransit/android/ui/view/map/lazy/LazyMarker.java:183-202 | app-android/src/main/java/org/mtransit/android/ui/view/map/lazy/LazyMarker.java:245-261 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (17 corresponding lines) app-android/src/main/java/org/mtransit/android/ui/news/NewsListAdapter.kt:277— app-android/src/main/java/org/mtransit/android/ui/news/NewsListAdapter.kt:277-293 | app-android/src/main/java/org/mtransit/android/ui/schedule/ScheduleAdapter.kt:428-444 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (9 corresponding lines) · ×4
Edited copy of a member (9 corresponding lines) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1050— app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1050-1060 | app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1074-1082 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) app-android/src/main/java/org/mtransit/android/data/JPaths.java:142— app-android/src/main/java/org/mtransit/android/data/JPaths.java:142-150 | app-android/src/main/java/org/mtransit/android/data/JPaths.java:188-197 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) app-android/src/main/java/org/mtransit/android/ui/MainActivity.kt:516— app-android/src/main/java/org/mtransit/android/ui/MainActivity.kt:516-525 | app-android/src/main/java/org/mtransit/android/ui/main/NextMainActivity.kt:388-396 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) app-android/src/main/java/org/mtransit/android/ui/nearby/NearbyFragment.kt:302— app-android/src/main/java/org/mtransit/android/ui/nearby/NearbyFragment.kt:302-312 | app-android/src/main/java/org/mtransit/android/ui/type/AgencyTypeFragment.kt:440-448 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (14 corresponding lines) · ×4
Edited copy of a member (14 corresponding lines) app-android/src/main/java/org/mtransit/android/ui/home/HomeViewModel.kt:410— app-android/src/main/java/org/mtransit/android/ui/home/HomeViewModel.kt:410-423 | app-android/src/main/java/org/mtransit/android/ui/nearby/NearbyViewModel.kt:263-280 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (14 corresponding lines) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1663— app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1663-1676 | app-android/src/main/java/org/mtransit/android/ui/view/POIViewController.java:142-155 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (14 corresponding lines) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1682— app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1682-1695 | app-android/src/main/java/org/mtransit/android/ui/view/POIViewController.java:113-126 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (14 corresponding lines) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1775— app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1775-1788 | app-android/src/main/java/org/mtransit/android/ui/view/POIViewController.java:170-183 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (12 lines × 2) app-android/src/main/java/org/mtransit/android/ui/news/details/NewsDetailsFragment.kt:274— app-android/src/main/java/org/mtransit/android/ui/news/details/NewsDetailsFragment.kt:274-285 | app-android/src/main/java/org/mtransit/android/ui/news/details/NewsDetailsFragment.kt:288-299 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (12 lines × 2) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:839— app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:839-850 | app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:857-868 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:839` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) app-android/src/main/java/org/mtransit/android/data/POIManager.java:631— app-android/src/main/java/org/mtransit/android/data/POIManager.java:631-642 | app-android/src/main/java/org/mtransit/android/data/POIManager.java:661-672 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: the declarations holding them bind `defaultColor` to `Integer` in one and `int` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (12 lines × 2) app-android/src/main/java/org/mtransit/android/provider/FavoriteProvider.java:251— app-android/src/main/java/org/mtransit/android/provider/FavoriteProvider.java:251-262 | app-android/src/main/java/org/mtransit/android/provider/FavoriteProvider.java:289-300 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app-android/src/main/java/org/mtransit/android/provider/FavoriteProvider.java:251` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) app-android/src/main/java/org/mtransit/android/ui/main/NextMainActivity.kt:124— app-android/src/main/java/org/mtransit/android/ui/main/NextMainActivity.kt:124-133 | app-android/src/main/java/org/mtransit/android/ui/pref/PreferencesActivity.kt:58-67 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (10 lines × 2) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:441— app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:441-450 | app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:483-492 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:441` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) app-android/src/main/java/org/mtransit/android/ui/fragment/WebBrowserFragment.java:536— app-android/src/main/java/org/mtransit/android/ui/fragment/WebBrowserFragment.java:536-545 | app-android/src/main/java/org/mtransit/android/ui/fragment/WebBrowserFragment.java:549-558 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (10 lines × 2) app-android/src/main/java/org/mtransit/android/ui/view/POIServiceUpdateViewController.java:61— app-android/src/main/java/org/mtransit/android/ui/view/POIServiceUpdateViewController.java:61-70 | app-android/src/main/java/org/mtransit/android/ui/view/POIServiceUpdateViewController.java:77-86 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Change-coupling hub: POIArrayAdapter.java → NearbyAgencyTypeViewModel.kt, POIServiceUpdateViewController.java, POIViewController.java app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java— `app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java` changes together with 3 other files — `app-android/src/main/java/org/mtransit/android/ui/nearby/type/NearbyAgencyTypeViewModel.kt`, `app-android/src/main/java/org/mtransit/android/ui/view/POIServiceUpdateViewController.java`, `app-android/src/main/java/org/mtransit/android/ui/view/POIViewController.java` — none of which declares a dependency on it: one file is the hub of 3 separate couplings, not 3 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 3.
Change-coupling hub: PickPOIDialogFragment.kt → FavoritesFragment.kt, HomeFragment.kt, NearbyAgencyTypeFragment.kt, RDSDirectionStopsFragment.kt, SearchFragment.kt, AgencyPOIsFragment.kt app-android/src/main/java/org/mtransit/android/ui/pick/PickPOIDialogFragment.kt— `app-android/src/main/java/org/mtransit/android/ui/pick/PickPOIDialogFragment.kt` changes together with 6 other files — `app-android/src/main/java/org/mtransit/android/ui/favorites/FavoritesFragment.kt`, `app-android/src/main/java/org/mtransit/android/ui/home/HomeFragment.kt`, `app-android/src/main/java/org/mtransit/android/ui/nearby/type/NearbyAgencyTypeFragment.kt`, `app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt`, `app-android/src/main/java/org/mtransit/android/ui/search/SearchFragment.kt`, `app-android/src/main/java/org/mtransit/android/ui/type/poi/AgencyPOIsFragment.kt` — none of which declares a dependency on it: one file is the hub of 6 separate couplings, not 6 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 6.
Change-coupling hub: UIScheduleExt.kt → POIManager.java, ScheduleAdapter.kt, ScheduleFragment.kt, ScheduleViewModel.kt app-android/src/main/java/org/mtransit/android/data/UIScheduleExt.kt— `app-android/src/main/java/org/mtransit/android/data/UIScheduleExt.kt` changes together with 4 other files — `app-android/src/main/java/org/mtransit/android/data/POIManager.java`, `app-android/src/main/java/org/mtransit/android/ui/schedule/ScheduleAdapter.kt`, `app-android/src/main/java/org/mtransit/android/ui/schedule/ScheduleFragment.kt`, `app-android/src/main/java/org/mtransit/android/ui/schedule/ScheduleViewModel.kt` — none of which declares a dependency on it: one file is the hub of 4 separate couplings, not 4 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 4.
D4 · Code Duplication· Edited copy of a member (18 corresponding lines) · ×3
Edited copy of a member (18 corresponding lines) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1710— app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1710-1727 | app-android/src/main/java/org/mtransit/android/ui/view/POIViewController.java:271-288 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (18 corresponding lines) app-android/src/main/java/org/mtransit/android/data/DataSourceManager.java:312— app-android/src/main/java/org/mtransit/android/data/DataSourceManager.java:312-330 | app-android/src/main/java/org/mtransit/android/data/DataSourceManager.java:414-431 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (18 corresponding lines) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1815— app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1815-1835 | app-android/src/main/java/org/mtransit/android/ui/view/POIViewController.java:314-331 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 11+ corresponding lines) · ×3
Edited copies of one member (3 members, 11+ corresponding lines) app-android/src/main/java/org/mtransit/android/ui/view/POIStatusDetailViewController.java:216— app-android/src/main/java/org/mtransit/android/ui/view/POIStatusDetailViewController.java:216-226 | app-android/src/main/java/org/mtransit/android/ui/view/POIViewController.java:342-352 | app-android/src/main/java/org/mtransit/android/ui/view/POIViewController.java:371-381 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Edited copies of one member (3 members, 11+ corresponding lines) app-android/src/main/java/org/mtransit/android/data/JPaths.java:380— app-android/src/main/java/org/mtransit/android/data/JPaths.java:380-390 | app-android/src/main/java/org/mtransit/android/data/JPaths.java:455-466 | app-android/src/main/java/org/mtransit/android/data/JPaths.java:530-543 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Edited copies of one member (3 members, 11+ corresponding lines) app-android/src/main/java/org/mtransit/android/ui/view/POIViewController.java:129— app-android/src/main/java/org/mtransit/android/ui/view/POIViewController.java:129-139 | app-android/src/main/java/org/mtransit/android/ui/view/POIViewController.java:158-168 | app-android/src/main/java/org/mtransit/android/ui/view/POIViewController.java:186-196 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 6+ corresponding lines) · ×3
Edited copies of one member (3 members, 6+ corresponding lines) app-android/src/main/java/org/mtransit/android/ui/MTFragmentActivity.java:35— app-android/src/main/java/org/mtransit/android/ui/MTFragmentActivity.java:35-40 | app-android/src/main/java/org/mtransit/android/ui/fragment/MTFragmentX.java:56-61 | app-android/src/main/java/org/mtransit/android/ui/fragment/MTPreferenceFragment.java:77-82 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 6 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Edited copies of one member (3 members, 6+ corresponding lines) app-android/src/main/java/org/mtransit/android/data/Module.java:204— app-android/src/main/java/org/mtransit/android/data/Module.java:204-209 | app-android/src/main/java/org/mtransit/android/data/Place.java:135-140 | app-android/src/main/java/org/mtransit/android/data/TextMessage.java:73-78 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 6 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Edited copies of one member (3 members, 6+ corresponding lines) app-android/src/main/java/org/mtransit/android/ui/view/poi/status/POIAppStatusViewHolder.kt:23— app-android/src/main/java/org/mtransit/android/ui/view/poi/status/POIAppStatusViewHolder.kt:23-28 | app-android/src/main/java/org/mtransit/android/ui/view/poi/status/POIAvailabilityStatusViewHolder.kt:26-31 | app-android/src/main/java/org/mtransit/android/ui/view/poi/status/POIScheduleViewHolder.kt:32-37 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 6 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Duplicated block (10 lines × 3) app-android/src/main/java/org/mtransit/android/ui/map/MapFragment.kt:259— app-android/src/main/java/org/mtransit/android/ui/map/MapFragment.kt:259-268 | app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt:469-478 | app-android/src/main/java/org/mtransit/android/ui/type/poi/AgencyPOIsFragment.kt:353-362 — before extracting anything, compare `app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt` and `app-android/src/main/java/org/mtransit/android/ui/type/poi/AgencyPOIsFragment.kt` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 67 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app-android/src/main/java/org/mtransit/android/ui/map/MapFragment.kt:259` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 3) app-android/src/main/java/org/mtransit/android/ui/nearby/NearbyFragment.kt:340— app-android/src/main/java/org/mtransit/android/ui/nearby/NearbyFragment.kt:340-349 | app-android/src/main/java/org/mtransit/android/ui/rds/route/RDSRouteFragment.kt:392-401 | app-android/src/main/java/org/mtransit/android/ui/type/AgencyTypeFragment.kt:380-389 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
Duplicated block (10 lines × 3) app-android/src/main/java/org/mtransit/android/ui/modules/ModulesActivity.kt:40— app-android/src/main/java/org/mtransit/android/ui/modules/ModulesActivity.kt:40-49 | app-android/src/main/java/org/mtransit/android/ui/pref/PreferencesActivity.kt:106-115 | app-android/src/main/java/org/mtransit/android/ui/purchase/PurchaseActivity.kt:58-67 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
Duplicated block (5 lines × 2) app-android/src/main/java/org/mtransit/android/datasource/DataSourcesReader.kt:308— app-android/src/main/java/org/mtransit/android/datasource/DataSourcesReader.kt:308-312 | app-android/src/main/java/org/mtransit/android/datasource/DataSourcesReader.kt:472-476 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (5 lines × 2) app-android/src/main/java/org/mtransit/android/ui/nearby/NearbyFragment.kt:227— app-android/src/main/java/org/mtransit/android/ui/nearby/NearbyFragment.kt:227-231 | app-android/src/main/java/org/mtransit/android/ui/rds/route/RDSRouteFragment.kt:216-220 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app-android/src/main/java/org/mtransit/android/ui/nearby/NearbyFragment.kt:227` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 2) app-android/src/main/java/org/mtransit/android/ui/fragment/POIFragment.java:1466— app-android/src/main/java/org/mtransit/android/ui/fragment/POIFragment.java:1466-1470 | app-android/src/main/java/org/mtransit/android/ui/fragment/WebBrowserFragment.java:406-410 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (11 lines × 2) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1717— app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1717-1727 | app-android/src/main/java/org/mtransit/android/ui/view/POIViewController.java:278-288 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1717` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1762— app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1762-1772 | app-android/src/main/java/org/mtransit/android/ui/view/POIViewController.java:298-308 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1762` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:465— app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:465-475 | app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:507-517 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:465` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:476` calls `w` and `app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:518` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Repeated repair: app-android/src/main/java/org/mtransit/android/ui/schedule/ScheduleAdapter.kt app-android/src/main/java/org/mtransit/android/ui/schedule/ScheduleAdapter.kt:342— app-android/src/main/java/org/mtransit/android/ui/schedule/ScheduleAdapter.kt changed 6 times in last 90 days and 5 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 12 (its worst body is ScheduleAdapter.getPosition at line 342), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix”; “fix”; “Schedule screen > fix non-real-time timestamps sort order (#471)”; “Schedule screen > fix non-real-time timestamp sort order”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-18..2026-11-16, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-18 15:47:15 -05:00' --until='2026-11-16 15:47:15 -05:00' --full-history --no-merges -- app-android/src/main/java/org/mtransit/android/ui/schedule/ScheduleAdapter.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: app-android/src/main/java/org/mtransit/android/ui/MTApplication.kt app-android/src/main/java/org/mtransit/android/ui/MTApplication.kt:59— app-android/src/main/java/org/mtransit/android/ui/MTApplication.kt changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 4 (its worst body is MTApplication.onCreate at line 59), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix crash in App.onCreate() > Night Utils > SharedPrefs from != process (#491)”; “MapsInitializer > fix ANR duing `Application.onCreate()` (#484)”; “Fix crash RuntimeException: Using WebView from 1+ processes w/ same data dir not supported. (#473)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-18..2026-11-16, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-18 15:47:15 -05:00' --until='2026-11-16 15:47:15 -05:00' --full-history --no-merges -- app-android/src/main/java/org/mtransit/android/ui/MTApplication.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
D4 · Code Duplication· Edited copy of a member (15 corresponding lines) · ×2
Edited copy of a member (15 corresponding lines) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1758— app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1758-1772 | app-android/src/main/java/org/mtransit/android/ui/view/POIViewController.java:294-308 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (15 corresponding lines) app-android/src/main/java/org/mtransit/android/data/DataSourceManager.java:434— app-android/src/main/java/org/mtransit/android/data/DataSourceManager.java:434-448 | app-android/src/main/java/org/mtransit/android/data/DataSourceManager.java:519-533 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (8 corresponding lines) · ×2
Edited copy of a member (8 corresponding lines) app-android/src/main/java/org/mtransit/android/ui/view/POIStatusDetailViewController.java:265— app-android/src/main/java/org/mtransit/android/ui/view/POIStatusDetailViewController.java:265-272 | app-android/src/main/java/org/mtransit/android/ui/view/POIStatusDetailViewController.java:344-351 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) app-android/src/main/java/org/mtransit/android/ui/type/AgencyTypeFragment.kt:76— app-android/src/main/java/org/mtransit/android/ui/type/AgencyTypeFragment.kt:76-83 | app-android/src/main/java/org/mtransit/android/ui/type/poi/AgencyPOIsFragment.kt:64-71 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (11 corresponding lines) · ×2
Edited copy of a member (11 corresponding lines) app-android/src/main/java/org/mtransit/android/task/ServiceUpdateLoader.java:247— app-android/src/main/java/org/mtransit/android/task/ServiceUpdateLoader.java:247-257 | app-android/src/main/java/org/mtransit/android/task/StatusLoader.java:172-182 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (11 corresponding lines) app-android/src/main/java/org/mtransit/android/ui/fragment/POIFragmentExt.kt:125— app-android/src/main/java/org/mtransit/android/ui/fragment/POIFragmentExt.kt:125-135 | app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt:642-652 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (16 lines × 2) app-android/src/main/java/org/mtransit/android/ui/location/GeocoderManager.kt:79— app-android/src/main/java/org/mtransit/android/ui/location/GeocoderManager.kt:79-94 | app-android/src/main/java/org/mtransit/android/ui/location/GeocoderManager.kt:109-124 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app-android/src/main/java/org/mtransit/android/ui/location/GeocoderManager.kt:79` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (16 lines × 2) app-android/src/main/java/org/mtransit/android/data/POIManager.java:446— app-android/src/main/java/org/mtransit/android/data/POIManager.java:446-461 | app-android/src/main/java/org/mtransit/android/data/POIManager.java:773-788 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `app-android/src/main/java/org/mtransit/android/data/POIManager.java:772` calls `getPkg` and `app-android/src/main/java/org/mtransit/android/data/POIManager.java:445` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (8 lines × 2) app-android/src/main/java/org/mtransit/android/ui/rds/route/RDSRouteFragment.kt:268— app-android/src/main/java/org/mtransit/android/ui/rds/route/RDSRouteFragment.kt:268-275 | app-android/src/main/java/org/mtransit/android/ui/type/AgencyTypeFragment.kt:329-336 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app-android/src/main/java/org/mtransit/android/ui/rds/route/RDSRouteFragment.kt:268` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8 lines × 2) app-android/src/main/java/org/mtransit/android/data/POIManager.java:458— app-android/src/main/java/org/mtransit/android/data/POIManager.java:458-465 | app-android/src/main/java/org/mtransit/android/data/POIManager.java:466-473 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (7 lines × 2) app-android/src/main/java/org/mtransit/android/ui/MainActivity.kt:245— app-android/src/main/java/org/mtransit/android/ui/MainActivity.kt:245-251 | app-android/src/main/java/org/mtransit/android/ui/main/NextMainActivity.kt:256-262 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `app-android/src/main/java/org/mtransit/android/ui/MainActivity.kt:254` calls `trackButtonClick` and `app-android/src/main/java/org/mtransit/android/ui/main/NextMainActivity.kt:265` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7 lines × 2) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1928— app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1928-1934 | app-android/src/main/java/org/mtransit/android/ui/fragment/POIFragment.java:1454-1460 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (23 lines × 2) app-android/src/main/java/org/mtransit/android/data/Module.java:270— app-android/src/main/java/org/mtransit/android/data/Module.java:270-292 | app-android/src/main/java/org/mtransit/android/data/Module.java:311-333 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app-android/src/main/java/org/mtransit/android/data/Module.java:270` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `app-android/src/main/java/org/mtransit/android/data/Module.java:293` calls `fromJSON` and `app-android/src/main/java/org/mtransit/android/data/Module.java:334` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (23 lines × 2) app-android/src/main/java/org/mtransit/android/data/POIManager.java:504— app-android/src/main/java/org/mtransit/android/data/POIManager.java:504-526 | app-android/src/main/java/org/mtransit/android/data/POIManager.java:790-812 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (13 lines × 2) app-android/src/main/java/org/mtransit/android/ui/fragment/POIFragment.java:843— app-android/src/main/java/org/mtransit/android/ui/fragment/POIFragment.java:843-855 | app-android/src/main/java/org/mtransit/android/ui/fragment/POIFragment.java:888-900 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app-android/src/main/java/org/mtransit/android/ui/fragment/POIFragment.java:843` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1950— app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1950-1962 | app-android/src/main/java/org/mtransit/android/ui/view/POIViewController.java:399-411 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1950` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Low cohesion: PlaceProvider (LCOM4 8) app-android/src/main/java/org/mtransit/android/provider/PlaceProvider.kt:49— PlaceProvider's methods fall into 8 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 8 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: RDSDirectionStopsViewModel (LCOM4 5) app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsViewModel.kt:54— RDSDirectionStopsViewModel's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
UISchedule.generateScheduleListTimes (cyclomatic 42) app-android/src/main/java/org/mtransit/android/data/UISchedule.java:543— UISchedule.generateScheduleListTimes has cyclomatic complexity 42 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This file is where this pass's cyclomatic complexity CONCENTRATES: app-android/src/main/java/org/mtransit/android/data/UISchedule.java holds 3 of the 24 methods over the threshold — including the worst — and 50 of the 160 points over it (31%), 2.8× the next-largest file (app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java at 18). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
UISchedule.findTimesSectionsStartEnd (cyclomatic 34) app-android/src/main/java/org/mtransit/android/data/UISchedule.java:679— UISchedule.findTimesSectionsStartEnd has cyclomatic complexity 34 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This file is where this pass's cyclomatic complexity CONCENTRATES: app-android/src/main/java/org/mtransit/android/data/UISchedule.java holds 3 of the 24 methods over the threshold — including the worst — and 50 of the 160 points over it (31%), 2.8× the next-largest file (app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java at 18). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
KeysManager.getKeysMap (cyclomatic 32) app-android/src/main/java/org/mtransit/android/util/KeysManager.kt:54— KeysManager.getKeysMap has cyclomatic complexity 32 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
POIStatusDetailViewController.updateScheduleView (cyclomatic 29) app-android/src/main/java/org/mtransit/android/ui/view/POIStatusDetailViewController.java:356— POIStatusDetailViewController.updateScheduleView has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
GetNearbyPOIListUseCase.invoke (cyclomatic 23) app-android/src/main/java/org/mtransit/android/usecase/GetNearbyPOIListUseCase.kt:67— GetNearbyPOIListUseCase.invoke has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
POIArrayAdapter.updateCommonView (cyclomatic 23) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1936— POIArrayAdapter.updateCommonView has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
UITimeUtils.getShortTimeSpanString (cyclomatic 23) app-android/src/main/java/org/mtransit/android/util/UITimeUtils.java:738— UITimeUtils.getShortTimeSpanString has cyclomatic complexity 23 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
MTClusterOptionsProvider.getColor (cyclomatic 22) app-android/src/main/java/org/mtransit/android/ui/view/map/MTClusterOptionsProvider.java:59— MTClusterOptionsProvider.getColor has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
UITimeUtils.getShortTimeSpanNumber (cyclomatic 22) app-android/src/main/java/org/mtransit/android/util/UITimeUtils.java:585— UITimeUtils.getShortTimeSpanNumber has cyclomatic complexity 22 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
RDSDirectionStopsFragment.onViewCreated (cyclomatic 21) app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt:304— RDSDirectionStopsFragment.onViewCreated has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FavoritesUI.showPickFavoriteFolderDialog (cyclomatic 20) app-android/src/main/java/org/mtransit/android/provider/favorite/FavoritesUI.kt:64— FavoritesUI.showPickFavoriteFolderDialog has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
POIArrayAdapter.onTypeHeaderButtonClick (cyclomatic 20) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1446— POIArrayAdapter.onTypeHeaderButtonClick has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
POIManager.setStatus (cyclomatic 20) app-android/src/main/java/org/mtransit/android/data/POIManager.java:187— POIManager.setStatus has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
UISchedule.getNextTimestamps (cyclomatic 19) app-android/src/main/java/org/mtransit/android/data/UISchedule.java:402— UISchedule.getNextTimestamps has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This file is where this pass's cyclomatic complexity CONCENTRATES: app-android/src/main/java/org/mtransit/android/data/UISchedule.java holds 3 of the 24 methods over the threshold — including the worst — and 50 of the 160 points over it (31%), 2.8× the next-largest file (app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java at 18). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
NavigationDrawerController.getScreenItemId (cyclomatic 19) app-android/src/main/java/org/mtransit/android/ui/NavigationDrawerController.java:466— NavigationDrawerController.getScreenItemId has cyclomatic complexity 19 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
POIArrayAdapter.getItemViewType (cyclomatic 18) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:353— POIArrayAdapter.getItemViewType has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
POIManager.showPoiViewerScreen (cyclomatic 18) app-android/src/main/java/org/mtransit/android/data/POIManager.java:755— POIManager.showPoiViewerScreen has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
POIArrayAdapter.getView (cyclomatic 17) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:542— POIArrayAdapter.getView has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
POIManager.onActionsItemClickApp (cyclomatic 17) app-android/src/main/java/org/mtransit/android/data/POIManager.java:431— POIManager.onActionsItemClickApp has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MapViewController.includeMarkersInLatLngBounds (cyclomatic 17) app-android/src/main/java/org/mtransit/android/ui/view/MapViewController.java:906— MapViewController.includeMarkersInLatLngBounds has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DataSourcesReader.lookForNewDataSources (cyclomatic 16) app-android/src/main/java/org/mtransit/android/datasource/DataSourcesReader.kt:303— DataSourcesReader.lookForNewDataSources has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MainPreferencesFragment.onViewCreated (cyclomatic 16) app-android/src/main/java/org/mtransit/android/ui/pref/main/MainPreferencesFragment.kt:336— MainPreferencesFragment.onViewCreated has cyclomatic complexity 16 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
NavigationDrawerController.getScreenNavItemId (cyclomatic 16) app-android/src/main/java/org/mtransit/android/ui/NavigationDrawerController.java:512— NavigationDrawerController.getScreenNavItemId has cyclomatic complexity 16 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
NavigationDrawerController.startNewScreen (cyclomatic 16) app-android/src/main/java/org/mtransit/android/ui/NavigationDrawerController.java:649— NavigationDrawerController.startNewScreen has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
UISchedule.generateScheduleListTimes (cognitive 82) app-android/src/main/java/org/mtransit/android/data/UISchedule.java:543— UISchedule.generateScheduleListTimes has cognitive complexity 82 (threshold 15). Drivers by points: if/else 29 (62 pts), boolean chains 13, ternaries 3 (6 pts), loops 1 (nesting depth added 36). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UISchedule.findTimesSectionsStartEnd (cognitive 80) app-android/src/main/java/org/mtransit/android/data/UISchedule.java:679— UISchedule.findTimesSectionsStartEnd has cognitive complexity 80 (threshold 15). Drivers by points: if/else 27 (73 pts), boolean chains 5, loops 2 (nesting depth added 46). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
POIStatusDetailViewController.updateScheduleView (cognitive 69) app-android/src/main/java/org/mtransit/android/ui/view/POIStatusDetailViewController.java:356— POIStatusDetailViewController.updateScheduleView has cognitive complexity 69 (threshold 15). Drivers by points: if/else 21 (51 pts), ternaries 6 (8 pts), boolean chains 5, loops 2 (5 pts) (nesting depth added 35). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
GetNearbyPOIListUseCase.invoke (cognitive 42) app-android/src/main/java/org/mtransit/android/usecase/GetNearbyPOIListUseCase.kt:67— GetNearbyPOIListUseCase.invoke has cognitive complexity 42 (threshold 15). Drivers by points: if/else 12 (29 pts), boolean chains 12, loops 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
POIArrayAdapter.onTypeHeaderButtonClick (cognitive 42) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1446— POIArrayAdapter.onTypeHeaderButtonClick has cognitive complexity 42 (threshold 15). Drivers by points: if/else 19 (39 pts), boolean chains 1, match/switch 1, ternaries 1 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
POIArrayAdapter.updateCommonView (cognitive 37) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1936— POIArrayAdapter.updateCommonView has cognitive complexity 37 (threshold 15). Drivers by points: if/else 22 (31 pts), boolean chains 5, match/switch 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
POIManager.setStatus (cognitive 35) app-android/src/main/java/org/mtransit/android/data/POIManager.java:187— POIManager.setStatus has cognitive complexity 35 (threshold 15). Drivers by points: if/else 14 (33 pts), boolean chains 1, match/switch 1 (nesting depth added 19). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
FavoritesUI.showPickFavoriteFolderDialog (cognitive 34) app-android/src/main/java/org/mtransit/android/provider/favorite/FavoritesUI.kt:64— FavoritesUI.showPickFavoriteFolderDialog has cognitive complexity 34 (threshold 15). Drivers by points: if/else 19 (30 pts), boolean chains 3, loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MTClusterOptionsProvider.getColor (cognitive 33) app-android/src/main/java/org/mtransit/android/ui/view/map/MTClusterOptionsProvider.java:59— MTClusterOptionsProvider.getColor has cognitive complexity 33 (threshold 15). Drivers by points: if/else 16 (27 pts), boolean chains 4, error handling 1, loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RDSDirectionStopsFragment.onViewCreated (cognitive 31) app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt:304— RDSDirectionStopsFragment.onViewCreated has cognitive complexity 31 (threshold 15). Drivers by points: if/else 21 (29 pts), boolean chains 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
POIArrayAdapter.getView (cognitive 31) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:542— POIArrayAdapter.getView has cognitive complexity 31 (threshold 15). Drivers by points: if/else 8 (23 pts), ternaries 1 (5 pts), boolean chains 2, match/switch 1 (nesting depth added 19). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
POIManager.showPoiViewerScreen (cognitive 31) app-android/src/main/java/org/mtransit/android/data/POIManager.java:755— POIManager.showPoiViewerScreen has cognitive complexity 31 (threshold 15). Drivers by points: if/else 14 (29 pts), boolean chains 1, match/switch 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UISchedule.getNextTimestamps (cognitive 31) app-android/src/main/java/org/mtransit/android/data/UISchedule.java:402— UISchedule.getNextTimestamps has cognitive complexity 31 (threshold 15). Drivers by points: if/else 8 (21 pts), boolean chains 7, ternaries 2, loops 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UISchedule.getStatusNextTimestamps (cognitive 30) app-android/src/main/java/org/mtransit/android/data/UISchedule.java:955— UISchedule.getStatusNextTimestamps has cognitive complexity 30 (threshold 15). Drivers by points: if/else 9 (22 pts), loops 2 (5 pts), boolean chains 3 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NestedScrollableHost.handleInterceptTouchEvent (cognitive 28) app-android/src/main/java/org/mtransit/android/ui/view/common/NestedScrollableHost.kt:60— NestedScrollableHost.handleInterceptTouchEvent has cognitive complexity 28 (threshold 15). Drivers by points: if/else 14 (26 pts), boolean chains 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
POIArrayAdapter.getItemViewType (cognitive 28) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:353— POIArrayAdapter.getItemViewType has cognitive complexity 28 (threshold 15). Drivers by points: if/else 7 (19 pts), match/switch 4 (7 pts), boolean chains 2 (nesting depth added 15). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
GridClusteringStrategy.splitClusters (cognitive 28) app-android/src/main/java/org/mtransit/android/ui/view/map/impl/GridClusteringStrategy.java:322— GridClusteringStrategy.splitClusters has cognitive complexity 28 (threshold 15). Drivers by points: if/else 7 (20 pts), loops 3 (6 pts), boolean chains 2 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UITimeUtils.getShortTimeSpanNumber (cognitive 28) app-android/src/main/java/org/mtransit/android/util/UITimeUtils.java:585— UITimeUtils.getShortTimeSpanNumber has cognitive complexity 28 (threshold 15). Drivers by points: if/else 20 (25 pts), boolean chains 3 (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
MapViewController.includeMarkersInLatLngBounds (cognitive 27) app-android/src/main/java/org/mtransit/android/ui/view/MapViewController.java:906— MapViewController.includeMarkersInLatLngBounds has cognitive complexity 27 (threshold 15). Drivers by points: if/else 9 (14 pts), loops 5 (11 pts), boolean chains 1, ternaries 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NewsDetailsFragment.updateThumbnails (cognitive 26) app-android/src/main/java/org/mtransit/android/ui/news/details/NewsDetailsFragment.kt:303— NewsDetailsFragment.updateThumbnails has cognitive complexity 26 (threshold 15). Drivers by points: if/else 13 (25 pts), match/switch 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
POIManager.getActionsItems (cognitive 26) app-android/src/main/java/org/mtransit/android/data/POIManager.java:332— POIManager.getActionsItems has cognitive complexity 26 (threshold 15). Drivers by points: if/else 6 (12 pts), ternaries 5 (12 pts), boolean chains 1, match/switch 1 (nesting depth added 13). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
GridClusteringStrategy.joinClusters (cognitive 26) app-android/src/main/java/org/mtransit/android/ui/view/map/impl/GridClusteringStrategy.java:363— GridClusteringStrategy.joinClusters has cognitive complexity 26 (threshold 15). Drivers by points: if/else 7 (15 pts), loops 4 (9 pts), boolean chains 2 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LinkMovementMethodInterceptor.onTouchEvent (cognitive 26) app-android/src/main/java/org/mtransit/android/util/LinkUtils.java:333— LinkMovementMethodInterceptor.onTouchEvent has cognitive complexity 26 (threshold 15). Drivers by points: if/else 6 (21 pts), ternaries 1 (4 pts), boolean chains 1 (nesting depth added 18). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
POIManager.onActionsItemClickApp (cognitive 25) app-android/src/main/java/org/mtransit/android/data/POIManager.java:431— POIManager.onActionsItemClickApp has cognitive complexity 25 (threshold 15). Drivers by points: if/else 10 (22 pts), boolean chains 2, match/switch 1 (nesting depth added 12). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
MapViewController.onInfoWindowClick (cognitive 25) app-android/src/main/java/org/mtransit/android/ui/view/MapViewController.java:645— MapViewController.onInfoWindowClick has cognitive complexity 25 (threshold 15). Drivers by points: if/else 11 (20 pts), ternaries 4, boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HomeViewModel.filterTypePOIs (cognitive 24) app-android/src/main/java/org/mtransit/android/ui/home/HomeViewModel.kt:279— HomeViewModel.filterTypePOIs has cognitive complexity 24 (threshold 15). Drivers by points: if/else 8 (20 pts), boolean chains 3, loops 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
POIArrayAdapter.notifyDataSetChanged (cognitive 24) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1114— POIArrayAdapter.notifyDataSetChanged has cognitive complexity 24 (threshold 15). Drivers by points: if/else 11 (20 pts), boolean chains 4 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LoadClusterItemsTask.createPOIMarkers (cognitive 24) app-android/src/main/java/org/mtransit/android/ui/view/MapViewController.java:1102— LoadClusterItemsTask.createPOIMarkers has cognitive complexity 24 (threshold 15). Drivers by points: if/else 7 (11 pts), ternaries 4 (8 pts), boolean chains 2, error handling 1 (2 pts), loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DataSourcesReader.lookForNewDataSources (cognitive 23) app-android/src/main/java/org/mtransit/android/datasource/DataSourcesReader.kt:303— DataSourcesReader.lookForNewDataSources has cognitive complexity 23 (threshold 15). Drivers by points: if/else 15 (23 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
POIArrayAdapter.setFavorites (cognitive 22) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:2017— POIArrayAdapter.setFavorites has cognitive complexity 22 (threshold 15). Drivers by points: if/else 8 (16 pts), boolean chains 4, loops 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UITimeUtils.getShortTimeSpanString (cognitive 22) app-android/src/main/java/org/mtransit/android/util/UITimeUtils.java:738— UITimeUtils.getShortTimeSpanString has cognitive complexity 22 (threshold 15). Drivers by points: boolean chains 11, if/else 11. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
POIFragment.onMenuItemSelected (cognitive 20) app-android/src/main/java/org/mtransit/android/ui/fragment/POIFragment.java:1519— POIFragment.onMenuItemSelected has cognitive complexity 20 (threshold 15). Drivers by points: ternaries 5 (14 pts), if/else 4 (6 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
POIViewController.updatePOIDistanceAndCompass (cognitive 20) app-android/src/main/java/org/mtransit/android/ui/view/POIViewController.java:392— POIViewController.updatePOIDistanceAndCompass has cognitive complexity 20 (threshold 15). Drivers by points: if/else 10 (16 pts), boolean chains 3, ternaries 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NavigationDrawerController.startNewScreen (cognitive 20) app-android/src/main/java/org/mtransit/android/ui/NavigationDrawerController.java:649— NavigationDrawerController.startNewScreen has cognitive complexity 20 (threshold 15). Drivers by points: if/else 17 (20 pts) (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
POIArrayAdapter.getBrowseHeaderSectionView (cognitive 19) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:601— POIArrayAdapter.getBrowseHeaderSectionView has cognitive complexity 19 (threshold 15). Drivers by points: if/else 8 (11 pts), boolean chains 3, loops 2 (3 pts), ternaries 2 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
POIArrayAdapter.setupHeaderButtonTextAndIcon (cognitive 19) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:663— POIArrayAdapter.setupHeaderButtonTextAndIcon has cognitive complexity 19 (threshold 15). Drivers by points: ternaries 4 (9 pts), if/else 5 (8 pts), boolean chains 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UISchedule.getStatusStringsTimes (cognitive 19) app-android/src/main/java/org/mtransit/android/data/UISchedule.java:1004— UISchedule.getStatusStringsTimes has cognitive complexity 19 (threshold 15). Drivers by points: if/else 11 (16 pts), boolean chains 3 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
WebBrowserFragment.onResume (cognitive 19) app-android/src/main/java/org/mtransit/android/ui/fragment/WebBrowserFragment.java:241— WebBrowserFragment.onResume has cognitive complexity 19 (threshold 15). Drivers by points: if/else 8 (15 pts), boolean chains 3, ternaries 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NavigationDrawerController.getScreenItemId (cognitive 19) app-android/src/main/java/org/mtransit/android/ui/NavigationDrawerController.java:466— NavigationDrawerController.getScreenItemId has cognitive complexity 19 (threshold 15). Drivers by points: if/else 16, ternaries 1 (2 pts), boolean chains 1 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
LinkUtils.open (cognitive 19) app-android/src/main/java/org/mtransit/android/util/LinkUtils.java:96— LinkUtils.open has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (13 pts), boolean chains 4, ternaries 1 (2 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MTJPathsView.initPaths (cognitive 18) app-android/src/main/java/org/mtransit/android/ui/view/MTJPathsView.java:134— MTJPathsView.initPaths has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (16 pts), loops 1 (2 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ActionBarController.updateABDrawerClosed (cognitive 18) app-android/src/main/java/org/mtransit/android/ui/ActionBarController.java:285— ActionBarController.updateABDrawerClosed has cognitive complexity 18 (threshold 15). Drivers by points: if/else 13 (18 pts) (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MainPreferencesFragment.onViewCreated (cognitive 17) app-android/src/main/java/org/mtransit/android/ui/pref/main/MainPreferencesFragment.kt:336— MainPreferencesFragment.onViewCreated has cognitive complexity 17 (threshold 15). Drivers by points: if/else 10 (11 pts), match/switch 6 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
TimeViewHolder.bind (cognitive 17) app-android/src/main/java/org/mtransit/android/ui/schedule/ScheduleAdapter.kt:665— TimeViewHolder.bind has cognitive complexity 17 (threshold 15). Drivers by points: if/else 13 (16 pts), boolean chains 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
POIArrayAdapter.getPosition (cognitive 17) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:440— POIArrayAdapter.getPosition has cognitive complexity 17 (threshold 15). Drivers by points: if/else 4 (8 pts), ternaries 3 (7 pts), loops 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
POIArrayAdapter.setupHeaderButtonColor (cognitive 17) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:696— POIArrayAdapter.setupHeaderButtonColor has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (11 pts), ternaries 2 (3 pts), boolean chains 2, loops 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NavigationDrawerController.setVisibleMenuItems (cognitive 17) app-android/src/main/java/org/mtransit/android/ui/NavigationDrawerController.java:398— NavigationDrawerController.setVisibleMenuItems has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (11 pts), boolean chains 3, loops 2 (3 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UITimeUtils.cleanTimes (cognitive 17) app-android/src/main/java/org/mtransit/android/util/UITimeUtils.java:475— UITimeUtils.cleanTimes has cognitive complexity 17 (threshold 15). Drivers by points: if/else 4 (10 pts), loops 3 (4 pts), boolean chains 3 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NewsListItemViewHolder.bind (cognitive 16) app-android/src/main/java/org/mtransit/android/ui/news/NewsListAdapter.kt:346— NewsListItemViewHolder.bind has cognitive complexity 16 (threshold 15). Drivers by points: if/else 12 (14 pts), boolean chains 2 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
SplashScreenViewModel.getAndUpdateAppOpenCounts (cognitive 16) app-android/src/main/java/org/mtransit/android/ui/splash/SplashScreenViewModel.kt:250— SplashScreenViewModel.getAndUpdateAppOpenCounts has cognitive complexity 16 (threshold 15). Drivers by points: if/else 10 (14 pts), boolean chains 2 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
KeysManager.getKeysMap (cognitive 16) app-android/src/main/java/org/mtransit/android/util/KeysManager.kt:54— KeysManager.getKeysMap has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (11 pts), match/switch 3 (5 pts) (nesting depth added 7). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
DataSourceManager.findAgencyProperties (cognitive 16) app-android/src/main/java/org/mtransit/android/data/DataSourceManager.java:333— DataSourceManager.findAgencyProperties has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (11 pts), error handling 2 (4 pts), boolean chains 1 (nesting depth added 8). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
POIArrayAdapter.getItem (cognitive 16) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:504— POIArrayAdapter.getItem has cognitive complexity 16 (threshold 15). Drivers by points: if/else 3 (9 pts), loops 2 (6 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PermissionProviderImpl.handleRequestPermissionsResult (cognitive 16) app-android/src/main/java/org/mtransit/android/provider/permission/PermissionProviderImpl.java:87— PermissionProviderImpl.handleRequestPermissionsResult has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (11 pts), boolean chains 2, ternaries 1 (2 pts), loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NavigationDrawerController.getScreenNavItemId (cognitive 16) app-android/src/main/java/org/mtransit/android/ui/NavigationDrawerController.java:512— NavigationDrawerController.getScreenNavItemId has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (8 pts), error handling 2 (4 pts), boolean chains 2, match/switch 1 (2 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D4 · Code Duplication· Members sharing a duplicated core (5 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (5 members, 50+ identical tokens) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1446— app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1446-1556 | app-android/src/main/java/org/mtransit/android/data/POIManager.java:501-529 | app-android/src/main/java/org/mtransit/android/data/POIManager.java:683-718 | app-android/src/main/java/org/mtransit/android/data/POIManager.java:762-844 | app-android/src/main/java/org/mtransit/android/data/POIManager.java:851-875 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
D4 · Code Duplication· Edited copy of a member (36 corresponding lines) · ×1
Edited copy of a member (36 corresponding lines) app-android/src/main/java/org/mtransit/android/provider/FavoriteProvider.java:227— app-android/src/main/java/org/mtransit/android/provider/FavoriteProvider.java:227-262 | app-android/src/main/java/org/mtransit/android/provider/FavoriteProvider.java:265-300 — These two members are one piece of code written twice and then edited apart: 36 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (38 corresponding lines) · ×1
Edited copy of a member (38 corresponding lines) app-android/src/main/java/org/mtransit/android/data/Module.java:261— app-android/src/main/java/org/mtransit/android/data/Module.java:261-299 | app-android/src/main/java/org/mtransit/android/data/Module.java:302-339 — These two members are one piece of code written twice and then edited apart: 38 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (5 members, 40+ corresponding lines) · ×1
Edited copies of one member (5 members, 40+ corresponding lines) app-android/src/main/java/org/mtransit/android/datasource/DataSourcesReader.kt:634— app-android/src/main/java/org/mtransit/android/datasource/DataSourcesReader.kt:634-673 | app-android/src/main/java/org/mtransit/android/datasource/DataSourcesReader.kt:675-714 | app-android/src/main/java/org/mtransit/android/datasource/DataSourcesReader.kt:716-755 | app-android/src/main/java/org/mtransit/android/datasource/DataSourcesReader.kt:760-800 | app-android/src/main/java/org/mtransit/android/datasource/DataSourcesReader.kt:802-841 — These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 40 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (33 corresponding lines) · ×1
Edited copy of a member (33 corresponding lines) app-android/src/main/java/org/mtransit/android/ui/fragment/POIFragment.java:840— app-android/src/main/java/org/mtransit/android/ui/fragment/POIFragment.java:840-883 | app-android/src/main/java/org/mtransit/android/ui/fragment/POIFragment.java:885-917 — These two members are one piece of code written twice and then edited apart: 33 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (43 corresponding lines) · ×1
Edited copy of a member (43 corresponding lines) app-android/src/main/java/org/mtransit/android/ad/banner/BannerAdListener.kt:52— app-android/src/main/java/org/mtransit/android/ad/banner/BannerAdListener.kt:52-101 | app-android/src/main/java/org/mtransit/android/ad/inlinebanner/InlineBannerAdListener.kt:48-90 — These two members are one piece of code written twice and then edited apart: 43 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (35 corresponding lines) · ×1
Edited copy of a member (35 corresponding lines) app-android/src/main/java/org/mtransit/android/util/FragmentUtils.java:91— app-android/src/main/java/org/mtransit/android/util/FragmentUtils.java:91-126 | app-android/src/main/java/org/mtransit/android/util/FragmentUtils.java:171-205 — These two members are one piece of code written twice and then edited apart: 35 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 14+ corresponding lines) · ×1
Edited copies of one member (3 members, 14+ corresponding lines) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1647— app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1647-1660 | app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1742-1756 | app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1792-1806 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 14 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (28 corresponding lines) · ×1
Edited copy of a member (28 corresponding lines) app-android/src/main/java/org/mtransit/android/ui/fares/FaresDialog.kt:74— app-android/src/main/java/org/mtransit/android/ui/fares/FaresDialog.kt:74-104 | app-android/src/main/java/org/mtransit/android/ui/feedback/FeedbackDialog.kt:86-113 — These two members are one piece of code written twice and then edited apart: 28 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (5 members, 25+ corresponding lines) · ×1
Edited copies of one member (5 members, 25+ corresponding lines) app-android/src/main/java/org/mtransit/android/util/FragmentUtils.java:135— app-android/src/main/java/org/mtransit/android/util/FragmentUtils.java:135-164 | app-android/src/main/java/org/mtransit/android/util/FragmentUtils.java:207-231 | app-android/src/main/java/org/mtransit/android/util/FragmentUtils.java:233-257 | app-android/src/main/java/org/mtransit/android/util/FragmentUtils.java:263-291 | app-android/src/main/java/org/mtransit/android/util/FragmentUtils.java:293-323 — These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 25 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (25 corresponding lines) · ×1
Edited copy of a member (25 corresponding lines) app-android/src/main/java/org/mtransit/android/ui/view/POIStatusDetailViewController.java:186— app-android/src/main/java/org/mtransit/android/ui/view/POIStatusDetailViewController.java:186-210 | app-android/src/main/java/org/mtransit/android/ui/view/POIStatusDetailViewController.java:233-258 — These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (23 corresponding lines) · ×1
Edited copy of a member (23 corresponding lines) app-android/src/main/java/org/mtransit/android/provider/FavoriteProvider.java:90— app-android/src/main/java/org/mtransit/android/provider/FavoriteProvider.java:90-112 | app-android/src/main/java/org/mtransit/android/provider/ModuleProvider.java:191-214 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (24 corresponding lines) · ×1
Edited copy of a member (24 corresponding lines) app-android/src/main/java/org/mtransit/android/ui/location/GeocoderManager.kt:73— app-android/src/main/java/org/mtransit/android/ui/location/GeocoderManager.kt:73-97 | app-android/src/main/java/org/mtransit/android/ui/location/GeocoderManager.kt:104-127 — These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (22 corresponding lines) · ×1
Edited copy of a member (22 corresponding lines) app-android/src/main/java/org/mtransit/android/ad/banner/SetupBannerAdTask.kt:52— app-android/src/main/java/org/mtransit/android/ad/banner/SetupBannerAdTask.kt:52-76 | app-android/src/main/java/org/mtransit/android/ad/inlinebanner/SetupInlineBannerAdTask.kt:51-72 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (20 corresponding lines) · ×1
Edited copy of a member (20 corresponding lines) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:440— app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:440-460 | app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:482-501 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 24+ corresponding lines) · ×1
Edited copies of one member (3 members, 24+ corresponding lines) app-android/src/main/java/org/mtransit/android/ui/nearby/NearbyFragment.kt:314— app-android/src/main/java/org/mtransit/android/ui/nearby/NearbyFragment.kt:314-337 | app-android/src/main/java/org/mtransit/android/ui/rds/route/RDSRouteFragment.kt:366-389 | app-android/src/main/java/org/mtransit/android/ui/type/AgencyTypeFragment.kt:354-377 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 24 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (5 members, 14+ corresponding lines) · ×1
Edited copies of one member (5 members, 14+ corresponding lines) app-android/src/main/java/org/mtransit/android/data/DataSourceManager.java:108— app-android/src/main/java/org/mtransit/android/data/DataSourceManager.java:108-121 | app-android/src/main/java/org/mtransit/android/data/DataSourceManager.java:137-150 | app-android/src/main/java/org/mtransit/android/data/DataSourceManager.java:170-184 | app-android/src/main/java/org/mtransit/android/data/DataSourceManager.java:204-217 | app-android/src/main/java/org/mtransit/android/data/DataSourceManager.java:231-244 — These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 14 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 10+ corresponding lines) · ×1
Edited copies of one member (3 members, 10+ corresponding lines) app-android/src/main/java/org/mtransit/android/data/JPaths.java:393— app-android/src/main/java/org/mtransit/android/data/JPaths.java:393-402 | app-android/src/main/java/org/mtransit/android/data/JPaths.java:469-479 | app-android/src/main/java/org/mtransit/android/data/JPaths.java:546-555 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 10 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 16+ corresponding lines) · ×1
Edited copies of one member (3 members, 16+ corresponding lines) app-android/src/main/java/org/mtransit/android/ui/nearby/NearbyFragment.kt:339— app-android/src/main/java/org/mtransit/android/ui/nearby/NearbyFragment.kt:339-354 | app-android/src/main/java/org/mtransit/android/ui/rds/route/RDSRouteFragment.kt:391-409 | app-android/src/main/java/org/mtransit/android/ui/type/AgencyTypeFragment.kt:379-398 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 16 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 17+ corresponding lines) · ×1
Edited copies of one member (3 members, 17+ corresponding lines) app-android/src/main/java/org/mtransit/android/ui/nearby/NearbyPagerAdapter.kt:21— app-android/src/main/java/org/mtransit/android/ui/nearby/NearbyPagerAdapter.kt:21-37 | app-android/src/main/java/org/mtransit/android/ui/rds/route/RDSRouteDirectionPagerAdapter.kt:27-43 | app-android/src/main/java/org/mtransit/android/ui/type/AgencyTypePagerAdapter.kt:27-43 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 17 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 12+ corresponding lines) · ×1
Edited copies of one member (3 members, 12+ corresponding lines) app-android/src/main/java/org/mtransit/android/data/JPaths.java:365— app-android/src/main/java/org/mtransit/android/data/JPaths.java:365-377 | app-android/src/main/java/org/mtransit/android/data/JPaths.java:439-452 | app-android/src/main/java/org/mtransit/android/data/JPaths.java:516-527 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 12 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (21 corresponding lines) · ×1
Edited copy of a member (21 corresponding lines) app-android/src/main/java/org/mtransit/android/ui/favorites/FavoritesFragment.kt:209— app-android/src/main/java/org/mtransit/android/ui/favorites/FavoritesFragment.kt:209-232 | app-android/src/main/java/org/mtransit/android/ui/pick/PickPOIDialogFragment.kt:215-235 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (4 members, 8+ corresponding lines) · ×1
Edited copies of one member (4 members, 8+ corresponding lines) app-android/src/main/java/org/mtransit/android/ui/view/POIServiceUpdateViewController.java:122— app-android/src/main/java/org/mtransit/android/ui/view/POIServiceUpdateViewController.java:122-129 | app-android/src/main/java/org/mtransit/android/ui/view/POIStatusDetailViewController.java:171-178 | app-android/src/main/java/org/mtransit/android/ui/view/POIViewController.java:333-340 | app-android/src/main/java/org/mtransit/android/ui/view/POIViewController.java:358-365 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 8 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (7 members, 11+ corresponding lines) · ×1
Edited copies of one member (7 members, 11+ corresponding lines) app-android/src/main/java/org/mtransit/android/data/DataSourceManager.java:153— app-android/src/main/java/org/mtransit/android/data/DataSourceManager.java:153-163 | app-android/src/main/java/org/mtransit/android/data/DataSourceManager.java:187-197 | app-android/src/main/java/org/mtransit/android/data/DataSourceManager.java:467-478 | app-android/src/main/java/org/mtransit/android/data/DataSourceManager.java:505-516 | app-android/src/main/java/org/mtransit/android/data/DataSourceManager.java:590-601 | app-android/src/main/java/org/mtransit/android/data/DataSourceManager.java:631-641 | app-android/src/main/java/org/mtransit/android/data/DataSourceManager.java:662-674 — These 7 members are one piece of code written 7 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 7 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 7+ corresponding lines) · ×1
Edited copies of one member (3 members, 7+ corresponding lines) app-android/src/main/java/org/mtransit/android/ui/map/MapFragment.kt:285— app-android/src/main/java/org/mtransit/android/ui/map/MapFragment.kt:285-294 | app-android/src/main/java/org/mtransit/android/ui/rds/route/RDSRouteFragment.kt:348-356 | app-android/src/main/java/org/mtransit/android/ui/type/AgencyTypeFragment.kt:424-430 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 7 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 9+ corresponding lines) · ×1
Edited copies of one member (3 members, 9+ corresponding lines) app-android/src/main/java/org/mtransit/android/ui/rds/route/RDSRouteFragment.kt:74— app-android/src/main/java/org/mtransit/android/ui/rds/route/RDSRouteFragment.kt:74-82 | app-android/src/main/java/org/mtransit/android/ui/rds/route/RDSRouteFragment.kt:112-120 | app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt:96-104 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 8+ corresponding lines) · ×1
Edited copies of one member (3 members, 8+ corresponding lines) app-android/src/main/java/org/mtransit/android/ui/inappnotification/locationpermission/LocationPermissionUI.kt:15— app-android/src/main/java/org/mtransit/android/ui/inappnotification/locationpermission/LocationPermissionUI.kt:15-22 | app-android/src/main/java/org/mtransit/android/ui/inappnotification/locationsettings/LocationSettingsUI.kt:15-22 | app-android/src/main/java/org/mtransit/android/ui/inappnotification/moduledisabled/ModuleDisabledUI.kt:24-31 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 8 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (7 corresponding lines) · ×1
Edited copy of a member (7 corresponding lines) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1917— app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1917-1923 | app-android/src/main/java/org/mtransit/android/ui/fragment/POIFragment.java:1345-1353 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (32–35 lines × 2) app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt:560— app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt:560-591 | app-android/src/main/java/org/mtransit/android/ui/type/poi/AgencyPOIsFragment.kt:388-422 — before extracting anything, compare `app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt` and `app-android/src/main/java/org/mtransit/android/ui/type/poi/AgencyPOIsFragment.kt` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 67 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (34 lines × 2) app-android/src/main/java/org/mtransit/android/ad/banner/BannerAdListener.kt:55— app-android/src/main/java/org/mtransit/android/ad/banner/BannerAdListener.kt:55-88 | app-android/src/main/java/org/mtransit/android/ad/inlinebanner/InlineBannerAdListener.kt:50-83 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app-android/src/main/java/org/mtransit/android/ad/banner/BannerAdListener.kt:55` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `app-android/src/main/java/org/mtransit/android/ad/banner/BannerAdListener.kt:54` calls `logAdsD` and `app-android/src/main/java/org/mtransit/android/ad/inlinebanner/InlineBannerAdListener.kt:49` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (22 lines × 2) app-android/src/main/java/org/mtransit/android/ui/fares/FaresDialog.kt:79— app-android/src/main/java/org/mtransit/android/ui/fares/FaresDialog.kt:79-100 | app-android/src/main/java/org/mtransit/android/ui/feedback/FeedbackDialog.kt:91-112 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app-android/src/main/java/org/mtransit/android/ui/fares/FaresDialog.kt:79` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `app-android/src/main/java/org/mtransit/android/ui/fares/FaresDialog.kt:101` calls `observe` and `app-android/src/main/java/org/mtransit/android/ui/feedback/FeedbackDialog.kt:113` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (21 lines × 2) app-android/src/main/java/org/mtransit/android/provider/sensor/SensorManagerImpl.kt:84— app-android/src/main/java/org/mtransit/android/provider/sensor/SensorManagerImpl.kt:84-104 | app-android/src/main/java/org/mtransit/android/provider/sensor/SensorManagerImpl.kt:106-126 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (19–20 lines × 2) app-android/src/main/java/org/mtransit/android/ui/news/details/NewsDetailsFragment.kt:306— app-android/src/main/java/org/mtransit/android/ui/news/details/NewsDetailsFragment.kt:306-324 | app-android/src/main/java/org/mtransit/android/ui/news/details/NewsDetailsFragment.kt:352-371 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app-android/src/main/java/org/mtransit/android/ui/news/details/NewsDetailsFragment.kt:306` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (18 lines × 3) app-android/src/main/java/org/mtransit/android/ui/nearby/NearbyFragment.kt:315— app-android/src/main/java/org/mtransit/android/ui/nearby/NearbyFragment.kt:315-332 | app-android/src/main/java/org/mtransit/android/ui/rds/route/RDSRouteFragment.kt:367-384 | app-android/src/main/java/org/mtransit/android/ui/type/AgencyTypeFragment.kt:355-372 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `app-android/src/main/java/org/mtransit/android/ui/nearby/NearbyFragment.kt:315` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `app-android/src/main/java/org/mtransit/android/ui/type/AgencyTypeFragment.kt:351` calls `onViewCreated` and `app-android/src/main/java/org/mtransit/android/ui/nearby/NearbyFragment.kt:311` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (17 lines × 2) app-android/src/main/java/org/mtransit/android/ui/type/rds/RDSAgencyRoutesAdapter.kt:157— app-android/src/main/java/org/mtransit/android/ui/type/rds/RDSAgencyRoutesAdapter.kt:157-173 | app-android/src/main/java/org/mtransit/android/ui/view/poi/POIViewHolderUtils.kt:99-115 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app-android/src/main/java/org/mtransit/android/ui/type/rds/RDSAgencyRoutesAdapter.kt:157` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) app-android/src/main/java/org/mtransit/android/ui/rds/route/RDSRouteFragment.kt:393— app-android/src/main/java/org/mtransit/android/ui/rds/route/RDSRouteFragment.kt:393-407 | app-android/src/main/java/org/mtransit/android/ui/type/AgencyTypeFragment.kt:381-395 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app-android/src/main/java/org/mtransit/android/ui/rds/route/RDSRouteFragment.kt:393` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt:524— app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt:524-537 | app-android/src/main/java/org/mtransit/android/ui/type/poi/AgencyPOIsFragment.kt:373-386 — before extracting anything, compare `app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt` and `app-android/src/main/java/org/mtransit/android/ui/type/poi/AgencyPOIsFragment.kt` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 67 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (10 lines × 4) app-android/src/main/java/org/mtransit/android/ui/fares/FaresDialog.kt:58— app-android/src/main/java/org/mtransit/android/ui/fares/FaresDialog.kt:58-67 | app-android/src/main/java/org/mtransit/android/ui/feedback/FeedbackDialog.kt:70-79 | app-android/src/main/java/org/mtransit/android/ui/pick/PickPOIDialogFragment.kt:155-164 | app-android/src/main/java/org/mtransit/android/ui/serviceupdates/ServiceUpdatesDialog.kt:90-99 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 4 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8 lines × 3) app-android/src/main/java/org/mtransit/android/ui/map/MapFragment.kt:185— app-android/src/main/java/org/mtransit/android/ui/map/MapFragment.kt:185-192 | app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt:593-600 | app-android/src/main/java/org/mtransit/android/ui/type/poi/AgencyPOIsFragment.kt:424-431 — before extracting anything, compare `app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt` and `app-android/src/main/java/org/mtransit/android/ui/type/poi/AgencyPOIsFragment.kt` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 67 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (9 lines × 3) app-android/src/main/java/org/mtransit/android/ui/map/MapViewModel.kt:140— app-android/src/main/java/org/mtransit/android/ui/map/MapViewModel.kt:140-148 | app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsViewModel.kt:293-301 | app-android/src/main/java/org/mtransit/android/ui/type/poi/AgencyPOIsViewModel.kt:137-145 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
Duplicated block (15 lines × 3) app-android/src/main/java/org/mtransit/android/util/FragmentUtils.java:92— app-android/src/main/java/org/mtransit/android/util/FragmentUtils.java:92-106 | app-android/src/main/java/org/mtransit/android/util/FragmentUtils.java:208-222 | app-android/src/main/java/org/mtransit/android/util/FragmentUtils.java:234-248 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app-android/src/main/java/org/mtransit/android/util/FragmentUtils.java:92` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (13–14 lines × 2) app-android/src/main/java/org/mtransit/android/provider/FavoriteProvider.java:100— app-android/src/main/java/org/mtransit/android/provider/FavoriteProvider.java:100-112 | app-android/src/main/java/org/mtransit/android/provider/ModuleProvider.java:201-214 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app-android/src/main/java/org/mtransit/android/provider/FavoriteProvider.java:100` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10–12 lines × 3) app-android/src/main/java/org/mtransit/android/ui/view/MTCompassView.java:92— app-android/src/main/java/org/mtransit/android/ui/view/MTCompassView.java:92-101 | app-android/src/main/java/org/mtransit/android/ui/view/MTJPathsView.java:117-128 | app-android/src/main/java/org/mtransit/android/ui/view/MTPieChartPercentView.java:161-170 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once.
Duplicated block (9 lines × 7) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1505— app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1505-1513 | app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1530-1538 | app-android/src/main/java/org/mtransit/android/data/POIManager.java:507-515 | app-android/src/main/java/org/mtransit/android/data/POIManager.java:692-700 | app-android/src/main/java/org/mtransit/android/data/POIManager.java:793-801 | app-android/src/main/java/org/mtransit/android/data/POIManager.java:820-828 | app-android/src/main/java/org/mtransit/android/data/POIManager.java:854-862 — there are 7 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 7 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1505` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `app-android/src/main/java/org/mtransit/android/data/POIManager.java:691` calls `updateRouteDirectionShowingListInsteadOfMapNow` and `app-android/src/main/java/org/mtransit/android/data/POIManager.java:506` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (8 lines × 6) app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1456— app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1456-1463 | app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1505-1512 | app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1530-1537 | app-android/src/main/java/org/mtransit/android/data/POIManager.java:692-699 | app-android/src/main/java/org/mtransit/android/data/POIManager.java:820-827 | app-android/src/main/java/org/mtransit/android/data/POIManager.java:854-861 — there are 6 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 6 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1456` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 3) app-android/src/main/java/org/mtransit/android/ui/view/POIViewController.java:231— app-android/src/main/java/org/mtransit/android/ui/view/POIViewController.java:231-237 | app-android/src/main/java/org/mtransit/android/ui/view/POIViewController.java:344-350 | app-android/src/main/java/org/mtransit/android/ui/view/POIViewController.java:373-379 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app-android/src/main/java/org/mtransit/android/ui/view/POIViewController.java:231` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `app-android/src/main/java/org/mtransit/android/ui/view/POIViewController.java:238` calls `updateCommonView`, `getContext`, `updateExtra` and `app-android/src/main/java/org/mtransit/android/ui/view/POIViewController.java:380` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (243 lines × 2) app-android/src/main/java/org/mtransit/android/ui/fragment/MTBottomSheetDialogFragmentX.java:34— app-android/src/main/java/org/mtransit/android/ui/fragment/MTBottomSheetDialogFragmentX.java:34-276 | app-android/src/main/java/org/mtransit/android/ui/fragment/MTDialogFragmentX.java:33-275 — before extracting anything, compare `app-android/src/main/java/org/mtransit/android/ui/fragment/MTBottomSheetDialogFragmentX.java` and `app-android/src/main/java/org/mtransit/android/ui/fragment/MTDialogFragmentX.java` as WHOLE FILES: 96% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (10 lines × 6) app-android/src/main/java/org/mtransit/android/ui/view/map/impl/DelegatingGoogleMap.java:373— app-android/src/main/java/org/mtransit/android/ui/view/map/impl/DelegatingGoogleMap.java:373-382 | app-android/src/main/java/org/mtransit/android/ui/view/map/impl/DelegatingGroundOverlay.java:131-140 | app-android/src/main/java/org/mtransit/android/ui/view/map/impl/DelegatingMarker.java:289-298 | app-android/src/main/java/org/mtransit/android/ui/view/map/impl/DelegatingPolygon.java:126-135 | app-android/src/main/java/org/mtransit/android/ui/view/map/impl/DelegatingPolyline.java:106-115 | app-android/src/main/java/org/mtransit/android/ui/view/map/impl/DelegatingTileOverlay.java:77-86 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 6 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Swallowed exception (caught, then discarded) app-android/src/main/java/org/mtransit/android/provider/location/CountryProvider.kt:50— `catch (_: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Duplicated predicate app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java:1966— `holder.getDistanceTv() != null && holder.getDistanceTv().getVisibility() == View.VISIBLE` appears character-identically in 2 files — app-android/src/main/java/org/mtransit/android/data/POIArrayAdapter.java, app-android/src/main/java/org/mtransit/android/ui/view/POIViewController.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate app-android/src/main/java/org/mtransit/android/ui/fragment/POIFragment.java:1062— `this.deviceLocation == null || LocationUtils.isMoreRelevant(getLogTag(), this.deviceLocation, newLocation)` appears character-identically in 2 files — app-android/src/main/java/org/mtransit/android/ui/fragment/POIFragment.java, app-android/src/main/java/org/mtransit/android/ui/view/MapViewController.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate app-android/src/main/java/org/mtransit/android/ui/home/HomeViewModel.kt:414— `!IGNORE_SAME_LOCATION_CHECK && LocationUtils.areAlmostTheSame(currentNearbyLocation, newDeviceLocation, LocationUtils.LOCATION_CHANGED_ALLOW…` appears character-identically in 2 files — app-android/src/main/java/org/mtransit/android/ui/home/HomeViewModel.kt, app-android/src/main/java/org/mtransit/android/ui/nearby/NearbyViewModel.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate app-android/src/main/java/org/mtransit/android/ui/fragment/POIViewModel.kt:95— `!agency.type.isNearbyScreen || agency.type == DataSourceType.TYPE_MODULE` appears character-identically in 2 files — app-android/src/main/java/org/mtransit/android/ui/fragment/POIViewModel.kt, app-android/src/main/java/org/mtransit/android/ui/pick/PickPOIViewModel.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt:562— `!listAdapter.isInitialized || showingListInsteadOfMap == null` appears character-identically in 2 files — app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt, app-android/src/main/java/org/mtransit/android/ui/type/poi/AgencyPOIsFragment.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate app-android/src/main/java/org/mtransit/android/ui/type/poi/AgencyPOIsFragment.kt:224— `adManager.canShowRewardedAd() && binding?.fabFares?.isVisible == false` appears character-identically in 2 files — app-android/src/main/java/org/mtransit/android/ui/type/poi/AgencyPOIsFragment.kt, app-android/src/main/java/org/mtransit/android/ui/type/rds/RDSAgencyRoutesFragment.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt:690— `context.twoPane || showingListInsteadOfMap.value == false` appears character-identically in 2 files — app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt, app-android/src/main/java/org/mtransit/android/ui/type/poi/AgencyPOIsFragment.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt:688— `context.twoPane || showingListInsteadOfMap.value == true` appears character-identically in 2 files — app-android/src/main/java/org/mtransit/android/ui/rds/route/direction/RDSDirectionStopsFragment.kt, app-android/src/main/java/org/mtransit/android/ui/type/poi/AgencyPOIsFragment.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate app-android/src/main/java/org/mtransit/android/ui/nearby/NearbyFragment.kt:316— `lastPageSelected < 0 || pagerAdapter?.isReady() != true` appears character-identically in 3 files — app-android/src/main/java/org/mtransit/android/ui/nearby/NearbyFragment.kt, app-android/src/main/java/org/mtransit/android/ui/rds/route/RDSRouteFragment.kt, app-android/src/main/java/org/mtransit/android/ui/type/AgencyTypeFragment.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate app-android/src/main/java/org/mtransit/android/datasource/DataSourcesInMemoryCache.kt:81— `notExtendedDST == null || extendedDST == null` appears character-identically in 2 files — app-android/src/main/java/org/mtransit/android/datasource/DataSourcesInMemoryCache.kt, app-android/src/main/java/org/mtransit/android/datasource/DataSourcesRepository.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate app-android/src/main/java/org/mtransit/android/ui/type/rds/RDSAgencyRoutesAdapter.kt:155— `routeShortName.isVisible && routeTypeImg.isVisible` appears character-identically in 2 files — app-android/src/main/java/org/mtransit/android/ui/type/rds/RDSAgencyRoutesAdapter.kt, app-android/src/main/java/org/mtransit/android/ui/view/poi/POIViewHolderUtils.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Fat interface: Circle (19 abstract methods) app-android/src/main/java/org/mtransit/android/ui/view/map/Circle.java:6— `Circle` declares 19 abstract methods: `contains`, `getCenter`, `getData`, `getFillColor`, `getId`, `getRadius`, `getStrokeColor`, `getStrokeWidth`, `getZIndex`, `isVisible`, `remove`, `setCenter`, `setData`, `setFillColor`, `setRadius`, `setStrokeColor`, `setStrokeWidth`, `setVisible`, `setZIndex`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: ExtendedGoogleMap (55 abstract methods) app-android/src/main/java/org/mtransit/android/ui/view/map/ExtendedGoogleMap.java:23— `ExtendedGoogleMap` declares 55 abstract methods: `addCircle`, `addGroundOverlay`, `addMarker`, `addPolygon`, `addPolyline`, `addTileOverlay`, `animateCamera`, `animateCamera`, `animateCamera`, `clear`, `getCameraPosition`, `getCircles`, `getDisplayedMarkers`, `getGroundOverlays`, `getMapType`, `getMarkerShowingInfoWindow`, `getMarkers`, `getMaxZoomLevel`, `getMinZoomLevel`, `getMinZoomLevelNotClustered`, `getPolygons`, `getPolylines`, `getProjection`, `getTileOverlays`, `getUiSettings`, `isBuildingsEnabled`, `isIndoorEnabled`, `isMyLocationEnabled`, `isTrafficEnabled`, `moveCamera`, `setBuildingsEnabled`, `setClustering`, `setIndoorEnabled`, `setInfoWindowAdapter`, `setLocationSource`, `setMapStyle`, `setMapType`, `setMyLocationEnabled`, `setOnCameraIdleListener`, `setOnCameraMoveListener`, and 15 more. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 55 declarations carry 52 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 52 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: GroundOverlay (21 abstract methods) app-android/src/main/java/org/mtransit/android/ui/view/map/GroundOverlay.java:8— `GroundOverlay` declares 21 abstract methods: `getBearing`, `getBounds`, `getData`, `getHeight`, `getId`, `getPosition`, `getTransparency`, `getWidth`, `getZIndex`, `isVisible`, `remove`, `setBearing`, `setData`, `setDimensions`, `setDimensions`, `setImage`, `setPosition`, `setPositionFromBounds`, `setTransparency`, `setVisible`, `setZIndex`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 21 declarations carry 20 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 20 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IMarker (40 abstract methods) app-android/src/main/java/org/mtransit/android/ui/view/map/IMarker.java:17— `IMarker` declares 40 abstract methods: `animatePosition`, `animatePosition`, `animatePosition`, `animatePosition`, `getAlpha`, `getClusterGroup`, `getColor`, `getData`, `getDefaultColor`, `getId`, `getMarkers`, `getPosition`, `getRotation`, `getSecondaryColor`, `getSnippet`, `getTitle`, `getZIndex`, `hideInfoWindow`, `isCluster`, `isDraggable`, `isFlat`, `isInfoWindowShown`, `isVisible`, `remove`, `setAlpha`, `setAnchor`, `setClusterGroup`, `setData`, `setDraggable`, `setFlat`, `setIcon`, `setIcon`, `setInfoWindowAnchor`, `setPosition`, `setRotation`, `setSnippet`, `setTitle`, `setVisible`, `setZIndex`, `showInfoWindow`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 40 declarations carry 36 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 36 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: Polygon (20 abstract methods) app-android/src/main/java/org/mtransit/android/ui/view/map/Polygon.java:8— `Polygon` declares 20 abstract methods: `getData`, `getFillColor`, `getHoles`, `getId`, `getPoints`, `getStrokeColor`, `getStrokeWidth`, `getZIndex`, `isGeodesic`, `isVisible`, `remove`, `setData`, `setFillColor`, `setGeodesic`, `setHoles`, `setPoints`, `setStrokeColor`, `setStrokeWidth`, `setVisible`, `setZIndex`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: Polyline (16 abstract methods) app-android/src/main/java/org/mtransit/android/ui/view/map/Polyline.java:8— `Polyline` declares 16 abstract methods: `getColor`, `getData`, `getId`, `getPoints`, `getWidth`, `getZIndex`, `isGeodesic`, `isVisible`, `remove`, `setColor`, `setData`, `setGeodesic`, `setPoints`, `setVisible`, `setWidth`, `setZIndex`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IAdManager (28 abstract methods) app-android/src/main/java/org/mtransit/android/ad/IAdManager.kt:10— `IAdManager` declares 28 abstract methods: `init`, `initForScreens`, `onHasAgenciesEnabledUpdated`, `initHasSubscriptionFromCache`, `canShowAds`, `setHasSubscriptionOrNoError`, `isAppOpenAdAvailable`, `isShowingAppOpenAd`, `loadAppOpenAd`, `showAppOpenAdIfAvailable`, `linkRewardedAd`, `unlinkRewardedAd`, `refreshRewardedAdStatus`, `isRewardedAdAvailableToShow`, `showRewardedAd`, `getBannerHeightInPx`, `adaptToScreenSize`, `onResumeScreen`, `onTimeChanged`, `resumeAd`, `pauseAd`, `destroyAd`, `getRewardedUntil`, `resetRewarded`, `isRewardedNow`, `setRewardedAdListener`, `openAdInspector`, `shouldSkipLoadingRewardedAd`. Counted over its public functions with no body, once per name; default-bodied functions and properties are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: AgencyPropertiesDao (19 abstract methods) app-android/src/main/java/org/mtransit/android/datasource/AgencyPropertiesDao.kt:15— `AgencyPropertiesDao` declares 19 abstract methods: `getAllAgenciesInclNotInstalled`, `getAllAgencies`, `readingAllAgencies`, `readingAllAgenciesBase`, `getAllEnabledAgencies`, `getAllNotInstalledOrNotEnabledAgencies`, `getAllAgenciesCount`, `readingAllAgenciesCount`, `getAllEnabledAgenciesCount`, `getAllNotExtendedDataSourceTypes`, `readingAllNotExtendedDataSourceTypes`, `getAllExtendedDataSourceTypes`, `readingAllExtendedDataSourceTypes`, `getAgency`, `readingAgency`, `readingAgencyBase`, `getAgencyPkg`, `getAgencyColorInt`, `updateAgencySetupRequired`. Counted over its public functions with no body, once per name; default-bodied functions and properties are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
D16 · Bus Factor· Small-team knowledge concentration · ×1
Small-team knowledge concentration — 91 file(s) are concentrated to one author — the ambient state with 2 active author(s), not 91 separate risks. The signal becomes meaningful as ownership spreads; no per-file action implied now.
D21 · Naming Consistency· `endAtInMS` spells `MS` where 45 names in the project spell it `Ms` · ×1
`endAtInMS` spells `MS` where 45 names in the project spell it `Ms` app-android/src/main/java/org/mtransit/android/ui/schedule/ScheduleViewModel.kt:196— 45 of 46 names in project repository spell the token `Ms` (45 of 46; unit: names in project repository containing `Ms`). Peers: BannerAdManager._adBannerLoadedLastInMs (app-android/src/main/java/org/mtransit/android/ad/banner/BannerAdManager.kt:49); BannerAdManager.adBannerLoadedLastInMs (app-android/src/main/java/org/mtransit/android/ad/banner/BannerAdManager.kt:50); BannerAdManager.setAdBannerLoaded(lastInMs) (app-android/src/main/java/org/mtransit/android/ad/banner/BannerAdManager.kt:79); RewardedUserManager._rewardedUntilInMs (app-android/src/main/java/org/mtransit/android/ad/rewarded/RewardedUserManager.kt:61); RewardedUserManager.getRewardedUntilInMs (app-android/src/main/java/org/mtransit/android/ad/rewarded/RewardedUserManager.kt:64). Rename to `endAtInMs`. [rule N6]
D21 · Naming Consistency· `getAbController` spells `Ab` where 40 names in the project spell it `AB` · ×1
`getAbController` spells `Ab` where 40 names in the project spell it `AB` app-android/src/main/java/org/mtransit/android/ui/fragment/ABFragment.java:315— 40 of 41 names in project repository spell the token `AB` (40 of 41; unit: names in project repository containing `AB`). Peers: ActionBarController.getABOrNull (app-android/src/main/java/org/mtransit/android/ui/ActionBarController.java:96); ActionBarController.setAB (app-android/src/main/java/org/mtransit/android/ui/ActionBarController.java:142); ActionBarController.setAB (app-android/src/main/java/org/mtransit/android/ui/ActionBarController.java:162); ActionBarController.setABReady (app-android/src/main/java/org/mtransit/android/ui/ActionBarController.java:195); ActionBarController.setABTitle (app-android/src/main/java/org/mtransit/android/ui/ActionBarController.java:203). Rename to `getABController`. [rule N6]
No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
M2 · Architecture documentation· No architecture diagram/doc · ×1
No architecture diagram/doc — No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.
No SAST REDACTED:5— No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 17 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
P3 · Security & performance tooling· Dependabot does not watch gitsubmodule · ×1
Dependabot does not watch gitsubmodule REDACTED:2— `REDACTED` schedules updates, but no `package-ecosystem` entry covers `gitsubmodule`, which this tree depends on — so those dependencies get no update pull requests and no advisory pressure, however complete the dep-scan credit looks. Add the missing entry to the `updates:` list.
Appendix B — Reproduction & audit trail
Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.
none (no readable dependency manifest): not applicable — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Python pyproject.toml/requirements.txt (pip/uv/Poetry), a Swift Package.swift/Package.resolved, a Cargo manifest, a Go module (go.mod/go.sum), a Gradle version catalogue, a Maven POM, an sbt build (build.sbt), composer.json, package.json, a Dart pubspec.yaml, an Elixir mix.exs/mix.lock (Hex), a rebar.config / erlang.mk DEPS (Hex), a Ruby Gemfile/Gemfile.lock or .gemspec (Bundler/RubyGems) — not scanned yet).
trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 5 file(s) — `app-android/src/main/java/org/mtransit/android/data/NewsImage.kt`, `app-android/src/main/java/org/mtransit/android/data/POIConnectionComparator.kt`, `app-android/src/main/java/org/mtransit/android/datasource/DataSourcesDatabase.kt`, `app-android/src/main/java/org/mtransit/android/ui/fragment/POIFragmentExt.kt`, `app-android/src/main/java/org/mtransit/android/ui/view/MTDotsView.kt` — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.
disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
none (no readable dependency manifest): not applicable — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Python pyproject.toml/requirements.txt (pip/uv/Poetry), a Swift Package.swift/Package.resolved, a Cargo manifest, a Go module (go.mod/go.sum), a Gradle version catalogue, a Maven POM, an sbt build (build.sbt), composer.json, package.json, a Dart pubspec.yaml, an Elixir mix.exs/mix.lock (Hex), a rebar.config / erlang.mk DEPS (Hex), a Ruby Gemfile/Gemfile.lock or .gemspec (Bundler/RubyGems) — not scanned yet).
0
—
Run 01a1e7d9-a384-74d8-a425-286fa276201e · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.
Issues: 147 · Warnings: 443 · Recommendations: 29 — Appendix A · all findings · full markdown report.
Generated by the Canine Code Analyzer: deterministic code-health analysis. 17-11-2026 @ 04:52 UTC.
Downloadable artifacts
Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.