Public report of mobile-dev-inc/Maestro, published 13 November 2026. It has the same score, grades and number of
findings as the full report. The details of security findings (where they are in the code, which known
vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive reportMeasured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.11.3). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey →
Signed and filed in the standard's public register, 13 November 2026, 18:38 UTC · Survey ID cd_4d419cef5e6b45b3a7ca5bcc4fe1bfb9
mobile-dev-inc/Maestro
Measured 13 November 2026, 18:37 UTC, at code version 0ccf5a9
CAI scoreAdequate
CriticalWeakAdequateStrongExemplary
Up 3 since the last survey
The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.
A medium codebase: 38,718 lines of product code in 15 projects, tests not counted · Estimated rebuild effort: about 0.5 person-years · Weakest lens: Production Readiness, 41
Findings by how serious they are
107 critical251 serious432 minor
9 dimensions are left out of the score. For each one, we either couldn't measure it in this code, or found no evidence of the safeguard we look for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.
This survey was produced by
Canine Code Analyzer
Producer
Canine Development
Analyzer
Canine Code Analyzer engine 1.0.0
Measured
13 November 2026, 18:37 UTC
A measurement, not a certificate. The Code Assurance Index records a number
together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee
the code. The standard was written by Canine Development, which also builds the Canine Code Analyzer. It is open to any tool that
implements it, and today the Canine Code Analyzer is the only one that does.
The score is deterministic, which means the same code always gets the same score. We work it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸
67of 67 dimensions measured by tools.
439of 790 findings point to an exact file and line, so you can open each one in the code. The other 351 concern the repository as a whole, such as missing documentation.
67dimensions across 7 lenses, read from 38,718 lines of product code in 15 projects.
mobile-dev-inc/Maestro falls short of our standard for production, in part because we found no automated security scanning of the code, its secrets or its dependencies. It scores 52 out of 100 and is rated Adequate, and 92 of its 107 critical findings are security problems.
Production Readiness, at 41, is the weakest lens and counts most in the score. The best first step is adding automated security scanning, worth about 7 points. Automating the release comes next, worth about 5 points. Raising Production Readiness to 70 would lift the score to about 61.
Seventy-five pipeline tools are referenced by a changeable name, so the build pipeline can be tampered with. Eight pipeline steps put outside input straight into a shell command, so an attacker can run commands in the build pipeline, and thirteen sets of files in separate parts keep changing together, which points to hidden dependencies. Pinning each tool to an exact version, passing outside input through environment variables and making the hidden dependencies explicit would close these risks. Updating the vulnerable packages would fix the four packages with a known security hole, and limiting each secret to its own step would deal with the four secrets exposed to more of the pipeline than needed. The image with no text description needs a text description.
The product code is 38,718 lines, about €71,000 to rebuild.
A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.
How the score is built: what each lens counts forThe lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
If Production Readiness rose from 41 to 70, the lowest score rated Strong, the score would rise from 52 to about 61.
Code composition: what the lines of code are
Product code 52%Tests 48%
New since the last survey: 74 findings
These 74 critical or serious findings weren't in the previous survey, on 24 October 2026.
Code Duplication · Edited copy of a member (21 corresponding lines) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt
Code Duplication · Members sharing a duplicated core (8 members, 50+ identical tokens) maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt
Code Duplication · Edited copy of a member (68 corresponding lines) maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt
Code Duplication · Edited copy of a member (65 corresponding lines) maestro-ai/src/main/java/maestro/ai/anthropic/Client.kt
Code Duplication · Edited copy of a member (28 corresponding lines) maestro-cli/src/main/java/maestro/cli/command/PrintHierarchyCommand.kt
Code Duplication · Edited copy of a member (41 corresponding lines) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt
Code Duplication · Edited copy of a member (28 corresponding lines) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt
Code Duplication · Edited copy of a member (29 corresponding lines) maestro-ai/src/main/java/maestro/ai/cloud/ApiClient.kt
Code Duplication · Edited copy of a member (31 corresponding lines) maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt
Code Duplication · Edited copy of a member (31 corresponding lines) maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlFluentCommand.kt
Code Duplication · Edited copy of a member (17 corresponding lines) maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlSetAirplaneMode.kt
Code Duplication · Edited copy of a member (25 corresponding lines) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt
Code Duplication · Edited copy of a member (24 corresponding lines) maestro-client/src/main/java/maestro/mockserver/MockInteractor.kt
Code Duplication · Edited copy of a member (28 corresponding lines) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt
Code Duplication · Edited copy of a member (25 corresponding lines) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt
Code Duplication · Edited copy of a member (10 corresponding lines) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt
Code Duplication · Edited copy of a member (13 corresponding lines) maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlEvalScript.kt
Code Duplication · Edited copy of a member (20 corresponding lines) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt
Code Duplication · Edited copy of a member (24 corresponding lines) maestro-cli/src/main/java/maestro/cli/command/TestCommand.kt
Code Duplication · Edited copy of a member (13 corresponding lines) maestro-ios-driver/src/main/kotlin/xcuitest/XCTestDriverClient.kt
Code Duplication · Edited copy of a member (16 corresponding lines) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt
Code Duplication · Edited copy of a member (9 corresponding lines) maestro-cli/src/main/java/maestro/cli/graphics/SkiaFrameRenderer.kt
Code Duplication · Edited copy of a member (12 corresponding lines) maestro-orchestra/src/main/java/maestro/orchestra/yaml/MaestroFlowParser.kt
Code Duplication · Edited copies of one member (3 members, 10+ corresponding lines) maestro-cli/src/main/java/maestro/cli/util/EnvUtils.kt
Code Duplication · Edited copy of a member (21 corresponding lines) maestro-ios-driver/src/main/kotlin/util/LocalIOSDeviceController.kt
Code Duplication · Edited copies of one member (3 members, 8+ corresponding lines) maestro-client/src/main/java/maestro/android/AndroidDeviceConnection.kt
Code Duplication · Edited copy of a member (4 corresponding lines) maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlSetAirplaneMode.kt
Code Duplication · Edited copy of a member (11 corresponding lines) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt
Code Duplication · Edited copy of a member (18 corresponding lines) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt
Code Duplication · Edited copy of a member (8 corresponding lines) maestro-orchestra/src/main/java/maestro/orchestra/workspace/DependencyResolver.kt
Code Duplication · Edited copy of a member (4 corresponding lines) maestro-orchestra/src/main/java/maestro/orchestra/workspace/WorkspaceExecutionPlanner.kt
Code Duplication · Edited copy of a member (7 corresponding lines) maestro-orchestra-models/src/main/java/maestro/orchestra/Commands.kt
Code Duplication · Edited copy of a member (9 corresponding lines) maestro-ios-driver/src/main/kotlin/util/AssociatedDomainsRefresher.kt
We compare every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.
Fixed since the last survey: 45 findings
These 45 critical or serious findings were in the previous survey, on 24 October 2026, and are gone from this one.
Secrets (history) · High secret: WD-SECRET-0004 debug.keystore
Rebuild cost: about €71,000 · Estimate
Cost to rebuild
€24,000 to €120,000, for 392 to 1,243 hours of work, about 0.5 person-years for one engineer
Difficulty of the problem
Standard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor
×0.7 at a score of 52. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
Size
Medium: 38,718 lines of product code
What it is not
Not a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.
How the estimate is made: We price the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.
Top priorities
The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.
1
Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
Automate the release in CI — a deploy stage for a service (Helm/Kubernetes manifests or an equivalent rollout), or a tag-triggered publish job for an artifact — so releases are repeatable and reversible.
Set connect and read timeouts on every client (`RestTemplateBuilder.connectTimeout/readTimeout`, WebClient `responseTimeout`, `HttpRequest.Builder.timeout`, `HttpURLConnection.setReadTimeout`, Feign `connectTimeout`/`readTimeout` in configuration), and wrap calls to dependencies in resilience4j `@Retry`/`@CircuitBreaker`/`@TimeLimiter` (or Spring Retry).
Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.
Where the investment is most exposed · Value at risk
This code would cost about €71,000 to build again, about 0.5 person-years of work. Its weakest lens is Production Readiness, at 41 (Weak). Production Readiness is about whether the product is ready to run in production and to change without breaking. Because the weakest lens counts most in the score, work on Production Readiness also moves the score most.
Based on: the rebuild estimate · the Production Readiness grade · how much each lens counts
What to do: Start with the Production Readiness actions in Top priorities.
If you do one thing first · First action
Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing. Of all the actions in this report, it raises the score most for the work it takes: about 7 points for medium effort. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
Architecture — module dependency graph
Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways, which only happens where the projects form a dependency cycle. A graph without cycles has none.
Architecture: which parts of the code depend on which
The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.
270 modules, with 352 dependencies between them. 8 loops run through 29 of the modules, marked above the diagonal.
The table shows the 40 modules with the most connections; 230 more are left out to keep it readable.
Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
maestro.cli.model.TestExecutionSummary uses maestro.cli.model, so a change to maestro.cli.model can break maestro.cli.model.TestExecutionSummary, while a change to maestro.cli.model.TestExecutionSummary can't break maestro.cli.model.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
5→12 maestro.device.Device uses maestro.devicepart of a loop✕
Connections
6 pairs of types, where a type in maestro.device.Device uses a type in maestro.device.
maestro.device.Device uses maestro.device, so a change to maestro.device can break maestro.device.Device, while a change to maestro.device.Device can't break maestro.device.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
6→12 maestro.device.locale uses maestro.devicepart of a loop✕
Connections
4 pairs of types, where a type in maestro.device.locale uses a type in maestro.device.
maestro.device.locale uses maestro.device, so a change to maestro.device can break maestro.device.locale, while a change to maestro.device.locale can't break maestro.device.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
maestro.cli.model uses maestro.cli.model.TestExecutionSummary, so a change to maestro.cli.model.TestExecutionSummary can break maestro.cli.model, while a change to maestro.cli.model can't break maestro.cli.model.TestExecutionSummary.
Position
Below the diagonal: maestro.cli.model uses a module listed above it, which is the healthy direction.
maestro.cli.api.UploadStatus uses maestro.cli.model, so a change to maestro.cli.model can break maestro.cli.api.UploadStatus, while a change to maestro.cli.api.UploadStatus can't break maestro.cli.model.
Position
Below the diagonal: maestro.cli.api.UploadStatus uses a module listed above it, which is the healthy direction.
maestro.cli.report uses maestro.cli.model.TestExecutionSummary, so a change to maestro.cli.model.TestExecutionSummary can break maestro.cli.report, while a change to maestro.cli.report can't break maestro.cli.model.TestExecutionSummary.
Position
Below the diagonal: maestro.cli.report uses a module listed above it, which is the healthy direction.
maestro.cli.report uses maestro.cli.model, so a change to maestro.cli.model can break maestro.cli.report, while a change to maestro.cli.report can't break maestro.cli.model.
Position
Below the diagonal: maestro.cli.report uses a module listed above it, which is the healthy direction.
maestro.device uses maestro.device.Device, so a change to maestro.device.Device can break maestro.device, while a change to maestro.device can't break maestro.device.Device.
Position
Below the diagonal: maestro.device uses a module listed above it, which is the healthy direction.
maestro.device uses maestro.device.locale, so a change to maestro.device.locale can break maestro.device, while a change to maestro.device can't break maestro.device.locale.
Position
Below the diagonal: maestro.device uses a module listed above it, which is the healthy direction.
maestro.device uses maestro.android, so a change to maestro.android can break maestro.device, while a change to maestro.device can't break maestro.android.
Position
Below the diagonal: maestro.device uses a module listed above it, which is the healthy direction.
12→18 maestro.device uses maestro.utilspart of a loop✕
Connections
1 pair of types, where a type in maestro.device uses a type in maestro.utils.
maestro.cli.api uses maestro.cli.api.UploadStatus, so a change to maestro.cli.api.UploadStatus can break maestro.cli.api, while a change to maestro.cli.api can't break maestro.cli.api.UploadStatus.
Position
Below the diagonal: maestro.cli.api uses a module listed above it, which is the healthy direction.
maestro.cli.api uses maestro.device, so a change to maestro.device can break maestro.cli.api, while a change to maestro.cli.api can't break maestro.device.
Position
Below the diagonal: maestro.cli.api uses a module listed above it, which is the healthy direction.
maestro.cli.view.TestSuiteStatusView.TestSuiteViewModel uses maestro.cli.model, so a change to maestro.cli.model can break maestro.cli.view.TestSuiteStatusView.TestSuiteViewModel, while a change to maestro.cli.view.TestSuiteStatusView.TestSuiteViewModel can't break maestro.cli.model.
Position
Below the diagonal: maestro.cli.view.TestSuiteStatusView.TestSuiteViewModel uses a module listed above it, which is the healthy direction.
maestro.cli.view.TestSuiteStatusView.TestSuiteViewModel uses maestro.cli.api.UploadStatus, so a change to maestro.cli.api.UploadStatus can break maestro.cli.view.TestSuiteStatusView.TestSuiteViewModel, while a change to maestro.cli.view.TestSuiteStatusView.TestSuiteViewModel can't break maestro.cli.api.UploadStatus.
Position
Below the diagonal: maestro.cli.view.TestSuiteStatusView.TestSuiteViewModel uses a module listed above it, which is the healthy direction.
maestro.device.DeviceSpec uses maestro.device.locale, so a change to maestro.device.locale can break maestro.device.DeviceSpec, while a change to maestro.device.DeviceSpec can't break maestro.device.locale.
Position
Below the diagonal: maestro.device.DeviceSpec uses a module listed above it, which is the healthy direction.
maestro.device.DeviceSpec uses maestro.device, so a change to maestro.device can break maestro.device.DeviceSpec, while a change to maestro.device.DeviceSpec can't break maestro.device.
Position
Below the diagonal: maestro.device.DeviceSpec uses a module listed above it, which is the healthy direction.
maestro.orchestra.debug uses maestro, so a change to maestro can break maestro.orchestra.debug, while a change to maestro.orchestra.debug can't break maestro.
Position
Below the diagonal: maestro.orchestra.debug uses a module listed above it, which is the healthy direction.
maestro.orchestra.debug uses maestro.device, so a change to maestro.device can break maestro.orchestra.debug, while a change to maestro.orchestra.debug can't break maestro.device.
Position
Below the diagonal: maestro.orchestra.debug uses a module listed above it, which is the healthy direction.
16→25 maestro.orchestra.debug uses maestro.orchestra.Orchestrapart of a loop✕
Connections
2 pairs of types, where a type in maestro.orchestra.debug uses a type in maestro.orchestra.Orchestra.
maestro.orchestra.debug uses maestro.orchestra.Orchestra, so a change to maestro.orchestra.Orchestra can break maestro.orchestra.debug, while a change to maestro.orchestra.debug can't break maestro.orchestra.Orchestra.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
16→27 maestro.orchestra.debug uses maestro.orchestrapart of a loop✕
Connections
12 pairs of types, where a type in maestro.orchestra.debug uses a type in maestro.orchestra.
maestro.orchestra.debug uses maestro.orchestra, so a change to maestro.orchestra can break maestro.orchestra.debug, while a change to maestro.orchestra.debug can't break maestro.orchestra.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
maestro.orchestra.validation uses maestro.device, so a change to maestro.device can break maestro.orchestra.validation, while a change to maestro.orchestra.validation can't break maestro.device.
Position
Below the diagonal: maestro.orchestra.validation uses a module listed above it, which is the healthy direction.
maestro.cli.analytics uses maestro.cli.model, so a change to maestro.cli.model can break maestro.cli.analytics, while a change to maestro.cli.analytics can't break maestro.cli.model.
Position
Below the diagonal: maestro.cli.analytics uses a module listed above it, which is the healthy direction.
maestro.cli.analytics uses maestro.cli.api, so a change to maestro.cli.api can break maestro.cli.analytics, while a change to maestro.cli.analytics can't break maestro.cli.api.
Position
Below the diagonal: maestro.cli.analytics uses a module listed above it, which is the healthy direction.
maestro.cli.cloud uses maestro.cli.model.TestExecutionSummary, so a change to maestro.cli.model.TestExecutionSummary can break maestro.cli.cloud, while a change to maestro.cli.cloud can't break maestro.cli.model.TestExecutionSummary.
Position
Below the diagonal: maestro.cli.cloud uses a module listed above it, which is the healthy direction.
maestro.cli.cloud uses maestro.cli.model, so a change to maestro.cli.model can break maestro.cli.cloud, while a change to maestro.cli.cloud can't break maestro.cli.model.
Position
Below the diagonal: maestro.cli.cloud uses a module listed above it, which is the healthy direction.
maestro.cli.cloud uses maestro.cli.report, so a change to maestro.cli.report can break maestro.cli.cloud, while a change to maestro.cli.cloud can't break maestro.cli.report.
Position
Below the diagonal: maestro.cli.cloud uses a module listed above it, which is the healthy direction.
maestro.cli.cloud uses maestro.cli.api, so a change to maestro.cli.api can break maestro.cli.cloud, while a change to maestro.cli.cloud can't break maestro.cli.api.
Position
Below the diagonal: maestro.cli.cloud uses a module listed above it, which is the healthy direction.
maestro.cli.cloud uses maestro.orchestra.validation, so a change to maestro.orchestra.validation can break maestro.cli.cloud, while a change to maestro.cli.cloud can't break maestro.orchestra.validation.
Position
Below the diagonal: maestro.cli.cloud uses a module listed above it, which is the healthy direction.
maestro.cli.runner.resultview uses maestro.orchestra.debug, so a change to maestro.orchestra.debug can break maestro.cli.runner.resultview, while a change to maestro.cli.runner.resultview can't break maestro.orchestra.debug.
Position
Below the diagonal: maestro.cli.runner.resultview uses a module listed above it, which is the healthy direction.
maestro.cli.runner.resultview uses maestro.utils, so a change to maestro.utils can break maestro.cli.runner.resultview, while a change to maestro.cli.runner.resultview can't break maestro.utils.
Position
Below the diagonal: maestro.cli.runner.resultview uses a module listed above it, which is the healthy direction.
22→37 maestro.cli.runner.resultview uses maestro.cli.runnerpart of a loop✕
Connections
2 pairs of types, where a type in maestro.cli.runner.resultview uses a type in maestro.cli.runner.
maestro.cli.runner.resultview uses maestro.cli.runner, so a change to maestro.cli.runner can break maestro.cli.runner.resultview, while a change to maestro.cli.runner.resultview can't break maestro.cli.runner.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
maestro.cli.util uses maestro.device, so a change to maestro.device can break maestro.cli.util, while a change to maestro.cli.util can't break maestro.device.
Position
Below the diagonal: maestro.cli.util uses a module listed above it, which is the healthy direction.
maestro.cli.util uses maestro.cli.api, so a change to maestro.cli.api can break maestro.cli.util, while a change to maestro.cli.util can't break maestro.cli.api.
Position
Below the diagonal: maestro.cli.util uses a module listed above it, which is the healthy direction.
maestro.cli.view uses maestro.cli.model, so a change to maestro.cli.model can break maestro.cli.view, while a change to maestro.cli.view can't break maestro.cli.model.
Position
Below the diagonal: maestro.cli.view uses a module listed above it, which is the healthy direction.
maestro.cli.view uses maestro.cli.api.UploadStatus, so a change to maestro.cli.api.UploadStatus can break maestro.cli.view, while a change to maestro.cli.view can't break maestro.cli.api.UploadStatus.
Position
Below the diagonal: maestro.cli.view uses a module listed above it, which is the healthy direction.
maestro.cli.view uses maestro.cli.view.TestSuiteStatusView.TestSuiteViewModel, so a change to maestro.cli.view.TestSuiteStatusView.TestSuiteViewModel can break maestro.cli.view, while a change to maestro.cli.view can't break maestro.cli.view.TestSuiteStatusView.TestSuiteViewModel.
Position
Below the diagonal: maestro.cli.view uses a module listed above it, which is the healthy direction.
maestro.orchestra.Orchestra uses maestro.orchestra.debug, so a change to maestro.orchestra.debug can break maestro.orchestra.Orchestra, while a change to maestro.orchestra.Orchestra can't break maestro.orchestra.debug.
Position
Below the diagonal: maestro.orchestra.Orchestra uses a module listed above it, which is the healthy direction.
maestro.orchestra.Orchestra uses maestro.utils, so a change to maestro.utils can break maestro.orchestra.Orchestra, while a change to maestro.orchestra.Orchestra can't break maestro.utils.
Position
Below the diagonal: maestro.orchestra.Orchestra uses a module listed above it, which is the healthy direction.
25→27 maestro.orchestra.Orchestra uses maestro.orchestrapart of a loop✕
Connections
2 pairs of types, where a type in maestro.orchestra.Orchestra uses a type in maestro.orchestra.
maestro.orchestra.Orchestra uses maestro.orchestra, so a change to maestro.orchestra can break maestro.orchestra.Orchestra, while a change to maestro.orchestra.Orchestra can't break maestro.orchestra.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
40 pairs of types, where a type in maestro.drivers uses a type in maestro. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
maestro.drivers uses maestro.android, so a change to maestro.android can break maestro.drivers, while a change to maestro.drivers can't break maestro.android.
Position
Below the diagonal: maestro.drivers uses a module listed above it, which is the healthy direction.
maestro.drivers uses maestro.device, so a change to maestro.device can break maestro.drivers, while a change to maestro.drivers can't break maestro.device.
Position
Below the diagonal: maestro.drivers uses a module listed above it, which is the healthy direction.
maestro.drivers uses maestro.utils, so a change to maestro.utils can break maestro.drivers, while a change to maestro.drivers can't break maestro.utils.
Position
Below the diagonal: maestro.drivers uses a module listed above it, which is the healthy direction.
maestro.orchestra uses maestro.orchestra.WorkspaceConfig, so a change to maestro.orchestra.WorkspaceConfig can break maestro.orchestra, while a change to maestro.orchestra can't break maestro.orchestra.WorkspaceConfig.
Position
Below the diagonal: maestro.orchestra uses a module listed above it, which is the healthy direction.
maestro.orchestra uses maestro.device, so a change to maestro.device can break maestro.orchestra, while a change to maestro.orchestra can't break maestro.device.
Position
Below the diagonal: maestro.orchestra uses a module listed above it, which is the healthy direction.
maestro.orchestra uses maestro.orchestra.debug, so a change to maestro.orchestra.debug can break maestro.orchestra, while a change to maestro.orchestra can't break maestro.orchestra.debug.
Position
Below the diagonal: maestro.orchestra uses a module listed above it, which is the healthy direction.
maestro.orchestra uses maestro.utils, so a change to maestro.utils can break maestro.orchestra, while a change to maestro.orchestra can't break maestro.utils.
Position
Below the diagonal: maestro.orchestra uses a module listed above it, which is the healthy direction.
maestro.orchestra uses maestro.orchestra.Orchestra, so a change to maestro.orchestra.Orchestra can break maestro.orchestra, while a change to maestro.orchestra can't break maestro.orchestra.Orchestra.
Position
Below the diagonal: maestro.orchestra uses a module listed above it, which is the healthy direction.
xcuitest.installer uses maestro.utils, so a change to maestro.utils can break xcuitest.installer, while a change to xcuitest.installer can't break maestro.utils.
Position
Below the diagonal: xcuitest.installer uses a module listed above it, which is the healthy direction.
maestro.cli.mcp.viewer uses maestro, so a change to maestro can break maestro.cli.mcp.viewer, while a change to maestro.cli.mcp.viewer can't break maestro.
Position
Below the diagonal: maestro.cli.mcp.viewer uses a module listed above it, which is the healthy direction.
maestro.cli.mcp.viewer uses maestro.orchestra, so a change to maestro.orchestra can break maestro.cli.mcp.viewer, while a change to maestro.cli.mcp.viewer can't break maestro.orchestra.
Position
Below the diagonal: maestro.cli.mcp.viewer uses a module listed above it, which is the healthy direction.
maestro.orchestra.util uses maestro, so a change to maestro can break maestro.orchestra.util, while a change to maestro.orchestra.util can't break maestro.
Position
Below the diagonal: maestro.orchestra.util uses a module listed above it, which is the healthy direction.
maestro.orchestra.util uses maestro.orchestra, so a change to maestro.orchestra can break maestro.orchestra.util, while a change to maestro.orchestra.util can't break maestro.orchestra.
Position
Below the diagonal: maestro.orchestra.util uses a module listed above it, which is the healthy direction.
maestro.orchestra.workspace.WorkspaceExecutionPlanner uses maestro.orchestra, so a change to maestro.orchestra can break maestro.orchestra.workspace.WorkspaceExecutionPlanner, while a change to maestro.orchestra.workspace.WorkspaceExecutionPlanner can't break maestro.orchestra.
Position
Below the diagonal: maestro.orchestra.workspace.WorkspaceExecutionPlanner uses a module listed above it, which is the healthy direction.
maestro.orchestra.yaml uses maestro, so a change to maestro can break maestro.orchestra.yaml, while a change to maestro.orchestra.yaml can't break maestro.
Position
Below the diagonal: maestro.orchestra.yaml uses a module listed above it, which is the healthy direction.
maestro.orchestra.yaml uses maestro.device, so a change to maestro.device can break maestro.orchestra.yaml, while a change to maestro.orchestra.yaml can't break maestro.device.
Position
Below the diagonal: maestro.orchestra.yaml uses a module listed above it, which is the healthy direction.
maestro.orchestra.yaml uses maestro.utils, so a change to maestro.utils can break maestro.orchestra.yaml, while a change to maestro.orchestra.yaml can't break maestro.utils.
Position
Below the diagonal: maestro.orchestra.yaml uses a module listed above it, which is the healthy direction.
maestro.orchestra.yaml uses maestro.orchestra, so a change to maestro.orchestra can break maestro.orchestra.yaml, while a change to maestro.orchestra.yaml can't break maestro.orchestra.
Position
Below the diagonal: maestro.orchestra.yaml uses a module listed above it, which is the healthy direction.
maestro.cli.command uses maestro.cli.model, so a change to maestro.cli.model can break maestro.cli.command, while a change to maestro.cli.command can't break maestro.cli.model.
Position
Below the diagonal: maestro.cli.command uses a module listed above it, which is the healthy direction.
maestro.cli.command uses maestro.cli.report, so a change to maestro.cli.report can break maestro.cli.command, while a change to maestro.cli.command can't break maestro.cli.report.
Position
Below the diagonal: maestro.cli.command uses a module listed above it, which is the healthy direction.
maestro.cli.command uses maestro.device, so a change to maestro.device can break maestro.cli.command, while a change to maestro.cli.command can't break maestro.device.
Position
Below the diagonal: maestro.cli.command uses a module listed above it, which is the healthy direction.
maestro.cli.command uses maestro.cli.api, so a change to maestro.cli.api can break maestro.cli.command, while a change to maestro.cli.command can't break maestro.cli.api.
Position
Below the diagonal: maestro.cli.command uses a module listed above it, which is the healthy direction.
maestro.cli.command uses maestro.orchestra.workspace.WorkspaceExecutionPlanner, so a change to maestro.orchestra.workspace.WorkspaceExecutionPlanner can break maestro.cli.command, while a change to maestro.cli.command can't break maestro.orchestra.workspace.WorkspaceExecutionPlanner.
Position
Below the diagonal: maestro.cli.command uses a module listed above it, which is the healthy direction.
maestro.cli.mcp uses maestro.device.Device, so a change to maestro.device.Device can break maestro.cli.mcp, while a change to maestro.cli.mcp can't break maestro.device.Device.
Position
Below the diagonal: maestro.cli.mcp uses a module listed above it, which is the healthy direction.
maestro.cli.mcp uses maestro.drivers, so a change to maestro.drivers can break maestro.cli.mcp, while a change to maestro.cli.mcp can't break maestro.drivers.
Position
Below the diagonal: maestro.cli.mcp uses a module listed above it, which is the healthy direction.
maestro.cli.mcp uses maestro.cli.mcp.viewer, so a change to maestro.cli.mcp.viewer can break maestro.cli.mcp, while a change to maestro.cli.mcp can't break maestro.cli.mcp.viewer.
Position
Below the diagonal: maestro.cli.mcp uses a module listed above it, which is the healthy direction.
maestro.cli.runner uses maestro.cli.model.TestExecutionSummary, so a change to maestro.cli.model.TestExecutionSummary can break maestro.cli.runner, while a change to maestro.cli.runner can't break maestro.cli.model.TestExecutionSummary.
Position
Below the diagonal: maestro.cli.runner uses a module listed above it, which is the healthy direction.
maestro.cli.runner uses maestro.cli.model, so a change to maestro.cli.model can break maestro.cli.runner, while a change to maestro.cli.runner can't break maestro.cli.model.
Position
Below the diagonal: maestro.cli.runner uses a module listed above it, which is the healthy direction.
maestro.cli.runner uses maestro.cli.report, so a change to maestro.cli.report can break maestro.cli.runner, while a change to maestro.cli.runner can't break maestro.cli.report.
Position
Below the diagonal: maestro.cli.runner uses a module listed above it, which is the healthy direction.
maestro.cli.runner uses maestro.device, so a change to maestro.device can break maestro.cli.runner, while a change to maestro.cli.runner can't break maestro.device.
Position
Below the diagonal: maestro.cli.runner uses a module listed above it, which is the healthy direction.
maestro.cli.runner uses maestro.orchestra.debug, so a change to maestro.orchestra.debug can break maestro.cli.runner, while a change to maestro.cli.runner can't break maestro.orchestra.debug.
Position
Below the diagonal: maestro.cli.runner uses a module listed above it, which is the healthy direction.
maestro.cli.runner uses maestro.utils, so a change to maestro.utils can break maestro.cli.runner, while a change to maestro.cli.runner can't break maestro.utils.
Position
Below the diagonal: maestro.cli.runner uses a module listed above it, which is the healthy direction.
maestro.cli.runner uses maestro.cli.runner.resultview, so a change to maestro.cli.runner.resultview can break maestro.cli.runner, while a change to maestro.cli.runner can't break maestro.cli.runner.resultview.
Position
Below the diagonal: maestro.cli.runner uses a module listed above it, which is the healthy direction.
maestro.cli.runner uses maestro.orchestra.Orchestra, so a change to maestro.orchestra.Orchestra can break maestro.cli.runner, while a change to maestro.cli.runner can't break maestro.orchestra.Orchestra.
Position
Below the diagonal: maestro.cli.runner uses a module listed above it, which is the healthy direction.
maestro.cli.runner uses maestro.orchestra, so a change to maestro.orchestra can break maestro.cli.runner, while a change to maestro.cli.runner can't break maestro.orchestra.
Position
Below the diagonal: maestro.cli.runner uses a module listed above it, which is the healthy direction.
maestro.cli.runner uses maestro.orchestra.workspace.WorkspaceExecutionPlanner, so a change to maestro.orchestra.workspace.WorkspaceExecutionPlanner can break maestro.cli.runner, while a change to maestro.cli.runner can't break maestro.orchestra.workspace.WorkspaceExecutionPlanner.
Position
Below the diagonal: maestro.cli.runner uses a module listed above it, which is the healthy direction.
maestro.cli.session uses maestro.orchestra.WorkspaceConfig, so a change to maestro.orchestra.WorkspaceConfig can break maestro.cli.session, while a change to maestro.cli.session can't break maestro.orchestra.WorkspaceConfig.
Position
Below the diagonal: maestro.cli.session uses a module listed above it, which is the healthy direction.
maestro.cli.session uses maestro.device.Device, so a change to maestro.device.Device can break maestro.cli.session, while a change to maestro.cli.session can't break maestro.device.Device.
Position
Below the diagonal: maestro.cli.session uses a module listed above it, which is the healthy direction.
maestro.cli.session uses maestro.android, so a change to maestro.android can break maestro.cli.session, while a change to maestro.cli.session can't break maestro.android.
Position
Below the diagonal: maestro.cli.session uses a module listed above it, which is the healthy direction.
maestro.cli.session uses maestro.device, so a change to maestro.device can break maestro.cli.session, while a change to maestro.cli.session can't break maestro.device.
Position
Below the diagonal: maestro.cli.session uses a module listed above it, which is the healthy direction.
maestro.cli.session uses maestro.orchestra.workspace.WorkspaceExecutionPlanner, so a change to maestro.orchestra.workspace.WorkspaceExecutionPlanner can break maestro.cli.session, while a change to maestro.cli.session can't break maestro.orchestra.workspace.WorkspaceExecutionPlanner.
Position
Below the diagonal: maestro.cli.session uses a module listed above it, which is the healthy direction.
maestro.cli.mcp.tools uses maestro, so a change to maestro can break maestro.cli.mcp.tools, while a change to maestro.cli.mcp.tools can't break maestro.
Position
Below the diagonal: maestro.cli.mcp.tools uses a module listed above it, which is the healthy direction.
maestro.cli.mcp.tools uses maestro.cli.api, so a change to maestro.cli.api can break maestro.cli.mcp.tools, while a change to maestro.cli.mcp.tools can't break maestro.cli.api.
Position
Below the diagonal: maestro.cli.mcp.tools uses a module listed above it, which is the healthy direction.
maestro.cli.mcp.tools uses maestro.orchestra, so a change to maestro.orchestra can break maestro.cli.mcp.tools, while a change to maestro.cli.mcp.tools can't break maestro.orchestra.
Position
Below the diagonal: maestro.cli.mcp.tools uses a module listed above it, which is the healthy direction.
maestro.cli.mcp.tools uses maestro.orchestra.workspace.WorkspaceExecutionPlanner, so a change to maestro.orchestra.workspace.WorkspaceExecutionPlanner can break maestro.cli.mcp.tools, while a change to maestro.cli.mcp.tools can't break maestro.orchestra.workspace.WorkspaceExecutionPlanner.
Position
Below the diagonal: maestro.cli.mcp.tools uses a module listed above it, which is the healthy direction.
maestro.cli.mcp.tools uses maestro.cli.mcp, so a change to maestro.cli.mcp can break maestro.cli.mcp.tools, while a change to maestro.cli.mcp.tools can't break maestro.cli.mcp.
Position
Below the diagonal: maestro.cli.mcp.tools uses a module listed above it, which is the healthy direction.
At a glance — Code Health · 63% · Adequate · gated by X4 ·
Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).
OWASP category
Findings
Severity
A05:2025 — Injection
88
High / Critical
A03:2025 — Software Supply Chain Failures
20
High / Critical
Roadmap
Top priorities: Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing; Automate the release in CI — a deploy stage for a service (Helm/Kubernetes manifests or an equivalent rollout), or a tag-triggered publish job for an artifact — so releases are repeatable and reversible; Set connect and read timeouts on every client (`RestTemplateBuilder.connectTimeout/readTimeout`, WebClient `responseTimeout`, `HttpRequest.Builder.timeout`, `HttpURLConnection.setReadTimeout`, Feign `connectTimeout`/`readTimeout` in configuration), and wrap calls to dependencies in resilience4j `@Retry`/`@CircuitBreaker`/`@TimeLimiter` (or Spring Retry).
Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.
Do this
Helps
Effort
Dimension
Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
Automate the release in CI — a deploy stage for a service (Helm/Kubernetes manifests or an equivalent rollout), or a tag-triggered publish job for an artifact — so releases are repeatable and reversible.
Set connect and read timeouts on every client (`RestTemplateBuilder.connectTimeout/readTimeout`, WebClient `responseTimeout`, `HttpRequest.Builder.timeout`, `HttpURLConnection.setReadTimeout`, Feign `connectTimeout`/`readTimeout` in configuration), and wrap calls to dependencies in resilience4j `@Retry`/`@CircuitBreaker`/`@TimeLimiter` (or Spring Retry).
Add a text alternative — alt on images (alt="" for purely decorative ones), a title or aria-label on meaningful svg, an aria-label or inner fallback content on canvas, and a captions <track> on video.
Keep a visible focus style (don't remove the outline without a replacement), guard animation with prefers-reduced-motion, and raise low-contrast colour pairs to at least 4.5:1.
Every finding carries one of four grades. Three say how serious it is. The fourth says this
survey could not settle it — and it is a grade, not a gap.
Critical — 107
A definite problem that already costs you something and drags the score down: a
missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here
tends to cause failures elsewhere.
Serious — 251
Likely wrong, but not failing yet. It degrades
the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to
carry for two years either.
Minor — 432
Recorded, with no effect on how the codebase functions.
Present so the survey is complete, not because it needs doing.
Could not be resolved — 9
Something this survey could not settle
from the outside, and which could be critical or serious. Either a control was required and no
positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves
nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean
result. These are excluded from the score rather than awarded a pass, so the number on the cover neither
rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each
one is named under Limitations.
Methodology & how to trust this report
This survey is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. All 67 evaluated dimensions are computed by tools and static analysis; no language model sets or judges any of them. Overall confidence is 0.9, the weighted average across measured dimensions.
Every figure here is one of two kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10.
What we checked — 67 dimensions across the health lenses
Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.
How to trust any code-health report — three questions
Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 439 of 790 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it: Roslyn, git or a scanner, not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.
This report answers yes to all three. That's the bar to hold any assessment to.
Tools & methods
The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.
Method
Backs
Version
Evaluator
Roslyn static analysis
Complexity, cohesion, coupling, dead code, API surface, layering
What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.
D8 Code Coverage — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT MEASURED: the Swift half could not be measured — the Swift suite in maestro-ios-xctest-runner/MaestroDriverLib produced no coverage export. Coverage is excluded from the score rather than counted as a near-zero. This is OUR limitation, not a defect in the repo.
D11 Test Reliability — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test source is present (.kt, .swift, .dart) and this repository declares a JVM test suite (repository root, Gradle), but it was not re-run: no test result was produced. Not scored — this is a gap in the analyzer's language coverage, not a finding about this repository.
D12 Dependency Hygiene — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Currency was graded against Maven Central, but whether an artifact is DEPRECATED is not: Maven Central publishes no deprecation marker, exactly as rubygems.org does not. Whether one is UNMAINTAINED is not graded either — no registry publishes a maintenance status, and release age does not stand in for one. Two of this dimension's four signals are therefore unread on a Gradle tree, and its score reflects currency alone.
D19 Documentation Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Each ecosystem's manifests (what makes a folder runnable or a published package) need their own proof before D19 judges its units. Until then those folders' READMEs are judged only as documents (boilerplate, structure), never counted as complete.
D19 Documentation Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This kind did not reach the 95 % precision gate in three adjudicated runs (docs/plans/deterministic-engine/adjudication/D19-sample3-v3.md), so by the pre-registered fallback it publishes no row until a re-measurement shows it does. The candidates are counted here, not reported as findings, and the score does not include them.
D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. D21's naming rules read C# through Roslyn and every other language through its sidecar model; these languages are left out (PHP's reading is its own change, a Roslyn-loaded VB or F# project has no population builder yet). Their declarations carry no naming verdict this run — this says nothing about whether their names are consistent.
D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
D22 Internal API Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D22's deterministic call-shape rules are gated on C# first (docs/plans/deterministic-engine.md, P5): each other language is switched on only after its own concept suite and A/B gate pass. This says nothing about whether that surface is consistent.
D24 Comment Value — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Each source language's comment syntax, and the code a comment annotates in it, needs its own proof before D24 judges it. Until then those comments are left unread, not counted as clean.
D32 Data Compliance (PII/GDPR) — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `maestro-cli/src/main/java/maestro/cli/mcp/tools/RunOnCloudTool.kt`, `maestro-client/src/main/java/maestro/ViewHierarchy.kt`, `REDACTED`, `maestro-client/src/main/java/maestro/drivers/WebDriver.kt`, `maestro-ios-driver/src/main/kotlin/util/AssociatedDomainsRefresher.kt`, … (+3 more) produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
AXB2 Runtime readiness — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `npm run` found no package.json in the folder where our sandbox ran it. This is a limit of our sandbox, not of your repository. (rule: no-root-manifest). The renderer reported: the dev server (`npm run dev`) exited before it served a page. Likely cause (our sandbox): `npm run` found no package.json in the folder where our sandbox ran it. This is a limit of our sandbox, not of your repository. Last output: "npm error code ENOENT / npm error syscall open / npm error path <repo>/package.json / npm error errno -2 / npm error enoent Could not read package.json: Error: ENOENT: no such file or directory, open '<repo>/package.json' / npm error enoent This is related to npm not being able to find a file. / npm error enoent / npm error A complete log of this run can be found in: <path>" No runtime evidence was gathered.
AXR1 Runtime accessibility — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Boot via AndroidApp (maestro-android). the Android app did not build — `./gradlew :maestro-android:assembleDebug` exited 1: FAILURE: Build failed with an exception.
* What went wrong:
Could not determine the dependencies of task ':maestro-android:compileDebugJavaWithJavac'.
> Failed to find target with hash string 'androi…; runtime evidence skipped (launch chosen because maestro-android/build.gradle.kts applies the Android application plugin and gradlew builds it).
C2 Access Controls — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These authorization controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks authorization controls.
GD1 Unfinished & placeholder code — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, F#, JavaScript/TypeScript, Dart, Ruby and Scala source only, and this repository's Kotlin, Swift, c, objectivec is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
IC1 Incompleteness & stubs — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, JavaScript/TypeScript, Java, Dart, Ruby and Scala source only, and this repository's Kotlin, Swift, c, objectivec is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
M4 Documentation accuracy — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. M4 checks only the claim kinds adjudicated at or above 95 % precision: links and versions (PREREGISTRATION version 9), and artefact counts an order of magnitude off. Paths, command arguments, installs, environment variables, settings, projects, packages, routes, cd targets, infrastructure products and removed modules are read but not checked, and none of them is reported or counted.
P5 DR & Backup — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. No backup/snapshot/replication config, RTO/RPO or restore-procedure documentation was found — and no production persistence was detected either (no data-access packages, no data-store services, no database resources), so there is nothing in this repository whose loss a DR control would recover. If this system's data lives in a platform or ops repo we can't see, that's where the DR evidence belongs.
X4 Structured logging — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 140 further occurrence(s) are not listed individually; the score already reflects all 180.
Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.
Limitations & what we did not check
We assess the repository exactly as committed, and only the repository. By design we do not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.
Per-dimension blind spots
For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.
D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
D12 Dependency Hygiene: Dependency health reads manifests and lockfiles — a vulnerability in a vendored/copied dependency, or risk from how a dependency is actually used, is outside this view.
D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
D19 Documentation Quality: Documentation quality publishes two things only: a runnable or packaged unit with no example, and a multi-project root README that maps none of its parts. It does not judge clarity, and its other checks (overview, licence, boilerplate, structure, empty sections, XML-doc coverage) are withheld after adjudication: their candidates are counted in the card's gaps, not shown as rows. A false statement in a document is M4's; units are .NET projects only.
D20 ADR Quality: ADR quality checks the structure of the decision records present: it cannot know about decisions made and never recorded, and it does not judge how well a record argues its case. Records in a language the section lexicon does not cover are not evaluated.
D21 Naming Consistency: Naming consistency compares each name with the convention its structural peers follow in this repository: it cannot tell whether a consistently used name is a good one, and languages other than C# and TypeScript are not measured.
D24 Comment Value: Comment value is measured as redundancy only: a comment that repeats its code's words is found, but a paraphrase in other words, a vague comment, or one the code contradicts is not, and whether a comment is valuable is not claimed. Comments in other scripts or languages, and outside C#, are not judged.
D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
AC1 Text alternatives: Alt-text is detected structurally — the scan sees that an alternative EXISTS, not whether it meaningfully describes the image, and decorative-vs-missing is judged by attribute shape; runtime-injected images and a non-role=img decorative svg are out of scope. This is accessibility readiness, never a WCAG conformance claim.
AC2 Forms & labels: Label association is read from static markup — a label wired up at runtime (JS-set aria-labelledby, framework-injected ids) reads as missing, a present label says nothing about whether its text is correct. A known UI-library field component (e.g. a JSX <TextField>) is now checked conservatively — flagged only when it carries NO label/aria-label/aria-labelledby/id/name — but wrapper/context-labelled libraries (Chakra/Radix FormControl+FormLabel) aren't statically visible (possible false positive) and non-JSX lowercased components are still skipped. A click handler on a plain element is now asked for a name too (it is a control the author declared), but the subtree test that answers it is deliberately generous: any DYNAMIC text expression in the subtree counts as a name, so an icon chosen by a ternary ({cond ? <IconA/> : <IconB/>}) reads as named, and a glyph component from a library the icon-import list does not know still names its parent. A clean result is "no unlabelled control found", not a labelling proof.
AC3 Page structure: Page structure is read from the static markup tree — landmarks, headings and lang injected at runtime aren't seen, heading ORDER is checked structurally (not against the rendered visual hierarchy), and lang/title/main fire only on full documents, never partials, and the data-table check sees header-cell presence (a <th> exists), not whether each header correctly associates with its cells. Static readiness, not conformance.
AC5 ARIA correctness: ARIA correctness is checked against the static role/attribute shape — roles/attributes set dynamically aren't seen, a valid role says nothing about whether it matches the element's real behaviour, and required-state checks are suppressed when a JSX spread could supply them. The two-branch toggle check (a control whose state is conveyed only by which of two mutually exclusive branches renders) reads CONDITIONALS THAT ARE ATTRIBUTES — Vue v-if/v-else/v-show and Alpine x-if/x-show — so the same toggle written as a Svelte {#if} block or a JSX ternary is control flow the markup model never projects as a branch and is not seen at all.
AC6 Visual & motion safety: Contrast and motion safety are PARTIAL by construction — literal colours (hex/rgb/hsl/named) in inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS top-level declarations are read (same-rule/same-element colour+background pairs only); computed/runtime/theme colour, external-CDN stylesheets, CSS-in-JS dynamic (${…}) and nested-selector colours, cross-element pairs and image contrast stay out of reach, so a clean result is bounded by what the static CSS itself shows.
AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
AX9 CQS / query purity: Handlers are found by interface/name convention — a query handler using neither is not seen. Mutation is a resolved write/publish invocation (SaveChanges/repository/bus), so a write hidden behind a hand-rolled wrapper, reflection, or a string-keyed service locator resolves to a non-persistence type and isn't flagged; it detects that a query writes state, not whether the write is a legitimate read-side cache update. Clean means "no resolved write/publish in a query body", not a proof of CQS purity.
M4 Documentation accuracy: Documentation accuracy checks links, versions and artefact counts against the tree: other claims (paths, commands, settings, routes) are read but not checked, and it cannot run the onboarding or measure how long a real new joiner takes.
P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.
What it measures: How tangled the control flow is — methods with many branches are hard to test and change.
Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.
8 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was maestro-web.traverse at 29. A further 5 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being YamlFluentCommand._toCommands at 65 — they are counted neither in the figure above nor in this dimension's score. 4 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlFluentCommand.kt (YamlFluentCommand._toCommands at 65), maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt (Orchestra.executeCommand at 51), maestro-orchestra-models/src/main/java/maestro/orchestra/MaestroCommand.kt (MaestroCommand.asCommand at 50), maestro-cli/src/main/java/maestro/cli/view/TestSuiteStatusView.kt (TestSuiteStatusView.printStatus at 19). They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.
+ 2 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 7 bodies over 15 down to 15 or less in Cyclomatic Complexity — start with maestro-web.traverse (cyclomatic 29), ApiClient.upload (cyclomatic 23), CloudInteractor.upload (cyclomatic 22). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 7 together lifts Cyclomatic Complexity from 8.7 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.
Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How hard the code is for a person to follow, beyond raw branching.
Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.
+ 17 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 22 bodies over 15 down to 15 or less in Cognitive Complexity — start with AndroidDriver.mapHierarchy (cognitive 34), ApiClient.upload (cognitive 33), LogcatReader.findJvmCrashes (cognitive 31). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 22 together lifts Cognitive Complexity from 7.2 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.
Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D3 · God Classes7.3 / 10Strong✓ Tool-verified
What it measures: Over-large classes that try to do too much ("god classes").
Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.
Resolve the 13 FileTooLong finding(s) in God Classes — start with Orchestra.kt, REDACTED, Commands.kt. — One of this dimension's main actionable groups (13 warning-level).
Resolve the 11 TooManyMethods finding(s) in God Classes — start with REDACTED, Orchestra.kt, CdpWebDriver.kt. — One of this dimension's main actionable groups (11 warning-level).
Resolve the 11 ClassTooLong finding(s) in God Classes — start with REDACTED, YamlFluentCommand.kt, ApiClient.kt. — One of this dimension's main actionable groups (11 warning-level).
Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Copy-pasted code that should be shared instead.
Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.
42 duplicated block group(s) detected. A further 34 rows report members as variants of one another; they aggregate block groups already counted above and are not themselves counted.
+ 47 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 4 Duplicated block (9 lines × 2) finding(s) in Code Duplication — start with ListCloudDevicesCommand.kt, Orchestra.kt, CdpWebDriver.kt. — One of this dimension's main actionable groups (4 warning-level).
Resolve the 3 Edited copy of a member (21 corresponding lines) finding(s) in Code Duplication — start with Maestro.kt, CdpWebDriver.kt, LocalIOSDeviceController.kt. — One of this dimension's main actionable groups (3 warning-level).
Resolve the 3 Edited copy of a member (28 corresponding lines) finding(s) in Code Duplication — start with CdpWebDriver.kt (2), PrintHierarchyCommand.kt. — One of this dimension's main actionable groups (3 warning-level).
Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D5 · Coupling8.4 / 10Strong✓ Tool-verified
What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.
Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.
Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.
15 production modules (Gradle+npm+SwiftPM), 0 dependency cycle(s), 0 unstable depended-on module(s). Read from the build's own module declarations; edges a convention plugin adds from buildSrc or build-logic are not visible there; 3 module(s) off the main sequence, with abstractness counted on 13 of the 15 (the rest declare no modelled class or interface, export only macros, declare types in source no model reads, or have no source directory of their own).
Off the main sequence: maestro:maestro-ai · ×3
What to do
Resolve the 3 Off the main sequence finding(s) in Coupling. — One of this dimension's main actionable groups (3 warning-level).
Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether a class's methods are focused on a single responsibility.
Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.
Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.
Resolve the 2 Low cohesion finding(s) in Cohesion (LCOM4) — start with LocalSimulatorUtils.kt, XCRunnerCLIUtils.kt. — One of this dimension's main actionable groups (2 warning-level).
Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether dependencies are current, not deprecated, and not bloated. Known vulnerabilities are D30's.
Method: Manifest scan via dotnet list package across all projects; worst-signal-per-package deduction (capped-linear for deprecation, prerelease and outdated) per KLoC. Known-vulnerable packages are D30's and are not charged here (rubric-2026.11.2). Exhaustive.
This repository's Gradle dependency graph was RESOLVED BY A BUILD, across every subproject rather than the root alone: 451 artifact(s) resolved, 393 of them gradable against Maven Central, and 335 behind a shipped release. Where a version was requested and a different one won conflict resolution, the RESOLVED version is what is graded — grading the request would recommend an upgrade already applied. Known CVEs in the same graph are a separate question again, reported under D30.
What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.
Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.
What it measures: Whether the licenses of third-party packages are compatible with your policy.
Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.
0 of 84 declared JVM dependency artifact(s) use a banned license. Licences were resolved from the POMs Maven Central publishes, over the coordinates this repository's 16 Maven/Gradle manifest(s) declare with a version resolvable from the manifest itself — the same declaration-site closure this analysis reads for dependency currency. The JVM has no lockfile a checkout is guaranteed to carry, so this is deliberately NOT the transitive closure. A further 4 coordinate(s) are not published to Maven Central — another repository (Google's Maven hosts androidx), a SNAPSHOT, or a private artifact — so their licences are not readable from here and they are outside this verdict.
What it measures: Files that change often and are also complex — the riskiest hotspots.
Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.
Top hotspots: maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt (5×23=115); maestro-cli/src/main/java/maestro/cli/cloud/CloudInteractor.kt (4×22=88) Repeated repair below the complexity floor: maestro-orchestra/src/main/kotlin/maestro/orchestra/debug/ArtifactsGenerator.kt (3 of 4 changes were fixes)
Resolve the 2 Hotspot finding(s) in Churn × Complexity Hotspots — start with ApiClient.kt, CloudInteractor.kt. — One of this dimension's main actionable groups (2 warning-level).
Resolve the 1 Repeated repair finding(s) in Churn × Complexity Hotspots — start with ArtifactsGenerator.kt. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D16 · Bus Factor8.9 / 10Strong✓ Tool-verified
What it measures: Whether knowledge is concentrated in too few people (the "bus factor").
Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.
17 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is maestro-cli/mcp-viewer/src/main.tsx. Counted over 157 of the 403 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
Off-boarding risk: anonymized user #1 · ×2
Further sole-owners (lower concentration)
What to do
Resolve the 2 Off-boarding risk finding(s) in Bus Factor. — One of this dimension's main actionable groups (2 recommendation-level).
Resolve the 1 Further sole-owners (lower concentration) finding(s) in Bus Factor. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.
Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.
19 deducted task-comment markers across 38718 LoC (0.0/KLoC) → score 9.9. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.
Resolve the 16 TodoComment finding(s) in Explicit Debt — start with XCTestIOSDevice.kt (4), MaestroFlowParser.kt (2), TestSuiteInteractor.kt (2). — One of this dimension's main actionable groups (16 warning-level).
Resolve the 3 FixmeComment finding(s) in Explicit Debt — start with LocalXCTestInstaller.kt, TestSuiteInteractor.kt, HtmlAITestSuiteReporter.kt. — One of this dimension's main actionable groups (3 warning-level).
Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the project's documentation is clear, complete, and useful.
Method: Every README, docs/ document and root guide parsed by its markup and measured in Unicode letters. Published: a runnable or packaged .NET project whose README (or a document it links, or a root guide) shows no example, and a root README naming none of three or more projects. Overview, licence, boilerplate, wall-of-text, empty-section and XML-doc rows are measured and withheld (counted in gaps) after adjudication. Deterministic, exhaustive, advisory.
1 of 1 documentation facets pass in full. 11 document(s) read across 2 unit(s).
✓ On the Gold path — maintain.
Detailed fixes: d19_recommendation.md.
Do you agree with this assessment?
D20 · ADR Quality0.0 / 10Critical✓ Tool-verified
What it measures: Whether architecture decisions are recorded well (context, decision, consequences).
Method: Every ADR read by its section structure: nine located rules (a missing Decision, Context or Consequences section, a stale status, two records deciding the same question, a dangling supersede link, a number-only title, a single option, no named cost, no status where the log uses one, no enforcement field where the log adopted one), each a fixed deduction from 10; the score is the mean over evaluated records. Deterministic, no model. Advisory.
No ADRs foundmaestro-ios-xctest-runner/maestro-driver-ios.xcodeproj/project.pbxproj:1
What to do
Resolve the 1 No ADRs found finding(s) in ADR Quality — start with project.pbxproj. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d20_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether names — types, methods, variables — are clear and consistent.
Method: Seven vocabulary-free rules (N1-N7) mine each naming convention from the repository and flag a name that breaks a convention its structural peers in the same unit follow; production C# and TypeScript, each its own population. Deterministic, no model, no sample. Advisory.
2 naming inconsistencies among 93 declarations measured against a convention their peers follow.
`windowContextID` spells `ID` where 92 names in the project spell it `Id`maestro-ios-driver/src/main/kotlin/hierarchy/AXElement.kt:28
`displayID` spells `ID` where 92 names in the project spell it `Id`maestro-ios-driver/src/main/kotlin/hierarchy/AXElement.kt:31
What to do
Resolve the 1 `windowContextID` spells `ID` where 92 names in the project spell it… finding(s) in Naming Consistency — start with AXElement.kt. — One of this dimension's main actionable groups (1 recommendation-level).
Resolve the 1 `displayID` spells `ID` where 92 names in the project spell it `Id` finding(s) in Naming Consistency — start with AXElement.kt. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d21_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether comments are worth it — explaining WHY (valuable) rather than WHAT (redundant).
Method: Every inline C# comment compared word by word with the identifiers, literals and constructs of the code it annotates (taken from the syntax); a comment whose words that code already contains is redundant, as are closing-brace labels and generator template text. Comments giving a reason or a reference are kept; other scripts and languages are not judged. Deterministic, exhaustive, advisory.
3 of 13 build units (Gradle, SwiftPM, Xcode, npm) flagged as possibly oversized/incoherent.
Projects may be oversized for their cohesion
What to do
Resolve the 1 Projects may be oversized for their cohesion finding(s) in Project Cohesion. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.
Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps. C# also names each pass-through layer (a class whose every public method only forwards its own parameters to one collaborator) as a located finding; the score is not affected.
Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.
57 % of calls cross a namespace and 1 % go through an interface, but 99 % of collaborators are co-located — so a call's collaborators sit together and tracing stays easy. Baseline: small — navigation cost is tolerated.
What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.
Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.
What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.
Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.
Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).
88 finding(s): 0 critical, 88 high, 0 medium, 0 low. 71 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. semgrep hit a parse error in 6 file(s) — `e2e/list_workspaces` (line 11), `e2e/run_tests` (line 151), `e2e/validate_workspaces` (line 54), `gradlew` (line 74, line 180), `REDACTED` (line 137, line 222), … (+1 more) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. Separately, one or more rules could not re-parse an embedded snippet in 3 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.
REDACTED
REDACTED
REDACTED
REDACTED
What to do
Resolve the 8 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (4), REDACTED (2), REDACTED (2). — One of this dimension's main actionable groups (8 issue-level).
Resolve the 4 REDACTED finding(s) charged to Static Analysis (SAST) — the other 71 are reported here at file:line but scored by D36 (supply-chain provenance), which charges them once. — One of this dimension's main actionable groups (75 issue-level, 4 of them charged here).
Resolve the 4 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (4 issue-level).
Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.
Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05. Advisory since rubric-2026.11.2 (CAI decision 0006): every row is a match against a vulnerability database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.
Resolve the 4 High CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (4). — One of this dimension's main actionable groups (4 issue-level).
Detailed fixes: d30_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.
Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.
24 of 157 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is maestro-client/src/main/java/maestro/utils/LocaleUtils.kt. Counted over 157 of the 403 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
Resolve the 24 Orphaned file finding(s) in Knowledge Freshness — start with Client.kt (2), LocaleUtils.kt, DescribeCloudRunTool.kt. — One of this dimension's main actionable groups (24 recommendation-level).
Resolve the 1 Orphaned files with no living knowledge finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.
Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.
Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.
Resolve the 13 Boundary-crossing change coupling finding(s) in Change Coupling — start with Filters.kt (3), SimctlIOSDevice.kt (2), Driver.kt (2). — One of this dimension's main actionable groups (13 issue-level).
Resolve the 3 Change coupling finding(s) in Change Coupling — start with CommandLineUtils.kt, RecordCommand.kt, PrintHierarchyCommand.kt. — One of this dimension's main actionable groups (3 warning-level).
Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.
Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.
+ 2 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 7 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (7 warning-level).
Resolve the 3 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (3 warning-level).
Resolve the 2 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED, REDACTED. — One of this dimension's main actionable groups (2 warning-level).
Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Reported apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.
Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. Advisory since rubric-2026.11.2 (CAI decision 0006): the malicious-package feed is a database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.
What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.
Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.
0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 15 platform declaration(s) and 88 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.
✓ On the Gold path — maintain.
Detailed fixes: d44_recommendation.md.
Do you agree with this assessment?
Frontend & cross-cutting dimensions
R = React/JS · M = Maturity · P = Readiness.
AC1 · Text alternatives2.7 / 10Weak✓ Tool-verified
Other · Accessibility — Whether non-text content carries a text alternative — img/area/input[type=image] have alt, a meaningful svg has a title or aria-label, video has a captions track, and object/embed/canvas have a name or fallback content. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: every img/area/input[type=image] checked for alt, svg[role=img] for a title/aria-label, video for a captions <track>. Components skipped, spreads suppressed. Deterministic, hard fact per element.
Coverage: Population: image/media elements — img, area, input[type=image], svg, video, object, embed, canvas — across the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and dynamic-attribute elements are skipped. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is NOT read by any producer, so it contributes no element to this population; where such a frontend is present the card discloses it as an analyzer gap rather than scoring around it.
A <canvas> with no aria-label/title and no inner fallback content can't be described by assistive tech. Add a name or fallback content. — maestro-cli/mcp-viewer/src/main.tsx:509
An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative. — maestro-cli/mcp-viewer/src/main.tsx:802
What to do
Add a text alternative — alt on images (alt="" for purely decorative ones), a title or aria-label on meaningful svg, an aria-label or inner fallback content on canvas, and a captions <track> on video.
Do you agree with this assessment?
AC2 · Forms & labels10.0 / 10Exemplary○ Nothing flagged
Other · Accessibility — Whether form controls have a programmatic label (an associated label, aria-label or aria-labelledby), buttons have text, links have an accessible name, a click handler on a plain element names the control it declares, fieldsets have a non-empty legend, known UI-library field components carry a label prop, and a placeholder isn't used as the only label. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: inputs/selects/textareas checked for an associated label[for]/wrapping label/aria-label/aria-labelledby (per document), buttons for accessible text, fieldsets for a legend; placeholder-only labelling flagged. Deterministic, hard fact per control.
Coverage: Population: form controls, buttons, links, fieldsets and known UI-library field components in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and spread/dynamic-attribute elements are skipped, so a control whose label arrives through a spread or a runtime expression is deliberately not judged. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
Do you agree with this assessment?
AC3 · Page structure4.8 / 10Weak✓ Tool-verified
Other · Accessibility — Whether pages declare a language (well-formed BCP-47) and a non-empty title, expose exactly one main landmark and a sane heading order with non-empty headings, keep zoom enabled, title their iframes, give data tables header cells, and avoid meta-refresh. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: html lang, document <title>, a main landmark and heading order on full documents only, plus zoom-disabling viewports, untitled iframes and meta-refresh anywhere. Deterministic, per structural checkpoint.
Coverage: Population: the PARSED MARKUP documents (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx). The page-level checks — lang, title, single main landmark — fire ONCE PER FULL DOCUMENT (an <html> root) and never on a partial or component fragment, so a repo of fragments is assessed only on the per-element checks (heading order, table headers, iframe titles, meta-refresh, zoom). Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en"). — maestro-cli/src/main/java/maestro/cli/report/HtmlTestSuiteReporter.kt:50
No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>. — maestro-cli/src/main/java/maestro/cli/report/HtmlTestSuiteReporter.kt:50
Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one. (×4) — maestro-cli/src/main/java/maestro/cli/report/HtmlTestSuiteReporter.kt:78, maestro-cli/src/main/java/maestro/cli/report/HtmlTestSuiteReporter.kt:84, maestro-cli/src/main/java/maestro/cli/report/HtmlTestSuiteReporter.kt:90, …
What to do
Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh.
Other · Accessibility — Whether ARIA is used correctly — valid non-abstract roles, the ARIA state a role requires, valid (non-misspelled) aria-* attribute names, in-enum values for token-typed aria-* attributes, and no aria-hidden on (or wrapping) a focusable element. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: role values checked against the WAI-ARIA role set (abstract/invalid flagged), required ARIA state for a role, and aria-hidden on a focusable element. Deterministic, role/attribute level.
Coverage: Population: elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx) that carry a role or an aria-* attribute; roles and token values are checked against the ARIA enums exhaustively within that set. An expression-valued (dynamic) role or aria-* value is skipped rather than guessed, and markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
Other · Accessibility — Whether focus outlines aren't removed without a replacement, motion respects prefers-reduced-motion, and literal CSS colour pairs meet contrast — PARTIAL: inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS literals are read (hex/rgb/hsl/named), never computed/runtime/external-CDN colour. Static markup readiness, not a WCAG conformance claim.
Method: Static markup/CSS scan: inline outline:none/0, literal inline colour/background contrast against the 4.5:1 AA floor, and <style>-block animation without a prefers-reduced-motion guard. Deterministic but PARTIAL — only inline styles and in-repo CSS literals are visible.
Coverage: Population: styled elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx), plus in-repo <style> blocks, in-repo .css files and CSS-in-JS literals. Colour contrast is computed from LITERAL colour pairs only (hex/rgb/hsl/named, including var() tokens and Tailwind neutral utilities) — computed, runtime-themed and external-CDN colour is never resolved, so this is a partial read of contrast by construction. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
<svg> moves — its `animate-spin` utility runs with no motion-safe:/motion-reduce: variant — and nothing reads prefers-reduced-motion for it, so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Gate it on @media (prefers-reduced-motion: no-preference) or motion-safe:. — maestro-cli/mcp-viewer/src/main.tsx:130
What to do
Keep a visible focus style (don't remove the outline without a replacement), guard animation with prefers-reduced-motion, and raise low-contrast colour pairs to at least 4.5:1.
Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.
Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.
Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.
Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).
Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.
Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.
Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.
Do you agree with this assessment?
AX8 · Test isolation10.0 / 10Exemplary✓ Tool-verified
Other · Architecture — Whether production projects stay free of references to test projects — tests may depend on production, never the reverse.
Method: Csproj graph: each production project checked for references to test projects (identified by test-framework presence, not name). Zero violations is clean. Deterministic.
Other · Architecture — Whether read (query) handlers stay side-effect-free — a query that writes persistent state or raises events breaks CQS and makes reads unsafe to retry, cache, or route to a read replica.
Method: Roslyn scan: CQRS handlers classified query-vs-command by interface (IQueryHandler/ICommandHandler/IRequestHandler<TQuery,TResult>) and name convention (*Query/Get*/Find* vs *Command); each query handler's body checked for persistent-state writes (SaveChanges/repository Add-Update) or event publishes by resolved invocation. Deterministic, type-level, exhaustive over the detected handlers.
Coverage: Population: CQRS handlers identified by IQueryHandler/ICommandHandler/IRequestHandler interface + *Query/Get*/Find*/*Command NAME convention; query purity then checked exhaustively within that set — a query handler using neither convention is invisible, and mutation is a resolved persistence/publish CALL, not full dataflow.
Maturity · Maturity — Whether the repository and its projects have a README, and whether it is substantive.
Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.
Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.
Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.
No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
What to do
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Maturity · Maturity — Whether the repository is organised deliberately: production code and tests are set apart in a way its ecosystem or the repository itself declares.
Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.
Maturity · Maturity — Whether the project's current-state documentation describes the code that exists.
Method: Every current-state document's checkable claims looked up in the tree (links, versions, and artefact counts an order of magnitude off), plus two README checks: an advertised infrastructure product with no footprint, and a module the CHANGELOG records as removed. Deterministic, no model. Advisory.
Readiness · Readiness — Whether an automated pipeline builds and tests every change.
Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.
Do you agree with this assessment?
P10 · Library API & versioning10.0 / 10Exemplary○ Nothing flagged
Readiness · Readiness — For a library: a deliberate (small) public API surface and explicit semantic versioning so consumers can depend on it safely.
Method: Roslyn scan: public API surface area and semantic-versioning markers (SemVer attributes, changelog entries) for libraries; off .NET, a library is the ecosystem's publication act (an npm package that is not private and names an entry point, a PyPI distribution with a build system, a Rust library crate, a Maven/Gradle module that publishes, a Go module with no package main, a gemspec, a Composer library, a SwiftPM library product, a pub.dev or Hex package), its surface is the share of types the language's code model records as public (Rust, Swift, Java, Kotlin, Go, Dart; not measured where the model records no type visibility or, as in TypeScript, only module-level export), and its version is read from the manifest, a semver CHANGELOG, release tooling or semver git tags. Exhaustive, deterministic.
Do you agree with this assessment?
P2 · Observability8.6 / 10Strong✓ Tool-verified
Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.
Only 7/8 runnable modules use logging (modules with no entry point or server are excluded — they are libraries a runnable module hosts). Silent: `maestro-ios-xctest-runner`.
What to do
Extend structured logging to the remaining runnable modules so everything you run is diagnosable in production.
Add a health-check endpoint (Spring Boot Actuator's /actuator/health, or a /health route) so orchestrators and load balancers can probe liveness/readiness.
Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).
Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.
No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 14 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner. — REDACTED:34
`maestro-cli/mcp-viewer/package.json` declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices — including after an advisory is published against it. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per ecosystem the tree uses (or an enabled `renovate.json`), and gate pull requests with `actions/dependency-review-action`. — maestro-cli/mcp-viewer/package.json:12
What to do
Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
Enable Dependabot/Renovate or a dependency-review gate.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.
Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.
No release automation was found in CI — neither a deploy stage (Helm/Kubernetes/compose manifests, an orchestrated rollout) nor a publish job that ships the built artifact. Releases appear to be run by hand, which is slower, less repeatable and harder to reverse.
What to do
Automate the release in CI — a deploy stage for a service (Helm/Kubernetes manifests or an equivalent rollout), or a tag-triggered publish job for an artifact — so releases are repeatable and reversible.
Readiness · Readiness — Whether outbound HTTP calls are wrapped in resilience (retry/timeout/circuit-breaker) so a failing dependency doesn't cascade.
Method: Source scan: outbound HTTP clients and what bounds them — resilience handlers (Polly, AddStandardResilienceHandler) on .NET; on Go, the JVM, Python, JavaScript/TypeScript, Ruby, PHP, Rust, Elixir, Swift, Dart and Erlang, a timeout, deadline, retry or breaker beside each call, or a process-wide client default (a framework-wide deadline such as Drupal core's, Laravel's or actix's awc counts). Exhaustive, deterministic.
`HttpClient(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout. (×2) — maestro-cli/src/main/java/maestro/cli/util/FileDownloader.kt:22, maestro-web/src/main/kotlin/maestro/web/cdp/CdpClient.kt:49
What to do
Set connect and read timeouts on every client (`RestTemplateBuilder.connectTimeout/readTimeout`, WebClient `responseTimeout`, `HttpRequest.Builder.timeout`, `HttpURLConnection.setReadTimeout`, Feign `connectTimeout`/`readTimeout` in configuration), and wrap calls to dependencies in resilience4j `@Retry`/`@CircuitBreaker`/`@TimeLimiter` (or Spring Retry).
Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.
Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from each language's code model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.
`startScreenRecording` is async and calls Thread.sleep — a blocking call inside async code stalls the coroutine's thread, and every coroutine dispatched to it for as long as it runs. — maestro-client/src/main/java/maestro/Maestro.kt:685
`waitIfPaused` is async and calls Thread.sleep — a blocking call inside async code stalls the coroutine's thread, and every coroutine dispatched to it for as long as it runs. — maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:108
What to do
Kotlin: call the suspend function directly instead of wrapping it in runBlocking, use delay() instead of Thread.sleep, and move unavoidable blocking I/O into withContext(Dispatchers.IO).
Other · Security — Only what this repository's own non-C# files could be read for was assessed — markup this repository SHIPS is scored for third-party script integrity whether or not the repository serves it itself, since a page handed to a consumer runs in that consumer’s origin. Nothing else in this dimension was assessed: the transport, cookie, input-validation and crypto controls are read from a source model that was not loaded for this repository’s language, so their absence here is not a finding about this repository.
Method: Roslyn plus filesystem scan: HSTS/security headers, secure cookies, input validation, middleware order, weak crypto (MD5/SHA1/DES); HTTPS-metadata context-aware. On a repository with no .NET source it reads JavaScript/TypeScript, Dart, Ruby, Scala, Rust or Elixir source itself (test, vendored, generated and minified paths not) for the arms that hold whether or not the code serves HTTP: a weak hash or cipher, key material fixed in the source, a TLS client that accepts any certificate, and (JavaScript/TypeScript, Ruby, Scala, Rust and Elixir) an obsolete TLS version; the server controls are not assessed there, and a Dart, Ruby, Scala, Rust or Elixir repository that serves no HTTP of its own is N/A on them. Deterministic.
`https://cdn.tailwindcss.com/3.4.5` is executed by this page with no Subresource Integrity. Whoever can answer that request — the CDN, anyone who compromises it, anyone on the network path — runs arbitrary script in this page's origin, with its session. 2 such include(s) across the repository's markup. — maestro-cli/src/main/java/maestro/cli/report/HtmlAITestSuiteReporter.kt:71
What to do
Pin third-party scripts and verify them: name an exact version in the URL and add an `integrity="sha384-…"` hash alongside `crossorigin="anonymous"` (both are required — an integrity hash on a cross-origin script without `crossorigin` is not evaluated, it blocks the script). Where the vendor ships a continuously-updated loader and publishes no stable hash (tag managers, analytics, chat widgets), Subresource Integrity is not available: constrain it instead with a `Content-Security-Policy` that names the exact origins allowed to execute, and drop the script from the pages that do not need it. Where the page is shipped inside a package that others host, prefer vendoring the asset and serving it from the app’s own origin, so no consumer inherits a third-party dependency they did not choose.
Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.
Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.
This coroutine runs on a dispatcher's thread, and `Thread.sleep` blocks that thread: for the whole delay no other coroutine scheduled on it makes progress (on `Dispatchers.Main` the UI freezes) — the Kotlin form of blocking on a task. Use `delay(…)`, which suspends only this coroutine. Where the blocking work is not a sleep but a call that cannot be made suspending, move it off the dispatcher with `withContext(Dispatchers.IO) { … }`. (×7) — maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:113, maestro-ios-driver/src/main/kotlin/util/LocalSimulatorUtils.kt:225, maestro-ios-driver/src/main/kotlin/util/LocalSimulatorUtils.kt:235, …
Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.
Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X13 · Undrained process stream4.7 / 10Weak✓ Tool-verified
Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.
Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.
The JDK pipes both `stdout` and `stderr` of a child started this way — no `redirectErrorStream`, `redirectError`, `redirectOutput` or `inheritIO` is set — and here `process.inputStream` (stdout) is read while the child's end is awaited, but nothing in this scope ever reads `process.errorStream` (stderr). The JDK's own `Process` documentation warns that failing to read a child's output promptly "may cause the process to block, or even deadlock": once the child writes more than the pipe holds to stderr (measured on OpenJDK 25 / Linux: 60,000 bytes finishes, 70,000 hangs forever), it blocks on the write, never exits, and the `waitFor` or end of stream this code waits on never comes. Nothing fails loudly: the thread hangs and the stuck child holds its resources until something kills it. Read both streams (a coroutine or thread per stream), merge them with `redirectErrorStream(true)` before `start()`, or discard the unwanted one with `redirectError(ProcessBuilder.Redirect.DISCARD)` (or `redirectOutput`). (×6) — maestro-ios-driver/src/main/kotlin/util/LocalSimulatorUtils.kt:59, maestro-ios-driver/src/main/kotlin/util/LocalSimulatorUtils.kt:216, maestro-ios-driver/src/main/kotlin/util/LocalSimulatorUtils.kt:360, …
The JDK pipes both `stdout` and `stderr` of a child started this way — no `redirectErrorStream`, `redirectError`, `redirectOutput` or `inheritIO` is set — and here `p1.inputStream` (stdout) is read while the child's end is awaited, but nothing in this scope ever reads `p1.errorStream` (stderr). The JDK's own `Process` documentation warns that failing to read a child's output promptly "may cause the process to block, or even deadlock": once the child writes more than the pipe holds to stderr (measured on OpenJDK 25 / Linux: 60,000 bytes finishes, 70,000 hangs forever), it blocks on the write, never exits, and the `waitFor` or end of stream this code waits on never comes. Nothing fails loudly: the thread hangs and the stuck child holds its resources until something kills it. Read both streams (a coroutine or thread per stream), merge them with `redirectErrorStream(true)` before `start()`, or discard the unwanted one with `redirectError(ProcessBuilder.Redirect.DISCARD)` (or `redirectOutput`). (×2) — maestro-client/src/main/java/maestro/device/util/EnvUtils.kt:16, maestro-cli/src/main/java/maestro/cli/util/EnvUtils.kt:49
The JDK pipes both `stdout` and `stderr` of a child started this way — no `redirectErrorStream`, `redirectError`, `redirectOutput` or `inheritIO` is set — and here `p2.inputStream` (stdout) is read while the child's end is awaited, but nothing in this scope ever reads `p2.errorStream` (stderr). The JDK's own `Process` documentation warns that failing to read a child's output promptly "may cause the process to block, or even deadlock": once the child writes more than the pipe holds to stderr (measured on OpenJDK 25 / Linux: 60,000 bytes finishes, 70,000 hangs forever), it blocks on the write, never exits, and the `waitFor` or end of stream this code waits on never comes. Nothing fails loudly: the thread hangs and the stuck child holds its resources until something kills it. Read both streams (a coroutine or thread per stream), merge them with `redirectErrorStream(true)` before `start()`, or discard the unwanted one with `redirectError(ProcessBuilder.Redirect.DISCARD)` (or `redirectOutput`). (×2) — maestro-client/src/main/java/maestro/device/util/EnvUtils.kt:22, maestro-cli/src/main/java/maestro/cli/util/EnvUtils.kt:55
What to do
Each finding names the span that makes the branch dead and the span it is dead because of. Confirm from the two, then delete the dead arm or fix the predicate that was meant to be reachable.
Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.
Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X17 · Uncapped recursion over a caller-supplied document2.7 / 10Weak✓ Tool-verified
Other · Security — Whether a walk that recurses through a JSON/XML tree handed in by its caller bounds how deep it will go — an uncapped walk lets the document's nesting choose the stack depth, and the resulting StackOverflowException cannot be caught.
Method: Roslyn syntax + semantics: methods that take a JSON/XML document node and call themselves with a child of it, reachable from an externally-callable member of the same type that accepts a document, checked for any depth parameter, descent counter or threaded arithmetic anywhere in the walk. On a repository with no .NET source it reads TypeScript off the engine’s own token stream (test, vendored, generated and minified paths and `.d.ts` not) with the same rule: a function or method with a parameter typed as a document value — `unknown`, `any`, `object`, `Record<string, unknown|any>`, a JSON alias (`JsonValue`, `JSONObject`, …) or a DOM node global the file does not rebind — that calls itself (bare, or through `this` for a method, or hands itself to a call over the value as in `value.map(walk)`) with something it took out of that value and never through an ancestor accessor such as `closest()` or `parentElement`, that is exported or reached from an exported function (a public method of the same exported class) taking such a value, and that names no depth, level, nesting, recursion, remaining or budget anywhere and threads no `+`/`-` arithmetic through a self-call. Plain JavaScript is not read: with no annotation nothing tells a parsed document from a tree the code built itself. Deterministic, provable per finding. Advisory.
`parseDomAsTreeNodes` is public and takes `domRepresentation: Map<String, Any>` from its caller, and it calls itself at line 400 with a piece of `domRepresentation` — the function is not `tailrec`, so every call is a real frame — and nowhere in `parseDomAsTreeNodes` is there a depth parameter, a descent counter, or any other cap. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. On the JVM's default 1 MB thread stack a recursive walk throws `StackOverflowError` from about 500–2,000 levels on a cold first call and 6,000–17,000 once warmed up (OpenJDK 21 and 25; Android's threads are smaller). kotlinx.serialization's `parseToJsonElement` accepts nested arrays to any depth and Android's built-in `org.json` sets no limit, while Jackson 2.15+ stops at 1,000 — on a cold JVM past the point the walk fails; Gson 2.12+ and Moshi stop at 255. `StackOverflowError` is an `Error`, not an `Exception`: a `catch (e: Exception)` around the call does not stop it, and on Android an uncaught one ends the process. Thread a depth argument through `parseDomAsTreeNodes` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack or a `DeepRecursiveFunction`. — maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:400
`parseDomAsTreeNodes` is public and takes `domRepresentation: Map<String, Any>` from its caller, and it calls itself at line 284 with a piece of `domRepresentation` — the function is not `tailrec`, so every call is a real frame — and nowhere in `parseDomAsTreeNodes` is there a depth parameter, a descent counter, or any other cap. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. On the JVM's default 1 MB thread stack a recursive walk throws `StackOverflowError` from about 500–2,000 levels on a cold first call and 6,000–17,000 once warmed up (OpenJDK 21 and 25; Android's threads are smaller). kotlinx.serialization's `parseToJsonElement` accepts nested arrays to any depth and Android's built-in `org.json` sets no limit, while Jackson 2.15+ stops at 1,000 — on a cold JVM past the point the walk fails; Gson 2.12+ and Moshi stop at 255. `StackOverflowError` is an `Error`, not an `Exception`: a `catch (e: Exception)` around the call does not stop it, and on Android an uncaught one ends the process. Thread a depth argument through `parseDomAsTreeNodes` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack or a `DeepRecursiveFunction`. — maestro-client/src/main/java/maestro/drivers/WebDriver.kt:284
What to do
Each finding names the externally-callable member that accepts the document and the self-call that descends, and states that no depth parameter or counter exists anywhere in the walk. Confirm from the two, then thread a depth argument through the walk and reject documents past a fixed maximum, or rewrite it with an explicit stack.
Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.
Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.
`Files.walk(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and its only use reads `.anyMatch` through it and drops it, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `Files.walk(…).use { r -> … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`. — maestro-orchestra/src/main/java/maestro/orchestra/workspace/YamlCommandsPathValidator.kt:21
`Files.walk(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and its only use reads `.forEach` through it and drops it, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `Files.walk(…).use { r -> … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`. — maestro-ios-driver/src/main/kotlin/util/LocalSimulatorUtils.kt:242
What to do
Each finding names the value and the span that decides who owns it — the `new` that created it, or the constructor parameter that handed it over. Confirm ownership from that span, then make the disposal match it: release what this type created, leave what it was injected with to whoever created THAT, and drop a finalizer whose type holds nothing unmanaged to release.
Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.
Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether functions that make a cancellable request accept or pass on an AbortSignal or the coroutine's cancellation (adoption curve).
Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.
Only 5/7 functions that make a cancellable request (fetch, axios, ky, ofetch, got, undici, node:http; Ktor, OkHttp newCall, URL streams) accept an AbortSignal or the coroutine's cancellation or pass one on, so a request keeps running after whatever wanted it has given up — a page navigated away from, a cancelled request, a shutdown, an expired deadline. Take a `signal` () and hand it to the request; in a Kotlin suspend function, make the request with a call that suspends — Ktor, OkHttp's `executeAsync()`, or a `suspendCancellableCoroutine` that cancels the `Call` — not a blocking `execute()`: `withContext(Dispatchers.IO)` moves the call off the caller's thread but does not make it cancellable; where nothing could ever cancel the call, omitting it is a deliberate choice — judge against how the function is used.
`startOnlyConnectedDevice` awaits `fetch(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `fetch(url, { signal })`. — maestro-cli/mcp-viewer/src/main.tsx:882
`startDeviceStream` awaits `fetch(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `fetch(url, { signal })`. — maestro-cli/mcp-viewer/src/main.tsx:900
What to do
Thread an AbortSignal or the coroutine's cancellation through functions that make requests, so the work stops when its caller gives up.
Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.
Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.
Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.
Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value handed from a callback to the body that waits on it crosses on something built to be crossed — a `Queue<T>`/`List<T>`/`Dictionary<K,V>` written inside an event handler and read back outside it is mutated by two flows at once, and the semaphore or completion source beside it orders how MANY items exist while leaving the collection's own head, tail and backing array unprotected.
Method: Roslyn syntax: method, accessor, local-function and lambda bodies that declare BOTH a non-thread-safe generic collection (`Queue`/`Stack`/`List`/`Dictionary`/`HashSet`/`Sorted*`/`LinkedList`) and a synchronisation primitive (`SemaphoreSlim`/`TaskCompletionSource`/`ManualResetEvent(Slim)`/`AutoResetEvent`/`CountdownEvent`) as locals, then read for a `+=`-registered lambda that raises that primitive while the body outside every lambda waits on it — and, in that scope, a mutating call on the collection inside the lambda paired with a mention of it outside. Any `lock` in the scope abstains it. On a repository with no .NET source the same handoff is read in Java off the engine’s own token stream (test source sets, vendored and demonstration paths not): an `ArrayList`/`LinkedList`/`ArrayDeque`/`PriorityQueue`/`Hash*`/`LinkedHash*`/`Tree*` local and a `CountDownLatch`/`Semaphore`/`CompletableFuture` local, a lambda or anonymous class that raises the primitive and mutates the collection, and a wait outside it; any `synchronized` or `lock()` abstains the body. Because each of those primitives orders what the callback wrote before raising it, only a touch that provably overlaps the callback is convicted: one after the registration and before the next wait, or one in a loop registered-before, waiting on every pass and not declaring the collection. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a `for (x in c)` or `c.forEach { … }` leaves the collection it is walking alone — a `mutableListOf`/`ArrayList`, `mutableMapOf`/`HashMap` or `mutableSetOf`/`HashSet` is a `java.util` collection on the JVM and is walked by its own fail-fast iterator, so a body that adds to or removes from the very collection the loop is walking makes the next step throw `ConcurrentModificationException` and the remaining elements are never seen.
Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.
Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.
Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.
An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. (×6) — maestro-utils/src/main/kotlin/SocketUtils.kt:36, maestro-utils/src/main/kotlin/TempFileHandler.kt:30, maestro-orchestra/src/main/java/maestro/orchestra/workspace/DependencyResolver.kt:46, …
`catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×12) — maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlCommandReader.kt:88, maestro-orchestra/src/main/java/maestro/orchestra/workspace/Filters.kt:26, maestro-ios-driver/src/main/kotlin/xcuitest/crash/IOSCrashFileFinder.kt:65, …
`catch (_: Throwable)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. — maestro-client/src/main/java/maestro/android/AndroidDeviceConnection.kt:486
`catch (ignored: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. — maestro-cli/src/main/java/maestro/cli/util/FileUtils.kt:16
`catch (_: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×2) — maestro-cli/src/main/java/maestro/cli/util/SocketUtils.kt:33, maestro-cli/src/main/java/maestro/cli/session/MaestroSessionManager.kt:277
`.catch(() => {})` handles the rejection by doing nothing — the failure is discarded with no log and no rethrow, and the chain carries on as if the work succeeded. Log it through whatever this codebase already uses to report problems, hand it to a caller that can (`next(error)`, a returned rejection), or don't catch it. — maestro-cli/mcp-viewer/src/main.tsx:546
What to do
Swallowed exception (empty catch)
Do you agree with this assessment?
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.
Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.
Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `package.json` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.
`warn` at line 90 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-orchestra/src/main/kotlin/maestro/orchestra/debug/ArtifactsGenerator.kt:90
`warn` at line 224 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-orchestra/src/main/kotlin/maestro/orchestra/debug/ArtifactsGenerator.kt:224
`warn` at line 246 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-orchestra/src/main/kotlin/maestro/orchestra/debug/ArtifactsGenerator.kt:246
`warn` at line 271 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-orchestra/src/main/kotlin/maestro/orchestra/debug/ArtifactsGenerator.kt:271
`warn` at line 322 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-orchestra/src/main/kotlin/maestro/orchestra/debug/ArtifactsGenerator.kt:322
`warn` at line 329 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-orchestra/src/main/kotlin/maestro/orchestra/debug/ArtifactsGenerator.kt:329
`error` at line 64 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-orchestra/src/main/kotlin/maestro/orchestra/debug/TestOutputWriter.kt:64
`warn` at line 223 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:223
`warn` at line 289 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:289
`info` at line 353 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:353
`info` at line 385 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:385
`info` at line 391 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:391
`error` at line 400 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:400
`info` at line 870 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:870
`info` at line 871 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:871
`info` at line 872 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:872
`info` at line 873 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:873
`info` at line 874 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:874
`warn` at line 885 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:885
`error` at line 1007 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:1007
`error` at line 1013 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:1013
`error` at line 1060 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:1060
`info` at line 1188 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:1188
`info` at line 1195 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:1195
`info` at line 179 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-orchestra/src/main/java/maestro/orchestra/workspace/WorkspaceExecutionPlanner.kt:179
`error` at line 75 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-ios-driver/src/main/kotlin/xcuitest/XCTestDriverClient.kt:75
`warn` at line 311 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-ios-driver/src/main/kotlin/xcuitest/XCTestDriverClient.kt:311
`error` at line 319 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-ios-driver/src/main/kotlin/xcuitest/XCTestDriverClient.kt:319
`error` at line 323 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-ios-driver/src/main/kotlin/xcuitest/XCTestDriverClient.kt:323
`error` at line 330 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-ios-driver/src/main/kotlin/xcuitest/XCTestDriverClient.kt:330
`error` at line 336 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-ios-driver/src/main/kotlin/xcuitest/XCTestDriverClient.kt:336
`error` at line 342 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-ios-driver/src/main/kotlin/xcuitest/XCTestDriverClient.kt:342
`error` at line 348 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-ios-driver/src/main/kotlin/xcuitest/XCTestDriverClient.kt:348
`error` at line 354 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-ios-driver/src/main/kotlin/xcuitest/XCTestDriverClient.kt:354
`trace` at line 98 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.trace("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-ios-driver/src/main/kotlin/xcuitest/installer/LocalXCTestInstaller.kt:98
`info` at line 121 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-ios-driver/src/main/kotlin/xcuitest/installer/LocalXCTestInstaller.kt:121
`info` at line 123 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-ios-driver/src/main/kotlin/xcuitest/installer/LocalXCTestInstaller.kt:123
`info` at line 152 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-ios-driver/src/main/kotlin/xcuitest/installer/LocalXCTestInstaller.kt:152
`error` at line 154 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-ios-driver/src/main/kotlin/xcuitest/installer/LocalXCTestInstaller.kt:154
`info` at line 156 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text. — maestro-ios-driver/src/main/kotlin/xcuitest/installer/LocalXCTestInstaller.kt:156
Other · Code Health — Whether Kotlin's null safety is not undermined by not-null assertions — `String` cannot hold null and `String?` must be checked before use in every Kotlin module, and each `!!` is a run-time `NullPointerException` the author has told the compiler cannot happen.
Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.
Do you agree with this assessment?
WCAG coverage — what static analysis assessed
Statically assessed 13 of 55 WCAG 2.2 Level A/AA success criteria (24%; ≈26% of the 50 WCAG 2.1 AA criteria for EN 301 549). The other 42 require runtime or manual evaluation. Partial signal only (a clean result is necessary, not sufficient; static analysis fully verifies none). This is accessibility readiness, not a conformance claim — a WCAG conformance claim requires manual evaluation (WCAG-EM 1.0).
The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.
Unscored — 2 check(s) recorded observations but carry no score
These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.
X10 Duplicated predicate — 12 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
X7 Silent fallback defaults — 5 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 1 control(s) we could not find positive evidence for
These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.
P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 49 check(s) not relevant to this codebase
These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.
AC4 Keyboard semantics — No interactive element found in the parsed markup — AC4 not applicable here.
AX1 Captive dependencies — Not applicable: this repository's JavaScript imports no dependency-injection container and defines no container of its own — nothing that both registers and resolves bindings, and nothing that names two lifetimes — so nothing holds one lifetime's instance while handing out another's; this repository's Kotlin imports no dependency-injection container and defines no container of its own — nothing that both registers and resolves bindings, and nothing that names two lifetimes — so nothing holds one lifetime's instance while handing out another's; this repository's Swift imports no dependency-injection container and defines no container of its own — nothing that both registers and resolves bindings, and nothing that names two lifetimes — so nothing holds one lifetime's instance while handing out another's; this repository's TypeScript imports no dependency-injection container and defines no container of its own — nothing that both registers and resolves bindings, and nothing that names two lifetimes — so nothing holds one lifetime's instance while handing out another's.
AX2 Stateful singletons — No container singleton was found, so there is no shared instance for concurrent requests to race on. No class in this Kotlin code is a Spring, JSR-330 or CDI singleton bean. No Swift request handler (a Vapor, Hummingbird, Kitura, Swifter or Perfect route handler, as a method or a registered closure) is declared, so no state is shared between request threads. Dart isolates share no mutable memory, so no two requests write one object at the same instant. TypeScript/JavaScript runs each process's requests on one event loop, so no two requests write a shared object at the same instant (interleaving across an await is a different defect).
AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
AX6 Interface segregation — no exported interface declares behaviour
AX7 Slice cohesion — not applicable — not a vertical-slice architecture
AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
AXR1 Runtime accessibility — the Android app did not build — `./gradlew :maestro-android:assembleDebug` exited 1: FAILURE: Build failed with an exception.
* What went wrong:
Could not determine the dependencies of task ':maestro-android:compileDebugJavaWithJavac'.
> Failed to find target with hash string 'androi…; runtime evidence skipped (launch chosen because maestro-android/build.gradle.kts applies the Android application plugin and gradlew builds it) This is a statement about this run, not a statement about your application: nothing here says the app is inaccessible, only that it was never run.
C1 Data Protection — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no data at rest for these controls to protect.
C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
C3 Audit Trail — No personal data detected in a persisted data model — no PII-named column (email, first_name, date_of_birth, phone_number, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no sensitive data whose changes an audit trail would record. If it does (through a store configured outside this repository, for instance), the trail belongs to wherever that data is stored.
C4 Data Retention — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no personal data whose lifetime a retention limit would bound.
C5 Data-Subject Rights — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no personal data for a data subject to erase, export or consent over.
D10 Test Quality — ~35100 lines of test source are present (.kt, .swift, .dart) but no test cases reached the test census for this repository — no test root we could resolve declared them, or the files we read declare no cases in a test framework we recognise — so skipped/assertion-free tests couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
D11 Test Reliability — Test reliability not included — the .kt suite was found but not re-run
D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
D22 Internal API Consistency — API consistency is measured on C# only; the exposed Swift surface was not measured.
D23 Boundary Type-Coupling — No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ sibling projects each declaring an entity of their own or taking another project's integration events. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
D25 ADR Conformance — no ADRs to check
D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
D32 Data Compliance (PII/GDPR) — 8 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
D8 Code Coverage — Coverage not measured — Swift suite
DM1 Domain Modelling — applicable but not scored (2 of 3 signals for this style — below the bar we score at): 241 value object(s); 12 domain event(s); its domain events are published by services or handlers — no domain entity raises one
ED2 Event/command shape — not scored — deciding whether a command has more than one competing handler requires resolving the call graph, and this analysis resolves a call's owner only where the receiver's type is written down in the source. Reported as guidance rather than measured
ED2 Event/command shape — not scored — deciding whether a command has more than one competing handler requires resolving the call graph, which this analysis does not build from source alone for this language. Reported as guidance rather than measured
ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
GD1 Unfinished & placeholder code — no source files were read — this check reads C#, F#, JavaScript/TypeScript, Dart, Ruby and Scala, and none was read for this repository's product. That is a limit of the analyzer, not a finding about your code.
IC1 Incompleteness & stubs — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, and the automatic-re-run check to any GitHub-Actions workflow, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
P8 Schema migrations — no ORM, schema-migration tool or schema auto-create was found in this repository's dependency manifests or source, so there is no database schema for this check to judge
P9 Domain vs controller coverage — coverage not measured: this check compares the coverage of the analyzer's own test run across the domain and web layers, and that run measured none here — Test coverage (D8) says why
PF1 Benchmark discipline — Not applicable: no benchmark suite was found. This check searched for `@Benchmark` in a Java, Kotlin or Scala file importing JMH or kotlinx-benchmark, Jetpack Benchmark's `measureRepeated` in a file importing androidx.benchmark, or JMH/kotlinx-benchmark/androidx.benchmark in a pom.xml, Gradle or sbt build, and for a `*benchmark*` script that this repository's CI runs. Benchmarks are credited as a bonus, so their absence is neither scored nor deducted.
PF2 Allocation hygiene — Not scored: this check counted allocation-aware idioms (Span, pools, stackalloc) per line, which describes what kind of code a repository is rather than whether it has an allocation problem, so it was withdrawn. Nothing here is a finding about your code.
SC1 Supply-chain hygiene — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X14 Bypassable address classification — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X15 Unvalidated length from an untrusted reader — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X20 Mistyped argument guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X22 Contradicted release guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X24 Document value interpolated into markup unescaped — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X28 Index access outside its own emptiness guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
Appendix A — Findings (grouped)
The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.
Boundary-crossing change coupling: SimctlIOSDevice.kt ↔ LocalIOSDevice.kt maestro-ios-driver/src/main/kotlin/device/SimctlIOSDevice.kt:1— `maestro-ios-driver/src/main/kotlin/device/SimctlIOSDevice.kt` (context maestro-ios-driver) and `maestro-ios/src/main/java/ios/LocalIOSDevice.kt` (context maestro-ios) sit in DIFFERENT parts of the tree yet change together 78% of the time (29 of the 37 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 29 shared commits counted here, the most recent 3 are `411e3bd9` Fail startRecording gracefully with error message (#3105); `9b04674b` [MA 3235] --reinstall-driver flag getting ignored (#2455); `d91b4fa8` [MA 3094] terminate app through xctest request instead of simctl (#2374) (at that commit the file was still `maestro-ios/src/main/java/ios/simctl/SimctlIOSDevice.kt`) — run `git show` on any of them.
Boundary-crossing change coupling: Filters.kt ↔ Orchestra.kt maestro-client/src/main/java/maestro/Filters.kt:1— `maestro-client/src/main/java/maestro/Filters.kt` (context maestro-client) and `maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt` (context maestro-orchestra) sit in DIFFERENT parts of the tree yet change together 71% of the time (15 of the 21 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 15 shared commits counted here, the most recent 3 are `53790d3e` Text matches should match against 'error' property (#3524); `6337008c` feat: make Maestro natively suspend-aware (#3162); `9e0cf33b` fix: text and id combined selector (#2711) — run `git show` on any of them.
Boundary-crossing change coupling: StartDeviceCommand.kt ↔ DeviceService.kt maestro-cli/src/main/java/maestro/cli/command/StartDeviceCommand.kt:1— `maestro-cli/src/main/java/maestro/cli/command/StartDeviceCommand.kt` (context maestro-cli) and `maestro-client/src/main/java/maestro/device/DeviceService.kt` (context maestro-client) sit in DIFFERENT parts of the tree yet change together 69% of the time (11 of the 16 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 11 shared commits counted here, the most recent 3 are `0f1d26c8` feat(cli): accept full Android system image path via --device-os (#3543); `d89b544e` Set locale on correct emulator after start-device (#3395); `b4c88bfe` refactor: slim DeviceSpec to required fields + sparse serialization (… — run `git show` on any of them.
Boundary-crossing change coupling: SimctlIOSDevice.kt ↔ XCTestIOSDevice.kt maestro-ios-driver/src/main/kotlin/device/SimctlIOSDevice.kt:1— `maestro-ios-driver/src/main/kotlin/device/SimctlIOSDevice.kt` (context maestro-ios-driver) and `maestro-ios/src/main/java/ios/xctest/XCTestIOSDevice.kt` (context maestro-ios) sit in DIFFERENT parts of the tree yet change together 62% of the time (23 of the 37 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 23 shared commits counted here, the most recent 3 are `411e3bd9` Fail startRecording gracefully with error message (#3105); `9b04674b` [MA 3235] --reinstall-driver flag getting ignored (#2455); `d91b4fa8` [MA 3094] terminate app through xctest request instead of simctl (#2374) (at that commit the file was still `maestro-ios/src/main/java/ios/simctl/SimctlIOSDevice.kt`) — run `git show` on any of them.
Boundary-crossing change coupling: DeviceCreateUtil.kt ↔ DeviceService.kt maestro-cli/src/main/java/maestro/cli/device/DeviceCreateUtil.kt:1— `maestro-cli/src/main/java/maestro/cli/device/DeviceCreateUtil.kt` (context maestro-cli) and `maestro-client/src/main/java/maestro/device/DeviceService.kt` (context maestro-client) sit in DIFFERENT parts of the tree yet change together 60% of the time (6 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `70733df4` feat(device): support API 37 in start-device (minor-versioned + ps16k…; `0f1d26c8` feat(cli): accept full Android system image path via --device-os (#3543); `3ab87981` fix start device command for os-version flag (#3073) — run `git show` on any of them.
Boundary-crossing change coupling: ElementSelector.kt ↔ YamlElementSelector.kt maestro-orchestra-models/src/main/java/maestro/orchestra/ElementSelector.kt:1— `maestro-orchestra-models/src/main/java/maestro/orchestra/ElementSelector.kt` (context maestro-orchestra-models) and `maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlElementSelector.kt` (context maestro-orchestra) sit in DIFFERENT parts of the tree yet change together 59% of the time (10 of the 17 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 10 shared commits counted here, the most recent 3 are `c9902c69` [Web] CSS/DOM selector (#2537); `4eca23fc` childOf selector (#1586); `bfe5d78c` Add `containsDescendants` selector (#999) — run `git show` on any of them.
Boundary-crossing change coupling: Maestro.kt ↔ IOSDevice.kt maestro-client/src/main/java/maestro/Maestro.kt:1— `maestro-client/src/main/java/maestro/Maestro.kt` (context maestro-client) and `maestro-ios-driver/src/main/kotlin/device/IOSDevice.kt` (context maestro-ios-driver) sit in DIFFERENT parts of the tree yet change together 57% of the time (25 of the 44 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 25 shared commits counted here, the most recent 3 are `222b48f4` feat: adds `filterOutKeyboardElements` to make backward compatible (#… (at that commit the file was still `maestro-ios/src/main/java/ios/IOSDevice.kt`); `8cfa5dc2` Improvements in iOS driver to filter elements behind keyboard (#1633) (at that commit the file was still `maestro-ios/src/main/java/ios/IOSDevice.kt`); `e118b840` refactor: removing cleanup at end of test from add media feature (#1455) (at that commit the file was still `maestro-ios/src/main/java/ios/IOSDevice.kt`) — run `git show` on any of them.
Boundary-crossing change coupling: REDACTED ↔ IOSDevice.kt REDACTED:1— `REDACTED` (context maestro-client) and `maestro-ios-driver/src/main/kotlin/device/IOSDevice.kt` (context maestro-ios-driver) sit in DIFFERENT parts of the tree yet change together 57% of the time (25 of the 44 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 25 shared commits counted here, the most recent 3 are `222b48f4` feat: adds `filterOutKeyboardElements` to make backward compatible (#… (at that commit the file was still `maestro-ios/src/main/java/ios/IOSDevice.kt`); `8cfa5dc2` Improvements in iOS driver to filter elements behind keyboard (#1633) (at that commit the file was still `maestro-ios/src/main/java/ios/IOSDevice.kt`); `5f6a7068` refactor: improvements on iOS and Android driver (#1627) (at that commit the file was still `maestro-ios/src/main/java/ios/IOSDevice.kt`) — run `git show` on any of them.
Boundary-crossing change coupling: Driver.kt ↔ IOSDevice.kt maestro-client/src/main/java/maestro/Driver.kt:1— `maestro-client/src/main/java/maestro/Driver.kt` (context maestro-client) and `maestro-ios-driver/src/main/kotlin/device/IOSDevice.kt` (context maestro-ios-driver) sit in DIFFERENT parts of the tree yet change together 56% of the time (24 of the 43 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 24 shared commits counted here, the most recent 3 are `222b48f4` feat: adds `filterOutKeyboardElements` to make backward compatible (#… (at that commit the file was still `maestro-ios/src/main/java/ios/IOSDevice.kt`); `8cfa5dc2` Improvements in iOS driver to filter elements behind keyboard (#1633) (at that commit the file was still `maestro-ios/src/main/java/ios/IOSDevice.kt`); `e118b840` refactor: removing cleanup at end of test from add media feature (#1455) (at that commit the file was still `maestro-ios/src/main/java/ios/IOSDevice.kt`) — run `git show` on any of them.
Boundary-crossing change coupling: Driver.kt ↔ YamlFluentCommand.kt maestro-client/src/main/java/maestro/Driver.kt:1— `maestro-client/src/main/java/maestro/Driver.kt` (context maestro-client) and `maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlFluentCommand.kt` (context maestro-orchestra) sit in DIFFERENT parts of the tree yet change together 56% of the time (24 of the 43 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 24 shared commits counted here, the most recent 3 are `c9902c69` [Web] CSS/DOM selector (#2537); `fc179543` Added KillApp command to reproduce System-initiated Process Death on …; `212996ef` feat: allow airplane mode control (#1672) — run `git show` on any of them.
Boundary-crossing change coupling: Filters.kt ↔ YamlElementSelector.kt maestro-client/src/main/java/maestro/Filters.kt:1— `maestro-client/src/main/java/maestro/Filters.kt` (context maestro-client) and `maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlElementSelector.kt` (context maestro-orchestra) sit in DIFFERENT parts of the tree yet change together 53% of the time (9 of the 17 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 9 shared commits counted here, the most recent 3 are `c9902c69` [Web] CSS/DOM selector (#2537); `bfe5d78c` Add `containsDescendants` selector (#999); `ccd66c84` Feature: assertion on properties (#781) — run `git show` on any of them.
Boundary-crossing change coupling: IOSDriver.kt ↔ SimctlIOSDevice.kt maestro-client/src/main/java/maestro/drivers/IOSDriver.kt:1— `maestro-client/src/main/java/maestro/drivers/IOSDriver.kt` (context maestro-client) and `maestro-ios-driver/src/main/kotlin/device/SimctlIOSDevice.kt` (context maestro-ios-driver) sit in DIFFERENT parts of the tree yet change together 51% of the time (19 of the 37 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 19 shared commits counted here, the most recent 3 are `411e3bd9` Fail startRecording gracefully with error message (#3105); `6eef287f` feat: introducing TempFileHandler for iOS drivers (#2937); `9b04674b` [MA 3235] --reinstall-driver flag getting ignored (#2455) — run `git show` on any of them.
Boundary-crossing change coupling: Filters.kt ↔ ElementSelector.kt maestro-client/src/main/java/maestro/Filters.kt:1— `maestro-client/src/main/java/maestro/Filters.kt` (context maestro-client) and `maestro-orchestra-models/src/main/java/maestro/orchestra/ElementSelector.kt` (context maestro-orchestra-models) sit in DIFFERENT parts of the tree yet change together 50% of the time (9 of the 18 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 9 shared commits counted here, the most recent 3 are `c9902c69` [Web] CSS/DOM selector (#2537); `bfe5d78c` Add `containsDescendants` selector (#999); `ccd66c84` Feature: assertion on properties (#781) — run `git show` on any of them.
AC1 · Text alternatives· <img> without a text alternative · ×1
<img> without a text alternative maestro-cli/mcp-viewer/src/main.tsx:802— An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
<html> without a lang maestro-cli/src/main/java/maestro/cli/report/HtmlTestSuiteReporter.kt:50— The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
TodoComment maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:91— // TODO(bartkepacia): Use this in onCommandGeneratedOutput. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment maestro-orchestra/src/main/java/maestro/orchestra/yaml/MaestroFlowParser.kt:55— // TODO: — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment maestro-orchestra/src/main/java/maestro/orchestra/yaml/MaestroFlowParser.kt:397— // TODO: Add docs link — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment maestro-ios-driver/src/main/kotlin/util/LocalSimulatorUtils.kt:554— // TODO: more simctl supported permissions can be migrated here — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment maestro-ios/src/main/java/ios/xctest/XCTestIOSDevice.kt:38— // TODO(as): remove this list of apps from here once tested on cloud, we are not using this appIds now on server. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment maestro-ios/src/main/java/ios/xctest/XCTestIOSDevice.kt:103— // TODO(as): remove this list of apps from here once tested on cloud, we are not using this appIds now on server. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment maestro-ios/src/main/java/ios/xctest/XCTestIOSDevice.kt:117— // TODO(as): remove this list of apps from here once tested on cloud, we are not using this appIds now on server. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment maestro-ios/src/main/java/ios/xctest/XCTestIOSDevice.kt:225— // TODO(as): remove this list of apps from here once tested on cloud, we are not using this appIds now on server. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment maestro-client/src/main/java/maestro/UiElement.kt:90— // TODO needs different impl for iOS — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment maestro-client/src/main/java/maestro/android/chromedevtools/AndroidWebViewHierarchyClient.kt:33— // TODO: Adapt to handle chrome in the same way — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment maestro-cli/src/main/java/maestro/cli/runner/TestRunner.kt:157— // TODO(bartekpacia): make AI outputs work in continuous mode (see #1972)
TodoComment maestro-cli/src/main/java/maestro/cli/runner/TestSuiteInteractor.kt:151— // TODO(bartekpacia): Should it also be saving to debugOutputPath? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment maestro-cli/src/main/java/maestro/cli/runner/TestSuiteInteractor.kt:163— // TODO(bartekpacia): merge TestExecutionSummary with AI suggestions — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment maestro-cli/src/main/java/maestro/cli/report/HtmlAITestSuiteReporter.kt:24— // TODO(bartekpacia): Ideally, AI output would be in the same HTML file as "normal test output". There is no inherent reason — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment maestro-cli/src/main/java/maestro/cli/report/TestDebugReporter.kt:33— // TODO(bartekpacia): Rename to TestOutputReporter, because it's not only for "debug" stuff — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment maestro-cli/src/main/java/maestro/cli/model/TestExecutionSummary.kt:5— // TODO: Some properties should be implemented as getters, but it's not possible. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
Swallowed exception (caught, then discarded) maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlCommandReader.kt:88— `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) maestro-orchestra/src/main/java/maestro/orchestra/workspace/Filters.kt:26— `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) maestro-ios-driver/src/main/kotlin/xcuitest/crash/IOSCrashFileFinder.kt:65— `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) maestro-ios-driver/src/main/kotlin/xcuitest/crash/IOSCrashFileFinder.kt:120— `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) maestro-ios-driver/src/main/kotlin/xcuitest/crash/IPSParser.kt:104— `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) maestro-client/src/main/java/maestro/device/locale/AndroidLocale.kt:144— `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) maestro-client/src/main/java/maestro/device/locale/AndroidLocale.kt:185— `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) maestro-client/src/main/java/maestro/android/AndroidDeviceConnection.kt:486— `catch (_: Throwable)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) maestro-cli/src/main/java/maestro/cli/util/EnvUtils.kt:128— `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) maestro-cli/src/main/java/maestro/cli/util/FileUtils.kt:16— `catch (ignored: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) maestro-cli/src/main/java/maestro/cli/util/SocketUtils.kt:9— `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) maestro-cli/src/main/java/maestro/cli/util/SocketUtils.kt:33— `catch (_: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) maestro-cli/src/main/java/maestro/cli/update/Updates.kt:37— `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) maestro-cli/src/main/java/maestro/cli/update/Updates.kt:49— `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) maestro-cli/src/main/java/maestro/cli/session/MaestroSessionManager.kt:277— `catch (_: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) maestro-cli/src/main/java/maestro/cli/promotion/PromotionStateManager.kt:72— `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
FileTooLong: orchestra/Orchestra.kt maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt— FileTooLong — 1264 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 764 over it, 2.53× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: REDACTED REDACTED— FileTooLong — 958 significant lines (blank, comment-only and punctuation-only lines excluded), about 95% of them inside a single declaration: AndroidDriver (85-1571). The bar is 500 significant lines; this is 458 over it, 1.92× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: orchestra/Commands.kt maestro-orchestra-models/src/main/java/maestro/orchestra/Commands.kt— FileTooLong — 844 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 344 over it, 1.69× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: api/ApiClient.kt maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt— FileTooLong — 742 significant lines (blank, comment-only and punctuation-only lines excluded), about 73% of them inside a single declaration: ApiClient (53-828). The bar is 500 significant lines; this is 242 over it, 1.48× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: yaml/YamlFluentCommand.kt maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlFluentCommand.kt— FileTooLong — 725 significant lines (blank, comment-only and punctuation-only lines excluded), about 90% of them inside a single declaration: YamlFluentCommand (96-1052). The bar is 500 significant lines; this is 225 over it, 1.45× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: src/main.tsx maestro-cli/mcp-viewer/src/main.tsx— FileTooLong — 684 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 184 over it, 1.37× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: cloud/CloudInteractor.kt maestro-cli/src/main/java/maestro/cli/cloud/CloudInteractor.kt— FileTooLong — 567 significant lines (blank, comment-only and punctuation-only lines excluded), about 89% of them inside a single declaration: CloudInteractor (64-780). The bar is 500 significant lines; this is 67 over it, 1.13× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: drivers/CdpWebDriver.kt maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt— FileTooLong — 562 significant lines (blank, comment-only and punctuation-only lines excluded), about 89% of them inside a single declaration: CdpWebDriver (59-909). The bar is 500 significant lines; this is 62 over it, 1.12× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: device/DeviceService.kt maestro-client/src/main/java/maestro/device/DeviceService.kt— FileTooLong — 555 significant lines (blank, comment-only and punctuation-only lines excluded), about 96% of them inside a single declaration: AvdInfo (27-864). The bar is 500 significant lines; this is 55 over it, 1.11× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: maestro/Maestro.kt maestro-client/src/main/java/maestro/Maestro.kt— FileTooLong — 535 significant lines (blank, comment-only and punctuation-only lines excluded), about 95% of them inside a single declaration: Maestro (49-843). The bar is 500 significant lines; this is 35 over it, 1.07× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: util/LocalSimulatorUtils.kt maestro-ios-driver/src/main/kotlin/util/LocalSimulatorUtils.kt— FileTooLong — 535 significant lines (blank, comment-only and punctuation-only lines excluded), about 96% of them inside a single declaration: LocalSimulatorUtils (22-780). The bar is 500 significant lines; this is 35 over it, 1.07× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: command/TestCommand.kt maestro-cli/src/main/java/maestro/cli/command/TestCommand.kt— FileTooLong — 512 significant lines (blank, comment-only and punctuation-only lines excluded), about 88% of them inside a single declaration: TestCommand (85-759). The bar is 500 significant lines; this is 12 over it, 1.02× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: yaml/MaestroFlowParser.kt maestro-orchestra/src/main/java/maestro/orchestra/yaml/MaestroFlowParser.kt— FileTooLong — 512 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 12 over it, 1.02× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
TooManyMethods: AndroidDriver REDACTED:85— TooManyMethods — 89 methods. The bar is 30 methods; this is 59 over it, 2.97× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: Orchestra maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:137— TooManyMethods — 74 methods. The bar is 30 methods; this is 44 over it, 2.47× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: CdpWebDriver maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:59— TooManyMethods — 60 methods. The bar is 30 methods; this is 30 over it, 2.00× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: WebDriver maestro-client/src/main/java/maestro/drivers/WebDriver.kt:47— TooManyMethods — 56 methods. The bar is 30 methods; this is 26 over it, 1.87× the bar. Most of these members implement maestro.Driver (38 of 54 members), so moving them onto a smaller type would remove them from that contract rather than reduce it. To reduce it, split the contract instead: give each cohesive group of operations its own smaller interface and its own implementing type. Where the contract has to stay whole, move the work behind these members into collaborator types, so what is left here is a forward per member rather than a responsibility per member.
TooManyMethods: Maestro maestro-client/src/main/java/maestro/Maestro.kt:49— TooManyMethods — 54 methods. The bar is 30 methods; this is 24 over it, 1.80× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: IOSDriver maestro-client/src/main/java/maestro/drivers/IOSDriver.kt:69— TooManyMethods — 51 methods. The bar is 30 methods; this is 21 over it, 1.70× the bar. Most of these members implement maestro.Driver (40 of 49 members), so moving them onto a smaller type would remove them from that contract rather than reduce it. To reduce it, split the contract instead: give each cohesive group of operations its own smaller interface and its own implementing type. Where the contract has to stay whole, move the work behind these members into collaborator types, so what is left here is a forward per member rather than a responsibility per member.
TooManyMethods: LocalSimulatorUtils maestro-ios-driver/src/main/kotlin/util/LocalSimulatorUtils.kt:22— TooManyMethods — 42 methods. The bar is 30 methods; this is 12 over it, 1.40× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: DeviceService maestro-client/src/main/java/maestro/device/DeviceService.kt:29— TooManyMethods — 34 methods. The bar is 30 methods; this is 4 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: XCTestDriverClient maestro-ios-driver/src/main/kotlin/xcuitest/XCTestDriverClient.kt:18— TooManyMethods — 33 methods. The bar is 30 methods; this is 3 over it, 1.10× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: XCTestIOSDevice maestro-ios/src/main/java/ios/xctest/XCTestIOSDevice.kt:17— TooManyMethods — 33 methods. The bar is 30 methods; this is 3 over it, 1.10× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: SimctlIOSDevice maestro-ios-driver/src/main/kotlin/device/SimctlIOSDevice.kt:22— TooManyMethods — 31 methods. The bar is 30 methods; this is 1 over it, 1.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: AndroidDriver REDACTED:85— ClassTooLong — 907 significant lines (blank, comment-only and punctuation-only lines excluded), 89 methods. The bar is 400 significant lines; this is 507 over it, 2.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: YamlFluentCommand maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlFluentCommand.kt:96— ClassTooLong — 651 significant lines (blank, comment-only and punctuation-only lines excluded), 28 methods. The bar is 400 significant lines; this is 251 over it, 1.63× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: ApiClient maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:53— ClassTooLong — 541 significant lines (blank, comment-only and punctuation-only lines excluded), 24 methods. The bar is 400 significant lines; this is 141 over it, 1.35× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: AvdInfo maestro-client/src/main/java/maestro/device/DeviceService.kt:27— ClassTooLong — 531 significant lines (blank, comment-only and punctuation-only lines excluded), 1 methods. The bar is 400 significant lines; this is 131 over it, 1.33× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: LocalSimulatorUtils maestro-ios-driver/src/main/kotlin/util/LocalSimulatorUtils.kt:22— ClassTooLong — 516 significant lines (blank, comment-only and punctuation-only lines excluded), 42 methods. The bar is 400 significant lines; this is 116 over it, 1.29× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: Maestro maestro-client/src/main/java/maestro/Maestro.kt:49— ClassTooLong — 508 significant lines (blank, comment-only and punctuation-only lines excluded), 54 methods. The bar is 400 significant lines; this is 108 over it, 1.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: CloudInteractor maestro-cli/src/main/java/maestro/cli/cloud/CloudInteractor.kt:64— ClassTooLong — 507 significant lines (blank, comment-only and punctuation-only lines excluded), 16 methods. The bar is 400 significant lines; this is 107 over it, 1.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: CdpWebDriver maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:59— ClassTooLong — 499 significant lines (blank, comment-only and punctuation-only lines excluded), 60 methods. The bar is 400 significant lines; this is 99 over it, 1.25× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: TestCommand maestro-cli/src/main/java/maestro/cli/command/TestCommand.kt:85— ClassTooLong — 450 significant lines (blank, comment-only and punctuation-only lines excluded), 19 methods. The bar is 400 significant lines; this is 50 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: WebDriver maestro-client/src/main/java/maestro/drivers/WebDriver.kt:47— ClassTooLong — 446 significant lines (blank, comment-only and punctuation-only lines excluded), 56 methods. The bar is 400 significant lines; this is 46 over it, 1.12× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: IOSDriver maestro-client/src/main/java/maestro/drivers/IOSDriver.kt:69— ClassTooLong — 402 significant lines (blank, comment-only and punctuation-only lines excluded), 51 methods. The bar is 400 significant lines; this is 2 over it, 1.01× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
X13 · Undrained process stream· Redirected process stream is never drained (deadlock) · ×10
Redirected process stream is never drained (deadlock) maestro-ios-driver/src/main/kotlin/util/LocalSimulatorUtils.kt:59— The JDK pipes both `stdout` and `stderr` of a child started this way — no `redirectErrorStream`, `redirectError`, `redirectOutput` or `inheritIO` is set — and here `process.inputStream` (stdout) is read while the child's end is awaited, but nothing in this scope ever reads `process.errorStream` (stderr). The JDK's own `Process` documentation warns that failing to read a child's output promptly "may cause the process to block, or even deadlock": once the child writes more than the pipe holds to stderr (measured on OpenJDK 25 / Linux: 60,000 bytes finishes, 70,000 hangs forever), it blocks on the write, never exits, and the `waitFor` or end of stream this code waits on never comes. Nothing fails loudly: the thread hangs and the stuck child holds its resources until something kills it. Read both streams (a coroutine or thread per stream), merge them with `redirectErrorStream(true)` before `start()`, or discard the unwanted one with `redirectError(ProcessBuilder.Redirect.DISCARD)` (or `redirectOutput`).
Redirected process stream is never drained (deadlock) maestro-ios-driver/src/main/kotlin/util/LocalSimulatorUtils.kt:216— The JDK pipes both `stdout` and `stderr` of a child started this way — no `redirectErrorStream`, `redirectError`, `redirectOutput` or `inheritIO` is set — and here `process.inputStream` (stdout) is read while the child's end is awaited, but nothing in this scope ever reads `process.errorStream` (stderr). The JDK's own `Process` documentation warns that failing to read a child's output promptly "may cause the process to block, or even deadlock": once the child writes more than the pipe holds to stderr (measured on OpenJDK 25 / Linux: 60,000 bytes finishes, 70,000 hangs forever), it blocks on the write, never exits, and the `waitFor` or end of stream this code waits on never comes. Nothing fails loudly: the thread hangs and the stuck child holds its resources until something kills it. Read both streams (a coroutine or thread per stream), merge them with `redirectErrorStream(true)` before `start()`, or discard the unwanted one with `redirectError(ProcessBuilder.Redirect.DISCARD)` (or `redirectOutput`).
Redirected process stream is never drained (deadlock) maestro-ios-driver/src/main/kotlin/util/LocalSimulatorUtils.kt:360— The JDK pipes both `stdout` and `stderr` of a child started this way — no `redirectErrorStream`, `redirectError`, `redirectOutput` or `inheritIO` is set — and here `process.inputStream` (stdout) is read while the child's end is awaited, but nothing in this scope ever reads `process.errorStream` (stderr). The JDK's own `Process` documentation warns that failing to read a child's output promptly "may cause the process to block, or even deadlock": once the child writes more than the pipe holds to stderr (measured on OpenJDK 25 / Linux: 60,000 bytes finishes, 70,000 hangs forever), it blocks on the write, never exits, and the `waitFor` or end of stream this code waits on never comes. Nothing fails loudly: the thread hangs and the stuck child holds its resources until something kills it. Read both streams (a coroutine or thread per stream), merge them with `redirectErrorStream(true)` before `start()`, or discard the unwanted one with `redirectError(ProcessBuilder.Redirect.DISCARD)` (or `redirectOutput`).
Redirected process stream is never drained (deadlock) maestro-ios-driver/src/main/kotlin/util/XCRunnerCLIUtils.kt:23— The JDK pipes both `stdout` and `stderr` of a child started this way — no `redirectErrorStream`, `redirectError`, `redirectOutput` or `inheritIO` is set — and here `process.inputStream` (stdout) is read while the child's end is awaited, but nothing in this scope ever reads `process.errorStream` (stderr). The JDK's own `Process` documentation warns that failing to read a child's output promptly "may cause the process to block, or even deadlock": once the child writes more than the pipe holds to stderr (measured on OpenJDK 25 / Linux: 60,000 bytes finishes, 70,000 hangs forever), it blocks on the write, never exits, and the `waitFor` or end of stream this code waits on never comes. Nothing fails loudly: the thread hangs and the stuck child holds its resources until something kills it. Read both streams (a coroutine or thread per stream), merge them with `redirectErrorStream(true)` before `start()`, or discard the unwanted one with `redirectError(ProcessBuilder.Redirect.DISCARD)` (or `redirectOutput`).
Redirected process stream is never drained (deadlock) maestro-ios-driver/src/main/kotlin/util/XCRunnerCLIUtils.kt:77— The JDK pipes both `stdout` and `stderr` of a child started this way — no `redirectErrorStream`, `redirectError`, `redirectOutput` or `inheritIO` is set — and here `process.inputStream` (stdout) is read while the child's end is awaited, but nothing in this scope ever reads `process.errorStream` (stderr). The JDK's own `Process` documentation warns that failing to read a child's output promptly "may cause the process to block, or even deadlock": once the child writes more than the pipe holds to stderr (measured on OpenJDK 25 / Linux: 60,000 bytes finishes, 70,000 hangs forever), it blocks on the write, never exits, and the `waitFor` or end of stream this code waits on never comes. Nothing fails loudly: the thread hangs and the stuck child holds its resources until something kills it. Read both streams (a coroutine or thread per stream), merge them with `redirectErrorStream(true)` before `start()`, or discard the unwanted one with `redirectError(ProcessBuilder.Redirect.DISCARD)` (or `redirectOutput`).
Redirected process stream is never drained (deadlock) maestro-client/src/main/java/maestro/device/util/EnvUtils.kt:16— The JDK pipes both `stdout` and `stderr` of a child started this way — no `redirectErrorStream`, `redirectError`, `redirectOutput` or `inheritIO` is set — and here `p1.inputStream` (stdout) is read while the child's end is awaited, but nothing in this scope ever reads `p1.errorStream` (stderr). The JDK's own `Process` documentation warns that failing to read a child's output promptly "may cause the process to block, or even deadlock": once the child writes more than the pipe holds to stderr (measured on OpenJDK 25 / Linux: 60,000 bytes finishes, 70,000 hangs forever), it blocks on the write, never exits, and the `waitFor` or end of stream this code waits on never comes. Nothing fails loudly: the thread hangs and the stuck child holds its resources until something kills it. Read both streams (a coroutine or thread per stream), merge them with `redirectErrorStream(true)` before `start()`, or discard the unwanted one with `redirectError(ProcessBuilder.Redirect.DISCARD)` (or `redirectOutput`).
Redirected process stream is never drained (deadlock) maestro-client/src/main/java/maestro/device/util/EnvUtils.kt:22— The JDK pipes both `stdout` and `stderr` of a child started this way — no `redirectErrorStream`, `redirectError`, `redirectOutput` or `inheritIO` is set — and here `p2.inputStream` (stdout) is read while the child's end is awaited, but nothing in this scope ever reads `p2.errorStream` (stderr). The JDK's own `Process` documentation warns that failing to read a child's output promptly "may cause the process to block, or even deadlock": once the child writes more than the pipe holds to stderr (measured on OpenJDK 25 / Linux: 60,000 bytes finishes, 70,000 hangs forever), it blocks on the write, never exits, and the `waitFor` or end of stream this code waits on never comes. Nothing fails loudly: the thread hangs and the stuck child holds its resources until something kills it. Read both streams (a coroutine or thread per stream), merge them with `redirectErrorStream(true)` before `start()`, or discard the unwanted one with `redirectError(ProcessBuilder.Redirect.DISCARD)` (or `redirectOutput`).
Redirected process stream is never drained (deadlock) maestro-cli/src/main/java/maestro/cli/util/EnvUtils.kt:49— The JDK pipes both `stdout` and `stderr` of a child started this way — no `redirectErrorStream`, `redirectError`, `redirectOutput` or `inheritIO` is set — and here `p1.inputStream` (stdout) is read while the child's end is awaited, but nothing in this scope ever reads `p1.errorStream` (stderr). The JDK's own `Process` documentation warns that failing to read a child's output promptly "may cause the process to block, or even deadlock": once the child writes more than the pipe holds to stderr (measured on OpenJDK 25 / Linux: 60,000 bytes finishes, 70,000 hangs forever), it blocks on the write, never exits, and the `waitFor` or end of stream this code waits on never comes. Nothing fails loudly: the thread hangs and the stuck child holds its resources until something kills it. Read both streams (a coroutine or thread per stream), merge them with `redirectErrorStream(true)` before `start()`, or discard the unwanted one with `redirectError(ProcessBuilder.Redirect.DISCARD)` (or `redirectOutput`).
Redirected process stream is never drained (deadlock) maestro-cli/src/main/java/maestro/cli/util/EnvUtils.kt:55— The JDK pipes both `stdout` and `stderr` of a child started this way — no `redirectErrorStream`, `redirectError`, `redirectOutput` or `inheritIO` is set — and here `p2.inputStream` (stdout) is read while the child's end is awaited, but nothing in this scope ever reads `p2.errorStream` (stderr). The JDK's own `Process` documentation warns that failing to read a child's output promptly "may cause the process to block, or even deadlock": once the child writes more than the pipe holds to stderr (measured on OpenJDK 25 / Linux: 60,000 bytes finishes, 70,000 hangs forever), it blocks on the write, never exits, and the `waitFor` or end of stream this code waits on never comes. Nothing fails loudly: the thread hangs and the stuck child holds its resources until something kills it. Read both streams (a coroutine or thread per stream), merge them with `redirectErrorStream(true)` before `start()`, or discard the unwanted one with `redirectError(ProcessBuilder.Redirect.DISCARD)` (or `redirectOutput`).
Redirected process stream is never drained (deadlock) maestro-cli/src/main/java/maestro/cli/util/EnvUtils.kt:175— The JDK pipes both `stdout` and `stderr` of a child started this way — no `redirectErrorStream`, `redirectError`, `redirectOutput` or `inheritIO` is set — and here `process.inputStream` (stdout) is read while the child's end is awaited, but nothing in this scope ever reads `process.errorStream` (stderr). The JDK's own `Process` documentation warns that failing to read a child's output promptly "may cause the process to block, or even deadlock": once the child writes more than the pipe holds to stderr (measured on OpenJDK 25 / Linux: 60,000 bytes finishes, 70,000 hangs forever), it blocks on the write, never exits, and the `waitFor` or end of stream this code waits on never comes. Nothing fails loudly: the thread hangs and the stuck child holds its resources until something kills it. Read both streams (a coroutine or thread per stream), merge them with `redirectErrorStream(true)` before `start()`, or discard the unwanted one with `redirectError(ProcessBuilder.Redirect.DISCARD)` (or `redirectOutput`).
MethodTooLong: YamlFluentCommand._toCommands maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlFluentCommand.kt:166— MethodTooLong — _toCommands runs 235 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 135 over it, 2.35× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: CloudInteractor.upload maestro-cli/src/main/java/maestro/cli/cloud/CloudInteractor.kt:78— MethodTooLong — upload runs 160 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 60 over it, 1.60× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: RunOnCloudTool.create maestro-cli/src/main/java/maestro/cli/mcp/tools/RunOnCloudTool.kt:19— MethodTooLong — create runs 153 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 53 over it, 1.53× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: HtmlTestSuiteReporter.buildHtmlReport maestro-cli/src/main/java/maestro/cli/report/HtmlTestSuiteReporter.kt:47— MethodTooLong — buildHtmlReport runs 145 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 45 over it, 1.45× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: WorkspaceExecutionPlanner.plan maestro-orchestra/src/main/java/maestro/orchestra/workspace/WorkspaceExecutionPlanner.kt:19— MethodTooLong — plan runs 115 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 15 over it, 1.15× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: MaestroFlowParserKt.wrapException maestro-orchestra/src/main/java/maestro/orchestra/yaml/MaestroFlowParser.kt:205— MethodTooLong — wrapException runs 113 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 13 over it, 1.13× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Orchestra.buildFilter maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:1624— MethodTooLong — buildFilter runs 109 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 9 over it, 1.09× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: MaestroCommandRunner.runCommands maestro-cli/src/main/java/maestro/cli/runner/MaestroCommandRunner.kt:56— MethodTooLong — runCommands runs 101 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 1 over it, 1.01× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
Blocking `Thread.sleep` inside a coroutine maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:113— This coroutine runs on a dispatcher's thread, and `Thread.sleep` blocks that thread: for the whole delay no other coroutine scheduled on it makes progress (on `Dispatchers.Main` the UI freezes) — the Kotlin form of blocking on a task. Use `delay(…)`, which suspends only this coroutine. Where the blocking work is not a sleep but a call that cannot be made suspending, move it off the dispatcher with `withContext(Dispatchers.IO) { … }`.
Blocking `Thread.sleep` inside a coroutine maestro-ios-driver/src/main/kotlin/util/LocalSimulatorUtils.kt:225— This coroutine runs on a dispatcher's thread, and `Thread.sleep` blocks that thread: for the whole delay no other coroutine scheduled on it makes progress (on `Dispatchers.Main` the UI freezes) — the Kotlin form of blocking on a task. Use `delay(…)`, which suspends only this coroutine. Where the blocking work is not a sleep but a call that cannot be made suspending, move it off the dispatcher with `withContext(Dispatchers.IO) { … }`.
Blocking `Thread.sleep` inside a coroutine maestro-ios-driver/src/main/kotlin/util/LocalSimulatorUtils.kt:235— This coroutine runs on a dispatcher's thread, and `Thread.sleep` blocks that thread: for the whole delay no other coroutine scheduled on it makes progress (on `Dispatchers.Main` the UI freezes) — the Kotlin form of blocking on a task. Use `delay(…)`, which suspends only this coroutine. Where the blocking work is not a sleep but a call that cannot be made suspending, move it off the dispatcher with `withContext(Dispatchers.IO) { … }`.
Blocking `Thread.sleep` inside a coroutine maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:203— This coroutine runs on a dispatcher's thread, and `Thread.sleep` blocks that thread: for the whole delay no other coroutine scheduled on it makes progress (on `Dispatchers.Main` the UI freezes) — the Kotlin form of blocking on a task. Use `delay(…)`, which suspends only this coroutine. Where the blocking work is not a sleep but a call that cannot be made suspending, move it off the dispatcher with `withContext(Dispatchers.IO) { … }`.
Blocking `Thread.sleep` inside a coroutine maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:219— This coroutine runs on a dispatcher's thread, and `Thread.sleep` blocks that thread: for the whole delay no other coroutine scheduled on it makes progress (on `Dispatchers.Main` the UI freezes) — the Kotlin form of blocking on a task. Use `delay(…)`, which suspends only this coroutine. Where the blocking work is not a sleep but a call that cannot be made suspending, move it off the dispatcher with `withContext(Dispatchers.IO) { … }`.
Blocking `Thread.sleep` inside a coroutine maestro-client/src/main/java/maestro/device/DeviceService.kt:131— This coroutine runs on a dispatcher's thread, and `Thread.sleep` blocks that thread: for the whole delay no other coroutine scheduled on it makes progress (on `Dispatchers.Main` the UI freezes) — the Kotlin form of blocking on a task. Use `delay(…)`, which suspends only this coroutine. Where the blocking work is not a sleep but a call that cannot be made suspending, move it off the dispatcher with `withContext(Dispatchers.IO) { … }`.
Blocking `Thread.sleep` inside a coroutine maestro-client/src/main/java/maestro/device/DeviceService.kt:147— This coroutine runs on a dispatcher's thread, and `Thread.sleep` blocks that thread: for the whole delay no other coroutine scheduled on it makes progress (on `Dispatchers.Main` the UI freezes) — the Kotlin form of blocking on a task. Use `delay(…)`, which suspends only this coroutine. Where the blocking work is not a sleep but a call that cannot be made suspending, move it off the dispatcher with `withContext(Dispatchers.IO) { … }`.
Swallowed exception (empty catch) maestro-utils/src/main/kotlin/SocketUtils.kt:36— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) maestro-utils/src/main/kotlin/TempFileHandler.kt:30— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) maestro-orchestra/src/main/java/maestro/orchestra/workspace/DependencyResolver.kt:46— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) maestro-client/src/main/java/maestro/drivers/IOSDriver.kt:598— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) maestro-client/src/main/java/maestro/device/util/EnvUtils.kt:27— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) maestro-cli/src/main/java/maestro/cli/util/EnvUtils.kt:60— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) maestro-cli/mcp-viewer/src/main.tsx:546— `.catch(() => {})` handles the rejection by doing nothing — the failure is discarded with no log and no rethrow, and the chain carries on as if the work succeeded. Log it through whatever this codebase already uses to report problems, hand it to a caller that can (`next(error)`, a returned rejection), or don't catch it.
Duplicated block (9 lines × 2) maestro-cli/src/main/java/maestro/cli/command/ListCloudDevicesCommand.kt:83— maestro-cli/src/main/java/maestro/cli/command/ListCloudDevicesCommand.kt:83-91 | maestro-cli/src/main/java/maestro/cli/command/ListDevicesCommand.kt:84-92 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (9 lines × 2) maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:376— maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:376-384 | maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:1178-1186 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:376` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:680— maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:680-688 | maestro-client/src/main/java/maestro/drivers/WebDriver.kt:583-591 — before extracting anything, compare `maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt` and `maestro-client/src/main/java/maestro/drivers/WebDriver.kt` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (9 lines × 2) maestro-client/src/main/java/maestro/device/DeviceService.kt:788— maestro-client/src/main/java/maestro/device/DeviceService.kt:788-796 | maestro-client/src/main/java/maestro/device/DeviceService.kt:812-820 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `maestro-client/src/main/java/maestro/device/DeviceService.kt:788` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
AC3 · Page structure· Heading level jumps from h3 to h5 · ×3
Heading level jumps from h3 to h5 maestro-cli/src/main/java/maestro/cli/report/HtmlTestSuiteReporter.kt:84— Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one.
Heading level jumps from h3 to h5 maestro-cli/src/main/java/maestro/cli/report/HtmlTestSuiteReporter.kt:90— Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one.
Heading level jumps from h3 to h5 maestro-cli/src/main/java/maestro/cli/report/HtmlTestSuiteReporter.kt:116— Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one.
FixmeComment maestro-ios-driver/src/main/kotlin/xcuitest/installer/LocalXCTestInstaller.kt:66— // FIXME(bartekpacia): This method probably doesn't have to care about killing the XCTest Runner process. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment maestro-cli/src/main/java/maestro/cli/runner/TestSuiteInteractor.kt:218— // FIXME(bartekpacia): Save AI output as well — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment maestro-cli/src/main/java/maestro/cli/report/HtmlAITestSuiteReporter.kt:113— // FIXME(bartekpacia): This path will be broken when moved across machines — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
Change coupling: CommandLineUtils.kt ↔ LocalSimulatorUtils.kt maestro-ios-driver/src/main/kotlin/util/CommandLineUtils.kt:1— `maestro-ios-driver/src/main/kotlin/util/CommandLineUtils.kt` and `maestro-ios-driver/src/main/kotlin/util/LocalSimulatorUtils.kt` change together 80% of the time (8 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `b4918015` [MA 3325] Introduce `snapshotKeyHonorModalViews` behind platform conf…; `1530e923` fix: addressing regression related to runCommand (#2539); `96e8c9a2` improving logs + actually finding errors (#2528) — run `git show` on any of them.
Change coupling: RecordCommand.kt ↔ TestCommand.kt maestro-cli/src/main/java/maestro/cli/command/RecordCommand.kt:1— `maestro-cli/src/main/java/maestro/cli/command/RecordCommand.kt` and `maestro-cli/src/main/java/maestro/cli/command/TestCommand.kt` change together 50% of the time (8 of the 16 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `07e6c9f8` Add shard/device env vars for screenshots (#2909); `31630f51` feat: posthog setup (#2755); `f1da9b9e` Test output dir (#2589) — run `git show` on any of them.
Change coupling: PrintHierarchyCommand.kt ↔ QueryCommand.kt maestro-cli/src/main/java/maestro/cli/command/PrintHierarchyCommand.kt:1— `maestro-cli/src/main/java/maestro/cli/command/PrintHierarchyCommand.kt` and `maestro-cli/src/main/java/maestro/cli/command/QueryCommand.kt` change together 50% of the time (5 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 5 shared commits counted here, the most recent 3 are `6337008c` feat: make Maestro natively suspend-aware (#3162); `57f2b950` Deprecate hierarchy and query commands (#494); `918d343a` Tweak: more robust device-selection logic. Embedding idb_companion (#… — run `git show` on any of them.
D4 · Code Duplication· Edited copy of a member (21 corresponding lines) · ×3
Edited copy of a member (21 corresponding lines) maestro-client/src/main/java/maestro/Maestro.kt:411— maestro-client/src/main/java/maestro/Maestro.kt:411-441 | maestro-client/src/main/java/maestro/Maestro.kt:451-507 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (21 corresponding lines) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:547— maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:547-571 | maestro-client/src/main/java/maestro/drivers/WebDriver.kt:430-471 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (21 corresponding lines) maestro-ios-driver/src/main/kotlin/util/LocalIOSDeviceController.kt:29— maestro-ios-driver/src/main/kotlin/util/LocalIOSDeviceController.kt:29-51 | maestro-ios-driver/src/main/kotlin/util/LocalSimulatorUtils.kt:386-406 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (28 corresponding lines) · ×3
Edited copy of a member (28 corresponding lines) maestro-cli/src/main/java/maestro/cli/command/PrintHierarchyCommand.kt:194— maestro-cli/src/main/java/maestro/cli/command/PrintHierarchyCommand.kt:194-221 | maestro-cli/src/main/java/maestro/cli/mcp/tools/ViewHierarchyFormatters.kt:43-83 — These two members are one piece of code written twice and then edited apart: 28 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (28 corresponding lines) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:863— maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:863-890 | maestro-client/src/main/java/maestro/drivers/WebDriver.kt:757-784 — These two members are one piece of code written twice and then edited apart: 28 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (28 corresponding lines) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:344— maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:344-371 | maestro-client/src/main/java/maestro/drivers/WebDriver.kt:228-255 — These two members are one piece of code written twice and then edited apart: 28 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (14 lines × 2) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:780— maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:780-793 | maestro-client/src/main/java/maestro/drivers/WebDriver.kt:674-687 — before extracting anything, compare `maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt` and `maestro-client/src/main/java/maestro/drivers/WebDriver.kt` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (14 lines × 2) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:260— maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:260-273 | maestro-client/src/main/java/maestro/drivers/WebDriver.kt:171-184 — before extracting anything, compare `maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt` and `maestro-client/src/main/java/maestro/drivers/WebDriver.kt` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (14 lines × 2) maestro-cli/src/main/java/maestro/cli/command/ListCloudDevicesCommand.kt:62— maestro-cli/src/main/java/maestro/cli/command/ListCloudDevicesCommand.kt:62-75 | maestro-cli/src/main/java/maestro/cli/command/ListDevicesCommand.kt:51-64 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `maestro-cli/src/main/java/maestro/cli/command/ListCloudDevicesCommand.kt:62` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:475— maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:475-487 | maestro-client/src/main/java/maestro/drivers/WebDriver.kt:358-370 — before extracting anything, compare `maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt` and `maestro-client/src/main/java/maestro/drivers/WebDriver.kt` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:475` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:764— maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:764-776 | maestro-client/src/main/java/maestro/drivers/WebDriver.kt:658-670 — before extracting anything, compare `maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt` and `maestro-client/src/main/java/maestro/drivers/WebDriver.kt` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:764` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlFluentCommand.kt:560— maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlFluentCommand.kt:560-572 | maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlFluentCommand.kt:592-604 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlFluentCommand.kt:560` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) REDACTED:779— REDACTED:779-785 | maestro-client/src/main/java/maestro/drivers/IOSDriver.kt:525-531 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (7 lines × 2) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:522— maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:522-528 | maestro-client/src/main/java/maestro/drivers/WebDriver.kt:405-411 — before extracting anything, compare `maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt` and `maestro-client/src/main/java/maestro/drivers/WebDriver.kt` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (7 lines × 2) maestro-orchestra/src/main/java/maestro/orchestra/workspace/DependencyResolver.kt:161— maestro-orchestra/src/main/java/maestro/orchestra/workspace/DependencyResolver.kt:161-167 | maestro-orchestra/src/main/java/maestro/orchestra/workspace/WorkspaceUtils.kt:110-116 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Off the main sequence: maestro:maestro-ai — maestro:maestro-ai: abstractness 0.06, instability 0.00, distance 0.94 — an application entry point, so it is concrete by design — the distance is expected; what is worth checking is that other projects depend on it at all, since a host should be a leaf of the graph.
Off the main sequence: maestro:maestro-utils — maestro:maestro-utils: abstractness 0.10, instability 0.00, distance 0.90 — zone of pain — concrete and depended on by 7 project(s), so it's rigid to change.
Off the main sequence: maestro:maestro-ios-driver — maestro:maestro-ios-driver: abstractness 0.04, instability 0.25, distance 0.71 — zone of pain — concrete and depended on by 3 project(s), so it's rigid to change.
Hotspot: maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:201— maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt changed 5 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 23 in ApiClient.upload at line 201. 1 of those changes was a fix/bug commit, and the other 4 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 17:07:34 +00:00' --until='2026-11-13 17:07:34 +00:00' --full-history --no-merges -- maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: maestro-cli/src/main/java/maestro/cli/cloud/CloudInteractor.kt maestro-cli/src/main/java/maestro/cli/cloud/CloudInteractor.kt:78— maestro-cli/src/main/java/maestro/cli/cloud/CloudInteractor.kt changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 22 in CloudInteractor.upload at line 78. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 17:07:34 +00:00' --until='2026-11-13 17:07:34 +00:00' --full-history --no-merges -- maestro-cli/src/main/java/maestro/cli/cloud/CloudInteractor.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
D4 · Code Duplication· Edited copy of a member (31 corresponding lines) · ×2
Edited copy of a member (31 corresponding lines) maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:584— maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:584-620 | maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:622-652 — These two members are one piece of code written twice and then edited apart: 31 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (31 corresponding lines) maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlFluentCommand.kt:554— maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlFluentCommand.kt:554-584 | maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlFluentCommand.kt:586-619 — These two members are one piece of code written twice and then edited apart: 31 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (25 corresponding lines) · ×2
Edited copy of a member (25 corresponding lines) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:463— maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:463-487 | maestro-client/src/main/java/maestro/drivers/WebDriver.kt:346-370 — These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (25 corresponding lines) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:403— maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:403-427 | maestro-client/src/main/java/maestro/drivers/WebDriver.kt:287-311 — These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (24 corresponding lines) · ×2
Edited copy of a member (24 corresponding lines) maestro-client/src/main/java/maestro/mockserver/MockInteractor.kt:46— maestro-client/src/main/java/maestro/mockserver/MockInteractor.kt:46-75 | maestro-client/src/main/java/maestro/mockserver/MockInteractor.kt:77-100 — These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (24 corresponding lines) maestro-cli/src/main/java/maestro/cli/command/TestCommand.kt:710— maestro-cli/src/main/java/maestro/cli/command/TestCommand.kt:710-733 | maestro-cli/src/main/java/maestro/cli/command/TestCommand.kt:735-758 — These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (13 corresponding lines) · ×2
Edited copy of a member (13 corresponding lines) maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlEvalScript.kt:15— maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlEvalScript.kt:15-29 | maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlInputText.kt:16-28 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (13 corresponding lines) maestro-ios-driver/src/main/kotlin/xcuitest/XCTestDriverClient.kt:232— maestro-ios-driver/src/main/kotlin/xcuitest/XCTestDriverClient.kt:232-244 | maestro-ios-driver/src/main/kotlin/xcuitest/XCTestDriverClient.kt:267-280 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (9 corresponding lines) · ×2
Edited copy of a member (9 corresponding lines) maestro-cli/src/main/java/maestro/cli/graphics/SkiaFrameRenderer.kt:150— maestro-cli/src/main/java/maestro/cli/graphics/SkiaFrameRenderer.kt:150-158 | maestro-cli/src/main/java/maestro/cli/graphics/SkiaFrameRenderer.kt:181-189 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) maestro-ios-driver/src/main/kotlin/util/AssociatedDomainsRefresher.kt:69— maestro-ios-driver/src/main/kotlin/util/AssociatedDomainsRefresher.kt:69-77 | maestro-ios-driver/src/main/kotlin/util/LocalSimulatorUtils.kt:305-313 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (4 corresponding lines) · ×2
Edited copy of a member (4 corresponding lines) maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlSetAirplaneMode.kt:62— maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlSetAirplaneMode.kt:62-65 | maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlSetDarkMode.kt:62-65 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (4 corresponding lines) maestro-orchestra/src/main/java/maestro/orchestra/workspace/WorkspaceExecutionPlanner.kt:188— maestro-orchestra/src/main/java/maestro/orchestra/workspace/WorkspaceExecutionPlanner.kt:188-193 | maestro-orchestra/src/main/java/maestro/orchestra/workspace/WorkspaceUtils.kt:79-82 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (17 lines × 2) maestro-cli/src/main/java/maestro/cli/mcp/tools/InspectScreenTool.kt:37— maestro-cli/src/main/java/maestro/cli/mcp/tools/InspectScreenTool.kt:37-53 | maestro-cli/src/main/java/maestro/cli/mcp/tools/TakeScreenshotTool.kt:36-52 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `maestro-cli/src/main/java/maestro/cli/mcp/tools/InspectScreenTool.kt:37` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (17 lines × 2) maestro-cli/src/main/java/maestro/cli/command/TestCommand.kt:713— maestro-cli/src/main/java/maestro/cli/command/TestCommand.kt:713-729 | maestro-cli/src/main/java/maestro/cli/command/TestCommand.kt:738-754 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `maestro-cli/src/main/java/maestro/cli/command/TestCommand.kt:713` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16 lines × 2) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:356— maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:356-371 | maestro-client/src/main/java/maestro/drivers/WebDriver.kt:240-255 — before extracting anything, compare `maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt` and `maestro-client/src/main/java/maestro/drivers/WebDriver.kt` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:356` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16 lines × 2) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:659— maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:659-674 | maestro-client/src/main/java/maestro/drivers/WebDriver.kt:562-577 — before extracting anything, compare `maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt` and `maestro-client/src/main/java/maestro/drivers/WebDriver.kt` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (8 lines × 3) maestro-cli/src/main/java/maestro/cli/util/EnvUtils.kt:76— maestro-cli/src/main/java/maestro/cli/util/EnvUtils.kt:76-83 | maestro-client/src/main/java/maestro/device/util/EnvUtils.kt:43-50 | maestro-client/src/main/java/maestro/device/util/SystemInfo.kt:6-13 — before extracting anything, compare `maestro-cli/src/main/java/maestro/cli/util/EnvUtils.kt` and `maestro-client/src/main/java/maestro/device/util/EnvUtils.kt` as WHOLE FILES: 97% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (8 lines × 3) maestro-client/src/main/java/maestro/Filters.kt:61— maestro-client/src/main/java/maestro/Filters.kt:61-68 | maestro-client/src/main/java/maestro/Filters.kt:72-80 | maestro-client/src/main/java/maestro/Filters.kt:83-90 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (8 lines × 2) maestro-client/src/main/java/maestro/android/AndroidDeviceConnection.kt:180— maestro-client/src/main/java/maestro/android/AndroidDeviceConnection.kt:180-187 | maestro-client/src/main/java/maestro/android/AndroidDeviceConnection.kt:190-197 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:106— maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:106-113 | maestro-web/src/main/kotlin/maestro/web/selenium/ChromeSeleniumFactory.kt:17-24 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (5 lines × 2) maestro-client/src/main/java/maestro/Maestro.kt:169— maestro-client/src/main/java/maestro/Maestro.kt:169-173 | maestro-client/src/main/java/maestro/Maestro.kt:175-179 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (5 lines × 2) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:511— maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:511-515 | maestro-client/src/main/java/maestro/drivers/WebDriver.kt:394-398 — before extracting anything, compare `maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt` and `maestro-client/src/main/java/maestro/drivers/WebDriver.kt` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:511` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Low cohesion: LocalSimulatorUtils (LCOM4 6) maestro-ios-driver/src/main/kotlin/util/LocalSimulatorUtils.kt:22— LocalSimulatorUtils's methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: XCRunnerCLIUtils (LCOM4 5) maestro-ios-driver/src/main/kotlin/util/XCRunnerCLIUtils.kt:18— XCRunnerCLIUtils's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Outbound HTTP without resilience maestro-cli/src/main/java/maestro/cli/util/FileDownloader.kt:22— `HttpClient(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
Outbound HTTP without resilience maestro-web/src/main/kotlin/maestro/web/cdp/CdpClient.kt:49— `HttpClient(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
Sync-over-async blocking maestro-client/src/main/java/maestro/Maestro.kt:685— `startScreenRecording` is async and calls Thread.sleep — a blocking call inside async code stalls the coroutine's thread, and every coroutine dispatched to it for as long as it runs.
Sync-over-async blocking maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:108— `waitIfPaused` is async and calls Thread.sleep — a blocking call inside async code stalls the coroutine's thread, and every coroutine dispatched to it for as long as it runs.
X17 · Uncapped recursion over a caller-supplied document· Recursive walk over a caller-supplied document has no depth cap · ×2
Recursive walk over a caller-supplied document has no depth cap maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:400— `parseDomAsTreeNodes` is public and takes `domRepresentation: Map<String, Any>` from its caller, and it calls itself at line 400 with a piece of `domRepresentation` — the function is not `tailrec`, so every call is a real frame — and nowhere in `parseDomAsTreeNodes` is there a depth parameter, a descent counter, or any other cap. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. On the JVM's default 1 MB thread stack a recursive walk throws `StackOverflowError` from about 500–2,000 levels on a cold first call and 6,000–17,000 once warmed up (OpenJDK 21 and 25; Android's threads are smaller). kotlinx.serialization's `parseToJsonElement` accepts nested arrays to any depth and Android's built-in `org.json` sets no limit, while Jackson 2.15+ stops at 1,000 — on a cold JVM past the point the walk fails; Gson 2.12+ and Moshi stop at 255. `StackOverflowError` is an `Error`, not an `Exception`: a `catch (e: Exception)` around the call does not stop it, and on Android an uncaught one ends the process. Thread a depth argument through `parseDomAsTreeNodes` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack or a `DeepRecursiveFunction`.
Recursive walk over a caller-supplied document has no depth cap maestro-client/src/main/java/maestro/drivers/WebDriver.kt:284— `parseDomAsTreeNodes` is public and takes `domRepresentation: Map<String, Any>` from its caller, and it calls itself at line 284 with a piece of `domRepresentation` — the function is not `tailrec`, so every call is a real frame — and nowhere in `parseDomAsTreeNodes` is there a depth parameter, a descent counter, or any other cap. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. On the JVM's default 1 MB thread stack a recursive walk throws `StackOverflowError` from about 500–2,000 levels on a cold first call and 6,000–17,000 once warmed up (OpenJDK 21 and 25; Android's threads are smaller). kotlinx.serialization's `parseToJsonElement` accepts nested arrays to any depth and Android's built-in `org.json` sets no limit, while Jackson 2.15+ stops at 1,000 — on a cold JVM past the point the walk fails; Gson 2.12+ and Moshi stop at 255. `StackOverflowError` is an `Error`, not an `Exception`: a `catch (e: Exception)` around the call does not stop it, and on Android an uncaught one ends the process. Thread a depth argument through `parseDomAsTreeNodes` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack or a `DeepRecursiveFunction`.
X18 · Disposal-pattern correctness· Disposable created and abandoned in the function that made it · ×2
Disposable created and abandoned in the function that made it maestro-orchestra/src/main/java/maestro/orchestra/workspace/YamlCommandsPathValidator.kt:21— `Files.walk(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and its only use reads `.anyMatch` through it and drops it, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `Files.walk(…).use { r -> … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`.
Disposable created and abandoned in the function that made it maestro-ios-driver/src/main/kotlin/util/LocalSimulatorUtils.kt:242— `Files.walk(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and its only use reads `.forEach` through it and drops it, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `Files.walk(…).use { r -> … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`.
X2 · Cancellation propagation· Async function without AbortSignal · ×2
Async function without AbortSignal: startOnlyConnectedDevice maestro-cli/mcp-viewer/src/main.tsx:882— `startOnlyConnectedDevice` awaits `fetch(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `fetch(url, { signal })`.
Async function without AbortSignal: startDeviceStream maestro-cli/mcp-viewer/src/main.tsx:900— `startDeviceStream` awaits `fetch(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `fetch(url, { signal })`.
AC1 · Text alternatives· <canvas> without a text alternative · ×1
<canvas> without a text alternative maestro-cli/mcp-viewer/src/main.tsx:509— A <canvas> with no aria-label/title and no inner fallback content can't be described by assistive tech. Add a name or fallback content.
AC3 · Page structure· Page without a main landmark · ×1
Page without a main landmark maestro-cli/src/main/java/maestro/cli/report/HtmlTestSuiteReporter.kt:50— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
AC3 · Page structure· Heading level jumps from h1 to h5 · ×1
Heading level jumps from h1 to h5 maestro-cli/src/main/java/maestro/cli/report/HtmlTestSuiteReporter.kt:78— Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one.
AC6 · Visual & motion safety· Animation without a prefers-reduced-motion guard · ×1
Animation without a prefers-reduced-motion guard maestro-cli/mcp-viewer/src/main.tsx:130— <svg> moves — its `animate-spin` utility runs with no motion-safe:/motion-reduce: variant — and nothing reads prefers-reduced-motion for it, so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Gate it on @media (prefers-reduced-motion: no-preference) or motion-safe:.
maestro-web.traverse (cyclomatic 29) maestro-client/src/main/resources/maestro-web.js:92— maestro-web.traverse has cyclomatic complexity 29 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
ApiClient.upload (cyclomatic 23) maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:201— ApiClient.upload has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
CloudInteractor.upload (cyclomatic 22) maestro-cli/src/main/java/maestro/cli/cloud/CloudInteractor.kt:78— CloudInteractor.upload has cyclomatic complexity 22 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
TestCommand.handleSessions (cyclomatic 22) maestro-cli/src/main/java/maestro/cli/command/TestCommand.kt:358— TestCommand.handleSessions has cyclomatic complexity 22 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
HtmlTestSuiteReporter.buildHtmlReport (cyclomatic 19) maestro-cli/src/main/java/maestro/cli/report/HtmlTestSuiteReporter.kt:47— HtmlTestSuiteReporter.buildHtmlReport has cyclomatic complexity 19 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
AndroidDriver.mapHierarchy (cyclomatic 18) REDACTED:1148— AndroidDriver.mapHierarchy has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This is NOT this file's highest cyclomatic complexity: AndroidDriver.pressKey (cyclomatic 31) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
WorkspaceExecutionPlanner.plan (cyclomatic 16) maestro-orchestra/src/main/java/maestro/orchestra/workspace/WorkspaceExecutionPlanner.kt:19— WorkspaceExecutionPlanner.plan has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
Repeated repair: maestro-orchestra/src/main/kotlin/maestro/orchestra/debug/ArtifactsGenerator.kt maestro-orchestra/src/main/kotlin/maestro/orchestra/debug/ArtifactsGenerator.kt:140— maestro-orchestra/src/main/kotlin/maestro/orchestra/debug/ArtifactsGenerator.kt changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 10 (its worst body is ArtifactsGenerator.onCommandFinished at line 140), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(ios): detect app crashes from one signal, how the process ended (#3648)”; “fix(orchestra): collect crash reports for the flow's evaluated appId (#3645)”; “fix(orchestra): write the assertScreenshot diff into the run's artifacts (#3637)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 17:07:34 +00:00' --until='2026-11-13 17:07:34 +00:00' --full-history --no-merges -- maestro-orchestra/src/main/kotlin/maestro/orchestra/debug/ArtifactsGenerator.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
AndroidDriver.mapHierarchy (cognitive 34) REDACTED:1148— AndroidDriver.mapHierarchy has cognitive complexity 34 (threshold 15). Drivers by points: if/else 18 (33 pts), boolean chains 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ApiClient.upload (cognitive 33) maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:201— ApiClient.upload has cognitive complexity 33 (threshold 15). Drivers by points: if/else 20 (28 pts), boolean chains 4, error handling 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LogcatReader.findJvmCrashes (cognitive 31) maestro-client/src/main/java/maestro/android/crashes/LogcatReader.kt:52— LogcatReader.findJvmCrashes has cognitive complexity 31 (threshold 15). Drivers by points: if/else 13 (30 pts), loops 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CloudInteractor.upload (cognitive 30) maestro-cli/src/main/java/maestro/cli/cloud/CloudInteractor.kt:78— CloudInteractor.upload has cognitive complexity 30 (threshold 15). Drivers by points: if/else 22 (23 pts), error handling 2 (4 pts), boolean chains 2, match/switch 1 (nesting depth added 3). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
maestro-web.maestro.createXPathFromElement (cognitive 30) maestro-client/src/main/resources/maestro-web.js:228— maestro-web.maestro.createXPathFromElement has cognitive complexity 30 (threshold 15). Drivers by points: if/else 8 (20 pts), loops 3 (7 pts), boolean chains 2, ternaries 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CloudInteractor.waitForCompletion (cognitive 27) maestro-cli/src/main/java/maestro/cli/cloud/CloudInteractor.kt:525— CloudInteractor.waitForCompletion has cognitive complexity 27 (threshold 15). Drivers by points: if/else 8 (20 pts), error handling 2 (3 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
traverse (cognitive 27) maestro-client/src/main/resources/maestro-web.js:92— traverse has cognitive complexity 27 (threshold 15). Drivers by points: boolean chains 12, if/else 8 (9 pts), error handling 2 (5 pts), ternaries 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TestCommand.handleSessions (cognitive 25) maestro-cli/src/main/java/maestro/cli/command/TestCommand.kt:358— TestCommand.handleSessions has cognitive complexity 25 (threshold 15). Drivers by points: if/else 18 (19 pts), boolean chains 4, match/switch 2 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
LogcatReader.findANRs (cognitive 22) maestro-client/src/main/java/maestro/android/crashes/LogcatReader.kt:114— LogcatReader.findANRs has cognitive complexity 22 (threshold 15). Drivers by points: if/else 13 (21 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AnalyticsStateManagerKt.getOrgStatus (cognitive 21) maestro-cli/src/main/java/maestro/cli/analytics/AnalyticsStateManager.kt:171— AnalyticsStateManagerKt.getOrgStatus has cognitive complexity 21 (threshold 15). Drivers by points: if/else 14 (20 pts), boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
WorkspaceExecutionPlanner.plan (cognitive 20) maestro-orchestra/src/main/java/maestro/orchestra/workspace/WorkspaceExecutionPlanner.kt:19— WorkspaceExecutionPlanner.plan has cognitive complexity 20 (threshold 15). Drivers by points: if/else 12 (14 pts), boolean chains 6 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
CommandArgsSanitizer.sanitize (cognitive 19) maestro-cli/src/main/java/maestro/cli/analytics/CommandArgsSanitizer.kt:39— CommandArgsSanitizer.sanitize has cognitive complexity 19 (threshold 15). Drivers by points: if/else 9 (16 pts), boolean chains 2, loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HtmlTestSuiteReporter.buildHtmlReport (cognitive 19) maestro-cli/src/main/java/maestro/cli/report/HtmlTestSuiteReporter.kt:47— HtmlTestSuiteReporter.buildHtmlReport has cognitive complexity 19 (threshold 15). Drivers by points: if/else 14, boolean chains 3, match/switch 1 (2 pts) (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
Maestro.screenshotBasedTap (cognitive 19) maestro-client/src/main/java/maestro/Maestro.kt:443— Maestro.screenshotBasedTap has cognitive complexity 19 (threshold 15). Drivers by points: if/else 11 (16 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Orchestra.scrollUntilVisible (cognitive 19) maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:856— Orchestra.scrollUntilVisible has cognitive complexity 19 (threshold 15). Drivers by points: if/else 11 (14 pts), boolean chains 2, error handling 1 (2 pts), loops 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
RunOnCloudTool.create (cognitive 18) maestro-cli/src/main/java/maestro/cli/mcp/tools/RunOnCloudTool.kt:19— RunOnCloudTool.create has cognitive complexity 18 (threshold 15). Drivers by points: if/else 11, error handling 3 (5 pts), match/switch 1 (2 pts) (nesting depth added 3). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
DeviceCreateUtil.getOrCreateAndroidDevice (cognitive 17) maestro-cli/src/main/java/maestro/cli/device/DeviceCreateUtil.kt:91— DeviceCreateUtil.getOrCreateAndroidDevice has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (13 pts), boolean chains 3, error handling 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LogcatReader.findNativeCrashes (cognitive 17) maestro-client/src/main/java/maestro/android/crashes/LogcatReader.kt:82— LogcatReader.findNativeCrashes has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (15 pts), boolean chains 1, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Orchestra.runFlow (cognitive 17) maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:228— Orchestra.runFlow has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (7 pts), error handling 4 (6 pts), boolean chains 4 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Orchestra.findElement (cognitive 17) maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:1486— Orchestra.findElement has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (17 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ViewHierarchyFormatters.extractCompactCsvOutput (cognitive 16) maestro-cli/src/main/java/maestro/cli/mcp/tools/ViewHierarchyFormatters.kt:95— ViewHierarchyFormatters.extractCompactCsvOutput has cognitive complexity 16 (threshold 15). Drivers by points: if/else 14 (15 pts), loops 1 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ScreenshotUtils.waitForAppToSettle (cognitive 16) maestro-client/src/main/java/maestro/utils/ScreenshotUtils.kt:38— ScreenshotUtils.waitForAppToSettle has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (14 pts), loops 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FunctionTooLong: main.CommandsPanel maestro-cli/mcp-viewer/src/main.tsx:234— FunctionTooLong — CommandsPanel runs 116 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 16 over it, 1.16× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
D4 · Code Duplication· Members sharing a duplicated core (8 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (8 members, 50+ identical tokens) maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:105— maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:105-127 | maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:175-199 | maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:624-653 | maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:655-684 | maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:686-715 | maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:717-746 | maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:748-777 | maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:783-812 — These 8 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 8 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 8 times.
D4 · Code Duplication· Edited copy of a member (68 corresponding lines) · ×1
Edited copy of a member (68 corresponding lines) maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:326— maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:326-412 | maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:1152-1219 — These two members are one piece of code written twice and then edited apart: 68 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (65 corresponding lines) · ×1
Edited copy of a member (65 corresponding lines) maestro-ai/src/main/java/maestro/ai/anthropic/Client.kt:47— maestro-ai/src/main/java/maestro/ai/anthropic/Client.kt:47-111 | maestro-ai/src/main/java/maestro/ai/openai/Client.kt:44-110 — These two members are one piece of code written twice and then edited apart: 65 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (41 corresponding lines) · ×1
Edited copy of a member (41 corresponding lines) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:105— maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:105-155 | maestro-web/src/main/kotlin/maestro/web/selenium/ChromeSeleniumFactory.kt:16-56 — These two members are one piece of code written twice and then edited apart: 41 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (29 corresponding lines) · ×1
Edited copy of a member (29 corresponding lines) maestro-ai/src/main/java/maestro/ai/cloud/ApiClient.kt:71— maestro-ai/src/main/java/maestro/ai/cloud/ApiClient.kt:71-99 | maestro-ai/src/main/java/maestro/ai/cloud/ApiClient.kt:105-133 — These two members are one piece of code written twice and then edited apart: 29 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (17 corresponding lines) · ×1
Edited copy of a member (17 corresponding lines) maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlSetAirplaneMode.kt:39— maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlSetAirplaneMode.kt:39-55 | maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlSetDarkMode.kt:39-55 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (10 corresponding lines) · ×1
Edited copy of a member (10 corresponding lines) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:506— maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:506-515 | maestro-client/src/main/java/maestro/drivers/WebDriver.kt:389-398 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (20 corresponding lines) · ×1
Edited copy of a member (20 corresponding lines) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:757— maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:757-776 | maestro-client/src/main/java/maestro/drivers/WebDriver.kt:651-670 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (16 corresponding lines) · ×1
Edited copy of a member (16 corresponding lines) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:573— maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:573-588 | maestro-client/src/main/java/maestro/drivers/WebDriver.kt:473-492 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (12 corresponding lines) · ×1
Edited copy of a member (12 corresponding lines) maestro-orchestra/src/main/java/maestro/orchestra/yaml/MaestroFlowParser.kt:545— maestro-orchestra/src/main/java/maestro/orchestra/yaml/MaestroFlowParser.kt:545-557 | maestro-orchestra/src/main/java/maestro/orchestra/yaml/MaestroFlowParser.kt:627-638 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 10+ corresponding lines) · ×1
Edited copies of one member (3 members, 10+ corresponding lines) maestro-cli/src/main/java/maestro/cli/util/EnvUtils.kt:74— maestro-cli/src/main/java/maestro/cli/util/EnvUtils.kt:74-83 | maestro-client/src/main/java/maestro/device/util/EnvUtils.kt:41-50 | maestro-client/src/main/java/maestro/device/util/SystemInfo.kt:4-13 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 10 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 8+ corresponding lines) · ×1
Edited copies of one member (3 members, 8+ corresponding lines) maestro-client/src/main/java/maestro/android/AndroidDeviceConnection.kt:159— maestro-client/src/main/java/maestro/android/AndroidDeviceConnection.kt:159-167 | maestro-client/src/main/java/maestro/android/AndroidDeviceConnection.kt:170-177 | maestro-client/src/main/java/maestro/android/AndroidDeviceConnection.kt:237-244 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 8 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (11 corresponding lines) · ×1
Edited copy of a member (11 corresponding lines) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:236— maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:236-246 | maestro-client/src/main/java/maestro/drivers/WebDriver.kt:147-157 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (18 corresponding lines) · ×1
Edited copy of a member (18 corresponding lines) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:86— maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:86-103 | maestro-client/src/main/java/maestro/drivers/WebDriver.kt:73-92 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (8 corresponding lines) · ×1
Edited copy of a member (8 corresponding lines) maestro-orchestra/src/main/java/maestro/orchestra/workspace/DependencyResolver.kt:105— maestro-orchestra/src/main/java/maestro/orchestra/workspace/DependencyResolver.kt:105-113 | maestro-utils/src/main/kotlin/FileAccessScope.kt:66-73 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (7 corresponding lines) · ×1
Edited copy of a member (7 corresponding lines) maestro-orchestra-models/src/main/java/maestro/orchestra/Commands.kt:417— maestro-orchestra-models/src/main/java/maestro/orchestra/Commands.kt:417-423 | maestro-orchestra-models/src/main/java/maestro/orchestra/Condition.kt:15-21 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (31–33 lines × 2) maestro-client/src/main/java/maestro/device/util/CommandLineUtils.kt:20— maestro-client/src/main/java/maestro/device/util/CommandLineUtils.kt:20-52 | maestro-ios-driver/src/main/kotlin/util/CommandLineUtils.kt:25-55 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `maestro-client/src/main/java/maestro/device/util/CommandLineUtils.kt:20` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (56 lines × 2) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:797— maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:797-852 | maestro-client/src/main/java/maestro/drivers/WebDriver.kt:691-746 — before extracting anything, compare `maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt` and `maestro-client/src/main/java/maestro/drivers/WebDriver.kt` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (28–29 lines × 2) maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:318— maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:318-346 | maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:396-423 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:318` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (28 lines × 2) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:374— maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:374-401 | maestro-client/src/main/java/maestro/drivers/WebDriver.kt:258-285 — before extracting anything, compare `maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt` and `maestro-client/src/main/java/maestro/drivers/WebDriver.kt` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (23 lines × 2) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:634— maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:634-656 | maestro-client/src/main/java/maestro/drivers/WebDriver.kt:537-559 — before extracting anything, compare `maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt` and `maestro-client/src/main/java/maestro/drivers/WebDriver.kt` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (22 lines × 2) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:864— maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:864-885 | maestro-client/src/main/java/maestro/drivers/WebDriver.kt:758-779 — before extracting anything, compare `maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt` and `maestro-client/src/main/java/maestro/drivers/WebDriver.kt` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:864` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (20 lines × 2) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:552— maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:552-571 | maestro-client/src/main/java/maestro/drivers/WebDriver.kt:451-470 — before extracting anything, compare `maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt` and `maestro-client/src/main/java/maestro/drivers/WebDriver.kt` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:552` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (19 lines × 2) maestro-client/src/main/java/maestro/Maestro.kt:416— maestro-client/src/main/java/maestro/Maestro.kt:416-434 | maestro-client/src/main/java/maestro/Maestro.kt:457-475 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `maestro-client/src/main/java/maestro/Maestro.kt:416` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `maestro-client/src/main/java/maestro/Maestro.kt:455` calls `runInterruptible`, `tryTakingScreenshot` and `maestro-client/src/main/java/maestro/Maestro.kt:414` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (16 lines × 5) maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:631— maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:631-646 | maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:662-677 | maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:693-708 | maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:724-739 | maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:755-770 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:631` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12–16 lines × 2) maestro-cli/src/main/java/maestro/cli/command/PrintHierarchyCommand.kt:203— maestro-cli/src/main/java/maestro/cli/command/PrintHierarchyCommand.kt:203-214 | maestro-cli/src/main/java/maestro/cli/mcp/tools/ViewHierarchyFormatters.kt:59-74 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `maestro-cli/src/main/java/maestro/cli/command/PrintHierarchyCommand.kt:203` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (13–15 lines × 7) maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:109— maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:109-123 | maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:181-195 | maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:630-644 | maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:661-675 | maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:692-706 | maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:754-768 | maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:797-809 — all 7 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:109` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:490— maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:490-504 | maestro-client/src/main/java/maestro/drivers/WebDriver.kt:373-387 — before extracting anything, compare `maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt` and `maestro-client/src/main/java/maestro/drivers/WebDriver.kt` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (11–12 lines × 2) maestro-client/src/main/java/maestro/device/DeviceService.kt:544— maestro-client/src/main/java/maestro/device/DeviceService.kt:544-555 | maestro-client/src/main/java/maestro/device/DeviceService.kt:593-603 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `maestro-client/src/main/java/maestro/device/DeviceService.kt:544` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:601— maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:601-612 | maestro-client/src/main/java/maestro/drivers/WebDriver.kt:505-516 — before extracting anything, compare `maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt` and `maestro-client/src/main/java/maestro/drivers/WebDriver.kt` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (10 lines × 4) REDACTED:400— REDACTED:400-409 | REDACTED:412-421 | REDACTED:424-433 | REDACTED:436-445 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (10 lines × 2) maestro-client/src/main/java/maestro/Filters.kt:62— maestro-client/src/main/java/maestro/Filters.kt:62-71 | maestro-client/src/main/java/maestro/Filters.kt:84-94 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `maestro-client/src/main/java/maestro/Filters.kt:62` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (9–10 lines × 2) maestro-client/src/main/java/maestro/device/DeviceService.kt:460— maestro-client/src/main/java/maestro/device/DeviceService.kt:460-468 | maestro-client/src/main/java/maestro/device/DeviceService.kt:472-481 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `maestro-client/src/main/java/maestro/device/DeviceService.kt:460` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (18 lines × 2) maestro-cli/src/main/java/maestro/cli/util/EnvUtils.kt:48— maestro-cli/src/main/java/maestro/cli/util/EnvUtils.kt:48-65 | maestro-client/src/main/java/maestro/device/util/EnvUtils.kt:15-32 — before extracting anything, compare `maestro-cli/src/main/java/maestro/cli/util/EnvUtils.kt` and `maestro-client/src/main/java/maestro/device/util/EnvUtils.kt` as WHOLE FILES: 97% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (6 lines × 2) maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:727— maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:727-732 | maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:1275-1280 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:727` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
P4 · Deployment & Rollback· No deployment automation · ×1
No deployment automation — No release automation was found in CI — neither a deploy stage (Helm/Kubernetes/compose manifests, an orchestrated rollout) nor a publish job that ships the built artifact. Releases appear to be run by hand, which is slower, less repeatable and harder to reverse.
Third-party script without Subresource Integrity maestro-cli/src/main/java/maestro/cli/report/HtmlAITestSuiteReporter.kt:71— `https://cdn.tailwindcss.com/3.4.5` is executed by this page with no Subresource Integrity. Whoever can answer that request — the CDN, anyone who compromises it, anyone on the network path — runs arbitrary script in this page's origin, with its session. 2 such include(s) across the repository's markup.
Interpolated log message defeats structured logging maestro-orchestra/src/main/kotlin/maestro/orchestra/debug/ArtifactsGenerator.kt:90— `warn` at line 90 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging maestro-orchestra/src/main/kotlin/maestro/orchestra/debug/ArtifactsGenerator.kt:224— `warn` at line 224 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging maestro-orchestra/src/main/kotlin/maestro/orchestra/debug/ArtifactsGenerator.kt:246— `warn` at line 246 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging maestro-orchestra/src/main/kotlin/maestro/orchestra/debug/ArtifactsGenerator.kt:271— `warn` at line 271 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging maestro-orchestra/src/main/kotlin/maestro/orchestra/debug/ArtifactsGenerator.kt:322— `warn` at line 322 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging maestro-orchestra/src/main/kotlin/maestro/orchestra/debug/ArtifactsGenerator.kt:329— `warn` at line 329 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging maestro-orchestra/src/main/kotlin/maestro/orchestra/debug/TestOutputWriter.kt:64— `error` at line 64 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:223— `warn` at line 223 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:289— `warn` at line 289 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:353— `info` at line 353 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:385— `info` at line 385 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:391— `info` at line 391 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:400— `error` at line 400 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:870— `info` at line 870 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:871— `info` at line 871 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:872— `info` at line 872 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:873— `info` at line 873 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:874— `info` at line 874 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:885— `warn` at line 885 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:1007— `error` at line 1007 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:1013— `error` at line 1013 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:1060— `error` at line 1060 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:1188— `info` at line 1188 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:1195— `info` at line 1195 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
Interpolated log message defeats structured logging maestro-orchestra/src/main/java/maestro/orchestra/workspace/WorkspaceExecutionPlanner.kt:179— `info` at line 179 is handed a message assembled at the call — a string template with `$…` values in it, a concatenation or `String.format` — through SLF4J, log4j 2 or kotlin-logging, so the logger receives one finished string: the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, log4j 2's JsonTemplateLayout, OpenTelemetry), or with kotlin-logging `logger.atInfo { message = "Order moved"; payload = mapOf("order_id" to orderId, "status" to status) }`. An exception goes last, as the throwable argument, not into the text.
Orphaned file maestro-client/src/main/java/maestro/utils/LocaleUtils.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file maestro-cli/src/main/java/maestro/cli/mcp/tools/DescribeCloudRunTool.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file maestro-ai/src/main/java/maestro/ai/DemoApp.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file maestro-cli/src/main/java/maestro/cli/insights/TestAnalysisManager.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file maestro-cli/src/main/java/maestro/cli/mcp/tools/GetCloudRunStatusTool.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file maestro-cli/src/main/java/maestro/cli/runner/resultview/PlainTextResultView.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file maestro-android/src/main/java/dev/mobile/maestro/receivers/LocaleSettingReceiver.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file maestro-cli/src/main/java/maestro/cli/auth/Auth.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file maestro-android/src/main/java/dev/mobile/maestro/input/MaestroInputMethodService.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file maestro-ai/src/main/java/maestro/ai/cloud/ApiClient.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file maestro-ai/src/main/java/maestro/ai/anthropic/Client.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file maestro-cli/src/main/java/maestro/cli/mcp/viewer/McpViewerDriver.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file maestro-ai/src/main/java/maestro/ai/openai/Client.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file maestro-client/src/main/java/maestro/utils/ScreenshotUtils.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file maestro-client/src/main/java/maestro/ViewHierarchy.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file maestro-client/src/main/java/maestro/mockserver/MockInteractor.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file maestro-web/src/main/kotlin/maestro/web/input/HtmlDateInputFormatter.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file maestro-cli/src/main/java/maestro/cli/mcp/tools/ListCloudDevicesTool.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file maestro-cli/src/main/java/maestro/cli/update/Updates.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file maestro-cli/src/main/java/maestro/cli/graphics/SkiaUtils.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file maestro-cli/src/main/java/maestro/cli/session/SessionStore.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlSetOrientation.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file maestro-utils/src/main/kotlin/Metrics.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file maestro-android/src/main/java/dev/mobile/maestro/handlers/LocaleSettingHandler.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Duplicated predicate maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:394— `attrs.containsKey("ignoreBoundsFiltering") && attrs["ignoreBoundsFiltering"] != null` appears character-identically in 2 files — maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt, maestro-client/src/main/java/maestro/drivers/WebDriver.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:385— `attrs.containsKey("resource-id") && attrs["resource-id"] != null` appears character-identically in 2 files — maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt, maestro-client/src/main/java/maestro/drivers/WebDriver.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:388— `attrs.containsKey("selected") && attrs["selected"] != null` appears character-identically in 2 files — maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt, maestro-client/src/main/java/maestro/drivers/WebDriver.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:391— `attrs.containsKey("synthetic") && attrs["synthetic"] != null` appears character-identically in 2 files — maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt, maestro-client/src/main/java/maestro/drivers/WebDriver.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate maestro-cli/src/main/java/maestro/cli/command/CloudCommand.kt:282— `configFile != null && configFile?.exists()?.not() == true` appears character-identically in 3 files — maestro-cli/src/main/java/maestro/cli/command/CloudCommand.kt, maestro-cli/src/main/java/maestro/cli/command/RecordCommand.kt, maestro-cli/src/main/java/maestro/cli/command/TestCommand.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:603— `element.isHtmlDateInput() && jsExecutor.inputHtmlDate(element, text)` appears character-identically in 2 files — maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt, maestro-client/src/main/java/maestro/drivers/WebDriver.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate maestro-orchestra-models/src/main/java/maestro/orchestra/Commands.kt:90— `elementSelector != null && direction != null` appears character-identically in 2 files — maestro-orchestra-models/src/main/java/maestro/orchestra/Commands.kt, maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate maestro-cli/src/main/java/maestro/cli/util/EnvUtils.kt:51— `p1.exitValue() == 0 && String(p1.inputStream.readBytes()).trim().isNotEmpty()` appears character-identically in 2 files — maestro-cli/src/main/java/maestro/cli/util/EnvUtils.kt, maestro-client/src/main/java/maestro/device/util/EnvUtils.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate maestro-cli/src/main/java/maestro/cli/util/EnvUtils.kt:57— `p2.exitValue() == 0 && String(p2.inputStream.readBytes()).trim().isNotEmpty()` appears character-identically in 2 files — maestro-cli/src/main/java/maestro/cli/util/EnvUtils.kt, maestro-client/src/main/java/maestro/device/util/EnvUtils.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:466— `point.x >= SYNTHETIC_COORDINATE_SPACE_OFFSET && point.y >= SYNTHETIC_COORDINATE_SPACE_OFFSET` appears character-identically in 2 files — maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt, maestro-client/src/main/java/maestro/drivers/WebDriver.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt:240— `point.y >= 0 && point.y.toLong() <= windowHeight` appears character-identically in 2 files — maestro-client/src/main/java/maestro/drivers/CdpWebDriver.kt, maestro-client/src/main/java/maestro/drivers/WebDriver.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate maestro-client/src/main/java/maestro/Maestro.kt:168— `startRelative != null && endRelative != null` appears character-identically in 3 files — maestro-client/src/main/java/maestro/Maestro.kt, maestro-orchestra-models/src/main/java/maestro/orchestra/Commands.kt, maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Silent fallback default in catch maestro-cli/src/main/java/maestro/cli/util/EnvUtils.kt:178— `runProcess` swallows every exception into `emptyList()` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the KDoc, and the row stops firing.
Silent fallback default in catch maestro-client/src/main/java/maestro/device/DeviceService.kt:344— `fetchAndroidAvdInfo` swallows every exception into `emptyList()` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the KDoc, and the row stops firing.
Silent fallback default in catch maestro-client/src/main/java/maestro/device/DeviceService.kt:393— `listIOSDevices` swallows every exception into `emptyList()` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the KDoc, and the row stops firing.
Silent fallback default in catch maestro-client/src/main/java/maestro/device/DeviceService.kt:415— `listIOSConnectedDevices` swallows every exception into `emptyList()` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the KDoc, and the row stops firing.
Silent fallback default in catch maestro-ios-driver/src/main/kotlin/xcuitest/crash/IOSCrashFileFinder.kt:163— `findFilesByBundleId` swallows every exception into `emptyList()` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the KDoc, and the row stops firing.
Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 7 significant file(s) lose their only recent owner: maestro-cli/src/main/java/maestro/cli/analytics/PostHogEvents.kt, maestro-cli/src/main/java/maestro/cli/analytics/AnalyticsStateManager.kt, maestro-orchestra-models/src/main/java/maestro/orchestra/util/NumericFields.kt, maestro-cli/src/main/java/maestro/cli/analytics/CommandArgsSanitizer.kt, maestro-orchestra/src/main/kotlin/maestro/orchestra/debug/StepArtifactNaming.kt, maestro-cli/src/main/java/maestro/cli/command/ListCloudDevicesCommand.kt, maestro-ios-driver/src/main/kotlin/util/Mp4DurationNormalizer.kt. Pair on, review, or document these before any departure.
Off-boarding risk: anonymized user #2 — If anonymized user #2 becomes unavailable, 5 significant file(s) lose their only recent owner: maestro-cli/mcp-viewer/src/main.tsx, maestro-cli/src/main/java/maestro/cli/mcp/viewer/McpViewerServer.kt, maestro-cli/mcp-viewer/src/demo.tsx, maestro-cli/src/main/java/maestro/cli/mcp/viewer/McpViewerOrchestra.kt, maestro-cli/src/main/java/maestro/cli/mcp/viewer/McpViewerEvents.kt. Pair on, review, or document these before any departure.
D16 · Bus Factor· Further sole-owners (lower concentration) · ×1
Further sole-owners (lower concentration) — 5 other contributor(s) are each the sole owner of a small amount of code below the off-boarding threshold — folded into the bus-factor score and metrics (17 single-owned of 157 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated, example/demo and scaffolding-template trees and test files identified by path convention, largest first; 157 of the 403 production source files in this repository met that bar). They are anonymized user #3 (1 file(s)), anonymized user #4 (1 file(s)), anonymized user #5 (1 file(s)), anonymized user #6 (1 file(s)), anonymized user #7 (1 file(s)) — spread or document their files in the same way, at lower priority than the named off-boarding risks above. The files folded here: maestro-cli/src/main/java/maestro/cli/graphics/SkiaFrameRenderer.kt, maestro-cli/src/main/java/maestro/cli/report/HtmlAITestSuiteReporter.kt, maestro-client/src/main/java/maestro/device/serialization/DeviceSpecSparseSerializer.kt, maestro-cli/src/main/java/maestro/cli/command/DownloadSamplesCommand.kt, maestro-client/src/main/java/maestro/DeviceUnreachableException.kt.
No ADRs found maestro-ios-xctest-runner/maestro-driver-ios.xcodeproj/project.pbxproj:1— No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`. ADRs are expected here because `maestro-ios-xctest-runner/maestro-driver-ios.xcodeproj/project.pbxproj` makes this repository a deployable product (line 1).
D21 · Naming Consistency· `windowContextID` spells `ID` where 92 names in the project spell it `Id` · ×1
`windowContextID` spells `ID` where 92 names in the project spell it `Id` maestro-ios-driver/src/main/kotlin/hierarchy/AXElement.kt:28— 92 of 94 names in project maestro-ios-driver spell the token `Id` (92 of 94; unit: names in project maestro-ios-driver containing `Id`). Peers: IOSDevice.deviceId (maestro-ios-driver/src/main/kotlin/device/IOSDevice.kt:31); SimctlIOSDevice.deviceId (maestro-ios-driver/src/main/kotlin/device/SimctlIOSDevice.kt:23); AssociatedDomainsRefresher.refresh(deviceId) (maestro-ios-driver/src/main/kotlin/util/AssociatedDomainsRefresher.kt:27); AssociatedDomainsRefresher.refresh(bundleId) (maestro-ios-driver/src/main/kotlin/util/AssociatedDomainsRefresher.kt:27); AssociatedDomainsRefresher.openAll(deviceId) (maestro-ios-driver/src/main/kotlin/util/AssociatedDomainsRefresher.kt:43). Rename to `windowContextId`. [rule N6]
D21 · Naming Consistency· `displayID` spells `ID` where 92 names in the project spell it `Id` · ×1
`displayID` spells `ID` where 92 names in the project spell it `Id` maestro-ios-driver/src/main/kotlin/hierarchy/AXElement.kt:31— 92 of 94 names in project maestro-ios-driver spell the token `Id` (92 of 94; unit: names in project maestro-ios-driver containing `Id`). Peers: IOSDevice.deviceId (maestro-ios-driver/src/main/kotlin/device/IOSDevice.kt:31); SimctlIOSDevice.deviceId (maestro-ios-driver/src/main/kotlin/device/SimctlIOSDevice.kt:23); AssociatedDomainsRefresher.refresh(deviceId) (maestro-ios-driver/src/main/kotlin/util/AssociatedDomainsRefresher.kt:27); AssociatedDomainsRefresher.refresh(bundleId) (maestro-ios-driver/src/main/kotlin/util/AssociatedDomainsRefresher.kt:27); AssociatedDomainsRefresher.openAll(deviceId) (maestro-ios-driver/src/main/kotlin/util/AssociatedDomainsRefresher.kt:43). Rename to `displayId`. [rule N6]
D26 · Project Cohesion· Projects may be oversized for their cohesion · ×1
Projects may be oversized for their cohesion — 3 of 13 project(s) overshoot their size bounds, lowering Project Cohesion to 5.5/10. The most over is `maestro-client` (10505 LoC, 392 module-visible types across 15 directories). Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.
D34 · Knowledge Freshness· Orphaned files with no living knowledge · ×1
Orphaned files with no living knowledge — 24 of 157 analysed file(s) have no living knowledge left — their last meaningful change has decayed away, so if one breaks, no one currently understands it (counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated, example/demo and scaffolding-template trees and test files identified by path convention, largest first; 157 of the 403 production source files in this repository met that bar). None is large enough to earn a read-through of its own, so this row stands in for the per-file rows rather than raising one each — most significant first: maestro-client/src/main/java/maestro/utils/LocaleUtils.kt, maestro-cli/src/main/java/maestro/cli/mcp/tools/DescribeCloudRunTool.kt, maestro-ai/src/main/java/maestro/ai/DemoApp.kt, maestro-cli/src/main/java/maestro/cli/insights/TestAnalysisManager.kt, maestro-cli/src/main/java/maestro/cli/mcp/tools/GetCloudRunStatusTool.kt, maestro-cli/src/main/java/maestro/cli/runner/resultview/PlainTextResultView.kt, maestro-android/src/main/java/dev/mobile/maestro/receivers/LocaleSettingReceiver.kt, maestro-cli/src/main/java/maestro/cli/auth/Auth.kt (and 16 more). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway.
No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
Logging is not universal — Only 7/8 runnable modules use logging (modules with no entry point or server are excluded — they are libraries a runnable module hosts). Silent: `maestro-ios-xctest-runner`.
No SAST REDACTED:34— No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 14 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
No dependency-update automation maestro-cli/mcp-viewer/package.json:12— `maestro-cli/mcp-viewer/package.json` declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices — including after an advisory is published against it. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per ecosystem the tree uses (or an enabled `renovate.json`), and gate pull requests with `actions/dependency-review-action`.
X2 · Cancellation propagation· Not all functions that make a request accept an AbortSignal or the coroutine's cancellation · ×1
Not all functions that make a request accept an AbortSignal or the coroutine's cancellation — Only 5/7 functions that make a cancellable request (fetch, axios, ky, ofetch, got, undici, node:http; Ktor, OkHttp newCall, URL streams) accept an AbortSignal or the coroutine's cancellation or pass one on, so a request keeps running after whatever wanted it has given up — a page navigated away from, a cancelled request, a shutdown, an expired deadline. Take a `signal` () and hand it to the request; in a Kotlin suspend function, make the request with a call that suspends — Ktor, OkHttp's `executeAsync()`, or a `suspendCancellableCoroutine` that cancels the `Call` — not a blocking `execute()`: `withContext(Dispatchers.IO)` moves the call off the caller's thread but does not make it cancellable; where nothing could ever cancel the call, omitting it is a deliberate choice — judge against how the function is used.
Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.
trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 8 file(s) — `maestro-cli/src/main/java/maestro/cli/mcp/tools/RunOnCloudTool.kt`, `maestro-client/src/main/java/maestro/ViewHierarchy.kt`, `REDACTED`, `maestro-client/src/main/java/maestro/drivers/WebDriver.kt`, `maestro-ios-driver/src/main/kotlin/util/AssociatedDomainsRefresher.kt`, … (+3 more) — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.
disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
Run 01a1d633-7dbd-702a-bc3f-4d9f69c6f7b7 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.
Issues: 107 · Warnings: 251 · Recommendations: 97 · Info: 335 — Appendix A · all findings · full markdown report.
Generated by the Canine Code Analyzer: deterministic code-health analysis. 13-11-2026 @ 18:37 UTC.
Downloadable artifacts
Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.