Public report of microsoft/FASTER, published 12 November 2026. It has the same score, grades and number of
findings as the full report. The details of security findings (where they are in the code, which known
vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive reportMeasured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.11.3). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey →
Signed and filed in the standard's public register, 12 November 2026, 02:32 UTC · Survey ID cd_29daf125672c4b81ae181d9192ac2740
microsoft/FASTER
Measured 12 November 2026, 02:32 UTC, at code version 332ea7d
Code coverage is not measured: No coverage collector is wired up.
Test reliability is not measured: No test run produced results.
Boundary Type-Coupling is not measured: Bounded contexts not declared.
CAI scoreWeak
CriticalWeakAdequateStrongExemplary
Down 1 since the last survey
The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.
A medium codebase: 78,137 lines of product code in 54 projects, tests not counted · Estimated rebuild effort: about 1.0 person-years · Weakest lens: Code Health, 35
Findings by how serious they are
91 critical906 serious161 minor
2 dimensions are left out of the score. For each one, we either couldn't measure it in this code, or found no evidence of the safeguard we look for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.
This survey was produced by
Canine Code Analyzer
Producer
Canine Development
Analyzer
Canine Code Analyzer engine 1.0.0
Measured
12 November 2026, 02:32 UTC
A measurement, not a certificate. The Code Assurance Index records a number
together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee
the code. The standard was written by Canine Development, which also builds the Canine Code Analyzer. It is open to any tool that
implements it, and today the Canine Code Analyzer is the only one that does.
The score is deterministic, which means the same code always gets the same score. We work it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸
68of 68 dimensions measured by tools.
1129of 1158 findings point to an exact file and line, so you can open each one in the code. The other 29 concern the repository as a whole, such as missing documentation.
68dimensions across 6 lenses, read from 78,137 lines of product code in 54 projects.
microsoft/FASTER falls short of our standard for production, held back most by its Code Health lens, the quality of the code itself. It scores 48 out of 100 and is rated Weak, and five of its 91 critical findings are security problems.
Code Health, at 35, is the weakest lens and counts most in the score. The best first step is removing the unread values, worth about 8 points. Adding type checking would lift Code Health itself, worth about 6 points. Raising Code Health to 70 would lift the score to about 59.
Two known security holes in the packages the code depends on can be used by attackers. One automatic update takes new releases before a bad one can be spotted, and fifty-one errors are caught and ignored, so failures can go unnoticed. Updating the vulnerable packages, setting a waiting period for automatic updates and handling or logging the ignored errors would close these risks. The password or key in the code and the password or key in the code's history need replacing, with the old ones switched off. The 19 warnings switched off for a whole file need narrowing to the lines that need them.
The product code is 78,137 lines, about €150,000 to rebuild.
A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.
How the score is built: what each lens counts forThe lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
If Code Health rose from 35 to 70, the lowest score rated Strong, the score would rise from 48 to about 59.
Code composition: what the lines of code are
Business logic 33%Supporting code 32%Tests 35%
New since the last survey: 189 findings
These 189 critical or serious findings weren't in the previous survey, on 23 October 2026. The first 100 are listed here, and the findings file in the download package lists them all.
Code Duplication · Edited copy of a member (81 corresponding lines) cs/remote/src/FASTER.server/BinaryServerSession.cs
Code Duplication · Edited copy of a member (138 corresponding lines) cs/src/core/Device/ManagedLocalStorageDevice.cs
Code Duplication · Edited copy of a member (97 corresponding lines) cs/src/core/FasterLog/FasterLogIterator.cs
Code Duplication · Edited copy of a member (58 corresponding lines) cs/src/core/Index/FASTER/Implementation/InternalDelete.cs
Code Duplication · Edited copy of a member (68 corresponding lines) cs/src/core/Allocator/BlittableScanIterator.cs
Code Duplication · Edited copy of a member (68 corresponding lines) cs/src/core/FasterLog/FasterLog.cs
Code Duplication · Edited copy of a member (40 corresponding lines) cs/src/core/Index/Recovery/Recovery.cs
Code Duplication · Edited copy of a member (46 corresponding lines) cs/src/core/Allocator/BlittableAllocator.cs
Code Duplication · Edited copy of a member (47 corresponding lines) cs/src/core/Allocator/AllocatorBase.cs
Code Duplication · Edited copy of a member (49 corresponding lines) cs/src/core/Device/LocalStorageDevice.cs
Code Duplication · Edited copy of a member (38 corresponding lines) cs/src/core/Index/Recovery/Recovery.cs
Code Duplication · Edited copy of a member (58 corresponding lines) cs/src/core/FasterLog/FasterLogIterator.cs
Code Duplication · Edited copy of a member (28 corresponding lines) cs/src/core/Index/Synchronization/HybridLogCheckpointTask.cs
Code Duplication · Edited copy of a member (24 corresponding lines) cs/remote/src/FASTER.server/Servers/GenericServer.cs
Code Duplication · Edited copy of a member (21 corresponding lines) cs/src/core/Allocator/AllocatorBase.cs
Code Duplication · Edited copy of a member (40 corresponding lines) cs/src/core/Device/ShardedStorageDevice.cs
Code Duplication · Edited copy of a member (20 corresponding lines) cs/src/devices/AzureStorageDevice/AzureStorageDevice.cs
Code Duplication · Edited copy of a member (26 corresponding lines) cs/src/core/Async/DeleteAsync.cs
Code Duplication · Edited copy of a member (21 corresponding lines) cs/src/core/Async/ReadAsync.cs
Code Duplication · Edited copy of a member (22 corresponding lines) cs/playground/CacheStoreConcurrent/Program.cs
Code Duplication · Edited copy of a member (27 corresponding lines) cs/src/core/Utilities/Utility.cs
Code Duplication · Edited copy of a member (48 corresponding lines) cs/src/core/Index/FASTER/Implementation/InternalRMW.cs
Code Duplication · Edited copy of a member (33 corresponding lines) cs/src/core/Index/FASTER/FASTERBase.cs
Code Duplication · Edited copy of a member (36 corresponding lines) cs/src/core/FasterLog/FasterLog.cs
Code Duplication · Edited copy of a member (33 corresponding lines) cs/src/core/Device/LocalStorageDevice.cs
Code Duplication · Edited copy of a member (23 corresponding lines) cs/src/core/VarLen/SpanByte.cs
Code Duplication · Edited copies of one member (3 members, 14+ corresponding lines) cs/stress/LongKeyTester.cs
Code Duplication · Edited copy of a member (35 corresponding lines) cs/src/core/Allocator/BlittableScanIterator.cs
Code Duplication · Edited copy of a member (27 corresponding lines) cs/src/core/FasterLog/FasterLog.cs
Code Duplication · Edited copy of a member (22 corresponding lines) cs/playground/AsyncStress/FasterWrapper.cs
Code Duplication · Edited copies of one member (3 members, 23+ corresponding lines) cs/playground/AsyncStress/SerializedFasterWrapper.cs
Code Duplication · Edited copy of a member (22 corresponding lines) cs/src/core/Index/Recovery/Recovery.cs
Code Duplication · Edited copy of a member (12 corresponding lines) cs/src/core/VarLen/MemoryVarLenStruct.cs
Code Duplication · Edited copy of a member (19 corresponding lines) cs/src/core/Index/FASTER/Implementation/InternalLock.cs
Code Duplication · Edited copy of a member (21 corresponding lines) cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs
Code Duplication · Edited copy of a member (27 corresponding lines) cs/src/core/FasterLog/FasterLog.cs
Code Duplication · Edited copy of a member (18 corresponding lines) cs/stress/SessionWrapper.cs
Code Duplication · Edited copy of a member (14 corresponding lines) cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs
Code Duplication · Edited copy of a member (23 corresponding lines) cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs
Code Duplication · Edited copy of a member (28 corresponding lines) cs/src/core/Index/FASTER/Implementation/InternalRMW.cs
Code Duplication · Edited copy of a member (8 corresponding lines) cs/remote/src/FASTER.client/MemoryParameterSerializer.cs
Code Duplication · Edited copy of a member (23 corresponding lines) cs/src/core/Allocator/AllocatorBase.cs
Code Duplication · Edited copy of a member (26 corresponding lines) cs/src/core/Allocator/WorkQueueFIFO.cs
Code Duplication · Edited copy of a member (12 corresponding lines) cs/playground/AsyncStress/FasterWrapper.cs
Code Duplication · Edited copy of a member (10 corresponding lines) cs/src/core/Allocator/BlittableAllocator.cs
Code Duplication · Edited copy of a member (9 corresponding lines) cs/src/core/Async/ReadAsync.cs
Code Duplication · Edited copy of a member (18 corresponding lines) cs/src/core/ClientSession/ClientSession.cs
Code Duplication · Edited copy of a member (21 corresponding lines) cs/src/core/FasterLog/FasterLog.cs
Code Duplication · Edited copy of a member (15 corresponding lines) cs/src/core/Index/Common/Contexts.cs
Code Duplication · Edited copies of one member (3 members, 22+ corresponding lines) cs/stress/LongValueTester.cs
Code Duplication · Edited copy of a member (8 corresponding lines) cs/playground/AsyncStress/FasterWrapper.cs
Code Duplication · Edited copy of a member (23 corresponding lines) cs/src/core/FasterLog/FasterLog.cs
Code Duplication · Edited copy of a member (25 corresponding lines) cs/src/core/Index/FASTER/LogAccessor.cs
Code Duplication · Edited copy of a member (11 corresponding lines) cs/src/core/Async/DeleteAsync.cs
Code Duplication · Edited copy of a member (10 corresponding lines) cs/src/core/Index/Recovery/Checkpoint.cs
Code Duplication · Edited copy of a member (11 corresponding lines) cs/src/core/Allocator/VarLenBlittableAllocator.cs
Code Duplication · Edited copy of a member (20 corresponding lines) cs/src/core/Index/Synchronization/FullCheckpointStateMachine.cs
Code Duplication · Edited copies of one member (3 members, 14+ corresponding lines) cs/stress/LongValueTester.cs
Code Duplication · Edited copy of a member (20 corresponding lines) cs/src/core/Allocator/WorkQueueFIFO.cs
Code Duplication · Edited copy of a member (15 corresponding lines) cs/src/core/FasterLog/FasterLogIterator.cs
Code Duplication · Edited copy of a member (8 corresponding lines) cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs
Code Duplication · Edited copies of one member (3 members, 6+ corresponding lines) cs/src/core/ClientSession/LockableContext.cs
Code Duplication · Edited copy of a member (5 corresponding lines) cs/src/core/ClientSession/LockableUnsafeContext.cs
Code Duplication · Edited copy of a member (18 corresponding lines) cs/src/core/Device/StorageDeviceBase.cs
Code Duplication · Edited copy of a member (16 corresponding lines) cs/remote/src/FASTER.client/ClientNetworkSession.cs
Code Duplication · Edited copy of a member (7 corresponding lines) cs/src/core/Async/ReadAsync.cs
Code Duplication · Edited copy of a member (12 corresponding lines) cs/src/core/FasterLog/FasterLog.cs
Code Duplication · Edited copies of one member (3 members, 8+ corresponding lines) cs/stress/LongValueTester.cs
Code Duplication · Edited copy of a member (9 corresponding lines) cs/src/core/Allocator/BlittableAllocator.cs
Code Duplication · Edited copy of a member (4 corresponding lines) cs/src/core/ClientSession/FASTERClientSession.cs
Code Duplication · Edited copy of a member (7 corresponding lines) cs/stress/LongValueTester.cs
Code Duplication · Edited copy of a member (5 corresponding lines) cs/src/core/ClientSession/LockableUnsafeContext.cs
Code Duplication · Edited copy of a member (9 corresponding lines) cs/src/core/Index/Recovery/Recovery.cs
Code Duplication · Edited copy of a member (7 corresponding lines) cs/src/core/Allocator/VarLenBlittableAllocator.cs
Code Duplication · Edited copy of a member (12 corresponding lines) cs/src/core/ClientSession/LockableContext.cs
Code Duplication · Edited copy of a member (12 corresponding lines) cs/src/core/ClientSession/LockableContext.cs
Code Duplication · Edited copy of a member (5 corresponding lines) cs/src/core/ClientSession/LockableUnsafeContext.cs
Code Duplication · Edited copy of a member (4 corresponding lines) cs/remote/src/FASTER.client/FasterKVClient.cs
Code Duplication · Edited copy of a member (17 corresponding lines) cs/src/core/Allocator/PendingFlushList.cs
Code Duplication · Edited copy of a member (8 corresponding lines) cs/stress/SessionWrapper.cs
Code Duplication · Edited copy of a member (13 corresponding lines) cs/src/core/Device/LocalStorageDevice.cs
Code Duplication · Edited copy of a member (8 corresponding lines) cs/remote/src/FASTER.client/ClientSessionAsync.cs
Code Duplication · Edited copy of a member (6 corresponding lines) cs/src/core/Async/ReadAsync.cs
Code Duplication · Edited copy of a member (14 corresponding lines) cs/src/core/ClientSession/LockableContext.cs
Code Duplication · Edited copy of a member (14 corresponding lines) cs/src/core/ClientSession/LockableContext.cs
Code Duplication · Edited copy of a member (5 corresponding lines) cs/src/core/ClientSession/LockableUnsafeContext.cs
Code Duplication · Edited copy of a member (15 corresponding lines) cs/src/core/Allocator/AtomicOwner.cs
Code Duplication · Edited copy of a member (17 corresponding lines) cs/src/core/FasterLog/FasterLog.cs
Code Duplication · Edited copy of a member (15 corresponding lines) cs/src/core/Device/ManagedLocalStorageDevice.cs
Code Duplication · Edited copy of a member (6 corresponding lines) cs/src/core/ClientSession/ClientSession.cs
Code Duplication · Edited copies of one member (3 members, 7+ corresponding lines) cs/stress/LongValueTester.cs
Code Duplication · Edited copy of a member (5 corresponding lines) cs/src/core/Async/UpsertAsync.cs
Code Duplication · Edited copy of a member (9 corresponding lines) cs/stress/StringKeyTester.cs
Code Duplication · Edited copy of a member (8 corresponding lines) cs/src/core/Allocator/BlittableAllocator.cs
Code Duplication · Edited copy of a member (6 corresponding lines) cs/src/core/Index/Recovery/IndexCheckpoint.cs
Code Duplication · Edited copies of one member (3 members, 6+ corresponding lines) cs/playground/AsyncStress/FasterWrapper.cs
Code Duplication · Edited copy of a member (8 corresponding lines) cs/src/core/Allocator/BlittableScanIterator.cs
Code Duplication · Edited copy of a member (5 corresponding lines) cs/src/core/Async/DeleteAsync.cs
Code Duplication · Edited copy of a member (4 corresponding lines) cs/src/core/ClientSession/LockableUnsafeContext.cs
Code Duplication · Edited copy of a member (3 corresponding lines) cs/src/core/Async/RMWAsync.cs
We compare every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.
Fixed since the last survey: 57 findings
These 57 critical or serious findings were in the previous survey, on 23 October 2026, and are gone from this one.
Code Coverage · Coverage not measured — no coverage collector is wired up
€48,000 to €250,000, for 804 to 2,602 hours of work, about 1.0 person-years for 1 to 2 engineers
Difficulty of the problem
Standard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor
×0.7 at a score of 48. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
Size
Medium: 78,137 lines of product code
Comment lines
The estimate prices 64,665 lines. Comment lines count towards the size of 78,137 lines but aren't priced as work.
What it is not
Not a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.
How the estimate is made: We price the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty.
Top priorities
The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.
1
Resolve the 10 WriteOnlyPrivateField finding(s) in Explicit Debt — start with SpanByteServerSerializer.cs (2), BlittableAllocator.cs (2), StorageErrorHandler.cs (2).
Raises the score by about 8 points · Medium effort · Explicit Debt
2
Resolve the 19 FileScopedPragmaDisable finding(s) in Explicit Debt — start with Program.cs (2), Input.cs, Key.cs.
Raises the score by about 8 points · Medium effort · Explicit Debt
3
Resolve the 51 EmptyCatchBlock finding(s) in Explicit Debt — start with FasterLog.cs (18), Program.cs (4), AllocatorBase.cs (3).
Raises the score by about 8 points · Medium effort · Explicit Debt
Diagnosis: what the measurements show together
Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.
Where the investment is most exposed · Value at risk
This code would cost about €150,000 to build again, about 1.0 person-years of work. Its weakest lens is Code Health, at 35 (Weak). Code Health is about how easy the code is to read and change safely, and code that is hard to read is slow and risky to change, so every future change costs more than it should. Because the weakest lens counts most in the score, work on Code Health also moves the score most.
Based on: the rebuild estimate · the Code Health grade · how much each lens counts
What to do: Start with the Code Health actions in Top priorities.
If you do one thing first · First action
Resolve the 10 WriteOnlyPrivateField finding(s) in Explicit Debt. Of all the actions in this report, it raises the score most for the work it takes: about 8 points for medium effort, because it clears the 10 Explicit Debt findings. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
Architecture — bounded-context dependency graph
Each box is a bounded context (its layer projects grouped, or a project count when large); arrows show dependencies between contexts. A shared kernel is where many arrows converge.
Architecture: which parts of the code depend on which
The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.
17 modules, with 9 dependencies between them. Every module uses only modules listed above it, so there are no loops.
Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
CacheStoreConcurrent uses FASTER.core, so a change to FASTER.core can break CacheStoreConcurrent, while a change to CacheStoreConcurrent can't break FASTER.core.
Position
Below the diagonal: CacheStoreConcurrent uses a module listed above it, which is the healthy direction.
ClassRecoveryDurablity uses FASTER.core, so a change to FASTER.core can break ClassRecoveryDurablity, while a change to ClassRecoveryDurablity can't break FASTER.core.
Position
Below the diagonal: ClassRecoveryDurablity uses a module listed above it, which is the healthy direction.
50 pairs of types, where a type in FASTER.server uses a type in FASTER.common. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
45 pairs of types, where a type in FASTER.server uses a type in FASTER.core. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).
OWASP category
Findings
Severity
A05:2025 — Injection
6
High / Critical
A03:2025 — Software Supply Chain Failures
6
High / Critical
A07:2025 — Authentication Failures
2
High / Critical
Roadmap
Top priorities: Resolve the 10 WriteOnlyPrivateField finding(s) in Explicit Debt — start with SpanByteServerSerializer.cs (2), BlittableAllocator.cs (2), StorageErrorHandler.cs (2); Resolve the 19 FileScopedPragmaDisable finding(s) in Explicit Debt — start with Program.cs (2), Input.cs, Key.cs; Resolve the 51 EmptyCatchBlock finding(s) in Explicit Debt — start with FasterLog.cs (18), Program.cs (4), AllocatorBase.cs (3).
Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.
Do this
Helps
Effort
Dimension
Resolve the 10 WriteOnlyPrivateField finding(s) in Explicit Debt — start with SpanByteServerSerializer.cs (2), BlittableAllocator.cs (2), StorageErrorHandler.cs (2).
Adopt TypeScript for the frontend: add a typecheck step to the build, then either type-check the existing JavaScript in place (`checkJs`/JSDoc types) or convert the highest-traffic modules first — no file is typed today, so this is an adoption, not a clean-up.
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Where a method uses `?.` on a symbol and then dereferences it directly, settle the question once: test it before the first use and handle null, or drop the `?.`.
Every finding carries one of four grades. Three say how serious it is. The fourth says this
survey could not settle it — and it is a grade, not a gap.
Critical — 91
A definite problem that already costs you something and drags the score down: a
missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here
tends to cause failures elsewhere.
Serious — 906
Likely wrong, but not failing yet. It degrades
the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to
carry for two years either.
Minor — 161
Recorded, with no effect on how the codebase functions.
Present so the survey is complete, not because it needs doing.
Could not be resolved — 2
Something this survey could not settle
from the outside, and which could be critical or serious. Either a control was required and no
positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves
nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean
result. These are excluded from the score rather than awarded a pass, so the number on the cover neither
rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each
one is named under Limitations.
Methodology & how to trust this report
This survey is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. All 68 evaluated dimensions are computed by tools and static analysis; no language model sets or judges any of them. Overall confidence is 0.9, the weighted average across measured dimensions.
Every figure here is one of two kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10.
What we checked — 68 dimensions across the health lenses
Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.
How to trust any code-health report — three questions
Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 1129 of 1158 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it: Roslyn, git or a scanner, not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.
This report answers yes to all three. That's the bar to hold any assessment to.
Tools & methods
The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.
Method
Backs
Version
Evaluator
Roslyn static analysis
Complexity, cohesion, coupling, dead code, API surface, layering
What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.
D4 Code Duplication — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The 180 duplicated block group(s) on this row were found in the languages this pass could tokenize, and they do NOT cover all of this repository's production source: .cc (20,188 lines, 26% of production source) went unread, because no language model this pass could load exposed a clone-unit token stream for those file kinds. Duplication in that source is UNMEASURED — its absence from the count above is a gap in this analyzer's language coverage, not a finding that the code is free of duplication.
D8 Code Coverage — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. Coverage NOT MEASURED: `--collect:"XPlat Code Coverage"` names a data collector that ships in the `coverlet.collector` package, and this repository wires up none — no test project references it and no runsettings declares one. The absence of coverage here is therefore not evidence about the suite or about our analyzer environment: without a collector, `--collect` produces nothing even from a suite that builds and passes. Add a `coverlet.collector` PackageReference to the test project(s) (or commit the Cobertura/OpenCover/lcov report your CI produces) and real coverage will be measured. It is excluded from the score rather than counted as a near-zero defect. You can widen what we reach: add the `coverlet.collector` package to the test projects to enable coverage (or commit the Cobertura/OpenCover/lcov report your CI produces).
D11 Test Reliability — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test reliability NOT MEASURED: the test run produced no results for any test tier, so no test ever ran and flakiness could not be exercised. The cause could not be attributed, so it is excluded from the score rather than read as an absence of tests.
D14 License Compliance — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This repository declares a Ruby Gemfile/Gemfile.lock or .gemspec (Bundler/RubyGems), but the licence verdict published here was taken over its NuGet package dependencies. Nothing was read about its Bundler dependencies' licensing in either direction, and a clean score on this card must not be read as covering them.
D17 Explicit Debt — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The 170 deducted marker(s) and the 1.9/KLoC density on this row were taken over this repository's .NET projects ALONE: .cc (20,188 lines, 26% of production source) went unread, because every marker collector on this path is reached through a C# workspace. D17's marker collectors need a compiler we do not have for that language, so none of its nine marker kinds were read there. The debt in that source is UNMEASURED — its absence from the score above is a gap in this analyzer's language coverage, not a finding that the code carries none.
D19 Documentation Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This kind did not reach the 95 % precision gate in three adjudicated runs (docs/plans/deterministic-engine/adjudication/D19-sample3-v3.md), so by the pre-registered fallback it publishes no row until a re-measurement shows it does. The candidates are counted here, not reported as findings, and the score does not include them.
D19 Documentation Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This kind did not reach the 95 % precision gate in three adjudicated runs (docs/plans/deterministic-engine/adjudication/D19-sample3-v3.md), so by the pre-registered fallback it publishes no row until a re-measurement shows it does. The candidates are counted here, not reported as findings, and the score does not include them.
D21 Naming Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D21's deterministic naming rules are gated on C# first (docs/plans/deterministic-engine.md, P5): each other language is switched on only after its own concept suite and A/B gate pass. Until then its declarations carry no naming verdict this run — this says nothing about whether its names are consistent.
D21 Naming Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
D21 Naming Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
D21 Naming Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
D22 Internal API Consistency — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. The loaded project set declares no packable project and no `.Contracts` project, so there is no intentionally-exposed surface for API consistency to be judged over.
D23 Boundary Type-Coupling — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Large codebase (57,439 production LoC in the .NET projects) with no declared bounded contexts — cross-boundary type coupling is unassessed Bounded contexts cannot be inferred from a codebase that is not physically organised by them (D-321), so with none declared there are no boundaries for the coupling pass to measure across. You can widen what we reach: name this codebase's bounded contexts (≥2 module groups, e.g. per subsystem) so cross-boundary type coupling can be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
D27 Navigability — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Tracing effort is measured over resolved call sites, and all 2567 sampled here came from .cs files. This repository's .cc source is a material share of its production lines and contributed none, so the score above is a verdict about the part that was read. Not a finding that the unread half navigates well — it is unmeasured.
D32 Data Compliance (PII/GDPR) — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `cs/src/core/Allocator/BlittableAllocator.cs`, `cs/src/core/Allocator/VarLenBlittableAllocator.cs`, `cs/src/core/VarLen/IVariableLengthStruct.cs` produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
AX6 Interface segregation — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This check's reader does not cover every language in this repository. The score describes the part it read, which is most of the product; the rest is a gap in this analyzer's language reach.
IC1 Incompleteness & stubs — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This check's reader does not cover every language in this repository. The score describes the part it read, which is most of the product; the rest is a gap in this analyzer's language reach.
P5 DR & Backup — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. No backup/snapshot/replication config, RTO/RPO or restore-procedure documentation was found — and no production persistence was detected either (no data-access packages, no data-store services, no database resources), so there is nothing in this repository whose loss a DR control would recover. If this system's data lives in a platform or ops repo we can't see, that's where the DR evidence belongs.
PF3 Async & latency hygiene — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 18 further occurrence(s) are not listed individually; the score already reflects all 58.
X1 Async correctness — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This check's reader does not cover every language in this repository. The score describes the part it read, which is most of the product; the rest is a gap in this analyzer's language reach.
X1 Async correctness — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 2 further occurrence(s) are not listed individually; the score already reflects all 42.
X12 Unreachable branch — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This check's reader does not cover every language in this repository. The score describes the part it read, which is most of the product; the rest is a gap in this analyzer's language reach.
X15 Unvalidated length from an untrusted reader — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This check's reader does not cover every language in this repository. The score describes the part it read, which is most of the product; the rest is a gap in this analyzer's language reach.
X16 Unfloored truncation loop — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This check's reader does not cover every language in this repository. The score describes the part it read, which is most of the product; the rest is a gap in this analyzer's language reach.
X18 Disposal-pattern correctness — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This check's reader does not cover every language in this repository. The score describes the part it read, which is most of the product; the rest is a gap in this analyzer's language reach.
X19 Unrestored process-global state — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This check's reader does not cover every language in this repository. The score describes the part it read, which is most of the product; the rest is a gap in this analyzer's language reach.
X2 Cancellation propagation — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This check's reader does not cover every language in this repository. The score describes the part it read, which is most of the product; the rest is a gap in this analyzer's language reach.
X2 Cancellation propagation — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 18 further occurrence(s) are not listed individually; the score already reflects all 58.
X22 Contradicted release guard — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This check's reader does not cover every language in this repository. The score describes the part it read, which is most of the product; the rest is a gap in this analyzer's language reach.
X25 Inert configuration knob — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This check's reader does not cover every language in this repository. The score describes the part it read, which is most of the product; the rest is a gap in this analyzer's language reach.
X27 Collection changed while being enumerated — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This check's reader does not cover every language in this repository. The score describes the part it read, which is most of the product; the rest is a gap in this analyzer's language reach.
X28 Index access outside its own emptiness guard — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This check's reader does not cover every language in this repository. The score describes the part it read, which is most of the product; the rest is a gap in this analyzer's language reach.
X29 Per-element action decided by a fixed element — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This check's reader does not cover every language in this repository. The score describes the part it read, which is most of the product; the rest is a gap in this analyzer's language reach.
X3 Exception handling — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This check's reader does not cover every language in this repository. The score describes the part it read, which is most of the product; the rest is a gap in this analyzer's language reach.
X3 Exception handling — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 12 further occurrence(s) are not listed individually; the score already reflects all 52.
X30 Support guard that admits what it rejects — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This check's reader does not cover every language in this repository. The score describes the part it read, which is most of the product; the rest is a gap in this analyzer's language reach.
X4 Structured logging — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This check's reader does not cover every language in this repository. The score describes the part it read, which is most of the product; the rest is a gap in this analyzer's language reach.
Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.
Limitations & what we did not check
We assess the repository exactly as committed, and only the repository. By design we do not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.
Per-dimension blind spots
For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.
D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
D12 Dependency Hygiene: Dependency health reads manifests and lockfiles — a vulnerability in a vendored/copied dependency, or risk from how a dependency is actually used, is outside this view.
D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
D18 Solution Shape: Build integrity reflects whether the solution compiled in this environment — a build that needs a private feed, a specific SDK, or a generated file absent from the repo can read as broken when it is merely unreproducible here.
D19 Documentation Quality: Documentation quality publishes two things only: a runnable or packaged unit with no example, and a multi-project root README that maps none of its parts. It does not judge clarity, and its other checks (overview, licence, boilerplate, structure, empty sections, XML-doc coverage) are withheld after adjudication: their candidates are counted in the card's gaps, not shown as rows. A false statement in a document is M4's; units are .NET projects only.
D24 Comment Value: Comment value is measured as redundancy only: a comment that repeats its code's words is found, but a paraphrase in other words, a vague comment, or one the code contradicts is not, and whether a comment is valuable is not claimed. Comments in other scripts or languages, and outside C#, are not judged.
D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.
What it measures: How tangled the control flow is — methods with many branches are hard to test and change.
Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.
+ 40 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 7 bodies over 30 down to 30 or less in Cyclomatic Complexity — start with WebsocketServerSession.ProcessBatch (cyclomatic 53), TestLoader.TestLoader.ctor (cyclomatic 39), GlobUtils.Match (cyclomatic 38). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 7 together lifts Cyclomatic Complexity from 6.7 to about 7.3/10, projected with the scoring formula itself and assuming each lands exactly at 30; a cleaner split scores higher.
Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How hard the code is for a person to follow, beyond raw branching.
Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.
+ 103 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 7 bodies over 60 down to 60 or less in Cognitive Complexity — start with GlobUtils.Match (cognitive 101), WebsocketServerSession.ProcessBatch (cognitive 91), FasterKV.ContinuePendingRead (cognitive 83). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 7 together lifts Cognitive Complexity from 5.7 to about 6.3/10, projected with the scoring formula itself and assuming each lands exactly at 60; a cleaner split scores higher.
Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D3 · God Classes8.6 / 10Strong✓ Tool-verified
What it measures: Over-large classes that try to do too much ("god classes").
Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.
Resolve the 15 TooManyMethods finding(s) in God Classes — start with ClientSession.cs (3), LockableContext.cs (2), FASTER.cs. — One of this dimension's main actionable groups (15 warning-level).
Resolve the 6 FileTooLong finding(s) in God Classes — start with FasterLog.cs, AllocatorBase.cs, ClientSession.cs. — One of this dimension's main actionable groups (6 warning-level).
Resolve the 4 MethodTooLong finding(s) in God Classes — start with WebsocketServerSession.cs, ClientSession.cs, GenericAllocator.cs. — One of this dimension's main actionable groups (4 warning-level).
Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Copy-pasted code that should be shared instead.
Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.
180 duplicated block group(s) detected. A further 477 rows report members as variants of one another; they aggregate block groups already counted above and are not themselves counted. 26 of the 657 are in trees this repository does not ship — vendored, example/demo, project-template, fixture and benchmark code — and are ranked below the shipped groups rather than excluded from them: the duplication there is real and is still counted in this dimension's score. The dimensions that publish a production-file census leave those trees out of theirs, so this count is deliberately drawn over the wider population. Measured on part of this repository only: .cc (26% of production source) was not exposed to the token comparison, so duplication there is unmeasured and is not in this count.
+ 107 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 20 Duplicated block (8 lines × 2) finding(s) in Code Duplication — start with SessionWrapper.cs (3), GenericAllocator.cs (3), BlittableAllocator.cs (2). — One of this dimension's main actionable groups (20 warning-level).
Resolve the 15 Edited copy of a member (4 corresponding lines) finding(s) in Code Duplication — start with LockableUnsafeContext.cs (8), ClientSession.cs (3), FASTERClientSession.cs. — One of this dimension's main actionable groups (15 warning-level).
Resolve the 11 Duplicated block (7 lines × 2) finding(s) in Code Duplication — start with GenericServer.cs (3), BlittableAllocator.cs (2), SubscribeKVBroker.cs. — One of this dimension's main actionable groups (11 warning-level).
Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D5 · Coupling9.9 / 10Stronggated by 1 serious finding✓ Tool-verified
What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.
Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.
Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.
Off the main sequence: FASTER.core(net7.0)cs/src/core/FASTER.core.csproj:1
What to do
Resolve the 1 Off the main sequence finding(s) in Coupling — start with FASTER.core.csproj. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether a class's methods are focused on a single responsibility.
Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.
Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.
D10 · Test Quality9.9 / 10Stronggated by 4 serious findings✓ Tool-verified
What it measures: Whether the tests truly assert behaviour rather than just running the code.
Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.
1 skipped (1 with a documented reason), 3 zero-assertion, 1 synchronised by a fixed sleep, no mocking-framework packages referenced (hand-written doubles or no mocking) across 351 tests.
No assertions: FasterLogShiftTailStressTest · ×3cs/test/LogShiftTailStressTest.cs:18
Resolve the 3 No assertions finding(s) in Test Quality — start with LogShiftTailStressTest.cs, OverflowBucketLockTableTests.cs, RecoverReadOnlyTest.cs. — One of this dimension's main actionable groups (3 warning-level).
Resolve the 1 Fixed-sleep synchronisation finding(s) in Test Quality — start with EnqueueAndWaitForCommit.cs. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d10_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether dependencies are current, not deprecated, and not bloated. Known vulnerabilities are D30's.
Method: Manifest scan via dotnet list package across all projects; worst-signal-per-package deduction (capped-linear for deprecation, prerelease and outdated) per KLoC. Known-vulnerable packages are D30's and are not charged here (rubric-2026.11.2). Exhaustive.
Resolve the 6 Outdated finding(s) in Dependency Hygiene — start with FixedLenServer.csproj (3), FASTER.core.csproj, FASTER.client.csproj. — One of this dimension's main actionable groups (6 recommendation-level).
Resolve the 2 Deprecated finding(s) in Dependency Hygiene — start with REDACTED, TstRunner.csproj. — One of this dimension's main actionable groups (2 warning-level).
Detailed fixes: d12_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.
Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.
What it measures: Whether the licenses of third-party packages are compatible with your policy.
Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.
0 of 176 packages use a banned license. ★ DEPTH: this repository's MSBuild projects declare 19 direct `PackageReference`(s), and 134 further package(s) were reached beyond them by closing the graph over nuget.org's own nuspec dependency graph — so a banned licence pulled in only by a dependency's OWN dependencies is inside this verdict. A package whose licence nuget.org could not be asked for is not graded, and version ranges are taken at their lower bound, so this is the closure as that graph states it rather than a restored consumer's exact resolution. ★ COVERAGE OF THIS VERDICT: it grades this repository's NuGet package dependencies and nothing else. The repository also declares a Ruby Gemfile/Gemfile.lock or .gemspec (Bundler/RubyGems), and the licences of those dependencies were NOT read by this pass — a gap in this engine's coverage, not a statement about them. So this result says the graded closure carries no banned licence; it does NOT say this repository's licensing is clear.
What it measures: Files that change often and are also complex — the riskiest hotspots.
Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.
What it measures: Whether knowledge is concentrated in too few people (the "bus factor").
Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.
7 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is cs/remote/src/FASTER.server/WebsocketServerSession.cs. Counted over 157 of the 282 production source files in this repository: 97 are under the ~2,400-byte size floor this dimension measures over, and the remaining 28 have no attributable history left to measure.
Off-boarding risk: anonymized user #1
✓ On the Gold path — maintain.
Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.
Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.
170 deducted debt markers + 56 dead symbols across 57439 LoC in the .NET projects (1.9/KLoC) → score 6.2. Measured on the .NET source only: .cc (26% of production source) was not read, and carries at least 0 uncounted task marker(s) in 0 file(s).
Dead code: numKeys · ×56cs/test/AdvancedLockTests.cs:207
+ 4 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 51 EmptyCatchBlock finding(s) in Explicit Debt — start with FasterLog.cs (18), Program.cs (4), AllocatorBase.cs (3). — One of this dimension's main actionable groups (51 issue-level).
Resolve the 19 FileScopedPragmaDisable finding(s) in Explicit Debt — start with Program.cs (2), Input.cs, Key.cs. — One of this dimension's main actionable groups (19 issue-level).
Resolve the 10 WriteOnlyPrivateField finding(s) in Explicit Debt — start with SpanByteServerSerializer.cs (2), BlittableAllocator.cs (2), StorageErrorHandler.cs (2). — One of this dimension's main actionable groups (10 issue-level).
Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the solution is laid out in a sensible, conventional structure.
Method: Solution structure: project count, decomposition, shell-project detection, build success (confirmed failures cap the score); traced to actual .sln files and binaries. Deterministic.
54 projects, 1305 source files, 81410 hand-written lines of code (57439 production / 23971 test — the split is derived per file: test is what its project, its own path, or a compile-guarded region marks as test, and a file carrying no test signal counts as production), 58 inter-project edges. Measured across 2 solutions loaded as one workspace: `cs/FASTER.sln`, `cs/remote/FASTER.remote.sln`.
What it measures: Whether the project's documentation is clear, complete, and useful.
Method: Every README, docs/ document and root guide parsed by its markup and measured in Unicode letters. Published: a runnable or packaged .NET project whose README (or a document it links, or a root guide) shows no example, and a root README naming none of three or more projects. Overview, licence, boilerplate, wall-of-text, empty-section and XML-doc rows are measured and withheld (counted in gaps) after adjudication. Deterministic, exhaustive, advisory.
1 of 2 documentation facets pass in full; short on: F2 example. 29 document(s) read across 13 unit(s).
Documentation: no build, run or usage exampleREADME.md:1
What to do
Resolve the 1 Documentation finding(s) in Documentation Quality — start with README.md. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d19_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether comments are worth it — explaining WHY (valuable) rather than WHAT (redundant).
Method: Every inline C# comment compared word by word with the identifiers, literals and constructs of the code it annotates (taken from the syntax); a comment whose words that code already contains is redundant, as are closing-brace labels and generator template text. Comments giving a reason or a reference are kept; other scripts and languages are not judged. Deterministic, exhaustive, advisory.
doc comments repeat the names · ×7cs/remote/src/FASTER.client/ClientSession.cs:53
What to do
Resolve the 29 redundant comment finding(s) in Comment Value — start with AssemblyInfo.cs (9), SimpleAsyncTests.cs (4), Recovery.cs (3). — One of this dimension's main actionable groups (29 recommendation-level).
Detailed fixes: d24_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.
Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps. C# also names each pass-through layer (a class whose every public method only forwards its own parameters to one collaborator) as a located finding; the score is not affected.
Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.
85 % of calls cross a namespace and 5 % go through an interface, but 100 % of collaborators are co-located — so a call's collaborators sit together and tracing stays easy. Baseline: large — vertical-slice locality expected. Measured over the .cs source only — this repository's .cc was not sampled for call sites, so this score covers part of the tree, not all of it.
What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.
Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.
What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.
Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.
Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).
6 finding(s): 0 critical, 1 high, 5 medium, 0 low. semgrep hit a parse error in 8 file(s) — `cc/src/core/faster.h` (line 1253, line 1362, line 1509, …), `cc/src/core/log_scan.h` (line 813), `cc/src/core/persistent_memory_malloc.h` (line 615), `cc/src/environment/file_windows.h` (line 35, line 39, line 48, …), `cc/src/index/mem_index.h` (line 151, line 1086, line 1087, …), … (+3 more) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them.
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
What to do
Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 2 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2). — One of this dimension's main actionable groups (2 warning-level).
Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.
Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05. Advisory since rubric-2026.11.2 (CAI decision 0006): every row is a match against a vulnerability database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.
3 finding(s): 0 critical, 2 high, 1 medium, 0 low. No known-vulnerable gem among the 10 declared gem(s) osv.dev was asked about. This repository commits no Gemfile.lock — which a published gem correctly does not — so osv-scanner had no resolved graph to read, and the question was put to osv.dev instead over the releases `bundle install` resolves this repository's 10 declared requirement(s) to. The verdict therefore covers the DIRECT declarations at their resolved releases, not the transitive graph a lock would close over.
REDACTED
REDACTED
What to do
Resolve the 2 High CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (2). — One of this dimension's main actionable groups (2 issue-level).
Resolve the 1 Medium CVE finding(s) in Dependency Vulnerabilities — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d30_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.
Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.
30 of 185 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is cs/stress/TestLoader.cs. Counted over 185 of the 282 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
Orphaned file · ×30cs/stress/TestLoader.cs:1
Orphaned files with no living knowledge
What to do
Resolve the 30 Orphaned file finding(s) in Knowledge Freshness — start with TestLoader.cs (2), Options.cs (2), ShardedStorageDevice.cs. — One of this dimension's main actionable groups (30 recommendation-level).
Resolve the 1 Orphaned files with no living knowledge finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.
Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.
Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.
What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.
Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.
What it measures: Whether the repository publishes a coordinated-vulnerability-disclosure policy (SECURITY.md or security.txt) with a reporting contact, so finders know how to report a vulnerability. Presence of a policy file with a contact, not whether the policy is adequate or honoured.
Method: Vulnerability-disclosure policy read deterministically from the repo: a SECURITY.md (root/.github/docs) or .well-known/security.txt / security.txt, regex-checked for a reporting contact (email / URL / mailto). Present + contact → 10; present without a contact → 4; NotApplicable when no policy file exists (it may live off-repo). Detects the policy file's presence + contact, not its adequacy.
What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Reported apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.
Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. Advisory since rubric-2026.11.2 (CAI decision 0006): the malicious-package feed is a database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.
No dependency in any ecosystem this repository declares is published as malicious. No known-vulnerable gem among the 10 declared gem(s) osv.dev was asked about. This repository commits no Gemfile.lock — which a published gem correctly does not — so osv-scanner had no resolved graph to read, and the question was put to osv.dev instead over the releases `bundle install` resolves this repository's 10 declared requirement(s) to. The verdict therefore covers the DIRECT declarations at their resolved releases, not the transitive graph a lock would close over.
What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.
Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.
2 end-of-life runtime(s) and 0 end-of-life framework(s), read from 37 platform declaration(s) and 10 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.
Resolve the 32 End-of-life runtime finding(s) in Platform End-of-Life — start with FASTER.benchmark.csproj (2), FASTER.remote.test.csproj, FASTER.test.csproj. — One of this dimension's main actionable groups (32 warning-level).
Detailed fixes: d44_recommendation.md · top locations in Appendix A, every location in findings.md.
Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does.
Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.
Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.
What to do
The domain core is a small share of production code, but most of the rest matched no layer vocabulary at all — so this is not yet an anemic-domain finding. The namespace/path convention could not place that code, which makes the composition above a statement about the naming, not about the design. Name the layers (or check that the repository's conventions differ from the ones this check knows) before reading a thin domain into it.
Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.
Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.
`FasterKV` is not registered, but `LongValueTester` creates it and keeps it in the static `fkv`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (systemState, maxSessionID, currentSyncStateMachine, callbacks; e.g. `systemState` at line 737). — cs/src/core/Async/AsyncOperationInternal.cs:13
`FasterLog` is not registered, but `Program` creates it and keeps it in the static `log`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (CommittedUntilAddress, CommittedBeginAddress, SafeTailAddress, commitNum, beginAddress, RecoveredIterators; e.g. `CommittedUntilAddress` at line 231). — cs/src/core/FasterLog/FasterLog.cs:21
`ManagedLocalStorageDevice` is not registered, but `Program` creates it and keeps it in the static `device`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (_disposed; e.g. `_disposed` at line 483). — cs/src/core/Device/ManagedLocalStorageDevice.cs:17
`GenericAllocator` is not registered, but the singleton `FasterKV` creates it and keeps it in `hlog`, so one instance outlives every request and is shared by every caller that reaches it — and it mutates instance state outside any lock (values; e.g. `values` at line 110). — cs/src/core/Allocator/GenericAllocator.cs:25
`DeviceLogCommitCheckpointManager` is not registered, but the singleton `FasterLog` creates it and keeps it in `logCommitManager`, so one instance outlives every request and is shared by every caller that reaches it — and it mutates instance state outside any lock (commitCount, flogCommitHistoryOffset, indexTokenHistoryOffset, logTokenHistoryOffset, bufferPool; e.g. `commitCount` at line 114). — cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs:17
`LightEpoch` is not registered, but the singleton `FasterLog` creates it and keeps it in `epoch`, so one instance outlives every request and is shared by every caller that reaches it — and it mutates instance state outside any lock (CurrentEpoch, SafeToReclaimEpoch; e.g. `CurrentEpoch` at line 164). — cs/src/core/Epochs/LightEpoch.cs:15
`WorkQueueLIFO` is not registered, but the singleton `FasterLog` creates it and keeps it in `commitQueue`, so one instance outlives every request and is shared by every caller that reaches it — and it mutates instance state outside any lock (_disposed; e.g. `_disposed` at line 35). — cs/src/core/Allocator/WorkQueueLIFO.cs:17
`LogSizeTracker` is not registered, but the singleton `CacheSizeTracker` creates it and keeps it in `mainLog`, so one instance outlives every request and is shared by every caller that reaches it — and it mutates instance state outside any lock (TargetSizeBytes; e.g. `TargetSizeBytes` at line 61). — cs/samples/ResizableCacheStore/LogSizeTracker.cs:10
`WorkQueueFIFO` is not registered, but the singleton `DeviceLogCommitCheckpointManager` creates it and keeps it in `deleteQueue`, so one instance outlives every request and is shared by every caller that reaches it — and it mutates instance state outside any lock (_disposed; e.g. `_disposed` at line 35). — cs/src/core/Allocator/WorkQueueFIFO.cs:17
`FasterSpanByteYcsbBenchmark` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (InitCount, TxnCount; e.g. `InitCount` at line 626). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — cs/benchmark/FasterSpanByteYcsbBenchmark.cs:15
`FASTER_YcsbBenchmark` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (InitCount, TxnCount; e.g. `InitCount` at line 589). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — cs/benchmark/FasterYcsbBenchmark.cs:15
`LongValueTester` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (fkv; e.g. `fkv` at line 36). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — cs/stress/LongValueTester.cs:9
`SpanByteKeyTester` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (keys; e.g. `keys` at line 89). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — cs/stress/SpanByteKeyTester.cs:35
`SpanByteValueTester` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (fkv, values; e.g. `fkv` at line 38). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — cs/stress/SpanByteValueTester.cs:9
`StringKeyTester` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (keys; e.g. `keys` at line 66). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — cs/stress/StringKeyTester.cs:8
`StringValueTester` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (fkv, values; e.g. `fkv` at line 38). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — cs/stress/StringValueTester.cs:9
`Native32` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (processPrivilegeEnabled; e.g. `processPrivilegeEnabled` at line 322). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — cs/src/core/Utilities/Native32.cs:16
What to do
Keep singletons stateless or back their state with thread-safe types (Concurrent*/Immutable*); otherwise concurrent callers race.
A `static` field is one slot for the whole process, however its type is created: back it with a thread-safe type (ConcurrentDictionary, Interlocked), take a lock around every write, or move it into a registered singleton that does.
Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).
Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.
Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.
Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.
Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.
Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.
Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').
Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.
`IFasterContext<Key, Value, Input, Output, Context>` declares 67 members: `CompletePending`, `CompletePendingWithOutputs`, `CompletePendingAsync`, `CompletePendingWithOutputsAsync`, `Read`, `Read`, `Read`, `Read`, `Read`, `Read`, `Read`, `Read`, `Read`, `Read`, `Read`, `ReadAtAddress`, `ReadAsync`, `ReadAsync`, `ReadAsync`, `ReadAsync`, `ReadAsync`, `ReadAsync`, `ReadAsync`, `ReadAsync`, `ReadAtAddressAsync`, `Upsert`, `Upsert`, `Upsert`, `Upsert`, `Upsert`, `Upsert`, `Upsert`, `Upsert`, `Upsert`, `Upsert`, `UpsertAsync`, `UpsertAsync`, `UpsertAsync`, `UpsertAsync`, `UpsertAsync`, and 27 more. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 67 declarations carry 16 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 16 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — cs/src/core/ClientSession/IFasterContext.cs:32
`ILockableContext<TKey>` declares 20 members under just 9 distinct name(s): `BeginLockable`, `EndLockable`, `NeedKeyHash`, `CompareKeyHashes`, `CompareKeyHashes`, `SortKeyHashes`, `SortKeyHashes`, `Lock`, `Lock`, `TryLock`, `TryLock`, `TryLock`, `TryLock`, `TryLock`, `TryLock`, `TryPromoteLock`, `TryPromoteLock`, `TryPromoteLock`, `Unlock`, `Unlock`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 20 separate responsibilities: a caller binds to 9 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 20 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — cs/src/core/ClientSession/ILockableContext.cs:13
`IDevice` declares 22 members: `SectorSize`, `FileName`, `Capacity`, `SegmentSize`, `StartSegment`, `EndSegment`, `ThrottleLimit`, `Initialize`, `TryComplete`, `Throttle`, `WriteAsync`, `ReadAsync`, `WriteAsync`, `ReadAsync`, `TruncateUntilAddressAsync`, `TruncateUntilAddress`, `TruncateUntilSegmentAsync`, `TruncateUntilSegment`, `RemoveSegmentAsync`, `RemoveSegment`, `GetFileSize`, `Reset`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 22 declarations carry 20 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 20 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — cs/src/core/Device/IDevice.cs:19
`IFasterKV<Key, Value>` declares 24 members: `NewSession`, `ResumeSession`, `ResumeSession`, `GrowIndex`, `TryInitiateFullCheckpoint`, `TakeFullCheckpointAsync`, `TryInitiateIndexCheckpoint`, `TakeIndexCheckpointAsync`, `TryInitiateHybridLogCheckpoint`, `TakeHybridLogCheckpointAsync`, `Recover`, `RecoverAsync`, `Recover`, `RecoverAsync`, `Recover`, `RecoverAsync`, `CompleteCheckpointAsync`, `Reset`, `EntryCount`, `IndexSize`, `Comparer`, `DumpDistribution`, `Log`, `ReadCache`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 24 declarations carry 19 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 19 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — cs/src/core/Index/Interfaces/IFasterKV.cs:13
`IFunctions<Key, Value, Input, Output, Context>` declares 23 members: `SingleReader`, `ConcurrentReader`, `ReadCompletionCallback`, `SingleWriter`, `PostSingleWriter`, `ConcurrentWriter`, `NeedInitialUpdate`, `InitialUpdater`, `PostInitialUpdater`, `NeedCopyUpdate`, `CopyUpdater`, `PostCopyUpdater`, `InPlaceUpdater`, `RMWCompletionCallback`, `SingleDeleter`, `PostSingleDeleter`, `ConcurrentDeleter`, `DisposeSingleWriter`, `DisposeCopyUpdater`, `DisposeInitialUpdater`, `DisposeSingleDeleter`, `DisposeDeserializedFromDisk`, `CheckpointCompletionCallback`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — cs/src/core/Index/Interfaces/IFunctions.cs:14
`ICheckpointManager` declares 17 members: `InitializeIndexCheckpoint`, `InitializeLogCheckpoint`, `CommitIndexCheckpoint`, `CommitLogCheckpoint`, `CheckpointVersionShift`, `CommitLogIncrementalCheckpoint`, `GetIndexCheckpointMetadata`, `GetLogCheckpointMetadata`, `GetIndexCheckpointTokens`, `GetLogCheckpointTokens`, `GetIndexDevice`, `GetSnapshotLogDevice`, `GetSnapshotObjectLogDevice`, `GetDeltaLogDevice`, `Purge`, `PurgeAll`, `OnRecovery`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — cs/src/core/Index/Recovery/ICheckpointManager.cs:31
What to do
Split fat interfaces into focused role-interfaces so clients depend only on what they use.
Where the width is an overload set rather than separate responsibilities, collapse the overloads instead — segregating those relieves no caller.
Do you agree with this assessment?
AX8 · Test isolation10.0 / 10Exemplary✓ Tool-verified
Other · Architecture — Whether production projects stay free of references to test projects — tests may depend on production, never the reverse.
Method: Csproj graph: each production project checked for references to test projects (identified by test-framework presence, not name). Zero violations is clean. Deterministic.
Other · Code Health — Unreviewed-generation residue: shipped members still throwing NotImplementedException, and placeholder string literals left in non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.
Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.
A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface. (×7) — cs/src/core/Device/LocalStorageDevice.cs:546, cs/src/core/Device/LocalStorageDevice.cs:548, cs/src/core/Device/LocalStorageDevice.cs:550, …
What to do
Finish or delete NotImplementedException stubs and replace placeholder literals before shipping.
Other · Code Health — Unfinished work detected by code SHAPE, not keywords: members that only throw a "not implemented" exception, methods that take inputs and return a constant, async methods that never await, dead `if (false)` / `#if false` branches, and skeleton types most of whose members are holes. A real, objective slice of technical debt.
Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.
The first 2 statements of the `if` and of the `else` are identical, so they run on both paths regardless of the condition. Lift them above the `if` — leaving them duplicated inside makes the branches read as though they handled this differently. — cs/remote/src/FASTER.client/ClientSession.cs:486
`SendResponse` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — cs/remote/src/FASTER.common/TcpNetworkSender.cs:157
`SendCallback` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — cs/remote/src/FASTER.common/TcpNetworkSender.cs:163
`IsDeleted` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. — cs/src/core/Compaction/ICompactionFunctions.cs:30
`SimpleAsyncResult` has 4 unfinished members out of 4 declared members (methods, properties, indexers and events, whether or not each carries a body) — a scaffolded type that was never implemented. — cs/src/core/Device/LocalStorageDevice.cs:539
`AsyncState` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — cs/src/core/Device/LocalStorageDevice.cs:546
`AsyncWaitHandle` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — cs/src/core/Device/LocalStorageDevice.cs:548
`CompletedSynchronously` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — cs/src/core/Device/LocalStorageDevice.cs:550
`IsCompleted` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — cs/src/core/Device/LocalStorageDevice.cs:552
`Compact` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — cs/src/core/Index/Recovery/Checkpoint.cs:93
A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers). (×15) — cs/playground/CacheStoreConcurrent/Program.cs:77, cs/playground/ClassRecoveryDurability/Program.cs:92, cs/playground/ClassRecoveryDurability/Program.cs:111, …
3 consecutive lines of code sit inside a `/* … */` block — a block of code switched off rather than removed, which rots and confuses. Delete it (version control remembers). — cs/playground/CacheStoreConcurrent/Program.cs:192
`GetKeyAddressInfo`'s body only throws NotSupportedException — sometimes a deliberate contract, often an unfinished stub. Confirm it's intentional. — cs/src/core/Allocator/VarLenBlittableAllocator.cs:276
`GetValueAddressInfo`'s body only throws NotSupportedException — sometimes a deliberate contract, often an unfinished stub. Confirm it's intentional. — cs/src/core/Allocator/VarLenBlittableAllocator.cs:281
11 consecutive lines of code sit inside a `/* … */` block — a block of code switched off rather than removed, which rots and confuses. Delete it (version control remembers). — cs/src/core/Device/LocalStorageDevice.cs:498
A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something. — cs/test/MemoryLogCompactionTests.cs:42
What to do
Finish or delete the unfinished stubs (NotImplementedException / empty / constant-returning bodies) — they are dead surface that looks live.
Clear the softer debt: remove commented-out code and dead branches, re-enable or delete skipped tests, and replace blanket warning suppressions with targeted ones.
Maturity · Maturity — Whether the repository and its projects have a README, and whether it is substantive.
Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.
This repository declares its own end of life: `README.md` line 8 reads “> **This repository is no longer actively maintained.**”. That is a first-party statement of intent, not an inference — the Maturity and Knowledge lenses otherwise approximate the same fact from decayed commit history (D16 reports a dormant codebase, D34 orphaned files), and this row says the maintainer already told you. It does NOT change any score: an honest end-of-life notice is the README doing its job, and every dimension below still measures the code as it stands. Read the whole report as an assessment of software the author has stopped working on. — README.md:8
What to do
Add a build/run (quick start) section to the root README — the first thing a newcomer needs.
Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
Describe the projects a newcomer cannot place from the root README: 29 of 31 have no README of their own, in their folder or in their family's project (`cs/src/core`, `cs/src/devices/AzureStorageDevice`, `cs/playground/ClassRecoveryDurability`, `cs/samples/HelloWorld`, `cs/samples/StoreCustomTypes` and 24 more).
Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.
Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.
No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.
What to do
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Add a C4 context/container diagram (Structurizr, PlantUML or Mermaid) or an architecture.md overview.
Maturity · Maturity — Whether the repository is organised deliberately: production code and tests are set apart in a way its ecosystem or the repository itself declares.
Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.
For more than a log file, an `ActivitySource`/`EventSource` the user can switch on gives you a structured trace to attach to a bug report. A health-check endpoint does not apply here: nothing orchestrates or load-balances a binary the user launches.
Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).
Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.
No static application security testing detected. For this repository's stack, add CodeQL's csharp pack, or a .NET security analyzer package (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 2 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
`REDACTED` schedules updates, but no `package-ecosystem` entry covers `bundler`, which this tree depends on — so those dependencies get no update pull requests and no advisory pressure, however complete the dep-scan credit looks. Add the missing entry to the `updates:` list. — REDACTED:12
What to do
Add a SAST step to CI running what this repository's stack ships: CodeQL's csharp pack, or a .NET security analyzer package — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
Dependabot is configured but does not watch `bundler` — add that `package-ecosystem` entry to REDACTED so those dependencies get the same automatic update and advisory pressure as the ones it already covers.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.
Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.
No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
What to do
Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.
Readiness · Performance — Whether the code protects its performance with benchmarks — a benchmark suite, allocation/memory measurement, and (ideally) a CI gate. Presence is credited as a bonus, never a deduction.
Method: Repo + source scan: BenchmarkDotNet referenced (csproj/source), [Benchmark]/[MemoryDiagnoser] attribute counts, and a benchmark step in CI; off .NET, the same ladder over Go testing.B, Rust criterion/#[bench]/divan, JMH/kotlinx-benchmark, pytest-benchmark/asv/pyperf, tinybench/mitata/vitest bench/benchmark.js and Swift package-benchmark — scored as a bonus ladder (absence is neutral, never a deduction). Deterministic, presence detection.
A BenchmarkDotNet suite exists but no [MemoryDiagnoser] — allocations (the main way hot code pressures the GC) aren't being measured.
What to do
Add [MemoryDiagnoser] to the benchmarks so allocation regressions are visible, not just time.
Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.
Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from each language's code model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.
57 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
`.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). (×11) — cs/benchmark/FasterSpanByteYcsbBenchmark.cs:416, cs/benchmark/FasterYcsbBenchmark.cs:380, cs/benchmark/TestLoader.cs:388, …
`waiter.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). (×8) — cs/benchmark/FasterSpanByteYcsbBenchmark.cs:107, cs/benchmark/FasterSpanByteYcsbBenchmark.cs:224, cs/benchmark/FasterSpanByteYcsbBenchmark.cs:458, …
`completionEvent.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). (×4) — cs/src/core/Allocator/AllocatorBase.cs:921, cs/src/core/Device/StorageDeviceBase.cs:203, cs/src/core/Device/StorageDeviceBase.cs:272, …
`flushEvent.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). (×4) — cs/src/core/Allocator/AllocatorBase.cs:1545, cs/src/core/Async/AsyncOperationInternal.cs:107, cs/src/core/FasterLog/FasterLog.cs:832, …
`handle.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). — cs/src/core/Allocator/GenericAllocator.cs:414
`syncEvent.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). — cs/src/core/Allocator/MallocFixedPageSize.cs:39
`handleAvailable.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). — cs/src/core/Device/AsyncPool.cs:118
`.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). (×8) — cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs:274, cs/src/core/Utilities/PageAsyncResultTypes.cs:95, cs/src/devices/AzureStorageDevice/AzureStorageDevice.cs:112, …
`NextLeaseRenewalTask.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). — cs/src/devices/AzureStorageDevice/BlobManager.cs:154
What to do
Make the call chain async end-to-end and await it — never block on a Task with .Wait()/.GetAwaiter().GetResult().
Do you agree with this assessment?
R1 · Type Safety0.0 / 10Critical✓ Tool-verified
React / JS · Code Health — How much of the frontend is typed TypeScript vs untyped JavaScript.
Method: Frontend file inventory: the share of typed TypeScript vs untyped JavaScript across the source tree. Deterministic, exhaustive over frontend files.
0 typed · 7 plain JS — the untyped files are cs/remote/src/FASTER.client/JavascriptClient/BatchHeader.js, cs/remote/src/FASTER.client/JavascriptClient/CallbackFunctionsBase.js, REDACTED, REDACTED, cs/remote/src/FASTER.client/JavascriptClient/ParameterSerializer.js, cs/remote/src/FASTER.client/JavascriptClient/Queue.js (+1 more).
What to do
Adopt TypeScript for the frontend: add a typecheck step to the build, then either type-check the existing JavaScript in place (`checkJs`/JSDoc types) or convert the highest-traffic modules first — no file is typed today, so this is an adoption, not a clean-up.
React / JS · Code Health — Near-exact copy-pasted blocks of substantial extent across the frontend (the D4 clone algorithm over JS/TS tokens, D-386): a block is reported only where its copies still agree on most of their own identifiers and literals, or were renamed as they were pasted but kept most of their constants, and where the copies carry enough code to stand on their own or the copied extent reaches 30 lines — so a re-implementation sharing neither names nor values, and a small pasted declaration, are both found and deliberately not reported, and a clean R10 is not a claim that nothing was copied.
Method: Near-exact copy-pasted blocks of substantial extent across the frontend (the D4 clone algorithm run over JS/TS tokens). Masking finds the candidates; a block is reported when its copies still agree on most of their own identifiers and literals, or when a renamed copy still agrees on most of its constants, AND the copies carry enough code to stand on their own — or when the copied extent reaches 30 lines. So a re-implementation sharing neither names nor values, and a small pasted declaration, are deliberately not counted. Deterministic.
REDACTED:70 · REDACTED:88 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — REDACTED:70
REDACTED:190 · REDACTED:237 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. — REDACTED:190
REDACTED:132 · REDACTED:142 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — REDACTED:132
REDACTED:200 · REDACTED:215 · REDACTED:247 · REDACTED:262 — all 4 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — REDACTED:200
REDACTED:62 · REDACTED:80 · REDACTED:98 — all 3 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — REDACTED:62
What to do
Act on each finding's own remediation rather than one rule: the move depends on what recurs. Where the copies are executable blocks, give the shared part one home and call it from each site; where they are declarations, a listing, a specialisation already delegating to its base, or one shape repeated per entity, there is no call site and the move is a shared type, a generated set or a factory — sometimes there is nothing to extract.
React / JS · Code Health — Per-function cyclomatic/cognitive complexity from the token-level function scanner (D-386) — real branching, not a regex heuristic.
Method: Per-function cyclomatic/cognitive complexity from a token-level function scanner (real branching, not a regex heuristic), computed over every frontend function. Deterministic.
ProcessReplies has cyclomatic complexity 20 and cognitive complexity 26; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — REDACTED:21
Do you agree with this assessment?
R3 · Large Files10.0 / 10Exemplary✓ Tool-verified
React / JS · Code Health — How many source files exceed the large-file threshold.
Method: Components/modules exceeding the large-file threshold, counted exhaustively across the frontend source tree. Deterministic.
React / JS · Architecture — Import cycles in the module graph (D-386) — files that can only be understood and changed together.
Method: Import cycles in the module graph, detected exhaustively over JS/TS imports (the same cycle detection as the .NET coupling dimension). Deterministic.
Other · Security — Cryptographic hygiene (weak hash/cipher, password key-derivation). This codebase has no web surface, so transport/header/cookie/CSRF controls are N/A and only crypto is scored.
Method: Roslyn plus filesystem scan: HSTS/security headers, secure cookies, input validation, middleware order, weak crypto (MD5/SHA1/DES); HTTPS-metadata context-aware. On a repository with no .NET source it reads JavaScript/TypeScript, Dart, Ruby, Scala, Rust or Elixir source itself (test, vendored, generated and minified paths not) for the arms that hold whether or not the code serves HTTP: a weak hash or cipher, key material fixed in the source, a TLS client that accepts any certificate, and (JavaScript/TypeScript, Ruby, Scala, Rust and Elixir) an obsolete TLS version; the server controls are not assessed there, and a Dart, Ruby, Scala, Rust or Elixir repository that serves no HTTP of its own is N/A on them. Deterministic.
MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses. — cs/remote/src/FASTER.server/WebsocketServerSession.cs:314
What to do
Review each MD5/SHA1 use by what it protects: replace it with SHA-256+ (or a KDF for passwords) where the digest is security-relevant, and switch it to a non-cryptographic hash (`System.IO.Hashing.XxHash64`/`Crc32`) where it only derives an identifier such as a cache key or a mutex name.
Do you agree with this assessment?
X1 · Async correctness4.4 / 10Weak✓ Tool-verified
Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.
Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.
Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process. (×31) — cs/benchmark/FasterSpanByteYcsbBenchmark.cs:416, cs/benchmark/FasterYcsbBenchmark.cs:380, cs/benchmark/TestLoader.cs:388, …
`FasterLogScanIterator.ScanForwardForCommit` is a synchronous helper that blocks (`CountdownEvent.Wait`): called from an `async` method it parks the thread exactly as the inline call would. Make the helper `async` and `await` it (`await Task.Delay`, `SemaphoreSlim.WaitAsync`, a `TaskCompletionSource` instead of the poll). — cs/src/core/FasterLog/FasterLog.cs:2454
`FasterLogScanIterator.GetNext` is a synchronous helper that blocks (`CountdownEvent.Wait`): called from an `async` method it parks the thread exactly as the inline call would. Make the helper `async` and `await` it (`await Task.Delay`, `SemaphoreSlim.WaitAsync`, a `TaskCompletionSource` instead of the poll). (×2) — cs/src/core/FasterLog/FasterLogIterator.cs:84, cs/src/core/FasterLog/FasterLogIterator.cs:106
`FasterLogScanIterator.TryConsumeNext` is a synchronous helper that blocks (`CountdownEvent.Wait`): called from an `async` method it parks the thread exactly as the inline call would. Make the helper `async` and `await` it (`await Task.Delay`, `SemaphoreSlim.WaitAsync`, a `TaskCompletionSource` instead of the poll). — cs/src/core/FasterLog/FasterLogIterator.cs:126
`FasterLogScanIterator.TryBulkConsumeNext` is a synchronous helper that blocks (`CountdownEvent.Wait`): called from an `async` method it parks the thread exactly as the inline call would. Make the helper `async` and `await` it (`await Task.Delay`, `SemaphoreSlim.WaitAsync`, a `TaskCompletionSource` instead of the poll). — cs/src/core/FasterLog/FasterLogIterator.cs:147
`HybridLogCheckpointInfo.Dispose` is a synchronous helper that blocks (`CountdownEvent.Wait`): called from an `async` method it parks the thread exactly as the inline call would. Make the helper `async` and `await` it (`await Task.Delay`, `SemaphoreSlim.WaitAsync`, a `TaskCompletionSource` instead of the poll). — cs/src/core/Index/FASTER/FASTER.cs:563
`FasterKV.DoPostRecovery` is a synchronous helper that blocks (`CountdownEvent.Wait`): called from an `async` method it parks the thread exactly as the inline call would. Make the helper `async` and `await` it (`await Task.Delay`, `SemaphoreSlim.WaitAsync`, a `TaskCompletionSource` instead of the poll). — cs/src/core/Index/Recovery/Recovery.cs:497
Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback. — cs/src/devices/AzureStorageDevice/AzureStorageDevice.cs:311
`Thread.Sleep` parks the thread for the whole delay: no other work runs on it, and under load the pool must grow to make up for it. `await Task.Delay(…)` suspends only this method. — cs/samples/FasterLogPubSub/Program.cs:123
Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.
Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X15 · Unvalidated length from an untrusted reader2.0 / 10Critical✓ Tool-verified
Other · Security — Whether a length read out of the stream being parsed is bounded before it is allocated or read — an unchecked count taken from the input lets the input choose the allocation.
Method: Roslyn syntax + semantics: integer lengths read from a BinaryReader and spent on a bulk read or an array allocation, checked for any comparison or bounding call on the value anywhere in the method. Deterministic, provable per finding. Advisory.
`len` is read from the stream being parsed at line 108 (`ReadInt32`), then read in bulk from that same stream at line 109 — and nowhere in this method is `len` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). A file the caller did not write therefore chooses the size directly: a value near `int.MaxValue` allocates until the process dies, and a value that overflows the cast to `int` goes negative and throws out of a parser whose failure path was written for malformed input, not for hostile input. Bound `len` against the bytes actually remaining in the stream before spending it. — cs/src/core/FasterLog/FasterLogRecoveryInfo.cs:109
`count` is read from the stream being parsed at line 24 (`ReadInt32`), then read in bulk from that same stream at line 25 — and nowhere in this method is `count` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). A file the caller did not write therefore chooses the size directly: a value near `int.MaxValue` allocates until the process dies, and a value that overflows the cast to `int` goes negative and throws out of a parser whose failure path was written for malformed input, not for hostile input. Bound `count` against the bytes actually remaining in the stream before spending it. — cs/src/core/Index/Interfaces/DataContractObjectSerializer.cs:25
`size` is read from the stream being parsed at line 38 (`ReadInt32`), then read in bulk from that same stream at line 39 — and nowhere in this method is `size` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). A file the caller did not write therefore chooses the size directly: a value near `int.MaxValue` allocates until the process dies, and a value that overflows the cast to `int` goes negative and throws out of a parser whose failure path was written for malformed input, not for hostile input. Bound `size` against the bytes actually remaining in the stream before spending it. — cs/samples/ResizableCacheStore/Types.cs:39
`size` is read from the stream being parsed at line 74 (`ReadInt32`), then read in bulk from that same stream at line 75 — and nowhere in this method is `size` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). A file the caller did not write therefore chooses the size directly: a value near `int.MaxValue` allocates until the process dies, and a value that overflows the cast to `int` goes negative and throws out of a parser whose failure path was written for malformed input, not for hostile input. Bound `size` against the bytes actually remaining in the stream before spending it. — cs/samples/ResizableCacheStore/Types.cs:75
What to do
Each finding names the read that takes the length from the input and the site that spends it, and states that the value is never compared in between. Confirm from the two, then bound the length against the remaining stream before using it.
Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.
Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.
Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.
`ctsBackground` is a `CancellationTokenSource`, which implements `IDisposable`, and it is created here (line 58). Every use of it in `Main` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var ctsBackground = …;`), which releases it at the end of the scope on every path including a throw. — cs/stress/StressApp.cs:58
`parser` is a `Parser`, which implements `IDisposable`, and it is created here (line 24). Every use of it in `TestLoader` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var parser = …;`), which releases it at the end of the scope on every path including a throw. — cs/stress/TestLoader.cs:24
`AllocatorBase` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `notifyFlushedUntilAddressSemaphore` itself (line 1833), which makes that instance its own. But `notifyFlushedUntilAddressSemaphore` is named in none of the methods the disposal search covered: `Dispose` (line 1182) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`notifyFlushedUntilAddressSemaphore?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — cs/src/core/Allocator/AllocatorBase.cs:1833
`MallocFixedPageSize` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `checkpointSemaphore` itself (line 94), which makes that instance its own. But `checkpointSemaphore` is named in none of the methods the disposal search covered: `Dispose` (line 357) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`checkpointSemaphore?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — cs/src/core/Allocator/MallocFixedPageSize.cs:94
`completionEvent` is a `ManualResetEventSlim`, which implements `IDisposable`, and it is created here (line 195). Every use of it in `RemoveSegment` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var completionEvent = …;`), which releases it at the end of the scope on every path including a throw. — cs/src/core/Device/StorageDeviceBase.cs:195
`DeviceLogCommitCheckpointManager` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `semaphore` itself (line 32), which makes that instance its own. But `semaphore` is named in none of the methods the disposal search covered: `Dispose` (line 140) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`semaphore?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs:32
`DeviceLogCommitCheckpointManager` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `deleteQueue` itself (line 45), which makes that instance its own. But `deleteQueue` is named in none of the methods the disposal search covered: `Dispose` (line 140) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`deleteQueue?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs:45
`completedSemaphore` is a `SemaphoreSlim` this type creates itself, and here (line 388) a new instance is written over it — but `FlushAsync` itself reads through `completedSemaphore` before replacing it, so it expects an instance to be there, and nothing earlier in `FlushAsync` disposes, closes, saves or hands on the instance being replaced. The assignment makes it unreachable while it still holds what it holds (a timer that keeps firing, a callback registered on a longer-lived token, a socket, a handle), and no later `Dispose` can reach it: the type's own disposal releases only the CURRENT instance. The cost accumulates once per overwrite. Release the previous instance first (`completedSemaphore?.Dispose();` before the assignment), or swap it out with `Interlocked.Exchange` and dispose what comes back. — cs/src/core/Index/Recovery/DeltaLog.cs:388
`hasher` (line 24) holds a `HashAlgorithm` that `Worker` acquires itself — every assignment to it is a call that opens or creates a new instance for the caller to own — and nothing in `Worker` ever releases it: the type is not `IDisposable`, declares no `Dispose`, and every other mention of `hasher` only reads through it, so it is never disposed, closed, returned or handed on. Whatever it opened (a connection, a channel, a file) stays open until finalization if the type has a finalizer and until the process ends if it does not, once per instance of `Worker`. Implement `IDisposable` and release `hasher` there, or take the instance from the caller so its owner ends it. — cs/samples/EpvsSample/EpvsBench.cs:24
`loggerFactory` is a `ILoggerFactory`, which implements `IDisposable`, and it is created here (line 30). Every use of it in `Main` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var loggerFactory = …;`), which releases it at the end of the scope on every path including a throw. — cs/remote/samples/VarLenServer/Program.cs:30
`loggerFactory` is a `ILoggerFactory`, which implements `IDisposable`, and it is created here (line 32). Every use of it in `Main` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var loggerFactory = …;`), which releases it at the end of the scope on every path including a throw. — cs/remote/samples/FixedLenServer/Program.cs:32
What to do
Each finding names the value and the span that decides who owns it — the `new` that created it, or the constructor parameter that handed it over. Confirm ownership from that span, then make the disposal match it: release what this type created, leave what it was injected with to whoever created THAT, and drop a finalizer whose type holds nothing unmanaged to release.
Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.
Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether async methods accept a CancellationToken so work can be cancelled (adoption curve).
Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.
Only 73/130 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
No CancellationToken parameter — this work can't be stopped early once started. (×28) — cs/stress/LongValueTester.cs:50, cs/stress/SessionWrapper.cs:72, cs/stress/SessionWrapper.cs:110, …
Queues or hands on an async lambda whose work calls something that takes a CancellationToken, while neither this method nor the delegate supplies one — that work can't be stopped early once started. Take a CancellationToken here and let the lambda capture it, or use a delegate that is handed one (`Func<CancellationToken, Task>`). (×3) — cs/src/core/Device/ManagedLocalStorageDevice.cs:192, cs/src/core/Device/ManagedLocalStorageDevice.cs:354, cs/src/core/FasterLog/LogCommitPolicy.cs:173
No CancellationToken parameter — the body observes an ambient token instead (a field or a context object), so the work does stop on cancellation, but a caller cannot cancel this call independently of the owner that created that token. (×8) — cs/src/devices/AzureStorageDevice/AzureStorageDevice.cs:156, cs/src/devices/AzureStorageDevice/AzureStorageDevice.cs:398, cs/src/devices/AzureStorageDevice/AzureStorageDevice.cs:513, …
What to do
Thread a CancellationToken through async methods so work stops promptly on cancellation.
Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `ArgumentNullException` tells the caller a parameter was null when it provably was not.
Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements controlled by an `if`, whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`). Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back. Also whether a `finally` that gives the primitive back unconditionally can run in a state where the method does not hold it: after a timed wait whose result was discarded, after an acquire inside the `try` that can fail, after the body already released it, or never, because a `return` left between the acquire and the `try`.
Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.
Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a `foreach` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is enumerating invalidates the enumerator it is holding, so the next `MoveNext` throws `InvalidOperationException` and the remaining items are never seen.
Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.
Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.
Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.
Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.
An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. (×34) — cs/src/core/Allocator/AllocatorBase.cs:2336, cs/src/core/Allocator/AllocatorBase.cs:2355, cs/src/core/Allocator/AllocatorBase.cs:2425, …
An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: record it through whatever this codebase already uses to report problems — or, if one specific failure truly cannot matter, catch exactly that exception type and say why in a comment on the catch (a comment on a catch-all still swallows everything else). (×3) — cs/src/core/Allocator/ScanIteratorBase.cs:251, cs/src/core/FasterLog/FasterLogSettings.cs:174, cs/src/core/Index/Common/FasterKVSettings.cs:191
`catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch. (×3) — cs/src/core/Index/Recovery/Recovery.cs:275, cs/src/core/Index/Recovery/Recovery.cs:296, cs/src/core/Index/Recovery/Recovery.cs:383
What to do
Swallowed exception (empty catch)
Do you agree with this assessment?
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.
Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.
Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `package.json` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.
Other · Code Health — Whether nullable reference types are enabled and not undermined by heavy `!` suppression.
Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.
This method contradicts itself about `uContext`: line 227 assigns it with `as IUnsafeContext`, which hands back null rather than throwing when the value is not a `IUnsafeContext`, but line 229 then dereferences it directly as `uContext.BeginUnsafe` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `uContext` once before the first use and handle the null case, or cast with `(IUnsafeContext)` so the failure is reported where it happens — rather than leaving the two readings side by side. — cs/stress/TestLoader.cs:229
This method contradicts itself about `uContext`: line 252 assigns it with `as IUnsafeContext`, which hands back null rather than throwing when the value is not a `IUnsafeContext`, but line 254 then dereferences it directly as `uContext.BeginUnsafe` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `uContext` once before the first use and handle the null case, or cast with `(IUnsafeContext)` so the failure is reported where it happens — rather than leaving the two readings side by side. — cs/stress/TestLoader.cs:254
2/30 NRT-eligible project(s) enable <Nullable>enable</Nullable> (projects targeting a pre-C#-8 framework are excluded — NRTs aren't available there). NRTs catch a whole class of null-deref bugs at compile time.
~1.4 `!` suppressions per 1k syntax nodes — 5 suppression(s) across the 3516 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide. Many are correct: each is a claim the checker could not verify, and it is wrong only where the value can in fact be missing, so review the densest places first.
What to do
Where a method uses `?.` on a symbol and then dereferences it directly, settle the question once: test it before the first use and handle null, or drop the `?.`.
Enable <Nullable>enable</Nullable> across all projects and resolve warnings rather than suppressing with `!`.
Do you agree with this assessment?
Reference — by lens
The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.
Unscored — 4 check(s) recorded observations but carry no score
These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.
P12 CI test-gate honesty — 1 observation(s) recorded · Reported, not scored — this card publishes what the CI gate does with the test inventory rather than grading it. The findings above are its output.
SC1 Supply-chain hygiene — 1 observation(s) recorded · Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X10 Duplicated predicate — 25 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
X7 Silent fallback defaults — 8 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 2 control(s) we could not find positive evidence for
These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.
P4 Deployment & Rollback — not evidenced — no deploy/rollback/approval signal in the repo; absence of evidence is not evidence of a manual release
P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 54 check(s) not relevant to this codebase
These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.
AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
AX1 Captive dependencies — no DI registrations detected
AX7 Slice cohesion — not applicable — not a vertical-slice architecture
AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
AXB1 Runtime evidence locked — no reproducible boot — This repository has nothing the runtime tiers could boot or serve — no markup, no UI framework or web-server dependency, no UI component source, no native UI project and no API definition — nothing here is a surface to boot — so runtime a11y/egress/header evidence has no subject here. Not applicable: this is neither a gap in the scan nor a finding about your code.
AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
C1 Data Protection — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
C2 Access Controls — No access-control surface detected in the analyzed source — no web/app surface to authorize (no HTTP API or web-UI project) and no authorization code at all (no [Authorize]/policies, no imperative guard methods). Access control is therefore N/A here — this is a library/CLI, which is authorized by its CALLER, not by itself. If this codebase grows request handlers, the dimension reactivates and a default-deny posture is expected then.
C3 Audit Trail — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
C4 Data Retention — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
C5 Data-Subject Rights — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
D11 Test Reliability — Test reliability not measured — no test run produced results
D20 ADR Quality — N/A — ADRs are expected on deployable products with a user-facing host, not consumed libraries; no ADR log is required here.
D21 Naming Consistency — Naming consistency is measured on C# and TypeScript only; JavaScript, html not measured.
D22 Internal API Consistency — No intentionally-exposed public API to evaluate for consistency.
D23 Boundary Type-Coupling — Cross-context type coupling could not be assessed — this codebase's bounded contexts are neither declared nor inferable.
D25 ADR Conformance — no ADRs to check
D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
D32 Data Compliance (PII/GDPR) — 3 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D7 Architectural Integrity — no checkable ADRs and no dependency cycles — architectural integrity not assessed
D8 Code Coverage — Coverage not measured — no coverage collector is wired up
DM1 Domain Modelling — not scored — this repository shows none of the 3 signals this lens looks for
ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
M4 Documentation accuracy — Not applicable: the 29 current-state document(s) make no claim of a kind M4 checks. 1 claim(s) of kinds M4 does not check were not checked (environment variable 1); M4 checks only links and versions and artefact counts.
P7 Outbound HTTP resilience — not applicable — this isn't a service/API/worker
P8 Schema migrations — no EF Core usage detected
P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (Cobertura — `dotnet test --collect:"XPlat Code Coverage"` with a `coverlet.collector` PackageReference) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures, or wire coverage collection into CI, to enable this cross-layer check
PF2 Allocation hygiene — Not scored: this check counted allocation-aware idioms (Span, pools, stackalloc) per line, which describes what kind of code a repository is rather than whether it has an allocation problem, so it was withdrawn. Nothing here is a finding about your code.
R11 Import Boundaries — No recognizable feature-sliced/layered src layout — boundary rules not applicable.
R4 Test Coverage — the JS/TS workspace (7 production file(s)) has no JavaScript/TypeScript test, but it is 0.88% of this repository's production source and the other 99.12% carries 23,982 line(s) of test code this pass cannot read — an incidental frontend's reachability is not the repository's test posture, so it is not scored as one
R5 Dependency Freshness — no package-lock.json — dependency freshness not measured (would require an npm lockfile); JS/npm CVEs are scored in D30 (Dependency Vulnerabilities), which answers every ecosystem
R6 Tooling — no package.json in the repository — test/lint/typecheck wiring is read from package.json scripts (corroborated against CI), so this project's own toolchain isn't measured here
R7 Dead Code — Not measured — no application, tooling or test entry point was detected, so no file can be shown to be reachable or unreachable. Declare an entry (package.json main/module/exports, src/index.*, or an index.html script) to enable reachability.
R8 Dependency Hygiene — Not measured — no package.json declares any dependency, so there is nothing to check imports against (imports may resolve through a host runtime rather than node).
X13 Undrained process stream — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X14 Bypassable address classification — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X17 Uncapped recursion over a caller-supplied document — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X21 Side-effecting pattern guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X23 Unguarded diagnostic materialisation — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X24 Document value interpolated into markup unescaped — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X26 Unsynchronised callback handoff — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X32 Type resolved by simple name across every loaded assembly — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
Appendix A — Findings (grouped)
The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.
EmptyCatchBlock cs/performance/BenchmarkDotNet/InliningTests.cs:63— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock cs/performance/BenchmarkDotNet/SyncVsAsyncTests.cs:79— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock cs/playground/MemoryDb/Program.cs:35— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock cs/remote/src/FASTER.server/Providers/FasterKVProviderBase.cs:60— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock cs/remote/src/FASTER.server/Servers/FasterServerTcp.cs:63— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock cs/remote/src/FASTER.server/Servers/FasterServerTcp.cs:66— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock cs/remote/src/FASTER.server/Servers/GenericServer.cs:56— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock cs/remote/src/FASTER.server/Servers/GenericServer.cs:136— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock cs/remote/src/FASTER.server/Servers/VarLenServer.cs:120— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock cs/samples/CacheStore/Program.cs:96— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock cs/samples/FasterLogPubSub/Program.cs:68— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock cs/samples/ReadAddress/VersionedReadApp.cs:73— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock cs/samples/StoreCustomTypes/Program.cs:94— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock cs/src/core/Allocator/AllocatorBase.cs:2336— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock cs/src/core/Allocator/AllocatorBase.cs:2355— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock cs/src/core/Allocator/AllocatorBase.cs:2425— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock cs/src/core/Allocator/ScanIteratorBase.cs:251— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock cs/src/core/Allocator/WorkQueueFIFO.cs:89— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock cs/src/core/Allocator/WorkQueueLIFO.cs:89— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock cs/src/core/Device/ManagedLocalStorageDevice.cs:449— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock cs/src/core/FasterLog/FasterLog.cs:219— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock cs/src/core/FasterLog/FasterLog.cs:1003— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock cs/src/core/FasterLog/FasterLog.cs:1038— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock cs/src/core/FasterLog/FasterLog.cs:1073— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock cs/src/core/FasterLog/FasterLog.cs:1110— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
FileScopedPragmaDisable cs/benchmark/Input.cs:4— #pragma warning disable 1591 — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable cs/benchmark/Key.cs:4— #pragma warning disable 1591 — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable cs/benchmark/KeySpanByte.cs:4— #pragma warning disable 1591 — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable cs/benchmark/Output.cs:4— #pragma warning disable 1591 — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable cs/benchmark/Value.cs:4— #pragma warning disable 1591 — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable cs/src/core/Index/Common/AddressInfo.cs:4— #pragma warning disable 1591 — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable cs/src/core/Index/Interfaces/FunctionsBase.cs:4— #pragma warning disable 1591 — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable cs/remote/benchmark/FASTER.benchmark/FasterYcsbBenchmark.cs:4— #pragma warning disable 0162 — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable cs/samples/StoreDiskReadBenchmark/Program.cs:4— #pragma warning disable 0162 — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable cs/src/core/Allocator/MallocFixedPageSize.cs:4— #pragma warning disable 0162 — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable cs/src/core/FasterLog/CommitFailureException.cs:4— #pragma warning disable 0162 — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable cs/src/core/FasterLog/CommitInfo.cs:4— #pragma warning disable 0162 — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable cs/src/core/Index/FASTER/Extensions.cs:4— #pragma warning disable 0162 — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable cs/samples/ResizableCacheStore/Program.cs:11— #pragma warning disable CS0162 // Unreachable code detected — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable cs/samples/StoreVarLenTypes/AsciiSumSample.cs:8— #pragma warning disable CS0162 // Unreachable code detected — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable cs/src/core/Allocator/BlittableAllocator.cs:11— #pragma warning disable CS1591 // Missing XML comment for publicly visible type or member — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable cs/src/core/Allocator/GenericAllocator.cs:13— #pragma warning disable CS1591 // Missing XML comment for publicly visible type or member — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable cs/src/core/Allocator/VarLenBlittableAllocator.cs:13— #pragma warning disable CS1591 // Missing XML comment for publicly visible type or member — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable cs/src/core/Index/Common/RecordInfo.cs:4— #pragma warning disable CS1591 // Missing XML comment for publicly visible type or member — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
WriteOnlyPrivateField cs/remote/src/FASTER.server/SpanByteServerSerializer.cs:22— private int keyLength — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField cs/remote/src/FASTER.server/SpanByteServerSerializer.cs:23— private int valueLength — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField cs/samples/ResizableCacheStore/LogSizeTracker.cs:14— private string name — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField cs/src/core/Allocator/BlittableAllocator.cs:28— private int recordInfoSize — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField cs/src/core/Allocator/BlittableAllocator.cs:30— private int valueSize — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField cs/src/core/ClientSession/ClientSession.cs:46— private ILoggerFactory loggerFactory — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField cs/src/devices/AzureStorageDevice/StorageErrorHandler.cs:18— private string account — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField cs/src/devices/AzureStorageDevice/StorageErrorHandler.cs:19— private string taskHub — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField cs/stress/SpanByteValueTester.cs:14— private int tid — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField cs/stress/StringValueTester.cs:14— private int tid — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
NoWarnInCsproj cs/test/FASTER.test.csproj:41— 1701 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj cs/remote/test/FASTER.remote.test/FASTER.remote.test.csproj:41— 1701 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj cs/test/FASTER.test.csproj:41— 1702 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj cs/remote/test/FASTER.remote.test/FASTER.remote.test.csproj:41— 1702 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj cs/test/FASTER.test.csproj:41— 1591 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj cs/remote/test/FASTER.remote.test/FASTER.remote.test.csproj:41— 1591 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
Dead code: numKeys cs/test/AdvancedLockTests.cs:207— Field numKeys — Roslyn's SymbolFinder walked every project the solution loads, including FASTER.test(net7.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: NoValue cs/test/ExpirationTests.cs:21— Field NoValue — Roslyn's SymbolFinder walked every project the solution loads, including FASTER.test(net7.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: TestValue cs/test/ExpirationTests.cs:25— Property TestValue — Roslyn's SymbolFinder walked every project the solution loads, including FASTER.test(net7.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: VerifyValue cs/test/ExpirationTests.cs:151— Method VerifyValue — Roslyn's SymbolFinder walked every project the solution loads, including FASTER.test(net7.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: FormatTime cs/test/LogFormatter.cs:24— Method FormatTime — Roslyn's SymbolFinder walked every project the solution loads, including FASTER.test(net7.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: RecoverAndReadTest cs/test/RecoveryTests.cs:457— Method RecoverAndReadTest — Roslyn's SymbolFinder walked every project the solution loads, including FASTER.test(net7.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: RecoverAndReadTest cs/test/RecoveryTests.cs:475— Method RecoverAndReadTest — Roslyn's SymbolFinder walked every project the solution loads, including FASTER.test(net7.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: RecoverAndReadTest cs/test/RecoveryTests.cs:504— Method RecoverAndReadTest — Roslyn's SymbolFinder walked every project the solution loads, including FASTER.test(net7.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: numRecords cs/test/SpanByteLogScanTests.cs:17— Field numRecords — Roslyn's SymbolFinder walked every project the solution loads, including FASTER.test(net7.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: PMMFlushStatus cs/src/core/Allocator/AllocatorBase.cs:16— NamedType PMMFlushStatus — Roslyn's SymbolFinder walked every project the solution loads, including FASTER.core(net7.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: PMMCloseStatus cs/src/core/Allocator/AllocatorBase.cs:18— NamedType PMMCloseStatus — Roslyn's SymbolFinder walked every project the solution loads, including FASTER.core(net7.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: VerifyPage cs/src/core/Allocator/AllocatorBase.cs:652— Method VerifyPage — Roslyn's SymbolFinder walked every project the solution loads, including FASTER.core(net7.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: DebugPrintAddresses cs/src/core/Allocator/AllocatorBase.cs:1699— Method DebugPrintAddresses — Roslyn's SymbolFinder walked every project the solution loads, including FASTER.core(net7.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: PrettyPrint cs/src/core/Allocator/AllocatorBase.cs:2448— Method PrettyPrint — Roslyn's SymbolFinder walked every project the solution loads, including FASTER.core(net7.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: AtomicOwner cs/src/core/Allocator/AtomicOwner.cs:9— NamedType AtomicOwner — Roslyn's SymbolFinder walked every project the solution loads, including FASTER.core(net7.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: PopulatePageFrame cs/src/core/Allocator/GenericAllocator.cs:1080— Method PopulatePageFrame — Roslyn's SymbolFinder walked every project the solution loads, including FASTER.core(net7.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: KeySize cs/src/core/Allocator/VarLenBlittableAllocator.cs:155— Method KeySize — Roslyn's SymbolFinder walked every project the solution loads, including FASTER.core(net7.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: CurrentState cs/src/core/Epochs/EpochProtectedVersionScheme.cs:271— Method CurrentState — Roslyn's SymbolFinder walked every project the solution loads, including FASTER.core(net7.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: FastThreadLocal cs/src/core/Epochs/FastThreadLocal.cs:13— NamedType FastThreadLocal — Roslyn's SymbolFinder walked every project the solution loads, including FASTER.core(net7.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: GetChecksum cs/src/core/FasterLog/FasterLog.cs:2835— Method GetChecksum — Roslyn's SymbolFinder walked every project the solution loads, including FASTER.core(net7.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: MaxParallel cs/src/core/FasterLog/LogCommitPolicy.cs:59— Method MaxParallel — Roslyn's SymbolFinder walked every project the solution loads, including FASTER.core(net7.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: RateLimit cs/src/core/FasterLog/LogCommitPolicy.cs:73— Method RateLimit — Roslyn's SymbolFinder walked every project the solution loads, including FASTER.core(net7.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: NullNamedDeviceFactory cs/src/core/Index/CheckpointManagement/NullNamedDeviceFactory.cs:11— NamedType NullNamedDeviceFactory — Roslyn's SymbolFinder walked every project the solution loads, including FASTER.core(net7.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: DetachKey cs/src/core/Index/Common/Contexts.cs:189— Method DetachKey — Roslyn's SymbolFinder walked every project the solution loads, including FASTER.core(net7.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: DetachInput cs/src/core/Index/Common/Contexts.cs:197— Method DetachInput — Roslyn's SymbolFinder walked every project the solution loads, including FASTER.core(net7.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
DeadPreprocessorBranch cs/benchmark/ConcurrentDictionaryBenchmark.cs:55— #if DASHBOARD — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch cs/benchmark/ConcurrentDictionaryBenchmark.cs:98— #if DASHBOARD — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch cs/benchmark/ConcurrentDictionaryBenchmark.cs:140— #if DASHBOARD — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch cs/benchmark/ConcurrentDictionaryBenchmark.cs:169— #if DASHBOARD — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch cs/benchmark/ConcurrentDictionaryBenchmark.cs:240— #if DASHBOARD — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch cs/benchmark/ConcurrentDictionaryBenchmark.cs:263— #if DASHBOARD — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch cs/benchmark/ConcurrentDictionaryBenchmark.cs:282— #if DASHBOARD — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch cs/benchmark/ConcurrentDictionaryBenchmark.cs:299— #if DASHBOARD — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch cs/benchmark/FasterSpanByteYcsbBenchmark.cs:60— #if DASHBOARD — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch cs/benchmark/FasterSpanByteYcsbBenchmark.cs:123— #if DASHBOARD — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch cs/benchmark/FasterSpanByteYcsbBenchmark.cs:177— #if DASHBOARD — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch cs/benchmark/FasterSpanByteYcsbBenchmark.cs:205— #if DASHBOARD — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch cs/benchmark/FasterSpanByteYcsbBenchmark.cs:240— #if DASHBOARD — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch cs/benchmark/FasterSpanByteYcsbBenchmark.cs:291— #if DASHBOARD — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch cs/benchmark/FasterSpanByteYcsbBenchmark.cs:313— #if DASHBOARD — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch cs/benchmark/FasterSpanByteYcsbBenchmark.cs:323— #if DASHBOARD — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch cs/benchmark/FasterSpanByteYcsbBenchmark.cs:436— #if DASHBOARD — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch cs/benchmark/FasterSpanByteYcsbBenchmark.cs:464— #if DASHBOARD — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch cs/benchmark/FasterSpanByteYcsbBenchmark.cs:494— #if DASHBOARD — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch cs/benchmark/FasterSpanByteYcsbBenchmark.cs:558— #if DASHBOARD — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch cs/benchmark/FasterYcsbBenchmark.cs:57— #if DASHBOARD — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch cs/benchmark/FasterYcsbBenchmark.cs:119— #if DASHBOARD — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch cs/benchmark/FasterYcsbBenchmark.cs:173— #if DASHBOARD — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch cs/benchmark/FasterYcsbBenchmark.cs:201— #if DASHBOARD — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch cs/benchmark/FasterYcsbBenchmark.cs:288— #if DASHBOARD — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
Sync-over-async blocking — 57 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking cs/benchmark/FasterSpanByteYcsbBenchmark.cs:416— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking cs/benchmark/FasterSpanByteYcsbBenchmark.cs:107— `waiter.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking cs/benchmark/FasterSpanByteYcsbBenchmark.cs:224— `waiter.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking cs/benchmark/FasterSpanByteYcsbBenchmark.cs:458— `waiter.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking cs/benchmark/FasterSpanByteYcsbBenchmark.cs:527— `waiter.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking cs/benchmark/FasterYcsbBenchmark.cs:380— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking cs/benchmark/FasterYcsbBenchmark.cs:107— `waiter.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking cs/benchmark/FasterYcsbBenchmark.cs:220— `waiter.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking cs/benchmark/FasterYcsbBenchmark.cs:423— `waiter.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking cs/benchmark/FasterYcsbBenchmark.cs:491— `waiter.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking cs/benchmark/TestLoader.cs:388— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking cs/playground/SumStore/RecoveryTest.cs:167— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking cs/src/core/Allocator/AllocatorBase.cs:921— `completionEvent.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking cs/src/core/Allocator/AllocatorBase.cs:1545— `flushEvent.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking cs/src/core/Allocator/GenericAllocator.cs:414— `handle.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking cs/src/core/Allocator/MallocFixedPageSize.cs:39— `syncEvent.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking cs/src/core/Async/AsyncOperationInternal.cs:107— `flushEvent.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking cs/src/core/Device/AsyncPool.cs:118— `handleAvailable.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking cs/src/core/Device/StorageDeviceBase.cs:203— `completionEvent.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking cs/src/core/Device/StorageDeviceBase.cs:272— `completionEvent.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking cs/src/core/Device/StorageDeviceBase.cs:316— `completionEvent.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking cs/src/core/FasterLog/FasterLog.cs:832— `flushEvent.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs:274— `.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking cs/src/core/Index/FASTER/Implementation/HandleOperationStatus.cs:73— `flushEvent.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Swallowed exception (empty catch) cs/src/core/Allocator/AllocatorBase.cs:2336— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) cs/src/core/Allocator/AllocatorBase.cs:2355— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) cs/src/core/Allocator/AllocatorBase.cs:2425— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) cs/src/core/Allocator/ScanIteratorBase.cs:251— An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: record it through whatever this codebase already uses to report problems — or, if one specific failure truly cannot matter, catch exactly that exception type and say why in a comment on the catch (a comment on a catch-all still swallows everything else).
Swallowed exception (empty catch) cs/src/core/Allocator/WorkQueueFIFO.cs:89— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) cs/src/core/Allocator/WorkQueueLIFO.cs:89— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) cs/src/core/Device/ManagedLocalStorageDevice.cs:449— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) cs/src/core/FasterLog/FasterLog.cs:219— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) cs/src/core/FasterLog/FasterLog.cs:1003— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) cs/src/core/FasterLog/FasterLog.cs:1038— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) cs/src/core/FasterLog/FasterLog.cs:1073— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) cs/src/core/FasterLog/FasterLog.cs:1110— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) cs/src/core/FasterLog/FasterLog.cs:1147— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) cs/src/core/FasterLog/FasterLog.cs:1233— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) cs/src/core/FasterLog/FasterLog.cs:1509— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) cs/src/core/FasterLog/FasterLog.cs:1561— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) cs/src/core/FasterLog/FasterLog.cs:1613— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) cs/src/core/FasterLog/FasterLog.cs:1666— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) cs/src/core/FasterLog/FasterLog.cs:1720— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) cs/src/core/FasterLog/FasterLog.cs:2285— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) cs/src/core/FasterLog/FasterLog.cs:2300— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) cs/src/core/FasterLog/FasterLog.cs:2368— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) cs/src/core/FasterLog/FasterLog.cs:2390— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) cs/src/core/FasterLog/FasterLog.cs:2441— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) cs/src/core/FasterLog/FasterLog.cs:2456— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
End-of-life runtime: .NET net6.0 cs/remote/test/FASTER.remote.test/FASTER.remote.test.csproj:4— cs/remote/test/FASTER.remote.test/FASTER.remote.test.csproj declares .NET net6.0 as this project's target framework, and .NET 6 LTS, support ended 2024-11-12. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-11-12 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
End-of-life runtime: .NET net6.0 cs/test/FASTER.test.csproj:4— cs/test/FASTER.test.csproj declares .NET net6.0 as this project's target framework, and .NET 6 LTS, support ended 2024-11-12. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-11-12 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
End-of-life runtime: .NET net7.0 cs/benchmark/FASTER.benchmark.csproj:4— cs/benchmark/FASTER.benchmark.csproj declares .NET net7.0 as this project's target framework, and .NET 7, support ended 2024-05-14. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-05-14 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
End-of-life runtime: .NET net7.0 cs/performance/BenchmarkDotNet/BenchmarkDotNetTests.csproj:3— cs/performance/BenchmarkDotNet/BenchmarkDotNetTests.csproj declares .NET net7.0 as this project's target framework, and .NET 7, support ended 2024-05-14. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-05-14 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
End-of-life runtime: .NET net7.0 REDACTED:5— REDACTED declares .NET net7.0 as this project's target framework, and .NET 7, support ended 2024-05-14. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-05-14 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
End-of-life runtime: .NET net7.0 cs/playground/CacheStoreConcurrent/CacheStoreConcurrent.csproj:6— cs/playground/CacheStoreConcurrent/CacheStoreConcurrent.csproj declares .NET net7.0 as this project's target framework, and .NET 7, support ended 2024-05-14. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-05-14 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
End-of-life runtime: .NET net7.0 cs/playground/ClassRecoveryDurability/ClassRecoveryDurability.csproj:5— cs/playground/ClassRecoveryDurability/ClassRecoveryDurability.csproj declares .NET net7.0 as this project's target framework, and .NET 7, support ended 2024-05-14. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-05-14 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
End-of-life runtime: .NET net7.0 cs/playground/FasterLogMLSDTest/FasterLogStress.csproj:5— cs/playground/FasterLogMLSDTest/FasterLogStress.csproj declares .NET net7.0 as this project's target framework, and .NET 7, support ended 2024-05-14. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-05-14 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
End-of-life runtime: .NET net7.0 cs/playground/MemoryDb/MemoryDb.csproj:5— cs/playground/MemoryDb/MemoryDb.csproj declares .NET net7.0 as this project's target framework, and .NET 7, support ended 2024-05-14. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-05-14 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
End-of-life runtime: .NET net7.0 cs/playground/SumStore/SumStore.csproj:4— cs/playground/SumStore/SumStore.csproj declares .NET net7.0 as this project's target framework, and .NET 7, support ended 2024-05-14. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-05-14 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
End-of-life runtime: .NET net7.0 cs/playground/TstRunner/TstRunner.csproj:5— cs/playground/TstRunner/TstRunner.csproj declares .NET net7.0 as this project's target framework, and .NET 7, support ended 2024-05-14. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-05-14 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
End-of-life runtime: .NET net7.0 cs/remote/benchmark/FASTER.benchmark/FASTER.benchmark.csproj:5— cs/remote/benchmark/FASTER.benchmark/FASTER.benchmark.csproj declares .NET net7.0 as this project's target framework, and .NET 7, support ended 2024-05-14. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-05-14 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
End-of-life runtime: .NET net7.0 cs/remote/samples/FixedLenClient/FixedLenClient.csproj:5— cs/remote/samples/FixedLenClient/FixedLenClient.csproj declares .NET net7.0 as this project's target framework, and .NET 7, support ended 2024-05-14. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-05-14 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
End-of-life runtime: .NET net7.0 cs/remote/samples/FixedLenServer/FixedLenServer.csproj:5— cs/remote/samples/FixedLenServer/FixedLenServer.csproj declares .NET net7.0 as this project's target framework, and .NET 7, support ended 2024-05-14. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-05-14 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
End-of-life runtime: .NET net7.0 cs/remote/samples/VarLenClient/VarLenClient.csproj:5— cs/remote/samples/VarLenClient/VarLenClient.csproj declares .NET net7.0 as this project's target framework, and .NET 7, support ended 2024-05-14. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-05-14 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
End-of-life runtime: .NET net7.0 cs/remote/samples/VarLenServer/VarLenServer.csproj:5— cs/remote/samples/VarLenServer/VarLenServer.csproj declares .NET net7.0 as this project's target framework, and .NET 7, support ended 2024-05-14. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-05-14 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
End-of-life runtime: .NET net7.0 cs/samples/AzureBackedStore/AzureBackedStore.csproj:4— cs/samples/AzureBackedStore/AzureBackedStore.csproj declares .NET net7.0 as this project's target framework, and .NET 7, support ended 2024-05-14. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-05-14 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
End-of-life runtime: .NET net7.0 cs/samples/CacheStore/CacheStore.csproj:6— cs/samples/CacheStore/CacheStore.csproj declares .NET net7.0 as this project's target framework, and .NET 7, support ended 2024-05-14. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-05-14 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
End-of-life runtime: .NET net7.0 cs/samples/EpvsSample/EpvsSample.csproj:5— cs/samples/EpvsSample/EpvsSample.csproj declares .NET net7.0 as this project's target framework, and .NET 7, support ended 2024-05-14. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-05-14 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
End-of-life runtime: .NET net7.0 cs/samples/FasterLogPubSub/FasterLogPubSub.csproj:4— cs/samples/FasterLogPubSub/FasterLogPubSub.csproj declares .NET net7.0 as this project's target framework, and .NET 7, support ended 2024-05-14. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-05-14 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
End-of-life runtime: .NET net7.0 cs/samples/FasterLogSample/FasterLogSample.csproj:4— cs/samples/FasterLogSample/FasterLogSample.csproj declares .NET net7.0 as this project's target framework, and .NET 7, support ended 2024-05-14. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-05-14 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
End-of-life runtime: .NET net7.0 cs/samples/HelloWorld/HelloWorld.csproj:4— cs/samples/HelloWorld/HelloWorld.csproj declares .NET net7.0 as this project's target framework, and .NET 7, support ended 2024-05-14. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-05-14 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
End-of-life runtime: .NET net7.0 cs/samples/ReadAddress/VersionedRead.csproj:5— cs/samples/ReadAddress/VersionedRead.csproj declares .NET net7.0 as this project's target framework, and .NET 7, support ended 2024-05-14. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-05-14 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
End-of-life runtime: .NET net7.0 cs/samples/ResizableCacheStore/ResizableCacheStore.csproj:6— cs/samples/ResizableCacheStore/ResizableCacheStore.csproj declares .NET net7.0 as this project's target framework, and .NET 7, support ended 2024-05-14. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-05-14 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
End-of-life runtime: .NET net7.0 cs/samples/SecondaryReaderStore/SecondaryReaderStore.csproj:6— cs/samples/SecondaryReaderStore/SecondaryReaderStore.csproj declares .NET net7.0 as this project's target framework, and .NET 7, support ended 2024-05-14. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-05-14 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
Sync-over-async (deadlock risk) cs/benchmark/FasterSpanByteYcsbBenchmark.cs:416— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) cs/benchmark/FasterYcsbBenchmark.cs:380— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) cs/benchmark/TestLoader.cs:388— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs:274— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) cs/src/devices/AzureStorageDevice/AzureStorageDevice.cs:112— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) cs/src/devices/AzureStorageDevice/AzureStorageDevice.cs:147— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) cs/src/devices/AzureStorageDevice/AzureStorageDevice.cs:311— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback.
Sync-over-async (deadlock risk) cs/src/devices/AzureStorageDevice/AzureStorageNamedDeviceFactory.cs:42— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) cs/src/devices/AzureStorageDevice/AzureStorageNamedDeviceFactory.cs:67— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) cs/src/devices/AzureStorageDevice/AzureStorageNamedDeviceFactory.cs:69— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) cs/src/devices/AzureStorageDevice/AzureStorageNamedDeviceFactory.cs:74— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) cs/src/devices/AzureStorageDevice/AzureStorageNamedDeviceFactory.cs:76— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) cs/src/devices/AzureStorageDevice/BlobManager.cs:95— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) cs/src/devices/AzureStorageDevice/BlobManager.cs:154— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) cs/playground/ClassRecoveryDurability/Program.cs:66— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) cs/playground/ClassRecoveryDurability/Program.cs:159— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) cs/playground/ClassRecoveryDurability/Storedb.cs:64— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) cs/samples/HelloWorld/Program.cs:130— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) cs/samples/StoreCheckpointRecover/Program.cs:55— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) cs/samples/StoreDiskReadBenchmark/Program.cs:245— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) cs/samples/StoreAsyncApi/Program.cs:171— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) cs/samples/FasterLogSample/Program.cs:160— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) cs/samples/SecondaryReaderStore/Program.cs:59— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) cs/samples/SecondaryReaderStore/Program.cs:68— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) cs/playground/AsyncStress/FasterWrapper.cs:83— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
+ 7 more in this group — see findings.md.
X2 · Cancellation propagation· Async method without CancellationToken · ×28
Async method without CancellationToken: CheckpointStore cs/stress/LongValueTester.cs:50— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: ReadAsync cs/stress/SessionWrapper.cs:72— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: ReadLUCAsync cs/stress/SessionWrapper.cs:110— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: RMWAsync cs/stress/SessionWrapper.cs:160— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: RMWLUCAsync cs/stress/SessionWrapper.cs:197— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: UpsertAsync cs/stress/SessionWrapper.cs:236— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: UpsertLUCAsync cs/stress/SessionWrapper.cs:252— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: DeleteAsync cs/stress/SessionWrapper.cs:273— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: DeleteLUCAsync cs/stress/SessionWrapper.cs:289— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: CheckpointStore cs/stress/SpanByteValueTester.cs:54— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: CheckpointStore cs/stress/StringValueTester.cs:52— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: TestAsync cs/stress/TestLoader.cs:301— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: FlushAsync cs/src/core/Index/Recovery/DeltaLog.cs:378— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: WriteToBlobAsync cs/src/devices/AzureStorageDevice/AzureStorageDevice.cs:657— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: InitializeAsync cs/src/devices/AzureStorageDevice/AzureStorageNamedDeviceFactory.cs:45— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: StartAsync cs/src/devices/AzureStorageDevice/BlobManager.cs:106— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: ForceDeleteAsync cs/src/devices/AzureStorageDevice/BlobUtilsV12.cs:178— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: WaitForTermination cs/src/devices/AzureStorageDevice/StorageErrorHandler.cs:148— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: PerformWithRetriesAsync cs/src/devices/AzureStorageDevice/StorageOperations.cs:14— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: AsyncUpsertOperator cs/samples/StoreDiskReadBenchmark/Program.cs:84— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: AsyncReadOperator cs/samples/StoreDiskReadBenchmark/Program.cs:118— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: AsyncOperator cs/samples/StoreAsyncApi/Program.cs:60— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: AsyncLogWriter cs/samples/FasterLogSample/Program.cs:111— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: AsyncScan cs/samples/FasterLogSample/Program.cs:183— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: PopulateStore cs/samples/ReadAddress/VersionedReadApp.cs:101— No CancellationToken parameter — this work can't be stopped early once started.
TodoComment cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:392— // TODO: this needs to be a single atomic enqueue — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment cs/samples/EpvsSample/ListExample.cs:283— // TODO(Tianyu): How to ensure this is correct in the face of concurrent pushes? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment cs/src/core/Device/ShardedStorageDevice.cs:226— // TODO: Check if it is incorrect to ignore o — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment cs/src/core/Device/ShardedStorageDevice.cs:239— // TODO: Check if overlapped wrapper is handled correctly — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment cs/src/core/Device/ShardedStorageDevice.cs:277— // TODO: this is incorrect if returned "bytes" written is allowed to be less than requested like POSIX. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment cs/src/core/Device/ShardedStorageDevice.cs:290— // TODO: Check handling of overlapped wrapper — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment cs/src/core/FasterLog/FasterLog.cs:2079— // TODO: can change to write this in separate thread for fast commit — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment cs/src/core/FasterLog/FasterLog.cs:2171— // TODO: Can invoke earlier in the case of fast commit — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment cs/src/core/Index/Common/RecordInfo.cs:277— // TODO: Interlocked.And is not supported in netstandard2.1 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment cs/src/core/Index/Common/RecordInfo.cs:336— // TODO: Interlocked.And is not supported in netstandard2.1 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment cs/src/core/Index/FASTER/FASTERBase.cs:52— // TODO verify these — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment cs/src/core/Index/FASTER/FASTERBase.cs:66— // TODO unused — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment cs/src/core/Index/FASTER/FASTERBase.cs:69— // TODO verify this number — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment cs/src/core/Index/FASTER/FASTERBase.cs:519— // TODO local var not used; use or change to byval param — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment cs/src/core/Index/FASTER/FASTERBase.cs:520— // TODO local var not used; use or change to byval param — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment cs/src/core/Index/FASTER/FASTERBase.cs:526— // TODO: Why not return orig_bucket and orig_slot if it's not Tentative? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment cs/src/core/Index/FASTER/Implementation/BlockAllocate.cs:62— // This allocation is below the necessary address so abandon it and repeat the loop. TODO potential reuse — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:437— // TODO: Another area where we can stash the record for reuse (not retry; this is canceling of the current operation). — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:459— // TODO: Another area where we can stash the record for reuse (not retry; this may have been false because the record was too small). — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs:337— // TODO save allocation for reuse (not retry, because these aren't retry status codes); check other InternalXxx as well — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment cs/src/core/Index/FASTER/Implementation/ReadCache.cs:298— // TODO: We currently don't save readcache allocations for retry, but we could — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment cs/src/core/Index/FASTER/Implementation/TryCopyToTail.cs:56— // No SaveAlloc here as we won't retry, but TODO this record could be reused later. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment cs/src/devices/AzureStorageDevice/AzureStorageDevice.cs:68— // set this at 512 GB for now TODO consider implications — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment cs/stress/SpanByteValueFunctions.cs:36— // TODO: we're not using output yet for Upsert, so this would leak: src.CopyTo(ref output, memoryPool); — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment cs/test/ExpirationTests.cs:87— // - (TODO with revivication) NewRecord (input len > record len): Return false from IPU, true from NCU, set in CU — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
Duplicated block (8 lines × 2) cs/stress/SessionWrapper.cs:97— cs/stress/SessionWrapper.cs:97-104 | cs/stress/SessionWrapper.cs:184-191 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/stress/SessionWrapper.cs:97` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (8 lines × 2) cs/src/core/Allocator/GenericAllocator.cs:929— cs/src/core/Allocator/GenericAllocator.cs:929-936 | cs/src/core/Allocator/GenericAllocator.cs:944-951 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Allocator/GenericAllocator.cs:929` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) cs/remote/src/FASTER.server/WebsocketServerSession.cs:491— cs/remote/src/FASTER.server/WebsocketServerSession.cs:491-498 | cs/remote/src/FASTER.server/WebsocketServerSession.cs:514-521 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8 lines × 2) cs/stress/SessionWrapper.cs:118— cs/stress/SessionWrapper.cs:118-125 | cs/stress/SessionWrapper.cs:205-212 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/stress/SessionWrapper.cs:118` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (8 lines × 2) cs/src/core/Index/Common/Contexts.cs:723— cs/src/core/Index/Common/Contexts.cs:723-730 | cs/src/core/Index/Common/Contexts.cs:741-748 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Index/Common/Contexts.cs:723` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) cs/stress/SessionWrapper.cs:151— cs/stress/SessionWrapper.cs:151-158 | cs/stress/SessionWrapper.cs:182-189 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/stress/SessionWrapper.cs:151` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) cs/src/core/Allocator/BlittableAllocator.cs:242— cs/src/core/Allocator/BlittableAllocator.cs:242-249 | cs/src/core/Allocator/VarLenBlittableAllocator.cs:348-355 — before extracting anything, compare `cs/src/core/Allocator/BlittableAllocator.cs` and `cs/src/core/Allocator/VarLenBlittableAllocator.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 179 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (8 lines × 2) cs/src/core/Allocator/BlittableAllocator.cs:277— cs/src/core/Allocator/BlittableAllocator.cs:277-284 | cs/src/core/Allocator/VarLenBlittableAllocator.cs:382-389 — before extracting anything, compare `cs/src/core/Allocator/BlittableAllocator.cs` and `cs/src/core/Allocator/VarLenBlittableAllocator.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 179 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (8 lines × 2) cs/src/core/Index/FASTER/FASTER.cs:647— cs/src/core/Index/FASTER/FASTER.cs:647-654 | cs/src/core/Index/FASTER/FASTER.cs:666-673 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) cs/remote/src/FASTER.client/ClientSession.cs:730— cs/remote/src/FASTER.client/ClientSession.cs:730-737 | cs/remote/src/FASTER.client/ClientSession.cs:776-783 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/remote/src/FASTER.client/ClientSession.cs:730` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `cs/remote/src/FASTER.client/ClientSession.cs:739` calls `Write` and `cs/remote/src/FASTER.client/ClientSession.cs:785` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (8 lines × 2) cs/src/core/Allocator/AllocatorBase.cs:2330— cs/src/core/Allocator/AllocatorBase.cs:2330-2337 | cs/src/core/Allocator/AllocatorBase.cs:2349-2357 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Allocator/AllocatorBase.cs:2330` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) cs/src/core/Allocator/GenericAllocator.cs:416— cs/src/core/Allocator/GenericAllocator.cs:416-423 | cs/src/core/Allocator/GenericAllocator.cs:426-433 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Allocator/GenericAllocator.cs:416` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) cs/src/core/Allocator/GenericAllocator.cs:858— cs/src/core/Allocator/GenericAllocator.cs:858-865 | cs/src/core/Allocator/GenericAllocator.cs:876-883 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) cs/src/core/FasterLog/FasterLog.cs:749— cs/src/core/FasterLog/FasterLog.cs:749-756 | cs/src/core/FasterLog/FasterLog.cs:874-881 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs:443— cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs:443-450 | cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs:469-476 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs:443` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) cs/remote/src/FASTER.server/Servers/ServerOptions.cs:276— cs/remote/src/FASTER.server/Servers/ServerOptions.cs:276-283 | cs/src/core/Utilities/Utility.cs:89-96 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (8 lines × 2) cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:411— cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:411-418 | cs/remote/src/FASTER.server/PubSub/SubscribeKVBroker.cs:263-270 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (8 lines × 2) cs/remote/samples/FixedLenClient/Program.cs:20— cs/remote/samples/FixedLenClient/Program.cs:20-27 | cs/remote/samples/VarLenClient/Program.cs:16-23 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (8 lines × 2) cs/samples/StoreVarLenTypes/MemoryByteSample.cs:33— cs/samples/StoreVarLenTypes/MemoryByteSample.cs:33-41 | cs/samples/StoreVarLenTypes/MemoryByteSample.cs:50-57 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/samples/StoreVarLenTypes/MemoryByteSample.cs:33` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `cs/samples/StoreVarLenTypes/MemoryByteSample.cs:59` calls `Read` and `cs/samples/StoreVarLenTypes/MemoryByteSample.cs:42` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (8 lines × 2) cs/samples/StoreVarLenTypes/MemoryIntSample.cs:33— cs/samples/StoreVarLenTypes/MemoryIntSample.cs:33-41 | cs/samples/StoreVarLenTypes/MemoryIntSample.cs:50-57 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/samples/StoreVarLenTypes/MemoryIntSample.cs:33` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `cs/samples/StoreVarLenTypes/MemoryIntSample.cs:59` calls `Read` and `cs/samples/StoreVarLenTypes/MemoryIntSample.cs:42` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
TooManyMethods: FasterKV cs/src/core/Index/FASTER/FASTER.cs— TooManyMethods — 3400 significant lines (blank, comment-only and punctuation-only lines excluded), 206 methods, declared across 34 files: FASTER/FASTER.cs (34), Recovery/Recovery.cs (33), Implementation/ReadCache.cs (11), ClientSession/FASTERClientSession.cs (10), +30 more file(s). The bar is 30 methods; this is 176 over it, 6.87× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ClientSession cs/src/core/ClientSession/ClientSession.cs— TooManyMethods — 555 significant lines (blank, comment-only and punctuation-only lines excluded), 111 methods. The bar is 30 methods; this is 81 over it, 3.70× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: AllocatorBase cs/src/core/Allocator/AllocatorBase.cs— TooManyMethods — 1047 significant lines (blank, comment-only and punctuation-only lines excluded), 108 methods, declared across 2 files: Allocator/AllocatorBase.cs (104), Recovery/Recovery.cs (4). The bar is 30 methods; this is 78 over it, 3.60× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: FasterLog cs/src/core/FasterLog/FasterLog.cs— TooManyMethods — 1355 significant lines (blank, comment-only and punctuation-only lines excluded), 104 methods. The bar is 30 methods; this is 74 over it, 3.47× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: LockableContext cs/src/core/ClientSession/LockableContext.cs— TooManyMethods — 473 significant lines (blank, comment-only and punctuation-only lines excluded), 100 methods. The bar is 30 methods; this is 70 over it, 3.33× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: LockableUnsafeContext cs/src/core/ClientSession/LockableUnsafeContext.cs— TooManyMethods — 336 significant lines (blank, comment-only and punctuation-only lines excluded), 98 methods. The bar is 30 methods; this is 68 over it, 3.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: UnsafeContext cs/src/core/ClientSession/UnsafeContext.cs— TooManyMethods — 279 significant lines (blank, comment-only and punctuation-only lines excluded), 77 methods. The bar is 30 methods; this is 47 over it, 2.57× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: GenericAllocator cs/src/core/Allocator/GenericAllocator.cs— TooManyMethods — 544 significant lines (blank, comment-only and punctuation-only lines excluded), 55 methods. The bar is 30 methods; this is 25 over it, 1.83× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: VariableLengthBlittableAllocator cs/src/core/Allocator/VarLenBlittableAllocator.cs— TooManyMethods — 259 significant lines (blank, comment-only and punctuation-only lines excluded), 51 methods. The bar is 30 methods; this is 21 over it, 1.70× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: InternalFasterSession cs/src/core/ClientSession/ClientSession.cs— TooManyMethods — 232 significant lines (blank, comment-only and punctuation-only lines excluded), 49 methods. The bar is 30 methods; this is 19 over it, 1.63× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: BlittableAllocator cs/src/core/Allocator/BlittableAllocator.cs— TooManyMethods — 199 significant lines (blank, comment-only and punctuation-only lines excluded), 41 methods. The bar is 30 methods; this is 11 over it, 1.37× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ClientSession cs/remote/src/FASTER.client/ClientSession.cs— TooManyMethods — 494 significant lines (blank, comment-only and punctuation-only lines excluded), 38 methods, declared across 2 files: FASTER.client/ClientSession.cs (34), FASTER.client/ClientSessionAsync.cs (4). The bar is 30 methods; this is 8 over it, 1.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: Native32 cs/src/core/Utilities/Native32.cs— TooManyMethods — 214 significant lines (blank, comment-only and punctuation-only lines excluded), 35 methods. The bar is 30 methods; this is 5 over it, 1.17× the bar. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
TooManyMethods: InternalFasterSession cs/src/core/ClientSession/LockableContext.cs— TooManyMethods — 121 significant lines (blank, comment-only and punctuation-only lines excluded), 34 methods. The bar is 30 methods; this is 4 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: DeviceLogCommitCheckpointManager cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs— TooManyMethods — 222 significant lines (blank, comment-only and punctuation-only lines excluded), 31 methods. The bar is 30 methods; this is 1 over it, 1.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D4 · Code Duplication· Edited copy of a member (4 corresponding lines) · ×15
Edited copy of a member (4 corresponding lines) cs/src/core/ClientSession/FASTERClientSession.cs:221— cs/src/core/ClientSession/FASTERClientSession.cs:221-227 | cs/src/core/ClientSession/FASTERClientSession.cs:258-261 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (4 corresponding lines) cs/remote/src/FASTER.client/FasterKVClient.cs:69— cs/remote/src/FASTER.client/FasterKVClient.cs:69-72 | cs/remote/src/FASTER.client/FasterKVClient.cs:91-94 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (4 corresponding lines) cs/src/core/ClientSession/LockableUnsafeContext.cs:660— cs/src/core/ClientSession/LockableUnsafeContext.cs:660-663 | cs/src/core/ClientSession/UnsafeContext.cs:532-535 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (4 corresponding lines) cs/src/core/ClientSession/LockableUnsafeContext.cs:206— cs/src/core/ClientSession/LockableUnsafeContext.cs:206-209 | cs/src/core/ClientSession/UnsafeContext.cs:82-85 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (4 corresponding lines) cs/src/core/ClientSession/LockableUnsafeContext.cs:511— cs/src/core/ClientSession/LockableUnsafeContext.cs:511-514 | cs/src/core/ClientSession/UnsafeContext.cs:386-389 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (4 corresponding lines) cs/src/core/Allocator/BlittableAllocator.cs:401— cs/src/core/Allocator/BlittableAllocator.cs:401-404 | cs/src/core/Allocator/VarLenBlittableAllocator.cs:524-527 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (4 corresponding lines) cs/src/core/ClientSession/LockableUnsafeContext.cs:198— cs/src/core/ClientSession/LockableUnsafeContext.cs:198-201 | cs/src/core/ClientSession/UnsafeContext.cs:74-77 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (4 corresponding lines) cs/src/core/ClientSession/LockableUnsafeContext.cs:290— cs/src/core/ClientSession/LockableUnsafeContext.cs:290-293 | cs/src/core/ClientSession/UnsafeContext.cs:166-169 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (4 corresponding lines) cs/src/core/ClientSession/LockableUnsafeContext.cs:182— cs/src/core/ClientSession/LockableUnsafeContext.cs:182-185 | cs/src/core/ClientSession/UnsafeContext.cs:58-61 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (4 corresponding lines) cs/src/core/ClientSession/ClientSession.cs:1243— cs/src/core/ClientSession/ClientSession.cs:1243-1246 | cs/src/core/ClientSession/LockableContext.cs:949-952 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (4 corresponding lines) cs/src/core/ClientSession/LockableUnsafeContext.cs:175— cs/src/core/ClientSession/LockableUnsafeContext.cs:175-178 | cs/src/core/ClientSession/UnsafeContext.cs:51-54 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (4 corresponding lines) cs/src/core/ClientSession/ClientSession.cs:1362— cs/src/core/ClientSession/ClientSession.cs:1362-1365 | cs/src/core/ClientSession/LockableContext.cs:994-997 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (4 corresponding lines) cs/src/core/ClientSession/ClientSession.cs:1323— cs/src/core/ClientSession/ClientSession.cs:1323-1326 | cs/src/core/ClientSession/LockableContext.cs:977-980 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (4 corresponding lines) cs/src/core/ClientSession/LockableUnsafeContext.cs:25— cs/src/core/ClientSession/LockableUnsafeContext.cs:25-28 | cs/src/core/ClientSession/UnsafeContext.cs:24-27 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (4 corresponding lines) cs/src/core/Index/FASTER/FASTER.cs:443— cs/src/core/Index/FASTER/FASTER.cs:443-446 | cs/src/core/Index/Recovery/Recovery.cs:358-361 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (7 lines × 2) cs/remote/src/FASTER.server/PubSub/SubscribeKVBroker.cs:128— cs/remote/src/FASTER.server/PubSub/SubscribeKVBroker.cs:128-134 | cs/remote/src/FASTER.server/PubSub/SubscribeKVBroker.cs:155-161 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/remote/src/FASTER.server/PubSub/SubscribeKVBroker.cs:128` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) cs/src/core/FasterLog/FasterLogIterator.cs:858— cs/src/core/FasterLog/FasterLogIterator.cs:858-864 | cs/src/core/FasterLog/FasterLogIterator.cs:956-962 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/FasterLog/FasterLogIterator.cs:858` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) cs/remote/src/FASTER.server/Servers/GenericServer.cs:40— cs/remote/src/FASTER.server/Servers/GenericServer.cs:40-46 | cs/remote/src/FASTER.server/Servers/VarLenServer.cs:32-38 — before extracting anything, compare `cs/remote/src/FASTER.server/Servers/GenericServer.cs` and `cs/remote/src/FASTER.server/Servers/VarLenServer.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 53 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (7 lines × 2) cs/remote/src/FASTER.client/ClientSession.cs:420— cs/remote/src/FASTER.client/ClientSession.cs:420-426 | cs/remote/src/FASTER.client/ClientSession.cs:622-628 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/remote/src/FASTER.client/ClientSession.cs:420` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) cs/remote/src/FASTER.client/MemoryParameterSerializer.cs:32— cs/remote/src/FASTER.client/MemoryParameterSerializer.cs:32-38 | cs/remote/src/FASTER.client/MemoryParameterSerializer.cs:43-49 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (7 lines × 2) cs/src/core/FasterLog/FasterLog.cs:807— cs/src/core/FasterLog/FasterLog.cs:807-813 | cs/src/core/FasterLog/FasterLog.cs:950-956 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (7 lines × 2) cs/src/core/Allocator/BlittableAllocator.cs:65— cs/src/core/Allocator/BlittableAllocator.cs:65-71 | cs/src/core/Allocator/VarLenBlittableAllocator.cs:84-90 — before extracting anything, compare `cs/src/core/Allocator/BlittableAllocator.cs` and `cs/src/core/Allocator/VarLenBlittableAllocator.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 179 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (7 lines × 2) cs/src/core/Allocator/BlittableAllocator.cs:216— cs/src/core/Allocator/BlittableAllocator.cs:216-222 | cs/src/core/Allocator/VarLenBlittableAllocator.cs:322-328 — before extracting anything, compare `cs/src/core/Allocator/BlittableAllocator.cs` and `cs/src/core/Allocator/VarLenBlittableAllocator.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 179 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (7 lines × 2) cs/remote/src/FASTER.server/Servers/GenericServer.cs:81— cs/remote/src/FASTER.server/Servers/GenericServer.cs:81-88 | cs/remote/src/FASTER.server/Servers/VarLenServer.cs:65-71 — before extracting anything, compare `cs/remote/src/FASTER.server/Servers/GenericServer.cs` and `cs/remote/src/FASTER.server/Servers/VarLenServer.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 53 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (7 lines × 2) cs/remote/src/FASTER.server/Servers/GenericServer.cs:107— cs/remote/src/FASTER.server/Servers/GenericServer.cs:107-113 | cs/remote/src/FASTER.server/Servers/VarLenServer.cs:91-97 — before extracting anything, compare `cs/remote/src/FASTER.server/Servers/GenericServer.cs` and `cs/remote/src/FASTER.server/Servers/VarLenServer.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 53 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (7 lines × 2) cs/samples/StoreAsyncApi/Program.cs:167— cs/samples/StoreAsyncApi/Program.cs:167-173 | cs/samples/StoreDiskReadBenchmark/Program.cs:239-250 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication· Edited copy of a member (8 corresponding lines) · ×10
Edited copy of a member (8 corresponding lines) cs/remote/src/FASTER.client/MemoryParameterSerializer.cs:31— cs/remote/src/FASTER.client/MemoryParameterSerializer.cs:31-38 | cs/remote/src/FASTER.client/MemoryParameterSerializer.cs:42-49 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) cs/playground/AsyncStress/FasterWrapper.cs:90— cs/playground/AsyncStress/FasterWrapper.cs:90-97 | cs/playground/AsyncStress/FasterWrapper.cs:117-124 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:43— cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:43-50 | cs/remote/src/FASTER.server/PubSub/SubscribeKVBroker.cs:44-51 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) cs/stress/SessionWrapper.cs:73— cs/stress/SessionWrapper.cs:73-80 | cs/stress/SessionWrapper.cs:161-168 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) cs/remote/src/FASTER.client/ClientSessionAsync.cs:22— cs/remote/src/FASTER.client/ClientSessionAsync.cs:22-29 | cs/remote/src/FASTER.client/ClientSessionAsync.cs:56-63 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) cs/src/core/Allocator/BlittableAllocator.cs:215— cs/src/core/Allocator/BlittableAllocator.cs:215-222 | cs/src/core/Allocator/VarLenBlittableAllocator.cs:321-328 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) cs/src/core/Allocator/BlittableScanIterator.cs:53— cs/src/core/Allocator/BlittableScanIterator.cs:53-60 | cs/src/core/Allocator/VarLenBlittableScanIterator.cs:54-61 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) cs/remote/src/FASTER.server/Servers/GenericServer.cs:106— cs/remote/src/FASTER.server/Servers/GenericServer.cs:106-113 | cs/remote/src/FASTER.server/Servers/VarLenServer.cs:90-97 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) cs/remote/src/FASTER.server/BinaryServerSession.cs:349— cs/remote/src/FASTER.server/BinaryServerSession.cs:349-356 | cs/remote/src/FASTER.server/WebsocketServerSession.cs:722-732 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (8 corresponding lines) cs/src/core/Allocator/BlittableAllocator.cs:64— cs/src/core/Allocator/BlittableAllocator.cs:64-71 | cs/src/core/Allocator/VarLenBlittableAllocator.cs:83-90 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (6 lines × 2) cs/src/core/Allocator/WorkQueueFIFO.cs:93— cs/src/core/Allocator/WorkQueueFIFO.cs:93-98 | cs/src/core/Allocator/WorkQueueLIFO.cs:93-98 — before extracting anything, compare `cs/src/core/Allocator/WorkQueueFIFO.cs` and `cs/src/core/Allocator/WorkQueueLIFO.cs` as WHOLE FILES: 85% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Allocator/WorkQueueFIFO.cs:93` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) cs/src/core/Async/RMWAsync.cs:128— cs/src/core/Async/RMWAsync.cs:128-133 | cs/src/core/Async/ReadAsync.cs:119-124 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Async/RMWAsync.cs:128` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) cs/remote/src/FASTER.server/WebsocketServerSession.cs:416— cs/remote/src/FASTER.server/WebsocketServerSession.cs:416-421 | cs/remote/src/FASTER.server/WebsocketServerSession.cs:470-475 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (6 lines × 2) cs/remote/src/FASTER.server/BinaryServerSession.cs:12— cs/remote/src/FASTER.server/BinaryServerSession.cs:12-17 | cs/remote/src/FASTER.server/WebsocketServerSession.cs:22-27 — before extracting anything, compare `cs/remote/src/FASTER.server/BinaryServerSession.cs` and `cs/remote/src/FASTER.server/WebsocketServerSession.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 189 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `cs/remote/src/FASTER.server/BinaryServerSession.cs:12` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:45— cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:45-50 | cs/remote/src/FASTER.server/PubSub/SubscribeKVBroker.cs:46-51 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:45` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) cs/playground/ClassRecoveryDurability/Program.cs:73— cs/playground/ClassRecoveryDurability/Program.cs:73-78 | cs/playground/ClassRecoveryDurability/Program.cs:167-172 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (6 lines × 2) cs/remote/src/FASTER.server/WebsocketServerSession.cs:430— cs/remote/src/FASTER.server/WebsocketServerSession.cs:430-436 | cs/remote/src/FASTER.server/WebsocketServerSession.cs:450-455 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/remote/src/FASTER.server/WebsocketServerSession.cs:430` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (6 lines × 2) cs/src/core/Allocator/BlittableAllocator.cs:231— cs/src/core/Allocator/BlittableAllocator.cs:231-236 | cs/src/core/Allocator/VarLenBlittableAllocator.cs:337-342 — before extracting anything, compare `cs/src/core/Allocator/BlittableAllocator.cs` and `cs/src/core/Allocator/VarLenBlittableAllocator.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 179 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (6 lines × 2) cs/samples/StoreVarLenTypes/MemoryByteSample.cs:37— cs/samples/StoreVarLenTypes/MemoryByteSample.cs:37-42 | cs/samples/StoreVarLenTypes/MemoryIntSample.cs:37-42 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (6 lines × 2) cs/stress/TestLoader.cs:288— cs/stress/TestLoader.cs:288-293 | cs/stress/TestLoader.cs:307-312 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/stress/TestLoader.cs:288` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `cs/stress/TestLoader.cs:304` calls `Delay` and `cs/stress/TestLoader.cs:285` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (10 lines × 2) cs/remote/src/FASTER.client/ClientSession.cs:457— cs/remote/src/FASTER.client/ClientSession.cs:457-466 | cs/remote/src/FASTER.client/ClientSession.cs:479-488 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/remote/src/FASTER.client/ClientSession.cs:457` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `cs/remote/src/FASTER.client/ClientSession.cs:489` calls `ReadKey` and `cs/remote/src/FASTER.client/ClientSession.cs:467` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (10 lines × 2) cs/remote/src/FASTER.client/ClientSession.cs:510— cs/remote/src/FASTER.client/ClientSession.cs:510-519 | cs/remote/src/FASTER.client/ClientSession.cs:531-540 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/remote/src/FASTER.client/ClientSession.cs:510` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `cs/remote/src/FASTER.client/ClientSession.cs:541` calls `ReadKey` and `cs/remote/src/FASTER.client/ClientSession.cs:520` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (10 lines × 2) cs/src/core/Device/LocalStorageDevice.cs:212— cs/src/core/Device/LocalStorageDevice.cs:212-221 | cs/src/core/Device/LocalStorageDevice.cs:279-288 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `cs/src/core/Device/LocalStorageDevice.cs:277` calls `HandleCapacity` and `cs/src/core/Device/LocalStorageDevice.cs:211` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (10 lines × 2) cs/remote/src/FASTER.client/ClientSession.cs:778— cs/remote/src/FASTER.client/ClientSession.cs:778-787 | cs/remote/src/FASTER.client/ClientSession.cs:846-855 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/remote/src/FASTER.client/ClientSession.cs:778` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) cs/stress/SessionWrapper.cs:61— cs/stress/SessionWrapper.cs:61-70 | cs/stress/SessionWrapper.cs:93-102 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/stress/SessionWrapper.cs:61` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) cs/src/core/Epochs/LightEpoch.cs:262— cs/src/core/Epochs/LightEpoch.cs:262-271 | cs/src/core/Epochs/LightEpoch.cs:394-403 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Epochs/LightEpoch.cs:262` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (10 lines × 2) cs/playground/CacheStoreConcurrent/Program.cs:104— cs/playground/CacheStoreConcurrent/Program.cs:104-113 | cs/samples/CacheStore/Program.cs:115-124 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `cs/playground/CacheStoreConcurrent/Program.cs:104` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `cs/samples/CacheStore/Program.cs:114` calls `Collect` and `cs/playground/CacheStoreConcurrent/Program.cs:103` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (10 lines × 2) cs/remote/src/FASTER.server/BinaryServerSession.cs:150— cs/remote/src/FASTER.server/BinaryServerSession.cs:150-159 | cs/remote/src/FASTER.server/WebsocketServerSession.cs:404-414 — before extracting anything, compare `cs/remote/src/FASTER.server/BinaryServerSession.cs` and `cs/remote/src/FASTER.server/WebsocketServerSession.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 189 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `cs/remote/src/FASTER.server/BinaryServerSession.cs:150` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `cs/remote/src/FASTER.server/BinaryServerSession.cs:150` calls `ReadSerialNum` and `cs/remote/src/FASTER.server/WebsocketServerSession.cs:404` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (10 lines × 2) cs/remote/src/FASTER.server/BinaryServerSession.cs:203— cs/remote/src/FASTER.server/BinaryServerSession.cs:203-212 | cs/remote/src/FASTER.server/WebsocketServerSession.cs:458-468 — before extracting anything, compare `cs/remote/src/FASTER.server/BinaryServerSession.cs` and `cs/remote/src/FASTER.server/WebsocketServerSession.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 189 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (10 lines × 2) cs/samples/HelloWorld/Program.cs:64— cs/samples/HelloWorld/Program.cs:64-73 | cs/samples/HelloWorld/Program.cs:174-183 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (5 lines × 2) cs/src/core/Async/ReadAsync.cs:134— cs/src/core/Async/ReadAsync.cs:134-138 | cs/src/core/Index/FASTER/FASTER.cs:610-615 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (5 lines × 2) cs/src/core/ClientSession/ClientSession.cs:1565— cs/src/core/ClientSession/ClientSession.cs:1565-1569 | cs/src/core/ClientSession/LockableContext.cs:1106-1110 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 2) cs/src/core/ClientSession/LockableContext.cs:572— cs/src/core/ClientSession/LockableContext.cs:572-576 | cs/src/core/ClientSession/LockableUnsafeContext.cs:364-368 — before extracting anything, compare `cs/src/core/ClientSession/LockableContext.cs` and `cs/src/core/ClientSession/LockableUnsafeContext.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 2) cs/remote/src/FASTER.client/FixedLenSerializer.cs:33— cs/remote/src/FASTER.client/FixedLenSerializer.cs:33-37 | cs/remote/src/FASTER.server/FixedLenSerializer.cs:87-91 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (5 lines × 2) cs/remote/src/FASTER.client/FixedLenSerializer.cs:42— cs/remote/src/FASTER.client/FixedLenSerializer.cs:42-46 | cs/remote/src/FASTER.server/FixedLenSerializer.cs:96-100 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (5 lines × 2) cs/remote/src/FASTER.server/FixedLenSerializer.cs:33— cs/remote/src/FASTER.server/FixedLenSerializer.cs:33-37 | cs/remote/src/FASTER.server/PubSub/FixedLenKeySerializer.cs:24-28 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 2) cs/remote/src/FASTER.server/FixedLenSerializer.cs:51— cs/remote/src/FASTER.server/FixedLenSerializer.cs:51-55 | cs/remote/src/FASTER.server/PubSub/FixedLenKeySerializer.cs:33-37 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 2) cs/remote/samples/FixedLenServer/Types.cs:137— cs/remote/samples/FixedLenServer/Types.cs:137-141 | cs/src/core/Compaction/LogCompactionFunctions.cs:69-73 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (5 lines × 2) cs/src/core/VarLen/MemoryVarLenStruct.cs:20— cs/src/core/VarLen/MemoryVarLenStruct.cs:20-24 | cs/src/core/VarLen/ReadOnlyMemoryVarLenStruct.cs:20-24 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note first that the copies are not typed on the same thing: the declarations holding them bind `source` to `ref Memory<T>` in one and `ref ReadOnlyMemory<T>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (5 lines × 2) cs/samples/StoreVarLenTypes/MemoryByteSample.cs:53— cs/samples/StoreVarLenTypes/MemoryByteSample.cs:53-57 | cs/samples/StoreVarLenTypes/MemoryIntSample.cs:53-57 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Stateful shared instance: FasterKV cs/src/core/Async/AsyncOperationInternal.cs:13— `FasterKV` is not registered, but `LongValueTester` creates it and keeps it in the static `fkv`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (systemState, maxSessionID, currentSyncStateMachine, callbacks; e.g. `systemState` at line 737).
Stateful shared instance: FasterLog cs/src/core/FasterLog/FasterLog.cs:21— `FasterLog` is not registered, but `Program` creates it and keeps it in the static `log`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (CommittedUntilAddress, CommittedBeginAddress, SafeTailAddress, commitNum, beginAddress, RecoveredIterators; e.g. `CommittedUntilAddress` at line 231).
Stateful shared instance: ManagedLocalStorageDevice cs/src/core/Device/ManagedLocalStorageDevice.cs:17— `ManagedLocalStorageDevice` is not registered, but `Program` creates it and keeps it in the static `device`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (_disposed; e.g. `_disposed` at line 483).
Stateful shared instance: GenericAllocator cs/src/core/Allocator/GenericAllocator.cs:25— `GenericAllocator` is not registered, but the singleton `FasterKV` creates it and keeps it in `hlog`, so one instance outlives every request and is shared by every caller that reaches it — and it mutates instance state outside any lock (values; e.g. `values` at line 110).
Stateful shared instance: DeviceLogCommitCheckpointManager cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs:17— `DeviceLogCommitCheckpointManager` is not registered, but the singleton `FasterLog` creates it and keeps it in `logCommitManager`, so one instance outlives every request and is shared by every caller that reaches it — and it mutates instance state outside any lock (commitCount, flogCommitHistoryOffset, indexTokenHistoryOffset, logTokenHistoryOffset, bufferPool; e.g. `commitCount` at line 114).
Stateful shared instance: LightEpoch cs/src/core/Epochs/LightEpoch.cs:15— `LightEpoch` is not registered, but the singleton `FasterLog` creates it and keeps it in `epoch`, so one instance outlives every request and is shared by every caller that reaches it — and it mutates instance state outside any lock (CurrentEpoch, SafeToReclaimEpoch; e.g. `CurrentEpoch` at line 164).
Stateful shared instance: WorkQueueLIFO cs/src/core/Allocator/WorkQueueLIFO.cs:17— `WorkQueueLIFO` is not registered, but the singleton `FasterLog` creates it and keeps it in `commitQueue`, so one instance outlives every request and is shared by every caller that reaches it — and it mutates instance state outside any lock (_disposed; e.g. `_disposed` at line 35).
Stateful shared instance: LogSizeTracker cs/samples/ResizableCacheStore/LogSizeTracker.cs:10— `LogSizeTracker` is not registered, but the singleton `CacheSizeTracker` creates it and keeps it in `mainLog`, so one instance outlives every request and is shared by every caller that reaches it — and it mutates instance state outside any lock (TargetSizeBytes; e.g. `TargetSizeBytes` at line 61).
Stateful shared instance: WorkQueueFIFO cs/src/core/Allocator/WorkQueueFIFO.cs:17— `WorkQueueFIFO` is not registered, but the singleton `DeviceLogCommitCheckpointManager` creates it and keeps it in `deleteQueue`, so one instance outlives every request and is shared by every caller that reaches it — and it mutates instance state outside any lock (_disposed; e.g. `_disposed` at line 35).
D4 · Code Duplication· Edited copy of a member (6 corresponding lines) · ×9
Edited copy of a member (6 corresponding lines) cs/src/core/Async/ReadAsync.cs:146— cs/src/core/Async/ReadAsync.cs:146-151 | cs/src/core/Async/RMWAsync.cs:154-159 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (6 corresponding lines) cs/src/core/ClientSession/ClientSession.cs:1200— cs/src/core/ClientSession/ClientSession.cs:1200-1205 | cs/src/core/ClientSession/ClientSession.cs:1265-1270 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (6 corresponding lines) cs/src/core/Index/Recovery/IndexCheckpoint.cs:38— cs/src/core/Index/Recovery/IndexCheckpoint.cs:38-44 | cs/src/core/Index/Recovery/IndexRecovery.cs:77-82 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (6 corresponding lines) cs/remote/src/FASTER.client/FixedLenSerializer.cs:32— cs/remote/src/FASTER.client/FixedLenSerializer.cs:32-37 | cs/remote/src/FASTER.server/FixedLenSerializer.cs:86-91 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (6 corresponding lines) cs/remote/src/FASTER.client/FixedLenSerializer.cs:41— cs/remote/src/FASTER.client/FixedLenSerializer.cs:41-46 | cs/remote/src/FASTER.server/FixedLenSerializer.cs:95-100 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (6 corresponding lines) cs/src/core/ClientSession/ClientSession.cs:1394— cs/src/core/ClientSession/ClientSession.cs:1394-1399 | cs/src/core/ClientSession/LockableContext.cs:1003-1009 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (6 corresponding lines) cs/src/core/ClientSession/ClientSession.cs:1274— cs/src/core/ClientSession/ClientSession.cs:1274-1279 | cs/src/core/ClientSession/LockableContext.cs:956-962 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (6 corresponding lines) cs/playground/AsyncStress/FasterWrapper.cs:57— cs/playground/AsyncStress/FasterWrapper.cs:57-62 | cs/playground/AsyncStress/SerializedUpdaters.cs:27-32 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (6 corresponding lines) cs/playground/AsyncStress/FasterWrapper.cs:65— cs/playground/AsyncStress/FasterWrapper.cs:65-70 | cs/playground/AsyncStress/SerializedUpdaters.cs:44-49 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (9 lines × 2) cs/src/core/Index/FASTER/Implementation/InternalDelete.cs:139— cs/src/core/Index/FASTER/Implementation/InternalDelete.cs:139-147 | cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs:129-137 — before extracting anything, compare `cs/src/core/Index/FASTER/Implementation/InternalDelete.cs` and `cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 55 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Index/FASTER/Implementation/InternalDelete.cs:139` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (9 lines × 2) cs/remote/src/FASTER.server/BinaryServerSession.cs:165— cs/remote/src/FASTER.server/BinaryServerSession.cs:165-173 | cs/remote/src/FASTER.server/WebsocketServerSession.cs:421-429 — before extracting anything, compare `cs/remote/src/FASTER.server/BinaryServerSession.cs` and `cs/remote/src/FASTER.server/WebsocketServerSession.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 189 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `cs/remote/src/FASTER.server/BinaryServerSession.cs:165` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:135— cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:135-143 | cs/remote/src/FASTER.server/PubSub/SubscribeKVBroker.cs:97-105 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:135` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) cs/src/core/Allocator/AllocatorBase.cs:1898— cs/src/core/Allocator/AllocatorBase.cs:1898-1906 | cs/src/core/Allocator/GenericAllocator.cs:729-737 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note first that the copies are not typed on the same thing: the declarations holding them bind `context` to `ref AsyncIOContext<Key, Value>` in one and `AsyncIOContext<Key, Value>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (9 lines × 2) cs/src/core/FasterLog/FasterLog.cs:779— cs/src/core/FasterLog/FasterLog.cs:779-787 | cs/src/core/FasterLog/FasterLog.cs:913-921 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) cs/playground/FasterLogMLSDTest/Program.cs:90— cs/playground/FasterLogMLSDTest/Program.cs:90-98 | cs/playground/FasterLogMLSDTest/Program.cs:139-147 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) cs/src/core/Allocator/BlittableAllocator.cs:299— cs/src/core/Allocator/BlittableAllocator.cs:299-307 | cs/src/core/Allocator/VarLenBlittableAllocator.cs:404-412 — before extracting anything, compare `cs/src/core/Allocator/BlittableAllocator.cs` and `cs/src/core/Allocator/VarLenBlittableAllocator.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 179 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (9 lines × 2) cs/remote/src/FASTER.server/BinaryServerSession.cs:40— cs/remote/src/FASTER.server/BinaryServerSession.cs:40-48 | cs/remote/src/FASTER.server/WebsocketServerSession.cs:44-52 — before extracting anything, compare `cs/remote/src/FASTER.server/BinaryServerSession.cs` and `cs/remote/src/FASTER.server/WebsocketServerSession.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 189 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (9 lines × 2) cs/remote/src/FASTER.server/Servers/GenericServer.cs:96— cs/remote/src/FASTER.server/Servers/GenericServer.cs:96-104 | cs/remote/src/FASTER.server/Servers/VarLenServer.cs:79-87 — before extracting anything, compare `cs/remote/src/FASTER.server/Servers/GenericServer.cs` and `cs/remote/src/FASTER.server/Servers/VarLenServer.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 53 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
AX2 · Stateful singletons· Process-global static state · ×8
Process-global static state: FasterSpanByteYcsbBenchmark cs/benchmark/FasterSpanByteYcsbBenchmark.cs:15— `FasterSpanByteYcsbBenchmark` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (InitCount, TxnCount; e.g. `InitCount` at line 626). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
Process-global static state: FASTER_YcsbBenchmark cs/benchmark/FasterYcsbBenchmark.cs:15— `FASTER_YcsbBenchmark` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (InitCount, TxnCount; e.g. `InitCount` at line 589). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
Process-global static state: LongValueTester cs/stress/LongValueTester.cs:9— `LongValueTester` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (fkv; e.g. `fkv` at line 36). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
Process-global static state: SpanByteKeyTester cs/stress/SpanByteKeyTester.cs:35— `SpanByteKeyTester` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (keys; e.g. `keys` at line 89). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
Process-global static state: SpanByteValueTester cs/stress/SpanByteValueTester.cs:9— `SpanByteValueTester` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (fkv, values; e.g. `fkv` at line 38). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
Process-global static state: StringKeyTester cs/stress/StringKeyTester.cs:8— `StringKeyTester` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (keys; e.g. `keys` at line 66). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
Process-global static state: StringValueTester cs/stress/StringValueTester.cs:9— `StringValueTester` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (fkv, values; e.g. `fkv` at line 38). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
Process-global static state: Native32 cs/src/core/Utilities/Native32.cs:16— `Native32` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (processPrivilegeEnabled; e.g. `processPrivilegeEnabled` at line 322). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
D4 · Code Duplication· Edited copy of a member (5 corresponding lines) · ×7
Edited copy of a member (5 corresponding lines) cs/src/core/ClientSession/LockableUnsafeContext.cs:462— cs/src/core/ClientSession/LockableUnsafeContext.cs:462-466 | cs/src/core/ClientSession/UnsafeContext.cs:337-341 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (5 corresponding lines) cs/src/core/ClientSession/LockableUnsafeContext.cs:575— cs/src/core/ClientSession/LockableUnsafeContext.cs:575-579 | cs/src/core/ClientSession/UnsafeContext.cs:447-451 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (5 corresponding lines) cs/src/core/ClientSession/LockableUnsafeContext.cs:632— cs/src/core/ClientSession/LockableUnsafeContext.cs:632-636 | cs/src/core/ClientSession/UnsafeContext.cs:504-508 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (5 corresponding lines) cs/src/core/ClientSession/LockableUnsafeContext.cs:605— cs/src/core/ClientSession/LockableUnsafeContext.cs:605-609 | cs/src/core/ClientSession/UnsafeContext.cs:477-481 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (5 corresponding lines) cs/src/core/Async/UpsertAsync.cs:77— cs/src/core/Async/UpsertAsync.cs:77-83 | cs/src/core/Async/DeleteAsync.cs:68-72 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (5 corresponding lines) cs/src/core/Async/DeleteAsync.cs:121— cs/src/core/Async/DeleteAsync.cs:121-125 | cs/src/core/Async/UpsertAsync.cs:146-150 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (5 corresponding lines) cs/src/core/VarLen/MemoryFunctions.cs:83— cs/src/core/VarLen/MemoryFunctions.cs:83-87 | cs/src/core/VarLen/SpanByteFunctions.cs:56-60 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (7 corresponding lines) · ×7
Edited copy of a member (7 corresponding lines) cs/src/core/Async/ReadAsync.cs:76— cs/src/core/Async/ReadAsync.cs:76-82 | cs/src/core/Async/RMWAsync.cs:77-83 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (7 corresponding lines) cs/stress/LongValueTester.cs:21— cs/stress/LongValueTester.cs:21-27 | cs/stress/StringValueTester.cs:22-29 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (7 corresponding lines) cs/src/core/Allocator/VarLenBlittableAllocator.cs:228— cs/src/core/Allocator/VarLenBlittableAllocator.cs:228-234 | cs/src/core/Allocator/VarLenBlittableAllocator.cs:237-243 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (7 corresponding lines) cs/src/core/Allocator/BlittableScanIterator.cs:40— cs/src/core/Allocator/BlittableScanIterator.cs:40-46 | cs/src/core/Allocator/VarLenBlittableScanIterator.cs:41-47 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (7 corresponding lines) cs/src/core/ClientSession/ClientSession.cs:1476— cs/src/core/ClientSession/ClientSession.cs:1476-1482 | cs/src/core/ClientSession/LockableContext.cs:1031-1038 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (7 corresponding lines) cs/src/core/Allocator/BlittableAllocator.cs:230— cs/src/core/Allocator/BlittableAllocator.cs:230-236 | cs/src/core/Allocator/VarLenBlittableAllocator.cs:336-342 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (7 corresponding lines) cs/samples/StoreVarLenTypes/AsciiSumSpanByteFunctions.cs:28— cs/samples/StoreVarLenTypes/AsciiSumSpanByteFunctions.cs:28-34 | cs/samples/StoreVarLenTypes/AsciiSumSpanByteFunctions.cs:38-44 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (11 lines × 2) cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs:189— cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs:189-199 | cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs:236-246 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs:189` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) cs/remote/src/FASTER.server/BinaryServerSession.cs:438— cs/remote/src/FASTER.server/BinaryServerSession.cs:438-448 | cs/remote/src/FASTER.server/WebsocketServerSession.cs:548-558 — before extracting anything, compare `cs/remote/src/FASTER.server/BinaryServerSession.cs` and `cs/remote/src/FASTER.server/WebsocketServerSession.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 189 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (11 lines × 2) cs/remote/src/FASTER.server/BinaryServerSession.cs:454— cs/remote/src/FASTER.server/BinaryServerSession.cs:454-464 | cs/remote/src/FASTER.server/WebsocketServerSession.cs:565-575 — before extracting anything, compare `cs/remote/src/FASTER.server/BinaryServerSession.cs` and `cs/remote/src/FASTER.server/WebsocketServerSession.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 189 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (11 lines × 2) cs/src/core/FasterLog/FasterLog.cs:742— cs/src/core/FasterLog/FasterLog.cs:742-752 | cs/src/core/FasterLog/FasterLog.cs:772-782 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `cs/src/core/FasterLog/FasterLog.cs:783` calls `CopyTo` and `cs/src/core/FasterLog/FasterLog.cs:753` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (11 lines × 2) cs/remote/src/FASTER.common/TcpNetworkSender.cs:60— cs/remote/src/FASTER.common/TcpNetworkSender.cs:60-70 | cs/remote/src/FASTER.common/TcpNetworkSender.cs:84-94 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (11 lines × 2) cs/src/core/Index/Recovery/Recovery.cs:736— cs/src/core/Index/Recovery/Recovery.cs:736-746 | cs/src/core/Index/Recovery/Recovery.cs:776-786 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Index/Recovery/Recovery.cs:736` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) cs/samples/FasterLogSample/Program.cs:62— cs/samples/FasterLogSample/Program.cs:62-72 | cs/samples/StoreAsyncApi/Program.cs:36-46 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `cs/samples/FasterLogSample/Program.cs:62` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Unfinished stub — throws NotImplementedException cs/src/core/Device/LocalStorageDevice.cs:546— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException cs/src/core/Device/LocalStorageDevice.cs:548— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException cs/src/core/Device/LocalStorageDevice.cs:550— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException cs/src/core/Device/LocalStorageDevice.cs:552— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException cs/src/core/Index/Recovery/Checkpoint.cs:93— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException cs/remote/src/FASTER.common/TcpNetworkSender.cs:157— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException cs/remote/src/FASTER.common/TcpNetworkSender.cs:163— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException cs/remote/src/FASTER.common/TcpNetworkSender.cs:157— `SendResponse` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException cs/remote/src/FASTER.common/TcpNetworkSender.cs:163— `SendCallback` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException cs/src/core/Device/LocalStorageDevice.cs:546— `AsyncState` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException cs/src/core/Device/LocalStorageDevice.cs:548— `AsyncWaitHandle` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException cs/src/core/Device/LocalStorageDevice.cs:550— `CompletedSynchronously` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException cs/src/core/Device/LocalStorageDevice.cs:552— `IsCompleted` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException cs/src/core/Index/Recovery/Checkpoint.cs:93— `Compact` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
FileTooLong: FasterLog/FasterLog.cs cs/src/core/FasterLog/FasterLog.cs— FileTooLong — 1367 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 867 over it, 2.73× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Allocator/AllocatorBase.cs cs/src/core/Allocator/AllocatorBase.cs— FileTooLong — 1020 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 520 over it, 2.04× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: ClientSession/ClientSession.cs cs/src/core/ClientSession/ClientSession.cs— FileTooLong — 795 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 295 over it, 1.59× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Recovery/Recovery.cs cs/src/core/Index/Recovery/Recovery.cs— FileTooLong — 608 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 108 over it, 1.22× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: ClientSession/LockableContext.cs cs/src/core/ClientSession/LockableContext.cs— FileTooLong — 600 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 100 over it, 1.20× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Allocator/GenericAllocator.cs cs/src/core/Allocator/GenericAllocator.cs— FileTooLong — 558 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 58 over it, 1.12× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
D4 · Code Duplication· Edited copy of a member (21 corresponding lines) · ×6
Edited copy of a member (21 corresponding lines) cs/src/core/Allocator/AllocatorBase.cs:1893— cs/src/core/Allocator/AllocatorBase.cs:1893-1913 | cs/src/core/Allocator/GenericAllocator.cs:724-747 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (21 corresponding lines) cs/src/core/Async/ReadAsync.cs:107— cs/src/core/Async/ReadAsync.cs:107-127 | cs/src/core/Async/RMWAsync.cs:116-136 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (21 corresponding lines) cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs:186— cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs:186-206 | cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs:233-253 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (21 corresponding lines) cs/src/core/FasterLog/FasterLog.cs:1854— cs/src/core/FasterLog/FasterLog.cs:1854-1874 | cs/src/core/FasterLog/FasterLog.cs:1885-1905 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (21 corresponding lines) cs/remote/samples/VarLenClient/CustomTypeSamples.cs:63— cs/remote/samples/VarLenClient/CustomTypeSamples.cs:63-83 | cs/remote/samples/VarLenClient/CustomTypeSamples.cs:87-107 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (21 corresponding lines) cs/stress/TestLoader.cs:223— cs/stress/TestLoader.cs:223-245 | cs/stress/TestLoader.cs:248-268 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (9 corresponding lines) · ×6
Edited copy of a member (9 corresponding lines) cs/src/core/Async/ReadAsync.cs:31— cs/src/core/Async/ReadAsync.cs:31-39 | cs/src/core/Async/RMWAsync.cs:31-39 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) cs/src/core/Allocator/BlittableAllocator.cs:241— cs/src/core/Allocator/BlittableAllocator.cs:241-249 | cs/src/core/Allocator/VarLenBlittableAllocator.cs:347-355 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) cs/src/core/Index/Recovery/Recovery.cs:1071— cs/src/core/Index/Recovery/Recovery.cs:1071-1079 | cs/src/core/Index/Recovery/Recovery.cs:1091-1099 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) cs/stress/StringKeyTester.cs:61— cs/stress/StringKeyTester.cs:61-69 | cs/stress/LongKeyTester.cs:58-66 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) cs/src/core/Utilities/Utility.cs:88— cs/src/core/Utilities/Utility.cs:88-96 | cs/remote/src/FASTER.server/Servers/ServerOptions.cs:275-283 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:410— cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:410-418 | cs/remote/src/FASTER.server/PubSub/SubscribeKVBroker.cs:262-270 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (17 lines × 2) cs/src/core/Allocator/BlittableScanIterator.cs:95— cs/src/core/Allocator/BlittableScanIterator.cs:95-111 | cs/src/core/Allocator/VarLenBlittableScanIterator.cs:98-114 — before extracting anything, compare `cs/src/core/Allocator/BlittableScanIterator.cs` and `cs/src/core/Allocator/VarLenBlittableScanIterator.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 90 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (17 lines × 2) cs/src/core/Device/LocalStorageDevice.cs:179— cs/src/core/Device/LocalStorageDevice.cs:179-195 | cs/src/core/Device/ManagedLocalStorageDevice.cs:102-118 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Device/LocalStorageDevice.cs:179` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 2) cs/remote/src/FASTER.server/PubSub/SubscribeKVBroker.cs:191— cs/remote/src/FASTER.server/PubSub/SubscribeKVBroker.cs:191-207 | cs/remote/src/FASTER.server/PubSub/SubscribeKVBroker.cs:224-240 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (17 lines × 2) cs/src/core/FasterLog/FasterLog.cs:495— cs/src/core/FasterLog/FasterLog.cs:495-511 | cs/src/core/FasterLog/FasterLog.cs:577-593 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (17 lines × 2) cs/src/core/FasterLog/FasterLog.cs:861— cs/src/core/FasterLog/FasterLog.cs:861-877 | cs/src/core/FasterLog/FasterLog.cs:900-916 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `cs/src/core/FasterLog/FasterLog.cs:917` calls `CopyTo` and `cs/src/core/FasterLog/FasterLog.cs:878` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (17 lines × 2) cs/src/core/Device/ManagedLocalStorageDevice.cs:238— cs/src/core/Device/ManagedLocalStorageDevice.cs:238-265 | cs/src/core/Device/ManagedLocalStorageDevice.cs:407-423 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Device/ManagedLocalStorageDevice.cs:238` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (15 lines × 2) cs/src/core/Allocator/WorkQueueFIFO.cs:62— cs/src/core/Allocator/WorkQueueFIFO.cs:62-76 | cs/src/core/Allocator/WorkQueueLIFO.cs:62-76 — before extracting anything, compare `cs/src/core/Allocator/WorkQueueFIFO.cs` and `cs/src/core/Allocator/WorkQueueLIFO.cs` as WHOLE FILES: 85% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Allocator/WorkQueueFIFO.cs:62` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) cs/src/core/Allocator/BlittableAllocator.cs:152— cs/src/core/Allocator/BlittableAllocator.cs:152-166 | cs/src/core/Allocator/VarLenBlittableAllocator.cs:260-274 — before extracting anything, compare `cs/src/core/Allocator/BlittableAllocator.cs` and `cs/src/core/Allocator/VarLenBlittableAllocator.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 179 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (15 lines × 2) cs/remote/src/FASTER.server/WebsocketServerSession.cs:545— cs/remote/src/FASTER.server/WebsocketServerSession.cs:545-559 | cs/remote/src/FASTER.server/WebsocketServerSession.cs:562-576 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (15 lines × 2) cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:131— cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:131-145 | cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:164-180 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:131` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) cs/remote/src/FASTER.client/FixedLenSerializer.cs:88— cs/remote/src/FASTER.client/FixedLenSerializer.cs:88-102 | cs/remote/src/FASTER.server/FixedLenSerializer.cs:135-149 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (15 lines × 2) cs/samples/StoreVarLenTypes/MemoryByteSample.cs:64— cs/samples/StoreVarLenTypes/MemoryByteSample.cs:64-78 | cs/samples/StoreVarLenTypes/MemoryIntSample.cs:64-78 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `cs/samples/StoreVarLenTypes/MemoryByteSample.cs:64` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (5 lines × 3) cs/remote/src/FASTER.client/MemoryParameterSerializer.cs:32— cs/remote/src/FASTER.client/MemoryParameterSerializer.cs:32-36 | cs/remote/src/FASTER.client/MemoryParameterSerializer.cs:43-47 | cs/remote/src/FASTER.client/MemoryParameterSerializer.cs:54-58 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `src` to `ref byte*` in one and `int) ReadOutput(ref byte*` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (5 lines × 3) cs/stress/LongValueTester.cs:52— cs/stress/LongValueTester.cs:52-56 | cs/stress/SpanByteValueTester.cs:56-60 | cs/stress/StringValueTester.cs:54-58 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (5 lines × 3) cs/src/core/ClientSession/LockableContext.cs:543— cs/src/core/ClientSession/LockableContext.cs:543-547 | cs/src/core/ClientSession/LockableUnsafeContext.cs:335-339 | cs/src/core/ClientSession/UnsafeContext.cs:201-205 — before extracting anything, compare `cs/src/core/ClientSession/LockableContext.cs` and `cs/src/core/ClientSession/LockableUnsafeContext.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 3) cs/src/core/ClientSession/LockableContext.cs:563— cs/src/core/ClientSession/LockableContext.cs:563-567 | cs/src/core/ClientSession/LockableUnsafeContext.cs:355-359 | cs/src/core/ClientSession/UnsafeContext.cs:230-234 — before extracting anything, compare `cs/src/core/ClientSession/LockableContext.cs` and `cs/src/core/ClientSession/LockableUnsafeContext.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 3) cs/src/core/ClientSession/LockableContext.cs:581— cs/src/core/ClientSession/LockableContext.cs:581-585 | cs/src/core/ClientSession/LockableUnsafeContext.cs:373-377 | cs/src/core/ClientSession/UnsafeContext.cs:248-252 — before extracting anything, compare `cs/src/core/ClientSession/LockableContext.cs` and `cs/src/core/ClientSession/LockableUnsafeContext.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 3) cs/remote/src/FASTER.server/BinaryServerSession.cs:341— cs/remote/src/FASTER.server/BinaryServerSession.cs:341-345 | cs/remote/src/FASTER.server/WebsocketServerSession.cs:696-700 | cs/remote/src/FASTER.server/WebsocketServerSession.cs:714-718 — before extracting anything, compare `cs/remote/src/FASTER.server/BinaryServerSession.cs` and `cs/remote/src/FASTER.server/WebsocketServerSession.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 189 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication· Members sharing a duplicated core (4 members, 50+ identical tokens) · ×5
Members sharing a duplicated core (4 members, 50+ identical tokens) cs/stress/SessionWrapper.cs:55— cs/stress/SessionWrapper.cs:55-70 | cs/stress/SessionWrapper.cs:83-108 | cs/stress/SessionWrapper.cs:144-158 | cs/stress/SessionWrapper.cs:171-195 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) cs/src/core/FasterLog/FasterLog.cs:1492— cs/src/core/FasterLog/FasterLog.cs:1492-1534 | cs/src/core/FasterLog/FasterLog.cs:1596-1638 | cs/src/core/FasterLog/FasterLog.cs:1649-1691 | cs/src/core/FasterLog/FasterLog.cs:1703-1745 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) cs/src/core/Index/FASTER/Implementation/ConditionalCopyToTail.cs:112— cs/src/core/Index/FASTER/Implementation/ConditionalCopyToTail.cs:112-136 | cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:52-233 | cs/src/core/Index/FASTER/Implementation/InternalRead.cs:50-172 | cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs:48-217 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) cs/remote/src/FASTER.server/BinaryServerSession.cs:60— cs/remote/src/FASTER.server/BinaryServerSession.cs:60-74 | cs/remote/src/FASTER.server/BinaryServerSession.cs:77-91 | cs/remote/src/FASTER.server/WebsocketServerSession.cs:66-80 | cs/remote/src/FASTER.server/WebsocketServerSession.cs:83-100 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:210— cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:210-230 | cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:240-260 | cs/remote/src/FASTER.server/PubSub/SubscribeKVBroker.cs:189-212 | cs/remote/src/FASTER.server/PubSub/SubscribeKVBroker.cs:222-245 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication· Edited copy of a member (12 corresponding lines) · ×5
Edited copy of a member (12 corresponding lines) cs/src/core/VarLen/MemoryVarLenStruct.cs:34— cs/src/core/VarLen/MemoryVarLenStruct.cs:34-46 | cs/src/core/VarLen/ReadOnlyMemoryVarLenStruct.cs:34-45 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (12 corresponding lines) cs/playground/AsyncStress/FasterWrapper.cs:157— cs/playground/AsyncStress/FasterWrapper.cs:157-168 | cs/playground/AsyncStress/SerializedFasterWrapper.cs:225-236 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (12 corresponding lines) cs/src/core/FasterLog/FasterLog.cs:2847— cs/src/core/FasterLog/FasterLog.cs:2847-2858 | cs/src/core/FasterLog/FasterLog.cs:2862-2874 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (12 corresponding lines) cs/src/core/ClientSession/LockableContext.cs:474— cs/src/core/ClientSession/LockableContext.cs:474-485 | cs/src/core/ClientSession/LockableContext.cs:626-637 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (12 corresponding lines) cs/src/core/ClientSession/LockableContext.cs:600— cs/src/core/ClientSession/LockableContext.cs:600-611 | cs/src/core/ClientSession/LockableContext.cs:626-637 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (19 lines × 2) cs/remote/src/FASTER.client/ClientSession.cs:707— cs/remote/src/FASTER.client/ClientSession.cs:707-725 | cs/remote/src/FASTER.client/ClientSession.cs:821-839 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (19 lines × 2) cs/remote/src/FASTER.client/ClientSession.cs:753— cs/remote/src/FASTER.client/ClientSession.cs:753-771 | cs/remote/src/FASTER.client/ClientSession.cs:798-816 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (19 lines × 2) cs/src/devices/AzureStorageDevice/AzureStorageDevice.cs:95— cs/src/devices/AzureStorageDevice/AzureStorageDevice.cs:95-113 | cs/src/devices/AzureStorageDevice/AzureStorageDevice.cs:130-148 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/devices/AzureStorageDevice/AzureStorageDevice.cs:95` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (19 lines × 2) cs/src/core/Allocator/BlittableAllocator.cs:75— cs/src/core/Allocator/BlittableAllocator.cs:75-93 | cs/src/core/Allocator/VarLenBlittableAllocator.cs:94-112 — before extracting anything, compare `cs/src/core/Allocator/BlittableAllocator.cs` and `cs/src/core/Allocator/VarLenBlittableAllocator.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 179 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (19 lines × 2) cs/src/core/Allocator/BlittableAllocator.cs:75— cs/src/core/Allocator/BlittableAllocator.cs:75-93 | cs/src/core/Allocator/VarLenBlittableAllocator.cs:94-112 — before extracting anything, compare `cs/src/core/Allocator/BlittableAllocator.cs` and `cs/src/core/Allocator/VarLenBlittableAllocator.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 179 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (14 lines × 2) cs/stress/SpanByteValueTester.cs:74— cs/stress/SpanByteValueTester.cs:74-87 | cs/stress/StringValueTester.cs:72-85 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `cs/stress/SpanByteValueTester.cs:74` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (14 lines × 2) cs/src/core/Index/FASTER/Implementation/ConditionalCopyToTail.cs:120— cs/src/core/Index/FASTER/Implementation/ConditionalCopyToTail.cs:120-133 | cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs:179-192 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (14 lines × 2) cs/src/core/Index/FASTER/Implementation/InternalDelete.cs:159— cs/src/core/Index/FASTER/Implementation/InternalDelete.cs:159-172 | cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs:148-162 — before extracting anything, compare `cs/src/core/Index/FASTER/Implementation/InternalDelete.cs` and `cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 55 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Index/FASTER/Implementation/InternalDelete.cs:159` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:104— cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:104-117 | cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:136-149 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (14 lines × 2) cs/src/core/VarLen/FixedLengthStruct.cs:21— cs/src/core/VarLen/FixedLengthStruct.cs:21-34 | cs/src/core/VarLen/IVariableLengthStruct.cs:37-60 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (13 lines × 2) cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:203— cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:203-215 | cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs:185-197 — before extracting anything, compare `cs/src/core/Index/FASTER/Implementation/InternalRMW.cs` and `cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 125 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:203` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (13 lines × 2) cs/src/core/Allocator/ScanIteratorBase.cs:112— cs/src/core/Allocator/ScanIteratorBase.cs:112-124 | cs/src/core/Allocator/ScanIteratorBase.cs:262-274 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (13 lines × 2) cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:199— cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:199-211 | cs/src/core/Index/FASTER/Implementation/InternalRead.cs:156-168 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:199` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) cs/remote/src/FASTER.server/BinaryServerSession.cs:423— cs/remote/src/FASTER.server/BinaryServerSession.cs:423-435 | cs/remote/src/FASTER.server/WebsocketServerSession.cs:532-544 — before extracting anything, compare `cs/remote/src/FASTER.server/BinaryServerSession.cs` and `cs/remote/src/FASTER.server/WebsocketServerSession.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 189 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (13 lines × 2) cs/samples/HelloWorld/Program.cs:31— cs/samples/HelloWorld/Program.cs:31-43 | cs/samples/HelloWorld/Program.cs:105-118 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (5 lines × 4) cs/remote/src/FASTER.server/BinaryServerSession.cs:387— cs/remote/src/FASTER.server/BinaryServerSession.cs:387-391 | cs/remote/src/FASTER.server/BinaryServerSession.cs:409-413 | cs/remote/src/FASTER.server/BinaryServerSession.cs:445-449 | cs/remote/src/FASTER.server/BinaryServerSession.cs:461-465 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 4) cs/remote/src/FASTER.server/WebsocketServerSession.cs:490— cs/remote/src/FASTER.server/WebsocketServerSession.cs:490-495 | cs/remote/src/FASTER.server/WebsocketServerSession.cs:513-518 | cs/remote/src/FASTER.server/WebsocketServerSession.cs:554-558 | cs/remote/src/FASTER.server/WebsocketServerSession.cs:571-575 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `cs/remote/src/FASTER.server/WebsocketServerSession.cs:496` calls `Write` and `cs/remote/src/FASTER.server/WebsocketServerSession.cs:559` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (5 lines × 4) cs/src/core/ClientSession/ClientSession.cs:339— cs/src/core/ClientSession/ClientSession.cs:339-343 | cs/src/core/ClientSession/LockableContext.cs:447-451 | cs/src/core/ClientSession/LockableUnsafeContext.cs:255-259 | cs/src/core/ClientSession/UnsafeContext.cs:131-135 — before extracting anything, compare `cs/src/core/ClientSession/LockableContext.cs` and `cs/src/core/ClientSession/LockableUnsafeContext.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 4) cs/src/core/ClientSession/ClientSession.cs:348— cs/src/core/ClientSession/ClientSession.cs:348-352 | cs/src/core/ClientSession/LockableContext.cs:456-460 | cs/src/core/ClientSession/LockableUnsafeContext.cs:264-268 | cs/src/core/ClientSession/UnsafeContext.cs:140-144 — before extracting anything, compare `cs/src/core/ClientSession/LockableContext.cs` and `cs/src/core/ClientSession/LockableUnsafeContext.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 4) cs/src/core/ClientSession/ClientSession.cs:357— cs/src/core/ClientSession/ClientSession.cs:357-361 | cs/src/core/ClientSession/LockableContext.cs:465-469 | cs/src/core/ClientSession/LockableUnsafeContext.cs:273-277 | cs/src/core/ClientSession/UnsafeContext.cs:149-153 — before extracting anything, compare `cs/src/core/ClientSession/LockableContext.cs` and `cs/src/core/ClientSession/LockableUnsafeContext.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
X18 · Disposal-pattern correctness· Disposable created and abandoned in the method that made it · ×5
Disposable created and abandoned in the method that made it cs/stress/StressApp.cs:58— `ctsBackground` is a `CancellationTokenSource`, which implements `IDisposable`, and it is created here (line 58). Every use of it in `Main` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var ctsBackground = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it cs/stress/TestLoader.cs:24— `parser` is a `Parser`, which implements `IDisposable`, and it is created here (line 24). Every use of it in `TestLoader` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var parser = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it cs/src/core/Device/StorageDeviceBase.cs:195— `completionEvent` is a `ManualResetEventSlim`, which implements `IDisposable`, and it is created here (line 195). Every use of it in `RemoveSegment` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var completionEvent = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it cs/remote/samples/VarLenServer/Program.cs:30— `loggerFactory` is a `ILoggerFactory`, which implements `IDisposable`, and it is created here (line 30). Every use of it in `Main` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var loggerFactory = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it cs/remote/samples/FixedLenServer/Program.cs:32— `loggerFactory` is a `ILoggerFactory`, which implements `IDisposable`, and it is created here (line 32). Every use of it in `Main` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var loggerFactory = …;`), which releases it at the end of the scope on every path including a throw.
MethodTooLong: WebsocketServerSession.ProcessBatch cs/remote/src/FASTER.server/WebsocketServerSession.cs:282— MethodTooLong — ProcessBatch runs 205 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 105 over it, 2.05× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ClientSession.ProcessReplies cs/remote/src/FASTER.client/ClientSession.cs:338— MethodTooLong — ProcessReplies runs 150 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 50 over it, 1.50× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: GenericAllocator.WriteAsync cs/src/core/Allocator/GenericAllocator.cs:375— MethodTooLong — WriteAsync runs 121 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 21 over it, 1.21× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: FasterKV.InternalRMW cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:48— MethodTooLong — InternalRMW runs 103 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 3 over it, 1.03× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
D4 · Code Duplication· Edited copy of a member (23 corresponding lines) · ×4
Edited copy of a member (23 corresponding lines) cs/src/core/VarLen/SpanByte.cs:418— cs/src/core/VarLen/SpanByte.cs:418-441 | cs/remote/src/FASTER.server/SpanByteFunctionsForServer.cs:41-63 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (23 corresponding lines) cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:269— cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:269-291 | cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:300-322 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (23 corresponding lines) cs/src/core/Allocator/AllocatorBase.cs:653— cs/src/core/Allocator/AllocatorBase.cs:653-675 | cs/src/core/Index/Recovery/Recovery.cs:907-933 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (23 corresponding lines) cs/src/core/FasterLog/FasterLog.cs:2626— cs/src/core/FasterLog/FasterLog.cs:2626-2648 | cs/src/core/FasterLog/FasterLog.cs:2651-2675 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (15 corresponding lines) · ×4
Edited copy of a member (15 corresponding lines) cs/src/core/Index/Common/Contexts.cs:722— cs/src/core/Index/Common/Contexts.cs:722-736 | cs/src/core/Index/Common/Contexts.cs:740-754 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (15 corresponding lines) cs/src/core/FasterLog/FasterLogIterator.cs:77— cs/src/core/FasterLog/FasterLogIterator.cs:77-92 | cs/src/core/FasterLog/FasterLogIterator.cs:99-113 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (15 corresponding lines) cs/src/core/Allocator/AtomicOwner.cs:26— cs/src/core/Allocator/AtomicOwner.cs:26-40 | cs/src/core/Allocator/AtomicOwner.cs:70-88 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (15 corresponding lines) cs/src/core/Device/ManagedLocalStorageDevice.cs:517— cs/src/core/Device/ManagedLocalStorageDevice.cs:517-531 | cs/src/core/Device/ManagedLocalStorageDevice.cs:534-552 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (18 lines × 2) cs/src/core/FasterLog/FasterLog.cs:1855— cs/src/core/FasterLog/FasterLog.cs:1855-1872 | cs/src/core/FasterLog/FasterLog.cs:1886-1903 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (18 lines × 2) cs/src/core/Index/FASTER/FASTERBase.cs:162— cs/src/core/Index/FASTER/FASTERBase.cs:162-179 | cs/src/core/Index/FASTER/FASTERBase.cs:200-217 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Index/FASTER/FASTERBase.cs:162` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (18 lines × 2) cs/playground/CacheStoreConcurrent/Types.cs:79— cs/playground/CacheStoreConcurrent/Types.cs:79-96 | cs/samples/CacheStore/Types.cs:87-104 — before extracting anything, compare `cs/playground/CacheStoreConcurrent/Types.cs` and `cs/samples/CacheStore/Types.cs` as WHOLE FILES: 82% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (18 lines × 2) cs/samples/StoreAsyncApi/Types.cs:98— cs/samples/StoreAsyncApi/Types.cs:98-115 | cs/samples/StoreLogCompaction/Types.cs:104-121 — `cs/samples/StoreAsyncApi/Types.cs` and `cs/samples/StoreLogCompaction/Types.cs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 1 separate duplicated blocks between them, totalling at least 18 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
X15 · Unvalidated length from an untrusted reader· Length read from the parsed input is spent without ever being bounded · ×4
Length read from the parsed input is spent without ever being bounded cs/src/core/FasterLog/FasterLogRecoveryInfo.cs:109— `len` is read from the stream being parsed at line 108 (`ReadInt32`), then read in bulk from that same stream at line 109 — and nowhere in this method is `len` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). A file the caller did not write therefore chooses the size directly: a value near `int.MaxValue` allocates until the process dies, and a value that overflows the cast to `int` goes negative and throws out of a parser whose failure path was written for malformed input, not for hostile input. Bound `len` against the bytes actually remaining in the stream before spending it.
Length read from the parsed input is spent without ever being bounded cs/src/core/Index/Interfaces/DataContractObjectSerializer.cs:25— `count` is read from the stream being parsed at line 24 (`ReadInt32`), then read in bulk from that same stream at line 25 — and nowhere in this method is `count` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). A file the caller did not write therefore chooses the size directly: a value near `int.MaxValue` allocates until the process dies, and a value that overflows the cast to `int` goes negative and throws out of a parser whose failure path was written for malformed input, not for hostile input. Bound `count` against the bytes actually remaining in the stream before spending it.
Length read from the parsed input is spent without ever being bounded cs/samples/ResizableCacheStore/Types.cs:39— `size` is read from the stream being parsed at line 38 (`ReadInt32`), then read in bulk from that same stream at line 39 — and nowhere in this method is `size` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). A file the caller did not write therefore chooses the size directly: a value near `int.MaxValue` allocates until the process dies, and a value that overflows the cast to `int` goes negative and throws out of a parser whose failure path was written for malformed input, not for hostile input. Bound `size` against the bytes actually remaining in the stream before spending it.
Length read from the parsed input is spent without ever being bounded cs/samples/ResizableCacheStore/Types.cs:75— `size` is read from the stream being parsed at line 74 (`ReadInt32`), then read in bulk from that same stream at line 75 — and nowhere in this method is `size` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). A file the caller did not write therefore chooses the size directly: a value near `int.MaxValue` allocates until the process dies, and a value that overflows the cast to `int` goes negative and throws out of a parser whose failure path was written for malformed input, not for hostile input. Bound `size` against the bytes actually remaining in the stream before spending it.
X18 · Disposal-pattern correctness· Owned disposable field is never released · ×4
Owned disposable field is never released cs/src/core/Allocator/AllocatorBase.cs:1833— `AllocatorBase` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `notifyFlushedUntilAddressSemaphore` itself (line 1833), which makes that instance its own. But `notifyFlushedUntilAddressSemaphore` is named in none of the methods the disposal search covered: `Dispose` (line 1182) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`notifyFlushedUntilAddressSemaphore?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.
Owned disposable field is never released cs/src/core/Allocator/MallocFixedPageSize.cs:94— `MallocFixedPageSize` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `checkpointSemaphore` itself (line 94), which makes that instance its own. But `checkpointSemaphore` is named in none of the methods the disposal search covered: `Dispose` (line 357) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`checkpointSemaphore?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.
Owned disposable field is never released cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs:32— `DeviceLogCommitCheckpointManager` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `semaphore` itself (line 32), which makes that instance its own. But `semaphore` is named in none of the methods the disposal search covered: `Dispose` (line 140) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`semaphore?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.
Owned disposable field is never released cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs:45— `DeviceLogCommitCheckpointManager` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `deleteQueue` itself (line 45), which makes that instance its own. But `deleteQueue` is named in none of the methods the disposal search covered: `Dispose` (line 140) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`deleteQueue?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.
No assertions: FasterLogShiftTailStressTest cs/test/LogShiftTailStressTest.cs:18— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: ThreadedLockStressTest1Thread cs/test/OverflowBucketLockTableTests.cs:234— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: RecoverReadOnlyAsyncBasicTest cs/test/RecoverReadOnlyTest.cs:60— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
D4 · Code Duplication· Edited copy of a member (20 corresponding lines) · ×3
Edited copy of a member (20 corresponding lines) cs/src/devices/AzureStorageDevice/AzureStorageDevice.cs:88— cs/src/devices/AzureStorageDevice/AzureStorageDevice.cs:88-113 | cs/src/devices/AzureStorageDevice/AzureStorageDevice.cs:129-148 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (20 corresponding lines) cs/src/core/Index/Synchronization/FullCheckpointStateMachine.cs:83— cs/src/core/Index/Synchronization/FullCheckpointStateMachine.cs:83-105 | cs/src/core/Index/Synchronization/HybridLogCheckpointTask.cs:420-439 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (20 corresponding lines) cs/src/core/Allocator/WorkQueueFIFO.cs:79— cs/src/core/Allocator/WorkQueueFIFO.cs:79-98 | cs/src/core/Allocator/WorkQueueLIFO.cs:79-98 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (26 corresponding lines) · ×3
Edited copy of a member (26 corresponding lines) cs/src/core/Async/DeleteAsync.cs:90— cs/src/core/Async/DeleteAsync.cs:90-115 | cs/src/core/Async/UpsertAsync.cs:115-141 — These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (26 corresponding lines) cs/src/core/Allocator/WorkQueueFIFO.cs:51— cs/src/core/Allocator/WorkQueueFIFO.cs:51-76 | cs/src/core/Allocator/WorkQueueLIFO.cs:51-76 — These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (26 corresponding lines) cs/remote/samples/VarLenServer/Program.cs:20— cs/remote/samples/VarLenServer/Program.cs:20-45 | cs/remote/samples/FixedLenServer/Program.cs:22-47 — These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (22 corresponding lines) · ×3
Edited copy of a member (22 corresponding lines) cs/playground/CacheStoreConcurrent/Program.cs:92— cs/playground/CacheStoreConcurrent/Program.cs:92-113 | cs/samples/CacheStore/Program.cs:103-124 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (22 corresponding lines) cs/playground/AsyncStress/FasterWrapper.cs:32— cs/playground/AsyncStress/FasterWrapper.cs:32-54 | cs/playground/AsyncStress/SerializedFasterWrapper.cs:34-55 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (22 corresponding lines) cs/src/core/Index/Recovery/Recovery.cs:611— cs/src/core/Index/Recovery/Recovery.cs:611-632 | cs/src/core/Index/Recovery/Recovery.cs:635-656 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (27 corresponding lines) · ×3
Edited copy of a member (27 corresponding lines) cs/src/core/Utilities/Utility.cs:104— cs/src/core/Utilities/Utility.cs:104-130 | cs/remote/src/FASTER.server/Servers/ServerOptions.cs:241-267 — These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (27 corresponding lines) cs/src/core/FasterLog/FasterLog.cs:574— cs/src/core/FasterLog/FasterLog.cs:574-601 | cs/src/core/FasterLog/FasterLog.cs:650-676 — These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (27 corresponding lines) cs/src/core/FasterLog/FasterLog.cs:492— cs/src/core/FasterLog/FasterLog.cs:492-518 | cs/src/core/FasterLog/FasterLog.cs:612-640 — These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (18 corresponding lines) · ×3
Edited copy of a member (18 corresponding lines) cs/stress/SessionWrapper.cs:111— cs/stress/SessionWrapper.cs:111-128 | cs/stress/SessionWrapper.cs:198-215 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (18 corresponding lines) cs/src/core/ClientSession/ClientSession.cs:1282— cs/src/core/ClientSession/ClientSession.cs:1282-1299 | cs/src/core/ClientSession/ClientSession.cs:1403-1424 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (18 corresponding lines) cs/src/core/Device/StorageDeviceBase.cs:263— cs/src/core/Device/StorageDeviceBase.cs:263-280 | cs/src/core/Device/StorageDeviceBase.cs:304-324 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (14 corresponding lines) · ×3
Edited copy of a member (14 corresponding lines) cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs:166— cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs:166-179 | cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs:216-229 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (14 corresponding lines) cs/src/core/ClientSession/LockableContext.cs:214— cs/src/core/ClientSession/LockableContext.cs:214-227 | cs/src/core/ClientSession/LockableContext.cs:314-327 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (14 corresponding lines) cs/src/core/ClientSession/LockableContext.cs:261— cs/src/core/ClientSession/LockableContext.cs:261-274 | cs/src/core/ClientSession/LockableContext.cs:293-306 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (10 corresponding lines) · ×3
Edited copy of a member (10 corresponding lines) cs/src/core/Allocator/BlittableAllocator.cs:276— cs/src/core/Allocator/BlittableAllocator.cs:276-285 | cs/src/core/Allocator/VarLenBlittableAllocator.cs:381-390 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (10 corresponding lines) cs/src/core/Index/Recovery/Checkpoint.cs:48— cs/src/core/Index/Recovery/Checkpoint.cs:48-57 | cs/src/core/Index/Recovery/Checkpoint.cs:60-69 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (10 corresponding lines) cs/src/core/FasterLog/FasterLogSettings.cs:168— cs/src/core/FasterLog/FasterLogSettings.cs:168-177 | cs/src/core/Index/Common/FasterKVSettings.cs:184-194 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 6+ corresponding lines) · ×3
Edited copies of one member (3 members, 6+ corresponding lines) cs/src/core/ClientSession/LockableContext.cs:1064— cs/src/core/ClientSession/LockableContext.cs:1064-1070 | cs/src/core/ClientSession/LockableContext.cs:1082-1087 | cs/src/core/ClientSession/LockableContext.cs:1090-1095 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 6 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Edited copies of one member (3 members, 6+ corresponding lines) cs/playground/AsyncStress/FasterWrapper.cs:73— cs/playground/AsyncStress/FasterWrapper.cs:73-78 | cs/playground/AsyncStress/FasterWrapper.cs:100-105 | cs/playground/AsyncStress/FasterWrapper.cs:127-133 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 6 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Edited copies of one member (3 members, 6+ corresponding lines) cs/stress/LongValueTester.cs:51— cs/stress/LongValueTester.cs:51-56 | cs/stress/SpanByteValueTester.cs:55-60 | cs/stress/StringValueTester.cs:53-58 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 6 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (16 corresponding lines) · ×3
Edited copy of a member (16 corresponding lines) cs/remote/src/FASTER.client/ClientNetworkSession.cs:50— cs/remote/src/FASTER.client/ClientNetworkSession.cs:50-65 | cs/remote/src/FASTER.server/BinaryServerSession.cs:94-119 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (16 corresponding lines) cs/stress/TestLoader.cs:284— cs/stress/TestLoader.cs:284-299 | cs/stress/TestLoader.cs:302-318 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (16 corresponding lines) cs/samples/StoreVarLenTypes/CustomMemoryFunctions.cs:23— cs/samples/StoreVarLenTypes/CustomMemoryFunctions.cs:23-39 | cs/samples/StoreVarLenTypes/CustomSpanByteFunctions.cs:20-35 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (24 lines × 2) cs/src/core/Device/LocalStorageDevice.cs:236— cs/src/core/Device/LocalStorageDevice.cs:236-259 | cs/src/core/Device/LocalStorageDevice.cs:303-326 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Device/LocalStorageDevice.cs:236` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (24 lines × 2) cs/src/core/Index/FASTER/Implementation/InternalRead.cs:219— cs/src/core/Index/FASTER/Implementation/InternalRead.cs:219-242 | cs/src/core/Index/FASTER/Implementation/InternalRead.cs:265-288 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Index/FASTER/Implementation/InternalRead.cs:219` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (24 lines × 2) cs/src/core/Index/Synchronization/HybridLogCheckpointTask.cs:273— cs/src/core/Index/Synchronization/HybridLogCheckpointTask.cs:273-296 | cs/src/core/Index/Synchronization/HybridLogCheckpointTask.cs:367-390 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (20 lines × 2) cs/remote/src/FASTER.server/Servers/ServerOptions.cs:243— cs/remote/src/FASTER.server/Servers/ServerOptions.cs:243-262 | cs/src/core/Utilities/Utility.cs:106-125 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (20 lines × 2) cs/src/core/Allocator/BlittableAllocator.cs:445— cs/src/core/Allocator/BlittableAllocator.cs:445-465 | cs/src/core/Allocator/VarLenBlittableAllocator.cs:565-584 — before extracting anything, compare `cs/src/core/Allocator/BlittableAllocator.cs` and `cs/src/core/Allocator/VarLenBlittableAllocator.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 179 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (20 lines × 2) cs/src/core/Allocator/BlittableScanIterator.cs:258— cs/src/core/Allocator/BlittableScanIterator.cs:258-277 | cs/src/core/Allocator/VarLenBlittableScanIterator.cs:251-270 — before extracting anything, compare `cs/src/core/Allocator/BlittableScanIterator.cs` and `cs/src/core/Allocator/VarLenBlittableScanIterator.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 90 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (16 lines × 2) cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:179— cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:179-194 | cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs:159-174 — before extracting anything, compare `cs/src/core/Index/FASTER/Implementation/InternalRMW.cs` and `cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 125 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:179` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (16 lines × 2) cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:241— cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:241-256 | cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs:225-240 — before extracting anything, compare `cs/src/core/Index/FASTER/Implementation/InternalRMW.cs` and `cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 125 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:241` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (16 lines × 2) cs/src/core/Allocator/BlittableScanIterator.cs:114— cs/src/core/Allocator/BlittableScanIterator.cs:114-129 | cs/src/core/Allocator/VarLenBlittableScanIterator.cs:117-132 — before extracting anything, compare `cs/src/core/Allocator/BlittableScanIterator.cs` and `cs/src/core/Allocator/VarLenBlittableScanIterator.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 90 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (12 lines × 2) cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:213— cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:213-224 | cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:243-254 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (12 lines × 2) cs/src/core/Epochs/EpochProtectedVersionScheme.cs:22— cs/src/core/Epochs/EpochProtectedVersionScheme.cs:22-33 | cs/src/core/Index/Synchronization/StateTransitions.cs:68-79 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (12 lines × 2) cs/samples/HelloWorld/Program.cs:79— cs/samples/HelloWorld/Program.cs:79-90 | cs/samples/HelloWorld/Program.cs:189-200 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (7 lines × 3) cs/src/core/Index/Synchronization/HybridLogCheckpointTask.cs:172— cs/src/core/Index/Synchronization/HybridLogCheckpointTask.cs:172-178 | cs/src/core/Index/Synchronization/HybridLogCheckpointTask.cs:273-279 | cs/src/core/Index/Synchronization/HybridLogCheckpointTask.cs:367-373 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Index/Synchronization/HybridLogCheckpointTask.cs:172` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (7 lines × 3) cs/stress/LongValueTester.cs:60— cs/stress/LongValueTester.cs:60-66 | cs/stress/SpanByteValueTester.cs:64-70 | cs/stress/StringValueTester.cs:62-68 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (7 lines × 3) cs/remote/src/FASTER.server/BinaryServerSession.cs:387— cs/remote/src/FASTER.server/BinaryServerSession.cs:387-393 | cs/remote/src/FASTER.server/BinaryServerSession.cs:409-415 | cs/remote/src/FASTER.server/BinaryServerSession.cs:445-451 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
X2 · Cancellation propagation· Async delegate without CancellationToken · ×3
Async delegate without CancellationToken: ReadAsync cs/src/core/Device/ManagedLocalStorageDevice.cs:192— Queues or hands on an async lambda whose work calls something that takes a CancellationToken, while neither this method nor the delegate supplies one — that work can't be stopped early once started. Take a CancellationToken here and let the lambda capture it, or use a delegate that is handed one (`Func<CancellationToken, Task>`).
Async delegate without CancellationToken: WriteAsync cs/src/core/Device/ManagedLocalStorageDevice.cs:354— Queues or hands on an async lambda whose work calls something that takes a CancellationToken, while neither this method nor the delegate supplies one — that work can't be stopped early once started. Take a CancellationToken here and let the lambda capture it, or use a delegate that is handed one (`Func<CancellationToken, Task>`).
Async delegate without CancellationToken: AdmitCommit cs/src/core/FasterLog/LogCommitPolicy.cs:173— Queues or hands on an async lambda whose work calls something that takes a CancellationToken, while neither this method nor the delegate supplies one — that work can't be stopped early once started. Take a CancellationToken here and let the lambda capture it, or use a delegate that is handed one (`Func<CancellationToken, Task>`).
Swallowed exception (caught, then discarded) cs/src/core/Index/Recovery/Recovery.cs:275— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) cs/src/core/Index/Recovery/Recovery.cs:296— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) cs/src/core/Index/Recovery/Recovery.cs:383— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Deprecated: xunit.assert REDACTED:13— xunit.assert 2.4.2 — Legacy — the publisher's replacement is `xunit.v3.assert`; migrate the reference to it.
Deprecated: xunit.assert cs/playground/TstRunner/TstRunner.csproj:12— xunit.assert 2.4.2 — Legacy — the publisher's replacement is `xunit.v3.assert`; migrate the reference to it.
Program.Main (cognitive 27) cs/samples/StoreLogCompaction/Program.cs:15— Program.Main has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Program.Main (cognitive 27) cs/playground/AsyncStress/Program.cs:63— Program.Main has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ClassTooLong: WebsocketServerSession cs/remote/src/FASTER.server/WebsocketServerSession.cs— ClassTooLong — 452 significant lines (blank, comment-only and punctuation-only lines excluded), 16 methods. The bar is 400 significant lines; this is 52 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: FasterLogScanIterator cs/src/core/FasterLog/FasterLogIterator.cs— ClassTooLong — 448 significant lines (blank, comment-only and punctuation-only lines excluded), 26 methods. The bar is 400 significant lines; this is 48 over it, 1.12× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D4 · Code Duplication· Members sharing a duplicated core (7 members, 50+ identical tokens) · ×2
Members sharing a duplicated core (7 members, 50+ identical tokens) cs/src/core/FasterLog/FasterLog.cs:711— cs/src/core/FasterLog/FasterLog.cs:711-728 | cs/src/core/FasterLog/FasterLog.cs:739-757 | cs/src/core/FasterLog/FasterLog.cs:769-788 | cs/src/core/FasterLog/FasterLog.cs:797-814 | cs/src/core/FasterLog/FasterLog.cs:858-883 | cs/src/core/FasterLog/FasterLog.cs:897-923 | cs/src/core/FasterLog/FasterLog.cs:934-958 — These 7 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 7 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 7 times.
Members sharing a duplicated core (7 members, 50+ identical tokens) cs/remote/src/FASTER.client/ClientSession.cs:706— cs/remote/src/FASTER.client/ClientSession.cs:706-725 | cs/remote/src/FASTER.client/ClientSession.cs:729-748 | cs/remote/src/FASTER.client/ClientSession.cs:752-771 | cs/remote/src/FASTER.client/ClientSession.cs:775-793 | cs/remote/src/FASTER.client/ClientSession.cs:797-816 | cs/remote/src/FASTER.client/ClientSession.cs:820-839 | cs/remote/src/FASTER.client/ClientSession.cs:843-861 — These 7 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 7 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 7 times.
D4 · Code Duplication· Edited copy of a member (58 corresponding lines) · ×2
Edited copy of a member (58 corresponding lines) cs/src/core/Index/FASTER/Implementation/InternalDelete.cs:233— cs/src/core/Index/FASTER/Implementation/InternalDelete.cs:233-290 | cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs:316-376 — These two members are one piece of code written twice and then edited apart: 58 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (58 corresponding lines) cs/src/core/FasterLog/FasterLogIterator.cs:248— cs/src/core/FasterLog/FasterLogIterator.cs:248-317 | cs/src/core/FasterLog/FasterLogIterator.cs:342-399 — These two members are one piece of code written twice and then edited apart: 58 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (68 corresponding lines) · ×2
Edited copy of a member (68 corresponding lines) cs/src/core/Allocator/BlittableScanIterator.cs:83— cs/src/core/Allocator/BlittableScanIterator.cs:83-150 | cs/src/core/Allocator/VarLenBlittableScanIterator.cs:86-168 — These two members are one piece of code written twice and then edited apart: 68 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (68 corresponding lines) cs/src/core/FasterLog/FasterLog.cs:2269— cs/src/core/FasterLog/FasterLog.cs:2269-2347 | cs/src/core/FasterLog/FasterLog.cs:2427-2494 — These two members are one piece of code written twice and then edited apart: 68 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (40 corresponding lines) · ×2
Edited copy of a member (40 corresponding lines) cs/src/core/Index/Recovery/Recovery.cs:416— cs/src/core/Index/Recovery/Recovery.cs:416-455 | cs/src/core/Index/Recovery/Recovery.cs:458-499 — These two members are one piece of code written twice and then edited apart: 40 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (40 corresponding lines) cs/src/core/Device/ShardedStorageDevice.cs:204— cs/src/core/Device/ShardedStorageDevice.cs:204-245 | cs/src/core/Device/ShardedStorageDevice.cs:257-296 — These two members are one piece of code written twice and then edited apart: 40 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (28 corresponding lines) · ×2
Edited copy of a member (28 corresponding lines) cs/src/core/Index/Synchronization/HybridLogCheckpointTask.cs:272— cs/src/core/Index/Synchronization/HybridLogCheckpointTask.cs:272-299 | cs/src/core/Index/Synchronization/HybridLogCheckpointTask.cs:366-393 — These two members are one piece of code written twice and then edited apart: 28 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (28 corresponding lines) cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:236— cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:236-266 | cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs:220-247 — These two members are one piece of code written twice and then edited apart: 28 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (33 corresponding lines) · ×2
Edited copy of a member (33 corresponding lines) cs/src/core/Index/FASTER/FASTERBase.cs:152— cs/src/core/Index/FASTER/FASTERBase.cs:152-184 | cs/src/core/Index/FASTER/FASTERBase.cs:188-223 — These two members are one piece of code written twice and then edited apart: 33 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (33 corresponding lines) cs/src/core/Device/LocalStorageDevice.cs:163— cs/src/core/Device/LocalStorageDevice.cs:163-195 | cs/src/core/Device/ManagedLocalStorageDevice.cs:86-118 — These two members are one piece of code written twice and then edited apart: 33 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 14+ corresponding lines) · ×2
Edited copies of one member (3 members, 14+ corresponding lines) cs/stress/LongKeyTester.cs:18— cs/stress/LongKeyTester.cs:18-31 | cs/stress/SpanByteKeyTester.cs:47-61 | cs/stress/StringKeyTester.cs:20-34 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 14 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Edited copies of one member (3 members, 14+ corresponding lines) cs/stress/LongValueTester.cs:94— cs/stress/LongValueTester.cs:94-108 | cs/stress/SpanByteValueTester.cs:97-110 | cs/stress/StringValueTester.cs:95-108 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 14 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (35 corresponding lines) · ×2
Edited copy of a member (35 corresponding lines) cs/src/core/Allocator/BlittableScanIterator.cs:157— cs/src/core/Allocator/BlittableScanIterator.cs:157-192 | cs/src/core/Allocator/VarLenBlittableScanIterator.cs:175-209 — These two members are one piece of code written twice and then edited apart: 35 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (35 corresponding lines) cs/stress/TestLoader.cs:321— cs/stress/TestLoader.cs:321-355 | cs/stress/TestLoader.cs:358-392 — These two members are one piece of code written twice and then edited apart: 35 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (19 corresponding lines) · ×2
Edited copy of a member (19 corresponding lines) cs/src/core/Index/FASTER/Implementation/InternalLock.cs:18— cs/src/core/Index/FASTER/Implementation/InternalLock.cs:18-40 | cs/src/core/Index/FASTER/Implementation/InternalLock.cs:49-67 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (19 corresponding lines) cs/samples/StoreDiskReadBenchmark/Program.cs:217— cs/samples/StoreDiskReadBenchmark/Program.cs:217-236 | cs/samples/StoreAsyncApi/Program.cs:146-164 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (11 corresponding lines) · ×2
Edited copy of a member (11 corresponding lines) cs/src/core/Async/DeleteAsync.cs:29— cs/src/core/Async/DeleteAsync.cs:29-39 | cs/src/core/Async/UpsertAsync.cs:29-40 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (11 corresponding lines) cs/src/core/Allocator/VarLenBlittableAllocator.cs:166— cs/src/core/Allocator/VarLenBlittableAllocator.cs:166-176 | cs/src/core/Allocator/VarLenBlittableAllocator.cs:179-189 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (17 corresponding lines) · ×2
Edited copy of a member (17 corresponding lines) cs/src/core/Allocator/PendingFlushList.cs:29— cs/src/core/Allocator/PendingFlushList.cs:29-45 | cs/src/core/Allocator/PendingFlushList.cs:51-67 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (17 corresponding lines) cs/src/core/FasterLog/FasterLog.cs:1026— cs/src/core/FasterLog/FasterLog.cs:1026-1042 | cs/src/core/FasterLog/FasterLog.cs:1544-1586 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (22 lines × 2) cs/remote/src/FASTER.server/Servers/ServerOptions.cs:212— cs/remote/src/FASTER.server/Servers/ServerOptions.cs:212-233 | cs/src/core/Utilities/Utility.cs:45-66 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (22 lines × 2) cs/remote/src/FASTER.server/Servers/GenericServer.cs:117— cs/remote/src/FASTER.server/Servers/GenericServer.cs:117-138 | cs/remote/src/FASTER.server/Servers/VarLenServer.cs:101-122 — before extracting anything, compare `cs/remote/src/FASTER.server/Servers/GenericServer.cs` and `cs/remote/src/FASTER.server/Servers/VarLenServer.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 53 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (17–18 lines × 2) cs/src/core/Allocator/ScanIteratorBase.cs:136— cs/src/core/Allocator/ScanIteratorBase.cs:136-152 | cs/src/core/Allocator/ScanIteratorBase.cs:185-202 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Allocator/ScanIteratorBase.cs:136` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (17–18 lines × 2) cs/src/core/Index/Synchronization/FullCheckpointStateMachine.cs:45— cs/src/core/Index/Synchronization/FullCheckpointStateMachine.cs:45-62 | cs/src/core/Index/Synchronization/VersionChangeStateMachine.cs:100-116 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (13 lines × 3) cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:120— cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:120-132 | cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:152-164 | cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:184-196 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:120` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:117` calls `TraceBackForOtherChainStart`, `GetInfo` and `cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:181` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (13 lines × 3) cs/src/core/Index/Synchronization/HybridLogCheckpointTask.cs:185— cs/src/core/Index/Synchronization/HybridLogCheckpointTask.cs:185-197 | cs/src/core/Index/Synchronization/HybridLogCheckpointTask.cs:287-299 | cs/src/core/Index/Synchronization/HybridLogCheckpointTask.cs:381-393 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Index/Synchronization/HybridLogCheckpointTask.cs:185` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `cs/src/core/Index/Synchronization/HybridLogCheckpointTask.cs:286` calls `Assert` and `cs/src/core/Index/Synchronization/HybridLogCheckpointTask.cs:184` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (10 lines × 3) cs/src/core/Allocator/BlittableAllocator.cs:198— cs/src/core/Allocator/BlittableAllocator.cs:198-207 | cs/src/core/Allocator/BlittableFrame.cs:39-48 | cs/src/core/Allocator/VarLenBlittableAllocator.cs:306-315 — before extracting anything, compare `cs/src/core/Allocator/BlittableAllocator.cs` and `cs/src/core/Allocator/VarLenBlittableAllocator.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 179 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (10 lines × 3) cs/src/core/Allocator/BlittableScanIterator.cs:258— cs/src/core/Allocator/BlittableScanIterator.cs:258-267 | cs/src/core/Allocator/GenericScanIterator.cs:267-276 | cs/src/core/Allocator/VarLenBlittableScanIterator.cs:251-260 — before extracting anything, compare `cs/src/core/Allocator/BlittableScanIterator.cs` and `cs/src/core/Allocator/VarLenBlittableScanIterator.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 90 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Allocator/BlittableScanIterator.cs:258` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 3) cs/src/core/FasterLog/FasterLog.cs:714— cs/src/core/FasterLog/FasterLog.cs:714-722 | cs/src/core/FasterLog/FasterLog.cs:742-750 | cs/src/core/FasterLog/FasterLog.cs:772-780 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `cs/src/core/FasterLog/FasterLog.cs:752` calls `CopyTo` and `cs/src/core/FasterLog/FasterLog.cs:724` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (9 lines × 3) cs/src/core/Index/FASTER/FASTER.cs:615— cs/src/core/Index/FASTER/FASTER.cs:615-623 | cs/src/core/Index/FASTER/FASTER.cs:671-679 | cs/src/core/Index/FASTER/FASTER.cs:691-699 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Index/FASTER/FASTER.cs:615` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (8 lines × 4) cs/src/core/Index/FASTER/FASTER.cs:595— cs/src/core/Index/FASTER/FASTER.cs:595-602 | cs/src/core/Index/FASTER/FASTER.cs:634-641 | cs/src/core/Index/FASTER/FASTER.cs:652-659 | cs/src/core/Index/FASTER/FASTER.cs:710-717 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Index/FASTER/FASTER.cs:595` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (8 lines × 4) cs/src/core/Index/Synchronization/FullCheckpointStateMachine.cs:52— cs/src/core/Index/Synchronization/FullCheckpointStateMachine.cs:52-60 | cs/src/core/Index/Synchronization/ISynchronizationStateMachine.cs:69-76 | cs/src/core/Index/Synchronization/ISynchronizationStateMachine.cs:128-136 | cs/src/core/Index/Synchronization/VersionChangeStateMachine.cs:106-114 — there are 4 copies across 3 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Blocking `FasterLogScanIterator.GetNext` inside an `async` method cs/src/core/FasterLog/FasterLogIterator.cs:84— `FasterLogScanIterator.GetNext` is a synchronous helper that blocks (`CountdownEvent.Wait`): called from an `async` method it parks the thread exactly as the inline call would. Make the helper `async` and `await` it (`await Task.Delay`, `SemaphoreSlim.WaitAsync`, a `TaskCompletionSource` instead of the poll).
Blocking `FasterLogScanIterator.GetNext` inside an `async` method cs/src/core/FasterLog/FasterLogIterator.cs:106— `FasterLogScanIterator.GetNext` is a synchronous helper that blocks (`CountdownEvent.Wait`): called from an `async` method it parks the thread exactly as the inline call would. Make the helper `async` and `await` it (`await Task.Delay`, `SemaphoreSlim.WaitAsync`, a `TaskCompletionSource` instead of the poll).
X5 · Nullable reference types· Symbol treated as nullable, then dereferenced unguarded · ×2
Symbol treated as nullable, then dereferenced unguarded cs/stress/TestLoader.cs:229— This method contradicts itself about `uContext`: line 227 assigns it with `as IUnsafeContext`, which hands back null rather than throwing when the value is not a `IUnsafeContext`, but line 229 then dereferences it directly as `uContext.BeginUnsafe` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `uContext` once before the first use and handle the null case, or cast with `(IUnsafeContext)` so the failure is reported where it happens — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded cs/stress/TestLoader.cs:254— This method contradicts itself about `uContext`: line 252 assigns it with `as IUnsafeContext`, which hands back null rather than throwing when the value is not a `IUnsafeContext`, but line 254 then dereferences it directly as `uContext.BeginUnsafe` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `uContext` once before the first use and handle the null case, or cast with `(IUnsafeContext)` so the failure is reported where it happens — rather than leaving the two readings side by side.
WebsocketServerSession.ProcessBatch (cyclomatic 53) cs/remote/src/FASTER.server/WebsocketServerSession.cs:282— WebsocketServerSession.ProcessBatch has cyclomatic complexity 53 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
TestLoader.TestLoader.ctor (cyclomatic 39) cs/stress/TestLoader.cs:21— TestLoader.TestLoader.ctor has cyclomatic complexity 39 (threshold 15). Of this number, 38 points are the body's own statements and 1 belongs to one function item inside it that branches. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
GlobUtils.Match (cyclomatic 38) cs/remote/src/FASTER.server/PubSub/GlobUtils.cs:15— GlobUtils.Match has cyclomatic complexity 38 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FasterKV.InternalRMW (cyclomatic 37) cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:48— FasterKV.InternalRMW has cyclomatic complexity 37 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. Note what this body is, though: it carries an aggressive-inlining request, so its author has asked in the source for this body to be inlined into every caller. Each part pulled out of it becomes a call the runtime has to decide to inline again, against a size budget — so the split can quietly turn one inlined body into several real calls, on the path the marker exists to protect. The measurement stands — a hot path is not a licence to be unreadable — but the move that pays here is to lift the COLD parts out first (argument validation, fallback and error paths, one-off setup) and leave the kernel whole. Where the kernel itself has to be divided, ask for the extracted parts to be inlined as well, and measure the result rather than assuming the division is free.
ClientSession.ProcessReplies (cyclomatic 34) cs/remote/src/FASTER.client/ClientSession.cs:338— ClientSession.ProcessReplies has cyclomatic complexity 34 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Program.ProfileStore (cyclomatic 33) cs/playground/AsyncStress/Program.cs:120— Program.ProfileStore has cyclomatic complexity 33 (threshold 15). Of this number, 29 points are the body's own statements and 4 belong to one function item inside it that branches. To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
GenericAllocator.WriteAsync (cyclomatic 31) cs/src/core/Allocator/GenericAllocator.cs:375— GenericAllocator.WriteAsync has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FasterKV.ContinuePendingRead (cyclomatic 30) cs/src/core/Index/FASTER/Implementation/ContinuePending.cs:29— FasterKV.ContinuePendingRead has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FasterKV.CreateNewRecordRMW (cyclomatic 30) cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:354— FasterKV.CreateNewRecordRMW has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FasterKV.InternalUpsert (cyclomatic 30) cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs:44— FasterKV.InternalUpsert has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. Note what this body is, though: it carries an aggressive-inlining request, so its author has asked in the source for this body to be inlined into every caller. Each part pulled out of it becomes a call the runtime has to decide to inline again, against a size budget — so the split can quietly turn one inlined body into several real calls, on the path the marker exists to protect. The measurement stands — a hot path is not a licence to be unreadable — but the move that pays here is to lift the COLD parts out first (argument validation, fallback and error paths, one-off setup) and leave the kernel whole. Where the kernel itself has to be divided, ask for the extracted parts to be inlined as well, and measure the result rather than assuming the division is free.
FasterKV.InternalRead (cyclomatic 29) cs/src/core/Index/FASTER/Implementation/InternalRead.cs:45— FasterKV.InternalRead has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. Note what this body is, though: it carries an aggressive-inlining request, so its author has asked in the source for this body to be inlined into every caller. Each part pulled out of it becomes a call the runtime has to decide to inline again, against a size budget — so the split can quietly turn one inlined body into several real calls, on the path the marker exists to protect. The measurement stands — a hot path is not a licence to be unreadable — but the move that pays here is to lift the COLD parts out first (argument validation, fallback and error paths, one-off setup) and leave the kernel whole. Where the kernel itself has to be divided, ask for the extracted parts to be inlined as well, and measure the result rather than assuming the division is free.
FasterKV.InternalDelete (cyclomatic 28) cs/src/core/Index/FASTER/Implementation/InternalDelete.cs:41— FasterKV.InternalDelete has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. Note what this body is, though: it carries an aggressive-inlining request, so its author has asked in the source for this body to be inlined into every caller. Each part pulled out of it becomes a call the runtime has to decide to inline again, against a size budget — so the split can quietly turn one inlined body into several real calls, on the path the marker exists to protect. The measurement stands — a hot path is not a licence to be unreadable — but the move that pays here is to lift the COLD parts out first (argument validation, fallback and error paths, one-off setup) and leave the kernel whole. Where the kernel itself has to be divided, ask for the extracted parts to be inlined as well, and measure the result rather than assuming the division is free.
FasterKV.UpdateVarLen (cyclomatic 27) cs/src/core/Index/FASTER/FASTER.cs:769— FasterKV.UpdateVarLen has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Program.GetArgs (cyclomatic 26) cs/samples/ResizableCacheStore/Program.cs:172— Program.GetArgs has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FasterKV.FasterKV.ctor (cyclomatic 25) cs/src/core/Index/FASTER/FASTER.cs:107— FasterKV.FasterKV.ctor has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Program.AsyncReadOperator (cyclomatic 25) cs/samples/StoreDiskReadBenchmark/Program.cs:118— Program.AsyncReadOperator has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
BinaryServerSession.ProcessBatch (cyclomatic 25) cs/remote/src/FASTER.server/BinaryServerSession.cs:121— BinaryServerSession.ProcessBatch has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
TestLoader.LoadDataFromFile (cyclomatic 24) cs/benchmark/TestLoader.cs:167— TestLoader.LoadDataFromFile has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Program.Main (cyclomatic 24) cs/playground/AsyncStress/Program.cs:63— Program.Main has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
WebsocketServerSession.TryParseFrames (cyclomatic 24) cs/remote/src/FASTER.server/WebsocketServerSession.cs:142— WebsocketServerSession.TryParseFrames has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
TestLoader.TestLoader.ctor (cyclomatic 23) cs/benchmark/TestLoader.cs:41— TestLoader.TestLoader.ctor has cyclomatic complexity 23 (threshold 15). Of this number, 21 points are the body's own statements and 2 belong to one function item inside it that branches. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
FasterLogScanIterator.GetNextInternal (cyclomatic 22) cs/src/core/FasterLog/FasterLogIterator.cs:760— FasterLogScanIterator.GetNextInternal has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FasterKV.ThreadStateMachineStep (cyclomatic 22) cs/src/core/Index/Synchronization/FasterStateMachine.cs:189— FasterKV.ThreadStateMachineStep has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
StressApp.Main (cyclomatic 21) cs/stress/StressApp.cs:11— StressApp.Main has cyclomatic complexity 21 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
FasterKV.SplitChunk (cyclomatic 21) cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:62— FasterKV.SplitChunk has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ClientSession.ProcessReplies (cyclomatic 20) REDACTED:21— ClientSession.ProcessReplies has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FasterSpanByteYcsbBenchmark.Run (cyclomatic 19) cs/benchmark/FasterSpanByteYcsbBenchmark.cs:321— FasterSpanByteYcsbBenchmark.Run has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FASTER_YcsbBenchmark.Run (cyclomatic 19) cs/benchmark/FasterYcsbBenchmark.cs:286— FASTER_YcsbBenchmark.Run has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AllocatorBase.AsyncFlushDeltaToDevice (cyclomatic 19) cs/src/core/Allocator/AllocatorBase.cs:444— AllocatorBase.AsyncFlushDeltaToDevice has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
GenericAllocator.GenericAllocator.ctor (cyclomatic 19) cs/src/core/Allocator/GenericAllocator.cs:44— GenericAllocator.GenericAllocator.ctor has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FasterLog.CommitInternal (cyclomatic 19) cs/src/core/FasterLog/FasterLog.cs:2696— FasterLog.CommitInternal has cyclomatic complexity 19 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
FasterLogScanIterator.ExpandGetNextInternal (cyclomatic 19) cs/src/core/FasterLog/FasterLogIterator.cs:872— FasterLogScanIterator.ExpandGetNextInternal has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Utils.NumDigits (cyclomatic 19) cs/samples/StoreVarLenTypes/Utils.cs:91— Utils.NumDigits has cyclomatic complexity 19 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
Program.RandomWorkload (cyclomatic 19) cs/samples/ResizableCacheStore/Program.cs:462— Program.RandomWorkload has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
VariableLengthBlittableScanIterator.GetNext (cyclomatic 18) cs/src/core/Allocator/VarLenBlittableScanIterator.cs:85— VariableLengthBlittableScanIterator.GetNext has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
LockableContext.DoInternalTryLock (cyclomatic 18) cs/src/core/ClientSession/LockableContext.cs:91— LockableContext.DoInternalTryLock has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. Note what this body is, though: it carries an aggressive-inlining request, so its author has asked in the source for this body to be inlined into every caller. Each part pulled out of it becomes a call the runtime has to decide to inline again, against a size budget — so the split can quietly turn one inlined body into several real calls, on the path the marker exists to protect. The measurement stands — a hot path is not a licence to be unreadable — but the move that pays here is to lift the COLD parts out first (argument validation, fallback and error paths, one-off setup) and leave the kernel whole. Where the kernel itself has to be divided, ask for the extracted parts to be inlined as well, and measure the result rather than assuming the division is free.
BinaryServerSession.HandlePubSub (cyclomatic 18) cs/remote/src/FASTER.server/BinaryServerSession.cs:370— BinaryServerSession.HandlePubSub has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
GenericAllocator.GetObjectInfo (cyclomatic 17) cs/src/core/Allocator/GenericAllocator.cs:912— GenericAllocator.GetObjectInfo has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FasterLogRecoveryInfo.Initialize (cyclomatic 17) cs/src/core/FasterLog/FasterLogRecoveryInfo.cs:74— FasterLogRecoveryInfo.Initialize has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
Program.ManagedLocalStoreBasicTest (cyclomatic 17) cs/playground/FasterLogMLSDTest/Program.cs:43— Program.ManagedLocalStoreBasicTest has cyclomatic complexity 17 (threshold 15). Of this number, 11 points are the body's own statements and 6 belong to 3 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Program.AsyncSamples (cyclomatic 17) cs/remote/samples/FixedLenClient/Program.cs:128— Program.AsyncSamples has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
BlittableScanIterator.GetNext (cyclomatic 16) cs/src/core/Allocator/BlittableScanIterator.cs:82— BlittableScanIterator.GetNext has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FasterLog.RestoreSpecificCommit (cyclomatic 16) cs/src/core/FasterLog/FasterLog.cs:2349— FasterLog.RestoreSpecificCommit has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DeltaLog.GetNext (cyclomatic 16) cs/src/core/Index/Recovery/DeltaLog.cs:197— DeltaLog.GetNext has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Worker.RunOneThread (cyclomatic 16) cs/samples/EpvsSample/EpvsBench.cs:72— Worker.RunOneThread has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D10 · Test Quality· Fixed-sleep synchronisation · ×1
Fixed-sleep synchronisation: EnqueueWaitCommitBasicTest cs/test/EnqueueAndWaitForCommit.cs:65— This test starts a background task and then orders itself against it with `Task.Delay(100)` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
BarePragmaDisable cs/src/core/Allocator/MallocFixedPageSize.cs:246— #pragma warning disable 420 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
GlobUtils.Match (cognitive 101) cs/remote/src/FASTER.server/PubSub/GlobUtils.cs:15— GlobUtils.Match has cognitive complexity 101 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
WebsocketServerSession.ProcessBatch (cognitive 91) cs/remote/src/FASTER.server/WebsocketServerSession.cs:282— WebsocketServerSession.ProcessBatch has cognitive complexity 91 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FasterKV.ContinuePendingRead (cognitive 83) cs/src/core/Index/FASTER/Implementation/ContinuePending.cs:29— FasterKV.ContinuePendingRead has cognitive complexity 83 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
FasterKV.SplitChunk (cognitive 80) cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:62— FasterKV.SplitChunk has cognitive complexity 80 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
Program.AsyncReadOperator (cognitive 77) cs/samples/StoreDiskReadBenchmark/Program.cs:118— Program.AsyncReadOperator has cognitive complexity 77 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
GenericAllocator.WriteAsync (cognitive 65) cs/src/core/Allocator/GenericAllocator.cs:375— GenericAllocator.WriteAsync has cognitive complexity 65 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Program.ProfileStore (cognitive 62) cs/playground/AsyncStress/Program.cs:120— Program.ProfileStore has cognitive complexity 62 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
TestLoader.LoadDataFromFile (cognitive 58) cs/benchmark/TestLoader.cs:167— TestLoader.LoadDataFromFile has cognitive complexity 58 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
FasterKV.CreateNewRecordRMW (cognitive 55) cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:354— FasterKV.CreateNewRecordRMW has cognitive complexity 55 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
FasterLogScanIterator.GetNextInternal (cognitive 51) cs/src/core/FasterLog/FasterLogIterator.cs:760— FasterLogScanIterator.GetNextInternal has cognitive complexity 51 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Program.GetArgs (cognitive 50) cs/samples/ResizableCacheStore/Program.cs:172— Program.GetArgs has cognitive complexity 50 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Program.RandomWorkload (cognitive 50) cs/samples/ResizableCacheStore/Program.cs:462— Program.RandomWorkload has cognitive complexity 50 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
Program.AsyncOperator (cognitive 46) cs/samples/StoreAsyncApi/Program.cs:60— Program.AsyncOperator has cognitive complexity 46 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LockableContext.DoInternalTryLock (cognitive 45) cs/src/core/ClientSession/LockableContext.cs:91— LockableContext.DoInternalTryLock has cognitive complexity 45 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. Note what this body is, though: it carries an aggressive-inlining request, so its author has asked in the source for this body to be inlined into every caller. Each part pulled out of it becomes a call the runtime has to decide to inline again, against a size budget — so the split can quietly turn one inlined body into several real calls, on the path the marker exists to protect. The measurement stands — a hot path is not a licence to be unreadable — but the move that pays here is to lift the COLD parts out first (argument validation, fallback and error paths, one-off setup) and leave the kernel whole. Where the kernel itself has to be divided, ask for the extracted parts to be inlined as well, and measure the result rather than assuming the division is free.
ClientSession.ProcessReplies (cognitive 45) cs/remote/src/FASTER.client/ClientSession.cs:338— ClientSession.ProcessReplies has cognitive complexity 45 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FasterKV.InternalRMW (cognitive 44) cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:48— FasterKV.InternalRMW has cognitive complexity 44 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. Note what this body is, though: it carries an aggressive-inlining request, so its author has asked in the source for this body to be inlined into every caller. Each part pulled out of it becomes a call the runtime has to decide to inline again, against a size budget — so the split can quietly turn one inlined body into several real calls, on the path the marker exists to protect. The measurement stands — a hot path is not a licence to be unreadable — but the move that pays here is to lift the COLD parts out first (argument validation, fallback and error paths, one-off setup) and leave the kernel whole. Where the kernel itself has to be divided, ask for the extracted parts to be inlined as well, and measure the result rather than assuming the division is free.
WebsocketServerSession.TryParseFrames (cognitive 43) cs/remote/src/FASTER.server/WebsocketServerSession.cs:142— WebsocketServerSession.TryParseFrames has cognitive complexity 43 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TestLoader.TestLoader.ctor (cognitive 40) cs/stress/TestLoader.cs:21— TestLoader.TestLoader.ctor has cognitive complexity 40 (threshold 15). Of this number, 39 points are the body's own statements and 1 belongs to one function item inside it that branches. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
GenericAllocator.GetObjectInfo (cognitive 39) cs/src/core/Allocator/GenericAllocator.cs:912— GenericAllocator.GetObjectInfo has cognitive complexity 39 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FasterLogScanIterator.ExpandGetNextInternal (cognitive 39) cs/src/core/FasterLog/FasterLogIterator.cs:872— FasterLogScanIterator.ExpandGetNextInternal has cognitive complexity 39 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FasterKV.InternalRead (cognitive 39) cs/src/core/Index/FASTER/Implementation/InternalRead.cs:45— FasterKV.InternalRead has cognitive complexity 39 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. Note what this body is, though: it carries an aggressive-inlining request, so its author has asked in the source for this body to be inlined into every caller. Each part pulled out of it becomes a call the runtime has to decide to inline again, against a size budget — so the split can quietly turn one inlined body into several real calls, on the path the marker exists to protect. The measurement stands — a hot path is not a licence to be unreadable — but the move that pays here is to lift the COLD parts out first (argument validation, fallback and error paths, one-off setup) and leave the kernel whole. Where the kernel itself has to be divided, ask for the extracted parts to be inlined as well, and measure the result rather than assuming the division is free.
FasterKVIterator.PushNext (cognitive 38) cs/src/core/Index/FASTER/FASTERIterator.cs:180— FasterKVIterator.PushNext has cognitive complexity 38 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
FasterKV.InternalDelete (cognitive 38) cs/src/core/Index/FASTER/Implementation/InternalDelete.cs:41— FasterKV.InternalDelete has cognitive complexity 38 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. Note what this body is, though: it carries an aggressive-inlining request, so its author has asked in the source for this body to be inlined into every caller. Each part pulled out of it becomes a call the runtime has to decide to inline again, against a size budget — so the split can quietly turn one inlined body into several real calls, on the path the marker exists to protect. The measurement stands — a hot path is not a licence to be unreadable — but the move that pays here is to lift the COLD parts out first (argument validation, fallback and error paths, one-off setup) and leave the kernel whole. Where the kernel itself has to be divided, ask for the extracted parts to be inlined as well, and measure the result rather than assuming the division is free.
AllocatorBase.AsyncFlushDeltaToDevice (cognitive 37) cs/src/core/Allocator/AllocatorBase.cs:444— AllocatorBase.AsyncFlushDeltaToDevice has cognitive complexity 37 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GenericAllocator.Deserialize (cognitive 37) cs/src/core/Allocator/GenericAllocator.cs:831— GenericAllocator.Deserialize has cognitive complexity 37 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
FasterKV.InternalUpsert (cognitive 37) cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs:44— FasterKV.InternalUpsert has cognitive complexity 37 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. Note what this body is, though: it carries an aggressive-inlining request, so its author has asked in the source for this body to be inlined into every caller. Each part pulled out of it becomes a call the runtime has to decide to inline again, against a size budget — so the split can quietly turn one inlined body into several real calls, on the path the marker exists to protect. The measurement stands — a hot path is not a licence to be unreadable — but the move that pays here is to lift the COLD parts out first (argument validation, fallback and error paths, one-off setup) and leave the kernel whole. Where the kernel itself has to be divided, ask for the extracted parts to be inlined as well, and measure the result rather than assuming the division is free.
FasterBase.FindTagOrFreeInternal (cognitive 36) cs/src/core/Index/FASTER/FASTERBase.cs:542— FasterBase.FindTagOrFreeInternal has cognitive complexity 36 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. Note what this body is, though: it carries an aggressive-inlining request, so its author has asked in the source for this body to be inlined into every caller, and it works in raw pointers or stack-allocated memory, whose lifetime is this stack frame. Each part pulled out of it becomes a call the runtime has to decide to inline again, against a size budget — so the split can quietly turn one inlined body into several real calls, on the path the marker exists to protect. Anything extracted from it has to take that memory as a parameter rather than reach for it. The measurement stands — a hot path is not a licence to be unreadable — but the move that pays here is to lift the COLD parts out first (argument validation, fallback and error paths, one-off setup) and leave the kernel whole. Where the kernel itself has to be divided, ask for the extracted parts to be inlined as well, and measure the result rather than assuming the division is free.
DeltaLog.GetNext (cognitive 36) cs/src/core/Index/Recovery/DeltaLog.cs:197— DeltaLog.GetNext has cognitive complexity 36 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FasterKV.FasterKV.ctor (cognitive 35) cs/src/core/Index/FASTER/FASTER.cs:107— FasterKV.FasterKV.ctor has cognitive complexity 35 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FasterKV.UpdateVarLen (cognitive 34) cs/src/core/Index/FASTER/FASTER.cs:769— FasterKV.UpdateVarLen has cognitive complexity 34 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FasterKV.ThreadStateMachineStep (cognitive 34) cs/src/core/Index/Synchronization/FasterStateMachine.cs:189— FasterKV.ThreadStateMachineStep has cognitive complexity 34 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BinaryServerSession.ProcessBatch (cognitive 34) cs/remote/src/FASTER.server/BinaryServerSession.cs:121— BinaryServerSession.ProcessBatch has cognitive complexity 34 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FasterSpanByteYcsbBenchmark.Run (cognitive 33) cs/benchmark/FasterSpanByteYcsbBenchmark.cs:321— FasterSpanByteYcsbBenchmark.Run has cognitive complexity 33 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FASTER_YcsbBenchmark.Run (cognitive 33) cs/benchmark/FasterYcsbBenchmark.cs:286— FASTER_YcsbBenchmark.Run has cognitive complexity 33 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Program.TestData (cognitive 31) cs/playground/ClassRecoveryDurability/Program.cs:157— Program.TestData has cognitive complexity 31 (threshold 15). None of this is in the body itself: all 31 points belong to one function literal inside it that branches (line 159). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
SubscribeKVBroker.Start (cognitive 31) cs/remote/src/FASTER.server/PubSub/SubscribeKVBroker.cs:91— SubscribeKVBroker.Start has cognitive complexity 31 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
FasterSpanByteYcsbBenchmark.RunYcsbSafeContext (cognitive 29) cs/benchmark/FasterSpanByteYcsbBenchmark.cs:213— FasterSpanByteYcsbBenchmark.RunYcsbSafeContext has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FASTER_YcsbBenchmark.RunYcsbSafeContext (cognitive 29) cs/benchmark/FasterYcsbBenchmark.cs:209— FASTER_YcsbBenchmark.RunYcsbSafeContext has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Program.Filldb (cognitive 29) cs/playground/ClassRecoveryDurability/Program.cs:40— Program.Filldb has cognitive complexity 29 (threshold 15). Most of this is not in the body itself: 1 of the 29 points is its own statement and the rest belongs to one function literal inside it that branches (line 66). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
AllocatorBase.AsyncFlushPages (cognitive 27) cs/src/core/Allocator/AllocatorBase.cs:2045— AllocatorBase.AsyncFlushPages has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GenericScanIterator.GetNext (cognitive 27) cs/src/core/Allocator/GenericScanIterator.cs:76— GenericScanIterator.GetNext has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
VariableLengthBlittableScanIterator.GetNext (cognitive 27) cs/src/core/Allocator/VarLenBlittableScanIterator.cs:85— VariableLengthBlittableScanIterator.GetNext has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ConcurrentDictionary_YcsbBenchmark.RunYcsb (cognitive 26) cs/benchmark/ConcurrentDictionaryBenchmark.cs:80— ConcurrentDictionary_YcsbBenchmark.RunYcsb has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FasterLog.RestoreSpecificCommit (cognitive 26) cs/src/core/FasterLog/FasterLog.cs:2349— FasterLog.RestoreSpecificCommit has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Worker.RunOneThread (cognitive 26) cs/samples/EpvsSample/EpvsBench.cs:72— Worker.RunOneThread has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ClientSession.ProcessReplies (cognitive 26) REDACTED:21— ClientSession.ProcessReplies has cognitive complexity 26 (threshold 15). Drivers by points: if/else 12 (20 pts), boolean chains 3, match/switch 1 (2 pts), loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FasterSpanByteYcsbBenchmark.RunYcsbUnsafeContext (cognitive 25) cs/benchmark/FasterSpanByteYcsbBenchmark.cs:96— FasterSpanByteYcsbBenchmark.RunYcsbUnsafeContext has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FASTER_YcsbBenchmark.RunYcsbUnsafeContext (cognitive 25) cs/benchmark/FasterYcsbBenchmark.cs:96— FASTER_YcsbBenchmark.RunYcsbUnsafeContext has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MallocFixedPageSize.InternalAllocate (cognitive 25) cs/src/core/Allocator/MallocFixedPageSize.cs:239— MallocFixedPageSize.InternalAllocate has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FasterKV.DumpDistributionInternal (cognitive 25) cs/src/core/Index/FASTER/FASTER.cs:865— FasterKV.DumpDistributionInternal has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BlobManager.PerformWithRetriesAsync (cognitive 25) cs/src/devices/AzureStorageDevice/StorageOperations.cs:14— BlobManager.PerformWithRetriesAsync has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BinaryServerSession.HandlePubSub (cognitive 25) cs/remote/src/FASTER.server/BinaryServerSession.cs:370— BinaryServerSession.HandlePubSub has cognitive complexity 25 (threshold 15). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
AllocatorBase.ApplyDelta (cognitive 24) cs/src/core/Allocator/AllocatorBase.cs:548— AllocatorBase.ApplyDelta has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LocalStorageNamedDeviceFactory.Delete (cognitive 24) cs/src/core/Index/CheckpointManagement/LocalStorageNamedDeviceFactory.cs:76— LocalStorageNamedDeviceFactory.Delete has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FasterKVIterator.GetNext (cognitive 24) cs/src/core/Index/FASTER/FASTERIterator.cs:133— FasterKVIterator.GetNext has cognitive complexity 24 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
BlobManager.AcquireOwnership (cognitive 24) cs/src/devices/AzureStorageDevice/BlobManager.cs:157— BlobManager.AcquireOwnership has cognitive complexity 24 (threshold 15). Of this number, 18 points are the body's own statements and 6 belong to one function literal inside it that branches. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
Program.ManagedLocalStoreBasicTest (cognitive 24) cs/playground/FasterLogMLSDTest/Program.cs:43— Program.ManagedLocalStoreBasicTest has cognitive complexity 24 (threshold 15). Most of this is not in the body itself: 10 of the 24 points are its own statements and the rest belongs to 3 function literals inside it that branch (lines 116, 59, 75). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
FasterLog.RestoreLatest (cognitive 23) cs/src/core/FasterLog/FasterLog.cs:2268— FasterLog.RestoreLatest has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AllocatorBase.OnPagesClosedWorker (cognitive 22) cs/src/core/Allocator/AllocatorBase.cs:1662— AllocatorBase.OnPagesClosedWorker has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BlittableScanIterator.GetNext (cognitive 22) cs/src/core/Allocator/BlittableScanIterator.cs:82— BlittableScanIterator.GetNext has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Program.DiskSample (cognitive 22) cs/samples/HelloWorld/Program.cs:98— Program.DiskSample has cognitive complexity 22 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
AllocatorBase.AsyncGetFromDiskCallback (cognitive 21) cs/src/core/Allocator/AllocatorBase.cs:2235— AllocatorBase.AsyncGetFromDiskCallback has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ScanIteratorBase.BufferAndLoad (cognitive 21) cs/src/core/Allocator/ScanIteratorBase.cs:135— ScanIteratorBase.BufferAndLoad has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FasterBase.BeginMainIndexCheckpoint (cognitive 21) cs/src/core/Index/Recovery/IndexCheckpoint.cs:69— FasterBase.BeginMainIndexCheckpoint has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BinaryServerSession.Publish (cognitive 21) cs/remote/src/FASTER.server/BinaryServerSession.cs:247— BinaryServerSession.Publish has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
WebsocketServerSession.Publish (cognitive 21) cs/remote/src/FASTER.server/WebsocketServerSession.cs:606— WebsocketServerSession.Publish has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GenericAllocator.GenericAllocator.ctor (cognitive 20) cs/src/core/Allocator/GenericAllocator.cs:44— GenericAllocator.GenericAllocator.ctor has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GenericAllocator.RetrievedFullRecord (cognitive 20) cs/src/core/Allocator/GenericAllocator.cs:979— GenericAllocator.RetrievedFullRecord has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FasterKV.CompactScan (cognitive 20) cs/src/core/Compaction/FASTERCompaction.cs:73— FasterKV.CompactScan has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FasterLog.CommitInternal (cognitive 20) cs/src/core/FasterLog/FasterLog.cs:2696— FasterLog.CommitInternal has cognitive complexity 20 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
VersionChangeTask.OnThreadState (cognitive 20) cs/src/core/Index/Synchronization/VersionChangeStateMachine.cs:32— VersionChangeTask.OnThreadState has cognitive complexity 20 (threshold 15). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
Program.Write (cognitive 20) cs/playground/MemoryDb/Program.cs:69— Program.Write has cognitive complexity 20 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
SubscribeKVBroker.RemoveSubscription (cognitive 20) cs/remote/src/FASTER.server/PubSub/SubscribeKVBroker.cs:58— SubscribeKVBroker.RemoveSubscription has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
StressApp.Main (cognitive 19) cs/stress/StressApp.cs:11— StressApp.Main has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FasterLog.CommitAsync (cognitive 19) cs/src/core/FasterLog/FasterLog.cs:1331— FasterLog.CommitAsync has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Utils.NumDigits (cognitive 19) cs/samples/StoreVarLenTypes/Utils.cs:91— Utils.NumDigits has cognitive complexity 19 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
FASTER_YcsbBenchmark.RunYcsb (cognitive 19) cs/remote/benchmark/FASTER.benchmark/FasterYcsbBenchmark.cs:106— FASTER_YcsbBenchmark.RunYcsb has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TestLoader.TestLoader.ctor (cognitive 18) cs/benchmark/TestLoader.cs:41— TestLoader.TestLoader.ctor has cognitive complexity 18 (threshold 15). Of this number, 17 points are the body's own statements and 1 belongs to one function item inside it that branches. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
MallocFixedPageSize.BeginCheckpoint (cognitive 18) cs/src/core/Allocator/MallocFixedPageSize.cs:409— MallocFixedPageSize.BeginCheckpoint has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FasterLog.RestoreLatestAsync (cognitive 18) cs/src/core/FasterLog/FasterLog.cs:2426— FasterLog.RestoreLatestAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FasterLogRecoveryInfo.Initialize (cognitive 18) cs/src/core/FasterLog/FasterLogRecoveryInfo.cs:74— FasterLogRecoveryInfo.Initialize has cognitive complexity 18 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
HybridLogRecoveryInfo.Initialize (cognitive 18) cs/src/core/Index/Common/Contexts.cs:439— HybridLogRecoveryInfo.Initialize has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AzureStorageDevice.StartAsync (cognitive 18) cs/src/devices/AzureStorageDevice/AzureStorageDevice.cs:156— AzureStorageDevice.StartAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SpanByteSample.Run (cognitive 18) cs/samples/StoreVarLenTypes/SpanByteSample.cs:39— SpanByteSample.Run has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ClientSession.HandlePending (cognitive 18) cs/remote/src/FASTER.client/ClientSession.cs:567— ClientSession.HandlePending has cognitive complexity 18 (threshold 15). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
FASTER_YcsbBenchmark.LoadDataFromFile (cognitive 18) cs/remote/benchmark/FASTER.benchmark/FasterYcsbBenchmark.cs:485— FASTER_YcsbBenchmark.LoadDataFromFile has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AllocatorBase.IterateKeyVersionsImpl (cognitive 17) cs/src/core/Allocator/AllocatorBase.cs:853— AllocatorBase.IterateKeyVersionsImpl has cognitive complexity 17 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
AllocatorBase.TryAllocate (cognitive 17) cs/src/core/Allocator/AllocatorBase.cs:1376— AllocatorBase.TryAllocate has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. Note what this body is, though: it carries an aggressive-inlining request, so its author has asked in the source for this body to be inlined into every caller. Each part pulled out of it becomes a call the runtime has to decide to inline again, against a size budget — so the split can quietly turn one inlined body into several real calls, on the path the marker exists to protect. The measurement stands — a hot path is not a licence to be unreadable — but the move that pays here is to lift the COLD parts out first (argument validation, fallback and error paths, one-off setup) and leave the kernel whole. Where the kernel itself has to be divided, ask for the extracted parts to be inlined as well, and measure the result rather than assuming the division is free.
FasterLog.SerialCommitCallbackWorker (cognitive 17) cs/src/core/FasterLog/FasterLog.cs:2105— FasterLog.SerialCommitCallbackWorker has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FasterLogScanIterator.GetNext (cognitive 17) cs/src/core/FasterLog/FasterLogIterator.cs:247— FasterLogScanIterator.GetNext has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DeviceLogCommitCheckpointManager.GetLogCheckpointMetadata (cognitive 17) cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs:284— DeviceLogCommitCheckpointManager.GetLogCheckpointMetadata has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FasterKV.ConditionalCopyToTail (cognitive 17) cs/src/core/Index/FASTER/Implementation/ConditionalCopyToTail.cs:27— FasterKV.ConditionalCopyToTail has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. Note what this body is, though: it carries an aggressive-inlining request, so its author has asked in the source for this body to be inlined into every caller. Each part pulled out of it becomes a call the runtime has to decide to inline again, against a size budget — so the split can quietly turn one inlined body into several real calls, on the path the marker exists to protect. The measurement stands — a hot path is not a licence to be unreadable — but the move that pays here is to lift the COLD parts out first (argument validation, fallback and error paths, one-off setup) and leave the kernel whole. Where the kernel itself has to be divided, ask for the extracted parts to be inlined as well, and measure the result rather than assuming the division is free.
FasterKV.AcquireCPRLatchRMW (cognitive 17) cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:268— FasterKV.AcquireCPRLatchRMW has cognitive complexity 17 (threshold 15). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
FasterKV.RecoverFromPage (cognitive 17) cs/src/core/Index/Recovery/Recovery.cs:938— FasterKV.RecoverFromPage has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AllocatorBase.RestoreHybridLogInitializePages (cognitive 17) cs/src/core/Index/Recovery/Recovery.cs:1101— AllocatorBase.RestoreHybridLogInitializePages has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FasterServerBase.DisposeActiveSessions (cognitive 17) cs/remote/src/FASTER.server/Servers/FasterServerBase.cs:116— FasterServerBase.DisposeActiveSessions has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Program.AsyncSamples (cognitive 17) cs/remote/samples/FixedLenClient/Program.cs:128— Program.AsyncSamples has cognitive complexity 17 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
TestLoader.GetKeysToLock (cognitive 16) cs/stress/TestLoader.cs:177— TestLoader.GetKeysToLock has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ConcurrencyTest.Test (cognitive 16) cs/playground/SumStore/ConcurrencyTest.cs:140— ConcurrencyTest.Test has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LightEpoch.BumpCurrentEpoch (cognitive 16) cs/src/core/Epochs/LightEpoch.cs:243— LightEpoch.BumpCurrentEpoch has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FasterLog.Scan (cognitive 16) cs/src/core/FasterLog/FasterLog.cs:1811— FasterLog.Scan has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RecordInfo.TryLockExclusive (cognitive 16) cs/src/core/Index/Common/RecordInfo.cs:143— RecordInfo.TryLockExclusive has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. Note what this body is, though: it carries an aggressive-inlining request, so its author has asked in the source for this body to be inlined into every caller. Each part pulled out of it becomes a call the runtime has to decide to inline again, against a size budget — so the split can quietly turn one inlined body into several real calls, on the path the marker exists to protect. The measurement stands — a hot path is not a licence to be unreadable — but the move that pays here is to lift the COLD parts out first (argument validation, fallback and error paths, one-off setup) and leave the kernel whole. Where the kernel itself has to be divided, ask for the extracted parts to be inlined as well, and measure the result rather than assuming the division is free.
FasterBase.FindOtherSlotForThisTagMaybeTentativeInternal (cognitive 16) cs/src/core/Index/FASTER/FASTERBase.cs:637— FasterBase.FindOtherSlotForThisTagMaybeTentativeInternal has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. Note what this body is, though: it carries an aggressive-inlining request, so its author has asked in the source for this body to be inlined into every caller, and it works in raw pointers or stack-allocated memory, whose lifetime is this stack frame. Each part pulled out of it becomes a call the runtime has to decide to inline again, against a size budget — so the split can quietly turn one inlined body into several real calls, on the path the marker exists to protect. Anything extracted from it has to take that memory as a parameter rather than reach for it. The measurement stands — a hot path is not a licence to be unreadable — but the move that pays here is to lift the COLD parts out first (argument validation, fallback and error paths, one-off setup) and leave the kernel whole. Where the kernel itself has to be divided, ask for the extracted parts to be inlined as well, and measure the result rather than assuming the division is free.
FasterKV.InternalContinue (cognitive 16) cs/src/core/Index/FASTER/FASTERThread.cs:13— FasterKV.InternalContinue has cognitive complexity 16 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
FasterKV.TraceBackForOtherChainStart (cognitive 16) cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:204— FasterKV.TraceBackForOtherChainStart has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SubscribeBroker.Broadcast (cognitive 16) cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:78— SubscribeBroker.Broadcast has cognitive complexity 16 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
SubscribeBroker.PUnsubscribe (cognitive 16) cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:299— SubscribeBroker.PUnsubscribe has cognitive complexity 16 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D4 · Code Duplication· Near-duplicate member family (3 members, 17 shared lines) · ×1
Near-duplicate member family (3 members, 17 shared lines) cs/src/core/Index/FASTER/Implementation/InternalDelete.cs:45— cs/src/core/Index/FASTER/Implementation/InternalDelete.cs:45-212 | cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:52-233 | cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs:48-217 — These 3 members are variants of one another: a block of 17 lines reported below appears in every one of them, and the pairwise near-duplicate rows they would otherwise produce are collapsed into this row. Read them as one construct written 3 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 3 times.
D4 · Code Duplication· Members sharing a duplicated core (8 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (8 members, 50+ identical tokens) cs/src/core/Async/ReadAsync.cs:133— cs/src/core/Async/ReadAsync.cs:133-141 | cs/src/core/Index/FASTER/FASTER.cs:588-602 | cs/src/core/Index/FASTER/FASTER.cs:608-623 | cs/src/core/Index/FASTER/FASTER.cs:628-641 | cs/src/core/Index/FASTER/FASTER.cs:646-659 | cs/src/core/Index/FASTER/FASTER.cs:665-679 | cs/src/core/Index/FASTER/FASTER.cs:685-699 | cs/src/core/Index/FASTER/FASTER.cs:704-717 — These 8 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 8 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 8 times.
D4 · Code Duplication· Edited copy of a member (81 corresponding lines) · ×1
Edited copy of a member (81 corresponding lines) cs/remote/src/FASTER.server/BinaryServerSession.cs:248— cs/remote/src/FASTER.server/BinaryServerSession.cs:248-328 | cs/remote/src/FASTER.server/WebsocketServerSession.cs:607-690 — These two members are one piece of code written twice and then edited apart: 81 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (138 corresponding lines) · ×1
Edited copy of a member (138 corresponding lines) cs/src/core/Device/ManagedLocalStorageDevice.cs:134— cs/src/core/Device/ManagedLocalStorageDevice.cs:134-271 | cs/src/core/Device/ManagedLocalStorageDevice.cs:288-433 — These two members are one piece of code written twice and then edited apart: 138 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (97 corresponding lines) · ×1
Edited copy of a member (97 corresponding lines) cs/src/core/FasterLog/FasterLogIterator.cs:761— cs/src/core/FasterLog/FasterLogIterator.cs:761-870 | cs/src/core/FasterLog/FasterLogIterator.cs:873-969 — These two members are one piece of code written twice and then edited apart: 97 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (46 corresponding lines) · ×1
Edited copy of a member (46 corresponding lines) cs/src/core/Allocator/BlittableAllocator.cs:433— cs/src/core/Allocator/BlittableAllocator.cs:433-479 | cs/src/core/Allocator/VarLenBlittableAllocator.cs:553-598 — These two members are one piece of code written twice and then edited apart: 46 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (47 corresponding lines) · ×1
Edited copy of a member (47 corresponding lines) cs/src/core/Allocator/AllocatorBase.cs:1989— cs/src/core/Allocator/AllocatorBase.cs:1989-2036 | cs/src/core/Allocator/GenericAllocator.cs:773-819 — These two members are one piece of code written twice and then edited apart: 47 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (49 corresponding lines) · ×1
Edited copy of a member (49 corresponding lines) cs/src/core/Device/LocalStorageDevice.cs:211— cs/src/core/Device/LocalStorageDevice.cs:211-259 | cs/src/core/Device/LocalStorageDevice.cs:276-326 — These two members are one piece of code written twice and then edited apart: 49 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (38 corresponding lines) · ×1
Edited copy of a member (38 corresponding lines) cs/src/core/Index/Recovery/Recovery.cs:735— cs/src/core/Index/Recovery/Recovery.cs:735-772 | cs/src/core/Index/Recovery/Recovery.cs:775-812 — These two members are one piece of code written twice and then edited apart: 38 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (24 corresponding lines) · ×1
Edited copy of a member (24 corresponding lines) cs/remote/src/FASTER.server/Servers/GenericServer.cs:39— cs/remote/src/FASTER.server/Servers/GenericServer.cs:39-70 | cs/remote/src/FASTER.server/Servers/VarLenServer.cs:31-54 — These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (48 corresponding lines) · ×1
Edited copy of a member (48 corresponding lines) cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:269— cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:269-331 | cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs:250-297 — These two members are one piece of code written twice and then edited apart: 48 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (36 corresponding lines) · ×1
Edited copy of a member (36 corresponding lines) cs/src/core/FasterLog/FasterLog.cs:529— cs/src/core/FasterLog/FasterLog.cs:529-564 | cs/src/core/FasterLog/FasterLog.cs:2523-2561 — These two members are one piece of code written twice and then edited apart: 36 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 23+ corresponding lines) · ×1
Edited copies of one member (3 members, 23+ corresponding lines) cs/playground/AsyncStress/SerializedFasterWrapper.cs:77— cs/playground/AsyncStress/SerializedFasterWrapper.cs:77-99 | cs/playground/AsyncStress/SerializedFasterWrapper.cs:103-126 | cs/playground/AsyncStress/SerializedFasterWrapper.cs:130-155 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 23 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 22+ corresponding lines) · ×1
Edited copies of one member (3 members, 22+ corresponding lines) cs/stress/LongValueTester.cs:69— cs/stress/LongValueTester.cs:69-91 | cs/stress/SpanByteValueTester.cs:73-94 | cs/stress/StringValueTester.cs:71-92 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 22 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (25 corresponding lines) · ×1
Edited copy of a member (25 corresponding lines) cs/src/core/Index/FASTER/LogAccessor.cs:148— cs/src/core/Index/FASTER/LogAccessor.cs:148-174 | cs/src/core/Index/FASTER/LogAccessor.cs:231-255 — These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 8+ corresponding lines) · ×1
Edited copies of one member (3 members, 8+ corresponding lines) cs/stress/LongValueTester.cs:59— cs/stress/LongValueTester.cs:59-66 | cs/stress/SpanByteValueTester.cs:63-70 | cs/stress/StringValueTester.cs:61-68 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 8 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (13 corresponding lines) · ×1
Edited copy of a member (13 corresponding lines) cs/src/core/Device/LocalStorageDevice.cs:371— cs/src/core/Device/LocalStorageDevice.cs:371-383 | cs/src/core/Device/LocalStorageDevice.cs:561-575 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 7+ corresponding lines) · ×1
Edited copies of one member (3 members, 7+ corresponding lines) cs/stress/LongValueTester.cs:34— cs/stress/LongValueTester.cs:34-40 | cs/stress/SpanByteValueTester.cs:36-42 | cs/stress/StringValueTester.cs:36-42 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 7 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (3 corresponding lines) · ×1
Edited copy of a member (3 corresponding lines) cs/src/core/Async/RMWAsync.cs:88— cs/src/core/Async/RMWAsync.cs:88-90 | cs/src/core/Async/UpsertAsync.cs:88-90 — These two members are one piece of code written twice and then edited apart: 3 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (98 lines × 2) cs/remote/src/FASTER.client/StatusCode.cs:39— cs/remote/src/FASTER.client/StatusCode.cs:39-136 | cs/src/core/Utilities/StatusCode.cs:39-136 — before extracting anything, compare `cs/remote/src/FASTER.client/StatusCode.cs` and `cs/src/core/Utilities/StatusCode.cs` as WHOLE FILES: 99% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (72 lines × 2) cs/remote/src/FASTER.server/BinaryServerSession.cs:249— cs/remote/src/FASTER.server/BinaryServerSession.cs:249-320 | cs/remote/src/FASTER.server/WebsocketServerSession.cs:608-679 — before extracting anything, compare `cs/remote/src/FASTER.server/BinaryServerSession.cs` and `cs/remote/src/FASTER.server/WebsocketServerSession.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 189 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (48–55 lines × 2) cs/src/core/Device/ManagedLocalStorageDevice.cs:165— cs/src/core/Device/ManagedLocalStorageDevice.cs:165-212 | cs/src/core/Device/ManagedLocalStorageDevice.cs:320-374 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Device/ManagedLocalStorageDevice.cs:165` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (30–40 lines × 2) cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:269— cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:269-308 | cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs:250-279 — before extracting anything, compare `cs/src/core/Index/FASTER/Implementation/InternalRMW.cs` and `cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 125 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:269` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (35 lines × 2) cs/src/core/FasterLog/FasterLog.cs:2272— cs/src/core/FasterLog/FasterLog.cs:2272-2306 | cs/src/core/FasterLog/FasterLog.cs:2428-2462 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/FasterLog/FasterLog.cs:2272` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (29 lines × 2) cs/src/core/FasterLog/FasterLogIterator.cs:771— cs/src/core/FasterLog/FasterLogIterator.cs:771-799 | cs/src/core/FasterLog/FasterLogIterator.cs:882-910 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/FasterLog/FasterLogIterator.cs:771` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (26 lines × 2) cs/src/core/Allocator/BlittableAllocator.cs:184— cs/src/core/Allocator/BlittableAllocator.cs:184-209 | cs/src/core/Allocator/VarLenBlittableAllocator.cs:292-317 — before extracting anything, compare `cs/src/core/Allocator/BlittableAllocator.cs` and `cs/src/core/Allocator/VarLenBlittableAllocator.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 179 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (25–27 lines × 2) cs/src/core/Allocator/BlittableScanIterator.cs:157— cs/src/core/Allocator/BlittableScanIterator.cs:157-183 | cs/src/core/Allocator/VarLenBlittableScanIterator.cs:175-199 — before extracting anything, compare `cs/src/core/Allocator/BlittableScanIterator.cs` and `cs/src/core/Allocator/VarLenBlittableScanIterator.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 90 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Allocator/BlittableScanIterator.cs:157` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (17 lines × 3) cs/src/core/Index/FASTER/Implementation/InternalDelete.cs:83— cs/src/core/Index/FASTER/Implementation/InternalDelete.cs:83-99 | cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:84-100 | cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs:79-95 — before extracting anything, compare `cs/src/core/Index/FASTER/Implementation/InternalDelete.cs` and `cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 55 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Index/FASTER/Implementation/InternalDelete.cs:83` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (24–25 lines × 2) cs/src/core/FasterLog/FasterLogIterator.cs:270— cs/src/core/FasterLog/FasterLogIterator.cs:270-293 | cs/src/core/FasterLog/FasterLogIterator.cs:366-390 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/FasterLog/FasterLogIterator.cs:270` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `entry` to `out byte[]` in one and `out IMemoryOwner<byte>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (23–24 lines × 2) cs/src/core/Allocator/BlittableAllocator.cs:37— cs/src/core/Allocator/BlittableAllocator.cs:37-60 | cs/src/core/Allocator/VarLenBlittableAllocator.cs:40-62 — before extracting anything, compare `cs/src/core/Allocator/BlittableAllocator.cs` and `cs/src/core/Allocator/VarLenBlittableAllocator.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 179 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Allocator/BlittableAllocator.cs:37` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (21–22 lines × 2) cs/src/core/FasterLog/FasterLog.cs:2318— cs/src/core/FasterLog/FasterLog.cs:2318-2339 | cs/src/core/FasterLog/FasterLog.cs:2395-2415 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (20–22 lines × 2) cs/playground/ClassRecoveryDurability/Program.cs:188— cs/playground/ClassRecoveryDurability/Program.cs:188-207 | cs/playground/ClassRecoveryDurability/Program.cs:209-230 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (18 lines × 4) cs/src/core/FasterLog/FasterLog.cs:1493— cs/src/core/FasterLog/FasterLog.cs:1493-1510 | cs/src/core/FasterLog/FasterLog.cs:1597-1614 | cs/src/core/FasterLog/FasterLog.cs:1650-1667 | cs/src/core/FasterLog/FasterLog.cs:1704-1721 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (17–19 lines × 2) cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs:316— cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs:316-332 | cs/src/core/Index/FASTER/Implementation/TryCopyToTail.cs:33-51 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs:316` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (14 lines × 3) cs/src/core/FasterLog/FasterLog.cs:861— cs/src/core/FasterLog/FasterLog.cs:861-874 | cs/src/core/FasterLog/FasterLog.cs:900-913 | cs/src/core/FasterLog/FasterLog.cs:937-950 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (16 lines × 3) cs/src/core/FasterLog/FasterLogIterator.cs:271— cs/src/core/FasterLog/FasterLogIterator.cs:271-286 | cs/src/core/FasterLog/FasterLogIterator.cs:367-383 | cs/src/core/FasterLog/FasterLogIterator.cs:431-446 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/FasterLog/FasterLogIterator.cs:271` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (15–16 lines × 2) cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:52— cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:52-66 | cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs:48-63 — before extracting anything, compare `cs/src/core/Index/FASTER/Implementation/InternalRMW.cs` and `cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 125 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:52` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13–14 lines × 2) cs/src/core/Index/FASTER/Implementation/InternalDelete.cs:269— cs/src/core/Index/FASTER/Implementation/InternalDelete.cs:269-281 | cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs:354-367 — before extracting anything, compare `cs/src/core/Index/FASTER/Implementation/InternalDelete.cs` and `cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 55 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Index/FASTER/Implementation/InternalDelete.cs:269` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (12–13 lines × 2) cs/remote/src/FASTER.server/BinaryServerSession.cs:176— cs/remote/src/FASTER.server/BinaryServerSession.cs:176-187 | cs/remote/src/FASTER.server/WebsocketServerSession.cs:432-444 — before extracting anything, compare `cs/remote/src/FASTER.server/BinaryServerSession.cs` and `cs/remote/src/FASTER.server/WebsocketServerSession.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 189 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (12 lines × 3) cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:101— cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:101-113 | cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:118-129 | cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:150-161 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:101` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 6) cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:104— cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:104-114 | cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:120-130 | cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:136-146 | cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:152-162 | cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:171-181 | cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:184-194 — all 6 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:117` calls `TraceBackForOtherChainStart`, `GetInfo` and `cs/src/core/Index/FASTER/Implementation/SplitIndex.cs:184` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (10–11 lines × 2) cs/remote/src/FASTER.client/ClientSession.cs:382— cs/remote/src/FASTER.client/ClientSession.cs:382-392 | cs/remote/src/FASTER.client/ClientSession.cs:585-594 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/remote/src/FASTER.client/ClientSession.cs:382` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (10 lines × 4) cs/remote/src/FASTER.server/BinaryServerSession.cs:61— cs/remote/src/FASTER.server/BinaryServerSession.cs:61-70 | cs/remote/src/FASTER.server/BinaryServerSession.cs:78-87 | cs/remote/src/FASTER.server/WebsocketServerSession.cs:67-76 | cs/remote/src/FASTER.server/WebsocketServerSession.cs:84-93 — before extracting anything, compare `cs/remote/src/FASTER.server/BinaryServerSession.cs` and `cs/remote/src/FASTER.server/WebsocketServerSession.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 189 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Note first that the copies are not typed on the same thing: the declarations holding them bind `status` to `Status` in one and `core.Status` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (8 lines × 5) cs/remote/src/FASTER.client/ClientSession.cs:707— cs/remote/src/FASTER.client/ClientSession.cs:707-714 | cs/remote/src/FASTER.client/ClientSession.cs:753-760 | cs/remote/src/FASTER.client/ClientSession.cs:798-805 | cs/remote/src/FASTER.client/ClientSession.cs:821-828 | cs/remote/src/FASTER.client/ClientSession.cs:844-851 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/remote/src/FASTER.client/ClientSession.cs:707` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `cs/remote/src/FASTER.client/ClientSession.cs:716` calls `Write` and `cs/remote/src/FASTER.client/ClientSession.cs:853` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (8–9 lines × 3) cs/remote/src/FASTER.client/ClientSession.cs:380— cs/remote/src/FASTER.client/ClientSession.cs:380-388 | cs/remote/src/FASTER.client/ClientSession.cs:583-590 | cs/remote/src/FASTER.client/ClientSession.cs:650-657 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/remote/src/FASTER.client/ClientSession.cs:380` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8–9 lines × 2) cs/remote/src/FASTER.server/BinaryServerSession.cs:173— cs/remote/src/FASTER.server/BinaryServerSession.cs:173-181 | cs/remote/src/FASTER.server/BinaryServerSession.cs:193-200 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `cs/remote/src/FASTER.server/BinaryServerSession.cs:203` calls `Publish` and `cs/remote/src/FASTER.server/BinaryServerSession.cs:183` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (6 lines × 4) cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:219— cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:219-224 | cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:249-254 | cs/remote/src/FASTER.server/PubSub/SubscribeKVBroker.cs:200-205 | cs/remote/src/FASTER.server/PubSub/SubscribeKVBroker.cs:233-238 — there are 4 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:219` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (7–8 lines × 2) cs/remote/src/FASTER.server/BinaryServerSession.cs:406— cs/remote/src/FASTER.server/BinaryServerSession.cs:406-412 | cs/remote/src/FASTER.server/WebsocketServerSession.cs:511-518 — before extracting anything, compare `cs/remote/src/FASTER.server/BinaryServerSession.cs` and `cs/remote/src/FASTER.server/WebsocketServerSession.cs` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 189 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `cs/remote/src/FASTER.server/WebsocketServerSession.cs:519` calls `Write` and `cs/remote/src/FASTER.server/BinaryServerSession.cs:413` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (6 lines × 3) cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:399— cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:399-404 | cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs:317-322 | cs/src/core/Index/FASTER/Implementation/TryCopyToTail.cs:35-41 — before extracting anything, compare `cs/src/core/Index/FASTER/Implementation/InternalRMW.cs` and `cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 125 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 7) cs/remote/src/FASTER.client/ClientSession.cs:711— cs/remote/src/FASTER.client/ClientSession.cs:711-715 | cs/remote/src/FASTER.client/ClientSession.cs:734-738 | cs/remote/src/FASTER.client/ClientSession.cs:757-761 | cs/remote/src/FASTER.client/ClientSession.cs:780-784 | cs/remote/src/FASTER.client/ClientSession.cs:802-806 | cs/remote/src/FASTER.client/ClientSession.cs:825-829 | cs/remote/src/FASTER.client/ClientSession.cs:848-852 — all 7 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `cs/remote/src/FASTER.client/ClientSession.cs:716` calls `Write` and `cs/remote/src/FASTER.client/ClientSession.cs:785` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Near-duplicate member pair (35 shared lines) cs/samples/HelloWorld/Program.cs:24— cs/samples/HelloWorld/Program.cs:24-96 | cs/samples/HelloWorld/Program.cs:99-206 — These two members are variants of one another: 35 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
Near-duplicate member pair (26 shared lines) cs/samples/StoreVarLenTypes/MemoryByteSample.cs:16— cs/samples/StoreVarLenTypes/MemoryByteSample.cs:16-86 | cs/samples/StoreVarLenTypes/MemoryIntSample.cs:16-86 — These two members are variants of one another: 26 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
Duplicated block (16–17 lines × 2) cs/samples/AzureBackedStore/Program.cs:49— cs/samples/AzureBackedStore/Program.cs:49-65 | cs/samples/AzureBackedStore/Program.cs:91-106 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cs/samples/AzureBackedStore/Program.cs:49` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (45 lines × 3) cs/samples/AzureBackedStore/Types.cs:13— cs/samples/AzureBackedStore/Types.cs:13-57 | cs/samples/StoreCheckpointRecover/Types.cs:13-77 | cs/samples/StoreCustomTypes/Types.cs:13-77 — `cs/samples/AzureBackedStore/Types.cs` and `cs/samples/StoreCheckpointRecover/Types.cs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 1 separate duplicated blocks between them, totalling at least 65 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `cs/samples/AzureBackedStore/Types.cs:13` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (61 lines × 2) cs/samples/StoreCheckpointRecover/Types.cs:17— cs/samples/StoreCheckpointRecover/Types.cs:17-77 | cs/samples/StoreCustomTypes/Types.cs:17-77 — `cs/samples/StoreCheckpointRecover/Types.cs` and `cs/samples/StoreCustomTypes/Types.cs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 2 separate duplicated blocks between them, totalling at least 126 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `cs/samples/StoreCheckpointRecover/Types.cs:17` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Off the main sequence: FASTER.core(net7.0) cs/src/core/FASTER.core.csproj:1— FASTER.core(net7.0): abstractness 0.27, instability 0.00, distance 0.73 — zone of pain — concrete and depended on by 2 project(s), so it's rigid to change.
IC1 · Incompleteness & stubs· Both branches open with the same statements · ×1
Both branches open with the same statements — the condition does not decide them cs/remote/src/FASTER.client/ClientSession.cs:486— The first 2 statements of the `if` and of the `else` are identical, so they run on both paths regardless of the condition. Lift them above the `if` — leaving them duplicated inside makes the branches read as though they handled this differently.
Hollow method — returns a constant without doing the work cs/src/core/Compaction/ICompactionFunctions.cs:30— `IsDeleted` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in.
Skeleton type — most members are unfinished cs/src/core/Device/LocalStorageDevice.cs:539— `SimpleAsyncResult` has 4 unfinished members out of 4 declared members (methods, properties, indexers and events, whether or not each carries a body) — a scaffolded type that was never implemented.
Repository declared end-of-life README.md:8— This repository declares its own end of life: `README.md` line 8 reads “> **This repository is no longer actively maintained.**”. That is a first-party statement of intent, not an inference — the Maturity and Knowledge lenses otherwise approximate the same fact from decayed commit history (D16 reports a dormant codebase, D34 orphaned files), and this row says the maintainer already told you. It does NOT change any score: an honest end-of-life notice is the README doing its job, and every dimension below still measures the code as it stands. Read the whole report as an assessment of software the author has stopped working on.
Duplicated block (17 lines × 2 locations) REDACTED:70— REDACTED:70 · REDACTED:88 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
Duplicated block (15 lines × 2 locations) REDACTED:190— REDACTED:190 · REDACTED:237 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2 locations) REDACTED:132— REDACTED:132 · REDACTED:142 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
Duplicated block (9 lines × 4 locations) REDACTED:200— REDACTED:200 · REDACTED:215 · REDACTED:247 · REDACTED:262 — all 4 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
Duplicated block (5 lines × 3 locations) REDACTED:62— REDACTED:62 · REDACTED:80 · REDACTED:98 — all 3 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
Complex function ProcessReplies (cyclomatic 20, cognitive 26) REDACTED:21— ProcessReplies has cyclomatic complexity 20 and cognitive complexity 26; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Weak hash algorithm cs/remote/src/FASTER.server/WebsocketServerSession.cs:314— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
SC1 · Supply-chain hygiene· NuGet dependencies are not locked · ×1
NuGet dependencies are not locked — No packages.lock.json and no central package management — restores aren't reproducible or pinned (SSDF PW.4.4). Enable <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile> (commit the lockfile) or adopt Directory.Packages.props. Advisory — never scored.
Blocking `FasterLogScanIterator.ScanForwardForCommit` inside an `async` method cs/src/core/FasterLog/FasterLog.cs:2454— `FasterLogScanIterator.ScanForwardForCommit` is a synchronous helper that blocks (`CountdownEvent.Wait`): called from an `async` method it parks the thread exactly as the inline call would. Make the helper `async` and `await` it (`await Task.Delay`, `SemaphoreSlim.WaitAsync`, a `TaskCompletionSource` instead of the poll).
Blocking `FasterLogScanIterator.TryConsumeNext` inside an `async` method cs/src/core/FasterLog/FasterLogIterator.cs:126— `FasterLogScanIterator.TryConsumeNext` is a synchronous helper that blocks (`CountdownEvent.Wait`): called from an `async` method it parks the thread exactly as the inline call would. Make the helper `async` and `await` it (`await Task.Delay`, `SemaphoreSlim.WaitAsync`, a `TaskCompletionSource` instead of the poll).
Blocking `FasterLogScanIterator.TryBulkConsumeNext` inside an `async` method cs/src/core/FasterLog/FasterLogIterator.cs:147— `FasterLogScanIterator.TryBulkConsumeNext` is a synchronous helper that blocks (`CountdownEvent.Wait`): called from an `async` method it parks the thread exactly as the inline call would. Make the helper `async` and `await` it (`await Task.Delay`, `SemaphoreSlim.WaitAsync`, a `TaskCompletionSource` instead of the poll).
Blocking `HybridLogCheckpointInfo.Dispose` inside an `async` method cs/src/core/Index/FASTER/FASTER.cs:563— `HybridLogCheckpointInfo.Dispose` is a synchronous helper that blocks (`CountdownEvent.Wait`): called from an `async` method it parks the thread exactly as the inline call would. Make the helper `async` and `await` it (`await Task.Delay`, `SemaphoreSlim.WaitAsync`, a `TaskCompletionSource` instead of the poll).
Blocking `FasterKV.DoPostRecovery` inside an `async` method cs/src/core/Index/Recovery/Recovery.cs:497— `FasterKV.DoPostRecovery` is a synchronous helper that blocks (`CountdownEvent.Wait`): called from an `async` method it parks the thread exactly as the inline call would. Make the helper `async` and `await` it (`await Task.Delay`, `SemaphoreSlim.WaitAsync`, a `TaskCompletionSource` instead of the poll).
Blocking `Thread.Sleep` inside an `async` method cs/samples/FasterLogPubSub/Program.cs:123— `Thread.Sleep` parks the thread for the whole delay: no other work runs on it, and under load the pool must grow to make up for it. `await Task.Delay(…)` suspends only this method.
X18 · Disposal-pattern correctness· Owned disposable field overwritten without releasing the previous instance · ×1
Owned disposable field overwritten without releasing the previous instance cs/src/core/Index/Recovery/DeltaLog.cs:388— `completedSemaphore` is a `SemaphoreSlim` this type creates itself, and here (line 388) a new instance is written over it — but `FlushAsync` itself reads through `completedSemaphore` before replacing it, so it expects an instance to be there, and nothing earlier in `FlushAsync` disposes, closes, saves or hands on the instance being replaced. The assignment makes it unreachable while it still holds what it holds (a timer that keeps firing, a callback registered on a longer-lived token, a socket, a handle), and no later `Dispose` can reach it: the type's own disposal releases only the CURRENT instance. The cost accumulates once per overwrite. Release the previous instance first (`completedSemaphore?.Dispose();` before the assignment), or swap it out with `Interlocked.Exchange` and dispose what comes back.
X18 · Disposal-pattern correctness· Disposable acquired into a field and never released · ×1
Disposable acquired into a field and never released cs/samples/EpvsSample/EpvsBench.cs:24— `hasher` (line 24) holds a `HashAlgorithm` that `Worker` acquires itself — every assignment to it is a call that opens or creates a new instance for the caller to own — and nothing in `Worker` ever releases it: the type is not `IDisposable`, declares no `Dispose`, and every other mention of `hasher` only reads through it, so it is never disposed, closed, returned or handed on. Whatever it opened (a connection, a channel, a file) stays open until finalization if the type has a finalizer and until the process ends if it does not, once per instance of `Worker`. Implement `IDisposable` and release `hasher` there, or take the instance from the caller so its owner ends it.
Orphaned file cs/stress/TestLoader.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file cs/benchmark/TestLoader.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file cs/src/core/Device/ShardedStorageDevice.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file cs/src/core/ClientSession/ILockableContext.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file cs/stress/SessionWrapper.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file cs/src/core/Index/FASTER/Implementation/Locking/OverflowBucketLockTable.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file cs/src/core/Index/FASTER/Implementation/ConditionalCopyToTail.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file cs/src/core/Index/Synchronization/ISynchronizationStateMachine.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file cs/src/core/Device/TieredStorageDevice.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file cs/stress/StressApp.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file cs/stress/Options.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file cs/src/core/Index/Synchronization/VersionChangeStateMachine.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file cs/src/core/Index/FASTER/Implementation/TryCopyToTail.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file cs/src/core/Index/FASTER/Implementation/TryCopyToReadCache.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file cs/src/core/Index/Common/OperationOptions.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file cs/benchmark/Options.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file cs/src/core/Utilities/LockType.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file cs/src/core/Index/Synchronization/IndexResizeStateMachine.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file cs/stress/SpanByteValueTester.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file cs/stress/StringValueTester.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file cs/stress/LongValueTester.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file cs/src/core/Index/FASTER/Implementation/Locking/TransientLocking.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file cs/benchmark/TestStats.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file cs/stress/SpanByteKeyTester.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file cs/src/core/Index/FASTER/Implementation/Locking/ILockTable.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
redundant comment cs/benchmark/Properties/AssemblyInfo.cs:20— "Setting ComVisible to false makes the types in this assembly not visible to COM components. If you need to access a type in this assembly from COM, set the ComV …" is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment cs/benchmark/Properties/AssemblyInfo.cs:25— "The following GUID is for the ID of the typelib if this project is exposed to COM" is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment cs/playground/SumStore/Properties/AssemblyInfo.cs:20— "Setting ComVisible to false makes the types in this assembly not visible to COM components. If you need to access a type in this assembly from COM, set the ComV …" is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment cs/playground/SumStore/Properties/AssemblyInfo.cs:25— "The following GUID is for the ID of the typelib if this project is exposed to COM" is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment cs/src/core/Compaction/FASTERCompaction.cs:114— "Scan until SafeReadOnlyAddress" repeats the code it sits on: 6 of its 6 words (scan, until, safe, read, only, address) are already in `var scanUntil = hlog.SafeReadOnlyAddress;`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment cs/src/core/Epochs/EpochProtectedVersionScheme.cs:273— "Atomic transition from expectedState -> nextState" repeats the code it sits on: 4 of its 5 words (transition, expected, state, next) are already in `[MethodImpl(MethodImplOptions.AggressiveInlining)]`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment cs/src/core/Epochs/EpochProtectedVersionScheme.cs:418— "Compute the actual ToVersion of state machine" repeats the code it sits on: 4 of its 5 words (actual, version, state, machine) are already in `stateMachine.actualToVersion =`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment cs/src/core/FasterLog/FasterLog.cs:2732— "log has been closed, throw an exception" repeats the code it sits on: 4 of its 4 words (log, closed, throw, exception) are already in `throw new FasterException("log has already been closed");`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment cs/src/core/Index/Common/Contexts.cs:631— "Write object log segment offsets" repeats the code it sits on: 5 of its 5 words (write, object, log, segment, offsets) are already in `writer.WriteLine(objectLogSegmentOffsets == null ? 0 : objectLogSegmentOffsets.Length);`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment cs/src/core/Index/FASTER/FASTER.cs:69— "version switch barrier" repeats the code it sits on: 3 of its 3 words (version, switch, barrier) are already in `internal readonly bool CheckpointVersionSwitchBarrier; // version switch barrier`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment cs/src/core/Index/FASTER/FASTERBase.cs:339— "Allocator for the hash buckets" repeats the code it sits on: 3 of its 3 words (allocator, hash, buckets) are already in `internal MallocFixedPageSize<HashBucket> overflowBucketsAllocator;`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment cs/src/core/Index/Recovery/IndexRecovery.cs:71— "Delete all tentative entries!" repeats the code it sits on: 3 of its 3 words (delete, tentative, entries) are already in `DeleteTentativeEntries();`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment cs/src/core/Index/Recovery/Recovery.cs:578— "Recover segment offsets for object log" repeats the code it sits on: 5 of its 5 words (recover, segment, offsets, object, log) are already in `if (recoveredHLCInfo.info.objectLogSegmentOffsets != null)`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment cs/src/core/Index/Recovery/Recovery.cs:1004— "Set the page status to flushed" repeats the code it sits on: 4 of its 4 words (set, page, status, flushed) are already in `var result = (PageAsyncFlushResult<RecoveryStatus>)context;`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment cs/src/core/Index/Recovery/Recovery.cs:1160— "Set the page status to "read done"" repeats the code it sits on: 4 of its 4 words (set, page, status, read) are already in `var result = (PageAsyncReadResult<RecoveryStatus>)context;`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment cs/src/core/Index/Synchronization/FasterStateMachine.cs:88— "Atomic transition from expectedState -> nextState" repeats the code it sits on: 4 of its 5 words (transition, expected, state, next) are already in `[MethodImpl(MethodImplOptions.AggressiveInlining)]`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment cs/src/core/Properties/AssemblyInfo.cs:8— "General Information about an assembly is controlled through the following set of attributes. Change these attribute values to modify the information associated …" is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment cs/src/core/Properties/AssemblyInfo.cs:16— "Setting ComVisible to false makes the types in this assembly not visible to COM components. If you need to access a type in this assembly from COM, set the ComV …" is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment cs/src/core/Properties/AssemblyInfo.cs:21— "The following GUID is for the ID of the typelib if this project is exposed to COM" is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment cs/test/DeviceFasterLogTests.cs:59— "Create devices \ log for test for in memory device" repeats the code it sits on: 6 of its 6 words (create, devices, log, test, memory, device) are already in `using var device = new LocalMemoryDevice(1L << 28, 1L << 25, 2, latencyMs: 20, fileName: TestUtils.MethodTestDir + "/tes …`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment cs/test/FasterLogScanTests.cs:157— "truncate log to tail" repeats the code it sits on: 3 of its 3 words (truncate, log, tail) are already in `log.TruncateUntil(log.TailAddress);`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment cs/test/GenericIterationTests.cs:29— "Default ConcurrencyControlMode for this iterator type." repeats the code it sits on: 5 of its 6 words (concurrency, control, mode, iterator, type) are already in `var concurrencyControlMode = scanIteratorType == ScanIteratorType.Pull ? ConcurrencyControlMode.None : ConcurrencyContro …`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment cs/test/Properties/AssemblyInfo.cs:20— "Setting ComVisible to false makes the types in this assembly not visible to COM components. If you need to access a type in this assembly from COM, set the ComV …" is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment cs/test/Properties/AssemblyInfo.cs:25— "The following GUID is for the ID of the typelib if this project is exposed to COM" is Visual Studio AssemblyInfo template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment cs/test/SimpleAsyncTests.cs:94— "Test that does .ReadAsync no ref key (key)" repeats the code it sits on: 6 of its 6 words (test, read, async, no, ref, key) are already in `[Test]`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
Duplicated predicate cs/remote/src/FASTER.client/FixedLenSerializer.cs:26— `!IsBlittable<Key>() || !IsBlittable<Value>() || !IsBlittable<Input>() || !IsBlittable<Output>()` appears character-identically in 2 files — cs/remote/src/FASTER.client/FixedLenSerializer.cs, cs/remote/src/FASTER.server/FixedLenSerializer.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate cs/src/core/Index/FASTER/Implementation/InternalDelete.cs:58— `!fasterSession.IsManualLocking || LockTable.IsLockedExclusive(ref key, ref stackCtx.hei)` appears character-identically in 3 files — cs/src/core/Index/FASTER/Implementation/InternalDelete.cs, cs/src/core/Index/FASTER/Implementation/InternalRMW.cs, cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate cs/src/core/Index/FASTER/Implementation/ConditionalCopyToTail.cs:119— `!pendingContext.NoKey && pendingContext.key == default` appears character-identically in 2 files — cs/src/core/Index/FASTER/Implementation/ConditionalCopyToTail.cs, cs/src/core/Index/FASTER/Implementation/InternalRead.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate cs/samples/StoreVarLenTypes/MemoryByteSample.cs:68— `!status.Found || (!output.Item1.Memory.Slice(0, output.Item2).Span.SequenceEqual(expectedValue.Span))` appears character-identically in 2 files — cs/samples/StoreVarLenTypes/MemoryByteSample.cs, cs/samples/StoreVarLenTypes/MemoryIntSample.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate cs/samples/StoreDiskReadBenchmark/Program.cs:145— `!status.Found || output.value.vfield1 != key.key` appears character-identically in 2 files — cs/samples/StoreDiskReadBenchmark/Program.cs, cs/samples/StoreDiskReadBenchmark/Types.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate cs/benchmark/FasterSpanByteYcsbBenchmark.cs:47— `(testLoader.Options.NumaStyle == 0 && testLoader.Options.ThreadCount <= (numProcs - 1)) || (testLoader.Options.NumaStyle == 1 && testLoader.…` appears character-identically in 2 files — cs/benchmark/FasterSpanByteYcsbBenchmark.cs, cs/benchmark/FasterYcsbBenchmark.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate cs/src/core/Allocator/AllocatorBase.cs:2024— `adjustedUntilAddress > 0 && ((adjustedUntilAddress - (long)offsetInFile) < PageSize)` appears character-identically in 5 files — cs/src/core/Allocator/AllocatorBase.cs, cs/src/core/Allocator/BlittableAllocator.cs, cs/src/core/Allocator/GenericAllocator.cs, cs/src/core/Allocator/VarLenBlittableAllocator.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate cs/src/core/Utilities/Status.cs:128— `basicCode != StatusCode.Pending && basicCode != StatusCode.Error` appears character-identically in 2 files — cs/remote/src/FASTER.client/Status.cs, cs/src/core/Utilities/Status.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate cs/src/core/Allocator/BlittableScanIterator.cs:108— `currentAddress < headAddress && !forceInMemory` appears character-identically in 2 files — cs/src/core/Allocator/BlittableScanIterator.cs, cs/src/core/Allocator/VarLenBlittableScanIterator.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate cs/src/core/Allocator/BlittableScanIterator.cs:95— `currentAddress < hlog.BeginAddress && !forceInMemory` appears character-identically in 2 files — cs/src/core/Allocator/BlittableScanIterator.cs, cs/src/core/Allocator/VarLenBlittableScanIterator.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate cs/src/core/Allocator/BlittableScanIterator.cs:136— `currentAddress >= headAddress && store is not null` appears character-identically in 3 files — cs/src/core/Allocator/BlittableScanIterator.cs, cs/src/core/Allocator/GenericScanIterator.cs, cs/src/core/Allocator/VarLenBlittableScanIterator.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate cs/remote/src/FASTER.server/Servers/GenericServer.cs:129— `ex is IOException || ex is UnauthorizedAccessException` appears character-identically in 2 files — cs/remote/src/FASTER.server/Servers/GenericServer.cs, cs/remote/src/FASTER.server/Servers/VarLenServer.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate cs/src/core/Index/FASTER/Implementation/ContinuePending.cs:60— `fasterSession.Ctx.phase == Phase.PREPARE && IsEntryVersionNew(ref stackCtx.hei.entry)` appears character-identically in 2 files — cs/src/core/Index/FASTER/Implementation/ContinuePending.cs, cs/src/core/Index/FASTER/Implementation/InternalRead.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate cs/src/core/Allocator/BlittableScanIterator.cs:99— `frameSize == 0 && currentAddress < headAddress && !forceInMemory` appears character-identically in 2 files — cs/src/core/Allocator/BlittableScanIterator.cs, cs/src/core/Allocator/VarLenBlittableScanIterator.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate cs/benchmark/ConcurrentDictionaryBenchmark.cs:115— `idx < chunk_idx + YcsbConstants.kChunkSize && !done` appears character-identically in 3 files — cs/benchmark/ConcurrentDictionaryBenchmark.cs, cs/benchmark/FasterSpanByteYcsbBenchmark.cs, cs/benchmark/FasterYcsbBenchmark.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate cs/remote/src/FASTER.server/Servers/GenericServer.cs:43— `opts.EnableStorageTier && !Directory.Exists(opts.LogDir)` appears character-identically in 2 files — cs/remote/src/FASTER.server/Servers/GenericServer.cs, cs/remote/src/FASTER.server/Servers/VarLenServer.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate cs/remote/src/FASTER.server/Servers/GenericServer.cs:84— `opts.EnableStorageTier && Directory.Exists(opts.LogDir)` appears character-identically in 2 files — cs/remote/src/FASTER.server/Servers/GenericServer.cs, cs/remote/src/FASTER.server/Servers/VarLenServer.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate cs/src/core/Allocator/BlittableScanIterator.cs:125— `recordInfo.SkipOnScan || recordInfo.IsNull()` appears character-identically in 3 files — cs/src/core/Allocator/BlittableScanIterator.cs, cs/src/core/Allocator/GenericScanIterator.cs, cs/src/core/Allocator/VarLenBlittableScanIterator.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate cs/src/core/Index/FASTER/Implementation/ContinuePending.cs:109— `stackCtx.recSrc.HasMainLogSrc && stackCtx.recSrc.LogicalAddress >= hlog.ReadOnlyAddress` appears character-identically in 3 files — cs/src/core/Index/FASTER/Implementation/ContinuePending.cs, cs/src/core/Index/FASTER/Implementation/InternalRMW.cs, cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate cs/src/core/Index/FASTER/Implementation/InternalDelete.cs:105— `stackCtx.recSrc.LogicalAddress >= hlog.ReadOnlyAddress && latchDestination == LatchDestination.NormalProcessing` appears character-identically in 3 files — cs/src/core/Index/FASTER/Implementation/InternalDelete.cs, cs/src/core/Index/FASTER/Implementation/InternalRMW.cs, cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate cs/src/core/Index/FASTER/Implementation/InternalRMW.cs:187— `stackCtx.recSrc.ephemeralLockResult == EphemeralLockResult.HoldForSeal && stackCtx.recSrc.LogicalAddress >= hlog.HeadAddress && srcRecordInf…` appears character-identically in 2 files — cs/src/core/Index/FASTER/Implementation/InternalRMW.cs, cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate cs/src/core/Index/FASTER/Implementation/InternalDelete.cs:164— `status == OperationStatus.ALLOCATE_FAILED && pendingContext.IsAsync` appears character-identically in 3 files — cs/src/core/Index/FASTER/Implementation/InternalDelete.cs, cs/src/core/Index/FASTER/Implementation/InternalRead.cs, cs/src/core/Index/FASTER/Implementation/InternalUpsert.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate cs/remote/src/FASTER.server/BinaryServerSession.cs:181— `status.Found && !serializer.SkipOutput(ref dcurr, (int)(dend - dcurr))` appears character-identically in 2 files — cs/remote/src/FASTER.server/BinaryServerSession.cs, cs/remote/src/FASTER.server/WebsocketServerSession.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate cs/samples/StoreCustomTypes/Program.cs:59— `status.Found && g1.value.value == key.key` appears character-identically in 2 files — cs/samples/StoreCheckpointRecover/Program.cs, cs/samples/StoreCustomTypes/Program.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs:370— `subscriptions == null && prefixSubscriptions == null` appears character-identically in 2 files — cs/remote/src/FASTER.server/PubSub/SubscribeBroker.cs, cs/remote/src/FASTER.server/PubSub/SubscribeKVBroker.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Commented-out code cs/playground/CacheStoreConcurrent/Program.cs:77— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code cs/playground/CacheStoreConcurrent/Program.cs:192— 3 consecutive lines of code sit inside a `/* … */` block — a block of code switched off rather than removed, which rots and confuses. Delete it (version control remembers).
Commented-out code cs/playground/ClassRecoveryDurability/Program.cs:92— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code cs/playground/ClassRecoveryDurability/Program.cs:111— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code cs/playground/ClassRecoveryDurability/Program.cs:197— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code cs/playground/ClassRecoveryDurability/Program.cs:217— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code cs/remote/src/FASTER.server/WebsocketServerSession.cs:300— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code cs/src/core/Allocator/AllocatorBase.cs:1612— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code cs/src/core/Allocator/AllocatorBase.cs:1733— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code cs/src/core/Allocator/AllocatorBase.cs:1763— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code cs/src/core/Allocator/MallocFixedPageSize.cs:303— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code cs/src/core/Allocator/VarLenBlittableAllocator.cs:495— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code cs/src/core/Device/LocalStorageDevice.cs:498— 11 consecutive lines of code sit inside a `/* … */` block — a block of code switched off rather than removed, which rots and confuses. Delete it (version control remembers).
Commented-out code cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs:133— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code cs/src/core/Index/Common/RecordInfo.cs:118— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code cs/src/core/Index/Common/RecordInfo.cs:131— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code cs/src/core/Index/Common/RecordInfo.cs:134— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Silent fallback default in catch cs/src/core/FasterLog/FasterLog.cs:1232— `WaitUncommittedAsync` swallows `ObjectDisposedException` into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch cs/src/core/FasterLog/FasterLogIterator.cs:193— `SlowWaitAsync` swallows `ObjectDisposedException` into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch cs/src/core/FasterLog/FasterLogIterator.cs:222— `SlowWaitUncommittedAsync` swallows `ObjectDisposedException` into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch cs/src/core/Utilities/Utility.cs:158— `IsBlittable` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch cs/src/devices/AzureStorageDevice/BlobUtilsV12.cs:187— `ForceDeleteAsync` swallows `Azure.RequestFailedException` into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch cs/samples/ResizableCacheStore/Program.cs:303— `GetArgs` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch cs/remote/src/FASTER.client/FixedLenSerializer.cs:97— `IsBlittable` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch cs/remote/src/FASTER.server/FixedLenSerializer.cs:144— `IsBlittable` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Fat interface: IFasterContext<Key, Value, Input, Output, Context> (67 members) cs/src/core/ClientSession/IFasterContext.cs:32— `IFasterContext<Key, Value, Input, Output, Context>` declares 67 members: `CompletePending`, `CompletePendingWithOutputs`, `CompletePendingAsync`, `CompletePendingWithOutputsAsync`, `Read`, `Read`, `Read`, `Read`, `Read`, `Read`, `Read`, `Read`, `Read`, `Read`, `Read`, `ReadAtAddress`, `ReadAsync`, `ReadAsync`, `ReadAsync`, `ReadAsync`, `ReadAsync`, `ReadAsync`, `ReadAsync`, `ReadAsync`, `ReadAtAddressAsync`, `Upsert`, `Upsert`, `Upsert`, `Upsert`, `Upsert`, `Upsert`, `Upsert`, `Upsert`, `Upsert`, `Upsert`, `UpsertAsync`, `UpsertAsync`, `UpsertAsync`, `UpsertAsync`, `UpsertAsync`, and 27 more. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 67 declarations carry 16 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 16 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: ILockableContext<TKey> (20 members) cs/src/core/ClientSession/ILockableContext.cs:13— `ILockableContext<TKey>` declares 20 members under just 9 distinct name(s): `BeginLockable`, `EndLockable`, `NeedKeyHash`, `CompareKeyHashes`, `CompareKeyHashes`, `SortKeyHashes`, `SortKeyHashes`, `Lock`, `Lock`, `TryLock`, `TryLock`, `TryLock`, `TryLock`, `TryLock`, `TryLock`, `TryPromoteLock`, `TryPromoteLock`, `TryPromoteLock`, `Unlock`, `Unlock`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 20 separate responsibilities: a caller binds to 9 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 20 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
Fat interface: IDevice (22 members) cs/src/core/Device/IDevice.cs:19— `IDevice` declares 22 members: `SectorSize`, `FileName`, `Capacity`, `SegmentSize`, `StartSegment`, `EndSegment`, `ThrottleLimit`, `Initialize`, `TryComplete`, `Throttle`, `WriteAsync`, `ReadAsync`, `WriteAsync`, `ReadAsync`, `TruncateUntilAddressAsync`, `TruncateUntilAddress`, `TruncateUntilSegmentAsync`, `TruncateUntilSegment`, `RemoveSegmentAsync`, `RemoveSegment`, `GetFileSize`, `Reset`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 22 declarations carry 20 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 20 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IFasterKV<Key, Value> (24 members) cs/src/core/Index/Interfaces/IFasterKV.cs:13— `IFasterKV<Key, Value>` declares 24 members: `NewSession`, `ResumeSession`, `ResumeSession`, `GrowIndex`, `TryInitiateFullCheckpoint`, `TakeFullCheckpointAsync`, `TryInitiateIndexCheckpoint`, `TakeIndexCheckpointAsync`, `TryInitiateHybridLogCheckpoint`, `TakeHybridLogCheckpointAsync`, `Recover`, `RecoverAsync`, `Recover`, `RecoverAsync`, `Recover`, `RecoverAsync`, `CompleteCheckpointAsync`, `Reset`, `EntryCount`, `IndexSize`, `Comparer`, `DumpDistribution`, `Log`, `ReadCache`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 24 declarations carry 19 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 19 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IFunctions<Key, Value, Input, Output, Context> (23 members) cs/src/core/Index/Interfaces/IFunctions.cs:14— `IFunctions<Key, Value, Input, Output, Context>` declares 23 members: `SingleReader`, `ConcurrentReader`, `ReadCompletionCallback`, `SingleWriter`, `PostSingleWriter`, `ConcurrentWriter`, `NeedInitialUpdate`, `InitialUpdater`, `PostInitialUpdater`, `NeedCopyUpdate`, `CopyUpdater`, `PostCopyUpdater`, `InPlaceUpdater`, `RMWCompletionCallback`, `SingleDeleter`, `PostSingleDeleter`, `ConcurrentDeleter`, `DisposeSingleWriter`, `DisposeCopyUpdater`, `DisposeInitialUpdater`, `DisposeSingleDeleter`, `DisposeDeserializedFromDisk`, `CheckpointCompletionCallback`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: ICheckpointManager (17 members) cs/src/core/Index/Recovery/ICheckpointManager.cs:31— `ICheckpointManager` declares 17 members: `InitializeIndexCheckpoint`, `InitializeLogCheckpoint`, `CommitIndexCheckpoint`, `CommitLogCheckpoint`, `CheckpointVersionShift`, `CommitLogIncrementalCheckpoint`, `GetIndexCheckpointMetadata`, `GetLogCheckpointMetadata`, `GetIndexCheckpointTokens`, `GetLogCheckpointTokens`, `GetIndexDevice`, `GetSnapshotLogDevice`, `GetSnapshotObjectLogDevice`, `GetDeltaLogDevice`, `Purge`, `PurgeAll`, `OnRecovery`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Outdated: Microsoft.Bcl.AsyncInterfaces cs/src/core/FASTER.core.csproj:51— Microsoft.Bcl.AsyncInterfaces 7.0.0 → 11.0.0 available (referenced by FASTER.core).
Outdated: Microsoft.Extensions.Logging cs/remote/samples/FixedLenServer/FixedLenServer.csproj:30— Microsoft.Extensions.Logging 7.0.0 → 11.0.0 available (referenced by FASTER.core).
Outdated: Microsoft.SourceLink.GitHub cs/remote/src/FASTER.client/FASTER.client.csproj:36— Microsoft.SourceLink.GitHub 1.1.1 → 11.0.100 available (referenced by FASTER.core).
Outdated: Microsoft.Extensions.Logging.Configuration cs/remote/samples/FixedLenServer/FixedLenServer.csproj:31— Microsoft.Extensions.Logging.Configuration 8.0.1 → 11.0.0 available (referenced by VarLenServer).
Outdated: Microsoft.Extensions.Logging.Console cs/remote/samples/FixedLenServer/FixedLenServer.csproj:32— Microsoft.Extensions.Logging.Console 8.0.1 → 11.0.0 available (referenced by VarLenServer).
Outdated: Microsoft.Extensions.Logging.Debug cs/remote/samples/VarLenServer/VarLenServer.csproj:29— Microsoft.Extensions.Logging.Debug 8.0.1 → 11.0.0 available (referenced by VarLenServer).
IC1 · Incompleteness & stubs· Member throws NotSupportedException · ×2
Member throws NotSupportedException cs/src/core/Allocator/VarLenBlittableAllocator.cs:276— `GetKeyAddressInfo`'s body only throws NotSupportedException — sometimes a deliberate contract, often an unfinished stub. Confirm it's intentional.
Member throws NotSupportedException cs/src/core/Allocator/VarLenBlittableAllocator.cs:281— `GetValueAddressInfo`'s body only throws NotSupportedException — sometimes a deliberate contract, often an unfinished stub. Confirm it's intentional.
Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 7 significant file(s) lose their only recent owner: cs/remote/src/FASTER.server/WebsocketServerSession.cs, cs/remote/src/FASTER.server/BinaryServerSession.cs, cs/remote/src/FASTER.server/Servers/FasterServerTcp.cs, cs/remote/src/FASTER.server/SpanByteServerSerializer.cs, cs/remote/src/FASTER.common/IServerSerializer.cs, cs/remote/src/FASTER.server/FixedLenSerializer.cs, cs/src/core/Index/CheckpointManagement/DefaultCheckpointNamingScheme.cs. Pair on, review, or document these before any departure.
Documentation: no build, run or usage example README.md:1— the repository holds project manifests and neither `README.md` nor the documents it links hold a code block or a command. Show the command that builds or runs it, or a usage snippet.
D26 · Project Cohesion· Projects may be oversized for their cohesion · ×1
Projects may be oversized for their cohesion cs/src/core/FASTER.core.csproj:1— `FASTER.core(net7.0)` overshoots its size bounds (37241 LoC, 161 public types across 1 namespaces). 1 of 37 project(s) overshoot their size bounds, lowering Project Cohesion to 9.5/10. Review these for cohesion — draw the boundary inside the assembly first (group each responsibility into its own namespace/folder and keep the cross-boundary members internal), since splitting a published assembly moves types between packages and breaks consumers.
D34 · Knowledge Freshness· Orphaned files with no living knowledge · ×1
Orphaned files with no living knowledge — 30 of 185 analysed file(s) have no living knowledge left — their last meaningful change has decayed away, so if one breaks, no one currently understands it (counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated, example/demo and scaffolding-template trees and test files identified by path convention, largest first; 185 of the 282 production source files in this repository met that bar). None is large enough to earn a read-through of its own, so this row stands in for the per-file rows rather than raising one each — most significant first: cs/stress/TestLoader.cs, cs/benchmark/TestLoader.cs, cs/src/core/Device/ShardedStorageDevice.cs, cs/src/core/ClientSession/ILockableContext.cs, cs/stress/SessionWrapper.cs, cs/src/core/Index/FASTER/Implementation/Locking/OverflowBucketLockTable.cs, cs/src/core/Index/FASTER/Implementation/ConditionalCopyToTail.cs, cs/src/core/Index/Synchronization/ISynchronizationStateMachine.cs (and 22 more). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway.
Disabled test cs/test/MemoryLogCompactionTests.cs:42— A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
M2 · Architecture documentation· No architecture diagram/doc · ×1
No architecture diagram/doc — No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.
P12 · CI test-gate honesty· Sleep-based test synchronization · ×1
Sleep-based test synchronization — 7 Task.Delay/Thread.Sleep call(s) in test code synchronize with background work by sleeping — a known flakiness precursor on slow runners. Prefer polling with a deadline or completion signals.
No SAST — No static application security testing detected. For this repository's stack, add CodeQL's csharp pack, or a .NET security analyzer package (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 2 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
P3 · Security & performance tooling· Dependabot does not watch bundler · ×1
Dependabot does not watch bundler REDACTED:12— `REDACTED` schedules updates, but no `package-ecosystem` entry covers `bundler`, which this tree depends on — so those dependencies get no update pull requests and no advisory pressure, however complete the dep-scan credit looks. Add the missing entry to the `updates:` list.
No changelog — No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
Benchmarks don't track allocations — A BenchmarkDotNet suite exists but no [MemoryDiagnoser] — allocations (the main way hot code pressures the GC) aren't being measured.
X2 · Cancellation propagation· Not all async methods take a CancellationToken · ×1
Not all async methods take a CancellationToken — Only 73/130 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
Nullable reference types not enabled everywhere — 2/30 NRT-eligible project(s) enable <Nullable>enable</Nullable> (projects targeting a pre-C#-8 framework are excluded — NRTs aren't available there). NRTs catch a whole class of null-deref bugs at compile time.
Null-forgiving operator (`!`) suppressions override nullable warnings — ~1.4 `!` suppressions per 1k syntax nodes — 5 suppression(s) across the 3516 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide. Many are correct: each is a claim the checker could not verify, and it is wrong only where the value can in fact be missing, so review the densest places first.
doc comments repeat the names cs/remote/src/FASTER.client/ClientSession.cs:53— 57 of 116 documented parameters and 11 of 82 summaries in `FASTER.client(net7.0)` only repeat the member or parameter name (e.g. "Port" for `port`). 29 documentation tag(s) are empty. This build requires documentation, so say what the name does not: units, ranges, null handling, side effects.
doc comments repeat the names cs/remote/src/FASTER.common/BatchHeader.cs:16— 6 of 73 documented parameters and 30 of 115 summaries in `FASTER.common(net7.0)` only repeat the member or parameter name (e.g. "Size" for `Size`). 25 documentation tag(s) are empty. This build requires documentation, so say what the name does not: units, ranges, null handling, side effects.
doc comments repeat the names cs/src/core/Allocator/AllocatorBase.cs:53— 68 of 1928 documented parameters and 222 of 1649 summaries in `FASTER.core(net7.0)` only repeat the member or parameter name (e.g. "Comparer" for `comparer`). 1049 documentation tag(s) are empty. This build requires documentation, so say what the name does not: units, ranges, null handling, side effects.
doc comments repeat the names cs/src/devices/AzureStorageDevice/AzureStorageDevice.cs:77— 4 of 48 documented parameters and 19 of 55 summaries in `FASTER.devices.AzureStorageDevice(net7.0)` only repeat the member or parameter name (e.g. "Blob manager instance" for `blobManager`). 17 documentation tag(s) are empty. This build requires documentation, so say what the name does not: units, ranges, null handling, side effects.
doc comments repeat the names cs/remote/test/FASTER.remote.test/TestUtils.cs:12— 0 of 0 documented parameters and 3 of 51 summaries in `FASTER.remote.test(net7.0)` only repeat the member or parameter name (e.g. "Address" for `Address`). Delete the restating tags, or add what the name does not say.
doc comments repeat the names cs/remote/src/FASTER.server/ByteArrayComparer.cs:16— 4 of 118 documented parameters and 19 of 118 summaries in `FASTER.server(net7.0)` only repeat the member or parameter name (e.g. "Equals" for `Equals`). 84 documentation tag(s) are empty. This build requires documentation, so say what the name does not: units, ranges, null handling, side effects.
doc comments repeat the names cs/test/LogFormatter.cs:14— 0 of 9 documented parameters and 2 of 7 summaries in `FASTER.test(net7.0)` only repeat the member or parameter name (e.g. "Format date" for `FormatDate`). 6 documentation tag(s) are empty. Delete the restating tags, or add what the name does not say.
Skipped (documented): MemoryLogCompactionTest1 cs/test/MemoryLogCompactionTests.cs:39— Skipped with a documented reason — a deferral, not lazy debt: Fix required in ReadOnlyMemory<T> AsRef
Appendix B — Reproduction & audit trail
Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.
trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 3 file(s) — `cs/src/core/Allocator/BlittableAllocator.cs`, `cs/src/core/Allocator/VarLenBlittableAllocator.cs`, `cs/src/core/VarLen/IVariableLengthStruct.cs` — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
0
—
Run 01a1cd99-416a-7ae4-94e7-059fc6f676cf · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.
Issues: 91 · Warnings: 906 · Recommendations: 141 · Info: 20 — Appendix A · all findings · full markdown report.
Generated by the Canine Code Analyzer: deterministic code-health analysis. 12-11-2026 @ 02:32 UTC.
Downloadable artifacts
Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.