Public report of lydavid/MusicSearch, published 17 November 2026. It has the same score, grades and number of findings as the full report. The details of security findings (where they are in the code, which known vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive report Measured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.11.4). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey → Signed and filed in the standard's public register, 17 November 2026, 13:00 UTC · Survey ID cd_2137046a85a14ac0af185eb5fc64894a

lydavid/MusicSearch

Measured 17 November 2026, 12:59 UTC, at code version 05bf11a

First survey, so nothing to compare with yet
CAI score 52.0out of 100 At risk

The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.

A medium codebase: 70,199 lines of product code in 35 projects, tests not counted · Estimated rebuild effort: about 0.7 person-years · Weakest lens: Accessibility, 43.3

Findings by how serious they are

51 critical 273 serious 17 minor

12 dimensions are left out of the score. For each one, we either couldn't measure it in this code, or found no evidence of the safeguard we look for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.

This survey was produced by

Assert small markCanine Code Analyzer
Producer
Canine Development
Analyzer
Canine Code Analyzer engine 1.0.0
Measured
17 November 2026, 12:59 UTC

A measurement, not a certificate. The Code Assurance Index records a number together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee the code. The standard was written by Canine Development, which also builds the Canine Code Analyzer. It is open to any tool that implements it, and today the Canine Code Analyzer is the only one that does.

A critical security finding is open, such as a library with a known critical vulnerability or a password or key found in the code. The score itself is unchanged, but its band shows At risk until the finding is fixed. See the Security and Compliance lens.

The score is deterministic, which means the same code always gets the same score. We work it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸

60of 60 dimensions measured by tools.
327of 341 findings point to an exact file and line, so you can open each one in the code. The other 14 concern the repository as a whole, such as missing documentation.
60dimensions across 8 lenses, read from 70,199 lines of product code in 35 projects.
Chapters

Executive summary

lydavid/MusicSearch is rated At risk because critical security findings are open. Its score is held back in part because it has controls that only work with a mouse. It scores 52.0 out of 100, which the At risk rating leaves unchanged.

Accessibility, at 43.3, is the weakest lens and counts most in the score. The best first step for the work it takes is fixing the password or key in the code, worth about 3.5 points. Making the controls keyboard-usable would lift Accessibility itself, worth about 4.0 points. Raising Accessibility to 70 would lift the score to about 57.2.

Seventeen known security holes in the packages the code depends on can be used by attackers. Fifteen secrets can leak from the build pipeline, and six passwords or keys in the code's history and one in the code are open to anyone who can read the repository. Replacing each exposed password or key, updating the vulnerable packages and limiting each secret to its own step would close these risks. Passing outside input through environment variables would fix the pipeline step that puts outside input straight into a shell command, and the three pipeline steps that run downloads without checking them need each download checked against a known checksum first. The three sets of files in separate parts that keep changing together need that dependency made explicit.

The product code is 70,199 lines, about €110,000 to rebuild.

A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.

How the score is built: what each lens counts for The lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
Accessibility 43.3 · counts for 45%Production Readiness 48.1 · counts for 25%Security and Compliance 48.4 · counts for 14%Maturity 81.3 · counts for 8%Architecture 86.8 · counts for 4%Code Health 92.6 · counts for 2%Performance 94.3 · counts for 1%Domain Modelling 100.0 · counts for 1%

If Accessibility rose from 43.3 to 70, the lowest score rated Strong, the score would rise from 52.0 to about 57.2.

Code composition: what the lines of code are
Product code 71%Tests 29%
Rebuild cost: about €110,000 · Estimate
Cost to rebuild€36,000 to €180,000, for 602 to 1,911 hours of work, about 0.7 person-years for 1 to 2 engineers
Difficulty of the problemStandard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor×0.7 at a score of 52. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
SizeMedium: 70,199 lines of product code
What it is notNot a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.

How the estimate is made: We price the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.

Top priorities

The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.

1
Resolve the 1 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED.
Raises the score by about 3.5 points · Low effort · REDACTED Scanning
2
Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href.
Raises the score by about 4.0 points · Medium effort · Keyboard semantics
3
Write a diagnostic trail the user can hand back with a bug report: a log file under the platform's per-user data directory, switchable with a `--verbose`/`--debug` flag.
Start with the error paths that emit nothing — a discarded error is the failure the user cannot describe and you cannot reproduce.
Raises the score by about 2.9 points · Medium effort · Observability

Diagnosis: what the measurements show together

Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.

Where the investment is most exposed · Value at risk
This code would cost about €110,000 to build again, about 0.7 person-years of work. Its weakest lens is Accessibility, at 43.3 (Weak). Accessibility is about whether the interface is built so that everyone can use it, including people who can't see the screen or can't use a mouse. Because the weakest lens counts most in the score, work on Accessibility also moves the score most.
Based on: the rebuild estimate · the Accessibility grade · how much each lens counts
What to do: Start with the Accessibility actions in Top priorities.
If you do one thing first · First action
Resolve the 1 Leaked secret finding(s) in REDACTED Scanning. Of all the actions in this report, it raises the score most for the work it takes: about 3.5 points for low effort, because it clears the 1 REDACTED Scanning findings. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort

Architecture — module dependency graph

Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways, which only happens where the projects form a dependency cycle. A graph without cycles has none.

arch MusicSearch:android:app MusicSearch:android:app MusicSearch:core:logging:api MusicSearch:core:logging:api MusicSearch:android:app->MusicSearch:core:logging:api MusicSearch:shared MusicSearch:shared MusicSearch:android:app->MusicSearch:shared MusicSearch:shared:domain MusicSearch:shared:domain MusicSearch:android:app->MusicSearch:shared:domain MusicSearch:shared:feature:nowplaying MusicSearch:shared:feature:nowplaying MusicSearch:android:app->MusicSearch:shared:feature:nowplaying MusicSearch:shared:feature:spotify MusicSearch:shared:feature:spotify MusicSearch:android:app->MusicSearch:shared:feature:spotify MusicSearch:ui:common MusicSearch:ui:common MusicSearch:android:app->MusicSearch:ui:common MusicSearch:data:coverart MusicSearch:data:coverart MusicSearch:data:coverart->MusicSearch:core:logging:api MusicSearch:data:coverart->MusicSearch:shared:domain MusicSearch:data:database MusicSearch:data:database MusicSearch:data:musicbrainz MusicSearch:data:musicbrainz MusicSearch:data:database->MusicSearch:data:musicbrainz MusicSearch:data:database->MusicSearch:shared:domain MusicSearch:data:musicbrainz->MusicSearch:core:logging:api MusicSearch:data:musicbrainz->MusicSearch:shared:domain MusicSearch:data:repository MusicSearch:data:repository MusicSearch:data:repository->MusicSearch:core:logging:api MusicSearch:data:repository->MusicSearch:data:coverart MusicSearch:data:repository->MusicSearch:data:database MusicSearch:data:repository->MusicSearch:data:musicbrainz MusicSearch:data:repository->MusicSearch:shared:domain MusicSearch:test-data MusicSearch:test-data MusicSearch:data:repository->MusicSearch:test-data MusicSearch:data:spotify MusicSearch:data:spotify MusicSearch:data:spotify->MusicSearch:core:logging:api MusicSearch:data:spotify->MusicSearch:shared:domain MusicSearch:shared->MusicSearch:data:coverart MusicSearch:shared->MusicSearch:data:database MusicSearch:shared->MusicSearch:data:musicbrainz MusicSearch:shared->MusicSearch:data:repository MusicSearch:shared->MusicSearch:data:spotify MusicSearch:shared->MusicSearch:shared:domain MusicSearch:shared:feature:database MusicSearch:shared:feature:database MusicSearch:shared->MusicSearch:shared:feature:database MusicSearch:shared:feature:details MusicSearch:shared:feature:details MusicSearch:shared->MusicSearch:shared:feature:details MusicSearch:shared:feature:history MusicSearch:shared:feature:history MusicSearch:shared->MusicSearch:shared:feature:history MusicSearch:shared:feature:images MusicSearch:shared:feature:images MusicSearch:shared->MusicSearch:shared:feature:images MusicSearch:shared:feature:listens MusicSearch:shared:feature:listens MusicSearch:shared->MusicSearch:shared:feature:listens MusicSearch:shared->MusicSearch:shared:feature:nowplaying MusicSearch:shared:feature:settings MusicSearch:shared:feature:settings MusicSearch:shared->MusicSearch:shared:feature:settings MusicSearch:shared->MusicSearch:shared:feature:spotify MusicSearch:shared->MusicSearch:ui:common MusicSearch:shared:feature:database->MusicSearch:shared:domain MusicSearch:shared:feature:database->MusicSearch:test-data MusicSearch:shared:feature:database->MusicSearch:ui:common MusicSearch:ui:test:screenshot MusicSearch:ui:test:screenshot MusicSearch:shared:feature:database->MusicSearch:ui:test:screenshot MusicSearch:shared:feature:details->MusicSearch:core:logging:api MusicSearch:shared:feature:details->MusicSearch:shared:domain MusicSearch:shared:feature:details->MusicSearch:test-data MusicSearch:shared:feature:details->MusicSearch:ui:common MusicSearch:shared:feature:details->MusicSearch:ui:test:screenshot MusicSearch:shared:feature:history->MusicSearch:shared:domain MusicSearch:shared:feature:history->MusicSearch:test-data MusicSearch:shared:feature:history->MusicSearch:ui:common MusicSearch:shared:feature:history->MusicSearch:ui:test:screenshot MusicSearch:shared:feature:images->MusicSearch:shared:domain MusicSearch:shared:feature:images->MusicSearch:test-data MusicSearch:shared:feature:images->MusicSearch:ui:common MusicSearch:shared:feature:images->MusicSearch:ui:test:screenshot MusicSearch:shared:feature:listens->MusicSearch:shared:domain MusicSearch:shared:feature:listens->MusicSearch:test-data MusicSearch:shared:feature:listens->MusicSearch:ui:common MusicSearch:shared:feature:listens->MusicSearch:ui:test:screenshot MusicSearch:shared:feature:nowplaying->MusicSearch:shared:domain MusicSearch:shared:feature:nowplaying->MusicSearch:ui:common MusicSearch:shared:feature:nowplaying->MusicSearch:ui:test:screenshot MusicSearch:shared:feature:settings->MusicSearch:shared:domain MusicSearch:shared:feature:settings->MusicSearch:test-data MusicSearch:shared:feature:settings->MusicSearch:ui:common MusicSearch:shared:feature:settings->MusicSearch:ui:test:screenshot MusicSearch:shared:feature:spotify->MusicSearch:shared:domain MusicSearch:shared:feature:spotify->MusicSearch:ui:common MusicSearch:shared:feature:spotify->MusicSearch:ui:test:screenshot MusicSearch:test-data->MusicSearch:data:coverart MusicSearch:test-data->MusicSearch:data:database MusicSearch:test-data->MusicSearch:data:musicbrainz MusicSearch:test-data->MusicSearch:data:spotify MusicSearch:test-data->MusicSearch:shared:domain MusicSearch:ui:common->MusicSearch:core:logging:api MusicSearch:ui:common->MusicSearch:shared:domain MusicSearch:ui:common->MusicSearch:test-data MusicSearch:ui:common->MusicSearch:ui:test:screenshot __more__ +15 more projects

Architecture: which parts of the code depend on which

The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.

407 modules, with 1257 dependencies between them. 6 loops run through 45 of the modules, marked above the diagonal.

The table shows the 40 modules with the most connections; 367 more are left out to keep it readable.

Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
uses →1 core.logging2 shared.domain3 shared.domain.auth4 shared.domain.coroutine5 shared.domain.error6 shared.domain.network7 shared.domain.sort8 shared.domain.list.ListFilters9 shared.domain.musicbrainz10 ui.common.musicbrainz11 shared.domain.image12 shared.domain.relation13 shared.domain.release14 shared.domain.listitem15 shared.domain.collection16 shared.domain.history17 shared.domain.list18 shared.domain.tag19 shared.domain.wikimedia20 shared.domain.history.usecase21 shared.domain.listen22 shared.domain.preferences23 shared.domain.details24 ui.common.screen25 shared.domain.artist26 ui.common.topappbar27 data.musicbrainz.models.core28 ui.common.list29 data.database.dao30 data.musicbrainz.api31 shared.feature.details.utils32 data.repository.base33 data.repository.list34 shared.feature.details.artist35 shared.feature.details.release36 data.repository.artist37 data.repository.recording38 data.repository.release39 data.repository.releasegroup40 data.repository.work
1 core.logging
2 shared.domain
3 shared.domain.auth
4 shared.domain.coroutine
5 shared.domain.error
6 shared.domain.network
7 shared.domain.sort
8 shared.domain.list.ListFilters12113
9 shared.domain.musicbrainz1
10 ui.common.musicbrainz2
11 shared.domain.image13121
12 shared.domain.relation2412
13 shared.domain.release31121
14 shared.domain.listitem22661444
15 shared.domain.collection211
16 shared.domain.history21
17 shared.domain.list7713
18 shared.domain.tag111
19 shared.domain.wikimedia11
20 shared.domain.history.usecase29
21 shared.domain.listen53221222
22 shared.domain.preferences1132111
23 shared.domain.details7131724315
24 ui.common.screen2632111
25 shared.domain.artist221112
26 ui.common.topappbar12111
27 data.musicbrainz.models.core221
28 ui.common.list211411
29 data.database.dao16291315113332316242513422
30 data.musicbrainz.api232150
31 shared.feature.details.utils11232412111242
32 data.repository.base111111114
33 data.repository.list45217116
34 shared.feature.details.artist111111111311113
35 shared.feature.details.release1111151111131213
36 data.repository.artist111111111131142932
37 data.repository.recording1111111113112842
38 data.repository.release2111111441131121632
39 data.repository.releasegroup2111112113112932
40 data.repository.work1111111112112832
Uses a module listed above itPart of a loopThe module itself
1 core.logging2 shared.domain3 shared.domain.auth4 shared.domain.coroutine5 shared.domain.error6 shared.domain.network7 shared.domain.sort8 shared.domain.list.ListFilters9 shared.domain.musicbrainz10 ui.common.musicbrainz11 shared.domain.image12 shared.domain.relation13 shared.domain.release14 shared.domain.listitem15 shared.domain.collection16 shared.domain.history17 shared.domain.list18 shared.domain.tag19 shared.domain.wikimedia20 shared.domain.history.usecase21 shared.domain.listen22 shared.domain.preferences23 shared.domain.details24 ui.common.screen25 shared.domain.artist26 ui.common.topappbar27 data.musicbrainz.models.core28 ui.common.list29 data.database.dao30 data.musicbrainz.api31 shared.feature.details.utils32 data.repository.base33 data.repository.list34 shared.feature.details.artist35 shared.feature.details.release36 data.repository.artist37 data.repository.recording38 data.repository.release39 data.repository.releasegroup40 data.repository.workcore.logging1shared.domain2shared.domain.auth3shared.domain.coroutine4shared.domain.error5shared.domain.network6shared.domain.sort7shared.domain.list.ListFilters8shared.domain.musicbrainz9ui.common.musicbrainz10shared.domain.image11shared.domain.relation12shared.domain.release13shared.domain.listitem14shared.domain.collection15shared.domain.history16shared.domain.list17shared.domain.tag18shared.domain.wikimedia19shared.domain.history.usecase20shared.domain.listen21shared.domain.preferences22shared.domain.details23ui.common.screen24shared.domain.artist25ui.common.topappbar26data.musicbrainz.models.core27ui.common.list28data.database.dao29data.musicbrainz.api30shared.feature.details.utils31data.repository.base32data.repository.list33shared.feature.details.artist34shared.feature.details.release35data.repository.artist36data.repository.recording37data.repository.release38data.repository.releasegroup39data.repository.work40121131213121241231121226614442112177131111129532212221132111713172431526321112211121211122121141116291315113332316242513422232150112324121112421111111144521711611111111131111311111511111312131111111111311429321111111113112842211111144113112163221111121131129321111111112112832+367 more modules (most-connected shown)

At a glance — Code Health · 92.6 · Exemplary ·

At a glance — Architecture · 86.8 · Strong ·

At a glance — Maturity · 81.3 · Strong ·

At a glance — Readiness · 48.1 · Weak · gated by P2, P3 ·

At a glance — Security · 48.4 · Weak · gated by D29 ·

At a glance — Domain Modelling · 100.0 · Exemplary ·

At a glance — Accessibility · 43.3 · Weak · gated by AC1, AC4 ·

At a glance — Performance · 94.3 · Exemplary ·

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP categoryFindingsSeverity
A03:2025 — Software Supply Chain Failures29High / Critical
A05:2025 — Injection20High / Critical
A07:2025 — Authentication Failures8High / Critical

Roadmap

Top priorities: Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href; Resolve the 1 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED; Write a diagnostic trail the user can hand back with a bug report: a log file under the platform's per-user data directory, switchable with a `--verbose`/`--debug` flag. Start with the error paths that emit nothing — a discarded error is the failure the user cannot describe and you cannot reproduce.

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do thisHelpsEffortDimension
Resolve the 1 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED.+3.5 ptsLowREDACTED Scanning
Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href.+4.0 ptsMediumKeyboard semantics
Write a diagnostic trail the user can hand back with a bug report: a log file under the platform's per-user data directory, switchable with a `--verbose`/`--debug` flag. Start with the error paths that emit nothing — a discarded error is the failure the user cannot describe and you cannot reproduce.+2.9 ptsMediumObservability
Add a text alternative — alt on images (alt="" for purely decorative ones), a title or aria-label on meaningful svg, an aria-label or inner fallback content on canvas, and a captions <track> on video.+2.9 ptsMediumText alternatives
Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh.+2.5 ptsMediumPage structure
Resolve the 6 REDACTED finding(s) in Secrets (history) — start with REDACTED (2), REDACTED, REDACTED.+1.2 ptsLowSecrets (history)
Keep a visible focus style (don't remove the outline without a replacement), guard animation with prefers-reduced-motion, and raise low-contrast colour pairs to at least 4.5:1.+2.3 ptsMediumVisual & motion safety
Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.+1.7 ptsMediumSecurity & performance tooling

File quality

Per-file score 0–10 — a quality signature. Of 157 files carrying findings, judged against the Production bar: 2% slop · 46% mixed · 52% near-clean.

FileScoreBandWorst signal
REDACTED0.0SlopDependency Vulnerabilities: Critical CVE: REDACTED
REDACTED3.0SlopREDACTED Scanning: Leaked secret: REDACTED
REDACTED3.7SlopStatic Analysis (SAST): High: REDACTED
REDACTED4.4MixedStatic Analysis (SAST): High: REDACTED
REDACTED5.1MixedStatic Analysis (SAST): High: REDACTED
REDACTED5.1MixedStatic Analysis (SAST): High: REDACTED
REDACTED5.8MixedStatic Analysis (SAST): High: REDACTED
core/preferences/src/commonMain/kotlin/ly/david/musicsearch/core/preferences/AppPreferencesImpl.kt5.9MixedGod Classes: TooManyMethods: AppPreferencesImpl
ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/release/ReleaseListItem.kt6.0MixedExplicit Debt: TodoComment
shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/utils/DetailsPresenter.kt6.0MixedExplicit Debt: TodoComment
ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/sort/ListFiltersMenuItems.kt6.0MixedExplicit Debt: TodoComment
ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/recording/RecordingListItem.kt6.0MixedExplicit Debt: TodoComment
shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistDetailsTabUi.kt6.0MixedExplicit Debt: TodoComment
shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaDetailsTabUi.kt6.0MixedExplicit Debt: TodoComment
data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ArtistDao.kt6.0MixedExplicit Debt: TodoComment
shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListenAdditionalActionsBottomSheetContent.kt6.0MixedExplicit Debt: TodoComment
data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AreaDao.kt6.0MixedExplicit Debt: TodoComment
data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/NowPlayingHistoryRepositoryImpl.kt6.0MixedExplicit Debt: TodoComment
ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/list/BaseListPresenter.kt6.3MixedGod Classes: MethodTooLong: BaseListPresenter.getEntityType
data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/MbidImageDao.kt6.3MixedCode Duplication: Edited copy of a member (15 corresponding lines)

How the grades work

Every finding carries one of four grades. Three say how serious it is. The fourth says this survey could not settle it — and it is a grade, not a gap.

Critical — 51

A definite problem that already costs you something and drags the score down: a missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here tends to cause failures elsewhere.

Serious — 273

Likely wrong, but not failing yet. It degrades the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to carry for two years either.

Minor — 17

Recorded, with no effect on how the codebase functions. Present so the survey is complete, not because it needs doing.

Could not be resolved — 12

Something this survey could not settle from the outside, and which could be critical or serious. Either a control was required and no positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean result. These are excluded from the score rather than awarded a pass, so the number on the cover neither rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each one is named under Limitations.

Methodology & how to trust this report

This survey is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. All 60 evaluated dimensions are computed by tools and static analysis; no language model sets or judges any of them. Overall confidence is 0.9, the weighted average across measured dimensions.

Every figure here is one of two kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10.

What we checked — 60 dimensions across the health lenses
D1D2D3D4D5D6D7D12D13D14D15D17D19D20D21D26D28D29D30D34D35D36D43D44AC1AC2AC3AC4AC5AC6AX10AX3AX4AX6AX8DM10DM12DM6DM9M1M2M3M4P1P2P3P4P6PF1PF3X1X12X16X18X2X21X23X27X3X5

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions
  1. Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 327 of 341 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
  2. Is there a tool behind the number? Every score below names the method that produced it: Roslyn, git or a scanner, not a narrative.
  3. Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

MethodBacksVersionEvaluator
Roslyn static analysisComplexity, cohesion, coupling, dead code, API surface, layering5.3.0✓ deterministic
Native secret scannerHardcoded secrets / credentials1.0.0✓ deterministic
Canine Code Analyzer duplication detector (in-process)Code duplication1.0.0✓ deterministic
Coverage (coverlet / dotnet-coverage)Line & branch coverage10.0.400✓ deterministic
NuGet / dotnetOutdated, vulnerable & deprecated dependencies10.0.400✓ deterministic
git / LibGit2SharpChurn hotspots, knowledge concentration, history2.43.0 · 0.31.0✓ deterministic
gitleaks · semgrep · trivySecrets in history, SAST, CVEs, IaC & container, PII / GDPR1.86.0 · 0.69.3✓ deterministic

Every finding is locatable in findings.md. Run 01a1e997-9505-7fa8-a152-ce45eefbc1bc.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

  • D8 Code Coverage — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT MEASURED: test source is present (.kt) but the built-in coverage collector has no runner for this repository's ecosystem — so this suite was never executed by it. Not scored — this is a gap in the analyzer's language coverage, not a defect in the repo.
  • D11 Test Reliability — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test source is present (.kt) and this repository declares a JVM test suite (repository root, Gradle), but it was not re-run: the analyzer environment could not run it. Not scored — this is a gap in the analyzer's language coverage, not a finding about this repository.
  • D14 License Compliance — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This repository declares a Gradle build (build.gradle/build.gradle.kts), but the licence verdict published here was taken over its gem dependencies. Nothing was read about its Gradle dependencies' licensing in either direction, and a clean score on this card must not be read as covering them.
  • D14 License Compliance — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This repository declares package.json, but the licence verdict published here was taken over its gem dependencies. Nothing was read about its npm dependencies' licensing in either direction, and a clean score on this card must not be read as covering them.
  • D16 Bus Factor — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. Single-maintainer repository — bus factor is not applicable (11 contributor(s) across 5816 commit(s) sampled, automation and bot accounts excluded). One of them holds 97% of the history; the other 10 hold 0.3% each on average, below the 5% at which there is somebody to hand the work to. That is a single maintainer with drive-by contributors, not a team whose knowledge has concentrated — so the bus factor is not applicable and there is nothing here for the owner to act on.
  • D19 Documentation Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This kind did not reach the 95 % precision gate in three adjudicated runs (docs/plans/deterministic-engine/adjudication/D19-sample3-v3.md), so by the pre-registered fallback it publishes no row until a re-measurement shows it does. The candidates are counted here, not reported as findings, and the score does not include them.
  • D20 ADR Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The ADR lexicon (adr-lexicon-1) covers de, en, it, nl. A record identified as another language, or whose language could not be identified (fewer than 25 words of prose, or no clear winner), is never read with English rules: its missing-section, status, consequence-cost and same-question rules abstain, and only the structural rules (title, single option, dangling link, enforcement field) run.
  • D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
  • D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
  • D22 Internal API Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D22 identifies the intentionally-exposed surface from `IsPackable` and `.Contracts` project names, MSBuild conventions read off the loaded project set. This target exposed no such projects, so the probe never ran; this says nothing about whether the repository has a public API. This repository commits no C#/VB source at all, so there was never an MSBuild project set to read these conventions off. That is OUR side and it is an ADMISSION gap, not an environment fault: no published-package marker D22 reads admitted any project here. D22 DOES collect the public API of every language in this tree, and admits a project only when its manifest makes that ecosystem's publication act in a form the marker recognises — so what is missing is not a collector but an admission rule for the publication act this repository makes, if it makes one. The remedy is a better discriminator for that marker — not a collector, and no change to the scan image can close it. The marker's rules are measured to refuse applications, so one refused repository is the rule working as calibrated; several are the evidence that it is too strict.
  • D24 Comment Value — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover the language this repository's product is written in, so it had nothing of the product to read. That is a gap in this analyzer's language reach — not a finding about this repository.
  • D32 Data Compliance (PII/GDPR) — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ArtistCollaborationDao.kt`, `data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/LookupHistoryRepositoryImpl.kt`, `data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/listen/ListensListRepositoryImpl.kt`, `shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/image/ImageId.kt`, `shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/edit/EditCollectionPresenter.kt`, … (+7 more) produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
  • AX1 Captive dependencies — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads Microsoft.Extensions.DependencyInjection registrations in C# and Spring beans in Java/Kotlin only, and this repository's container is Koin, whose lifetimes are not modelled yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • AXB1 Runtime evidence locked — no reproducible boot — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Subject: 1 markup document(s) — HTML, Razor, JSX, Vue, Svelte or server templates. The Runtime Evidence tier boots an app only via docker-compose, an Aspire AppHost, a Dockerfile, an npm dev script, a web service's own toolchain entry point (cargo, go, dotnet, Python, Spring Boot), or an Android app's own Gradle wrapper (run on an emulator); an Apple or Flutter app needs a host it lacks. None applied, so no live runtime a11y/egress/header evidence was collected. You can widen what we reach: add a docker-compose.yml (or an Aspire AppHost) that brings the app up with its dependencies. We then boot it in an isolated sandbox and gathers real runtime evidence — you change nothing in your pipeline (no CI step, no SDK).
  • C2 Access Controls — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These authorization controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks authorization controls.
  • DM8 Value-object opportunities — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check finds primitive parameters that travel together through several signatures of the domain (a missing value object). Its deterministic rule has not yet shown 95 % precision on adjudicated rows, so the clumps it finds are counted here and not published as findings, and the card carries no score. That is a limit of the analyzer, not a finding about your code.
  • DM9 Scattered domain decisions — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Arm two tells a construction that PRODUCES a measurement from one that merely passes it along, and this repository's frontend does not compute that fact. A measurement built independently in two places would not appear above.
  • DM9 Scattered domain decisions — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Some of this repository's production types come from a frontend that does not bind comparison operands to the members they read, which arm one needs, and those types were not walked for this dimension. The counts above speak for the languages that declare it.
  • GD1 Unfinished & placeholder code — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, F#, JavaScript/TypeScript, Dart, Ruby, Scala, Rust and Java source only, and no C#, F#, JavaScript/TypeScript, Dart, Ruby, Scala, Rust or Java was found, and this repository's Kotlin, Python, Swift is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • IC1 Incompleteness & stubs — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, JavaScript/TypeScript, Java, Dart, Ruby, Scala and Rust source only, and no C#, JavaScript/TypeScript, Java, Dart, Ruby, Scala or Rust was found, and this repository's Kotlin, Python, Swift is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • M4 Documentation accuracy — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. M4 checks only the claim kinds adjudicated at or above 95 % precision: links and versions (PREREGISTRATION version 9), and artefact counts an order of magnitude off. Paths, command arguments, installs, environment variables, settings, projects, packages, routes, cd targets, infrastructure products and removed modules are read but not checked, and none of them is reported or counted.
  • P3 Security & performance tooling — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. `renovate.json5` is not valid JSON (''' is an invalid start of a value. LineNumber: 35 | BytePositionInLine: 25.). Each was counted as dependency-update automation without being read, so whether it actually schedules updates is unverified: if it does not, the dep-scan credit on this card is not earned.
  • P5 DR & Backup — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. No backup/snapshot/replication config, RTO/RPO or restore-procedure documentation was found — and no production persistence was detected either (no data-access packages, no data-store services, no database resources), so there is nothing in this repository whose loss a DR control would recover. If this system's data lives in a platform or ops repo we can't see, that's where the DR evidence belongs.
  • S1 Web-Security Posture — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These web-security controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks web-security controls.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

We assess the repository exactly as committed, and only the repository. By design we do not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

  • D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
  • D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
  • D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
  • D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
  • D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
  • D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
  • D7 Architectural Integrity: Layering is checked against detected/declared rules — an architecture whose boundaries live in convention or in code review, not in a rule a scanner can read, is not enforced here.
  • D12 Dependency Hygiene: Dependency health reads manifests and lockfiles — a vulnerability in a vendored/copied dependency, or risk from how a dependency is actually used, is outside this view.
  • D13 REDACTED Scanning: REDACTED detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
  • D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
  • D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
  • D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
  • D19 Documentation Quality: Documentation quality publishes two things only: a runnable or packaged unit with no example, and a multi-project root README that maps none of its parts. It does not judge clarity, and its other checks (overview, licence, boilerplate, structure, empty sections, XML-doc coverage) are withheld after adjudication: their candidates are counted in the card's gaps, not shown as rows. A false statement in a document is M4's; units are .NET projects only.
  • D20 ADR Quality: ADR quality checks the structure of the decision records present: it cannot know about decisions made and never recorded, and it does not judge how well a record argues its case. Records in a language the section lexicon does not cover are not evaluated.
  • D21 Naming Consistency: Naming consistency compares each name with the convention its structural peers follow in this repository: it cannot tell whether a consistently used name is a good one, and languages other than C# and TypeScript are not measured.
  • D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
  • D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
  • D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
  • D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
  • D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
  • D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
  • D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
  • D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
  • AC1 Text alternatives: Alt-text is detected structurally — the scan sees that an alternative EXISTS, not whether it meaningfully describes the image, and decorative-vs-missing is judged by attribute shape; runtime-injected images and a non-role=img decorative svg are out of scope. This is accessibility readiness, never a WCAG conformance claim.
  • AC2 Forms & labels: Label association is read from static markup — a label wired up at runtime (JS-set aria-labelledby, framework-injected ids) reads as missing, a present label says nothing about whether its text is correct. A known UI-library field component (e.g. a JSX <TextField>) is now checked conservatively — flagged only when it carries NO label/aria-label/aria-labelledby/id/name — but wrapper/context-labelled libraries (Chakra/Radix FormControl+FormLabel) aren't statically visible (possible false positive) and non-JSX lowercased components are still skipped. A click handler on a plain element is now asked for a name too (it is a control the author declared), but the subtree test that answers it is deliberately generous: any DYNAMIC text expression in the subtree counts as a name, so an icon chosen by a ternary ({cond ? <IconA/> : <IconB/>}) reads as named, and a glyph component from a library the icon-import list does not know still names its parent. A clean result is "no unlabelled control found", not a labelling proof.
  • AC3 Page structure: Page structure is read from the static markup tree — landmarks, headings and lang injected at runtime aren't seen, heading ORDER is checked structurally (not against the rendered visual hierarchy), and lang/title/main fire only on full documents, never partials, and the data-table check sees header-cell presence (a <th> exists), not whether each header correctly associates with its cells. Static readiness, not conformance.
  • AC4 Keyboard semantics: Keyboard semantics are inferred from markup attributes — interactivity wired purely in script, focus managed at runtime, and component-level handlers are invisible. A clean result means "no static keyboard-trap shape", not a keyboard-operability proof.
  • AC5 ARIA correctness: ARIA correctness is checked against the static role/attribute shape — roles/attributes set dynamically aren't seen, a valid role says nothing about whether it matches the element's real behaviour, and required-state checks are suppressed when a JSX spread could supply them. The two-branch toggle check (a control whose state is conveyed only by which of two mutually exclusive branches renders) reads CONDITIONALS THAT ARE ATTRIBUTES — Vue v-if/v-else/v-show and Alpine x-if/x-show — so the same toggle written as a Svelte {#if} block or a JSX ternary is control flow the markup model never projects as a branch and is not seen at all.
  • AC6 Visual & motion safety: Contrast and motion safety are PARTIAL by construction — literal colours (hex/rgb/hsl/named) in inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS top-level declarations are read (same-rule/same-element colour+background pairs only); computed/runtime/theme colour, external-CDN stylesheets, CSS-in-JS dynamic (${…}) and nested-selector colours, cross-element pairs and image contrast stay out of reach, so a clean result is bounded by what the static CSS itself shows.
  • AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
  • DM6 Domain ↔ infrastructure boundary: Infrastructure reached through a hand-rolled wrapper, a domain-named facade, reflection, or a string-keyed service locator resolves to a non-infra type and isn't seen; the body scan is symbol resolution over syntax, not full dataflow. A clean result means "no resolved infra reference in a domain body", not a proof of purity.
  • M4 Documentation accuracy: Documentation accuracy checks links, versions and artefact counts against the tree: other claims (paths, commands, settings, routes) are read but not checked, and it cannot run the onboarding or measure how long a real new joiner takes.
  • P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
  • P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.

Dimensions

D1 · Cyclomatic Complexity9.3 / 10Stronggated by 5 serious findings✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.3 / 10 · rule-coverage 100% · ceiling Prevented

5 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was CoverKt.cover at 20. A further 16 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being BaseListPresenter.present at 32 — they are counted neither in the figure above nor in this dimension's score. 14 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/list/BaseListPresenter.kt (BaseListPresenter.present at 32), ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/work/WorkTypeExt.kt (WorkTypeExtKt.getDisplayString at 30), shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/alias/AliasTypeExt.kt (AliasTypeExtKt.getDisplayString at 26), shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListensPresenter.kt (ListensPresenter.present at 25), ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/series/SeriesTypeExt.kt (SeriesTypeExtKt.getDisplayString at 20), and 9 more not listed here. They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.

CoverKt.cover (cyclomatic 20)shared/feature/graph/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/graph/viz/quadtree/Cover.kt:30
TopAppBarWithFilterKt.TopAppBarWithFilterInternal (cyclomatic 17)ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/topappbar/TopAppBarWithFilter.kt:120
ImagesPresenter.present (cyclomatic 17)shared/feature/images/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/images/ImagesPresenter.kt:49
ForceNBody.applyForce (cyclomatic 16)shared/feature/graph/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/graph/viz/force/ForceNBody.kt:138
AddKt._add (cyclomatic 16)shared/feature/graph/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/graph/viz/quadtree/Add.kt:32

What to do

  1. Bring the 5 bodies over 15 down to 15 or less in Cyclomatic Complexity — start with CoverKt.cover (cyclomatic 20), TopAppBarWithFilterKt.TopAppBarWithFilterInternal (cyclomatic 17), ImagesPresenter.present (cyclomatic 17). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 5 together lifts Cyclomatic Complexity from 9.3 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

D2 · Cognitive Complexity8.5 / 10Strong✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: Documented → Verified → Prevented · effective 8.5 / 10 · rule-coverage 100% · ceiling Prevented

10 method(s) exceeded the cognitive complexity threshold of 15; the worst was AddKt._add at 30.

AddKt._add (cognitive 30)shared/feature/graph/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/graph/viz/quadtree/Add.kt:32
CoverKt.cover (cognitive 27)shared/feature/graph/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/graph/viz/quadtree/Cover.kt:30
ForceNBody.applyForce (cognitive 26)shared/feature/graph/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/graph/viz/force/ForceNBody.kt:138
ScreenWithPagingLoadingAndErrorKt.ScreenWithPagingLoadingAndError (cognitive 25)ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/paging/ScreenWithPagingLoadingAndError.kt:108
ReleaseListItemKt.ReleaseListItem (cognitive 22)ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/release/ReleaseListItem.kt:46

+ 5 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 10 bodies over 15 down to 15 or less in Cognitive Complexity — start with AddKt._add (cognitive 30), CoverKt.cover (cognitive 27), ForceNBody.applyForce (cognitive 26). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 10 together lifts Cognitive Complexity from 8.5 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

D3 · God Classes8.1 / 10Strong✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: Documented → Verified → Prevented · effective 8.1 / 10 · rule-coverage 100% · ceiling Prevented

32 god class(es) detected.

MethodTooLong: ReleaseUiKt.ReleaseUi · ×29shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseUi.kt:57
TooManyMethods: AppPreferencesImplcore/preferences/src/commonMain/kotlin/ly/david/musicsearch/core/preferences/AppPreferencesImpl.kt:49
ClassTooLong: AppPreferencesImplcore/preferences/src/commonMain/kotlin/ly/david/musicsearch/core/preferences/AppPreferencesImpl.kt:49
FileTooLong: preferences/AppPreferencesImpl.ktcore/preferences/src/commonMain/kotlin/ly/david/musicsearch/core/preferences/AppPreferencesImpl.kt

What to do

  1. Resolve the 29 MethodTooLong finding(s) in God Classes — start with DetailsPresenter.kt (2), BaseListPresenter.kt (2), ReleaseUi.kt. — One of this dimension's main actionable groups (29 warning-level).
  2. Resolve the 1 TooManyMethods finding(s) in God Classes — start with AppPreferencesImpl.kt. — One of this dimension's main actionable groups (1 warning-level).
  3. Resolve the 1 ClassTooLong finding(s) in God Classes — start with AppPreferencesImpl.kt. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

D4 · Code Duplication5.7 / 10Adequate✓ Tool-verified

What it measures: How much of the production code is copy-pasted: the share of production lines inside a reported copy (every copy of a duplicated block or of an edited member, each line once), 10 at none and 0 at a quarter of the lines.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), scored on the share of production lines inside a reported copy (each line once; 10 at none, 0 at a quarter). Deterministic.

Maturity: Documented → Verified → Prevented · effective 5.7 / 10 · rule-coverage 100% · ceiling Verified

84 duplicated block group(s) detected. 10.9 % of the production lines (7,622 of 70,199) are in a reported copy. A further 71 rows report members as variants of one another; the share counts each copied line once, however many rows cite it.

Duplicated block (19 lines × 2) · ×5data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/mapper/MapToReleaseListItemModel.kt:46
Duplicated block (18 lines × 2) · ×5data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ArtistDao.kt:96
Duplicated block (15 lines × 2) · ×4shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelDetailsTabUi.kt:94
Edited copy of a member (41 corresponding lines) · ×3shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/submit/DatePickerField.kt:42
Edited copy of a member (23 corresponding lines) · ×3data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ReleaseDao.kt:58

+ 107 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 5 Duplicated block (19 lines × 2) finding(s) in Code Duplication — start with MapToReleaseListItemModel.kt, ArtistUi.kt, RecordingUi.kt. — One of this dimension's main actionable groups (5 warning-level).
  2. Resolve the 5 Duplicated block (18 lines × 2) finding(s) in Code Duplication — start with ArtistDao.kt, ReleaseDao.kt, ReleaseUi.kt. — One of this dimension's main actionable groups (5 warning-level).
  3. Resolve the 4 Duplicated block (15 lines × 2) finding(s) in Code Duplication — start with LabelDetailsTabUi.kt, ListenAdditionalActionsBottomSheetContent.kt, AppBottomNavigationBar.kt. — One of this dimension's main actionable groups (4 warning-level).

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

D5 · Coupling7.4 / 10Adequategated by 1 critical finding✓ Tool-verified

What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.

Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.

Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 7.4 / 10 · rule-coverage 100% · ceiling Prevented

35 production modules (Gradle), 1 dependency cycle(s), 5 unstable depended-on module(s). Read from the build's own module declarations; edges a convention plugin adds from buildSrc or build-logic are not visible there; 2 module(s) off the main sequence, with abstractness counted on 31 of the 35 (the rest declare no modelled class or interface, export only macros, declare types in source no model reads, or have no source directory of their own).

Circular dependency
Unstable project MusicSearch:data:repository · ×5
Off the main sequence: MusicSearch:shared:domain · ×2

What to do

  1. Resolve the 5 Unstable project MusicSearch finding(s) in Coupling. — One of this dimension's main actionable groups (5 warning-level).
  2. Resolve the 1 Circular dependency finding(s) in Coupling. — One of this dimension's main actionable groups (1 issue-level).

Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.

D6 · Cohesion (LCOM4)9.9 / 10Stronggated by 1 serious finding✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Verified

1 of 89 classes have LCOM4 above 3.

Low cohesion: ReleasesListRepositoryImpl (LCOM4 4)data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/release/ReleasesListRepositoryImpl.kt:29

What to do

  1. Resolve the 1 Low cohesion finding(s) in Cohesion (LCOM4) — start with ReleasesListRepositoryImpl.kt. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.

D7 · Architectural Integrity6.0 / 10Adequate✓ Tool-verified

What it measures: Whether the code respects its intended layering / architecture rules.

Method: Enforcement rung (Prevented/Verified/Documented) per checkable ADR via Roslyn, plus dependency cycles via the engine shared with D5/AX3. Deterministic, exact.

Maturity: Documented → Verified → Prevented · effective 6.0 / 10 · rule-coverage 100% · ceiling Prevented

No mechanizable ADR was identified, so enforcement is not measured. Dependency cycles not checked (no project-reference graph; where this repository's language has an import-cycle lens, cycles are reported there).

Detailed fixes: d7_recommendation.md.

D12 · Dependency Hygiene10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether dependencies are current, not deprecated, and not bloated. Known vulnerabilities are D30's.

Method: Manifest scan via dotnet list package across all projects; worst-signal-per-package deduction (capped-linear for deprecation, prerelease and outdated) per KLoC. Known-vulnerable packages are D30's and are not charged here (rubric-2026.11.2). Exhaustive.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 outdated direct gem(s), 0 pinning defect(s). 1 declaration(s) graded against rubygems.org, 1 of them against a version resolved in a committed Gemfile.lock. Whether any of these gems is DEPRECATED or YANKED is not graded — rubygems.org publishes no deprecation marker, and a yank removes a version rather than flagging it. Whether any is UNMAINTAINED is not graded either: no registry publishes a maintenance status, and release age does not stand in for one. Whether any is UNUSED is a source question, not a registry one. Known CVEs in this dependency graph are D30's question, read from the manifest there.

✓ On the Gold path — maintain.

Detailed fixes: d12_recommendation.md.

D13 · REDACTED Scanning5.0 / 10Adequate✓ Tool-verified

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: Documented → Verified → Prevented · effective 5.0 / 10 · rule-coverage 100% · ceiling Prevented

1 secret(s) detected.

REDACTED

What to do

  1. Resolve the 1 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).

Detailed fixes: d13_recommendation.md · top locations in Appendix A, every location in findings.md.

D14 · License Compliance10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the licenses of third-party packages are compatible with your policy.

Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 105 shipped gem(s) use a banned license. Licences were resolved from rubygems.org over the 105 gem(s) a consumer installs — this repository's runtime declarations closed transitively over its committed Gemfile.lock. Development-group and `add_development_dependency` gems are excluded: they are not distributed with this repository. 1 of them publish no licence on rubygems.org; that is missing data, not a violation, and none of them is charged. ★ COVERAGE OF THIS VERDICT: it grades this repository's gem dependencies and nothing else. The repository also declares a Gradle build (build.gradle/build.gradle.kts) and package.json, and the licences of those dependency graphs were NOT read by this pass — a gap in this engine's coverage, not a statement about them. So this result says the graded closure carries no banned licence; it does NOT say this repository's licensing is clear.

✓ On the Gold path — maintain.

Detailed fixes: d14_recommendation.md.

D15 · Churn × Complexity Hotspots10.0 / 10Exemplary✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No churn × complexity hotspots in the window.

✓ On the Gold path — maintain.

Detailed fixes: d15_recommendation.md.

D17 · Explicit Debt9.9 / 10Stronggated by 34 serious findings✓ Tool-verified

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: Documented → Verified → Prevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Prevented

34 deducted task-comment markers across 70199 LoC (0.0/KLoC) → score 9.9. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.

TodoComment · ×34ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/work/WorkListItem.kt:80

What to do

  1. Resolve the 34 TodoComment finding(s) in Explicit Debt — start with scrape_relationships.py (3), RecordingListItem.kt (2), NowPlayingHistoryRepositoryImpl.kt (2). — One of this dimension's main actionable groups (34 warning-level).

Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.

D19 · Documentation Quality5.0 / 10Adequate✓ Tool-verified

What it measures: Whether the project's documentation is clear, complete, and useful.

Method: Every README, docs/ document and root guide parsed by its markup and measured in Unicode letters. Published: a runnable or packaged .NET project whose README (or a document it links, or a root guide) shows no example, and a root README naming none of three or more projects. Overview, licence, boilerplate, wall-of-text, empty-section and XML-doc rows are measured and withheld (counted in gaps) after adjudication. Deterministic, exhaustive, advisory.

Maturity: Documented → Verified → Prevented · effective 5.0 / 10 · rule-coverage 100% · ceiling Documented

1 of 2 documentation facets pass in full; short on: F2 example. 18 document(s) read across 33 unit(s).

Documentation: no build, run or usage exampleREADME.md:1

What to do

  1. Resolve the 1 Documentation finding(s) in Documentation Quality — start with README.md. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d19_recommendation.md · top locations in Appendix A, every location in findings.md.

D20 · ADR Quality10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether architecture decisions are recorded well (context, decision, consequences).

Method: Every ADR read by its section structure: nine located rules (a missing Decision, Context or Consequences section, a stale status, two records deciding the same question, a dangling supersede link, a number-only title, a single option, no named cost, no status where the log uses one, no enforcement field where the log adopted one), each a fixed deduction from 10; the score is the mean over evaluated records. Deterministic, no model. Advisory.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 of 3 evaluated ADRs have a defect readable from the log itself (a missing or empty section, no title, a single option, consequences with no cost, no status, a missing enforcement field, a status the log contradicts, a dangling link, an unlinked second decision on one question, a date that is no calendar day). How well each record argues its case is not measured.

✓ On the Gold path — maintain.

Detailed fixes: d20_recommendation.md.

D21 · Naming Consistency8.8 / 10Strong✓ Tool-verified

What it measures: Whether names — types, methods, variables — are clear and consistent.

Method: Seven vocabulary-free rules (N1-N7) mine each naming convention from the repository and flag a name that breaks a convention its structural peers in the same unit follow; production C# and TypeScript, each its own population. Deterministic, no model, no sample. Advisory.

Maturity: Documented → Verified → Prevented · effective 8.8 / 10 · rule-coverage 100% · ceiling Verified

1 naming inconsistencies among 84 declarations measured against a convention their peers follow.

`InvalidID` spells `ID` where 93 names in the project spell it `Id`shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/listen/ListensListRepository.kt:65

What to do

  1. Resolve the 1 `InvalidID` spells `ID` where 93 names in the project spell it `Id` finding(s) in Naming Consistency — start with ListensListRepository.kt. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d21_recommendation.md · top locations in Appendix A, every location in findings.md.

D26 · Project Cohesion8.2 / 10Strong✓ Tool-verified

What it measures: Whether each project is a focused, coherent unit rather than an oversized grab-bag.

Method: Project size overshoot penalties (LoC / public-type count / namespace count, 2-of-3 flag) weighted by log magnitude. Exhaustive across projects, deterministic.

Maturity: Documented → Verified → Prevented · effective 8.2 / 10 · rule-coverage 100% · ceiling Documented

3 of 33 build units (Gradle, Xcode) flagged as possibly oversized/incoherent.

Projects may be oversized for their cohesion · ×3ui/common/build.gradle.kts:1

What to do

  1. Resolve the 3 Projects may be oversized for their cohesion finding(s) in Project Cohesion — start with build.gradle.kts (3). — One of this dimension's main actionable groups (3 recommendation-level).

Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.

D28 · Secrets (history)4.0 / 10Weak✓ Tool-verified

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: REDACTED scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.

Maturity: Documented → Verified → Prevented · effective 4.0 / 10 · rule-coverage 100% · ceiling Documented

6 finding(s): 0 critical, 6 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.

REDACTED
REDACTED

What to do

  1. Resolve the 6 REDACTED finding(s) in Secrets (history) — start with REDACTED (2), REDACTED, REDACTED. — One of this dimension's main actionable groups (6 issue-level).
  2. Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.

D29 · Static Analysis (SAST)0.4 / 10Critical✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: Documented → Verified → Prevented · effective 0.4 / 10 · rule-coverage 100% · ceiling Documented

20 finding(s): 0 critical, 19 high, 1 medium, 0 low. semgrep hit a parse error in 1 file(s) — `gradlew` (line 74, line 178) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. Separately, one or more rules could not re-parse an embedded snippet in 5 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 10 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (3), REDACTED (3), REDACTED (2). — One of this dimension's main actionable groups (10 issue-level).
  2. Resolve the 5 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (3), REDACTED, REDACTED. — One of this dimension's main actionable groups (5 issue-level).
  3. Resolve the 3 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (3 issue-level).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

D30 · Dependency Vulnerabilities0.0 / 10Critical✓ Tool-verified

What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.

Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05. Advisory since rubric-2026.11.2 (CAI decision 0006): every row is a match against a vulnerability database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

21 finding(s): 2 critical, 15 high, 3 medium, 1 low.

REDACTED
REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 15 High CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (15). — One of this dimension's main actionable groups (15 issue-level).
  2. Resolve the 2 Critical CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (2). — One of this dimension's main actionable groups (2 issue-level).
  3. Resolve the 3 Medium CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (3). — One of this dimension's main actionable groups (3 warning-level).

Detailed fixes: d30_recommendation.md · top locations in Appendix A, every location in findings.md.

D34 · Knowledge Freshness10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.

Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

Every significant source file has living knowledge — recently and meaningfully worked. Counted over 374 of the 1135 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.

✓ On the Gold path — maintain.

Detailed fixes: d34_recommendation.md.

D35 · Change Coupling9.7 / 10Adequategated by 3 critical findings✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.

Maturity: Documented → Verified → Prevented · effective 9.7 / 10 · rule-coverage 100% · ceiling Documented

Strongest change-coupling: ListFilters.kt↔SortOptionsBottomSheet.kt 100%; ImageMetadataRepository.kt↔ImageUrlDao.kt 90%; AppPreferencesImpl.kt↔ListFilters.kt 80%

Boundary-crossing change coupling: ListFilters.kt ↔ SortOptionsBottomSheet.kt · ×3shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/list/ListFilters.kt:1
Change coupling: ListFiltersMenuItems.kt ↔ SortOptionsBottomSheet.kt · ×14ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/sort/ListFiltersMenuItems.kt:1
Change-coupling hub: ImageMetadataRepository.kt → MbidImageDao.kt, MusicBrainzImageMetadataRepositoryImpl.kt, ArtistImageRepositoryImpl.kt, ImageUrlDao.kt · ×4shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/image/ImageMetadataRepository.kt

What to do

  1. Resolve the 3 Boundary-crossing change coupling finding(s) in Change Coupling — start with ListFilters.kt, AppPreferences.kt, AppPreferencesKey.kt. — One of this dimension's main actionable groups (3 issue-level).
  2. Resolve the 14 Change coupling finding(s) in Change Coupling — start with ImageUrlDao.kt (2), MbidImageDao.kt (2), ArtistUi.android.kt (2). — One of this dimension's main actionable groups (14 warning-level).
  3. Resolve the 4 Change-coupling hub finding(s) in Change Coupling — start with ImageMetadataRepository.kt, AppPreferencesImpl.kt, ListensListRepositoryImpl.kt. — One of this dimension's main actionable groups (4 warning-level).

Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.

D36 · Supply-chain Provenance & Signing5.0 / 10Adequate✓ Tool-verified

What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.

Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.

Maturity: Documented → Verified → Prevented · effective 5.0 / 10 · rule-coverage 100% · ceiling Documented

2/4 supply-chain integrity signals present (provenance, signing, SBOM, pinned actions).

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

+ 1 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 3 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (3 warning-level).
  2. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).
  3. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.

D43 · Malicious Dependencies10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Reported apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.

Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. Advisory since rubric-2026.11.2 (CAI decision 0006): the malicious-package feed is a database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No dependency in any ecosystem this repository declares is published as malicious.

✓ On the Gold path — maintain.

Detailed fixes: d43_recommendation.md.

D44 · Platform End-of-Life10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.

Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 3 platform declaration(s) and 76 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.

✓ On the Gold path — maintain.

Detailed fixes: d44_recommendation.md.

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AC1 · Text alternatives3.5 / 10Weak✓ Tool-verified

Other · Accessibility — Whether non-text content carries a text alternative — img/area/input[type=image] have alt, a meaningful svg has a title or aria-label, video has a captions track, and object/embed/canvas have a name or fallback content. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: every img/area/input[type=image] checked for alt, svg[role=img] for a title/aria-label, video for a captions <track>. Components skipped, spreads suppressed. Deterministic, hard fact per element.

Coverage: Population: image/media elements — img, area, input[type=image], svg, video, object, embed, canvas — across the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and dynamic-attribute elements are skipped. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is NOT read by any producer, so it contributes no element to this population; where such a frontend is present the card discloses it as an analyzer gap rather than scoring around it.

  • An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative. — download.html:294

What to do

  • Add a text alternative — alt on images (alt="" for purely decorative ones), a title or aria-label on meaningful svg, an aria-label or inner fallback content on canvas, and a captions <track> on video.
AC2 · Forms & labels10.0 / 10Exemplary○ Nothing flagged

Other · Accessibility — Whether form controls have a programmatic label (an associated label, aria-label or aria-labelledby), buttons have text, links have an accessible name, a click handler on a plain element names the control it declares, fieldsets have a non-empty legend, known UI-library field components carry a label prop, and a placeholder isn't used as the only label. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: inputs/selects/textareas checked for an associated label[for]/wrapping label/aria-label/aria-labelledby (per document), buttons for accessible text, fieldsets for a legend; placeholder-only labelling flagged. Deterministic, hard fact per control.

Coverage: Population: form controls, buttons, links, fieldsets and known UI-library field components in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and spread/dynamic-attribute elements are skipped, so a control whose label arrives through a spread or a runtime expression is deliberately not judged. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

AC3 · Page structure4.8 / 10Weak✓ Tool-verified

Other · Accessibility — Whether pages declare a language (well-formed BCP-47) and a non-empty title, expose exactly one main landmark and a sane heading order with non-empty headings, keep zoom enabled, title their iframes, give data tables header cells, and avoid meta-refresh. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: html lang, document <title>, a main landmark and heading order on full documents only, plus zoom-disabling viewports, untitled iframes and meta-refresh anywhere. Deterministic, per structural checkpoint.

Coverage: Population: the PARSED MARKUP documents (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx). The page-level checks — lang, title, single main landmark — fire ONCE PER FULL DOCUMENT (an <html> root) and never on a partial or component fragment, so a repo of fragments is assessed only on the per-element checks (heading order, table headers, iframe titles, meta-refresh, zoom). Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

  • No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>. — download.html:3

What to do

  • Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh.
AC4 · Keyboard semantics1.0 / 10Critical✓ Tool-verified

Other · Accessibility — Whether interactive behaviour is keyboard-reachable — no click handler on a non-interactive element lacking a role, tabindex and key handler, no element the repo's own CSS styles `cursor: pointer` without giving it any of the three, no unfocusable element whose only binding is a mouse enter/leave pair or a double-click, no positive tabindex, no href-less anchor, no placeholder-href (#/javascript) link acting as a button. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: click handlers on non-interactive elements lacking role+tabindex+key handler, positive tabindex values, and href-less anchors. Components skipped, spreads suppressed. Deterministic, hard fact per element.

Coverage: Population: elements that pose a keyboard-semantics question, in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx) — a non-natively-interactive element carrying a click handler, a double-click or hover enter/leave binding, a pointer-only gesture on a tabindex="0" element, or `cursor: pointer` from the repo's own CSS; an href-less or placeholder-href (#, javascript:) anchor; and any element with a positive tabindex. Natively interactive elements used correctly (<button>, <a href>, form controls) are NOT in the population — there is nothing to judge — so a page of nothing but correct controls gives AC4 nothing to measure. Keyboard reachability is judged from the markup, never from a rendered page. ★ An interactive element declared in a tagged-template (html`…`) or hyperscript frontend is NOT in this population — no producer reads either — so an empty population is reported as an analyzer gap, never as "this repository has no interactive elements".

  • A script attaches a click listener to this <div>, but it has no role, no tabindex and no key handler, so it can only be operated with a mouse. Use a <button>, or add role + tabindex="0" + a key handler. — download.html:334
  • A script attaches a click listener to this <svg>, but it has no role, no tabindex and no key handler, so it can only be operated with a mouse. Use a <button>, or add role + tabindex="0" + a key handler. — download.html:0

What to do

  • Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href.
AC5 · ARIA correctness10.0 / 10Exemplary○ Nothing flagged

Other · Accessibility — Whether ARIA is used correctly — valid non-abstract roles, the ARIA state a role requires, valid (non-misspelled) aria-* attribute names, in-enum values for token-typed aria-* attributes, and no aria-hidden on (or wrapping) a focusable element. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: role values checked against the WAI-ARIA role set (abstract/invalid flagged), required ARIA state for a role, and aria-hidden on a focusable element. Deterministic, role/attribute level.

Coverage: Population: elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx) that carry a role or an aria-* attribute; roles and token values are checked against the ARIA enums exhaustively within that set. An expression-valued (dynamic) role or aria-* value is skipped rather than guessed, and markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

AC6 · Visual & motion safety5.7 / 10Adequate✓ Tool-verified

Other · Accessibility — Whether focus outlines aren't removed without a replacement, motion respects prefers-reduced-motion, and literal CSS colour pairs meet contrast — PARTIAL: inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS literals are read (hex/rgb/hsl/named), never computed/runtime/external-CDN colour. Static markup readiness, not a WCAG conformance claim.

Method: Static markup/CSS scan: inline outline:none/0, literal inline colour/background contrast against the 4.5:1 AA floor, and <style>-block animation without a prefers-reduced-motion guard. Deterministic but PARTIAL — only inline styles and in-repo CSS literals are visible.

Coverage: Population: styled elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx), plus in-repo <style> blocks, in-repo .css files and CSS-in-JS literals. Colour contrast is computed from LITERAL colour pairs only (hex/rgb/hsl/named, including var() tokens and Tailwind neutral utilities) — computed, runtime-themed and external-CDN colour is never resolved, so this is a partial read of contrast by construction. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

  • `.download-button` sets color: white on background-color: #01e675 — 1.7:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — download.html:91

What to do

  • Keep a visible focus style (don't remove the outline without a replacement), guard animation with prefers-reduced-motion, and raise low-contrast colour pairs to at least 4.5:1.
AX10 · Code composition7.3 / 10Strong✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

AX3 · Project dependency cycles6.8 / 10Adequate✓ Tool-verified

Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).

Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.

  • The projects MusicSearch:data:spotify → MusicSearch:test-data → MusicSearch:data:spotify form a reference cycle. Cyclic dependencies prevent independent build/test/deploy, blur ownership, and tend to grow into a big ball of mud. Break the cycle by extracting the shared types into a separate project both can reference.

What to do

  • Break project reference cycles by extracting shared abstractions into a separate project; keep the graph a DAG.
AX4 · Dependency direction10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.

Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.

AX6 · Interface segregation10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').

Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.

  • `AppPreferences` declares 39 abstract methods: `setTheme`, `setUseMaterialYou`, `setSeedColor`, `setAreaSortOption`, `setArtistSortOption`, `setEventSortOption`, `setInstrumentSortOption`, `setLabelSortOption`, `setPlaceSortOption`, `setRecordingSortOption`, `setReleaseSortOption`, `setShowMoreInfoInReleaseListItem`, `setShowReleaseStatus`, `setReleaseGroupSortOption`, `setGenreSortOption`, `setTrackSortOption`, `setSeriesSortOption`, `setWorkSortOption`, `setShowLocalCollections`, `setShowRemoteCollections`, `setHistorySortOption`, `setCollectionSortOption`, `setImagesSortOption`, `setEnableCrashReporting`, `setDeveloperMode`, `setNumberOfImagesPerRow`, `setImagesGridPaddingDp`, `setCollaborationEntityType`, `setScrollToHideTopAppBar`, `setPullToRefresh`, `setNumberOfListensInDetails`, `setSubmitClientAndVersionWithListen`, `setExcludeParametersInUrlLookup`, `setSearchLocalDatabaseInUrlLookup`, `setMusicBrainzInstance`, `setListenBrainzInstance`, `setWikidataInstance`, `setArtistImageSource`, `setBoldUnvisited`. Counted over its public functions with no body, once per name; default-bodied functions and properties are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/preferences/AppPreferences.kt:24

What to do

  • Split fat interfaces into focused role-interfaces so clients depend only on what they use.
AX8 · Test isolation10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether production projects stay free of references to test projects — tests may depend on production, never the reverse.

Method: Csproj graph: each production project checked for references to test projects (identified by test-framework presence, not name). Zero violations is clean. Deterministic.

DM10 · One transaction, one aggregate10.0 / 10Exemplary○ Nothing flagged

Other · Domain Modelling — Whether a single operation mutates more than one aggregate root. An aggregate is a consistency boundary, so saving two together fuses them into one — the second's invariants come to depend on the first's transaction, and the pair can no longer be separated. Reads of other aggregates are not counted.

Method: Neutral body surface (DDD-gated): every method body scanned for repository WRITE calls (Add/Update/Save/Remove/Delete/Insert/Store and their async forms), keyed on the ARGUMENT type rather than the repository type — three `IRepository<T>` writes collapse to one repository but are three distinct aggregates. Reads (Get/Find/Load/Query) are excluded, so loading another aggregate for context never counts. Score is offending methods over methods that write at all. Deterministic.

DM12 · Ambient inputs in the domain10.0 / 10Exemplary○ Nothing flagged

Other · Domain Modelling — Whether domain types receive the time and randomness their rules depend on, rather than reading the process clock or a global random source directly — an ambient read makes the rule it feeds untestable at the instant that matters and lets two reads inside one operation disagree.

Method: Roslyn (DDD-gated, C#/VB only): domain-layer types scanned for ambient reads — DateTime/DateTimeOffset.Now/UtcNow/Today, Random.Shared, new Random(), Stopwatch.GetTimestamp — resolved against the semantic model, with a comment/string-stripped token fallback only where resolution fails. Body reads are scored; field/property initialisers are surfaced unscored. Apply/When folds excluded (ES1 owns them). Deterministic, symbol-resolved.

DM6 · Domain ↔ infrastructure boundary10.0 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether the domain layer stays free of infrastructure dependencies (EF/Marten/HTTP/ASP.NET) — the clean-architecture dependency rule.

Method: Roslyn (DDD-gated): domain-layer types scanned for infrastructure usage in member SIGNATURES and inside method/accessor BODIES — resolved calls and object-creations into EF/Marten/HTTP/Mongo/Redis/message-bus types (not just a namespace allowlist). Deterministic, symbol-resolved, exhaustive over domain-layer bodies, DDD-native.

Coverage: Domain layer identified by NAMESPACE heuristic; infrastructure then resolved by symbol in member SIGNATURES and method/accessor BODIES — rename the layer and the check evaporates.

DM9 · Scattered domain decisions10.0 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether one domain rule is decided — or one measurement produced — in more than one place, rather than living on the type that owns it.

Method: Neutral body surface plus Roslyn (DDD-gated), two arms. DECISION (Roslyn only): a predicate over a domain type's members judged in two or more types, where none of those decisions live on the owning type — operands of comparisons and relational property patterns only, so a member merely passed as an argument is not judged. DERIVATION: a plain all-numeric carrier of ≥2 members, with no base type and exactly one constructor, CONSTRUCTED as the result of a method (returned or assigned, never inline as an argument) in two or more types other than its own — the same measurement produced twice, which centralising the judgement does not fix. DERIVATION runs on every language whose frontend declares the produced-or-passed fact per construction (Roslyn and the Java sidecar today); a target with only the derivation arm carries an engine gap naming the decision arm as not assessed, and a frontend that declares nothing keeps the dimension not measured rather than clean. Single-member rules, test code and generated code are out of population for both. Advisory.

M1 · Documentation (README)8.7 / 10Strong✓ Tool-verified

Maturity · Maturity — Whether the repository and its projects have a README, and whether it is substantive.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

What to do

  • Add a build/run (quick start) section to the root README — the first thing a newcomer needs.
M2 · Architecture documentation9.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

M3 · Folder & project structure10.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether the repository is organised deliberately: production code and tests are set apart in a way its ecosystem or the repository itself declares.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

M4 · Documentation accuracy5.8 / 10Adequate✓ Tool-verified

Maturity · Maturity — Whether the project's current-state documentation describes the code that exists.

Method: Every current-state document's checkable claims looked up in the tree (links, versions, and artefact counts an order of magnitude off), plus two README checks: an advertised infrastructure product with no footprint, and a module the CHANGELOG records as removed. Deterministic, no model. Advisory.

  • build-logic/README.md links to `convention/src/main/kotlin/ly/david/convention/plugin/AndroidLibraryConventionPlugin.kt`, but `build-logic/convention/src/main/kotlin/ly/david/convention/plugin/AndroidLibraryConventionPlugin.kt` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — build-logic/README.md:6
  • build-logic/README.md links to `convention/src/main/kotlin/ly/david/convention/plugin/KotlinJvmConventionPlugin.kt`, but `build-logic/convention/src/main/kotlin/ly/david/convention/plugin/KotlinJvmConventionPlugin.kt` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — build-logic/README.md:7
  • build-logic/README.md links to `convention/src/main/kotlin/ly/david/convention/plugin/AndroidComposeConventionPlugin.kt`, but `build-logic/convention/src/main/kotlin/ly/david/convention/plugin/AndroidComposeConventionPlugin.kt` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — build-logic/README.md:11

What to do

  • Reconcile the README with reality: build-logic/README.md links to `convention/src/main/kotlin/ly/david/convention/plugin/AndroidLibraryConventionPlugin.kt`, but `build-logic/convention/src/main/kotlin/ly/david/convention/plugin/AndroidLibraryConventionPlugin.kt` does not exist; build-logic/README.md links to `convention/src/main/kotlin/ly/david/convention/plugin/KotlinJvmConventionPlugin.kt`, but `build-logic/convention/src/main/kotlin/ly/david/convention/plugin/KotlinJvmConventionPlugin.kt` does not exist; build-logic/README.md links to `convention/src/main/kotlin/ly/david/convention/plugin/AndroidComposeConventionPlugin.kt`, but `build-logic/convention/src/main/kotlin/ly/david/convention/plugin/AndroidComposeConventionPlugin.kt` does not exist.
P1 · CI/CD gates10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

P2 · Observability0.0 / 10Critical✓ Tool-verified

Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.

Method: Filesystem/Roslyn scan: structured-logging frameworks (Serilog, NLog), OpenTelemetry, and health-check endpoint patterns. Exhaustive, deterministic.

  • No logging or diagnostics emission found. This repository ships a binary its users launch rather than a service you operate, so there is no operator to page — but when a run fails on a user's machine, neither they nor you have anything to read.

What to do

  • Write a diagnostic trail the user can hand back with a bug report: a log file under the platform's per-user data directory, switchable with a `--verbose`/`--debug` flag. Start with the error paths that emit nothing — a discarded error is the failure the user cannot describe and you cannot reproduce.
P3 · Security & performance tooling3.0 / 10Weak✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

  • No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 21 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.

What to do

  • Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
  • Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
P4 · Deployment & Rollback7.0 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.

Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.

P6 · Release Hygiene10.0 / 10Exemplary✓ Tool-verified

Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.

Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.

PF1 · Benchmark discipline9.0 / 10Exemplary✓ Tool-verified

Readiness · Performance — Whether the code protects its performance with benchmarks — a benchmark suite, allocation/memory measurement, and (ideally) a CI gate. Presence is credited as a bonus, never a deduction.

Method: Repo + source scan: BenchmarkDotNet referenced (csproj/source), [Benchmark]/[MemoryDiagnoser] attribute counts, and a benchmark step in CI; off .NET, the same ladder over Go testing.B, Rust criterion/#[bench]/divan, JMH/kotlinx-benchmark, pytest-benchmark/asv/pyperf, tinybench/mitata/vitest bench/benchmark.js and Swift package-benchmark — scored as a bonus ladder (absence is neutral, never a deduction). Deterministic, presence detection.

PF3 · Async & latency hygiene10.0 / 10Exemplary✓ Tool-verified

Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.

Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from each language's code model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.

X1 · Async correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.

Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.

X12 · Unreachable branch10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.

Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.

X16 · Unfloored truncation loop10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.

Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.

X18 · Disposal-pattern correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.

Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.

X2 · Cancellation propagation10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether suspend functions that make a cancellable request accept or pass on the coroutine's cancellation (adoption curve).

Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.

X21 · Side-effecting pattern guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.

Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.

X23 · Unguarded diagnostic materialisation10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.

Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.

X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `for` loop leaves the `dict`, `set` or `deque` it is walking alone — CPython's iterators over those check that the collection has not changed size since the loop began, so a body that removes from (or empties) the very collection the loop is walking makes the next step raise `RuntimeError: dictionary changed size during iteration` and the remaining items are never seen. Whether a `for (x in c)` or `c.forEach { … }` leaves the collection it is walking alone — a `mutableListOf`/`ArrayList`, `mutableMapOf`/`HashMap` or `mutableSetOf`/`HashSet` is a `java.util` collection on the JVM and is walked by its own fail-fast iterator, so a body that adds to or removes from the very collection the loop is walking makes the next step throw `ConcurrentModificationException` and the remaining elements are never seen.

Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.

X3 · Exception handling10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.

Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.

X5 · Nullable reference types9.7 / 10Exemplary✓ Tool-verified

Other · Code Health — Whether Kotlin's null safety is not undermined by not-null assertions — `String` cannot hold null and `String?` must be checked before use in every Kotlin module, and each `!!` is a run-time `NullPointerException` the author has told the compiler cannot happen.

Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.

WCAG coverage — what static analysis assessed

Statically assessed 15 of 55 WCAG 2.2 Level A/AA success criteria (27%; ≈30% of the 50 WCAG 2.1 AA criteria for EN 301 549). The other 40 require runtime or manual evaluation. Partial signal only (a clean result is necessary, not sufficient; static analysis fully verifies none). This is accessibility readiness, not a conformance claim — a WCAG conformance claim requires manual evaluation (WCAG-EM 1.0).

DimensionWCAG 2.2 A/AA criteriaCoverage
AC1 · Text alternatives1.1.1, 1.2.2, 1.2.5Partial signal
AC2 · Forms & labels1.3.1, 3.3.2, 4.1.2Partial signal
AC3 · Page structure1.4.4, 2.2.1, 2.4.1, 2.4.2, 3.1.1, 4.1.2Partial signal
AC4 · Keyboard semantics2.1.1, 2.4.3Partial signal
AC5 · ARIA correctness4.1.2Partial signal
AC6 · Visual & motion safety1.4.3, 2.4.7Partial — literal CSS only

Not statically assessed — these 40 Level A/AA criteria need runtime or manual evaluation (WCAG-EM): 1.2.1, 1.2.3, 1.2.4, 1.3.2, 1.3.3, 1.3.4, 1.3.5, 1.4.1, 1.4.2, 1.4.5, 1.4.10, 1.4.11, 1.4.12, 1.4.13, 2.1.2, 2.1.4, 2.2.2, 2.3.1, 2.4.4, 2.4.5, 2.4.6, 2.4.11, 2.5.1, 2.5.2, 2.5.3, 2.5.4, 2.5.7, 2.5.8, 3.1.2, 3.2.1, 3.2.2, 3.2.3, 3.2.4, 3.2.6, 3.3.1, 3.3.3, 3.3.4, 3.3.7, 3.3.8, 4.1.3.

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

LensScoreRatingImpact
Code Health92.6ExemplarySolid.
Architecture86.8StrongSolid.
Maturity81.3StrongSolid.
Readiness48.1Weak — gated by P2, P3Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Security48.4Weak — gated by D29Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Domain Modelling100.0ExemplaryStrongest area.
Accessibility43.3Weak — gated by AC1, AC4Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Performance94.3ExemplarySolid.
Unscored — 1 check(s) recorded observations but carry no score

These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.

  • X10 Duplicated predicate — 1 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 1 control(s) we could not find positive evidence for

These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.

  • P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 66 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

  • AX1 Captive dependencies — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX2 Stateful singletons — No container singleton was found, so there is no shared instance for concurrent requests to race on. No class in this Kotlin code is a Spring, JSR-330 or CDI singleton bean. No function in this Python code is served by a threaded web framework (a Flask, Bottle or FastAPI route, a Django or Pyramid view), so no module is shared between request threads. No Swift request handler (a Vapor, Hummingbird, Kitura, Swifter or Perfect route handler, as a method or a registered closure) is declared, so no state is shared between request threads.
  • AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX7 Slice cohesion — not applicable — not a vertical-slice architecture
  • AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
  • AXB1 Runtime evidence locked — no reproducible boot — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • C1 Data Protection — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no data at rest for these controls to protect.
  • C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C3 Audit Trail — No personal data detected in a persisted data model — no PII-named column (email, first_name, date_of_birth, phone_number, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no sensitive data whose changes an audit trail would record. If it does (through a store configured outside this repository, for instance), the trail belongs to wherever that data is stored.
  • C4 Data Retention — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no personal data whose lifetime a retention limit would bound.
  • C5 Data-Subject Rights — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no personal data for a data subject to erase, export or consent over.
  • D10 Test Quality — ~28411 lines of test source are present (.kt) but no test cases reached the test census for this repository — no test root we could resolve declared them, or the files we read declare no cases in a test framework we recognise — so skipped/assertion-free tests couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
  • D11 Test Reliability — Test reliability not included — the .kt suite was found but not re-run
  • D16 Bus Factor — single-maintainer repository — bus factor is not applicable
  • D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
  • D22 Internal API Consistency — The exposed public-API surface could not be collected — no C#/VB projects loaded.
  • D23 Boundary Type-Coupling — No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ sibling projects each declaring an entity of their own or taking another project's integration events. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
  • D24 Comment Value — D24 reads C#, Visual Basic, TypeScript and JavaScript comments only — this repository's production source is .kt, .py, .swift, which was left unread. Not scored: this is a gap in the analyzer, not a verdict about this repository.
  • D25 ADR Conformance — None of 0 binding record(s) states a rule in checkable form (a backticked element with a prohibition, or an `adr-rules` block), so conformance cannot be read from the code. Write the rule as an `adr-rules` block (`forbid:` a symbol, a package or a dependency) to make it checkable.
  • D27 Navigability — symbol resolution incomplete — navigability not assessed
  • D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
  • D32 Data Compliance (PII/GDPR) — 12 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
  • D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
  • D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
  • D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
  • D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
  • D8 Code Coverage — Coverage not included — suite not readable by the collector
  • DM1 Aggregate boundaries — no aggregates detected — aggregate-boundary check not applicable
  • DM11 Constructible invalid state — no entities detected — construction-time invariants not assessable
  • DM2 Strongly-typed ids — no id-bearing domain types detected — strongly-typed-id adoption not assessable
  • DM3 Integration-event coupling — no integration events detected — coupling check not applicable
  • DM4 Rich vs anemic model — no data-bearing entities detected — rich-vs-anemic model not assessable
  • DM5 Encapsulated state — no domain entities found — DM5 grades how entities protect their state, and this repository declares none
  • DM7 Repository granularity — no repository abstraction detected (e.g. uses a document session)
  • DM8 Value-object opportunities — not scored — the deterministic rule found 0 candidate clump(s); its rows are withheld until it has a measured precision of 95 % (a sample of fewer than 10 rows cannot show one)
  • ED2 Event/command shape — not scored — deciding whether a command has more than one competing handler requires resolving the call graph, and this analysis resolves a call's owner only where the receiver's type is written down in the source. Reported as guidance rather than measured
  • ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
  • ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
  • GD1 Unfinished & placeholder code — no source files were read — this check reads C#, F#, JavaScript/TypeScript, Dart, Ruby, Scala, Rust and Java, and none was read for this repository's product. That is a limit of the analyzer, not a finding about your code.
  • IC1 Incompleteness & stubs — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, and the automatic-re-run check to any GitHub-Actions workflow, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
  • P7 Outbound HTTP resilience — not applicable — no HTTP server, API framework or worker entry point was found in the JVM, Python, Swift source, so there is no service whose uptime a failing dependency could take down
  • P8 Schema migrations — no ORM, schema-migration tool or schema auto-create was found in this repository's dependency manifests or source, so there is no database schema for this check to judge
  • P9 Domain vs controller coverage — coverage not measured: this check compares the coverage of the analyzer's own test run across the domain and web layers, and that run measured none here — Test coverage (D8) says why
  • PF2 Allocation hygiene — Not scored: this check counted allocation-aware idioms (Span, pools, stackalloc) per line, which describes what kind of code a repository is rather than whether it has an allocation problem, so it was withdrawn. Nothing here is a finding about your code.
  • S1 Web-Security Posture — Not assessed: these web-security controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks web-security controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • SC1 Supply-chain hygiene — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X13 Undrained process stream — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X14 Bypassable address classification — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X15 Unvalidated length from an untrusted reader — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X17 Uncapped recursion over a caller-supplied document — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X19 Unrestored process-global state — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X20 Mistyped argument guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X22 Contradicted release guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X24 Document value interpolated into markup unescaped — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X25 Inert configuration knob — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X26 Unsynchronised callback handoff — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X28 Index access outside its own emptiness guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X29 Per-element action decided by a fixed element — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X30 Support guard that admits what it rejects — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
  • X4 Structured logging — This check asks whether log calls keep a message's values apart from its text, which needs a logger that can carry them as fields. This repository's Kotlin was read, and it logs through none that an assembled message defeats: Android's `Log` and Timber, java.util.logging and log4j-api-kotlin take one finished message (as log4net does in C#), or it makes no call through a named logger at all. Calls made through SLF4J, log4j 2 or kotlin-logging (`LoggerFactory.getLogger`, `KotlinLogging.logger {}`) would be judged.
  • X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X7 Silent fallback defaults — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Critical — 51 finding(s)
D30 · Dependency Vulnerabilities · High CVE · ×15
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D28 · Secrets (history) · REDACTED · ×6
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D35 · Change Coupling · Boundary-crossing change coupling · ×3
  • Boundary-crossing change coupling: ListFilters.kt ↔ SortOptionsBottomSheet.kt shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/list/ListFilters.kt:1 — `shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/list/ListFilters.kt` (context shared) and `ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/sort/SortOptionsBottomSheet.kt` (context ui) sit in DIFFERENT parts of the tree yet change together 100% of the time (10 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 10 shared commits counted here, the most recent 3 are `07894a81` feat: support sorting genres by cached order or name, ascending/desce…; `4a165c88` feat: show number of listens for release groups lists (#2438); `50ab74d4` feat: show number of listens in artists lists; support sorting by lis… — run `git show` on any of them.
  • Boundary-crossing change coupling: AppPreferences.kt ↔ ListFiltersMenuItems.kt shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/preferences/AppPreferences.kt:1 — `shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/preferences/AppPreferences.kt` (context shared) and `ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/sort/ListFiltersMenuItems.kt` (context ui) sit in DIFFERENT parts of the tree yet change together 80% of the time (8 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `07894a81` feat: support sorting genres by cached order or name, ascending/desce…; `6bb95754` feat: support sorting series by cached order or name, ascending/desce…; `378fb05f` feat: support sorting instruments by cached order or name, ascending/… — run `git show` on any of them.
  • Boundary-crossing change coupling: AppPreferencesKey.kt ↔ ListFiltersMenuItems.kt shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/preferences/AppPreferencesKey.kt:1 — `shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/preferences/AppPreferencesKey.kt` (context shared) and `ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/sort/ListFiltersMenuItems.kt` (context ui) sit in DIFFERENT parts of the tree yet change together 80% of the time (8 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `07894a81` feat: support sorting genres by cached order or name, ascending/desce…; `6bb95754` feat: support sorting series by cached order or name, ascending/desce…; `378fb05f` feat: support sorting instruments by cached order or name, ascending/… — run `git show` on any of them.
D30 · Dependency Vulnerabilities · Critical CVE · ×2
  • REDACTED
  • REDACTED
AC1 · Text alternatives · <img> without a text alternative · ×1
  • <img> without a text alternative download.html:294 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
AC4 · Keyboard semantics · Click handler on a non-interactive <div> · ×1
  • Click handler on a non-interactive <div> download.html:334 — A script attaches a click listener to this <div>, but it has no role, no tabindex and no key handler, so it can only be operated with a mouse. Use a <button>, or add role + tabindex="0" + a key handler.
AC4 · Keyboard semantics · Click handler on a non-interactive <svg> · ×1
  • Click handler on a non-interactive <svg> download.html — A script attaches a click listener to this <svg>, but it has no role, no tabindex and no key handler, so it can only be operated with a mouse. Use a <button>, or add role + tabindex="0" + a key handler.
AX3 · Project dependency cycles · Project dependency cycle · ×1
  • Project dependency cycle — The projects MusicSearch:data:spotify → MusicSearch:test-data → MusicSearch:data:spotify form a reference cycle. Cyclic dependencies prevent independent build/test/deploy, blur ownership, and tend to grow into a big ball of mud. Break the cycle by extracting the shared types into a separate project both can reference.
D13 · REDACTED Scanning · Leaked secret · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D5 · Coupling · Circular dependency · ×1
  • Circular dependency — MusicSearch:data:spotify → MusicSearch:test-data → MusicSearch:data:spotify
Serious — 273 finding(s)
D17 · Explicit Debt · TodoComment · ×34
  • TodoComment ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/work/WorkListItem.kt:80 — // TODO: writers — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/wikimedia/WikipediaSection.kt:88 — // TODO: eventually, migrate the stored url to be decoded — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/track/TracksByReleasePresenter.kt:73 — // TODO: consider changing "select all" for all other list screens to actually select all like tracks — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/topappbar/AddToCollectionActionToggle.kt:25 — // TODO: support removing current entity from collections from bottom sheet — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/text/SyncingText.kt:22 — // TODO: Any screenshot tests with animations such as CircularProgressIndicator may flake — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/sort/ListFiltersMenuItems.kt:55 — // TODO: consider moving to AllEntitiesListUiEvent — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/screen/Screens.kt:81 — // TODO: rename to OverlayPopResult: isn't just for snackbars — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/release/ReleaseListItem.kt:103 — // TODO: formats/tracks count are not currently shown — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/recording/RecordingListItem.kt:76 — // TODO: highlight date when filtering for recording list item — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/recording/RecordingListItem.kt:123 — // TODO: show relatively how often you've listened to a recording compared to other recordings — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/place/CoordinateListItem.kt:61 — // TODO: need different implementation for desktop — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListenAdditionalActionsBottomSheetContent.kt:270 — // TODO: filter by recording's work if it exists. there can be more than one (e.g. tracks with two songs) — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/submit/SubmitListenPresenter.kt:149 — // TODO: emit flow, so that we can show more feedback, don't pop until final feedback — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/utils/DetailsPresenter.kt:219 — // TODO: this will clear when returning from backstack — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/place/PlacePresenter.kt:26 — // TODO: Should exclude event-rels because they appear to be the same as the results from browse events by place — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventDetailsTabUi.kt:74 — // TODO: set list — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistDetailsTabUi.kt:87 — // TODO: begin area, end area — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaDetailsTabUi.kt:59 — // TODO: api doesn't seem to include area containment — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/create/CreateNewCollectionDialogContent.kt:85 — // TODO: handle next focus — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/error/Feedback.kt:54 — // TODO: emit IOState instead of returning this in all places — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment selenium/scrape_relationships.py:12 — # TODO: For testing only. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment selenium/scrape_relationships.py:53 — # TODO: Doesn't work for some ~5 types — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment selenium/scrape_relationships.py:69 — # TODO: temp — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment data/repository/src/jvmTest/kotlin/ly/david/musicsearch/data/repository/label/LabelsListRepositoryImplTest.kt:306 — // TODO: test deleting labels that belong to an area and collection after merging collection entity table — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/NowPlayingHistoryRepositoryImpl.kt:54 — // TODO: consider whether to support undo delete for now playing history — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • + 9 more in this group — see findings.md.
D3 · God Classes · MethodTooLong · ×29
  • MethodTooLong: ReleaseUiKt.ReleaseUi shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseUi.kt:57 — MethodTooLong — ReleaseUi runs 235 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 135 over it, 2.35× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: CollectionUiKt.CollectionUi shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionUi.kt:62 — MethodTooLong — CollectionUi runs 204 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 104 over it, 2.04× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SearchResultsRepositoryImpl.fetchAndStore data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/search/SearchResultsRepositoryImpl.kt:95 — MethodTooLong — fetchAndStore runs 190 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 90 over it, 1.90× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: RecordingUiKt.RecordingUi shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt:53 — MethodTooLong — RecordingUi runs 190 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 90 over it, 1.90× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ArtistUiKt.ArtistUi shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:57 — MethodTooLong — ArtistUi runs 182 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 82 over it, 1.82× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ReleaseGroupUiKt.ReleaseGroupUi shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupUi.kt:55 — MethodTooLong — ReleaseGroupUi runs 178 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 78 over it, 1.78× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: DetailsPresenter.lookupDetailsModel shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/utils/DetailsPresenter.kt:88 — MethodTooLong — lookupDetailsModel runs 176 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 76 over it, 1.76× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: DetailsPresenter.present shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/utils/DetailsPresenter.kt:95 — MethodTooLong — present runs 170 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 70 over it, 1.70× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: LabelUiKt.LabelUi shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt:46 — MethodTooLong — LabelUi runs 166 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 66 over it, 1.66× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: AreaUiKt.AreaUi shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt:46 — MethodTooLong — AreaUi runs 161 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 61 over it, 1.61× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: WorkUiKt.WorkUi shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/work/WorkUi.kt:45 — MethodTooLong — WorkUi runs 157 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 57 over it, 1.57× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: AllEntitiesListPresenter.present ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/list/AllEntitiesListPresenter.kt:52 — MethodTooLong — present runs 157 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 57 over it, 1.57× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: PlaceUiKt.PlaceUi shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/place/PlaceUi.kt:43 — MethodTooLong — PlaceUi runs 156 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 56 over it, 1.56× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: BaseListPresenter.getEntityType ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/list/BaseListPresenter.kt:51 — MethodTooLong — getEntityType runs 151 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 51 over it, 1.51× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ListensPresenter.present shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListensPresenter.kt:62 — MethodTooLong — present runs 149 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 49 over it, 1.49× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: BaseListPresenter.present ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/list/BaseListPresenter.kt:54 — MethodTooLong — present runs 149 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 49 over it, 1.49× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: EventUiKt.EventUi shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt:47 — MethodTooLong — EventUi runs 148 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 48 over it, 1.48× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SearchResultsUiKt.ListItemUi shared/feature/search/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/search/SearchResultsUi.kt:76 — MethodTooLong — ListItemUi runs 144 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 44 over it, 1.44× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: AliasDao.insert data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AliasDao.kt:69 — MethodTooLong — insert runs 140 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 40 over it, 1.40× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: InstrumentUiKt.InstrumentUi shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/instrument/InstrumentUi.kt:45 — MethodTooLong — InstrumentUi runs 139 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 39 over it, 1.39× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SeriesUiKt.SeriesUi shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/series/SeriesUi.kt:45 — MethodTooLong — SeriesUi runs 139 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 39 over it, 1.39× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: AllLocalEntitiesUiKt.AllLocalEntitiesUi shared/feature/database/src/commonMain/kotlin/ly/david/musicsearch/share/feature/database/all/AllLocalEntitiesUi.kt:44 — MethodTooLong — AllLocalEntitiesUi runs 135 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 35 over it, 1.35× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SubmitListenUiKt.SubmitListenUi shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/submit/SubmitListenUi.kt:46 — MethodTooLong — SubmitListenUi runs 127 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 27 over it, 1.27× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: androidKt.PreviewTracksByReleaseUi shared/feature/details/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/details/release/TracksByReleaseUi.android.kt:20 — MethodTooLong — PreviewTracksByReleaseUi runs 114 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 14 over it, 1.14× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ReleaseDetailsTabUiKt.ReleaseDetailsTabUi shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseDetailsTabUi.kt:71 — MethodTooLong — ReleaseDetailsTabUi runs 114 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 14 over it, 1.14× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • + 4 more in this group — see findings.md.
D35 · Change Coupling · Change coupling · ×14
  • Change coupling: ListFiltersMenuItems.kt ↔ SortOptionsBottomSheet.kt ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/sort/ListFiltersMenuItems.kt:1 — `ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/sort/ListFiltersMenuItems.kt` and `ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/sort/SortOptionsBottomSheet.kt` change together 80% of the time (8 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `07894a81` feat: support sorting genres by cached order or name, ascending/desce…; `6bb95754` feat: support sorting series by cached order or name, ascending/desce…; `378fb05f` feat: support sorting instruments by cached order or name, ascending/… — run `git show` on any of them.
  • Change coupling: CollectionsFeatureModule.kt ↔ CollectionUi.kt shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/CollectionsFeatureModule.kt:1 — `shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/CollectionsFeatureModule.kt` and `shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionUi.kt` change together 78% of the time (14 of the 18 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 14 shared commits counted here, the most recent 3 are `2080e668` chore: rename to edit; make delete from collection more clear; `674ad36b` fix: improve add to collection messages and make them localizable; sh…; `3492e51f` chore: pass an external coroutine scope that can outlive the presente… — run `git show` on any of them.
  • Change coupling: BaseListPresenter.kt ↔ SortOptionsBottomSheet.kt ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/list/BaseListPresenter.kt:1 — `ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/list/BaseListPresenter.kt` and `ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/sort/SortOptionsBottomSheet.kt` change together 77% of the time (10 of the 13 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 10 shared commits counted here, the most recent 3 are `07894a81` feat: support sorting genres by cached order or name, ascending/desce…; `6bb95754` feat: support sorting series by cached order or name, ascending/desce…; `378fb05f` feat: support sorting instruments by cached order or name, ascending/… — run `git show` on any of them.
  • Change coupling: ArtistPresenter.kt ↔ ArtistUi.kt shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistPresenter.kt:1 — `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistPresenter.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt` change together 64% of the time (16 of the 25 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 16 shared commits counted here, the most recent 3 are `4326c065` feat: support collapsing artist external links; `9a3c246e` chore: pass Flow<PagingData<ListItemModel>> rather than LazyPagingIte…; `2092770c` fix: pass handled exception to all details retry screen to display a … — run `git show` on any of them.
  • Change coupling: ImageUrlDao.kt ↔ ReleasePresenter.kt shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/image/ImageUrlDao.kt:1 — `shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/image/ImageUrlDao.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleasePresenter.kt` change together 60% of the time (6 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `ad388c7e` feat: show the number of cover art images in release group and event …; `1549ed3a` fix: less UI reloads when browsing large lists of releases and releas…; `43edc9c8` chore: rename to ImageMetadata because it holds data besides the imag… — run `git show` on any of them.
  • Change coupling: MbidImageDao.kt ↔ ImagesPresenter.kt data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/MbidImageDao.kt:1 — `data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/MbidImageDao.kt` and `shared/feature/images/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/images/ImagesPresenter.kt` change together 57% of the time (8 of the 14 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `571c3ddf` feat: support getting artist image from Wikimedia if wikidata url exi…; `20eaa60c` fix: remove duplicate images based on url with http/https and .jpg st…; `ee5e31ec` chore: move under images dir — run `git show` on any of them.
  • Change coupling: ArtistListItem.kt ↔ PlaceListItem.kt ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/artist/ArtistListItem.kt:1 — `ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/artist/ArtistListItem.kt` and `ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/place/PlaceListItem.kt` change together 53% of the time (8 of the 15 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `d9ca1a1a` fix: only bold unvisited item's name without bolding its disambiguati…; `a130a884` fix: only bold an unvisited entity's name/disambiguation/aliases inst…; `56860a3c` chore: fix core tests (at that commit the files were still `ui/common/src/main/java/ly/david/ui/common/artist/ArtistListItem..kt` and `ui/common/src/main/java/ly/david/ui/common/place/PlaceListItem.kt`) — run `git show` on any of them.
  • Change coupling: ReleaseListItem.kt ↔ WorkListItem.kt ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/release/ReleaseListItem.kt:1 — `ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/release/ReleaseListItem.kt` and `ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/work/WorkListItem.kt` change together 53% of the time (9 of the 17 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 9 shared commits counted here, the most recent 3 are `47cc5f4f` feat: support sorting recordings by most/least recently listened date…; `8f2636c1` fix: show just the listen count, but content description reads "X lis…; `d9ca1a1a` fix: only bold unvisited item's name without bolding its disambiguati… — run `git show` on any of them.
  • Change coupling: ArtistUi.android.kt ↔ ArtistDetailsTabUi.kt shared/feature/details/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.android.kt:1 — `shared/feature/details/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.android.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistDetailsTabUi.kt` change together 53% of the time (9 of the 17 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 9 shared commits counted here, the most recent 3 are `c1f5a89d` feat: support collapsing all sections in Details tab; `a398cde1` chore: PascalCase; `da67ca99` chore: use a single set to track which details sections are collapsed — run `git show` on any of them.
  • Change coupling: AreaPresenter.kt ↔ AreaUi.kt shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaPresenter.kt:1 — `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaPresenter.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt` change together 50% of the time (10 of the 20 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 10 shared commits counted here, the most recent 3 are `87b413f3` feat: support collapsing area external links; `6f145b49` feat: add refresh menu item for area screen; `f54a2e59` chore: use Tab instead of AreaTab; no-op rest of tabs — run `git show` on any of them.
  • Change coupling: MbidImageDao.kt ↔ ImagesUi.kt data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/MbidImageDao.kt:1 — `data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/MbidImageDao.kt` and `shared/feature/images/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/images/ImagesUi.kt` change together 50% of the time (7 of the 14 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `ad388c7e` feat: show the number of cover art images in release group and event …; `ee5e31ec` chore: move under images dir; `11c10fd9` feat: support sorting cover arts by name of artist/release/release gr… (at that commit the file was still `shared/feature/images/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/images/CoverArtsUi.kt`) — run `git show` on any of them.
  • Change coupling: CollectionDao.kt ↔ CollectionRepository.kt data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/CollectionDao.kt:1 — `data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/CollectionDao.kt` and `shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/collection/CollectionRepository.kt` change together 50% of the time (6 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `64dea7f1` feat: add icons next to collections in "Add to collection" sheet to r…; `a6f283b8` feat: support undoing deleting a local collection; update database ve…; `bb884baf` chore: count number of stored remote collections instead of using `br… — run `git show` on any of them.
  • Change coupling: ImageUrlDao.kt ↔ ImagesUi.kt shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/image/ImageUrlDao.kt:1 — `shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/image/ImageUrlDao.kt` and `shared/feature/images/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/images/ImagesUi.kt` change together 50% of the time (5 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 5 shared commits counted here, the most recent 3 are `ad388c7e` feat: show the number of cover art images in release group and event …; `ee5e31ec` chore: move under images dir; `11c10fd9` feat: support sorting cover arts by name of artist/release/release gr… (at that commit the file was still `shared/feature/images/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/images/CoverArtsUi.kt`) — run `git show` on any of them.
  • Change coupling: ArtistUi.android.kt ↔ ReleaseGroupUi.android.kt shared/feature/details/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.android.kt:1 — `shared/feature/details/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.android.kt` and `shared/feature/details/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupUi.android.kt` change together 50% of the time (5 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 5 shared commits counted here, the most recent 3 are `c1f5a89d` feat: support collapsing all sections in Details tab; `da67ca99` chore: use a single set to track which details sections are collapsed (at that commit the file was still `shared/feature/details/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/PreviewReleaseGroupDetailsUi.kt`); `070a166a` feat: show highlight over filtered text in Details screens (at that commit the file was still `shared/feature/details/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/PreviewReleaseGroupDetailsUi.kt`) — run `git show` on any of them.
D4 · Code Duplication · Duplicated block (19 lines × 2) · ×5
  • Duplicated block (19 lines × 2) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/mapper/MapToReleaseListItemModel.kt:46 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/mapper/MapToReleaseListItemModel.kt:46-64 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/mapper/MapToReleaseListItemModel.kt:108-126 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/mapper/MapToReleaseListItemModel.kt:46` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (19 lines × 2) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:282 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:282-300 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt:243-261 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 286 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:282` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (19 lines × 2) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt:226 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt:226-244 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseUi.kt:260-278 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseUi.kt` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 154 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt:226` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (19 lines × 2) shared/feature/listens/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListensUi.android.kt:73 — shared/feature/listens/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListensUi.android.kt:73-91 | shared/feature/listens/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListensUi.android.kt:128-146 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/listens/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListensUi.android.kt:73` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (19 lines × 2) shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/submit/DatePickerField.kt:55 — shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/submit/DatePickerField.kt:55-73 | shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/submit/TimePickerField.kt:69-87 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/submit/DatePickerField.kt:55` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (18 lines × 2) · ×5
  • Duplicated block (18 lines × 2) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ArtistDao.kt:96 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ArtistDao.kt:96-113 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ReleaseGroupDao.kt:126-143 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ArtistDao.kt:96` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (18 lines × 2) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ReleaseDao.kt:64 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ReleaseDao.kt:64-81 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ReleaseDao.kt:92-109 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ReleaseDao.kt:64` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (18 lines × 2) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseUi.kt:361 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseUi.kt:361-378 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupUi.kt:276-293 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupUi.kt` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 107 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseUi.kt:361` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (18 lines × 2) shared/feature/stats/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/stats/PreviewAddEntityStatsSection.kt:45 — shared/feature/stats/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/stats/PreviewAddEntityStatsSection.kt:45-62 | shared/feature/stats/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/stats/PreviewStatsUi.kt:48-65 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (18 lines × 2) shared/feature/details/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/details/release/TracksByReleaseUi.android.kt:62 — shared/feature/details/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/details/release/TracksByReleaseUi.android.kt:62-79 | shared/feature/details/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/details/release/TracksByReleaseUi.android.kt:87-104 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/details/release/TracksByReleaseUi.android.kt:62` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D5 · Coupling · Unstable project MusicSearch · ×5
  • Unstable project MusicSearch:data:repository — MusicSearch:data:repository has instability 0.88 with 1 dependents.
  • Unstable project MusicSearch:shared — MusicSearch:shared has instability 0.93 with 2 dependents.
  • Unstable project MusicSearch:shared:feature:details — MusicSearch:shared:feature:details has instability 0.83 with 1 dependents.
  • Unstable project MusicSearch:shared:feature:history — MusicSearch:shared:feature:history has instability 0.83 with 1 dependents.
  • Unstable project MusicSearch:shared:feature:images — MusicSearch:shared:feature:images has instability 0.83 with 1 dependents.
D35 · Change Coupling · Change-coupling hub · ×4
  • Change-coupling hub: ImageMetadataRepository.kt → MbidImageDao.kt, MusicBrainzImageMetadataRepositoryImpl.kt, ArtistImageRepositoryImpl.kt, ImageUrlDao.kt shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/image/ImageMetadataRepository.kt — `shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/image/ImageMetadataRepository.kt` changes together with 4 other files — `data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/MbidImageDao.kt`, `data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/image/MusicBrainzImageMetadataRepositoryImpl.kt`, `data/spotify/src/commonMain/kotlin/ly/david/musicsearch/data/spotify/ArtistImageRepositoryImpl.kt`, `shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/image/ImageUrlDao.kt` — none of which declares a dependency on it: one file is the hub of 4 separate couplings, not 4 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 4.
  • Change-coupling hub: AppPreferencesImpl.kt → ListFilters.kt, BaseListPresenter.kt, ListFiltersMenuItems.kt, SortOptionsBottomSheet.kt core/preferences/src/commonMain/kotlin/ly/david/musicsearch/core/preferences/AppPreferencesImpl.kt — `core/preferences/src/commonMain/kotlin/ly/david/musicsearch/core/preferences/AppPreferencesImpl.kt` changes together with 4 other files — `shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/list/ListFilters.kt`, `ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/list/BaseListPresenter.kt`, `ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/sort/ListFiltersMenuItems.kt`, `ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/sort/SortOptionsBottomSheet.kt` — none of which declares a dependency on it: one file is the hub of 4 separate couplings, not 4 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 4.
  • Change-coupling hub: ListensListRepositoryImpl.kt → ListensUi.android.kt, ListensPresenter.kt, ListensUi.kt data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/listen/ListensListRepositoryImpl.kt — `data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/listen/ListensListRepositoryImpl.kt` changes together with 3 other files — `shared/feature/listens/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListensUi.android.kt`, `shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListensPresenter.kt`, `shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListensUi.kt` — none of which declares a dependency on it: one file is the hub of 3 separate couplings, not 3 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 3.
  • Change-coupling hub: ListenDaoImpl.kt → ListensListRepository.kt, ListensUi.android.kt, ListenAdditionalActionsBottomSheetContent.kt data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ListenDaoImpl.kt — `data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ListenDaoImpl.kt` changes together with 3 other files — `shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/listen/ListensListRepository.kt`, `shared/feature/listens/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListensUi.android.kt`, `shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListenAdditionalActionsBottomSheetContent.kt` — none of which declares a dependency on it: one file is the hub of 3 separate couplings, not 3 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 3.
D4 · Code Duplication · Duplicated block (15 lines × 2) · ×4
  • Duplicated block (15 lines × 2) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelDetailsTabUi.kt:94 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelDetailsTabUi.kt:94-108 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/place/PlaceDetailsTabUi.kt:85-99 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelDetailsTabUi.kt:94` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 2) shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListenAdditionalActionsBottomSheetContent.kt:436 — shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListenAdditionalActionsBottomSheetContent.kt:436-450 | shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListenListItem.kt:45-59 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListenAdditionalActionsBottomSheetContent.kt:436` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 2) shared/src/commonMain/kotlin/ly/david/musicsearch/shared/AppBottomNavigationBar.kt:35 — shared/src/commonMain/kotlin/ly/david/musicsearch/shared/AppBottomNavigationBar.kt:35-49 | shared/src/commonMain/kotlin/ly/david/musicsearch/shared/AppNavigationRail.kt:20-34 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `shared/src/commonMain/kotlin/ly/david/musicsearch/shared/AppBottomNavigationBar.kt:35` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 2) ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/release/ReleaseListItem.kt:165 — ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/release/ReleaseListItem.kt:165-179 | ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/work/WorkListItem.kt:94-108 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/release/ReleaseListItem.kt:165` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/work/WorkListItem.kt:93` calls `padding` and `ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/release/ReleaseListItem.kt:164` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D30 · Dependency Vulnerabilities · Medium CVE · ×3
  • REDACTED
  • REDACTED
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Edited copy of a member (41 corresponding lines) · ×3
  • Edited copy of a member (41 corresponding lines) shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/submit/DatePickerField.kt:42 — shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/submit/DatePickerField.kt:42-82 | shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/submit/TimePickerField.kt:56-96 — These two members are one piece of code written twice and then edited apart: 41 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (41 corresponding lines) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaDetailsTabUi.kt:30 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaDetailsTabUi.kt:30-70 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventDetailsTabUi.kt:37-85 — These two members are one piece of code written twice and then edited apart: 41 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (41 corresponding lines) shared/feature/listens/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/listens/FacetsBottomSheetContent.android.kt:19 — shared/feature/listens/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/listens/FacetsBottomSheetContent.android.kt:19-63 | shared/feature/listens/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/listens/FacetsBottomSheetContent.android.kt:67-107 — These two members are one piece of code written twice and then edited apart: 41 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (23 corresponding lines) · ×3
  • Edited copy of a member (23 corresponding lines) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ReleaseDao.kt:58 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ReleaseDao.kt:58-87 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ReleaseDao.kt:89-111 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (23 corresponding lines) data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/listen/ListenRemoteMediator.kt:73 — data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/listen/ListenRemoteMediator.kt:73-95 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/listen/ListenRemoteMediator.kt:97-119 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (23 corresponding lines) ui/common/src/androidMain/kotlin/ly/david/musicsearch/ui/common/artist/ArtistListItemPreview..kt:49 — ui/common/src/androidMain/kotlin/ly/david/musicsearch/ui/common/artist/ArtistListItemPreview..kt:49-71 | ui/common/src/androidMain/kotlin/ly/david/musicsearch/ui/common/artist/ArtistListItemPreview..kt:75-97 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (19 corresponding lines) · ×3
  • Edited copy of a member (19 corresponding lines) shared/src/commonMain/kotlin/ly/david/musicsearch/shared/AppBottomNavigationBar.kt:31 — shared/src/commonMain/kotlin/ly/david/musicsearch/shared/AppBottomNavigationBar.kt:31-49 | shared/src/commonMain/kotlin/ly/david/musicsearch/shared/AppNavigationRail.kt:16-34 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (19 corresponding lines) shared/feature/images/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/images/PreviewImagesUi.kt:62 — shared/feature/images/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/images/PreviewImagesUi.kt:62-80 | shared/feature/images/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/images/PreviewImagesUi.kt:84-102 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (19 corresponding lines) ui/common/src/androidMain/kotlin/ly/david/musicsearch/ui/common/recording/RecordingListItem.android.kt:28 — ui/common/src/androidMain/kotlin/ly/david/musicsearch/ui/common/recording/RecordingListItem.android.kt:28-48 | ui/common/src/androidMain/kotlin/ly/david/musicsearch/ui/common/recording/RecordingListItem.android.kt:52-70 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (30 lines × 2) · ×3
  • Duplicated block (30 lines × 2) shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionUi.kt:306 — shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionUi.kt:306-335 | shared/feature/database/src/commonMain/kotlin/ly/david/musicsearch/share/feature/database/all/AllLocalEntitiesUi.kt:182-211 — before extracting anything, compare `shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionUi.kt` and `shared/feature/database/src/commonMain/kotlin/ly/david/musicsearch/share/feature/database/all/AllLocalEntitiesUi.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 71 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionUi.kt:306` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionUi.kt:337` calls `loginEventSink` and `shared/feature/database/src/commonMain/kotlin/ly/david/musicsearch/share/feature/database/all/AllLocalEntitiesUi.kt:212` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (30 lines × 2) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt:95 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt:95-124 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/instrument/InstrumentUi.kt:92-121 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/instrument/InstrumentUi.kt` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt:95` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note first that the copies are not typed on the same thing: the declarations holding them bind `state` to `DetailsUiState<EventDetailsModel>` in one and `DetailsUiState<InstrumentDetailsModel>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (30 lines × 2) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingDetailsTabUi.kt:93 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingDetailsTabUi.kt:93-122 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/work/WorkDetailsTabUi.kt:100-129 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingDetailsTabUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/work/WorkDetailsTabUi.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 74 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingDetailsTabUi.kt:93` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (16 lines × 3) · ×3
  • Duplicated block (16 lines × 3) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelDetailsTabUi.kt:38 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelDetailsTabUi.kt:38-53 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/place/PlaceDetailsTabUi.kt:34-49 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/work/WorkDetailsTabUi.kt:48-63 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelDetailsTabUi.kt:38` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (16 lines × 3) data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/area/AreasListRepositoryImpl.kt:57 — data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/area/AreasListRepositoryImpl.kt:57-72 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/instrument/InstrumentsListRepositoryImpl.kt:57-72 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/series/SeriesListRepositoryImpl.kt:57-72 — before extracting anything, compare `data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/instrument/InstrumentsListRepositoryImpl.kt` and `data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/series/SeriesListRepositoryImpl.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 41 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/area/AreasListRepositoryImpl.kt:57` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (16 lines × 3) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AreaDao.kt:181 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AreaDao.kt:181-196 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/GenreDao.kt:49-64 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/InstrumentDao.kt:89-104 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AreaDao.kt:181` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `sortOption` to `AreaSortOption` in one and `GenreSortOption` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (14 lines × 2) · ×3
  • Duplicated block (14 lines × 2) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/PlaceDao.kt:87 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/PlaceDao.kt:87-100 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/mapper/MapToPlaceListItemModel.kt:24-37 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (14 lines × 2) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/mapper/MapToArtistListItemModel.kt:36 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/mapper/MapToArtistListItemModel.kt:36-49 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/mapper/MapToEventListItemModel.kt:31-44 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (14 lines × 2) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaDetailsTabUi.kt:32 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaDetailsTabUi.kt:32-45 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventDetailsTabUi.kt:39-52 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication · Duplicated block (13 lines × 2) · ×3
  • Duplicated block (13 lines × 2) data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/area/AreasListRepositoryImpl.kt:95 — data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/area/AreasListRepositoryImpl.kt:95-107 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/genre/GenresListRepositoryImpl.kt:92-104 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/area/AreasListRepositoryImpl.kt:95` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/instrument/InstrumentsListRepositoryImpl.kt:95 — data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/instrument/InstrumentsListRepositoryImpl.kt:95-107 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/series/SeriesListRepositoryImpl.kt:95-107 — before extracting anything, compare `data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/instrument/InstrumentsListRepositoryImpl.kt` and `data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/series/SeriesListRepositoryImpl.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 41 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/instrument/InstrumentsListRepositoryImpl.kt:95` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) data/listenbrainz/src/commonMain/kotlin/ly/david/musicsearch/data/listenbrainz/api/ListenBrainzRepositoryImpl.kt:15 — data/listenbrainz/src/commonMain/kotlin/ly/david/musicsearch/data/listenbrainz/api/ListenBrainzRepositoryImpl.kt:15-27 | data/musicbrainz/src/commonMain/kotlin/ly/david/musicsearch/data/musicbrainz/api/MusicBrainzRepositoryImpl.kt:14-26 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication · Duplicated block (12 lines × 2) · ×3
  • Duplicated block (12 lines × 2) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt:207 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt:207-218 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseUi.kt:304-315 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseUi.kt` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 83 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt:207` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (12 lines × 2) shared/feature/graph/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/graph/ArtistCollaborationGraphUi.kt:330 — shared/feature/graph/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/graph/ArtistCollaborationGraphUi.kt:330-341 | shared/feature/graph/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/graph/ArtistCollaborationGraphUi.kt:345-356 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (12 lines × 2) ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/component/MultipleChoiceBottomSheet.kt:20 — ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/component/MultipleChoiceBottomSheet.kt:20-31 | ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/sort/SortOptionsBottomSheet.kt:67-78 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/component/MultipleChoiceBottomSheet.kt:20` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) · ×2
  • Members sharing a duplicated core (4 members, 50+ identical tokens) shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionUi.kt:66 — shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionUi.kt:66-342 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/utils/DetailsTabUi.kt:106-294 | ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/collection/ShowAddToCollectionSheet.kt:24-61 | ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/topappbar/SubmitListenMenuItem.kt:69-103 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/event/EventListItem.kt:40 — ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/event/EventListItem.kt:40-118 | ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/instrument/InstrumentListItem.kt:33-86 | ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/place/PlaceListItem.kt:34-95 | ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/series/SeriesListItem.kt:32-76 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication · Edited copy of a member (17 corresponding lines) · ×2
  • Edited copy of a member (17 corresponding lines) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/CollectedStatsDao.kt:90 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/CollectedStatsDao.kt:90-106 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/VisitedStatsDao.kt:90-106 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (17 corresponding lines) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/RecordingDao.kt:76 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/RecordingDao.kt:76-92 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/WorkDao.kt:67-83 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (28 corresponding lines) · ×2
  • Edited copy of a member (28 corresponding lines) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistDetailsTabUi.kt:190 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistDetailsTabUi.kt:190-217 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/work/WorkDetailsTabUi.kt:139-174 — These two members are one piece of code written twice and then edited apart: 28 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (28 corresponding lines) shared/feature/history/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/history/internal/HistoryUi.kt:196 — shared/feature/history/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/history/internal/HistoryUi.kt:196-223 | shared/feature/nowplaying/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/nowplaying/NowPlayingHistoryUi.kt:78-116 — These two members are one piece of code written twice and then edited apart: 28 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 19+ corresponding lines) · ×2
  • Edited copies of one member (4 members, 19+ corresponding lines) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AreaDao.kt:96 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AreaDao.kt:96-117 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ArtistDao.kt:39-61 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/EventDao.kt:34-52 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/LabelDao.kt:40-61 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 19 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
  • Edited copies of one member (4 members, 19+ corresponding lines) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/RelationDao.kt:62 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/RelationDao.kt:62-80 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ReleaseDao.kt:316-336 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ReleaseDao.kt:382-402 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ReleaseDao.kt:412-432 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 19 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (18 corresponding lines) · ×2
  • Edited copy of a member (18 corresponding lines) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/CollectedStatsDao.kt:23 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/CollectedStatsDao.kt:23-40 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/VisitedStatsDao.kt:23-40 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (18 corresponding lines) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AreaDao.kt:248 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AreaDao.kt:248-265 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/SeriesDao.kt:108-125 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 19+ corresponding lines) · ×2
  • Edited copies of one member (3 members, 19+ corresponding lines) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/mapper/MapToArtistListItemModel.kt:29 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/mapper/MapToArtistListItemModel.kt:29-52 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/mapper/MapToEventListItemModel.kt:25-45 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/mapper/MapToPlaceListItemModel.kt:23-41 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 19 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 19+ corresponding lines) ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/screen/ShowInBottomSheet.kt:18 — ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/screen/ShowInBottomSheet.kt:18-36 | ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/screen/ShowInDialog.kt:15-34 | ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/screen/ShowInDialog.kt:38-57 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 19 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (16 corresponding lines) · ×2
  • Edited copy of a member (16 corresponding lines) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/TagDao.kt:176 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/TagDao.kt:176-191 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/TagDao.kt:195-212 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (16 corresponding lines) ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/topappbar/TopAppBarWithFilter.kt:77 — ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/topappbar/TopAppBarWithFilter.kt:77-94 | ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/topappbar/ScrollableTopAppBar.kt:68-83 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 20+ corresponding lines) · ×2
  • Edited copies of one member (3 members, 20+ corresponding lines) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ArtistCollaborationDao.kt:40 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ArtistCollaborationDao.kt:40-59 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ArtistCollaborationDao.kt:64-83 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ArtistCollaborationDao.kt:88-107 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 20 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 20+ corresponding lines) data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/place/PlacesListRepositoryImpl.kt:57 — data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/place/PlacesListRepositoryImpl.kt:57-76 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/release/ReleasesListRepositoryImpl.kt:75-94 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/releasegroup/ReleaseGroupsListRepositoryImpl.kt:111-130 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 20 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (12 corresponding lines) · ×2
  • Edited copy of a member (12 corresponding lines) data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/NowPlayingHistoryRepositoryImpl.kt:41 — data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/NowPlayingHistoryRepositoryImpl.kt:41-52 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/SpotifyHistoryRepositoryImpl.kt:51-62 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (12 corresponding lines) data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/SpotifyHistoryRepositoryImpl.kt:33 — data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/SpotifyHistoryRepositoryImpl.kt:33-46 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/NowPlayingHistoryRepositoryImpl.kt:25-36 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (15 corresponding lines) · ×2
  • Edited copy of a member (15 corresponding lines) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/mapper/MapToLabelListItemModel.kt:19 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/mapper/MapToLabelListItemModel.kt:19-33 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/mapper/MapToRecordingListItemModel.kt:46-60 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (15 corresponding lines) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/MbidImageDao.kt:82 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/MbidImageDao.kt:82-100 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/SpotifyHistoryDao.kt:45-59 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (9 corresponding lines) · ×2
  • Edited copy of a member (9 corresponding lines) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/alias/AliasesSection.kt:51 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/alias/AliasesSection.kt:51-59 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/utils/FilterUrlRelations.kt:9-17 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (9 corresponding lines) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/mapper/MapToInstrumentListItemModel.kt:16 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/mapper/MapToInstrumentListItemModel.kt:16-25 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/mapper/MapToSeriesListItemModel.kt:15-23 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (7 corresponding lines) · ×2
  • Edited copy of a member (7 corresponding lines) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/InstrumentDao.kt:72 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/InstrumentDao.kt:72-79 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/SeriesDao.kt:71-77 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/RelationDao.kt:96 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/RelationDao.kt:96-105 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/TrackDao.kt:89-95 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (20 lines × 2) · ×2
  • Duplicated block (20 lines × 2) shared/feature/collections/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/collections/list/PreviewCollectionListUi.kt:17 — shared/feature/collections/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/collections/list/PreviewCollectionListUi.kt:17-36 | shared/feature/collections/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/collections/list/PreviewCollectionListUi.kt:51-70 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/collections/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/collections/list/PreviewCollectionListUi.kt:17` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `shared/feature/collections/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/collections/list/PreviewCollectionListUi.kt:72` calls `rememberSelectionState`, `toggleSelection`, `SelectableId` and `shared/feature/collections/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/collections/list/PreviewCollectionListUi.kt:38` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (20 lines × 2) shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/edit/EditCollectionPresenter.kt:79 — shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/edit/EditCollectionPresenter.kt:79-98 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/tag/TagDetailsPresenter.kt:63-82 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/edit/EditCollectionPresenter.kt:79` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (12 lines × 4) · ×2
  • Duplicated block (12 lines × 4) shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionUi.kt:165 — shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionUi.kt:165-176 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/utils/DetailsTabUi.kt:228-239 | ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/collection/ShowAddToCollectionSheet.kt:38-49 | ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/topappbar/SubmitListenMenuItem.kt:86-97 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 4 times. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionUi.kt:165` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 4) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ArtistDao.kt:172 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ArtistDao.kt:172-183 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/EventDao.kt:105-116 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ReleaseGroupDao.kt:194-205 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/WorkDao.kt:113-124 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 4 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ArtistDao.kt:172` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9 lines × 2) · ×2
  • Duplicated block (9 lines × 2) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseDetailsTabUi.kt:248 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseDetailsTabUi.kt:248-256 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseDetailsTabUi.kt:294-302 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseDetailsTabUi.kt:248` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseDetailsTabUi.kt:246` calls `toString` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseDetailsTabUi.kt:292` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (9 lines × 2) shared/feature/settings/src/iosMain/kotlin/ly/david/musicsearch/shared/feature/settings/internal/appearance/AppearanceSettingsUi.ios.kt:14 — shared/feature/settings/src/iosMain/kotlin/ly/david/musicsearch/shared/feature/settings/internal/appearance/AppearanceSettingsUi.ios.kt:14-22 | shared/feature/settings/src/jvmMain/kotlin/ly/david/musicsearch/shared/feature/settings/internal/appearance/AppearanceSettingsUi.jvm.kt:14-22 — before extracting anything, compare `shared/feature/settings/src/iosMain/kotlin/ly/david/musicsearch/shared/feature/settings/internal/appearance/AppearanceSettingsUi.ios.kt` and `shared/feature/settings/src/jvmMain/kotlin/ly/david/musicsearch/shared/feature/settings/internal/appearance/AppearanceSettingsUi.jvm.kt` as WHOLE FILES: 100% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/settings/src/iosMain/kotlin/ly/david/musicsearch/shared/feature/settings/internal/appearance/AppearanceSettingsUi.ios.kt:14` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (8 lines × 2) · ×2
  • Duplicated block (8 lines × 2) shared/feature/database/src/commonMain/kotlin/ly/david/musicsearch/share/feature/database/all/AllLocalEntitiesPresenter.kt:49 — shared/feature/database/src/commonMain/kotlin/ly/david/musicsearch/share/feature/database/all/AllLocalEntitiesPresenter.kt:49-56 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/utils/DetailsPresenter.kt:120-127 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/database/src/commonMain/kotlin/ly/david/musicsearch/share/feature/database/all/AllLocalEntitiesPresenter.kt:49` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) shared/feature/images/src/iosMain/kotlin/ly/david/musicsearch/shared/feature/images/ImagesUi.ios.kt:14 — shared/feature/images/src/iosMain/kotlin/ly/david/musicsearch/shared/feature/images/ImagesUi.ios.kt:14-21 | shared/feature/images/src/jvmMain/kotlin/ly/david/musicsearch/shared/feature/images/ImagesUi.jvm.kt:14-21 — before extracting anything, compare `shared/feature/images/src/iosMain/kotlin/ly/david/musicsearch/shared/feature/images/ImagesUi.ios.kt` and `shared/feature/images/src/jvmMain/kotlin/ly/david/musicsearch/shared/feature/images/ImagesUi.jvm.kt` as WHOLE FILES: 100% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/images/src/iosMain/kotlin/ly/david/musicsearch/shared/feature/images/ImagesUi.ios.kt:14` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
AC3 · Page structure · Page without a main landmark · ×1
  • Page without a main landmark download.html:3 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
AC6 · Visual & motion safety · Low contrast colour pair in CSS (1.7 · ×1
  • Low contrast colour pair in CSS (1.7:1) download.html:91 — `.download-button` sets color: white on background-color: #01e675 — 1.7:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
D1 · Cyclomatic Complexity · CoverKt.cover (cyclomatic 20) · ×1
  • CoverKt.cover (cyclomatic 20) shared/feature/graph/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/graph/viz/quadtree/Cover.kt:30 — CoverKt.cover has cyclomatic complexity 20 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · TopAppBarWithFilterKt.TopAppBarWithFilterInternal (cyclomatic 17) · ×1
  • TopAppBarWithFilterKt.TopAppBarWithFilterInternal (cyclomatic 17) ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/topappbar/TopAppBarWithFilter.kt:120 — TopAppBarWithFilterKt.TopAppBarWithFilterInternal has cyclomatic complexity 17 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · ImagesPresenter.present (cyclomatic 17) · ×1
  • ImagesPresenter.present (cyclomatic 17) shared/feature/images/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/images/ImagesPresenter.kt:49 — ImagesPresenter.present has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ForceNBody.applyForce (cyclomatic 16) · ×1
  • ForceNBody.applyForce (cyclomatic 16) shared/feature/graph/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/graph/viz/force/ForceNBody.kt:138 — ForceNBody.applyForce has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · AddKt._add (cyclomatic 16) · ×1
  • AddKt._add (cyclomatic 16) shared/feature/graph/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/graph/viz/quadtree/Add.kt:32 — AddKt._add has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D2 · Cognitive Complexity · AddKt._add (cognitive 30) · ×1
  • AddKt._add (cognitive 30) shared/feature/graph/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/graph/viz/quadtree/Add.kt:32 — AddKt._add has cognitive complexity 30 (threshold 15). Drivers by points: if/else 17 (26 pts), boolean chains 2, loops 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CoverKt.cover (cognitive 27) · ×1
  • CoverKt.cover (cognitive 27) shared/feature/graph/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/graph/viz/quadtree/Cover.kt:30 — CoverKt.cover has cognitive complexity 27 (threshold 15). Drivers by points: loops 4 (12 pts), boolean chains 7, if/else 5 (6 pts), match/switch 1 (2 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ForceNBody.applyForce (cognitive 26) · ×1
  • ForceNBody.applyForce (cognitive 26) shared/feature/graph/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/graph/viz/force/ForceNBody.kt:138 — ForceNBody.applyForce has cognitive complexity 26 (threshold 15). Drivers by points: if/else 12 (23 pts), boolean chains 2, loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ScreenWithPagingLoadingAndErrorKt.ScreenWithPagingLoadingAndError (cognitive 25) · ×1
  • ScreenWithPagingLoadingAndErrorKt.ScreenWithPagingLoadingAndError (cognitive 25) ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/paging/ScreenWithPagingLoadingAndError.kt:108 — ScreenWithPagingLoadingAndErrorKt.ScreenWithPagingLoadingAndError has cognitive complexity 25 (threshold 15). Drivers by points: if/else 5 (14 pts), boolean chains 5, match/switch 2 (4 pts), loops 1 (2 pts) (nesting depth added 12). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · ReleaseListItemKt.ReleaseListItem (cognitive 22) · ×1
  • ReleaseListItemKt.ReleaseListItem (cognitive 22) ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/release/ReleaseListItem.kt:46 — ReleaseListItemKt.ReleaseListItem has cognitive complexity 22 (threshold 15). Drivers by points: if/else 10 (19 pts), match/switch 1 (2 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ImagesPresenter.present (cognitive 22) · ×1
  • ImagesPresenter.present (cognitive 22) shared/feature/images/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/images/ImagesPresenter.kt:49 — ImagesPresenter.present has cognitive complexity 22 (threshold 15). Drivers by points: if/else 10 (14 pts), boolean chains 5, match/switch 2 (3 pts) (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · VisitKt.visitAfter (cognitive 19) · ×1
  • VisitKt.visitAfter (cognitive 19) shared/feature/graph/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/graph/viz/quadtree/Visit.kt:121 — VisitKt.visitAfter has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (17 pts), loops 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ForceCollision.applyForce (cognitive 17) · ×1
  • ForceCollision.applyForce (cognitive 17) shared/feature/graph/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/graph/viz/force/ForceCollision.kt:118 — ForceCollision.applyForce has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (16 pts), boolean chains 1 (nesting depth added 9). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · VisitKt.visit (cognitive 17) · ×1
  • VisitKt.visit (cognitive 17) shared/feature/graph/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/graph/viz/quadtree/Visit.kt:34 — VisitKt.visit has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (15 pts), boolean chains 1, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TopAppBarWithFilterKt.TopAppBarWithFilterInternal (cognitive 16) · ×1
  • TopAppBarWithFilterKt.TopAppBarWithFilterInternal (cognitive 16) ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/topappbar/TopAppBarWithFilter.kt:120 — TopAppBarWithFilterKt.TopAppBarWithFilterInternal has cognitive complexity 16 (threshold 15). Drivers by points: if/else 11, match/switch 4 (5 pts) (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D3 · God Classes · TooManyMethods · ×1
  • TooManyMethods: AppPreferencesImpl core/preferences/src/commonMain/kotlin/ly/david/musicsearch/core/preferences/AppPreferencesImpl.kt:49 — TooManyMethods — 44 methods. The bar is 30 methods; this is 14 over it, 1.47× the bar. Most of these members implement preferences.AppPreferences (39 of 44 members), so moving them onto a smaller type would remove them from that contract rather than reduce it. To reduce it, split the contract instead: give each cohesive group of operations its own smaller interface and its own implementing type. Where the contract has to stay whole, move the work behind these members into collaborator types, so what is left here is a forward per member rather than a responsibility per member.
D3 · God Classes · ClassTooLong · ×1
  • ClassTooLong: AppPreferencesImpl core/preferences/src/commonMain/kotlin/ly/david/musicsearch/core/preferences/AppPreferencesImpl.kt:49 — ClassTooLong — 465 significant lines (blank, comment-only and punctuation-only lines excluded), 44 methods. The bar is 400 significant lines; this is 65 over it, 1.16× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D3 · God Classes · FileTooLong · ×1
  • FileTooLong: preferences/AppPreferencesImpl.kt core/preferences/src/commonMain/kotlin/ly/david/musicsearch/core/preferences/AppPreferencesImpl.kt — FileTooLong — 514 significant lines (blank, comment-only and punctuation-only lines excluded), about 90% of them inside a single declaration: AppPreferencesImpl (49-822). The bar is 500 significant lines; this is 14 over it, 1.03× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D4 · Code Duplication · Near-duplicate member family (11 members, 62 shared lines) · ×1
  • Near-duplicate member family (11 members, 62 shared lines) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt:49 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt:49-254 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:60-300 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt:50-238 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/instrument/InstrumentUi.kt:48-223 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt:49-261 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/place/PlaceUi.kt:46-245 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt:56-307 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseUi.kt:60-378 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupUi.kt:58-293 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/series/SeriesUi.kt:48-224 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/work/WorkUi.kt:48-246 — These 11 members are variants of one another: a block of 62 lines reported below appears in every one of them, and the pairwise near-duplicate rows they would otherwise produce are collapsed into this row. Read them as one construct written 11 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 11 times.
D4 · Code Duplication · Near-duplicate member family (9 members, 105 shared lines) · ×1
  • Near-duplicate member family (9 members, 105 shared lines) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:60 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:60-300 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt:50-238 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/instrument/InstrumentUi.kt:48-223 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt:49-261 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/place/PlaceUi.kt:46-245 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt:56-307 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupUi.kt:58-293 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/series/SeriesUi.kt:48-224 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/work/WorkUi.kt:48-246 — These 9 members are variants of one another: a block of 105 lines reported below appears in every one of them, and the pairwise near-duplicate rows they would otherwise produce are collapsed into this row. Read them as one construct written 9 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 9 times.
D4 · Code Duplication · Near-duplicate member family (9 members, 71 shared lines) · ×1
  • Near-duplicate member family (9 members, 71 shared lines) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt:49 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt:49-254 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:60-300 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt:50-238 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/instrument/InstrumentUi.kt:48-223 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt:49-261 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/place/PlaceUi.kt:46-245 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupUi.kt:58-293 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/series/SeriesUi.kt:48-224 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/work/WorkUi.kt:48-246 — These 9 members are variants of one another: a block of 71 lines reported below appears in every one of them, and the pairwise near-duplicate rows they would otherwise produce are collapsed into this row. Read them as one construct written 9 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 9 times.
D4 · Code Duplication · Near-duplicate member pair (71 shared lines) · ×1
  • Near-duplicate member pair (71 shared lines) shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionUi.kt:66 — shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionUi.kt:66-342 | shared/feature/database/src/commonMain/kotlin/ly/david/musicsearch/share/feature/database/all/AllLocalEntitiesUi.kt:48-214 — These two members are variants of one another: 71 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Edited copy of a member (71 corresponding lines) · ×1
  • Edited copy of a member (71 corresponding lines) ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/recording/RecordingListItem.kt:56 — ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/recording/RecordingListItem.kt:56-155 | ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/recording/RecordingListItem.kt:165-235 — These two members are one piece of code written twice and then edited apart: 71 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (78 corresponding lines) · ×1
  • Edited copy of a member (78 corresponding lines) shared/feature/graph/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/graph/viz/quadtree/Visit.kt:34 — shared/feature/graph/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/graph/viz/quadtree/Visit.kt:34-111 | shared/feature/graph/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/graph/viz/quadtree/Visit.kt:121-204 — These two members are one piece of code written twice and then edited apart: 78 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (73 corresponding lines) · ×1
  • Edited copy of a member (73 corresponding lines) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingDetailsTabUi.kt:50 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingDetailsTabUi.kt:50-122 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/work/WorkDetailsTabUi.kt:47-129 — These two members are one piece of code written twice and then edited apart: 73 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (67 corresponding lines) · ×1
  • Edited copy of a member (67 corresponding lines) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelDetailsTabUi.kt:37 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelDetailsTabUi.kt:37-108 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/place/PlaceDetailsTabUi.kt:33-99 — These two members are one piece of code written twice and then edited apart: 67 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (50 corresponding lines) · ×1
  • Edited copy of a member (50 corresponding lines) shared/feature/settings/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/settings/internal/components/ListenBrainzProfileCard.kt:47 — shared/feature/settings/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/settings/internal/components/ListenBrainzProfileCard.kt:47-115 | shared/feature/settings/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/settings/internal/components/MusicBrainzProfileCard.kt:32-81 — These two members are one piece of code written twice and then edited apart: 50 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (51 corresponding lines) · ×1
  • Edited copy of a member (51 corresponding lines) shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListensUi.kt:325 — shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListensUi.kt:325-387 | shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListensUi.kt:396-446 — These two members are one piece of code written twice and then edited apart: 51 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (55 corresponding lines) · ×1
  • Edited copy of a member (55 corresponding lines) shared/feature/settings/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/settings/internal/images/ImagesSettingsUi.kt:30 — shared/feature/settings/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/settings/internal/images/ImagesSettingsUi.kt:30-84 | shared/feature/settings/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/settings/internal/listens/ListensSettingsUi.kt:27-81 — These two members are one piece of code written twice and then edited apart: 55 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (45 corresponding lines) · ×1
  • Edited copy of a member (45 corresponding lines) data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/collection/CollectionRepositoryImpl.kt:152 — data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/collection/CollectionRepositoryImpl.kt:152-196 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/collection/CollectionRepositoryImpl.kt:202-257 — These two members are one piece of code written twice and then edited apart: 45 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (57 corresponding lines) · ×1
  • Edited copy of a member (57 corresponding lines) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistDetailsTabUi.kt:61 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistDetailsTabUi.kt:61-121 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupDetailsTabUi.kt:48-104 — These two members are one piece of code written twice and then edited apart: 57 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (39 corresponding lines) · ×1
  • Edited copy of a member (39 corresponding lines) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseDetailsTabUi.kt:240 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseDetailsTabUi.kt:240-280 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseDetailsTabUi.kt:288-326 — These two members are one piece of code written twice and then edited apart: 39 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 29+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 29+ corresponding lines) data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/recording/RecordingRepositoryImpl.kt:98 — data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/recording/RecordingRepositoryImpl.kt:98-127 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/releasegroup/ReleaseGroupRepositoryImpl.kt:50-78 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/work/WorkRepositoryImpl.kt:49-77 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 29 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (38 corresponding lines) · ×1
  • Edited copy of a member (38 corresponding lines) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistDetailsTabUi.kt:226 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistDetailsTabUi.kt:226-263 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseDetailsTabUi.kt:394-431 — These two members are one piece of code written twice and then edited apart: 38 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (31 corresponding lines) · ×1
  • Edited copy of a member (31 corresponding lines) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/mapper/MapToReleaseListItemModel.kt:34 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/mapper/MapToReleaseListItemModel.kt:34-64 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/mapper/MapToReleaseListItemModel.kt:95-126 — These two members are one piece of code written twice and then edited apart: 31 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (29 corresponding lines) · ×1
  • Edited copy of a member (29 corresponding lines) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ArtistDao.kt:78 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ArtistDao.kt:78-116 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ReleaseGroupDao.kt:117-145 — These two members are one piece of code written twice and then edited apart: 29 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 39+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 39+ corresponding lines) shared/feature/details/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/details/release/TrackAdditionalActionsBottomSheetContent.android.kt:14 — shared/feature/details/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/details/release/TrackAdditionalActionsBottomSheetContent.android.kt:14-52 | ui/common/src/androidMain/kotlin/ly/david/musicsearch/ui/common/track/TrackListItem.android.kt:39-82 | ui/common/src/androidMain/kotlin/ly/david/musicsearch/ui/common/track/TrackListItem.android.kt:125-168 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 39 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (40 corresponding lines) · ×1
  • Edited copy of a member (40 corresponding lines) shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListenAdditionalActionsBottomSheetContent.kt:286 — shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListenAdditionalActionsBottomSheetContent.kt:286-325 | shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListenAdditionalActionsBottomSheetContent.kt:334-374 — These two members are one piece of code written twice and then edited apart: 40 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (32 corresponding lines) · ×1
  • Edited copy of a member (32 corresponding lines) shared/feature/settings/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/settings/internal/components/SettingWithDialogChoices.kt:25 — shared/feature/settings/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/settings/internal/components/SettingWithDialogChoices.kt:25-56 | shared/feature/settings/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/settings/internal/services/DefaultCustomInstanceSetting.kt:25-56 — These two members are one piece of code written twice and then edited apart: 32 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (6 members, 19+ corresponding lines) · ×1
  • Edited copies of one member (6 members, 19+ corresponding lines) data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/area/AreaRepositoryImpl.kt:40 — data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/area/AreaRepositoryImpl.kt:40-59 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/artist/ArtistRepositoryImpl.kt:49-75 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/event/EventRepositoryImpl.kt:40-58 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/instrument/InstrumentRepositoryImpl.kt:40-58 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/label/LabelRepositoryImpl.kt:40-58 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/series/SeriesRepositoryImpl.kt:40-58 — These 6 members are one piece of code written 6 times and then edited apart: every two of them correspond over at least 19 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 6 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 31+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 31+ corresponding lines) shared/feature/collections/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/collections/list/PreviewCollectionListUi.kt:16 — shared/feature/collections/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/collections/list/PreviewCollectionListUi.kt:16-46 | shared/feature/collections/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/collections/list/PreviewCollectionListUi.kt:50-82 | shared/feature/collections/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/collections/list/PreviewCollectionListUi.kt:86-118 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 31 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (5 members, 22+ corresponding lines) · ×1
  • Edited copies of one member (5 members, 22+ corresponding lines) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ArtistDao.kt:242 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ArtistDao.kt:242-263 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/EventDao.kt:163-184 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/LabelDao.kt:211-232 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/RecordingDao.kt:206-227 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/WorkDao.kt:175-196 — These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 22 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (20 corresponding lines) · ×1
  • Edited copy of a member (20 corresponding lines) data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/place/PlacesListRepositoryImpl.kt:92 — data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/place/PlacesListRepositoryImpl.kt:92-113 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/releasegroup/ReleaseGroupsListRepositoryImpl.kt:146-165 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (24 corresponding lines) · ×1
  • Edited copy of a member (24 corresponding lines) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/alias/AliasesSection.kt:20 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/alias/AliasesSection.kt:20-46 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/utils/UrlsSection.kt:19-42 — These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (7 members, 24+ corresponding lines) · ×1
  • Edited copies of one member (7 members, 24+ corresponding lines) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ArtistDao.kt:210 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ArtistDao.kt:210-236 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/EventDao.kt:134-157 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/LabelDao.kt:181-205 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/PlaceDao.kt:151-174 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/RecordingDao.kt:174-200 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ReleaseGroupDao.kt:281-307 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/WorkDao.kt:143-169 — These 7 members are one piece of code written 7 times and then edited apart: every two of them correspond over at least 24 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 7 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (8 members, 16+ corresponding lines) · ×1
  • Edited copies of one member (8 members, 16+ corresponding lines) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ArtistDao.kt:298 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ArtistDao.kt:298-316 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ArtistDao.kt:323-341 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/RecordingDao.kt:262-277 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/RecordingDao.kt:292-310 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ReleaseGroupDao.kt:369-387 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ReleaseGroupDao.kt:394-412 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/WorkDao.kt:231-246 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/WorkDao.kt:261-279 — These 8 members are one piece of code written 8 times and then edited apart: every two of them correspond over at least 16 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 8 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (26 corresponding lines) · ×1
  • Edited copy of a member (26 corresponding lines) shared/feature/listens/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListensUi.android.kt:72 — shared/feature/listens/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListensUi.android.kt:72-97 | shared/feature/listens/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListensUi.android.kt:127-153 — These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 17+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 17+ corresponding lines) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ArtistDao.kt:275 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ArtistDao.kt:275-291 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/RecordingDao.kt:239-255 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ReleaseGroupDao.kt:346-362 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/WorkDao.kt:208-224 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 17 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (8 members, 15+ corresponding lines) · ×1
  • Edited copies of one member (8 members, 15+ corresponding lines) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/EventDao.kt:216 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/EventDao.kt:216-233 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/EventDao.kt:247-264 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/GenreDao.kt:96-113 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/InstrumentDao.kt:132-149 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/LabelDao.kt:264-281 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/LabelDao.kt:295-309 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/PlaceDao.kt:233-247 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/PlaceDao.kt:261-278 — These 8 members are one piece of code written 8 times and then edited apart: every two of them correspond over at least 15 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 8 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (7 members, 16+ corresponding lines) · ×1
  • Edited copies of one member (7 members, 16+ corresponding lines) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AreaDao.kt:227 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AreaDao.kt:227-242 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/EventDao.kt:195-210 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/GenreDao.kt:126-141 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/InstrumentDao.kt:162-177 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/LabelDao.kt:243-258 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/PlaceDao.kt:212-227 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/SeriesDao.kt:164-179 — These 7 members are one piece of code written 7 times and then edited apart: every two of them correspond over at least 16 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 7 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 14+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 14+ corresponding lines) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/InstrumentDao.kt:31 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/InstrumentDao.kt:31-45 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/SeriesDao.kt:32-45 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/WorkDao.kt:35-50 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 14 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 15+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 15+ corresponding lines) data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/area/AreasListRepositoryImpl.kt:93 — data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/area/AreasListRepositoryImpl.kt:93-107 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/genre/GenresListRepositoryImpl.kt:90-104 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/label/LabelsListRepositoryImpl.kt:90-107 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 15 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (6 members, 15+ corresponding lines) · ×1
  • Edited copies of one member (6 members, 15+ corresponding lines) data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/artist/ArtistsListRepositoryImpl.kt:100 — data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/artist/ArtistsListRepositoryImpl.kt:100-119 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/event/EventsListRepositoryImpl.kt:90-107 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/instrument/InstrumentsListRepositoryImpl.kt:93-107 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/recording/RecordingsListRepositoryImpl.kt:100-117 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/series/SeriesListRepositoryImpl.kt:93-107 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/work/WorksListRepositoryImpl.kt:100-117 — These 6 members are one piece of code written 6 times and then edited apart: every two of them correspond over at least 15 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 6 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (21 corresponding lines) · ×1
  • Edited copy of a member (21 corresponding lines) ui/common/src/androidMain/kotlin/ly/david/musicsearch/ui/common/topappbar/PreviewScrollableTopAppBar.kt:42 — ui/common/src/androidMain/kotlin/ly/david/musicsearch/ui/common/topappbar/PreviewScrollableTopAppBar.kt:42-63 | ui/common/src/androidMain/kotlin/ly/david/musicsearch/ui/common/topappbar/TopAppBarWithFilter.android.kt:162-182 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 13+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 13+ corresponding lines) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AreaDao.kt:136 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AreaDao.kt:136-148 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/EventDao.kt:83-96 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/PlaceDao.kt:86-102 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (13 corresponding lines) · ×1
  • Edited copy of a member (13 corresponding lines) ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/component/MultipleChoiceBottomSheet.kt:38 — ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/component/MultipleChoiceBottomSheet.kt:38-50 | ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/sort/SortOptionsBottomSheet.kt:85-97 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (35 lines × 2) · ×1
  • Duplicated block (35 lines × 2) ui/common/src/androidMain/kotlin/ly/david/musicsearch/ui/common/track/TrackListItem.android.kt:40 — ui/common/src/androidMain/kotlin/ly/david/musicsearch/ui/common/track/TrackListItem.android.kt:40-74 | ui/common/src/androidMain/kotlin/ly/david/musicsearch/ui/common/track/TrackListItem.android.kt:126-160 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `ui/common/src/androidMain/kotlin/ly/david/musicsearch/ui/common/track/TrackListItem.android.kt:40` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (32–35 lines × 2) · ×1
  • Duplicated block (32–35 lines × 2) ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/recording/RecordingListItem.kt:68 — ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/recording/RecordingListItem.kt:68-102 | ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/recording/RecordingListItem.kt:177-208 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/recording/RecordingListItem.kt:68` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (32–34 lines × 3) · ×1
  • Duplicated block (32–34 lines × 3) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt:143 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt:143-174 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt:152-185 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupUi.kt:155-186 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 209 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt:143` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (33 lines × 2) · ×1
  • Duplicated block (33 lines × 2) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistDetailsTabUi.kt:89 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistDetailsTabUi.kt:89-121 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupDetailsTabUi.kt:72-104 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistDetailsTabUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupDetailsTabUi.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 73 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistDetailsTabUi.kt:89` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (30 lines × 4) · ×1
  • Duplicated block (30 lines × 4) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt:160 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt:160-189 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/instrument/InstrumentUi.kt:157-186 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/place/PlaceUi.kt:156-185 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/series/SeriesUi.kt:158-187 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/instrument/InstrumentUi.kt` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt:160` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/place/PlaceUi.kt:154` calls `refresh` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt:158` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (28–30 lines × 2) · ×1
  • Duplicated block (28–30 lines × 2) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt:238 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt:238-265 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupUi.kt:212-241 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupUi.kt` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 257 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt:238` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (29 lines × 8) · ×1
  • Duplicated block (29 lines × 8) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt:126 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt:126-154 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:138-166 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt:125-153 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/instrument/InstrumentUi.kt:122-150 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt:124-152 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/place/PlaceUi.kt:120-148 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/series/SeriesUi.kt:123-151 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/work/WorkUi.kt:124-152 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 138 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt:126` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (28 lines × 11) · ×1
  • Duplicated block (28 lines × 11) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt:78 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt:78-105 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:88-115 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt:82-109 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/instrument/InstrumentUi.kt:79-106 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt:77-104 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/place/PlaceUi.kt:74-101 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt:85-112 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseUi.kt:91-118 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupUi.kt:88-115 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/series/SeriesUi.kt:78-105 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/work/WorkUi.kt:76-103 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 138 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Note first that the copies are not typed on the same thing: the declarations holding them bind `state` to `DetailsUiState<AreaDetailsModel>` in one and `DetailsUiState<ArtistDetailsModel>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (28 lines × 2) · ×1
  • Duplicated block (28 lines × 2) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingDetailsTabUi.kt:137 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingDetailsTabUi.kt:137-164 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/work/WorkDetailsTabUi.kt:144-171 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingDetailsTabUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/work/WorkDetailsTabUi.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 74 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingDetailsTabUi.kt:137` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (23–28 lines × 2) · ×1
  • Duplicated block (23–28 lines × 2) ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/release/ReleaseListItem.kt:58 — ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/release/ReleaseListItem.kt:58-85 | ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/releasegroup/ReleaseGroupListItem.kt:44-66 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/release/ReleaseListItem.kt:58` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (25 lines × 13) · ×1
  • Duplicated block (25 lines × 13) shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionUi.kt:80 — shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionUi.kt:80-104 | shared/feature/database/src/commonMain/kotlin/ly/david/musicsearch/share/feature/database/all/AllLocalEntitiesUi.kt:58-82 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt:62-86 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:72-96 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt:66-90 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/instrument/InstrumentUi.kt:63-87 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt:61-85 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/place/PlaceUi.kt:58-82 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt:69-93 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseUi.kt:75-99 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupUi.kt:72-96 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/series/SeriesUi.kt:62-86 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/work/WorkUi.kt:60-84 — before extracting anything, compare `shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionUi.kt` and `shared/feature/database/src/commonMain/kotlin/ly/david/musicsearch/share/feature/database/all/AllLocalEntitiesUi.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 71 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Note first that the copies are not typed on the same thing: the declarations holding them bind `state` to `CollectionUiState` in one and `AllLocalEntitiesUiState` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (24–25 lines × 7) · ×1
  • Duplicated block (24–25 lines × 7) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:211 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:211-235 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt:176-199 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/instrument/InstrumentUi.kt:173-196 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt:184-208 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/place/PlaceUi.kt:172-195 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/series/SeriesUi.kt:174-197 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/work/WorkUi.kt:183-207 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 230 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:211` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt:175` calls `CopyToClipboardMenuItem`, `AddAllToCollectionMenuItem` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:211` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (25 lines × 2) · ×1
  • Duplicated block (25 lines × 2) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt:122 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt:122-146 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseUi.kt:128-152 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseUi.kt` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 154 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt:122` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt:148` calls `AddToCollectionActionToggle` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseUi.kt:153` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (24 lines × 4) · ×1
  • Duplicated block (24 lines × 4) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistDetailsTabUi.kt:240 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistDetailsTabUi.kt:240-263 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingDetailsTabUi.kt:154-177 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseDetailsTabUi.kt:408-431 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupDetailsTabUi.kt:145-168 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistDetailsTabUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupDetailsTabUi.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 73 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistDetailsTabUi.kt:240` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (23 lines × 9) · ×1
  • Duplicated block (23 lines × 9) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt:116 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt:116-138 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:128-150 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt:115-137 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/instrument/InstrumentUi.kt:112-134 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt:114-136 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/place/PlaceUi.kt:110-132 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupUi.kt:125-147 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/series/SeriesUi.kt:113-135 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/work/WorkUi.kt:114-136 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 138 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt:116` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (23 lines × 7) · ×1
  • Duplicated block (23 lines × 7) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:241 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:241-263 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt:205-227 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt:214-236 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/place/PlaceUi.kt:201-223 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt:271-293 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupUi.kt:247-269 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/work/WorkUi.kt:213-235 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 230 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:241` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (23 lines × 2) · ×1
  • Duplicated block (23 lines × 2) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt:163 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt:163-185 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/work/WorkUi.kt:162-184 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/work/WorkUi.kt` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 161 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt:163` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (21–22 lines × 9) · ×1
  • Duplicated block (21–22 lines × 9) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:151 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:151-172 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt:138-158 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/instrument/InstrumentUi.kt:135-155 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt:137-157 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/place/PlaceUi.kt:133-153 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt:146-166 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupUi.kt:149-169 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/series/SeriesUi.kt:136-156 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/work/WorkUi.kt:137-157 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 230 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:151` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt:159` calls `refresh` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt:160` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (22 lines × 9) · ×1
  • Duplicated block (22 lines × 9) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:222 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:222-243 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt:186-207 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/instrument/InstrumentUi.kt:183-204 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt:195-216 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/place/PlaceUi.kt:182-203 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt:252-273 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupUi.kt:228-249 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/series/SeriesUi.kt:184-205 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/work/WorkUi.kt:194-215 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 230 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:222` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (22 lines × 2) · ×1
  • Duplicated block (22 lines × 2) shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionPresenter.kt:139 — shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionPresenter.kt:139-160 | shared/feature/database/src/commonMain/kotlin/ly/david/musicsearch/share/feature/database/all/AllLocalEntitiesPresenter.kt:83-104 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (21–22 lines × 2) · ×1
  • Duplicated block (21–22 lines × 2) shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionUi.kt:167 — shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionUi.kt:167-188 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/utils/DetailsTabUi.kt:230-250 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionUi.kt:167` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (21 lines × 2) · ×1
  • Duplicated block (21 lines × 2) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt:201 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt:201-221 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseUi.kt:217-237 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseUi.kt` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 154 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt:201` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (18–20 lines × 4) · ×1
  • Duplicated block (18–20 lines × 4) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:202 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:202-219 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt:175-192 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt:211-230 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupUi.kt:187-204 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 286 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:202` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (15–20 lines × 3) · ×1
  • Duplicated block (15–20 lines × 3) ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/artist/ArtistListItem.kt:46 — ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/artist/ArtistListItem.kt:46-65 | ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/release/ReleaseListItem.kt:65-84 | ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/releasegroup/ReleaseGroupListItem.kt:51-65 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/artist/ArtistListItem.kt:46` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (18 lines × 11) · ×1
  • Duplicated block (18 lines × 11) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt:112 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt:112-129 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:124-141 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt:111-128 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/instrument/InstrumentUi.kt:108-125 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt:110-127 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/place/PlaceUi.kt:106-123 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt:118-135 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseUi.kt:124-141 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupUi.kt:121-138 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/series/SeriesUi.kt:109-126 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/work/WorkUi.kt:110-127 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 138 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt:112` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (16–18 lines × 3) · ×1
  • Duplicated block (16–18 lines × 3) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt:236 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt:236-251 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseUi.kt:270-285 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupUi.kt:210-227 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/release/ReleaseUi.kt` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 154 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt:236` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (17 lines × 4) · ×1
  • Duplicated block (17 lines × 4) ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/event/EventListItem.kt:41 — ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/event/EventListItem.kt:41-57 | ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/instrument/InstrumentListItem.kt:34-50 | ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/place/PlaceListItem.kt:35-51 | ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/series/SeriesListItem.kt:33-49 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 4 times. Read the line range as the matched WINDOW rather than a finished unit: at `ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/event/EventListItem.kt:41` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (17 lines × 3) · ×1
  • Duplicated block (17 lines × 3) ui/common/src/androidMain/kotlin/ly/david/musicsearch/ui/common/topappbar/TopAppBarWithFilter.android.kt:53 — ui/common/src/androidMain/kotlin/ly/david/musicsearch/ui/common/topappbar/TopAppBarWithFilter.android.kt:53-69 | ui/common/src/iosMain/kotlin/ly/david/musicsearch/ui/common/topappbar/TopAppBarWithFilter.ios.kt:31-47 | ui/common/src/jvmMain/kotlin/ly/david/musicsearch/ui/common/topappbar/TopAppBarWithFilter.jvm.kt:31-47 — before extracting anything, compare `ui/common/src/androidMain/kotlin/ly/david/musicsearch/ui/common/topappbar/TopAppBarWithFilter.android.kt` and `ui/common/src/iosMain/kotlin/ly/david/musicsearch/ui/common/topappbar/TopAppBarWithFilter.ios.kt` as WHOLE FILES: 97% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `ui/common/src/androidMain/kotlin/ly/david/musicsearch/ui/common/topappbar/TopAppBarWithFilter.android.kt:53` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (17 lines × 2) · ×1
  • Duplicated block (17 lines × 2) shared/feature/listens/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/listens/LinkWithMusicBrainzDialogContent.android.kt:88 — shared/feature/listens/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/listens/LinkWithMusicBrainzDialogContent.android.kt:88-104 | shared/feature/listens/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/listens/LinkWithMusicBrainzDialogContent.android.kt:117-133 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/listens/src/androidMain/kotlin/ly/david/musicsearch/shared/feature/listens/LinkWithMusicBrainzDialogContent.android.kt:88` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (16 lines × 6) · ×1
  • Duplicated block (16 lines × 6) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt:160 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt:160-175 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/instrument/InstrumentUi.kt:157-172 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt:160-175 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/place/PlaceUi.kt:156-171 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupUi.kt:172-187 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/series/SeriesUi.kt:158-173 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/instrument/InstrumentUi.kt` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt:160` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt:158` calls `refresh` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt:158` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (16 lines × 5) · ×1
  • Duplicated block (16 lines × 5) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:207 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:207-222 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt:180-195 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingUi.kt:217-233 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupUi.kt:192-207 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/work/WorkUi.kt:179-194 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 286 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:207` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (16 lines × 4) · ×1
  • Duplicated block (16 lines × 4) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistDetailsTabUi.kt:191 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistDetailsTabUi.kt:191-206 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/recording/RecordingDetailsTabUi.kt:133-148 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupDetailsTabUi.kt:116-131 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/work/WorkDetailsTabUi.kt:140-155 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistDetailsTabUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupDetailsTabUi.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 73 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistDetailsTabUi.kt:191` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (16 lines × 2) · ×1
  • Duplicated block (16 lines × 2) shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionUi.kt:106 — shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionUi.kt:106-121 | shared/feature/database/src/commonMain/kotlin/ly/david/musicsearch/share/feature/database/all/AllLocalEntitiesUi.kt:84-99 — before extracting anything, compare `shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionUi.kt` and `shared/feature/database/src/commonMain/kotlin/ly/david/musicsearch/share/feature/database/all/AllLocalEntitiesUi.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 71 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (15 lines × 8) · ×1
  • Duplicated block (15 lines × 8) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt:187 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt:187-201 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:214-228 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt:178-192 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/instrument/InstrumentUi.kt:175-189 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt:187-201 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/place/PlaceUi.kt:174-188 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/series/SeriesUi.kt:176-190 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/work/WorkUi.kt:186-200 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 138 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/area/AreaUi.kt:187` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/event/EventUi.kt:175` calls `CopyToClipboardMenuItem` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/artist/ArtistUi.kt:211` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (13 lines × 3) · ×1
  • Duplicated block (13 lines × 3) shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionUi.kt:166 — shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionUi.kt:166-179 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/utils/DetailsTabUi.kt:229-241 | ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/collection/ShowAddToCollectionSheet.kt:39-51 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionUi.kt:166` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (12–13 lines × 2) · ×1
  • Duplicated block (12–13 lines × 2) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/LabelDao.kt:46 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/LabelDao.kt:46-58 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/LabelDao.kt:69-80 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/LabelDao.kt:46` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (10–12 lines × 6) · ×1
  • Duplicated block (10–12 lines × 6) shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/instrument/InstrumentUi.kt:49 — shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/instrument/InstrumentUi.kt:49-58 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt:50-61 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/place/PlaceUi.kt:47-58 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/releasegroup/ReleaseGroupUi.kt:59-68 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/series/SeriesUi.kt:49-58 | shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/work/WorkUi.kt:49-60 — before extracting anything, compare `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/instrument/InstrumentUi.kt` and `shared/feature/details/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/details/label/LabelUi.kt` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 235 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. Note first that the copies are not typed on the same thing: the declarations holding them bind `state` to `DetailsUiState<InstrumentDetailsModel>` in one and `DetailsUiState<LabelDetailsModel>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (11 lines × 12) · ×1
  • Duplicated block (11 lines × 12) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AliasDao.kt:79 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AliasDao.kt:79-89 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AliasDao.kt:93-103 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AliasDao.kt:107-117 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AliasDao.kt:121-131 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AliasDao.kt:135-145 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AliasDao.kt:149-159 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AliasDao.kt:163-173 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AliasDao.kt:177-187 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AliasDao.kt:191-201 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AliasDao.kt:205-215 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AliasDao.kt:219-229 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AliasDao.kt:232-243 — all 12 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AliasDao.kt:79` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9–10 lines × 2) · ×1
  • Duplicated block (9–10 lines × 2) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AreaDao.kt:75 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AreaDao.kt:75-83 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AreaDao.kt:102-111 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/AreaDao.kt:102` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (10 lines × 2) · ×1
  • Duplicated block (10 lines × 2) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ReleaseGroupDao.kt:232 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ReleaseGroupDao.kt:232-241 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ReleaseGroupDao.kt:245-255 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ReleaseGroupDao.kt:232` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (44 lines × 2) · ×1
  • Duplicated block (44 lines × 2) data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/CollectedStatsDao.kt:45 — data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/CollectedStatsDao.kt:45-88 | data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/VisitedStatsDao.kt:45-88 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/CollectedStatsDao.kt:45` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (10 lines × 3) · ×1
  • Duplicated block (10 lines × 3) data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/artist/ArtistsListRepositoryImpl.kt:42 — data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/artist/ArtistsListRepositoryImpl.kt:42-51 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/recording/RecordingsListRepositoryImpl.kt:42-51 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/work/WorksListRepositoryImpl.kt:42-51 — before extracting anything, compare `data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/artist/ArtistsListRepositoryImpl.kt` and `data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/recording/RecordingsListRepositoryImpl.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 39 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/artist/ArtistsListRepositoryImpl.kt:42` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (12 lines × 3) · ×1
  • Duplicated block (12 lines × 3) data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/area/AreasListRepositoryImpl.kt:77 — data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/area/AreasListRepositoryImpl.kt:77-88 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/instrument/InstrumentsListRepositoryImpl.kt:77-88 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/series/SeriesListRepositoryImpl.kt:77-88 — before extracting anything, compare `data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/instrument/InstrumentsListRepositoryImpl.kt` and `data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/series/SeriesListRepositoryImpl.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 41 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/area/AreasListRepositoryImpl.kt:77` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (18 lines × 5) · ×1
  • Duplicated block (18 lines × 5) data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/artist/ArtistsListRepositoryImpl.kt:67 — data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/artist/ArtistsListRepositoryImpl.kt:67-84 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/event/EventsListRepositoryImpl.kt:57-74 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/label/LabelsListRepositoryImpl.kt:57-74 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/recording/RecordingsListRepositoryImpl.kt:67-84 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/work/WorksListRepositoryImpl.kt:67-84 — before extracting anything, compare `data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/artist/ArtistsListRepositoryImpl.kt` and `data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/recording/RecordingsListRepositoryImpl.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 39 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/artist/ArtistsListRepositoryImpl.kt:67` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (11 lines × 7) · ×1
  • Duplicated block (11 lines × 7) data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/artist/ArtistsListRepositoryImpl.kt:123 — data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/artist/ArtistsListRepositoryImpl.kt:123-133 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/event/EventsListRepositoryImpl.kt:111-121 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/label/LabelsListRepositoryImpl.kt:111-121 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/place/PlacesListRepositoryImpl.kt:117-127 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/recording/RecordingsListRepositoryImpl.kt:121-131 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/releasegroup/ReleaseGroupsListRepositoryImpl.kt:169-179 | data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/work/WorksListRepositoryImpl.kt:121-131 — before extracting anything, compare `data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/artist/ArtistsListRepositoryImpl.kt` and `data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/recording/RecordingsListRepositoryImpl.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 39 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/artist/ArtistsListRepositoryImpl.kt:123` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (18 lines × 3) · ×1
  • Duplicated block (18 lines × 3) ui/common/src/androidMain/kotlin/ly/david/musicsearch/ui/common/track/TrackListItem.android.kt:40 — ui/common/src/androidMain/kotlin/ly/david/musicsearch/ui/common/track/TrackListItem.android.kt:40-57 | ui/common/src/androidMain/kotlin/ly/david/musicsearch/ui/common/track/TrackListItem.android.kt:88-105 | ui/common/src/androidMain/kotlin/ly/david/musicsearch/ui/common/track/TrackListItem.android.kt:126-143 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `ui/common/src/androidMain/kotlin/ly/david/musicsearch/ui/common/track/TrackListItem.android.kt:40` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (11 lines × 2) · ×1
  • Duplicated block (11 lines × 2) shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListenListItem.kt:44 — shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListenListItem.kt:44-54 | ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/track/TrackListItem.kt:142-152 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `shared/feature/listens/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/listens/ListenListItem.kt:44` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D6 · Cohesion (LCOM4) · Low cohesion · ×1
  • Low cohesion: ReleasesListRepositoryImpl (LCOM4 4) data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/release/ReleasesListRepositoryImpl.kt:29 — ReleasesListRepositoryImpl's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
P2 · Observability · No structured logging · ×1
  • No structured logging — No logging or diagnostics emission found. This repository ships a binary its users launch rather than a service you operate, so there is no operator to page — but when a run fails on a user's machine, neither they nor you have anything to read.
Minor — 15 finding(s)
D26 · Project Cohesion · Projects may be oversized for their cohesion · ×3
  • Projects may be oversized for their cohesion ui/common/build.gradle.kts:1 — `ui/common` (16834 LoC, 387 module-visible types across 86 directories) overshoots its size bounds. 3 of 33 build unit(s) (Gradle, Xcode) overshoot their size bounds, lowering Project Cohesion to 8.2/10. Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.
  • Projects may be oversized for their cohesion shared/domain/build.gradle.kts:1 — `shared/domain` (5137 LoC, 775 module-visible types across 61 directories) overshoots its size bounds. 3 of 33 build unit(s) (Gradle, Xcode) overshoot their size bounds, lowering Project Cohesion to 8.2/10. Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.
  • Projects may be oversized for their cohesion shared/feature/details/build.gradle.kts:1 — `shared/feature/details` (10230 LoC, 122 module-visible types across 29 directories) overshoots its size bounds. 3 of 33 build unit(s) (Gradle, Xcode) overshoot their size bounds, lowering Project Cohesion to 8.2/10. Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.
M4 · Documentation accuracy · README/code drift · ×3
  • README/code drift build-logic/README.md:6 — build-logic/README.md links to `convention/src/main/kotlin/ly/david/convention/plugin/AndroidLibraryConventionPlugin.kt`, but `build-logic/convention/src/main/kotlin/ly/david/convention/plugin/AndroidLibraryConventionPlugin.kt` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift build-logic/README.md:7 — build-logic/README.md links to `convention/src/main/kotlin/ly/david/convention/plugin/KotlinJvmConventionPlugin.kt`, but `build-logic/convention/src/main/kotlin/ly/david/convention/plugin/KotlinJvmConventionPlugin.kt` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift build-logic/README.md:11 — build-logic/README.md links to `convention/src/main/kotlin/ly/david/convention/plugin/AndroidComposeConventionPlugin.kt`, but `build-logic/convention/src/main/kotlin/ly/david/convention/plugin/AndroidComposeConventionPlugin.kt` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
AX6 · Interface segregation · Fat interface · ×1
  • Fat interface: AppPreferences (39 abstract methods) shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/preferences/AppPreferences.kt:24 — `AppPreferences` declares 39 abstract methods: `setTheme`, `setUseMaterialYou`, `setSeedColor`, `setAreaSortOption`, `setArtistSortOption`, `setEventSortOption`, `setInstrumentSortOption`, `setLabelSortOption`, `setPlaceSortOption`, `setRecordingSortOption`, `setReleaseSortOption`, `setShowMoreInfoInReleaseListItem`, `setShowReleaseStatus`, `setReleaseGroupSortOption`, `setGenreSortOption`, `setTrackSortOption`, `setSeriesSortOption`, `setWorkSortOption`, `setShowLocalCollections`, `setShowRemoteCollections`, `setHistorySortOption`, `setCollectionSortOption`, `setImagesSortOption`, `setEnableCrashReporting`, `setDeveloperMode`, `setNumberOfImagesPerRow`, `setImagesGridPaddingDp`, `setCollaborationEntityType`, `setScrollToHideTopAppBar`, `setPullToRefresh`, `setNumberOfListensInDetails`, `setSubmitClientAndVersionWithListen`, `setExcludeParametersInUrlLookup`, `setSearchLocalDatabaseInUrlLookup`, `setMusicBrainzInstance`, `setListenBrainzInstance`, `setWikidataInstance`, `setArtistImageSource`, `setBoldUnvisited`. Counted over its public functions with no body, once per name; default-bodied functions and properties are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
D19 · Documentation Quality · Documentation · ×1
  • Documentation: no build, run or usage example README.md:1 — the repository holds project manifests and neither `README.md` nor the documents it links hold a code block or a command. Show the command that builds or runs it, or a usage snippet.
D21 · Naming Consistency · `InvalidID` spells `ID` where 93 names in the project spell it `Id` · ×1
  • `InvalidID` spells `ID` where 93 names in the project spell it `Id` shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/listen/ListensListRepository.kt:65 — 93 of 94 names in project domain spell the token `Id` (93 of 94; unit: names in project domain containing `Id`). Peers: ByEntity.entityId (shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/BrowseMethod.kt:17); Companion.fromId (shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/alias/AliasType.kt:44); AreaRepository.lookupEntity(entityId) (shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/area/AreaRepository.kt:7); Companion.fromId (shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/area/AreaType.kt:18); ArtistCollaborationRepository.getAllCollaboratingArtistsAndEntities(artistId) (shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/artist/ArtistCollaborationRepository.kt:6). Rename to `InvalidId`. [rule N6]
D28 · Secrets (history) · Rotate the exposed credentials · ×1
  • REDACTED
D30 · Dependency Vulnerabilities · Low CVE · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
P3 · Security & performance tooling · No SAST · ×1
  • No SAST — No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 21 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
X10 · Duplicated predicate · Duplicated predicate · ×1
  • Duplicated predicate data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/NowPlayingHistoryRepositoryImpl.kt:44 — `beforeDate != afterDate && afterDate != null` appears character-identically in 2 files — data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/NowPlayingHistoryRepositoryImpl.kt, data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/SpotifyHistoryRepositoryImpl.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Minor — 2 finding(s)
D5 · Coupling · Off the main sequence · ×2
  • Off the main sequence: MusicSearch:shared:domain — MusicSearch:shared:domain: abstractness 0.19, instability 0.00, distance 0.81 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.
  • Off the main sequence: MusicSearch:ui:common — MusicSearch:ui:common: abstractness 0.04, instability 0.24, distance 0.72 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

DimensionToolVersionCommandFindingsRaw output
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=0 --max-count=200" --report-format json --report-path /tmp/watchdog-gitleaks-69d7a36ca0934412afcbdb4f90aafac1/history.json --exit-code 0 --source .0artifacts/raw/gitleaks-history.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=200 --max-count=800" --report-format json --report-path /tmp/watchdog-gitleaks-69d7a36ca0934412afcbdb4f90aafac1/history-1.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-1.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=1000 --max-count=3200" --report-format json --report-path /tmp/watchdog-gitleaks-69d7a36ca0934412afcbdb4f90aafac1/history-2.json --exit-code 0 --source .3artifacts/raw/gitleaks-history-2.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=4200 --max-count=1616" --report-format json --report-path /tmp/watchdog-gitleaks-69d7a36ca0934412afcbdb4f90aafac1/history-3.json --exit-code 0 --source .4artifacts/raw/gitleaks-history-3.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-git --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-69d7a36ca0934412afcbdb4f90aafac1/tree.json --exit-code 0 --source .1artifacts/raw/gitleaks-tree.json
D29 · Static Analysis (SAST)semgrep—semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --config /opt/semgrep-rules/canine-sast.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off --exclude *.arrow --exclude *.avro --exclude *.csv --exclude *.dat --exclude *.db --exclude *.feather --exclude *.geojson --exclude *.h5 --exclude *.hdf5 --exclude *.jsonl --exclude *.log --exclude *.ndjson --exclude *.npy --exclude *.npz --exclude *.orc --exclude *.parquet --exclude *.pickle --exclude *.pkl --exclude *.psv --exclude *.sqlite --exclude *.sqlite3 --exclude *.tfrecord --exclude *.tsv --exclude *.txt .20artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilitiestrivy—trivy fs --scanners vuln --format json --quiet --severity CRITICAL,HIGH,MEDIUM,LOW --skip-dirs **/bin/** --skip-dirs **/obj/** .21artifacts/raw/trivy-fs.json
D31 · IaC & Container Securitytrivy—trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.0—
D32 · Data Compliance (PII/GDPR)semgrep—semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 12 file(s) — `data/database/src/commonMain/kotlin/ly/david/musicsearch/data/database/dao/ArtistCollaborationDao.kt`, `data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/LookupHistoryRepositoryImpl.kt`, `data/repository/src/commonMain/kotlin/ly/david/musicsearch/data/repository/listen/ListensListRepositoryImpl.kt`, `shared/domain/src/commonMain/kotlin/ly/david/musicsearch/shared/domain/image/ImageId.kt`, `shared/feature/collections/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/edit/EditCollectionPresenter.kt`, … (+7 more) — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.0—
D37 · Vulnerability-disclosure Policydisclosure—disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.0—
D40 · Network Egress Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.0—
D41 · Kernel & Syscall Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.0—
D42 · Runtime Threat Enforcementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.0—
D43 · Malicious Dependenciestrivy—trivy fs --scanners vuln --format json --quiet --severity CRITICAL,HIGH,MEDIUM,LOW --skip-dirs **/bin/** --skip-dirs **/obj/** .0artifacts/raw/trivy-fs.json

Run 01a1e997-9505-7fa8-a152-ce45eefbc1bc · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Downloadable artifacts

Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.

⬇ Findings, MITRE CWE-tagged .sarif⬇ Health changelog .md